[PATCH] isdn/i4l: Fix DLE handling for i4l-audio

2008-01-03 Thread Matthias Goebl
The DLE handling in i4l-audio seems to be broken. It produces spurious DLEs so asterisk 1.2.24 with chan_modem_i4l gets irritated, the error message is: chan_modem_i4l.c:450 i4l_read: Value of escape is ^ (17). - There shouldn't be a DLE-^. If a spurious DLE-ETX occurs, the audio connection even

[PATCH] isdn/i4l: 'NO CARRIER' message lost after ldisc flush

2008-01-03 Thread Matthias Goebl
The ISDN tty layer doesn't produce a 'NO CARRIER' message after hangup. I suppose it broke when tty_buffer_flush() has been added to tty_ldisc_flush() in the commit below. For isdn_tty_modem_result(RESULT_NO_CARRIER..) the message inserted via isdn_tty_at_cout() - tty_insert_flip_char() is

Re: [PATCH 1/3] Merge mkubootimg tool for building U-Boot images

2008-01-03 Thread Josh Boyer
On Thu, 3 Jan 2008 17:15:48 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: On Jan 3, 2008 5:02 PM, Josh Boyer [EMAIL PROTECTED] wrote: Several platforms require the mkimage tool to generate a uImage file that is used with U-Boot. This brings the mkimage tool in-kernel to enable building

Re: [PATCH 1/3] Merge mkubootimg tool for building U-Boot images

2008-01-03 Thread Mike Frysinger
On Jan 3, 2008 5:02 PM, Josh Boyer [EMAIL PROTECTED] wrote: Several platforms require the mkimage tool to generate a uImage file that is used with U-Boot. This brings the mkimage tool in-kernel to enable building those platforms without having mkimage externally provided. The tool is named

Re: [PATCH] isdn/i4l: 'NO CARRIER' message lost after ldisc flush

2008-01-03 Thread Alan Cox
For non-audio connections the problem remains. Maybe we can remove the tty_ldisc_flush() in isdn_tty_modem_result() at all because it's done at tty_close? I'm not sure I understand why the tty_ldisc_flush is being done in the ISDN layer at this point but this change looks fine to me. Alan --

Re: [PATCH 1/3] Merge mkubootimg tool for building U-Boot images

2008-01-03 Thread Mike Frysinger
On Jan 3, 2008 5:26 PM, Josh Boyer [EMAIL PROTECTED] wrote: On Thu, 3 Jan 2008 17:15:48 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: On Jan 3, 2008 5:02 PM, Josh Boyer [EMAIL PROTECTED] wrote: Several platforms require the mkimage tool to generate a uImage file that is used with

Re: Kbuild update

2008-01-03 Thread Jan Engelhardt
On Jan 3 2008 22:32, Sam Ravnborg wrote: On top of this I have my personal todo items such as: - modern ncurses interface for menuconfig (ala tig, htop and others) Sorry.. your comparison {menuconfig, htop} raises an incompatible pointer passed on my side. Please explain :) TODO items (from

Re: [PATCH 1/3] Merge mkubootimg tool for building U-Boot images

2008-01-03 Thread Josh Boyer
On Thu, 3 Jan 2008 17:33:20 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: On Jan 3, 2008 5:26 PM, Josh Boyer [EMAIL PROTECTED] wrote: On Thu, 3 Jan 2008 17:15:48 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: On Jan 3, 2008 5:02 PM, Josh Boyer [EMAIL PROTECTED] wrote: Several

Re: [04/06] [typo fix] drivers/infiniband/ulp/iser/iser_verbs.c

2008-01-03 Thread Roland Dreier
what the heck, applied. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/3] Rework arch specific Makefiles to use mkubootimg

2008-01-03 Thread Ben Dooks
On Thu, Jan 03, 2008 at 04:04:06PM -0600, Josh Boyer wrote: Rework the architecture specific Makefiles to use the in-kernel version of the mkubootimg tool. Signed-off-by: Josh Boyer [EMAIL PROTECTED] A CC: to RMK and any other arch maintainers being touched by this would have useful too. --

[PATCH] md: Fix data corruption when a degraded raid5 array is reshaped.

2008-01-03 Thread NeilBrown
This patch fixes a fairly serious bug in md/raid5 in 2.6.23 and 24-rc. It would be great if it cold get into 23.13 and 24.final. Thanks. NeilBrown ### Comments for Changeset We currently do not wait for the block from the missing device to be computed from parity before copying data to the new

Re: [PATCH] IB/ehca: Forward event client-reregister-required to registered clients

2008-01-03 Thread Hoang-Nam Nguyen
Hi Roland, Just want to make sure you've seen this patch and if it looks ok for you. Thanks Nam On Thursday 20 December 2007 15:06, Hoang-Nam Nguyen wrote: This patch allows ehca to forward event client-reregister-required to registered clients. Such one event is generated by the switch eg.

Re: [patch 1/2] move WARN_ON() out of line

2008-01-03 Thread Matt Mackall
On Thu, 2008-01-03 at 22:26 +0100, Arjan van de Ven wrote: Subject: move WARN_ON() out of line From: Arjan van de Ven [EMAIL PROTECTED] CC: Ingo Molnar [EMAIL PROTECTED] CC: Andrew Morton [EMAIL PROTECTED] CC: Olof Johansson [EMAIL PROTECTED] CC: Matt Meckall [EMAIL PROTECTED] A quick

Re: freeze vs freezer

2008-01-03 Thread Rafael J. Wysocki
On Thursday, 3 of January 2008, Nigel Cunningham wrote: Hi. Rafael J. Wysocki wrote: On Wednesday, 2 of January 2008, Nigel Cunningham wrote: Pavel Machek wrote: So how do you handle threads that are blocked on I/O or a lock during the system freeze process, then? We wait until

Re: [PATCH] md: Fix data corruption when a degraded raid5 array is reshaped.

2008-01-03 Thread Dan Williams
On Thu, 2008-01-03 at 15:46 -0700, NeilBrown wrote: This patch fixes a fairly serious bug in md/raid5 in 2.6.23 and 24-rc. It would be great if it cold get into 23.13 and 24.final. Thanks. NeilBrown ### Comments for Changeset We currently do not wait for the block from the missing device

Re: [PATCH 2/3] Rework arch specific Makefiles to use mkubootimg

2008-01-03 Thread Josh Boyer
On Thu, 3 Jan 2008 22:41:40 + Ben Dooks [EMAIL PROTECTED] wrote: On Thu, Jan 03, 2008 at 04:04:06PM -0600, Josh Boyer wrote: Rework the architecture specific Makefiles to use the in-kernel version of the mkubootimg tool. Signed-off-by: Josh Boyer [EMAIL PROTECTED] A CC: to RMK

Re: [RFC] libusb / in-kernel usb driver criteria (was: USB driver for talking to the Microchip PIC18 boot loader)

2008-01-03 Thread mgross
On Wed, Jan 02, 2008 at 07:59:15PM +, Paulo Marques wrote: Xiaofan Chen wrote: On Dec 30, 2007 11:53 AM, mgross [EMAIL PROTECTED] wrote: [...] What is the linux-usb policies on new drivers that could be implemented in user space? When does a kernel driver make sense over a libusb one?

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Christer Weinigel
On Thu, 03 Jan 2008 13:34:45 +0100 Tomas Carnecky [EMAIL PROTECTED] wrote: Christer Weinigel wrote: By the way, what is the consensus on lines over 80 characters? checkpatch complains about the following: WARNING: line over 80 characters #762: FILE: drivers/spi/spi_s3c24xx_dma.c:720:

Re: [GIT PULL] please pull infiniband.git for-linus

2008-01-03 Thread Rik van Riel
On Thu, 03 Jan 2008 15:20:09 -0500 David Dillow [EMAIL PROTECTED] wrote: diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 950228f..6e7e3c8 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -423,8 +423,8

Re: [PATCH] This patch to profile.c fixes a few errors reported by checkpatch.pl

2008-01-03 Thread Jesper Juhl
On 04/01/2008, Paolo Ciarrocchi [EMAIL PROTECTED] wrote: Before: total: 25 errors, 13 warnings, 602 lines checked After: total: 3 errors, 13 warnings, 602 lines checked Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED] Looks sane to me. Reviewed-by: Jesper Juhl [EMAIL PROTECTED] --

Re: [PATCH] md: Fix data corruption when a degraded raid5 array is reshaped.

2008-01-03 Thread Dan Williams
On Thu, 2008-01-03 at 16:00 -0700, Williams, Dan J wrote: On Thu, 2008-01-03 at 15:46 -0700, NeilBrown wrote: This patch fixes a fairly serious bug in md/raid5 in 2.6.23 and 24-rc. It would be great if it cold get into 23.13 and 24.final. Thanks. NeilBrown ### Comments for Changeset

Re: [PATCH] This patch to printk.c fixes a few errors reported by checkpatch.pl

2008-01-03 Thread Jesper Juhl
On 04/01/2008, Paolo Ciarrocchi [EMAIL PROTECTED] wrote: This patch to printk.c fixes a few errors reported by checkpatch.pl [...] - for (a=console_drivers-next, b=console_drivers ; -a; b=a, a=b-next) { + for (a = console_drivers-next, b =

Re: [PATCH] This patch to printk.c fixes a few errors reported by checkpatch.pl

2008-01-03 Thread Randy Dunlap
On Fri, 4 Jan 2008 00:14:46 +0100 Paolo Ciarrocchi wrote: This patch to printk.c fixes a few errors reported by checkpatch.pl Before: total: 18 errors, 17 warnings, 1306 lines checked After: total: 1 errors, 17 warnings, 1305 lines checked Signed-off-by: Paolo Ciarrocchi [EMAIL

Re: [PATCH] proc: advertise new restrictions on /proc/*/maps /proc/*/smaps

2008-01-03 Thread Al Viro
On Fri, Jan 04, 2008 at 12:51:50AM +0100, Guillaume Chazarain wrote: Now that strangers are kept out of /proc/pid/maps, let's welcome them with -EPERM instead of a blank file. NAK The whole point is that we have to reject it at read() time, not open() time. Checks in open() are a)

[PATCH] proc: advertise new restrictions on /proc/*/maps /proc/*/smaps

2008-01-03 Thread Guillaume Chazarain
Now that strangers are kept out of /proc/pid/maps, let's welcome them with -EPERM instead of a blank file. Signed-off-by: Guillaume Chazarain [EMAIL PROTECTED] --- fs/proc/base.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c

[PATCH] This patch to profile.c fixes a few errors reported by checkpatch.pl

2008-01-03 Thread Paolo Ciarrocchi
Before: total: 25 errors, 13 warnings, 602 lines checked After: total: 3 errors, 13 warnings, 602 lines checked Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED] --- Ingo, I'm sending this patch to you since according to git shortlog -e you are the most active modifier of this file

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Andrew Patterson
On Mon, 2007-12-03 at 14:15 -0700, Andrew Patterson wrote: On Thu, 2007-11-29 at 10:07 +0900, Tejun Heo wrote: Andrew Patterson wrote: I tried with clean 2.6.24-rc3 and get the same bad behavior. This is on an ia64 box, so maybe that is an issue. I can try on an x86 box as well. Oh,

PIT clocksource makes invalid assumptions

2008-01-03 Thread Dan Hecht
Looking at pit_read() in arch/x86/kernel/i8253.c, it seems that the PIT clocksource code assumes that the PIT CH0 is in periodic mode. With clockevents, this assumption is no longer valid. There are at least two places that make this assumption: 1) The calculation at the end of pit_read()

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Tejun Heo
Hello, Andrew Patterson wrote: It looks like this is a shell issue. After looking through the sysfs code, I realized that this problem seems to be driven from user-land. So I performed some experiments: 1. Wrote a simple program that just used write(2) to write to the sysfs

Re: kernel BUG at fs/buffer.c:1245!

2008-01-03 Thread Parag Warudkar
Jayakrishnan.Chathu at nokia.com writes: Hi I am running 2.6.23 kernel on i386. Sometimes during reboot or file read write I get this kernel crash. .config attached. kernel BUG at fs/buffer.c:1245! invalid opcode: [#1] SMP Modules linked in: sfpacket(PF) e1000 adm1026

[PATCH] x86: reboot_{32|64}.c unification

2008-01-03 Thread Miguel Botón
reboot_{32|64}.c unification patch. This patch unifies the code from the reboot_32.c and reboot_64.c files. It has been tested in computers with X86_32 and X86_64 kernels and it looks like all reboot modes work fine (EFI restart system hasn't been tested yet). Probably I made some mistakes

Re: INITIO scsi driver fails to work properly

2008-01-03 Thread Filippos Papadopoulos
First of all let me wish a happy new year. I come back from the vacations and i compiled the initio driver with #define DEBUG_INTERRUPT 1 #define DEBUG_QUEUE 1 #define DEBUG_STATE 1 #define INT_DISC1 I used the sources from 2.6.24-rc6-git9 kernel. At kernel boot time the initio

RE: sata_nv + ADMA + Samsung disk problem

2008-01-03 Thread Allen Martin
Dunno about the NVidia version. Theirs works rather differently - the GO bit is there, but there's another append register which is used to tell the controller that a new tag has been added to the CPB list. The only thing we currently use the GO bit for is to switch between ADMA

[PATCH 1/2] pda_power: various cleanups

2008-01-03 Thread Anton Vorontsov
- handle spurious interrupts correctly; - get rid of pda_power_supplies array, use two variables instead; - factor out psy_changed() function, it will be used for polling. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- Untested, just to show the idea. drivers/power/pda_power.c | 152

[PATCH 2/2] pda_power: implement polling

2008-01-03 Thread Anton Vorontsov
Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- Untested, just to show the idea. drivers/power/pda_power.c | 40 include/linux/pda_power.h |1 + 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/drivers/power/pda_power.c

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread FUJITA Tomonori
On Thu, 03 Jan 2008 15:51:25 -0500 David Dillow [EMAIL PROTECTED] wrote: On Thu, 2008-01-03 at 15:09 -0500, David Dillow wrote: As for a better fix, I'm not sure. Here's a better way than the strncmp. If this meets everyone's approval, then I can roll up a proper commit. Thanks! I

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Andrew Patterson
On Thu, 2008-01-03 at 17:17 -0700, Andrew Patterson wrote: On Fri, 2008-01-04 at 09:07 +0900, Tejun Heo wrote: Hello, Andrew Patterson wrote: It looks like this is a shell issue. After looking through the sysfs code, I realized that this problem seems to be driven from user-land.

Re: [RESEND PATCH 04/10] ide-floppy: cleanup debugging macros

2008-01-03 Thread Bartlomiej Zolnierkiewicz
On Thursday 03 January 2008, Borislav Petkov wrote: There should be no functional change resulting from this patch. the patch is fine but the description is a bit inaccurate: * some debug_log() calls were not using ide-floppy: prefix * a few used printk levels different than KERN_INFO

Re: [RESEND PATCH 10/10] ide-floppy: replace ntoh{s,l} and hton{s,l} calls with the generic byteorder macros

2008-01-03 Thread Bartlomiej Zolnierkiewicz
On Thursday 03 January 2008, Borislav Petkov wrote: Signed-off-by: Borislav Petkov [EMAIL PROTECTED] minor thing: WARNING: line over 80 characters #88: FILE: drivers/ide/ide-floppy.c:759: + put_unaligned(cpu_to_be16(blocks), (unsigned short *) pc-c[7]); seems like it can be

Re: [RESEND PATCH 07/10] ide-floppy: remove unnecessary -handler != NULL check

2008-01-03 Thread Bartlomiej Zolnierkiewicz
On Thursday 03 January 2008, Borislav Petkov wrote: This BUG_ON is unneeded since the -handler != NULL check is performed in ide_set_handler(). Signed-off-by: Borislav Petkov [EMAIL PROTECTED] looks good, please move it at the beginning of the patch series -- To unsubscribe from this list:

Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG

2008-01-03 Thread Robin Getz
On Thu 3 Jan 2008 12:04, Richard D pondered: Does all USB Host controller hardware have the ability to disable PING? I think they do. (or at least should)... http://www.intel.com/technology/usb/download/ehci-r10.pdf == 4.11 Ping Control (page 88) USB 2.0 defines an addition to

Re: [PATCH] pda-power: only register available psu

2008-01-03 Thread Dmitry
Hi, Anton, 2008/1/4, Anton Vorontsov [EMAIL PROTECTED]: Hi Dmitry, On Thu, Jan 03, 2008 at 03:53:19AM +0300, Dmitry Baryshkov wrote: Currently pda-power adds both ac and usb power supply units. This patch fixes it so that psu are added only if they are enabled. Thanks for the patch, this

Re: [RFC] PCIE ASPM support

2008-01-03 Thread Shaohua Li
On Thu, 2008-01-03 at 11:33 -0800, Kok, Auke wrote: Shaohua Li wrote: PCI Express ASPM defines a protocol for PCI Express components in the D0 state to reduce Link power by placing their Links into a low power state and instructing the other end of the Link to do likewise. This capability

Re: forcedeth: MAC-address reversed on resume from suspend

2008-01-03 Thread Richard Jonsson
I don't know, this all looks a bit dirty to me, MAC reading/writing should have been implemented in a more central way, then those people wouldn't have confused heaven and hell with MAC address fiddling. And yeah, this certainly looks like a bug that should be fixed ASAP, unless my short

[PATCH] checkpatch: clear the report buffer after processing a file

2008-01-03 Thread Li Zefan
When checking multiple files, the report buffer is not cleared after processing a file, thus the report will be printed again and again, mixing up with other reports. Signed-off-by: Li Zefan [EMAIL PROTECTED] --- scripts/checkpatch.pl |6 +++--- 1 files changed, 3 insertions(+), 3

Re: [patch 2.6.24-rc6-mm 8/9] gpiolib: pca9539 i2c gpio expander support

2008-01-03 Thread David Brownell
Le 02 Janvier 2008, Jean Delvare a écrit: Hi David, hi Eric, Le 29/12/2007, David Brownell [EMAIL PROTECTED] a écrit: From: eric miao [EMAIL PROTECTED] This adds a new-style I2C driver with basic support for the sixteen bit PCA9539 GPIO expanders. ... Random

Re: sata_nv + ADMA + Samsung disk problem

2008-01-03 Thread Robert Hancock
Benjamin Herrenschmidt wrote: Another thing about the PacDigi core: one has to be very careful to avoid sequential accesses to sequential PCI locations when programming the chip -- it cannot handle merged register writes. So for any group of sequentially laid out registers, the code has to

Re: [PATCH] Exporting capability code/name pairs

2008-01-03 Thread KaiGai Kohei
There is also the issue of compiled code which explicitly raises and lowers capabilities around critical code sections (ie., as they were intended to be used) is also not well served by this change. That is, unless the code was compiled with things like CAP_MAC_ADMIN being #define'd then it

Re: [agp-mm][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

2008-01-03 Thread Zhenyu Wang
On 2007.12.19 13:26:08 +, Zhenyu Wang wrote: [agp-mm] [intel_iommu] explicit export current graphics dmar status To make it possbile to tell other modules about curent graphics dmar engine status, that could decide if graphics driver should remap physical address to dma address.

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-03 Thread Venki Pallipadi
Reintroduce run time configurable max_cstate for !CPU_IDLE case. Signed-off-by: Venkatesh Pallipadi [EMAIL PROTECTED] Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c === --- linux-2.6.24-rc.orig/drivers/acpi/processor_idle.c

Re: [PATCH] procfs: provide slub's /proc/slabinfo

2008-01-03 Thread Christoph Lameter
On Thu, 3 Jan 2008, Matt Mackall wrote: There are three downsides with the slab-like approach: internal fragmentation, under-utilized slabs, and pinning. The first is the situation where we ask for a kmalloc of 33 bytes and get 64. I think the average kmalloc wastes about 30% trying to fit

Re: [PATCH] Exporting capability code/name pairs

2008-01-03 Thread KaiGai Kohei
James Morris wrote: On Wed, 2 Jan 2008, KaiGai Kohei wrote: Another issue is that securityfs depends on CONFIG_SECURITY, which might be undesirable, given that capabilities are a standard feature. We can implement this feature on another pseudo filesystems. Do you think what filesystem is

[2.6.24-rc BUGFIX] SRP transport: only remove our own entries

2008-01-03 Thread Dave Dillow
The SCSI SRP transport class currently iterates over all children devices of the host that is being removed in srp_remove_host(). However, not all of those children were created by the SRP transport, and removing them will cause corruption and an oops when their creator tries to remove them.

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-03 Thread Robert Hancock
Linda Walsh wrote: Robert Hancock wrote: Linda Walsh wrote: Alan Cox wrote: rate began falling; at 128k block-reads-at-a-time or larger, it drops below 20MB/s (only on buffered SATA). Try disabling NCQ - see if you've got a drive with the 'NCQ = no readahead' flaw.

Re:Believed resolved: SATA kern-buffRd read slow: based on promise driver bug

2008-01-03 Thread Linda Walsh
Mikael Pettersson wrote: Linda Walsh writes: Robert Hancock wrote: Linda Walsh wrote: read rate began falling; at 128k block-reads-at-a-time or larger, it drops below 20MB/s (only on buffered SATA). But more importantly -- I notice a chronic error message associate with this

Re: [PATCHv3] powerpc: DBox2 Board Support

2008-01-03 Thread David Gibson
On Thu, Jan 03, 2008 at 12:46:23PM +0100, Jochen Friedrich wrote: Hi David, +/ { + model = unknown,dbox2; // boot wrapper fills in correct manufacturer Probably better just to leave model out of the dts and let the bootwrapper add it. Unfortunately, dtc requires a model: $ dtc

[2.6.24-rc BUGFIX] IB/srp: release transport when removing host

2008-01-03 Thread Dave Dillow
When removing the ib_srp module, srp_remove_one() does not release the SRP transport class when it is releasing the SCSI host. This leads to dangling references to kfree()'d memory, and an eventual oops. Signed-off-by: David Dillow [EMAIL PROTECTED] --- On Fri, 2008-01-04 at 09:47 +0900, FUJITA

Re: [PATCH] procfs: provide slub's /proc/slabinfo

2008-01-03 Thread Andi Kleen
I still have trouble to see that SLOB still has much to offer. An embedded allocator that in many cases has more allocation overhead than the default one? Ok you still have advantages if allocations are rounded up to the next power of two for a kmalloc and because of the combining of

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-03 Thread Linda Walsh
Robert Hancock wrote: Looks like the drive reports ERR/ABRT (command aborted), meaning it likely doesn't support those commands. --- Except the PATA version of the drive does (same capacity, other specs). Seagate would disable advanced features for SATA but leave them for the older

Re: Believed resolved: SATA kern-buffRd read slow: based on promise driver bug

2008-01-03 Thread Robert Hancock
Linda Walsh wrote: I seem to remember reading about some problems with Promise SATA ACPI. Does this address that or is that a separate issue? (Am using no-acpi for now, but would like to try acpi again if it may be fixed (last time I tried it with this card, sdb went offline (once it

Re: sata_nv + ADMA + Samsung disk problem

2008-01-03 Thread Robert Hancock
Allen Martin wrote: Dunno about the NVidia version. Theirs works rather differently - the GO bit is there, but there's another append register which is used to tell the controller that a new tag has been added to the CPB list. The only thing we currently use the GO bit for is to switch

Re: [2.6.24-rc BUGFIX] SRP transport: only remove our own entries

2008-01-03 Thread FUJITA Tomonori
On Thu, 03 Jan 2008 21:34:49 -0500 Dave Dillow [EMAIL PROTECTED] wrote: The SCSI SRP transport class currently iterates over all children devices of the host that is being removed in srp_remove_host(). However, not all of those children were created by the SRP transport, and removing them

Re: [2.6.24-rc BUGFIX] IB/srp: release transport when removing host

2008-01-03 Thread FUJITA Tomonori
On Thu, 03 Jan 2008 21:39:19 -0500 Dave Dillow [EMAIL PROTECTED] wrote: When removing the ib_srp module, srp_remove_one() does not release the SRP transport class when it is releasing the SCSI host. This leads to dangling references to kfree()'d memory, and an eventual oops. Signed-off-by:

Re: [2.6 patch] mthca: the scheduled MSI support removal

2008-01-03 Thread Roland Dreier
thanks for keeping on top of the schedule, applied for 2.6.25. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 2 of 8] x86: page.h: unify page copying and clearing

2008-01-03 Thread Jeremy Fitzhardinge
# HG changeset patch # User Jeremy Fitzhardinge [EMAIL PROTECTED] # Date 1199317362 28800 # Node ID 4d9a413a0f4c1d98dbea704f0366457b5117045d # Parent ba0ec40a50a7aef1a3153cea124c35e261f5a2df x86: page.h: unify page copying and clearing Move, and to some extent unify, the various page copying and

[PATCH 5 of 8] x86: page.h: move pa and va related things

2008-01-03 Thread Jeremy Fitzhardinge
# HG changeset patch # User Jeremy Fitzhardinge [EMAIL PROTECTED] # Date 1199319656 28800 # Node ID d617b72a0cc9d14bde2087d065c36d4ed3265761 # Parent 3bd7db6e85e66e7f3362874802df26a82fcb2d92 x86: page.h: move pa and va related things Move and unify the virtual-physical address space conversion

[PATCH 1 of 8] x86: page.h: unify constants

2008-01-03 Thread Jeremy Fitzhardinge
# HG changeset patch # User Jeremy Fitzhardinge [EMAIL PROTECTED] # Date 1199317360 28800 # Node ID ba0ec40a50a7aef1a3153cea124c35e261f5a2df # Parent c45c263179cb78284b6b869c574457df088027d1 x86: page.h: unify constants There are many constants which are shared by 32 and 64-bit. Signed-off-by:

[PATCH 4 of 8] x86: page.h: move and unify types for pagetable entry definitions

2008-01-03 Thread Jeremy Fitzhardinge
# HG changeset patch # User Jeremy Fitzhardinge [EMAIL PROTECTED] # Date 1199319654 28800 # Node ID 3bd7db6e85e66e7f3362874802df26a82fcb2d92 # Parent f7e7db3facd9406545103164f9be8f9ba1a2b549 x86: page.h: move and unify types for pagetable entry definitions This patch: 1. Defines arch-specific

[PATCH 0 of 8] x86: unify asm/page.h

2008-01-03 Thread Jeremy Fitzhardinge
Hi Ingo, Here's a series which concentrates on unifying and cleaning up asm-86/page*.h. Each patch in the series restricts itself to doing one thing fairly simply, so it should be fairly low-risk and easy to bisect. The early version of this patch got rid of asm/page_32|64.h entirely, but I

[PATCH 8 of 8] x86/efi: fix improper use of lvalue

2008-01-03 Thread Jeremy Fitzhardinge
# HG changeset patch # User Jeremy Fitzhardinge [EMAIL PROTECTED] # Date 1199391030 28800 # Node ID 5d35c92fdf0e2c52edbb6fc4ccd06c7f65f25009 # Parent 22f6a5902285b58bfc1fbbd9e183498c9017bd78 x86/efi: fix improper use of lvalue pgd_val is no longer valid as an lvalue, so don't try to assign to

[PATCH 6 of 8] x86: page.h: move remaining bits and pieces

2008-01-03 Thread Jeremy Fitzhardinge
# HG changeset patch # User Jeremy Fitzhardinge [EMAIL PROTECTED] # Date 1199319657 28800 # Node ID bba9287641ff90e836d090d80b5c0a846aab7162 # Parent d617b72a0cc9d14bde2087d065c36d4ed3265761 x86: page.h: move remaining bits and pieces Move the remaining odds and ends into page.h. Signed-off-by:

Re: sata_nv + ADMA + Samsung disk problem

2008-01-03 Thread Benjamin Herrenschmidt
On Thu, 2008-01-03 at 19:43 -0600, Robert Hancock wrote: Benjamin Herrenschmidt wrote: Another thing about the PacDigi core: one has to be very careful to avoid sequential accesses to sequential PCI locations when programming the chip -- it cannot handle merged register writes. So for

[PATCH 1/5] CONNECTOR: add a missing break in cn_netlink_send()

2008-01-03 Thread Li Zefan
Each entry in the list has a unique id, so just break out of the loop if the matched id is found. Signed-off-by: Li Zefan [EMAIL PROTECTED] --- drivers/connector/connector.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/connector/connector.c

[PATCH 2/5] CONNECTOR: clean up {,__}cn_rx_skb()

2008-01-03 Thread Li Zefan
- __cn_rx_skb() does nothing but calls cn_call_callback(), it doesn't check skb and msg sizes as the comment suggests, but cn_rx_skb() checks those sizes. - In cn_rx_skb() Local variable 'len' is not used. 'len' is probably intended to be passed to skb_pull(), but here skb_pull() is not needed,

[PATCH 5/5] CONNECTOR: return proper error code in cn_call_callback()

2008-01-03 Thread Li Zefan
Error code should be set to EINVAL instead of ENODEV if !queue_work(). There's another call of queue_work() which may set err to EINVAL. Signed-off-by: Li Zefan [EMAIL PROTECTED] --- drivers/connector/connector.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

Improve hackbench

2008-01-03 Thread Zhang, Yanmin
hackbench is to test Linux scheduler. The original program is at http://devresources.linux-foundation.org/craiger/hackbench/src/hackbench.c Based on this multi-process version, a nice person created a multi-thread version. Pls. see http://www.bullopensource.org/posix/pi-futex/hackbench_pth.c

Re: [PATCH] x86: kprobes change kprobe_handler flow

2008-01-03 Thread Abhishek Sagar
On 1/4/08, Masami Hiramatsu [EMAIL PROTECTED] wrote: I could understand what the original code did at last. If a kprobe is inserted on a breakpoint which other debugger inserts, it single step inline instead of out-of-line.(this is done in prepare_singlestep) In this case, (p

Re: [PATCH] x86: kprobes change kprobe_handler flow

2008-01-03 Thread Abhishek Sagar
On 1/4/08, Masami Hiramatsu [EMAIL PROTECTED] wrote: + case KPROBE_HIT_SS: + if (*p-ainsn.insn == BREAKPOINT_INSTRUCTION) { + regs-flags = ~TF_MASK; + regs-flags |= kcb-kprobe_saved_flags; + return 0; +

Re: [PATCH 1/3] ipc: Convert handmade 'max' to max().

2008-01-03 Thread Richard Knutsson
Sorry for the late response, have been away during the holidays. Andrew Morton wrote: On Mon, 17 Dec 2007 03:35:55 +0100 (MET) Richard Knutsson [EMAIL PROTECTED] wrote: Convert handmade 'max' to max(). ... --- a/ipc/msg.c +++ b/ipc/msg.c @@ -473,7 +473,7 @@ asmlinkage long

[PATCH] PROC_FS: get and set the smp affinity of tasks by read-write /proc/pid/smp_affinity

2008-01-03 Thread Denis Cheng
this adds a read-write /proc/pid/smp_affinity entry, just like what /proc/irq/irq/smp_affinity does, so now we can get and set the affinity of tasks by procfs, this is especially useful used in shell scripts. this also adds a read-write /proc/pid/tasks/tid/smp_affinity for the same purpose. Cc:

[PATCH][BUG 3879] add some check before scsi_cmd_ioctl

2008-01-03 Thread Dave Young
The behaviour of eject/lock_door ioctl is not consistent, so add some check before scsi_cmd_ioctl. Signed-off-by: Dave Young [EMAIL PROTECTED] --- drivers/cdrom/cdrom.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) diff -upr

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Andrey Borzenkov
On Friday 04 January 2008, Andrew Patterson wrote: On Thu, 2008-01-03 at 17:17 -0700, Andrew Patterson wrote: On Fri, 2008-01-04 at 09:07 +0900, Tejun Heo wrote: Hello, Andrew Patterson wrote: It looks like this is a shell issue. After looking through the sysfs code, I

Re: [2.6.22] circular lock detected

2008-01-03 Thread Simon Arlott
On 25/09/07 09:46, Jan Kara wrote: On Tue 25-09-07 10:02:43, Peter Zijlstra wrote: On Mon, 3 Sep 2007 16:01:35 +0200 Jan Kara [EMAIL PROTECTED] wrote: On Mon 03-09-07 05:49:59, Andrew Morton wrote: On Mon, 3 Sep 2007 14:27:02 +0200 Jan Kara [EMAIL PROTECTED] wrote: On Fri, 24 Aug

Re: [patch 1/2] move WARN_ON() out of line

2008-01-03 Thread Ingo Molnar
* Arjan van de Ven [EMAIL PROTECTED] wrote: This patch build on top of Olof's patch that introduces __WARN, and places the slowpath out of line. It also uses Ingo's suggestion to not use __FUNCTION__ but to use kallsyms to do the lookup; this saves a ton of extra space since gcc doesn't

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-03 Thread Ingo Molnar
* Arjan van de Ven [EMAIL PROTECTED] wrote: + printk(KERN_WARNING [ cut here ]\n); printk(KERN_WARNING WARNING: at %s:%d %s()\n, file, line, function); + print_modules(); dump_stack(); + print_oops_end_marker(); another thing:

Re: [PATCH] PROC_FS: get and set the smp affinity of tasks by read-write /proc/pid/smp_affinity

2008-01-03 Thread Paul Jackson
Denis wrote: + length += sprintf(page + length, \n); Could that overrun the 'page' buffer by one byte? -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson [EMAIL PROTECTED] 1.940.382.4214 -- To unsubscribe

[PATCH -mm -v2] EFI : Split EFI tables parsing code from EFI runtime service support code

2008-01-03 Thread Huang, Ying
This patch split EFI tables parsing code from EFI runtime service support code. This makes ACPI support and DMI support on EFI platform not depend on EFI runtime service support. Both EFI32 and EFI64 tables parsing functions are provided on i386 and x86_64. This makes it possible to use EFI

<    3   4   5   6   7   8