Re: [patch] block: fix blktrace timestamps

2008-01-13 Thread Ingo Molnar
* Jens Axboe <[EMAIL PROTECTED]> wrote: > > - Fact: feature CONFIG_CPU_IDLE=y did not exist in 64-bit x86 in v2.6.23. > > It has known bugs but they are not flagged 'regressions' (because the > > feature did not exist before and the option is default-disabled) hence > > the feature can st

Re: [PATCH] CRIS v10: Correct do_signal to fix oops and clean up signal handling in general.

2008-01-13 Thread Jesper Nilsson
On Fri, Jan 11, 2008 at 03:45:13PM -0800, Andrew Morton wrote: > On Fri, 11 Jan 2008 19:59:24 +0100 > Jesper Nilsson <[EMAIL PROTECTED]> wrote: > > > CRIS v10: Correct do_signal to fix oops and clean up signal handling in > > general. > > > > This fixes a kernel panic on boot due to do_signal no

Re: [PATCH] Fix kprobes on ia64

2008-01-13 Thread Christoph Hellwig
On Sun, Jan 13, 2008 at 07:24:24PM -0700, Matthew Wilcox wrote: > If CONFIG_KPROBES is set, we get the error during build: > > kernel/kprobes.c:1057: error: __ksymtab_jprobe_return causes a section > type conflict > > This is because ia64 defines a static inline jprobe_return which kprobes > atte

Re: [RFC, PATCH] watchdog on gpio

2008-01-13 Thread Marc Pignat
On Friday 11 January 2008, Florian Fainelli wrote: > Hello Marc, > > Your patch looks good to me, and I have been waiting for something like > this :). Other comments below. > > Le jeudi 10 janvier 2008, Marc Pignat a écrit : > > +#include > > +#include > > At first sight, this will only work

Re: The ext3 way of journalling

2008-01-13 Thread Tuomo Valkonen
On 2008-01-13 18:11 -0500, Theodore Tso wrote: > It's much more likely that this early in your boot cycle, your clock is > sometimes incorrect. I doubt it. I get this nearly _always_ when the system crashes, which accounts for the vast majority of the times I boot it. (I wish swsusp didn't suck so

Re: [Bluez-devel] Oops involving RFCOMM and sysfs

2008-01-13 Thread Dave Young
On Jan 12, 2008 7:09 AM, Gabor Gombas <[EMAIL PROTECTED]> wrote: > On Thu, Jan 10, 2008 at 09:11:17AM +0800, Dave Young wrote: > > > For bluetooth device_move, the only child device of hci_conn dev is > > the rfcomm tty_dev. How about the following patch, please verify : > > There is now no oops, i

Re: [PATCH 3/7] Move rcutorture to tests/

2008-01-13 Thread Paul E. McKenney
On Thu, Jan 10, 2008 at 03:14:48PM -0800, Josh Triplett wrote: > On Thu, 2008-01-10 at 17:27 +0530, Ananth N Mavinakayanahalli wrote: > > From: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> > > > > Move the rcutorture infrastructure to tests/ > > > > Signed-off-by: Ananth N Mavinakayanahalli <[E

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Dave Young
On Jan 14, 2008 2:58 PM, Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On Mon, Jan 14, 2008 at 09:36:04AM +0800, Dave Young wrote: > > On Jan 13, 2008 4:11 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote: > ... > > > Probably some tiny oversight, but I see this comment to struct class > > > doesn't me

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Jarek Poplawski
On Mon, Jan 14, 2008 at 09:36:04AM +0800, Dave Young wrote: > On Jan 13, 2008 4:11 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote: ... > > Probably some tiny oversight, but I see this comment to struct class > > doesn't mention devices list, so maybe this needs to be updated BTW?: > > > > (from incl

[RFC] hotplug cpu move tasks in empty cpusets - possible refinements

2008-01-13 Thread Paul Jackson
Query for Cliff: 1) Can we narrow the scope of callback_mutex in scan_for_empty_cpusets()? 2) Can we avoid rewriting the cpus, mems of cpusets except when it is likely that we'll be changing them? 3) Should not remove_tasks_in_empty_cpuset() also check for empty mems? -pj --- kernel/cpuse

[PATCH 2/3] hotplug cpu move tasks in empty cpusets to parent various other fixes

2008-01-13 Thread Paul Jackson
From: Paul Jackson <[EMAIL PROTECTED]> Various minor formatting and comment tweaks to Cliff Wickman's [PATCH_3_of_3]_cpusets__update_cpumask_revision.patch I had had "iff", meaning "if and only if" in a comment. However, except for ancient mathematicians, the abbreviation "iff" was a tad too cryp

[PATCH 3/3] cpusets: update_cpumask documentation fix

2008-01-13 Thread Paul Jackson
From: Paul Jackson <[EMAIL PROTECTED]> Update cpuset documentation to match the October 2007 "Fix cpusets update_cpumask" changes that now apply changes to a cpusets 'cpus' allowed mask immediately to the cpus_allowed of the tasks in that cpuset. Signed-off-by: Paul Jackson <[EMAIL PROTECTED]> Cc

[PATCH 1/3] hotplug cpu move tasks in empty cpusets to parent node_online_map fix

2008-01-13 Thread Paul Jackson
From: Paul Jackson <[EMAIL PROTECTED]> As of the October 2007 kernel/cpuset.c patch "Memoryless nodes: Use N_HIGH_MEMORY for cpusets", cpuset nodes are relative to the nodes with (HIGH) memory, not relative to all nodes in node_online_map. Signed-off-by: Paul Jackson <[EMAIL PROTECTED]> Cc: Cliff

Re: [GIT PATCH] Update to Chinese documents

2008-01-13 Thread WANG Cong
On Thu, Jan 10, 2008 at 12:48:56AM +0800, Bryan Wu wrote: >On Jan 9, 2008 7:54 PM, Sam Ravnborg <[EMAIL PROTECTED]> wrote: >> > > >> > > What is generally seen as a showstopper is the amount of work needed >> > > to do the translation - and keeping it up-to-date. >> > >> > Sure. The key is to have

Re: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl

2008-01-13 Thread Cyrill Gorcunov
This patch converts ioctl call to unlocked_ioctl form. It's possible due to rtl_lock spinlock protection. Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- The patch is *not* tested but the patch does not bring _much_ changes so it wouldn't break the compilation procedure. If there is proble

Re: [PATCH 002 of 6] md: Fix use-after-free bug when dropping an rdev from an md array.

2008-01-13 Thread Neil Brown
On Monday January 14, [EMAIL PROTECTED] wrote: > > Thanks. I'll see what I can some up with. How about this, against current -mm On both the read and write path for an rdev attribute, we call mddev_lock, first checking that mddev is not NULL. Once we get the lock, we check again. If rdev->mddev

Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-13 Thread WANG Cong
On Fri, Jan 11, 2008 at 06:02:04PM +0100, Sam Ravnborg wrote: >On Fri, Jan 11, 2008 at 02:17:54PM +, Ralf Baechle wrote: >> On Wed, Jan 02, 2008 at 02:21:36PM +0800, WANG Cong wrote: >> >> > >> Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)? >> > >It would be better to use $(LINUXIN

Re: Why is deleting (or reading) files not counted as IO-Wait in top?

2008-01-13 Thread David Chinner
On Wed, Jan 02, 2008 at 08:35:03PM +0100, Matthias Schniedermeyer wrote: > Hi > > > Currently i'm deleting about 500.000 files on a XFS-filesystem which > takes a few minutes, as i had a top open i saw that 'wa' is shown as > 0.0% (Nothing else running currently) and everything except 'id' is n

RE: fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.

2008-01-13 Thread Kuan Luo
Robert Hancock wrote: > As I mentioned, this doesn't seem to resolve the problem we're seeing > with rapidly intermixed NCQ commands and cache flushes (at > least, if I > take out the arbitrary 20usec delay from the driver and add > this patch, > the problem still shows up). It could be a simi

Re: sparc oops in ip_fast_csum

2008-01-13 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 07:09:22 +0100 > But I agree to your suggestion, that will allow us to properly > handle packets with IP options. I'll take care of this. Thanks a lot Patrick. -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: sparc oops in ip_fast_csum

2008-01-13 Thread Patrick McHardy
Herbert Xu wrote: Patrick, please have a look at the former. In fact it's not just that ihl may be bogus (which might be harmless as long as the REJECT hook only gets called from within the IP stack), I think REJECT would also do the wrong thing if the packet had IP options. So perhaps we shoul

Re: [git pull] Input updates for 2.6.24-rc3

2008-01-13 Thread Dmitry Torokhov
On Monday 14 January 2008, Dmitry Torokhov wrote: > Hi Linus, > > Please pull from: > > git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus > or > master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus > > to receive updates for the input subsystem. >

Re: Is it possible to change IRQ for certain device?

2008-01-13 Thread Lee Revell
On Jan 14, 2008 12:30 AM, Bryan Donlan <[EMAIL PROTECTED]> wrote: > > On Jan 13, 2008 10:57 PM, Lee Revell <[EMAIL PROTECTED]> wrote: > > On Jan 11, 2008 11:57 AM, Jan Marek <[EMAIL PROTECTED]> wrote: > > Why is a shared IRQ a problem for you? IRQ handlers are supposed to > > be fast enough that d

Re: [PATCH] Fix kprobes on ia64

2008-01-13 Thread Sam Ravnborg
On Sun, Jan 13, 2008 at 07:24:24PM -0700, Matthew Wilcox wrote: > > If CONFIG_KPROBES is set, we get the error during build: > > kernel/kprobes.c:1057: error: __ksymtab_jprobe_return causes a section > type conflict > > This is because ia64 defines a static inline jprobe_return which kprobes > a

[git pull] Input updates for 2.6.24-rc3

2008-01-13 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Changelog: - Dmitry Baryshkov (1): Input: Handle

Re: kconfig: support option env="" [Was: kconfig: use $K64BIT to set 64BIT with all*config targets]

2008-01-13 Thread Sam Ravnborg
On Mon, Jan 14, 2008 at 04:49:48AM +0100, Roman Zippel wrote: > Hi, > > On Sun, 6 Jan 2008, Sam Ravnborg wrote: > > > Please get back to me so we can finsih this patch and have it applied. > > I will split the patch in two btw. > > I reworked the patch a little and split it into three. Thanks R

Re: Is it possible to change IRQ for certain device?

2008-01-13 Thread Bryan Donlan
On Jan 13, 2008 10:57 PM, Lee Revell <[EMAIL PROTECTED]> wrote: > On Jan 11, 2008 11:57 AM, Jan Marek <[EMAIL PROTECTED]> wrote: > > I suppose, that VGA card does not need unique IRQ, but programmers, > > which wrote driver, want it. I can imagine, that VGA card have many > > interrupts, especially

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-13 Thread Linus Torvalds
On Mon, 14 Jan 2008, Alan Cox wrote: > > > > As someone gently pointed out to me, you are in a position to know this, > > so I probably am wrong. > > I suspect Arjan is wrong. It might be some Intel agenda but I still see > fairly new driver reference code that is hardcoding port accesses even

Re: fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.

2008-01-13 Thread Robert Hancock
Kuan Luo wrote: Robert hancock wrote: What problem does this resolve? I tested it against the cache flush/NCQ write switching problem we've been trying to solve, and it doesn't look like it fixes that one - if I apply this patch and then remove the udelay(20) in sata_nv.c that I added which

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-13 Thread Arjan van de Ven
On Sun, 13 Jan 2008 22:29:23 -0500 Tony Camuso <[EMAIL PROTECTED]> wrote: > . There is no need to provide different PCI config access >mechanisms at device granularity, since the PCI config access >mechanism between the CPU and the Northbridge is opaque to >the devices. PCI config mech

Re: [PATCH 002 of 6] md: Fix use-after-free bug when dropping an rdev from an md array.

2008-01-13 Thread Neil Brown
On Monday January 14, [EMAIL PROTECTED] wrote: > On Mon, Jan 14, 2008 at 02:21:45PM +1100, Neil Brown wrote: > > > Maybe it isn't there any more > > > > Once upon a time, when I > >echo remove > /sys/block/mdX/md/dev-YYY/state > > Egads. And just what will protect you from parallel cal

Re: Is it possible to change IRQ for certain device?

2008-01-13 Thread Lee Revell
On Jan 11, 2008 11:57 AM, Jan Marek <[EMAIL PROTECTED]> wrote: > I suppose, that VGA card does not need unique IRQ, but programmers, > which wrote driver, want it. I can imagine, that VGA card have many > interrupts, especially in the OpenGL games, but I cannot assign unique > IRQ for VGA card at a

Re: regression: 100% io-wait with 2.6.24-rcX

2008-01-13 Thread Fengguang Wu
On Sun, Jan 13, 2008 at 07:59:33PM +0800, Fengguang Wu wrote: > On Sun, Jan 13, 2008 at 10:49:31AM +0100, Joerg Platte wrote: > > register_jprobe(ext2_writepage) = 0 > > register_jprobe(requeue_io) = 0 > > register_kprobe(submit_bio) = 0 > > requeue_io: > > inode 114019(sda7/.kde) count 2,2 size 0

[PATCH 2/3] environment symbol support

2008-01-13 Thread Roman Zippel
Add the possibility to import a value from the environment into kconfig via the option syntax. Beside flexibility this has the advantage providing proper dependencies. Signed-off-by: Roman Zippel <[EMAIL PROTECTED]> --- Documentation/kbuild/kconfig-language.txt | 21 ++ scripts/kc

[PATCH 3/3] use environment option

2008-01-13 Thread Roman Zippel
Use the environment option to provide the ARCH symbol. Remove the unused KERNELVERSION symbol. Signed-off-by: Roman Zippel <[EMAIL PROTECTED]> --- init/Kconfig |4 scripts/kconfig/symbol.c | 14 -- 2 files changed, 4 insertions(+), 14 deletions(-) Index: linu

Re: [PATCH] Default keyboard LEDs

2008-01-13 Thread H. Peter Anvin
Samuel Thibault wrote: In many cases, one prefers to have e.g. the NumLock on by default. In many cases, one doesn't want to have it by default, e.g. on laptops. Distributions actually have a very hard time trying to set this correctly after the kernel boot, and that doesn't work for new consol

[PATCH 1/3] explicitly introduce expression list

2008-01-13 Thread Roman Zippel
Rename E_CHOICE to E_LIST to explicitly add support for expression lists. Add a helper macro expr_list_for_each_sym to more easily iterate over the list. Signed-off-by: Roman Zippel <[EMAIL PROTECTED]> --- scripts/kconfig/confdata.c |8 scripts/kconfig/expr.c | 16 ---

Re: kconfig: support option env="" [Was: kconfig: use $K64BIT to set 64BIT with all*config targets]

2008-01-13 Thread Roman Zippel
Hi, On Sun, 6 Jan 2008, Sam Ravnborg wrote: > Please get back to me so we can finsih this patch and have it applied. > I will split the patch in two btw. I reworked the patch a little and split it into three. > > + if (sym->flags & SYMBOL_AUTO) > > + sym->flags &= ~SYMBOL_WRITE; > >

Re: [PATCH 002 of 6] md: Fix use-after-free bug when dropping an rdev from an md array.

2008-01-13 Thread Al Viro
On Mon, Jan 14, 2008 at 02:21:45PM +1100, Neil Brown wrote: > Maybe it isn't there any more > > Once upon a time, when I >echo remove > /sys/block/mdX/md/dev-YYY/state Egads. And just what will protect you from parallel callers of state_store()? buffer->mutex does *not* do that - it o

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-13 Thread Tony Camuso
To all ... Well, here is what I perceive we've got so far. . Some PCI Northbridges do not work with MMCONFIG. . Some PCI BARs can overlap the MMCONFIG area during bus sizing. It is hoped that new BIOSes will locate MMCONFIG in an area safely out of the way of bus sizing code, but there can

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2008-01-13 Thread Alex Dubov
--- Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 2 Jan 2008 17:42:24 +1100 [EMAIL PROTECTED] wrote: > > > From: Alex Dubov <[EMAIL PROTECTED]> > > > > Sony MemoryStick cards are used in many products manufactured by Sony. They > > are available both as storage and as IO expansion cards.

Re: [PATCH 002 of 6] md: Fix use-after-free bug when dropping an rdev from an md array.

2008-01-13 Thread Neil Brown
On Monday January 14, [EMAIL PROTECTED] wrote: > On Mon, Jan 14, 2008 at 12:45:31PM +1100, NeilBrown wrote: > > > > Due to possible deadlock issues we need to use a schedule work to > > kobject_del an 'rdev' object from a different thread. > > > > A recent change means that kobject_add no longer

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-13 Thread Zhang, Yanmin
On Fri, 2008-01-11 at 09:56 -0800, Rick Jones wrote: > >>The test command is: > >>#sudo taskset -c 7 ./netserver > >>#sudo taskset -c 0 ./netperf -t TCP_RR -l 60 -H 127.0.0.1 -i 50,3 -I 99,5 > >>-- -r 1,1 > > A couple of comments/questions on the command lines: Thanks for your kind comments. >

[PATCH] Reset ACPI backlight on resume

2008-01-13 Thread Matthew Garrett
Some machines seem to need the backlight brightness to be reset on resume. Add support for doing so to the video module. Signed-off-by: Matthew Garrett <[EMAIL PROTECTED]> --- diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index b8ce6dc..09a85eb 100644 --- a/drivers/acpi/video.c +++ b

RE: fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.

2008-01-13 Thread Kuan Luo
Robert hancock wrote: > What problem does this resolve? I tested it against the cache > flush/NCQ > write switching problem we've been trying to solve, and it > doesn't look > like it fixes that one - if I apply this patch and then remove the > udelay(20) in sata_nv.c that I added which preven

Re: [PATCH: 2/2] [SERIAL] avoid stalling suspend if serial port won't drain

2008-01-13 Thread nigel
Hi. Alan Cox wrote: >>> Is printk() enough for 'we've just lost your data' condition? Maybe we >>> should abort suspend if we can't drain fifo? >> No way. Think about this from a users' perspective. No one wants suspend >> to ram or hibernate functionality that works sometimes and not others. >> T

[PATCH] Fix kprobes on ia64

2008-01-13 Thread Matthew Wilcox
If CONFIG_KPROBES is set, we get the error during build: kernel/kprobes.c:1057: error: __ksymtab_jprobe_return causes a section type conflict This is because ia64 defines a static inline jprobe_return which kprobes attempts to EXPORT_SYMBOL. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> di

Re: [PATCH 002 of 6] md: Fix use-after-free bug when dropping an rdev from an md array.

2008-01-13 Thread Al Viro
On Mon, Jan 14, 2008 at 12:45:31PM +1100, NeilBrown wrote: > > Due to possible deadlock issues we need to use a schedule work to > kobject_del an 'rdev' object from a different thread. > > A recent change means that kobject_add no longer gets a refernce, and > kobject_del doesn't put a reference.

Re: Lenovo ThinkPads need acpi_osi="Linux"

2008-01-13 Thread Matthew Garrett
On Sun, Jan 13, 2008 at 11:57:18PM -0200, Henrique de Moraes Holschuh wrote: > On Mon, 14 Jan 2008, Matthew Garrett wrote: > > not going to want the low-level ACPI code to do anything video-related > > on a lot of hardware. The in-kernel modesetting code for Intel machines > > will be able to han

Re: [PATCH 2/7] ieee1394 : use class iteration api

2008-01-13 Thread Dave Young
On Jan 12, 2008 7:10 PM, Stefan Richter <[EMAIL PROTECTED]> wrote: > Dave Young wrote: > > +++ linux.new/drivers/ieee1394/nodemgr.c 2008-01-12 15:20:27.0 > > +0800 > ... > > > static void nodemgr_remove_uds(struct node_entry *ne) > > { > > struct device *dev; > > - struct

Re: Lenovo ThinkPads need acpi_osi="Linux"

2008-01-13 Thread Henrique de Moraes Holschuh
On Mon, 14 Jan 2008, Matthew Garrett wrote: > On Mon, Jan 14, 2008 at 12:35:54AM +, Matthew Garrett wrote: > > No. This breaks on the R50e, at least - I suspect it'd also have > > problems on any nvidia based machines, but I don't have one to hand at > > the moment. It can be set at runtime a

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-13 Thread Matthew Garrett
Len, I've had no feedback on this - the backlight maintainer thinks it's the right way to go, so I'd like to get it queued for .25 at least. -- Matthew Garrett | [EMAIL PROTECTED] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECT

Re: Lenovo ThinkPads need acpi_osi="Linux"

2008-01-13 Thread Matthew Garrett
On Mon, Jan 14, 2008 at 12:35:54AM +, Matthew Garrett wrote: > No. This breaks on the R50e, at least - I suspect it'd also have > problems on any nvidia based machines, but I don't have one to hand at > the moment. It can be set at runtime already. Just to clarify this further, in the relat

[PATCH 006 of 6] md: Change ITERATE_RDEV_GENERIC to rdev_for_each_list, and remove ITERATE_RDEV_PENDING.

2008-01-13 Thread NeilBrown
Finish ITERATE_ to for_each conversion. Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./drivers/md/md.c |8 ./include/linux/raid/md_k.h | 14 -- 2 files changed, 8 insertions(+), 14 deletions(-) diff .prev/drivers/md/md.c ./drivers/md/md

Re: regression: 100% io-wait with 2.6.24-rcX

2008-01-13 Thread Fengguang Wu
On Sun, Jan 13, 2008 at 10:49:31AM +0100, Joerg Platte wrote: > register_jprobe(ext2_writepage) = 0 > register_jprobe(requeue_io) = 0 > register_kprobe(submit_bio) = 0 > requeue_io: > inode 114019(sda7/.kde) count 2,2 size 0 pages 1 > 0 2 0 U > requeue_io: > inode 114025(sda7/ca

[PATCH 005 of 6] md: Change ITERATE_RDEV to rdev_for_each

2008-01-13 Thread NeilBrown
as this is morein line with common practice in the kernel. Also swap the args around to be more like list_for_each. Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./drivers/md/bitmap.c |4 +- ./drivers/md/faulty.c |2 - ./drivers/md/linear.c |2 -

[PATCH 002 of 6] md: Fix use-after-free bug when dropping an rdev from an md array.

2008-01-13 Thread NeilBrown
Due to possible deadlock issues we need to use a schedule work to kobject_del an 'rdev' object from a different thread. A recent change means that kobject_add no longer gets a refernce, and kobject_del doesn't put a reference. Consequently, we need to explicitly hold a reference to ensure that t

[PATCH 003 of 6] md: Change a few 'int' to 'size_t' in md

2008-01-13 Thread NeilBrown
As suggested by Andrew Morton. Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./drivers/md/md.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff .prev/drivers/md/md.c ./drivers/md/md.c --- .prev/drivers/md/md.c 2008-01-14 12:24:17.0 +1100 +++

[PATCH 004 of 6] md: Change INTERATE_MDDEV to for_each_mddev

2008-01-13 Thread NeilBrown
As this is more consistent with kernel style. Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./drivers/md/md.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff .prev/drivers/md/md.c ./drivers/md/md.c --- .prev/drivers/md/md.c 2008-01-14 12:24:5

[PATCH 001 of 6] md: Fix an occasional deadlock in raid5

2008-01-13 Thread NeilBrown
raid5's 'make_request' function calls generic_make_request on underlying devices and if we run out of stripe heads, it could end up waiting for one of those requests to complete. This is bad as recursive calls to generic_make_request go on a queue and are not even attempted until make_request comp

[PATCH 000 of 6] md: various fixes for md

2008-01-13 Thread NeilBrown
Following are 6 patches for md which are suitable for 2.6.25-rc1. The first fixes a bug which could make it a candidate for 24-final. However it is a deadlock that seems to occur very rarely, and has been in mainline since 2.6.22. So letting it into one more release shouldn't be a big problem. W

EXPORTS_SYMBOLs that are in assembly?

2008-01-13 Thread Steven Rostedt
Hi guys, Just wondering what the proper way to export a symbol that is defined in assembly? Or is there some kind of annotation I can add in comment form that will let checkpatch know the variable is not in C? Here's what I'm getting: ./scripts/checkpatch.pl patches/`quilt top` WARNING: EXPORT_

Re: [PATCH] Default keyboard LEDs

2008-01-13 Thread Jan Engelhardt
On Jan 14 2008 00:52, Samuel Thibault wrote: > >In many cases, one prefers to have e.g. the NumLock on by default. In >many cases, one doesn't want to have it by default, e.g. on laptops. > >Distributions actually have a very hard time trying to set this >correctly after the kernel boot, and that

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-13 Thread Neil Brown
On Thursday January 10, [EMAIL PROTECTED] wrote: > On Thu, Jan 10, 2008 at 03:13:48PM +1100, Neil Brown wrote: > > > What guarantees that it doesn't happen before we get to callback? AFAICS, > > > nothing whatsoever... > > > > Yes, that's bad isn't it :-) > > > > I think I should be using sysfs_

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Dave Young
On Jan 13, 2008 4:11 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > On Sat, Jan 12, 2008 at 05:47:54PM +0800, Dave Young wrote: > > Add the following class iteration functions for driver use: > > class_for_each_device > > class_find_device > > class_for_each_child > > class_find_child > > > > S

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-13 Thread Arjan van de Ven
On Mon, 14 Jan 2008 00:54:34 + Alan Cox <[EMAIL PROTECTED]> wrote: > On Sun, 13 Jan 2008 16:28:08 -0500 > Tony Camuso <[EMAIL PROTECTED]> wrote: > > > Arjan van de Ven wrote: > > > > >> The PCI spec provides for conf1 as an architected solution. It's > > >> not going away, and especially not

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Dave Young
On Jan 12, 2008 6:50 PM, Stefan Richter <[EMAIL PROTECTED]> wrote: > Dave Young wrote: > > Add the following class iteration functions for driver use: > > Thanks Dave. I will check the ieee1394 part in detail later. > > ... > > +/** > > + * class_find_device - device iterator for locating a partic

Re: [CALL FOR TESTING] Make Ext3 fsck way faster [2.6.23.13]

2008-01-13 Thread Daniel Phillips
On Sunday 13 January 2008 01:14, Michael Gerdau wrote: > This patch does not apply to a clean 2.6.23.13 tree using either of > patch -p1patch -p1 -l http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: The ext3 way of journalling

2008-01-13 Thread Bernd Eckenfels
In article <[EMAIL PROTECTED]> you wrote: > Just to clarify, I had about 60 days of uptime, and hence at least > 60 days since the last FS check/mount/etc., when Linux crashed those > few days ago, and wanted to start checking disks with "9192 days since > last file system check". This, however so

[PATCH] Default keyboard LEDs

2008-01-13 Thread Samuel Thibault
In many cases, one prefers to have e.g. the NumLock on by default. In many cases, one doesn't want to have it by default, e.g. on laptops. Distributions actually have a very hard time trying to set this correctly after the kernel boot, and that doesn't work for new consoles that are created via t

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-13 Thread Alan Cox
On Sun, 13 Jan 2008 16:28:08 -0500 Tony Camuso <[EMAIL PROTECTED]> wrote: > Arjan van de Ven wrote: > > >> The PCI spec provides for conf1 as an architected solution. It's not > >> going away, and especially not in x86 land where Port IO is built-in > >> to the CPU. > > > > again sadly you're wr

Re: 2.6.22.15: kernel processes stuck in D state

2008-01-13 Thread CaT
On Sat, Jan 12, 2008 at 09:15:16AM +1100, CaT wrote: > On Fri, Jan 11, 2008 at 12:20:58PM +0100, Stefan Richter wrote: > > CaT wrote: > > > Not sure what other info to provide > > > > Is the bug present in 2.6.24-rc7? > > Can't rightly say. I didn't try it before because 2.6.23 fails to > compile

Re: [PATCH: 2/2] [SERIAL] avoid stalling suspend if serial port won't drain

2008-01-13 Thread Alan Cox
> > Is printk() enough for 'we've just lost your data' condition? Maybe we > > should abort suspend if we can't drain fifo? > > No way. Think about this from a users' perspective. No one wants suspend > to ram or hibernate functionality that works sometimes and not others. > They want it to work r

Re: Lenovo ThinkPads need acpi_osi="Linux"

2008-01-13 Thread Matthew Garrett
On Sun, Jan 13, 2008 at 09:41:29PM -0200, Henrique de Moraes Holschuh wrote: > On Sun, 13 Jan 2008, Pavel Machek wrote: > > When linux calls video BIOS with lcall (acpi_sleep=s3_bios), they > > should turn on backlight and put video into text mode. They should > > also make sure mode setting works

Re: [PATCH: 2/2] [SERIAL] avoid stalling suspend if serial port won't drain

2008-01-13 Thread Russell King
On Fri, Jan 11, 2008 at 10:17:21AM +, Pavel Machek wrote: > On Tue 2008-01-08 11:57:03, Russell King wrote: > > + if (!tries) > > + printk(KERN_ERR "%s%s%s%d: Unable to drain > > transmitter\n", > > + port->dev ? port->dev->bus_id : "", > >

Re: [RFD] Incremental fsck

2008-01-13 Thread Daniel Phillips
Hi Ted, On Saturday 12 January 2008 06:51, Theodore Tso wrote: > What is very hard to check is whether or not the link count on the > inode is correct. Suppose the link count is 1, but there are > actually two directory entries pointing at it. Now when someone > unlinks the file through one of t

Re: Lenovo ThinkPads need acpi_osi="Linux"

2008-01-13 Thread Henrique de Moraes Holschuh
A bit more on this issue. I have received a report that on a X61, it actually works the opposite from the T61 and you need acpi_osi="!Linux" to get the "mute" key to work. Well, I am asking the users to track down exactly *where* the mute key is comming from in each case (ACPI or keyboard control

Re: Linux 2.6.24-rc7

2008-01-13 Thread Tejun Heo
J.A. Magallón wrote: > I'm still pending to pysically remove the disks (or at least unplug the > cable...), but I have realized a cusious thing: after some errors, the > kernel is lowering the disk speed (UDMA/133, then 100, then 33): That's the standard error handling behavior. Timeouts are like

Re: [PATCH 3/5] NLM: Have lockd call try_to_freeze

2008-01-13 Thread Rafael J. Wysocki
On Sunday, 13 of January 2008, Neil Brown wrote: > On Sunday January 13, [EMAIL PROTECTED] wrote: > > On Thu, 10 Jan 2008 13:01:34 -0500 > > Jeff Layton <[EMAIL PROTECTED]> wrote: > > > > > lockd makes itself freezable, but never calls try_to_freeze(). Have it > > > call try_to_freeze() within the

Re: Lenovo ThinkPads need acpi_osi="Linux"

2008-01-13 Thread Henrique de Moraes Holschuh
On Sun, 13 Jan 2008, Pavel Machek wrote: > > The reason it shoudl be turned off is that backlight enabling > > backlight from a native graphics driver is much faster than running > > through the video BIOS POST. So if we keep the OSI(Linux) > > video BIOS POST workaround in place permanently, it w

Re: [PATCH] leds: Add support for the 3rd LED on the PCEngines WRAP

2008-01-13 Thread Richard Purdie
On Thu, 2007-12-27 at 14:31 +0100, Michael Loeffler wrote: > The 3rd LED on this board is something like a power-led, it is on all the > time. With this change to the leds-wrap driver it is possible to use this > LED too. > > Signed-off-by: Michael Loeffler <[EMAIL PROTECTED]> > --- > Hi > > I won

Re: Linux 2.6.24-rc7

2008-01-13 Thread J.A. Magallón
On Thu, 10 Jan 2008 22:10:08 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Hi, > > J.A. Magallón wrote: > > It reproduces also with 2.6.23.13. > > Finally I think the problematic disk is sdc: > > Okay, then, it's less likely a regression and more likely a newly > developed hardware problem. > >

Re: The ext3 way of journalling

2008-01-13 Thread Theodore Tso
On Mon, Jan 14, 2008 at 12:23:10AM +0200, Tuomo Valkonen wrote: > On 2008-01-14 00:13 +0200, Tuomo Valkonen wrote: > > Also, I must say that e2fsck is brain-damaged, if it can be confused > > by/do the stupid then when the system clock has warped by just a few > > hours, not the _days_ that a file

Re: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl

2008-01-13 Thread Andi Kleen
On Sunday 13 January 2008 21:32:23 Cyrill Gorcunov wrote: > This patch converts ioctl call to unlocked_ioctl form with > explicit big-kernel-lock. > Also it makes a bit of cleanup > converting miscdevice structure initialization to C99 form. First please always send cleanup patches separately. I

Re: [PATCH: 2/2] [SERIAL] avoid stalling suspend if serial port won't drain

2008-01-13 Thread Benjamin Herrenschmidt
On Fri, 2008-01-11 at 10:17 +, Pavel Machek wrote: > Is printk() enough for 'we've just lost your data' condition? Maybe we > should abort suspend if we can't drain fifo? YUCK ! Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMA

Re: 2.6.24-rc7-rt1

2008-01-13 Thread Mark Knecht
On Jan 13, 2008 11:00 AM, Steven Rostedt <[EMAIL PROTECTED]> wrote: > We are pleased to announce the 2.6.24-rc7-rt1 tree, which can be > downloaded from the location: > > http://rt.et.redhat.com/download/ > Up and running here. No significant testing but no problems building it and no obvious re

Re: CONFIG_NO_HZ breaks blktrace timestamps

2008-01-13 Thread nigel
Hi. Ingo Molnar wrote: > * [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > Just out of curiosity, could you try the appended cumulative patch > and report .clock_warps, .clock_overflows and .clock_underflows as > you did. With those patches, CONFIG_NO_HZ works just fine. >> Co

ATA device reset, shoud I be concerned?

2008-01-13 Thread Georgi Chulkov
Hello, During heavy disk load on my laptop, sometimes the IDE disk will pause for a second and then continue. I get this in my kernel log: [ 9031.028000] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen [ 9031.028000] ata1.00: cmd c8/00:08:90:ca:ce/00:00:00:00:00/e0 tag 0 cdb 0x

Re: [PATCH: 2/2] [SERIAL] avoid stalling suspend if serial port won't drain

2008-01-13 Thread nigel
Hi. Pavel Machek wrote: > On Tue 2008-01-08 11:57:03, Russell King wrote: >> Some ports seem to be unable to drain their transmitters on shut down. >> Such a problem can occur if the port is programmed for hardware imposed >> flow control, characters are in the FIFO but the CTS signal is inactive.

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2008-01-13 Thread Miguel Botón
This happens when trying to compile memory stick support inside the kernel. drivers/memstick/core/mspro_block.o: In function `memstick_priv': mspro_block.c:(.text+0x0): multiple definition of `memstick_priv' drivers/memstick/core/memstick.o:memstick.c:(.text+0x0): first defined here drivers/memsti

checkpatch: add filename before the summary line

2008-01-13 Thread Paolo Ciarrocchi
With the patch applied the output of checkpatch.pl is as follow: ./arch/arm/mach-footbridge/ebsa285-pci.c total: 1 errors, 0 warnings, 48 lines checked Adding the file name allowed me to collects stats running: find . -name *.c |xargs ./scripts/checkpatch.pl --file |grep -B 1 total but I

Re: [PATCH 3/5] NLM: Have lockd call try_to_freeze

2008-01-13 Thread Neil Brown
On Sunday January 13, [EMAIL PROTECTED] wrote: > On Thu, 10 Jan 2008 13:01:34 -0500 > Jeff Layton <[EMAIL PROTECTED]> wrote: > > > lockd makes itself freezable, but never calls try_to_freeze(). Have it > > call try_to_freeze() within the main loop. > > > > Signed-off-by: Jeff Layton <[EMAIL PROTE

Re: The ext3 way of journalling

2008-01-13 Thread Tuomo Valkonen
On 2008-01-14 00:13 +0200, Tuomo Valkonen wrote: > Also, I must say that e2fsck is brain-damaged, if it can be confused > by/do the stupid then when the system clock has warped by just a few > hours, not the _days_ that a file system check interval typically is, > and users need to specifically kl

Re: The ext3 way of journalling

2008-01-13 Thread Tuomo Valkonen
On 2008-01-12 10:06 -0500, Theodore Tso wrote: > So running the "date" command after the boot sequence is completely > finished. That doesn't mean that system clock was correct at the time > when fsck is run. Unless ntpd has managed to change it by that time, it was correct, in the local time

Re: [PATCH] serial: remove "too much work for irq" printk

2008-01-13 Thread Pavel Machek
On Sat 2008-01-12 21:24:57, Alan Cox wrote: > On Sat, 12 Jan 2008 15:15:43 -0500 > Benjamin LaHaise <[EMAIL PROTECTED]> wrote: > > > When using kvm with a serial console, the serial driver will print out > > "too much work for irq4" on any heavy activity (ie vi on a file repainting > > the termi

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-13 Thread Herbert Xu
[EMAIL PROTECTED] wrote: > > Any ideas? Please provide a packet dump on both sides (or at least the sender side). Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.or

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-13 Thread Sam Ravnborg
> And I found another small buglet too. I hope to post a complete > solution later today. The modpost bits turned out to take longer than expected so they are not done yet. The problem was the modpost structure were not prepared for adding such additional chacks. So I reworked those bits and the

[PATCH] kbuild: simplify section mismatch check in modpost

2008-01-13 Thread Sam Ravnborg
In another thread I mentioned the idea to introduce additional sections for all the __init markers. Introducing checks for all the new combinations in modpost turned out to be difficult so I decided to clean up what we have today by introducing a table based approach. The patch below is the result

Re: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl

2008-01-13 Thread Cyrill Gorcunov
Thanks Jiri. Will do that all tomorrow. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-13 Thread Tony Camuso
Arjan van de Ven wrote: The PCI spec provides for conf1 as an architected solution. It's not going away, and especially not in x86 land where Port IO is built-in to the CPU. again sadly you're wrong. As someone gently pointed out to me, you are in a position to know this, so I probably am

  1   2   3   >