Re: About closed-source module use GPL module function

2008-01-29 Thread Pekka Enberg
Hi, On Jan 30, 2008 8:41 AM, CooperYuan Cooper <[EMAIL PROTECTED]> wrote: > Now I am porting a device driver to Linux, its source code is not opened. > > In this module, I use some interface functions exported from GPL > module through EXPORT_SYMBOL macros. (not EXPORT_SYMBOL_GPL), For > example,

Re: [PATCH 2.6.24] x86: add sysfs interface for cpuid module

2008-01-29 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 06:22:43AM +0800, Yi Yang wrote: > On Tue, 2008-01-29 at 09:44 +0100, Sam Ravnborg wrote: > > > + > > > +static struct notifier_block __cpuinitdata cpuid_sysfs_cpu_notifier = { > > > + .notifier_call = cpuid_sysfs_cpu_callback, > > > +}; > > Data is annotated _cpuintidata >

Re: [PATCH v3] ipwireless: driver for 3G PC Card

2008-01-29 Thread David Sterba
Hi, On Tue, Jan 29, 2008 at 02:49:24PM +0100, David Sterba wrote: > --- > From: David Sterba <[EMAIL PROTECTED]> > > ipwireless_cs: driver for PC Card, 3G internet connection > > The driver is manufactured by IPWireless. Sorry this ^^^ is not correct, should be "The device is manufactured by

Re: ndiswrapper and GPL-only symbols redux

2008-01-29 Thread Geert Uytterhoeven
On Tue, 29 Jan 2008, Zan Lynx wrote: > Jon Masters wrote: > > I wouldn't quite say that. I wasn't going to comment, but...personally, > > I actually disagree with the assertions that ndiswrapper isn't causing > > proprietary code to link against GPL functions in the kernel (how is > > an NDIS

Re: ndiswrapper and GPL-only symbols redux

2008-01-29 Thread Geert Uytterhoeven
On Wed, 30 Jan 2008, M�ns Rullg�rd wrote: > Adrian Bunk <[EMAIL PROTECTED]> writes: > > On Tue, Jan 29, 2008 at 11:25:22PM +, M�ns Rullg�rd wrote: > >> As long as you don't distribute /proc/kcore, I can't see how the GPL > >> would have any say in the matter. The Windows drivers are

Re: [PATCH 2.6.24] x86: add sysfs interface for cpuid module

2008-01-29 Thread Yi Yang
On Tue, 2008-01-29 at 09:44 +0100, Sam Ravnborg wrote: > > + > > +static struct notifier_block __cpuinitdata cpuid_sysfs_cpu_notifier = { > > + .notifier_call = cpuid_sysfs_cpu_callback, > > +}; > Data is annotated _cpuintidata > > but > > > + > Data is annotated _cpuintidata > > > @@ -217,11

Re: [PATCH 2.6.24] x86: add sysfs interface for cpuid module

2008-01-29 Thread H. Peter Anvin
Yi Yang wrote: Function cpuid has reset ecx to 0 immediate before calling to __cpuid, so this shouldn't be a problem now. Unless, of course, you want to get to the information for the higher CPUID levels. The easiest way to fix that would be to use cpuid_count() and let /dev/cpu/*/cpuid

Re: [RFC v2 2/5] dmaengine: Add slave DMA interface

2008-01-29 Thread David Brownell
On Tuesday 29 January 2008, Haavard Skinnemoen wrote: > @@ -297,6 +356,13 @@ struct dma_device { > struct dma_async_tx_descriptor *(*device_prep_dma_interrupt)( > struct dma_chan *chan); >   > +   struct dma_slave_descriptor *(*device_prep_slave)( > +   

Re: [RFC v2 0/5] dmaengine: Slave DMA interface and example users

2008-01-29 Thread David Brownell
On Tuesday 29 January 2008, Haavard Skinnemoen wrote: > > Btw, there's one issue I forgot to mention: I believe the DMA Engine > framework is currently misusing the DMA mapping API, and this patchset > makes things worse. > > Currently, the async_tx bits of the API do the required calls to >

Re: ptrace API extensions for BTS

2008-01-29 Thread Roland McGrath
Sorry I did not get more into this discussion earlier. I still have not read through all of the email threads. But I have looked over the current version of your code now in -mm. I think this work has a great deal of overlap with the perfmon2 project. There are two facets that overlap, which

Re: [PATCH 2.6.24] x86: add sysfs interface for cpuid module

2008-01-29 Thread Yi Yang
On Tue, 2008-01-29 at 23:17 -0800, H. Peter Anvin wrote: > Yi Yang wrote: > >> > >> It's broken, because it doesn't take into account the fact that Intel > >> broke CPUID level 4 and made it "repeating" (neither did the cpuid char > >> device, because it predated the Intel braindamage; I've had

Re: [PATCH 2.6.24] x86: add sysfs interface for cpuid module

2008-01-29 Thread H. Peter Anvin
Yi Yang wrote: It's broken, because it doesn't take into account the fact that Intel broke CPUID level 4 and made it "repeating" (neither did the cpuid char device, because it predated the Intel braindamage; I've had a patch for it privately for a while, but didn't push it upstream because

Re: [GIT PULL] ext4 update

2008-01-29 Thread Theodore Tso
On Tue, Jan 29, 2008 at 10:54:03PM +0100, Jan Engelhardt wrote: > > On Jan 29 2008 07:53, Theodore Tso wrote: > > > >>fwiw, diffstat is confused by git's diff output; you need to use > >>'diffstat -p1' > > I am seeing normal behavior: > > 22:52 sovereign:~/linux > git diff HEAD | diffstat

[PATCH] Debugfs compile fix.

2008-01-29 Thread Denis V. Lunev
Debugfs is not compiled without CONFIG_SYSFS in net-2.6 tree. Move kobject_create_and_add under appropriate ifdef. The fix looks correct from a first glance, but may be the dependency should be added into the Kconfig. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- fs/debugfs/inode.c |

Re: [PATCH 2.6.24] x86: add sysfs interface for cpuid module

2008-01-29 Thread Yi Yang
On Tue, 2008-01-29 at 07:51 -0800, H. Peter Anvin wrote: > Yi Yang wrote: > > Current cpuid module will create a char device for every logical cpu, > > when a user cats /dev/cpu/*/cpuid, he/she will enter a limitless loop, > > the root cause is that cpuid module doesn't decide wether a cpuid level

2.6.24-git6-ext4-1 patchset released

2008-01-29 Thread Theodore Ts'o
I've just released 2.6.24-git6-ext4-1. It removes the patches that have been pulled into mainline by Linus, and adds the unlocked ioctl patches from Andi Kleen, and Eric's patch to allow the root inode to use in-inode EA's. As a git tree:

[PATCH] lib: Add support for DIF CRC

2008-01-29 Thread Martin K. Petersen
Add support for the T10 Data Integrity Field CRC. Signed-off-by: Martin K. Petersen <[EMAIL PROTECTED]> diff -r f5ec697e8b10 include/linux/crc-t10dif.h --- /dev/null Thu Jan 01 00:00:00 1970 + +++ b/include/linux/crc-t10dif.hTue Jan 29 13:26:19 2008 -0500 @@ -0,0 +1,9 @@ +#ifndef

Re: [PATCH] lib: Add support for DIF CRC

2008-01-29 Thread Martin K. Petersen
> "Jan" == Jan Engelhardt <[EMAIL PROTECTED]> writes: Jan> 'const unsigned char *', like the rest of all code does. Updated patch follows. Jan> Do we already have some users for the T10DIF CRC? This is a runt patch given that it doesn't fit in block and SCSI. The remaining bits will

Re: [RFC/PATCH] e100 driver didn't support any MII-less PHYs...

2008-01-29 Thread Andreas Mohr
Hi, On Tue, Jan 29, 2008 at 03:09:25PM -0800, Kok, Auke wrote: > Andreas Mohr wrote: > > Perhaps it's useful to file a bug/patch > > on http://sourceforge.net/projects/e1000/ ? Perhaps -mm testing? > > I wanted to push this though our testing labs first which has not happened > due to > time

[BUG] 2.6.24-git6 soft lockup detected while running libhugetlbfs

2008-01-29 Thread Kamalesh Babulal
Hi, Softlockup is detected while running libhugetlbfs on the 2.6.24-git6 kernel. The machine is a Pentium III (Cascades) 16 cpu machine. BUG: soft lockup - CPU#13 stuck for 61s! [swapper:0] Pid: 0, comm: swapper Not tainted (2.6.24-git6-autokern1 #1) EIP: 0060:[] EFLAGS: 0246 CPU: 13 EIP is

Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-29 Thread Trond Myklebust
On Wed, 2008-01-30 at 03:25 +, David Howells wrote: > Chuck Lever <[EMAIL PROTECTED]> wrote: > > > This patch really ought to be broken into more manageable atomic > > changes to make it easier to review, and to provide more fine-grained > > explanation and rationalization for each specific

About closed-source module use GPL module function

2008-01-29 Thread CooperYuan Cooper
Hi all, Now I am porting a device driver to Linux, its source code is not opened. In this module, I use some interface functions exported from GPL module through EXPORT_SYMBOL macros. (not EXPORT_SYMBOL_GPL), For example, register_sound_dsp() and so on. Do I violate GPL? How to solve it?

Re: Change In sk_buff structure in 2.6.22 kernel

2008-01-29 Thread Stephen Hemminger
On Wed, 30 Jan 2008 10:49:49 +0530 "PV Juliet" <[EMAIL PROTECTED]> wrote: > Hi All, > > > The header fields in the sk_buff structure have been renamed and are > no longer unions. > > Networking code and drivers are supposed to use skb->transport_header, > skb->network_header, and

Re: ndiswrapper and GPL-only symbols redux

2008-01-29 Thread Pavel Roskin
Quoting Andi Kleen <[EMAIL PROTECTED]>: Pavel Roskin <[EMAIL PROTECTED]> writes: */ @@ -162,6 +163,7 @@ const char *print_tainted(void) if (tainted) { snprintf(buf, sizeof(buf), "Tainted: %c%c%c%c%c%c%c%c", tainted & TAINT_PROPRIETARY_MODULE ?

Re: [PATCH 2.6.24] x86: add sysfs interface for cpuid module

2008-01-29 Thread H. Peter Anvin
Yi Yang wrote: It's broken, because it doesn't take into account the fact that Intel broke CPUID level 4 and made it "repeating" (neither did the cpuid char device, because it predated the Intel braindamage; I've had a patch for it privately for a while, but didn't push it upstream because

Re: [RFC] ext3: per-process soft-syncing data=ordered mode

2008-01-29 Thread Al Boldi
Jan Kara wrote: > > Chris Snook wrote: > > > Al Boldi wrote: > > > > This RFC proposes to introduce a tunable which allows to disable > > > > fsync and changes ordered into writeback writeout on a per-process > > > > basis like this: > > > > > > > > echo 1 > /proc/`pidof process`/softsync >

Re: ndiswrapper and GPL-only symbols redux

2008-01-29 Thread Andi Kleen
Pavel Roskin <[EMAIL PROTECTED]> writes: > */ > @@ -162,6 +163,7 @@ const char *print_tainted(void) > if (tainted) { > snprintf(buf, sizeof(buf), "Tainted: %c%c%c%c%c%c%c%c", > tainted & TAINT_PROPRIETARY_MODULE ? 'P' : 'G', > +

[PATCH 4/4] IB: introducing MTHCA_MR_DMABARRIER

2008-01-29 Thread akepner
Add MTHCA_MR_DMABARRIER to mthca's API, increment ABI version, and make use of MTHCA_MR_DMABARRIER when mapping a user-allocated memory region with ib_umem_get(). Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> -- drivers/infiniband/core/umem.c | 15 +---

[PATCH 3/4] IB: add dmabarrier to ib_umem_get() prototype

2008-01-29 Thread akepner
Add a new parameter, dmabarrier, to the ib_umem_get() prototype. Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> -- drivers/infiniband/core/umem.c |2 +- drivers/infiniband/hw/amso1100/c2_provider.c |2 +- drivers/infiniband/hw/cxgb3/iwch_provider.c |2 +-

Re: Mostly revert "e1000/e1000e: Move PCI-Express device IDs over to e1000e"

2008-01-29 Thread Linus Torvalds
On Wed, 30 Jan 2008, Linus Torvalds wrote: > > Untested, but as mentioned, this is more of a "this looks maintainable and > like it should solve the issues" rather than anything I was planning on > committing now. Side note: I "verified" this patch by also diffing it against the HEAD^ state

[PATCH 2/4] dma/ia64: update ia64 machvecs

2008-01-29 Thread akepner
Change all ia64 machvecs to use the new dma_{un}map_*_attrs() interfaces. Implement the old dma_{un}map_*() interfaces in terms of the corresponding new interfaces. For ia64/sn, make use of one dma attribute, DMA_ATTR_BARRIER. Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> --

Re: Mostly revert "e1000/e1000e: Move PCI-Express device IDs over to e1000e"

2008-01-29 Thread Linus Torvalds
On Tue, 29 Jan 2008, Randy Dunlap wrote: > > Andrew was concerned about this when the driver was in -mm. > He asked for a patch that would set E1000E to same value as E1000 > and I supplied that. Auke acked it IIRC. Other people vetoed it. :( Yeah, I've been discussing with Jeff and the

[PATCH 0/4] dma: dma_{un}map_{single|sg}_attrs() interface

2008-01-29 Thread akepner
Introduce a new interface for passing architecture-specific attributes when memory is mapped and unmapped for DMA. Give the interface a default implementation which ignores attributes. Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> -- dma-mapping.h | 33

[PATCH 1/4] dma: document dma_{un}map_{single|sg}_attrs() interface

2008-01-29 Thread akepner
Document the new dma_{un}map_{single|sg}_attrs() functions. Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> -- DMA-API.txt | 63 1 files changed, 63 insertions(+) diff --git a/Documentation/DMA-API.txt

Re: [WARNING -rc8] at fs/sysfs/dir.c:424 sysfs_add_one(), related with processor (ACPI)

2008-01-29 Thread Dave Young
On Jan 25, 2008 9:27 AM, Dave Young <[EMAIL PROTECTED]> wrote: > > On Jan 25, 2008 12:32 AM, Miguel Ojeda <[EMAIL PROTECTED]> wrote: > > > > On Jan 24, 2008 2:44 AM, Dave Young <[EMAIL PROTECTED]> wrote: > > > > > > On Wed, Jan 23, 2008 at 02:06:43PM -0800, Andrew Morton wrote: > > > > > On Mon,

Re: ndiswrapper and GPL-only symbols redux

2008-01-29 Thread Zan Lynx
Jon Masters wrote: I wouldn't quite say that. I wasn't going to comment, but...personally, I actually disagree with the assertions that ndiswrapper isn't causing proprietary code to link against GPL functions in the kernel (how is an NDIS implementation any different than a shim layer provided

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

2008-01-29 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 09:11:36AM +0530, Kamalesh Babulal wrote: > Hi, > > The 2.6.24-git6 kernel build fails on various x86_64 machines with the build > failure > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict > make[2]: *** [drivers/net/sis190.o] Error 1 >

Re: ndiswrapper and GPL-only symbols redux

2008-01-29 Thread Pavel Roskin
On Wed, 2008-01-30 at 05:07 +, Jon Masters wrote: > *). Add a new taint? > *). Move it later? > > It's all trivial, but a policy should be established for the future. I'd prefer a new taint. It's less likely to break. It provides more information in the stack dumps. It makes it clear the

Re: Mostly revert "e1000/e1000e: Move PCI-Express device IDs over to e1000e"

2008-01-29 Thread Randy Dunlap
On Tue, 29 Jan 2008 23:59:37 GMT Linux Kernel Mailing List wrote: > Gitweb: > http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5b10ca19ea4859d3884d10a3eb8495de92089792 > Commit: 5b10ca19ea4859d3884d10a3eb8495de92089792 > Parent:

[RFC] Proportional bandwidth scheduling using anticipatory I/O scheduler on 2.6.24

2008-01-29 Thread Naveen Gupta
This patch creates channels in anticipatory I/O scheduler for sharing bandwidth in specified proportions. It uses the ioprio_(get/set) interface to create various channels and as of now it is using the best effort levels. It is an initial attempt to get proportional b/w working in I/O schedulers.

Re: [PATCH] add support for dynamic ticks and preempt rcu

2008-01-29 Thread Paul E. McKenney
On Tue, Jan 29, 2008 at 11:18:12AM -0500, Steven Rostedt wrote: > > [ > Paul, you had your Signed-off-by in the RT patch, so I attached it here > too > ] Works for me!!! > The PREEMPT-RCU can get stuck if a CPU goes idle and NO_HZ is set. The > idle CPU will not progress the RCU through its

Re: [PATCH powerpc] Fake NUMA emulation for PowerPC (Take 3)

2008-01-29 Thread Balbir Singh
* Michael Ellerman <[EMAIL PROTECTED]> [2008-01-30 00:04:58]: > Why do you check !p after assigning to nid? I assume it's because we > might have reached the end of the command line, ie. p == NULL, but we're > still adding memory to the last node? If so it's a it's a little subtle > and deserves

Change In sk_buff structure in 2.6.22 kernel

2008-01-29 Thread PV Juliet
Hi All, The header fields in the sk_buff structure have been renamed and are no longer unions. Networking code and drivers are supposed to use skb->transport_header, skb->network_header, and skb->skb_mac_header. But when I am trying to access fields of TCP using the code struct tcphdr *tcp =

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-01-29 Thread Borislav Petkov
On Wed, Jan 30, 2008 at 06:03:47AM +0100, Borislav Petkov wrote: > On Wed, Jan 30, 2008 at 12:58:33AM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Wednesday 30 January 2008, Kiyoshi Ueda wrote: > > > Hi Bart, > > > > > > On Tue, 29 Jan 2008 14:22:53 -0800, Roland Dreier

Re: [PATCH retry] bluetooth : add conn add/del workqueues to avoid connection fail

2008-01-29 Thread David Miller
From: Dave Young <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 10:23:54 +0800 > > The bluetooth hci_conn sysfs add/del executed in the default workqueue. > If the del_conn is executed after the new add_conn with same target, > add_conn will failed with warning of "same kobject name". > > Here add

Re: ndiswrapper and GPL-only symbols redux

2008-01-29 Thread Jon Masters
On Wed, Jan 30, 2008 at 04:24:50AM +0100, Andi Kleen wrote: > Pavel Roskin <[EMAIL PROTECTED]> writes: > > > > static inline void add_taint_module(struct module *mod, unsigned flag) > > { > > add_taint(flag); > > mod->taints |= flag; > > } > > > > The module taint is set before the

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-01-29 Thread Borislav Petkov
On Wed, Jan 30, 2008 at 12:58:33AM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday 30 January 2008, Kiyoshi Ueda wrote: > > Hi Bart, > > > > On Tue, 29 Jan 2008 14:22:53 -0800, Roland Dreier wrote: > > > Hi, I saw the same BUG from ide-cd on one of my systems. I applied > > >

Re: ndiswrapper and GPL-only symbols redux

2008-01-29 Thread Jon Masters
On Tue, Jan 29, 2008 at 08:48:21PM -0500, Pavel Roskin wrote: > On Tue, 2008-01-29 at 19:20 -0500, Jon Masters wrote: > > > Yes it is. But I thought the existing code was intending to taint the > > kernel (that's what it does), so it would really help to identify why it > > tainted the kernel, by

Re: [PATCH] fix tasklist + find_pid() with CONFIG_PREEMPT_RCU

2008-01-29 Thread Paul E. McKenney
On Tue, Jan 29, 2008 at 08:24:17PM -0700, Eric W. Biederman wrote: > Oleg Nesterov <[EMAIL PROTECTED]> writes: > > > With CONFIG_PREEMPT_RCU read_lock(tasklist_lock) doesn't imply > > rcu_read_lock(), > > but find_pid_ns()->hlist_for_each_entry_rcu() should be safe under tasklist. > > > >

Re: [PATCH] fix tasklist + find_pid() with CONFIG_PREEMPT_RCU

2008-01-29 Thread Paul E. McKenney
On Tue, Jan 29, 2008 at 07:16:50PM -0700, Eric W. Biederman wrote: > Andrew Morton <[EMAIL PROTECTED]> writes: > > > On Tue, 29 Jan 2008 19:40:19 +0300 > > Oleg Nesterov <[EMAIL PROTECTED]> wrote: > > > >> With CONFIG_PREEMPT_RCU read_lock(tasklist_lock) doesn't imply > > rcu_read_lock(), > >>

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

2008-01-29 Thread Gabriel C
Kamalesh Babulal wrote: > Hi, > > The 2.6.24-git6 kernel build fails on various x86_64 machines with the build > failure > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict > make[2]: *** [drivers/net/sis190.o] Error 1 > > # gcc --version (machine1) > gcc (GCC)

Re: [PATCH 0/3][RFC] x86: Catch stray non-kprobe breakpoints

2008-01-29 Thread Ananth N Mavinakayanahalli
On Tue, Jan 29, 2008 at 02:29:41PM -0500, Masami Hiramatsu wrote: > Abhishek Sagar wrote: > > On 1/29/08, Masami Hiramatsu <[EMAIL PROTECTED]> wrote: > >> In that case, why don't you just reduce the priority of > >> kprobe_exceptions_nb? > >> Then, the execution path becomes very simple. > > > >

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-29 Thread Matthew Wilcox
On Tue, Jan 29, 2008 at 05:19:55AM -0800, Greg KH wrote: > On Mon, Jan 28, 2008 at 08:18:04PM -0700, Matthew Wilcox wrote: > > I'm more optimistic because we've so severely restricted the use of > > mmconf after these patches that it's unlikely to cause problems. I also > > hear Vista is now

Re: at91sam9260 wakeup on serial port

2008-01-29 Thread David Brownell
On Monday 28 January 2008, Haavard Skinnemoen wrote: > > > What will AVR32 (AP7) need to do, when it supports system sleep states? > > Not sure. The PIOs seem to require a clock in order to detect a pin > change, so I don't think we can enter very deep sleep states if we want > to be woken up by

[BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

2008-01-29 Thread Kamalesh Babulal
Hi, The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190.o] Error 1 # gcc --version (machine1) gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52) # gcc

Re: [Xen-devel] dm-band: The I/O bandwidth controller: Performance Report

2008-01-29 Thread Ryo Tsuruta
Hi, > you mean that you run 128 processes on each user-device pairs? Namely, > I guess that > > user1: 128 processes on sdb5, > user2: 128 processes on sdb5, > another: 128 processes on sdb5, > user2: 128 processes on sdb6. "User-device pairs" means "band groups", right? What I

Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-29 Thread David Howells
Chuck Lever <[EMAIL PROTECTED]> wrote: > This patch really ought to be broken into more manageable atomic > changes to make it easier to review, and to provide more fine-grained > explanation and rationalization for each specific change via > individual patch descriptions. Hmmm I broke the

Re: [PATCH] fix tasklist + find_pid() with CONFIG_PREEMPT_RCU

2008-01-29 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > With CONFIG_PREEMPT_RCU read_lock(tasklist_lock) doesn't imply > rcu_read_lock(), > but find_pid_ns()->hlist_for_each_entry_rcu() should be safe under tasklist. > > Usually it is, detach_pid() is always called under write_lock(tasklist_lock), > but

Re: [patch 05/19] split LRU lists into anon & file sets

2008-01-29 Thread KOSAKI Motohiro
Hi Rik, Lee I tested new hackbench on rvr split LRU patch. http://people.redhat.com/mingo/cfs-scheduler/tools/hackbench.c method of test (1) $ ./hackbench 150 process 1000 (2) # sync; echo 3 > /proc/sys/vm/drop_caches $ dd if=tmp10G of=/dev/null $ ./hackbench 150 process 1000 test

[PATCH 2/2] x86_64: make bootmap_start page align v3

2008-01-29 Thread Yinghai Lu
[PATCH 2/2] x86_64: make bootmap_start page align v3 boot oops when system get 64g or 128 installed Calling initcall 0x80bc33b6: sctp_init+0x0/0x711() BUG: unable to handle kernel NULL pointer dereference at 005f IP: [] proc_register+0xe7/0x10f PGD 0 Oops: [1] SMP CPU 0

Re: ndiswrapper and GPL-only symbols redux

2008-01-29 Thread Andi Kleen
Pavel Roskin <[EMAIL PROTECTED]> writes: > > static inline void add_taint_module(struct module *mod, unsigned flag) > { > add_taint(flag); > mod->taints |= flag; > } > > The module taint is set before the symbols are resolved. Therefore, the > GPL-only symbols won't be resolved.

[PATCH 18/22 -v7] Trace irq disabled critical timings

2008-01-29 Thread Steven Rostedt
This patch adds latency tracing for critical timings (how long interrupts are disabled for). "irqsoff" is added to /debugfs/tracing/available_tracers Note: tracing_max_latency also holds the max latency for irqsoff (in usecs). (default to large number so one must start latency tracing)

[PATCH 06/22 -v7] handle accurate time keeping over long delays

2008-01-29 Thread Steven Rostedt
Handle accurate time even if there's a long delay between accumulated clock cycles. Signed-off-by: John Stultz <[EMAIL PROTECTED]> Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- arch/powerpc/kernel/time.c|3 +- arch/x86/kernel/vsyscall_64.c |5 ++- include/asm-x86/vgtod.h

[PATCH 13/22 -v7] Add tracing of context switches

2008-01-29 Thread Steven Rostedt
This patch adds context switch tracing, of the format of: _--=> CPU# / _-=> irqs-off | / _=> need-resched || / _---=> hardirq/softirq ||| / _--=> preempt-depth

[PATCH 09/22 -v7] add notrace annotations to timing events

2008-01-29 Thread Steven Rostedt
This patch adds notrace annotations to timer functions that will be used by tracing. This helps speed things up and also keeps the ugliness of printing these functions down. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- arch/x86/kernel/apic_32.c |2 +- arch/x86/kernel/hpet.c

[PATCH 16/22 -v7] Add marker in try_to_wake_up

2008-01-29 Thread Steven Rostedt
Add markers into the wakeup code, to allow the tracer to record wakeup timings. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- kernel/sched.c |8 1 file changed, 8 insertions(+) Index: linux-mcount.git/kernel/sched.c

[PATCH 03/22 -v7] Annotate core code that should not be traced

2008-01-29 Thread Steven Rostedt
Mark with "notrace" functions in core code that should not be traced. The "notrace" attribute will prevent gcc from adding a call to mcount on the annotated funtions. Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> ---

[PATCH 17/22 -v7] mcount tracer for wakeup latency timings.

2008-01-29 Thread Steven Rostedt
This patch adds hooks to trace the wake up latency of the highest priority waking task. "wakeup" is added to /debugfs/tracing/available_tracers Also added to /debugfs/tracing tracing_max_latency holds the current max latency for the wakeup wakeup_thresh if set to other than

[PATCH 14/22 -v7] Generic command line storage

2008-01-29 Thread Steven Rostedt
Saving the comm of tasks for each trace is very expensive. This patch includes in the context switch hook, a way to store the last 100 command lines of tasks. This table is examined when a trace is to be printed. Note: The comm may be destroyed if other traces are performed. Later (TBD) patches

[PATCH 05/22 -v7] add notrace annotations to vsyscall.

2008-01-29 Thread Steven Rostedt
Add the notrace annotations to some of the vsyscall functions. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- arch/x86/kernel/vsyscall_64.c |3 ++- arch/x86/vdso/vclock_gettime.c | 15 --- arch/x86/vdso/vgetcpu.c|3 ++- include/asm-x86/vsyscall.h |3

[PATCH 21/22 -v7] Add event tracer.

2008-01-29 Thread Steven Rostedt
This patch adds a event trace that hooks into various events in the kernel. Although it can be used separately, it is mainly to help other traces (wakeup and preempt off) with seeing various events in the traces without having to enable the heavy mcount hooks. Signed-off-by: Steven Rostedt

[PATCH 04/22 -v7] x86_64: notrace annotations

2008-01-29 Thread Steven Rostedt
Add "notrace" annotation to x86_64 specific files. Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- arch/x86/kernel/head64.c |2 +- arch/x86/kernel/setup64.c|4 ++-- arch/x86/kernel/smpboot_64.c |2 +- 3 files

[PATCH 00/22 -v7] mcount and latency tracing utility -v7

2008-01-29 Thread Steven Rostedt
[ version 7 (and hopefully last) of mcount / trace patches: changes include: Ported to lastest git 0ba6c33bcddc64a54b5f1c25a696c4767dc76292 Moved the markers around so they would only be armed when used, this brings down the overhead dramatically. Added printing of the "to"

[PATCH 20/22 -v7] Add markers to various events

2008-01-29 Thread Steven Rostedt
This patch adds markers to various events in the kernel. (interrupts, task activation and hrtimers) Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- arch/x86/kernel/apic_32.c |2 ++ arch/x86/kernel/irq_32.c |1 + arch/x86/kernel/irq_64.c |2 ++ arch/x86/kernel/traps_32.c |

[PATCH 12/22 -v7] Make the task State char-string visible to all

2008-01-29 Thread Steven Rostedt
The tracer wants to be able to convert the state number into a user visible character. This patch pulls that conversion string out the scheduler into the header. This way if it were to ever change, other parts of the kernel will know. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> ---

[PATCH 08/22 -v7] add get_monotonic_cycles

2008-01-29 Thread Steven Rostedt
The latency tracer needs a way to get an accurate time without grabbing any locks. Locks themselves might call the latency tracer and cause at best a slow down. This patch adds get_monotonic_cycles that returns cycles from a reliable clock source in a monotonic fashion. Signed-off-by: John

[PATCH 10/22 -v7] mcount based trace in the form of a header file library

2008-01-29 Thread Steven Rostedt
This is a simple trace that uses the mcount infrastructure. It is designed to be fast and small, and easy to use. It is useful to record things that happen over a very short period of time, and not to analyze the system in general. An interface is added to the debugfs /debugfs/tracing/ This

[PATCH 07/22 -v7] initialize the clock source to jiffies clock.

2008-01-29 Thread Steven Rostedt
The latency tracer can call clocksource_read very early in bootup and before the clock source variable has been initialized. This results in a crash at boot up (even before earlyprintk is initialized). Since the clock->read variable points to NULL. This patch simply initializes the clock to use

[PATCH 11/22 -v7] Add context switch marker to sched.c

2008-01-29 Thread Steven Rostedt
Add marker into context_switch to record the prev and next tasks. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- kernel/sched.c |2 ++ 1 file changed, 2 insertions(+) Index: linux-mcount.git/kernel/sched.c === ---

[PATCH 19/22 -v7] trace preempt off critical timings

2008-01-29 Thread Steven Rostedt
Add preempt off timings. A lot of kernel core code is taken from the RT patch latency trace that was written by Ingo Molnar. This adds "preemptoff" and "preemptirqsoff" to /debugfs/tracing/available_tracers Now instead of just tracing irqs off, preemption off can be selected to be recorded.

[PATCH 22/22 -v7] Critical latency timings histogram

2008-01-29 Thread Steven Rostedt
This patch adds hooks into the latency tracer to give us histograms of interrupts off, preemption off and wakeup timings. This code was based off of work done by Yi Yang <[EMAIL PROTECTED]> But heavily modified to work with the new tracer, and some clean ups by Steven Rostedt <[EMAIL PROTECTED]>

[PATCH 02/22 -v7] Add basic support for gcc profiler instrumentation

2008-01-29 Thread Steven Rostedt
If CONFIG_MCOUNT is selected and /proc/sys/kernel/mcount_enabled is set to a non-zero value the mcount routine will be called everytime we enter a kernel function that is not marked with the "notrace" attribute. The mcount routine will then call a registered function if a function happens to be

[PATCH 01/22 -v7] printk - dont wakeup klogd with interrupts disabled

2008-01-29 Thread Steven Rostedt
[ This patch is added to the series since the wakeup timings trace may lockup without it. ] I thought that one could place a printk anywhere without worrying. But it seems that it is not wise to place a printk where the runqueue lock is held. I just spent two hours debugging why some of my

[PATCH 15/22 -v7] trace generic call to schedule switch

2008-01-29 Thread Steven Rostedt
This patch adds hooks into the schedule switch tracing to allow other latency traces to hook into the schedule switches. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- lib/tracing/trace_sched_switch.c | 123 +-- lib/tracing/tracer.h | 14

Re: [PATCH 4/4] x86_64: increse MAX_EARLY_RES for NODE_DATA and bootmap

2008-01-29 Thread Yinghai Lu
On Tuesday 29 January 2008 06:57:54 pm Andi Kleen wrote: > On Tuesday 29 January 2008 20:16, Yinghai Lu wrote: > > [PATCH 4/4] x86_64: increse MAX_EARLY_RES for NODE_DATA and bootmap > > > > otherise early_node_mem will use up these for 8 nodes system > > Yes this was the problem with my

Re: [PATCH 2/2] x86_64: make early_node_mem return align address

2008-01-29 Thread Yinghai Lu
On Tuesday 29 January 2008 06:55:45 pm Andi Kleen wrote: > On Tuesday 29 January 2008 18:41, Yinghai Lu wrote: > > On Tuesday 29 January 2008 01:33:29 am Andi Kleen wrote: > > > On Tuesday 29 January 2008 10:05, Yinghai Lu wrote: > > > > [PATCH 2/2] x86_64: make early_node_mem return align address

Re: [PATCH 2.6.24] x86: add sysfs interface for cpuid module

2008-01-29 Thread Yi Yang
On Tue, 2008-01-29 at 07:51 -0800, H. Peter Anvin wrote: > Yi Yang wrote: > > Current cpuid module will create a char device for every logical cpu, > > when a user cats /dev/cpu/*/cpuid, he/she will enter a limitless loop, > > the root cause is that cpuid module doesn't decide wether a cpuid level

Re: [PATCH] Fix NUMA emulation for x86_64

2008-01-29 Thread Minoru Usui
> ">" == Ingo Molnar <[EMAIL PROTECTED]> writes: >> * Minoru Usui <[EMAIL PROTECTED]> wrote: >> I found a small bug of NUMA emulation code for x86_64. >> (CONFIG_NUMA_EMU) If machine is non-NUMA, find_node_by_addr() should >> return NUMA_NO_NODE, but current implementation

Re: [PATCH 2/2] x86_64: make early_node_mem return align address

2008-01-29 Thread Andi Kleen
On Tuesday 29 January 2008 18:41, Yinghai Lu wrote: > On Tuesday 29 January 2008 01:33:29 am Andi Kleen wrote: > > On Tuesday 29 January 2008 10:05, Yinghai Lu wrote: > > > [PATCH 2/2] x86_64: make early_node_mem return align address > > > > > > boot oops when system get 64g or 128g installed > >

Re: [PATCH 4/4] x86_64: increse MAX_EARLY_RES for NODE_DATA and bootmap

2008-01-29 Thread Andi Kleen
On Tuesday 29 January 2008 20:16, Yinghai Lu wrote: > [PATCH 4/4] x86_64: increse MAX_EARLY_RES for NODE_DATA and bootmap > > otherise early_node_mem will use up these for 8 nodes system Yes this was the problem with my early_reserve node bootmem patch. It adds a node limit. But even with

Re: [PATCH] sata_nv: fix for completion handling

2008-01-29 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: This patch is based on an original patch from Kuan Luo of NVIDIA, posted under subject "fixed a bug of adma in rhel4u5 with HDS7250SASUN500G". His description follows. I've reworked it a bit to avoid some unnecessary repeated checks but it should be

RE: SATA DOM is not identified by ata_piix module

2008-01-29 Thread Mao Rui
Hmm... Does anybody own this bug? Best regards, Mao Rui > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Mao Rui > Sent: Friday, January 18, 2008 2:12 PM > To: 'Alan Cox' > Cc: linux-kernel@vger.kernel.org > Subject: RE: SATA DOM is not identified

Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

2008-01-29 Thread Tony Camuso
Matthew Wilcox wrote: On Tue, Jan 29, 2008 at 07:29:51AM -0800, Arjan van de Ven wrote: Right now, that isn't a lot of people in x86 land, but your patch encumbers drivers for non-x86 archs with an additional call to access space that they've never had a problem with. lets say s/x86/x86, IA64

Re: [PATCH] x86: Add a list for custom page fault handlers.

2008-01-29 Thread Harvey Harrison
From: Pekka Paalanen <[EMAIL PROTECTED]> Provides kernel modules a way to register custom page fault handlers. On every page fault, except those handled in vmalloc_fault(), this will call a list of registered functions. The functions may handle the fault and force do_page_fault() to return

[patch 2/6] mmu_notifier: Callbacks to invalidate address ranges

2008-01-29 Thread Christoph Lameter
The invalidation of address ranges in a mm_struct needs to be performed when pages are removed or permissions etc change. Most of the VM address space changes can use the range invalidate callback. invalidate_range() is generally called with mmap_sem held but no spinlocks are active. If

Re: [PATCH 2/4] x86_64: make early_node_mem return align address v2

2008-01-29 Thread Yinghai Lu
On Tuesday 29 January 2008 11:14:48 am Yinghai Lu wrote: > [PATCH 2/4] x86_64: make early_node_mem return align address v2 > > boot oops when system get 64g or 128 installed > can you apply this updated version with others? setup_node_mem should return with PAGE_ALIGN. in setup_node_bootmem,

[patch 6/6] mmu_notifier: Add invalidate_all()

2008-01-29 Thread Christoph Lameter
when a task exits we can remove all external pts at once. At that point the extern mmu may also unregister itself from the mmu notifier chain to avoid future calls. Note the complications because of RCU. Other processors may not see that the notifier was unlinked until a quiescent period has

[patch 4/6] MMU notifier: invalidate_page callbacks using Linux rmaps

2008-01-29 Thread Christoph Lameter
These notifiers here use the Linux rmaps to perform the callbacks. In order to walk the rmaps locks must be held. Callbacks can therefore only operate in an atomic context. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- mm/rmap.c | 12 +--- 1 file changed, 9 insertions(+), 3

[patch 0/6] [RFC] MMU Notifiers V3

2008-01-29 Thread Christoph Lameter
This is a patchset implementing MMU notifier callbacks based on Andrea's earlier work. These are needed if Linux pages are referenced from something else than tracked by the rmaps of the kernel. The known immediate users are KVM (establishes a refcount to the page. External references called

[patch 3/6] mmu_notifier: invalidate_page callbacks for subsystems with rmap

2008-01-29 Thread Christoph Lameter
Callbacks to remove individual pages if the subsystem has an rmap capability. The pagelock is held but no spinlocks are held. The refcount of the page is elevated so that dropping the refcount in the subsystem will not directly free the page. The callbacks occur after the Linux rmaps have been

  1   2   3   4   5   6   7   8   9   10   >