[PATCH] Avoid divides in BITS_TO_LONGS

2008-02-06 Thread Eric Dumazet
BITS_PER_LONG is a signed value (32 or 64) DIV_ROUND_UP(nr, BITS_PER_LONG) performs signed arithmetic if "nr" is signed too. Converting BITS_TO_LONGS(nr) to DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(long)) makes sure compiler can perform a right shift, even if "nr" is a signed value, instead of

Re: [PATCH 1/3] KGDB: Major refactoring

2008-02-06 Thread Jan Kiszka
Jason Wessel wrote: > Ingo Molnar wrote: >> * Jan Kiszka <[EMAIL PROTECTED]> wrote: >> >> >>> As most changes are tightly coupled, this refactoring patch for >>> KGDB_8250 as well as the core and the new KGDBOC driver comes as a >>> single chunk. The changes are: >>> - Reorganized

[PATCH] KGDB-8250: fix initial interrupt

2008-02-06 Thread Jan Kiszka
Latest rework of kgdb8250_interrupt caused a regression in that the new code wrongly assumes a ctrl-c character is also sent on initial connect from the host. Here is a fix. Signed-off-by: Jan Kiszka <[EMAIL PROTECTED]> --- drivers/serial/8250_kgdb.c |6 +++--- 1 file changed, 3

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 11:33:39PM -0800, David Miller wrote: > From: Greg KH <[EMAIL PROTECTED]> > Date: Wed, 6 Feb 2008 23:18:07 -0800 > > > How about this attempt? > > That works, thanks. Please push to Linus :-) > > Acked-by: David S. Miller <[EMAIL PROTECTED]> Great, thanks for testing,

[PATCH] KGDB: kconfig polishing

2008-02-06 Thread Jan Kiszka
Just for the sake of cleanness. Signed-off-by: Jan Kiszka <[EMAIL PROTECTED]> --- lib/Kconfig.kgdb |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/lib/Kconfig.kgdb === --- a/lib/Kconfig.kgdb +++

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 11:24:51PM -0800, David Miller wrote: > From: Greg KH <[EMAIL PROTECTED]> > Date: Wed, 6 Feb 2008 23:20:30 -0800 > > > It's odd that the original one didn't also do that, > > In the old code it would vector through part_sysfs_ops (look at how it > works before the

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 23:18:07 -0800 > How about this attempt? That works, thanks. Please push to Linus :-) Acked-by: David S. Miller <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[PATCH][Regression] x86, 32-bit: trim memory not covered by wb mtrrs - FIX

2008-02-06 Thread Balaji Rao
Hello, The following commit caused my X server to stop working. commit 99fc8d424bc5d803fe92cad56c068fe64e73747a Author: Jesse Barnes <[EMAIL PROTECTED]> Date: Wed Jan 30 13:33:18 2008 +0100 x86, 32-bit: trim memory not covered by wb mtrrs This patch fixes the improper handling of

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-06 Thread Gilles Espinasse
- Original Message - From: "Jan Engelhardt" <[EMAIL PROTECTED]> To: "Gilles Espinasse" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]>; Sent: Wednesday, February 06, 2008 10:14 PM Subject: RE: [PATCH] USB: mark USB drivers as being GPL only > > On Feb 1 2008 15:45, Gilles Espinasse wrote:

[PATCH] fix typo "goot" -> "good"

2008-02-06 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König <[EMAIL PROTECTED]> --- Hello, ups, I made a typo myself, how embarrassing. Sorry for getting this patch twice. Best regards Uwe scripts/checkpatch.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/checkpatch.pl

Re: blackfin compile error

2008-02-06 Thread Bryan Wu
On Feb 7, 2008 3:37 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 6 Feb 2008 14:12:50 -0500 > Robin Getz <[EMAIL PROTECTED]> wrote: > > > On Wed 6 Feb 2008 11:23, Matt Mackall pondered: > > > > > > On Wed, 2008-02-06 at 17:18 +0200, Adrian Bunk wrote: > > > > Commit

Re: [stable] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 11:18:50PM -0200, Henrique de Moraes Holschuh wrote: > On Thu, 07 Feb 2008, Roel Kluin wrote: > > It's a oneliner and the patch is from linus' tree. > > Roel, better to just let me and Len Brown handle it. I will add your patch > to my thinkpad-acpi queue and send it to

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-06 Thread Evgeniy Polyakov
On Wed, Feb 06, 2008 at 10:30:24AM -0800, Glenn Griffin ([EMAIL PROTECTED]) wrote: > > > +static u32 cookie_hash(struct in6_addr *saddr, struct in6_addr *daddr, > > > +__be16 sport, __be16 dport, u32 count, int c) > > > +{ > > > + __u32 tmp[16 + 5 + SHA_WORKSPACE_WORDS]; > > > >

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 23:20:30 -0800 > It's odd that the original one didn't also do that, In the old code it would vector through part_sysfs_ops (look at how it works before the changeset), which returns 0 if the attribute lacked a ->show method. -- To

Re: [PATCH] x86_64: fix page table size

2008-02-06 Thread Andi Kleen
Yinghai Lu <[EMAIL PROTECTED]> writes: > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index eb376b5..31f0e82 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -370,7 +370,7 @@ static void __init find_early_table_space(unsigned long > end) > > puds =

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 11:11:44PM -0800, David Miller wrote: > From: Greg KH <[EMAIL PROTECTED]> > Date: Wed, 6 Feb 2008 23:00:44 -0800 > > > On Wed, Feb 06, 2008 at 10:39:44PM -0800, David Miller wrote: > > > From: Greg KH <[EMAIL PROTECTED]> > > > Date: Wed, 6 Feb 2008 22:42:10 -0800 > > > >

Re: [PATCH/HP7XX] - Add combined LCD / BL driver for platform HP Jornada 7xx handhelds

2008-02-06 Thread Uwe Kleine-König
Hello Russell, > > Doh, right. Do you use a different checkpatch? I mean it doesn't react on > > that for me. > > No, all of the comments I've given were spotted by merely reading the patch. May I ask how you spot tab vs. 8 space problems? Do you apply the patch and check in an editor? Best

Re: [PATCH 1/3] x86: sparse warning in cpufreq/powernow-k8.c

2008-02-06 Thread Harvey Harrison
On Wed, 2008-02-06 at 23:35 -0500, Dave Jones wrote: > On Wed, Feb 06, 2008 at 04:07:47PM -0800, Harvey Harrison wrote: > > Nested per_cpu accessors will shadow the internal __ptr variable. Use > > a temporary first_core variable. > > > > arch/x86/kernel/cpu/cpufreq/powernow-k8.c:1239:9:

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 11:11:44PM -0800, David Miller wrote: > From: Greg KH <[EMAIL PROTECTED]> > Date: Wed, 6 Feb 2008 23:00:44 -0800 > > > On Wed, Feb 06, 2008 at 10:39:44PM -0800, David Miller wrote: > > > From: Greg KH <[EMAIL PROTECTED]> > > > Date: Wed, 6 Feb 2008 22:42:10 -0800 > > > >

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 23:00:44 -0800 > On Wed, Feb 06, 2008 at 10:39:44PM -0800, David Miller wrote: > > From: Greg KH <[EMAIL PROTECTED]> > > Date: Wed, 6 Feb 2008 22:42:10 -0800 > > > > > On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote: > > > > I

[PATCH] fix type "goot" -> "good"

2008-02-06 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König <[EMAIL PROTECTED]> --- scripts/checkpatch.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 579f50f..35bb5a1 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1373,7

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 10:39:44PM -0800, David Miller wrote: > From: Greg KH <[EMAIL PROTECTED]> > Date: Wed, 6 Feb 2008 22:42:10 -0800 > > > On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote: > > > I found the problem, it's the "whole_disk" partition attribute. > > > > I don't

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 10:39:44PM -0800, David Miller wrote: > From: Greg KH <[EMAIL PROTECTED]> > Date: Wed, 6 Feb 2008 22:42:10 -0800 > > > On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote: > > > I found the problem, it's the "whole_disk" partition attribute. > > > > I don't

Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread David Rientjes
On Thu, 7 Feb 2008, Sven Wegener wrote: > Negative values will be converted to MAX_JIFFY_OFFSET by msecs_to_jiffies and > result in a very long interval. A too long interval will be a good way to get > your system OOM. We could use an unsigned int or even restrict the value with >

Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-06 Thread Greg KH
On Thu, Feb 07, 2008 at 12:43:09AM +0100, Ingo Molnar wrote: > > * Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > I don't see this in Linus's tree, am I just missing it? Do you have > > > a git commit id? > > > > Isn't this 9d55b9923a1b7ea8193b8875c57ec940dc2ff027 (possibly with > >

[PATCH] Fix powerpc vdso clock_getres().

2008-02-06 Thread Tony Breeds
Since implementing highres timers on powerpc the clock_getres syscall has reported different resolutions due to the vdso using the a low res value. In the patch d7f71674ad7c3c4467e48f6ab9e85516dae2720 ([POWERPC] Use a sensible default for clock_getres() in the VDSO), the powerpc vdso was updated

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 22:44:07 -0800 > On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote: > > From: Greg KH <[EMAIL PROTECTED]> > > Date: Wed, 6 Feb 2008 21:47:38 -0800 > > > > > On Wed, Feb 06, 2008 at 08:06:18PM -0800, David Miller wrote: > > > > I

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 22:42:10 -0800 > On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote: > > I found the problem, it's the "whole_disk" partition attribute. > > I don't understand that code at all, on 2.6.24, what does reading that > file give you?

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote: > From: Greg KH <[EMAIL PROTECTED]> > Date: Wed, 6 Feb 2008 21:47:38 -0800 > > > On Wed, Feb 06, 2008 at 08:06:18PM -0800, David Miller wrote: > > > I redid the bisect to make sure it absolutely was that specific > > > changeset, and

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 22:38:03 -0800 > I'm guessing that you have a partition that is the whole disk? That > would make sense why I and most others haven't seen this yet. It's an attribute used by Sun disk labels, usually it's the third partition. -- To

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote: > From: Greg KH <[EMAIL PROTECTED]> > Date: Wed, 6 Feb 2008 21:47:38 -0800 > > > On Wed, Feb 06, 2008 at 08:06:18PM -0800, David Miller wrote: > > > I redid the bisect to make sure it absolutely was that specific > > > changeset, and

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote: > From: Greg KH <[EMAIL PROTECTED]> > Date: Wed, 6 Feb 2008 21:47:38 -0800 > > > On Wed, Feb 06, 2008 at 08:06:18PM -0800, David Miller wrote: > > > I redid the bisect to make sure it absolutely was that specific > > > changeset, and

Re: [linux-pm] Re: Small pm documentation cleanups

2008-02-06 Thread Len Brown
applied (with nigel's last comment included) thanks, -len On Wednesday 06 February 2008 16:27, Nigel Cunningham wrote: > Hi again. > > Pavel Machek wrote: > > Hi! > > > >>> On Tuesday, 5 of February 2008, Pavel Machek wrote: > Small documentation fixes/additions that accumulated in my

Re: [git pull] drm patches for 2.6.25

2008-02-06 Thread Jesse Barnes
On Wednesday, February 06, 2008 9:37 pm Dave Airlie wrote: > Hi Linus, > > Please pull the 'drm-patches' branch from > ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git > drm-patches > > Sorry this is so late, after much talking at LCA we decided to pull TTM > from this round

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-06 Thread Pekka Enberg
Hi Christer, On Tue, 5 Feb 2008 13:46:08 +0200 "Pekka Enberg" <[EMAIL PROTECTED]> wrote: > > What makes you qualified to make that statement (without giving any > > evidence)? Are you're an expert on international copyright law? On Feb 6, 2008 11:12 PM, Christer Weinigel <[EMAIL PROTECTED]>

[PATCH 16/16] dlm: add __init and __exit marks to init and exit functions

2008-02-06 Thread David Teigland
From: Denis Cheng <[EMAIL PROTECTED]> it moves 365 bytes from .text to .init.text, and 30 bytes from .text to .exit.text, saves memory. Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/config.c|2 +- fs/dlm/debug_fs.c |2 +-

Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-06 Thread Len Brown
Applied. thanks, -Len On Monday 04 February 2008 18:24, Roel Kluin wrote: > Roland Dreier wrote: > > > /* safety net should the EC not support AUTO > > > * or FULLSPEED mode bits and just ignore them */ > > > if (level & TP_EC_FAN_FULLSPEED) >

[PATCH 15/16] dlm: eliminate astparam type casting

2008-02-06 Thread David Teigland
Put lkb_astparam in a union with a dlm_user_args pointer to eliminate a lot of type casting. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/debug_fs.c |6 ++ fs/dlm/dlm_internal.h |5 - fs/dlm/lock.c | 14 ++ fs/dlm/memory.c |2 +-

[PATCH 14/16] dlm: proper types for asts and basts

2008-02-06 Thread David Teigland
Use proper types for ast and bast functions, and use consistent type for ast param. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/ast.c |9 +++ fs/dlm/dlm_internal.h | 14 +--- fs/dlm/lock.c | 50 +++-

[PATCH 12/16] dlm: fix dlm_dir_lookup() handling of too long names

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> ... those can happen and BUG() from DLM_ASSERT() in allocate_direntry() is not a good way to handle them. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dir.c |3 +++ 1 files changed, 3 insertions(+),

[PATCH 11/16] dlm: fix overflows when copying from ->m_extra to lvb

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 6d98cf9..5b82187 100644 ---

[PATCH 09/16] dlm: receive_rcom_lock_args() overflow check

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 6c605fc..0593dd8 100644 ---

[PATCH 10/16] dlm: make find_rsb() fail gracefully when namelen is too large

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> We *can* get there from receive_request() and dlm_recover_master_copy() with namelen too large if incoming request is invalid; BUG() from DLM_ASSERT() in allocate_rsb() is a bit excessive reaction to that and in case of dlm_recover_master_copy() we would actually

[PATCH 05/16] dlm: use proper type for ->ls_recover_buf

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dir.c |2 +- fs/dlm/dlm_internal.h |2 +- fs/dlm/rcom.c | 11 ++- fs/dlm/recover.c |4 ++-- 4 files changed, 10

[PATCH 01/16] dlm: use proper C for dlm/requestqueue stuff (and fix alignment bug)

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> a) don't cast the pointer to dlm_header *, we use it as dlm_message * anyway. b) we copy the message into a queue element, then pass the pointer to copy to dlm_receive_message_saved(); declare it properly to make sure that we have the right alignment.

[PATCH 08/16] dlm: verify that places expecting rcom_lock have packet long enough

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |3 +++ fs/dlm/rcom.c | 12 +++- 2 files changed, 14 insertions(+), 1 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index

[PATCH 06/16] dlm: missing length check in check_config()

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/rcom.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/fs/dlm/rcom.c b/fs/dlm/rcom.c index 3f9b96f..a312f1d 100644 ---

[PATCH 13/16] dlm: dlm/user.c input validation fixes

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> a) in device_write(): add sentinel NUL byte, making sure that lspace.name will be NUL-terminated b) in compat_input() be keep it simple about the amounts of data we are copying. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL

[PATCH 03/16] dlm: do not byteswap rcom_lock

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dlm_internal.h | 22 +++--- fs/dlm/lock.c | 34 +++--- fs/dlm/rcom.c | 14 +++---

[PATCH 02/16] dlm: dlm_process_incoming_buffer() fixes

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> * check that length is large enough to cover the non-variable part of message or rcom resp. (after checking that it's large enough to cover the header, of course). * kill more pointless casts Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David

[PATCH 04/16] dlm: do not byteswap rcom_config

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dlm_internal.h |6 +++--- fs/dlm/rcom.c | 15 --- fs/dlm/util.c | 20 3 files changed, 11

[PATCH 07/16] dlm: validate data in dlm_recover_directory()

2008-02-06 Thread David Teigland
From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dir.c | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/fs/dlm/dir.c b/fs/dlm/dir.c index ce30136..831050e

[PATCH 00/16] dlm patches for 2.6.25 (batch 2)

2008-02-06 Thread David Teigland
This is a second batch of dlm patches that I think should be ready for 2.6.25. It's largely clean ups and minor fixes from Al Viro, and a couple more added by me after Al pointed them out. Thanks, Dave Al Viro (13): dlm: use proper C for dlm/requestqueue stuff (and fix alignment bug)

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 21:47:38 -0800 > On Wed, Feb 06, 2008 at 08:06:18PM -0800, David Miller wrote: > > I redid the bisect to make sure it absolutely was that specific > > changeset, and it is. > > Thanks for doing that, I'll let you know when I have a patch to

Re: [stable] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-06 Thread Greg KH
On Thu, Feb 07, 2008 at 12:48:24AM +0100, Roel Kluin wrote: > Greg KH wrote: > > On Tue, Feb 05, 2008 at 09:34:54AM +0100, Roel Kluin wrote: > >> Henrique de Moraes Holschuh wrote: > >>> On Tue, 05 Feb 2008, Roel Kluin wrote: > Roland Dreier wrote: > > > > Note the duplicate test 'if

Re: [git pull] CPU isolation extensions

2008-02-06 Thread Andrew Morton
On Wed, 06 Feb 2008 21:32:55 -0800 Max Krasnyansky <[EMAIL PROTECTED]> wrote: > Linus, please pull CPU isolation extensions from > > git://git.kernel.org/pub/scm/linux/kernel/git/maxk/cpuisol-2.6.git for-linus The feature as a whole seems useful, and I don't actually oppose the merge based on

Re: [PATCH] 2.4: USB: fix DoS in pwc USB video driver

2008-02-06 Thread Willy Tarreau
On Wed, Feb 06, 2008 at 07:06:18PM -0700, dann frazier wrote: > This is a 2.4 backport of a linux-2.6 change by Oliver Neukum. > (commit 85237f202d46d55c1bffe0c5b1aa3ddc0f1dce4d) That's weird, because I remember about this one I checked while working on 2.6.20-stable. For an unknown reason, I

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread Greg KH
On Wed, Feb 06, 2008 at 08:06:18PM -0800, David Miller wrote: > > Greg, I'm pretty sure I know what's happening. > > For whatever reason we're invoking dev_attr_show() on attribute_group > objects. Ugh, that makes sense. > The reason it probably only crashes on sparc64 is because perhaps at >

Re: [PATCH 12/11] sched: rt-group: uid-group interface

2008-02-06 Thread Greg KH
On Thu, Feb 07, 2008 at 09:47:22AM +0530, Dhaval Giani wrote: > On Wed, Jan 09, 2008 at 04:05:31PM -0800, Greg KH wrote: > > > > > Ingo, Greg, > > > > > > > > > > What would be the easiest way to carry this forward? sched-devel and > > > > > greg's tree would intersect at this point and leave

Re: [PATCH] [drivers/misc/asus-laptop.c] add parentheses

2008-02-06 Thread Len Brown
applied. thanks, -Len On Saturday 02 February 2008 15:07, Roel Kluin wrote: > '!' has a higher priority than '&': bitanding has no effect. > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- > diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c > index 7dce318..65c67d1

[git pull] drm patches for 2.6.25

2008-02-06 Thread Dave Airlie
Hi Linus, Please pull the 'drm-patches' branch from ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-patches Sorry this is so late, after much talking at LCA we decided to pull TTM from this round and I had to re-order a lot of things, so highlights of this bunch are

[git pull] CPU isolation extensions

2008-02-06 Thread Max Krasnyansky
Linus, please pull CPU isolation extensions from git://git.kernel.org/pub/scm/linux/kernel/git/maxk/cpuisol-2.6.git for-linus Diffstat: b/arch/x86/Kconfig |1 b/arch/x86/kernel/genapic_flat_64.c |5 ++- b/drivers/base/cpu.c| 48

[PATCH] AVR32: pass i2c board info through at32_add_device_twi

2008-02-06 Thread Ben Nizette
New-style I2C drivers require that motherboard-mounted I2C devices are registered with the I2C core, typically at arch_initcall time. This can be done nice and neat by passing the struct i2c_board_info[] through at32_add_device_twi just like we do for the SPI board info. While we've got the

Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Simon Horman
On Thu, Feb 07, 2008 at 12:57:43AM +0100, Sven Wegener wrote: > The default synchronization interval of 1000 milliseconds is too high for a > heavily loaded director. Collecting the connection information from one second > and then sending it out in a burst will overflow the socket buffer and lead

[PATCH] ext4 can fail badly when device stops accepting BIO_RW_BARRIER requests.

2008-02-06 Thread Dave Kleikamp
Duplicating Neil Brown's jbd patch for jbd2. I guess this can go through the ext4 queue rather than straight into -mm. Neil's text: Some devices - notably dm and md - can change their behaviour in response to BIO_RW_BARRIER requests. They might start out accepting such requests but on

Re: [PATCH 12/11] sched: rt-group: uid-group interface

2008-02-06 Thread Dhaval Giani
On Wed, Jan 09, 2008 at 04:05:31PM -0800, Greg KH wrote: > > > > Ingo, Greg, > > > > > > > > What would be the easiest way to carry this forward? sched-devel and > > > > greg's tree would intersect at this point and leave poor akpm with the > > > > resulting mess. Should I just make an

[PATCH] x86_64: clean up find_e820_area

2008-02-06 Thread Yinghai Lu
[PATCH] x86_64: clean up find_e820_area change size to unsigned long, becase caller and user all used unsigned long. also make bad_addr take align. Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> Index: linux-2.6/arch/x86/kernel/e820_64.c

[PATCH] x86_64: fix page table size

2008-02-06 Thread Yinghai Lu
[PATCH] x86_64: fix page table size Command line: apic=debug acpi.debug_level=0x000F debug initcall_debug pci=routeirq ramdisk_size=131072 root=/dev/ram0 rw ip=dhcp console=uart8250,io,0x3f8,115200n8 BIOS-provided physical RAM map: BIOS-e820: 0100 - 0009bc00 (usable)

Re: partition sysfs OOPS in current GIT

2008-02-06 Thread David Miller
Greg, I'm pretty sure I know what's happening. For whatever reason we're invoking dev_attr_show() on attribute_group objects. The reason it probably only crashes on sparc64 is because perhaps at that dev_attr->show offset on x86 there are zero bytes there instead of a pointer, so the NULL check

Re: where is the capset kernel module?

2008-02-06 Thread serge
Quoting Jeff Chua ([EMAIL PROTECTED]): > On Feb 6, 2008 7:40 PM, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > > >warning: `named' uses 32-bit capabilities (legacy support in use) > > Yes it is a really interesting case I have seen before, > > but did not bother to investigate. > >

Re: inotify_add_watch() returning ENOSPC in 2.6.24 [watch descriptor leak?]

2008-02-06 Thread Amy Griffis
Clem Taylor wrote: [Wed Feb 06 2008, 02:40:58PM EST] > > Good bug report, thanks. That code was significantly altered in June 2006 > > and perhaps something broke. > > I also tested on a 2.6.20 x86 desktop machine. It took ~8k iterations > to fail, which matched max_user_watches. Once the

Re: [Bugme-new] [Bug 9906] New: Weird hang with NPTL and SIGPROF.

2008-02-06 Thread Parag Warudkar
On Wed, 6 Feb 2008, Frank Mayhar wrote: > On Wed, 2008-02-06 at 16:50 -0800, Andrew Morton wrote: > > It's probably better to handle this one via email, so please send that > > testcase vie reply-to-all to this email, thanks. > > Testcase attached. > > Build with > gcc -D_GNU_SOURCE

Re: [PULL] v9fs patches for merge window

2008-02-06 Thread Andrew Morton
On Wed, 6 Feb 2008 19:39:26 -0600 "Eric Van Hensbergen" <[EMAIL PROTECTED]> wrote: Could you please cc me on pull requests? I need to pay more attention to them. Thanks. > Andrew Morton (1): > 9p: fix p9_printfcall export Really this should have been folded into the patch which it

[PATCH] kernel-doc: fix for vunmap function prototype

2008-02-06 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix kernel-doc function prototype parsing for vunmap() in -mm kernel: (but merge to mainline, please) Allow more than one '*' before the function name. Error(linux-2.6.24-mm1//mm/vmalloc.c:438): cannot understand prototype: 'struct page **vunmap(const

Re: [PATCH 1/2] - SH/Dreamcast - fix maple bus bugs

2008-02-06 Thread Paul Mundt
On Wed, Feb 06, 2008 at 10:46:21PM +, Adrian McMenamin wrote: > This patch is fundamentally about fixing up the whitespace problems > introduced by my previous patch (that brought the code into mainline). A > second patch will follow that will fix memory leaks. The two need to be > applied

Re: MM kernels 2.6.24-rc*-mm*, 2.6.24-mm1: gnome-terminal stuck in tty_poll

2008-02-06 Thread Andrew Morton
On Wed, 06 Feb 2008 20:10:50 -0600 "J. K. Cliburn" <[EMAIL PROTECTED]> wrote: > Zan Lynx wrote: > > > gnome-terminal gets stuck. > > I began seeing this very thing around 2.6.24 time. (Fedora 8, vanilla > kernel.) I could usually cause the gnome terminal to hang if I rapidly > resized the

Re: MM kernels 2.6.24-rc*-mm*, 2.6.24-mm1: gnome-terminal stuck in tty_poll

2008-02-06 Thread J. K. Cliburn
Zan Lynx wrote: gnome-terminal gets stuck. I began seeing this very thing around 2.6.24 time. (Fedora 8, vanilla kernel.) I could usually cause the gnome terminal to hang if I rapidly resized the window while executing make check-headers. Over a couple of days I bisected it down to this

Re: [PULL] v9fs patches for merge window

2008-02-06 Thread Linus Torvalds
On Wed, 6 Feb 2008, Eric Van Hensbergen wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git There seems to be a "for-linus" missing there.. With that I get the right diffstat. But please don't make me have to search around and guess.. Linus -- To

[PATCH] 2.4: USB: fix DoS in pwc USB video driver

2008-02-06 Thread dann frazier
This is a 2.4 backport of a linux-2.6 change by Oliver Neukum. (commit 85237f202d46d55c1bffe0c5b1aa3ddc0f1dce4d) CVE-2007-5093 was assigned for this issue. This backport has been compile-tested only. Commit log from 2.6 follows. the pwc driver has a disconnect method that waits for user space

[PATCH] procfs task exe symlink

2008-02-06 Thread Matt Helsley
The kernel implements readlink of /proc/pid/exe by getting the file from the first executable VMA. Then the path to the file is reconstructed and reported as the result. Because of the VMA walk the code is slightly different on nommu systems. This patch avoids separate /proc/pid/exe code on

[PATCH] 2.4: [PPPOE]: memory leak when socket is release()d before PPPIOCGCHAN has been called on it

2008-02-06 Thread dann frazier
This is a 2.4 backport of a linux-2.6 change by Florian Zumbiehl. (commit 202a03acf9994076055df40ae093a5c5474ad0bd) CVE-2007-2525 was assigned for this issue. It has been compile tested-only. Commit log from 2.6 follows. below you find a patch that fixes a memory leak when a PPPoE socket is

[PULL] v9fs patches for merge window

2008-02-06 Thread Eric Van Hensbergen
The following changes since commit 3e6bdf473f489664dac4d7511d26c7ac3dfdc748: Linus Torvalds (1): Merge git://git.kernel.org/.../x86/linux-2.6-x86 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git Andrew Morton (1): 9p: fix

Re: more iommu sg merging fallout

2008-02-06 Thread FUJITA Tomonori
On Wed, 06 Feb 2008 16:01:47 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: FUJITA Tomonori <[EMAIL PROTECTED]> > Date: Thu, 07 Feb 2008 08:53:33 +0900 > > > On Wed, 06 Feb 2008 15:18:55 -0800 (PST) > > David Miller <[EMAIL PROTECTED]> wrote: > > > > > I intend to put merging back

Re: [patch 05/19] split LRU lists into anon & file sets

2008-02-06 Thread Rik van Riel
On Thu, 07 Feb 2008 10:20:39 +0900 KOSAKI Motohiro <[EMAIL PROTECTED]> wrote: > looks good. > thank you clean up code. Yeah, it looks good. Too bad it still does not work :) Oh well, I'll look at that tomorrow. Jet lag is catching up with me, so I should get some rest first... -- All rights

RE: [PATCH] USB: mark USB drivers as being GPL only

2008-02-06 Thread David Schwartz
> IANAL, but when looking at the "But when you distribute the same > sections as part of a whole which is a work based on the Program, the > distribution of the whole must be on the terms of this License" of the > GPLv2 I would still consult a lawyer before e.g. selling a laptop with a >

Re: [PATCH], issue EOI to APIC prior to calling crash_kexec in die_nmi path

2008-02-06 Thread Eric W. Biederman
Ingo Molnar <[EMAIL PROTECTED]> writes: > * Eric W. Biederman <[EMAIL PROTECTED]> wrote: > >> Looking at the patch the local_irq_enable() is totally bogus. As soon >> was we hit machine_crash_shutdown the first thing we do is disable >> irqs. > > yeah. > >> I'm wondering if someone was using

[PATCH] ext3 can fail badly when device stops accepting BIO_RW_BARRIER requests.

2008-02-06 Thread Neil Brown
Some devices - notably dm and md - can change their behaviour in response to BIO_RW_BARRIER requests. They might start out accepting such requests but on reconfiguration, they find out that they cannot any more. ext3 (and other filesystems) deal with this by always testing if BIO_RW_BARRIER

Re: [patch 05/19] split LRU lists into anon & file sets

2008-02-06 Thread KOSAKI Motohiro
Hi Rik Welcome back :) > > I found number of scan pages calculation bug. > > My latest version of get_scan_ratio() works differently, with the > percentages always adding up to 100. However, your patch gave me > the inspiration to (hopefully) find the bug in my version of the > code. OK. >

Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-06 Thread Henrique de Moraes Holschuh
On Thu, 07 Feb 2008, Roel Kluin wrote: > It's a oneliner and the patch is from linus' tree. Roel, better to just let me and Len Brown handle it. I will add your patch to my thinkpad-acpi queue and send it to Len soon, along with other simple patches that are pending. Either I or Len will notify

Re: softlockup: automatically detect hung TASK_UNINTERRUPTIBLE tasks

2008-02-06 Thread Andrew Morton
On Thu, 7 Feb 2008 01:51:10 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > Nope. > > > > But I tested it on mainline, and mainline exhibits the > > never-powers-off symptom, whereas > > ed50d6cbc394cd0966469d3e249353c9dd1d38b9 demonstrates

Re: Access MSR functions in userspace?

2008-02-06 Thread H. Peter Anvin
Hasan Rashid wrote: I am using kernel 2.4.32. Inside msr.c it is trying to register cpu/msr as shown here. int __init msr_init(void) { if (register_chrdev(MSR_MAJOR, "cpu/msr", _fops)) { printk(KERN_ERR "msr: unable to get major %d for msr\n", MSR_MAJOR); return -EBUSY; }

Re: [RFC] ext3 freeze feature

2008-02-06 Thread Takashi Sato
Hi, What you *could* do is to start putting processes to sleep if they attempt to write to the frozen filesystem, and then detect the deadlock case where the process holding the file descriptor used to freeze the filesystem gets frozen because it attempted to write to the filesystem --- at

Re: [Bugme-new] [Bug 9906] New: Weird hang with NPTL and SIGPROF.

2008-02-06 Thread Frank Mayhar
On Wed, 2008-02-06 at 16:50 -0800, Andrew Morton wrote: > It's probably better to handle this one via email, so please send that > testcase vie reply-to-all to this email, thanks. Testcase attached. Build with gcc -D_GNU_SOURCE -c hangc-2.c -o hangc-2.o gcc -lpthread -o hangc-2

Re: [PATCH] lguest: Accept guest _PAGE_PWT page table entries

2008-02-06 Thread Ingo Molnar
* Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > Ofcourse :) : > > Accept guest _PAGE_PWT page table entries, otherwise lguest will > always fail with a "bad page table entry" message. thanks - i've queued this up into x86.git. Rusty, is this fine to you, and should we nurse this fix

[PATCH] lguest: Accept guest _PAGE_PWT page table entries

2008-02-06 Thread Ahmed S. Darwish
On Thu, Feb 07, 2008 at 12:59:23AM +0100, Ingo Molnar wrote: > > * Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > > Hi all, > > > > Beginning from commit 4138cc3418f5, ioremap_nocache() sets the _PAGE_PWT > > flag. > > > > Lguest doesn't accept a guest pte with a _PWT flag and reports a "bad

Re: softlockup: automatically detect hung TASK_UNINTERRUPTIBLE tasks

2008-02-06 Thread Andrew Morton
On Thu, 7 Feb 2008 01:04:25 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > Does that kernel have: > > > > > > commit ed50d6cbc394cd0966469d3e249353c9dd1d38b9 > > > Author: Peter Zijlstra <[EMAIL PROTECTED]> > > > Date: Sat Feb 2 00:23:08

Re: [Bugme-new] [Bug 9906] New: Weird hang with NPTL and SIGPROF.

2008-02-06 Thread Andrew Morton
On Wed, 6 Feb 2008 16:33:20 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9906 > >Summary: Weird hang with NPTL and SIGPROF. >Product: Process Management >Version: 2.5 > KernelVersion: 2.6.24-rc4 > Platform:

Re: OOPS in sysctl.c

2008-02-06 Thread Eric W. Biederman
Alexey Dobriyan <[EMAIL PROTECTED]> writes: > On Wed, Feb 06, 2008 at 12:24:20AM -0800, Andrew Morton wrote: >> On Tue, 5 Feb 2008 12:24:56 +0100 Holger Schurig <[EMAIL PROTECTED]> > wrote: >> >> > > I have an embedded target (PXA255 based) where I have a nice >> > > running kernel 2.6.15. Today

Re: softlockup: automatically detect hung TASK_UNINTERRUPTIBLE tasks

2008-02-06 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > Nope. > > But I tested it on mainline, and mainline exhibits the > never-powers-off symptom, whereas > ed50d6cbc394cd0966469d3e249353c9dd1d38b9 demonstrates the > powers-off-after-20-seconds symptom. > > So we _may_ be dealing with two bugs here,

Re: [Netatalk-admins] netatalk slow after system upgrade (possibly kernel problem?)

2008-02-06 Thread Michael Monnerie
I received this e-mail, which could be the resolution to this problem. I will test it with the customer tomorrow. Is there a workaround possible from the Linux server, instead of modifying all clients? As it runs with kernel 2.6.13, but not with 2.6.23, maybe some behaviour change via sysctl

  1   2   3   4   5   6   7   8   9   10   >