[PATCH 2/2] nfsd: fix sparse warning in vfs.c

2008-02-20 Thread Harvey Harrison
fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- fs/nfsd/vfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 0265310..17ac51b 100644 --- a/fs/nfsd/vfs.c +++

[PATCH] Fix tty speed handling on 8250

2008-02-20 Thread Alan Cox
We try and write the correct speed back but the serial midlayer already mangles the speed on us and that means if we request B0 we report back B9600 when we should not. For now we'll hack around this in the drivers and serial code, pending a better long term solution. Signed-off-by: Alan Cox

Re: [Rt2400-devel] 2.6.25-rc2 regression in rt61pci wireless driver

2008-02-20 Thread Ivo van Doorn
On Wednesday 20 February 2008, Chris Vine wrote: On Wed, 2008-02-20 at 11:05 -0500, Dan Williams wrote: On Tue, 2008-02-19 at 23:04 +, Chris Vine wrote: On Tue, 2008-02-19 at 20:46 +0100, Ivo van Doorn wrote: Hi, [added rt2400-devel (rt2x00 development mailinglist) to the

[PATCH] riscom8: Prepare for BKL pushdown

2008-02-20 Thread Alan Cox
Push the locking down into a couple of functions that need it and remove bogus TIOCG/SSOFTCAR handling Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc2-mm1/drivers/char/riscom8.c

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-20 Thread Pierre Ossman
On Wed, 20 Feb 2008 14:26:16 -0500 (EST) Alan Stern [EMAIL PROTECTED] wrote: Do I understand this correctly? You've got special handling for the case where a bus handler doesn't have a resume routine, but no special handling for the case where it doesn't have a suspend routine? Hmm...

[PATCH] crisv10: prepare for BKL push down

2008-02-20 Thread Alan Cox
Just the modem bits this time Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc2-mm1/drivers/serial/crisv10.c linux-2.6.25-rc2-mm1/drivers/serial/crisv10.c --- linux.vanilla-2.6.25-rc2-mm1/drivers/serial/crisv10.c

[PATCH] uart_get_baud_rate: stop mangling termios

2008-02-20 Thread Alan Cox
Russell King noticed this one: We have to avoid replacing B0 when we pick a baud rate for a hung up port. Ugly but the proper fix is in the tty layer and means changing the tty-serial interfaces so we will defer that for now. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file

[PATCH] serial_core: Prepare for BKL push down

2008-02-20 Thread Alan Cox
Instead of checking for the BKL in these methods, take it ourselves. That avoids propogating it into the serial drivers and we can then fix them later on. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Pablo Sanchez
On Wednesday 20 February 2008 at 3:29 pm, Linus Torvalds penned about Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green. Can we please get this fixed some day? I can't say I even come close to understand what's going on but getting s2ram to

[PATCH] usb-serial: Prepare for BKL push down

2008-02-20 Thread Alan Cox
Take the lock in usb-serial instead. As it relies on the BKL internally we can't push it any deeper yet. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc2-mm1/drivers/usb/serial/usb-serial.c

[PATCH] fs: removing unused fops from struct char_device_struct

2008-02-20 Thread Jiri Olsa
Hi, seems struct char_device_struct::fops is no longer used, removing it. I checked with make allyesconfig and got proper compile. Signed-off-by: Jiri Olsa [EMAIL PROTECTED] --- fs/char_dev.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/char_dev.c b/fs/char_dev.c

Re: [rtc-linux] state of GEN_RTC vs rtc subsystem

2008-02-20 Thread woodys
Alessandro Zummo wrote: On Wed, 20 Feb 2008 10:11:23 -0600 Kumar Gala [EMAIL PROTECTED] wrote: Is the functionality provided by drivers/char/gen_rtc.c completely handled by the rtc subsystem in drivers/rtc? I ask for two reasons: 1. should we make it mutually exclusive in Kconfig 2. I've

Re: [PATCH] x86: add the debugfs interface for the sysprof tool

2008-02-20 Thread Peter Zijlstra
On Wed, 2008-02-20 at 11:26 -0800, Arjan van de Ven wrote: feel free to reinvent a whole GUI just to avoid a 200 line kernel module. sysprof is here. it works. the gui is REALLY nice. I guess we have to agree to disagree here. Its plain useless from my POV. I think it's the wrong

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-20 Thread Rafael J. Wysocki
On Wednesday, 20 of February 2008, Pierre Ossman wrote: On Wed, 20 Feb 2008 14:26:16 -0500 (EST) Alan Stern [EMAIL PROTECTED] wrote: Do I understand this correctly? You've got special handling for the case where a bus handler doesn't have a resume routine, but no special handling

[PATCH] nfs: fix sparse warnings

2008-02-20 Thread Harvey Harrison
fs/nfs/nfs4state.c:788:34: warning: Using plain integer as NULL pointer fs/nfs/delegation.c:52:34: warning: Using plain integer as NULL pointer fs/nfs/idmap.c:312:12: warning: Using plain integer as NULL pointer fs/nfs/callback_xdr.c:257:6: warning: Using plain integer as NULL pointer

Re: [PATCH] mmu notifiers #v6

2008-02-20 Thread Jack Steiner
On Wed, Feb 20, 2008 at 11:39:42AM +0100, Andrea Arcangeli wrote: Given Nick's comments I ported my version of the mmu notifiers to latest mainline. There are no known bugs AFIK and it's obviously safe (nothing is allowed to schedule inside rcu_read_lock taken by mmu_notifier() with my patch).

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-20 Thread Alan Stern
On Wed, 20 Feb 2008, Pierre Ossman wrote: And why not simply fail the suspend if the resume routine doesn't exist and the suspend routine does? Maybe with an error message in the system log. For the asymmetric case, I guess that would do. But I still want to remove devices when the

[PATCH] redo locking of tty-pgrp

2008-02-20 Thread Alan Cox
Historically tty-pgrp and friends were pid_t and the code knew they were safe. The change to pid structs opened up a few races and the removal of the BKL in places made them quite hittable. We put tty-pgrp under the ctrl_lock for the tty. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u

Re: [PATCH] x86: add the debugfs interface for the sysprof tool

2008-02-20 Thread Arjan van de Ven
On Wed, 20 Feb 2008 21:58:42 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote: On Wed, 2008-02-20 at 11:26 -0800, Arjan van de Ven wrote: feel free to reinvent a whole GUI just to avoid a 200 line kernel module. sysprof is here. it works. the gui is REALLY nice. I guess we have to

Re: [PATCH 28/30] r/o bind mounts: track numbers of writers to mounts

2008-02-20 Thread Dave Hansen
On Mon, 2008-02-18 at 17:10 +0100, Miklos Szeredi wrote: + /* + * We don't have to hold all of the locks at the + * same time here because we know that we're the + * last reference to mnt and that no new writers + * can come in. + */ +

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Linus Torvalds
On Wed, 20 Feb 2008, Jesse Barnes wrote: The current callback system looks like this (according to Rafael and the last time I looked): -suspend(PMSG_FREEZE) -resume() -suspend(PMSG_SUSPEND) *enter S3 or power off* -resume() Yes, it's very messy. It's messy for a few

[PATCH] pci: remove parisc consumer of the pci global_list

2008-02-20 Thread James Bottomley
The patch pci-remove-global-list-of-pci-devices.patch misses the parisc dino use of this. However, it's a simple removal job. Signed-off-by: James Bottomley [EMAIL PROTECTED] --- diff --git a/drivers/parisc/dino.c b/drivers/parisc/dino.c index 03c763c..d9c6322 100644 ---

Re: [PATCH] nfs: fix sparse warnings

2008-02-20 Thread Trond Myklebust
On Wed, 2008-02-20 at 13:03 -0800, Harvey Harrison wrote: fs/nfs/nfs4state.c:788:34: warning: Using plain integer as NULL pointer fs/nfs/delegation.c:52:34: warning: Using plain integer as NULL pointer fs/nfs/idmap.c:312:12: warning: Using plain integer as NULL pointer

Re: [git patches] net driver fixes

2008-02-20 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Wed, 20 Feb 2008 11:55:57 -0500 Note: this is based off of Linus's latest commit (5d9c4a7de64d398604a978d267a6987f1f4025b7), since all my previous submissions are now upstream (thanks!). The whole point of my not rebasing net-2.6 is so that you can

Re: Improve init/Kconfig help descriptions [PATCH 6/9]

2008-02-20 Thread Nick Andrew
On Wed, Feb 20, 2008 at 10:55:07AM -0600, [EMAIL PROTECTED] wrote: Quoting Nick Andrew ([EMAIL PROTECTED]): On Tue, Feb 19, 2008 at 06:04:57PM -0800, Paul Menage wrote: Maybe Control Groups enable processes to be grouped into cgroups to facilitate tracking and resource

[PATCH 0/2] kthread: synchronization issues

2008-02-20 Thread Dmitry Adamushko
[ I've taken the liberty of CC'ing people who replied on my previous message dedicated to this topic ] Andrew, could you please check whether this series makes any difference on the 'permanent-pause-upon-power-off' issue you observed earlier? You would also need to take along another fix

BUG?: Cannot map mmconfig aperture

2008-02-20 Thread Diego Calleja
I get the following new message in my dmesg: [0.155476] ACPI: bus type pci registered [0.155567] PCI: Found Intel Corporation 945G/GZ/P/PL Express Memory Controller Hub with MMCONFIG support. [0.161149] PCI: Cannot map mmconfig aperture for segment 0 [0.161181] PCI: Using

[PATCH 1/2] kthread: add a missing memory barrier to kthread_stop()

2008-02-20 Thread Dmitry Adamushko
From: Dmitry Adamushko [EMAIL PROTECTED] Subject: kthread: add a missing memory barrier to kthread_stop() We must ensure that kthread_stop_info.k has been updated before kthread's wakeup. This is required to properly support the use of kthread_should_stop() in the main loop of kthread.

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Jesse Barnes
On Wednesday, February 20, 2008 11:10 am Jeff Chua wrote: On Feb 21, 2008 2:53 AM, Jesse Barnes [EMAIL PROTECTED] wrote: So, next I'll try shutdown to see if it work. I was using platform. Ok, that would be good to try. shutdown does power down properly. But still green on resume.

[PATCH 2/2] kthread: call wake_up_process() whithout the lock being held

2008-02-20 Thread Dmitry Adamushko
From: Dmitry Adamushko [EMAIL PROTECTED] Subject: kthread: call wake_up_process() whithout the lock being held - from the POV of synchronization, there should be no need to call wake_up_process() with the 'kthread_create_lock' being held; - moreover, in order to support a lockless check

[PATCH 1/1] resubmit: cciss: procfs updates to display info about many volumes

2008-02-20 Thread Mike Miller
Patch 1 of 1 This patch hopefully fixes all the brokeness in my last submission. It compiles cleanly with tape support on or off. I added a couple of #ifdef's and removed the broken macro definition. The #ifdef's made it unneccesary. It also replaces create_proc_read_entry with proc_create. This

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Jesse Barnes
On Wednesday, February 20, 2008 1:13 pm Linus Torvalds wrote: On Wed, 20 Feb 2008, Jesse Barnes wrote: The current callback system looks like this (according to Rafael and the last time I looked): -suspend(PMSG_FREEZE) -resume() -suspend(PMSG_SUSPEND) *enter S3 or power off*

Re: [PATCH] x86: add the debugfs interface for the sysprof tool

2008-02-20 Thread Peter Zijlstra
On Wed, 2008-02-20 at 13:07 -0800, Arjan van de Ven wrote: On Wed, 20 Feb 2008 21:58:42 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote: On Wed, 2008-02-20 at 11:26 -0800, Arjan van de Ven wrote: feel free to reinvent a whole GUI just to avoid a 200 line kernel module. sysprof is

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-20 Thread Tony Battersby
Update: Herbert's patch alters the arguments to alloc_skb_fclone() and skb_reserve() from within sk_stream_alloc_pskb(). This changes the skb_headroom() and skb_tailroom() of the returned skb. I decided to see if I could detect the precise point at which data corruption started to happen. The

[2.6.25-rc2] Drivers sd, sr, st, osst need updating - please use bus_type methods

2008-02-20 Thread Tilman Schmidt
Finding these in my syslog when testing 2.6.25-rc2{,-mm1} with CONFIG_ENABLE_WARN_DEPRECATED=y: 4[5.312173] Driver 'sd' needs updating - please use bus_type methods 4[ 20.028800] Driver 'sr' needs updating - please use bus_type methods 6[ 22.849626] st: Version 20080117, fixed bufsize

Re: inode leak in 2.6.24?

2008-02-20 Thread David Chinner
On Wed, Feb 20, 2008 at 03:36:53PM +0100, Ferenc Wagner wrote: David Chinner [EMAIL PROTECTED] writes: The xfs inodes are clearly pinned by the dentry cache, so the issue is dentries, not inodes. What's causing dentries not to be reclaimed? I can't see anything that cold pin them (e.g. no

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: On Wednesday, 20 of February 2008, Linus Torvalds wrote: On Wed, 20 Feb 2008, Rafael J. Wysocki wrote: I think we should export the target sleep state somehow. Yeah. By *not* using -suspend() for freezing or hibernate. Please, Rafael - just make the

[PATCH 1/2] firmware: move firmware_class from Documentation/ to samples/

2008-02-20 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Move the firmware_class sample drivers to samples/ so that they are buildable and can be maintained. Add Kconfig entry for firmware_class. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- Documentation/firmware_class/firmware_sample_driver.c | 115

Re: [git patches] net driver fixes

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 01:15:30PM -0800, David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Wed, 20 Feb 2008 11:55:57 -0500 Note: this is based off of Linus's latest commit (5d9c4a7de64d398604a978d267a6987f1f4025b7), since all my previous submissions are now upstream

Re: USB OOPS 2.6.25-rc2-git1

2008-02-20 Thread David Brownell
On Wednesday 20 February 2008, Andre Tomt wrote: ehci_hcd :00:1d.7: IAA watchdog, lost IAA: status 8029 cmd 10021 ehci_hcd :00:1d.7: IAA watchdog, lost IAA: status 8029 cmd 10021 ehci_hcd :00:1d.7: IAA watchdog, lost IAA: status 8029 cmd 10021 ehci_hcd :00:1d.7: IAA watchdog,

Re: [Rt2400-devel] 2.6.25-rc2 regression in rt61pci wireless driver

2008-02-20 Thread Chris Vine
On Wed, 2008-02-20 at 21:50 +0100, Ivo van Doorn wrote: [snip] On Wednesday 20 February 2008, Chris Vine wrote: I did that yesterday and it just reported a kernel panic on the terminal with the message: Kernel panic - not syncing: Aiee, killing interrupt handler! I have an idea,

Re: USB OOPS 2.6.25-rc2-git1

2008-02-20 Thread Alan Stern
On Wed, 20 Feb 2008, Andre Tomt wrote: David Brownell wrote: On Tuesday 19 February 2008, Andre Tomt wrote: Can you try this diagnostic patch, to see if it reports any messages about IAA and/or IAAD oddities? There's surely a quick workaround for this, but I'd rather understand the root

Re: [PATCH] cyclades: Prepare for relaxed locking in callers

2008-02-20 Thread John Stoffel
Alan Basically wrap it in lock_kernel where it is hard to prove the Alan locking is ok. I've got cyclades cards, both ISA and Serial. Do you want/need any specific tests? Or should I just send you (or your deputy) the ISA card for your collection? John Alan Signed-off-by: Alan Cox [EMAIL

[PATCH 2/2] firmware: fix a few build errors

2008-02-20 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix one typo (comma to semi-colon). Fix sysfs externs (just use sysfs.h for prototypes). Documentation/firmware_class/firmware_sample_firmware_class.c:37: error: conflicting types for 'sysfs_remove_bin_file' include/linux/sysfs.h:100: error: previous

Re: 2.6.25-rc1 xen pvops regression

2008-02-20 Thread Joel Becker
On Wed, Feb 20, 2008 at 08:51:50AM +, Ian Campbell wrote: On Tue, 2008-02-19 at 23:43 -0800, H. Peter Anvin wrote: NAK! As far as the actual change goes I was assuming that any machine that has DMI/SMBIOS would easily be new enough to have an E820 which could be expected to reserve

Re: [PATCH 1/2] firmware: move firmware_class from Documentation/ to samples/

2008-02-20 Thread Marcel Holtmann
Hi Randy, Move the firmware_class sample drivers to samples/ so that they are buildable and can be maintained. Add Kconfig entry for firmware_class. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] this is a good idea. Acked-by: Marcel Holtmann [EMAIL PROTECTED] Regards Marcel -- To

Re: [PATCH 2/2] firmware: fix a few build errors

2008-02-20 Thread Marcel Holtmann
Hi Randy, Fix one typo (comma to semi-colon). Fix sysfs externs (just use sysfs.h for prototypes). Documentation/firmware_class/firmware_sample_firmware_class.c:37: error: conflicting types for 'sysfs_remove_bin_file' include/linux/sysfs.h:100: error: previous declaration of

Re: 2.6.25-rc2-mm1 - several bugs and a crash

2008-02-20 Thread Patrick McHardy
Tilman Schmidt wrote: Still, X came up fine, I could log in (Gnome feeling subjectively a bit sluggish), call up a web page from the Internet in Firefox, and start perusing the logs, when the whole system froze: neither mouse nor keyboard would react anymore, and only the Wind^Wreset button

Re: Purpose of numa_node?

2008-02-20 Thread Yinghai Lu
On Wed, Feb 13, 2008 at 10:52 AM, Brice Goglin [EMAIL PROTECTED] wrote: /sys/devices/pci:40/:40:0f.0/numa_node1 /sys/devices/pci:40/:40:10.0/numa_node1 /sys/devices/pci:40/:40:11.0/numa_node1 /sys/devices/pci:40/:40:12.0/numa_node1

[PATCH] char: make functions static in synclinkmp.c

2008-02-20 Thread Harvey Harrison
All were forward declared with static. Fixes sparse warnings: drivers/char/synclinkmp.c:1476:5: warning: symbol 'read_proc' was not declared. Should it be static? drivers/char/synclinkmp.c:2027:5: warning: symbol 'bh_action' was not declared. Should it be static?

Re: [PATCH] cyclades: Prepare for relaxed locking in callers

2008-02-20 Thread Alan Cox
On Wed, 20 Feb 2008 16:22:29 -0500 John Stoffel [EMAIL PROTECTED] wrote: Alan Basically wrap it in lock_kernel where it is hard to prove the Alan locking is ok. I've got cyclades cards, both ISA and Serial. Do you want/need any specific tests? Or should I just send you (or your deputy)

Re: [PATCH 2/2] firmware: fix a few build errors

2008-02-20 Thread Randy Dunlap
Marcel Holtmann wrote: Hi Randy, Fix one typo (comma to semi-colon). Fix sysfs externs (just use sysfs.h for prototypes). Documentation/firmware_class/firmware_sample_firmware_class.c:37: error: conflicting types for 'sysfs_remove_bin_file' include/linux/sysfs.h:100: error: previous

patch pm-remove-unbalanced-mutex_unlock-from-dpm_resume.patch added to gregkh-2.6 tree

2008-02-20 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: PM: Remove unbalanced mutex_unlock() from dpm_resume() to my gregkh-2.6 tree. Its filename is pm-remove-unbalanced-mutex_unlock-from-dpm_resume.patch This tree can be found at

Re: 2.6.25-rc1 xen pvops regression

2008-02-20 Thread Jeremy Fitzhardinge
Ian Campbell wrote: On Tue, 2008-02-19 at 23:43 -0800, H. Peter Anvin wrote: Ian Campbell wrote: On Mon, 2008-02-18 at 02:40 -0800, Joel Becker wrote: On Sun, Feb 17, 2008 at 06:49:21PM +, Ian Campbell wrote: x86/xen: Do not scan for DMI unless the DMI region is

Re: [PATCH] cyclades: Prepare for relaxed locking in callers

2008-02-20 Thread John Stoffel
Alan == Alan Cox [EMAIL PROTECTED] writes: Alan On Wed, 20 Feb 2008 16:22:29 -0500 Alan John Stoffel [EMAIL PROTECTED] wrote: Alan Basically wrap it in lock_kernel where it is hard to prove the Alan locking is ok. I've got cyclades cards, both ISA and Serial. Do you want/need any

sparse - make __CHECK_ENDIAN__ default enabled?

2008-02-20 Thread Sam Ravnborg
Hi Harvey. Can I ask you to look into the worst offenders so we can make -D__CHECK_ENDIAN__ enabled per default in the kernel. Or maybe we should do it anyway? I made a quick test-run with a x86 64 bit defconfig. My first thought was that this was just really bad because the amount of warnings

Re: [patch 1/3] m32r: cleanup - drop .data.idt section in vmlinux.lds script

2008-02-20 Thread Sam Ravnborg
On Wed, Feb 20, 2008 at 10:41:24PM +0300, [EMAIL PROTECTED] wrote: The section .data.idt is not used at all - so drop it. Only used by 32 bit x86 to be precise. Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED] Acked-by: Sam Ravnborg [EMAIL PROTECTED] --- vmlinux.lds.S |3 --- 1 file

Re: [patch 2/3] mn10300: cleanup - drop .data.idt section in vmlinux.lds script

2008-02-20 Thread Sam Ravnborg
On Wed, Feb 20, 2008 at 10:41:25PM +0300, [EMAIL PROTECTED] wrote: The section .data.idt is not used at all - so drop it. Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED] Acked-by: Sam Ravnborg [EMAIL PROTECTED] --- vmlinux.lds.S |3 --- 1 file changed, 3 deletions(-) Index:

Re: [patch 3/3] s390: cleanup - drop .data.idt section in vmlinux.lds script

2008-02-20 Thread Sam Ravnborg
On Wed, Feb 20, 2008 at 10:41:26PM +0300, [EMAIL PROTECTED] wrote: The section .data.idt is not used at all - so drop it. Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED] Acked-by: Sam Ravnborg [EMAIL PROTECTED] --- vmlinux.lds.S |5 - 1 file changed, 5 deletions(-) Index:

Re: [bug] Re: [PATCH 4/12] riscom8: fix SMP brokenness

2008-02-20 Thread Alan Cox
This is unfortunately very low on the priority stack. I was a bit surprised when it went in, honestly, since I hadn't gotten any it works test reports yet... but that's my fault for not keeping akpm up to date. We'll want to revert this for 2.6.25 release, if it doesn't get fixed up.

BT8x8 TV Card

2008-02-20 Thread Chris Brennan
I'm having a kernel related issue (I think) with the BT878 card I have in my gentoo box. Here are pastebin results of varius infomation, I hope I give all the necessary info. If I am missing something or you need more, please let me know. dmesg - http://rafb.net/p/MVIiSg62.html xorg.conf -

[PATCH 1/2] moxa: make functions static

2008-02-20 Thread Harvey Harrison
All were forward declared static already. Fixes sparse warnings: drivers/char/moxa.c:1421:6: warning: symbol 'MoxaDriverInit' was not declared. Should it be static? drivers/char/moxa.c:1464:6: warning: symbol 'MoxaPortFlushData' was not declared. Should it be static? drivers/char/moxa.c:1477:5:

[PATCH 2/2] moxa: fix sparse warnings

2008-02-20 Thread Harvey Harrison
drivers/char/moxa.c:873:26: warning: Using plain integer as NULL pointer drivers/char/moxa.c:2037:49: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/char/moxa.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Rt2400-devel] 2.6.25-rc2 regression in rt61pci wireless driver

2008-02-20 Thread Chris Clayton
Hi Ivo, [...] I have an idea, could you try below patch? Note that while applying it will mention something about a line offset, but that can be ignored. This could perhaps also fix the TX/RX issue mentioned earlier in the thread, but I am not quite sure about that. Sorry, but

Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf

2008-02-20 Thread Vlad Yasevich
Ilpo Järvinen wrote: I added inline to sctp_add_cmd and appropriate comment there to avoid adding another call into the call chain. This works at least with gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13). Alternatively, __sctp_add_cmd could be introduced to .h. My only concern was performance

Re: Improve init/Kconfig help descriptions [PATCH 4/9]

2008-02-20 Thread Nick Andrew
On Tue, Feb 19, 2008 at 10:42:10PM -0500, [EMAIL PROTECTED] wrote: On Wed, 20 Feb 2008 01:38:55 +1100, Nick Andrew said: + AVC refers to Access Vector Cache, a subsystem used by SELinux + to improve performance of the security checking by caching + previous access decisions.

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-20 Thread Rafael J. Wysocki
On Wednesday, 20 of February 2008, Alan Stern wrote: On Wed, 20 Feb 2008, Pierre Ossman wrote: And why not simply fail the suspend if the resume routine doesn't exist and the suspend routine does? Maybe with an error message in the system log. For the asymmetric case, I guess

Re: sparse - make __CHECK_ENDIAN__ default enabled?

2008-02-20 Thread Harvey Harrison
On Wed, 2008-02-20 at 23:03 +0100, Sam Ravnborg wrote: Hi Harvey. Can I ask you to look into the worst offenders so we can make -D__CHECK_ENDIAN__ enabled per default in the kernel. Or maybe we should do it anyway? Well, I've got the worst of fs and drivers/ata done so far, still weeping

Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot

2008-02-20 Thread Ilpo Järvinen
On Wed, 20 Feb 2008, Jan Engelhardt wrote: On Feb 20 2008 17:27, Patrick McHardy wrote: Striking. How can this even happen? A callsite which calls dev_alloc_skb(n) is just equivalent to __dev_alloc_skb(n, GFP_ATOMIC); which means there's like 4 (or 8 if it's long) bytes

Re: USB OOPS 2.6.25-rc2-git1

2008-02-20 Thread David Brownell
On Wednesday 20 February 2008, Alan Stern wrote: ehci_hcd :00:1d.7: IAA watchdog, lost IAA: status 8029 cmd 10021 lines in the log brings up some ideas that have been percolating in my mind for a while.  They have to do with the possibility of a race between the watchdog routine and

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Linus Torvalds
On Wed, 20 Feb 2008, Jesse Barnes wrote: Really, in the simple s3 case we still need early/late stuff? Absolutely. Two big reasons: - debuggability I know we don't do this correctly right now, but I want to be able to at least feel like we can some day actually do printk's etc

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-20 Thread Alan Stern
On Wed, 20 Feb 2008, Rafael J. Wysocki wrote: Well, below is an uncompiled and untested but illustrating the idea that might allow people not to bother with device_pm_schedule_removal() explicitly and can fix the issue at hand. [There are some cases that need handling and are not covered

Re: [git patches] net driver fixes

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 01:42:57PM -0800, David Miller wrote: From: J. Bruce Fields [EMAIL PROTECTED] Date: Wed, 20 Feb 2008 16:23:02 -0500 On Wed, Feb 20, 2008 at 01:15:30PM -0800, David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Wed, 20 Feb 2008 11:55:57 -0500

Re: [PATCH] pci: remove parisc consumer of the pci global_list

2008-02-20 Thread Greg KH
On Wed, Feb 20, 2008 at 03:14:24PM -0600, James Bottomley wrote: The patch pci-remove-global-list-of-pci-devices.patch misses the parisc dino use of this. However, it's a simple removal job. Signed-off-by: James Bottomley [EMAIL PROTECTED] Ah, sorry about that, I'll add that to my tree in

Re: [PATCH 07/30] r/o bind mounts: stub functions

2008-02-20 Thread Dave Hansen
On Sat, 2008-02-16 at 07:31 +0100, Christoph Hellwig wrote: once we put pieces in the first three patches would be useful aswell, to easily catch additions in the next cycle that might be adding NULL-vfsmount calls to dentry_open. So, we want [PATCH 07/30] r/o bind mounts: stub

patch pci-remove-parisc-consumer-of-the-pci-global_list.patch added to gregkh-2.6 tree

2008-02-20 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: PCI: remove parisc consumer of the pci global_list to my gregkh-2.6 tree. Its filename is pci-remove-parisc-consumer-of-the-pci-global_list.patch This tree can be found at

Re: 2.6.25-rc1 xen pvops regression

2008-02-20 Thread Ian Campbell
On Wed, 2008-02-20 at 13:58 -0800, Jeremy Fitzhardinge wrote: Ian Campbell wrote: On Tue, 2008-02-19 at 23:43 -0800, H. Peter Anvin wrote: Ian Campbell wrote: On Mon, 2008-02-18 at 02:40 -0800, Joel Becker wrote: On Sun, Feb 17, 2008 at 06:49:21PM +, Ian Campbell

Re: 2.6.25-rc1 xen pvops regression

2008-02-20 Thread Ian Campbell
On Wed, 2008-02-20 at 13:42 -0800, Joel Becker wrote: What changed to make this not work in the first place? New dmi code? I don't think so -- this code is present even in the 2.6.18-xen.hg tree (where it's gated with is_initial_domain() which isn't suitable for the upstream tree). I

Re: [PATCH] x86: add the debugfs interface for the sysprof tool

2008-02-20 Thread Arjan van de Ven
On Wed, 20 Feb 2008 22:44:29 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote: On Wed, 2008-02-20 at 13:07 -0800, Arjan van de Ven wrote: On Wed, 20 Feb 2008 21:58:42 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote: On Wed, 2008-02-20 at 11:26 -0800, Arjan van de Ven wrote: feel

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Rafael J. Wysocki
On Wednesday, 20 of February 2008, Jesse Barnes wrote: On Wednesday, February 20, 2008 1:13 pm Linus Torvalds wrote: On Wed, 20 Feb 2008, Jesse Barnes wrote: The current callback system looks like this (according to Rafael and the last time I looked): -suspend(PMSG_FREEZE)

Re: sparse - make __CHECK_ENDIAN__ default enabled?

2008-02-20 Thread Harvey Harrison
On Wed, 2008-02-20 at 23:03 +0100, Sam Ravnborg wrote: Hi Harvey. Can I ask you to look into the worst offenders so we can make -D__CHECK_ENDIAN__ enabled per default in the kernel. Or maybe we should do it anyway? From a quick test, the same places that spew sparse warnings, spew lots

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-20 Thread Rafael J. Wysocki
On Wednesday, 20 of February 2008, Alan Stern wrote: On Wed, 20 Feb 2008, Rafael J. Wysocki wrote: Well, below is an uncompiled and untested but illustrating the idea that might allow people not to bother with device_pm_schedule_removal() explicitly and can fix the issue at hand.

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Nigel Cunningham
Hi. Jesse Barnes wrote: Well, it seems like we'll have to fix drivers in either case, and isn't a kexec approach fundamentally more sound and simple, design-wise? Rafael pointed out some problems with properly setting wakeup states, but I think that could be overcome... No. AFAICS, kexec

Re: patch pci-remove-parisc-consumer-of-the-pci-global_list.patch added to gregkh-2.6 tree

2008-02-20 Thread Kyle McMartin
On Wed, Feb 20, 2008 at 02:25:02PM -0800, [EMAIL PROTECTED] wrote: This is a note to let you know that I've just added the patch titled Subject: PCI: remove parisc consumer of the pci global_list Thanks for finding this, both of you. Probably saves me some heartaches for 2.6.26-rc1.

[PATCH 2.6.25-rc2 1/9] init: Improve init/Kconfig help descriptions part 1

2008-02-20 Thread Nick Andrew
Rewrite the help descriptions for clarity, accuracy and consistency. The problems I can see with the supplied help descriptions fall into these areas: - Uses arcane terminology which only kernel developers can understand - Inconsistently describes safe response (if unsure, ...) -

Re: USB OOPS 2.6.25-rc2-git1

2008-02-20 Thread Alan Stern
On Wed, 20 Feb 2008, David Brownell wrote: On Wednesday 20 February 2008, Alan Stern wrote: ehci_hcd :00:1d.7: IAA watchdog, lost IAA: status 8029 cmd 10021 lines in the log brings up some ideas that have been percolating in my mind for a while.  They have to do with the

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Jesse Barnes
On Wednesday, February 20, 2008 11:10 am Jeff Chua wrote: On Feb 21, 2008 2:53 AM, Jesse Barnes [EMAIL PROTECTED] wrote: So, next I'll try shutdown to see if it work. I was using platform. Ok, that would be good to try. shutdown does power down properly. But still green on resume.

Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf

2008-02-20 Thread Ilpo Järvinen
On Wed, 20 Feb 2008, Vlad Yasevich wrote: Ilpo Järvinen wrote: I added inline to sctp_add_cmd and appropriate comment there to avoid adding another call into the call chain. This works at least with gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13). Alternatively, __sctp_add_cmd could be

Re: Plans for mISDN?

2008-02-20 Thread Tilman Schmidt
Am 20.02.2008 20:04 schrieb Gregory Nietsky: did someone say interface/API documentation ooops ... DUCK seriously this is lacking and im sure as time goes on some volenteer (sucker) will get it up and running.this is not a show stoper but a nice to have. It's an enabler for getting a move

Re: sparse - make __CHECK_ENDIAN__ default enabled?

2008-02-20 Thread Sam Ravnborg
On Wed, Feb 20, 2008 at 02:39:46PM -0800, Harvey Harrison wrote: On Wed, 2008-02-20 at 23:03 +0100, Sam Ravnborg wrote: Hi Harvey. Can I ask you to look into the worst offenders so we can make -D__CHECK_ENDIAN__ enabled per default in the kernel. Or maybe we should do it anyway?

Re: [BUG] 2.6.25-rc2-mm1 - Kernel panic while bootup caused by signal_group_exit()

2008-02-20 Thread Rik van Riel
On Wed, 20 Feb 2008 23:04:40 +0300 Oleg Nesterov [EMAIL PROTECTED] wrote: Yes, please look at http://marc.info/?t=12030984056 Btw. The bug in tty_io.c _can_ explain this trace, but it would be nice to ensure we don't have other problems. Could you try this

Re: USB OOPS 2.6.25-rc2-git1

2008-02-20 Thread David Brownell
On Wednesday 20 February 2008, Alan Stern wrote: On Wed, 20 Feb 2008, David Brownell wrote: On Wednesday 20 February 2008, Alan Stern wrote: ehci_hcd :00:1d.7: IAA watchdog, lost IAA: status 8029 cmd 10021 lines in the log brings up some ideas that have been percolating in my

Re: [git patches] net driver fixes

2008-02-20 Thread David Miller
From: J. Bruce Fields [EMAIL PROTECTED] Date: Wed, 20 Feb 2008 17:25:30 -0500 The advantages include earlier warning of merge problems, and avoidance of duplicate commits--if Jeff's done work that depends on patches that already upstream, then he either does that work against upstream, or

Re: [PATCH 07/30] r/o bind mounts: stub functions

2008-02-20 Thread Christoph Hellwig
On Wed, Feb 20, 2008 at 02:25:52PM -0800, Dave Hansen wrote: On Sat, 2008-02-16 at 07:31 +0100, Christoph Hellwig wrote: once we put pieces in the first three patches would be useful aswell, to easily catch additions in the next cycle that might be adding NULL-vfsmount calls to dentry_open.

Re: [git patches] net driver fixes

2008-02-20 Thread Francois Romieu
David Miller [EMAIL PROTECTED] : [...] Because it forces me to pull Linus's upstream into net-2.6, I don't have any choice in the matter. Jeff's choice is a bit surprizing. That being said, it would had been nice to fast-forward net-2.6 from a442585952f137bd4cdb1f2f3166e4157d383b82 to Linus's

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Jesse Barnes
On Wednesday, February 20, 2008 2:32 pm Jesse Barnes wrote: On Wednesday, February 20, 2008 11:10 am Jeff Chua wrote: On Feb 21, 2008 2:53 AM, Jesse Barnes [EMAIL PROTECTED] wrote: So, next I'll try shutdown to see if it work. I was using platform. Ok, that would be good to try.

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-20 Thread Tony Battersby
The following patch fixes the problem for me. Do we want to accept this patch and call it a day or continue investigating the source of the problem? Patch applies to 2.6.24.2, but doesn't apply to 2.6.25-rc. If everyone agrees that this is the right solution, I will resubmit with a proper

Re: [git patches] net driver fixes

2008-02-20 Thread David Miller
From: Francois Romieu [EMAIL PROTECTED] Date: Wed, 20 Feb 2008 23:40:53 +0100 David Miller [EMAIL PROTECTED] : [...] Because it forces me to pull Linus's upstream into net-2.6, I don't have any choice in the matter. Jeff's choice is a bit surprizing. That being said, it would had been

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-20 Thread David Miller
From: Tony Battersby [EMAIL PROTECTED] Date: Wed, 20 Feb 2008 18:04:09 -0500 The following patch fixes the problem for me. Do we want to accept this patch and call it a day or continue investigating the source of the problem? Patch applies to 2.6.24.2, but doesn't apply to 2.6.25-rc. If

[PATCH 1/3] x86: Coding style fixes to arch/x86/kernel/cpu/mcheck/p6.c

2008-02-20 Thread Paolo Ciarrocchi
Hopefully this time the patches will reach the list :-) After the patch: total: 0 errors, 0 warnings, 122 lines checked arch/x86/kernel/cpu/mcheck/p6.c has no obvious style problems and is ready for submission. Compile tested. Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED] ---

<    7   8   9   10   11   12   13   14   >