Re: [PATCH v3] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-11 Thread Eric Dumazet
On Wed, 2012-07-11 at 16:30 +0800, Gao feng wrote: > there are some out of bound accesses in netprio cgroup. > > now before accessing the dev->priomap.priomap array,we only check > if the dev->priomap exist.and because we don't want to see > additional bound checkings in fast path, so we should

[PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer

2012-07-11 Thread Julia Lawall
From: Julia Lawall dev_get_platdata returns a pointer, so the failure value would be NULL rather than a negative integer. The semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // @@ expression x,e; statement S1,S2; @@ *x = dev_get_platdata(...) ... when != x = e *if (x

Re: [PATCH 00/36] AArch64 Linux kernel port

2012-07-11 Thread Catalin Marinas
On Tue, Jul 10, 2012 at 10:44:29PM +0100, Catalin Marinas wrote: > On Tue, Jul 10, 2012 at 09:35:27PM +0100, Ingo Molnar wrote: > > Do you *really* think that all of the 32-bit ARM code should > > essentially be thrown away when going to 64-bit ARM, that > > patches can only touch arch/arm64/ +

Re: [PATCH RFC 1/2] kvm vcpu: Note down pause loop exit

2012-07-11 Thread Avi Kivity
On 07/09/2012 09:20 AM, Raghavendra K T wrote: > Signed-off-by: Raghavendra K T > > Noting pause loop exited vcpu helps in filtering right candidate to yield. > Yielding to same vcpu may result in more wastage of cpu. > > > struct kvm_lpage_info { > diff --git a/arch/x86/kvm/svm.c

Re: + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to

2012-07-11 Thread Linus Torvalds
On Wed, Jul 11, 2012 at 1:14 AM, George Spelvin wrote: > > Huh. I prefer sizeof without parens, like I prefer return without parens. Umm. The two have *nothing* to do with each other. > It actually annoys me when I see someone write > > return(0); Absolutely. Anybody who does that is

Re: [PATCH v3 7/8] bluetooth: Added /proc/net/rfcomm via bt_procfs_init()

2012-07-11 Thread Andrei Emeltchenko
Hi Masatake, On Wed, Jul 11, 2012 at 02:04:01PM +0900, Masatake YAMATO wrote: > Signed-off-by: Masatake YAMATO > --- > net/bluetooth/rfcomm/sock.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) error: patch failed: net/bluetooth/rfcomm/sock.c:1033 error:

Re: [PATCH v3 6/8] bluetooth: Added /proc/net/l2cap via bt_procfs_init()

2012-07-11 Thread Andrei Emeltchenko
Hi Masatake, On Wed, Jul 11, 2012 at 02:03:37PM +0900, Masatake YAMATO wrote: > Signed-off-by: Masatake YAMATO > --- > net/bluetooth/l2cap_sock.c | 20 ++-- > 1 file changed, 18 insertions(+), 2 deletions(-) error: patch failed: net/bluetooth/l2cap_sock.c:1248 error:

Re: linux-next: Tree for July 10 (gpio/gpio-tps65910.c)

2012-07-11 Thread Linus Walleij
On Wed, Jul 11, 2012 at 7:44 AM, Randy Dunlap wrote: > On 07/10/2012 12:43 AM, Stephen Rothwell wrote: >> >> Changes since 20120709: > > when CONFIG_OF_GPIO is not enabled: > > drivers/gpio/gpio-tps65910.c: In function 'tps65910_gpio_probe': > drivers/gpio/gpio-tps65910.c:152:26: error: 'struct

Re: [PATCH] USB: add USB_VENDOR_AND_INTERFACE_INFO() macro

2012-07-11 Thread Bjørn Mork
Greg Kroah-Hartman writes: > On Tue, Jul 10, 2012 at 06:51:03PM -0300, Gustavo Padovan wrote: > >> { USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01) } > > Two entries in the cdc_wdm driver can also be converted to use this > interface. Do you want to send a patch doing that, or do you

Re: [PATCH] mm/hugetlb_cgroup: Add list_del to remove unused page from hugepage_activelist when hugepage migration

2012-07-11 Thread Aneesh Kumar K.V
Wanpeng Li writes: > From: Wanpeng Li > > hugepage_activelist is used to track currently used HugeTLB pages. > We can find the in-use HugeTLB pages to support HugeTLB cgroup > removal. Don't keep unused page in hugetlb_activelist too long. > Otherwise, on cgroup removal we should update the

Re: [GIT PULL] x86/mce fix (ready for 3.6 merge window)

2012-07-11 Thread Borislav Petkov
On Wed, Jul 11, 2012 at 10:04:46AM +0200, Ingo Molnar wrote: > A couple of commit log details: > > - If it's for v3.6 then the Cc: stable backport is not >justified. Either it's for tip:x86/urgent and then we'll >merge it straight away, or for tip:x86/mce for v3.6 and then >

[PATCH v3] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-11 Thread Gao feng
there are some out of bound accesses in netprio cgroup. now before accessing the dev->priomap.priomap array,we only check if the dev->priomap exist.and because we don't want to see additional bound checkings in fast path, so we should make sure that dev->priomap is null or array size of

Re: [PATCH net-next 6/6] r8169: support RTL8168G

2012-07-11 Thread David Miller
From: Francois Romieu Date: Tue, 10 Jul 2012 08:50:10 +0200 > Hayes Wang : >> fix incorrct argument in rtl_hw_init_8168g. >> >> Signed-off-by: Hayes Wang > > Thanks Hayes. > > It's available with proper attribution and subject at: > > git://violet.fr.zoreil.com/romieu/linux

Re: [PATCH v2 04/23] ARM: LPC32xx: Add DMA configuration to platform data

2012-07-11 Thread Roland Stigge
On 07/10/2012 11:36 PM, Arnd Bergmann wrote: >> +/* NOTE: These will change, according to RMK */ >> +static int pl08x_get_signal(struct pl08x_dma_chan *ch) >> +{ >> +return ch->cd->min_signal; >> +} >> + > > This has changed now, rendering linux-next broken for lpc32xx_defconfig: > >

Re: [PATCH 00/36] AArch64 Linux kernel port

2012-07-11 Thread Ingo Molnar
* Arnd Bergmann wrote: > > Do you really think that all of the 32-bit ARM code should > > essentially be thrown away when going to 64-bit ARM, that > > patches can only touch arch/arm64/ + drivers/ or the > > highway? > > Yes. Straight answer ;-) > If you're curious, please have a look at

Re: + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to

2012-07-11 Thread George Spelvin
Unser geliebter Führer schreib: > sizeof without parenthesis is an abomination, and should never be used. Huh. I prefer sizeof without parens, like I prefer return without parens. It actually annoys me when I see someone write return(0); Because it's not a function (our language is

Re: mmotm 2012-07-10-16-59 uploaded

2012-07-11 Thread Andrew Morton
On Wed, 11 Jul 2012 11:08:26 +0300 Artem Bityutskiy wrote: > On Wed, 2012-07-11 at 00:59 -0700, Andrew Morton wrote: > > > > I looked at them, but they're identical to what I now have, so nothing > > > > needed doing. > > > > > > Strange, I thought they had the white-spaces issue solved. > >

Organising Mini Summits within the Kernel Summit

2012-07-11 Thread James Bottomley
Hi All, We have set aside the second day of the kernel summit (Tuesday 28 August) as mini-summit day. So far we have only the PCI mini summit on this day, so if you can think of other topics, please send them to the kernel summit discuss list: ksummit-2012-disc...@lists.linux-foundation.org

Re: [GIT PULL] x86/mce fix (ready for 3.6 merge window)

2012-07-11 Thread Ingo Molnar
* Luck, Tony wrote: > The following changes since commit 6887a4131da3adaab011613776d865f4bcfb5678: > > Linux 3.5-rc5 (2012-06-30 16:08:57 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git > tags/please-pull-mce-ripvfix > >

Re: mmotm 2012-07-10-16-59 uploaded

2012-07-11 Thread Artem Bityutskiy
On Wed, 2012-07-11 at 00:59 -0700, Andrew Morton wrote: > > > I looked at them, but they're identical to what I now have, so nothing > > > needed doing. > > > > Strange, I thought they had the white-spaces issue solved. > > They did, but I'd already fixed everything. That's what those emails >

Re: [PATCH 2/7] memcg: remove MEMCG_NR_FILE_MAPPED

2012-07-11 Thread Sha Zhengju
On 07/10/2012 05:01 AM, Greg Thelen wrote: On Thu, Jun 28 2012, Sha Zhengju wrote: From: Sha Zhengju While accounting memcg page stat, it's not worth to use MEMCG_NR_FILE_MAPPED as an extra layer of indirection because of the complexity and presumed performance overhead. We can use

Re: [PATCH v4 1/1] Input: xpad - Handle all variations of Mad Catz Beat Pad

2012-07-11 Thread Dmitry Torokhov
On Wed, Jul 11, 2012 at 02:02:19PM +0700, Yuri Khan wrote: > * Add this device to usbhid ignore list > > Signed-off-by: Yuri Khan > Acked-by: Jiri Kosina Applied, thank you Yuri. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: mmotm 2012-07-10-16-59 uploaded

2012-07-11 Thread Andrew Morton
On Wed, 11 Jul 2012 10:53:13 +0300 Artem Bityutskiy wrote: > On Wed, 2012-07-11 at 00:44 -0700, Andrew Morton wrote: > > On Wed, 11 Jul 2012 09:38:00 +0300 Artem Bityutskiy > > wrote: > > > > > Andrew, thanks for picking my changes! > > > > > > On Tue, 2012-07-10 at 17:01 -0700,

Re: 82571EB: Detected Hardware Unit Hang

2012-07-11 Thread Joe Jin
On 07/11/12 15:50, Dave, Tushar N wrote: > Device status and AER sections show some errors that looks little suspicious > to me but I'm not too sure. I will get back tomorrow. > Thanks a lot, Tushar! Joe -- Oracle Joe Jin | Software Development Senior Manager |

Re: [PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-11 Thread Dmitry Torokhov
On Wed, Jul 11, 2012 at 09:49:04AM +0200, Roland Stigge wrote: > On 07/10/2012 10:55 PM, Dmitry Torokhov wrote: > > Hi Roland, > > > > On Tue, Jul 10, 2012 at 09:35:10PM +0200, Roland Stigge wrote: > >> This patch adds a driver for the key scan interface of the LPC32xx SoC > >> > > > > Could of

Re: rcu_dyntick and suspicious RCU usage

2012-07-11 Thread Paul E. McKenney
On Tue, Jul 10, 2012 at 12:47:00PM +0800, Fengguang Wu wrote: > Hi Paul, > > Fortunately this bug is bisectable and the first bad commit is: > > commit 9b2e4f1880b789be1f24f9684f7a54b90310b5c0 > Author: Paul E. McKenney > Date: Fri Sep 30 12:10:22 2011 -0700 > >

RE: 82571EB: Detected Hardware Unit Hang

2012-07-11 Thread Dave, Tushar N
>-Original Message- >From: Joe Jin [mailto:joe@oracle.com] >Sent: Wednesday, July 11, 2012 12:39 AM >To: Dave, Tushar N >Cc: e1000-de...@lists.sf.net; net...@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: Re: 82571EB: Detected Hardware Unit Hang > >On 07/11/12 15:37, Dave,

Re: [PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-11 Thread Roland Stigge
On 07/10/2012 10:55 PM, Dmitry Torokhov wrote: > Hi Roland, > > On Tue, Jul 10, 2012 at 09:35:10PM +0200, Roland Stigge wrote: >> This patch adds a driver for the key scan interface of the LPC32xx SoC >> > > Could of more things that I had in my patch but forgot to specifically > call out: > >>

Re: mmotm 2012-07-10-16-59 uploaded

2012-07-11 Thread Artem Bityutskiy
On Wed, 2012-07-11 at 00:44 -0700, Andrew Morton wrote: > On Wed, 11 Jul 2012 09:38:00 +0300 Artem Bityutskiy > wrote: > > > Andrew, thanks for picking my changes! > > > > On Tue, 2012-07-10 at 17:01 -0700, a...@linux-foundation.org wrote: > > > *

[PATCH 7/7 v2] release memory resources if hotadd_new_pgdat() failed

2012-07-11 Thread Wen Congyang
We should goto error to release memory resource if hotadd_new_pgdat() failed. Signed-off-by: Wen Congyang --- mm/memory_hotplug.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 0d7e3ec..427bb29 100644 ---

[GIT PULL] SCSI fixes for 3.5-rc6

2012-07-11 Thread James Bottomley
This is a set of three fixes for data corruption (libsas task file), oops causing (NULL in scsi_cmd_to_driver) and driver failure (bnx2i). The oops caused by the NULL in scsi_cmd_to_driver() manifests in scsi_eh_send_cmd() and has been seen by several people now. The patch is available here:

[PATCH 6/7 v2] auto bind the memory device which is hotpluged before the driver is loaded

2012-07-11 Thread Wen Congyang
If the memory device is hotpluged before the driver is loaded, the user cannot see this device under the directory /sys/bus/acpi/devices/, and the user cannot bind it by hand after the driver is loaded. This patch introduces a new feature to bind such device when the driver is being loaded.

[PATCH 5/7 v2] bind the memory device when the driver is being loaded

2012-07-11 Thread Wen Congyang
We had introduced acpi_hotmem_initialized to avoid strange add_memory fail message. But the memory device may not be used by the kernel, and the device should be bound when the driver is being loaded. Remove acpi_hotmem_initialized to allow that the device can be bound when the driver is being

[PATCH 4/7 v2] don't allow to eject the memory device if it is being used

2012-07-11 Thread Wen Congyang
We eject the memory device even if it is in use. It is very dangerous, and it will cause the kernel panicked. Signed-off-by: Wen Congyang --- drivers/acpi/acpi_memhotplug.c | 38 +++--- 1 files changed, 31 insertions(+), 7 deletions(-) diff --git

[PATCH 3/7 v2] remove memory info from list before freeing it

2012-07-11 Thread Wen Congyang
We free info, but we forget to remove it from the list. It will cause unexpected problem when we access the list next time. Signed-off-by: Wen Congyang --- drivers/acpi/acpi_memhotplug.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/acpi/acpi_memhotplug.c

[PATCH 2/7 v2] free memory device if acpi_memory_enable_device() failed

2012-07-11 Thread Wen Congyang
If acpi_memory_enable_device() fails, acpi_memory_enable_device() will return a non-zero value, which means we fail to bind the memory device to this driver. So we should free memory device before acpi_memory_device_add() returns. Signed-off-by: Wen Congyang --- drivers/acpi/acpi_memhotplug.c |

Re: [PATCH 3/4] zsmalloc: add details to zs_map_object boiler plate

2012-07-11 Thread Minchan Kim
On 07/11/2012 12:17 AM, Seth Jennings wrote: > On 07/09/2012 09:35 PM, Minchan Kim wrote: >> On 07/03/2012 06:15 AM, Seth Jennings wrote: >>> Add information on the usage limits of zs_map_object() >>> >>> Signed-off-by: Seth Jennings >>> --- >>> drivers/staging/zsmalloc/zsmalloc-main.c |7

[PATCH 1/7 v2] fix memory leak when memory device is unbound from the module acpi_memhotplug

2012-07-11 Thread Wen Congyang
We allocate memory to store acpi_memory_info, so we should free it before freeing mem_device. Signed-off-by: Wen Congyang --- drivers/acpi/acpi_memhotplug.c | 31 +-- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/acpi/acpi_memhotplug.c

Re: mmotm 2012-07-10-16-59 uploaded

2012-07-11 Thread Andrew Morton
On Wed, 11 Jul 2012 09:38:00 +0300 Artem Bityutskiy wrote: > Andrew, thanks for picking my changes! > > On Tue, 2012-07-10 at 17:01 -0700, a...@linux-foundation.org wrote: > > * hfs-get-rid-of-hfs_sync_super-checkpatch-fixes.patch > > > * hfsplus-get-rid-of-write_super-checkpatch-fixes.patch >

[PATCH 0/7 v2] some fixes about acpi_memhotplug

2012-07-11 Thread Wen Congyang
Changes from v1 to v2: 1. address David Rientjes and Konrad Rzeszutek Wilk's comment Note: Patch 2, 3, 7 have been acked by David Rientjes. Wen Congyang (7): fix memory leak when memory device is unbound from the module acpi_memhotplug free memory device if acpi_memory_enable_device()

Re: 82571EB: Detected Hardware Unit Hang

2012-07-11 Thread Joe Jin
On 07/11/12 15:37, Dave, Tushar N wrote: >> -Original Message- >> From: Joe Jin [mailto:joe@oracle.com] >> Sent: Wednesday, July 11, 2012 12:18 AM >> To: Dave, Tushar N >> Cc: e1000-de...@lists.sf.net; net...@vger.kernel.org; linux- >> ker...@vger.kernel.org >> Subject: Re: 82571EB:

RE: 82571EB: Detected Hardware Unit Hang

2012-07-11 Thread Dave, Tushar N
>-Original Message- >From: Joe Jin [mailto:joe@oracle.com] >Sent: Wednesday, July 11, 2012 12:18 AM >To: Dave, Tushar N >Cc: e1000-de...@lists.sf.net; net...@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: Re: 82571EB: Detected Hardware Unit Hang > >On 07/11/12 15:11, Dave,

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-11 Thread Minchan Kim
On 07/11/2012 12:29 AM, Seth Jennings wrote: > On 07/09/2012 09:21 PM, Minchan Kim wrote: >> On 07/03/2012 06:15 AM, Seth Jennings wrote: > >>> +static void zs_copy_map_object(char *buf, struct page *firstpage, >>> + int off, int size) >> >> firstpage is rather

Re: [RFC PATCH v3 11/13] memory-hotplug : free memmap of sparse-vmemmap

2012-07-11 Thread Wen Congyang
At 07/11/2012 02:48 PM, Yasuaki Ishimatsu Wrote: > Hi Wen, > > 2012/07/11 15:25, Wen Congyang wrote: >> At 07/11/2012 01:52 PM, Yasuaki Ishimatsu Wrote: >>> 2012/07/11 14:06, Wen Congyang wrote: >>> Hi Wen, >>> At 07/09/2012 06:33 PM, Yasuaki Ishimatsu Wrote: > I don't think that all

Re: 82571EB: Detected Hardware Unit Hang

2012-07-11 Thread Joe Jin
On 07/11/12 15:11, Dave, Tushar N wrote: >> -Original Message- >> From: Joe Jin [mailto:joe@oracle.com] >> Sent: Tuesday, July 10, 2012 10:03 PM >> To: Dave, Tushar N >> Cc: e1000-de...@lists.sf.net; net...@vger.kernel.org; linux- >> ker...@vger.kernel.org >> Subject: Re: 82571EB:

RE: 82571EB: Detected Hardware Unit Hang

2012-07-11 Thread Dave, Tushar N
>-Original Message- >From: Joe Jin [mailto:joe@oracle.com] >Sent: Tuesday, July 10, 2012 10:03 PM >To: Dave, Tushar N >Cc: e1000-de...@lists.sf.net; net...@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: Re: 82571EB: Detected Hardware Unit Hang > >On 07/11/12 12:05, Dave,

Re: perf with precise attribute kills all KVM based VMs

2012-07-11 Thread Gleb Natapov
On Tue, Jul 10, 2012 at 05:38:40PM -0600, David Ahern wrote: > On 7/9/12 8:59 AM, Peter Zijlstra wrote: > >On Mon, 2012-07-09 at 17:51 +0300, Avi Kivity wrote: > >>On 07/09/2012 05:49 PM, Peter Zijlstra wrote: > >>>On Mon, 2012-07-09 at 08:47 -0600, David Ahern wrote: > > I found this

Re: [PATCH v1] usb: host: Fix possible kernel crash

2012-07-11 Thread Venu Byravarasu
On Tuesday 10 July 2012 08:15 PM, gre...@linuxfoundation.org wrote: On Tue, Jul 10, 2012 at 09:56:39AM +0530, Venu Byravarasu wrote: Thanks Alan for your comments. On Monday 09 July 2012 08:04 PM, Alan Stern wrote: On Mon, 9 Jul 2012, Venu Byravarasu wrote: In functions itd_complete &

Re: [PATCH v1] usb: host: Fix possible kernel crash

2012-07-11 Thread Venu Byravarasu
On Tuesday 10 July 2012 08:39 PM, Alan Stern wrote: On Tue, 10 Jul 2012, Venu Byravarasu wrote: Thanks Alan for your comments. On Monday 09 July 2012 08:04 PM, Alan Stern wrote: On Mon, 9 Jul 2012, Venu Byravarasu wrote: In functions itd_complete & sitd_complete, a pointer by name stream

Re: [PATCH v1] usb: host: Fix possible kernel crash

2012-07-11 Thread Venu Byravarasu
On Tuesday 10 July 2012 10:05 PM, Scan Subscription wrote: Hi Greg/Venu/Alan and others, The defect discussed in this thread was found in 2006, and was marked in Coverity Scan as false positive - intentional ( by linux developer or coverity admin that we don't know)... As a general rule, 1.

Re: [PATCH 0/4] zsmalloc improvements

2012-07-11 Thread Minchan Kim
Hi everybody, I realized it by Seth's mention yesterday that Greg already merged this series I should have hurried but last week I have no time. :( On 07/03/2012 06:15 AM, Seth Jennings wrote: > This patchset removes the current x86 dependency for zsmalloc > and introduces some performance

[PATCH v4 1/1] Input: xpad - Handle all variations of Mad Catz Beat Pad

2012-07-11 Thread Yuri Khan
* Add this device to usbhid ignore list Signed-off-by: Yuri Khan Acked-by: Jiri Kosina --- drivers/hid/hid-core.c|1 + drivers/hid/hid-ids.h |3 +++ drivers/input/joystick/xpad.c |1 + 3 files changed, 5 insertions(+) diff --git a/drivers/hid/hid-core.c

linux-next: no tree for July 11

2012-07-11 Thread Stephen Rothwell
Normal service will resume tomorrow. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpmJyBkrt8nJ.pgp Description: PGP signature

Re: [PATCH] iio: dac: ad5064: fix section mismatch in ad5064_init() in linux-next

2012-07-11 Thread Lars-Peter Clausen
On 07/11/2012 06:05 AM, Gerard Snitselaar wrote: > ad5064_init() calls ad5064_spi_unregister_driver() which is annotated > __exit. > > Signed-off-by: Gerard Snitselaar Thanks, Acked-by: Lars-Peter Clausen > --- > drivers/iio/dac/ad5064.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [RFC PATCH v3 11/13] memory-hotplug : free memmap of sparse-vmemmap

2012-07-11 Thread Yasuaki Ishimatsu
Hi Wen, 2012/07/11 15:25, Wen Congyang wrote: > At 07/11/2012 01:52 PM, Yasuaki Ishimatsu Wrote: >> 2012/07/11 14:06, Wen Congyang wrote: >> Hi Wen, >> >>> At 07/09/2012 06:33 PM, Yasuaki Ishimatsu Wrote: I don't think that all pages of virtual mapping in removed memory can be freed,

[PATCH] fs/ioctl.c: set local var past_eof to true instead of integer 1 in __generic_block_fiemap

2012-07-11 Thread Wang Sheng-Hui
In function __generic_block_fiemap, local var past_eof is declared as bool, so use 'true' instead of number 1 here. Signed-off-by: Wang Sheng-Hui --- fs/ioctl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ioctl.c b/fs/ioctl.c index 29167be..e42abb0 100644 ---

Re: [PATCH] mei: module version

2012-07-11 Thread Ortwin Glück
On 07/10/2012 05:28 PM, Alan Cox wrote: On Tue, 10 Jul 2012 12:10:27 +0200 Ortwin Glück wrote: The LMS daemon expects a /sys/modules/mei/version file with, a four digit version number. see http://software.intel.com/en-us/articles/download-the-latest-intel-amt-open-source-drivers/ Just get

Re: [RFC PATCH 05/14] PCI: add access functions for PCIe capabilities to hide PCIe spec differences

2012-07-11 Thread Jiang Liu
On 2012-7-11 11:40, Bjorn Helgaas wrote: >> Good point. Return success when reading unimplemented registeres, that >> may simplify code. For we still should return -EINVAL when writing >> unimplemented registers, right? > > Yeah, I guess it's OK to return -EINVAL when *writing* to an >

[patch] tty: double unlock on error in ptmx_open()

2012-07-11 Thread Dan Carpenter
The problem here is that we called mutex_unlock(_mutex) on the error path when we weren't holding the lock. Signed-off-by: Dan Carpenter diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c index d855883..a0ca083 100644 --- a/drivers/tty/pty.c +++ b/drivers/tty/pty.c @@ -618,13 +618,12 @@ static

Re: [PATCH] mm/slob: avoid type warning about alignment value

2012-07-11 Thread Arnd Bergmann
On Wednesday 11 July 2012, David Rientjes wrote: > Wouldn't it be better to avoid this problem more generally by casting the > __alignof__ for ARCH_{KMALLOC,SLAB}_MINALIGN to int in slab.h? All > architectures that define these themselves will be using plain integers, > the problem is

Re: [PATCH] pwm: fix used-uninitialized warning in pwm_get()

2012-07-11 Thread Thierry Reding
On Thu, Jul 05, 2012 at 09:56:50AM -0600, Stephen Warren wrote: > On 07/03/2012 11:58 PM, Thierry Reding wrote: > > On Tue, Jul 03, 2012 at 02:34:21PM -0600, Stephen Warren wrote: > >> From: Stephen Warren > >> > >> This fixes: drivers/pwm/core.c: In function 'pwm_get': > >>

Re: linux-next: build failure after merge of the net-next tree

2012-07-11 Thread David Miller
From: Stephen Rothwell Date: Tue, 10 Jul 2012 13:08:48 +1000 > I added the following merge fix patch: > > From: Stephen Rothwell > Date: Tue, 10 Jul 2012 13:06:01 +1000 > Subject: [PATCH] net: fix for qmi_wwan_unbind_shared changes > > Signed-off-by: Stephen Rothwell Thanks Stephen, I'll

[patch] Extcon: Arizona: unlock on an error in arizona_micdet()

2012-07-11 Thread Dan Carpenter
Smatch complains about this. I don't have a way to test this, but it does look like we should unlock on error here. Signed-off-by: Dan Carpenter diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index b068bc9..4782884 100644 --- a/drivers/extcon/extcon-arizona.c

Re: [PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

2012-07-11 Thread Hans Verkuil
Hi Federico! A few small remarks: On Wed July 11 2012 04:34:46 Federico Vaga wrote: > Signed-off-by: Federico Vaga > --- > drivers/media/video/adv7180.c | 221 > + > 1 file changed, 90 insertions(+), 131 deletions(-) > > diff --git

[patch] tracing: check for allocation failure

2012-07-11 Thread Dan Carpenter
Clean up and return -ENOMEM on if the kzalloc() fails. Signed-off-by: Dan Carpenter diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 814ff30..a120f98 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -2390,6 +2390,9 @@ __tracing_open(struct inode *inode, struct file

[PATCH] staging/gdm72xx: use kthread APIs

2012-07-11 Thread Devendra Naga
This patch modifies the kthread usage in the gdm_usb code, and tries to use the kthread APIs better. Actually the task_struct is taken as global as the limitation of priv. we run the kthread before we allocate the priv. did only compilation test, but not the insmod, check ps ax for kthread and

Re: mmotm 2012-07-10-16-59 uploaded

2012-07-11 Thread Artem Bityutskiy
Andrew, thanks for picking my changes! On Tue, 2012-07-10 at 17:01 -0700, a...@linux-foundation.org wrote: > * hfs-get-rid-of-hfs_sync_super-checkpatch-fixes.patch > * hfsplus-get-rid-of-write_super-checkpatch-fixes.patch I sent updated versions which would fix checkpatch.pl complaints. I guess

Re: [PATCH resend 0/3] pstore/ram: Configurable ECC size

2012-07-11 Thread Anton Vorontsov
On Tue, Jul 10, 2012 at 01:17:48PM -0700, Kees Cook wrote: > On Mon, Jul 9, 2012 at 4:45 PM, Anton Vorontsov > wrote: > > Just a few patches left from the series that used to add configurable > > ECC size for pstore/ram backend. Most patches were merged into -next, > > and this is just a resend

Re: [PATCH 0/4] Calxeda xgmac fixes and performance improvements

2012-07-11 Thread David Miller
From: Rob Herring Date: Mon, 9 Jul 2012 19:16:06 -0500 > From: Rob Herring > > A few fixes and performance improvements for the Calxeda xgmac driver for > 3.6. It would be nice to get the 2 fixes into 3.5, but since it is a bit > late in the cycle they can wait. All applied to net-nex,

[PATCH V3] perf/x86: Add Intel Nehalem-EX/Westmere-EX uncore support

2012-07-11 Thread Yan, Zheng
From: "Yan, Zheng" The uncore subsystem in Nehalem-EX/Westmere-EX consists of 7 components (U-Box, C-Box, B-Box, S-Box, R-Box, M-Box and W-Box). This patch is large because the way to program these boxes is diverse. Signed-off-by: Yan, Zheng --- Changes since v2: -Add code to explicit specify

Re: [RFC PATCH v3 11/13] memory-hotplug : free memmap of sparse-vmemmap

2012-07-11 Thread Wen Congyang
At 07/11/2012 01:52 PM, Yasuaki Ishimatsu Wrote: > 2012/07/11 14:06, Wen Congyang wrote: > Hi Wen, > >> At 07/09/2012 06:33 PM, Yasuaki Ishimatsu Wrote: >>> I don't think that all pages of virtual mapping in removed memory can be >>> freed, since page which type is MIX_SECTION_INFO is difficult

Re: [PATCH 05/13] rbtree: performance and correctness test

2012-07-11 Thread Michel Lespinasse
On Tue, Jul 10, 2012 at 5:27 AM, Michal Nazarewicz wrote: > On Tue, 10 Jul 2012 01:35:15 +0200, Michel Lespinasse > wrote: >> + u32 prev_key = 0; >> + >> + for (rb = rb_first(); rb; rb = rb_next(rb)) { >> + struct test_node *node = rb_entry(rb, struct test_node, >>

Re: Logitech HD Webcam C525 does not work when connected to USB 2 port, works on USB 3

2012-07-11 Thread Heinz Diehl
Hi, I have exactly the same webcam, lsusb says "Bus 002 Device 004: ID 046d:0826 Logitech, Inc."... On 06.07.2012, Alan Stern wrote: > On Thu, 5 Jul 2012, Frederik Himpe wrote: > > I tried setting to on again, and then this appears in the logs: > > Jul 5 21:21:59 piranha kernel: [

[PATCH V2] staging/slicoss: disable pci device at remove

2012-07-11 Thread Devendra Naga
at probe we enabled the device, and we should disable it at remove. Signed-off-by: Devendra Naga --- changes v2: nothing, just a resend, incremented patch version count for maintainer to have notified the latest change easily. drivers/staging/slicoss/slicoss.c |1 + 1 file

[PATCH V2] staging/slicoss: disable pci device at remove

2012-07-11 Thread Devendra Naga
at probe we enabled the device, and we should disable it at remove. Signed-off-by: Devendra Naga devendra.a...@gmail.com --- changes v2: nothing, just a resend, incremented patch version count for maintainer to have notified the latest change easily. drivers/staging/slicoss/slicoss.c

Re: Logitech HD Webcam C525 does not work when connected to USB 2 port, works on USB 3

2012-07-11 Thread Heinz Diehl
Hi, I have exactly the same webcam, lsusb says Bus 002 Device 004: ID 046d:0826 Logitech, Inc On 06.07.2012, Alan Stern wrote: On Thu, 5 Jul 2012, Frederik Himpe wrote: I tried setting to on again, and then this appears in the logs: Jul 5 21:21:59 piranha kernel: [ 9788.223118] usb

Re: [PATCH 05/13] rbtree: performance and correctness test

2012-07-11 Thread Michel Lespinasse
On Tue, Jul 10, 2012 at 5:27 AM, Michal Nazarewicz min...@mina86.com wrote: On Tue, 10 Jul 2012 01:35:15 +0200, Michel Lespinasse wal...@google.com wrote: + u32 prev_key = 0; + + for (rb = rb_first(root); rb; rb = rb_next(rb)) { + struct test_node *node =

Re: [RFC PATCH v3 11/13] memory-hotplug : free memmap of sparse-vmemmap

2012-07-11 Thread Wen Congyang
At 07/11/2012 01:52 PM, Yasuaki Ishimatsu Wrote: 2012/07/11 14:06, Wen Congyang wrote: Hi Wen, At 07/09/2012 06:33 PM, Yasuaki Ishimatsu Wrote: I don't think that all pages of virtual mapping in removed memory can be freed, since page which type is MIX_SECTION_INFO is difficult to free.

[PATCH V3] perf/x86: Add Intel Nehalem-EX/Westmere-EX uncore support

2012-07-11 Thread Yan, Zheng
From: Yan, Zheng zheng.z@intel.com The uncore subsystem in Nehalem-EX/Westmere-EX consists of 7 components (U-Box, C-Box, B-Box, S-Box, R-Box, M-Box and W-Box). This patch is large because the way to program these boxes is diverse. Signed-off-by: Yan, Zheng zheng.z@intel.com --- Changes

Re: [PATCH 0/4] Calxeda xgmac fixes and performance improvements

2012-07-11 Thread David Miller
From: Rob Herring robherri...@gmail.com Date: Mon, 9 Jul 2012 19:16:06 -0500 From: Rob Herring rob.herr...@calxeda.com A few fixes and performance improvements for the Calxeda xgmac driver for 3.6. It would be nice to get the 2 fixes into 3.5, but since it is a bit late in the cycle they

Re: [PATCH resend 0/3] pstore/ram: Configurable ECC size

2012-07-11 Thread Anton Vorontsov
On Tue, Jul 10, 2012 at 01:17:48PM -0700, Kees Cook wrote: On Mon, Jul 9, 2012 at 4:45 PM, Anton Vorontsov anton.voront...@linaro.org wrote: Just a few patches left from the series that used to add configurable ECC size for pstore/ram backend. Most patches were merged into -next, and this

Re: mmotm 2012-07-10-16-59 uploaded

2012-07-11 Thread Artem Bityutskiy
Andrew, thanks for picking my changes! On Tue, 2012-07-10 at 17:01 -0700, a...@linux-foundation.org wrote: * hfs-get-rid-of-hfs_sync_super-checkpatch-fixes.patch * hfsplus-get-rid-of-write_super-checkpatch-fixes.patch I sent updated versions which would fix checkpatch.pl complaints. I guess

[PATCH] staging/gdm72xx: use kthread APIs

2012-07-11 Thread Devendra Naga
This patch modifies the kthread usage in the gdm_usb code, and tries to use the kthread APIs better. Actually the task_struct is taken as global as the limitation of priv. we run the kthread before we allocate the priv. did only compilation test, but not the insmod, check ps ax for kthread and

[patch] tracing: check for allocation failure

2012-07-11 Thread Dan Carpenter
Clean up and return -ENOMEM on if the kzalloc() fails. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 814ff30..a120f98 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -2390,6 +2390,9 @@ __tracing_open(struct

Re: [PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

2012-07-11 Thread Hans Verkuil
Hi Federico! A few small remarks: On Wed July 11 2012 04:34:46 Federico Vaga wrote: Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/video/adv7180.c | 221 + 1 file changed, 90 insertions(+), 131 deletions(-) diff --git

[patch] Extcon: Arizona: unlock on an error in arizona_micdet()

2012-07-11 Thread Dan Carpenter
Smatch complains about this. I don't have a way to test this, but it does look like we should unlock on error here. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index b068bc9..4782884 100644 ---

Re: linux-next: build failure after merge of the net-next tree

2012-07-11 Thread David Miller
From: Stephen Rothwell s...@canb.auug.org.au Date: Tue, 10 Jul 2012 13:08:48 +1000 I added the following merge fix patch: From: Stephen Rothwell s...@canb.auug.org.au Date: Tue, 10 Jul 2012 13:06:01 +1000 Subject: [PATCH] net: fix for qmi_wwan_unbind_shared changes Signed-off-by: Stephen

Re: [PATCH] pwm: fix used-uninitialized warning in pwm_get()

2012-07-11 Thread Thierry Reding
On Thu, Jul 05, 2012 at 09:56:50AM -0600, Stephen Warren wrote: On 07/03/2012 11:58 PM, Thierry Reding wrote: On Tue, Jul 03, 2012 at 02:34:21PM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com This fixes: drivers/pwm/core.c: In function 'pwm_get':

Re: [PATCH] mm/slob: avoid type warning about alignment value

2012-07-11 Thread Arnd Bergmann
On Wednesday 11 July 2012, David Rientjes wrote: Wouldn't it be better to avoid this problem more generally by casting the __alignof__ for ARCH_{KMALLOC,SLAB}_MINALIGN to int in slab.h? All architectures that define these themselves will be using plain integers, the problem is __alignof__

[patch] tty: double unlock on error in ptmx_open()

2012-07-11 Thread Dan Carpenter
The problem here is that we called mutex_unlock(devpts_mutex) on the error path when we weren't holding the lock. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c index d855883..a0ca083 100644 --- a/drivers/tty/pty.c +++ b/drivers/tty/pty.c

Re: [RFC PATCH 05/14] PCI: add access functions for PCIe capabilities to hide PCIe spec differences

2012-07-11 Thread Jiang Liu
On 2012-7-11 11:40, Bjorn Helgaas wrote: Good point. Return success when reading unimplemented registeres, that may simplify code. For we still should return -EINVAL when writing unimplemented registers, right? Yeah, I guess it's OK to return -EINVAL when *writing* to an unimplemented

Re: [PATCH] mei: module version

2012-07-11 Thread Ortwin Glück
On 07/10/2012 05:28 PM, Alan Cox wrote: On Tue, 10 Jul 2012 12:10:27 +0200 Ortwin Glücko...@odi.ch wrote: The LMS daemon expects a /sys/modules/mei/version file with, a four digit version number. see http://software.intel.com/en-us/articles/download-the-latest-intel-amt-open-source-drivers/

[PATCH] fs/ioctl.c: set local var past_eof to true instead of integer 1 in __generic_block_fiemap

2012-07-11 Thread Wang Sheng-Hui
In function __generic_block_fiemap, local var past_eof is declared as bool, so use 'true' instead of number 1 here. Signed-off-by: Wang Sheng-Hui shh...@gmail.com --- fs/ioctl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ioctl.c b/fs/ioctl.c index

Re: [RFC PATCH v3 11/13] memory-hotplug : free memmap of sparse-vmemmap

2012-07-11 Thread Yasuaki Ishimatsu
Hi Wen, 2012/07/11 15:25, Wen Congyang wrote: At 07/11/2012 01:52 PM, Yasuaki Ishimatsu Wrote: 2012/07/11 14:06, Wen Congyang wrote: Hi Wen, At 07/09/2012 06:33 PM, Yasuaki Ishimatsu Wrote: I don't think that all pages of virtual mapping in removed memory can be freed, since page which

Re: [PATCH] iio: dac: ad5064: fix section mismatch in ad5064_init() in linux-next

2012-07-11 Thread Lars-Peter Clausen
On 07/11/2012 06:05 AM, Gerard Snitselaar wrote: ad5064_init() calls ad5064_spi_unregister_driver() which is annotated __exit. Signed-off-by: Gerard Snitselaar d...@snitselaar.org Thanks, Acked-by: Lars-Peter Clausen l...@metafoo.de --- drivers/iio/dac/ad5064.c | 2 +- 1 file changed,

linux-next: no tree for July 11

2012-07-11 Thread Stephen Rothwell
Normal service will resume tomorrow. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpmJyBkrt8nJ.pgp Description: PGP signature

[PATCH v4 1/1] Input: xpad - Handle all variations of Mad Catz Beat Pad

2012-07-11 Thread Yuri Khan
* Add this device to usbhid ignore list Signed-off-by: Yuri Khan yurivk...@gmail.com Acked-by: Jiri Kosina jkos...@suse.cz --- drivers/hid/hid-core.c|1 + drivers/hid/hid-ids.h |3 +++ drivers/input/joystick/xpad.c |1 + 3 files changed, 5 insertions(+) diff --git

Re: [PATCH 0/4] zsmalloc improvements

2012-07-11 Thread Minchan Kim
Hi everybody, I realized it by Seth's mention yesterday that Greg already merged this series I should have hurried but last week I have no time. :( On 07/03/2012 06:15 AM, Seth Jennings wrote: This patchset removes the current x86 dependency for zsmalloc and introduces some performance

Re: [PATCH v1] usb: host: Fix possible kernel crash

2012-07-11 Thread Venu Byravarasu
On Tuesday 10 July 2012 10:05 PM, Scan Subscription wrote: Hi Greg/Venu/Alan and others, The defect discussed in this thread was found in 2006, and was marked in Coverity Scan as false positive - intentional ( by linux developer or coverity admin that we don't know)... As a general rule, 1.

Re: [PATCH v1] usb: host: Fix possible kernel crash

2012-07-11 Thread Venu Byravarasu
On Tuesday 10 July 2012 08:39 PM, Alan Stern wrote: On Tue, 10 Jul 2012, Venu Byravarasu wrote: Thanks Alan for your comments. On Monday 09 July 2012 08:04 PM, Alan Stern wrote: On Mon, 9 Jul 2012, Venu Byravarasu wrote: In functions itd_complete sitd_complete, a pointer by name stream

<    2   3   4   5   6   7   8   9   10   11   >