RE: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-09-30 Thread Arun MURTHY
> On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +static struct class *modem_class; > > What's wrong with a bus_type instead? Can I know the advantage of using bus_type over class? > > > +static

Re: [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core

2012-09-30 Thread ABRAHAM, KISHON VIJAY
Hi, On Sun, Sep 30, 2012 at 10:17 PM, Sergei Shtylyov wrote: > Hello. > > > On 28-09-2012 14:53, Kishon Vijay Abraham I wrote: > >> Added dwc3 support for dwc3 core and update the documentation with >> device tree binding information. >> >> Signed-off-by: Kishon Vijay Abraham I > > [...] > > >>

Re: [PATCH] Fix userspace compilation of ip_tables.h/ip6_tables.h in C++ mode

2012-09-30 Thread David Miller
From: Jason Gunthorpe Date: Sun, 30 Sep 2012 17:17:37 -0600 > The implicit cast from void * is not allowed for C++ compilers, and the > arithmetic on void * generates warnings in C++ mode. > > $ g++ -c t.cc > ip_tables.h:221:24: warning: pointer of type 'void *' used in arithmetic >

Re: [RFC v9 PATCH 00/21] memory-hotplug: hot-remove physical memory

2012-09-30 Thread Yasuaki Ishimatsu
Hi Chen, 2012/09/29 17:19, Ni zhan Chen wrote: On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote: From: Wen Congyang This patch series aims to support physical memory hot-remove. The patches can free/remove the following things: - acpi_memory_info : [RFC PATCH

Re: CONFIG_EXPERT is a booby trap

2012-09-30 Thread Tim Shepard
Interestingly, of the 26 configs that use EXPERT in the default clause, 15 of them are in drivers/hid (see below). -Tim Shepard s...@alum.mit.edu - - - - - - - - - - - - - - - - - - - - - - - - - - - - $ find . -type f -name

linux-next: manual merge of the mips tree with Linus' tree

2012-09-30 Thread Stephen Rothwell
Hi Ralf, Today's linux-next merge of the mips tree got a conflict in drivers/net/ethernet/octeon/octeon_mgmt.c between commit df555b665367 ("netdev: octeon: fix return value check in octeon_mgmt_init_phy()") from Linus' tree and commit eeae05aa2169 ("netdev: octeon_mgmt: Add support for 1Gig

linux-next: build failure after merge of the btrfs tree

2012-09-30 Thread Stephen Rothwell
Hi Chris, After merging the btrfs tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: fs/btrfs/disk-io.c:34:28: fatal error: asm/cpufeature.h: No such file or directory Caused by commit 2fcfff234500 ("Btrfs: do not async metadata csumming in certain situations"). Only

linux-next: import of the device-mapper series failed

2012-09-30 Thread Stephen Rothwell
Hi Alasdair, Trying to import the device-mapper series produce this error: $ git am ../quilt/device-mapper/dm-thin-support-discard-with-non-power-of-two-block-size.patch Applying: Support discards when the pool's block size is not a power of 2. error: patch failed: drivers/md/dm-thin.c:2762

Re: [PATCH V2 3/3] workqueue: Schedule work on non-idle cpu instead of current one

2012-09-30 Thread Viresh Kumar
On 1 October 2012 06:02, Tejun Heo wrote: > It isn't about the CPU being actually idle? No. Being idle only from scheduler's perspective. :) > Also, if it's only about timers, shouldn't it be enough to implement > it for timer and delayed_work? What if we need a timer, which must re-arm itself

[tip:x86/acpi] ACPI: Document ACPI table overriding via initrd

2012-09-30 Thread tip-bot for Thomas Renninger
Commit-ID: 8347bbecf3518aa1518f6157e661812a35775130 Gitweb: http://git.kernel.org/tip/8347bbecf3518aa1518f6157e661812a35775130 Author: Thomas Renninger AuthorDate: Mon, 1 Oct 2012 00:23:57 +0200 Committer: H. Peter Anvin CommitDate: Sun, 30 Sep 2012 18:03:41 -0700 ACPI: Document ACPI

[tip:x86/acpi] ACPI: Create acpi_table_taint() function to avoid code duplication

2012-09-30 Thread tip-bot for Thomas Renninger
Commit-ID: 325a8d36035f0623950e38e9cf7a47a48e72df11 Gitweb: http://git.kernel.org/tip/325a8d36035f0623950e38e9cf7a47a48e72df11 Author: Thomas Renninger AuthorDate: Mon, 1 Oct 2012 00:23:56 +0200 Committer: H. Peter Anvin CommitDate: Sun, 30 Sep 2012 18:03:35 -0700 ACPI: Create

[tip:x86/acpi] ACPI: Implement physical address table override

2012-09-30 Thread tip-bot for Thomas Renninger
Commit-ID: b2a35003dfbcc7b7a5e5c6e524e7d49ba66e0bb5 Gitweb: http://git.kernel.org/tip/b2a35003dfbcc7b7a5e5c6e524e7d49ba66e0bb5 Author: Thomas Renninger AuthorDate: Mon, 1 Oct 2012 00:23:55 +0200 Committer: H. Peter Anvin CommitDate: Sun, 30 Sep 2012 18:03:29 -0700 ACPI: Implement

[tip:x86/acpi] ACPI: Store valid ACPI tables passed via early initrd in reserved memblock areas

2012-09-30 Thread tip-bot for Thomas Renninger
Commit-ID: 53aac44c904abbad9f474f652f099de13b5c3563 Gitweb: http://git.kernel.org/tip/53aac44c904abbad9f474f652f099de13b5c3563 Author: Thomas Renninger AuthorDate: Mon, 1 Oct 2012 00:23:54 +0200 Committer: H. Peter Anvin CommitDate: Sun, 30 Sep 2012 18:03:23 -0700 ACPI: Store valid

[tip:x86/acpi] lib: Add early cpio decoder

2012-09-30 Thread tip-bot for H. Peter Anvin
Commit-ID: e6459606b04e6385ccd3c2060fc10f78a92c7700 Gitweb: http://git.kernel.org/tip/e6459606b04e6385ccd3c2060fc10f78a92c7700 Author: H. Peter Anvin AuthorDate: Mon, 1 Oct 2012 00:23:52 +0200 Committer: H. Peter Anvin CommitDate: Sun, 30 Sep 2012 18:02:20 -0700 lib: Add early cpio

Re: CONFIG_EXPERT is a booby trap

2012-09-30 Thread Randy Dunlap
On 09/30/2012 07:21 PM, Tim Shepard wrote: > A month or two ago when I attempted to upgrade from 3.4 to 3.5 on my > MacBook Pro laptop, in preparation to try an interesting patch to TCP > developed against 3.5 by a colleague, my keyboard stopped working. I > tried bisecting, but that lead to

Re: [RFC v9 PATCH 13/21] memory-hotplug: check page type in get_page_bootmem

2012-09-30 Thread Yasuaki Ishimatsu
Hi Chen, 2012/09/29 11:15, Ni zhan Chen wrote: On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote: From: Yasuaki Ishimatsu The function get_page_bootmem() may be called more than one time to the same page. There is no need to set page's type, private if the function is not the first time

CONFIG_EXPERT is a booby trap

2012-09-30 Thread Tim Shepard
A month or two ago when I attempted to upgrade from 3.4 to 3.5 on my MacBook Pro laptop, in preparation to try an interesting patch to TCP developed against 3.5 by a colleague, my keyboard stopped working. I tried bisecting, but that lead to nowhere useful and much confusion. It turns out

Re: Re: [PATCH -tip 0/3] Move kprobes files under the kprobes directory

2012-09-30 Thread Masami Hiramatsu
(2012/09/28 21:34), Steven Rostedt wrote: > On Fri, 2012-09-28 at 17:15 +0900, Masami Hiramatsu wrote: >> Hi, >> >> Here are a series of patches to split ftrace-based kprobe part >> from arch/x86/kernel/kprobes.c and to move kprobes related >> files under arch/x86/kernel/kprobes/, according to

[PATCH -next] bluetooth: fix printk format warnings

2012-09-30 Thread Randy Dunlap
From: Randy Dunlap Fix printk format warnings in net/bluetooth/: net/bluetooth/hci_event.c:886:3: warning: format '%ld' expects type 'long int', but argument 2 has type 'size_t' net/bluetooth/hci_event.c:886:3: warning: format '%ld' expects type 'long int', but argument 3 has type 'size_t'

Re: [PATCH v4] KSM: numa awareness sysfs knob

2012-09-30 Thread Hugh Dickins
Andrea's point about ksm_migrate_page() is an important one, and I've answered that against his mail, but here's some other easier points. On Mon, 24 Sep 2012, Petr Holasek wrote: > Introduces new sysfs boolean knob /sys/kernel/mm/ksm/merge_across_nodes > which control merging pages across

Re: [PATCH] perf, tools: Add library dependencies for static perf link

2012-09-30 Thread Andi Kleen
> This is superfluous, because FLAGS_BFD has -ldl already by your change > above. This is cascaded downwards. I tried to remove it, but that makes it not link again for the static build. Haven't looked into the causes. -Andi -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v3 04/13] kmem accounting basic infrastructure

2012-09-30 Thread Tejun Heo
Hello, James. On Sun, Sep 30, 2012 at 12:25:52PM +0100, James Bottomley wrote: > But you've got to ask yourself who cares about accurate accounting per > container of dentry and inode objects? They're not objects that any > administrator is used to limiting. What we at parallels care about >

[RFC v3] perf tools: Try to find cross-built objdump path

2012-09-30 Thread Irina Tirdea
From: Namhyung Kim As we have architecture information of saved perf.data file, we can try to find cross-built objdump path. The triplets include support for Android (arm, x86 and mips architectures). Signed-off-by: Namhyung Kim Signed-off-by: Irina Tirdea --- v3: () update triplets to

Linux 3.6

2012-09-30 Thread Linus Torvalds
When I did the -rc7 announcement a week ago, I said I might have to do an -rc8, but a week passed, and things have been calm, and I honestly cannot see a major reason to do another rc. So here it is, 3.6 final. Sure, I'd have been happier with even fewer changes, but that just never happens. And

Re: [PATCH v4] KSM: numa awareness sysfs knob

2012-09-30 Thread Hugh Dickins
Sorry for taking so long to look at Petr's nice work: it's more than what I can think through in odd stolen moments; but yesterday at last I managed to get down to remembering KSM and giving this some time. On Fri, 28 Sep 2012, Andrea Arcangeli wrote: > On Mon, Sep 24, 2012 at 02:56:06AM +0200,

Re: [PATCH V2 3/3] workqueue: Schedule work on non-idle cpu instead of current one

2012-09-30 Thread Tejun Heo
Hello, On Sun, Sep 30, 2012 at 05:46:45PM +0530, Viresh Kumar wrote: > For the scheduler CPU is idle, if all below are true: > - current task is idle task > - nr_running == 0 > - wake_list is empty > > And during these conditions, there can be a timer running in background. > And when we reach

Re: [PATCH 8/10] bug.h: Make BUILD_BUG_ON generate compile-time error

2012-09-30 Thread Josh Triplett
On Sun, Sep 30, 2012 at 06:29:01PM -0500, Daniel Santos wrote: > On 09/28/2012 09:55 PM, Josh Triplett wrote: > > Assuming you don't call BUILD_BUG_ON_MSG more than once per line: > > > > /tmp$ cat test.c > > #define BUILD_BUG_ON_MSG_INTERNAL2(cond, msg, line) \ > > do { \ > > extern

Re: [PATCH 3/10] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro

2012-09-30 Thread Josh Triplett
On Sun, Sep 30, 2012 at 06:11:01PM -0500, Daniel Santos wrote: > So in light of feedback I've been getting on this patch set, it leaves > me with > this question. > > +#define GCC_VERSION (__GNUC__ * 1 \ > > + + __GNUC_MINOR__ * 100 \ > > + + __GNUC_PATCHLEVEL__) >

Re: [PATCH] gpio: mvebu: Add missing breaks in mvebu_gpio_irq_set_type

2012-09-30 Thread Jason Cooper
On Sun, Sep 30, 2012 at 11:49:49PM +0200, Linus Walleij wrote: > On Sun, Sep 30, 2012 at 10:23 AM, Axel Lin wrote: > > > Signed-off-by: Axel Lin > > Acked-by: Linus Walleij > > Since this gpio-mvebu patch is in ARM SoC or somewhere I expect > whoever put it there to safeguide the fix to its

[PATCH] [ARM] Use AT() in the linker script to create correct program headers

2012-09-30 Thread Jason Gunthorpe
The standard linux asm-generic/vmlinux.lds.h already supports this, and it seems other architectures do as well. The goal is to create an ELF file that has correct program headers. We want to see the VirtAddr be the runtime address of the kernel with the MMU turned on, and PhysAddr be the

[PATCH] Fix userspace compilation of ip_tables.h/ip6_tables.h in C++ mode

2012-09-30 Thread Jason Gunthorpe
The implicit cast from void * is not allowed for C++ compilers, and the arithmetic on void * generates warnings in C++ mode. $ g++ -c t.cc ip_tables.h:221:24: warning: pointer of type 'void *' used in arithmetic ip_tables.h:221:24: error: invalid conversion from 'void*' to 'xt_entry_target*'

Re: [PATCH 11/12] perf tools: Convert to BACKTRACE_SUPPORT

2012-09-30 Thread Irina Tirdea
> @@ -751,10 +753,8 @@ else > endif > > ifdef NO_BACKTRACE This should be changed to ifndef NO_BACKTRACE. > - BASIC_CFLAGS += -DNO_BACKTRACE > -else > - ifneq ($(call try-cc,$(SOURCE_BACKTRACE),),y) > - BASIC_CFLAGS += -DNO_BACKTRACE > + ifeq ($(call

Re: [PATCH v2 3/4] perf annotate: configure objdump path at compile time

2012-09-30 Thread Irina Tirdea
On Thu, Sep 27, 2012 at 4:16 PM, Namhyung Kim wrote: > On Thu, 27 Sep 2012 14:25:10 +0300, Irina Tirdea wrote: The perf built to run on the host needs to use arm-eabi-objdump from the toolchain so that it can analyse data recorded on Android. This patch is targeting this scenario,

[PATCH] TPM: Let the tpm char device be openable multiple times

2012-09-30 Thread Jason Gunthorpe
How to use the TPM is really a user space policy choice, if the environment wants to use middleware then fine, but it is possible to make correct TPM apps without using middleware. So, remove the kernel restriction that only one process may open the TPM. - TPM low level functions (in kernel

[PATCH] TPM: Provide a tpm_tis OF driver

2012-09-30 Thread Jason Gunthorpe
This provides an open firwmare driver binding for tpm_tis. OF is useful on arches where PNP is not used. Allow the tpm_tis driver to be selected if PNP or OF are compiled in. Signed-off-by: Jason Gunthorpe --- drivers/char/tpm/Kconfig |2 +- drivers/char/tpm/tpm_tis.c | 56

[PATCH] TPM: Issue TPM_STARTUP at driver load if the TPM has not been started

2012-09-30 Thread Jason Gunthorpe
The TPM will respond to TPM_GET_CAP with TPM_ERR_INVALID_POSTINIT if TPM_STARTUP has not been issued. This will result in the TPM driver failing to load and no way to recover. Detect this and automatically issue TPM_STARTUP. This is for embedded applications where the kernel is the first thing to

Re: [PATCH 8/10] bug.h: Make BUILD_BUG_ON generate compile-time error

2012-09-30 Thread Daniel Santos
On 09/28/2012 09:55 PM, Josh Triplett wrote: > Assuming you don't call BUILD_BUG_ON_MSG more than once per line: > > /tmp$ cat test.c > #define BUILD_BUG_ON_MSG_INTERNAL2(cond, msg, line) \ > do { \ > extern void __build_bug_on_failed_ ## line (void) > __attribute__((error(msg))); \ >

[PATCH] PPC: Do not make the entire heap executable

2012-09-30 Thread Jason Gunthorpe
On PPC the ELF PLT sections look like this: [17] .sbss NOBITS 0002aff8 01aff8 14 00 WA 0 0 4 [18] .plt NOBITS 0002b00c 01aff8 84 00 WAX 0 0 4 [19] .bss NOBITS 0002b090 01aff8 a4 00 WA 0 0 4 Which

Re: [PATCH v4 5/5] MFD: ti_tscadc: add suspend/resume functionality

2012-09-30 Thread Samuel Ortiz
Hi Jonathan, On Sat, Sep 29, 2012 at 10:50:19AM +0100, Jonathan Cameron wrote: > On 09/26/2012 11:09 AM, Patil, Rachna wrote: > > Hi Shubhrajyoti, > > > > On Wed, Sep 26, 2012 at 12:10:51, Datta, Shubhrajyoti wrote: > >> On Wednesday 26 September 2012 10:50 AM, Patil, Rachna wrote: > >>> This

Re: [PATCH v4 2/5] MFD: ti_tscadc: Add support for TI's TSC/ADC MFDevice

2012-09-30 Thread Samuel Ortiz
Hi Rachna, On Wed, Sep 26, 2012 at 10:50:11AM +0530, Patil, Rachna wrote: > Add the mfd core driver which supports touchscreen > and ADC. > With this patch we are only adding infrastructure to > support the MFD clients. > > Signed-off-by: Patil, Rachna > --- > Changes in v2: > Merged

Re: [PATCH 3/10] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro

2012-09-30 Thread Daniel Santos
So in light of feedback I've been getting on this patch set, it leaves me with this question. > +#define GCC_VERSION (__GNUC__ * 1 \ > ++ __GNUC_MINOR__ * 100 \ > ++ __GNUC_PATCHLEVEL__) This macro presumes you are using gcc 3.0 or later, which introduced the

Re: Instead of IP addresses the kernel started to show zero's

2012-09-30 Thread Borislav Petkov
+ netdev On Sun, Sep 30, 2012 at 11:25:59PM +0200, Giuliano Pochini wrote: > On Tue, 25 Sep 2012 14:26:07 +0400 > Alexey Vlasov wrote: > > > Hi. > > > > Here it writes LOG target from syslog: > > > > Sep 25 03:23:49 l24 kernel: ip:SYN-OUTPUT-HTTP IN= OUT=eth0 > > SRC=

Re: [PATCH] backlight: tps65217_bl: Add missing platform_set_drvdata in tps65217_bl_probe

2012-09-30 Thread Samuel Ortiz
Hi Axel, On Sun, Sep 30, 2012 at 06:28:26PM +0800, Axel Lin wrote: > Otherwise, we got NULL derefernce while calling backlight_device_unregister() > in tps65217_bl_remove(). > > Also convert to use module_platform_driver. > > Signed-off-by: Axel Lin > --- >

Re: [PATCH v6 1/3] drivers/mfd: Add realtek pcie card reader driver

2012-09-30 Thread Samuel Ortiz
Hi Wei, On Tue, Sep 11, 2012 at 12:54:22PM +0800, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Realtek PCI-E card reader driver adapts requests from upper-level > sdmmc/memstick layer to the real physical card reader. > > Signed-off-by: Wei WANG > Reviewed-by: Arnd Bergmann >

Re: [PATCH] gpio: mvebu: Add missing breaks in mvebu_gpio_irq_set_type

2012-09-30 Thread Linus Walleij
On Sun, Sep 30, 2012 at 10:23 AM, Axel Lin wrote: > Signed-off-by: Axel Lin Acked-by: Linus Walleij Since this gpio-mvebu patch is in ARM SoC or somewhere I expect whoever put it there to safeguide the fix to its destination. Else poke me after 3.7-rc1 and I'll take it as a GPIO fix...

Re: [PATCH 10/12] gpio: pcf857x: select IRQ_DOMAIN

2012-09-30 Thread Linus Walleij
On Fri, Sep 28, 2012 at 11:36 PM, Arnd Bergmann wrote: > Patch 6e20a0a4 "gpio: pcf857x: enable gpio_to_irq() support" > added IRQ domain support to the pcf857x driver, but some configurations > (e.g. davinci_all_defconfig) don't already enable CONFIG_IRQ_DOMAIN. Excellent patch Arnd thanks for

[PATCH 2/2] scripts/kernel-doc: check that non-void fcts describe their return value

2012-09-30 Thread Yacine Belkadi
If a function has a return value, but its kernel-doc comment doesn't contain a "Return" section, then emit the following warning: Warning(file.h:129): No description found for return value of 'fct' Note: This check emits a lot of warnings at the moment, because many functions don't have a

[PATCH 1/2] Kernel-doc: Convention: Use a "Return" section to describe return values

2012-09-30 Thread Yacine Belkadi
Non-void functions should describe their return values in their kernel-doc comments. Currently, some don't, others do in various forms. For example: * Return the result. * Return: The result. * Returns the result. * Returns: the result. * Return Value: The result. * @return: the

Re: Instead of IP addresses the kernel started to show zero's

2012-09-30 Thread Giuliano Pochini
On Tue, 25 Sep 2012 14:26:07 +0400 Alexey Vlasov wrote: > Hi. > > Here it writes LOG target from syslog: > > Sep 25 03:23:49 l24 kernel: ip:SYN-OUTPUT-HTTP IN= OUT=eth0 > SRC= DST= LEN=60 TOS=0x00 PREC=0x00 > TTL=64 ID=22467 DF PROTO=TCP SPT=52829 DPT=80

Re: [PATCH] qla2xxx: silence two GCC warnings

2012-09-30 Thread Rolf Eike Beer
Am Sonntag 30 September 2012, 13:07:54 schrieb Paul Bolle: > Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC > warnings: > drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_rhba’: > drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is above > array

Re: [PATCH 6/10] bug.h: Replace __linktime_error with __compiletime_error

2012-09-30 Thread Daniel Santos
On 09/30/2012 08:22 AM, Borislav Petkov wrote: > On Fri, Sep 28, 2012 at 09:04:35PM -0400, Steven Rostedt wrote: >> On Fri, 2012-09-28 at 17:23 -0700, Josh Triplett wrote: >>> On Fri, Sep 28, 2012 at 06:20:07PM -0500, Daniel Santos wrote: Signed-off-by: Daniel Santos ---

[PATCH V2] ath/ath9k/ar9003_eeprom.c: Remove semicolon after if

2012-09-30 Thread Peter Senna Tschudin
The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r1@ position p; @@ if (...);@p @script:python@ p0 << r1.p; @@ // Emacs org-mode output cocci.print_main("", p0) cocci.print_secs("", p0) // Signed-off-by: Peter Senna Tschudin --- NOTE: This patch

HID: picoLCD: optimize for inactive debugfs

2012-09-30 Thread Bruno Prémont
Matthieu CASTET adjusted picolcd_debug_out_report() to only operate when there is an active listener on debugfs for events. His change got lost while splitting hid_picolcd.c, restore it. Signed-off-by: Bruno Prémont --- diff --git a/drivers/hid/hid-picolcd_debugfs.c

Re: [PATCH 0/7] uprobes: register/unregister bugfixes

2012-09-30 Thread Oleg Nesterov
Forgot to mention, This is on top of "[PATCH 0/3] uprobes: mprotect fixes" series, which is still waiting for review... On 09/30, Oleg Nesterov wrote: > > Hello. > > Misc bugfixes, mostly register/unregister related. > > Note: 4/7 and especially 6/7 are the really ugly (but hopefully >

[PATCH 2/7] uprobes: Don't return success if alloc_uprobe() fails

2012-09-30 Thread Oleg Nesterov
If alloc_uprobe() fails uprobe_register() should return ENOMEM, not 0. Signed-off-by: Oleg Nesterov --- kernel/events/uprobes.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index a741ba7..3ec114c 100644 ---

[PATCH 6/7] uprobes: Fix uprobe_copy_insn() race with itself

2012-09-30 Thread Oleg Nesterov
install_breakpoint() is called under mm->mmap_sem, this protects set_swbp() but not uprobe_copy_insn(). Two or more different tasks can call install_breakpoint()->uprobe_copy_insn() at the same time, this leads to numerous problems if UPROBE_COPY_INSN is not set. Just for example, the second

[PATCH 7/7] uprobes: Fix the racy uprobe->flags manipulation

2012-09-30 Thread Oleg Nesterov
Multiple threads can manipulate uprobe->flags, this is obviously unsafe. For example mmap can set UPROBE_COPY_INSN while register tries to set UPROBE_RUN_HANDLER, the latter can also race with can_skip_sstep() which clears UPROBE_SKIP_SSTEP. Change this code to use bitops. Signed-off-by: Oleg

[PATCH 5/7] uprobes: Introduce uprobe_copy_insn()

2012-09-30 Thread Oleg Nesterov
Preparation. Extract the copy_insn/arch_uprobe_analyze_insn code from install_breakpoint() into the new helper, uprobe_copy_insn(). And move uprobe->flags defines from uprobes.h to uprobes.c, nobody else can use them anyway. Signed-off-by: Oleg Nesterov --- include/linux/uprobes.h | 10

[PATCH 4/7] uprobes: Fix handle_swbp() vs unregister() + register() race

2012-09-30 Thread Oleg Nesterov
Strictly speaking this race was added by me in 56bb4cf6. However I think that this bug is just another indication that we should move copy_insn/uprobe_analyze_insn code from install_breakpoint() to uprobe_register(), there are a lot of other reasons for that. Until then, add a hack to close the

[PATCH 1/7] uprobes/x86: Only rep+nop can be emulated correctly

2012-09-30 Thread Oleg Nesterov
__skip_sstep() correctly detects the "nontrivial" nop insns, but since it doesn't update regs->ip we can not really skip "0x0f 0x1f | 0x0f 0x19 | 0x87 0xc0", the probed application is killed by SIGILL'ed handle_swbp(). Remove these additional checks. If we want to implement this correctly we need

[PATCH 3/7] uprobes: Do not delete uprobe if uprobe_unregister() fails

2012-09-30 Thread Oleg Nesterov
delete_uprobe() must not be called if register_for_each_vma(false) fails to remove all breakpoints, __uprobe_unregister() is correct. The problem is that register_for_each_vma(false) always returns 0 and thus this logic does not work. 1. Change verify_opcode() to return 0 rather than -EINVAL when

[PATCH 0/7] uprobes: register/unregister bugfixes

2012-09-30 Thread Oleg Nesterov
Hello. Misc bugfixes, mostly register/unregister related. Note: 4/7 and especially 6/7 are the really ugly (but hopefully temporary) hacks. We already discussed this, we should inspect the original insn in uprobe_register(). But this is not easy, and we need something simple to fix (some of) the

Re: The 10ms averager in fair.c

2012-09-30 Thread Uwaysi Bin Kareem
Just to illustrate, you have a filter that lasts 10ms, and a cpu process that lasts 100uS Original spike 5 | 4 | 3 | 2 | 1 | 0 | 0ms___10ms Filtered spike 5 4 3 2 1 . 0.. .. 0ms10ms Not only is the

Re: [PATCH] sysfs: sysfs_pathname/sysfs_add_one: Use strlcat() instead of strcat()

2012-09-30 Thread Geert Uytterhoeven
Hi Greg, On Sun, Sep 30, 2012 at 4:49 PM, Greg Kroah-Hartman wrote: > On Sat, Sep 29, 2012 at 10:23:19PM +0200, Geert Uytterhoeven wrote: >> The warning check for duplicate sysfs entries can cause a buffer overflow >> when printing the warning, as strcat() doesn't check buffer sizes. >> Use

Re: 3.6-rc7 32-bit PAE miscalculates dirty page limits

2012-09-30 Thread H. Peter Anvin
On 09/30/2012 02:38 AM, Pierre Beck wrote: Hi, there seems to be a bug in either ext4 or VM code triggered with 16 GB memory when compiled with 32-bit and PAE. dirty_background_ratio defaults to 10, dirty_ratio to 20. But in effect, dirty pages are strongly limited (zero or negative?). I

Re: hot CPU with 3.6.0-rc7+ and intel graphic

2012-09-30 Thread Samuel Ortiz
Hi, On Sun, Sep 30, 2012 at 05:06:43PM +0300, Anca Emanuel wrote: > On Sun, Sep 30, 2012 at 4:37 PM, Feng Tang wrote: > > Where can we get a powertop-2.1? I searched google and found > > git clone git://git.kernel.org/pub/scm/status/powertop/powertop.git > > is null now. > >

Re: [PATCH v2] psmouse: mitigate failing-mouse symptoms

2012-09-30 Thread Alessandro Rubini
> I think this would be less controversial if the run-time default were > to disable the feature. Yes, that's the common sensible path to new little-tested features. As you say, it may become enabled by default over time. Then, I think it would be good to have a specific sub-structure for this

Re: ABI change for setitimer(2) [in feature-removal-schedule.txt]

2012-09-30 Thread Linus Torvalds
On Sat, Sep 29, 2012 at 11:30 PM, Michael Kerrisk wrote: > >> I think the whole "let's deprecate this six months into the future" is >> unnecessary. Yes, it may well be worth doing for something with bigger >> consequences, but I think that for something like this, it's just >> overthinking the

Re: [PATCH v2] psmouse: mitigate failing-mouse symptoms

2012-09-30 Thread Jonathan Nieder
Hi Jim, In January, 2011, Jim Hill wrote: > Keep a failing PS/2 mouse usable until it's convenient to replace it. > Filter incoming packets: drop invalid ones and attempt to correct for > dropped bytes. > > New parameter 'filter' makes filtering and logging selectable, set to 0 > to shut off all

[PATCH RFC] pkt_sched: QFQ Plus: fair-queueing service at DRR cost

2012-09-30 Thread Paolo Valente
Hi, this patch turns QFQ into QFQ+, a faster variant of QFQ that groups classes into aggregates, and uses the original QFQ scheduling algorithm to schedule aggregates instead of single classes. An aggregate is made of at most M classes, all with the same weight and maximum packet size. M is equal

Re: ARM SoC tree, Was: Re: [PATCH 05/12] ARM: ixp4xx: use __iomem for MMIO

2012-09-30 Thread Krzysztof Halasa
Russell King - ARM Linux writes: >> Note I'm not only doing ARM, but also X86 and MIPS, with additional code >> shared between them, and the "stable" part of it is what I'm paid for. >> I can't simply work with arm-soc, none of my platforms will even boot >> with pure arm-soc. > > I'm assuming

Re: [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core

2012-09-30 Thread Sergei Shtylyov
Hello. On 28-09-2012 14:53, Kishon Vijay Abraham I wrote: Added dwc3 support for dwc3 core and update the documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I [...] diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 08a5738..0c17a7a

Re: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib

2012-09-30 Thread Roland Stigge
On 30/09/12 17:19, Stijn Devriendt wrote: >> If I understand correctly, it's a violation (single-value should hold >> for read and write). >> >> To solve it, I have the following in mind: /sys/.../gpiogroupXXX/ >> contains files "bit0" ... "bit31" which contain a gpio number each, >> empty if

Re: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib

2012-09-30 Thread Stijn Devriendt
On Sun, Sep 30, 2012 at 5:09 PM, Roland Stigge wrote: > Hi Stijn, > > On 30/09/12 16:52, Stijn Devriendt wrote: >>> One question: How did you solve the one-value-per-file in the sysfs >>> interface? >>> >> By exporting the group as a whole: >> /sys/.../gpiogroup248/value >> where value contains a

Re: hot CPU with 3.6.0-rc7+ and intel graphic

2012-09-30 Thread Toralf Förster
On 09/30/2012 03:37 PM, Feng Tang wrote: > Hi Toralf, Really weird, my commit only change the lpc_ich.c which affects the TCO_WDT > driver. but from your .config file, neither CONFIG_LPC_ICH nor the > CONFIG_ITCO_WDT is enabled, which means the commit should not affect > your kernel, could you

Re: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib

2012-09-30 Thread Stijn Devriendt
On Sun, Sep 30, 2012 at 12:34 PM, Roland Stigge wrote: > On 29/09/12 21:57, Jean-Christophe PLAGNIOL-VILLARD wrote: >>> Problem here is that it's only an intermediate format since hardware >>> often needs special preparation of the data. >>> >>> But will evaluate what makes most sense. >> the key

Re: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib

2012-09-30 Thread Roland Stigge
Hi Stijn, On 30/09/12 16:52, Stijn Devriendt wrote: >> One question: How did you solve the one-value-per-file in the sysfs >> interface? >> > By exporting the group as a whole: > /sys/.../gpiogroup248/value > where value contains a decimal representing the group value. > Again, this respects the

Re: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib

2012-09-30 Thread Stijn Devriendt
On Sun, Sep 30, 2012 at 12:50 PM, Roland Stigge wrote: > On 30/09/12 11:35, Stijn Devriendt wrote: >> In our kernel tree we have similar code. If you like I can request >> permission >> to share. I can, however, already give you an update on the basic >> structure, perhaps >> it's useful now. >>

Re: [PATCH] sysfs: sysfs_pathname/sysfs_add_one: Use strlcat() instead of strcat()

2012-09-30 Thread Greg Kroah-Hartman
On Sat, Sep 29, 2012 at 10:23:19PM +0200, Geert Uytterhoeven wrote: > The warning check for duplicate sysfs entries can cause a buffer overflow > when printing the warning, as strcat() doesn't check buffer sizes. > Use strlcat() instead. As the comment said, we knew about this, but I have never

Re: hot CPU with 3.6.0-rc7+ and intel graphic

2012-09-30 Thread Toralf Förster
On 09/30/2012 04:06 PM, Anca Emanuel wrote: > On Sun, Sep 30, 2012 at 4:37 PM, Feng Tang wrote: >> Where can we get a powertop-2.1? I searched google and found >> git clone git://git.kernel.org/pub/scm/status/powertop/powertop.git >> is null now. > > https://01.org/powertop/ >

Re: Re: 3.4.10 i915 [GM45] regression

2012-09-30 Thread Greg KH
On Sun, Sep 30, 2012 at 01:15:38PM +0200, Andreas Sturmlechner wrote: > > Ok, now reverted, thanks. > > > > greg k-h > > The same patch also breaks 3.0 for me. A 3.0.42 image with the patch > reverted was fine, I checked with several restarts. > > Sort of confirms there is something in >=3.5

re: Linux 3.6-rc7

2012-09-30 Thread Uwaysi Bin Kareem
Compiled 3.6-rc7, with a hz timer of 3956 for a "natural" psychovisual profile jitter level in OpenGL, and a shaved config for minimal jitter. Also changed the 10ms filter in fair.c to 1. And I suggest the whole filter to be removed. https://lkml.org/lkml/2012/9/30/78 There is very few clicks

Re: hot CPU with 3.6.0-rc7+ and intel graphic

2012-09-30 Thread Anca Emanuel
On Sun, Sep 30, 2012 at 4:37 PM, Feng Tang wrote: > Where can we get a powertop-2.1? I searched google and found > git clone git://git.kernel.org/pub/scm/status/powertop/powertop.git > is null now. https://01.org/powertop/ https://01.org/powertop/sites/default/files/downloads/powertop-2.1.tar.gz

Re: hot CPU with 3.6.0-rc7+ and intel graphic

2012-09-30 Thread Feng Tang
Hi Toralf, On Sat, 29 Sep 2012 10:16:11 +0200 Toralf Förster wrote: > > Hello, > > I'm observed hot CPUs at my ThinkPad T420 (i5-2540M CPU) w/ integrated > intel graphic with current git > Powertop-2.1 shows that the GPU is always at 100%. Where can we get a powertop-2.1? I searched google

Re: [PATCH 6/10] bug.h: Replace __linktime_error with __compiletime_error

2012-09-30 Thread Borislav Petkov
On Fri, Sep 28, 2012 at 09:04:35PM -0400, Steven Rostedt wrote: > On Fri, 2012-09-28 at 17:23 -0700, Josh Triplett wrote: > > On Fri, Sep 28, 2012 at 06:20:07PM -0500, Daniel Santos wrote: > > > Signed-off-by: Daniel Santos > > > --- > > > include/linux/bug.h |2 +- > > > 1 files changed, 1

Re: [PATCH 3/10] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro

2012-09-30 Thread Borislav Petkov
On Fri, Sep 28, 2012 at 06:20:04PM -0500, Daniel Santos wrote: > Throughout compiler*.h, many version checks are made. These can be > simplified by using the macro that gcc's documentation recommends. > However, my primary reason for adding this is that I need bug-check > macros that are enabled

re: Linux 3.5-rc7

2012-09-30 Thread Uwaysi Bin Kareem
Compiled 3.6-rc7, with a hz timer of 3956 for a "natural" psychovisual profile jitter level in OpenGL, and a shaved config for minimal jitter. Also changed the 10ms filter in fair.c to 1. And I suggest the whole filter to be removed. https://lkml.org/lkml/2012/9/30/78 There is very few

Re: [ 080/262] usb: gadget: dummy_hcd: fixup error probe path

2012-09-30 Thread Sebastian Andrzej Siewior
On Sat, Sep 29, 2012 at 09:01:15PM +0200, Ben Hutchings wrote: > > This is a problem since 448b6eb1 ("USB: Make sure to fetch the BOS desc > > for roothubs.) if used in USB3 mode because dummy does not provide this > > descriptor and explodes later. > [...] > > i.e. for 3.5 (as noted in the cc:

Re: [PATCH V2 3/3] workqueue: Schedule work on non-idle cpu instead of current one

2012-09-30 Thread Viresh Kumar
On 30 September 2012 14:24, Tejun Heo wrote: > On Thu, Sep 27, 2012 at 02:34:05PM +0530, Viresh Kumar wrote: >> - A cpu has programmed a timer and is IDLE now. >> - CPU gets into interrupt handler due to timer and queues a work. As the CPU >> is >> currently IDLE, we can queue this work to

Re: INFO: rcu_preempt detected stalls on CPUs/tasks: { 1} (detected by 0, t=10002 jiffies)

2012-09-30 Thread Fengguang Wu
On Sun, Sep 30, 2012 at 01:32:46PM +0200, Avi Kivity wrote: > On 09/30/2012 01:23 PM, Fengguang Wu wrote: > > On Sun, Sep 30, 2012 at 01:10:55PM +0200, Avi Kivity wrote: > >> On 09/28/2012 05:35 AM, Paul E. McKenney wrote: > >> > On Thu, Sep 27, 2012 at 12:40:44PM +0800, Fengguang Wu wrote: > >>

re: The 10ms averager in fair.c

2012-09-30 Thread Uwaysi Bin Kareem
I also did a quick hack changing some of those values, giving non-interrputed audiostream with audioapp alone, at 0.7ms. (on a core2duo @ 2.5ghz) That is actually better than BFS. Peace Be With You. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[PATCH 1/2] kstrto*: add documentation

2012-09-30 Thread Eldad Zack
As J. Bruce Fields pointed out, kstrto* is currently lacking kerneldoc comments. This patch adds kerneldoc comments to common variants of kstrto*: kstrto(u)l, kstrto(u)ll and kstrto(u)int. Cc: J. Bruce Fields Signed-off-by: Eldad Zack --- v2: includes typo fix from Joe Perches , added details

[PATCH 2/2] simple_strto*: annotate function as obsolete

2012-09-30 Thread Eldad Zack
This patch update the documentation to simple_strto* to reflect that it has been obsoleted and advise the usage of kstrto*. Cc: J. Bruce Fields Signed-off-by: Eldad Zack --- lib/vsprintf.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/lib/vsprintf.c

The 10ms averager in fair.c

2012-09-30 Thread Uwaysi Bin Kareem
Hiya. I just had an initial look at fair.c There seems to be a 10ms averager in there? You are aware that that means you work on delayed values? Isn`t that counterintuitive to the principle of sharing? That means short bursts of cpu-use will be filtered out, and given less cpu time.

Re: INFO: rcu_preempt detected stalls on CPUs/tasks: { 1} (detected by 0, t=10002 jiffies)

2012-09-30 Thread Avi Kivity
On 09/30/2012 01:23 PM, Fengguang Wu wrote: > On Sun, Sep 30, 2012 at 01:10:55PM +0200, Avi Kivity wrote: >> On 09/28/2012 05:35 AM, Paul E. McKenney wrote: >> > On Thu, Sep 27, 2012 at 12:40:44PM +0800, Fengguang Wu wrote: >> >> On Wed, Sep 26, 2012 at 09:28:50PM -0700, Paul E. McKenney wrote: >>

Re: INFO: rcu_preempt detected stalls on CPUs/tasks: { 1} (detected by 0, t=10002 jiffies)

2012-09-30 Thread Avi Kivity
On 09/30/2012 01:18 PM, Fengguang Wu wrote: > On Sun, Sep 30, 2012 at 01:10:55PM +0200, Avi Kivity wrote: >> On 09/28/2012 05:35 AM, Paul E. McKenney wrote: >> > On Thu, Sep 27, 2012 at 12:40:44PM +0800, Fengguang Wu wrote: >> >> On Wed, Sep 26, 2012 at 09:28:50PM -0700, Paul E. McKenney wrote: >>

Re: [PATCH v3 04/13] kmem accounting basic infrastructure

2012-09-30 Thread James Bottomley
On Sun, 2012-09-30 at 19:37 +0900, Tejun Heo wrote: > Hello, James. > > On Sun, Sep 30, 2012 at 09:56:28AM +0100, James Bottomley wrote: > > The beancounter approach originally used by OpenVZ does exactly this. > > There are two specific problems, though, firstly you can't count > > references in

Re: INFO: rcu_preempt detected stalls on CPUs/tasks: { 1} (detected by 0, t=10002 jiffies)

2012-09-30 Thread Fengguang Wu
On Sun, Sep 30, 2012 at 01:10:55PM +0200, Avi Kivity wrote: > On 09/28/2012 05:35 AM, Paul E. McKenney wrote: > > On Thu, Sep 27, 2012 at 12:40:44PM +0800, Fengguang Wu wrote: > >> On Wed, Sep 26, 2012 at 09:28:50PM -0700, Paul E. McKenney wrote: > >> > On Thu, Sep 27, 2012 at 10:54:00AM +0800,

Re: Re: 3.4.10 i915 [GM45] regression

2012-09-30 Thread Andreas Sturmlechner
> Ok, now reverted, thanks. > > greg k-h The same patch also breaks 3.0 for me. A 3.0.42 image with the patch reverted was fine, I checked with several restarts. Sort of confirms there is something in >=3.5 that makes this thing work. Regards -- To unsubscribe from this list: send the line

Re: [PATCH RFC 1/2] kvm: Handle undercommitted guest case in PLE handler

2012-09-30 Thread Avi Kivity
On 09/30/2012 01:07 PM, Gleb Natapov wrote: > On Sun, Sep 30, 2012 at 10:18:17AM +0200, Avi Kivity wrote: >> On 09/28/2012 08:16 AM, Raghavendra K T wrote: >> > >> >> >> >> +struct pv_sched_info { >> >> + unsigned long sched_bitmap; >> > >> > Thinking, whether we need something

  1   2   3   4   >