Re: [PATCH 00/50] staging: omap-thermal: several code refactoring

2013-03-16 Thread Dan Carpenter
I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't really like the bunny hop patches and I'm trying to discourage that going forward. ;P But I wouldn't say it's a Redo the whole thing kind of problem. Could just resend

Re: Getting kernel uImage build issue on omap2+

2013-03-16 Thread Javier Martinez Canillas
On Sat, Mar 16, 2013 at 5:44 AM, Anil Kumar anilk...@gmail.com wrote: Hi, I am getting kernel uImage build issue on omap2+ log[1] Taken kernel branch for_3.10/dts from https://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git Taking reference from

Re: [PATCH] hpet, allow user controlled mmap for user processes

2013-03-16 Thread Clemens Ladisch
Prarit Bhargava wrote: The CONFIG_HPET_MMAP Kconfig option exposes the memory map of the HPET registers to userspace. The Kconfig help points out that in some cases this can be a security risk as some systems may erroneously configure the map such that additional data is exposed to userspace.

[PATCH v5 0/2] ARM: davinci: dm355: add support for vpbe display

2013-03-16 Thread Prabhakar lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch series enables VPBE display driver on DM355. Changes for v5: 1: Rebased on 3.9, fix review comments pointed by Sekhar for DM365 series. Changes for v4: 1: pass different platform names to handle different ip's. Changes for v3: 1:

[PATCH v5 1/2] ARM: davinci: dm355: add support for v4l2 video display

2013-03-16 Thread Prabhakar lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm355. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- arch/arm/mach-davinci/board-dm355-evm.c |4 +- arch/arm/mach-davinci/davinci.h

Re: [Intel-gfx] [PATCH] drm/i915: Sanity check incoming ioctl data for a NULL pointer

2013-03-16 Thread Chris Wilson
On Fri, Mar 15, 2013 at 04:49:42PM -0700, Ben Widawsky wrote: On Fri, Mar 15, 2013 at 10:06:19PM +, Chris Wilson wrote: On Fri, Mar 15, 2013 at 09:36:07AM -0700, Ben Widawsky wrote: On Fri, Mar 15, 2013 at 08:24:03AM +, Chris Wilson wrote: That's what I thought too. Looking at

[PATCH v5 2/2] ARM: davinci: dm355 EVM: add support for VPBE display

2013-03-16 Thread Prabhakar lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com add support for V4L2 video display to DM355 EVM. Support for SD modes is provided, along with Composite output Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- arch/arm/mach-davinci/board-dm355-evm.c | 69

Re: [PATCH 3/6] OF: Export all DT proc update functions

2013-03-16 Thread Grant Likely
On Fri, 4 Jan 2013 21:31:07 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: There are other users for the proc DT functions. Export them. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com Hi Pantelis. Patches 1 2 look good. No comments there. This patch

Re: [PATCH 3/6] OF: Export all DT proc update functions

2013-03-16 Thread Grant Likely
On Fri, 4 Jan 2013 21:31:07 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: There are other users for the proc DT functions. Export them. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com Actually, I cannot find the user of this patch. Why is it needed? g. -- To

Re: [PATCH 5/6] OF: Introduce Device Tree resolve support.

2013-03-16 Thread Grant Likely
On Wed, 23 Jan 2013 12:58:02 +0200, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi David, On Jan 23, 2013, at 6:40 AM, David Gibson wrote: Ok. Nonetheless it's not hard to avoid a recursive approach here. How can I find the maximum phandle value of a subtree without using

Re: 3.8.2-3.8.3 i915 regression: GMBUS [i915 gmbus dpb] timed out, falling back to bit banging on pin 5

2013-03-16 Thread Arkadiusz Miskiewicz
On Thursday 14 of March 2013, Arkadiusz Miskiewicz wrote: Hello. After upgrading from 3.8.2 to 3.8.3 I'm getting regression : More people hits this: https://bugzilla.redhat.com/show_bug.cgi?id=922304 https://bugs.archlinux.org/task/34327 (seems always GM45 gpu in these reports) archlinux

Re: Getting kernel uImage build issue on omap2+

2013-03-16 Thread Anil Kumar
Hi Javier, On Sat, Mar 16, 2013 at 2:53 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Sat, Mar 16, 2013 at 5:44 AM, Anil Kumar anilk...@gmail.com wrote: Hi, I am getting kernel uImage build issue on omap2+ log[1] Taken kernel branch for_3.10/dts from

[PATCH v1 5/9] x86, mm, numa, acpi: Extend movablemem_map to the end of each node.

2013-03-16 Thread Tang Chen
When implementing movablemem_map boot option, we introduced an array movablemem_map.map[] to store the memory ranges to be set as ZONE_MOVABLE. Since ZONE_MOVABLE is the latst zone of a node, if user didn't specify the whole node memory range, we need to extend it to the node end so that we can

[PATCH v1 7/9] x86, mm, numa, acpi: Sanitize zone_movable_limit[].

2013-03-16 Thread Tang Chen
As mentioned by Liu Jiang and Wu Jiangguo, users could specify DMA, DMA32, and HIGHMEM as movable. In order to ensure the kernel will work correctly, we should exclude these memory ranges out from zone_movable_limit[]. NOTE: Do find_usable_zone_for_movable() to initialize movable_zone so

[PATCH v1 6/9] x86, mm, numa, acpi: Support getting hotplug info from SRAT.

2013-03-16 Thread Tang Chen
We now provide an option for users who don't want to specify physical memory address in kernel commandline. /* * For movablemem_map=acpi: * * SRAT:|_| |_| |_| |_| .. * node id:0 1

[PATCH v1 8/9] x86, mm, numa, acpi: make movablemem_map have higher priority

2013-03-16 Thread Tang Chen
If kernelcore or movablecore is specified at the same time with movablemem_map, movablemem_map will have higher priority to be satisfied. This patch will make find_zone_movable_pfns_for_nodes() calculate zone_movable_pfn[] with the limit from zone_movable_limit[]. Signed-off-by: Tang Chen

[PATCH v1 part1 0/9] Introduce movablemem_map boot option.

2013-03-16 Thread Tang Chen
Hi Yinghai, all, As Yinghai have implemented parsing numa info early more considerately, I think we can introduce the movablemem_map boot option again. This patch-set is based on Linux 3.9 rc-2, but need to apply Yinghai's x86, ACPI, numa: Parse numa info early patch-set first. Please refer to:

[PATCH v1 4/9] x86, mm, numa, acpi: Introduce zone_movable_limit[] to store start pfn of ZONE_MOVABLE.

2013-03-16 Thread Tang Chen
Since node info in SRAT may not be in increasing order, we may meet a lower range after we handled a higher range. So we need to keep the lowest movable pfn each time we parse a SRAT memory entry, and update it when we get a lower one. This patch introduces a new array zone_movable_limit[], which

[PATCH v1 1/9] x86: get pg_data_t's memory from other node

2013-03-16 Thread Tang Chen
From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com If system can create movable node which all memory of the node is allocated as ZONE_MOVABLE, setup_node_data() cannot allocate memory for the node's pg_data_t. So, use memblock_alloc_try_nid() instead of memblock_alloc_nid() to retry when the

[PATCH v1 9/9] x86, mm, numa, acpi: Memblock limit with movablemem_map

2013-03-16 Thread Tang Chen
Ensure memblock will not allocate memory from areas that may be ZONE_MOVABLE. The map info is from movablemem_map boot option. The following problem was reported by Stephen Rothwell: The definition of struct movablecore_map is protected by CONFIG_HAVE_MEMBLOCK_NODE_MAP but its use in

[PATCH v1 2/9] acpi: Print hotplug info in SRAT.

2013-03-16 Thread Tang Chen
The Hot Pluggable field in SRAT points out if the memory could be hotplugged while the system is running. It is useful to print out this info when parsing SRAT. Signed-off-by: Tang Chen tangc...@cn.fujitsu.com --- arch/x86/mm/srat.c |9 ++--- 1 files changed, 6 insertions(+), 3

Re: OOM triggered with plenty of memory free

2013-03-16 Thread Jonathan Woithe
On Sat, Mar 16, 2013 at 02:33:23AM -0700, Raymond Jennings wrote: On Sat, Mar 16, 2013 at 2:25 AM, Hillf Danton dhi...@gmail.com wrote: Some system specifications: - CPU: i7 860 at 2.8 GHz - Mainboard: Advantech AIMB-780 - RAM: 4 GB - Kernel: 2.6.35.11 SMP, 32 bit (kernel.org kernel, no

[PATCH v1 3/9] x86, mm, numa, acpi: Add movable_memmap boot option.

2013-03-16 Thread Tang Chen
Add functions to parse movablemem_map boot option. Since the option could be specified more then once, all the maps will be stored in the global array movablemem_map.map[]. And also, we keep the array in monotonic increasing order by start_pfn. And merge all overlapped ranges. Signed-off-by:

[PATCH] sound: soc: fix invalid free of devm_ allocated data

2013-03-16 Thread Silviu-Mihai Popescu
The objects allocated by devm_* APIs are managed by devres and are freed when the device is detached. Hence there is no need to use kfree() explicitly. Signed-off-by: Silviu-Mihai Popescu silviupopescu1...@gmail.com --- sound/soc/soc-core.c |2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH] [trivial]treewide: Fix typos in printk and comment

2013-03-16 Thread Masanari Iida
Correct spelling typos Signed-off-by: Masanari Iida standby2...@gmail.com --- arch/arc/plat-arcfpga/Kconfig | 2 +- arch/blackfin/include/asm/bfin_sport3.h | 2 +- arch/s390/kernel/irq.c | 2 +- arch/s390/kvm/trace.h | 2 +-

[PATCH] imx_drm: ipu_v3: fix invalid free of devm_* allocated data

2013-03-16 Thread Silviu-Mihai Popescu
The objects allocated by devm_* APIs are managed by devres and are freed when the device is detached. There is no need to use kfree() explicitly. Signed-off-by: Silviu-Mihai Popescu silviupopescu1...@gmail.com --- drivers/staging/imx-drm/ipu-v3/ipu-dp.c |1 - 1 file changed, 1 deletion(-)

drm/i915: new warning (regression) in 3.7.10 and 3.8.3

2013-03-16 Thread Richard Cochran
I have an Acer Aspire One netbook, and on it I get the following warning when closing and opening the lid. I think this warning first appeared in 3.7. Does this need fixing? If so, who can do it? Thanks, Richard ** close lid Mar 16 11:32:03 netboy kernel: [ 287.429404]

Re: [PATCH 07/50] staging: omap-thermal: introduce RMW_BITS macro

2013-03-16 Thread Eduardo Valentin
Hello Dan, On 15-03-2013 17:09, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 08:59:55AM -0400, Eduardo Valentin wrote: This patch introduce a macro to read, update, write bitfields. It will be specific to bandgap data structures. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com ---

Re: use after free in sysfs_find_dirent

2013-03-16 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:04 PM, Sasha Levin levinsasha...@gmail.com wrote: On 03/15/2013 12:03 AM, Sasha Levin wrote: On 03/07/2013 01:26 AM, Dave Jones wrote: On Thu, Mar 07, 2013 at 02:02:30PM +0800, Greg Kroah-Hartman wrote: On Thu, Mar 07, 2013 at 12:28:54AM -0500, Dave Jones wrote:

Re: [PATCH 09/50] staging: omap-thermal: make a omap_bandgap_power with only one exit point

2013-03-16 Thread Eduardo Valentin
Hey Dan, On 15-03-2013 17:22, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 08:59:57AM -0400, Eduardo Valentin wrote: Change the way the omap_bandgap_power is written so that it has only one exit entry (Documentation/CodingStyle). It's only if there is an unlock or something that you should

Re: [PATCH 47/50] staging: omap-thermal: switch mutex to spinlock inside omap-bandgap

2013-03-16 Thread Eduardo Valentin
On 16-03-2013 04:59, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 09:00:35AM -0400, Eduardo Valentin wrote: Because there is a need to lock inside IRQ handler, this patch changes the locking mechanism inside the omap-bandgap.[c,h] to spinlocks. Now this lock is used to protect omap_bandgap

Re: [PATCH 00/50] staging: omap-thermal: several code refactoring

2013-03-16 Thread Eduardo Valentin
Hello Dan, On 16-03-2013 05:05, Dan Carpenter wrote: I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't really like the bunny hop patches and I'm trying to discourage that going forward. ;P But I wouldn't say it's a Redo

Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values

2013-03-16 Thread Eduardo Valentin
On 16-03-2013 04:39, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote: if (ret) { dev_err(bg_ptr-dev, failed to read thot\n); - return -EIO; + ret = -EIO; + goto exit; } - *thot

mmc: rts_pstor worked fine, but rtsx_pci_sdmmc does not

2013-03-16 Thread Richard Cochran
I have an Acer Aspire One netbook with a built in card reader, and I have two cards, one with 32 MB and one with 4 GB. The card reader used to work with the staging driver in 3.7.10, but the new 3.8.3 driver does not work with the larger card. The old driver was removed in commit cd211222. Now,

Re: [PATCH] wireless:iwlwifi: changed kmalloc+memcpy with kmemdup

2013-03-16 Thread Johannes Berg
Applied. johannes -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 1/4] introduce zero filled pages handler

2013-03-16 Thread Konrad Rzeszutek Wilk
On Thu, Mar 14, 2013 at 06:08:14PM +0800, Wanpeng Li wrote: Introduce zero-filled pages handler to capture and handle zero pages. Acked-by: Dan Magenheimer dan.magenhei...@oracle.com Signed-off-by: Wanpeng Li liw...@linux.vnet.ibm.com --- drivers/staging/zcache/zcache-main.c | 26

Re: [PATCH v2 3/4] introduce zero-filled page stat count

2013-03-16 Thread Konrad Rzeszutek Wilk
On Thu, Mar 14, 2013 at 06:08:16PM +0800, Wanpeng Li wrote: Introduce zero-filled page statistics to monitor the number of zero-filled pages. Hm, you must be using an older version of the driver. Please rebase it against Greg KH's staging tree. This is where most if not all of the DebugFS

Re: [PATCH v2 2/4] zero-filled pages awareness

2013-03-16 Thread Konrad Rzeszutek Wilk
On Thu, Mar 14, 2013 at 06:08:15PM +0800, Wanpeng Li wrote: Compression of zero-filled pages can unneccessarily cause internal fragmentation, and thus waste memory. This special case can be optimized. This patch captures zero-filled pages, and marks their corresponding zcache backing page

[PATCH] firewire: Remove two unneeded checks for macros

2013-03-16 Thread Paul Bolle
The old IEEE 1394 driver stack was removed in v2.6.37. That made the checks for two Kconfig (module) macros unneeded, since they will now always evaluate to true. Remove these two checks. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Perhaps these alias can be dropped entirely. Bat that's not

Re: [PATCH v3 3/5] handle zcache_[eph|pers]_zpages for zero-filled page

2013-03-16 Thread Konrad Rzeszutek Wilk
On Fri, Mar 15, 2013 at 10:34:18AM +0800, Wanpeng Li wrote: Increment/decrement zcache_[eph|pers]_zpages for zero-filled pages, the main point of the counters for zpages and pageframes is to be able to calculate density == zpages/pageframes. A zero-filled page becomes a zpage that compresses

Re: use after free in sysfs_find_dirent

2013-03-16 Thread Ming Lei
On Sat, Mar 16, 2013 at 8:39 PM, Hillf Danton dhi...@gmail.com wrote: init rb node before use due to empty node checked by rb_next(). --- a/fs/sysfs/dir.cSat Mar 16 20:12:16 2013 +++ b/fs/sysfs/dir.cSat Mar 16 20:37:10 2013 @@ -396,6 +396,7 @@ struct sysfs_dirent *sysfs_new_dirent(co

[PATCH] zcache/TODO: Update on two items.

2013-03-16 Thread Konrad Rzeszutek Wilk
Two of them (zcache DebugFS cleanup) and the module loading capability are now in linux-next for v3.10. Also Bob Liu is full-time going to help on knocking these items off the list. CC: bob@oracle.com Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com ---

Re: [ 11/21] hwmon: (sht15) Check return value of regulator_enable()

2013-03-16 Thread Guenter Roeck
On Sat, Mar 16, 2013 at 04:15:24AM +, Ben Hutchings wrote: On Tue, 2013-03-12 at 15:44 -0700, Greg Kroah-Hartman wrote: 3.0-stable review patch. If anyone has any objections, please let me know. -- From: Mark Brown broo...@opensource.wolfsonmicro.com commit

[RFC PATCH] seq_file: Use seq_puts when seq_printf has only a format with no args

2013-03-16 Thread Joe Perches
Instead of converting the 800 or so uses of seq_printf with a constant format (without a % substitution) to seq_puts, maybe there's another way to slightly speed up these outputs. Taking a similar approach to commit abd84d60eb (tracing: Optimize trace_printk() with one arg to use trace_puts())

Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

2013-03-16 Thread J. R. Okajima
Al Viro: Sure - btrfs happens to have an interesting limit on the number of links to the same object located in one directory. It doesn't matter. On every filesystem, the link count has its upper limit eventually. When vfs_link() for whiteout returns EMLINK, aufs removes the whiteout-src file

Re: [PATCH 09/50] staging: omap-thermal: make a omap_bandgap_power with only one exit point

2013-03-16 Thread Dan Carpenter
On Sat, Mar 16, 2013 at 08:39:11AM -0400, Eduardo Valentin wrote: Hey Dan, On 15-03-2013 17:22, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 08:59:57AM -0400, Eduardo Valentin wrote: Change the way the omap_bandgap_power is written so that it has only one exit entry

Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

2013-03-16 Thread J. R. Okajima
Linus Torvalds: Yes. That would be lovely. And trivial for most filesystems to support. Sure, you could have an inode if you need to (not all filesystems may have a flag in the directory entry), so it would look like mknod() for the filesystem. But the filesystem might decide to never

Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values

2013-03-16 Thread Dan Carpenter
On Sat, Mar 16, 2013 at 08:49:20AM -0400, Eduardo Valentin wrote: On 16-03-2013 04:39, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote: if (ret) { dev_err(bg_ptr-dev, failed to read thot\n); - return -EIO; + ret =

Re: [PATCH 07/50] staging: omap-thermal: introduce RMW_BITS macro

2013-03-16 Thread Dan Carpenter
On Sat, Mar 16, 2013 at 08:36:51AM -0400, Eduardo Valentin wrote: But that said, I don't care for the RMW_BITS() very much as a long term thing. If we just used pointers instead of passing the offset into the bg_ptr-conf-sensors[] array then everything would be a lot cleaner. In other

Re: [PATCHv7 1/8] zsmalloc: add to mm/

2013-03-16 Thread Bob Liu
On 03/06/2013 11:52 PM, Seth Jennings wrote: = DO NOT MERGE, FOR REVIEW ONLY This patch introduces zsmalloc as new code, however, it already exists in drivers/staging. In order to build successfully, you must select EITHER to driver/staging version OR this version. Once zsmalloc

Re: [PATCH v3 2/5] zero-filled pages awareness

2013-03-16 Thread Bob Liu
On 03/15/2013 10:34 AM, Wanpeng Li wrote: Compression of zero-filled pages can unneccessarily cause internal fragmentation, and thus waste memory. This special case can be optimized. This patch captures zero-filled pages, and marks their corresponding zcache backing page entry as

Re: [PATCH 47/50] staging: omap-thermal: switch mutex to spinlock inside omap-bandgap

2013-03-16 Thread Dan Carpenter
On Sat, Mar 16, 2013 at 08:41:30AM -0400, Eduardo Valentin wrote: On 16-03-2013 04:59, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 09:00:35AM -0400, Eduardo Valentin wrote: @@ -502,9 +504,9 @@ int _omap_bandgap_write_threshold(struct omap_bandgap *bg_ptr, int id, int val, if (ret 0)

Re: [RFC: PATCH 2/2] iio: adc: exynos_adc: Handle timeout and race conditions

2013-03-16 Thread Lars-Peter Clausen
On 03/16/2013 01:37 AM, Doug Anderson wrote: On Fri, Mar 15, 2013 at 2:53 PM, Lars-Peter Clausen l...@metafoo.de wrote: What exactly is the spinlock protecting against here? Concurrent runs of exynos_adc_isr? This is probably not issue in the first place. What you want to protect against is

Re: [PATCH 1/5] net: Add davicom wemac ethernet driver found on Allwinner A10 SoC's

2013-03-16 Thread Florian Fainelli
Hello Maxime, Stefan, Please find below some comments regarding your PHY implementation in the driver as well as the transmit and transmit completion routines. Le vendredi 15 mars 2013 21:50:00, Maxime Ripard a écrit : From: Stefan Roese s...@denx.de The Allwinner A10 has an ethernet

Re: [PATCH V2 RESEND 1/2] regmap: irq: Add support for interrupt type

2013-03-16 Thread Laxman Dewangan
On Wednesday 13 March 2013 01:25 AM, Mark Brown wrote: * PGP Signed by an unknown key On Thu, Mar 07, 2013 at 10:03:17PM +0530, Laxman Dewangan wrote: /** + * The Regmap IRQ type Index + * REGMAP_IRQ_TYPE_NONE is used for setting inital value for clearing type. + */ +enum { +

Re: [PATCH 1/5] net: Add davicom wemac ethernet driver found on Allwinner A10 SoC's

2013-03-16 Thread Alexander Shiyan
From: Stefan Roese s...@denx.de The Allwinner A10 has an ethernet controller that is advertised as coming from Davicom. The exact feature set of this controller is unknown, since there is no public documentation for this IP, and this driver is mostly the one published by Allwinner that

Re: [PATCH] clk: add DT test clock consumer driver

2013-03-16 Thread Arnd Bergmann
On Saturday 16 March 2013, Sebastian Hesselbarth wrote: This driver adds a DT test clock consumer that exposes debugfs files to enable/disable and set/get rate of the attached programmable clock. During development of a i2c-attached clock generator I found it useful to debug the clock

Re: [PATCH 3/3] misc: ep93xx_pwm.c: fix section mismatch and use module_platform_driver

2013-03-16 Thread Arnd Bergmann
On Saturday 16 March 2013, H Hartley Sweeten wrote: Remove the __init tags from the ep93xx_pwm_probe() and ep93xx_pwm_remove() functions to fix the section mismatch warnings. Use module_platform_driver() to remove the init/exit boilerplate. Signed-off-by: H Hartley Sweeten

Re: use after free in sysfs_find_dirent

2013-03-16 Thread Sasha Levin
On 03/16/2013 09:30 AM, Ming Lei wrote: On Sat, Mar 16, 2013 at 8:39 PM, Hillf Danton dhi...@gmail.com wrote: init rb node before use due to empty node checked by rb_next(). --- a/fs/sysfs/dir.cSat Mar 16 20:12:16 2013 +++ b/fs/sysfs/dir.cSat Mar 16 20:37:10 2013 @@ -396,6 +396,7 @@

Re: CONFIG_EARLY_PRINTK

2013-03-16 Thread Thomas Meyer
Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap: On 03/13/13 10:15, Thomas Meyer wrote: Hi, -*- Early printk help text says: You should normally N here, unless you want to debug such a crash. (Depends on: EXPERT [=n]) How to normally N here? You'll have to

Re: [PATCH v2] clk: add si5351 i2c common clock driver

2013-03-16 Thread Daniel Mack
Hi Sebastian, On 16.03.2013 14:10, Sebastian Hesselbarth wrote: This patch adds a common clock driver for Silicon Labs Si5351a/b/c i2c programmable clock generators. Currently, the driver supports DT kernels only and VXCO feature of si5351b is not implemented. DT bindings selectively allow to

Re: use after free in sysfs_find_dirent

2013-03-16 Thread Ming Lei
On Sat, Mar 16, 2013 at 11:07 PM, Sasha Levin levinsasha...@gmail.com wrote: Hi Ming, With your patch: [ 1525.874312] release_sysfs_dirent sysfs_dirent use after free: ptysb-uevent Sasha, thanks for your test. So is the oops always triggered on this node of 'ptysb-uevent' or the node name

[PATCH] mm/fremap.c: fix another oops on error path

2013-03-16 Thread Ming Lei
Since find_vma() may return NULL, so don't dereference the returned 'vma' until it is valid. The problem is introduced by the commit in linus tree: 6d7825b(mm/fremap.c: fix oops on error path). Also mark vm_flags as ninitialized_var() to avoid compile warning. Cc: Tommi Rantala

Re: [RFC PATCH] seq_file: Use seq_puts when seq_printf has only a format with no args

2013-03-16 Thread Bjorn Helgaas
On Sat, Mar 16, 2013 at 7:50 AM, Joe Perches j...@perches.com wrote: Instead of converting the 800 or so uses of seq_printf with a constant format (without a % substitution) to seq_puts, maybe there's another way to slightly speed up these outputs. Taking a similar approach to commit

Re: [RFC PATCH] seq_file: Use seq_puts when seq_printf has only a format with no args

2013-03-16 Thread Steven Rostedt
My macro nastiness is contagious ;-) On Sat, 2013-03-16 at 06:50 -0700, Joe Perches wrote: Instead of converting the 800 or so uses of seq_printf with a constant format (without a % substitution) to seq_puts, maybe there's another way to slightly speed up these outputs. Taking a similar

Re: use after free in sysfs_find_dirent

2013-03-16 Thread Ming Lei
On Sat, Mar 16, 2013 at 11:22 PM, Ming Lei tom.leim...@gmail.com wrote: On Sat, Mar 16, 2013 at 11:07 PM, Sasha Levin levinsasha...@gmail.com wrote: Hi Ming, With your patch: [ 1525.874312] release_sysfs_dirent sysfs_dirent use after free: ptysb-uevent Sasha, thanks for your test. So

Re: use after free in sysfs_find_dirent

2013-03-16 Thread Sasha Levin
On 03/16/2013 11:22 AM, Ming Lei wrote: On Sat, Mar 16, 2013 at 11:07 PM, Sasha Levin levinsasha...@gmail.com wrote: Hi Ming, With your patch: [ 1525.874312] release_sysfs_dirent sysfs_dirent use after free: ptysb-uevent Sasha, thanks for your test. So is the oops always triggered on

Re: [PATCH] perf,x86: fix kernel crash with PEBS/BTS after suspend/resume

2013-03-16 Thread Parag Warudkar
On Fri, Mar 15, 2013 at 9:26 AM, Stephane Eranian eran...@google.com wrote: This patch fixes a kernel crash when using precise sampling (PEBS) after a suspend/resume. Turns out the CPU notifier code is not invoked on CPU0 (BP). Therefore, the DS_AREA (used by PEBS) is not restored properly by

Re: [RFC PATCH] seq_file: Use seq_puts when seq_printf has only a format with no args

2013-03-16 Thread Steven Rostedt
On Sat, 2013-03-16 at 09:43 -0600, Bjorn Helgaas wrote: This is certainly a neat trick. Thank you ;-) But I don't really like the fact that it complicates things for every future code reader, especially when a trivial change in the caller would accomplish the same thing. Do you have any

Re: [PATCH 00/50] staging: omap-thermal: several code refactoring

2013-03-16 Thread Greg KH
On Sat, Mar 16, 2013 at 08:46:03AM -0400, Eduardo Valentin wrote: Hello Dan, On 16-03-2013 05:05, Dan Carpenter wrote: I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't really like the bunny hop patches and I'm

Re: [RFC PATCH] seq_file: Use seq_puts when seq_printf has only a format with no args

2013-03-16 Thread Joe Perches
On Sat, 2013-03-16 at 11:57 -0400, Steven Rostedt wrote: My macro nastiness is contagious ;-) True. On Sat, 2013-03-16 at 06:50 -0700, Joe Perches wrote: +int (seq_printf)(struct seq_file *m, const char *f, ...) That's rather ugly. Why not just #undef seq_printf before defining it? The

Re: [RFC PATCH 0/2] fs: sysfs: Add devres support

2013-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 14, 2013 at 08:24:45PM -0700, Guenter Roeck wrote: Provide devres functions for device_create_file, sysfs_create_file, and sysfs_create_group plus the respective remove functions. Idea is to be able to drop calls to the remove functions from the various drivers using those calls.

Re: [PATCH v2] sp5100_tco: Remove code that may cause a boot failure

2013-03-16 Thread Tanaka Takahisa
Hi Wim, I found out the commit of this patch in the linux-next. Thank you for improving the commit log. I am sorry for all the trouble I have caused you and Paul. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=84a9a694633692d54c8b969664ce8fd115fa09f9 Best regards,

[PATCH] ath9k : Fix ieee80211 work while going to suspend

2013-03-16 Thread Parag Warudkar
During suspend below warning is seen when ath9k is active. Attached patch fixes the warning for me. Tested to work across few suspend-resume cycles. Mar 16 09:39:17 Parags-iMac kernel: [ 3993.642939] WARNING: at net/mac80211/util.c:599 ieee80211_can_queue_work.isra.7+0x32/0x40 [mac80211]() Mar

Re: [RFC PATCH] seq_file: Use seq_puts when seq_printf has only a format with no args

2013-03-16 Thread Steven Rostedt
On Sat, 2013-03-16 at 09:15 -0700, Joe Perches wrote: +int (seq_printf)(struct seq_file *m, const char *f, ...) That's rather ugly. Why not just #undef seq_printf before defining it? The whole thing is ugly, nasty and hackish. I kinda like it. But I don't like unnecessary undefs.

[PATCH v2, part3 00/12] accurately calculate zone-managed_pages

2013-03-16 Thread Jiang Liu
The original goal of this patchset is to fix the bug reported by https://bugzilla.kernel.org/show_bug.cgi?id=53501 Now it has also been expanded to reduce common code used by memory initializion. This is the third part, previous two patch sets could be accessed at:

[PATCH v2, part3 01/12] mm: enhance free_reserved_area() to support poisoning memory with zero

2013-03-16 Thread Jiang Liu
Address comments from last round of code review. 1) Enhance free_reserved_area() to support poisoning memory with zero. This could be used to get rid of poison_init_mem() on ARM64. 2) Other minor fixes. Signed-off-by: Jiang Liu jiang@huawei.com Cc: Geert Uytterhoeven ge...@linux-m68k.org

[PATCH v2, part3 04/12] mm/tile: use common help functions to free reserved pages

2013-03-16 Thread Jiang Liu
Use common help functions to free reserved pages. Signed-off-by: Jiang Liu jiang@huawei.com Cc: Chris Metcalf cmetc...@tilera.com Cc: Wen Congyang we...@cn.fujitsu.com Cc: linux-kernel@vger.kernel.org --- arch/tile/mm/init.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-)

[PATCH v2, part3 06/12] mm/acornfb: use common help functions to free reserved pages

2013-03-16 Thread Jiang Liu
Use common help functions to free reserved pages. Signed-off-by: Jiang Liu jiang@huawei.com Cc: Florian Tobias Schandinat Cc: linux-fb...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/video/acornfb.c | 28 ++-- 1 file changed, 2 insertions(+), 26

[PATCH v2, part3 08/12] mm: use a dedicated lock to protect totalram_pages and zone-managed_pages

2013-03-16 Thread Jiang Liu
Currently lock_memory_hotplug()/unlock_memory_hotplug() are used to protect totalram_pages and zone-managed_pages. Other than the memory hotplug driver, totalram_pages and zone-managed_pages may be modified by Xen balloon, virtio_balloon etc at runtime. For those case, memory hotplug lock is a

[PATCH v2, part3 07/12] mm: accurately calculate zone-managed_pages for highmem zones

2013-03-16 Thread Jiang Liu
Commit mm: introduce new field 'managed_pages' to struct zone assumes that all highmem pages will be freed into the buddy system by function mem_init(). But that's not always true, some architectures may reserve some highmem pages during boot. For example PPC may allocate highmem pages for giagant

[PATCH v2, part3 09/12] mm: avoid using __free_pages_bootmem() at runtime

2013-03-16 Thread Jiang Liu
Avoid using __free_pages_bootmem() at runtime, so we could easily manage totalram_pages and zone-managed_pages. With this change applied, __free_pages_bootmem() is only used by bootmem.c and nobootmem.c at boot time, so mark it as __init. And other callers of __free_pages_bootmem() have been

[PATCH v2, part3 10/12] mm: correctly update zone-mamaged_pages

2013-03-16 Thread Jiang Liu
Enhance adjust_managed_page_count() to adjust totalhigh_pages for highmem pages. And change code which directly adjusts totalram_pages to use adjust_managed_page_count() because it adjusts totalram_pages, totalhigh_pages and zone-managed_pages altogether in a safe way. Remove

[PATCH v2, part3 11/12] mm: report available pages as MemTotal for each NUMA node

2013-03-16 Thread Jiang Liu
As reported by https://bugzilla.kernel.org/show_bug.cgi?id=53501, MemTotal from /proc/meminfo means memory pages managed by the buddy system (managed_pages), but MemTotal from /sys/.../node/nodex/meminfo means phsical pages present (present_pages) within the NUMA node. There's a difference between

[PATCH v2, part3 03/12] mm/x86: use common help functions to furthur simplify code

2013-03-16 Thread Jiang Liu
Use common help functions to free reserved pages. Signed-off-by: Jiang Liu jiang@huawei.com Cc: Thomas Gleixner t...@linutronix.de Cc: Ingo Molnar mi...@redhat.com Cc: H. Peter Anvin h...@zytor.com Cc: x...@kernel.org Cc: Yinghai Lu ying...@kernel.org Cc: Tang Chen tangc...@cn.fujitsu.com Cc:

[PATCH v2, part3 05/12] mm/powertv: use common help functions to free reserved pages

2013-03-16 Thread Jiang Liu
Use common help functions to free reserved pages. Signed-off-by: Jiang Liu jiang@huawei.com Cc: Ralf Baechle r...@linux-mips.org Cc: Jiang Liu jiang@huawei.com Cc: linux-m...@linux-mips.org Cc: linux-kernel@vger.kernel.org --- arch/mips/powertv/asic/asic_devices.c | 13 ++--- 1

[PATCH v2, part3 02/12] mm/ARM64: kill poison_init_mem()

2013-03-16 Thread Jiang Liu
Use free_reserved_area() to kill poison_init_mem() on ARM64. Signed-off-by: Jiang Liu jiang@huawei.com Cc: Catalin Marinas catalin.mari...@arm.com Cc: Will Deacon will.dea...@arm.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm64/mm/init.c | 17

[PATCH v2, part3 12/12] mm: concentrate adjusting of totalram_pages

2013-03-16 Thread Jiang Liu
Concentrate code to modify totalram_pages into the mm core, so the arch memory initialized code doesn't need to take care of it. With these changes applied, only following functions from mm core modify global variable totalram_pages: free_bootmem_late(), free_all_bootmem(),

Re: BUG: IPv4: Attempt to release TCP socket in state 1

2013-03-16 Thread Eric Dumazet
On Fri, 2013-03-15 at 00:19 +0100, Eric Dumazet wrote: Thanks thats really useful, we might miss to increment socket refcount in a timer setup. Hmm, please add following debugging patch as well diff --git a/include/net/sock.h b/include/net/sock.h index 14f6e9d..fe7c8a6 100644 ---

Re: [PATCH v2, part3 01/12] mm: enhance free_reserved_area() to support poisoning memory with zero

2013-03-16 Thread Geert Uytterhoeven
On Sat, Mar 16, 2013 at 6:03 PM, Jiang Liu liu...@gmail.com wrote: --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5130,13 +5130,13 @@ unsigned long free_reserved_area(unsigned long start, unsigned long end, pos = start = PAGE_ALIGN(start); end = PAGE_MASK; for

Re: CONFIG_EARLY_PRINTK

2013-03-16 Thread Randy Dunlap
On 03/16/13 08:08, Thomas Meyer wrote: Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap: On 03/13/13 10:15, Thomas Meyer wrote: Hi, -*- Early printk help text says: You should normally N here, unless you want to debug such a crash. (Depends on: EXPERT [=n]) How to

Re: [PATCH] USB: EHCI: fix for leaking isochronous data

2013-03-16 Thread Alan Stern
On Sat, 16 Mar 2013, Soeren Moch wrote: I implemented the counter. The max value is sampled at the beginning of end_free_itds(), the current counter value is sampled at the end of this function. Counter values w/o a max number are from the error path in itd_urb_transaction(). The number

Re: [RFC PATCH] seq_file: Use seq_puts when seq_printf has only a format with no args

2013-03-16 Thread Joe Perches
On Sat, 2013-03-16 at 09:43 -0600, Bjorn Helgaas wrote: Checkpatch could look for additions of seq_printf() with constant formats. Suggested-by: Bjorn Helgaas bhelg...@google.com Signed-off-by: Joe Perches j...@perches.com --- I don't know what perl version introduced $-[0] and $+[0] so this

Re: BUG: IPv4: Attempt to release TCP socket in state 1

2013-03-16 Thread Eric Dumazet
On Sat, 2013-03-16 at 10:36 -0700, Eric Dumazet wrote: On Fri, 2013-03-15 at 00:19 +0100, Eric Dumazet wrote: Thanks thats really useful, we might miss to increment socket refcount in a timer setup. Hmm, please add following debugging patch as well diff --git a/include/net/sock.h

Re: [PATCH v2, part3 01/12] mm: enhance free_reserved_area() to support poisoning memory with zero

2013-03-16 Thread Jiang Liu
On 03/17/2013 01:37 AM, Geert Uytterhoeven wrote: On Sat, Mar 16, 2013 at 6:03 PM, Jiang Liu liu...@gmail.com wrote: --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5130,13 +5130,13 @@ unsigned long free_reserved_area(unsigned long start, unsigned long end, pos = start =

Re: [RFC PATCH] seq_file: Use seq_puts when seq_printf has only a format with no args

2013-03-16 Thread Joe Perches
On Sat, 2013-03-16 at 09:43 -0600, Bjorn Helgaas wrote: On Sat, Mar 16, 2013 at 7:50 AM, Joe Perches j...@perches.com wrote: Instead of converting the 800 or so uses of seq_printf with a constant format (without a % substitution) to seq_puts, maybe there's another way to slightly speed up

Re: [RFC PATCH] seq_file: Use seq_puts when seq_printf has only a format with no args

2013-03-16 Thread Al Viro
On Sat, Mar 16, 2013 at 06:50:44AM -0700, Joe Perches wrote: Instead of converting the 800 or so uses of seq_printf with a constant format (without a % substitution) to seq_puts, maybe there's another way to slightly speed up these outputs. Taking a similar approach to commit abd84d60eb

Re: [PATCH] perf,x86: fix kernel crash with PEBS/BTS after suspend/resume

2013-03-16 Thread Linus Torvalds
On Sat, Mar 16, 2013 at 9:11 AM, Parag Warudkar parag.l...@gmail.com wrote: This seems to trigger a WARN_ON during suspend/resume. Ugh, yes. It's practically harmless, but it's ugly and technically wrong (we're using wrmsr_on_cpu() on our current cpu, but in a context where using it on anything

[PATCH] documentation: alsa: Fix typo in Documentation/sound

2013-03-16 Thread Masanari Iida
Correct spelling typos in Documentation/sound/alsa Signed-off-by: Masanari Iida standby2...@gmail.com --- Documentation/sound/alsa/ALSA-Configuration.txt | 2 +- Documentation/sound/alsa/seq_oss.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: ptracing a task from core_pattern pipe

2013-03-16 Thread Oleg Nesterov
Hi Daniel, Sorry, I can't understand your email... On 03/15, Daniel Walker wrote: I was writing an application to ptrace a process which is dumping core from inside the pipe application for core_pattern. This was never possible. And never will, I think. So for example you make core pattern

<    1   2   3   4   >