BTW, just to give another example of the difference between the mixing
funtions, try compiling the following with and without ORIG_MIX defined...
- Ted
#include stdio.h
#include unistd.h
#include stdlib.h
#include string.h
/* #define ORIG_MIX */
On Sat, 2013-09-21 at 13:58 -0500, Frederic Weisbecker wrote:
Now certainly what needs to be fixed then is archs that don't have
__ARCH_IRQ_EXIT_IRQS_DISABLED
or archs that have any other significant opportunity to nest interrupt.
Interesting. I notice we don't define it on powerpc but we
On Saturday 21 September 2013, Kishon Vijay Abraham I wrote:
{
u32 val;
void __iomem *val1;
void __iomem *dbi_base = pp-dbi_base;
/* Program viewport 0 : INBOUND : MEMORY*/
val = PCIE_ATU_REGION_INBOUND | (0 0xF);
dw_pcie_writel_rc(pp, val,
The variable pll_overclock is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
The variable success is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by:
The variable fully_acked is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
The variable ownbit_flag is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
The variable update_sr is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
The variable Trigger is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by:
The variable ret is only assigned the values true and false.
The function atl1c_read_eeprom already returns bool. Change
ret type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
The variables bMultiBand and bKeyTableFull are only assigned the
values true and false. Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b =
The variable is_rpmb is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by:
The variable want_irq is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by:
The variable frame_ready is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
The variable vco_select is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
The variable continual is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
The variable noCh is only assigned the values true and false. Change
its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
Signed-off-by:
The variables found and is_uctx_pd are only assigned the values true
and false. Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
The variables cancel_scan_cmd, enable_data, hs_activate and valid are
only assigned the values true and false. Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
...
The variable rc is only assigned the values true and false.
The function bnx2x_prev_is_path_marked already returns bool.
Change rc type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b =
There is the rc variable on both myri10ge_ss_lock_napi and
myri10ge_ss_lock_poll functions. In both cases rc is only assigned the
values true and false. Both functions already return bool. Change rc
type to bool.
The simplified semantic patch that find this problem is as
follows
The variable execute_shutdown is only assigned the values true and
false. Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)
On Sun, Sep 22, 2013 at 12:49:45AM +0800, cinifr wrote:
Thanks. I have modify my patch as you said.
It is in attachments. Maybe I remail the new patch?
Yes, remail the whole serie and change the prefix to PATCHv3 (you can
use the --subject-prefix option of git format-patch to do so).
Maxime
On systems where certain filesystem contents cannot be entirely trusted,
it is beneficial to block mounts on symlinks. This makes sure that
malicious filesystem contents cannot trigger the over-mounting of trusted
filesystems. (For example, a bind-mounted subdirectory of /var cannot be
redirected
Regid, All,
On 2013-09-12 03:35 +0300, Regid Ichira spake thusly:
Signed-off-by: Regid Ichira regi...@nt1.in
---
Documentation/kbuild/kconfig.txt | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
There was a trailing whitespace. I fixed it here, and pulled it in my
tree for
On Sun, Sep 22, 2013 at 12:27:47AM +0200, Peter Senna Tschudin wrote:
The variable ownbit_flag is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
On Sat, Sep 21, 2013 at 03:51:26PM +0100, Al Viro wrote:
On Sat, Sep 21, 2013 at 01:10:48AM +0200, Michal Nazarewicz wrote:
On Fri, Sep 20 2013, Al Viro wrote:
There's a bunch of failure exits in ffs_fs_mount() with
seriously broken recovery logics. Most of that appears to stem
from
On Sun, Sep 22, 2013 at 07:45:01AM +1000, Benjamin Herrenschmidt wrote:
On Sat, 2013-09-21 at 13:58 -0500, Frederic Weisbecker wrote:
Now certainly what needs to be fixed then is archs that don't have
__ARCH_IRQ_EXIT_IRQS_DISABLED
or archs that have any other significant opportunity to
On 21-09-2013 14:06, Guenter Roeck wrote:
On 09/18/2013 09:21 AM, Eduardo Valentin wrote:
This patch adds to lm75 temperature sensor the possibility
to expose itself as thermal zone device, registered on the
thermal framework.
The thermal zone is built only if a device tree node
describing
Add a driver for SILabs 570, 571, 598, 599 programmable oscillators.
The devices generate low-jitter clock signals and are reprogrammable via
an I2C interface.
Cc: Guenter Roeck li...@roeck-us.net
Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com
---
v5:
- fix typo in bindings
On Fri, Sep 20, 2013 at 08:34:01AM -0700, Kees Cook wrote:
This reports the names of boot consoles as they're being disabled to
help identify which is which during cut-over. Helps answer the question
which boot console actually got activated? once the regular console
is running, mostly when
On 09/21/2013 04:30 PM, Eduardo Valentin wrote:
On 21-09-2013 14:06, Guenter Roeck wrote:
On 09/18/2013 09:21 AM, Eduardo Valentin wrote:
This patch adds to lm75 temperature sensor the possibility
to expose itself as thermal zone device, registered on the
thermal framework.
The thermal zone
Mike,
We don't need to go through staging. If the dm-writeboost target is
designed well and provides a tangible benefit it doesn't need
wide-spread users as justification for going in. The users will come if
it is implemented well.
OK.
The benefit of introducing writeboost will be
On 21-09-2013 19:56, Guenter Roeck wrote:
On 09/21/2013 04:30 PM, Eduardo Valentin wrote:
On 21-09-2013 14:06, Guenter Roeck wrote:
On 09/18/2013 09:21 AM, Eduardo Valentin wrote:
This patch adds to lm75 temperature sensor the possibility
to expose itself as thermal zone device, registered on
On 2013/9/19 16:33, Petr Holasek wrote:
On Mon, 16 Sep 2013, Jianguo Wu wrote:
In get_mergeable_page() local variable page is not initialized,
it may hold a garbage value, when find_mergeable_vma() return NULL,
get_mergeable_page() may return a garbage value to the caller.
So initialize
On 21 September 2013 23:12, Mateusz Krawczuk
m.krawc...@partner.samsung.com wrote:
Use common clock framework api to get clock.
Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/cpufreq/s5pv210-cpufreq.c | 6
Few comments in cpuidle core files have trivial mistakes. This patch fixes them.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/coupled.c | 2 +-
drivers/cpuidle/cpuidle.c | 2 +-
drivers/cpuidle/driver.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
cpumask is indented using spaces instead of tabs. Fix it.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
include/linux/cpuidle.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
index 781addc..c082425 100644
---
Hello dear,
I am Miss Jane Ruba. I am presently single and searching for a trusted
and God fearing person. I hope you are fine in perfect condition of
health. I saw your email today when I was searching for a good
friend and took interest on it, if you don't mind I will like you to
contact me
__cpuidle_driver_init() doesn't return anything except zero and so doesn't
really need a return type other than void.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/driver.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git
Few statements in cpuidle_idle_call() are broken into multiple lines, whereas
they can actually come in a single line. Convert those to single line.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/cpuidle.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
__cpuidle_device_init() doesn't return anything except zero and so doesn't
really need a return type other than void.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/cpuidle.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git
This patch rearranges __cpuidle_register_device() a bit in order to reduce the
number of exit points of this function.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/cpuidle.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
Both return same error message and so better write them in a single line.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/cpuidle.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index
__cpuidle_get_cpu_driver() is a single line function and so deserves to be
marked inline.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c
index
We are doing this twice in cpuidle_idle_call() routine:
drv-states[next_state].flags CPUIDLE_FLAG_TIMER_STOP
Would be better if we actually store this in a local variable and use that. That
would remove code duplication as well as make this piece of code run fast (in
case compiler wasn't
This is trivial patch that just reorders few statements in
__cpuidle_driver_init() routine, so that we don't need both 'continue' and
'break' in the for loop. Functionally it shouldn't change anything.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/driver.c | 10
We have a routine for getting value of off, better call that instead of using
off directly.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/cpuidle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
cpuidle_driver_lock is taken correctly at most of the places but at few places
calls to cpuidle_get_driver() are done from outside of this lock.
Fix them by calling cpuidle_get_driver() after taking cpuidle_driver_lock.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
We always need to allocate struct cpuidle_device_kobj for all CPUs and so there
is no real need to have a pointer to it inside struct cpuidle_device.
This patch makes a object instance of struct cpuidle_device_kobj inside struct
cpuidle_device instead of a pointer.
Signed-off-by: Viresh Kumar
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/cpuidle.c | 41 -
drivers/cpuidle/driver.c | 42 ++
2 files changed, 42 insertions(+), 41 deletions(-)
diff --git a/drivers/cpuidle/cpuidle.c
Instances of struct cpuidle_driver * are consistently named as drv in
cpuidle core. Its broken only at one place: show_current_driver().
Fix it for consistency.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/sysfs.c | 8
1 file changed, 4 insertions(+), 4
If entered_state == 0, we don't need to set dev-last_residency to 'diff' as we
will be setting it to zero without using its new value.
And so move calculation of diff also inside the if statement.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/cpuidle.c | 17
For CONFIG_CPU_IDLE_MULTIPLE_DRIVERS, struct cpuidle_device always needs to
allocate struct cpuidle_driver_kobj for all CPUs and so there is no real need to
have a pointer to it inside struct cpuidle_device.
This patch makes a object instance of struct cpuidle_driver_kobj inside struct
When I first read cpuidle_replace_governor()'s name I thought it will replace
the governor (as per its name) but then found that it just returns the next best
governor. And cpuidle_unregister_governor() actually replaces it.
We always replace current governor with the next best and this
Currently we have multiple definitions of few routines based on following config
option: CONFIG_CPU_IDLE_MULTIPLE_DRIVERS.
These are present to save space by not creating per-cpu variable for platforms
which need only one cpuidle driver to be registered for all CPUs.
But this setup has a
In cpuidle_coupled_register_device() we do following:
if (WARN_ON(!cpumask_equal(dev-coupled_cpus, coupled-coupled_cpus)))
coupled-prevent++;
This is only required to be done when we are using 'coupled' from an existing
cpuidle_device and not when we have just done this:
Loop for states is currently present on callers side and so is replicated at
several places. It would be better to move that inside cpuidle_free_state_kobj()
instead.
This patch does it.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpuidle/sysfs.c | 23 ---
Hi Rafael/Daniel,
This is a small cleanup patchset for CPUIdle which can go in 3.13 if it looks
okay to you guys..
Mostly trivial patches but few are doing good/significant changes. Tested on my
thinkpad with suspend/resume and didn't found any broken stuff with it.
I a not very sure about this
On 09/21/2013 02:45 PM, Benjamin Herrenschmidt wrote:
I really don't like the larger irq stack ... probably because I can't
make it work easily :-) See my previous comment about how we get to
thread_info on ppc.
For the record, I intend to remove thread_info from the stack on x86 and
In commit 0a2b9d4c,the update of semaphore's sem_otime(last semop time)
was removed because he wanted to move setting sem-sem_otime to one
place. But after that, the initial semop() will not set the otime
because its sem_op value is 0(in semtimedop,will not change
otime if alter == 1).
the error
On 09/21/2013 05:23 PM, Eduardo Valentin wrote:
On 21-09-2013 19:56, Guenter Roeck wrote:
On 09/21/2013 04:30 PM, Eduardo Valentin wrote:
On 21-09-2013 14:06, Guenter Roeck wrote:
On 09/18/2013 09:21 AM, Eduardo Valentin wrote:
This patch adds to lm75 temperature sensor the possibility
to
On 09/21/2013 04:40 PM, Soren Brinkmann wrote:
Add a driver for SILabs 570, 571, 598, 599 programmable oscillators.
The devices generate low-jitter clock signals and are reprogrammable via
an I2C interface.
Cc: Guenter Roeck li...@roeck-us.net
Signed-off-by: Soren Brinkmann
On 09/20/2013 04:36 PM, Jani Nikula wrote:
On Tue, 17 Sep 2013, Aaron Lu aaron...@intel.com wrote:
According to Matthew Garrett, Windows 8 leaves backlight control up
to individual graphics drivers rather than making ACPI calls itself.
There's plenty of evidence to suggest that the Intel
The following fast_mix function, with the loop unrolling, is about 70%
slower than your proposed version, but it's still four times faster
than the original byte-based fast_mix function. This is what I'm
considering using as a compromise.
Any comments or objections?
Need include the default implementation, just like another platforms
(e.g. parisc, tile ...), or can not pass compiling.
The related error (with allmodconfig for arc):
CC [M] fs/btrfs/ioctl.o
fs/btrfs/ioctl.c: In function ‘btrfs_ioctl_file_extent_same’:
fs/btrfs/ioctl.c:2802: error:
On Sat, 2013-09-21 at 19:01 -0700, H. Peter Anvin wrote:
On 09/21/2013 02:45 PM, Benjamin Herrenschmidt wrote:
I really don't like the larger irq stack ... probably because I can't
make it work easily :-) See my previous comment about how we get to
thread_info on ppc.
For the
Some of sub-systems may need cmpxchg64() or another cmpxchg*local()
functions, need implement them, or can not pass compiling.
The related error (allmodconfig for arc):
CC drivers/block/blockconsole.o
drivers/block/blockconsole.c: In function ‘bcon_advance_console_bytes’:
On Sat, Sep 21, 2013 at 11:52:21AM +0100, Jonathan Cameron wrote:
Hi Zubair,
Thanks for persevering with this patch set. Now this
gets to be the example for dealing with hardware buffer
equipped devices ;)
Applied to the togreg branch of
On Sat, Sep 21, 2013 at 07:28:32PM +0100, Jonathan Cameron wrote:
On 09/19/13 07:24, Zubair Lutfullah wrote:
Previously the driver had only one-shot reading functionality.
This patch adds continuous sampling support to the driver.
...
I've added a SELECT IIO_KFIFO_BUF after the autobuilders
On Sun, 2013-09-22 at 14:39 +1000, Benjamin Herrenschmidt wrote:
How do you do your per-cpu on x86 ? On powerpc we struggle because we
try to dedicate a register (r13) to this PACA (the per-cpu offset hangs
off it), but we constantly run into issues where gcc copies r13 to
another register and
From: Wei Yongjun yongjun_...@trendmicro.com.cn
This patch fix the error handle of function cci_pmu_probe():
- using IS_ERR() instead of NULL test for the return value of
devm_ioremap_resource() since it nerver return NULL.
- remove kfree() for devm_kzalloc allocated memory
- remove dev_warn()
301 - 372 of 372 matches
Mail list logo
