Re: [PATCH] soc_button_array: fix a crash during rmmod

2014-04-22 Thread Dmitry Torokhov
On Tue, Apr 22, 2014 at 02:38:39PM +0800, Zhu, Lejun wrote: > When the system has zero or one button available, trying to rmmod > soc_button_array will cause crash. Fix this by properly handling -ENODEV > in probe(). > > Signed-off-by: Lejun Zhu Applied, thank you. > --- >

[PATCH V2] ARM: EXYNOS: cpu hotplug: use v7_exit_coherency_flush macro for cache disabling

2014-04-22 Thread Leela Krishna Amudala
A common macro v7_exit_coherency_flush available which does the below tasks in the seqeunce. -clearing C bit -clearing L1 cache -exit SMP -instruction and data synchronization So removing the local functions which does the same thing and use the macro instead. Signed-off-by: Leela Krishna

Re: [PATCH] extcon: palmas: explicitly set edev name as node name

2014-04-22 Thread Kishon Vijay Abraham I
Hi Chanwoo, On Thursday 10 April 2014 09:19 AM, Chanwoo Choi wrote: > Hi Kishon, > > On 03/28/2014 03:51 PM, Kishon Vijay Abraham I wrote: >> commit ca488 (extcon: of: Remove unnecessary function call by using the >> name of device_node) started using node name instead of device name >> to get

Re: [Bugfix] sched: fix possible invalid memory access caused by CPU hot-addition

2014-04-22 Thread Peter Zijlstra
On Wed, Apr 23, 2014 at 07:32:13AM +0200, Peter Zijlstra wrote: > On Wed, Apr 23, 2014 at 10:45:13AM +0800, Jiang Liu wrote: > > Hi Peter, > > It's not for memoryless node, but to solve a race window > > in CPU hot-addition. The related CPU hot-addition flow is: > > 1) Handle CPU hot-addition

Re: [Resend Patch 9/9] I2C/ACPI: Add CONFIG_I2C_ACPI config

2014-04-22 Thread Lan Tianyu
On 2014年04月22日 19:45, Mika Westerberg wrote: > On Tue, Apr 22, 2014 at 02:24:15PM +0800, Lan Tianyu wrote: >> This patch is to add CONFIG_I2C_ACPI. Current there is a race between >> removing I2C ACPI operation region and ACPI AML code accessing. >> So make i2c core built-in if CONFIG_I2C_ACPI is

Re: [Bugfix] sched: fix possible invalid memory access caused by CPU hot-addition

2014-04-22 Thread Jiang Liu
On 2014/4/23 13:32, Peter Zijlstra wrote: > On Wed, Apr 23, 2014 at 10:45:13AM +0800, Jiang Liu wrote: >> Hi Peter, >> It's not for memoryless node, but to solve a race window >> in CPU hot-addition. The related CPU hot-addition flow is: >> 1) Handle CPU hot-addition event >> 1.a) gather

Re: [PATCH] ARM: EXYNOS: cpu hotplug: use v7_exit_coherency_flush macro for cache disabling

2014-04-22 Thread Leela Krishna Amudala
Hi Daniel, Thanks for reviewing the patch. On Tue, Apr 22, 2014 at 8:06 PM, Daniel Lezcano wrote: > On 04/22/2014 04:18 PM, Leela Krishna Amudala wrote: >> >> Remove the duplicated code for cache disabling and use >> "v7_exit_coherency_flush" >> macro to do the same job. > > > Hi Leela, > >

Re: [PATCH 1/3] tools: Unify export.h

2014-04-22 Thread Rusty Russell
Borislav Petkov writes: > From: Borislav Petkov > > So tools/ has been growing three, at a different stage of their > development export.h headers and so we should unite into one. Add > tools/include/ to the include path of virtio and liblockdep to pick the > shared header now. Acked-by: Rusty

Re: Futex Question (64 bits?)

2014-04-22 Thread Rusty Russell
Ryan Nicholl writes: > I would like to know if it would be possible to use a 64 bit futex > call? If not, I would like to request it be added. (It is acknowledged > in the manpages that it must be added eventually anyway.) It could be done; it's just not been done yet. Simple matter of coding

Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.

2014-04-22 Thread Rusty Russell
si...@mungewell.org writes: >> In line with practice for module parameters, we're adding a build-time >> check that sysfs files aren't world-writable. > > So this is the equivalent of 'chmod 774 ...' rather than 'chmod > 777...'? Yep. Though not sure why it was 777 rather than 666... > Yep I'm

Re: [PATCH] Fix: tracing: use 'E' instead of 'X' for unsigned module tain flag

2014-04-22 Thread Rusty Russell
Mathieu Desnoyers writes: > In the following commit: > > commit 57673c2b0baa900dddae3b9eb3d7748ebf550eb3 > Author: Rusty Russell > Date: Mon Mar 31 14:39:57 2014 +1030 > > Use 'E' instead of 'X' for unsigned module taint flag. > > One site has been forgotten in trace events module.h. Hmm,

Re: [PATCH v2] fix printk output

2014-04-22 Thread Rusty Russell
Sergei Ianovich writes: > On Tue, 2013-12-10 at 15:59 +1030, Rusty Russell wrote: >> BTW, did you actually hit this? > > # modprobe usb_storage > [ 600.807274] usbcore: registered new interface driver usb-storage > # modprobe -r usb_storage > [ 604.216318] waiting module removal not supported:

Re: [PATCH] sched / idle: Make cpuidle_idle_call() void

2014-04-22 Thread Peter Zijlstra
On Wed, Apr 23, 2014 at 01:36:42AM +0200, Rafael J. Wysocki wrote: > On Tuesday, April 22, 2014 01:49:30 PM Peter Zijlstra wrote: > > On Mon, Apr 21, 2014 at 01:26:58AM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > The only value ever returned by cpuidle_idle_call()

Re: debug_dma_assert_idle - snd_hda_intel - cpu touching an active dma mapped cacheline

2014-04-22 Thread poma
On 23.04.2014 02:53, poma wrote: > > This one comes and goes... > > [ cut here ] > WARNING: CPU: 2 PID: 521 at lib/dma-debug.c:593 > debug_dma_assert_idle+0x159/0x1d0() > snd_hda_intel :00:07.0: DMA-API: cpu touching an active dma mapped > cacheline [cln=0x03019000] >

Re: Microblaze image hanging in qemu with 3.15-rc

2014-04-22 Thread Michal Simek
Hi Guenter, On 04/22/2014 07:23 PM, Guenter Roeck wrote: > Hi all, > > when trying to run a microblaze image with 3.15-rc1 or 3.15-rc2 in qemu, > I get the following hangup. This used to work with earlier kernels > with the same configuration. > > Is this a known problem, or is something wrong

Re: [Bugfix] sched: fix possible invalid memory access caused by CPU hot-addition

2014-04-22 Thread Peter Zijlstra
On Wed, Apr 23, 2014 at 10:45:13AM +0800, Jiang Liu wrote: > Hi Peter, > It's not for memoryless node, but to solve a race window > in CPU hot-addition. The related CPU hot-addition flow is: > 1) Handle CPU hot-addition event > 1.a) gather platform specific information > 1.b) associate

Re: [PATCH 5/4] ipc,shm: minor cleanups

2014-04-22 Thread Michael Kerrisk (man-pages)
On 04/23/2014 07:25 AM, Davidlohr Bueso wrote: > On Wed, 2014-04-23 at 07:07 +0200, Michael Kerrisk (man-pages) wrote: >> On 04/23/2014 04:53 AM, Davidlohr Bueso wrote: >>> - Breakup long function names/args. >>> - Cleaup variable declaration. >>> - s/current->mm/mm >>> >>> Signed-off-by:

[PATCH 2/3] f2fs: pass flags field to setxattr functions

2014-04-22 Thread Jaegeuk Kim
This patch passes the "flags" field to the low level setxattr functions to use XATTR_REPLACE in the following patches. Signed-off-by: Jaegeuk Kim --- fs/f2fs/acl.c | 2 +- fs/f2fs/xattr.c | 13 +++-- fs/f2fs/xattr.h | 4 ++-- 3 files changed, 10 insertions(+), 9 deletions(-) diff

Re: [PATCH 5/4] ipc,shm: minor cleanups

2014-04-22 Thread Davidlohr Bueso
On Wed, 2014-04-23 at 07:07 +0200, Michael Kerrisk (man-pages) wrote: > On 04/23/2014 04:53 AM, Davidlohr Bueso wrote: > > - Breakup long function names/args. > > - Cleaup variable declaration. > > - s/current->mm/mm > > > > Signed-off-by: Davidlohr Bueso > > --- > > ipc/shm.c | 40

[PATCH 3/3] f2fs: return errors right after checking them

2014-04-22 Thread Jaegeuk Kim
This patch adds two error conditions early in the setxattr operations. Signed-off-by: Jaegeuk Kim --- fs/f2fs/xattr.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index bbe9c2b..6073f9f 100644 --- a/fs/f2fs/xattr.c +++

[PATCH 1/3] f2fs: clean up long variable names

2014-04-22 Thread Jaegeuk Kim
This patch includes simple clean-ups to reduce unnecessary long variable names. Signed-off-by: Jaegeuk Kim --- fs/f2fs/xattr.c | 86 + fs/f2fs/xattr.h | 6 ++-- 2 files changed, 47 insertions(+), 45 deletions(-) diff --git

Re: [PATCH] vfs: rw_copy_check_uvector() - free iov on error

2014-04-22 Thread Eric Biggers
On Wed, Apr 23, 2014 at 12:06:39AM -0500, Eric Biggers wrote: > The proposed patch doesn't work because in compat_rw_copy_check_uvector(), > 'iov' > is incremented in the loop before it is freed or returned. This probably > should > be changed to indexing with 'seg', like in the non-compat

[PATCH] autofs - fix lockref lookup

2014-04-22 Thread Ian Kent
autofs needs to be able to see private data dentry flags for its dentrys that are being created but not yet hashed and for its dentys that have been rmdir()ed but not yet freed. It needs to do this so it can block processes in these states until a status has been returned to indicate the given

Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

2014-04-22 Thread Adam Williamson
On Mon, 2014-04-21 at 10:30 -0400, Benjamin Tissoires wrote: > On Mon, Apr 21, 2014 at 9:28 AM, Jin, Yao wrote: > > > > > > On 2014/4/21 14:27, Jin, Yao wrote: > >> > >> > >> On 2014/4/20 23:28, Adam Williamson wrote: > >>> On Sun, 2014-04-20 at 20:08 +0800, Jin, Yao wrote: > For the issue

Re: [PATCH] proc: fix documentation for /proc/stat, line "intr"

2014-04-22 Thread Michael Kerrisk (man-pages)
On Wed, Apr 23, 2014 at 12:35 AM, Randy Dunlap wrote: > On 04/22/14 11:19, Michael Kerrisk (man-pages) wrote: >> On 04/22/2014 05:29 PM, Jan Moskyto Matejka wrote: >>> The sum at the beginning of line "intr" includes also unnumbered interrupts. >>> It implies that the sum at the beginning isn't

Re: [PATCH 3/9] perf tools: Account entry stats when it's added to the output tree

2014-04-22 Thread Namhyung Kim
On Tue, 22 Apr 2014 19:10:49 +0200, Jiri Olsa wrote: > On Tue, Apr 22, 2014 at 05:49:45PM +0900, Namhyung Kim wrote: > > SNIP > >> >> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c >> index 1c77714f668d..f955ae5a41c5 100644 >> --- a/tools/perf/util/hist.c >> +++

RE: [PATCHv2 2/3] regmap: Add the DT binding documentation for endianness

2014-04-22 Thread li.xi...@freescale.com
> -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Tuesday, April 15, 2014 5:10 AM > To: Xiubo Li-B47053 > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCHv2 2/3] regmap: Add the DT binding documentation for > endianness > > On

Re: [PATCH 1/4] ipc/shm.c: check for ulong overflows in shmat

2014-04-22 Thread Michael Kerrisk (man-pages)
On 04/21/2014 04:26 PM, Manfred Spraul wrote: > find_vma_intersection does not work as intended if addr+size overflows. > The patch adds a manual check before the call to find_vma_intersection. > > Signed-off-by: Manfred Spraul > --- > ipc/shm.c | 3 +++ > 1 file changed, 3 insertions(+) > >

Re: [PATCH 5/4] ipc,shm: minor cleanups

2014-04-22 Thread Michael Kerrisk (man-pages)
On 04/23/2014 04:53 AM, Davidlohr Bueso wrote: > - Breakup long function names/args. > - Cleaup variable declaration. > - s/current->mm/mm > > Signed-off-by: Davidlohr Bueso > --- > ipc/shm.c | 40 +--- > 1 file changed, 17 insertions(+), 23 deletions(-) >

Re: [PATCH 3/4] ipc/shm.c: check for integer overflow during shmget.

2014-04-22 Thread Michael Kerrisk (man-pages)
On 04/21/2014 04:26 PM, Manfred Spraul wrote: > SHMMAX is the upper limit for the size of a shared memory segment, > counted in bytes. The actual allocation is that size, rounded up to > the next full page. > Add a check that prevents the creation of segments where the > rounded up size causes an

Re: [PATCH] vfs: rw_copy_check_uvector() - free iov on error

2014-04-22 Thread Eric Biggers
The proposed patch doesn't work because in compat_rw_copy_check_uvector(), 'iov' is incremented in the loop before it is freed or returned. This probably should be changed to indexing with 'seg', like in the non-compat version... -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 4/4] ipc/shm.c: Increase the defaults for SHMALL, SHMMAX.

2014-04-22 Thread Michael Kerrisk (man-pages)
On 04/21/2014 04:26 PM, Manfred Spraul wrote: > System V shared memory > > a) can be abused to trigger out-of-memory conditions and the standard >measures against out-of-memory do not work: > > - it is not possible to use setrlimit to limit the size of shm segments. > > - segments

Re: [PATCH 2/4] ipc/shm.c: check for overflows of shm_tot

2014-04-22 Thread Michael Kerrisk (man-pages)
On 04/21/2014 04:26 PM, Manfred Spraul wrote: > shm_tot counts the total number of pages used by shm segments. > > If SHMALL is ULONG_MAX (or nearly ULONG_MAX), then the number > can overflow. Subsequent calls to shmctl(,SHM_INFO,) would return > wrong values for shm_tot. > > The patch adds a

linux-next: Tree for Apr 23

2014-04-22 Thread Stephen Rothwell
Hi all, This tree still fails (more than usual) the powerpc allyesconfig build. Changes since 20140422: New tree: drm-panel The arm tree still produces quite a few build warnings. The powerpc tree still had its build failure. The vfs tree still had its build failure so I applied a fix patch

Re: [RFC PATCH v5 2/2] Use kernfs_break_active_protection() for device online store callbacks

2014-04-22 Thread Li Zhong
On Tue, 2014-04-22 at 16:44 -0400, Tejun Heo wrote: > Hello, > > On Tue, Apr 22, 2014 at 11:34:39AM +0800, Li Zhong wrote: > > > Is this assumption true? If so, can we add lockdep assertions in > > > places to verify and enforce this? If not, aren't we just feeling > > > good when the reality

Re: [PATCH] zram: correct offset usage in zram_bio_discard

2014-04-22 Thread Joonsoo Kim
On Wed, Apr 23, 2014 at 11:52:08AM +0800, Weijie Yang wrote: > On Wed, Apr 23, 2014 at 11:08 AM, Joonsoo Kim wrote: > > On Wed, Apr 23, 2014 at 10:32:30AM +0800, Weijie Yang wrote: > >> On Wed, Apr 23, 2014 at 3:55 AM, Andrew Morton > >> wrote: > >> > On Tue, 22 Apr 2014 11:14:02 +0800 Weijie

Re: [PATCH 3/9] perf tools: Account entry stats when it's added to the output tree

2014-04-22 Thread Namhyung Kim
On Tue, 22 Apr 2014 16:54:49 +0200, Jiri Olsa wrote: > On Tue, Apr 22, 2014 at 05:49:45PM +0900, Namhyung Kim wrote: > > SNIP > >> } >> >> static int process_sample_event(struct perf_tool *tool, >> @@ -234,19 +230,17 @@ static int __cmd_annotate(struct perf_annotate *ann) >>

Re: [PATCH] proc: fix documentation for /proc/stat, line "intr"

2014-04-22 Thread Michael Kerrisk (man-pages)
On 04/23/2014 12:35 AM, Randy Dunlap wrote: > On 04/22/14 11:19, Michael Kerrisk (man-pages) wrote: >> On 04/22/2014 05:29 PM, Jan Moskyto Matejka wrote: >>> The sum at the beginning of line "intr" includes also unnumbered interrupts. >>> It implies that the sum at the beginning isn't the sum of

Re: [PATCH 2/9] perf hists: Introduce hists__add_nr_events()

2014-04-22 Thread Namhyung Kim
On Tue, 22 Apr 2014 16:52:03 +0200, Jiri Olsa wrote: > On Tue, Apr 22, 2014 at 05:49:44PM +0900, Namhyung Kim wrote: >> +static void hists__add_nr_events(struct hists *hists, u32 type, u32 val) >> +{ >> +__events_stats__add(>stats, type, val); >> +} > > adding static function with no usage

Re: [Bugfix] sched: fix possible invalid memory access caused by CPU hot-addition

2014-04-22 Thread Jiang Liu
On 2014/4/23 9:59, David Rientjes wrote: > On Tue, 22 Apr 2014, Peter Zijlstra wrote: > >> On Tue, Apr 22, 2014 at 01:01:51PM -0700, Andrew Morton wrote: >>> On Tue, 22 Apr 2014 10:15:15 +0200 Peter Zijlstra >>> wrote: >>> On Tue, Apr 22, 2014 at 01:27:15PM +0800, Jiang Liu wrote: >

Re: [PATCH 1/9] perf report: Count number of entries and samples separately

2014-04-22 Thread Namhyung Kim
Hi Jiri, On Tue, 22 Apr 2014 16:51:03 +0200, Jiri Olsa wrote: > On Tue, Apr 22, 2014 at 05:49:43PM +0900, Namhyung Kim wrote: >> Those stats are counted counted in multiple places so that they can >> confuse readers of the code. This is a preparation of later change >> and do not intend any

Re: [PATCHSET 0/9] perf tools: Fixup for the --percentage change

2014-04-22 Thread Namhyung Kim
Hi Ingo, On Tue, 22 Apr 2014 11:55:57 +0200, Ingo Molnar wrote: > I gave it some quick testing and after fixing a trivial merge conflict > in tools/lib/lockdep/Makefile all seems to be working fine. Thanks for testing! > > But while looking at it I remembered one of my old UI complains about

Re: [PATCH V2 01/19] tick: trivial cleanups

2014-04-22 Thread Viresh Kumar
On 23 April 2014 02:53, Frederic Weisbecker wrote: > On Mon, Apr 21, 2014 at 03:24:57PM +0530, Viresh Kumar wrote: >> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c >> index 6558b7a..9e9ddba 100644 >> --- a/kernel/time/tick-sched.c >> +++ b/kernel/time/tick-sched.c >> @@ -108,7

Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

2014-04-22 Thread Viresh Kumar
On 23 April 2014 02:43, Stratos Karafotis wrote: > @@ -342,7 +333,7 @@ static int core_voltage_pre_transition(struct > powernow_k8_data *data, > return 1; > > if (savefid != data->currfid) { > - printk(KERN_ERR PFX "ph1 err, currfid changed 0x%x\n", > +

[PATCH] ceph: fix corruption when using page_count 0 page in rbd

2014-04-22 Thread Chunwei Chen
It has been reported that using ZFSonLinux on rbd will result in memory corruption. The bug report can be found here: https://github.com/zfsonlinux/spl/issues/241 http://tracker.ceph.com/issues/7790 The reason is that ZFS will send pages with page_count 0 into rbd, which in turns send them to

Re: [PATCH] cpufreq: Kconfig: Fix spelling errors

2014-04-22 Thread Viresh Kumar
On 23 April 2014 01:10, Stratos Karafotis wrote: > Fix 4 spelling errors in help sections. > > Signed-off-by: Stratos Karafotis > --- > drivers/cpufreq/Kconfig.arm | 4 ++-- > drivers/cpufreq/Kconfig.x86 | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Acked-by: Viresh Kumar -- To

Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support

2014-04-22 Thread sundeep subbaraya
Hi, On Tue, Apr 22, 2014 at 8:19 PM, Felipe Balbi wrote: > Hi, > > On Tue, Apr 22, 2014 at 12:58:41PM +0530, sundeep subbaraya wrote: >> Hi, >> >> On Mon, Apr 21, 2014 at 10:09 PM, Alan Stern >> wrote: >> > On Mon, 21 Apr 2014, Felipe Balbi wrote: >> > >> >> Hi, >> >> >> >> On Fri, Apr 18,

linux-next: build failure after merge of the akpm-current tree

2014-04-22 Thread Stephen Rothwell
Hi Andrew, After merging the akpm-current tree, today's linux-next build (arm multi_v7_defconfig) failed like this: In file included from arch/arm/mm/flush.c:20:0: include/linux/hugetlb.h: In function 'hugepages_supported': include/linux/hugetlb.h:468:9: error: 'HPAGE_SHIFT' undeclared (first

[PATCH] usb: phy: tahvo: Use devm_extcon_dev_* function for resource management of extcon

2014-04-22 Thread Chanwoo Choi
This patch uses devm_extcon_dev_{allocate, register} function for automatically resource management of extcon device instead of legacy method and simplifies the behavior of register/unregister for extcon device. Signed-off-by: Chanwoo Choi --- This patch has dependency about following

Re: [perf] yet another 32/64-bit range check failure

2014-04-22 Thread Vince Weaver
On Tue, 22 Apr 2014, Vince Weaver wrote: > This is allowing events to be allocated memory but not being freed somehow > before returning EINVAL (a memory leak). > At least it looks like this is happening in the huge traces I have trying > to track down the perf_fuzzer memory corruption bug. I

Re: [PATCH] mmc: dw_mmc: Don't print data errors

2014-04-22 Thread Alim Akhtar
Hi Doug, On Wed, Apr 23, 2014 at 5:21 AM, Doug Anderson wrote: > Data errors are completely expected during tuning. Printing them out > is confusing people looking at the kernel logs. They see things like: > > [3.613296] dwmmc_exynos 1220.dwmmc0: data error, status 0x0088 > >

Re: [PATCH 0/6][v2] audit: implement multicast socket for journald

2014-04-22 Thread Eric Paris
On Tue, 2014-04-22 at 22:25 -0400, Steve Grubb wrote: > On Tuesday, April 22, 2014 09:31:52 PM Richard Guy Briggs wrote: > > This is a patch set Eric Paris and I have been working on to add a > > restricted capability read-only netlink multicast socket to kernel audit to > > enable userspace

Re: [PATCH 0/6][v2] audit: implement multicast socket for journald

2014-04-22 Thread David Miller
From: Richard Guy Briggs Date: Tue, 22 Apr 2014 21:49:29 -0400 > On 14/04/22, David Miller wrote: >> From: Richard Guy Briggs >> Date: Tue, 22 Apr 2014 21:31:52 -0400 >> >> > This is a patch set Eric Paris and I have been working on to add a >> > restricted >> > capability read-only netlink

Re: [PATCH] zram: correct offset usage in zram_bio_discard

2014-04-22 Thread Weijie Yang
On Wed, Apr 23, 2014 at 11:08 AM, Joonsoo Kim wrote: > On Wed, Apr 23, 2014 at 10:32:30AM +0800, Weijie Yang wrote: >> On Wed, Apr 23, 2014 at 3:55 AM, Andrew Morton >> wrote: >> > On Tue, 22 Apr 2014 11:14:02 +0800 Weijie Yang >> > wrote: >> > >> >> we want to skip the logical block which is

[PATCH 5/5] NFS: avoid deadlocks with loop-back mounted NFS filesystems.

2014-04-22 Thread NeilBrown
Support for loop-back mounted NFS filesystems is useful when NFS is used to access shared storage in a high-availability cluster. If the node running the NFS server fails some other node can mount the filesystem and start providing NFS service. If that node already had the filesystem NFS

linux-next: build failure after merge of the wireless-next tree

2014-04-22 Thread Stephen Rothwell
Hi John, After merging the wireless-next tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/net/wireless/mwifiex/pcie.c: In function 'mwifiex_pcie_fw_dump_work': drivers/net/wireless/mwifiex/pcie.c:2290:3: error: implicit declaration of function 'vmalloc'

[PATCH 4/5] SUNRPC: track when a client connection is routed to the local host.

2014-04-22 Thread NeilBrown
If requests are being sent to the local host, then NFS will need to take care to avoid deadlocks. So keep track when accepting a connection or sending a UDP request and set a flag in the svc_xprt when the peer connected to is local. The interface rpc_is_foreign() is provided to check is a given

[PATCH 3/5] nfsd: Only set PF_LESS_THROTTLE when really needed.

2014-04-22 Thread NeilBrown
PF_LESS_THROTTLE has a very specific use case: to avoid deadlocks and live-locks while writing to the page cache in a loop-back NFS mount situation. It therefore makes sense to *only* set PF_LESS_THROTTLE in this situation. We now know when a request came from the local-host so it could be a

[PATCH 2/5] SUNRPC: track whether a request is coming from a loop-back interface.

2014-04-22 Thread NeilBrown
If an incoming NFS request is coming from the local host, then nfsd will need to perform some special handling. So detect that possibility and make the source visible in rq_local. Signed-off-by: NeilBrown --- include/linux/sunrpc/svc.h |1 + include/linux/sunrpc/svc_xprt.h |1 +

[PATCH 1/5] MM: avoid throttling reclaim for loop-back nfsd threads.

2014-04-22 Thread NeilBrown
When a loop-back NFS mount is active and the backing device for the NFS mount becomes congested, that can impose throttling delays on the nfsd threads. These delays significantly reduce throughput and so the NFS mount remains congested. This results in a live lock and the reduced throughput

[PATCH/RFC 0/5] Support loop-back NFS mounts - take 2

2014-04-22 Thread NeilBrown
This is a somewhat shorter patchset for loop-back NFS support than last time, thanks to the excellent feedback and particularly to Dave Chinner. Thanks. Avoiding the wait-for-congestion which can trigger a livelock is much the same, though I've reduced the cases in which the wait is by-passed. I

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

2014-04-22 Thread navin patidar
On Tue, Apr 22, 2014 at 7:58 PM, Larry Finger wrote: > > To me, the opposite case is true. If you have not tested, then you need to > explicitly state "compile tested only" in the commit message. Without saying > that, your signed-off-by is implying that you have tested, as well as > declaring

[RFC][PATCH 2/3] printk: Add printk_once_deferred

2014-04-22 Thread John Stultz
Two of the three prink_deferred uses are really printk_once style uses, so add a printk_once_deferred macro to simplify those call sites. Cc: Jan Kara Cc: Peter Zijlstra Cc: Jiri Bohac Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Andrew Morton Signed-off-by: John Stultz ---

[RFC][PATCH 3/3] timekeeping: Use printk_deferred when holding timekeeping seqlock

2014-04-22 Thread John Stultz
Jiri Bohac pointed out that there are rare but potential deadlock possibilities when calling printk while holding the timekeeping seqlock. This is due to printk() triggering console sem wakeup, which can cause scheduling code to trigger hrtimers which may try to read the time. Specifically, as

[RFC][PATCH 0/3] Convert timekeeping core to use printk_deferred

2014-04-22 Thread John Stultz
Jiri pointed out a potential deadlock when calling printk while holding the timekeeping seqlock. Annoyingly, the seqlock lockdep enablement doesn't catch this, as printk disables lockdep. When looking for possible solutions, one idea was to use a local buffer and defer the printk to later. Ends

[RFC][PATCH 1/3] printk: Rename printk_sched to printk_deferred

2014-04-22 Thread John Stultz
After learning we'll need some sort of deferred printk functionality in the timekeeping core, Peter suggested we rename the printk_sched function so it can be reused by needed subsystems. This only changes the function name and name of the associated buffer. No logic changes. Cc: Jan Kara Cc:

[perf] yet another 32/64-bit range check failure

2014-04-22 Thread Vince Weaver
More fun found by the perf_fuzzer... In kernel/events/core.c SYSCALL_DEFINE5(perf_event_open, We check if flags is valid like this: /* for future expandability... */ if (flags & ~PERF_FLAG_ALL) return -EINVAL; but flags is a 64-bit value but ~PERF_FLAG_ALL is

Re: [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

2014-04-22 Thread navin patidar
dan, It is ok to rearrange and remove members of enum LED_STATE_871x and enum LED_CTL_MODE. these enum are not related to firmware . regards, --navin-patidar On Tue, Apr 22, 2014 at 4:05 PM, Dan Carpenter wrote: > It's ok to renumber all of these? It's not something the firmware will > care

Re: [PATCH 20/28] nios2: Time keeping

2014-04-22 Thread Ley Foon Tan
On Tue, Apr 22, 2014 at 9:44 PM, Arnd Bergmann wrote: > On Friday 18 April 2014, Ley Foon Tan wrote: >> +static inline unsigned long read_timersnapshot(void) >> +{ >> + unsigned long count; >> + >> + outw(0, timer_membase + ALTERA_TIMER_SNAPL_REG); >> + count = >> +

Re: [PATCH 2/6] netlink: have netlink per-protocol bind function return an error code.

2014-04-22 Thread Richard Guy Briggs
On 14/04/22, David Miller wrote: > From: Richard Guy Briggs > Date: Fri, 18 Apr 2014 13:34:06 -0400 > > > @@ -1449,6 +1453,26 @@ static int netlink_bind(struct socket *sock, struct > > sockaddr *addr, > > if (!nladdr->nl_groups && (nlk->groups == NULL || !(u32)nlk->groups[0])) > >

Re: [PATCH] sysfs, device-tree: aid for debugging device tree boot problems

2014-04-22 Thread Greg Kroah-Hartman
On Tue, Apr 22, 2014 at 06:25:25PM -0700, Frank Rowand wrote: > Create some infrastructure to aid trouble shooting device tree related > boot issues. > > Add a %driver_name file to each device tree node sysfs directory which has had > a driver bound to it. This allows detecting device tree nodes

Re: [PATCH] zram: correct offset usage in zram_bio_discard

2014-04-22 Thread Joonsoo Kim
On Wed, Apr 23, 2014 at 10:32:30AM +0800, Weijie Yang wrote: > On Wed, Apr 23, 2014 at 3:55 AM, Andrew Morton > wrote: > > On Tue, 22 Apr 2014 11:14:02 +0800 Weijie Yang > > wrote: > > > >> we want to skip the logical block which is partially covered by > >> the discard bio, so check the

[PATCH] smc91x: improve definition of debug macros

2014-04-22 Thread Zi Shen Lim
Redefine some macros that were conditioned upon SMC_DEBUG level. By allowing compiler to verify parameters used by these macros unconditionally, we can flag compilation failures. Compiler will still optimize out the unused code path depending on SMC_DEBUG, so this is a net gain. Signed-off-by:

Re: [PATCH 2/2] mm/compaction: cleanup isolate_freepages()

2014-04-22 Thread Joonsoo Kim
On Tue, Apr 22, 2014 at 03:17:30PM +0200, Vlastimil Babka wrote: > On 04/22/2014 08:52 AM, Minchan Kim wrote: > > On Tue, Apr 22, 2014 at 08:33:35AM +0200, Vlastimil Babka wrote: > >> On 22.4.2014 1:53, Minchan Kim wrote: > >>> On Mon, Apr 21, 2014 at 11:43:24PM +0200, Vlastimil Babka wrote: >

[PATCHv2 2/2] clocksource: fix clocksource_mmio_readX_down

2014-04-22 Thread Xiubo Li
For some clocksource devices, for example, the registers are 32-bit, while the lower 16-bit is used for timer counting(And reading the upper 16-bit will return 0). For example, when the counter value is 0x, and then the ~readl_relaxed(to_mmio_clksrc(c)->reg) will return the value of

[PATCHv2 1/2] clocksource: fix type confusion for clocksource_mmio_readX_Y

2014-04-22 Thread Xiubo Li
The types' definations are: o cycle_t -> u64 o readl_relaxed -> u32 o readw_relaxed -> u16 So let clocksource_mmio_readX_Ys return a cast to cycle_t, though this maybe look reduntant sometimes, it make sense and they will be more readable and less confusion... This patch

[PATCH 5/4] ipc,shm: minor cleanups

2014-04-22 Thread Davidlohr Bueso
- Breakup long function names/args. - Cleaup variable declaration. - s/current->mm/mm Signed-off-by: Davidlohr Bueso --- ipc/shm.c | 40 +--- 1 file changed, 17 insertions(+), 23 deletions(-) diff --git a/ipc/shm.c b/ipc/shm.c index f000696..584d02e

Re: [PATCH 06/28] nios2: Memory management

2014-04-22 Thread LF.Tan
On Wed, Apr 23, 2014 at 12:24 AM, Sam Ravnborg wrote: >> Other than being "pretty" the above fix is to remove a mismatch type >> warning. You can get rid of the warning in different ways: >> >> ifdef __ASSEMBLY__ >> define PAGE_SIZE 4096 >> else >> define PAGE_SIZE 4096UL >> endif > >

Re: Why do we set _PAGE_DIRTY for page tables?

2014-04-22 Thread H. Peter Anvin
On 04/22/2014 07:48 PM, Linus Torvalds wrote: > On Tue, Apr 22, 2014 at 4:35 PM, H. Peter Anvin wrote: >> I just noticed this: >> >> #define _PAGE_TABLE (_PAGE_PRESENT | _PAGE_RW | _PAGE_USER | \ >> _PAGE_ACCESSED | _PAGE_DIRTY) >> #define _KERNPG_TABLE

Re: Why do we set _PAGE_DIRTY for page tables?

2014-04-22 Thread Linus Torvalds
On Tue, Apr 22, 2014 at 4:35 PM, H. Peter Anvin wrote: > I just noticed this: > > #define _PAGE_TABLE (_PAGE_PRESENT | _PAGE_RW | _PAGE_USER | \ > _PAGE_ACCESSED | _PAGE_DIRTY) > #define _KERNPG_TABLE (_PAGE_PRESENT | _PAGE_RW | _PAGE_ACCESSED | \ >

Re: [PATCH 5/6] ARM: berlin: add the AHCI node for the BG2

2014-04-22 Thread Jisheng Zhang
Hi Antoine On Tue, 22 Apr 2014 08:38:24 -0700 Antoine Ténart wrote: > The BG2 has an AHCI SATA controller. Add the corresponding node > in its device tree. The AHCI IP of BG2 is different with BG2Q, so the driver in the series of patch doesn't work on BG2. Thanks -- To unsubscribe from this

Re: [PATCH 04/28] nios2: Exception handling

2014-04-22 Thread Ley Foon Tan
On Tue, Apr 22, 2014 at 8:33 PM, Arnd Bergmann wrote: > On Friday 18 April 2014, Ley Foon Tan wrote: >> +static const struct file_operations misalign_fops = { >> + .open = proc_misaligned_open, >> + .read = seq_read, >> + .llseek = seq_lseek, >> +

Re: [PATCH 6/6] ARM: berlin: add the AHCI node for the BG2CD

2014-04-22 Thread Jisheng Zhang
Hi Antoine, On Tue, 22 Apr 2014 08:38:25 -0700 Antoine Ténart wrote: > The BG2CD has an AHCI SATA controller. Add the corresponding node > in its device tree. BG2CD doesn't has AHCI controller. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [Bugfix] sched: fix possible invalid memory access caused by CPU hot-addition

2014-04-22 Thread Jiang Liu
Hi Peter, It's not for memoryless node, but to solve a race window in CPU hot-addition. The related CPU hot-addition flow is: 1) Handle CPU hot-addition event 1.a) gather platform specific information 1.b) associate hot-added CPU with a node 1.c) create CPU device 2) User online hot-added

Re: ftrace/kprobes: Warning when insmod two modules

2014-04-22 Thread Masami Hiramatsu
(2014/04/23 10:56), Steven Rostedt wrote: > On Wed, 23 Apr 2014 10:26:00 +0900 > Masami Hiramatsu wrote: > > >> Agreed. That should be done in a protected (critical) region, >> and the region must be protected by correct lock. It seems that >> the ftrace_lock is not a correct one. > > The

Re: [PATCH] zram: correct offset usage in zram_bio_discard

2014-04-22 Thread Weijie Yang
On Wed, Apr 23, 2014 at 3:55 AM, Andrew Morton wrote: > On Tue, 22 Apr 2014 11:14:02 +0800 Weijie Yang > wrote: > >> we want to skip the logical block which is partially covered by >> the discard bio, so check the remaining size and subtract it if >> there is a need to goto the next logical

RE: [PATCH] clocksource: fix clocksource_mmio_readX_down

2014-04-22 Thread li.xi...@freescale.com
> > diff --git a/drivers/clocksource/mmio.c b/drivers/clocksource/mmio.c > > index c0e2512..f17a0d1 100644 > > --- a/drivers/clocksource/mmio.c > > +++ b/drivers/clocksource/mmio.c > > @@ -27,7 +27,7 @@ cycle_t clocksource_mmio_readl_up(struct clocksource *c) > > > > cycle_t

Re: [PATCH 0/6][v2] audit: implement multicast socket for journald

2014-04-22 Thread Steve Grubb
On Tuesday, April 22, 2014 09:31:52 PM Richard Guy Briggs wrote: > This is a patch set Eric Paris and I have been working on to add a > restricted capability read-only netlink multicast socket to kernel audit to > enable userspace clients such as systemd/journald to receive audit logs, in >

Re: rm -f * on large files very slow on XFS + MD RAID 6 volume of 15x 4TB of HDDs (52TB)

2014-04-22 Thread Dave Chinner
[cc x...@oss.sgi.com] On Mon, Apr 21, 2014 at 10:58:53PM +0200, Speedy Milan wrote: > I want to report very slow deletion of 24 50GB files (in total 12 TB), > all present in the same folder. total = 1.2TB? > OS is CentOS 6.4, with upgraded kernel 3.13.1. > > The hardware is a Supermicro server

Re: [PATCH] workqueue: allow changing attributions of ordered workqueue

2014-04-22 Thread Lai Jiangshan
On 04/23/2014 08:04 AM, Frederic Weisbecker wrote: > Hi Lai, > > So actually I'll need to use apply_workqueue_attr() on the next patchset. So > I'm considering this patch. > > Some comments below: > > On Tue, Apr 15, 2014 at 05:58:08PM +0800, Lai Jiangshan wrote: >> From

Re: [PATCH v2 04/10] drm/nouveau/fb: add GK20A support

2014-04-22 Thread Alexandre Courbot
On 04/22/2014 07:40 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Mon, Apr 21, 2014 at 03:02:16PM +0900, Alexandre Courbot wrote: [...] diff --git a/drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c b/drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c [...] +

Re: [Bugfix] sched: fix possible invalid memory access caused by CPU hot-addition

2014-04-22 Thread Mike Galbraith
On Tue, 2014-04-22 at 22:04 +0200, Peter Zijlstra wrote: > On Tue, Apr 22, 2014 at 01:01:51PM -0700, Andrew Morton wrote: > > On Tue, 22 Apr 2014 10:15:15 +0200 Peter Zijlstra > > wrote: > > > > > On Tue, Apr 22, 2014 at 01:27:15PM +0800, Jiang Liu wrote: > > > > When calling

Re: [PATCH] pinctrl-baytrail: workaround for irq descriptor conflict on ASUS T100TA

2014-04-22 Thread Jin, Yao
On 2014/4/22 21:18, Linus Walleij wrote: > On Mon, Apr 14, 2014 at 4:48 AM, Jin, Yao wrote: > >> A crash is triggered on the ASUS T100TA Baytrail-T because of a IRQ >> descriptor conflict. There are two gpio triggered acpi events in this >> device, GPIO 6 and 18. These gpios are translated to

Re: [Resend Patch 7/9] I2C/ACPI: Add i2c ACPI operation region support

2014-04-22 Thread Lan Tianyu
Hi Mika: Thanks a lot for your review. On 2014年04月22日 19:36, Mika Westerberg wrote: >> > + >> > + client.adapter = adapter; >> > + client.addr = sb->slave_address; >> > + client.flags = 0; > I'm not sure if this is the correct way to use struct i2c_client > (allocating it from stack

Re: [RFC PATCH v5 1/2] Use lock_device_hotplug() in cpu_probe_store() and cpu_release_store()

2014-04-22 Thread Li Zhong
On Tue, 2014-04-22 at 16:40 -0400, Tejun Heo wrote: > Hello, > > On Tue, Apr 22, 2014 at 10:29:37AM +0800, Li Zhong wrote: > > The probe/release files are attribute files for cpu subsys, looks like > > following in sysfs dirs > > > > $ cd /sys/devices/system/cpu/ > > $ ls -l > > total 0 > >

Re: [Bugfix] sched: fix possible invalid memory access caused by CPU hot-addition

2014-04-22 Thread David Rientjes
On Tue, 22 Apr 2014, Peter Zijlstra wrote: > On Tue, Apr 22, 2014 at 01:01:51PM -0700, Andrew Morton wrote: > > On Tue, 22 Apr 2014 10:15:15 +0200 Peter Zijlstra > > wrote: > > > > > On Tue, Apr 22, 2014 at 01:27:15PM +0800, Jiang Liu wrote: > > > > When calling kzalloc_node(size, flags,

Re: [PATCH 1/1] fs/xfs/xfs_log.c: Fix comparison to bool

2014-04-22 Thread Dave Chinner
On Wed, Apr 16, 2014 at 03:15:57PM -0700, Andrew Morton wrote: > On Sun, 13 Apr 2014 22:09:17 +0200 Fabian Frederick wrote: > > > Fixing coccinelle warning > > Please always quote the full error message or warning text when fixing > such things. And CC the correct lists (x...@oss.sgi.com)

Re: ftrace/kprobes: Warning when insmod two modules

2014-04-22 Thread Steven Rostedt
On Wed, 23 Apr 2014 10:26:00 +0900 Masami Hiramatsu wrote: > Agreed. That should be done in a protected (critical) region, > and the region must be protected by correct lock. It seems that > the ftrace_lock is not a correct one. The setting of RO to RW done by ftrace before doing the normal

Re: [PATCH 2/4] idr: reduce the number of MAX_IDR_FREE

2014-04-22 Thread Lai Jiangshan
On 04/23/2014 03:58 AM, Tejun Heo wrote: > On Tue, Apr 22, 2014 at 06:16:19PM +0800, Lai Jiangshan wrote: >> +/* >> + * Number of idr_layer structs to leave in free list. >> + * When idr is not empty, we need atmost (MAX_IDR_LEVEL - 1) idr_layers >> + * to build up and atmost (MAX_IDR_LEVEL - 1)

[PATCH] Input: atkbd - fix keyboard LG Electronics

2014-04-22 Thread Sheng-Liang Song
After issuing ATKBD_CMD_RESET_DIS, LG Keyboard stop working. The workaround is to remove ATKBD_CMD_RESET_DIS for LG Keyboards. In order to keep the minimum changes to the current atkbd driver, I add logic to apply the patch if and only if the device is LG LW25-B7HV or P1-J273B. ---

  1   2   3   4   5   6   7   8   9   10   >