Re: [PATCH] fs: cifs: cifsencrypt.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-08-02 Thread Shirish Pargaonkar
Joe, Thanks for watching out. I think this patch is not correct and think also the current LM authentication code is broken if the password length exceeds 14 characters. Reading from Chris Hertel's book (Chapter 15, 15.3.3 Creating the LM Hash), it says: The LM Hash is a sixteen byte string, cre

Re: [PATCH 1/1] cris: fix %d confusingly prefixed with 0x in format string

2014-08-02 Thread Joe Perches
On Sat, 2014-08-02 at 18:19 -0700, Hans Wennborg wrote: > Yes, I have a patch for a bunch of these, but I figured it would be > easier to get it merged if I split it up. (Complete kernel newbie here.) You as a kernel newbie did good, thanks. A small tip would be to do all of them in a single ser

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
On Sun, Aug 3, 2014 at 1:17 AM, Pranith Kumar wrote: > On 08/03/2014 12:57 AM, Pranith Kumar wrote: >> On 08/03/2014 12:46 AM, Pranith Kumar wrote: >>> On 08/02/2014 10:10 PM, Pranith Kumar wrote: Corrently adding Anssi this time. On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar >>>

Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Nick Krause
On Sun, Aug 3, 2014 at 1:18 AM, Nick Krause wrote: > On Sun, Aug 3, 2014 at 1:02 AM, Mateusz Guzik wrote: >> On Sun, Aug 03, 2014 at 12:31:30AM -0400, Nick Krause wrote: >>> On Sat, Aug 2, 2014 at 11:59 PM, Mateusz Guzik wrote: >>> > On Sat, Aug 02, 2014 at 10:56:13PM -0400, Nicholas Krause wrot

Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Nick Krause
On Sun, Aug 3, 2014 at 1:02 AM, Mateusz Guzik wrote: > On Sun, Aug 03, 2014 at 12:31:30AM -0400, Nick Krause wrote: >> On Sat, Aug 2, 2014 at 11:59 PM, Mateusz Guzik wrote: >> > On Sat, Aug 02, 2014 at 10:56:13PM -0400, Nicholas Krause wrote: >> >> This changes the ifdef statement in sg_set_bg to

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
On 08/03/2014 12:57 AM, Pranith Kumar wrote: > On 08/03/2014 12:46 AM, Pranith Kumar wrote: >> On 08/02/2014 10:10 PM, Pranith Kumar wrote: >>> Corrently adding Anssi this time. >>> >>> On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar >>> wrote: Hello Anssi, Joe, Mike, I just found y

Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Mateusz Guzik
On Sun, Aug 03, 2014 at 12:31:30AM -0400, Nick Krause wrote: > On Sat, Aug 2, 2014 at 11:59 PM, Mateusz Guzik wrote: > > On Sat, Aug 02, 2014 at 10:56:13PM -0400, Nicholas Krause wrote: > >> This changes the ifdef statement in sg_set_bg to !CONFIG_DEBUG_SG in order > >> to avoid a bug with xhci de

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
On 08/03/2014 12:46 AM, Pranith Kumar wrote: > On 08/02/2014 10:10 PM, Pranith Kumar wrote: >> Corrently adding Anssi this time. >> >> On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: >>> Hello Anssi, Joe, Mike, >>> >>> I just found your patch in the latest rc and wanted to ask a few >>> ques

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
On 08/02/2014 10:10 PM, Pranith Kumar wrote: > Corrently adding Anssi this time. > > On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: >> Hello Anssi, Joe, Mike, >> >> I just found your patch in the latest rc and wanted to ask a few >> questions. I am not sure how this patch helps at all othe

Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Nick Krause
On Sat, Aug 2, 2014 at 11:59 PM, Mateusz Guzik wrote: > On Sat, Aug 02, 2014 at 10:56:13PM -0400, Nicholas Krause wrote: >> This changes the ifdef statement in sg_set_bg to !CONFIG_DEBUG_SG in order >> to avoid a bug with xhci dequence/enquence functions. >> >> Signed-off-by: Nicholas Krause >> -

Re: pull request: wireless-next 2014-08-01

2014-08-02 Thread Marcel Holtmann
Hi Dave, >> Please pull this last(?) batch of wireless change intended for the >> 3.17 stream... > > When I pull this I get tons of conflicts for: > > CONFLICT (content): Merge conflict in net/6lowpan/iphc.c > > I don't feel comfortable fixing these up, where are they coming > from? they are c

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
On Sat, Aug 2, 2014 at 11:33 PM, Anssi Hannula wrote: > 03.08.2014, 05:10, Pranith Kumar kirjoitti: >> Corrently adding Anssi this time. >> >> On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: >>> Hello Anssi, Joe, Mike, > > Hi, > >>> I just found your patch in the latest rc and wanted to ask

Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Mateusz Guzik
On Sat, Aug 02, 2014 at 10:56:13PM -0400, Nicholas Krause wrote: > This changes the ifdef statement in sg_set_bg to !CONFIG_DEBUG_SG in order > to avoid a bug with xhci dequence/enquence functions. > > Signed-off-by: Nicholas Krause > --- > include/linux/scatterlist.h | 2 +- > 1 file changed, 1

Re: [PATCH] net: phy: spi_ks8995: Introduce the use of devm_kzalloc

2014-08-02 Thread David Miller
Please submit networking patches at least CC:'d to net...@vger.kernel.org, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Anssi Hannula
03.08.2014, 05:10, Pranith Kumar kirjoitti: > Corrently adding Anssi this time. > > On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: >> Hello Anssi, Joe, Mike, Hi, >> I just found your patch in the latest rc and wanted to ask a few >> questions. I am not sure how this patch helps at all ot

Re: [FIX][RESEND PATCH v3] ARM: EXYNOS: Fix suspend/resume sequences

2014-08-02 Thread Olof Johansson
On Sat, Aug 02, 2014 at 08:27:18PM -0700, Olof Johansson wrote: > On Fri, Aug 01, 2014 at 11:18:53PM +0900, Kukjin Kim wrote: > > Bartlomiej Zolnierkiewicz wrote: > > > > > > Hi, > > > > > Hi, > > > > > On Friday, August 01, 2014 10:51:37 AM Tomasz Figa wrote: > > > > From: Tomasz Figa > > > >

Re: [FIX][RESEND PATCH v3] ARM: EXYNOS: Fix suspend/resume sequences

2014-08-02 Thread Olof Johansson
On Fri, Aug 01, 2014 at 11:18:53PM +0900, Kukjin Kim wrote: > Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > Hi, > > > On Friday, August 01, 2014 10:51:37 AM Tomasz Figa wrote: > > > From: Tomasz Figa > > > > > > Due to recent consolidation of Exynos suspend and cpuidle code, some > > > par

Re: [REBASED PATCH] ARM: multi_v7_defconfig: Enable TI PIPE3 PHY driver

2014-08-02 Thread Olof Johansson
On Fri, Aug 01, 2014 at 02:25:04PM +0300, Roger Quadros wrote: > From: Roger Quadros > > This driver is needed by SATA, PCIe and USB modules on TI SoCs. > > Signed-off-by: Roger Quadros > Acked-by: Tony Lindgren Thanks, applied. -Olof -- To unsubscribe from this list: send the line "unsubsc

[PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Nicholas Krause
This changes the ifdef statement in sg_set_bg to !CONFIG_DEBUG_SG in order to avoid a bug with xhci dequence/enquence functions. Signed-off-by: Nicholas Krause --- include/linux/scatterlist.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/scatterlist.h b/includ

Re: [PATCH net-next v5 0/3] Lockless netlink_lookup() with new concurrent hash table

2014-08-02 Thread David Miller
From: Thomas Graf Date: Sat, 2 Aug 2014 11:47:43 +0200 > Netlink sockets are maintained in a hash table to allow efficient lookup > via the port ID for unicast messages. However, lookups currently require > a read lock to be taken. This series adds a new generic, resizable, > scalable, concurren

Re: pull request: wireless-next 2014-08-01

2014-08-02 Thread David Miller
From: "John W. Linville" Date: Fri, 1 Aug 2014 12:57:38 -0400 > Please pull this last(?) batch of wireless change intended for the > 3.17 stream... When I pull this I get tons of conflicts for: CONFLICT (content): Merge conflict in net/6lowpan/iphc.c I don't feel comfortable fixing these up, w

[PATCH 2/2] gpu: ipu-v3: Return proper error on ipu_add_client_devices error path

2014-08-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/gpu/ipu-v3/ipu-common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c index 04e7b2e..e340beb 100644 --- a/drivers/gpu/ipu-v3/ipu-common.c +++ b/drivers/gpu/ipu-v3/ipu-com

[PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error

2014-08-02 Thread Axel Lin
This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to avoid build error. Fixes below build errors: ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined! ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined! ERROR: "irq_gc

Re: [PATCH 1/1] cris: fix %d confusingly prefixed with 0x in format string

2014-08-02 Thread Steve French
Thanks for pointing this out. I fixed the instances of this that you spotted in the cifs.ko driver (pushed to cifs-2.6.git for-next) and noted that you pointed it out in the commit message. http://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=59b04c5df75bd715002bb535930ae1982a739269 On Sat,

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
Corrently adding Anssi this time. On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: > Hello Anssi, Joe, Mike, > > I just found your patch in the latest rc and wanted to ask a few > questions. I am not sure how this patch helps at all other than luck in > that dm_cblock_t type is of type int32

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
Correctly adding Anssi this time. On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: > Hello Anssi, Joe, Mike, > > I just found your patch in the latest rc and wanted to ask a few > questions. I am not sure how this patch helps at all other than luck in > that dm_cblock_t type is of type int32

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
Hello Anssi, Joe, Mike, I just found your patch in the latest rc and wanted to ask a few questions. I am not sure how this patch helps at all other than luck in that dm_cblock_t type is of type int32_t, which should guarantee that it is atomic on most platforms. Which begs the question, what platf

Re: Kernel Debugging Support

2014-08-02 Thread Nick Krause
On Sat, Aug 2, 2014 at 9:48 AM, Alan Stern wrote: > On Sat, 2 Aug 2014, Nick Krause wrote: > >> Hey Sharp, >> After reading around seems people want support for usb debugging in >> kgdb or other usb based solutions. >> If you and the other developers are able to help me out a bit as I am >> new I

[PATCH v4 1/1] doc: this_cpu_ops.txt: clarify remote accesses of per cpu areas

2014-08-02 Thread Pranith Kumar
Signed-off-by: Pranith Kumar CC: Christoph Lameter --- v4: more updates from Christoph Lameter v3: clearly mention that remote write access is discouraged v2: updated with comments from Christoph Lameter Documentation/this_cpu_ops.txt | 174 ++--- 1 file chan

Re: [PATCH 1/1] cris: fix %d confusingly prefixed with 0x in format string

2014-08-02 Thread Hans Wennborg
On 08/02/2014 05:46 PM, Joe Perches wrote: On Sat, 2014-08-02 at 15:20 -0700, Hans Wennborg wrote: Signed-off-by: Hans Wennborg --- arch/cris/arch-v32/drivers/cryptocop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris

Re: [PATCH][v3.2.y] xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near

2014-08-02 Thread Ben Hutchings
On Wed, 2014-07-30 at 12:26 -0400, Joseph Salisbury wrote: > Hello, > > Please consider including mainline commit > e3a746f5aab71f2dd0a83116772922fb37ae29d6 in the next v3.2.y release. It > was included in the mainline tree as of v3.5. It has been tested and > confirmed > to resolve http://b

Re: [PATCH RFC] sched: deferred set priority (dprio)

2014-08-02 Thread Sergey Oboguev
On Wed, Jul 30, 2014 at 6:02 AM, Pavel Machek wrote: > Hi! > >> One of the intended purposes of this facility (but its not sole purpose) is >> to >> render a lightweight mechanism for priority protection of lock-holding >> critical >> sections that would be an adequate match for lightweight lock

Re: [PATCH 1/1] cris: fix %d confusingly prefixed with 0x in format string

2014-08-02 Thread Joe Perches
On Sat, 2014-08-02 at 15:20 -0700, Hans Wennborg wrote: > Signed-off-by: Hans Wennborg > --- > arch/cris/arch-v32/drivers/cryptocop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/cris/arch-v32/drivers/cryptocop.c > b/arch/cris/arch-v32/drivers/cryptocop.c [] > @

Re: [PATCH RFC] sched: deferred set priority (dprio)

2014-08-02 Thread Sergey Oboguev
On Mon, Jul 28, 2014 at 12:24 AM, Mike Galbraith wrote: > On Sun, 2014-07-27 at 18:19 -0700, Andi Kleen wrote: >> Sergey Oboguev writes: >> >> > [This is a repost of the message from few day ago, with patch file >> > inline instead of being pointed by the URL.] >> >> Have you checked out the pree

Re: [PATCH] fs: cifs: cifsencrypt.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-08-02 Thread Joe Perches
On Sun, 2014-08-03 at 01:13 +0200, Rickard Strandqvist wrote: > 2014-08-02 19:33 GMT+02:00 Joe Perches : > > On Sat, 2014-08-02 at 11:55 -0500, Shirish Pargaonkar wrote: > >> Acked-by: Shirish Pargaonkar > > [] > >> > diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c > > [] > >> > @@ -307

Re: [PATCH] HID: hid-sensor-hub: use devm_ functions consistently

2014-08-02 Thread Srinivas Pandruvada
On 08/02/2014 03:11 PM, Himangi Saraogi wrote: Use devm_kzalloc for all calls to kzalloc and not just the first. Use devm functions for other allocations as well. The calls to free the allocated memory in the probe and remove functions are done away with and a label is removed in the probe func

[tip:x86/platform] x86/pmc_atom: Silence shift wrapping warnings in pmc_sleep_tmr_show()

2014-08-02 Thread tip-bot for Dan Carpenter
Commit-ID: 4c51cb005b29e6329d7e598bf835689b230817c9 Gitweb: http://git.kernel.org/tip/4c51cb005b29e6329d7e598bf835689b230817c9 Author: Dan Carpenter AuthorDate: Fri, 1 Aug 2014 11:27:15 +0300 Committer: H. Peter Anvin CommitDate: Sat, 2 Aug 2014 16:52:17 -0700 x86/pmc_atom: Silence shi

Re: [PATCH] drivers/net: Use managed interfaces

2014-08-02 Thread David Miller
From: Himangi Saraogi Date: Fri, 1 Aug 2014 21:00:03 +0530 > This patch introduces the use of managed interfaces like > devm_ioremap_resource and does away with the calls to free the > allocated memory in the probe and remove functions. Also, some > labels and variable are done away with. This fi

Re: [PATCH] net: ks8851-ml: Use devm_ioremap_resource

2014-08-02 Thread David Miller
From: Himangi Saraogi Date: Fri, 1 Aug 2014 20:59:13 +0530 > This patch introduces the use of devm_ioremap_resource, devm_kmalloc and > does away with the functions to free the allocated memory in the probe > and remove functions. Also, some labels are done away with. A bug is > fixed as two regi

Re: [PATCH] cirrus: cs89x0: Use managed interfaces

2014-08-02 Thread David Miller
From: Himangi Saraogi Date: Fri, 1 Aug 2014 20:58:19 +0530 > This patch introduces the use of managed interfaces like > devm_ioremap_resource and does away with the functions to free the > allocated memory in the probe and remove functions. Also, many labels > are done away with. The field size i

[PATCH] scsi: ibmvscsi: ibmvstgt.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-08-02 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. Signed-off-by: Rickard Strandqvist --- drivers/scsi/ibmvscsi/ibmvstgt.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvstgt.c b/drivers/scsi/ibmvscsi/ibmvstgt.c index

Re: [PATCH] fs: cifs: cifsencrypt.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-08-02 Thread Rickard Strandqvist
2014-08-02 19:33 GMT+02:00 Joe Perches : > On Sat, 2014-08-02 at 11:55 -0500, Shirish Pargaonkar wrote: >> Acked-by: Shirish Pargaonkar > [] >> > diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c > [] >> > @@ -307,7 +307,7 @@ int calc_lanman_hash(const char *password, const char >> > *cr

Re: [PATCH v3 tip/core/rcu 1/9] rcu: Add call_rcu_tasks()

2014-08-02 Thread Paul E. McKenney
On Fri, Aug 01, 2014 at 08:40:59PM +0200, Oleg Nesterov wrote: > On 08/01, Paul E. McKenney wrote: > > > > On Fri, Aug 01, 2014 at 04:11:44PM +0200, Oleg Nesterov wrote: > > > Not sure this makes any sense, but perhaps we can check for the new > > > callbacks and start the next gp. IOW, the main lo

Re: [PATCH v3 tip/core/rcu 3/9] rcu: Add synchronous grace-period waiting for RCU-tasks

2014-08-02 Thread Paul E. McKenney
On Sat, Aug 02, 2014 at 04:47:19PM +0200, Oleg Nesterov wrote: > On 08/01, Paul E. McKenney wrote: > > > > On Fri, Aug 01, 2014 at 11:32:51AM -0700, Paul E. McKenney wrote: > > > On Fri, Aug 01, 2014 at 05:09:26PM +0200, Oleg Nesterov wrote: > > > > On 07/31, Paul E. McKenney wrote: > > > > > > > >

Re: [PATCH v3 tip/core/rcu 1/9] rcu: Add call_rcu_tasks()

2014-08-02 Thread Paul E. McKenney
On Sat, Aug 02, 2014 at 04:56:16PM +0200, Oleg Nesterov wrote: > On 07/31, Paul E. McKenney wrote: > > > > + rcu_read_lock(); > > + for_each_process_thread(g, t) { > > + if (t != current && ACCESS_ONCE(t->on_rq) && > > + !is_idle_task(t))

Re: [PATCH v3 tip/core/rcu 1/9] rcu: Add call_rcu_tasks()

2014-08-02 Thread Paul E. McKenney
On Fri, Aug 01, 2014 at 08:57:53PM +0200, Oleg Nesterov wrote: > On 07/31, Paul E. McKenney wrote: > > > > + rcu_read_lock(); > > + for_each_process_thread(g, t) { > > + if (t != current && ACCESS_ONCE(t->on_rq) && > > + !is_idle_task(t))

Re: [PATCH] xen-netfront: Fix handling packets on compound pages with skb_segment

2014-08-02 Thread David Miller
From: Wei Liu Date: Fri, 1 Aug 2014 12:02:46 +0100 > On Thu, Jul 31, 2014 at 01:25:20PM -0700, David Miller wrote: >> If you were to have a 64-slot TX queue, you ought to be able to handle >> this theoretical 51 slot SKB. > > There's two problems: > 1. IIRC a single page ring has 256 slots, allo

[PATCH 1/1] cris: fix %d confusingly prefixed with 0x in format string

2014-08-02 Thread Hans Wennborg
Signed-off-by: Hans Wennborg --- arch/cris/arch-v32/drivers/cryptocop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c index 877da19..0ae4f65 100644 --- a/arch/cris/arch-v32/drivers/cryptocop.c +

Re: [PATCH] iovec: make sure the caller actually wants anything in memcpy_fromiovecend

2014-08-02 Thread David Miller
From: Sasha Levin Date: Thu, 31 Jul 2014 23:00:35 -0400 > Check for cases when the caller requests 0 bytes instead of running off > and dereferencing potentially invalid iovecs. > > Signed-off-by: Sasha Levin Applied, thanks. BTW, if you look at the function above this one (memcpy_toiovecend)

Re: [PATCH v3 1/7] ARM: l2c: Refactor the driver to use commit-like interface

2014-08-02 Thread Tomasz Figa
On 03.08.2014 00:09, Russell King - ARM Linux wrote: > On Thu, Jul 17, 2014 at 06:38:56PM +0200, Tomasz Figa wrote: >> Certain implementations of secure hypervisors (namely the one found on >> Samsung Exynos-based boards) do not provide access to individual L2C >> registers. This makes the .write_s

[PATCH] HID: hid-sensor-hub: use devm_ functions consistently

2014-08-02 Thread Himangi Saraogi
Use devm_kzalloc for all calls to kzalloc and not just the first. Use devm functions for other allocations as well. The calls to free the allocated memory in the probe and remove functions are done away with and a label is removed in the probe function. The semantic match that finds the inconsist

[PATCH] net: phy: spi_ks8995: Introduce the use of devm_kzalloc

2014-08-02 Thread Himangi Saraogi
This patch introduces the use of devm_kzalloc and does away with the kfrees in the probe and remove functions. Also, a label is removed. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/phy/spi_ks8995.c | 26 -- 1 file changed, 8 insertions(+), 18 de

Re: [PATCH v3 1/7] ARM: l2c: Refactor the driver to use commit-like interface

2014-08-02 Thread Russell King - ARM Linux
On Thu, Jul 17, 2014 at 06:38:56PM +0200, Tomasz Figa wrote: > Certain implementations of secure hypervisors (namely the one found on > Samsung Exynos-based boards) do not provide access to individual L2C > registers. This makes the .write_sec()-based interface insufficient and > provoking ugly hac

Re: [PATCH v4 net-next 0/5] net: filter: split sk_filter into socket and bpf, cleanup names

2014-08-02 Thread David Miller
From: Alexei Starovoitov Date: Wed, 30 Jul 2014 20:34:11 -0700 > The main goal of the series is to split 'struct sk_filter' into socket and > bpf parts and cleanup names in the following way: > - everything that deals with sockets keeps 'sk_*' prefix > - everything that is pure BPF is changed to

Re: [PATCH v4 net-next 5/5] net: filter: split 'struct sk_filter' into socket and bpf parts

2014-08-02 Thread David Miller
From: Alexei Starovoitov Date: Fri, 1 Aug 2014 12:12:36 -0700 > Dave, this patch has trivial conflict with Daniel's > ("team: fix releasing uninitialized pointer to BPF prog") fix. > Let me know if you want me to respin the series or you'll patch up > the conflict yourself. I took care of this,

mm: BUG in unmap_page_range

2014-08-02 Thread Sasha Levin
Hi all, While fuzzing with trinity inside a KVM tools guest running the latest -next kernel, I've stumbled on the following spew: [ 2957.087977] BUG: unable to handle kernel paging request at ea0003480008 [ 2957.088008] IP: unmap_page_range (mm/memory.c:1132 mm/memory.c:1256 mm/memory.c:1277

Re: [PATCH 4/5] x86: entry_64.S: always allocate complete "struct pt_regs"

2014-08-02 Thread Andy Lutomirski
On Sat, Aug 2, 2014 at 2:23 PM, H. Peter Anvin wrote: > It would be nice to automate running a T-test on it. I'll see if I can do something like that. Using the t statistic seems like overkill here, though -- timing_test_64 runs millions of iterations, so even if I batch them, I'll end up with n

Re: [PATCH 4/5] x86: entry_64.S: always allocate complete "struct pt_regs"

2014-08-02 Thread H. Peter Anvin
It would be nice to automate running a T-test on it. On August 2, 2014 2:14:50 PM PDT, Andy Lutomirski wrote: >On Fri, Aug 1, 2014 at 3:13 PM, H. Peter Anvin wrote: >> On 08/01/2014 03:11 PM, Denys Vlasenko wrote: Could you please try to see if there is a measurable change in the

Re: [PATCH 4/5] x86: entry_64.S: always allocate complete "struct pt_regs"

2014-08-02 Thread Andy Lutomirski
On Fri, Aug 1, 2014 at 3:13 PM, H. Peter Anvin wrote: > On 08/01/2014 03:11 PM, Denys Vlasenko wrote: >>> >>> Could you please try to see if there is a measurable change in the >>> latency of a trivial syscall? >> >> Will do. >> Something along the lines of "how long does it take to execute two >>

[PATCH V3] SYSV: logging update

2014-08-02 Thread Fabian Frederick
-use current logging functions -replace no level printk by pr_err -add debug.c / sysv_err function to include sb->s_id -use pr_fmt with standard KBUILD_MODNAME ": " -use __builtin_return_address to display function name logging format is now: sysv: (sb->s_id) sysv_fill_super [sysv]: msg Signed-off

[PATCH, RESEND] procfs: silence lockdep warning about read vs. exec seq_file

2014-08-02 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" Testcase: cat /proc/self/maps >/dev/null chmod +x /proc/self/net/packet exec /proc/self/net/packet It triggers lockdep warning: [ INFO: possible circular locking dependency detected ] 3.16.0-rc7-00064-g26bcd8b72563 #8 Not tainted

[PATCH v5.1 9/7] watchdog: s3c2410: add restart handler

2014-08-02 Thread Heiko Stübner
On a lot of Samsung systems the watchdog is responsible for restarting the system and until now this code was contained in plat-samsung/watchdog-reset.c . With the introduction of the restart handlers, this code can now move into driver itself, removing the need for arch-specific code. Tested on

[PATCH v5.1 10/7] clk: samsung: register restart handlers for s3c2412 and s3c2443

2014-08-02 Thread Heiko Stübner
S3C2412, S3C2443 and their derivatives contain a special software-reset register in their system-controller. Therefore register a restart handler for those. Tested on a s3c2416-based board, s3c2412 compile-tested. Signed-off-by: Heiko Stuebner [ Guenter Roeck: Updated to latest API version] Sig

Re: [PATCH v2 06/25] drm/radeon: Add radeon <--> amdkfd interface

2014-08-02 Thread Oded Gabbay
On 20/07/14 20:35, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:13PM +0300, Oded Gabbay wrote: >> This patch adds the interface between the radeon driver and the amdkfd >> driver. >> The interface implementation is contained in radeon_kfd.c and radeon_kfd.h. >> >> The interface itself is

[RFC][PATCH] locking: Debug nested wait/locking primitives

2014-08-02 Thread Peter Zijlstra
This should cover most cases I think. I'll have to break this out into different patches, and maybe clean up things a bit (there's certainly comments missing and some repetition). But this boots on my test box and builds a kernel without generating a single WARN -- big improvement over not booti

Re: [PATCH v2 08/25] amdkfd: Add IOCTL set definitions of amdkfd

2014-08-02 Thread Oded Gabbay
On 20/07/14 19:54, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:15PM +0300, Oded Gabbay wrote: >> - KFD_IOC_GET_VERSION: >> Retrieves the interface version of amdkfd >> >> - KFD_IOC_CREATE_QUEUE: >> Creates a usermode queue that runs on a specific GPU device >> >> - KFD_IOC_DEST

Re: [PATCH v2 09/25] amdkfd: Add amdkfd skeleton driver

2014-08-02 Thread Oded Gabbay
On 20/07/14 20:09, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:16PM +0300, Oded Gabbay wrote: >> This patch adds the amdkfd skeleton driver. The driver does nothing except >> define a /dev/kfd device. >> >> It returns -ENODEV on all amdkfd IOCTLs. >> >> Signed-off-by: Oded Gabbay >> ---

Re: [PATCH v2 11/25] amdkfd: Add basic modules to amdkfd

2014-08-02 Thread Oded Gabbay
On 21/07/14 02:02, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:18PM +0300, Oded Gabbay wrote: >> From: Andrew Lewycky >> >> This patch adds the process module and 4 helper modules: >> >> - kfd_process, which handles process which open /dev/kfd >> - kfd_doorbell, which provides helper fu

Re: [PATCH v2 14/25] amdkfd: Add mqd_manager module

2014-08-02 Thread Oded Gabbay
On 21/07/14 05:33, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:21PM +0300, Oded Gabbay wrote: >> From: Ben Goz >> >> The mqd_manager module handles MQD data structures. MQD stands for Memory >> Queue Descriptor, which is used by the H/W to keep the usermode queue state >> in memory. >

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-08-02 Thread Maxime Ripard
On Sat, Aug 02, 2014 at 04:17:14PM +0100, Russell King - ARM Linux wrote: > On Sat, Aug 02, 2014 at 04:49:25PM +0200, Maxime Ripard wrote: > > In the case of the call to device_control, especially in the > > DMA_SLAVE_CONFIG case, but that also applies to pause/resume, are the > > changes supposed

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-08-02 Thread Maxime Ripard
On Sat, Aug 02, 2014 at 04:29:21PM +0100, Russell King - ARM Linux wrote: > On Sat, Aug 02, 2014 at 05:11:44PM +0200, Maxime Ripard wrote: > > On Fri, Aug 01, 2014 at 03:53:26PM +0100, Russell King - ARM Linux wrote: > > > > > > - That might just be my experience, but judging from previous > > >

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-08-02 Thread Maxime Ripard
On Sat, Aug 02, 2014 at 10:02:08AM +0200, Wim Van Sebroeck wrote: > Maxime, All, > > > > 1) For me the discussion was not ended and needs further > > > thinking. (And I just read some good ideas about it). > > > > It would have been great for you to mention it then. > > > > > 2) You never mentio

Re: Soft lockups during reading /proc/PID/smaps

2014-08-02 Thread Oleg Nesterov
On 07/31, Aleksei Besogonov wrote: > > On 31 Jul 2014, at 00:43, David Rientjes wrote: > > > The while_each_thread() in vm_is_stack() looks suspicious since the task > > isn't current and rcu won't protect the iteration, and we also don't hold > > sighand lock or a readlock on tasklist_lock. > > I

[PATCH] perf tools: report PERF_FLAG_FD_CLOEXEC probing error once

2014-08-02 Thread Yann Droneaud
In case of failure, unrelated to PERF_FLAG_FD_CLOEXEC, perf_flag_probe() reports the error twice. For example: $ perf record ls Error: perf_event_open(..., PERF_FLAG_FD_CLOEXEC) failed with unexpected error 16 (Device or resource busy) perf_event_open(..., 0) failed unexpectedly with erro

Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist

2014-08-02 Thread Johannes Weiner
On Fri, Aug 01, 2014 at 02:42:19PM -0700, David Rientjes wrote: > On Fri, 1 Aug 2014, Johannes Weiner wrote: > > > > > out_of_memory() wants the zonelist that was used during allocation, > > > > not just the random first node's zonelist that's simply picked to > > > > serialize page fault OOM kill

Re: [PATCH] perf tools: Show better error message in case we fail to open counters due to EBUSY error

2014-08-02 Thread Yann Droneaud
Hi Jiri, Le vendredi 01 août 2014 à 17:46 +0200, Jiri Olsa a écrit : > Showing better error message in case we fail to open > counters due to the EBUSY error. If we detect oprofile > daemon process running, we now display following message > for EBUSY error: > > $ perf record ls > Error: >

Re: [PATCH] fs: cifs: cifsencrypt.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-08-02 Thread Joe Perches
On Sat, 2014-08-02 at 11:55 -0500, Shirish Pargaonkar wrote: > Acked-by: Shirish Pargaonkar [] > > diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c [] > > @@ -307,7 +307,7 @@ int calc_lanman_hash(const char *password, const char > > *cryptkey, bool encrypt, > > > > memset(passwo

Re: TIF_NOHZ can escape nonhz mask? (Was: [PATCH v3 6/8] x86: Split syscall_trace_enter into two phases)

2014-08-02 Thread Oleg Nesterov
On 07/31, Frederic Weisbecker wrote: > > On Thu, Jul 31, 2014 at 08:12:30PM +0200, Oleg Nesterov wrote: > > > > > > > > Yes sure. But context_tracking_cpu_set() is called by init task with > > > > PID 1, not > > > > by "swapper". > > > > > > Are you sure? It's called from start_kernel() which is i

Re: [PATCHv9 1/3] mfd: altera: Add Altera SDRAM Controller

2014-08-02 Thread Steffen Trumtrar
Hi! On Fri, Aug 01, 2014 at 05:27:57PM -0500, Thor Thayer wrote: > > On 08/01/2014 03:13 AM, Lee Jones wrote: > >On Thu, 31 Jul 2014, Thor Thayer wrote: > >>On 07/31/2014 03:26 AM, Lee Jones wrote: > >>>On Wed, 30 Jul 2014, ttha...@opensource.altera.com wrote: [...] > +u32 altera_sdr_readl(

Re: [PATCH] fs: cifs: cifsencrypt.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-08-02 Thread Shirish Pargaonkar
Acked-by: Shirish Pargaonkar On Sat, Jul 26, 2014 at 5:28 PM, Rickard Strandqvist wrote: > If you are going to use memset before strncpy you must copy sizeof -1 > > Signed-off-by: Rickard Strandqvist > --- > fs/cifs/cifsencrypt.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

[PATCH 1/1 V2] Drivers: net-next: hyperv: Increase the size of the sendbuf region

2014-08-02 Thread K. Y. Srinivasan
Intel did some benchmarking on our network throughput when Linux on Hyper-V is as used as a gateway. This fix gave us almost a 1 Gbps additional throughput on about 5Gbps base throughput we hadi, prior to increasing the sendbuf size. The sendbuf mechanism is a copy based transport that we have whic

RE: [PATCH 1/1] Drivers: net-next: hyperv: Increase the size of the sendbuf region

2014-08-02 Thread KY Srinivasan
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, August 1, 2014 11:14 PM > To: KY Srinivasan > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com > Subjec

[3.16-rcX][pciehp][radeon] PCIe HotPlug conflicts with radeon GPU

2014-08-02 Thread Shawn Starr
Hello devs, There are two issues I am encountering with the PCIe Hotplug driver on my Lenovo Laptop (W500). I note this goes back further than 3.15. It is noted here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f244d8b623dae7a7bc695b0336f67729b95a9736 https://bugzi

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-08-02 Thread Guenter Roeck
On Sat, Aug 02, 2014 at 10:02:08AM +0200, Wim Van Sebroeck wrote: > Maxime, All, > > > > 1) For me the discussion was not ended and needs further > > > thinking. (And I just read some good ideas about it). > > > > It would have been great for you to mention it then. > > > > > 2) You never mentio

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-08-02 Thread Russell King - ARM Linux
On Sat, Aug 02, 2014 at 05:11:44PM +0200, Maxime Ripard wrote: > On Fri, Aug 01, 2014 at 03:53:26PM +0100, Russell King - ARM Linux wrote: > > > > > - That might just be my experience, but judging from previous > > > > > commits, DMA_PRIVATE is completely obscure, and we just set it > > > > >

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-08-02 Thread Russell King - ARM Linux
On Sat, Aug 02, 2014 at 04:49:25PM +0200, Maxime Ripard wrote: > In the case of the call to device_control, especially in the > DMA_SLAVE_CONFIG case, but that also applies to pause/resume, are the > changes supposed to be immediates or can they happen later? pause/resume are expected to operate s

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-08-02 Thread Maxime Ripard
On Fri, Aug 01, 2014 at 08:09:17PM +0200, Lars-Peter Clausen wrote: > On 08/01/2014 07:15 PM, Vinod Koul wrote: > >On Fri, Aug 01, 2014 at 10:57:07AM +0200, Maxime Ripard wrote: > >>On Fri, Aug 01, 2014 at 10:00:10AM +0200, Lars-Peter Clausen wrote: > >>>On 07/31/2014 07:37 PM, Maxime Ripard wrote:

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-08-02 Thread Maxime Ripard
On Fri, Aug 01, 2014 at 03:53:26PM +0100, Russell King - ARM Linux wrote: > > > > - That might just be my experience, but judging from previous > > > > commits, DMA_PRIVATE is completely obscure, and we just set it > > > > because it was making it work, without knowing what it was > > > >

Re: [PATCH v3 tip/core/rcu 1/9] rcu: Add call_rcu_tasks()

2014-08-02 Thread Oleg Nesterov
On 07/31, Paul E. McKenney wrote: > > + rcu_read_lock(); > + for_each_process_thread(g, t) { > + if (t != current && ACCESS_ONCE(t->on_rq) && > + !is_idle_task(t)) { I didn't notice this check before, but it is not needed. for_eac

[PATCH] cw1200: Introduce the use of devm_kzalloc

2014-08-02 Thread Himangi Saraogi
This patch introduces the use of devm_kzalloc and does away with the kfrees in the probe and remove functions. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/wireless/cw1200/cw1200_spi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wi

Re: [PATCH] Documentation: dmaengine: Add a documentation for the dma controller API

2014-08-02 Thread Maxime Ripard
On Fri, Aug 01, 2014 at 10:43:06PM +0530, Vinod Koul wrote: > On Thu, Jul 31, 2014 at 06:23:30PM +0200, Maxime Ripard wrote: > > On Thu, Jul 31, 2014 at 05:26:28PM +0530, Vinod Koul wrote: > > > > Also, feel free to add anything that you feel like you keep saying > > during the review. If mistakes

Re: [PATCH v3 tip/core/rcu 3/9] rcu: Add synchronous grace-period waiting for RCU-tasks

2014-08-02 Thread Oleg Nesterov
On 08/01, Paul E. McKenney wrote: > > On Fri, Aug 01, 2014 at 11:32:51AM -0700, Paul E. McKenney wrote: > > On Fri, Aug 01, 2014 at 05:09:26PM +0200, Oleg Nesterov wrote: > > > On 07/31, Paul E. McKenney wrote: > > > > > > > > +void synchronize_rcu_tasks(void) > > > > +{ > > > > + /* Complain

[PATCH] arch/x86/kernel/cpu/cyrix.c: remove redundant code

2014-08-02 Thread Daniele Forsi
This function doesn't read dir1 so it doesn't need to set a default value and code for case 3 and case 5 is identical so replace it with a "fall through" comment. Signed-off-by: Daniele Forsi --- arch/x86/kernel/cpu/cyrix.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [f2fs-dev][PATCH 2/2] f2fs: invalidate xattr node page when evict inode

2014-08-02 Thread Jaegeuk Kim
Hi Chao, On Thu, Jul 31, 2014 at 09:13:11PM +0800, Chao Yu wrote: > When inode is evicted, all the page cache belong to this inode should be > released including the xattr node page. But previously we didn't do this, this > patch fixed this issue. > > Signed-off-by: Chao Yu > --- > fs/f2fs/inod

Re: [PATCH v2 3/7] usb: phy: mxs: Add VF610 USB PHY support

2014-08-02 Thread Stefan Agner
Am 2014-08-02 02:36, schrieb Peter Chen: > On Mon, Jul 28, 2014 at 04:57:29PM +0200, Stefan Agner wrote: >> This adds support for the USB PHY in Vybrid VF610. We assume that >> the disconnection without VBUS is also needed for Vybrid. >> >> Tests showed, without MXS_PHY_NEED_IP_FIX, enumeration of

Re: [PATCH] can: mcp251x: Use dmam_alloc_coherent

2014-08-02 Thread Alexander Shiyan
Sat, 2 Aug 2014 19:22:04 +0530 от Himangi Saraogi : > This patch moves the data allocated using dma_alloc_coherent to the > corresponding managed interface and does away with the calls to free the > allocated memory in the probe and remove functions. Just for information: On my opinion, all SPI DM

[PATCH] can: mcp251x: Use dmam_alloc_coherent

2014-08-02 Thread Himangi Saraogi
This patch moves the data allocated using dma_alloc_coherent to the corresponding managed interface and does away with the calls to free the allocated memory in the probe and remove functions. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/can/spi/mcp251x.c | 16 -

Re: Kernel Debugging Support

2014-08-02 Thread Alan Stern
On Sat, 2 Aug 2014, Nick Krause wrote: > Hey Sharp, > After reading around seems people want support for usb debugging in > kgdb or other usb based solutions. > If you and the other developers are able to help me out a bit as I am > new I can definitively write this > area of kgdb support. Doesn'

Re: [PATCH 8/8] perf symbol: Don't demangle parameters and such by default

2014-08-02 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 31, 2014 at 02:47:42PM +0900, Namhyung Kim escreveu: > Some C++ symbols have very long name and they make column length > longer. Most of them are about parameters including templates and we > can ignore such info most of time IMHO. > > This patch passes DMGL_NO_OPTS by default when c

Re: [PATCH 2/8] perf tools: Make __hpp__fmt() receive an additional len argument

2014-08-02 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 31, 2014 at 02:47:36PM +0900, Namhyung Kim escreveu: > So that it can properly handle alignment requirements later. To do > that, add percent_color_len_snprintf() fucntion to help coloring of > overhead columns. Can you elaborate on this description? What is not possible to do before

  1   2   >