Re: [PATCH] iwl4965: Enable checking of format strings

2015-02-12 Thread Mark Rustad
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2/12/15 2:20 AM, Rasmus Villemoes wrote: > Rather weak arguments, but I have three of them :-) Yes, weak. All three. > (1) If I'm reading some code and spot a non-constant format > argument, I sometimes track back to see how e.g. fmt_value is >

Re: [PATCH v8 00/21] Introduce ACPI for ARM64 based on ACPI 5.1

2015-02-12 Thread Hanjun Guo
Hi Jonathan, On 2015年02月13日 08:50, Jonathan (Zhixiong) Zhang wrote: On 02/02/2015 05:45 AM, Hanjun Guo wrote: From: Al Stone Two more documentation files are also being added: (1) A verbatim copy of the "Why ACPI on ARM?" blog posting by Grant Likely, which is also summarized in

Re: [PATCH 02/13] clk: mediatek: Add initial common clock support for Mediatek SoCs.

2015-02-12 Thread Tomasz Figa
Hi, Let me add some suggestions inline. On Mon, Feb 9, 2015 at 7:47 PM, Sascha Hauer wrote: > From: James Liao > > This patch adds common clock support for Mediatek SoCs, including plls, > muxes and clock gates. [snip] > +static int mtk_cg_enable(struct clk_hw *hw) > +{ > +

Re: [PATCH 1/1] Staging: dgnc: dgnc_tty: code style improvements

2015-02-12 Thread Dan Carpenter
On Thu, Feb 12, 2015 at 11:18:50PM -0800, tolga ceylan wrote: > Just noticed this warning in all dgnc_* files: > > *NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE! > * > *This is shared code between Digi's CVS archive and the > *Linux Kernel sources. > *Changing the

Re: [PATCH 10/11] ARM: sti: always enable RESET_CONTROLLER

2015-02-12 Thread Patrice Chotard
Hi Arnd On 02/12/2015 08:42 PM, Arnd Bergmann wrote: A lot of the sti device drivers require reset controller support, but do not all have individual 'depends on RESET_CONTROLLER' statements. Using 'select' here once avoids a lot of build errors resulting from this. Signed-off-by: Arnd

Re: [PATCH v2 2/3] clk: Add __clk_hw_set_clk helper function

2015-02-12 Thread Javier Martinez Canillas
Hello Stephen, On 02/12/2015 08:55 PM, Stephen Boyd wrote: > On 02/12/15 05:58, Javier Martinez Canillas wrote: >> After the clk API change to return a per-user clock instance, both the >> struct clk_core and struct clk pointers from the hw clock needs to be >> assigned to clock that share the

[PATCH] mmc: dw_mmc: rockchip: add support MMC_CAP_RUNTIME_RESUME capability

2015-02-12 Thread Addy Ke
To support HS200 and UHS mode, mmc core will call init_card() to execute tuning: - sdio: init_card can be executed at runtime resume. - sd and mmc: init_card can be executed at resume or runtime resume, which depends on MMC_CAP_RUNTIME_RESUME capability. On rk3288 SoC, host will get DRTO

Re: [PATCH v2 3/3] clk: Replace explicit clk assignment with __clk_hw_set_clk

2015-02-12 Thread Javier Martinez Canillas
Hello Stephen, On 02/12/2015 08:55 PM, Stephen Boyd wrote: > On 02/12/15 05:58, Javier Martinez Canillas wrote: >> >> The changes were made using the following cocinelle semantic patch: >> >> @i@ >> @@ >> >> @depends on i@ >> identifier dst; >> @@ >> >> - dst->clk = hw->clk; >> +

Re: [PATCH 1/1] Staging: dgnc: dgnc_tty: code style improvements

2015-02-12 Thread tolga ceylan
On 02/12/2015 10:20 PM, Joe Perches wrote: On Thu, 2015-02-12 at 21:58 -0800, Tolga Ceylan wrote: On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter wrote: That looks kind of uglier than before. Please run your patch throught scripts/checkpatch.pl --strict. [] Running with --strict helped, but

[PATCH v2] perf: fix building error in x86_64

2015-02-12 Thread He Kuang
When build with ARCH=x86_64, perf failed to compile with following error: tests/builtin-test.o:(.data+0x158): undefined reference to `test__perf_time_to_tsc' collect2: error: ld returned 1 exit status Makefile.perf:632: recipe for target 'perf' failed ... Which is caused commit c6e5e9fbc3ea1

Re: [PATCH v5] perf: Use monotonic clock as a source for timestamps

2015-02-12 Thread Adrian Hunter
On 12/02/15 12:28, Peter Zijlstra wrote: > On Thu, Feb 12, 2015 at 12:04:54PM +0200, Adrian Hunter wrote: >> On 11/02/15 18:12, Peter Zijlstra wrote: >>> >>> How about something like the below? I _think_ it should mostly work for >>> x86, where the tsc is a 64bit wide cycle counter. >> >> It would

[PULL] modules-next

2015-02-12 Thread Rusty Russell
The following changes since commit f8de05ca38b7bce4079b52002a6817e9582e3e01: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux (2015-01-23 06:53:06 +1200) are available in the git repository at:

Re: [PATCH v2] usb: dwc2: Register interrupt handler only once gadget is correctly initialized

2015-02-12 Thread Romain Perier
No problem Regards, Romain 2015-02-13 3:47 GMT+01:00 John Youn : > On 2/12/2015 4:42 AM, Romain Perier wrote: >> ping >> >> 2015-02-06 17:50 GMT+01:00 Romain Perier : >>> Don't register interrupt handler before usb gadget is correctly initialized. >>> For some embedded platforms which don't have

[PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style improvements

2015-02-12 Thread Tolga Ceylan
Code reformatting based on checkpatch.pl with --strict: 1) Lines over 80 characters were fixed 2) Alignment should match open paranthesis cases corrected 3) Comparison to NULL rewritten as !indio_dev Signed-off-by: Tolga Ceylan --- drivers/staging/iio/meter/ade7854-i2c.c | 39

[PATCH V4] x86 spinlock: Fix memory corruption on completing completions

2015-02-12 Thread Raghavendra K T
Paravirt spinlock clears slowpath flag after doing unlock. As explained by Linus currently it does: prev = *lock; add_smp(>tickets.head, TICKET_LOCK_INC); /* add_smp() is a full mb() */ if (unlikely(lock->tickets.tail &

Re: [RFC 07/16] mm/page_isolation: watch out zone range overlap

2015-02-12 Thread Gioh Kim
> diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index c8778f7..883e78d 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -210,8 +210,8 @@ int undo_isolate_page_range(unsigned long start_pfn, > unsigned long end_pfn, >* Returns 1 if all pages in the range are

Re: [PATCH 1/1] Staging: dgnc: dgnc_tty: code style improvements

2015-02-12 Thread Joe Perches
On Thu, 2015-02-12 at 21:58 -0800, Tolga Ceylan wrote: > On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter > wrote: > > That looks kind of uglier than before. Please run your patch throught > > scripts/checkpatch.pl --strict. [] > Running with --strict helped, but now I'm also getting warnings for

Re: [PATCH 1/3] cpuset: initialize effective masks when clone_children is enabled

2015-02-12 Thread Serge E. Hallyn
Quoting Zefan Li (lize...@huawei.com): > If clone_children is enabled, effective masks won't be initialized > due to the bug: > > # mount -t cgroup -o cpuset xxx /mnt > # echo 1 > cgroup.clone_children > # mkdir /mnt/tmp > # cat /mnt/tmp/ > # cat cpuset.effective_cpus > > # cat

Re: [PATCH 1/1] Staging: dgnc: dgnc_tty: code style improvements

2015-02-12 Thread Tolga Ceylan
On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter wrote: > That looks kind of uglier than before. Please run your patch throught > scripts/checkpatch.pl --strict. > > regards, > dan carpenter > Running with --strict helped, but now I'm also getting warnings for camel case usage. If I try to fix

[RFC PATCH v3 24/26] early kprobes: core logic to support early kprobe on ftrace.

2015-02-12 Thread Wang Nan
This is the main patch to support early kprobes on ftrace. Utilizes previous introduced ftrace update notification chain to fix possible ftrace code modifition failuer. For early kprobes on ftrace, register ftrace_notifier_call() to ftrace update notifier to receive ftrace code conversion

linux-next: Tree for Feb 13

2015-02-12 Thread Stephen Rothwell
Hi all, Please do not add any material destined for v3.21 to your linux-next included trees until after v3.20-rc1 has been released. Changes since 20150212: The mips tree gained a conflict against Linus' tree. Non-merge commits (relative to Linus' tree): 4418 4081 files changed, 183203

[RFC PATCH v3 04/26] ftrace: don't update record flags if code modification fail.

2015-02-12 Thread Wang Nan
X86 and common ftrace_replace_code() behave differently. In x86, rec->flags get updated only when (almost) all works are done. In common code, rec->flags is updated before code modification, and never get restored when code modification fails. This patch ensures rec->flags kept its original

[RFC PATCH v3 07/26] ftrace: allow search ftrace addr before ftrace fully inited.

2015-02-12 Thread Wang Nan
This patch enables ftrace_location() to be used before ftrace_init(). The first user should be early kprobes, which can insert kprobes to kernel code even before setup_arch() finishes. This patch gives it a chance to determine whether it is probing ftrace entries and allows it do some special

[RFC PATCH v3 05/26] ftrace/x86: Ensure rec->flags no change when failure occures.

2015-02-12 Thread Wang Nan
Don't change rec->flags if code modification fails. Signed-off-by: Wang Nan --- arch/x86/kernel/ftrace.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c index 8b7b0a5..7bdba65 100644 ---

[RFC PATCH v3 17/26] early kprobes: introduces macros for allocing early kprobe resources.

2015-02-12 Thread Wang Nan
Introduces macros to genearte common early kprobe related resource allocator. All early kprobe related resources are statically allocated during linking for each early kprobe slot. For each type of resource, a bitmap is used to track allocation. __DEFINE_EKPROBE_ALLOC_OPS defines alloc and free

[RFC PATCH v3 16/26] early kprobes: x86: introduce early kprobes related code area.

2015-02-12 Thread Wang Nan
This patch introduces EARLY_KPROBES_CODES_AREA into x86 vmlinux for early kprobes. Signed-off-by: Wang Nan --- arch/x86/include/asm/insn.h| 7 --- arch/x86/include/asm/kprobes.h | 47 +++--- arch/x86/kernel/vmlinux.lds.S | 2 ++ 3 files changed, 45

[RFC PATCH v3 18/26] early kprobes: allows __alloc_insn_slot() from early kprobes slots.

2015-02-12 Thread Wang Nan
Introduces early_slots_start/end and bitmap for struct kprobe_insn_cache then uses previous introduced macro to generate allocator. This patch makes get/free_insn_slot() and get/free_optinsn_slot() transparent to early kprobes. Signed-off-by: Wang Nan --- include/linux/kprobes.h | 40

[RFC PATCH v3 19/26] early kprobes: perhibit probing at early kprobe reserved area.

2015-02-12 Thread Wang Nan
Puts early kprobe reserved area into kprobe blacklist. Signed-off-by: Wang Nan --- kernel/kprobes.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/kernel/kprobes.c b/kernel/kprobes.c index fa1e422..b83c406 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -1358,6 +1358,13 @@

[RFC PATCH v3 26/26] kprobes: enable 'ekprobe=' cmdline option for early kprobes.

2015-02-12 Thread Wang Nan
This patch shows a very rough usage of arly kprobes. By adding kernel cmdline options such as 'ekprobe=__alloc_pages_nodemask' or 'ekprobe=0xc00f3c2c', early kprobes are installed. When the probed instructions get hit, a message is printed. This patch is only a sample. I'll drop it in future

[RFC PATCH v3 15/26] early kprobes: x86: directly modify code.

2015-02-12 Thread Wang Nan
When registering early kprobes, SMP should has not been enabled, so doesn't require synchronization in text_poke_bp(). Simply memcpy is enough. Signed-off-by: Wang Nan --- arch/x86/kernel/kprobes/opt.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[RFC PATCH v3 22/26] early kprobes: introduce arch_fix_ftrace_early_kprobe().

2015-02-12 Thread Wang Nan
This patch is for futher use. arch_fix_ftrace_early_kprobe() will be called when ftrace trying to convert ftrace entries to nop and fail. For x86 it should adjust the saved nop instruction here because it doesn't know what nop ftrace will choose when early probing. Signed-off-by: Wang Nan ---

[RFC PATCH v3 21/26] early kprobes: add CONFIG_EARLY_KPROBES option.

2015-02-12 Thread Wang Nan
Enable early kprobes in Kconfig. Signed-off-by: Wang Nan --- arch/Kconfig | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/Kconfig b/arch/Kconfig index 05d7a8a..32e9f4a 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -46,6 +46,21 @@ config KPROBES for kernel

[RFC PATCH v3 20/26] early kprobes: core logic of eraly kprobes.

2015-02-12 Thread Wang Nan
This patch is the main logic of early kprobe. If register_kprobe() is called before kprobes_initialized, an early kprobe is allocated. Try to utilize existing OPTPROBE mechanism to replace the target instruction by a branch instead of breakpoint, because interrupt handlers may not been

[RFC PATCH v3 12/26] early kprobes: Add an KPROBE_FLAG_EARLY for early kprobe.

2015-02-12 Thread Wang Nan
Introduce a KPROBE_FLAG_EARLY for futher using. KPROBE_FLAG_EARLY indicates a kprobe is installed at very early stage, its resources should be allocated statically. Signed-off-by: Wang Nan --- include/linux/kprobes.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/kprobes.h

[RFC PATCH v3 02/26] kprobes: makes kprobes/enabled works correctly for optimized kprobes.

2015-02-12 Thread Wang Nan
debugfs/kprobes/enabled doesn't work correctly on optimized kprobes. Masami Hiramatsu has a test report on x86_64 platform: https://lkml.org/lkml/2015/1/19/274 This patch forces it to unoptimize kprobe if kprobes_all_disarmed is set. It also checks the flag in unregistering path for skipping

[RFC PATCH v3 01/26] kprobes: set kprobes_all_disarmed earlier to enable re-optimization.

2015-02-12 Thread Wang Nan
In original code, the probed instruction doesn't get optimized after echo 0 > /sys/kernel/debug/kprobes/enabled echo 1 > /sys/kernel/debug/kprobes/enabled This is because original code checks kprobes_all_disarmed in optimize_kprobe(), but this flag is turned off after calling that function.

[RFC PATCH v3 10/26] ftrace: x86: try to fix ftrace when ftrace_replace_code.

2015-02-12 Thread Wang Nan
For ftrace x86, when ftrace_replace_code(), if it failed to add breakpoint, trigger a bugfix trying instead of ftrace_bug(). Only give one chance for fixing at add_breakpoints(). If it fails at other stage, bug directly. Signed-off-by: Wang Nan --- arch/x86/kernel/ftrace.c | 12 ++-- 1

[RFC PATCH v3 00/26] Early kprobe: enable kprobes at very early booting stage.

2015-02-12 Thread Wang Nan
I fell very sorry for people who reviewed my v2 patch series yesterday at https://lkml.org/lkml/2015/2/12/234 because I didn't provide enough information in commit log. This v3 patch series add those missing commit messages. There are also 2 small fix based on v2: 1. Fixes

[RFC PATCH v3 14/26] early kprobes: ARM: introduce early kprobes related code area.

2015-02-12 Thread Wang Nan
In arm's vmlinux.lds, introduces code area inside text section. Executable area used by early kprobes will be allocated from there. Signed-off-by: Wang Nan --- arch/arm/include/asm/kprobes.h | 31 +-- arch/arm/kernel/vmlinux.lds.S | 2 ++ 2 files changed, 31

[RFC PATCH v3 13/26] early kprobes: ARM: directly modify code.

2015-02-12 Thread Wang Nan
For early kprobe, we can simply patch text because we are in a relative simple environment. Signed-off-by: Wang Nan --- arch/arm/probes/kprobes/opt-arm.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/arm/probes/kprobes/opt-arm.c

[RFC PATCH v3 00/26] Early kprobe: enable kprobes at very early booting stage.

2015-02-12 Thread Wang Nan
I fell very sorry for people who reviewed my v2 patch series yesterday at https://lkml.org/lkml/2015/2/12/234 because I didn't provide enough information in commit log. This v3 patch series add those missing commit messages. There are also 2 small fix based on v2: 1. Fixes

[RFC PATCH v3 06/26] ftrace: sort ftrace entries earlier.

2015-02-12 Thread Wang Nan
By extracting mcount sorting code and sort them earliler, futher patches will be able to determine whether an address is on an ftrace entry or not using bsearch(). ftrace_sort_mcount_area() will be called before, during and after ftrace_init (when module insertion). Ensure it sort kernel mcount

[RFC PATCH v3 11/26] early kprobes: introduce kprobe_is_early for futher early kprobe use.

2015-02-12 Thread Wang Nan
Following early kprobe patches will enable kprobe registering very early, even before kprobe system initialized. kprobe_is_early() can be used to check whether we are working on early kprobe. Signed-off-by: Wang Nan --- include/linux/kprobes.h | 2 ++ kernel/kprobes.c| 6 ++ 2 files

[RFC PATCH v3 25/26] early kprobes: introduce kconfig option to support early kprobe on ftrace.

2015-02-12 Thread Wang Nan
On platform (like x86) which supports CONFIG_KPROBE_ON_FTRACE, makes early kprobe depend on it so we are able to probe function entries. Signed-off-by: Wang Nan --- arch/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/Kconfig b/arch/Kconfig index

[RFC PATCH v3 23/26] early kprobes: x86: arch_restore_optimized_kprobe().

2015-02-12 Thread Wang Nan
arch_restore_optimized_kprobe() can be used to temporarily restore probed instruction. It will actually disable optimized kprobe, but keep the relatived data structure. It uses stop_machine() to enforce atimicity. Signed-off-by: Wang Nan --- arch/x86/kernel/kprobes/opt.c | 26

[RFC PATCH v3 08/26] ftrace: enable make ftrace nop before ftrace_init().

2015-02-12 Thread Wang Nan
This patch is for early kprobes. Ftrace converts ftrace entries to nop when init, which will conflict with early kprobes if it probe on an ftrace entry before such conversion. For x86, ftrace entries is 'call' instruction which is happends unboostable. This patch provides

[RFC PATCH v3 03/26] kprobes: x86: mark 2 bytes NOP as boostable.

2015-02-12 Thread Wang Nan
Currently, x86 kprobes is unable to boost 2 bytes nop like: nopl 0x0(%rax,%rax,1) which is 0x0f 0x1f 0x44 0x00 0x00. Such nops have exactly 5 bytes which is able to hold a relative jmp instruction. Boosting them should be obviously safe. This patch enable boosting such nops by simply updating

[RFC PATCH v3 09/26] ftrace: allow fixing code update failure by notifier chain.

2015-02-12 Thread Wang Nan
This patch introduces a notifier chain (ftrace_update_notifier_list) and ftrace_tryfix_bug(). The goal of this patch is to provide other subsystem a chance to fix code if they alert ftrace entries before ftrace_init(). Such subsystems should register a callback with

Re: [RESEND Patch V2 1/4] xen: build infrastructure for generating hypercall depending symbols

2015-02-12 Thread Juergen Gross
## ### # # # # # # ### # # # # # # # # # ### # # # # # # # # # # # # # ### # # #### # # # David still wants a comment from the x86 maintainers... Juergen On 01/21/2015

[LKP] [mmu_gather] fb7332a9fed: +5.4% tlbflush.mem_acc_time_thread_ms -6.2% will-it-scale.per_thread_ops

2015-02-12 Thread Huang Ying
FYI, we noticed the below changes on commit fb7332a9fedfd62b1ba6530c86f39f0fa38afd49 ("mmu_gather: move minimal range calculations into generic code") testbox/testcase/testparams: ivb42/will-it-scale/performance-brk1 63648dd20fa0780a fb7332a9fedfd62b1ba6530c86

[PATCH] virtio: don't set VIRTIO_CONFIG_S_DRIVER_OK twice.

2015-02-12 Thread Rusty Russell
I noticed this with the console device. It's not *wrong*, just a bit weird. Signed-off-by: Rusty Russell diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index b9f70dfc4751..5ce2aa48fc6e 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -236,7 +236,10 @@

[LKP] [mutex] 6aa15f5a2fe: -9.2% will-it-scale.per_process_ops

2015-02-12 Thread Huang Ying
FYI, we noticed the below changes on git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git locking/core commit 6aa15f5a2febe058056180786bb39513ad5ae70d ("mutex: In mutex_spin_on_owner(), return true when owner changes") testbox/testcase/testparams:

Re: [PATCH] perf: fix building error in x86_64

2015-02-12 Thread Namhyung Kim
On Thu, Feb 12, 2015 at 04:56:44PM +0800, Hekuang wrote: > > 在 2015/2/12 16:07, Namhyung Kim 写道: > >Hi, > > > >On Wed, Feb 11, 2015 at 10:01:08AM +0800, He Kuang wrote: > >>When build with ARCH=x86_64, perf failed to compile with following error: > >> > >>tests/builtin-test.o:(.data+0x158):

[PATCH] mfd: stw481x: Remove unused fields from struct stw481x

2015-02-12 Thread Axel Lin
The mutex lock is not used at all, remove it. The *vmmc_regulator is not necessary, use a local variable in stw481x_vmmc_regulator_probe() instead. Signed-off-by: Axel Lin --- drivers/regulator/stw481x-vmmc.c | 8 include/linux/mfd/stw481x.h | 4 2 files changed, 4

Re: RAID1 might_sleep() warning on 3.19-rc7

2015-02-12 Thread NeilBrown
On Tue, 10 Feb 2015 10:29:36 +0100 Peter Zijlstra wrote: > On Tue, Feb 10, 2015 at 01:50:17PM +1100, NeilBrown wrote: > > On Mon, 9 Feb 2015 10:10:00 +0100 Peter Zijlstra > > wrote: > > > > However, when io_schedule() explicitly calls blk_flush_plug(), then > > > > @from_schedule=false variant

Re: [PATCH v3 2/2] remoteproc: add support to handle internal memories

2015-02-12 Thread Ohad Ben-Cohen
On Thu, Feb 12, 2015 at 10:54 PM, Suman Anna wrote: > My original motivation was that it would only need to be added on > firmwares requiring support for loading into internal memories, > otherwise, these are something left to be managed by the software > running on the remote processor

[PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format

2015-02-12 Thread Liu Ying
Signed-off-by: Liu Ying --- v9->v9.5: * Add kernel-doc for the new helper function to address Daniel Vetter's comment. v8->v9: * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository. v7->v8: * None. v6->v7: * None. v5->v6: * Address the over 80 characters in one

Re: [PATCH RESEND] ARM: DMA: Fix kzalloc flags in __iommu_alloc_buffer()

2015-02-12 Thread Alexandre Courbot
On 02/13/2015 12:32 PM, Will Deacon wrote: On Wed, Feb 11, 2015 at 09:01:41AM +, Alexandre Courbot wrote: There doesn't seem to be any valid reason to allocate the pages array with the same flags as the buffer itself. Doing so can eventually lead to the following safeguard in mm/slab.c to

Re: [PATCH 1/3] hwmon: (applesmc) Allow format checking

2015-02-12 Thread Guenter Roeck
On 02/12/2015 06:15 AM, Rasmus Villemoes wrote: Currently gcc and other tools can't check the format strings. It's easy to fix by letting fan_speed_fmt simply hold what is different between the strings (and renaming it appropriately). While at it, we can also eliminate some wasted space and an

Re: [PATCH 3/3] hwmon: (ibmpex) Allow format string checking

2015-02-12 Thread Guenter Roeck
On 02/12/2015 06:15 AM, Rasmus Villemoes wrote: The only difference between the three power_sensor_name_templates is whether there is a suffix of "", "_lowest" or "_highest". We might as well pull those into an array and use a literal format string, allowing gcc to do type checking of the

Re: [PATCH 2/3] hwmon: (coretemp) Allow format checking

2015-02-12 Thread Guenter Roeck
On 02/12/2015 06:15 AM, Rasmus Villemoes wrote: By extracting the only part that differs we can allow static checking of the format string, and possibly save a little .rodata. Signed-off-by: Rasmus Villemoes Applied to -next after fixing multi-line alignment. Thanks, Guenter -- To

Re: [GIT PULL] x86/apic updates for v3.20

2015-02-12 Thread Jiang Liu
On 2015/2/13 10:50, Linus Torvalds wrote: > On Thu, Feb 12, 2015 at 6:08 PM, Linus Torvalds > wrote: >> >> Jiang, Joerg - that commit seems to cause a lockup at suspend time for >> me. Now, I haven't verified by reverting it from top-of-git yet, but >> the bisection seemed to be pretty stable.

RE: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode

2015-02-12 Thread Hiroshi Shimamoto
> > > -Original Message- > > > From: Hiroshi Shimamoto [mailto:h-shimam...@ct.jp.nec.com] > > > Sent: Monday, February 09, 2015 6:29 PM > > > To: Kirsher, Jeffrey T > > > Cc: Alexander Duyck; Skidmore, Donald C; Bjørn Mork; e1000- > > > de...@lists.sourceforge.net; net...@vger.kernel.org;

Re: [PATCH v3 2/2] sched/rt: Add check_preempt_equal_prio() logic in pick_next_task_rt()

2015-02-12 Thread Steven Rostedt
On Fri, 13 Feb 2015 11:55:11 +0800 Xunlei Pang wrote: > > RT1 just got pushed behind RT3 and it is now not the next one to run. > > RT2 will get this rq, RT3 will be pushed off, but say there's no more > > rq's available to run RT1. > > > > You just broke FIFO. > > Yes, I've also thought of

Re: [PATCH RFC v9 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format

2015-02-12 Thread Liu Ying
On Thu, Feb 12, 2015 at 10:26:42AM +0100, Daniel Vetter wrote: > On Thu, Feb 12, 2015 at 02:01:32PM +0800, Liu Ying wrote: > > Signed-off-by: Liu Ying > > --- > > v8->v9: > > * Rebase onto the imx-drm/next branch of Philipp Zabel's open git > > repository. > > > > v7->v8: > > * None. > > > >

[PATCH] fix platform_no_drv_owner.cocci warnings

2015-02-12 Thread kbuild test robot
drivers/clk/qcom/clk-rpm.c:262:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Fengguang Wu --- clk-rpm.c |1 - 1 file changed, 1

Re: [PATCH] usb: dwc3: dwc3-omap: Fix disable IRQ

2015-02-12 Thread George Cherian
On 02/12/2015 11:52 PM, Felipe Balbi wrote: On Thu, Feb 12, 2015 at 11:13:16AM +0530, George Cherian wrote: >In the wrapper the IRQ disable should be done by writing 1's to the >IRQ*_CLR register. Existing code is broken because it instead writes >zeros to IRQ*_SET register. > >Fix this by

[PATCH v2] usb: dwc3: dwc3-omap: Fix disable IRQ

2015-02-12 Thread George Cherian
In the wrapper the IRQ disable should be done by writing 1's to the IRQ*_CLR register. Existing code is broken because it instead writes zeros to IRQ*_SET register. Fix this by adding functions dwc3_omap_write_irqmisc_clr() and dwc3_omap_write_irq0_clr() which do the right thing. Fixes:

Re: [PATCH v3 2/2] sched/rt: Add check_preempt_equal_prio() logic in pick_next_task_rt()

2015-02-12 Thread Xunlei Pang
Hi Steve, On 13 February 2015 at 11:55, Xunlei Pang wrote: > Hi steve, > > On 13 February 2015 at 08:04, Steven Rostedt wrote: >> On Sun, 8 Feb 2015 23:51:26 +0800 >> Xunlei Pang wrote: >> >>> check_preempt_curr() doesn't call sched_class::check_preempt_curr >>> when the class of current is a

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-12 Thread Stephen Boyd
On 02/12/15 20:28, Ivan T. Ivanov wrote: > On Thu, 2015-02-12 at 20:07 -0800, Stephen Boyd wrote: >> On 01/29/15 04:48, Ivan T. Ivanov wrote: >>> Otherwise it looks good. Driver is loaded and device is detected >>> properly (i have added readings for type and subtype registers). >>> Do you know

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-12 Thread Ivan T. Ivanov
On Thu, 2015-02-12 at 20:07 -0800, Stephen Boyd wrote: > On 01/29/15 04:48, Ivan T. Ivanov wrote: > > Otherwise it looks good. Driver is loaded and device is detected > > properly (i have added readings for type and subtype registers). > > Do you know where I can measure result from changing

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-12 Thread Stephen Boyd
On 01/23/15 16:54, Bjorn Andersson wrote: > + > +static int pm8941_wled_set(struct led_classdev *cdev, > +enum led_brightness value) > +{ > + struct pm8941_wled *wled; > + u8 ctrl = 0; > + u16 val; > + int rc; > + int i; > + > + wled =

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-12 Thread Stephen Boyd
On 01/29/15 04:48, Ivan T. Ivanov wrote: > > Otherwise it looks good. Driver is loaded and device is detected > properly (i have added readings for type and subtype registers). > Do you know where I can measure result from changing brightness > sysfs entry. I am using 8074 dragonboard? Does the

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-12 Thread Stephen Boyd
On 01/23/15 16:54, Bjorn Andersson wrote: > + > +static int pm8941_wled_configure(struct pm8941_wled *wled, struct device > *dev) > +{ > + struct pm8941_wled_config *cfg = >cfg; > + u32 val; > + int rc; > + int i; > + > + const struct { > + const char *name; > +

[PATCH 3/3] cpuset: Fix cpuset sched_relax_domain_level

2015-02-12 Thread Zefan Li
From: Jason Low The cpuset.sched_relax_domain_level can control how far we do immediate load balancing on a system. However, it was found on recent kernels that echo'ing a value into cpuset.sched_relax_domain_level did not reduce any immediate load balancing. The reason this occurred was

Re: [PATCH v3 2/2] sched/rt: Add check_preempt_equal_prio() logic in pick_next_task_rt()

2015-02-12 Thread Xunlei Pang
Hi steve, On 13 February 2015 at 08:04, Steven Rostedt wrote: > On Sun, 8 Feb 2015 23:51:26 +0800 > Xunlei Pang wrote: > >> check_preempt_curr() doesn't call sched_class::check_preempt_curr >> when the class of current is a higher level. > > The above sentence does not make sense. > >> So if

Re: [PATCH v4 0/5] sched_clock: Optimize and avoid deadlock during read from NMI

2015-02-12 Thread Stephen Boyd
On 02/08/15 04:02, Daniel Thompson wrote: > This patchset optimizes the generic sched_clock implementation by > removing branches and significantly reducing the data cache profile. It > also makes it safe to call sched_clock() from NMI (or FIQ on ARM). > > The data cache profile of sched_clock()

Re: [PATCH v2] clockevents: Introduce mode specific callbacks

2015-02-12 Thread Preeti U Murthy
On 02/13/2015 06:24 AM, Viresh Kumar wrote: > It is not possible for the clockevents core to know which modes (other than > those with a corresponding feature flag) are supported by a particular > implementation. And drivers are expected to handle transition to all modes > elegantly, as

Re: [PATCH v3 1/2] sched/rt: Check to push the task when changing its affinity

2015-02-12 Thread Xunlei Pang
On 13 February 2015 at 07:31, Steven Rostedt wrote: > On Sun, 8 Feb 2015 23:51:25 +0800 > Xunlei Pang wrote: > > >> + if (new_weight > 1 && >> + rt_task(rq->curr) && >> + !test_tsk_need_resched(rq->curr)) { >> + /* >> + * We own p->pi_lock and

Re: [PATCH RESEND] ARM: DMA: Fix kzalloc flags in __iommu_alloc_buffer()

2015-02-12 Thread Will Deacon
On Wed, Feb 11, 2015 at 09:01:41AM +, Alexandre Courbot wrote: > There doesn't seem to be any valid reason to allocate the pages array > with the same flags as the buffer itself. Doing so can eventually lead > to the following safeguard in mm/slab.c to be hit: > > BUG_ON(flags &

Re: [PATCH 1/3] cpuset: initialize effective masks when clone_children is enabled

2015-02-12 Thread Zefan Li
From: Jason Low The cpuset.sched_relax_domain_level can control how far we do immediate load balancing on a system. However, it was found on recent kernels that echo'ing a value into cpuset.sched_relax_domain_level did not reduce any immediate load balancing. The reason this occurred was

[PATCH 2/3] cpuset: fix a warning when clearing configured masks in old hierarchy

2015-02-12 Thread Zefan Li
When we clear cpuset.cpus, cpuset.effective_cpus won't be cleared: # mount -t cgroup -o cpuset xxx /mnt # mkdir /mnt/tmp # echo 0 > /mnt/tmp/cpuset.cpus # echo > /mnt/tmp/cpuset.cpus # cat cpuset.cpus # cat cpuset.effective_cpus 0-15 And a kernel warning in update_cpumasks_hier()

[PATCH 1/3] cpuset: initialize effective masks when clone_children is enabled

2015-02-12 Thread Zefan Li
If clone_children is enabled, effective masks won't be initialized due to the bug: # mount -t cgroup -o cpuset xxx /mnt # echo 1 > cgroup.clone_children # mkdir /mnt/tmp # cat /mnt/tmp/ # cat cpuset.effective_cpus # cat cpuset.cpus 0-15 And then this cpuset won't constrain the

[ANNOUNCE] Linux Security Summit 2015, Seattle WA, USA, August 20-21

2015-02-12 Thread James Morris
This is to announce the date & location of the 2015 Linux Security Summit. LSS 2015 will be co-located with LinuxCon North America, in Seattle WA, USA, on 20 and 21 August. As with previous events, LSS 2015 will be open to all registered LinuxCon attendees. Please see the event web site for

Re: [PATCH 1/4] mm: cma: add currently allocated CMA buffers list to debugfs

2015-02-12 Thread Joonsoo Kim
On Fri, Feb 13, 2015 at 01:15:41AM +0300, Stefan Strogin wrote: > static int cma_debugfs_get(void *data, u64 *val) > { > unsigned long *p = data; > @@ -125,6 +221,52 @@ static int cma_alloc_write(void *data, u64 val) > > DEFINE_SIMPLE_ATTRIBUTE(cma_alloc_fops, NULL, cma_alloc_write,

Re: [PATCH 1/2] x86: entry_64.S: always allocate complete "struct pt_regs"

2015-02-12 Thread Travis
I'll read this later and get back to you. On Feb 12, 2015 7:54 PM, Denys Vlasenko wrote: > > On Thu, Feb 12, 2015 at 11:29 PM, Andy Lutomirski > wrote: > >> Thanks! > >> The renaming of macros caught the bug at compile time, as intended. > >> > >> I'll send an updated patch set v3 in a

Re: [PATCH RFC v9 01/20] clk: divider: Correct parent clk round rate if no bestdiv is normally found

2015-02-12 Thread Travis
Travis liked your message with Boxer for Android. On Feb 12, 2015 8:58 PM, Liu Ying wrote: > > On Thu, Feb 12, 2015 at 10:06:27PM +0800, Liu Ying wrote: > > On Thu, Feb 12, 2015 at 02:41:31PM +0100, Sascha Hauer wrote: > > > On Thu, Feb 12, 2015 at 12:56:46PM +, Russell King - ARM Linux

Re: [PATCH 2/4] mm: cma: add functions to get region pages counters

2015-02-12 Thread Joonsoo Kim
On Fri, Feb 13, 2015 at 01:15:42AM +0300, Stefan Strogin wrote: > From: Dmitry Safonov > > Here are two functions that provide interface to compute/get used size > and size of biggest free chunk in cma region. > Add that information to debugfs. > > Signed-off-by: Dmitry Safonov >

Re: [PATCH 3/6] timekeeping: Make it safe to use the fast timekeeper while suspended

2015-02-12 Thread Travis
Sounds good to me! On Feb 12, 2015 8:03 PM, "Rafael J. Wysocki" wrote: > > On Friday, February 13, 2015 08:53:38 AM John Stultz wrote: > > On Wed, Feb 11, 2015 at 12:03 PM, Rafael J. Wysocki > > wrote: > > > From: Rafael J. Wysocki > > > > > > Theoretically, ktime_get_mono_fast_ns() may

Re: [PATCH 1/4] mm: cma: add currently allocated CMA buffers list to debugfs

2015-02-12 Thread Joonsoo Kim
On Fri, Feb 13, 2015 at 01:15:41AM +0300, Stefan Strogin wrote: > /sys/kernel/debug/cma/cma-/buffers contains a list of currently allocated > CMA buffers for CMA region N when CONFIG_CMA_DEBUGFS is enabled. > > Format is: > > - ( kB), allocated by () > > > Signed-off-by: Stefan Strogin >

Re: [PATCH 07/11] ARM: prima2: do not select SMP_ON_UP

2015-02-12 Thread Barry Song
2015-02-13 3:42 GMT+08:00 Arnd Bergmann : > The new Atlas7 platform implicitly selects 'CONFIG_SMP_ON_UP', > which leads to problems if we enable building the platform without > MMU, as that combination is not allowed and causes a link error: > > arch/arm/kernel/built-in.o: In function `c_show': >

Re: [PATCH v2] clockevents: Introduce mode specific callbacks

2015-02-12 Thread Viresh Kumar
On 13 February 2015 at 10:11, Rafael J. Wysocki wrote: > On Friday, February 13, 2015 08:54:56 AM Viresh Kumar wrote: >> It is not possible for the clockevents core to know which modes (other than >> those with a corresponding feature flag) are supported by a particular >> implementation. And

Re: [PATCH 0/4] mm: cma: add some debug information for CMA

2015-02-12 Thread Joonsoo Kim
On Fri, Feb 13, 2015 at 01:15:40AM +0300, Stefan Strogin wrote: > Hi all. > > Sorry for the long delay. Here is the second attempt to add some facility > for debugging CMA (the first one was "mm: cma: add /proc/cmainfo" [1]). > > This patch set is based on v3.19 and Sasha Levin's patch set >

Re: Possible Bug in gnet_start_copy_compat for the file,gen_stats.c

2015-02-12 Thread Cong Wang
On Thu, Feb 12, 2015 at 6:33 PM, nick wrote: > Greets to Everyone, > I am wondering after running sparse on the latest mainline tree why we are > not unlocking the spinlock_bh,lock when calling the function, > gnet_stats_start_copy_compat at the end of this function's body. Unless > someone

Re: [PATCH RFC v5 net-next 4/6] virtio-net: add basic interrupt coalescing support

2015-02-12 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Tue, Feb 10, 2015 at 12:02:37PM +1030, Rusty Russell wrote: >> Jason Wang writes: >> > This patch enables the interrupt coalescing setting through ethtool. >> >> The problem is that there's nothing network specific about interrupt >> coalescing. I can see

Re: [PATCH v2] usb: dwc2: Register interrupt handler only once gadget is correctly initialized

2015-02-12 Thread John Youn
On 2/12/2015 4:42 AM, Romain Perier wrote: > ping > > 2015-02-06 17:50 GMT+01:00 Romain Perier : >> Don't register interrupt handler before usb gadget is correctly initialized. >> For some embedded platforms which don't have a usb-phy, it crashes the driver >> because an interrupt is emitted with

Re: [PATCH RFC v9 01/20] clk: divider: Correct parent clk round rate if no bestdiv is normally found

2015-02-12 Thread Liu Ying
On Thu, Feb 12, 2015 at 10:06:27PM +0800, Liu Ying wrote: > On Thu, Feb 12, 2015 at 02:41:31PM +0100, Sascha Hauer wrote: > > On Thu, Feb 12, 2015 at 12:56:46PM +, Russell King - ARM Linux wrote: > > > On Thu, Feb 12, 2015 at 01:24:05PM +0100, Sascha Hauer wrote: > > > > On Thu, Feb 12, 2015

Re: [GIT PULL] x86/apic updates for v3.20

2015-02-12 Thread Linus Torvalds
On Thu, Feb 12, 2015 at 6:08 PM, Linus Torvalds wrote: > > Jiang, Joerg - that commit seems to cause a lockup at suspend time for > me. Now, I haven't verified by reverting it from top-of-git yet, but > the bisection seemed to be pretty stable. I'll try the revert next (it > doesn't revert

Re: [PATCH v5 2/3] mm: cma: allocation trigger

2015-02-12 Thread Joonsoo Kim
On Thu, Feb 12, 2015 at 05:26:47PM -0500, Sasha Levin wrote: > Provides a userspace interface to trigger a CMA allocation. > > Usage: > > echo [pages] > alloc > > This would provide testing/fuzzing access to the CMA allocation paths. > > Signed-off-by: Sasha Levin > --- > mm/cma.c

Re: [PATCH v5 3/3] mm: cma: release trigger

2015-02-12 Thread Joonsoo Kim
On Thu, Feb 12, 2015 at 05:26:48PM -0500, Sasha Levin wrote: > Provides a userspace interface to trigger a CMA release. > > Usage: > > echo [pages] > free > > This would provide testing/fuzzing access to the CMA release paths. > > Signed-off-by: Sasha Levin Acked-by: Joonsoo Kim -- To

  1   2   3   4   5   6   7   8   9   10   >