Re: [PATCH] ext4 crypto: remove unneeded assignation

2015-07-08 Thread Joe Perches
On Wed, 2015-07-08 at 21:51 +0200, Laurent Navet wrote: > Return value of ext4_derive_key_aes() is stored but never used before > being overwritten. > Also fix coverity CID 1309760. > > Signed-off-by: Laurent Navet > --- > fs/ext4/crypto_key.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] mac80211: Use kstrdup to simplify code

2015-07-08 Thread Emmanuel Grumbach
The subject is wrong. You are not patch mac80211, but bcrmsmac. On Wed, Jul 8, 2015 at 10:32 PM, Christophe JAILLET wrote: > Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve > readability. > > Signed-off-by: Christophe JAILLET > --- > drivers/net/wireless/brcm80211/brcmsmac

Re: [PATCH v3] ipc: Modify message queue accounting to not take kernel data structures into account

2015-07-08 Thread Michael Kerrisk (man-pages)
On 8 July 2015 at 21:17, Doug Ledford wrote: > On 07/07/2015 09:01 AM, Michael Kerrisk (man-pages) wrote: >> Hi David, >> >> On 7 July 2015 at 07:16, Davidlohr Bueso wrote: >>> On Mon, 2015-07-06 at 17:49 +0200, Marcus Gelderie wrote: A while back, the message queue implementation in the ker

Re: [PATCH 4.1 11/56] mvneta: add forgotten initialization of autonegotiation bits

2015-07-08 Thread Arnaud Ebalard
Hi, Stas Sergeev writes: >>> Another problem was reported: >>> https://lkml.org/lkml/2015/7/8/865 >>> >>> So, while the above patch is correct and fixes what >>> it should, the original patch has more problems to deal >>> with. Maybe for stable it would be better to just revert >>> the whole thi

Re: [PATCH v11 28/39] perf tools: Make perf depend on libbpf

2015-07-08 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 08, 2015 at 01:14:17PM +, Wang Nan escreveu: > By adding libbpf into perf's Makefile, this patch enables perf to build > libbpf during building if libelf is found and neither NO_LIBELF nor > NO_LIBBPF is set. The newly introduced code is similar to libapi and > libtraceevent buildin

[PATCH 2/2] net: pktgen: kill the "Wait for kthread_stop" code in pktgen_thread_worker()

2015-07-08 Thread Oleg Nesterov
pktgen_thread_worker() doesn't need to wait for kthread_stop(), it can simply exit. Just pktgen_create_thread() and pg_net_exit() should do get_task_struct()/put_task_struct(). kthread_stop(dead_thread) is fine. Signed-off-by: Oleg Nesterov --- net/core/pktgen.c | 11 ++- 1 files chang

[PATCH 1/2] net: pktgen: fix race between pktgen_thread_worker() and kthread_stop()

2015-07-08 Thread Oleg Nesterov
pktgen_thread_worker() is obviously racy, kthread_stop() can come between the kthread_should_stop() check and set_current_state(). Signed-off-by: Oleg Nesterov Reported-by: Jan Stancek Reported-by: Marcelo Leitner --- net/core/pktgen.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions

[PATCH] ext4 crypto: remove unneeded assignation

2015-07-08 Thread Laurent Navet
Return value of ext4_derive_key_aes() is stored but never used before being overwritten. Also fix coverity CID 1309760. Signed-off-by: Laurent Navet --- fs/ext4/crypto_key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/crypto_key.c b/fs/ext4/crypto_key.c index 442d

[PATCH 0/2] net: pktgen: fix race between pktgen_thread_worker() and kthread_stop()

2015-07-08 Thread Oleg Nesterov
Hello, I am not familiar with this code and I have no idea how to test these changes, so 2/2 comes as a separate change. 1/2 looks like the obvious bugfix, and probably candidate for -stable. Oleg. net/core/pktgen.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) -- To unsub

[PATCH] checkpatch: Fix perl 5.22 brace deprecation warnings

2015-07-08 Thread Stefan Tatschner
This patch fixes four "Unescaped left brace in regex is deprecated" (perl 5.22) warnings by escaping left braces properly. Signed-off-by: Stefan Tatschner --- scripts/checkpatch.pl | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpa

Re: [PATCH v7 0/3] Add arm pl353 smc nand driver for xilinx zynq soc

2015-07-08 Thread Josh Cartwright
On Mon, Jun 08, 2015 at 11:38:35PM +0530, Punnaiah Choudary Kalluri wrote: > The following patches add arm pl353 static memory controller driver for > xilinx zynq soc. The arm pl353 smc supports two interfaces i.e nand and > nor/sram memory interfaces. The current implementation supports only a > s

Re: [REPOST PATCH 3/3] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled

2015-07-08 Thread Julius Werner
> But I don't see how you will make it work when the root hub itself is > not enabled for wakeup and a non-hub device plugged into one of the > root hub's ports is enabled. > > It seems like you would need a usb_hcd_wakeup_not_needed(hcd, port) > subroutine. We'd just put that in the Tegra platfor

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Brian Gerst
On Wed, Jul 8, 2015 at 3:14 PM, Andy Lutomirski wrote: > On Wed, Jul 8, 2015 at 12:05 PM, Brian Gerst wrote: >> On Wed, Jul 8, 2015 at 1:30 PM, Andy Lutomirski wrote: >>> On Wed, Jul 8, 2015 at 9:59 AM, Linus Torvalds >>> wrote: On Tue, Jul 7, 2015 at 7:33 PM, Arjan van de Ven wrote

[PATCH] mac80211: Use kstrdup to simplify code

2015-07-08 Thread Christophe JAILLET
Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve readability. Signed-off-by: Christophe JAILLET --- drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmsmac/mac80211_i

[PATCH] ALSA: hda: Delete an unnecessary check before the function call "kobject_put"

2015-07-08 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 8 Jul 2015 21:26:02 +0200 The kobject_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/

[RFC/PATCH 0/7] x86_32: Migrate to new entry/exit paths

2015-07-08 Thread Andy Lutomirski
This is a review version of the 32-bit asm-to-C migration. I think it works, but it's not yet well enough tested. I'm a lot more familiar with the 64-bit asm than the 32-bit asm. Al is cc'd, because some of this partially reverts some of his old changes. The vm86 stuff especially needs much mor

[RFC/PATCH 2/7] x86/entry/32: Fix an incorrect comment for work_notifysig_v86

2015-07-08 Thread Andy Lutomirski
This code path is for returns to user mode only. Signed-off-by: Andy Lutomirski --- arch/x86/entry/entry_32.S | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index 90f9e7f6c15e..a36d5df6a749 100644 --- a/arch/x86/entry/e

[RFC/PATCH 7/7] x86/entry: Remove do_notify_resume, syscall_trace_leave, and their TIF masks

2015-07-08 Thread Andy Lutomirski
They are no longer used. Good riddance! Deleting the TIF_ macros is really nice. It was never clear why there were so many variants. Signed-off-by: Andy Lutomirski --- arch/x86/entry/common.c| 57 -- arch/x86/include/asm/ptrace.h | 1 - ar

Re: [PATCH 28/37] usb: gadget: pxa27x_udc: add ep capabilities support

2015-07-08 Thread Robert Jarzmik
Robert Baldyga writes: > Convert endpoint configuration to new capabilities model. The commit message is very short to judge the patch's correctness. I'll side up with Felipe's opinion. If it's fine by him, so it is by me. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsu

[RFC/PATCH 1/7] x86/entry/32: Remove 32-bit syscall audit optimizations

2015-07-08 Thread Andy Lutomirski
The asm audit optimizations are ugly and obfuscate the code too much. Remove them. This will regress performance if syscall auditing is enabled on 32-bit kernels and sysenter is in use. If this becomes a problem, interested parties are encouraged to implement the equivalent of the 64-bit opportu

Re: [RFC/PATCH 3/7] [TEMPORARY] x86/entry/32: Sanity check for work_notifysig

2015-07-08 Thread Andy Lutomirski
[cc: Al -- saying I'm cc-ing you in the patch 0 description doesn't make it so.] On Wed, Jul 8, 2015 at 12:24 PM, Andy Lutomirski wrote: > 44fbbb3dc687c added an unnecessary check. Add a temporary assertion > to confirm that it's unnecessary. > > Signed-off-by: Andy Lutomirski > --- > arch/x86

Re: [RFC/PATCH 4/7] x86/entry/32: Finish removing bogus kernel-mode check

2015-07-08 Thread Andy Lutomirski
[cc: Al -- saying I'm cc-ing you in the patch 0 description doesn't make it so.] On Wed, Jul 8, 2015 at 12:24 PM, Andy Lutomirski wrote: > Signed-off-by: Andy Lutomirski > --- > arch/x86/entry/entry_32.S | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/arch/x86/entry/entry_32.S b/

[RFC/PATCH 6/7] x86/entry/32: Use prepare_exit_to_usermode and syscall_return_slowpath

2015-07-08 Thread Andy Lutomirski
This removes the hybrid asm-and-C implementation of exit work. Signed-off-by: Andy Lutomirski --- arch/x86/entry/entry_32.S | 62 +-- 1 file changed, 11 insertions(+), 51 deletions(-) diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S

[RFC/PATCH 4/7] x86/entry/32: Finish removing bogus kernel-mode check

2015-07-08 Thread Andy Lutomirski
Signed-off-by: Andy Lutomirski --- arch/x86/entry/entry_32.S | 7 --- 1 file changed, 7 deletions(-) diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index d36afad80ad1..66ff9c4055d7 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -491,13 +491,6 @@

[RFC/PATCH 3/7] [TEMPORARY] x86/entry/32: Sanity check for work_notifysig

2015-07-08 Thread Andy Lutomirski
44fbbb3dc687c added an unnecessary check. Add a temporary assertion to confirm that it's unnecessary. Signed-off-by: Andy Lutomirski --- arch/x86/entry/entry_32.S | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index

[BUG] Kernel splat when taking CPUs offline

2015-07-08 Thread Steven Rostedt
My tests for ftrace includes testing the mmiotracer, which to run requires taking all CPUs offline but one of them. This test crashed every so often, and I was able to bisect down to this commit: commit 87549141d516 ("cpufreq: Stop migrating sysfs files on hotplug") Just to make sure this wasn'

[RFC/PATCH 5/7] x86/vm86: Teach handle_vm86_trap to return to 32bit mode directly

2015-07-08 Thread Andy Lutomirski
The TIF_NOTIFY_RESUME hack it was using was buggy and unsupportable. vm86 mode was completely broken under ptrace, for example, because we'd never make it to v8086 mode. This code is still a huge, scary mess, but at least it's no longer tangled with the exit-to-userspace loop. Signed-off-by: Andy

Re: [PATCH V3 3/5] mm: mlock: Introduce VM_LOCKONFAULT and add mlock flags to enable it

2015-07-08 Thread Jonathan Corbet
On Tue, 7 Jul 2015 13:03:41 -0400 Eric B Munson wrote: > This patch introduces the ability to request that pages are not > pre-faulted, but are placed on the unevictable LRU when they are finally > faulted in. This can be done area at a time via the > mlock2(MLOCK_ONFAULT) or the mlockall(MCL_O

Re: [PATCH] um: umid: Use strdup to simplify code

2015-07-08 Thread Richard Weinberger
Am 08.07.2015 um 21:15 schrieb Christophe JAILLET: > Replace a malloc+strcpy by an equivalent strdup in order to improve > readability. Makes sense! > Turn a some spaces into a tab to be consistent with the rest of the code. Do this in an extra patch. One logical change per patch please. Thanks

Re: [PATCH v3] ipc: Modify message queue accounting to not take kernel data structures into account

2015-07-08 Thread Doug Ledford
On 07/07/2015 09:01 AM, Michael Kerrisk (man-pages) wrote: > Hi David, > > On 7 July 2015 at 07:16, Davidlohr Bueso wrote: >> On Mon, 2015-07-06 at 17:49 +0200, Marcus Gelderie wrote: >>> A while back, the message queue implementation in the kernel was >>> improved to use btrees to speed up retri

[PATCH] um: umid: Use strdup to simplify code

2015-07-08 Thread Christophe JAILLET
Replace a malloc+strcpy by an equivalent strdup in order to improve readability. Turn a some spaces into a tab to be consistent with the rest of the code. Signed-off-by: Christophe JAILLET --- arch/um/os-Linux/umid.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Andy Lutomirski
On Wed, Jul 8, 2015 at 12:05 PM, Brian Gerst wrote: > On Wed, Jul 8, 2015 at 1:30 PM, Andy Lutomirski wrote: >> On Wed, Jul 8, 2015 at 9:59 AM, Linus Torvalds >> wrote: >>> On Tue, Jul 7, 2015 at 7:33 PM, Arjan van de Ven >>> wrote: if this patch would not be acceptable, at minimum w

[tip:x86/asm] x86/entry/64: Fix IRQ state confusion and related warning on compat syscalls with CONFIG_AUDITSYSCALL =n

2015-07-08 Thread tip-bot for Andy Lutomirski
Commit-ID: 8f7f06b87acd2e017d6c536f59e10045dd8d0578 Gitweb: http://git.kernel.org/tip/8f7f06b87acd2e017d6c536f59e10045dd8d0578 Author: Andy Lutomirski AuthorDate: Tue, 7 Jul 2015 10:55:28 -0700 Committer: Ingo Molnar CommitDate: Wed, 8 Jul 2015 21:10:25 +0200 x86/entry/64: Fix IRQ stat

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Ingo Molnar
* Linus Torvalds wrote: > On Tue, Jul 7, 2015 at 7:33 PM, Arjan van de Ven > wrote: > > > > if this patch would not be acceptable, at minimum we need some sort of "off > > by > > default unless the sysadmin flips a sysfs thing", which is really just a > > huge > > hack. > > The only thing

Re: [PATCH v11 00/39] perf tools: filtering events using eBPF programs - part1

2015-07-08 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 08, 2015 at 11:57:13PM +0800, pi3orama escreveu: > 发自我的 iPhone > > 在 2015年7月8日,下午10:03,Arnaldo Carvalho de Melo 写道: > > And those wrappers struck me as exaggerated, see one of them: > > int bpf_program__get_fd(struct bpf_program *prog, int *pfd) > > { > >if (!pfd) > >

[PATCH] [media] dvb-core: remove ktime_add_us() call

2015-07-08 Thread Laurent Navet
Calling ktime_add_us() seems useless as is only useful for it's return value which is ignored. Also fix coverity CID 1309761. Signed-off-by: Laurent Navet --- drivers/media/dvb-core/dvb_frontend.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/driver

Re: [PATCH] Revert: audit: Fix check of return value of strnlen_user()

2015-07-08 Thread Paul Moore
On Wednesday, July 08, 2015 12:29:43 PM Steven Rostedt wrote: > On Wed, 8 Jul 2015 12:02:49 -0400 > > Steven Rostedt wrote: > > Well, any testing will have to wait. The reason I found this is because > > it caused my own tests to fail for a bug fix I'm testing (unrelated to > > this) that I'm get

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Brian Gerst
On Wed, Jul 8, 2015 at 1:30 PM, Andy Lutomirski wrote: > On Wed, Jul 8, 2015 at 9:59 AM, Linus Torvalds > wrote: >> On Tue, Jul 7, 2015 at 7:33 PM, Arjan van de Ven >> wrote: >>> >>> if this patch would not be acceptable, at minimum we need some sort of "off >>> by default >>> unless the sysadm

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Andy Lutomirski
On Wed, Jul 8, 2015 at 11:48 AM, Kees Cook wrote: > On Wed, Jul 8, 2015 at 10:55 AM, Linus Torvalds > wrote: >> On Wed, Jul 8, 2015 at 10:49 AM, Andy Lutomirski wrote: >>> >>> I don't know how to tell whether something is trying to use real mode, >>> but I can play this just fine in DOSEMU on my

Re: Linux 4.2-rc1

2015-07-08 Thread Ingo Molnar
* Linus Torvalds wrote: > On Wed, Jul 8, 2015 at 9:32 AM, Shuah Khan wrote: > > > > I am seeing the following NULL pointer dereference on my test system: > > > > [3.640599] BUG: unable to handle kernel NULL pointer dereference at > > 0080 > > [3.640609] IP: [] firmware_ueve

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Austin S Hemmelgarn
On 2015-07-08 13:55, Linus Torvalds wrote: On Wed, Jul 8, 2015 at 10:49 AM, Andy Lutomirski wrote: I don't know how to tell whether something is trying to use real mode, but I can play this just fine in DOSEMU on my 64-bit laptop: So a 64-bit distro obviously will never have used vm86 mode -

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Kees Cook
On Wed, Jul 8, 2015 at 11:47 AM, Andy Lutomirski wrote: > Fedora doesn't package dosemu at all, and Ubuntu turns off CONFIG_VM86 > AFAIK. RPMFusion does package dosemu. Just for reference, here's the config on latest Ubuntu: http://kernel.ubuntu.com/git/ubuntu/ubuntu-vivid.git/tree/debian.master

Re: [PATCH, resend] build: fix broken kernel RPM source symlink

2015-07-08 Thread Paul Bolle
On wo, 2015-07-08 at 20:47 +0200, Espen Carlsen wrote: > I assume your wild guess was that if I had /lib/modules/4.1.0/build & > source as that was the kernel I was building? Yes. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to ma

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Kees Cook
On Wed, Jul 8, 2015 at 10:55 AM, Linus Torvalds wrote: > On Wed, Jul 8, 2015 at 10:49 AM, Andy Lutomirski wrote: >> >> I don't know how to tell whether something is trying to use real mode, >> but I can play this just fine in DOSEMU on my 64-bit laptop: > > So a 64-bit distro obviously will never

RE: [PATCH, resend] build: fix broken kernel RPM source symlink

2015-07-08 Thread Espen Carlsen
> From: Paul Bolle [mailto:pebo...@tiscali.nl] > On wo, 2015-07-08 at 17:42 +0200, Espen Carlsen wrote: > Wild guess: do the Ubuntu systems already have > /lib/modules/4.1.0/build > /lib/modules/4.1.0/source > as symlinks to /usr/src/kernels/4.1.0 when you're building the rpms? > (That is,

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Andy Lutomirski
On Wed, Jul 8, 2015 at 10:55 AM, Linus Torvalds wrote: > On Wed, Jul 8, 2015 at 10:49 AM, Andy Lutomirski wrote: >> >> I don't know how to tell whether something is trying to use real mode, >> but I can play this just fine in DOSEMU on my 64-bit laptop: > > So a 64-bit distro obviously will never

Re: [PATCH] GPU-DRM-Tegra: Delete an unnecessary check before the function call "vunmap"

2015-07-08 Thread SF Markus Elfring
> From: Markus Elfring > Date: Thu, 5 Feb 2015 10:12:51 +0100 > > The vunmap() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/

Re: [PATCH 4.1 11/56] mvneta: add forgotten initialization of autonegotiation bits

2015-07-08 Thread Stas Sergeev
08.07.2015 20:36, Greg Kroah-Hartman пишет: On Wed, Jul 08, 2015 at 08:10:46PM +0300, Stas Sergeev wrote: 08.07.2015 10:35, Greg Kroah-Hartman пишет: 4.1-stable review patch. If anyone has any objections, please let me know. -- From: Stas Sergeev [ Upstream commit 538761b79

Re: [PATCH] MIPS: ath79: irq: Remove the include of drivers/irqchip/irqchip.h

2015-07-08 Thread Jonas Gorski
On Wed, Jul 8, 2015 at 8:11 PM, Alban Bedel wrote: > We shouldn't include irqchip.h from outside of the drivers/irqchip > directory. The irq driver should idealy be there, however this not > trivial at the moment. We still need to support platforms without DT > support and the interface to the DDR

Re: [PATCH] tools/lib: improve clean target

2015-07-08 Thread Riku Voipio
On 18 June 2015 at 15:52, wrote: > From: Riku Voipio > > The clean targets miss some .cmd and .d files. Is this patch slipping through cracks? > Signed-off-by: Riku Voipio > --- > tools/lib/api/Makefile| 2 +- > tools/lib/traceevent/Makefile | 2 +- > 2 files changed, 2 insertions(+)

Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

2015-07-08 Thread Felipe Balbi
Hi, On Wed, Jul 08, 2015 at 09:50:47AM +, Subbaraya Sundeep Bhatta wrote: > > > > > In any case, can you run on your setup with g_zero and > > > > > test.sh/testusb [1]/[2] just to verify that it really works for you ? > > Can you please send test.sh and testusb.c in attachment. I guess am >

[PATCH] xfs: Use consistent logging message prefixes

2015-07-08 Thread Joe Perches
The second and subsequent lines of multi-line logging messages are not prefixed with the same information as the first line. Separate messages with newlines into multiple calls to ensure consistent prefixing and allow easier grep use. Signed-off-by: Joe Perches --- fs/xfs/libxfs/xfs_dir2_node.c

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Vivien Didelot
Hi Andrew, On Jul 8, 2015, at 1:32 PM, Andrew Lunn and...@lunn.ch wrote: > Vivien Didelot wrote: >> Hi Andrew, >> >> On Jul 8, 2015, at 10:38 AM, Andrew Lunn and...@lunn.ch wrote: >> >> > On Tue, Jul 07, 2015 at 05:18:17PM -0400, Vivien Didelot wrote: >> >> Hi all, >> >> >> >> This patchset br

[PATCH] MIPS: ath79: irq: Remove the include of drivers/irqchip/irqchip.h

2015-07-08 Thread Alban Bedel
We shouldn't include irqchip.h from outside of the drivers/irqchip directory. The irq driver should idealy be there, however this not trivial at the moment. We still need to support platforms without DT support and the interface to the DDR controller still use a custom arch specific API. For now j

Re: [PATCH v5] clk: change clk_ops' ->determine_rate() prototype

2015-07-08 Thread Stephen Boyd
On 07/08/2015 02:00 AM, Boris Brezillon wrote: > Hi Stephen, > > On Tue, 7 Jul 2015 17:57:48 -0700 > Stephen Boyd wrote: > >> On 07/07, Boris Brezillon wrote: >>> >>> } else { >>> pr_err("clk: clk_composite_determine_rate function called, but >>> no mux or rate callback set!\n");

Re: Linux 4.2-rc1

2015-07-08 Thread Stephen Smalley
On 07/08/2015 01:47 PM, Casey Schaufler wrote: > On 7/8/2015 10:29 AM, Linus Torvalds wrote: >> On Wed, Jul 8, 2015 at 10:17 AM, Linus Torvalds >> wrote: >>> Decoding the "Code:" line shows that this is the "->fw_id" dereference in >>> >>> if (add_uevent_var(env, "FIRMWARE=%s", fw_priv->bu

Re: [PATCH 28/42] x86, boot: Allow 64bit EFI kernel to be loaded above 4G

2015-07-08 Thread Matt Fleming
On Tue, 07 Jul, at 04:12:26PM, Kees Cook wrote: > > @@ -301,7 +301,7 @@ _start: > > # Part 2 of the header, from the old setup.S > > > > .ascii "HdrS" # header signature > > - .word 0x020d # header version number (>= 0x0105) > > +

Re: printk: preempt_disable with long time resulting in softlockup/RCU stall issues

2015-07-08 Thread Steven Rostedt
On Wed, 08 Jul 2015 10:35:29 -0700 Joe Perches wrote: > On Wed, 2015-07-08 at 19:04 +0200, Luis R. Rodriguez wrote: > > On Wed, Jul 08, 2015 at 05:08:35PM +0800, Gavin Hu wrote: > > > Hi, > > > > > > Yes. We should disable the printk_limit feature when panic to avoid > > > missing > > > message

Re: [PATCH V3] trace/events: add chip name and hwirq to irq entry tracepoint

2015-07-08 Thread Ankit Gupta
> On Wed, 24 Jun 2015, Steven Rostedt wrote: >> > + >> > +#define show_chip_name(irq) \ >> > + (irq_get_irq_data(irq) \ >> > + ? irq_get_irq_data(irq)->chip->name\ >> > + : "NULL") >> > +

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Linus Torvalds
On Wed, Jul 8, 2015 at 10:49 AM, Andy Lutomirski wrote: > > I don't know how to tell whether something is trying to use real mode, > but I can play this just fine in DOSEMU on my 64-bit laptop: So a 64-bit distro obviously will never have used vm86 mode - it doesn't work there. Never has. There's

Re: Linux 4.2-rc1

2015-07-08 Thread Casey Schaufler
On 7/8/2015 10:33 AM, Shuah Khan wrote: > On 07/08/2015 11:05 AM, Casey Schaufler wrote: >> On 7/8/2015 9:32 AM, Shuah Khan wrote: >>> On Sun, Jul 5, 2015 at 2:22 PM, Linus Torvalds >>> wrote: It's Sunday, two weeks have passed, and the merge window is closed. I just pushed out the tag t

Re: [PATCH 07/13] arm64: KVM: VHE: Patch out use of HVC

2015-07-08 Thread Marc Zyngier
On 08/07/15 18:14, Paolo Bonzini wrote: > > > On 08/07/2015 18:19, Marc Zyngier wrote: >> +/* Hack to allow stringification of macros... */ >> +#define __S__(a,args...)__stringify(a, ##args) >> +#define _S_(a,args...) __S__(a, args) >> + >> +.macro ifnvhe nonvhe vhe >> +alter

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Andy Lutomirski
On Wed, Jul 8, 2015 at 10:30 AM, Andy Lutomirski wrote: > I'll try to confirm later this week that dosemu can really handle real > mode without sys_vm86. I don't know how to tell whether something is trying to use real mode, but I can play this just fine in DOSEMU on my 64-bit laptop: http://dos

Re: [PATCH] bcache: Deletion of an unnecessary check before the function call "kobject_put"

2015-07-08 Thread SF Markus Elfring
> From: Markus Elfring > Date: Wed, 19 Nov 2014 21:25:39 +0100 > > The kobject_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus E

Re: [PATCH -mm v6 0/6] idle memory tracking

2015-07-08 Thread Vladimir Davydov
Hi, Any comments, thoughts, proposals regarding this patch? Any chance for it to get merged? Thanks, Vladimir On Fri, Jun 12, 2015 at 12:52:20PM +0300, Vladimir Davydov wrote: > Hi, > > This patch set introduces a new user API for tracking user memory pages > that have not been used for a given

Re: Linux 4.2-rc1

2015-07-08 Thread Casey Schaufler
On 7/8/2015 10:29 AM, Linus Torvalds wrote: > On Wed, Jul 8, 2015 at 10:17 AM, Linus Torvalds > wrote: >> Decoding the "Code:" line shows that this is the "->fw_id" dereference in >> >> if (add_uevent_var(env, "FIRMWARE=%s", fw_priv->buf->fw_id)) >> return -ENOMEM; >> >> an

Re: [RFC/RFT PATCH v3 0/4] KVM: x86: full virtualization of guest MTRR

2015-07-08 Thread Joerg Roedel
On Wed, Jul 08, 2015 at 05:18:26PM +0200, Paolo Bonzini wrote: > I do not have any AMD machines that support an IOMMU, so I would like > some help testing these patches. Works here, tested on an AMD IOMMUv2 machine and could successfully download a file over the assigned NIC. Tested-by: Joerg Roe

[PATCH] Documentation: filesystems: btrfs: Fixed typos and whitespace

2015-07-08 Thread Daniel Grimshaw
I am a high school student trying to become familiar with Linux kernel development. The btrfs documentation in Documentation/filesystems had a few typos and errors in whitespace. This patch corrects both of these. This is a resend of an earlier patch with corrected patchfile. Signed-off-by: Danie

Re: [PATCH 27/42] x86: restore end_of_ram to E820_RAM

2015-07-08 Thread Matt Fleming
On Tue, 07 Jul, at 01:20:13PM, Yinghai Lu wrote: > We don't need to create mapping for E820_PRAM. > > Signed-off-by: Yinghai Lu > --- > arch/x86/kernel/e820.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c >

Re: [PATCH 8/8] memcg: get rid of mem_cgroup_from_task

2015-07-08 Thread Vladimir Davydov
On Wed, Jul 08, 2015 at 02:27:52PM +0200, Michal Hocko wrote: > From: Michal Hocko > > mem_cgroup_from_task has always been a tricky API. It was added > by 78fb74669e80 ("Memory controller: accounting setup") for > mm_struct::mem_cgroup initialization. Later on it gained new callers > mostly due

Re: [PATCH 0/24] kernel: add a netlink interface to get information about processes (v2)

2015-07-08 Thread Andy Lutomirski
On Wed, Jul 8, 2015 at 9:10 AM, Andrew Vagin wrote: > On Tue, Jul 07, 2015 at 08:56:37AM -0700, Andy Lutomirski wrote: >> On Tue, Jul 7, 2015 at 8:43 AM, Andrew Vagin wrote: >> > On Mon, Jul 06, 2015 at 10:10:32AM -0700, Andy Lutomirski wrote: >> >> On Mon, Jul 6, 2015 at 1:47 AM, Andrey Vagin w

Re: [PATCH v2 2/2] arm: kernel: implement cpuidle_ops with psci backend

2015-07-08 Thread Lorenzo Pieralisi
On Wed, Jul 08, 2015 at 01:51:08PM +0100, Jisheng Zhang wrote: > This patch implements cpuidle_ops using psci. After this patch, we can > use cpuidle-arm.c with psci backend for both arm and arm64. > > Signed-off-by: Jisheng Zhang > --- > arch/arm/kernel/Makefile | 1 + > arch/arm/kernel/

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Andrew Lunn
Vivien Didelot wrote: > Hi Andrew, > > On Jul 8, 2015, at 10:38 AM, Andrew Lunn and...@lunn.ch wrote: > > > On Tue, Jul 07, 2015 at 05:18:17PM -0400, Vivien Didelot wrote: > >> Hi all, > >> > >> This patchset brings full support for hardware VLANs in DSA, and the > >> Marvell > >> 88E6xxx compa

Re: Kernel broken on processors without performance counters

2015-07-08 Thread Andy Lutomirski
On Wed, Jul 8, 2015 at 9:07 AM, Peter Zijlstra wrote: > On Wed, Jul 08, 2015 at 11:17:38AM -0400, Mikulas Patocka wrote: >> Hi >> >> I found out that the patch a66734297f78707ce39d756b656bfae861d53f62 breaks >> the kernel on processors without performance counters, such as AMD K6-3. >> Reverting t

Re: [PATCH 4.1 11/56] mvneta: add forgotten initialization of autonegotiation bits

2015-07-08 Thread Greg Kroah-Hartman
On Wed, Jul 08, 2015 at 08:10:46PM +0300, Stas Sergeev wrote: > 08.07.2015 10:35, Greg Kroah-Hartman пишет: > >4.1-stable review patch. If anyone has any objections, please let me know. > > > >-- > > > >From: Stas Sergeev > > > >[ Upstream commit 538761b794c1542f1c6e31eadd9d7aae11

Re: printk: preempt_disable with long time resulting in softlockup/RCU stall issues

2015-07-08 Thread Joe Perches
On Wed, 2015-07-08 at 19:04 +0200, Luis R. Rodriguez wrote: > On Wed, Jul 08, 2015 at 05:08:35PM +0800, Gavin Hu wrote: > > Hi, > > > > Yes. We should disable the printk_limit feature when panic to avoid missing > > messages. > > Sounds like you have been looking into it and have a good idea of w

Re: [PATCH 7/8] memcg: get rid of mm_struct::owner

2015-07-08 Thread Vladimir Davydov
I like the gist of this patch. A few comments below. On Wed, Jul 08, 2015 at 02:27:51PM +0200, Michal Hocko wrote: [...] > diff --git a/fs/exec.c b/fs/exec.c > index 1977c2a553ac..3ed9c0abc9f5 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -870,7 +870,7 @@ static int exec_mmap(struct mm_struct *m

Re: [PATCH 4.1 54/56] fs/ufs: restore s_lock mutex

2015-07-08 Thread Greg Kroah-Hartman
On Wed, Jul 08, 2015 at 06:28:23PM +0200, Fabian Frederick wrote: > > Hello Greg, > >                 Here's the complete list of linux-next/UFS patches needed > to stop regressions in write mode: > > 13b987ea2758 > fs/ufs: revert "ufs: fix deadlocks introduced by sb mutex merge" > > cdd9eefdf9

Re: [PATCH v2 1/2] firmware: psci: move cpu_suspend handling to generic code

2015-07-08 Thread Lorenzo Pieralisi
Hi Jisheng, On Wed, Jul 08, 2015 at 01:51:07PM +0100, Jisheng Zhang wrote: > Functions implemented on arm64 to suspend cpu and translate the idle > state index passed by the cpu_suspend core call to a valid PSCI state > are not arm64 specific and should be moved to generic code so that they > can

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Andy Lutomirski
On Wed, Jul 8, 2015 at 9:59 AM, Linus Torvalds wrote: > On Tue, Jul 7, 2015 at 7:33 PM, Arjan van de Ven > wrote: >> >> if this patch would not be acceptable, at minimum we need some sort of "off >> by default >> unless the sysadmin flips a sysfs thing", which is really just a huge hack. > > The

Re: Linux 4.2-rc1

2015-07-08 Thread Linus Torvalds
On Wed, Jul 8, 2015 at 10:17 AM, Linus Torvalds wrote: > > Decoding the "Code:" line shows that this is the "->fw_id" dereference in > > if (add_uevent_var(env, "FIRMWARE=%s", fw_priv->buf->fw_id)) > return -ENOMEM; > > and that "fw_priv->buf" pointer is NULL. > > However,

Re: [PATCH] uio: Destroy uio_idr on module exit

2015-07-08 Thread Greg Kroah-Hartman
On Wed, Jul 08, 2015 at 05:24:46PM +0200, Johannes Thumshirn wrote: > Destroy uio_idr on module exit, reclaiming the allocated memory. > > This was detected by the following semantic patch (written by Luis Rodriguez > ) > > @ defines_module_init @ > declarer name module_init, module_exit; > decla

Re: [PATCH 2/4] locking/qrwlock: Reduce reader/writer to reader lock transfer latency

2015-07-08 Thread Will Deacon
On Wed, Jul 08, 2015 at 10:52:48AM +0100, Peter Zijlstra wrote: > On Tue, Jul 07, 2015 at 05:29:50PM -0400, Waiman Long wrote: > > I prefer the current setting as you won't know if the writer has the > > lock or not when you take a snapshot of the value of the lock. You > > need the whole time sequ

Re: Linux 4.2-rc1

2015-07-08 Thread Linus Torvalds
On Wed, Jul 8, 2015 at 9:32 AM, Shuah Khan wrote: > > I am seeing the following NULL pointer dereference on my test system: > > [3.640599] BUG: unable to handle kernel NULL pointer dereference at > 0080 > [3.640609] IP: [] firmware_uevent+0x23/0x80 Decoding the "Code:" line s

Re: [PATCH 07/13] arm64: KVM: VHE: Patch out use of HVC

2015-07-08 Thread Paolo Bonzini
On 08/07/2015 18:19, Marc Zyngier wrote: > +/* Hack to allow stringification of macros... */ > +#define __S__(a,args...) __stringify(a, ##args) > +#define _S_(a,args...) __S__(a, args) > + > +.macro ifnvhe nonvhe vhe > + alternative_insn"\nonvhe", "\vhe", ARM64_HAS_V

[PATCH] MCA: garbage collect sys_desc_table

2015-07-08 Thread Paolo Pisati
Signed-off-by: Paolo Pisati --- Documentation/x86/zero-page.txt | 1 - arch/x86/boot/Makefile| 2 +- arch/x86/boot/boot.h | 3 --- arch/x86/boot/compressed/eboot.c | 4 arch/x86/boot/main.c | 3 --- arch/x86/boot/mca.c

[PATCH] MCA: garbage collect sys_desc_table

2015-07-08 Thread Paolo Pisati
Is sys_desc_table still used anywhere? It seems not: arch/x86/boot/mca.c::query_mca() ... copy_from_fs(&boot_params.sys_desc_table, oreg.bx, len); ... arch/x86/kernel/setup.c::setup_arch() ... if (boot_params.sys_desc_table.length != 0) { machine_id = boot_params.sys_desc_table.ta

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Vivien Didelot
Hi Andrew, On Jul 8, 2015, at 10:38 AM, Andrew Lunn and...@lunn.ch wrote: > On Tue, Jul 07, 2015 at 05:18:17PM -0400, Vivien Didelot wrote: >> Hi all, >> >> This patchset brings full support for hardware VLANs in DSA, and the Marvell >> 88E6xxx compatible switch chips. > > Hi Vivien > > I woul

Re: Linux 4.2-rc1

2015-07-08 Thread Casey Schaufler
On 7/8/2015 9:32 AM, Shuah Khan wrote: > On Sun, Jul 5, 2015 at 2:22 PM, Linus Torvalds > wrote: >> It's Sunday, two weeks have passed, and the merge window is closed. I >> just pushed out the tag to the git trees, and tar-balls and patches >> should be mirroring out too. >> >> I thought this rele

Re: [PATCH 4.1 11/56] mvneta: add forgotten initialization of autonegotiation bits

2015-07-08 Thread Stas Sergeev
08.07.2015 10:35, Greg Kroah-Hartman пишет: 4.1-stable review patch. If anyone has any objections, please let me know. -- From: Stas Sergeev [ Upstream commit 538761b794c1542f1c6e31eadd9d7aae118889f7 ] The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link stat

Re: [PATCH v4 3/5] tee: generic TEE subsystem

2015-07-08 Thread Jason Gunthorpe
On Wed, Jul 08, 2015 at 12:16:30PM +0200, Jens Wiklander wrote: > +static void tee_device_complete_unused(struct kref *kref) > +{ > + struct tee_device *teedev; > + > + teedev = container_of(kref, struct tee_device, users); > + /* When the mutex is released, no other tee_device_get() w

Re: tw5864 driver development, help needed

2015-07-08 Thread Andrey Utkin
On Fri, Jul 3, 2015 at 5:23 PM, Andrey Utkin wrote: > Up... we are moving much slower than we expected, desperately needing help. > > Running reference driver with Ubuntu 9 (with kernel 2.6.28.10) with > 16-port card shows that the > reference driver fails to work with it correctly. Also that driv

[PATCH] libata: increase the timeout when setting transfer mode

2015-07-08 Thread Mikulas Patocka
I have a ST4000DM000 disk. If Linux is booted while the disk is spun down, the command that sets transfer mode causes the disk to spin up. The spin-up takes longer than the default 5s timeout, so the command fails and timeout is reported. Fix this by increasing the timeout to 15s, which is enough

Re: printk: preempt_disable with long time resulting in softlockup/RCU stall issues

2015-07-08 Thread Luis R. Rodriguez
On Wed, Jul 08, 2015 at 05:08:35PM +0800, Gavin Hu wrote: > Hi, > > Yes. We should disable the printk_limit feature when panic to avoid missing > messages. Sounds like you have been looking into it and have a good idea of what you want to do, why not try it and send some RFC patches ? While at i

[PATCH v5 2/2] sched/deadline: Check to push the task away after its affinity was changed

2015-07-08 Thread Xunlei Pang
From: Xunlei Pang (Sync up the same behaviour as that of RT) We may suffer from extra dl overload rq due to the affinity, so when the affinity of any runnable dl task is changed, we should check to trigger balancing, otherwise it will cause some unnecessary delayed real-time response. Unfortunat

[PATCH v5 1/2] sched/rt: Check to push the task away after its affinity was changed

2015-07-08 Thread Xunlei Pang
From: Xunlei Pang We may suffer from extra rt overload rq due to the affinity, so when the affinity of any runnable rt task is changed, we should check to trigger balancing, otherwise it will cause some unnecessary delayed real-time response. Unfortunately, current RT global scheduler does nothin

Re: [PATCH V3 0/5] Allow user to request memory to be locked on page fault

2015-07-08 Thread Andrew Morton
On Wed, 8 Jul 2015 09:23:02 -0400 Eric B Munson wrote: > > I don't know whether these syscalls should be documented via new > > manpages, or if we should instead add them to the existing > > mlock/munlock/mlockall manpages. Michael, could you please advise? > > > > Thanks for adding the series

Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN

2015-07-08 Thread Linus Torvalds
On Tue, Jul 7, 2015 at 7:33 PM, Arjan van de Ven wrote: > > if this patch would not be acceptable, at minimum we need some sort of "off > by default > unless the sysadmin flips a sysfs thing", which is really just a huge hack. The only thing that matters is whether people use this or not. If peo

Re: [PATCH, resend] build: fix broken kernel RPM source symlink

2015-07-08 Thread Paul Bolle
[I resisted looking into the flood of info you included in this message. But this part could turn out to be interesting.] On ma, 2015-07-06 at 21:37 +0200, Espen Carlsen wrote: > This is the how BUILDROOT looks after rpmbuild -bi kernel-4.1.0.spec > on an Ubuntu system, notice that on Ubuntu, the

Re: Query: Clock driver requests mailbox channel

2015-07-08 Thread Michael Turquette
Cc'ing linux-clk and Stephen Boyd Quoting Leo Yan (2015-07-07 07:04:25) > On Tue, Jul 07, 2015 at 10:54:55AM +0530, Jassi Brar wrote: > > On Mon, Jul 6, 2015 at 5:03 PM, Leo Yan wrote: > > > Hi all, > > > > > > i'm working with one clock driver, which will invoke mailbox API to > > > request the

<    1   2   3   4   5   6   7   8   9   10   >