[PATCH] staging: wlan-ng: fixed a comment

2015-11-23 Thread Gavin O'Leary
Fixed a comment style issue. Signed-off-by: Gavin O'Leary --- drivers/staging/wlan-ng/cfg80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index 8c1e3f0..2d9b42f 100644 ---

Re: [RFC] asm-generic: default BUG_ON(x) to "if(x) BUG()"

2015-11-23 Thread Willy Tarreau
On Mon, Nov 23, 2015 at 05:52:38PM +0100, Arnd Bergmann wrote: > On Monday 23 November 2015 16:37:50 Russell King - ARM Linux wrote: > > On Mon, Nov 23, 2015 at 05:33:59PM +0100, Willy Tarreau wrote: > > > I think you could do better by simply calling panic("BUG!") instead as > > > BUG() does. It

Re: [PATCH] nfsd: recover: constify nfsd4_client_tracking_ops structures

2015-11-23 Thread J. Bruce Fields
On Sun, Nov 22, 2015 at 07:25:12AM -0500, Jeff Layton wrote: > On Sun, 22 Nov 2015 08:22:10 +0100 > Julia Lawall wrote: > > > The nfsd4_client_tracking_ops structures are never modified, so declare > > them as const. > > > > Done with the help of Coccinelle. > > > > Signed-off-by: Julia Lawall

[4.4-rc2] regresstion: ksoftirqd/2 Fatal exception in interrupt pids.freepids.uncharge.constprop

2015-11-23 Thread Martin Steigerwald
Hi! I saw this with 4.4-rc2 twice on boot: pids.freepids.uncharge.constprop cgroup_free RIP pids.cancel.constprop. I think somewhat after systemd mounted cgroup filesystems. Had no digital camera at hand and I am on the go, so just these few pointers at the moment. martin@merkaba:~>

Re: [PATCH 07/13] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information

2015-11-23 Thread Arnd Bergmann
On Sunday 22 November 2015 22:24:01 Marcin Wojtas wrote: > > 2015-11-22 21:02 GMT+01:00 Arnd Bergmann : > > On Sunday 22 November 2015 08:53:53 Marcin Wojtas wrote: > >> This commit enables finding appropriate mbus window and obtaining its > >> target id and attribute for given physical address

Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module

2015-11-23 Thread Arnd Bergmann
On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote: > Separate out I2C functionality into a module. This fixes several small > issues and simplifies the driver initialization. > > Signed-off-by: Andrew F. Davis That looks good to me overall, it should help with the randconfig warnings

Re: dw_mmc: HLE errors

2015-11-23 Thread Doug Anderson
Jorge, On Mon, Nov 23, 2015 at 6:10 AM, Jorge Ramirez-Ortiz wrote: > Doug/Jaehoon, > > Were there any follow ups to this thread [1] from March 30, 2015? > We are seeing HLE errors on 3.18 and we are trying to determine if a solution > was ever delivered. > On inspection, I can't find anything

[PATCH] ARM: dts: keystone: k2l: fix kernel crash when clk_ignore_unused is not in bootargs

2015-11-23 Thread Murali Karicheri
Currently kernel crash randomly when K2L EVM is booted without clk_ignore_unused in the bootargs. This workaround is not needed on other K2 devices such as K2HK and K2E and with this fix, we can remove the workaround altogether. netcp driver on K2L uses linked ram on OSR (On chip Static RAM) and

Re: [PATCH v4 52/79] include/uapi/netfilter/*.h: fix include files for compilation

2015-11-23 Thread Pablo Neira Ayuso
On Thu, Oct 15, 2015 at 07:56:30AM +0200, Mikko Rapeli wrote: > Add missing header dependencies and other small changes so that each file > compiles alone in userspace. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 10/14] irqchip/mips-gic: Add a IPI hierarchy domaind

2015-11-23 Thread Qais Yousef
On 11/20/2015 08:39 PM, Thomas Gleixner wrote: Same applies when doing the reverse mapping. In other words, the ipi_mask won't always necessarily be linear to facilitate the 1:1 mapping that this approach assumes. It is a solvable problem, but I think we're losing the elegance that promoted

Re: [PATCH v4 21/79] ebtables.h: use __u64 from linux/types.h

2015-11-23 Thread Pablo Neira Ayuso
On Thu, Oct 15, 2015 at 07:55:59AM +0200, Mikko Rapeli wrote: > Fixes userspace compilation error: > > linux/netfilter_bridge/ebtables.h:38:2: error: unknown type name ‘uint64_t’ Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[PATCH] power: bq27xxx_battery: Reorganize I2C into a module

2015-11-23 Thread Andrew F. Davis
Separate out I2C functionality into a module. This fixes several small issues and simplifies the driver initialization. Signed-off-by: Andrew F. Davis --- drivers/power/Kconfig | 14 +- drivers/power/Makefile| 1 + drivers/power/bq27xxx_battery.c | 326

Re: [PATCH v2] sp5100_tco: Add AMD Mullins platform support

2015-11-23 Thread Guenter Roeck
On 11/22/2015 11:59 PM, Denis Turischev wrote: AMD Mullins watchdog is fully compatible to the previous Hudson chipset, reuse the existent sp5100_tco driver. v2: rebased to v4.4-rc2 Signed-off-by: Denis Turischev diff -Nru linux-4.4-rc2.orig/drivers/watchdog/sp5100_tco.c

Re: [RFC] asm-generic: default BUG_ON(x) to "if(x) BUG()"

2015-11-23 Thread Arnd Bergmann
On Monday 23 November 2015 16:37:50 Russell King - ARM Linux wrote: > On Mon, Nov 23, 2015 at 05:33:59PM +0100, Willy Tarreau wrote: > > I think you could do better by simply calling panic("BUG!") instead as > > BUG() does. It will avoid the printk() call and pushing the file/line > > number onto

[PATCH v2] mm: fix swapped Movable and Reclaimable in /proc/pagetypeinfo

2015-11-23 Thread Vlastimil Babka
Commit 016c13daa5c9 ("mm, page_alloc: use masks and shifts when converting GFP flags to migrate types") has swapped MIGRATE_MOVABLE and MIGRATE_RECLAIMABLE in the enum definition. However, migratetype_names wasn't updated to reflect that. As a result, the file /proc/pagetypeinfo shows the counts

Re: [RFC] asm-generic: default BUG_ON(x) to "if(x) BUG()"

2015-11-23 Thread Willy Tarreau
On Mon, Nov 23, 2015 at 04:37:50PM +, Russell King - ARM Linux wrote: > On Mon, Nov 23, 2015 at 05:33:59PM +0100, Willy Tarreau wrote: > > I think you could do better by simply calling panic("BUG!") instead as > > BUG() does. It will avoid the printk() call and pushing the file/line > > number

Re: [RFC2 PATCH v6 00/19] ILP32 for ARM64

2015-11-23 Thread Andreas Schwab
Yury Norov writes: > v6: > - time_t, __kenel_off_t and other types turned to be 32-bit >for compatibility reasons (after v5 discussion); > - related changes applied to ILP32 syscall table and handlers; > - ILP32 VDSO code excluded. It's not mandatory, and caused questions >during

Re: [linux-sunxi] Re: [PATCH v4 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI

2015-11-23 Thread Chen-Yu Tsai
On Mon, Nov 23, 2015 at 6:50 PM, Hans de Goede wrote: > HI, > > > On 23-11-15 09:57, Maxime Ripard wrote: >> >> Hi, >> >> On Sun, Nov 01, 2015 at 02:33:23PM +0100, Jens Kuske wrote: > > + bus_gates: clk@01c20060 { > + #clock-cells = <1>; > +

Re: [PATCH] PCI: keystone: fix crash with deferred probe

2015-11-23 Thread Sekhar Nori
On Monday 23 November 2015 04:57 PM, Jisheng Zhang wrote: > On Mon, 23 Nov 2015 19:22:09 +0800 > Jisheng Zhang wrote: > >> Dear Sekhar, >> >> On Fri, 20 Nov 2015 16:47:02 +0530 >> Sekhar Nori wrote: >> >>> Drop __init annotations for functions called during >>> probe of keystone PCIe host. >>>

Re: [PATCH v5 4/4] devicetree: update documentation for fw_cfg ARM bindings

2015-11-23 Thread Gabriel L. Somlo
On Mon, Nov 23, 2015 at 05:35:51PM +0100, Laszlo Ersek wrote: > On 11/23/15 16:57, Gabriel L. Somlo wrote: > > From: Gabriel Somlo > > > > Remove fw_cfg hardware interface details from > > Documentation/devicetree/bindings/arm/fw-cfg.txt, > > and replace them with a pointer to the authoritative

[GIT PULL] USB fixes for v4.4-rc3

2015-11-23 Thread Felipe Balbi
Hi Greg, Here's my second round of fixes for current -rc as promissed. Let me know if you want anything to be changed, but response may be slow. 'vacation-mode' is a major mode which prevents emacs from being used :-p regards The following changes since commit

[PATCH 2/3] Drivers: hv: ring_buffer: remove stray smp_read_barrier_depends()

2015-11-23 Thread Vitaly Kuznetsov
smp_read_barrier_depends() does nothing on almost all arcitectures including x86 and having it in the beginning of hv_get_ringbuffer_availbytes() does not provide any guarantees anyway. Signed-off-by: Vitaly Kuznetsov --- include/linux/hyperv.h | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 1/3] Drivers: hv: ring_buffer.c: fix comment style

2015-11-23 Thread Vitaly Kuznetsov
Convert 6+-string comments repeating function names to normal kernel-style comments and fix a couple of other comment style issues. No textual or functional changes intended. Signed-off-by: Vitaly Kuznetsov --- drivers/hv/ring_buffer.c | 135 +-- 1

[PATCH 3/3] Drivers: hv: ring_buffer: remove code duplication from hv_ringbuffer_peek/read()

2015-11-23 Thread Vitaly Kuznetsov
hv_ringbuffer_peek() does the same as hv_ringbuffer_read() without advancing the read index. The only functional change this patch brings is moving hv_need_to_signal_on_read() call under the ring_lock but this function is just a couple of comparisons. Signed-off-by: Vitaly Kuznetsov ---

Re: [PATCH] power: bq27xxx_battery: avoid unused function warnings

2015-11-23 Thread Andrew F. Davis
On 11/23/2015 07:42 AM, Arnd Bergmann wrote: We can configure the bq27xxx_battery driver with neither the I2C nor the platform driver backends, which leaves out all references to some of the symbols, causing a couple of warnings in many randconfig builds: drivers/power/bq27xxx_battery.c:288:12:

[PATCH 0/3] Drivers: hv: ring_buffer: do some code cleanup

2015-11-23 Thread Vitaly Kuznetsov
1) Fix comment style in ring_buffer.c 2) Remove unneeded smp_read_barrier_depends() from hyperv.h 3) Unify hv_ringbuffer_peek/read() functions. Vitaly Kuznetsov (3): Drivers: hv: ring_buffer.c: fix comment style Drivers: hv: ring_buffer: remove stray smp_read_barrier_depends() Drivers: hv:

Re: [PATCH v5 4/4] devicetree: update documentation for fw_cfg ARM bindings

2015-11-23 Thread Laszlo Ersek
On 11/23/15 16:57, Gabriel L. Somlo wrote: > From: Gabriel Somlo > > Remove fw_cfg hardware interface details from > Documentation/devicetree/bindings/arm/fw-cfg.txt, > and replace them with a pointer to the authoritative > documentation in the QEMU source tree. > > Signed-off-by: Gabriel Somlo

Re: [PATCH v5 2/8] watchdog: Introduce WDOG_RUNNING flag

2015-11-23 Thread Guenter Roeck
On 11/23/2015 08:30 AM, Alexander Stein wrote: On Sunday 22 November 2015 19:20:59, Guenter Roeck wrote: diff --git a/Documentation/watchdog/watchdog-kernel-api.txt b/Documentation/watchdog/watchdog-kernel-api.txt index f66859117d1f..3f0963b2c33e 100644 ---

Re: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment

2015-11-23 Thread Arnd Bergmann
On Monday 23 November 2015 18:23:47 Stanimir Varbanov wrote: > >> > >> Fixes: 0021d22b73d6 ("PCI: designware: Use > >> of_pci_get_host_bridge_resources() > >> to parse DT") > >> Reviewed-by: Arnd Bergmann > > I think the bug is introduced in: > > cbce7900598c ("PCI: designware: Make driver

Re: [PATCH] lightnvm: fix memory leak

2015-11-23 Thread Sudip Mukherjee
On Mon, Nov 23, 2015 at 04:13:39PM +0100, Matias Bjørling wrote: > On 11/23/2015 11:35 AM, Sudip Mukherjee wrote: > >If copy_to_user() fails we returned error but we missed releasing > >devices. > > > >Signed-off-by: Sudip Mukherjee > >--- > > drivers/lightnvm/core.c | 5 - > > 1 file

Re: [PATCH v11 6/8] Input: goodix - add support for ESD

2015-11-23 Thread Bastien Nocera
On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > > Signed-off-by: Irina Tirdea > For the binding: Acked-by: Rob Herring > > Signed-off-by: Irina Tirdea Tested-by: Bastien Nocera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [GIT PULL] optimize 64-by-32 ddivision for constant divisors on 32-bit machines

2015-11-23 Thread Nicolas Pitre
On Mon, 23 Nov 2015, Arnd Bergmann wrote: > On Monday 23 November 2015 11:04:33 Nicolas Pitre wrote: > > > > OK... I'm able to "fix" the build with: > > > > diff --git a/include/asm-generic/div64.h b/include/asm-generic/div64.h > > index 163f77999e..d246c4c801 100644 > > ---

Re: [RFC] asm-generic: default BUG_ON(x) to "if(x) BUG()"

2015-11-23 Thread Russell King - ARM Linux
On Mon, Nov 23, 2015 at 05:33:59PM +0100, Willy Tarreau wrote: > I think you could do better by simply calling panic("BUG!") instead as > BUG() does. It will avoid the printk() call and pushing the file/line > number onto the stack. It will also probably not inflate the rodata this > way. Does

Re: [RFC] asm-generic: default BUG_ON(x) to "if(x) BUG()"

2015-11-23 Thread Willy Tarreau
Hi Arnd, On Mon, Nov 23, 2015 at 05:25:28PM +0100, Arnd Bergmann wrote: > When CONFIG_BUG is disabled, BUG_ON() will only evaluate the condition, > but will not actually stop the current thread. GCC warns about a couple > of BUG_ON() users where this actually leads to further undefined >

Re: [RFC] asm-generic: default BUG_ON(x) to "if(x) BUG()"

2015-11-23 Thread Russell King - ARM Linux
On Mon, Nov 23, 2015 at 05:25:28PM +0100, Arnd Bergmann wrote: > This patch picks the second choice, and changes the NOP to BUG(), which > normally stops the execution of the current thread in some form (endless > loop or a trap). This follows the logic we applied in a4b5d580e078 ("bug: > Make

Re: [PATCH v11 8/8] Input: goodix - add runtime power management support

2015-11-23 Thread Bastien Nocera
On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > Add support for runtime power management so that the device is > turned off when not used (when the userspace holds no open > handles of the input device). The device uses autosuspend with a > default delay of 2 seconds, so the device will

[tip:sched/core] sched/fair: Prepare __update_cpu_load() to handle active tickless

2015-11-23 Thread tip-bot for Byungchul Park
Commit-ID: 59543275488d18d878cd2ab2b1072efc1e9ac1c4 Gitweb: http://git.kernel.org/tip/59543275488d18d878cd2ab2b1072efc1e9ac1c4 Author: Byungchul Park AuthorDate: Wed, 14 Oct 2015 18:47:35 +0900 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:37:53 +0100 sched/fair: Prepare

Re: [PATCH v11 4/8] Input: goodix - add power management support

2015-11-23 Thread Bastien Nocera
On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > Implement suspend/resume for goodix driver. > > The suspend and resume process uses the gpio pins. > If the device ACPI/DT information does not declare gpio pins, > suspend/resume will not be available for these devices. > > This is based

[tip:sched/core] stop_machine: Kill cpu_stop_done->executed

2015-11-23 Thread tip-bot for Oleg Nesterov
Commit-ID: 6fa3b826bcb3309157166e6e523a4be236fe267a Gitweb: http://git.kernel.org/tip/6fa3b826bcb3309157166e6e523a4be236fe267a Author: Oleg Nesterov AuthorDate: Sun, 15 Nov 2015 20:33:26 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:48:19 +0100 stop_machine: Kill

Re: [PATCH v11 3/8] Input: goodix - write configuration data to device

2015-11-23 Thread Bastien Nocera
On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > > Signed-off-by: Octavian Purdila > Signed-off-by: Irina Tirdea Works on the WinBook TW100 Tested-by: Bastien Nocera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v5 2/8] watchdog: Introduce WDOG_RUNNING flag

2015-11-23 Thread Alexander Stein
On Sunday 22 November 2015 19:20:59, Guenter Roeck wrote: > diff --git a/Documentation/watchdog/watchdog-kernel-api.txt > b/Documentation/watchdog/watchdog-kernel-api.txt > index f66859117d1f..3f0963b2c33e 100644 > --- a/Documentation/watchdog/watchdog-kernel-api.txt > +++

Re: [PATCH 3.12 00/72] 3.12.51-stable review

2015-11-23 Thread Shuah Khan
On 11/23/2015 06:07 AM, Jiri Slaby wrote: > This is the start of the stable review cycle for the 3.12.51 release. > There are 72 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should

Re: [PATCH v11 2/8] Input: goodix - reset device at init

2015-11-23 Thread Bastien Nocera
On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > > Signed-off-by: Octavian Purdila > Signed-off-by: Irina Tirdea Works on the WinBook TW100 Acked-by: Bastien Nocera Tested-by: Bastien Nocera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[tip:x86/mm] x86/mm: Turn CONFIG_X86_PTDUMP into a module

2015-11-23 Thread tip-bot for Kees Cook
Commit-ID: 8609d1b5daa36350e020e737946c40887af1743a Gitweb: http://git.kernel.org/tip/8609d1b5daa36350e020e737946c40887af1743a Author: Kees Cook AuthorDate: Thu, 19 Nov 2015 17:07:55 -0800 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 10:50:13 +0100 x86/mm: Turn

[tip:x86/asm] x86/entry, x86/paravirt: Remove the unused usergs_sysret32 PV op

2015-11-23 Thread tip-bot for Boris Ostrovsky
Commit-ID: 75ef82190dceac3d84cdc209fdf82800a7cc6609 Gitweb: http://git.kernel.org/tip/75ef82190dceac3d84cdc209fdf82800a7cc6609 Author: Boris Ostrovsky AuthorDate: Thu, 19 Nov 2015 16:55:47 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 10:48:16 +0100 x86/entry,

Re: [PATCH v2] vmscan: do not force-scan file lru if its absolute size is small

2015-11-23 Thread Johannes Weiner
On Mon, Nov 23, 2015 at 01:39:33PM +0300, Vladimir Davydov wrote: > We assume there is enough inactive page cache if the size of inactive > file lru is greater than the size of active file lru, in which case we > force-scan file lru ignoring anonymous pages. While this logic works > fine when

Re: [PATCH 3.12 00/72] 3.12.51-stable review

2015-11-23 Thread Guenter Roeck
On 11/23/2015 08:27 AM, Guenter Roeck wrote: On 11/23/2015 05:07 AM, Jiri Slaby wrote: This is the start of the stable review cycle for the 3.12.51 release. There are 72 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied,

[tip:x86/asm] x86/paravirt: Remove the unused irq_enable_sysexit pv op

2015-11-23 Thread tip-bot for Boris Ostrovsky
Commit-ID: 88c15ec90ff16880efab92b519436ee17b198477 Gitweb: http://git.kernel.org/tip/88c15ec90ff16880efab92b519436ee17b198477 Author: Boris Ostrovsky AuthorDate: Thu, 19 Nov 2015 16:55:46 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 10:48:16 +0100 x86/paravirt: Remove

[tip:x86/asm] x86/xen: Avoid fast syscall path for Xen PV guests

2015-11-23 Thread tip-bot for Boris Ostrovsky
Commit-ID: 5fdf5d37f40a3b18c0d613463867f71c017b75ef Gitweb: http://git.kernel.org/tip/5fdf5d37f40a3b18c0d613463867f71c017b75ef Author: Boris Ostrovsky AuthorDate: Thu, 19 Nov 2015 16:55:45 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 10:48:16 +0100 x86/xen: Avoid fast

Re: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module

2015-11-23 Thread Lee Jones
On Thu, 19 Nov 2015, Charles Keepax wrote: > The MFD part of wm8994 consists of three files wm8994-core.c, > wm8994-irq.c and wm8994-regmap.c only wm8994-core.c has a > MODULE_DESCRIPTION / LICENSE. These were clearly intended to be built > as a single module, but currently are not. This will

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

2015-11-23 Thread Jason Baron
On 11/20/2015 05:07 PM, Rainer Weikusat wrote: > Rainer Weikusat writes: > An AF_UNIX datagram socket being the client in an n:1 association with > some server socket is only allowed to send messages to the server if the > receive queue of this socket contains at most sk_max_ack_backlog >

[tip:locking/core] locking/pvqspinlock, x86: Optimize the PV unlock code path

2015-11-23 Thread tip-bot for Waiman Long
Commit-ID: d78045306c41bd9334b956e4e7fa77cc72f06a40 Gitweb: http://git.kernel.org/tip/d78045306c41bd9334b956e4e7fa77cc72f06a40 Author: Waiman Long AuthorDate: Mon, 9 Nov 2015 19:09:24 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 10:02:02 +0100 locking/pvqspinlock, x86:

[tip:locking/core] locking/qspinlock: Prefetch the next node cacheline

2015-11-23 Thread tip-bot for Waiman Long
Commit-ID: 81b5598665a24083dd889fbd8cb08b0d8de4b8ad Gitweb: http://git.kernel.org/tip/81b5598665a24083dd889fbd8cb08b0d8de4b8ad Author: Waiman Long AuthorDate: Mon, 9 Nov 2015 19:09:22 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 10:01:59 +0100 locking/qspinlock: Prefetch

[tip:locking/core] locking/qspinlock: Avoid redundant read of next pointer

2015-11-23 Thread tip-bot for Waiman Long
Commit-ID: aa68744f80bfb6f26fbe7f10e42876066f7dac1b Gitweb: http://git.kernel.org/tip/aa68744f80bfb6f26fbe7f10e42876066f7dac1b Author: Waiman Long AuthorDate: Mon, 9 Nov 2015 19:09:23 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 10:02:00 +0100 locking/qspinlock: Avoid

[tip:x86/urgent] x86/microcode: Initialize the driver late when facilities are up

2015-11-23 Thread tip-bot for Borislav Petkov
Commit-ID: 2d5be37d686c4dae8e60d20283d6f44ac2c44f65 Gitweb: http://git.kernel.org/tip/2d5be37d686c4dae8e60d20283d6f44ac2c44f65 Author: Borislav Petkov AuthorDate: Fri, 20 Nov 2015 12:24:00 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 10:39:49 +0100 x86/microcode:

[tip:locking/core] atomics: Add test for atomic operations with _relaxed variants

2015-11-23 Thread tip-bot for Boqun Feng
Commit-ID: 978e5a3692c3b674b4c7c412e96835fd996c2ff4 Gitweb: http://git.kernel.org/tip/978e5a3692c3b674b4c7c412e96835fd996c2ff4 Author: Boqun Feng AuthorDate: Wed, 4 Nov 2015 18:52:45 +0800 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 10:01:58 +0100 atomics: Add test for atomic

[tip:locking/core] locking/qspinlock: Use _acquire/_release() versions of cmpxchg() & xchg()

2015-11-23 Thread tip-bot for Waiman Long
Commit-ID: 64d816cba06c67455b8c78ebcda349d49c24 Gitweb: http://git.kernel.org/tip/64d816cba06c67455b8c78ebcda349d49c24 Author: Waiman Long AuthorDate: Mon, 9 Nov 2015 19:09:21 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 10:01:58 +0100 locking/qspinlock: Use

Re: [PATCH 3.12 00/72] 3.12.51-stable review

2015-11-23 Thread Guenter Roeck
On 11/23/2015 05:07 AM, Jiri Slaby wrote: This is the start of the stable review cycle for the 3.12.51 release. There are 72 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by

[tip:perf/core] perf/x86: Handle multiple umask bits for BDW CYCLE_ACTIVITY.*

2015-11-23 Thread tip-bot for Andi Kleen
Commit-ID: b7883a1c4f75edb62fc49da6000c59fb881e3c7b Gitweb: http://git.kernel.org/tip/b7883a1c4f75edb62fc49da6000c59fb881e3c7b Author: Andi Kleen AuthorDate: Mon, 16 Nov 2015 16:21:07 -0800 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:58:27 +0100 perf/x86: Handle multiple

[tip:perf/core] perf, x86: Stop Intel PT before kdump starts

2015-11-23 Thread tip-bot for Takao Indoh
Commit-ID: da06a43d3f3f3df87416f654fe15d29fecb5e321 Gitweb: http://git.kernel.org/tip/da06a43d3f3f3df87416f654fe15d29fecb5e321 Author: Takao Indoh AuthorDate: Wed, 4 Nov 2015 14:22:33 +0900 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:58:26 +0100 perf, x86: Stop Intel PT

[PATCH] Kbuild: disable 'maybe-uninitialized' warning for CONFIG_PROFILE_ALL_BRANCHES

2015-11-23 Thread Arnd Bergmann
CONFIG_PROFILE_ALL_BRANCHES confuses gcc-5.x to the degree that it prints incorrect warnings about a lot of variables that it thinks can be used uninitialized, e.g.: i2c/busses/i2c-diolan-u2c.c: In function 'diolan_usb_xfer': i2c/busses/i2c-diolan-u2c.c:391:16: warning: 'byte' may be used

[tip:perf/core] perf/x86/intel/pt: Add interface to stop Intel PT logging

2015-11-23 Thread tip-bot for Takao Indoh
Commit-ID: 24cc12b17679f8e9046746f92fd377f589efc163 Gitweb: http://git.kernel.org/tip/24cc12b17679f8e9046746f92fd377f589efc163 Author: Takao Indoh AuthorDate: Wed, 4 Nov 2015 14:22:32 +0900 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:58:26 +0100 perf/x86/intel/pt: Add

[tip:perf/core] perf/x86: Add option to disable reading branch flags/cycles

2015-11-23 Thread tip-bot for Andi Kleen
Commit-ID: b16a5b52eb90d92b597257778e51e1fdc6423e64 Gitweb: http://git.kernel.org/tip/b16a5b52eb90d92b597257778e51e1fdc6423e64 Author: Andi Kleen AuthorDate: Tue, 20 Oct 2015 11:46:34 -0700 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:58:25 +0100 perf/x86: Add option to

[RFC] asm-generic: default BUG_ON(x) to "if(x) BUG()"

2015-11-23 Thread Arnd Bergmann
When CONFIG_BUG is disabled, BUG_ON() will only evaluate the condition, but will not actually stop the current thread. GCC warns about a couple of BUG_ON() users where this actually leads to further undefined behavior: include/linux/ceph/osdmap.h: In function 'ceph_can_shift_osds':

Re: [linux-sunxi] Re: [PATCH v4 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI

2015-11-23 Thread Jens Kuske
On 23/11/15 11:50, Hans de Goede wrote: > HI, > > On 23-11-15 09:57, Maxime Ripard wrote: >> Hi, >> >> On Sun, Nov 01, 2015 at 02:33:23PM +0100, Jens Kuske wrote: > + bus_gates: clk@01c20060 { > + #clock-cells = <1>; > +

[tip:perf/core] perf/x86: Optimize stack walk user accesses

2015-11-23 Thread tip-bot for Andi Kleen
Commit-ID: 75925e1ad7f5a4e867bd14ff8e7f114ea1596434 Gitweb: http://git.kernel.org/tip/75925e1ad7f5a4e867bd14ff8e7f114ea1596434 Author: Andi Kleen AuthorDate: Thu, 22 Oct 2015 15:07:21 -0700 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:58:25 +0100 perf/x86: Optimize stack

[tip:sched/core] stop_machine: Clean up the usage of the preemption counter in cpu_stopper_thread()

2015-11-23 Thread tip-bot for Oleg Nesterov
Commit-ID: accaf6ea3db6f5fb997f096b6eefd5431d03f7e5 Gitweb: http://git.kernel.org/tip/accaf6ea3db6f5fb997f096b6eefd5431d03f7e5 Author: Oleg Nesterov AuthorDate: Sun, 15 Nov 2015 20:33:32 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:48:20 +0100 stop_machine: Clean up

[tip:sched/core] stop_machine: Shift the 'done != NULL' check from cpu_stop_signal_done() to callers

2015-11-23 Thread tip-bot for Oleg Nesterov
Commit-ID: dd2e3121e3cb16d03a6e3f2db48f260f046f39c2 Gitweb: http://git.kernel.org/tip/dd2e3121e3cb16d03a6e3f2db48f260f046f39c2 Author: Oleg Nesterov AuthorDate: Sun, 15 Nov 2015 20:33:29 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:48:19 +0100 stop_machine: Shift the

[tip:perf/core] x86: Add an inlined __copy_from_user_nmi() variant

2015-11-23 Thread tip-bot for Andi Kleen
Commit-ID: 10013ebb5d7856c243541870f4e62fed68253e88 Gitweb: http://git.kernel.org/tip/10013ebb5d7856c243541870f4e62fed68253e88 Author: Andi Kleen AuthorDate: Thu, 22 Oct 2015 15:07:20 -0700 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:58:24 +0100 x86: Add an inlined

[tip:sched/core] sched/fair: Modify the comment about lock assumptions in migrate_task_rq_fair()

2015-11-23 Thread tip-bot for Byungchul Park
Commit-ID: 525628c73bd6af65f27d927e699e7460d7d55ed3 Gitweb: http://git.kernel.org/tip/525628c73bd6af65f27d927e699e7460d7d55ed3 Author: Byungchul Park AuthorDate: Wed, 18 Nov 2015 09:34:59 +0900 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:48:20 +0100 sched/fair: Modify the

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-23 Thread Laurent Dufour
On 23/11/2015 16:27, Ming Lei wrote: > On Mon, Nov 23, 2015 at 11:20 PM, Laurent Dufour > wrote: >>> >>> Reverting above commit on top if 4.4-rc1 seems to fix the problem for me. >> >> That's what I mentioned earlier ;) >> >> Now Ming send an additional patch with seems to fix the bug introduced

[tip:sched/core] stop_machine: Make cpu_stop_queue_work() and stop_one_cpu_nowait() return bool

2015-11-23 Thread tip-bot for Oleg Nesterov
Commit-ID: 1b034bd989aa4a396c13d305759c376c52595a97 Gitweb: http://git.kernel.org/tip/1b034bd989aa4a396c13d305759c376c52595a97 Author: Oleg Nesterov AuthorDate: Tue, 17 Nov 2015 18:05:23 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:48:18 +0100 stop_machine: Make

[tip:sched/core] stop_machine: Change __stop_cpus() to rely on cpu_stop_queue_work()

2015-11-23 Thread tip-bot for Oleg Nesterov
Commit-ID: 4aff1ca6970afbf9cd916c34a9c442c8ccba905e Gitweb: http://git.kernel.org/tip/4aff1ca6970afbf9cd916c34a9c442c8ccba905e Author: Oleg Nesterov AuthorDate: Sun, 15 Nov 2015 20:33:23 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:48:19 +0100 stop_machine: Change

Re: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment

2015-11-23 Thread Stanimir Varbanov
On 11/23/2015 12:27 PM, Gabriele Paoloni wrote: > Hi Stanimir, Many Thanks for this fix > >> -Original Message- >> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >> ow...@vger.kernel.org] On Behalf Of Arnd Bergmann >> Sent: 23 November 2015 10:00 >> To: Stanimir Varbanov

[tip:perf/core] perf report: Add callchain value option

2015-11-23 Thread tip-bot for Namhyung Kim
Commit-ID: f2af008695e0b54a58b76caecd52af7e6c97fb29 Gitweb: http://git.kernel.org/tip/f2af008695e0b54a58b76caecd52af7e6c97fb29 Author: Namhyung Kim AuthorDate: Mon, 9 Nov 2015 14:45:41 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 19 Nov 2015 13:19:23 -0300 perf report:

[tip:sched/core] stop_machine: Change stop_one_cpu() to rely on cpu_stop_queue_work()

2015-11-23 Thread tip-bot for Oleg Nesterov
Commit-ID: 958c5f848e17e216df138cc2161b07b7120e2d15 Gitweb: http://git.kernel.org/tip/958c5f848e17e216df138cc2161b07b7120e2d15 Author: Oleg Nesterov AuthorDate: Sun, 15 Nov 2015 20:33:20 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:48:18 +0100 stop_machine: Change

Re: [PATCH] backlight: adp88x0: fix uninitialized variable use

2015-11-23 Thread Lee Jones
On Mon, 23 Nov 2015, Arnd Bergmann wrote: > gcc correctly warns about both the adp8860 and adp8870 backlight > drivers using an uninitialized variable in their error handling > path: > > drivers/video/backlight/adp8870_bl.c: In function > 'adp8870_bl_ambient_light_zone_store': >

[PATCH] mm: fix swapped Movable and Reclaimable in /proc/pagetypeinfo

2015-11-23 Thread Vlastimil Babka
Commit 016c13daa5c9 ("mm, page_alloc: use masks and shifts when converting GFP flags to migrate types") has swapped MIGRATE_MOVABLE and MIGRATE_RECLAIMABLE in the enum definition. However, migratetype_names wasn't updated to reflect that. As a result, the file /proc/pagetypeinfo shows the counts

[tip:sched/core] stop_machine: Fix possible cpu_stopper_thread() crash

2015-11-23 Thread tip-bot for Oleg Nesterov
Commit-ID: 64038f292a1b33c7d46bd11f62f7798101152c00 Gitweb: http://git.kernel.org/tip/64038f292a1b33c7d46bd11f62f7798101152c00 Author: Oleg Nesterov AuthorDate: Sun, 15 Nov 2015 20:33:11 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:48:17 +0100 stop_machine: Fix

[tip:sched/core] sched/core: Use list_is_singular() in sched_can_stop_tick()

2015-11-23 Thread tip-bot for Geliang Tang
Commit-ID: 01783e0d452736d7deff1b920c5eccad67adc428 Gitweb: http://git.kernel.org/tip/01783e0d452736d7deff1b920c5eccad67adc428 Author: Geliang Tang AuthorDate: Sun, 15 Nov 2015 18:18:40 +0800 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:48:17 +0100 sched/core: Use

[tip:sched/core] stop_machine: Don' t disable preemption in stop_two_cpus()

2015-11-23 Thread tip-bot for Oleg Nesterov
Commit-ID: 6a19005157c464b47b2082f2617d12bc11198a0d Gitweb: http://git.kernel.org/tip/6a19005157c464b47b2082f2617d12bc11198a0d Author: Oleg Nesterov AuthorDate: Sun, 15 Nov 2015 20:33:14 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:48:18 +0100 stop_machine: Don't

[tip:sched/core] sched/core: Fix incorrect wait time and wait count statistics

2015-11-23 Thread tip-bot for Joonwoo Park
Commit-ID: 3ea94de15ce9f3a217f6d0a7e9e0f48388902bb7 Gitweb: http://git.kernel.org/tip/3ea94de15ce9f3a217f6d0a7e9e0f48388902bb7 Author: Joonwoo Park AuthorDate: Thu, 12 Nov 2015 19:38:54 -0800 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:48:17 +0100 sched/core: Fix incorrect

[tip:sched/core] sched/fair: Consider missed ticks in NOHZ_FULL in update_cpu_load_nohz()

2015-11-23 Thread tip-bot for Byungchul Park
Commit-ID: 525705d15e63b7455977408e4601e76e6bc41524 Gitweb: http://git.kernel.org/tip/525705d15e63b7455977408e4601e76e6bc41524 Author: Byungchul Park AuthorDate: Tue, 10 Nov 2015 09:36:02 +0900 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:37:53 +0100 sched/fair: Consider

[tip:perf/core] perf/x86: Fix LBR call stack save/restore

2015-11-23 Thread tip-bot for Andi Kleen
Commit-ID: b28ae9560b693bcd2e9f4d6d9c415d5380b7c3c5 Gitweb: http://git.kernel.org/tip/b28ae9560b693bcd2e9f4d6d9c415d5380b7c3c5 Author: Andi Kleen AuthorDate: Tue, 20 Oct 2015 11:46:33 -0700 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:44:57 +0100 perf/x86: Fix LBR call stack

[tip:sched/core] sched/numa: Cap PTE scanning overhead to 3% of run time

2015-11-23 Thread tip-bot for Rik van Riel
Commit-ID: 51170840fe91dfca10fd533b303ea39b2524782a Gitweb: http://git.kernel.org/tip/51170840fe91dfca10fd533b303ea39b2524782a Author: Rik van Riel AuthorDate: Thu, 5 Nov 2015 15:56:23 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:37:54 +0100 sched/numa: Cap PTE

Re: [PATCH v4 2/4] mfd: tps65086: Add driver for the TPS65086 PMIC

2015-11-23 Thread Lee Jones
On Thu, 19 Nov 2015, Andrew F. Davis wrote: > Add support for the TPS65912 device. It provides communication > through I2C and contains the following components: > > - Regulators > - Load switches > - GPO controller > > Signed-off-by: Andrew F. Davis > --- > drivers/mfd/Kconfig |

Re: [PATCH] ARM: dts: rockchip: Add IR receiver to Radxa Rock 2 Square

2015-11-23 Thread Heiko Stübner
Am Montag, 23. November 2015, 15:36:28 schrieb Sjoerd Simons: > Add support for the IR receiver as present on the Radxa Rock 2 Square > board. > > Signed-off-by: Sjoerd Simons applied to my dts32 branch for 4.5. Thanks Heiko -- To unsubscribe from this list: send the line "unsubscribe

[tip:sched/core] sched/rt: Hide the push_irq_work_func() declaration

2015-11-23 Thread tip-bot for Arnd Bergmann
Commit-ID: 89b411081d70fe3772efa4665279293269c1150d Gitweb: http://git.kernel.org/tip/89b411081d70fe3772efa4665279293269c1150d Author: Arnd Bergmann AuthorDate: Thu, 12 Nov 2015 17:19:58 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:25:08 +0100 sched/rt: Hide the

[tip:perf/core] perf hists browser: Factor out hist_browser__show_callchain_list()

2015-11-23 Thread tip-bot for Namhyung Kim
Commit-ID: 18bb838129b08fb0009b1ba1dc2f748a9537ee89 Gitweb: http://git.kernel.org/tip/18bb838129b08fb0009b1ba1dc2f748a9537ee89 Author: Namhyung Kim AuthorDate: Mon, 9 Nov 2015 14:45:42 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 19 Nov 2015 13:19:24 -0300 perf hists

[tip:sched/core] sched/fair: Remove empty idle enter and exit functions

2015-11-23 Thread tip-bot for Dietmar Eggemann
Commit-ID: 38c6ade2dd4dcc3bca06c981e2a1b91289046177 Gitweb: http://git.kernel.org/tip/38c6ade2dd4dcc3bca06c981e2a1b91289046177 Author: Dietmar Eggemann AuthorDate: Tue, 20 Oct 2015 13:04:41 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:37:51 +0100 sched/fair: Remove

[tip:perf/core] perf/core: Robustify the perf_cgroup_from_task() RCU checks

2015-11-23 Thread tip-bot for Stephane Eranian
Commit-ID: 614e4c4ebc75517295bccd29b20ddbc5b52af6fc Gitweb: http://git.kernel.org/tip/614e4c4ebc75517295bccd29b20ddbc5b52af6fc Author: Stephane Eranian AuthorDate: Thu, 12 Nov 2015 11:00:04 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:21:03 +0100 perf/core: Robustify

[tip:x86/apic] x86/smpboot: Re-enable init_udelay= 0 by default on modern CPUs

2015-11-23 Thread tip-bot for Len Brown
Commit-ID: 2fde46b79e2fdbc90d0d97cf992782732b5a371c Gitweb: http://git.kernel.org/tip/2fde46b79e2fdbc90d0d97cf992782732b5a371c Author: Len Brown AuthorDate: Sun, 22 Nov 2015 18:16:15 -0500 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:08:33 +0100 x86/smpboot: Re-enable

[tip:perf/core] perf/core: Fix RCU problem with cgroup context switching code

2015-11-23 Thread tip-bot for Stephane Eranian
Commit-ID: ddaaf4e291dd63db0667991e4a335fcf3a7df13e Gitweb: http://git.kernel.org/tip/ddaaf4e291dd63db0667991e4a335fcf3a7df13e Author: Stephane Eranian AuthorDate: Thu, 12 Nov 2015 11:00:03 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2015 09:21:03 +0100 perf/core: Fix RCU

[tip:perf/core] perf ui/gtk: Support folded callchains

2015-11-23 Thread tip-bot for Namhyung Kim
Commit-ID: 2c6caff2b26fde8f3f87183f8c97f2cebfdbcb98 Gitweb: http://git.kernel.org/tip/2c6caff2b26fde8f3f87183f8c97f2cebfdbcb98 Author: Namhyung Kim AuthorDate: Mon, 9 Nov 2015 14:45:46 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 19 Nov 2015 13:19:26 -0300 perf ui/gtk:

Re: [PATCH] memcg: fix memory.high target

2015-11-23 Thread Johannes Weiner
On Mon, Nov 23, 2015 at 03:22:31PM +0300, Vladimir Davydov wrote: > When the memory.high threshold is exceeded, try_charge() schedules a > task_work to reclaim the excess. The reclaim target is set to the number > of pages requested by try_charge(). This is wrong, because try_charge() > usually

Re: severe regression in alx ethernet driver

2015-11-23 Thread David Miller
From: David Miller Date: Mon, 23 Nov 2015 11:15:30 -0500 (EST) > From: Ldap Tester > Date: Mon, 23 Nov 2015 11:00:08 -0300 > >> https://bugzilla.kernel.org/show_bug.cgi?id=70761 > > Patches sitting in a bugzilla entry will simply rot. > > For upstream inclusion someone must formally submit

[tip:perf/core] perf hists browser: Support flat callchains

2015-11-23 Thread tip-bot for Namhyung Kim
Commit-ID: 4b3a3212233a042f48b7b8fedc64933e1ccd8643 Gitweb: http://git.kernel.org/tip/4b3a3212233a042f48b7b8fedc64933e1ccd8643 Author: Namhyung Kim AuthorDate: Mon, 9 Nov 2015 14:45:43 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 19 Nov 2015 13:19:24 -0300 perf hists

[tip:perf/core] perf ui/gtk: Support flat callchains

2015-11-23 Thread tip-bot for Namhyung Kim
Commit-ID: 3cd99dfd1c87067fb28a19fee76500aed56d7c8f Gitweb: http://git.kernel.org/tip/3cd99dfd1c87067fb28a19fee76500aed56d7c8f Author: Namhyung Kim AuthorDate: Mon, 9 Nov 2015 14:45:45 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 19 Nov 2015 13:19:25 -0300 perf ui/gtk:

Re: [RFC 6/9] iio: ina2xx: add direct IO support for TI INA2xx Power Monitors

2015-11-23 Thread Marc Titinger
On 21/11/2015 19:13, Jonathan Cameron wrote: On 18/11/15 14:38, Marc Titinger wrote: Basic support or direct IO raw read, with averaging attribute. Values are RAW, INT_PLUS_MICRO (Volt/Ampere/Watt). Output of iio_info: iio:device0: ina226 4 channels found: power3:

[PATCH v2] mtd: nand: use of_property_read_u8()

2015-11-23 Thread Saurabh Sengar
use of_property_read_u8() for u8 values Signed-off-by: Saurabh Sengar --- v2 : added the missed semi colon drivers/mtd/nand/orion_nand.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c

<    1   2   3   4   5   6   7   8   9   10   >