> The error return value of platform_get_irq seems to often get dropped.
How do you think about any more fine-tuning here?
Commit message:
* … of the platform_get_irq() function seems to get dropped too often.
* Why do you concentrate on a single function name?
Do you plan to extend this
On Wed, 2015-12-23 at 18:54 +0800, Boqun Feng wrote:
> On Wed, Dec 23, 2015 at 01:40:05PM +1100, Michael Ellerman wrote:
> > On Tue, 2015-12-15 at 22:24 +0800, Boqun Feng wrote:
> > > Hi all,
> > >
> > > This is v6 of the series.
> > >
> > > Link for v1: https://lkml.org/lkml/2015/8/27/798
> > >
On Sat, Dec 26, 2015 at 6:16 PM, Andy Lutomirski wrote:
>>> We could make one of them 31-bits (since even an "allyesconfig" kernel
>>> is still much smaller than a gigabyte) to free a bit for a flag. But there
>>> are those external tools to pre-sort exception tables that would all
>>> need to be
nrs_resource_put_safe() might hold a lock one one struct
while operating on the other.
There are 2 levels of structures.
Use nrs_policy_put(), which has locking baked in.
sparse gives the following warning:
drivers/staging/lustre//lustre/ptlrpc/nrs.c:498:39:
warning: context imbalance in
> >
> > Signed-off-by: Figo Zhang
>
> As you ignored my instructions to you, I'm going to just ignore this patch,
> sorry. Now discarded.
>
I am no at intel kernel group (SSG OTC), I am at CCG CCE. I will involve the
intel open source guys if they like to help.
Hi fengguang:
Would you like
running sparse on drivers/staging/lustre results in dozens of warnings:
include/linux/gfp.h:281:41: warning:
odd constant _Bool cast (40 becomes 1)
Use "!!" to explicitly convert to bool and get rid of the warning.
Signed-off-by: Joshua Clayton
---
On Sunday, December 27, 2015 05:41:17 AM
>Well, looking again, the patch should be good. I just thought its goal was
> to fix the code as well...
I could do that for the irq < 0 case, but I think that in that case, kbuild
will only run the patch version, and the <= cases will not be reported on.
I don't have a general fix for the <=
On Sat, 26 Dec 2015, Joe Perches wrote:
> On Sat, 2015-12-26 at 13:12 -0500, David Miller wrote:
> > IDE is in deep freeze maintainence mode.
> >
> > Therefore patches that perform simplications and cleanups will
> > not be accepted.
>
> Maybe there should be something like a README
> in
On Sat, Dec 26, 2015 at 09:12:42PM -0800, Joshua Clayton wrote:
> running sparse on drivers/staging/lustre results in dozens of warnings:
> include/linux/gfp.h:281:41: warning:
> odd constant _Bool cast (40 becomes 1)
>
> Use "!!" to explicitly convert the result to bool range.
... and the
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
Hi Joshua,
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.4-rc6 next-20151223]
url:
running sparse on drivers/staging/lustre results in dozens of warnings:
include/linux/gfp.h:281:41: warning:
odd constant _Bool cast (40 becomes 1)
Use "!!" to explicitly convert the result to bool range.
---
include/linux/gfp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
nrs_resource_put_safe() might hold a lock one one struct
while operating on the other.
There are 2 levels of structures.
Use nrs_policy_put(), which has locking baked in.
sparse gives the following warning:
drivers/staging/lustre//lustre/ptlrpc/nrs.c:498:39:
warning: context imbalance in
On Sun, Dec 27, 2015 at 05:14:51PM +0800, Figo Zhang wrote:
> Android System UI hang when run heavy monkey stress test.
>
> V2: add more detail about how to re-produce this issue, the
> important is install more than 100 apps/games.
>
> Re-produce step:
> Run this monkey stress test script with
On Sat, Dec 26, 2015 at 6:08 PM, Tony Luck wrote:
> On Sat, Dec 26, 2015 at 6:54 AM, Andy Lutomirski wrote:
>> On Dec 26, 2015 6:33 PM, "Borislav Petkov" wrote:
>>> Andy, why is that? It makes the exception handling much simpler this way...
>>>
>>
>> I like the idea of moving more logic into C,
On Sat, Dec 26, 2015 at 6:15 PM, Andy Lutomirski wrote:
> On Sat, Dec 26, 2015 at 6:08 PM, Tony Luck wrote:
>> On Sat, Dec 26, 2015 at 6:54 AM, Andy Lutomirski wrote:
>>> On Dec 26, 2015 6:33 PM, "Borislav Petkov" wrote:
Andy, why is that? It makes the exception handling much simpler this
On 12/26/15 at 05:31pm, Toshi Kani wrote:
> + cc: kexec list
>
> On 12/26/2015 3:38 AM, Borislav Petkov wrote:
> >On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote:
> >>Change to call walk_iomem_res_desc() for searching resource entries
> >>with the following names:
> >> "ACPI Tables"
>
On Sat, Dec 26, 2015 at 6:54 AM, Andy Lutomirski wrote:
> On Dec 26, 2015 6:33 PM, "Borislav Petkov" wrote:
>> Andy, why is that? It makes the exception handling much simpler this way...
>>
>
> I like the idea of moving more logic into C, but I don't like
> splitting the logic across files and
On Sat, Dec 26, 2015 at 1:51 PM, Serge E. Hallyn
wrote:
> On Sat, Dec 26, 2015 at 03:52:31AM +0100, Jann Horn wrote:
>> ptrace_has_cap() checks whether the current process should be
>> treated as having a certain capability for ptrace checks
>> against another process. Until now, this was
Android System UI hang when run heavy monkey stress test.
V2: add more detail about how to re-produce this issue, the
important is install more than 100 apps/games.
Re-produce step:
Run this monkey stress test script with more than 100
apps/games installed:
adb shell "monkey --ignore-crashes
On Fri, Dec 11, 2015 at 02:39:11AM -0500, Sanidhya Solanki wrote:
> >From c07c57f3e045865b0acae498c631189f24aeda0b Mon Sep 17 00:00:00 2001
> From: Sanidhya Solanki
> Date: Thu, 10 Dec 2015 21:13:10 -0500
> Subject: [PATCH] staging: gdm72xx: Code cleanups
What is all of this in here for?
> Code
On Thu, Dec 24, 2015 at 09:58:27AM +0900, Chanwoo Choi wrote:
> Dear Greg,
>
> This is extcon-next pull request for v4.5. I add detailed description of
> this pull request on below. Please pull extcon with following updates.
>
> Best Regards,
> Chanwoo Choi
>
> The following changes since
On Tue, Dec 22, 2015 at 04:08:33PM +0530, Kishon Vijay Abraham I wrote:
> Hi Greg,
>
> Please find the pull request for 4.5 merge window below. This should be
> my final pull request for 2015 unless you want me to change
> something ;-)
>
> It adds two new PHY drivers, deprecates
On Wed, Dec 23, 2015 at 10:45:56AM -0600, Felipe Balbi wrote:
> Hi Greg,
>
> Here's the large usb gadget pull request for v4.5. Please consider
> merging it to your usb-next branch. We have a total 97 non-merge commits
> this time, so a substantial amount of code. Here's a dirstat to show you
>
On Sun, Dec 27, 2015 at 04:34:56PM +0800, Figo.zhang wrote:
> From: Figo
This doesn't match your signed-off-by name :(
> Signed-off-by: Figo.zhang
I doubt that you have a '.' in your name :(
Again, please consult the Intel Linux kernel group for how to do this
correctly, I will not accept
On 12/25/2015 5:05 PM, Joe Perches wrote:
On Fri, 2015-12-25 at 15:09 -0700, Toshi Kani wrote:
Use of walk_iomem_res() is deprecated in new code. Change
checkpatch.pl to check new use of walk_iomem_res() and suggest
to use walk_iomem_res_desc() instead.
[]
diff --git a/scripts/checkpatch.pl
From: Figo
Android System UI hang when run heavy monkey stress test.
V2: add more detail about how to re-produce this issue, the
important is install more than 100 apps/games.
Re-produce step:
Run this monkey stress test script with more than 100
apps/games installed:
adb shell "monkey
On 12/26/2015 9:05 AM, Minfei Huang wrote:
Ccing kexec maillist.
On 12/25/15 at 03:09pm, Toshi Kani wrote:
diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
index c245085..e2bd737 100644
--- a/kernel/kexec_file.c
+++ b/kernel/kexec_file.c
@@ -522,10 +522,10 @@ int kexec_add_buffer(struct
On Tue, Dec 15, 2015 at 10:10 PM, NeilBrown wrote:
> On Wed, Dec 16 2015, Trond Myklebust wrote:
>
>> On Tue, Dec 15, 2015 at 6:44 PM, NeilBrown wrote:
>>>
>>> Commit: c05eecf63610 ("SUNRPC: Don't allow low priority tasks to pre-empt
>>> higher priority ones")
>>>
>>> removed the 'fair
+ cc: kexec list
On 12/26/2015 3:38 AM, Borislav Petkov wrote:
On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote:
Change to call walk_iomem_res_desc() for searching resource entries
with the following names:
"ACPI Tables"
"ACPI Non-volatile Storage"
"Persistent Memory (legacy)"
From: Figo
Android System UI hang when run heavy monkey stress test.
V2: add more detail about how to re-produce this issue, the
important is install more than 100 apps/games.
Re-produce step:
Run this monkey stress test script with more than 100
apps/games installed:
On Sun, Dec 27, 2015 at 12:19:08AM +, Zhang, Tianfei wrote:
> > Great, please use that, but why does your email address show a different
> > name? Intel has standards that you have to follow when submitting Linux
> > kernel patches, please consult them before you resend.
> >
>
> Hi greg, I
> Great, please use that, but why does your email address show a different
> name? Intel has standards that you have to follow when submitting Linux
> kernel patches, please consult them before you resend.
>
Hi greg, I should resend this patch using [PATCH RESEND v2 1/1]?
On Sat, Dec 26, 2015 at 11:24:14PM +, Zhang, Tianfei wrote:
> > > Android System UI hang when run heavy monkey stress test.
> >
> > What changed from v1 of this patch? Please describe that below the ---
> > line.
> V2，I just modify my comments.
Then say so. How am I supposed to know?
> >
On Sun, Dec 27, 2015 at 12:42:31AM +0100, Harald Arnesen wrote:
> Greg KH [2015-12-26 19:12]:
>
> > I need a "full" name here, not a "short" name, sorry, before I can do
> > anything with this patch.
>
> I don't know if that is the case here, but:
>
> You know, of course, that there are
On Sat, 2015-12-26 at 13:12 -0500, David Miller wrote:
> IDE is in deep freeze maintainence mode.
>
> Therefore patches that perform simplications and cleanups will
> not be accepted.
Maybe there should be something like a README
in drivers/ide that says that.
Maybe the MAINTAINERS entry for
Greg KH [2015-12-26 19:12]:
> I need a "full" name here, not a "short" name, sorry, before I can do
> anything with this patch.
I don't know if that is the case here, but:
You know, of course, that there are societies in this world where only
one name is used?
--
Hilsen Harald
--
To
> > Android System UI hang when run heavy monkey stress test.
>
> What changed from v1 of this patch? Please describe that below the ---
> line.
V2，I just modify my comments.
>
> >
> > Signed-off-by: Figo
>
> I need a "full" name here, not a "short" name, sorry, before I can do anything
>
The value returned by sys_personality has type "long int".
It is saved to a variable of type "int", which is not a problem
yet because the type of task_struct->pesonality is "unsigned int".
The problem is the sign extension from "int" to "long int"
that happens on return from
From: Rafael J. Wysocki
cpufreq_boost_supported() is not used outside of cpufreq.c, so make
it static.
While at it, refactor it as a one-liner (which it really is).
Signed-off-by: Rafael J. Wysocki
---
drivers/cpufreq/cpufreq.c |8 ++--
include/linux/cpufreq.h |5 -
2 files
Hi,
This series cleans up a few things related to the boost sysfs attribute
used by cpufreq.
[1/3] - Make local function static.
[2/3] - Simplify boost-related code in acpi-cpufreq.
[3/3] - Simplify boost-related core code.
Thanks,
Rafael
--
To unsubscribe from this list: send the line
From: Rafael J. Wysocki
Notice that the boost_supported field in struct cpufreq_driver is
redundant, because the driver's ->set_boost callback may be left
unset if "boost" is not supported. Moreover, the only driver
populating the ->set_boost callback is acpi_cpufreq, so make it
avoid
From: Rafael J. Wysocki
The store_boost() routine is only used by store_cpb(), so move
the code from it directly to that function and rename _store_boost()
to set_boost() to make its name reflect the name of the driver
callback pointing to it.
Signed-off-by: Rafael J. Wysocki
---
The ld-version.sh script doesn't handle versions with large (>= 10) 3rd
version components, because the 2nd component is only multiplied by 10
times that of the 3rd component.
For example the following version string:
GNU ld (Codescape GNU Tools 2015.06-05 for MIPS MTI Linux) 2.24.90
gives a
Eric Anholt writes:
> This should be a complete port of bcm2835 functionality to bcm2836
> (Raspberry Pi 2).
>
> Signed-off-by: Eric Anholt
> ---
>
> v2: Implement Arnd's feedback to not split to ARCH_BCM2836, and
> instead use more conditionals in ARCH_BCM2835. Also reduce diff
>
On 12/27/2015 01:32 AM, Julia Lawall wrote:
The error return value of platform_get_irq seems to often get dropped.
Signed-off-by: Julia Lawall
---
v2: Check for the direct return case also. Added some mailing lists of
common offenders.
diff --git
On Sun, 27 Dec 2015, Sergei Shtylyov wrote:
> On 12/26/2015 11:58 PM, Julia Lawall wrote:
>
> > The error return value of platform_get_irq seems to often get dropped.
> >
> > Signed-off-by: Julia Lawall
> >
> > ---
> >
> > v2: Check for the direct return case also. Added some mailing lists
On 12/26/2015 11:58 PM, Julia Lawall wrote:
The error return value of platform_get_irq seems to often get dropped.
Signed-off-by: Julia Lawall
---
v2: Check for the direct return case also. Added some mailing lists of
common offenders.
diff --git
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
expression e1,e2;
statement S1,S2;
@@
+e1 = e2;
if (IS_ERR(
e1
- = e2
)) S1 else S2
//
Signed-off-by: Julia Lawall
---
drivers/usb/mon/mon_text.c |6 --
1 file changed, 4
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
expression e1,e2;
statement S1,S2;
@@
+e1 = e2;
if (IS_ERR(
e1
- = e2
)) S1 else S2
//
---
drivers/usb/mon/mon_text.c |6 --
ipc/mqueue.c |3 ++-
2 files changed, 6
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
expression e1,e2;
statement S1,S2;
@@
+e1 = e2;
if (IS_ERR(
e1
- = e2
)) S1 else S2
//
Signed-off-by: Julia Lawall
---
ipc/mqueue.c |3 ++-
1 file changed, 2 insertions(+), 1
On Sat, Dec 26, 2015 at 03:52:31AM +0100, Jann Horn wrote:
> ptrace_has_cap() checks whether the current process should be
> treated as having a certain capability for ptrace checks
> against another process. Until now, this was equivalent to
> has_ns_capability(current, target_ns,
On Sat, Dec 26, 2015 at 10:27:33PM +0100, Jann Horn wrote:
> On Sat, Dec 26, 2015 at 03:17:29PM -0600, Serge E. Hallyn wrote:
> > On Sat, Dec 26, 2015 at 03:52:31AM +0100, Jann Horn wrote:
> > > ptrace_has_cap() checks whether the current process should be
> > > treated as having a certain
While the 2836 interrupt controller technically works, it would be
nice to merge these improvements to it, adding SMP booting, fixing the
timers, and fixing an apparently-spurious error message.
Patches 1, 2 were seen before in the full Pi 2 series I sent recently,
now with their summary prefixes
From: Andrea Merello
The firmware sets the secondaries spinning waiting for a non-NULL
value to show up in the last IPI mailbox.
The original SMP port from the downstream tree was done by Andrea, and
Eric cleaned it up/rewrote it a few times from there.
Signed-off-by: Andrea Merello
From: Andrea Merello
On my RPi2 I got a lot of:
unexpected IRQ trap at vector 00
This happens because bcm2836_arm_irqchip_handle_irq() is sometimes
invoked even if the ISR is clear, and this case is not handled.
This patch explicitly handle this case, fixing the kernel complaints
about the bad
From: Andrea Merello
Avoid using hardcoded magics. We have a #define for this number.
No functional changes.
Signed-off-by: Andrea Merello
Reviewed-by: Eric Anholt
Signed-off-by: Eric Anholt
---
drivers/irqchip/irq-bcm2836.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The irqchip's register area includes the the setup for the timer's
scaling factors, and for the platform we want a fixed configuration of
these registers.
Signed-off-by: Eric Anholt
---
drivers/irqchip/irq-bcm2836.c | 26 ++
1 file changed, 26 insertions(+)
diff --git
Den 22.12.2015 20:01, skrev Eric Anholt:
After finally booting the RPi2 I get several messages of:
unexpected IRQ trap at vector 00
while typing _one_ character over uart.
We were doing some debugging of that recently. It seems that every once
in a while we get woken up but nothing shows
Hi Linus,
Please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
pm+acpi-4.4-rc7
to receive power management and ACPI fixes for v4.4-rc7 with top-most
commit 43b28ca8dfb07f2faa44204b3b3e7cb016468847
Merge branches 'acpi-processor' and 'pm-cpufreq'
on top of
On Sat, Dec 26, 2015 at 8:58 AM, Sudip Mukherjee
wrote:
> We were getting build warning about "iterator" being used uninitialized.
> Use iterator properly to fix the build warning and in the process remove
> the variable "pos" which is not required now.
>
> Signed-off-by: Sudip Mukherjee
Aha
On Sat, Dec 26, 2015 at 03:17:29PM -0600, Serge E. Hallyn wrote:
> On Sat, Dec 26, 2015 at 03:52:31AM +0100, Jann Horn wrote:
> > ptrace_has_cap() checks whether the current process should be
> > treated as having a certain capability for ptrace checks
> > against another process. Until now, this
From: Markus Elfring
Date: Sat, 26 Dec 2015 22:18:38 +0100
This issue was detected by using the Coccinelle software.
* Let us return directly if a call of the _ocrdma_alloc_pd()
function failed.
* Reduce the scope for the local variable "status" to one case
of an if statement.
* Delete
On Sat, Dec 26, 2015 at 03:52:31AM +0100, Jann Horn wrote:
> ptrace_has_cap() checks whether the current process should be
> treated as having a certain capability for ptrace checks
> against another process. Until now, this was equivalent to
> has_ns_capability(current, target_ns,
I'll be sending pull-requests to Florian soon, but I would like to get
my trees included in linux-next to get increased testing coverage of
them against everything else going on for 4.5. I'm expecting to produce
trees under these branch names for the forseeable future.
Repo:
On Sat, Dec 26, 2015 at 09:55:50PM +0100, Jann Horn wrote:
> On Sat, Dec 26, 2015 at 02:23:45PM -0600, Serge E. Hallyn wrote:
> > On Sat, Dec 26, 2015 at 02:10:38AM +0100, Jann Horn wrote:
> > > On Sat, Dec 12, 2015 at 09:12:41PM +0100, Jann Horn wrote:
> > > > With this change, the entering
The error return value of platform_get_irq seems to often get dropped.
Signed-off-by: Julia Lawall
---
v2: Check for the direct return case also. Added some mailing lists of
common offenders.
diff --git a/scripts/coccinelle/api/platform_get_irq_return.cocci
On Sat, Dec 26, 2015 at 02:23:45PM -0600, Serge E. Hallyn wrote:
> On Sat, Dec 26, 2015 at 02:10:38AM +0100, Jann Horn wrote:
> > On Sat, Dec 12, 2015 at 09:12:41PM +0100, Jann Horn wrote:
> > > With this change, the entering process can first enter the
> > > namespace and then safely inspect the
On Sat, 26 Dec 2015, Sergei Shtylyov wrote:
> On 12/26/2015 11:24 PM, Julia Lawall wrote:
>
> > The conclusion seems to be that it is useful to override the value, so we
> > can just drop this semantic patch.
>
>No! As I said, unconditionally overriding an error value breaks the
>
On 12/26/2015 11:24 PM, Julia Lawall wrote:
The conclusion seems to be that it is useful to override the value, so we
can just drop this semantic patch.
No! As I said, unconditionally overriding an error value breaks the
deferred probing. It's actually a bug to override it, so the patch
The conclusion seems to be that it is useful to override the value, so we
can just drop this semantic patch.
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Sat, Dec 26, 2015 at 02:10:38AM +0100, Jann Horn wrote:
> On Sat, Dec 12, 2015 at 09:12:41PM +0100, Jann Horn wrote:
> > With this change, the entering process can first enter the
> > namespace and then safely inspect the namespace's
> > properties, e.g. through /proc/self/{uid_map,gid_map},
>
On 12/26/2015 11:07 PM, Julia Lawall wrote:
diff --git a/drivers/net/ethernet/ti/cpsw.c
b/drivers/net/ethernet/ti/cpsw.c
index 3409e80..6a76992 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform_device
On Sat, 26 Dec 2015, Sergei Shtylyov wrote:
> On 12/26/2015 10:24 PM, Julia Lawall wrote:
>
> > The error return value of platform_get_irq seems to often get dropped.
>
>Maybe it was intentional (see my recent follow-up to your netdev patch).
> But if an error gets unconditionally
On Sat, 26 Dec 2015, Sergei Shtylyov wrote:
> Hello.
>
> On 12/26/2015 08:50 PM, Sergei Shtylyov wrote:
>
> > > > > diff --git a/drivers/net/ethernet/ti/cpsw.c
> > > > > b/drivers/net/ethernet/ti/cpsw.c
> > > > > index 3409e80..6a76992 100644
> > > > > --- a/drivers/net/ethernet/ti/cpsw.c
> > >
On 12/26/2015 10:24 PM, Julia Lawall wrote:
The error return value of platform_get_irq seems to often get dropped.
Maybe it was intentional (see my recent follow-up to your netdev patch).
But if an error gets unconditionally overriden, deferred probing can't work.
So your patches seem
Hello.
On 12/26/2015 08:50 PM, Sergei Shtylyov wrote:
diff --git a/drivers/net/ethernet/ti/cpsw.c
b/drivers/net/ethernet/ti/cpsw.c
index 3409e80..6a76992 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -2448,8 +2448,10 @@ static int cpsw_probe(struct
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
Hi Markus,
[auto build test WARNING on v4.4-rc6]
[also build test WARNING on next-20151223]
url:
The error return value of platform_get_irq seems to often get dropped.
Signed-off-by: Julia Lawall
---
scripts/coccinelle/api/platform_get_irq_return.cocci | 53 ++
1 file changed, 53 insertions(+)
diff --git a/scripts/coccinelle/api/platform_get_irq_return.cocci
>> I would appreciate if an unnecessary function call can be avoided here
>> so that the affected exception handling can become also a bit more efficient.
>
> Simpler code is easier to maintain.
There are different opinions available around the desired simplicity.
> See your patch, you didn't
Propagate the return value of platform_get_irq on failure.
A simplified version of the semantic match that finds the two cases where
no error code is returned at all is as follows:
(http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return
From: Markus Elfring
Date: Sat, 26 Dec 2015 19:09:23 +0100
1. Return zero in one case directly.
2. Return the value from a call of the _ocrdma_dealloc_pd() function
without using an extra assignment for the local variable.
3. Remove the variable "status" in this function then.
On Sat 2015-12-26 00:32:25, Pali Rohár wrote:
> Driver for omap3 with documentation is there since v4.4-rc1.
>
> Signed-off-by: Pali Rohár
Acked-by: Pavel Machek
Tested-by: Pavel Machek
Thanks!
Pavel
--
(english)
From: Markus Elfring
Date: Sat, 26 Dec 2015 18:54:47 +0100
Return constant integer values without storing them in the local
variable "status".
Signed-off-by: Markus Elfring
---
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff
From: Markus Elfring
Date: Sat, 26 Dec 2015 18:40:43 +0100
Return the value from a call of the ocrdma_mbx_modify_qp() function
without using an extra assignment for the local variable "status".
Signed-off-by: Markus Elfring
---
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +---
1 file
From: Markus Elfring
Date: Sat, 26 Dec 2015 18:28:35 +0100
Return zero at the end without using the local variable "status".
Signed-off-by: Markus Elfring
---
drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
From: Markus Elfring
Date: Sat, 26 Dec 2015 18:18:18 +0100
The variable "status" will be set to an appropriate value a bit later.
Thus let us omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/infiniband/hw/ocrdma/ocrdma_ah.c| 2 +-
From: Markus Elfring
Date: Sat, 26 Dec 2015 17:16:00 +0100
This issue was detected by using the Coccinelle software.
* Let us return directly if a call of the _ocrdma_alloc_pd()
function failed.
* Delete the jump label "err" and the local variable "status" then.
Signed-off-by: Markus
On Sat, Dec 26, 2015 at 09:52:11AM +0100, SF Markus Elfring wrote:
> >> The kfree() function was called in one case by the
> >> acpi_i2c_space_handler() function during error handling
> >> even if the passed variable "client" contained a null pointer.
> >
> > This is OK. kfree() is known to be
From: Markus Elfring
Date: Sat, 26 Dec 2015 19:30:54 +0100
Several update suggestions were taken into account
from static source code analysis.
Markus Elfring (6):
One variable and jump label less in ocrdma_alloc_ucontext_pd()
Delete unnecessary variable initialisations in 11 functions
Document the start and size fields (which were introduced in commit
v2.5.42-215-gb288f6a) to avoid guesswork on the unit.
Signed-off-by: Peter Wu
---
Hi,
As the meaning has not changed for over 13 years, I would like to
formalize these attributes such that users can rely on it[1][2].
The sector
On Sat 2015-12-26 00:37:16, Pali Rohár wrote:
> Property names do not match real names needed by driver itself.
> This patch fix this problem.
>
> Signed-off-by: Pali Rohár
Acked-by: Pavel Machek
Now... if someone could convert adp1653 to the LED subsystem so this
is testable from the
On Sat 2015-12-26 00:40:12, Pali Rohár wrote:
> This patch adds adp1653 device into n900 DT structure. DT support in
> adp1653 driver is there since v4.2-rc1 version.
>
> Signed-off-by: Pali Rohár
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
This is an API consolidation only. The use of kmalloc + memset to 0
here should be equivalent to kzalloc.
Signed-off-by: Nicholas Mc Guire
---
Found by coccinelle script (relaxed version of
scripts/coccinelle/api/alloc/kzalloc-simple.cocci)
Patch was compile tested with: x86_64_defconfig
On Sun, Dec 27, 2015 at 03:39:42AM +0800, Figo wrote:
> Android System UI hang when run heavy monkey stress test.
What changed from v1 of this patch? Please describe that below the ---
line.
>
> Signed-off-by: Figo
I need a "full" name here, not a "short" name, sorry, before I can do
IDE is in deep freeze maintainence mode.
Therefore patches that perform simplications and cleanups will
not be accepted.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On 12/26/2015 8:40 PM, Julia Lawall wrote:
diff --git a/drivers/net/ethernet/ti/cpsw.c
b/drivers/net/ethernet/ti/cpsw.c
index 3409e80..6a76992 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform_device
> > diff --git a/drivers/net/ethernet/ti/cpsw.c
> > b/drivers/net/ethernet/ti/cpsw.c
> > index 3409e80..6a76992 100644
> > --- a/drivers/net/ethernet/ti/cpsw.c
> > +++ b/drivers/net/ethernet/ti/cpsw.c
> > @@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform_device *pdev)
> >
> > /* RX
Hello.
On 12/26/2015 6:28 PM, Julia Lawall wrote:
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return
Hello.
We are upgrading to the 4.1.x kernel for our smart metering appliance
project, which is based on TI's Sitara hardware (AM335x SoC), and I
decided to switch from omap-serial legacy driver to the newer
8250-based one. It marginally increases throughput efficiency, CPU
cycle wise, among other
All new 32-bit architectures should have 64-bit off_t type, but existing
architectures has 32-bit ones.
To handle it, new config option is added to arch/Kconfig that defaults
ARCH_32BIT_OFF_T to be disabled by default. All existing 32-bit architectures
enable it explicitly here.
New option
1 - 100 of 328 matches
Mail list logo
