Nokia N900: Proper C-states

Hello, due to this Daniel Lezcano commit (ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table) https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=231900afba52d6faddfb480cde4132d4edc089bc we need patch cpuidle34xx.c code to fix commit for Nokia N900. See:

Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access

On Sat, Jan 02, 2016 at 12:19:52AM +0100, Arnd Bergmann wrote: > - if (i2c_client->dev.of_node) { > + if (IS_ENABLED(CONFIG_OF) && i2c_client->dev.of_node) { This would be a lot nicer if there was an __always_null annotation we could put on of_node for !OF configurations,

Nokia N900: twl4030-power different data in DTS and board code

Hello, now I'm looking at differences between legacy board code and DTS file for Nokia N900 and I see some inconsistency for twl4030-power driver. In board code are defined more twl4030 power scripts which override defaults defined in twl4030-power code. See:

Re: [PATCH 1/1] video: ARM CLCD: Add the framebuffer parameters setting in probe

On Wed, Dec 30, 2015 at 08:38:48AM +0800, Rongjun Ying wrote: > This patch fixes the user space applications can't get the framebuffer > parameters, if disable the fb console feature. > > Signed-off-by: Rongjun Ying I think this behaviour is intentional: userspace is expected to set the initial

Re: GPF in shm_lock ipc

On Sat, Jan 2, 2016 at 12:33 PM, Manfred Spraul wrote: > Hi Dmitry, > > shm locking differs too much from msg/sem locking, I never looked at it in > depth, so I'm not able to perform a proper review. > > Except for the obvious: Races that can be triggered from user space are > inacceptable. >

[PATCH] ipc/sem.c: Fix complex_count vs. simple op race

Commit 6d07b68ce16a ("ipc/sem.c: optimize sem_lock()") introduced a race: sem_lock has a fast path that allows parallel simple operations. There are two reasons why a simple operation cannot run in parallel: - a non-simple operations is ongoing (sma->sem_perm.lock held) - a complex operation is

Re: [PATCH] BTRFS: Adds the files and options needed for Hybrid Storage

On Sat, 02 Jan 2016 12:40:46 +0100 Martin Steigerwald wrote: > Or is this something different? Yes, Martin this patch starts the implementation that I hope will lead to the implementation of a Hybrid Cache to the BTRFS. However, there is no need to limit ourselves to just Flash devices.

Re: cgroup: BUG: unable to handle kernel NULL pointer dereference

On Fri, Jan 01, 2016 at 03:40:28PM -0800, Jeremiah Mahler wrote: > all, > > When running the latest linux-next (20151231) two of my machines > hang early in the boot sequence. The initial message is for a > NULL pointer dereference. > > BUG: unable to handle kernel NULL pointer dereference at

Re: CGroup Namespaces (v8)

On Fri, Jan 01, 2016 at 11:14:14AM -0800, Dan Williams wrote: > On Fri, Jan 1, 2016 at 10:06 AM, Serge E. Hallyn > wrote: > > On Fri, Jan 01, 2016 at 01:42:57AM -0800, Dan Williams wrote: > >> Commit 54b39d263704 "cgroup: cgroup namespace setns support" not > >> booting is a separate issue. > > >

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 12/25/2015 08:40 AM, Herbert Xu wrote: > Dmitry Vyukov wrote: >> >> I am testing with your two patches: >> crypto: algif_skcipher - Use new skcipher interface >> crypto: algif_skcipher - Require setkey before accept(2) >> on top of a88164345b81292b55a8d4829fdd35c8d611cd7d (Dec 23). > > You

Re: [PATCH 1/5] nbd: Fix debugfs error handling

-handling/20160102-182030 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next coccinelle warnings: (new ones prefixed by >>) >> drivers/block/nbd.c:937:2-26: WARNING: NULL check before freeing functions >> like kfree, debugfs_remove, debugf

[PATCH] nbd: fix ifnullfree.cocci warnings

drivers/block/nbd.c:937:2-26: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/block/nbd.c:918:2-26: WARNING: NULL check before freeing

Re: [PATCH, RESEND] ipc/shm: handle removed segments gracefully in shm_mmap()

On 11/13/2015 08:23 PM, Davidlohr Bueso wrote: So considering EINVAL, even your approach to bumping up nattach by calling _shm_open earlier isn't enough. Races exposed to user called rmid can still occur between dropping the lock and doing ->mmap(). Ultimately this leads to all

Re: [PATCH v4 2/2] virtio_balloon: Use a workqueue instead of "vballoon" kthread

Hello, On Fri, Jan 01, 2016 at 12:18:17PM +0200, Michael S. Tsirkin wrote: > > My initial idea was to use a dedicated workqueue. Michael S. Tsirkin > > suggested using a system one. Tejun Heo confirmed that the system > > workqueue has a pretty high concurrency level (256) by default. > >

Re: [PATCH] BTRFS: Adds the files and options needed for Hybrid Storage

Hello, Am Freitag, 1. Januar 2016, 22:08:32 CET schrieb Sanidhya Solanki: > This patch adds the file required for Hybrid Storage. It contains > the memory, time and size limits for the cache and the statistics that > will be provided while the cache is operating. > It also adds the Makefile

Re: GPF in shm_lock ipc

Hi Dmitry, shm locking differs too much from msg/sem locking, I never looked at it in depth, so I'm not able to perform a proper review. Except for the obvious: Races that can be triggered from user space are inacceptable. Regardless if there is a BUG_ON, a WARN_ON or nothing at all. On

Re: [PATCH v2 17/32] arm: define __smp_xxx

On Thu, Dec 31, 2015 at 09:07:59PM +0200, Michael S. Tsirkin wrote: > This defines __smp_xxx barriers for arm, > for use by virtualization. > > smp_xxx barriers are removed as they are > defined correctly by asm-generic/barriers.h > > This reduces the amount of arch-specific boiler-plate code. >

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

> I have never seen much evolution going on in this area. I can get an other impression from a specific document for example. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle > What the patch tries to do is avoid the extra 'if (err)'. Yes. - I

Re: [PATCH v2 08/32] arm: reuse asm-generic/barrier.h

On Thu, Dec 31, 2015 at 09:06:46PM +0200, Michael S. Tsirkin wrote: > On arm smp_store_mb, read_barrier_depends, smp_read_barrier_depends, > smp_store_release, smp_load_acquire, smp_mb__before_atomic and > smp_mb__after_atomic match the asm-generic variants exactly. Drop the > local definitions

Re: [Question about DMA] Consistent memory?

On Thu, Dec 31, 2015 at 11:57:55PM +0900, Masahiro Yamada wrote: > [1] DMA-coherent buffers > > Allocate buffers with dma_alloc_coherent() > and just have access to the buffers without cache synchronization. > > There is no need to call dma_sync_single_for_*(). dma_sync_single_for_*() is part

Re: [Question about DMA] Consistent memory?

On Thu, Dec 31, 2015 at 04:50:54PM +0900, Masahiro Yamada wrote: > Hi. > > I am new to the Linux DMA APIs. > > First, I started by reading Documentation/DMA-API.txt, > but I am confused with the term "consistent memory". Just read "coherent memory" instead - the documentation confusingly uses

Re: [PATCH] arm: kernel: utilize hrtimer based broadcast

On Tue, Dec 29, 2015 at 02:54:10PM +0100, Thomas Gleixner wrote: > On Mon, 28 Dec 2015, Arnd Bergmann wrote: > > > On Monday 28 December 2015 07:18:58 Huan Wang wrote: > > > Hi, Arnd, > > > > > > Could you help to review the following patch? Thanks. > > > > > > > Hi Alison, > > > > I'm

Re: [PATCH 2/4] irqchip: bcm2836: Add SMP support for the 2836

On Sat, Dec 26, 2015 at 01:47:22PM -0800, Eric Anholt wrote: > +int __init bcm2836_smp_boot_secondary(unsigned int cpu, > + struct task_struct *idle) > +{ > + unsigned long secondary_startup_phys = > + (unsigned long)virt_to_phys((void

[PATCH 2/5] nbd: Remove signal usage

As discussed on the mailing list, the usage of signals for timeout handling has a lot of potential issues. The nbd driver used for some time signals for timeouts. These signals where able to get the threads out of the blocking socket operations. This patch removes all signal usage and uses a

[PATCH 4/5] nbd: Cleanup reset of nbd and bdev after a disconnect

Group all variables that are reset after a disconnect into reset functions. This patch adds two of these functions, nbd_reset() and nbd_bdev_reset(). Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 40 +--- 1 file changed, 29 insertions(+), 11

[PATCH 5/5] nbd: Move flag parsing to a function

nbd changes properties of the blockdevice depending on flags that were received. This patch moves this flag parsing into a separate function nbd_parse_flags(). Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-)

[PATCH 1/5] nbd: Fix debugfs error handling

Static checker complains about the implemented error handling. It is indeed wrong. We don't care about the return values of created debugfs files. We only have to check the return values of created dirs for NULL pointer. If we use a null pointer as parent directory for files, this may lead to

[PULL] NBD changes

Hi Jens, This pull request contains 5 patches which are mainly cleanups. Patch 1 fixes some unnecessarily complicated code I introduced some versions ago for debugfs. Patch 2 removes the criticised signal usage within NBD to kill the NBD threads after a timeout. This code was used for the last

[PATCH 3/5] nbd: Timeouts are not user requested disconnects

It may be useful to know in the client that a connection timed out. The current code returns success for a timeout. This patch reports the error code -ETIMEDOUT for a timeout. Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 02-01-16 10:08, SF Markus Elfring wrote: >>> I assume that a software development taste can evolve, can't it? >> >> So far, you have gotten several down votes for this kind of change, > > I am curious when more contributors will share corresponding opinions. Let's burn some cycles on this

Re: [PATCH] ACPI / OSL: Add kerneldoc comments to memory mapping functions

On 2 January 2016 at 03:10, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Add kerneldoc comments to acpi_os_map_iomem() and acpi_os_unmap_iomem() > and explain why the latter needs the __ref annotation in one of them > (as suggested by Mathias Krause). > > Signed-off-by: Rafael J.

Re: [PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2)

Am Freitag, 1. Januar 2016, 21:12:40 schrieb Stephan Mueller: Hi Herbert, > Am Mittwoch, 30. Dezember 2015, 11:47:53 schrieb Herbert Xu: > > Hi Herbert, > > > On Tue, Dec 29, 2015 at 07:36:14PM +0100, Dmitry Vyukov wrote: > > > Hello, > > > > > > On commit

Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

В Fri, 01 Jan 2016 22:53:33 +0100 Arnd Bergmann пишет: > On Friday 01 January 2016 20:32:30 Roman Volkov wrote: > > > Applied both to next/dt, thanks a lot for following up! > > > > > > Let me know if you think this should go into stable backports as > > > well, I did not apply it to the fixes

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

>> I assume that a software development taste can evolve, can't it? > > So far, you have gotten several down votes for this kind of change, I am curious when more contributors will share corresponding opinions. > and no enthusiasm. How many software designers and developers can become

Re: [PATCH] net-brcmfmac: Delete an unnecessary variable initialisation in brcmf_sdio_download_firmware()

On 01/01/2016 08:26 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 1 Jan 2016 20:20:15 +0100 I think it has been said over and over, but please use driver name only as prefix. I don't see value to prepend it with 'net-'. Omit explicit initialisation at the beginning for one

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

On Sat, 2 Jan 2016, SF Markus Elfring wrote: > >> Move the jump label directly before the desired log statement > >> so that the variable "err" will not be checked once more > >> after it was determined that a function call failed. > >> Use the identifier "report_failure" instead of the label

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

>> Move the jump label directly before the desired log statement >> so that the variable "err" will not be checked once more >> after it was determined that a function call failed. >> Use the identifier "report_failure" instead of the label "err". > >Why? I suggest to reconsider the places

Re: [PATCH] ACPI / OSL: Add kerneldoc comments to memory mapping functions

On 2 January 2016 at 03:10, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Add kerneldoc comments to acpi_os_map_iomem() and acpi_os_unmap_iomem() > and explain why the latter needs the __ref annotation in one of them > (as suggested by

[PULL] NBD changes

Hi Jens, This pull request contains 5 patches which are mainly cleanups. Patch 1 fixes some unnecessarily complicated code I introduced some versions ago for debugfs. Patch 2 removes the criticised signal usage within NBD to kill the NBD threads after a timeout. This code was used for the last

[PATCH 5/5] nbd: Move flag parsing to a function

nbd changes properties of the blockdevice depending on flags that were received. This patch moves this flag parsing into a separate function nbd_parse_flags(). Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 22 +- 1 file changed, 13

[PATCH 1/5] nbd: Fix debugfs error handling

Static checker complains about the implemented error handling. It is indeed wrong. We don't care about the return values of created debugfs files. We only have to check the return values of created dirs for NULL pointer. If we use a null pointer as parent directory for files, this may lead to

[PATCH 2/5] nbd: Remove signal usage

As discussed on the mailing list, the usage of signals for timeout handling has a lot of potential issues. The nbd driver used for some time signals for timeouts. These signals where able to get the threads out of the blocking socket operations. This patch removes all signal usage and uses a

[PATCH 4/5] nbd: Cleanup reset of nbd and bdev after a disconnect

Group all variables that are reset after a disconnect into reset functions. This patch adds two of these functions, nbd_reset() and nbd_bdev_reset(). Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 40 +--- 1 file changed, 29

[PATCH 3/5] nbd: Timeouts are not user requested disconnects

It may be useful to know in the client that a connection timed out. The current code returns success for a timeout. This patch reports the error code -ETIMEDOUT for a timeout. Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 9 ++--- 1 file changed, 6

Re: [Question about DMA] Consistent memory?

On Thu, Dec 31, 2015 at 04:50:54PM +0900, Masahiro Yamada wrote: > Hi. > > I am new to the Linux DMA APIs. > > First, I started by reading Documentation/DMA-API.txt, > but I am confused with the term "consistent memory". Just read "coherent memory" instead - the documentation confusingly uses

Re: [PATCH v4 2/2] virtio_balloon: Use a workqueue instead of "vballoon" kthread

Hello, On Fri, Jan 01, 2016 at 12:18:17PM +0200, Michael S. Tsirkin wrote: > > My initial idea was to use a dedicated workqueue. Michael S. Tsirkin > > suggested using a system one. Tejun Heo confirmed that the system > > workqueue has a pretty high concurrency level (256) by default. > >

Re: [PATCH 1/1] video: ARM CLCD: Add the framebuffer parameters setting in probe

On Wed, Dec 30, 2015 at 08:38:48AM +0800, Rongjun Ying wrote: > This patch fixes the user space applications can't get the framebuffer > parameters, if disable the fb console feature. > > Signed-off-by: Rongjun Ying I think this behaviour is intentional: userspace is expected

Re: [Question about DMA] Consistent memory?

On Thu, Dec 31, 2015 at 11:57:55PM +0900, Masahiro Yamada wrote: > [1] DMA-coherent buffers > > Allocate buffers with dma_alloc_coherent() > and just have access to the buffers without cache synchronization. > > There is no need to call dma_sync_single_for_*(). dma_sync_single_for_*() is part

Re: CGroup Namespaces (v8)

On Fri, Jan 01, 2016 at 11:14:14AM -0800, Dan Williams wrote: > On Fri, Jan 1, 2016 at 10:06 AM, Serge E. Hallyn > wrote: > > On Fri, Jan 01, 2016 at 01:42:57AM -0800, Dan Williams wrote: > >> Commit 54b39d263704 "cgroup: cgroup namespace setns support" not > >> booting

[PATCH] ipc/sem.c: Fix complex_count vs. simple op race

Commit 6d07b68ce16a ("ipc/sem.c: optimize sem_lock()") introduced a race: sem_lock has a fast path that allows parallel simple operations. There are two reasons why a simple operation cannot run in parallel: - a non-simple operations is ongoing (sma->sem_perm.lock held) - a complex operation is

Nokia N900: twl4030-power different data in DTS and board code

Hello, now I'm looking at differences between legacy board code and DTS file for Nokia N900 and I see some inconsistency for twl4030-power driver. In board code are defined more twl4030 power scripts which override defaults defined in twl4030-power code. See:

Nokia N900: Adjust MPU OPP values

Hello, MPU OPP table table (omap36xx_vddcore_volt_data) defined in opp3xxx_data.c does not match Nokia N900 phone. For a long time we have dirty patch in linux-n900 tree for it, see: https://github.com/pali/linux-n900/commit/4644c5801d7469e2be01d847c61df3d934dadd8c Now when doing transition to

[PATCH 0/3] net-rsi: Fine-tuning for two function implementations

From: Markus Elfring Date: Sat, 2 Jan 2016 15:36:25 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Delete unnecessary variable

Charity Donation

Hi, My name is Jeffrey Skoll, a philanthropist and the founder of one of the largest private foundations in the world. I believe strongly in ‘giving while living.’ I had one idea that never changed in my mind — that you should use your wealth to help people and I have decided to secretly give

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 01/02/2016 12:52 PM, Milan Broz wrote: > On 12/25/2015 08:40 AM, Herbert Xu wrote: >> Dmitry Vyukov wrote: >>> >>> I am testing with your two patches: >>> crypto: algif_skcipher - Use new skcipher interface >>> crypto: algif_skcipher - Require setkey before accept(2) >>> on

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

>> Move the jump label directly before the desired log statement >> so that the variable "err" will not be checked once more >> after it was determined that a function call failed. >> Use the identifier "report_failure" instead of the label "err". > >Why? I suggest to reconsider the places

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

> I have never seen much evolution going on in this area. I can get an other impression from a specific document for example. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle > What the patch tries to do is avoid the extra 'if (err)'. Yes. - I

Re: [PATCH v2 08/32] arm: reuse asm-generic/barrier.h

On Thu, Dec 31, 2015 at 09:06:46PM +0200, Michael S. Tsirkin wrote: > On arm smp_store_mb, read_barrier_depends, smp_read_barrier_depends, > smp_store_release, smp_load_acquire, smp_mb__before_atomic and > smp_mb__after_atomic match the asm-generic variants exactly. Drop the > local definitions

Re: GPF in shm_lock ipc

Hi Dmitry, shm locking differs too much from msg/sem locking, I never looked at it in depth, so I'm not able to perform a proper review. Except for the obvious: Races that can be triggered from user space are inacceptable. Regardless if there is a BUG_ON, a WARN_ON or nothing at all. On

Re: [PATCH] BTRFS: Adds the files and options needed for Hybrid Storage

Hello, Am Freitag, 1. Januar 2016, 22:08:32 CET schrieb Sanidhya Solanki: > This patch adds the file required for Hybrid Storage. It contains > the memory, time and size limits for the cache and the statistics that > will be provided while the cache is operating. > It also adds the Makefile

Re: cgroup: BUG: unable to handle kernel NULL pointer dereference

On Fri, Jan 01, 2016 at 03:40:28PM -0800, Jeremiah Mahler wrote: > all, > > When running the latest linux-next (20151231) two of my machines > hang early in the boot sequence. The initial message is for a > NULL pointer dereference. > > BUG: unable to handle kernel NULL pointer dereference at

Nokia N900: Broken lirc ir-rx51 driver

Hello, due to this commit (ARM: OMAP2+: Disable code that currently does not work with multiplaform) https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/media/rc/Kconfig?id=a62a6e98c370ccca37d353a5f763b532411a4c14 lirc driver for Nokia N900 (ir-rx51) cannot be enabled

[PATCH 3/3] rsi: Replace variable initialisations by assignments in rsi_send_data_pkt()

From: Markus Elfring Date: Sat, 2 Jan 2016 15:25:34 +0100 Replace explicit initialisation for two local variables at the beginning by assignments. Signed-off-by: Markus Elfring --- drivers/net/wireless/rsi/rsi_91x_pkt.c | 10

Re: [PATCH] arm: kernel: utilize hrtimer based broadcast

On Tue, Dec 29, 2015 at 02:54:10PM +0100, Thomas Gleixner wrote: > On Mon, 28 Dec 2015, Arnd Bergmann wrote: > > > On Monday 28 December 2015 07:18:58 Huan Wang wrote: > > > Hi, Arnd, > > > > > > Could you help to review the following patch? Thanks. > > > > > > > Hi Alison, > > > > I'm

[PATCH] nbd: fix ifnullfree.cocci warnings

drivers/block/nbd.c:937:2-26: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/block/nbd.c:918:2-26: WARNING: NULL check before freeing

Re: [PATCH 1/5] nbd: Fix debugfs error handling

-handling/20160102-182030 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next coccinelle warnings: (new ones prefixed by >>) >> drivers/block/nbd.c:937:2-26: WARNING: NULL check before freeing functions >> like kfree, debugfs_remove, debugf

Re: [PATCH] BTRFS: Adds the files and options needed for Hybrid Storage

On Sat, 02 Jan 2016 12:40:46 +0100 Martin Steigerwald wrote: > Or is this something different? Yes, Martin this patch starts the implementation that I hope will lead to the implementation of a Hybrid Cache to the BTRFS. However, there is no need to limit ourselves to just

Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access

On Sat, Jan 02, 2016 at 12:19:52AM +0100, Arnd Bergmann wrote: > - if (i2c_client->dev.of_node) { > + if (IS_ENABLED(CONFIG_OF) && i2c_client->dev.of_node) { This would be a lot nicer if there was an __always_null annotation we could put on of_node for !OF configurations,

Re: [PATCH v3 RESEND 0/2] WM8505/WM8650 DT fixes for SD card controller

В Fri, 01 Jan 2016 22:53:33 +0100 Arnd Bergmann пишет: > On Friday 01 January 2016 20:32:30 Roman Volkov wrote: > > > Applied both to next/dt, thanks a lot for following up! > > > > > > Let me know if you think this should go into stable backports as > > > well, I did not apply

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 02-01-16 10:08, SF Markus Elfring wrote: >>> I assume that a software development taste can evolve, can't it? >> >> So far, you have gotten several down votes for this kind of change, > > I am curious when more contributors will share corresponding opinions. Let's burn some cycles on this

Re: [PATCH, RESEND] ipc/shm: handle removed segments gracefully in shm_mmap()

On 11/13/2015 08:23 PM, Davidlohr Bueso wrote: So considering EINVAL, even your approach to bumping up nattach by calling _shm_open earlier isn't enough. Races exposed to user called rmid can still occur between dropping the lock and doing ->mmap(). Ultimately this leads to all

Nokia N900: Proper C-states

Hello, due to this Daniel Lezcano commit (ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table) https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=231900afba52d6faddfb480cde4132d4edc089bc we need patch cpuidle34xx.c code to fix commit for Nokia N900. See:

Re: [PATCH] net-brcmfmac: Delete an unnecessary variable initialisation in brcmf_sdio_download_firmware()

On 01/01/2016 08:26 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 1 Jan 2016 20:20:15 +0100 I think it has been said over and over, but please use driver name only as prefix. I don't see value to prepend it with 'net-'. Omit explicit

Re: [PATCH v2 17/32] arm: define __smp_xxx

On Thu, Dec 31, 2015 at 09:07:59PM +0200, Michael S. Tsirkin wrote: > This defines __smp_xxx barriers for arm, > for use by virtualization. > > smp_xxx barriers are removed as they are > defined correctly by asm-generic/barriers.h > > This reduces the amount of arch-specific boiler-plate code. >

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 12/25/2015 08:40 AM, Herbert Xu wrote: > Dmitry Vyukov wrote: >> >> I am testing with your two patches: >> crypto: algif_skcipher - Use new skcipher interface >> crypto: algif_skcipher - Require setkey before accept(2) >> on top of a88164345b81292b55a8d4829fdd35c8d611cd7d

Re: GPF in shm_lock ipc

On Sat, Jan 2, 2016 at 12:33 PM, Manfred Spraul wrote: > Hi Dmitry, > > shm locking differs too much from msg/sem locking, I never looked at it in > depth, so I'm not able to perform a proper review. > > Except for the obvious: Races that can be triggered from user space

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

On Sat, 2 Jan 2016, SF Markus Elfring wrote: > >> Move the jump label directly before the desired log statement > >> so that the variable "err" will not be checked once more > >> after it was determined that a function call failed. > >> Use the identifier "report_failure" instead of the label

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

>> I assume that a software development taste can evolve, can't it? > > So far, you have gotten several down votes for this kind of change, I am curious when more contributors will share corresponding opinions. > and no enthusiasm. How many software designers and developers can become

Re: [PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2)

Am Freitag, 1. Januar 2016, 21:12:40 schrieb Stephan Mueller: Hi Herbert, > Am Mittwoch, 30. Dezember 2015, 11:47:53 schrieb Herbert Xu: > > Hi Herbert, > > > On Tue, Dec 29, 2015 at 07:36:14PM +0100, Dmitry Vyukov wrote: > > > Hello, > > > > > > On commit

Re: [PATCH 2/4] irqchip: bcm2836: Add SMP support for the 2836

On Sat, Dec 26, 2015 at 01:47:22PM -0800, Eric Anholt wrote: > +int __init bcm2836_smp_boot_secondary(unsigned int cpu, > + struct task_struct *idle) > +{ > + unsigned long secondary_startup_phys = > + (unsigned long)virt_to_phys((void

[PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

From: Markus Elfring Date: Sat, 2 Jan 2016 14:54:30 +0100 Omit explicit initialisation at the beginning for five local variables which are redefined before their first use. Signed-off-by: Markus Elfring ---

[PATCH 2/3] rsi: Delete unnecessary variable initialisations in rsi_send_data_pkt()

From: Markus Elfring Date: Sat, 2 Jan 2016 15:15:12 +0100 Omit explicit initialisation at the beginning for four local variables which are redefined before their first use. Signed-off-by: Markus Elfring ---

Re: [PATCH 2/4] irqchip: bcm2836: Add SMP support for the 2836

Agreed. This probably comes from the downstream code, I think.. But I agree it's actually redundant. Thank you for pointing this out. On Sat, Jan 2, 2016 at 11:27 AM, Russell King - ARM Linux wrote: > On Sat, Dec 26, 2015 at 01:47:22PM -0800, Eric Anholt wrote: >> +int

[PATCH 1/5] xen-netback: Delete an unnecessary assignment in connect_rings()

From: Markus Elfring Date: Sat, 2 Jan 2016 17:32:40 +0100 Remove the assignment for a local variable because its value is not changed compared to the one from a previous function call. Signed-off-by: Markus Elfring ---

Re: cgroup: BUG: unable to handle kernel NULL pointer dereference

On Sat, Jan 02, 2016 at 06:54:37AM -0500, Tejun Heo wrote: > On Fri, Jan 01, 2016 at 03:40:28PM -0800, Jeremiah Mahler wrote: > > all, > > > > When running the latest linux-next (20151231) two of my machines > > hang early in the boot sequence. The initial message is for a > > NULL pointer

[PATCH 2/5] xen-netback: Delete an unnecessary goto statement in connect_rings()

From: Markus Elfring Date: Sat, 2 Jan 2016 17:50:21 +0100 One goto statement referred to a source code position directly behind it. Thus omit such an unnecessary jump. Signed-off-by: Markus Elfring ---

[PATCH] ARM: pxa: add defconfig covering all the boards

Add a defconfig covering all known pxa board, ie. all selectable machine files in arch/arm/mach-pxa/*.c. This defconfig was built by doing : - aggregation of all known defconfigs by cat am200epdkit_defconfig cm_x2xx_defconfig cm_x300_defconfig

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

On 01/02/2016 09:03 PM, Stephan Mueller wrote: > Am Samstag, 2. Januar 2016, 15:41:34 schrieb Milan Broz: > > Hi Milan, > ... >>> Hi Herbert, >>> >>> this patch breaks userspace in cryptsetup... >>> >>> We use algif_skcipher in cryptsetup (for years, even before >>> there was Stephan's library)

net-rsi: Reconsider usage of variable "vap_id" in rsi_send_mgmt_pkt()

Hello, I have taken another look at the implementation of the function "rsi_send_mgmt_pkt". https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/wireless/rsi/rsi_91x_pkt.c?id=e8c58e7a5a106c3d557fccd01cd4d1128f9bab38#n114 I find the following statement combination

Re: Nokia N900: Adjust MPU OPP values

* Pali Rohár [160102 06:31]: > Hello, > > MPU OPP table table (omap36xx_vddcore_volt_data) defined in > opp3xxx_data.c does not match Nokia N900 phone. For a long time we have > dirty patch in linux-n900 tree for it, see: > >

[PATCH 3/5] xen-netback: Replace a variable initialisation by an assignment in read_xenbus_vif_flags()

From: Markus Elfring Date: Sat, 2 Jan 2016 18:01:57 +0100 Replace an explicit initialisation for one local variable at the beginning by an assignment. Signed-off-by: Markus Elfring --- drivers/net/xen-netback/xenbus.c | 7 ---

[PATCH 4/5] xen-netback: Replace a variable initialisation by an assignment in xen_register_watchers()

From: Markus Elfring Date: Sat, 2 Jan 2016 18:23:16 +0100 Replace an explicit initialisation for one local variable at the beginning by an assignment. Signed-off-by: Markus Elfring --- drivers/net/xen-netback/xenbus.c | 3 ++- 1

Re: [Question about DMA] Consistent memory?

On Sat, 2016-01-02 at 19:35 +0100, Mike Looijmans wrote: > On 2-1-2016 11:39, Russell King - ARM Linux wrote: > > On Thu, Dec 31, 2015 at 04:50:54PM +0900, Masahiro Yamada wrote: > > > Hi. > > > > > > I am new to the Linux DMA APIs. > > > > > > First, I started by reading

[PATCH 0/5] xen-netback: Fine-tuning for three function implementations

From: Markus Elfring Date: Sat, 2 Jan 2016 18:46:45 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Delete an unnecessary assignment in connect_rings() Delete an unnecessary goto statement in

Re: [PATCH] iio: qcom-spmi-vadc: One check less in vadc_measure_ref_points() after error detection

On 26/12/15 13:04, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 26 Dec 2015 13:53:15 +0100 > > This issue was detected by using the Coccinelle software. > > Move the jump label directly before the desired log statement > so that the variable "ret"

[PATCH v2 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

From: Markus Elfring Date: Sat, 2 Jan 2016 19:22:36 +0100 Omit explicit initialisation at the beginning for four local variables which are redefined before their first use. Signed-off-by: Markus Elfring ---

Re: [PATCH 0/3] OOM detection rework v4

Tetsuo Handa wrote: > Michal Hocko wrote: > > On Mon 28-12-15 21:08:56, Tetsuo Handa wrote: > > > Tetsuo Handa wrote: > > > > I got OOM killers while running heavy disk I/O (extracting kernel > > > > source, > > > > running lxr's genxref command). (Environ: 4 CPUs / 2048MB RAM / no swap > > > >

Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition

On Friday 01 January 2016 12:33:03 Ivaylo Dimitrov wrote: > Hi Pali, > > On 1.01.2016 13:26, Pali Rohár wrote: > > On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote: > >> All calls to isp1704_write() are using parameter sequence of > >> isp1704_write(isp, reg, val) but the function is

Re: [Question about DMA] Consistent memory?

On Sat, 2016-01-02 at 10:39 +, Russell King - ARM Linux wrote: > On Thu, Dec 31, 2015 at 04:50:54PM +0900, Masahiro Yamada wrote: > > Hi. > > > > I am new to the Linux DMA APIs. > > > > First, I started by reading Documentation/DMA-API.txt, > > but I am confused with the term "consistent

Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral clock gates.

Michael Turquette writes: > Hi Arnd, > > Quoting Arnd Bergmann (2015-12-30 01:29:02) >> It's also ok to merge the header file and binding with either the dts file >> changes or the driver and then do the other part the following release. >> >> In the past, we've worked

<    1   2   3   4   5   >