On 2-1-2016 11:39, Russell King - ARM Linux wrote:
On Thu, Dec 31, 2015 at 04:50:54PM +0900, Masahiro Yamada wrote:
Hi.
I am new to the Linux DMA APIs.
First, I started by reading Documentation/DMA-API.txt,
but I am confused with the term "consistent memory".
Just read "coherent memory"
SF Markus Elfring :
> From: Markus Elfring
> Date: Sat, 2 Jan 2016 15:25:34 +0100
>
> Replace explicit initialisation for two local variables at the beginning
> by assignments.
It makes no sense for the 'adapter' variable.
--
Hi Dmitry,
On 01/02/2016 01:19 PM, Dmitry Vyukov wrote:
On Sat, Jan 2, 2016 at 12:33 PM, Manfred Spraul
wrote:
Hi Dmitry,
shm locking differs too much from msg/sem locking, I never looked at it in
depth, so I'm not able to perform a proper review.
Except for the
On Mon, Dec 28, 2015 at 12:05:51PM +0200, Kirill A. Shutemov wrote:
> On Thu, Dec 24, 2015 at 11:20:30AM -0500, Matthew Wilcox wrote:
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index 4bf3811..e14634f 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -1958,6
Hi,
* Pali Rohár [160102 06:46]:
> --- a/drivers/media/rc/ir-rx51.c
> +++ b/drivers/media/rc/ir-rx51.c
> @@ -25,9 +25,9 @@
> #include
> #include
> #include
> +#include
>
> -#include
> -#include
> +#include "../../../arch/arm/plat-omap/include/plat/dmtimer.h"
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give
On Monday 28 December 2015 15:55:28 Arnd Bergmann wrote:
> On Monday 28 December 2015 15:54:35 Pali Rohár wrote:
> > On Monday 28 December 2015 15:41:01 Arnd Bergmann wrote:
> > > On Monday 28 December 2015 15:28:48 Pali Rohár wrote:
> > > > On Monday 28 December 2015 15:14:50 Arnd Bergmann wrote:
-rsi-Fine-tuning-for-two-function-implementations/20160102-224740
base:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
master
config: x86_64-randconfig-s2-01030012 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make
On Thu, Dec 31, 2015 at 10:30:27AM +1100, Dave Chinner wrote:
> > @@ -1637,6 +1669,7 @@ xfs_filemap_pfn_mkwrite(
> > static const struct vm_operations_struct xfs_file_vm_ops = {
> > .fault = xfs_filemap_fault,
> > .pmd_fault = xfs_filemap_pmd_fault,
> > + .pud_fault =
* Pali Rohár [160102 06:14]:
> Hello,
>
> now I'm looking at differences between legacy board code and DTS file
> for Nokia N900 and I see some inconsistency for twl4030-power driver.
>
> In board code are defined more twl4030 power scripts which override
> defaults
From: Markus Elfring
Date: Sat, 2 Jan 2016 18:28:26 +0100
Omit explicit initialisation at the beginning for one local variable
that is redefined before its first use.
Signed-off-by: Markus Elfring
---
On Sat, Jan 02, 2016 at 08:17:51AM -0800, James Bottomley wrote:
> On Sat, 2016-01-02 at 10:39 +, Russell King - ARM Linux wrote:
> > On Thu, Dec 31, 2015 at 04:50:54PM +0900, Masahiro Yamada wrote:
> > > Hi.
> > >
> > > I am new to the Linux DMA APIs.
> > >
> > > First, I started by reading
On Sat, Jan 2, 2016 at 2:02 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Fri, 1 Jan 2016 21:16:01 +0100
>
> Rename a jump label according to the current Linux coding style convention.
>
> Signed-off-by: Markus Elfring
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give
This removes a few Sparse warnings.
Signed-off-by: Hugo Camboulive
---
drivers/staging/most/hdm-dim2/dim2_hal.c | 6 +++---
drivers/staging/most/hdm-dim2/dim2_hal.h | 6 +++---
drivers/staging/most/hdm-dim2/dim2_hdm.c | 6 +++---
gcc correctly warns that the ctx variable in ext4_set_encrypted_filename
has gone out of scope in ext4_set_encrypted_filename if we enter the
retry path and a 'goto' into the previous code block can not guarantee
to get the contents back:
fs/ext4/namei.c: In function
Am Samstag, 2. Januar 2016, 15:41:34 schrieb Milan Broz:
Hi Milan,
> On 01/02/2016 12:52 PM, Milan Broz wrote:
> > On 12/25/2015 08:40 AM, Herbert Xu wrote:
> >> Dmitry Vyukov wrote:
> >>> I am testing with your two patches:
> >>> crypto: algif_skcipher - Use new skcipher
From: Markus Elfring
Date: Sat, 2 Jan 2016 21:47:30 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Refactoring for mei_nfc_connect()
Refactoring for mei_nfc_if_version()
Delete an unnecessary
On Fri, Dec 11, 2015 at 02:55:10PM +0100, Bartosz Golaszewski wrote:
> 2015-12-11 13:08 GMT+01:00 Wolfram Sang :
> > On Wed, Dec 02, 2015 at 11:25:17AM +0100, Bartosz Golaszewski wrote:
> >> Chips from the at24cs EEPROM series have an additional read-only memory
> >> area
> >>
From: Markus Elfring
Date: Sat, 2 Jan 2016 21:40:10 +0100
Omit explicit initialisation at the beginning for one local variable
that is redefined before its first use.
Signed-off-by: Markus Elfring
---
drivers/nfc/mei_phy.c | 2 +-
From: Markus Elfring
Date: Sat, 2 Jan 2016 21:33:04 +0100
Rename a jump label according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/nfc/mei_phy.c | 5 ++---
1 file changed, 2
SF Markus Elfring writes:
> From: Markus Elfring
> Date: Fri, 1 Jan 2016 17:32:07 +0100
>
> Reduce the scope for the local variable "desc" to one branch
> of an if statement.
This patch is harmless. But is also pointless.
You
Am 02.01.2016 um 23:04 schrieb Richard Weinberger:
> Prefix public functions with "orangefs_" do don't
> pollute the global namespace.
>
> This fixes a build issue on UML which also has block_signals().
>
> Signed-off-by: Richard Weinberger
> ---
> fs/orangefs/orangefs-kernel.h
On 12/17/2015 08:37 AM, Baolin Wang wrote:
> Hi Milan,
>
> On 16 December 2015 at 16:08, Milan Broz wrote:
>> On 12/16/2015 04:18 AM, Baolin Wang wrote:
>>> From the dm-crypt performance report, we found it shows low efficiency
>>> with crypto engine for some mode (like ecb
Hi Markus,
On Sun, Jan 3, 2016 at 7:54 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Sat, 2 Jan 2016 21:21:24 +0100
>
> This issue was detected by using the Coccinelle software.
>
> Adjust jump targets according to the
On Wednesday, December 23, 2015 10:59:55 PM Julia Lawall wrote:
> The powercap_zone_ops and powercap_zone_constraint_ops structures are never
> modified, so declare them as const.
>
> Most of the actual changes adjust indentation to accomodate the const
> keyword.
>
> Done with the help of
On Friday, December 18, 2015 07:21:35 AM Viresh Kumar wrote:
> On 17-12-15, 19:04, Bartlomiej Zolnierkiewicz wrote:
> > Commit 01fb4d3c39d3 ("PM / OPP: Parse 'opp--'
> > bindings") broke support for parsing standard opp-microvolt and
> > opp-microamp properties. Fix it by setting 'name' string to
I had a patch which also worked, but yours may be better -- I enclose it
here for your information.
--- drivers/staging/speakup/serialio.h.old 2015-08-30 14:34:09.0
-0400
+++ drivers/staging/speakup/serialio.h 2015-10-07 06:27:04.880829874 -0400
@@ -1,22 +1,24 @@
#ifndef
On Sat, Jan 02, 2016 at 01:50:49PM -0800, Jeremiah Mahler wrote:
> Serge,
>
> On Sat, Jan 02, 2016 at 12:24:16PM -0600, Serge E. Hallyn wrote:
> [...]
> >
> > Tried to reproduce with setting CONFIG_CFQ_GROUP_IOSCHED=y, but did not
> > succeed. Could you send me the .config? Also, if someone
From: Markus Elfring
Date: Sat, 2 Jan 2016 21:21:24 +0100
This issue was detected by using the Coccinelle software.
Adjust jump targets according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
On Sun, Dec 27, 2015 at 04:57:48PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 23, 2015 at 9:18 PM, Akshay Bhat wrote:
> > "at" is not a valid vendor prefix, correcting the same to "atmel"
> >
>
> I'm afraid you can't just do this change alone as it's used in some
> DTS.
On Sat, Jan 02, 2016 at 06:43:16AM -0500, Tejun Heo wrote:
> Hello,
>
> On Fri, Jan 01, 2016 at 12:18:17PM +0200, Michael S. Tsirkin wrote:
> > > My initial idea was to use a dedicated workqueue. Michael S. Tsirkin
> > > suggested using a system one. Tejun Heo confirmed that the system
> > >
Quoting Heiko Stübner (2016-01-01 14:05:10)
> Am Freitag, 1. Januar 2016, 22:50:43 schrieb Arnd Bergmann:
> > On Friday 01 January 2016 18:06:30 Heiko Stübner wrote:
> > > "[PATCH] clk: rockchip: fix section mismatches with new child-clocks" [0]
> > >
> > > should be in Mike's + Stephen's inbox
This function does never return NULL, IS_ERR() is sufficent.
Signed-off-by: Richard Weinberger
---
fs/ext4/crypto_key.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/crypto_key.c b/fs/ext4/crypto_key.c
index c5882b3..436ea2a 100644
---
...instead of open coding it.
Signed-off-by: Richard Weinberger
---
fs/ubifs/xattr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c
index e8b01b7..e53292d 100644
--- a/fs/ubifs/xattr.c
+++ b/fs/ubifs/xattr.c
@@ -267,7
On Saturday 02 January 2016 11:59:29 Sudip Mukherjee wrote:
> >
> > Just to be sure we are talking about the same thing: you mean running a
> > 64-bit
> > kernel in a kvm guest with a 32-bit file system, right? Running a 32-bit
> > kvm guest on a 64-bit host would not be interesting of course.
>
On Saturday 02 January 2016 16:22:03 Pali Rohár wrote:
> On Monday 28 December 2015 15:55:28 Arnd Bergmann wrote:
> > On Monday 28 December 2015 15:54:35 Pali Rohár wrote:
> > > >
> > > > I mean you can add the platform data to the omap_auxdata_lookup[]
> > > > table for this board.
> > >
> > >
On Sat, Jan 02, 2016 at 08:30:21PM +, Hugo Camboulive wrote:
> This removes a few Sparse warnings.
> + g.dim2 = (struct dim2_regs __iomem *)dim_base_address;
> -u8 dim_startup(void *dim_base_address, u32 mlb_clock);
> +u8 dim_startup(void __iomem *dim_base_address, u32 mlb_clock);
On Sun, Dec 27, 2015 at 05:02:48PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 23, 2015 at 8:38 PM, Akshay Bhat wrote:
> > This adds devicetree documentation for the bindings of rtc-rx8010
> > driver.
> >
> > Signed-off-by: Akshay Bhat
> > ---
>
This removes a few Sparse warnings.
Signed-off-by: Hugo Camboulive
---
drivers/staging/most/hdm-dim2/dim2_hal.c | 4 ++--
drivers/staging/most/hdm-dim2/dim2_hal.h | 7 ---
drivers/staging/most/hdm-dim2/dim2_hdm.c | 6 +++---
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give
Prefix public functions with "orangefs_" do don't
pollute the global namespace.
This fixes a build issue on UML which also has block_signals().
Signed-off-by: Richard Weinberger
---
fs/orangefs/orangefs-kernel.h | 4 ++--
fs/orangefs/orangefs-utils.c | 4 ++--
Not every arch has io memory.
So, unbreak the build by fixing the dependencies.
Signed-off-by: Richard Weinberger
---
drivers/clocksource/Kconfig | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/clocksource/Kconfig
Samuel Thibault, on Sun 03 Jan 2016 00:25:29 +0100, wrote:
> 5e6dc54 broke the port information in the speakup driver:
> SERIAL_PORT_DFNS only gets defined if asm/serial.h is included.
>
> Along the way, make sure that we do have information for the requested
> serial port number (index)
(It'd
On Tuesday, December 29, 2015 01:52:19 PM Lv Zheng wrote:
> The 20151218 ACPICA kernel-resident subsystem updates are linuxized based
> on the linux-pm/linux-next branch.
>
> The patchset has passed the following build/boot tests.
> Build tests are performed as follows:
> 1. i386 + allyes
> 2.
On Tuesday, December 29, 2015 05:43:33 PM Pavel Machek wrote:
> On Tue 2015-12-29 11:03:21, Manuel Pégourié-Gonnard wrote:
> > The documentation for detach() said attach.
> >
> > Signed-off-by: Manuel Pégourié-Gonnard
> > Cc: triv...@kernel.org
>
> Acked-by: Pavel Machek
On Wednesday, December 16, 2015 12:20:29 PM Chen Yu wrote:
> It is reported that, with CONFIG_HZ_PERIODIC=y cpu stays at the
> lowest frequency even if the usage goes to 100%, neither ondemand
> nor conservative governor works, however performance and
> userspace work as expected. If set with
On Tuesday, December 22, 2015 11:05:43 AM Viresh Kumar wrote:
> On 21-12-15, 22:32, SF Markus Elfring wrote:
> > From: Markus Elfring
> > Date: Mon, 21 Dec 2015 22:12:26 +0100
> >
> > The cpu_set_cclk() function was only used in a single source file so far.
> >
On 01/02/2016 03:26 PM, Pali Rohár wrote:
Hello,
due to this Daniel Lezcano commit (ARM: OMAP3: cpuidle - remove rx51
cpuidle parameters table)
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=231900afba52d6faddfb480cde4132d4edc089bc
we need patch cpuidle34xx.c code
On Saturday 02 January 2016 23:57:47 Arnd Bergmann wrote:
> On Saturday 02 January 2016 16:22:03 Pali Rohár wrote:
> > On Monday 28 December 2015 15:55:28 Arnd Bergmann wrote:
> > > On Monday 28 December 2015 15:54:35 Pali Rohár wrote:
> > > > > I mean you can add the platform data to the
> > > >
cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote:
> I had a patch which also worked, but yours may be better -- I enclose it
> here for your information.
Well, it's not up to serialio.h to include things for serialio.c. That
however makes me realize that the culprit is actually
From: Rafael J. Wysocki
Commit f06147f9fbf1 (ACPICA: Hardware: Enable firmware waking vector
for both 32-bit and 64-bit FACS) added three functions that aren't
present in upstream ACPICA, acpi_hw_set_firmware_waking_vectors(),
acpi_set_firmware_waking_vectors() and
On Sunday 03 January 2016 00:03:54 Pali Rohár wrote:
> On Saturday 02 January 2016 23:57:47 Arnd Bergmann wrote:
> > On Saturday 02 January 2016 16:22:03 Pali Rohár wrote:
> > > On Monday 28 December 2015 15:55:28 Arnd Bergmann wrote:
> > > > On Monday 28 December 2015 15:54:35 Pali Rohár wrote:
>
5e6dc54 broke the port information in the speakup driver:
SERIAL_PORT_DFNS only gets defined if asm/serial.h is included.
Along the way, make sure that we do have information for the requested
serial port number (index)
Signed-off-by: Samuel Thibault
---
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give
On Wednesday, December 23, 2015 05:19:39 PM Aleksey Makarov wrote:
> As discussed when Shannon Zhao sent a patch to add platform_device support
> to pl061 driver. Russel and other maintainers prefered that ACPI learned
> how to create AMBA devices rather than converting/adding platform_device
>
On Sat, Jan 02, 2016 at 09:18:30PM +0100, Milan Broz wrote:
>
> But I cannot change thousands of cryptsetup installations that are actively
> using that code.
> This is clear userspace breakage which should not happen this way.
I'll try to add some compatibility code for your case, assuming
your
Well, OK with me, I will use yours instead because I don't know if they
will backport the thing, thanks so much for doing this.
Samuel Thibault wrote:
> cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote:
> > I had a patch which also worked, but yours
From: Bjørn Mork
Date: Sat, 02 Jan 2016 22:30:48 +0100
> SF Markus Elfring writes:
>
>> From: Markus Elfring
>> Date: Fri, 1 Jan 2016 17:35:03 +0100
>>
>> Omit explicit initialisation at the beginning for one local
On Saturday 02 Jan 2016 20:33:23 (+), Al Viro wrote:
> On Sat, Jan 02, 2016 at 08:30:21PM +, Hugo Camboulive wrote:
> > This removes a few Sparse warnings.
>
> > + g.dim2 = (struct dim2_regs __iomem *)dim_base_address;
>
> > -u8 dim_startup(void *dim_base_address, u32 mlb_clock);
> >
SF Markus Elfring writes:
> From: Markus Elfring
> Date: Fri, 1 Jan 2016 17:35:03 +0100
>
> Omit explicit initialisation at the beginning for one local variable
> that is redefined before its first use.
This patch is unnecessary.
... instead of open coding it.
Signed-off-by: Richard Weinberger
---
fs/xattr.c | 38 ++
1 file changed, 14 insertions(+), 24 deletions(-)
diff --git a/fs/xattr.c b/fs/xattr.c
index 9b932b9..9e8a652 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@
We cannot use positive error codes in ERR_PTR().
IS_ERR() won't catch them.
Cc: sta...@vger.kernel.org
Signed-off-by: Richard Weinberger
---
fs/ubifs/super.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
On Mon, Dec 21, 2015 at 6:05 PM, Marcelo Tosatti wrote:
> OK cool hopefully that makes it clear to Fenghua Yu what must
> be changed in the patchset.
>
>> - http://lkml.iu.edu/hypermail/linux/kernel/1511.0/02375.html
...beating a dead horse but this patch is in -next and
Original issue is fixed by:
f2fs: cover more area with nat_tree_lock
This reverts commit 24928634f81b1592e83b37dcd89ed45c28f12feb.
---
fs/f2fs/node.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 4dab09f..6d5f548 100644
--- a/fs/f2fs/node.c
There was a subtle bug on nat cache management which incurs wrong nid allocation
or wrong block addresses when try_to_free_nats is triggered heavily.
This patch enlarges the previous coverage of nat_tree_lock to avoid data race.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/node.c
After reading a page, we need to check whether there is any error.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c | 8
1 file changed, 8 insertions(+)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 89a978c..11b2111 100644
--- a/fs/f2fs/data.c
+++
On 01/02/2016 11:16 AM, Tony Lindgren wrote:
> * Pali Rohár [160102 06:31]:
>> Hello,
>>
>> MPU OPP table table (omap36xx_vddcore_volt_data) defined in
>> opp3xxx_data.c does not match Nokia N900 phone. For a long time we have
>> dirty patch in linux-n900 tree for it, see:
On Saturday 02 January 2016 18:14:31 Tony Lindgren wrote:
> * Pali Rohár [160102 06:14]:
> > Hello,
> >
> > now I'm looking at differences between legacy board code and DTS
> > file for Nokia N900 and I see some inconsistency for twl4030-power
> > driver.
> >
> > In board
Serge,
On Sat, Jan 02, 2016 at 12:24:16PM -0600, Serge E. Hallyn wrote:
[...]
>
> Tried to reproduce with setting CONFIG_CFQ_GROUP_IOSCHED=y, but did not
> succeed. Could you send me the .config? Also, if someone could send
> the objdump -d output that might help. Though really, it seems
On Sat, 2016-01-02 at 18:50 +0100, SF Markus Elfring wrote:
> A few update suggestions were taken into account
> from static source code analysis.
While static analysis can be useful, I don't think these
specific conversions are generally useful.
Perhaps it would be more useful to convert the
On Wed, Dec 30, 2015 at 01:14:23AM +0100, Aurélien Francillon wrote:
> Without i8042.nomux=1 the Elantech touch pad is not working at all on
> a Fujitsu Lifebook U745. This patch does not seem necessary for all
> U745 (maybe because of different BIOS versions?). However, it was
> verified that the
The workarounds for chip errata appear twice, in slightly different
forms. One is used when defined(REAL_DMA) || defined(REAL_DMA_POLL), the
other when defined(PSEUDO_DMA). In the PDMA case, the workarounds have
been made conditional on FLAG_NO_DMA_FIXUPS. Do the same for the DMA case,
to
The hostdata struct is now protected by a spin lock so the volatile
qualifiers are redundant. Remove them.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Tested-by: Ondrej Zary
Tested-by: Michael Schmitz
Because interrupt handling is crucial to the core driver(s), all wrapper
drivers need to agree on this code. This patch removes discrepancies.
NCR5380_intr() in NCR5380.c has the following pointless loop that differs
from the code in atari_NCR5380.c.
done = 1;
do {
Use timeouts in do_abort() in atari_NCR5380.c instead of infinite loops.
Also fix the kernel-doc comment. Keep the two core driver forks in sync.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Tested-by: Ondrej Zary
Move board-specific code like this,
NCR5380_write(C400_CONTROL_STATUS_REG, CSR_BASE);
from the core driver to the board driver. Eliminate the NCR53C400 macro
from the core driver. Removal of all macros like this one will be
necessary in order to have one core driver that can support all
This macro makes the code cryptic. Remove it.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Tested-by: Ondrej Zary
---
drivers/scsi/NCR5380.c |2 +-
drivers/scsi/g_NCR5380.c |7 ---
NCR5380.c presently uses the instance->host_lock spin lock. Convert this
to a new spin lock that protects the NCR5380_hostdata struct.
atari_NCR5380.c previously used local_irq_save/restore() rather than a
spin lock. Convert this to hostdata->lock in irq mode. For SMP platforms,
the interrupt
SCSI bus protocol sometimes requires monitoring two related conditions
simultaneously. Enhance NCR5380_poll_politely() for this purpose, and
put it to use in the arbitration algorithm. It will also find use in
pseudo DMA.
Signed-off-by: Finn Thain
Reviewed-by: Hannes
The flags DMA_WORKS_RIGHT, FLAG_NCR53C400 and FLAG_HAS_LAST_BYTE_SENT
all mean the same thing, i.e. the chip is not a 538[01]. (More recent
devices such as the 53C80 have a 'Last Byte Sent' bit in the Target
Command Register as well as other fixes for End-of-DMA errata.)
These flags have no
Fix the array bounds check when transferring an extended message from the
target.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Tested-by: Ondrej Zary
Tested-by: Michael Schmitz
---
Bring the two NCR5380_reselect() implementations into agreement.
Replace infinite loops in atari_NCR5380.c with timeouts, as per NCR5380.c.
Remove 'abort' flag in NCR5380.c as per atari_NCR5380.c -- if reselection
fails, there may be no MESSAGE IN phase so don't attempt data transfer.
During
NCR5380_poll_politely() returns either 0 (success) or -ETIMEDOUT. However,
in do_abort(), the return value is incorrectly taken to be the status
register value. This means that the bus is put into DATA OUT phase instead
of MESSAGE OUT. Fix this.
Signed-off-by: Finn Thain
Allow target selection to fail with a timeout instead of waiting in
infinite loops. This gets rid of the unused NCR_TIMEOUT macro, it is more
defensive and has proved helpful in debugging.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
NDEBUG_NO_DATAOUT should not disable DATA IN phases too. Fix this.
(This bug has long been fixed in atari_NCR5380.c.)
Signed-off-by: Finn Thain
Tested-by: Ondrej Zary
Reviewed-by: Hannes Reinecke
---
Remove unused includes (stat.h, signal.h, proc_fs.h) and move includes
needed by the core drivers into the common header (delay.h etc).
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Tested-by: Ondrej Zary
The complex main_running/queue_main mechanism is peculiar to
atari_NCR5380.c. It isn't SMP safe and offers little value given that
the work queue already offers concurrency management. Remove this
complexity to bring atari_NCR5380.c closer to NCR5380.c.
It is not a good idea to call the
When there is a queued command and no connected command, NCR5380_select()
is called and arbitration begins. The chip waits for BUS FREE once the
MR_ARBITRATE bit in the mode register is enabled. That means there is
no need to wait for BUS FREE after disconnecting.
There is presently no polling
Configuring core drivers using macros like this one prevents re-unifying
the core driver forks, and prevents implementing the core driver as a
library or a platform driver.
The UNSAFE macro in particular is a poor workaround for the problem of
interrupt latency. Releasing the locks complicates
Remove the duplicate write to the Select Enable Register that appeared
in v1.1.38.
Also remove the redundant write to Initiator Command Register prior to
calling do_abort().
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Tested-by: Ondrej Zary
ASM macro is never defined. rtrc in pas16.c is not used.
NCR5380_map_config, do_NCR5380_intr, do_t128_intr and do_pas16_intr
are unused. NCR_NOT_SET harms readability. Remove them.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Tested-by:
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Tested-by: Ondrej Zary
---
drivers/scsi/NCR5380.c |2 +-
drivers/scsi/dtc.c |4 ++--
drivers/scsi/g_NCR5380.c |4 ++--
drivers/scsi/pas16.c |
The "failed" label in NCR5380_select() is not helpful. Some failures
return 0, others -1. Use return instead of goto to improve clarity and
brevity, like atari_NCR5380.c does. Fix the relevant comments.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
If a target disappears from the SCSI bus, NCR5380_select() may
subsequently fail with a time-out. In this situation, scsi_done is
called and NCR5380_select() returns 0. Both hostdata->connected and
hostdata->selecting are NULL and the main loop should proceed with
the next command in the issue
The NVRAM location of this byte is 16, as documented in
http://toshyp.atari.org/en/004009.html
This was confirmed by Michael Schmitz, by setting the SCSI host ID
under EmuTOS and then checking the value in /proc/driver/nvram and
/dev/nvram under Linux.
Signed-off-by: Finn Thain
what is ACPICA and why should we care about divergence between it and the linux
upstream? Where is it to be found?
This may be common knowlege to many people, but it should probably be documented
in the patch bundle and it's explination.
David Lang
On Tue, 29 Dec 2015, Lv Zheng wrote:
This e1000_phy_operations structure is never modified, so declare it as
const. Other structures of this type are already const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/net/ethernet/intel/igb/e1000_82575.c |2 +-
While trying to write documentation on allocator choice, I've run
into something odd:
/*
* __vmalloc() will allocate data pages and auxillary structures (e.g.
* pagetables) with GFP_KERNEL, yet we may be under GFP_NOFS context
* here. Hence we need to
301 - 400 of 474 matches
Mail list logo