Re: [PATCH 1/2] vfs: make sure struct filename->iname is word-aligned

On Fri, Feb 19 2016, Theodore Ts'o wrote: > On Thu, Feb 18, 2016 at 09:10:21PM +0100, Rasmus Villemoes wrote: >> >> Sure, that would work as well. I don't really care how ->iname is pushed >> out to offset 32, but I'd like to know if it's worth it. > > Do you have access to one

Re: [PATCH 1/2] vfs: make sure struct filename->iname is word-aligned

On Fri, Feb 19 2016, Theodore Ts'o wrote: > On Thu, Feb 18, 2016 at 09:10:21PM +0100, Rasmus Villemoes wrote: >> >> Sure, that would work as well. I don't really care how ->iname is pushed >> out to offset 32, but I'd like to know if it's worth it. > > Do you have access to one of these

[PATCH] Staging: comedi: contec_pci_dio: fixed comment blocks coding style issues

Makes the comment blocks start with /* on separate lines, and end with */ on separate lines as well, starting with * for each comment lines. Signed-off-by: Philippe Loctaux --- drivers/staging/comedi/drivers/contec_pci_dio.c | 47 + 1 file

[PATCH] Staging: comedi: contec_pci_dio: fixed comment blocks coding style issues

Makes the comment blocks start with /* on separate lines, and end with */ on separate lines as well, starting with * for each comment lines. Signed-off-by: Philippe Loctaux --- drivers/staging/comedi/drivers/contec_pci_dio.c | 47 + 1 file changed, 24 insertions(+), 23

Re: [PATCH 1/2] MIPS: Add barriers between dcache & icache flushes

On 02/22/2016 13:09, Paul Burton wrote: > Index-based cache operations may be arbitrarily reordered by out of > order CPUs. Thus code which writes back the dcache & then invalidates > the icache using indexed cache ops must include a barrier between > operating on the 2 caches in order to prevent

Re: [PATCH 1/2] MIPS: Add barriers between dcache & icache flushes

On 02/22/2016 13:09, Paul Burton wrote: > Index-based cache operations may be arbitrarily reordered by out of > order CPUs. Thus code which writes back the dcache & then invalidates > the icache using indexed cache ops must include a barrier between > operating on the 2 caches in order to prevent

[PATCH] clk: Update some outdated comments

__clk_init() was renamed to __clk_core_init() but these comments weren't updated. Cc: Masahiro Yamada Signed-off-by: Stephen Boyd --- drivers/clk/clk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] clk: Update some outdated comments

__clk_init() was renamed to __clk_core_init() but these comments weren't updated. Cc: Masahiro Yamada Signed-off-by: Stephen Boyd --- drivers/clk/clk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index

Re: [PATCH] intel-pstate: Update frequencies of policy->cpus only from ->set_policy()

On 02/21/2016 08:57 PM, Viresh Kumar wrote: The intel-pstate driver is using intel_pstate_hwp_set() from two separate paths, i.e. ->set_policy() callback and sysfs update path for the files present in /sys/devices/system/cpu/intel_pstate/ directory. While an update to the sysfs path applies

Re: [PATCH] intel-pstate: Update frequencies of policy->cpus only from ->set_policy()

On 02/21/2016 08:57 PM, Viresh Kumar wrote: The intel-pstate driver is using intel_pstate_hwp_set() from two separate paths, i.e. ->set_policy() callback and sysfs update path for the files present in /sys/devices/system/cpu/intel_pstate/ directory. While an update to the sysfs path applies

Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer

On 02/22/2016 02:28 PM, David Howells wrote: > Tadeusz Struk wrote: > >> I wonder if this should be merged with the crypto/rsa-pkcs1pad.c template >> that we already have. Looks like the two do the same padding now. >> Should we merge then and pass the hash param as a

Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer

On 02/22/2016 02:28 PM, David Howells wrote: > Tadeusz Struk wrote: > >> I wonder if this should be merged with the crypto/rsa-pkcs1pad.c template >> that we already have. Looks like the two do the same padding now. >> Should we merge then and pass the hash param as a separate template param, >>

Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station *DUPLICATE*

Please ignore this duplicate thread.

Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station *DUPLICATE*

Please ignore this duplicate thread.

[PATCH] Staging: comedi: mite: added spaces around | and *

Added spaces around | and *, fixing 2 checkpatch checks. Signed-off-by: Philippe Loctaux --- drivers/staging/comedi/drivers/mite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/mite.c

[PATCH] Staging: comedi: mite: added spaces around | and *

Added spaces around | and *, fixing 2 checkpatch checks. Signed-off-by: Philippe Loctaux --- drivers/staging/comedi/drivers/mite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c index

Re: [PATCH 04/10] x86/xsaves: Introduce a new check that allows correct xstates copy from kernel to user directly

On Mon, Feb 22, 2016 at 3:27 PM, Yu-cheng Yu wrote: > On Mon, Feb 22, 2016 at 02:42:54PM -0800, Andy Lutomirski wrote: >> > +static int should_save_registers_directly(void) >> >> I don't like the name of this function because: >> >> > +{ >> > + /* >> > +* In

Re: [PATCH 04/10] x86/xsaves: Introduce a new check that allows correct xstates copy from kernel to user directly

On Mon, Feb 22, 2016 at 3:27 PM, Yu-cheng Yu wrote: > On Mon, Feb 22, 2016 at 02:42:54PM -0800, Andy Lutomirski wrote: >> > +static int should_save_registers_directly(void) >> >> I don't like the name of this function because: >> >> > +{ >> > + /* >> > +* In signal handling path,

[PATCH v2] mm: scale kswapd watermarks in proportion to memory

In machines with 140G of memory and enterprise flash storage, we have seen read and write bursts routinely exceed the kswapd watermarks and cause thundering herds in direct reclaim. Unfortunately, the only way to tune kswapd aggressiveness is through adjusting min_free_kbytes - the system's

[PATCH v2] mm: scale kswapd watermarks in proportion to memory

In machines with 140G of memory and enterprise flash storage, we have seen read and write bursts routinely exceed the kswapd watermarks and cause thundering herds in direct reclaim. Unfortunately, the only way to tune kswapd aggressiveness is through adjusting min_free_kbytes - the system's

Re: [PATCH v2 12/16] clk: avoid circular clock topology

On 22 February 2016 at 03:29, Masahiro Yamada wrote: > Hi Joachim, > > > 2016-02-22 6:39 GMT+09:00 Joachim Eastwood : >> Hi everyone, >> >> On 28 December 2015 at 11:10, Masahiro Yamada >> wrote: >>> Currently,

Re: [PATCH v2 12/16] clk: avoid circular clock topology

On 22 February 2016 at 03:29, Masahiro Yamada wrote: > Hi Joachim, > > > 2016-02-22 6:39 GMT+09:00 Joachim Eastwood : >> Hi everyone, >> >> On 28 December 2015 at 11:10, Masahiro Yamada >> wrote: >>> Currently, clk_register() never checks a circular parent looping, >>> but clock providers could

Re: [PATCH 04/10] x86/xsaves: Introduce a new check that allows correct xstates copy from kernel to user directly

On Mon, Feb 22, 2016 at 02:42:54PM -0800, Andy Lutomirski wrote: > > +static int should_save_registers_directly(void) > > I don't like the name of this function because: > > > +{ > > + /* > > +* In signal handling path, the kernel already checks if > > +* FPU instructions

Re: [PATCH 04/10] x86/xsaves: Introduce a new check that allows correct xstates copy from kernel to user directly

On Mon, Feb 22, 2016 at 02:42:54PM -0800, Andy Lutomirski wrote: > > +static int should_save_registers_directly(void) > > I don't like the name of this function because: > > > +{ > > + /* > > +* In signal handling path, the kernel already checks if > > +* FPU instructions

Re: [PATCH v3 4/5] ACPI / processor_idle : introduce ARCH_SUPPORTS_ACPI_PROCESSOR_CSTATE

On Mon, Feb 22, 2016 at 2:46 PM, Sudeep Holla wrote: > Hi Rafael, > > On 17/02/16 12:21, Sudeep Holla wrote: >> >> >> >> On 16/02/16 20:18, Rafael J. Wysocki wrote: > > > [..] > >> >>> This way it all should work without any new Kconfig options. >>> >> >> I agree with you in

Re: [PATCH v3 4/5] ACPI / processor_idle : introduce ARCH_SUPPORTS_ACPI_PROCESSOR_CSTATE

On Mon, Feb 22, 2016 at 2:46 PM, Sudeep Holla wrote: > Hi Rafael, > > On 17/02/16 12:21, Sudeep Holla wrote: >> >> >> >> On 16/02/16 20:18, Rafael J. Wysocki wrote: > > > [..] > >> >>> This way it all should work without any new Kconfig options. >>> >> >> I agree with you in terms of avoiding new

Re: [PATCH] lkdtm: add test for executing .rodata

On 22 Feb 2016 at 12:46, Kees Cook wrote: > GCC really wants to declare the section. :( hmm, i see, so how about going about it another way. instead of trying to do this at compile/link time, do it an load/runtime. one way of doing it would be to preserve a page in .rodata then map in a code

Re: [PATCH] lkdtm: add test for executing .rodata

On 22 Feb 2016 at 12:46, Kees Cook wrote: > GCC really wants to declare the section. :( hmm, i see, so how about going about it another way. instead of trying to do this at compile/link time, do it an load/runtime. one way of doing it would be to preserve a page in .rodata then map in a code

[PATCH] Revert "clk: avoid circular clock topology"

This reverts commit 858d5881564026cbc4e6f5e25ae878a27df5d4c9. Joachim reports that this commit breaks lpc18xx boot. This is because the hardware has circular clk topology where PLLs can feed into dividers and the same dividers can feed into the PLLs. The hardware is designed this way so that you

[PATCH] Revert "clk: avoid circular clock topology"

This reverts commit 858d5881564026cbc4e6f5e25ae878a27df5d4c9. Joachim reports that this commit breaks lpc18xx boot. This is because the hardware has circular clk topology where PLLs can feed into dividers and the same dividers can feed into the PLLs. The hardware is designed this way so that you

[PATCH 2/6] ncr5380: Dont release lock for PIO transfer

The calls to NCR5380_transfer_pio() for DATA IN and DATA OUT phases will modify cmd->SCp.this_residual, cmd->SCp.ptr and cmd->SCp.buffer. That works as long as EH does not intervene, which became possible in atari_NCR5380.c when I changed the locking to bring it closer to NCR5380.c. If error

[PATCH 2/6] ncr5380: Dont release lock for PIO transfer

The calls to NCR5380_transfer_pio() for DATA IN and DATA OUT phases will modify cmd->SCp.this_residual, cmd->SCp.ptr and cmd->SCp.buffer. That works as long as EH does not intervene, which became possible in atari_NCR5380.c when I changed the locking to bring it closer to NCR5380.c. If error

[PATCH 3/6] ncr5380: Dont re-enter NCR5380_select()

Calling NCR5380_select() from the abort handler causes various problems. Firstly, it means potentially re-entering NCR5380_select(). Secondly, it means that the lock is released, which permits the EH handlers to be re-entered. The combination results in crashes. Don't do it. Fixes: 8b00c3d5d40d

[PATCH 4/6] ncr5380: Forget aborted commands

The list structures and related logic used in the NCR5380 driver mean that a command cannot be queued twice (i.e. can't appear on more than one queue and can't appear on the same queue more than once). The abort handler must forget the command so that the mid-layer can re-use it. E.g. the ML may

[PATCH 3/6] ncr5380: Dont re-enter NCR5380_select()

Calling NCR5380_select() from the abort handler causes various problems. Firstly, it means potentially re-entering NCR5380_select(). Secondly, it means that the lock is released, which permits the EH handlers to be re-entered. The combination results in crashes. Don't do it. Fixes: 8b00c3d5d40d

[PATCH 4/6] ncr5380: Forget aborted commands

The list structures and related logic used in the NCR5380 driver mean that a command cannot be queued twice (i.e. can't appear on more than one queue and can't appear on the same queue more than once). The abort handler must forget the command so that the mid-layer can re-use it. E.g. the ML may

[PATCH 1/6] ncr5380: Correctly clear command pointers and lists after bus reset

Commands subject to exception handling are to be returned to the scsi mid-layer. Make sure that the various command pointers and command lists in the low-level driver are correctly cleansed of affected commands. This fixes some bugs that I accidentally introduced in v4.5-rc1 including the removal

[PATCH 1/6] ncr5380: Correctly clear command pointers and lists after bus reset

Commands subject to exception handling are to be returned to the scsi mid-layer. Make sure that the various command pointers and command lists in the low-level driver are correctly cleansed of affected commands. This fixes some bugs that I accidentally introduced in v4.5-rc1 including the removal

[PATCH 5/6] ncr5380: Fix NCR5380_select() EH checks and result handling

Add missing checks for EH abort during arbitration and selection. Rework the handling of NCR5380_select() result to improve clarity. Fixes: 707d62b37fbb ("ncr5380: Fix EH during arbitration and selection") Tested-by: Michael Schmitz Signed-off-by: Finn Thain

[PATCH 6/6] ncr5380: Call scsi_eh_prep_cmnd() and scsi_eh_restore_cmnd() as and when appropriate

This bug causes the wrong command to have its sense pointer overwritten, which sometimes leads to a NULL pointer deref. Fix this by checking which command is being requeued before restoring the scsi_eh_save data. It turns out that some targets will disconnect a REQUEST SENSE command. The

[PATCH 5/6] ncr5380: Fix NCR5380_select() EH checks and result handling

Add missing checks for EH abort during arbitration and selection. Rework the handling of NCR5380_select() result to improve clarity. Fixes: 707d62b37fbb ("ncr5380: Fix EH during arbitration and selection") Tested-by: Michael Schmitz Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c |

[PATCH 6/6] ncr5380: Call scsi_eh_prep_cmnd() and scsi_eh_restore_cmnd() as and when appropriate

This bug causes the wrong command to have its sense pointer overwritten, which sometimes leads to a NULL pointer deref. Fix this by checking which command is being requeued before restoring the scsi_eh_save data. It turns out that some targets will disconnect a REQUEST SENSE command. The

Re: [PATCH net v2] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

Chunhao Lin : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 537974c..a645f8d 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -7730,10 +7730,13 @@

[PATCH 0/6] ncr5380: Exception handling fixes for v4.5

These patches fix some exception handling and autosense bugs that I accidentally introduced in v4.5-rc1. The error recovery and autosense code in these drivers has been unstable for a long time. Despite that, v4.5-rc1 shows a regression in as much as it exposes a bug in the aranym emulator. This

Re: [PATCH net v2] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

Chunhao Lin : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 537974c..a645f8d 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -7730,10 +7730,13 @@ rtl8169_get_stats64(struct

[PATCH 0/6] ncr5380: Exception handling fixes for v4.5

These patches fix some exception handling and autosense bugs that I accidentally introduced in v4.5-rc1. The error recovery and autosense code in these drivers has been unstable for a long time. Despite that, v4.5-rc1 shows a regression in as much as it exposes a bug in the aranym emulator. This

Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check

On Mon, Feb 22, 2016 at 09:34:26AM -0500, Boris Ostrovsky wrote: > On 02/22/2016 05:27 AM, Borislav Petkov wrote: > >On Mon, Feb 22, 2016 at 07:07:56AM +0100, Luis R. Rodriguez wrote: > >>diff --git a/arch/x86/include/asm/x86_init.h > >>b/arch/x86/include/asm/x86_init.h > >>index

Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check

On Mon, Feb 22, 2016 at 09:34:26AM -0500, Boris Ostrovsky wrote: > On 02/22/2016 05:27 AM, Borislav Petkov wrote: > >On Mon, Feb 22, 2016 at 07:07:56AM +0100, Luis R. Rodriguez wrote: > >>diff --git a/arch/x86/include/asm/x86_init.h > >>b/arch/x86/include/asm/x86_init.h > >>index

linux-next: manual merge of the f2fs tree with Linus' tree

Hi Jaegeuk, Today's linux-next merge of the f2fs tree got conflicts in: fs/ext4/crypto.c fs/ext4/ext4.h fs/ext4/namei.c between commits: 28b4c263961c ("ext4 crypto: revalidate dentry after adding or removing the key") ff978b09f973 ("ext4 crypto: move context consistency check to

linux-next: manual merge of the f2fs tree with Linus' tree

Hi Jaegeuk, Today's linux-next merge of the f2fs tree got conflicts in: fs/ext4/crypto.c fs/ext4/ext4.h fs/ext4/namei.c between commits: 28b4c263961c ("ext4 crypto: revalidate dentry after adding or removing the key") ff978b09f973 ("ext4 crypto: move context consistency check to

[PATCH 1/6] cgroup: fix error return value of cgroup_addrm_files()

cgroup_addrm_files() incorrectly returned 0 after add failure. Fix it. Signed-off-by: Tejun Heo --- kernel/cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 7ad6191..68b032d 100644 --- a/kernel/cgroup.c +++

[PATCH 1/6] cgroup: fix error return value of cgroup_addrm_files()

cgroup_addrm_files() incorrectly returned 0 after add failure. Fix it. Signed-off-by: Tejun Heo --- kernel/cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 7ad6191..68b032d 100644 --- a/kernel/cgroup.c +++

[PATCH 3/6] cgroup: s/child_subsys_mask/subtree_ss_mask/

For consistency with cgroup->subtree_control. * cgroup->child_subsys_mask -> cgroup->subtree_ss_mask * cgroup_calc_child_subsys_mask() -> cgroup_calc_subtree_ss_mask() * cgroup_refresh_child_subsys_mask() -> cgroup_refresh_subtree_ss_mask() No functional changes. Signed-off-by: Tejun Heo

[PATCH 3/6] cgroup: s/child_subsys_mask/subtree_ss_mask/

For consistency with cgroup->subtree_control. * cgroup->child_subsys_mask -> cgroup->subtree_ss_mask * cgroup_calc_child_subsys_mask() -> cgroup_calc_subtree_ss_mask() * cgroup_refresh_child_subsys_mask() -> cgroup_refresh_subtree_ss_mask() No functional changes. Signed-off-by: Tejun Heo ---

[PATCHSET] cgroup: misc fixes and cleanups

Hello, This patchset contains the following six patches. The first one is a fix but should be safe to route through for-4.6. The rest are misc cleanups and improvements which don't cause notable behavior changes. 0001-cgroup-fix-error-return-value-of-cgroup_addrm_files.patch

[PATCHSET] cgroup: misc fixes and cleanups

Hello, This patchset contains the following six patches. The first one is a fix but should be safe to route through for-4.6. The rest are misc cleanups and improvements which don't cause notable behavior changes. 0001-cgroup-fix-error-return-value-of-cgroup_addrm_files.patch

[PATCH 5/6] cgroup: use do_each_subsys_mask() where applicable

There are several places in cgroup_subtree_control_write() which can use do_each_subsys_mask() instead of manual mask testing. Use it. No functional changes. Signed-off-by: Tejun Heo --- kernel/cgroup.c | 35 --- 1 file changed, 12

[PATCH 2/6] Revert "cgroup: add cgroup_subsys->css_e_css_changed()"

This reverts commit 56c807ba4e91f0980567b6a69de239677879b17f. cgroup_subsys->css_e_css_changed() was supposed to be used by cgroup writeback support; however, the change to per-inode cgroup association made it unnecessary and the callback doesn't have any user. Remove it. Signed-off-by: Tejun

[PATCH 5/6] cgroup: use do_each_subsys_mask() where applicable

There are several places in cgroup_subtree_control_write() which can use do_each_subsys_mask() instead of manual mask testing. Use it. No functional changes. Signed-off-by: Tejun Heo --- kernel/cgroup.c | 35 --- 1 file changed, 12 insertions(+), 23

[PATCH 2/6] Revert "cgroup: add cgroup_subsys->css_e_css_changed()"

This reverts commit 56c807ba4e91f0980567b6a69de239677879b17f. cgroup_subsys->css_e_css_changed() was supposed to be used by cgroup writeback support; however, the change to per-inode cgroup association made it unnecessary and the callback doesn't have any user. Remove it. Signed-off-by: Tejun

[PATCH 6/6] cgroup: make cgroup subsystem masks u16

After the recent do_each_subsys_mask() conversion, there's no reason to use ulong for subsystem masks. We'll be adding more subsystem masks to persistent data structures, let's reduce its size to u16 which should be enough for now and the foreseeable future. This doesn't create any noticeable

[PATCH 6/6] cgroup: make cgroup subsystem masks u16

After the recent do_each_subsys_mask() conversion, there's no reason to use ulong for subsystem masks. We'll be adding more subsystem masks to persistent data structures, let's reduce its size to u16 which should be enough for now and the foreseeable future. This doesn't create any noticeable

[PATCH 4/6] cgroup: convert for_each_subsys_which() to do-while style

for_each_subsys_which() allows iterating subsystems specified in a subsystem bitmask; unfortunately, it requires the mask to be an unsigned long l-value which can be inconvenient and makes it awkward to use a smaller type for subsystem masks. This patch converts for_each_subsy_which() to do-while

[PATCH 4/6] cgroup: convert for_each_subsys_which() to do-while style

for_each_subsys_which() allows iterating subsystems specified in a subsystem bitmask; unfortunately, it requires the mask to be an unsigned long l-value which can be inconvenient and makes it awkward to use a smaller type for subsystem masks. This patch converts for_each_subsy_which() to do-while

Re: [RFC/RFT][PATCH 1/1] cpufreq: New governor using utilization data from the scheduler

On Mon, Feb 22, 2016 at 3:16 PM, Juri Lelli wrote: > Hi Rafael, Hi, > thanks for this RFC. I'm going to test it more in the next few days, but > I already have some questions from skimming through it. Please find them > inline below. > > On 22/02/16 00:18, Rafael J. Wysocki

Re: [RFC/RFT][PATCH 1/1] cpufreq: New governor using utilization data from the scheduler

On Mon, Feb 22, 2016 at 3:16 PM, Juri Lelli wrote: > Hi Rafael, Hi, > thanks for this RFC. I'm going to test it more in the next few days, but > I already have some questions from skimming through it. Please find them > inline below. > > On 22/02/16 00:18, Rafael J. Wysocki wrote: >> From:

Re: 4.4-final: 28 bioset threads on small notebook

On Sun, Feb 21, 2016 at 05:40:59PM +0800, Ming Lei wrote: > On Sun, Feb 21, 2016 at 2:43 PM, Ming Lin-SSI wrote: > >>-Original Message- > > > > So it's almost already "per request_queue" > > Yes, that is because of the following line: > > q->bio_split =

Re: 4.4-final: 28 bioset threads on small notebook

On Sun, Feb 21, 2016 at 05:40:59PM +0800, Ming Lei wrote: > On Sun, Feb 21, 2016 at 2:43 PM, Ming Lin-SSI wrote: > >>-Original Message- > > > > So it's almost already "per request_queue" > > Yes, that is because of the following line: > > q->bio_split = bioset_create(BIO_POOL_SIZE, 0);

Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES

On Mon, Feb 22, 2016 at 2:53 PM, Dave Hansen wrote: > On 02/22/2016 02:45 PM, Andy Lutomirski wrote: >>> +/* >>> > + * Convert from kernel XSAVES compacted format to standard format and >>> > copy >>> > + * to a ptrace buffer. It supports partial copy but pos always

[PATCH 1/8] tty: n_gsm: fix formatting errors

Minor formatting changes to remove errors and reduce number of warnings produced by checkpatch.pl script. Signed-off-by: Andrej Krpic --- drivers/tty/n_gsm.c | 138 1 file changed, 95 insertions(+), 43 deletions(-) diff --git

Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES

On Mon, Feb 22, 2016 at 2:53 PM, Dave Hansen wrote: > On 02/22/2016 02:45 PM, Andy Lutomirski wrote: >>> +/* >>> > + * Convert from kernel XSAVES compacted format to standard format and >>> > copy >>> > + * to a ptrace buffer. It supports partial copy but pos always starts >>> > from >>> > + *

[PATCH 1/8] tty: n_gsm: fix formatting errors

Minor formatting changes to remove errors and reduce number of warnings produced by checkpatch.pl script. Signed-off-by: Andrej Krpic --- drivers/tty/n_gsm.c | 138 1 file changed, 95 insertions(+), 43 deletions(-) diff --git

[PATCH 3/8] tty: n_gsm: make mux work as a responder station

Comment suggests that cr == 1 represents a received command and cr == 0 a received response. Received frames are then filtered: - correctly by rejection of SABM and DISC responses, they are command only frame types and - incorrectly by rejection of UA (a response only frame type) responses.

[PATCH 3/8] tty: n_gsm: make mux work as a responder station

Comment suggests that cr == 1 represents a received command and cr == 0 a received response. Received frames are then filtered: - correctly by rejection of SABM and DISC responses, they are command only frame types and - incorrectly by rejection of UA (a response only frame type) responses.

[PATCH 2/8] tty: n_gsm: fix C/R bit when sending as a responder

According to the specification (3GPP TS 27.010 v12.0.0 R1, 5.2.1.2), C/R bit must be the same for corresponding command and response. If mux is an initiator (station that initiates DLC 0), valid sent commands and received responses must have C/R bit set to 1. For a station that is a responder,

[PATCH 2/8] tty: n_gsm: fix C/R bit when sending as a responder

According to the specification (3GPP TS 27.010 v12.0.0 R1, 5.2.1.2), C/R bit must be the same for corresponding command and response. If mux is an initiator (station that initiates DLC 0), valid sent commands and received responses must have C/R bit set to 1. For a station that is a responder,

[PATCH 7/8] tty: n_gsm: properly format Modem Status Command message

Change format of Modem Status Command (MSC) message that is sent to the one expected in the receive function gsm_control_modem and specified in 3GPP TS 27.010 version 12.0.0 Release 12, 5.4.6.3.7. Wrongly formatted MSC causes DLC to be marked as constipated. A bug appears after format of

[PATCH 7/8] tty: n_gsm: properly format Modem Status Command message

Change format of Modem Status Command (MSC) message that is sent to the one expected in the receive function gsm_control_modem and specified in 3GPP TS 27.010 version 12.0.0 Release 12, 5.4.6.3.7. Wrongly formatted MSC causes DLC to be marked as constipated. A bug appears after format of

[PATCH 6/8] tty: n_gsm: add missing length field in control channel commands

Observing debug output while running initator and responder using n_gsm shows all control channel commands sent by initiator are malformed - they don't include length field (3GPP TS 07.10 ver 7.2.0, 5.4.6.1). Add length field to transmitted control channel commands in the gsm_control_transmit)

[PATCH 8/8] tty: n_gsm: Enable reception of frames separated with a single SOF marker

Frames may be separated with a single SOF (5.2.6.1 of 27.010 mux spec). While transmission of a single SOF between frames is implemented in gsm_data_kick, the reception isn't. As a side effect, it is now possible to receive and ignore a stream of consecutive SOFs (5.2.5 of 27.010 mux spec).

[PATCH 6/8] tty: n_gsm: add missing length field in control channel commands

Observing debug output while running initator and responder using n_gsm shows all control channel commands sent by initiator are malformed - they don't include length field (3GPP TS 07.10 ver 7.2.0, 5.4.6.1). Add length field to transmitted control channel commands in the gsm_control_transmit)

[PATCH 8/8] tty: n_gsm: Enable reception of frames separated with a single SOF marker

Frames may be separated with a single SOF (5.2.6.1 of 27.010 mux spec). While transmission of a single SOF between frames is implemented in gsm_data_kick, the reception isn't. As a side effect, it is now possible to receive and ignore a stream of consecutive SOFs (5.2.5 of 27.010 mux spec).

[PATCH 0/8] tty: n_gsm: Make mux work as a responder station

When using n_gsm you have to explicitly set it to work as a initiator station. This led me to believe that it can also work as a responder. In a use case where I needed responder station mux I came to the conclusion that it actually does not work. Second and third patch fix dealings with frame

[PATCH 0/8] tty: n_gsm: Make mux work as a responder station

When using n_gsm you have to explicitly set it to work as a initiator station. This led me to believe that it can also work as a responder. In a use case where I needed responder station mux I came to the conclusion that it actually does not work. Second and third patch fix dealings with frame

[PATCH 5/8] tty: n_gsm: replace dead code with a meaningful comment

UI/UIH frame can be received as a command from other station or as a response to a command we issued earlier. Add this knowledge to the source code as a comment and remove useless #if 0/#endif block. Signed-off-by: Andrej Krpic --- drivers/tty/n_gsm.c | 9 + 1 file

[PATCH 5/8] tty: n_gsm: replace dead code with a meaningful comment

UI/UIH frame can be received as a command from other station or as a response to a command we issued earlier. Add this knowledge to the source code as a comment and remove useless #if 0/#endif block. Signed-off-by: Andrej Krpic --- drivers/tty/n_gsm.c | 9 + 1 file changed, 5

[PATCH 4/8] tty: n_gsm: send DM response when accessing an invalid channel

Change C/R bit in a response to a UI/UIH frame sent to non-existing/closed channel. As DM frame type is only valid as a response, it should be sent using gsm_response function. Signed-off-by: Andrej Krpic --- drivers/tty/n_gsm.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 4/8] tty: n_gsm: send DM response when accessing an invalid channel

Change C/R bit in a response to a UI/UIH frame sent to non-existing/closed channel. As DM frame type is only valid as a response, it should be sent using gsm_response function. Signed-off-by: Andrej Krpic --- drivers/tty/n_gsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES

On 02/22/2016 02:45 PM, Andy Lutomirski wrote: >> +/* >> > + * Convert from kernel XSAVES compacted format to standard format and copy >> > + * to a ptrace buffer. It supports partial copy but pos always starts from >> > + * zero. This is called from xstateregs_get() and there we check the cpu >>

Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES

On 02/22/2016 02:45 PM, Andy Lutomirski wrote: >> +/* >> > + * Convert from kernel XSAVES compacted format to standard format and copy >> > + * to a ptrace buffer. It supports partial copy but pos always starts from >> > + * zero. This is called from xstateregs_get() and there we check the cpu >>

Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES

On Mon, Feb 22, 2016 at 02:45:54PM -0800, Andy Lutomirski wrote: > > +/* > > + * Convert from kernel XSAVES compacted format to standard format and copy > > + * to a ptrace buffer. It supports partial copy but pos always starts from > > + * zero. This is called from xstateregs_get() and there we

Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES

On Mon, Feb 22, 2016 at 02:45:54PM -0800, Andy Lutomirski wrote: > > +/* > > + * Convert from kernel XSAVES compacted format to standard format and copy > > + * to a ptrace buffer. It supports partial copy but pos always starts from > > + * zero. This is called from xstateregs_get() and there we

Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES

On Mon, Feb 22, 2016 at 11:00 AM, Yu-cheng Yu wrote: > XSAVES uses compacted format and is a kernel instruction. The kernel > should use standard-format, non-supervisor state data for PTRACE. > > +/* > + * Convert from kernel XSAVES compacted format to standard format and

Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES

On Mon, Feb 22, 2016 at 11:00 AM, Yu-cheng Yu wrote: > XSAVES uses compacted format and is a kernel instruction. The kernel > should use standard-format, non-supervisor state data for PTRACE. > > +/* > + * Convert from kernel XSAVES compacted format to standard format and copy > + * to a ptrace

Re: [PATCH 04/10] x86/xsaves: Introduce a new check that allows correct xstates copy from kernel to user directly

On Mon, Feb 22, 2016 at 10:58 AM, Yu-cheng Yu wrote: > XSAVES is a kernel instruction and uses a compacted format. When > working with user space, the kernel should provide standard-format, > non-supervisor state data. We cannot do __copy_to_user() from a compacted- >

Re: [PATCH 04/10] x86/xsaves: Introduce a new check that allows correct xstates copy from kernel to user directly

On Mon, Feb 22, 2016 at 10:58 AM, Yu-cheng Yu wrote: > XSAVES is a kernel instruction and uses a compacted format. When > working with user space, the kernel should provide standard-format, > non-supervisor state data. We cannot do __copy_to_user() from a compacted- > format kernel xstate area to

Re: [PATCH 9/9] ARM: mmp: mark usb_dma_mask as __maybe_unused

Arnd Bergmann writes: > This variable may be used by some devices that each have their > on Kconfig symbol, or by none of them, and that causes a build > warning: > > arch/arm/mach-mmp/devices.c:241:12: error: 'usb_dma_mask' defined but not > used [-Werror=unused-variable] > >

Re: [PATCH 9/9] ARM: mmp: mark usb_dma_mask as __maybe_unused

Arnd Bergmann writes: > This variable may be used by some devices that each have their > on Kconfig symbol, or by none of them, and that causes a build > warning: > > arch/arm/mach-mmp/devices.c:241:12: error: 'usb_dma_mask' defined but not > used [-Werror=unused-variable] > > Marking it

[PATCH 01/24] staging: lustre: Dynamic LNet Configuration (DLC) IOCTL changes

From: Amir Shehata This is the fourth patch of a set of patches that enables DLC. This patch changes the IOCTL infrastructure in preparation of adding extra IOCTL communication between user and kernel space. The changes include: - adding a common header to be passed to

[PATCH 01/24] staging: lustre: Dynamic LNet Configuration (DLC) IOCTL changes

From: Amir Shehata This is the fourth patch of a set of patches that enables DLC. This patch changes the IOCTL infrastructure in preparation of adding extra IOCTL communication between user and kernel space. The changes include: - adding a common header to be passed to ioctl infra functions

<    2   3   4   5   6   7   8   9   10   11   >