Re: [PATCH 5/5] MIPS: jz4740: Use the jz4740-rtc driver as the power controller

2016-03-13 Thread Ralf Baechle
On Sat, Mar 05, 2016 at 11:38:51PM +0100, Paul Cercueil wrote: > Signed-off-by: Paul Cercueil > --- > arch/mips/boot/dts/ingenic/jz4740.dtsi | 2 ++ > arch/mips/jz4740/reset.c | 64 > -- Acked-by: Ralf Baechle

Re: [PATCH 5/5] MIPS: jz4740: Use the jz4740-rtc driver as the power controller

2016-03-13 Thread Ralf Baechle
On Sat, Mar 05, 2016 at 11:38:51PM +0100, Paul Cercueil wrote: > Signed-off-by: Paul Cercueil > --- > arch/mips/boot/dts/ingenic/jz4740.dtsi | 2 ++ > arch/mips/jz4740/reset.c | 64 > -- Acked-by: Ralf Baechle Feel free to funnel this patch

Re: [kbuild-all] drivers/vhost/vhost.c:718:3: error: call to '__compiletime_assert_718' declared with attribute error: BUILD_BUG_ON failed: __alignof__ *vq->avail > VRING_AVAIL_ALIGN_SIZE

2016-03-13 Thread Fengguang Wu
Hi Michael, Sorry for the delay! I blacklisted it just now. Fengguang On Sun, Mar 13, 2016 at 04:57:26PM +0200, Michael S. Tsirkin wrote: > On Thu, Mar 10, 2016 at 08:49:24AM +0800, Fengguang Wu wrote: > > Hi Michael, > > > > On Sun, Mar 06, 2016 at 10:37:07AM +0200, Michael S. Tsirkin wrote:

Re: [kbuild-all] drivers/vhost/vhost.c:718:3: error: call to '__compiletime_assert_718' declared with attribute error: BUILD_BUG_ON failed: __alignof__ *vq->avail > VRING_AVAIL_ALIGN_SIZE

2016-03-13 Thread Fengguang Wu
Hi Michael, Sorry for the delay! I blacklisted it just now. Fengguang On Sun, Mar 13, 2016 at 04:57:26PM +0200, Michael S. Tsirkin wrote: > On Thu, Mar 10, 2016 at 08:49:24AM +0800, Fengguang Wu wrote: > > Hi Michael, > > > > On Sun, Mar 06, 2016 at 10:37:07AM +0200, Michael S. Tsirkin wrote:

C1E auto-promotion suspend/resume

2016-03-13 Thread Andy Lutomirski
Hi- By BIOS (1.2.3 on a Dell XPS 13 9350) seems to want to enable C1E auto-promotion (ugh!), which results in this difference across suspend/resume according to turbostat: -cpu3: MSR_IA32_POWER_CTL: 0x0024005d (C1E auto-promotion: DISabled) +cpu3: MSR_IA32_POWER_CTL: 0x0024005f (C1E

C1E auto-promotion suspend/resume

2016-03-13 Thread Andy Lutomirski
Hi- By BIOS (1.2.3 on a Dell XPS 13 9350) seems to want to enable C1E auto-promotion (ugh!), which results in this difference across suspend/resume according to turbostat: -cpu3: MSR_IA32_POWER_CTL: 0x0024005d (C1E auto-promotion: DISabled) +cpu3: MSR_IA32_POWER_CTL: 0x0024005f (C1E

Re: [PATCH v6 2/2] printk: Make printing of spin_dump() deferred to avoid a deadlock

2016-03-13 Thread Sergey Senozhatsky
On (03/11/16 19:37), Byungchul Park wrote: [..] > +static void __spin_dump_deferred(raw_spinlock_t *lock, const char *msg) > +{ > + printk_func_t s; > + > + s = this_cpu_read(printk_func); > + this_cpu_write(printk_func, vprintk_deferred); > + > + /* > + * To change

Re: [PATCH v6 2/2] printk: Make printing of spin_dump() deferred to avoid a deadlock

2016-03-13 Thread Sergey Senozhatsky
On (03/11/16 19:37), Byungchul Park wrote: [..] > +static void __spin_dump_deferred(raw_spinlock_t *lock, const char *msg) > +{ > + printk_func_t s; > + > + s = this_cpu_read(printk_func); > + this_cpu_write(printk_func, vprintk_deferred); > + > + /* > + * To change

Re: [PATCH] android: lmk: add swap pte pmd in tasksize

2016-03-13 Thread Chen Feng
Hi greg, On 2016/3/12 1:12, Greg KH wrote: > On Fri, Mar 11, 2016 at 05:05:45PM +0800, Chen Feng wrote: >> >> >> On 2016/3/11 15:30, yalin wang wrote: >>> On Mar 11, 2016, at 15:23, Lu Bing wrote: From: l00215322

Re: [PATCH] android: lmk: add swap pte pmd in tasksize

2016-03-13 Thread Chen Feng
Hi greg, On 2016/3/12 1:12, Greg KH wrote: > On Fri, Mar 11, 2016 at 05:05:45PM +0800, Chen Feng wrote: >> >> >> On 2016/3/11 15:30, yalin wang wrote: >>> On Mar 11, 2016, at 15:23, Lu Bing wrote: From: l00215322 Many android devices have zram,so we should add

Re: [PATCH v6 1/2] printk: Factor out buffering and irq work queuing in printk_deferred

2016-03-13 Thread Sergey Senozhatsky
Hello Byungchul, Sorry, I'll make sure I Cc you next time. Jan Kara's updated patch set http://marc.info/?l=linux-kernel=145787625506342 it's quite close to what you have done in this patch, but Jan's patch also solves a number of more likely to happen cases. have time to take a look? the

Re: [PATCH v6 1/2] printk: Factor out buffering and irq work queuing in printk_deferred

2016-03-13 Thread Sergey Senozhatsky
Hello Byungchul, Sorry, I'll make sure I Cc you next time. Jan Kara's updated patch set http://marc.info/?l=linux-kernel=145787625506342 it's quite close to what you have done in this patch, but Jan's patch also solves a number of more likely to happen cases. have time to take a look? the

Re: [patch] drm/vc4: Return -EFAULT on copy_from_user() failure

2016-03-13 Thread Eric Anholt
Dan Carpenter writes: > The copy_from_user() function returns the number of bytes not copied but > we want to return a negative error code. > > Fixes: 463873d57014 ('drm/vc4: Add an API for creating GPU shaders in GEM > BOs.') > Signed-off-by: Dan Carpenter

Re: [patch] drm/vc4: Return -EFAULT on copy_from_user() failure

2016-03-13 Thread Eric Anholt
Dan Carpenter writes: > The copy_from_user() function returns the number of bytes not copied but > we want to return a negative error code. > > Fixes: 463873d57014 ('drm/vc4: Add an API for creating GPU shaders in GEM > BOs.') > Signed-off-by: Dan Carpenter Pulled. Thanks! signature.asc

Re: [PATCH v2 2/2] mm, thp: avoid unnecessary swapin in khugepaged

2016-03-13 Thread Rik van Riel
On Mon, 2016-03-14 at 02:33 +0300, Kirill A. Shutemov wrote: > On Sun, Mar 13, 2016 at 11:28:55AM +0200, Ebru Akagunduz wrote: > >  > > @@ -2493,7 +2494,14 @@ static void collapse_huge_page(struct > > mm_struct *mm, > >   goto out; > >   } > >   > > - __collapse_huge_page_swapin(mm,

Re: [PATCH v2 2/2] mm, thp: avoid unnecessary swapin in khugepaged

2016-03-13 Thread Rik van Riel
On Mon, 2016-03-14 at 02:33 +0300, Kirill A. Shutemov wrote: > On Sun, Mar 13, 2016 at 11:28:55AM +0200, Ebru Akagunduz wrote: > >  > > @@ -2493,7 +2494,14 @@ static void collapse_huge_page(struct > > mm_struct *mm, > >   goto out; > >   } > >   > > - __collapse_huge_page_swapin(mm,

Re: [lkp] [i2c] 95026658c4: WARNING: CPU: 0 PID: 1 at drivers/i2c/i2c-core.c:1930 i2c_register_driver+0x2c/0x79()

2016-03-13 Thread Wolfram Sang
On Mon, Mar 14, 2016 at 08:47:59AM +0800, kernel test robot wrote: > FYI, we noticed the below changes on > > https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/for-next > commit 95026658c46ea2d94498d0dac1282e28cd47c64a ("i2c: do not use internal > data from driver core") Ouch! So

Re: [lkp] [i2c] 95026658c4: WARNING: CPU: 0 PID: 1 at drivers/i2c/i2c-core.c:1930 i2c_register_driver+0x2c/0x79()

2016-03-13 Thread Wolfram Sang
On Mon, Mar 14, 2016 at 08:47:59AM +0800, kernel test robot wrote: > FYI, we noticed the below changes on > > https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/for-next > commit 95026658c46ea2d94498d0dac1282e28cd47c64a ("i2c: do not use internal > data from driver core") Ouch! So

Re: [PATCH 2/3] net: hns: add Hisilicon RoCE support

2016-03-13 Thread Yankejian (Hackim Yim)
On 2016/3/12 18:43, Leon Romanovsky wrote: > On Fri, Mar 11, 2016 at 06:37:10PM +0800, Lijun Ou wrote: >> It added hns_dsaf_roce_reset routine for roce driver. >> RoCE is a feature of hns. >> In hip06 SOC, in roce reset process, it's needed to configure >> dsaf channel reset,port and sl map

Re: [PATCH 2/3] net: hns: add Hisilicon RoCE support

2016-03-13 Thread Yankejian (Hackim Yim)
On 2016/3/12 18:43, Leon Romanovsky wrote: > On Fri, Mar 11, 2016 at 06:37:10PM +0800, Lijun Ou wrote: >> It added hns_dsaf_roce_reset routine for roce driver. >> RoCE is a feature of hns. >> In hip06 SOC, in roce reset process, it's needed to configure >> dsaf channel reset,port and sl map

[PATCH] ARM: dts: Add initial pin configuration for exynos3250-rinato

2016-03-13 Thread Chanwoo Choi
This patch adds initial pin configuration using pinctrl subsystem to reduce leakage power-consumption of gpio pins in normal state. All pins included in this patch are NC (not connected) pin. Cc: Kukjin Kim Cc: Krzysztof Kozlowski Signed-off-by:

[PATCH] ARM: dts: Add initial pin configuration for exynos3250-rinato

2016-03-13 Thread Chanwoo Choi
This patch adds initial pin configuration using pinctrl subsystem to reduce leakage power-consumption of gpio pins in normal state. All pins included in this patch are NC (not connected) pin. Cc: Kukjin Kim Cc: Krzysztof Kozlowski Signed-off-by: Chanwoo Choi ---

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-13 Thread Lu Baolu
Hi, On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: > On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: >> Several Intel PCHs and SOCs have an internal mux that is used to >> share one USB port between device controller and host controller. >> >> A usb port mux could be abstracted as

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-13 Thread Lu Baolu
Hi, On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: > On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: >> Several Intel PCHs and SOCs have an internal mux that is used to >> share one USB port between device controller and host controller. >> >> A usb port mux could be abstracted as

Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables

2016-03-13 Thread Scott Ashcroft
On Sun, 2016-03-13 at 23:07 +, Matt Fleming wrote: > Assuming the answer to this question is "no", can you try out this > patch? > > diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c > index 8fee5b6f8f66..af74849e8c0f 100644 > --- a/arch/x86/mm/pageattr.c > +++

Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables

2016-03-13 Thread Scott Ashcroft
On Sun, 2016-03-13 at 23:07 +, Matt Fleming wrote: > Assuming the answer to this question is "no", can you try out this > patch? > > diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c > index 8fee5b6f8f66..af74849e8c0f 100644 > --- a/arch/x86/mm/pageattr.c > +++

Re: [PATCH] direct-io: Deinline dio_zero_block, save 2684 bytes

2016-03-13 Thread Ming Lei
On Mon, Mar 14, 2016 at 5:36 AM, Denys Vlasenko wrote: > On Sun, Mar 13, 2016 at 10:00 PM, Denys Vlasenko wrote: >> This function compiles to 2684 bytes, 2 callsites >> >>textdata bss dec hex filename >>9655 16 0

Re: [PATCH] direct-io: Deinline dio_zero_block, save 2684 bytes

2016-03-13 Thread Ming Lei
On Mon, Mar 14, 2016 at 5:36 AM, Denys Vlasenko wrote: > On Sun, Mar 13, 2016 at 10:00 PM, Denys Vlasenko wrote: >> This function compiles to 2684 bytes, 2 callsites >> >>textdata bss dec hex filename >>9655 16 0967125c7 direct-io.o.before2 >>9559

Re: [PATCH] drm/msm/dsi: fix definition of msm_dsi_pll_28nm_8960_init()

2016-03-13 Thread Rob Clark
On Sun, Mar 13, 2016 at 5:12 PM, Kieran Bingham wrote: > On 04/02/16 05:09, Archit Taneja wrote: >> >> >> On 02/03/2016 07:55 PM, Luis Henriques wrote: >>> This fixes the following build failure: >>> >>> drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.o: In function >>>

Re: [PATCH] drm/msm/dsi: fix definition of msm_dsi_pll_28nm_8960_init()

2016-03-13 Thread Rob Clark
On Sun, Mar 13, 2016 at 5:12 PM, Kieran Bingham wrote: > On 04/02/16 05:09, Archit Taneja wrote: >> >> >> On 02/03/2016 07:55 PM, Luis Henriques wrote: >>> This fixes the following build failure: >>> >>> drivers/gpu/drm/msm/dsi/pll/dsi_pll_28nm.o: In function >>> `msm_dsi_pll_28nm_8960_init': >>>

Re: [PATCH] clk: rockchip: release io resource when failing to init clk

2016-03-13 Thread Heiko Stuebner
Am Sonntag, 13. März 2016, 12:13:22 schrieb Shawn Lin: > We should call iounmap to relase reg_base since it's not going > to be used any more if failing to init clk. > > Signed-off-by: Shawn Lin applied for v4.7 Thanks Heiko

Re: [PATCH] clk: rockchip: release io resource when failing to init clk

2016-03-13 Thread Heiko Stuebner
Am Sonntag, 13. März 2016, 12:13:22 schrieb Shawn Lin: > We should call iounmap to relase reg_base since it's not going > to be used any more if failing to init clk. > > Signed-off-by: Shawn Lin applied for v4.7 Thanks Heiko

Re: [lkp] [namei] fda89e6574: kernel BUG at fs/namei.c:679!

2016-03-13 Thread Al Viro
On Mon, Mar 14, 2016 at 08:48:26AM +0800, kernel test robot wrote: > FYI, we noticed the below changes on > > https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.lookups > commit fda89e65743179d09e55bc6c265d06fa5efa8803 ("namei: untanlge > lookup_fast()") Could you check if the

Re: [lkp] [namei] fda89e6574: kernel BUG at fs/namei.c:679!

2016-03-13 Thread Al Viro
On Mon, Mar 14, 2016 at 08:48:26AM +0800, kernel test robot wrote: > FYI, we noticed the below changes on > > https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.lookups > commit fda89e65743179d09e55bc6c265d06fa5efa8803 ("namei: untanlge > lookup_fast()") Could you check if the

Re: arch/x86/um/user-offsets.c:8:24: fatal error: asm/ptrace.h: No such file or directory

2016-03-13 Thread Krzysztof Kozlowski
On Sun, Mar 13, 2016 at 7:45 AM, kbuild test robot wrote: > Hi Al, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 03c668a93187fe7fba9464f96fbe7c22eebd9897 > commit:

Re: arch/x86/um/user-offsets.c:8:24: fatal error: asm/ptrace.h: No such file or directory

2016-03-13 Thread Krzysztof Kozlowski
On Sun, Mar 13, 2016 at 7:45 AM, kbuild test robot wrote: > Hi Al, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 03c668a93187fe7fba9464f96fbe7c22eebd9897 > commit:

ERROR: "isa_io_base" [drivers/net/wireless/atmel/atmel.ko] undefined!

2016-03-13 Thread kbuild test robot
Hi Kalle, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a26555498849489fb87139a15abe2eeb8a366ae7 commit: 30fe0f9b8c755d9aab04bb7c98ce9c7835c3bd24 atmel: move under atmel vendor directory date: 4 months ago

ERROR: "isa_io_base" [drivers/net/wireless/atmel/atmel.ko] undefined!

2016-03-13 Thread kbuild test robot
Hi Kalle, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a26555498849489fb87139a15abe2eeb8a366ae7 commit: 30fe0f9b8c755d9aab04bb7c98ce9c7835c3bd24 atmel: move under atmel vendor directory date: 4 months ago

Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt

2016-03-13 Thread Daode Huang
On 2016/3/11 21:29, Sergei Shtylyov wrote: Hello. On 3/11/2016 4:53 AM, Daode Huang wrote: In V2 chip, when sending mamagement packets, the driver should config the port id to BD descs. Signed-off-by: Daode Huang Signed-off-by: Lisheng ---

Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt

2016-03-13 Thread Daode Huang
On 2016/3/11 21:29, Sergei Shtylyov wrote: Hello. On 3/11/2016 4:53 AM, Daode Huang wrote: In V2 chip, when sending mamagement packets, the driver should config the port id to BD descs. Signed-off-by: Daode Huang Signed-off-by: Lisheng --- drivers/net/ethernet/hisilicon/hns/hnae.h

[RFC PATCH V2] checkpatch: Check output format style of __func__ uses

2016-03-13 Thread Joe Perches
Loggng messages that emit function names have many different forms. Perhaps it'd be better for logging consistency and grep ease to exclusively use "%s:" As well, function tracing logging uses are generally unnecessary given the kernel's function tracing (ftrace) capability. Right now, grep

[RFC PATCH V2] checkpatch: Check output format style of __func__ uses

2016-03-13 Thread Joe Perches
Loggng messages that emit function names have many different forms. Perhaps it'd be better for logging consistency and grep ease to exclusively use "%s:" As well, function tracing logging uses are generally unnecessary given the kernel's function tracing (ftrace) capability. Right now, grep

[PATCH] serial: samsung: Reorder the sequence of clock control when call s3c24xx_serial_set_termios()

2016-03-13 Thread Chanwoo Choi
This patch fixes the broken serial log when changing the clock source of uart device. Before disabling the original clock source, this patch enables the new clock source to protect the clock off state for a split second. Signed-off-by: Chanwoo Choi ---

[PATCH] serial: samsung: Reorder the sequence of clock control when call s3c24xx_serial_set_termios()

2016-03-13 Thread Chanwoo Choi
This patch fixes the broken serial log when changing the clock source of uart device. Before disabling the original clock source, this patch enables the new clock source to protect the clock off state for a split second. Signed-off-by: Chanwoo Choi --- drivers/tty/serial/samsung.c | 4 ++-- 1

Re: [PATCH] kbuild: drop FORCE from PHONY targets

2016-03-13 Thread Andy Lutomirski
On Mar 12, 2016 4:14 PM, "Masahiro Yamada" wrote: > > These targets are marked as PHONY. No need to add FORCE to their > dependency. If this is, in fact, correct, can you update Documentation/kbuild/makefiles.txt as well? Thanks, Andy

Re: [PATCH] kbuild: drop FORCE from PHONY targets

2016-03-13 Thread Andy Lutomirski
On Mar 12, 2016 4:14 PM, "Masahiro Yamada" wrote: > > These targets are marked as PHONY. No need to add FORCE to their > dependency. If this is, in fact, correct, can you update Documentation/kbuild/makefiles.txt as well? Thanks, Andy

Re: [PATCH 6/7] clk: rockchip: remove redundant checking of device_node

2016-03-13 Thread Heiko Stuebner
Am Sonntag, 13. März 2016, 00:25:53 schrieb Shawn Lin: > rockchip_clk_of_add_provider is used by sub-clk driver which > already call of_iomap before calling it. If device_node does > not exist, of_iomap returns NULL which will fail to init the > sub-clk driver. So really it's redundant. > >

Re: [PATCH 2/7] clk: rockchip: fix warning reported by kernel-doc

2016-03-13 Thread Heiko Stuebner
Am Sonntag, 13. März 2016, 00:25:14 schrieb Shawn Lin: > ./scripts/kernel-doc -man -v drivers/clk/rockchip/clk.h > /dev/null > > drivers/clk/rockchip/clk.h:133: warning: missing initial short > description on line: > * struct rockchip_clk_provider: information about clock provider >

Re: [PATCH 6/7] clk: rockchip: remove redundant checking of device_node

2016-03-13 Thread Heiko Stuebner
Am Sonntag, 13. März 2016, 00:25:53 schrieb Shawn Lin: > rockchip_clk_of_add_provider is used by sub-clk driver which > already call of_iomap before calling it. If device_node does > not exist, of_iomap returns NULL which will fail to init the > sub-clk driver. So really it's redundant. > >

Re: [PATCH 2/7] clk: rockchip: fix warning reported by kernel-doc

2016-03-13 Thread Heiko Stuebner
Am Sonntag, 13. März 2016, 00:25:14 schrieb Shawn Lin: > ./scripts/kernel-doc -man -v drivers/clk/rockchip/clk.h > /dev/null > > drivers/clk/rockchip/clk.h:133: warning: missing initial short > description on line: > * struct rockchip_clk_provider: information about clock provider >

Re: [PATCH v2.1 3/9] net: arc_emac: support the phy reset for emac driver

2016-03-13 Thread Caesar Wang
在 2016年03月14日 02:02, David Miller 写道: When you submit a new version of a patch that's part of a series, you must submit the entire series anew, not just the patch which is changing. Thanks for reminding me. I think it's not good to respin-respin since the build error. So that just send a

Re: [PATCH v2.1 3/9] net: arc_emac: support the phy reset for emac driver

2016-03-13 Thread Caesar Wang
在 2016年03月14日 02:02, David Miller 写道: When you submit a new version of a patch that's part of a series, you must submit the entire series anew, not just the patch which is changing. Thanks for reminding me. I think it's not good to respin-respin since the build error. So that just send a

Re: [PATCH 1/7] clk: rockchip: remove mux_core_reg from rockchip_cpuclk_reg_data

2016-03-13 Thread Heiko Stuebner
Am Sonntag, 13. März 2016, 00:25:00 schrieb Shawn Lin: > mux_core_reg isn't been used anywhere, let's remove it. > > Signed-off-by: Shawn Lin applied for v4.7 Thanks Heiko

Re: [PATCH 1/7] clk: rockchip: remove mux_core_reg from rockchip_cpuclk_reg_data

2016-03-13 Thread Heiko Stuebner
Am Sonntag, 13. März 2016, 00:25:00 schrieb Shawn Lin: > mux_core_reg isn't been used anywhere, let's remove it. > > Signed-off-by: Shawn Lin applied for v4.7 Thanks Heiko

[PATCH v2 4/4] hwrng: exynos - Disable runtime PM on driver unbind

2016-03-13 Thread Krzysztof Kozlowski
Driver enabled runtime PM but did not revert this on removal. Re-binding of a device triggered warning: exynos-rng 10830400.rng: Unbalanced pm_runtime_enable! Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number generator") Signed-off-by: Krzysztof Kozlowski

[PATCH v2 4/4] hwrng: exynos - Disable runtime PM on driver unbind

2016-03-13 Thread Krzysztof Kozlowski
Driver enabled runtime PM but did not revert this on removal. Re-binding of a device triggered warning: exynos-rng 10830400.rng: Unbalanced pm_runtime_enable! Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number generator") Signed-off-by: Krzysztof Kozlowski ---

[PATCH v2 3/4] hwrng: exynos - Disable runtime PM on probe failure

2016-03-13 Thread Krzysztof Kozlowski
Add proper error path (for disabling runtime PM) when registering of hwrng fails. Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number generator") Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Call also

[PATCH v2 2/4] hwrng: exynos - Fix unbalanced PM runtime put on timeout error path

2016-03-13 Thread Krzysztof Kozlowski
In case of timeout during read operation, the exit path lacked PM runtime put. This could lead to unbalanced runtime PM usage counter thus leaving the device in an active state. Fixes: d7fd6075a205 ("hwrng: exynos - Add timeout for waiting on init done") Cc: # v4.4+

[PATCH v2 1/4] hwrng: exynos - Runtime suspend device after init

2016-03-13 Thread Krzysztof Kozlowski
The driver uses pm_runtime_put_noidle() after initialization so the device might remain in active state if the core does not read from it (the read callback contains regular runtime put). The put_noidle() was chosen probably to avoid unneeded suspend and resume cycle after the initialization.

[PATCH v2 3/4] hwrng: exynos - Disable runtime PM on probe failure

2016-03-13 Thread Krzysztof Kozlowski
Add proper error path (for disabling runtime PM) when registering of hwrng fails. Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number generator") Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Call also pm_runtime_dont_use_autosuspend() to revert everything

[PATCH v2 2/4] hwrng: exynos - Fix unbalanced PM runtime put on timeout error path

2016-03-13 Thread Krzysztof Kozlowski
In case of timeout during read operation, the exit path lacked PM runtime put. This could lead to unbalanced runtime PM usage counter thus leaving the device in an active state. Fixes: d7fd6075a205 ("hwrng: exynos - Add timeout for waiting on init done") Cc: # v4.4+ Signed-off-by: Krzysztof

[PATCH v2 1/4] hwrng: exynos - Runtime suspend device after init

2016-03-13 Thread Krzysztof Kozlowski
The driver uses pm_runtime_put_noidle() after initialization so the device might remain in active state if the core does not read from it (the read callback contains regular runtime put). The put_noidle() was chosen probably to avoid unneeded suspend and resume cycle after the initialization.

Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables

2016-03-13 Thread Scott Ashcroft
On Sun, 2016-03-13 at 23:07 +, Matt Fleming wrote: > On Sun, 13 Mar, at 09:58:47PM, Matt Fleming wrote: > > Does $(grep pdpe1gb /proc/cpuinfo) show any output on your machine? > Assuming the answer to this question is "no", can you try out this > patch? The answer is no. Attached is the dmesg

Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables

2016-03-13 Thread Scott Ashcroft
On Sun, 2016-03-13 at 23:07 +, Matt Fleming wrote: > On Sun, 13 Mar, at 09:58:47PM, Matt Fleming wrote: > > Does $(grep pdpe1gb /proc/cpuinfo) show any output on your machine? > Assuming the answer to this question is "no", can you try out this > patch? The answer is no. Attached is the dmesg

[PATCH] drivers/tty: make serial/mvebu-uart.c explicitly non-modular

2016-03-13 Thread Paul Gortmaker
The Kconfig currently controlling compilation of this code is: drivers/tty/serial/Kconfig:config SERIAL_MVEBU_UART drivers/tty/serial/Kconfig: bool "Marvell EBU serial port support" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is

Re: [PATCH v18 21/22] ext4: Add richacl support

2016-03-13 Thread Andreas Gruenbacher
On Fri, Mar 11, 2016 at 3:27 PM, Christoph Hellwig wrote: >> +static int >> +__ext4_set_richacl(handle_t *handle, struct inode *inode, struct richacl >> *acl) >> +{ >> + const int name_index = EXT4_XATTR_INDEX_RICHACL; >> + umode_t mode = inode->i_mode; >> + int

[PATCH] drivers/tty: make serial/mvebu-uart.c explicitly non-modular

2016-03-13 Thread Paul Gortmaker
The Kconfig currently controlling compilation of this code is: drivers/tty/serial/Kconfig:config SERIAL_MVEBU_UART drivers/tty/serial/Kconfig: bool "Marvell EBU serial port support" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is

Re: [PATCH v18 21/22] ext4: Add richacl support

2016-03-13 Thread Andreas Gruenbacher
On Fri, Mar 11, 2016 at 3:27 PM, Christoph Hellwig wrote: >> +static int >> +__ext4_set_richacl(handle_t *handle, struct inode *inode, struct richacl >> *acl) >> +{ >> + const int name_index = EXT4_XATTR_INDEX_RICHACL; >> + umode_t mode = inode->i_mode; >> + int retval, size; >> +

Re: [PATCH v2 2/2] mm, thp: avoid unnecessary swapin in khugepaged

2016-03-13 Thread Kirill A. Shutemov
On Sun, Mar 13, 2016 at 11:28:55AM +0200, Ebru Akagunduz wrote: > Currently khugepaged makes swapin readahead to improve > THP collapse rate. This patch checks vm statistics > to avoid workload of swapin, if unnecessary. So that > when system under pressure, khugepaged won't consume > resources to

Re: [PATCH v2 2/2] mm, thp: avoid unnecessary swapin in khugepaged

2016-03-13 Thread Kirill A. Shutemov
On Sun, Mar 13, 2016 at 11:28:55AM +0200, Ebru Akagunduz wrote: > Currently khugepaged makes swapin readahead to improve > THP collapse rate. This patch checks vm statistics > to avoid workload of swapin, if unnecessary. So that > when system under pressure, khugepaged won't consume > resources to

Re: [PATCH 2/2] block: create ioctl to discard-or-zeroout a range of blocks

2016-03-13 Thread Dave Chinner
On Fri, Mar 11, 2016 at 04:44:16PM -0800, Linus Torvalds wrote: > On Fri, Mar 11, 2016 at 4:35 PM, Theodore Ts'o wrote: > > > > At the end of the day it's about whether you trust the userspace > > program or not. > > There's a big difference between "give the user rope", and "tie

Re: [PATCH 2/2] block: create ioctl to discard-or-zeroout a range of blocks

2016-03-13 Thread Dave Chinner
On Fri, Mar 11, 2016 at 04:44:16PM -0800, Linus Torvalds wrote: > On Fri, Mar 11, 2016 at 4:35 PM, Theodore Ts'o wrote: > > > > At the end of the day it's about whether you trust the userspace > > program or not. > > There's a big difference between "give the user rope", and "tie the > rope in a

linux-next: manual merge of the vfs tree with Linus' tree

2016-03-13 Thread Stephen Rothwell
Hi Al, Today's linux-next merge of the vfs tree got a conflict in: fs/nfs/nfs4proc.c between commit: d9dfd8d74168 ("NFSv4: Fix a dentry leak on alias use") from Linus' tree and commit: 7635e19a39f6 ("replace d_add_unique() with saner primitive") from the vfs tree. I fixed it up (I

linux-next: manual merge of the vfs tree with Linus' tree

2016-03-13 Thread Stephen Rothwell
Hi Al, Today's linux-next merge of the vfs tree got a conflict in: fs/nfs/nfs4proc.c between commit: d9dfd8d74168 ("NFSv4: Fix a dentry leak on alias use") from Linus' tree and commit: 7635e19a39f6 ("replace d_add_unique() with saner primitive") from the vfs tree. I fixed it up (I

Re: [patch] mfd: lp8788-irq: uninitialized variable in irq handler

2016-03-13 Thread Kim, Milo
On 3/11/2016 5:11 PM, Dan Carpenter wrote: Instead to being true/false, the "handled" is true/uninitialized. Presumably this doesn't cause that many problems in real life because normally we handle the IRQ. Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver') Signed-off-by: Dan Carpenter

Re: [patch] mfd: lp8788-irq: uninitialized variable in irq handler

2016-03-13 Thread Kim, Milo
On 3/11/2016 5:11 PM, Dan Carpenter wrote: Instead to being true/false, the "handled" is true/uninitialized. Presumably this doesn't cause that many problems in real life because normally we handle the IRQ. Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver') Signed-off-by: Dan Carpenter

Re: [PATCH 1/3] pfn_t: Change the encoding

2016-03-13 Thread Dan Williams
On Sat, Mar 12, 2016 at 10:30 AM, Matthew Wilcox wrote: > On Fri, Mar 11, 2016 at 01:40:20PM -0800, Dan Williams wrote: >> On Fri, Mar 11, 2016 at 1:13 PM, Matthew Wilcox >> wrote: >> > By moving the flag bits to the bottom, we encourage

Re: [PATCH 1/3] pfn_t: Change the encoding

2016-03-13 Thread Dan Williams
On Sat, Mar 12, 2016 at 10:30 AM, Matthew Wilcox wrote: > On Fri, Mar 11, 2016 at 01:40:20PM -0800, Dan Williams wrote: >> On Fri, Mar 11, 2016 at 1:13 PM, Matthew Wilcox >> wrote: >> > By moving the flag bits to the bottom, we encourage commonality >> > between SGs with pages and those using

Re: [PATCH v18 21/22] ext4: Add richacl support

2016-03-13 Thread Andreas Gruenbacher
On Fri, Mar 11, 2016 at 3:27 PM, Christoph Hellwig wrote: >> +static inline int >> +ext4_acl_chmod(struct inode *inode, umode_t mode) >> +{ >> + if (IS_RICHACL(inode)) >> + return richacl_chmod(inode, inode->i_mode); >> + return posix_acl_chmod(inode,

Re: [PATCH v2 1/2] mm, vmstat: calculate particular vm event

2016-03-13 Thread Kirill A. Shutemov
On Sun, Mar 13, 2016 at 11:28:54AM +0200, Ebru Akagunduz wrote: > Currently, vmstat can calculate specific vm event with all_vm_events() > however it allocates all vm events to stack. This patch introduces > a helper to sum value of a specific vm event over all cpu, without > loading all the

Re: [PATCH v18 21/22] ext4: Add richacl support

2016-03-13 Thread Andreas Gruenbacher
On Fri, Mar 11, 2016 at 3:27 PM, Christoph Hellwig wrote: >> +static inline int >> +ext4_acl_chmod(struct inode *inode, umode_t mode) >> +{ >> + if (IS_RICHACL(inode)) >> + return richacl_chmod(inode, inode->i_mode); >> + return posix_acl_chmod(inode, inode->i_mode); >> +} > >

Re: [PATCH v2 1/2] mm, vmstat: calculate particular vm event

2016-03-13 Thread Kirill A. Shutemov
On Sun, Mar 13, 2016 at 11:28:54AM +0200, Ebru Akagunduz wrote: > Currently, vmstat can calculate specific vm event with all_vm_events() > however it allocates all vm events to stack. This patch introduces > a helper to sum value of a specific vm event over all cpu, without > loading all the

Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables

2016-03-13 Thread Matt Fleming
On Sun, 13 Mar, at 09:58:47PM, Matt Fleming wrote: > (Fixing Maarten's email address which I botched originally) > > On Sun, 13 Mar, at 05:09:35PM, Scott Ashcroft wrote: > > On Fri, 2016-03-11 at 11:19 +, Matt Fleming wrote: > > > Some machines have EFI regions in page zero (physical address

Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables

2016-03-13 Thread Matt Fleming
On Sun, 13 Mar, at 09:58:47PM, Matt Fleming wrote: > (Fixing Maarten's email address which I botched originally) > > On Sun, 13 Mar, at 05:09:35PM, Scott Ashcroft wrote: > > On Fri, 2016-03-11 at 11:19 +, Matt Fleming wrote: > > > Some machines have EFI regions in page zero (physical address

Re: [PATCH v18 00/22] Richacls (Core and Ext4)

2016-03-13 Thread Andreas Gruenbacher
On Sat, Mar 12, 2016 at 12:02 AM, Jeremy Allison wrote: > On Fri, Mar 11, 2016 at 02:05:16PM -0600, Steve French wrote: >> Sounds like I need to quickly rework the SMB3 ACL helper functions >> for cifs.ko >> >> Also do you know where is the current version of the corresponding >>

Re: [PATCH v18 00/22] Richacls (Core and Ext4)

2016-03-13 Thread Andreas Gruenbacher
On Sat, Mar 12, 2016 at 12:02 AM, Jeremy Allison wrote: > On Fri, Mar 11, 2016 at 02:05:16PM -0600, Steve French wrote: >> Sounds like I need to quickly rework the SMB3 ACL helper functions >> for cifs.ko >> >> Also do you know where is the current version of the corresponding >> vfs_richacl for

[PATCH v8 05/10] tpm: Split out the devm stuff from tpmm_chip_alloc

2016-03-13 Thread Stefan Berger
From: Jason Gunthorpe tpm_chip_alloc becomes a typical subsystem allocate call. Signed-off-by: Jason Gunthorpe Reviewed-by: Stefan Berger Tested-by: Stefan Berger

[PATCH v8 09/10] tpm: Initialize TPM and get durations and timeouts

2016-03-13 Thread Stefan Berger
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires the startup of the TPM, do this for TPM 1.2 and TPM 2. Signed-off-by: Stefan Berger CC: linux-kernel@vger.kernel.org CC: linux-...@vger.kernel.org CC: linux-...@vger.kernel.org ---

[PATCH v8 05/10] tpm: Split out the devm stuff from tpmm_chip_alloc

2016-03-13 Thread Stefan Berger
From: Jason Gunthorpe tpm_chip_alloc becomes a typical subsystem allocate call. Signed-off-by: Jason Gunthorpe Reviewed-by: Stefan Berger Tested-by: Stefan Berger Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 49

[PATCH v8 09/10] tpm: Initialize TPM and get durations and timeouts

2016-03-13 Thread Stefan Berger
Add the retrieval of TPM 1.2 durations and timeouts. Since this requires the startup of the TPM, do this for TPM 1.2 and TPM 2. Signed-off-by: Stefan Berger CC: linux-kernel@vger.kernel.org CC: linux-...@vger.kernel.org CC: linux-...@vger.kernel.org --- drivers/char/tpm/tpm_vtpm_proxy.c | 95

[PATCH v8 04/10] tpm: Get rid of module locking

2016-03-13 Thread Stefan Berger
Now that the tpm core has strong locking around 'ops' it is possible to remove a TPM driver, module and all, even while user space still has things like /dev/tpmX open. For consistency and simplicity, drop the module locking entirely. The module lock can be dropped since /dev/tpmX holds the

[PATCH v8 04/10] tpm: Get rid of module locking

2016-03-13 Thread Stefan Berger
Now that the tpm core has strong locking around 'ops' it is possible to remove a TPM driver, module and all, even while user space still has things like /dev/tpmX open. For consistency and simplicity, drop the module locking entirely. The module lock can be dropped since /dev/tpmX holds the

[PATCH v8 03/10] tpm: Provide strong locking for device removal

2016-03-13 Thread Stefan Berger
From: Jason Gunthorpe Add a read/write semaphore around the ops function pointers so ops can be set to null when the driver un-registers. Previously the tpm core expected module locking to be enough to ensure that tpm_unregister could not be called during

[PATCH v8 01/10] tpm: Get rid of chip->pdev

2016-03-13 Thread Stefan Berger
From: Jason Gunthorpe This is a hold over from before the struct device conversion. - All prints should be using >dev, which is the Linux standard. This changes prints to use tpm0 as the device name, not the PnP/etc ID. - The few places involving

[PATCH v8 10/10] tpm: Add documentation for the tpm_vtpm device driver

2016-03-13 Thread Stefan Berger
Add documentation for the tpm_vtpm device driver that implements support for providing TPM functionality to Linux containers. Parts of this documentation were recycled from the Xen vTPM device driver documentation. Update the documentation for the ioctl numbers. Signed-off-by: Stefan Berger

[PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs

2016-03-13 Thread Stefan Berger
This patch implements a proxy driver for supporting multiple emulated TPMs in a system. The driver implements a device /dev/vtpmx that is used to created a client device pair /dev/tpmX (e.g., /dev/tpm10) and a server side that is accessed using a file descriptor returned by an ioctl. The device

[PATCH v8 00/10] Multi-instance vTPM proxy driver

2016-03-13 Thread Stefan Berger
The following series of patches implements a multi-instance vTPM proxy driver that can dynamically create TPM 'server' and client device pairs. Using an ioctl on the provided /dev/vtpmx, a client-side vTPM device and a server side file descriptor is created. The file descriptor must be passed to

[PATCH v8 03/10] tpm: Provide strong locking for device removal

2016-03-13 Thread Stefan Berger
From: Jason Gunthorpe Add a read/write semaphore around the ops function pointers so ops can be set to null when the driver un-registers. Previously the tpm core expected module locking to be enough to ensure that tpm_unregister could not be called during certain times, however that hasn't been

[PATCH v8 01/10] tpm: Get rid of chip->pdev

2016-03-13 Thread Stefan Berger
From: Jason Gunthorpe This is a hold over from before the struct device conversion. - All prints should be using >dev, which is the Linux standard. This changes prints to use tpm0 as the device name, not the PnP/etc ID. - The few places involving sysfs/modules that really do need the

[PATCH v8 10/10] tpm: Add documentation for the tpm_vtpm device driver

2016-03-13 Thread Stefan Berger
Add documentation for the tpm_vtpm device driver that implements support for providing TPM functionality to Linux containers. Parts of this documentation were recycled from the Xen vTPM device driver documentation. Update the documentation for the ioctl numbers. Signed-off-by: Stefan Berger

<    1   2   3   4   5   6   7   >