[PATCH net] net: sched: do not requeue a NULL skb

2016-04-06 Thread Lars Persson
A failure in validate_xmit_skb_list() triggered an unconditional call to dev_requeue_skb with skb=NULL. This slowly grows the queue discipline's qlen count until all traffic through the queue stops. Fixes: 55a93b3ea780 ("qdisc: validate skb without holding lock") Signed-off-by: Lars Persson

[PATCH net] net: sched: do not requeue a NULL skb

2016-04-06 Thread Lars Persson
A failure in validate_xmit_skb_list() triggered an unconditional call to dev_requeue_skb with skb=NULL. This slowly grows the queue discipline's qlen count until all traffic through the queue stops. Fixes: 55a93b3ea780 ("qdisc: validate skb without holding lock") Signed-off-by: Lars Persson ---

Re: [PATCH] sched/deadline: No need to check NULL later_mask

2016-04-06 Thread Xunlei Pang
On 2016/04/06 at 17:30, Peter Zijlstra wrote: > On Sat, Apr 02, 2016 at 06:14:28PM +0800, Xunlei Pang wrote: >> Your proposal is very nice! >> >> At the sched_init() stage we only have one (to be "idle") task and with irq >> disabled, >> no scheduling will happen, and the cpu_possible_mask was

Re: [PATCH] sched/deadline: No need to check NULL later_mask

2016-04-06 Thread Xunlei Pang
On 2016/04/06 at 17:30, Peter Zijlstra wrote: > On Sat, Apr 02, 2016 at 06:14:28PM +0800, Xunlei Pang wrote: >> Your proposal is very nice! >> >> At the sched_init() stage we only have one (to be "idle") task and with irq >> disabled, >> no scheduling will happen, and the cpu_possible_mask was

[PATCH] rtmutex: Consider deadline tasks in try_to_take_rt_mutex()

2016-04-06 Thread Xunlei Pang
If mutliple tasks contest try_to_take_rt_mutex(), it should let the high-priority task acquire the lock, but it misses the deadline tasks in the following condition: if (task->prio >= rt_mutex_top_waiter(lock)->prio) return 0; Deadline tasks all have "-1" prio, so above logic will

[PATCH] rtmutex: Consider deadline tasks in try_to_take_rt_mutex()

2016-04-06 Thread Xunlei Pang
If mutliple tasks contest try_to_take_rt_mutex(), it should let the high-priority task acquire the lock, but it misses the deadline tasks in the following condition: if (task->prio >= rt_mutex_top_waiter(lock)->prio) return 0; Deadline tasks all have "-1" prio, so above logic will

Re: [RFC PATCH v1.9 05/14] sched: horrible way to detect whether a task has been preempted

2016-04-06 Thread Petr Mladek
On Fri 2016-03-25 14:34:52, Josh Poimboeuf wrote: > This is a horrible way to detect whether a task has been preempted. > Come up with something better: task flag? or is there already an > existing mechanism? What about using kallsyms_lookup_size_offset() to check the address. It is more

Re: [RFC PATCH v1.9 05/14] sched: horrible way to detect whether a task has been preempted

2016-04-06 Thread Petr Mladek
On Fri 2016-03-25 14:34:52, Josh Poimboeuf wrote: > This is a horrible way to detect whether a task has been preempted. > Come up with something better: task flag? or is there already an > existing mechanism? What about using kallsyms_lookup_size_offset() to check the address. It is more

Re: [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

2016-04-06 Thread Andy Shevchenko
On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote: > This patchset adds gpio-signaled acpi events support for power button on > hisilicon > D02 board. > > The three patches respectively: > - remove name from dwapb_port_property > - convert device node to fwnode

Re: [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

2016-04-06 Thread Andy Shevchenko
On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote: > This patchset adds gpio-signaled acpi events support for power button on > hisilicon > D02 board. > > The three patches respectively: > - remove name from dwapb_port_property > - convert device node to fwnode > - add

Re: [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode

2016-04-06 Thread Andy Shevchenko
On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote: > This patch converts device node to fwnode for dwapb driver, so > as to provide a unified fwnode for DT and ACPI bindings. > > Acked-by: Andy Shevchenko > Signed-off-by: qiujiang

Re: [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode

2016-04-06 Thread Andy Shevchenko
On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote: > This patch converts device node to fwnode for dwapb driver, so > as to provide a unified fwnode for DT and ACPI bindings. > > Acked-by: Andy Shevchenko > Signed-off-by: qiujiang > static struct dwapb_platform_data * >

Re: [PATCH v3 13/16] zsmalloc: migrate head page of zspage

2016-04-06 Thread Chulmin Kim
On 2016년 03월 30일 16:12, Minchan Kim wrote: This patch introduces run-time migration feature for zspage. To begin with, it supports only head page migration for easy review(later patches will support tail page migration). For migration, it supports three functions * zs_page_isolate It isolates

Re: [PATCH v3 13/16] zsmalloc: migrate head page of zspage

2016-04-06 Thread Chulmin Kim
On 2016년 03월 30일 16:12, Minchan Kim wrote: This patch introduces run-time migration feature for zspage. To begin with, it supports only head page migration for easy review(later patches will support tail page migration). For migration, it supports three functions * zs_page_isolate It isolates

[PATCH v2 1/2] sched/rtmutex/deadline: Fix a PI crash for deadline tasks

2016-04-06 Thread Xunlei Pang
A crash happened while I'm playing with deadline PI rtmutex. BUG: unable to handle kernel NULL pointer dereference at 0018 IP: [] rt_mutex_get_top_task+0x1f/0x30 PGD 232a75067 PUD 230947067 PMD 0 Oops: [#1] SMP CPU: 1 PID: 10994 Comm: a.out Not tainted

[PATCH v2 1/2] sched/rtmutex/deadline: Fix a PI crash for deadline tasks

2016-04-06 Thread Xunlei Pang
A crash happened while I'm playing with deadline PI rtmutex. BUG: unable to handle kernel NULL pointer dereference at 0018 IP: [] rt_mutex_get_top_task+0x1f/0x30 PGD 232a75067 PUD 230947067 PMD 0 Oops: [#1] SMP CPU: 1 PID: 10994 Comm: a.out Not tainted

[PATCH v2 2/2] rtmutex: Kill pi_waiters_leftmost from task_struct

2016-04-06 Thread Xunlei Pang
Current code use pi_waiters_leftmost to record the leftmost waiter, but actually it can be get directly from task_struct::pi_waiters using rb_first(). The performance penalty introduced by rb_first() should be fine, because normally there aren't that many rtmutexes chained together for one task.

[PATCH v2 2/2] rtmutex: Kill pi_waiters_leftmost from task_struct

2016-04-06 Thread Xunlei Pang
Current code use pi_waiters_leftmost to record the leftmost waiter, but actually it can be get directly from task_struct::pi_waiters using rb_first(). The performance penalty introduced by rb_first() should be fine, because normally there aren't that many rtmutexes chained together for one task.

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

2016-04-06 Thread Felipe Balbi
Hi, Jun Li writes: >> >> On 6 April 2016 at 15:19, Peter Chen wrote: >> >> > On Fri, Apr 01, 2016 at 03:21:50PM +0800, Baolin Wang wrote: >> >> >> >> >> >> @@ -563,6 +564,8 @@ struct usb_gadget_ops { >> >> >> struct usb_ep *(*match_ep)(struct

Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property

2016-04-06 Thread Andy Shevchenko
On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote: > This patch removed the name property from dwapb_port_property. > The name property is redundant because we can get those info > from dwapb_gpio dev and pp->idx property. Where idx is used in such replacements? > ---

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

2016-04-06 Thread Felipe Balbi
Hi, Jun Li writes: >> >> On 6 April 2016 at 15:19, Peter Chen wrote: >> >> > On Fri, Apr 01, 2016 at 03:21:50PM +0800, Baolin Wang wrote: >> >> >> >> >> >> @@ -563,6 +564,8 @@ struct usb_gadget_ops { >> >> >> struct usb_ep *(*match_ep)(struct usb_gadget *, >> >> >>

Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property

2016-04-06 Thread Andy Shevchenko
On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote: > This patch removed the name property from dwapb_port_property. > The name property is redundant because we can get those info > from dwapb_gpio dev and pp->idx property. Where idx is used in such replacements? > --- a/drivers/gpio/gpio-dwapb.c

Re: [PATCH] PKCS#7: fix missing break on OID_sha224 case

2016-04-06 Thread David Howells
Colin King wrote: > From: Colin Ian King > > The OID_sha224 case is missing a break and it falls through > to the -ENOPKG error default. Since HASH_ALGO_SHA224 seems > to be supported, this looks like an unintentional missing break. > >

Re: [PATCH] PKCS#7: fix missing break on OID_sha224 case

2016-04-06 Thread David Howells
Colin King wrote: > From: Colin Ian King > > The OID_sha224 case is missing a break and it falls through > to the -ENOPKG error default. Since HASH_ALGO_SHA224 seems > to be supported, this looks like an unintentional missing break. > > Fixes: 07f081fb5057 ("PKCS#7: Add OIDs for sha224,

Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void

2016-04-06 Thread Andrew Lunn
On Tue, Apr 05, 2016 at 11:14:54PM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > >>mutex_lock(>smi_mutex); > >> - ret = _mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state); > >> + if (_mv88e6xxx_port_fdb_load(ds, port, fdb->addr,

Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void

2016-04-06 Thread Andrew Lunn
On Tue, Apr 05, 2016 at 11:14:54PM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > >>mutex_lock(>smi_mutex); > >> - ret = _mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state); > >> + if (_mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state)) > >> +

[PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-06 Thread Sjoerd Simons
clk_get on a disabled clock node will return EPROBE_DEFER, which can cause drivers to be deferred forever if such clocks are referenced in their clocks property. Update the various disabled external clock nodes to default to a frequency of 0, but don't disable them to prevent this.

Re: [PATCH 1/2] phy: Group vendor specific phy drivers

2016-04-06 Thread Kishon Vijay Abraham I
Hi, On Friday 01 April 2016 07:05 PM, Vivek Gautam wrote: > Hi, > > > On Fri, Apr 1, 2016 at 6:05 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Friday 01 April 2016 04:59 PM, Vivek Gautam wrote: >>> Adding vendor specific directories in phy to group >>> phy drivers under

[PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-06 Thread Sjoerd Simons
clk_get on a disabled clock node will return EPROBE_DEFER, which can cause drivers to be deferred forever if such clocks are referenced in their clocks property. Update the various disabled external clock nodes to default to a frequency of 0, but don't disable them to prevent this.

Re: [PATCH 1/2] phy: Group vendor specific phy drivers

2016-04-06 Thread Kishon Vijay Abraham I
Hi, On Friday 01 April 2016 07:05 PM, Vivek Gautam wrote: > Hi, > > > On Fri, Apr 1, 2016 at 6:05 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Friday 01 April 2016 04:59 PM, Vivek Gautam wrote: >>> Adding vendor specific directories in phy to group >>> phy drivers under their respective

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

2016-04-06 Thread Jun Li
> -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Wednesday, April 06, 2016 8:22 PM > To: Jun Li ; Baolin Wang ; Peter > Chen > Cc: Greg KH ; Sebastian Reichel >

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

2016-04-06 Thread Jun Li
> -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Wednesday, April 06, 2016 8:22 PM > To: Jun Li ; Baolin Wang ; Peter > Chen > Cc: Greg KH ; Sebastian Reichel > ; Dmitry Eremin-Solenikov ; David > Woodhouse ; Peter Chen ; > Alan Stern ; r.bald...@samsung.com;

Re: [PATCH 2/3] phy: rcar-gen3-usb2: Add vbus-supply to handle VBUS on/off

2016-04-06 Thread Kishon Vijay Abraham I
Hi, On Wednesday 06 April 2016 05:55 AM, Yoshihiro Shimoda wrote: > Hi, > >> From: Kishon Vijay Abraham I >> Sent: Tuesday, April 05, 2016 7:54 PM >> >> Hi, >> >> On Thursday 03 March 2016 03:39 PM, Yoshihiro Shimoda wrote: >>> To handle the VBUS on/off by a regulator driver, this patch adds >>>

Re: [PATCH 2/3] phy: rcar-gen3-usb2: Add vbus-supply to handle VBUS on/off

2016-04-06 Thread Kishon Vijay Abraham I
Hi, On Wednesday 06 April 2016 05:55 AM, Yoshihiro Shimoda wrote: > Hi, > >> From: Kishon Vijay Abraham I >> Sent: Tuesday, April 05, 2016 7:54 PM >> >> Hi, >> >> On Thursday 03 March 2016 03:39 PM, Yoshihiro Shimoda wrote: >>> To handle the VBUS on/off by a regulator driver, this patch adds >>>

[PATCH 0/2] perf probe fixes for ppc64le

2016-04-06 Thread Naveen N. Rao
This patchset fixes three issues found with perf probe on ppc64le: 1. 'perf test kallsyms' failure on ppc64le (reported by Michael Ellerman). This was due to the symbols being fixed up during symbol table load. This is fixed in patch 2 by delaying symbol fixup until later. 2. perf probe function

[PATCH 0/2] perf probe fixes for ppc64le

2016-04-06 Thread Naveen N. Rao
This patchset fixes three issues found with perf probe on ppc64le: 1. 'perf test kallsyms' failure on ppc64le (reported by Michael Ellerman). This was due to the symbols being fixed up during symbol table load. This is fixed in patch 2 by delaying symbol fixup until later. 2. perf probe function

Re: [PATCH v10 4/9] phy: Add Tegra XUSB pad controller support

2016-04-06 Thread Kishon Vijay Abraham I
Hi, On Friday 04 March 2016 09:49 PM, Thierry Reding wrote: > From: Thierry Reding > > Add a new driver for the XUSB pad controller found on NVIDIA Tegra SoCs. > This hardware block used to be exposed as a pin controller, but it turns > out that this isn't a good fit. The

Re: [PATCH v10 4/9] phy: Add Tegra XUSB pad controller support

2016-04-06 Thread Kishon Vijay Abraham I
Hi, On Friday 04 March 2016 09:49 PM, Thierry Reding wrote: > From: Thierry Reding > > Add a new driver for the XUSB pad controller found on NVIDIA Tegra SoCs. > This hardware block used to be exposed as a pin controller, but it turns > out that this isn't a good fit. The new driver and DT

[PATCH] neigh: remove duplicated log msg

2016-04-06 Thread Abdelmajid Mlayeh
From: Abdelmajid MLAYEH This will be printed anyways by neigh_suspect Signed-off-by: Abdelmajid Mlayeh --- net/core/neighbour.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index

[PATCH] neigh: remove duplicated log msg

2016-04-06 Thread Abdelmajid Mlayeh
From: Abdelmajid MLAYEH This will be printed anyways by neigh_suspect Signed-off-by: Abdelmajid Mlayeh --- net/core/neighbour.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index f18ae91..bf20118 100644 --- a/net/core/neighbour.c +++

Re: [PATCH v2 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-06 Thread Adrian Hunter
On 04/04/16 18:27, Ludovic Desroches wrote: > In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to > reduce code duplication, put the code relative to the SD clock > configuration in a function which can be used by hosts for the > implementation of the set_clock() callback. > >

Re: [PATCH v2 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-06 Thread Adrian Hunter
On 04/04/16 18:27, Ludovic Desroches wrote: > In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to > reduce code duplication, put the code relative to the SD clock > configuration in a function which can be used by hosts for the > implementation of the set_clock() callback. > >

Re: [RFC PATCH] mm, oom: move GFP_NOFS check to out_of_memory

2016-04-06 Thread Michal Hocko
On Tue 05-04-16 20:12:51, Tetsuo Handa wrote: [...] > What I can observe under OOM livelock condition is a three-way dependency > loop. > > (1) An OOM victim (which has TIF_MEMDIE) is unable to make forward progress > due to blocked at unkillable lock waiting for other thread's memory >

Re: [RFC PATCH] mm, oom: move GFP_NOFS check to out_of_memory

2016-04-06 Thread Michal Hocko
On Tue 05-04-16 20:12:51, Tetsuo Handa wrote: [...] > What I can observe under OOM livelock condition is a three-way dependency > loop. > > (1) An OOM victim (which has TIF_MEMDIE) is unable to make forward progress > due to blocked at unkillable lock waiting for other thread's memory >

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-04-06 Thread Sergei Shtylyov
Hello. On 4/6/2016 9:44 AM, Lu Baolu wrote: +struct intel_mux_dev { + struct device *dev; + char*extcon_name; + char*cable_name; + int (*cable_set_cb)(struct intel_mux_dev *mux); + int (*cable_unset_cb)(struct

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-04-06 Thread Sergei Shtylyov
Hello. On 4/6/2016 9:44 AM, Lu Baolu wrote: +struct intel_mux_dev { + struct device *dev; + char*extcon_name; + char*cable_name; + int (*cable_set_cb)(struct intel_mux_dev *mux); + int (*cable_unset_cb)(struct

Re: [patch] remove unnecessary code in hyperv.c

2016-04-06 Thread Radim Krčmář
2016-04-06 10:21+0800, rhett rhett: > 8499907b52c9cebf3c1a4aaa63b84bd9c3c1ff3d > arch/x86/kvm/hyperv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c > index 01bd7b7..e831032 100644 > --- a/arch/x86/kvm/hyperv.c > +++ b/arch/x86/kvm/hyperv.c

Re: [patch] remove unnecessary code in hyperv.c

2016-04-06 Thread Radim Krčmář
2016-04-06 10:21+0800, rhett rhett: > 8499907b52c9cebf3c1a4aaa63b84bd9c3c1ff3d > arch/x86/kvm/hyperv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c > index 01bd7b7..e831032 100644 > --- a/arch/x86/kvm/hyperv.c > +++ b/arch/x86/kvm/hyperv.c

Re: [PART1 RFC v3 12/12] svm: Manage vcpu load/unload when enable AVIC

2016-04-06 Thread Radim Krčmář
2016-04-06 10:40+0700, Suravee Suthikulpanit: > On 04/05/2016 09:56 PM, Radim Krčmář wrote: >>I meant to change the place where we remember that is_running must not >>be true. Something like >> >> svm_vcpu_blocking(struct kvm_vcpu *vcpu): >> vcpu->is_blocking = true; >>

Re: [PART1 RFC v3 12/12] svm: Manage vcpu load/unload when enable AVIC

2016-04-06 Thread Radim Krčmář
2016-04-06 10:40+0700, Suravee Suthikulpanit: > On 04/05/2016 09:56 PM, Radim Krčmář wrote: >>I meant to change the place where we remember that is_running must not >>be true. Something like >> >> svm_vcpu_blocking(struct kvm_vcpu *vcpu): >> vcpu->is_blocking = true; >>

Re: [PATCH v10 11/17] ARM: XEN: Move xen_early_init() before efi_init()

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: Move xen_early_init() before efi_init(), then when calling efi_init() could initialize Xen specific UEFI. Check if it runs on Xen hypervisor through the flat dts. Cc: Russell King Signed-off-by: Shannon Zhao

[PATCH 1/2] perf/powerpc: Fix kprobe and kretprobe handling with kallsyms

2016-04-06 Thread Naveen N. Rao
So far, we used to treat probe point offsets as being offset from the LEP. However, userspace applications (objdump/readelf) always show disassembly and offsets from the function GEP. This is confusing to the user as we will end up probing at an address different from what the user expects when

Re: [PATCH v10 11/17] ARM: XEN: Move xen_early_init() before efi_init()

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: Move xen_early_init() before efi_init(), then when calling efi_init() could initialize Xen specific UEFI. Check if it runs on Xen hypervisor through the flat dts. Cc: Russell King Signed-off-by: Shannon Zhao Reviewed-by: Stefano

[PATCH 1/2] perf/powerpc: Fix kprobe and kretprobe handling with kallsyms

2016-04-06 Thread Naveen N. Rao
So far, we used to treat probe point offsets as being offset from the LEP. However, userspace applications (objdump/readelf) always show disassembly and offsets from the function GEP. This is confusing to the user as we will end up probing at an address different from what the user expects when

[PATCH 2/2] tools/perf: Fix kallsyms perf test on ppc64le

2016-04-06 Thread Naveen N. Rao
ppc64le functions have a Global Entry Point (GEP) and a Local Entry Point (LEP). While placing a probe, we always prefer the LEP since it catches function calls through both the GEP and the LEP. In order to do this, we fixup the function entry points during elf symbol table lookup to point to the

[PATCH 2/2] tools/perf: Fix kallsyms perf test on ppc64le

2016-04-06 Thread Naveen N. Rao
ppc64le functions have a Global Entry Point (GEP) and a Local Entry Point (LEP). While placing a probe, we always prefer the LEP since it catches function calls through both the GEP and the LEP. In order to do this, we fixup the function entry points during elf symbol table lookup to point to the

Re: [PATCH] staging: rts5208: ensure braces on all arms of if stmt

2016-04-06 Thread Dan Carpenter
On Tue, Apr 05, 2016 at 05:29:17PM +0100, Nicholas Sim wrote: > Added braces on if arm of if statement where else arm already needs braces > as suggested for clarity in Documentation/CodingStyle > > Signed-off-by: Nicholas Sim > --- > drivers/staging/rts5208/ms.c | 3

Re: [PATCH] staging: rts5208: ensure braces on all arms of if stmt

2016-04-06 Thread Dan Carpenter
On Tue, Apr 05, 2016 at 05:29:17PM +0100, Nicholas Sim wrote: > Added braces on if arm of if statement where else arm already needs braces > as suggested for clarity in Documentation/CodingStyle > > Signed-off-by: Nicholas Sim > --- > drivers/staging/rts5208/ms.c | 3 ++- > 1 file changed, 2

Re: [PATCH v10 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: The kernel will get the event-channel IRQ through HVM_PARAM_CALLBACK_IRQ. Signed-off-by: Shannon Zhao Reviewed-by: Stefano Stabellini Reviewed-by: Julien Grall

RE: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

2016-04-06 Thread Machani, Yaniv
On Wed, Apr 06, 2016 at 15:12:43, Pali Rohár wrote: > > > > For other TI wilink chips there are -ap.bin firmware files > > > > (wl1271-fw-ap.bin and wl128x-fw-ap.bin) which support AP mode. > > > > But for > > > > wl1251 firmware file with guessed name "wl1251-fw-ap.bin" is > > > > missing. > >

Re: [PATCH v10 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: The kernel will get the event-channel IRQ through HVM_PARAM_CALLBACK_IRQ. Signed-off-by: Shannon Zhao Reviewed-by: Stefano Stabellini Reviewed-by: Julien Grall Regards, -- Julien Grall

RE: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

2016-04-06 Thread Machani, Yaniv
On Wed, Apr 06, 2016 at 15:12:43, Pali Rohár wrote: > > > > For other TI wilink chips there are -ap.bin firmware files > > > > (wl1271-fw-ap.bin and wl128x-fw-ap.bin) which support AP mode. > > > > But for > > > > wl1251 firmware file with guessed name "wl1251-fw-ap.bin" is > > > > missing. > >

Re: [RFC6 PATCH v6 00/21] ILP32 for ARM64

2016-04-06 Thread Yury Norov
Hi Geert, On Wed, Apr 06, 2016 at 08:51:50AM +0200, Geert Uytterhoeven wrote: > Hi Yuri, > > On Wed, Apr 6, 2016 at 12:08 AM, Yury Norov wrote: > > This version is rebased on kernel v4.6-rc2, and has fixes in signal > > subsystem. > > It works with updated glibc [1]

Re: [PREEMPT-RT] [PATCH] MIPS: Remove no longer needed work_on_cpu() call

2016-04-06 Thread Ralf Baechle
On Tue, Apr 05, 2016 at 03:26:11PM +0200, Anna-Maria Gleixner wrote: > On Mon, 4 Apr 2016, Ralf Baechle wrote: > > > On Mon, Apr 04, 2016 at 02:18:03PM +0200, Anna-Maria Gleixner wrote: > > > > > Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to > > > hotplugged cpu") it is ensured

RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space

2016-04-06 Thread Felipe Balbi
Hi, (please make sure to break your lines at 80-characters. Documentation/email-clients.txt has several tips for different email clients ;-)) "Du, Changbin" writes: >> > @@ -648,6 +687,12 @@ int dwc3_debugfs_init(struct dwc3 *dwc) >> >goto err1; >> >} >>

Re: [RFC6 PATCH v6 00/21] ILP32 for ARM64

2016-04-06 Thread Yury Norov
Hi Geert, On Wed, Apr 06, 2016 at 08:51:50AM +0200, Geert Uytterhoeven wrote: > Hi Yuri, > > On Wed, Apr 6, 2016 at 12:08 AM, Yury Norov wrote: > > This version is rebased on kernel v4.6-rc2, and has fixes in signal > > subsystem. > > It works with updated glibc [1] (though very draft), and

Re: [PREEMPT-RT] [PATCH] MIPS: Remove no longer needed work_on_cpu() call

2016-04-06 Thread Ralf Baechle
On Tue, Apr 05, 2016 at 03:26:11PM +0200, Anna-Maria Gleixner wrote: > On Mon, 4 Apr 2016, Ralf Baechle wrote: > > > On Mon, Apr 04, 2016 at 02:18:03PM +0200, Anna-Maria Gleixner wrote: > > > > > Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to > > > hotplugged cpu") it is ensured

RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space

2016-04-06 Thread Felipe Balbi
Hi, (please make sure to break your lines at 80-characters. Documentation/email-clients.txt has several tips for different email clients ;-)) "Du, Changbin" writes: >> > @@ -648,6 +687,12 @@ int dwc3_debugfs_init(struct dwc3 *dwc) >> >goto err1; >> >} >> > >> > + file =

Re: [PATCH v10 09/17] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: This new delivery type which is for ARM shares the same value with HVM_PARAM_CALLBACK_TYPE_VECTOR which is for x86. val[15:8] is flag: val[7:0] is a PPI. To the flag, bit 8 stands the interrupt mode is edge(1) or level(0) and bit 9 stands

Re: [PATCH v10 09/17] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: This new delivery type which is for ARM shares the same value with HVM_PARAM_CALLBACK_TYPE_VECTOR which is for x86. val[15:8] is flag: val[7:0] is a PPI. To the flag, bit 8 stands the interrupt mode is edge(1) or level(0) and bit 9 stands

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

2016-04-06 Thread Felipe Balbi
Hi, Jun Li writes: >> -Original Message- >> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- >> ow...@vger.kernel.org] On Behalf Of Baolin Wang >> Sent: Wednesday, April 06, 2016 6:47 PM >> To: Peter Chen >> Cc: Felipe Balbi

Re: [PATCH v10 07/17] Xen: ARM: Add support for mapping AMBA device mmio

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: Add a bus_notifier for AMBA bus device in order to map the device mmio regions when DOM0 booting with ACPI. Signed-off-by: Shannon Zhao Reviewed-by: Stefano Stabellini

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

2016-04-06 Thread Felipe Balbi
Hi, Jun Li writes: >> -Original Message- >> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- >> ow...@vger.kernel.org] On Behalf Of Baolin Wang >> Sent: Wednesday, April 06, 2016 6:47 PM >> To: Peter Chen >> Cc: Felipe Balbi ; Greg KH ; >> Sebastian Reichel ; Dmitry

Re: [PATCH v10 07/17] Xen: ARM: Add support for mapping AMBA device mmio

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: Add a bus_notifier for AMBA bus device in order to map the device mmio regions when DOM0 booting with ACPI. Signed-off-by: Shannon Zhao Reviewed-by: Stefano Stabellini Reviewed-by: Julien Grall Regards, -- Julien Grall

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

2016-04-06 Thread Xunlei Pang
On 2016/03/31 at 11:52, Xunlei Pang wrote: > Hi Bao, > > On 2016/03/31 at 10:52, Baoquan He wrote: >> On 03/31/16 at 10:43am, Minfei Huang wrote: >>> On 03/30/16 at 08:30pm, Baoquan He wrote: Hi Xunlei, I have two questions. One is do we still need Minfei's patch if this

Re: [PATCH] s390/kexec: Consolidate crash_map/unmap_reserved_pages() and arch_kexec_protect(unprotect)_crashkres()

2016-04-06 Thread Xunlei Pang
On 2016/03/31 at 11:52, Xunlei Pang wrote: > Hi Bao, > > On 2016/03/31 at 10:52, Baoquan He wrote: >> On 03/31/16 at 10:43am, Minfei Huang wrote: >>> On 03/30/16 at 08:30pm, Baoquan He wrote: Hi Xunlei, I have two questions. One is do we still need Minfei's patch if this

[PATCH] arch:blackfin:adis162** cleanup

2016-04-06 Thread Valentin Rothberg
Remove dead #if blocks referencing previously removed Kconfig options. Signed-off-by: Valentin Rothberg --- arch/blackfin/mach-bf537/boards/stamp.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/arch/blackfin/mach-bf537/boards/stamp.c

[PATCH] arch:blackfin:adis162** cleanup

2016-04-06 Thread Valentin Rothberg
Remove dead #if blocks referencing previously removed Kconfig options. Signed-off-by: Valentin Rothberg --- arch/blackfin/mach-bf537/boards/stamp.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/arch/blackfin/mach-bf537/boards/stamp.c

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

2016-04-06 Thread Jun Li
Hi > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Baolin Wang > Sent: Wednesday, April 06, 2016 6:47 PM > To: Peter Chen > Cc: Felipe Balbi ; Greg KH

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

2016-04-06 Thread Jun Li
Hi > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Baolin Wang > Sent: Wednesday, April 06, 2016 6:47 PM > To: Peter Chen > Cc: Felipe Balbi ; Greg KH ; > Sebastian Reichel ; Dmitry Eremin-Solenikov > ; David Woodhouse

Re: [PATCH v10 06/17] Xen: ARM: Add support for mapping platform device mmio

2016-04-06 Thread Julien Grall
Hi Shannon, Sorry to come late in the review process. On 01/04/2016 16:49, Shannon Zhao wrote: Add a bus_notifier for platform bus device in order to map the device mmio regions when DOM0 booting with ACPI. Signed-off-by: Shannon Zhao Acked-by: Stefano Stabellini

Re: [PATCH v10 06/17] Xen: ARM: Add support for mapping platform device mmio

2016-04-06 Thread Julien Grall
Hi Shannon, Sorry to come late in the review process. On 01/04/2016 16:49, Shannon Zhao wrote: Add a bus_notifier for platform bus device in order to map the device mmio regions when DOM0 booting with ACPI. Signed-off-by: Shannon Zhao Acked-by: Stefano Stabellini --- drivers/xen/Makefile

[PATCH 2/7] cpufreq: Loongson1: Update cpufreq of Loongson1B

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung - Rename the file to loongson1-cpufreq.c - Use kcalloc() instead of kzalloc() - Use devm_kzalloc() instead of global structure - Use dev_get_platdata() to access the platform_data field instead of referencing it directly - Remove superfluous error

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

2016-04-06 Thread Pali Rohár
On Wednesday 06 April 2016 13:30:22 Machani, Yaniv wrote: > On Mon, Apr 04, 2016 at 15:39:44, Pali Rohár wrote: > > > In linux-firmware repository [1] is missing AP firmware for TI > > > wl1251 chip. There is only STA firmware wl1251-fw.bin which > > > supports managed and ad-hoc modes. > > > > >

Re: [PATCH RFC] sched/fair: let cpu's cfs_rq to reflect task migration

2016-04-06 Thread Vincent Guittot
On 6 April 2016 at 10:37, Morten Rasmussen wrote: > On Tue, Apr 05, 2016 at 06:00:40PM +0100, Dietmar Eggemann wrote: >> @@ -2893,8 +2906,12 @@ static void attach_entity_load_avg(struct cfs_rq >> *cfs_rq, struct sched_entity *s >> se->avg.last_update_time =

[PATCH 2/7] cpufreq: Loongson1: Update cpufreq of Loongson1B

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung - Rename the file to loongson1-cpufreq.c - Use kcalloc() instead of kzalloc() - Use devm_kzalloc() instead of global structure - Use dev_get_platdata() to access the platform_data field instead of referencing it directly - Remove superfluous error messages Signed-off-by:

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

2016-04-06 Thread Pali Rohár
On Wednesday 06 April 2016 13:30:22 Machani, Yaniv wrote: > On Mon, Apr 04, 2016 at 15:39:44, Pali Rohár wrote: > > > In linux-firmware repository [1] is missing AP firmware for TI > > > wl1251 chip. There is only STA firmware wl1251-fw.bin which > > > supports managed and ad-hoc modes. > > > > >

Re: [PATCH RFC] sched/fair: let cpu's cfs_rq to reflect task migration

2016-04-06 Thread Vincent Guittot
On 6 April 2016 at 10:37, Morten Rasmussen wrote: > On Tue, Apr 05, 2016 at 06:00:40PM +0100, Dietmar Eggemann wrote: >> @@ -2893,8 +2906,12 @@ static void attach_entity_load_avg(struct cfs_rq >> *cfs_rq, struct sched_entity *s >> se->avg.last_update_time = cfs_rq->avg.last_update_time;

[PATCH 5/7] gpio: Loongson1: add Loongson1 GPIO driver

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung This patch adds GPIO driver for Loongson1B. Signed-off-by: Kelvin Cheung --- drivers/gpio/Kconfig | 7 +++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-loongson1.c | 102

[PATCH 5/7] gpio: Loongson1: add Loongson1 GPIO driver

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung This patch adds GPIO driver for Loongson1B. Signed-off-by: Kelvin Cheung --- drivers/gpio/Kconfig | 7 +++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-loongson1.c | 102 ++ 3 files changed, 110 insertions(+)

[PATCH 1/7] clk: Loongson1: Update clocks of Loongson1B

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung - Rename the file to clk-loongson1.c - Add AC97, DMA and NAND clock - Update clock names - Remove superfluous error messages Signed-off-by: Kelvin Cheung --- drivers/clk/Makefile| 2 +- drivers/clk/clk-loongson1.c

[PATCH 6/7] MIPS: Loongson1B: Some updates/fixes for LS1B

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung - Add DMA device - Add NAND device - Add GPIO device - Add LED device - Update the defconfig and rename it to loongson1b_defconfig - Fix ioremap size - Other minor fixes Signed-off-by: Kelvin Cheung --- arch/mips/Kconfig

[PATCH 3/7] dmaengine: Loongson1: add Loongson1 dmaengine driver

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung This patch adds DMA Engine driver for Loongson1B. Signed-off-by: Kelvin Cheung --- drivers/dma/Kconfig | 9 + drivers/dma/Makefile| 1 + drivers/dma/loongson1-dma.c | 546

[PATCH 0/7] MIPS: Loongson1B: add NAND, DMA and GPIO support

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung This patchset is to add NAND, DMA and GPIO support for Loongson1B, and moreover, include some updates/fixes. This applies on top of mips-for-linux-next. Thanks! Kelvin Cheung (7): clk: Loongson1: Update clocks of Loongson1B cpufreq: Loongson1:

[PATCH 1/7] clk: Loongson1: Update clocks of Loongson1B

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung - Rename the file to clk-loongson1.c - Add AC97, DMA and NAND clock - Update clock names - Remove superfluous error messages Signed-off-by: Kelvin Cheung --- drivers/clk/Makefile| 2 +- drivers/clk/clk-loongson1.c | 163

[PATCH 6/7] MIPS: Loongson1B: Some updates/fixes for LS1B

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung - Add DMA device - Add NAND device - Add GPIO device - Add LED device - Update the defconfig and rename it to loongson1b_defconfig - Fix ioremap size - Other minor fixes Signed-off-by: Kelvin Cheung --- arch/mips/Kconfig | 2 +

[PATCH 3/7] dmaengine: Loongson1: add Loongson1 dmaengine driver

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung This patch adds DMA Engine driver for Loongson1B. Signed-off-by: Kelvin Cheung --- drivers/dma/Kconfig | 9 + drivers/dma/Makefile| 1 + drivers/dma/loongson1-dma.c | 546 3 files changed, 556 insertions(+)

[PATCH 0/7] MIPS: Loongson1B: add NAND, DMA and GPIO support

2016-04-06 Thread Keguang Zhang
From: Kelvin Cheung This patchset is to add NAND, DMA and GPIO support for Loongson1B, and moreover, include some updates/fixes. This applies on top of mips-for-linux-next. Thanks! Kelvin Cheung (7): clk: Loongson1: Update clocks of Loongson1B cpufreq: Loongson1: Update cpufreq of

Re: [BUG] lib: zram lz4 compression/decompression still broken on big endian

2016-04-06 Thread Sergey Senozhatsky
Cc Chanho Min, Kyungsik Lee Hello, On (04/06/16 10:39), Rui Salvaterra wrote: > > may we please ask you to test the patch first? quite possible there > > is nothing to fix there; I've no access to mips h/w but the patch > > seems correct to me. > > > > LZ4_READ_LITTLEENDIAN_16 does

Re: [BUG] lib: zram lz4 compression/decompression still broken on big endian

2016-04-06 Thread Sergey Senozhatsky
Cc Chanho Min, Kyungsik Lee Hello, On (04/06/16 10:39), Rui Salvaterra wrote: > > may we please ask you to test the patch first? quite possible there > > is nothing to fix there; I've no access to mips h/w but the patch > > seems correct to me. > > > > LZ4_READ_LITTLEENDIAN_16 does

<    8   9   10   11   12   13   14   15   16   17   >