On Thursday, May 12, 2016 01:55:44 PM Arnd Bergmann wrote:
> On Thursday 12 May 2016 11:58:18 Christian Lamparter wrote:
> > > > > Detecting the endianess of the
> > > > > device is probably the best future-proof solution, but it's also
> > > > > considerably more work to do in the driver, and
> ---
> Subject: perf/core: don't find side-band event from all pmus
> From: Kan Liang
> Date: Wed, 23 Mar 2016 11:24:37 -0700
>
Hi Peter,
Is there something wrong with the patch?
The last time I saw this patch was in your personal tree
(kernel/git/peterz/queue.git).
But now I cannot find it
2016-05-12 14:14 GMT+02:00 Thierry Reding :
> On Thu, May 12, 2016 at 01:49:12PM +0200, Guillermo Rodriguez Garcia wrote:
>> Hello,
>>
>> [...]
>> >>> One thing that I'd request is that instead of the cpu_relax() you use a
>> >>> usleep_range() within the loop instead. I
First, the headings for structs, enums and typedefs will be similar to
functions. Second, this provides a kind of namespace for cross
references. Third, and most importantly, the return and parameter types
from .. c:function:: definitions will automagically become cross
references to the
2016-05-12 14:14 GMT+02:00 Thierry Reding :
> On Thu, May 12, 2016 at 01:49:12PM +0200, Guillermo Rodriguez Garcia wrote:
>> Hello,
>>
>> [...]
>> >>> One thing that I'd request is that instead of the cpu_relax() you use a
>> >>> usleep_range() within the loop instead. I assume it can potentially
First, the headings for structs, enums and typedefs will be similar to
functions. Second, this provides a kind of namespace for cross
references. Third, and most importantly, the return and parameter types
from .. c:function:: definitions will automagically become cross
references to the
On Tue 10-05-16 09:35:54, Vlastimil Babka wrote:
> The retry loop in __alloc_pages_slowpath is supposed to keep trying reclaim
> and compaction (and OOM), until either the allocation succeeds, or returns
> with failure. Success here is more probable when reclaim precedes compaction,
> as certain
Hi Linus,
this will be my last pin control fix for this kernel cycle. It's tagged for
stable and only hits a single driver with two added lines so
should be safe. Tested in linux-next.
Please pull it in!
Yours,
Linus Walleij
The following changes since commit
On Tue 10-05-16 09:35:54, Vlastimil Babka wrote:
> The retry loop in __alloc_pages_slowpath is supposed to keep trying reclaim
> and compaction (and OOM), until either the allocation succeeds, or returns
> with failure. Success here is more probable when reclaim precedes compaction,
> as certain
Hi Linus,
this will be my last pin control fix for this kernel cycle. It's tagged for
stable and only hits a single driver with two added lines so
should be safe. Tested in linux-next.
Please pull it in!
Yours,
Linus Walleij
The following changes since commit
Hi David,
On 12/05/16 00:26, David Miller wrote:
From: Harvey Hunt
Date: Tue, 10 May 2016 17:43:21 +0100
@@ -1686,8 +1686,7 @@ dm9000_probe(struct platform_device *pdev)
}
if (!is_valid_ether_addr(ndev->dev_addr)) {
- dev_warn(db->dev,
Hi David,
On 12/05/16 00:26, David Miller wrote:
From: Harvey Hunt
Date: Tue, 10 May 2016 17:43:21 +0100
@@ -1686,8 +1686,7 @@ dm9000_probe(struct platform_device *pdev)
}
if (!is_valid_ether_addr(ndev->dev_addr)) {
- dev_warn(db->dev, "%s: Invalid ethernet MAC
Hi Stephen,
On 10/05/16 19:31, Stephen Hemminger wrote:
On Tue, 10 May 2016 17:43:21 +0100
Harvey Hunt wrote:
For ethernet devices, net_device.name will be eth%d before
register_netdev() is called. Don't print the net_device name until
the format string is replaced.
Hi Stephen,
On 10/05/16 19:31, Stephen Hemminger wrote:
On Tue, 10 May 2016 17:43:21 +0100
Harvey Hunt wrote:
For ethernet devices, net_device.name will be eth%d before
register_netdev() is called. Don't print the net_device name until
the format string is replaced.
Cc: Robert Jarzmik
Cc:
On Tue, 10 May 2016, Keerthy wrote:
> Add information for the mfd and regulator drivers.
>
> Signed-off-by: Keerthy
> ---
> Documentation/devicetree/bindings/mfd/lp873x.txt | 55
>
> 1 file changed, 55 insertions(+)
> create mode 100644
On Tue, 10 May 2016, Keerthy wrote:
> Add information for the mfd and regulator drivers.
>
> Signed-off-by: Keerthy
> ---
> Documentation/devicetree/bindings/mfd/lp873x.txt | 55
>
> 1 file changed, 55 insertions(+)
> create mode 100644
ACPI 6.0 adds a new method to specify the CPU idle states(C-states)
called Low Power Idle(LPI) states. Since new architectures like ARM64
use only LPIs, introduce ACPI_PROCESSOR_CSTATE to encapsulate all the
code supporting the old style C-states(_CST).
This patch will help to extend the
ACPI 6.0 adds a new method to specify the CPU idle states(C-states)
called Low Power Idle(LPI) states. Since new architectures like ARM64
use only LPIs, introduce ACPI_PROCESSOR_CSTATE to encapsulate all the
code supporting the old style C-states(_CST).
This patch will help to extend the
On Thu, May 12, 2016 at 08:52:46PM +0800, Zhangjian (Bamvor) wrote:
> Hi,
>
> On 2016/5/12 16:24, Yury Norov wrote:
> >On Thu, May 12, 2016 at 11:45:53AM +0800, Zhangjian (Bamvor) wrote:
> >
> >[...]
> >
> >>>Hmm, that is indeed tricky. I think COMPAT_SYSCALL_WRAP4 rightfully
> >>>refuses the
On Thu, May 12, 2016 at 08:52:46PM +0800, Zhangjian (Bamvor) wrote:
> Hi,
>
> On 2016/5/12 16:24, Yury Norov wrote:
> >On Thu, May 12, 2016 at 11:45:53AM +0800, Zhangjian (Bamvor) wrote:
> >
> >[...]
> >
> >>>Hmm, that is indeed tricky. I think COMPAT_SYSCALL_WRAP4 rightfully
> >>>refuses the
On Tue, 10 May 2016, Keerthy wrote:
> The LP873X chip is a power management IC for Portable Navigation Systems
> and Tablet Computing devices. It contains the following components:
>
> - Regulators.
> - Configurable General Purpose Output Signals(GPO).
>
> PMIC interacts with the
On Tue, 10 May 2016, Keerthy wrote:
> The LP873X chip is a power management IC for Portable Navigation Systems
> and Tablet Computing devices. It contains the following components:
>
> - Regulators.
> - Configurable General Purpose Output Signals(GPO).
>
> PMIC interacts with the
Improves clarity. No functional changes.
Signed-off-by: Jani Nikula
---
scripts/docproc.c | 93 ---
1 file changed, 47 insertions(+), 46 deletions(-)
diff --git a/scripts/docproc.c b/scripts/docproc.c
index
Improves clarity. No functional changes.
Signed-off-by: Jani Nikula
---
scripts/docproc.c | 93 ---
1 file changed, 47 insertions(+), 46 deletions(-)
diff --git a/scripts/docproc.c b/scripts/docproc.c
index 48abc01a920e..fb195f0ed0ef 100644
Leave a hint to folks which file to edit instead.
Signed-off-by: Jani Nikula
---
scripts/docproc.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/scripts/docproc.c b/scripts/docproc.c
index 9babfd108d2e..0a12593b9041 100644
--- a/scripts/docproc.c
+++
Cleaner code. Also fixes a bug when F or P directives didn't in fact
have space.
Signed-off-by: Jani Nikula
---
scripts/docproc.c | 34 +-
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/scripts/docproc.c b/scripts/docproc.c
Helps follow-up work. No functional changes.
Signed-off-by: Jani Nikula
---
scripts/docproc.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/scripts/docproc.c b/scripts/docproc.c
index fb195f0ed0ef..bc900310b431 100644
Expect reStructuredText input and have kernel-doc produce
reStructuredText output with the new --rst option. Also add --docbook
option for completeness. If no option is given, default to
reStructuredText if the input file has ".rst" extension, DocBook
otherwise.
Directives for reStructuredText
Leave a hint to folks which file to edit instead.
Signed-off-by: Jani Nikula
---
scripts/docproc.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/scripts/docproc.c b/scripts/docproc.c
index 9babfd108d2e..0a12593b9041 100644
--- a/scripts/docproc.c
+++ b/scripts/docproc.c
@@ -45,6
Cleaner code. Also fixes a bug when F or P directives didn't in fact
have space.
Signed-off-by: Jani Nikula
---
scripts/docproc.c | 34 +-
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/scripts/docproc.c b/scripts/docproc.c
index
Helps follow-up work. No functional changes.
Signed-off-by: Jani Nikula
---
scripts/docproc.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/scripts/docproc.c b/scripts/docproc.c
index fb195f0ed0ef..bc900310b431 100644
---
Expect reStructuredText input and have kernel-doc produce
reStructuredText output with the new --rst option. Also add --docbook
option for completeness. If no option is given, default to
reStructuredText if the input file has ".rst" extension, DocBook
otherwise.
Directives for reStructuredText
Instead of having the kernel-doc usage in both comments and in output to
the user, merge them all to one here document. While at it, imrove the
text and make it pretty. Give shoemaker's children some shoes.
Signed-off-by: Jani Nikula
---
scripts/kernel-doc | 83
Instead of having the kernel-doc usage in both comments and in output to
the user, merge them all to one here document. While at it, imrove the
text and make it pretty. Give shoemaker's children some shoes.
Signed-off-by: Jani Nikula
---
scripts/kernel-doc | 83
Improves clarity. No functional changes.
Signed-off-by: Jani Nikula
---
scripts/docproc.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/scripts/docproc.c b/scripts/docproc.c
index e267e621431a..48abc01a920e 100644
---
From: Jonathan Corbet
If given the -rst flag, output will now be in RestructuredText. Various
glitches to be worked out yet.
In the end I decided not to use RST section headings within the kerneldoc
comments. gpu.tmpl already has headings five levels deep; adding more is
not
Jon, I was hoping we could consider nudging things forward a bit in the
kernel-doc and docproc reStructuredText front already in 4.7. I know
it's a bit close to the merge window, but this should not interfere with
anything else, and some of it are just trivial cleanups that I've been
carrying
Improves clarity. No functional changes.
Signed-off-by: Jani Nikula
---
scripts/docproc.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/scripts/docproc.c b/scripts/docproc.c
index e267e621431a..48abc01a920e 100644
--- a/scripts/docproc.c
+++
From: Jonathan Corbet
If given the -rst flag, output will now be in RestructuredText. Various
glitches to be worked out yet.
In the end I decided not to use RST section headings within the kerneldoc
comments. gpu.tmpl already has headings five levels deep; adding more is
not going to bring
Jon, I was hoping we could consider nudging things forward a bit in the
kernel-doc and docproc reStructuredText front already in 4.7. I know
it's a bit close to the merge window, but this should not interfere with
anything else, and some of it are just trivial cleanups that I've been
carrying
From: Rafael J. Wysocki
None of the cpufreq governors currently in the tree will ever fail
an invocation of the ->governor() callback with the event argument
equal to CPUFREQ_GOV_POLICY_EXIT (unless invoked with incorrect
arguments which doesn't matter anyway) and it
From: Rafael J. Wysocki
None of the cpufreq governors currently in the tree will ever fail
an invocation of the ->governor() callback with the event argument
equal to CPUFREQ_GOV_POLICY_EXIT (unless invoked with incorrect
arguments which doesn't matter anyway) and it wouldn't really
make sense
Hi,
As it turns out, all of the existing governors (and the upcoming schedutil one)
always return 0 from ->governor() for the event argument equal to _GOV_STOP
or _POLICY_EXIT.
The following two patches rearrange the core cpufreq code to take that into
account.
Thanks,
Rafael
Hi,
As it turns out, all of the existing governors (and the upcoming schedutil one)
always return 0 from ->governor() for the event argument equal to _GOV_STOP
or _POLICY_EXIT.
The following two patches rearrange the core cpufreq code to take that into
account.
Thanks,
Rafael
From: Rafael J. Wysocki
None of the cpufreq governors currently in the tree will ever fail
an invocation of the ->governor() callback with the event argument
equal to CPUFREQ_GOV_STOP (unless invoked with incorrect arguments
which doesn't matter anyway) and it is
From: Rafael J. Wysocki
None of the cpufreq governors currently in the tree will ever fail
an invocation of the ->governor() callback with the event argument
equal to CPUFREQ_GOV_STOP (unless invoked with incorrect arguments
which doesn't matter anyway) and it is rather difficult to imagine
a
Il 06/05/2016 22:20, Paolo Valente ha scritto:
...
I can now confirm that, because of a little bug, a fraction ranging
from one third to half of the writeback bios for the writer is wrongly
associated with the root group. I'm sending a bugfix.
I'm retesting BFQ after this blk fix. If I
Il 06/05/2016 22:20, Paolo Valente ha scritto:
...
I can now confirm that, because of a little bug, a fraction ranging
from one third to half of the writeback bios for the writer is wrongly
associated with the root group. I'm sending a bugfix.
I'm retesting BFQ after this blk fix. If I
Em Thu, May 12, 2016 at 08:43:11AM +, He Kuang escreveu:
> When unwinding callchains on a different machine, vdso info should be
> provided so the unwind process won't be interrupted if address falls
> into vdso region. But in most cases, the addresses of sample events
> are not in vdso range,
Em Thu, May 12, 2016 at 08:43:11AM +, He Kuang escreveu:
> When unwinding callchains on a different machine, vdso info should be
> provided so the unwind process won't be interrupted if address falls
> into vdso region. But in most cases, the addresses of sample events
> are not in vdso range,
On Thu, May 12, 2016 at 02:14:52PM +0200, Peter Zijlstra wrote:
> But this is a C function, with C calling convention. You're now assuming
> GCC doesn't clobber anything with its prologue/epilogue.
>
> I think hpa meant to put it in an .S file and avoid all that.
I wanted to have gcc use %[w]
Em Thu, May 12, 2016 at 08:43:12AM +, He Kuang escreveu:
> Symfs dir and buildid dir are two places that perf looks into for
> symbols, currently, if symfs dir is given, buildid-cache is skipped.
>
> In the cross-platform perf record/script scenario, we need vdsos in
> buildid-cache dir and
On 2016/5/12 19:52, Aleksey Makarov wrote:
> Hi Jon,
>
> In v7 I addressed the issues that were brought up by Rafael J . Wysocki
> (but I still do not have ACK from ACPI people).
>
> The issue with D02 will be addressed in a separate patch.
>
> There possibly is an issue with 16550 and
On Thu, May 12, 2016 at 02:14:52PM +0200, Peter Zijlstra wrote:
> But this is a C function, with C calling convention. You're now assuming
> GCC doesn't clobber anything with its prologue/epilogue.
>
> I think hpa meant to put it in an .S file and avoid all that.
I wanted to have gcc use %[w]
Em Thu, May 12, 2016 at 08:43:12AM +, He Kuang escreveu:
> Symfs dir and buildid dir are two places that perf looks into for
> symbols, currently, if symfs dir is given, buildid-cache is skipped.
>
> In the cross-platform perf record/script scenario, we need vdsos in
> buildid-cache dir and
On 2016/5/12 19:52, Aleksey Makarov wrote:
> Hi Jon,
>
> In v7 I addressed the issues that were brought up by Rafael J . Wysocki
> (but I still do not have ACK from ACPI people).
>
> The issue with D02 will be addressed in a separate patch.
>
> There possibly is an issue with 16550 and
On 10/05/16 15:31, Mark Rutland wrote:
On Tue, May 10, 2016 at 02:41:54PM +0100, Daniel Thompson wrote:
On 10/05/16 11:45, Mark Rutland wrote:
When commit 44679a4f142b ("arm64: KGDB: Add step debugging support") was
introduced it was paired with a gdb patch that made an incompatible
change to
On 10/05/16 15:31, Mark Rutland wrote:
On Tue, May 10, 2016 at 02:41:54PM +0100, Daniel Thompson wrote:
On 10/05/16 11:45, Mark Rutland wrote:
When commit 44679a4f142b ("arm64: KGDB: Add step debugging support") was
introduced it was paired with a gdb patch that made an incompatible
change to
On Thursday 12 May 2016 20:49:24 Zhangjian wrote:
> Hi,
>
> On 2016/5/12 17:21, Arnd Bergmann wrote:
> > On Thursday 12 May 2016 10:17:58 Catalin Marinas wrote:
> >> On Wed, May 11, 2016 at 09:30:07PM +0200, Arnd Bergmann wrote:
> >>> On Wednesday 11 May 2016 17:59:01 Catalin Marinas wrote:
> >>>
On Thursday 12 May 2016 20:49:24 Zhangjian wrote:
> Hi,
>
> On 2016/5/12 17:21, Arnd Bergmann wrote:
> > On Thursday 12 May 2016 10:17:58 Catalin Marinas wrote:
> >> On Wed, May 11, 2016 at 09:30:07PM +0200, Arnd Bergmann wrote:
> >>> On Wednesday 11 May 2016 17:59:01 Catalin Marinas wrote:
> >>>
On Thursday, May 12, 2016 07:30:05 PM Alexandre Courbot wrote:
> On Wednesday, May 11, 2016 6:34:35 PM JST, Christian Lamparter wrote:
> > This patch integrates the GPIO drivers for the following
> > boards, SoCs, etc. into gpio-mmio:
> > - CLPS711X SoCs
> > - MOXA ART SoC
> > - TS-4800 FPGA
On Thursday, May 12, 2016 07:30:05 PM Alexandre Courbot wrote:
> On Wednesday, May 11, 2016 6:34:35 PM JST, Christian Lamparter wrote:
> > This patch integrates the GPIO drivers for the following
> > boards, SoCs, etc. into gpio-mmio:
> > - CLPS711X SoCs
> > - MOXA ART SoC
> > - TS-4800 FPGA
On 10.05.2016 20:20, Konstantin Khlebnikov wrote:
On 10.05.2016 19:36, Tejun Heo wrote:
Hello,
On Tue, May 10, 2016 at 07:28:08PM +0300, Konstantin Khlebnikov wrote:
On 10.05.2016 11:21, Konstantin Khlebnikov wrote:
I've got plenty warnings, bugs and oops around trivial use of
On 10.05.2016 20:20, Konstantin Khlebnikov wrote:
On 10.05.2016 19:36, Tejun Heo wrote:
Hello,
On Tue, May 10, 2016 at 07:28:08PM +0300, Konstantin Khlebnikov wrote:
On 10.05.2016 11:21, Konstantin Khlebnikov wrote:
I've got plenty warnings, bugs and oops around trivial use of
Ingo Molnar writes:
> * Alexander Shishkin wrote:
>
>> tip-bot for Alexander Shishkin writes:
>>
>> > Commit-ID: 5fbe4788b55540a6c4fe2c47e05482ac356eaf74
>> > Gitweb:
>> >
Ingo Molnar writes:
> * Alexander Shishkin wrote:
>
>> tip-bot for Alexander Shishkin writes:
>>
>> > Commit-ID: 5fbe4788b55540a6c4fe2c47e05482ac356eaf74
>> > Gitweb:
>> > http://git.kernel.org/tip/5fbe4788b55540a6c4fe2c47e05482ac356eaf74
>> > Author: Alexander Shishkin
>> >
Hi Steve,
On Thu, May 12, 2016 at 4:09 AM, Steven Rostedt wrote:
>
> At the end of process_filter(), collapse_tree() was changed to update the
> parg parameter, but the reassignment after the call wasn't removed.
> What happens is that the "current_op" gets modified and
Hi Steve,
On Thu, May 12, 2016 at 4:09 AM, Steven Rostedt wrote:
>
> At the end of process_filter(), collapse_tree() was changed to update the
> parg parameter, but the reassignment after the call wasn't removed.
> What happens is that the "current_op" gets modified and freed and parg
> is
Commit 086d7f804e26 ("ASoC: Convert WM8962 MICBIAS to a supply widget",
2011-09-23) says:
A supply widget is generally clearer than a MICBIAS widget and a
mic bias is just a type of supply so use a supply widget for the
MICBIAS. This also avoids confusion with the routing
Commit 086d7f804e26 ("ASoC: Convert WM8962 MICBIAS to a supply widget",
2011-09-23) says:
A supply widget is generally clearer than a MICBIAS widget and a
mic bias is just a type of supply so use a supply widget for the
MICBIAS. This also avoids confusion with the routing
On Thu, May 12, 2016 at 10:56 AM, Will Deacon wrote:
> On Thu, May 12, 2016 at 12:29:02AM +0200, Rafael J. Wysocki wrote:
>> On Wed, May 11, 2016 at 11:30 PM, David Daney
>> wrote:
>> > On 05/11/2016 02:22 PM, Rafael J. Wysocki wrote:
>> >> On
Hi,
On 2016/5/12 16:24, Yury Norov wrote:
On Thu, May 12, 2016 at 11:45:53AM +0800, Zhangjian (Bamvor) wrote:
[...]
Hmm, that is indeed tricky. I think COMPAT_SYSCALL_WRAP4 rightfully
refuses the loff_t argument here, as the common case is that this is
not possible.
It works if I apply the
On Thu, May 12, 2016 at 10:56 AM, Will Deacon wrote:
> On Thu, May 12, 2016 at 12:29:02AM +0200, Rafael J. Wysocki wrote:
>> On Wed, May 11, 2016 at 11:30 PM, David Daney
>> wrote:
>> > On 05/11/2016 02:22 PM, Rafael J. Wysocki wrote:
>> >> On Wed, May 11, 2016 at 11:08 PM, David Daney
>> >>
Hi,
On 2016/5/12 16:24, Yury Norov wrote:
On Thu, May 12, 2016 at 11:45:53AM +0800, Zhangjian (Bamvor) wrote:
[...]
Hmm, that is indeed tricky. I think COMPAT_SYSCALL_WRAP4 rightfully
refuses the loff_t argument here, as the common case is that this is
not possible.
It works if I apply the
Provides helper functions for drivers that have a simple display
pipeline. Plane, crtc and encoder are collapsed into one entity.
Cc: jsa...@ti.com
Signed-off-by: Noralf Trønnes
---
Changes since v2:
- Drop Kconfig knob DRM_KMS_HELPER
- Expand documentation
Changes since
This patchset adds various helpers that was originally part of the
tinydrm patchset.
4 patches from the previous version have been applied and 2 are now left.
Essentially it adds 2 functions:
- drm_fb_cma_create_with_funcs()
CMA backed framebuffer supporting a dirty() callback.
-
Provides helper functions for drivers that have a simple display
pipeline. Plane, crtc and encoder are collapsed into one entity.
Cc: jsa...@ti.com
Signed-off-by: Noralf Trønnes
---
Changes since v2:
- Drop Kconfig knob DRM_KMS_HELPER
- Expand documentation
Changes since v1:
- Add DOC header
This patchset adds various helpers that was originally part of the
tinydrm patchset.
4 patches from the previous version have been applied and 2 are now left.
Essentially it adds 2 functions:
- drm_fb_cma_create_with_funcs()
CMA backed framebuffer supporting a dirty() callback.
-
Add drm_fb_cma_create_with_funcs() for drivers that need to set the
dirty() callback.
Cc: laurent.pinch...@ideasonboard.com
Signed-off-by: Noralf Trønnes
---
Changes since v1:
- Expand docs
drivers/gpu/drm/drm_fb_cma_helper.c | 31 +--
Add drm_fb_cma_create_with_funcs() for drivers that need to set the
dirty() callback.
Cc: laurent.pinch...@ideasonboard.com
Signed-off-by: Noralf Trønnes
---
Changes since v1:
- Expand docs
drivers/gpu/drm/drm_fb_cma_helper.c | 31 +--
We have the following structures keeping netvsc adapter state:
- struct net_device
- struct net_device_context
- struct netvsc_device
- struct rndis_device
- struct hv_device
and there are pointers/dependencies between them:
- struct net_device_context is contained in struct net_device
- struct
We have the following structures keeping netvsc adapter state:
- struct net_device
- struct net_device_context
- struct netvsc_device
- struct rndis_device
- struct hv_device
and there are pointers/dependencies between them:
- struct net_device_context is contained in struct net_device
- struct
MTU change and set channels operations are implemented as netvsc device
re-creation destroying internal structures (struct net_device stays). This
is really unfortunate but there is no support from Hyper-V host to do it
in a different way. Such re-creation is unsurprisingly racy, Haiyang
reported
MTU change and set channels operations are implemented as netvsc device
re-creation destroying internal structures (struct net_device stays). This
is really unfortunate but there is no support from Hyper-V host to do it
in a different way. Such re-creation is unsurprisingly racy, Haiyang
reported
struct netvsc_device is destroyed on mtu change so keeping the
protection flag there is not a good idea. Move it to struct
net_device_context which is preserved.
Signed-off-by: Vitaly Kuznetsov
---
drivers/net/hyperv/hyperv_net.h | 4 +++-
drivers/net/hyperv/netvsc.c |
When netvsc device is removed during mtu change or channels setup we get
into troubles as both paths are trying to remove the device. Synchronize
them with start_remove flag and rtnl lock.
Signed-off-by: Vitaly Kuznetsov
---
drivers/net/hyperv/netvsc_drv.c | 9 +++--
1
Commit-ID: ab92b232ae05c382c3df0e3d6a5c6d16b639ac8c
Gitweb: http://git.kernel.org/tip/ab92b232ae05c382c3df0e3d6a5c6d16b639ac8c
Author: Alexander Shishkin
AuthorDate: Tue, 10 May 2016 16:18:32 +0300
Committer: Ingo Molnar
CommitDate:
struct netvsc_device is destroyed on mtu change so keeping the
protection flag there is not a good idea. Move it to struct
net_device_context which is preserved.
Signed-off-by: Vitaly Kuznetsov
---
drivers/net/hyperv/hyperv_net.h | 4 +++-
drivers/net/hyperv/netvsc.c | 3 +--
When netvsc device is removed during mtu change or channels setup we get
into troubles as both paths are trying to remove the device. Synchronize
them with start_remove flag and rtnl lock.
Signed-off-by: Vitaly Kuznetsov
---
drivers/net/hyperv/netvsc_drv.c | 9 +++--
1 file changed, 7
Commit-ID: ab92b232ae05c382c3df0e3d6a5c6d16b639ac8c
Gitweb: http://git.kernel.org/tip/ab92b232ae05c382c3df0e3d6a5c6d16b639ac8c
Author: Alexander Shishkin
AuthorDate: Tue, 10 May 2016 16:18:32 +0300
Committer: Ingo Molnar
CommitDate: Thu, 12 May 2016 14:45:59 +0200
perf/x86/intel/pt:
Commit-ID: 9f448cd3cbcec8995935e60b27802ae56aac8cc0
Gitweb: http://git.kernel.org/tip/9f448cd3cbcec8995935e60b27802ae56aac8cc0
Author: Alexander Shishkin
AuthorDate: Tue, 10 May 2016 16:18:33 +0300
Committer: Ingo Molnar
CommitDate:
Commit-ID: 9f448cd3cbcec8995935e60b27802ae56aac8cc0
Gitweb: http://git.kernel.org/tip/9f448cd3cbcec8995935e60b27802ae56aac8cc0
Author: Alexander Shishkin
AuthorDate: Tue, 10 May 2016 16:18:33 +0300
Committer: Ingo Molnar
CommitDate: Thu, 12 May 2016 14:46:11 +0200
perf/core: Disable
Hi,
On 2016/5/12 17:21, Arnd Bergmann wrote:
On Thursday 12 May 2016 10:17:58 Catalin Marinas wrote:
On Wed, May 11, 2016 at 09:30:07PM +0200, Arnd Bergmann wrote:
On Wednesday 11 May 2016 17:59:01 Catalin Marinas wrote:
I don't think the shifts are a problem, the main downside would be
the
Hi,
On 2016/5/12 17:21, Arnd Bergmann wrote:
On Thursday 12 May 2016 10:17:58 Catalin Marinas wrote:
On Wed, May 11, 2016 at 09:30:07PM +0200, Arnd Bergmann wrote:
On Wednesday 11 May 2016 17:59:01 Catalin Marinas wrote:
I don't think the shifts are a problem, the main downside would be
the
Simplify netvsvc pointer graph by getting rid of the redundant ndev
pointer. We can always get a pointer to struct net_device from somewhere
else.
Signed-off-by: Vitaly Kuznetsov
---
drivers/net/hyperv/hyperv_net.h | 2 --
drivers/net/hyperv/netvsc.c | 30
Crash in netvsc_send() is observed when netvsc device is re-created on
mtu change/set channels. The crash is caused by dereferencing of NULL
channel pointer which comes from chn_table. The root cause is a mixture
of two facts:
- we set nvdev pointer in net_device_context in alloc_net_device()
netvsc_link_change() can race with netvsc_change_mtu() or
netvsc_set_channels() as these functions destroy struct netvsc_device and
rndis filter. Use start_remove flag for syncronization. As
netvsc_change_mtu()/netvsc_set_channels() are called with rtnl lock held
we need to take it before checking
Simplify netvsvc pointer graph by getting rid of the redundant ndev
pointer. We can always get a pointer to struct net_device from somewhere
else.
Signed-off-by: Vitaly Kuznetsov
---
drivers/net/hyperv/hyperv_net.h | 2 --
drivers/net/hyperv/netvsc.c | 30 --
Crash in netvsc_send() is observed when netvsc device is re-created on
mtu change/set channels. The crash is caused by dereferencing of NULL
channel pointer which comes from chn_table. The root cause is a mixture
of two facts:
- we set nvdev pointer in net_device_context in alloc_net_device()
netvsc_link_change() can race with netvsc_change_mtu() or
netvsc_set_channels() as these functions destroy struct netvsc_device and
rndis filter. Use start_remove flag for syncronization. As
netvsc_change_mtu()/netvsc_set_channels() are called with rtnl lock held
we need to take it before checking
901 - 1000 of 1734 matches
Mail list logo