2016-09-18 14:53 GMT+08:00 Wanpeng Li :
> 2016-09-15 23:58 GMT+08:00 Radim Krčmář :
>> 2016-09-15 15:05+0800, Wanpeng Li:
>>> 2016-09-14 20:03 GMT+08:00 Radim Krčmář :
2016-09-14 11:40+0200, Paolo Bonzini:
> On 14/09/2016 09:58, Wanpeng Li wrote:
>> From: Wanpeng Li
>>
>> I ob
2016-09-15 23:58 GMT+08:00 Radim Krčmář :
> 2016-09-15 15:05+0800, Wanpeng Li:
>> 2016-09-14 20:03 GMT+08:00 Radim Krčmář :
>>> 2016-09-14 11:40+0200, Paolo Bonzini:
On 14/09/2016 09:58, Wanpeng Li wrote:
> From: Wanpeng Li
>
> I observed that kvmvapic(to optimize flexpriority=N o
On 09/18/2016 11:02 AM, Ben Hutchings wrote:
> * PGP Signed by an unknown key
>
> Signed-off-by: Ben Hutchings
Stupid copy-paste. Thanks for catching this!
Reviewed-by: Alexandre Courbot
> ---
> WHENCE | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/WHENCE b/WHENCE
> index 6002834
From: Markus Elfring
Date: Sun, 18 Sep 2016 07:48:56 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script "checkpatch.pl" can point information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code
From: Markus Elfring
Date: Sat, 17 Sep 2016 22:48:46 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/firewire/net.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/firewire/net.
From: Markus Elfring
Date: Sat, 17 Sep 2016 22:40:05 +0200
Adjust a jump label according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/firewire/net.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/firewire/net.c b/driv
From: Markus Elfring
Date: Sat, 17 Sep 2016 22:32:14 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/firewire/net.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/firewire/net.c b
From: Markus Elfring
Date: Sat, 17 Sep 2016 22:27:52 +0200
Adjust a jump label according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/firewire/net.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/firewire/net.c b/driv
From: Markus Elfring
Date: Sat, 17 Sep 2016 22:22:58 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/firewire/net.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/firewire/net.c
From: Markus Elfring
Date: Sat, 17 Sep 2016 22:17:12 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/firewire/net.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/firewire/net.c b
From: Markus Elfring
Date: Sat, 17 Sep 2016 22:11:25 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/firewire/net.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/firewire/net.c b/dr
From: Markus Elfring
Date: Sat, 17 Sep 2016 22:02:44 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/firewire/net.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/firewire/net.
From: Markus Elfring
Date: Sat, 17 Sep 2016 21:55:42 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle s
On Sat, 2016-09-17 at 20:58 +0100, Matt Fleming wrote:
> These addresses are pretty low. Can you try the hacky patch plus
> Ricardo's change in commit 3dad6f7f6975 ("x86/efi: Defer efi_esrt_init
> until after memblock_x86_fill"). He fixed a bug where it's possible to
> run out of memblock regions.
From: Markus Elfring
Date: Sun, 18 Sep 2016 08:04:02 +0200
Some update suggestions were taken into account
from static source code analysis.
Markus Elfring (10):
Use kmalloc_array() in fwnet_broadcast_start()
Rename a jump label in fwnet_broadcast_start()
Rename jump labels in fwnet_init()
The patch 2 in this patchset adding tracepoints for alarmtimers will build
failed on S390 platform, due to S390 defconfig did not define CONFIG_RTC_LIB
macro to define the rtc_ktime_to_tm() function which is used in this patch.
Thus we should add some ummy static inline functions in case CONFIG_RTC
For system debugging, we sometimes want to know who sets one
alarm timer, the time of the timer, when the timer started and
fired and so on. Thus adding tracepoints can help us trace the
alarmtimer information.
For example, when we debug the system supend/resume, if the
system is always resumed by
Hi Linus,
It's probably a bug fix that unveils the link errors.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: d4690f1e1cdabb4d61207b6787b1605a0dc0aeab
commit: 2527ecc9195e9c66252af24c4689e8a67cd4ccb9 gpio: Fix OF build problem on
UM
date: 4 weeks ag
Hi Davidlohr,
Just as with msgrcv (along with the rest of sysvipc since a few years
ago), perform the security checks without holding the ipc object lock.
Thinking about it: isn't this wrong?
CPU1:
* msgrcv()
* ipcperms()
CPU2:
* msgctl(), change permissions
** msgctl() returns, new perm
On Sat, 17 Sep 2016, Joe Perches wrote:
> On Sat, 2016-09-17 at 22:24 +0200, Julia Lawall wrote:
> > diff -u -p a/lib/sha1.c b/lib/sha1.c
> []
> > @@ -49,18 +49,18 @@
> > * the input data, the next mix it from the 512-bit array.
> > */
> > #define SHA_SRC(t) get_unaligned_be32((__u32 *)data
Hi Felipe,
On 9 September 2016 at 19:03, Felipe Balbi wrote:
>
> Hi,
>
> Baolin Wang writes:
>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>> index 057739d..22787b6 100644
>> --- a/drivers/usb/dwc3/core.c
>> +++ b/drivers/usb/dwc3/core.c
>> @@ -999,6 +999,7 @@ static int dwc3
On Sat, 17 Sep 2016, Joe Perches wrote:
> On Sat, 2016-09-17 at 22:24 +0200, Julia Lawall wrote:
>
> (A 2.2MB message that (perhaps thankfully) didn't get through to lkml)
>
> > Below is the Coccinelle output for the case where the definition of the
> > macro is a single expression. There is al
Hi Felipe,
Sorry for late reply due to my holiday.
On 9 September 2016 at 18:47, Felipe Balbi wrote:
>
> Hi,
>
> Baolin Wang writes:
>> When system has stpped the gadget, we should avoid queuing any requests
>> which will cause tranfer failed. Thus adding some disconnect checking to
>> avoid th
On 09/16/2016 09:23 PM, Guenter Roeck wrote:
> On 09/16/2016 04:32 PM, Rich Felker wrote:
>>> 4.6.3 from kernel.org.
>>
>> That is utterly ancient and probaby very buggy. I would recommend 5.x+
>> or at the very least 4.7 or 4.8.
>>
> Unfortunately that is the latest one available from kernel.org
Hi Mark,
On Sun, Sep 18, 2016 at 10:50 AM, Mark yao wrote:
> On 2016年09月14日 20:54, Tomasz Figa wrote:
>>
>> Current code implements prepare_fb and cleanup_fb callbacks only to
>> grab/release fb references, which is already done by atomic framework
>> when creating/destryoing plane state. Let's r
Hi, Arnd,
On 2016年09月14日 22:23, Arnd Bergmann wrote:
> On Wednesday, September 14, 2016 10:16:28 PM CEST zhichang.yuan wrote:
>>>
>>> No need to guard includes with an #ifdef.
>> If remove #ifdef here, extio.h should not contain any function external
>> declarations whose definitions are in
>> e
Hi Shawn,
> -Original Message-
> From: Shawn Guo [mailto:shawn...@kernel.org]
> Sent: Sunday, September 18, 2016 8:52 AM
> To: Po Liu
> Cc: linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> linux-kernel@vger.kernel.org; devicet...@vger.kernel.org; Roy Zang; Arnd
>
On Thu, Sep 15, 2016 at 03:58:18PM -0400, Theodore Ts'o wrote:
> On Thu, Sep 15, 2016 at 12:03:09PM -0400, Theodore Ts'o wrote:
> > On Wed, Sep 07, 2016 at 03:16:24PM +0200, Jan Kara wrote:
> > > On Wed 07-09-16 20:41:13, Geliang Tang wrote:
> > > > There are some repetitive code in jbd2_journal_in
Dear Friend,
Your contact details came to me by recommendation, I am interested in investing
in your country and I believe you have the capabilities of providing the needed
assistance, solutions and advise in actualizing this, Let me know if you are
willing to understake this task for me so we
Hello
We want to let you know that record available to us states that sometime ago,
you were contacted by some people who said they wanted to wire some money into
your account and you people share at an agreed ratio. You opened communication
with the consulting company then but after sometime,
On Sun, Sep 18, 2016 at 03:03:43AM +0100, Ben Hutchings wrote:
[...]
> @@ -2957,6 +2964,7 @@ File: qat_c3xxx.bin
> File: qat_c3xxx_mmp.bin
> File: qat_c62x.bin
> File: qat_c62x_mmp.bin
> +Link: qat_mmp.bin -> qat_895xcc_mmp.bin
>
> Licence: Redistributable. See LICENCE.qat_firmware for detail
Hi Peter,
What should I do next? Thanks.
Cheng
on 09/14/2016 10:01 AM, Cheng Chao wrote:
> In case @cpu == smp_proccessor_id(), we can avoid a sleep+wakeup
> by doing a preemption.
>
> the caller such as sched_exec can benefit from this change.
>
> Signed-off-by: Cheng Chao
> Cc: Oleg Neste
- Say that new files must, not 'should', be listed in WHENCE
- State the expected form of a reference to a separate licence file
- Mention 'make check'
Signed-off-by: Ben Hutchings
---
README | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/README b/README
index cdaec
Signed-off-by: Ben Hutchings
---
WHENCE | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/WHENCE b/WHENCE
index 64fea97a20dc..aafd503f9447 100644
--- a/WHENCE
+++ b/WHENCE
@@ -3144,7 +3144,7 @@ File: qca/rampatch_usb_0302.bin
File: qca/rampatch_00130300.bin
File: qca/rampa
Signed-off-by: Ben Hutchings
---
WHENCE | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/WHENCE b/WHENCE
index 93927fcfe627..17dda3bfb16f 100644
--- a/WHENCE
+++ b/WHENCE
@@ -469,8 +469,7 @@ Version: 1.4.0
File: ath9k_htc/htc_9271-1.4.0.fw
Version: 1.4.0
-Licence: Red
Fix filename 'intel/dsp_fw_bxtn.bin'. List all the files and their
versions, not just the symlinks. Delete the non-standard 'md5sum'
fields.
Signed-off-by: Ben Hutchings
---
WHENCE | 30 --
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git a/WHENCE b/WHEN
These were added in commits 406964300821, 9693ff6d749d.
Signed-off-by: Ben Hutchings
---
WHENCE | 8
1 file changed, 8 insertions(+)
diff --git a/WHENCE b/WHENCE
index df69dd8cbc75..64fea97a20dc 100644
--- a/WHENCE
+++ b/WHENCE
@@ -1743,36 +1743,42 @@ File: radeon/MULLINS_pfp.bin
File
This was the licence text for mwl8335_duplex.fw which has already been
removed.
Signed-off-by: Ben Hutchings
---
LICENCE.mwl8335 | 52
1 file changed, 52 deletions(-)
delete mode 100644 LICENCE.mwl8335
diff --git a/LICENCE.mwl8335 b/LICENCE.
Signed-off-by: Ben Hutchings
---
WHENCE | 2 --
1 file changed, 2 deletions(-)
diff --git a/WHENCE b/WHENCE
index 60028347b443..93927fcfe627 100644
--- a/WHENCE
+++ b/WHENCE
@@ -3227,10 +3227,8 @@ File: nvidia/gm20b/gr/fecs_bl.bin
File: nvidia/gm20b/gr/fecs_data.bin
File: nvidia/gm20b/gr/fecs_
Signed-off-by: Ben Hutchings
---
GPL-2 | 339 +
WHENCE | 16 ++--
2 files changed, 347 insertions(+), 8 deletions(-)
create mode 100644 GPL-2
diff --git a/GPL-2 b/GPL-2
new file mode 100644
index ..d159169d1050
--- /d
The 'sources' appear to be the names of ihex files, not actual source
code, and in any case those files are not included in this repository.
Signed-off-by: Ben Hutchings
---
WHENCE | 3 ---
1 file changed, 3 deletions(-)
diff --git a/WHENCE b/WHENCE
index 372f111c1b01..60028347b443 100644
--- a
This stops check_whence.py complaining about Makefiles etc.
Signed-off-by: Ben Hutchings
---
WHENCE | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/WHENCE b/WHENCE
index 6ca42394eeb7..372f111c1b01 100644
--- a/WHENCE
+++ b/WHENCE
@@ -1074,13 +1074,7 @@ Fil
Signed-off-by: Ben Hutchings
---
WHENCE | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/WHENCE b/WHENCE
index d7feede2b4da..5abdd8d3f49f 100644
--- a/WHENCE
+++ b/WHENCE
@@ -2889,7 +2889,7 @@ File: moxa/moxa-1131.fw
File: moxa/moxa-1150.fw
File: moxa/moxa-1151.fw
-Lice
Hi Peter,
Would you please review this patch? thanks.
Cheng
on 09/14/2016 10:23 AM, Cheng Chao wrote:
> init_idle() is called immediately after current->sched_class
> = &fair_sched_class, init_idle() sets current->sched_class
> = &idle_sched_class.
>
> Signed-off-by: Cheng Chao
> Cc: sta...@
The script compares the files listed in WHENCE (or otherwise expected)
and the files known to git, and reports all differences as errors.
Add a 'check' rule to the Makefile that runs this.
Signed-off-by: Ben Hutchings
---
Makefile| 3 +++
check_whence.py | 56 ++
This series adds a metadata consistency check script, fixes all the
errors it found, and adds a reference to it in README.
If I don't hear any objections, I'll apply these changes next week.
Ben.
Ben Hutchings (12):
Add a metadata consistency check script
WHENCE: Correct filename of LICENCE.
Minchan Kim writes:
> On Tue, Sep 13, 2016 at 04:53:49PM +0800, Huang, Ying wrote:
>> Minchan Kim writes:
>> > On Tue, Sep 13, 2016 at 02:40:00PM +0800, Huang, Ying wrote:
>> >> Minchan Kim writes:
>> >>
>> >> > Hi Huang,
>> >> >
>> >> > On Fri, Sep 09, 2016 at 01:35:12PM -0700, Huang, Ying wr
On 2016年09月14日 20:54, Tomasz Figa wrote:
Current code implements prepare_fb and cleanup_fb callbacks only to
grab/release fb references, which is already done by atomic framework
when creating/destryoing plane state. Let's remove these
unused bits.
Signed-off-by: Tomasz Figa
---
drivers/gpu/d
On 2016/9/15 5:01, Stephen Boyd wrote:
> On 09/12, Jiancheng Xue wrote:
>> Add CRG driver for Hi3798CV200 SoC. CRG(Clock and Reset
>> Generator) module generates clock and reset signals used
>> by other module blocks on SoC.
>>
>> Signed-off-by: Jiancheng Xue
>
> Overall looks fine. Just a few ni
On Sat, Sep 17, 2016 at 07:23:57PM +0300, Mike Krinkin wrote:
> Hello,
>
> after commit 3dad6f7f6975 ("x86/efi: Defer efi_esrt_init until after
> memblock_x86_fill") kernel hits BUG_ON __efi_enter_virtual_mode because
> efi.systab is NULL. With older kernel versions i face the problem with
> efi_m
From: Andi Kleen
This is a generic bug fix, but it helps with Sukadev's JSON event tree
where such events can happen.
Any event inclduing a .c/.o/.bpf currently triggers BPF compilation or loading
and then an error. This can happen for some Intel JSON events, which cannot
be used.
Fix the scan
On 09/17/2016 05:08 PM, Shawn Guo wrote:
Hi Guenter,
On Thu, Sep 15, 2016 at 04:35:04PM +0300, Vladimir Zapolskiy wrote:
The proper fix in this particular case should be like this one:
Does Vladimir's patch below fix your problem?
Yes, it does. Feel free to add
Tested-by: Guenter Roeck
t
On Tue, Sep 13, 2016 at 12:40:59PM +0800, Po Liu wrote:
> On some platforms, root port doesn't support MSI/MSI-X/INTx in RC mode.
> When chip support the aer interrupt with none MSI/MSI-X/INTx mode,
> maybe there is interrupt line for aer pme etc. Search the interrupt
> number in the fdt file. Then
On Sun, Sep 18, 2016 at 08:21:59AM +0800, Shawn Guo wrote:
> On Thu, Sep 15, 2016 at 08:42:33PM +0300, Alexander Shiyan wrote:
> > >Четверг, 15 сентября 2016, 13:13 +03:00 от Fabien Lahoudere
> > >:
> > >
> > >From: Kalle Kankare < kalle.kank...@vincit.fi >
> > >
> > >Add clocks configuration for
Hi Guenter,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: d4690f1e1cdabb4d61207b6787b1605a0dc0aeab
commit: 398c7500a1f5f74e207bd2edca1b1721b3cc1f1e MIPS: VDSO: Fix build error
with binutils 2.24 and earlier
date
On Thu, Sep 15, 2016 at 08:42:33PM +0300, Alexander Shiyan wrote:
> >Четверг, 15 сентября 2016, 13:13 +03:00 от Fabien Lahoudere
> >:
> >
> >From: Kalle Kankare < kalle.kank...@vincit.fi >
> >
> >Add clocks configuration for CSI, FIRI and IEEE1588.
> >
> >Signed-off-by: Fabien Lahoudere < fabien.l
Hi Alex,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: d4690f1e1cdabb4d61207b6787b1605a0dc0aeab
commit: ebb5e78cc63417a35254a791de66e1cc84f963cc MIPS: Initial implementation
of a VDSO
date: 10 months ago
config:
Hi Guenter,
On Thu, Sep 15, 2016 at 04:35:04PM +0300, Vladimir Zapolskiy wrote:
> The proper fix in this particular case should be like this one:
>
Does Vladimir's patch below fix your problem?
Shawn
> diff --git a/arch/arm/mach-imx/mach-kzm_arm11_01.c
> b/arch/arm/mach-imx/mach-kzm_arm11_01.
2016-09-17 9:28 GMT+08:00 Joonwoo Park :
> From: Srivatsa Vaddagiri
>
> SCHED_HRTICK feature is useful to preempt SCHED_FAIR tasks on-the-dot
> (just when they would have exceeded their ideal_runtime). It makes use
> of a per-cpu hrtimer resource and hence alarming that hrtimer should
> be based o
/dhowells/linux-fs.git
rxrpc-rewrite-20160917-2
David
---
David Howells (11):
rxrpc: Print the packet type name in the Rx packet trace
rxrpc: Add some additional call tracing
rxrpc: Add connection tracepoint and client conn state tracepoint
rxrpc: Add a tracepoint to
Print a symbolic packet type name for each valid received packet in the
trace output, not just a number.
Signed-off-by: David Howells
---
include/trace/events/rxrpc.h |5 +++--
net/rxrpc/ar-internal.h |6 +++---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/include
Add a tracepoint to follow the insertion of a packet into the transmit
buffer, its transmission and its rotation out of the buffer.
Signed-off-by: David Howells
---
include/trace/events/rxrpc.h | 26 ++
net/rxrpc/ar-internal.h | 12
net/rxrpc/input.
Add a pair of tracepoints, one to track rxrpc_connection struct ref
counting and the other to track the client connection cache state.
Signed-off-by: David Howells
---
include/trace/events/rxrpc.h | 60 +++
net/rxrpc/ar-internal.h | 76 ++
Remove _enter/_debug/_leave calls from rxrpc_recvmsg_data() of which one
uses an uninitialised variable.
Signed-off-by: David Howells
---
net/rxrpc/recvmsg.c |8
1 file changed, 8 deletions(-)
diff --git a/net/rxrpc/recvmsg.c b/net/rxrpc/recvmsg.c
index b62a08151895..79e65668bc58
Add a configuration option to inject packet loss by discarding
approximately every 8th packet received and approximately every 8th DATA
packet transmitted.
Note that no locking is used, but it shouldn't really matter.
Signed-off-by: David Howells
---
net/rxrpc/Kconfig |7 +++
net/rxrp
Add a tracepoint to follow what recvmsg does within AF_RXRPC.
Signed-off-by: David Howells
---
include/trace/events/rxrpc.h | 34 ++
net/rxrpc/ar-internal.h | 17 +
net/rxrpc/misc.c | 14 ++
net/rxrpc/recvmsg.c
Improve sk_buff tracing within AF_RXRPC by the following means:
(1) Use an enum to note the event type rather than plain integers and use
an array of event names rather than a big multi ?: list.
(2) Distinguish Rx from Tx packets and account them separately. This
requires the call ph
Add a tracepoint to log information from received ACK packets.
Signed-off-by: David Howells
---
include/trace/events/rxrpc.h | 26 ++
net/rxrpc/input.c|2 ++
2 files changed, 28 insertions(+)
diff --git a/include/trace/events/rxrpc.h b/include/trace/ev
Add a tracepoint to log information about ACK transmission.
Signed-off-by: David Howels
---
include/trace/events/rxrpc.h | 30 ++
net/rxrpc/conn_event.c |3 +++
net/rxrpc/output.c |7 ++-
3 files changed, 39 insertions(+), 1 deletion(-)
Add a tracepoint to follow the life of packets that get added to a call's
receive buffer.
Signed-off-by: David Howells
---
include/trace/events/rxrpc.h | 33 +
net/rxrpc/ar-internal.h | 12
net/rxrpc/call_accept.c |3 +++
net/rxrpc/
Add additional call tracepoint points for noting call-connected,
call-released and connection-failed events.
Also fix one tracepoint that was using an integer instead of the
corresponding enum value as the point type.
Signed-off-by: David Howells
---
net/rxrpc/ar-internal.h |3 +++
net/rxr
Record calls that need to be accepted using sk_acceptq_added() otherwise
the backlog counter goes negative because sk_acceptq_removed() is called.
This causes the preallocator to malfunction.
Calls that are preaccepted by AFS within the kernel aren't affected by
this.
Signed-off-by: David Howells
The soft-ACK parser doesn't increment the pointer into the soft-ACK list,
resulting in the first ACK/NACK value being applied to all the relevant
packets in the Tx queue. This has the potential to miss retransmissions
and cause excessive retransmissions.
Fix this by incrementing the pointer.
Sig
Move the check of rx_pkt_offset from rxrpc_locate_data() to the caller,
rxrpc_recvmsg_data(), so that it's more clear what's going on there.
Signed-off-by: David Howells
---
net/rxrpc/recvmsg.c |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/net/rxrpc/recvmsg.c b
Make the retransmission algorithm use for-loops instead of do-loops and
move the counter increments into the for-statement increment slots.
Though the do-loops are slighly more efficient since there will be at least
one pass through the each loop, the counter increments are harder to get
right as
Don't transmit an ACK if call->ackr_reason in unset. There's the
possibility of a race between recvmsg() sending an ACK and the background
processing thread trying to send the same one.
Signed-off-by: David Howells
---
net/rxrpc/output.c |5 +
1 file changed, 5 insertions(+)
diff --gi
In rxrpc_put_one_client_conn(), if a connection has RXRPC_CONN_COUNTED set
on it, then it's accounted for in rxrpc_nr_client_conns and may be on
various lists - and this is cleaned up correctly.
However, if the connection doesn't have RXRPC_CONN_COUNTED set on it, then
the put routine returns rath
Purge the queue of to_be_accepted calls on socket release. Note that
purging sock_calls doesn't release the ref owned by to_be_accepted.
Probably the sock_calls list is redundant given a purges of the recvmsg_q,
the to_be_accepted queue and the calls tree.
Signed-off-by: David Howells
---
net
The code for determining the last packet in rxrpc_recvmsg_data() has been
using the RXRPC_CALL_RX_LAST flag to determine if the rx_top pointer points
to the last packet or not. This isn't a good idea, however, as the input
code may be running simultaneously on another CPU and that sets the flag
*b
If the last call on a client connection is release after the connection has
had a bunch of calls allocated but before any DATA packets are sent (so
that it's not yet marked RXRPC_CONN_EXPOSED), an assertion will happen in
rxrpc_disconnect_client_call().
af_rxrpc: Assertion failed - 1(0x1)
rxrpc_send_call_packet() should use type in both its switch-statements
rather than using pkt->whdr.type. This might give the compiler an easier
job of uninitialised variable checking.
Signed-off-by: David Howells
---
net/rxrpc/output.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Fix the basic transmit DATA packet content size at 1412 bytes so that they
can be arbitrarily assembled into jumbo packets.
In the future, I'm thinking of moving to keeping a jumbo packet header at
the beginning of each packet in the Tx queue and creating the packet header
on the spot when kernel_
Call rxrpc_release_call() on getting an error in rxrpc_new_client_call()
rather than trying to do the cleanup ourselves. This isn't a problem,
provided we set RXRPC_CALL_HAS_USERID only if we actually add the call to
the calls tree as cleanup code fragments that would otherwise cause
problems are
Remove a tab that's on a line that should otherwise be blank.
Signed-off-by: David Howells
---
net/rxrpc/call_event.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c
index 61432049869b..9367c3be31eb 100644
--- a/net/rxrpc/ca
Check the return value of rxrpc_locate_data() in rxrpc_recvmsg_data().
Signed-off-by: David Howells
---
net/rxrpc/recvmsg.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/rxrpc/recvmsg.c b/net/rxrpc/recvmsg.c
index 0d085f5cf1bf..1edf2cf62cc5 100644
--- a/net/rxrp
write-20160917-1
David
---
David Howells (14):
rxrpc: Remove some whitespace.
rxrpc: Move the check of rx_pkt_offset from rxrpc_locate_data() to caller
rxrpc: Check the return value of rxrpc_locate_data()
rxrpc: Fix handling of the last packet in rxrpc_recvmsg_data()
Fixed three minor coding style issues.
Signed-off-by: Cathal Mullaney
---
drivers/staging/octeon/ethernet-rx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-rx.c
b/drivers/staging/octeon/ethernet-rx.c
index ce1e2a3..f0900d1 100644
--- a/drivers/staging/oc
Hi Denys,
[auto build test WARNING on tip/auto-latest]
[also build test WARNING on v4.8-rc6 next-20160916]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
[Suggest to use git(>=2.9.0) format-patch --base= (or --base
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/broadcom/b44.c | 98 +++
1 files changed, 54 insertions(+), 44 deletions(-)
diff --git a/drivers/n
The private structure contain a pointer to phydev, but the structure
net_device already contain such pointer. So we can remove the pointer
phydev in the private structure, and update the driver to use the
one contained in struct net_device.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet
On Sat, 2016-09-17 at 22:24 +0200, Julia Lawall wrote:
(A 2.2MB message that (perhaps thankfully) didn't get through to lkml)
> Below is the Coccinelle output for the case where the definition of the
> macro is a single expression. There is also the case where it is a
> sequence of statements, b
On Sun, 2016-09-18 at 00:40 +0300, Konstantin Khlebnikov wrote:
> #define printk_periodic(period, fmt, ...)
> ({
> static unsigned long __prev __read_mostly = INITIAL_JIFFIES -
> (period);
> unsigned long __now = jiffies;
> bool __print = !time_in_range_open(__now, __prev,
On Sat, Sep 17, 2016 at 09:43:02PM +0200, Christian Lamparter wrote:
> Ben Greear reported:
> > I see lots of instability as soon as I load up the carl9710 NIC.
> > My application is going to be poking at it's debugfs files...
> >
> > BUG: KASAN: slab-out-of-bounds in carl9170_debugfs_read+0xd5/0x2
On Sat, Sep 17, 2016 at 3:20 PM, Cyrill Gorcunov wrote:
> On Sat, Sep 17, 2016 at 03:09:09PM +0300, Konstantin Khlebnikov wrote:
>> >
>> > Seems I don't understand the bottom unlikely...
>>
>> This is gcc extrension:
>> https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html
>> Here macro works
The maximum size of e820 map array for EFI systems is defined as
E820_X_MAX (E820MAX + 3 * MAX_NUMNODES).
In x86_64 defconfig, this ends up with E820_X_MAX = 320, e820 and e820_saved
are 6404 bytes each.
With larger configs, for example Fedora kernels, E820_X_MAX = 3200, e820
and e820_saved are 6
They are all called only from other __init functions in e820.c
Signed-off-by: Denys Vlasenko
CC: Ingo Molnar
CC: Andy Lutomirski
CC: "H. Peter Anvin"
CC: Borislav Petkov
CC: Brian Gerst
CC: x...@kernel.org
CC: linux-kernel@vger.kernel.org
---
arch/x86/kernel/e820.c | 12 ++--
1 file
This patch turns e820 and e820_saved into pointers to e820 tables,
of the same size as before.
Signed-off-by: Denys Vlasenko
CC: Ingo Molnar
CC: Andy Lutomirski
CC: "H. Peter Anvin"
CC: Borislav Petkov
CC: Brian Gerst
CC: x...@kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Denys
On Sat, 2016-09-17 at 22:24 +0200, Julia Lawall wrote:
> diff -u -p a/lib/sha1.c b/lib/sha1.c
[]
> @@ -49,18 +49,18 @@
> * the input data, the next mix it from the 512-bit array.
> */
> #define SHA_SRC(t) get_unaligned_be32((__u32 *)data + t)
> -#define SHA_MIX(t) rol32(W(t+13) ^ W(t+8) ^ W(t+
On 09/15/2016 09:04 AM, Ingo Molnar wrote:
* Denys Vlasenko wrote:
The maximum size of e820 map array for EFI systems is defined as
E820_X_MAX (E820MAX + 3 * MAX_NUMNODES).
In x86_64 defconfig, this ends up with E820_X_MAX = 320, e820 and e820_saved
are 6404 bytes each.
With larger configs,
[Re: [ANNOUNCE] 4.8-rc5-rt1 beta] On 08/09/2016 (Thu 07:47) Mike Galbraith
wrote:
> On Tue, 2016-09-06 at 14:25 -0400, Paul Gortmaker wrote:
>
> > Patch conflicts/issues of interest 4.6 --> 4.7
> > --
> >
> > -v4.7 introduced a lot of users of dow
1 - 100 of 226 matches
Mail list logo