[PATCH v2 2/3] tpm_crb: encapsulate crb_wait_for_reg_32

Encapsulated crb_wait_for_reg32() so that state changes in other CRB registers than TPM_CRB_CTRL_REQ_x can be waited. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm_crb.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git

[PATCH v2 1/3] tpm_crb: map locality registers

In order to provide access to locality registers, this commits adds mapping of the head of the CRB registers, which are located right before the control area. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm_crb.c | 96 ++ 1 file changed, 64

[PATCH v2 0/3] Locality support for tpm_crb

The tpm_crb driver should follow the policy of reserving and relinquishing the locality it uses when multiple localities are used, like when TXT is another locality. Jarkko Sakkinen (3): tpm_crb: map locality registers tpm_crb: encapsulate crb_wait_for_reg_32 tpm_crb: request and relinquish

[PATCH v2 3/3] tpm_crb: request and relinquish locality 0

Request and relinquish locality for the driver use in order to be a better citizen in a multi locality environment like TXT. The locality is requested and relinquished as part of going into and waking up from idle. Signed-off-by: Jarkko Sakkinen ---

[PATCH v2 0/3] Locality support for tpm_crb

The tpm_crb driver should follow the policy of reserving and relinquishing the locality it uses when multiple localities are used, like when TXT is another locality. Jarkko Sakkinen (3): tpm_crb: map locality registers tpm_crb: encapsulate crb_wait_for_reg_32 tpm_crb: request and relinquish

[PATCH v2 3/3] tpm_crb: request and relinquish locality 0

Request and relinquish locality for the driver use in order to be a better citizen in a multi locality environment like TXT. The locality is requested and relinquished as part of going into and waking up from idle. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm_crb.c | 36

Re: Re: [PATCH] Input: joystick: adi - change msleep to usleep_range for small msecs

On Tue, Nov 29, 2016 at 12:29 PM, vojt...@ucw.cz wrote: > On Mon, Nov 28, 2016 at 01:49:31PM +, Aniroop Mathur wrote: >> Hello Mr. Vojtech Pavlik, >> >> On 28 Nov 2016 17:23, "vojt...@ucw.cz" wrote: >> > >> > Hi. >> > >> > ADI_INIT_DELAY/ADI_DATA_DELAY

Re: Re: [PATCH] Input: joystick: adi - change msleep to usleep_range for small msecs

On Tue, Nov 29, 2016 at 12:29 PM, vojt...@ucw.cz wrote: > On Mon, Nov 28, 2016 at 01:49:31PM +, Aniroop Mathur wrote: >> Hello Mr. Vojtech Pavlik, >> >> On 28 Nov 2016 17:23, "vojt...@ucw.cz" wrote: >> > >> > Hi. >> > >> > ADI_INIT_DELAY/ADI_DATA_DELAY doesn't have to be exact, and a

Re: net: use-after-free in worker_thread

On Sat, Dec 3, 2016 at 4:56 AM, Andrey Konovalov wrote: > Hi! > > I'm seeing lots of the following error reports while running the > syzkaller fuzzer. > > Reports appeared when I updated to 3c49de52 (Dec 2) from 2caceb32 (Dec 1). > >

Re: net: use-after-free in worker_thread

On Sat, Dec 3, 2016 at 4:56 AM, Andrey Konovalov wrote: > Hi! > > I'm seeing lots of the following error reports while running the > syzkaller fuzzer. > > Reports appeared when I updated to 3c49de52 (Dec 2) from 2caceb32 (Dec 1). > >

Re: usb/gadget: GPF in usb_gadget_unregister_driver

Hi, > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). > > general protection fault: [#1] SMP KASAN > Dumping ftrace buffer: >(ftrace buffer empty) > Modules linked in: > CPU: 0 PID: 10564 Comm:

Re: usb/gadget: GPF in usb_gadget_unregister_driver

Hi, > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). > > general protection fault: [#1] SMP KASAN > Dumping ftrace buffer: >(ftrace buffer empty) > Modules linked in: > CPU: 0 PID: 10564 Comm:

Re: [PATCH] uio: uio_cif: Fix style issues

On Sat, Dec 03, 2016 at 07:39:44PM +0530, ChinmayVS wrote: > - Update header-file inclusion path. > - Fix indentation of switch and case. > - Remove extra space in function calls. > > Signed-off-by: ChinmayVS I need a "real" name here, one that you use on legal documents.

Re: [SPCR] mmio32 iotype access requirements for X-Gene 8250(_dw) UART

On Sat, 2016-12-03 at 05:06 -0500, Jon Masters wrote: > Hi Duc, all, > > (and changing the subject and trimming/adjusting the CC) > > On 12/02/2016 02:39 PM, Duc Dang wrote: > > > > On Fri, Dec 2, 2016 at 12:11 AM, Jon Masters wrote: > > > > > > You're welcome. > > > > > >

Re: [PATCH] uio: uio_cif: Fix style issues

On Sat, Dec 03, 2016 at 07:39:44PM +0530, ChinmayVS wrote: > - Update header-file inclusion path. > - Fix indentation of switch and case. > - Remove extra space in function calls. > > Signed-off-by: ChinmayVS I need a "real" name here, one that you use on legal documents. Also, please break

Re: [SPCR] mmio32 iotype access requirements for X-Gene 8250(_dw) UART

On Sat, 2016-12-03 at 05:06 -0500, Jon Masters wrote: > Hi Duc, all, > > (and changing the subject and trimming/adjusting the CC) > > On 12/02/2016 02:39 PM, Duc Dang wrote: > > > > On Fri, Dec 2, 2016 at 12:11 AM, Jon Masters wrote: > > > > > > You're welcome. > > > > > > (Unrelated) Note

Re: usb/gadget: GPF in usb_gadget_unregister_driver

On Sat, Dec 03, 2016 at 05:36:35PM +0100, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). > > general protection fault: [#1] SMP KASAN > Dumping ftrace buffer: >

Re: usb/gadget: GPF in usb_gadget_unregister_driver

On Sat, Dec 03, 2016 at 05:36:35PM +0100, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). > > general protection fault: [#1] SMP KASAN > Dumping ftrace buffer: >

Re: [PATCH] x86/alternatives: Do not use sync_core() to serialize I$

On Sat, Dec 3, 2016 at 7:02 AM, Borislav Petkov wrote: > On Fri, Dec 02, 2016 at 08:28:44PM +0100, Borislav Petkov wrote: >> Ah, it is called only from apply_alternatives() but sure, it is safer >> this way. Lemme do that and run it through the boxes to see whether >> anything

Re: [PATCH] x86/alternatives: Do not use sync_core() to serialize I$

On Sat, Dec 3, 2016 at 7:02 AM, Borislav Petkov wrote: > On Fri, Dec 02, 2016 at 08:28:44PM +0100, Borislav Petkov wrote: >> Ah, it is called only from apply_alternatives() but sure, it is safer >> this way. Lemme do that and run it through the boxes to see whether >> anything catches fire. > >

Re: [GIT PULL 1/3] ARM: exynos: Soc/mach for v4.10

On Fri, Dec 02, 2016 at 10:52:57PM +0100, Arnd Bergmann wrote: > On Thursday, December 1, 2016 8:34:04 PM CET Krzysztof Kozlowski wrote: > > On Thu, Nov 24, 2016 at 08:08:27AM +0200, Krzysztof Kozlowski wrote: > > > Hi, > > > > > > This contains previous dts branch because SCU node in dts is

Re: [GIT PULL 1/3] ARM: exynos: Soc/mach for v4.10

On Fri, Dec 02, 2016 at 10:52:57PM +0100, Arnd Bergmann wrote: > On Thursday, December 1, 2016 8:34:04 PM CET Krzysztof Kozlowski wrote: > > On Thu, Nov 24, 2016 at 08:08:27AM +0200, Krzysztof Kozlowski wrote: > > > Hi, > > > > > > This contains previous dts branch because SCU node in dts is

[PATCH 2/2] ARM: mmp: Delete an unnecessary variable initialisation in sram_probe()

From: Markus Elfring Date: Sat, 3 Dec 2016 17:38:21 +0100 The local variable "ret" will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 2/2] ARM: mmp: Delete an unnecessary variable initialisation in sram_probe()

From: Markus Elfring Date: Sat, 3 Dec 2016 17:38:21 +0100 The local variable "ret" will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- arch/arm/mach-mmp/sram.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/2] ARM: mmp: Check return values from ioremap() and kstrdup() in sram_probe()

From: Markus Elfring Date: Sat, 3 Dec 2016 17:26:32 +0100 Two return values were not checked before their further use so far. This issue was detected by using the Coccinelle software. * Add a bit of exception handling. * Adjust tump targets. Fixes:

[PATCH 1/2] ARM: mmp: Check return values from ioremap() and kstrdup() in sram_probe()

From: Markus Elfring Date: Sat, 3 Dec 2016 17:26:32 +0100 Two return values were not checked before their further use so far. This issue was detected by using the Coccinelle software. * Add a bit of exception handling. * Adjust tump targets. Fixes: 3c7241bd36e2a618fe20c91f6c69cc20f2d981f2

[PATCH 0/2] ARM: mmp: Fine-tuning for sram_probe()

From: Markus Elfring Date: Sat, 3 Dec 2016 17:50:23 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Check return values from ioremap() and kstrdup() Delete an unnecessary variable initialisation

[PATCH 0/2] ARM: mmp: Fine-tuning for sram_probe()

From: Markus Elfring Date: Sat, 3 Dec 2016 17:50:23 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Check return values from ioremap() and kstrdup() Delete an unnecessary variable initialisation arch/arm/mach-mmp/sram.c | 19

Re: [PATCH] ARM: pxa: ezx: fix a910 camera data

On Sat, 26 Nov 2016 00:30:52 +0100 Stefan Schmidt wrote: > Hello. > Hi everyone, > On 25.11.2016 20:53, Robert Jarzmik wrote: > > Stefan Schmidt writes: > > > >> Hello. > >> > >> On 24.11.2016 17:29, Arnd Bergmann wrote: > >>> The

Re: [PATCH] ARM: pxa: ezx: fix a910 camera data

On Sat, 26 Nov 2016 00:30:52 +0100 Stefan Schmidt wrote: > Hello. > Hi everyone, > On 25.11.2016 20:53, Robert Jarzmik wrote: > > Stefan Schmidt writes: > > > >> Hello. > >> > >> On 24.11.2016 17:29, Arnd Bergmann wrote: > >>> The camera_supply_dummy_device definition is shared between a780

Re: btrfs_destroy_inode warn (outstanding extents)

On Thu, Dec 01, 2016 at 10:32:09AM -0500, Dave Jones wrote: > http://codemonkey.org.uk/junk/btrfs-destroy-inode-outstanding-extents.txt > > Also same bug, different run, but a different traceview > http://codemonkey.org.uk/junk/btrfs-destroy-inode-outstanding-extents-function-graph.txt >

Re: btrfs_destroy_inode warn (outstanding extents)

On Thu, Dec 01, 2016 at 10:32:09AM -0500, Dave Jones wrote: > http://codemonkey.org.uk/junk/btrfs-destroy-inode-outstanding-extents.txt > > Also same bug, different run, but a different traceview > http://codemonkey.org.uk/junk/btrfs-destroy-inode-outstanding-extents-function-graph.txt >

[PATCH] uapi glibc compat: fix outer guard of net device flags enum

Fix a wrong condition preventing the higher net device flags IFF_LOWER_UP etc to be defined if net/if.h is included before linux/if.h. The comment makes it clear the intention was to allow partial definition with either parts. This fixes compilation of userspace programs trying to use

[PATCH] uapi glibc compat: fix outer guard of net device flags enum

Fix a wrong condition preventing the higher net device flags IFF_LOWER_UP etc to be defined if net/if.h is included before linux/if.h. The comment makes it clear the intention was to allow partial definition with either parts. This fixes compilation of userspace programs trying to use

Re: [PATCH] fpga: fix sparse warnings in fpga-mgr and fpga-bridge

On Fri, Dec 2, 2016 at 1:23 PM, Dinh Nguyen wrote: > Fix up these sparse warnings: > > drivers/fpga/fpga-mgr.c:189:21: warning: symbol '__fpga_mgr_get' was not > declared. Should it be static? > drivers/fpga/fpga-bridge.c:30:12: warning: symbol 'bridge_list_lock' was > not

Re: [PATCH] fpga: fix sparse warnings in fpga-mgr and fpga-bridge

On Fri, Dec 2, 2016 at 1:23 PM, Dinh Nguyen wrote: > Fix up these sparse warnings: > > drivers/fpga/fpga-mgr.c:189:21: warning: symbol '__fpga_mgr_get' was not > declared. Should it be static? > drivers/fpga/fpga-bridge.c:30:12: warning: symbol 'bridge_list_lock' was > not declared. Should it be

usb/gadget: GPF in usb_gadget_unregister_driver

Hi! I've got the following error report while running the syzkaller fuzzer. On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). general protection fault: [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 0 PID: 10564 Comm: syz-executor0 Not

usb/gadget: GPF in usb_gadget_unregister_driver

Hi! I've got the following error report while running the syzkaller fuzzer. On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). general protection fault: [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 0 PID: 10564 Comm: syz-executor0 Not

Re: [PATCH 1/1] net: caif: fix ineffective error check

From: PanBian Hello Sergei, On Sat, Dec 03, 2016 at 04:17:51PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/3/2016 2:18 PM, Pan Bian wrote: > > >In function caif_sktinit_module(), the check of the return value of > >sock_register() seems ineffective. This patch fixes

Re: [PATCH 1/1] net: caif: fix ineffective error check

From: PanBian Hello Sergei, On Sat, Dec 03, 2016 at 04:17:51PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/3/2016 2:18 PM, Pan Bian wrote: > > >In function caif_sktinit_module(), the check of the return value of > >sock_register() seems ineffective. This patch fixes it. > > > >Bugzilla:

Re: [PATCH v2 0/4] tpm: kdoc cleanup

On Wed, Nov 23, 2016 at 12:04:10PM +0200, Tomas Winkler wrote: > Cleanup tpm in-code documentation. These are all applied to my master branch but please do answer to my question about TPM_DIGEST_SIZE so I can adjust that. /Jarkko

Re: [PATCH v2 0/4] tpm: kdoc cleanup

On Wed, Nov 23, 2016 at 12:04:10PM +0200, Tomas Winkler wrote: > Cleanup tpm in-code documentation. These are all applied to my master branch but please do answer to my question about TPM_DIGEST_SIZE so I can adjust that. /Jarkko

Re: [PATCH v2 2/4] tpm/tpm2-chip: fix kdoc errors

On Sat, Dec 03, 2016 at 05:34:17PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:12PM +0200, Tomas Winkler wrote: > > Use correct kdoc format, describe correct parameters and return values. > > > > Signed-off-by: Tomas Winkler > > Reviewed-by: Jarkko

Re: [PATCH v2 2/4] tpm/tpm2-chip: fix kdoc errors

On Sat, Dec 03, 2016 at 05:34:17PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:12PM +0200, Tomas Winkler wrote: > > Use correct kdoc format, describe correct parameters and return values. > > > > Signed-off-by: Tomas Winkler > > Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko

Re: [PATCH v2 4/4] tpm/vtpm: fix kdoc warnings

On Sat, Dec 03, 2016 at 05:36:04PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:14PM +0200, Tomas Winkler wrote: > > Use corret kdoc format for function description and eliminate warning > > of type: > > > > tpm_ibmvtpm.c:66: warning: No description found for parameter 'count' >

Re: [PATCH v2 4/4] tpm/vtpm: fix kdoc warnings

On Sat, Dec 03, 2016 at 05:36:04PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:14PM +0200, Tomas Winkler wrote: > > Use corret kdoc format for function description and eliminate warning > > of type: > > > > tpm_ibmvtpm.c:66: warning: No description found for parameter 'count' >

Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd

On Sat, Dec 03, 2016 at 05:32:36PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:11PM +0200, Tomas Winkler wrote: > > Functions tpm_transmit and transmit_cmd are referenced > > from other functions kdoc hence deserve documentation. > > > > Signed-off-by: Tomas Winkler

Re: [PATCH v2 3/4] tmp: use pdev for parent device in tpm_chip_alloc

On Sat, Dec 03, 2016 at 05:35:30PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:13PM +0200, Tomas Winkler wrote: > > The tpm stack uses pdev name convention for the parent device. > > Fix that also in tpm_chip_alloc(). > > Usually I'm not too fond for minor style fixes but in

Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd

On Sat, Dec 03, 2016 at 05:32:36PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:11PM +0200, Tomas Winkler wrote: > > Functions tpm_transmit and transmit_cmd are referenced > > from other functions kdoc hence deserve documentation. > > > > Signed-off-by: Tomas Winkler > > Do you

Re: [PATCH v2 3/4] tmp: use pdev for parent device in tpm_chip_alloc

On Sat, Dec 03, 2016 at 05:35:30PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:13PM +0200, Tomas Winkler wrote: > > The tpm stack uses pdev name convention for the parent device. > > Fix that also in tpm_chip_alloc(). > > Usually I'm not too fond for minor style fixes but in

Re: Unkillable processes due to PTRACE_TRACEME again

On Fri, Dec 2, 2016 at 10:02 PM, Pavel Machek wrote: > On Fri 2016-12-02 19:48:40, Dmitry Vyukov wrote: >> Hello, >> >> There was an issue discussed a year ago which leads to >> unkillalble/unwaitable zombie processes due to PTRACE_TRACEME: >>

Re: Unkillable processes due to PTRACE_TRACEME again

On Fri, Dec 2, 2016 at 10:02 PM, Pavel Machek wrote: > On Fri 2016-12-02 19:48:40, Dmitry Vyukov wrote: >> Hello, >> >> There was an issue discussed a year ago which leads to >> unkillalble/unwaitable zombie processes due to PTRACE_TRACEME: >>

Re: [PATCH v13 0/8] x86/arch_prctl Add ARCH_[GET|SET]_CPUID for controlling the CPUID instruction

On Fri, Dec 2, 2016 at 2:29 AM, Ingo Molnar wrote: > > * Kyle Huey wrote: > >> rr (http://rr-project.org/), a userspace record-and-replay reverse- >> execution debugger, would like to trap and emulate the CPUID instruction. >> This would allow us to a) mask

Re: [PATCH v13 0/8] x86/arch_prctl Add ARCH_[GET|SET]_CPUID for controlling the CPUID instruction

On Fri, Dec 2, 2016 at 2:29 AM, Ingo Molnar wrote: > > * Kyle Huey wrote: > >> rr (http://rr-project.org/), a userspace record-and-replay reverse- >> execution debugger, would like to trap and emulate the CPUID instruction. >> This would allow us to a) mask away certain hardware features that rr

Re: [PATCH] IIO: Change msleep to usleep_range for small msecs

On Sat, Dec 3, 2016 at 2:30 PM, Jonathan Cameron wrote: > On 02/12/16 19:07, Aniroop Mathur wrote: >> On Wed, Nov 30, 2016 at 8:13 PM, Aniroop Mathur wrote: >>> On 30 Nov 2016 19:05, "Lars-Peter Clausen" wrote: >>> > >>> > On 11/27/2016

Re: [PATCH] IIO: Change msleep to usleep_range for small msecs

On Sat, Dec 3, 2016 at 2:30 PM, Jonathan Cameron wrote: > On 02/12/16 19:07, Aniroop Mathur wrote: >> On Wed, Nov 30, 2016 at 8:13 PM, Aniroop Mathur wrote: >>> On 30 Nov 2016 19:05, "Lars-Peter Clausen" wrote: >>> > >>> > On 11/27/2016 11:51 AM, Jonathan Cameron wrote: >>> > > On 26/11/16

Re: [PATCH 1/1] net: ethernet: 3com: set error code on failures

From: PanBian Hi, Lino, There is no special reason to map different errors to -EIO. In the original source code, err is set to -EIO on most error paths. I copied that. I guess it has no difference with the error value provided by the called functions in the view of

Re: [PATCH 1/1] net: ethernet: 3com: set error code on failures

From: PanBian Hi, Lino, There is no special reason to map different errors to -EIO. In the original source code, err is set to -EIO on most error paths. I copied that. I guess it has no difference with the error value provided by the called functions in the view of callers of

Re: net: use-after-free in worker_thread

On Sat, Dec 3, 2016 at 2:49 PM, Eric Dumazet wrote: > On Sat, 2016-12-03 at 14:05 +0100, Andrey Konovalov wrote: >> On Sat, Dec 3, 2016 at 1:58 PM, Andrey Konovalov >> wrote: >> > +syzkal...@googlegroups.com >> > >> > On Sat, Dec 3, 2016 at 1:56

Re: net: use-after-free in worker_thread

On Sat, Dec 3, 2016 at 2:49 PM, Eric Dumazet wrote: > On Sat, 2016-12-03 at 14:05 +0100, Andrey Konovalov wrote: >> On Sat, Dec 3, 2016 at 1:58 PM, Andrey Konovalov >> wrote: >> > +syzkal...@googlegroups.com >> > >> > On Sat, Dec 3, 2016 at 1:56 PM, Andrey Konovalov >> > wrote: >> >> Hi! >>

Re: [PATCH v2 4/4] tpm/vtpm: fix kdoc warnings

On Wed, Nov 23, 2016 at 12:04:14PM +0200, Tomas Winkler wrote: > Use corret kdoc format for function description and eliminate warning > of type: > > tpm_ibmvtpm.c:66: warning: No description found for parameter 'count' > > Signed-off-by: Tomas Winkler Reviewed-by:

Re: [PATCH v2 4/4] tpm/vtpm: fix kdoc warnings

On Wed, Nov 23, 2016 at 12:04:14PM +0200, Tomas Winkler wrote: > Use corret kdoc format for function description and eliminate warning > of type: > > tpm_ibmvtpm.c:66: warning: No description found for parameter 'count' > > Signed-off-by: Tomas Winkler Reviewed-by: Jarkko Sakkinen /Jarkkko

Re: [PATCH v2 3/4] tmp: use pdev for parent device in tpm_chip_alloc

On Wed, Nov 23, 2016 at 12:04:13PM +0200, Tomas Winkler wrote: > The tpm stack uses pdev name convention for the parent device. > Fix that also in tpm_chip_alloc(). Usually I'm not too fond for minor style fixes but in this case it improves the clarity. Reviewed-by: Jarkko Sakkinen

Re: [PATCH v2 3/4] tmp: use pdev for parent device in tpm_chip_alloc

On Wed, Nov 23, 2016 at 12:04:13PM +0200, Tomas Winkler wrote: > The tpm stack uses pdev name convention for the parent device. > Fix that also in tpm_chip_alloc(). Usually I'm not too fond for minor style fixes but in this case it improves the clarity. Reviewed-by: Jarkko Sakkinen /Jarkko >

Re: [PATCH v2 2/4] tpm/tpm2-chip: fix kdoc errors

On Wed, Nov 23, 2016 at 12:04:12PM +0200, Tomas Winkler wrote: > Use correct kdoc format, describe correct parameters and return values. > > Signed-off-by: Tomas Winkler Reviewed-by: Jarkko Sakkinen /Jarkko > --- > V2: Add missing '.'

Re: [PATCH v2 2/4] tpm/tpm2-chip: fix kdoc errors

On Wed, Nov 23, 2016 at 12:04:12PM +0200, Tomas Winkler wrote: > Use correct kdoc format, describe correct parameters and return values. > > Signed-off-by: Tomas Winkler Reviewed-by: Jarkko Sakkinen /Jarkko > --- > V2: Add missing '.' > > drivers/char/tpm/tpm2-cmd.c | 105 >

Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd

On Wed, Nov 23, 2016 at 12:04:11PM +0200, Tomas Winkler wrote: > Functions tpm_transmit and transmit_cmd are referenced > from other functions kdoc hence deserve documentation. > > Signed-off-by: Tomas Winkler Do you mind if I change TPM_DIGEST_SIZE to SHA1_DIGEST_SIZE?

Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd

On Wed, Nov 23, 2016 at 12:04:11PM +0200, Tomas Winkler wrote: > Functions tpm_transmit and transmit_cmd are referenced > from other functions kdoc hence deserve documentation. > > Signed-off-by: Tomas Winkler Do you mind if I change TPM_DIGEST_SIZE to SHA1_DIGEST_SIZE? I'm looking to drop

Re: [PATCH] tpm: use get_unaligned_be32 unaligned buffer access.

Hey, On Thu, Nov 24, 2016 at 03:34:00PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 01:04:54PM +0200, Tomas Winkler wrote: > > Use get_unaligned_be32 as b32_to_cpu doesn't work correctly on > > all platforms for unaligned access. > > > > The fix doesn't cover all the cases as also

Re: [PATCH] tpm: use get_unaligned_be32 unaligned buffer access.

Hey, On Thu, Nov 24, 2016 at 03:34:00PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 01:04:54PM +0200, Tomas Winkler wrote: > > Use get_unaligned_be32 as b32_to_cpu doesn't work correctly on > > all platforms for unaligned access. > > > > The fix doesn't cover all the cases as also

Re: scsi: use-after-free in bio_copy_from_iter

On Sat, Dec 3, 2016 at 11:38 AM, Johannes Thumshirn wrote: > On Fri, Dec 02, 2016 at 05:50:39PM +0100, Dmitry Vyukov wrote: >> On Fri, Nov 25, 2016 at 8:08 PM, Dmitry Vyukov wrote: > > [...] > >> >> +David did some debugging of a similar case. His 0x400 at

Re: scsi: use-after-free in bio_copy_from_iter

On Sat, Dec 3, 2016 at 11:38 AM, Johannes Thumshirn wrote: > On Fri, Dec 02, 2016 at 05:50:39PM +0100, Dmitry Vyukov wrote: >> On Fri, Nov 25, 2016 at 8:08 PM, Dmitry Vyukov wrote: > > [...] > >> >> +David did some debugging of a similar case. His 0x400 at location >> 0x2000efdc refers to 0x

[PATCH 1/1] gpu: drm: qxl: fix use of uninitialized variable

In function qxl_release_alloc(), when kmalloc() returns a NULL pointer, it returns value 0 and parameter *ret is uninitialized. 0 means no error to the callers of qxl_release_alloc(). The callers keep going and will try to reference the uninitialized variable. This patch fixes the bug, returning

[PATCH 1/1] gpu: drm: qxl: fix use of uninitialized variable

In function qxl_release_alloc(), when kmalloc() returns a NULL pointer, it returns value 0 and parameter *ret is uninitialized. 0 means no error to the callers of qxl_release_alloc(). The callers keep going and will try to reference the uninitialized variable. This patch fixes the bug, returning

[PATCH 1/1] cpuidle: fix improper return value on error

From: Pan Bian In function cpuidle_add_state_sysfs(), variable ret takes the return value. Its value should be negative on errors. Because ret is reset in the loop, its value will be 0 during the second and after repeat of the loop. If kzalloc() returns a NULL pointer then,

[PATCH 1/1] cpuidle: fix improper return value on error

From: Pan Bian In function cpuidle_add_state_sysfs(), variable ret takes the return value. Its value should be negative on errors. Because ret is reset in the loop, its value will be 0 during the second and after repeat of the loop. If kzalloc() returns a NULL pointer then, it will return 0. It

[PATCH] x86/alternatives: Do not use sync_core() to serialize I$

On Fri, Dec 02, 2016 at 08:28:44PM +0100, Borislav Petkov wrote: > Ah, it is called only from apply_alternatives() but sure, it is safer > this way. Lemme do that and run it through the boxes to see whether > anything catches fire. Looks good, ran it on a bunch of machines, two of them huge AMD

[PATCH] x86/alternatives: Do not use sync_core() to serialize I$

On Fri, Dec 02, 2016 at 08:28:44PM +0100, Borislav Petkov wrote: > Ah, it is called only from apply_alternatives() but sure, it is safer > this way. Lemme do that and run it through the boxes to see whether > anything catches fire. Looks good, ran it on a bunch of machines, two of them huge AMD

Hello Beautiful

Hello beautiful, How you doing today? I hope you are doing well. My name is Bentley, from the US. I'm in Syria right now fighting ISIS. I want to get to know you better, if I may be so bold. I consider myself an easy-going man, and I am currently looking for a relationship in which I feel

Hello Beautiful

Hello beautiful, How you doing today? I hope you are doing well. My name is Bentley, from the US. I'm in Syria right now fighting ISIS. I want to get to know you better, if I may be so bold. I consider myself an easy-going man, and I am currently looking for a relationship in which I feel

[PATCH 1/1] crypto: asymmetric_keys: set error code on failure

From: Pan Bian In function public_key_verify_signature(), returns variable ret on error paths. When the call to kmalloc() fails, the value of ret is 0, and it is not set to an errno before returning. This patch fixes the bug. Bugzilla:

[PATCH 1/1] crypto: asymmetric_keys: set error code on failure

From: Pan Bian In function public_key_verify_signature(), returns variable ret on error paths. When the call to kmalloc() fails, the value of ret is 0, and it is not set to an errno before returning. This patch fixes the bug. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891

[PATCH] drm/radeon: don't add files at control minor debugfs directory

Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, radeon_debugfs_add_files() accesses ->control->debugfs_root though. This results in the following Oops: BUG: unable to handle kernel NULL pointer

[PATCH] drm/radeon: don't add files at control minor debugfs directory

Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, radeon_debugfs_add_files() accesses ->control->debugfs_root though. This results in the following Oops: BUG: unable to handle kernel NULL pointer

Re: [PATCH] iio: cros_ec_light_prox: add ChromeOS EC Light and Proximity Sensors

On 30/11/16 08:57, Enric Balletbo Serra wrote: > Hi Jonathan, > > Many thanks for the review, I'm preparing v2. One question below. > > 2016-11-27 11:39 GMT+01:00 Jonathan Cameron : >> On 25/11/16 12:03, Enric Balletbo i Serra wrote: >>> From: Gwendal Grignou

Re: [PATCH v4] iio: adc: New driver for TI ADS7950 chips

On 28/11/16 16:58, David Lechner wrote: > This adds a new driver for the TI ADS7950 family of ADC chips. These > communicate using SPI and come in 8/10/12-bit and 4/8/12/16 channel > varieties. > > Signed-off-by: David Lechner Very nice. Applied to the togreg branch of

Re: [PATCH] iio: cros_ec_light_prox: add ChromeOS EC Light and Proximity Sensors

On 30/11/16 08:57, Enric Balletbo Serra wrote: > Hi Jonathan, > > Many thanks for the review, I'm preparing v2. One question below. > > 2016-11-27 11:39 GMT+01:00 Jonathan Cameron : >> On 25/11/16 12:03, Enric Balletbo i Serra wrote: >>> From: Gwendal Grignou >>> >>> Handle Light and Proximity

Re: [PATCH v4] iio: adc: New driver for TI ADS7950 chips

On 28/11/16 16:58, David Lechner wrote: > This adds a new driver for the TI ADS7950 family of ADC chips. These > communicate using SPI and come in 8/10/12-bit and 4/8/12/16 channel > varieties. > > Signed-off-by: David Lechner Very nice. Applied to the togreg branch of iio.git - initially pushed

Re: [PATCH v3 0/7] Add pwm and IIO timer drivers for stm32

On 02/12/16 10:17, Benjamin Gaignard wrote: > version 3: > - no change on mfd and pwm divers patches > - add cross reference between bindings > - change compatible to "st,stm32-timer-trigger" > - fix attributes access rights > - use string instead of int for master_mode and slave_mode > - document

Re: [PATCH] iio: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8

On 29/11/16 20:00, William Breathitt Gray wrote: > The LSI/CSI LS7266R1 chip provides programmable output via the FLG pins. > When interrupts are enabled on the ACCES 104-QUAD-8, they occur whenever > FLG1 is active. Four functions are available for the FLG1 signal: > /Carry, /Compare,

Re: [PATCH] iio: 104-quad-8: Fix active level mismatch for the preset enable option

On 29/11/16 15:51, William Breathitt Gray wrote: > The set_to_preset_on_index sysfs attribute provides a boolean > configuration option to enable a preset operation on the respective > channel's counter when Index occurs. However, the corresponding > configuration bit on the Input/Output Control

Re: [PATCH v3 5/7] IIO: add bindings for stm32 timer trigger driver

On 02/12/16 14:23, Benjamin Gaignard wrote: > 2016-12-02 14:59 GMT+01:00 Lee Jones : >> On Fri, 02 Dec 2016, Benjamin Gaignard wrote: >> >>> Define bindings for stm32 timer trigger >>> >>> version 3: >>> - change file name >>> - add cross reference with mfd bindings >>> >>>

Re: [PATCH v3 0/7] mux controller abstraction and iio/i2c muxes

On 29/11/16 16:02, Peter Rosin wrote: > On 2016-11-27 13:00, Jonathan Cameron wrote: >> On 23/11/16 11:47, Peter Rosin wrote: >>> On 2016-11-22 21:58, Lars-Peter Clausen wrote: On 11/21/2016 02:17 PM, Peter Rosin wrote: [...] > I have a piece of hardware that is using the same 3 GPIO

Re: [PATCH v3 0/7] Add pwm and IIO timer drivers for stm32

On 02/12/16 10:17, Benjamin Gaignard wrote: > version 3: > - no change on mfd and pwm divers patches > - add cross reference between bindings > - change compatible to "st,stm32-timer-trigger" > - fix attributes access rights > - use string instead of int for master_mode and slave_mode > - document

Re: [PATCH] iio: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8

On 29/11/16 20:00, William Breathitt Gray wrote: > The LSI/CSI LS7266R1 chip provides programmable output via the FLG pins. > When interrupts are enabled on the ACCES 104-QUAD-8, they occur whenever > FLG1 is active. Four functions are available for the FLG1 signal: > /Carry, /Compare,

Re: [PATCH] iio: 104-quad-8: Fix active level mismatch for the preset enable option

On 29/11/16 15:51, William Breathitt Gray wrote: > The set_to_preset_on_index sysfs attribute provides a boolean > configuration option to enable a preset operation on the respective > channel's counter when Index occurs. However, the corresponding > configuration bit on the Input/Output Control

Re: [PATCH v3 5/7] IIO: add bindings for stm32 timer trigger driver

On 02/12/16 14:23, Benjamin Gaignard wrote: > 2016-12-02 14:59 GMT+01:00 Lee Jones : >> On Fri, 02 Dec 2016, Benjamin Gaignard wrote: >> >>> Define bindings for stm32 timer trigger >>> >>> version 3: >>> - change file name >>> - add cross reference with mfd bindings >>> >>> version 2: >>> - only

Re: [PATCH v3 0/7] mux controller abstraction and iio/i2c muxes

On 29/11/16 16:02, Peter Rosin wrote: > On 2016-11-27 13:00, Jonathan Cameron wrote: >> On 23/11/16 11:47, Peter Rosin wrote: >>> On 2016-11-22 21:58, Lars-Peter Clausen wrote: On 11/21/2016 02:17 PM, Peter Rosin wrote: [...] > I have a piece of hardware that is using the same 3 GPIO

[PATCH 1/1] staging: iio: cdc: fix improper return value

From: Pan Bian At the end of function ad7150_write_event_config(), directly returns 0. As a result, the errors will be ignored by the callers. It may be better to return variable "ret". Signed-off-by: Pan Bian --- drivers/staging/iio/cdc/ad7150.c | 2

Re: [PATCH] iio: 104-quad-8: Fix off-by-one errors when addressing IOR

On 28/11/16 21:55, William Breathitt Gray wrote: > The Input/Output Control register (IOR) is offset by 1 from the > respective channel data register. This patch fixes off-by-one errors > when attempting to write to a channel IOR where the base address was not > properly offset. > > Fixes:

<    1   2   3   4   5   6   >