Re: [PATCH] iio: 104-quad-8: Fix index control configuration

2016-12-03 Thread Jonathan Cameron
On 28/11/16 21:22, William Breathitt Gray wrote: > The LS7266R1 requires bits 5 & 6 to be high in order to select the Index > Control Register. This patch fixes a typo that incorrectly selects the > Input/Output Control Register where the Index Control Register was > desired. > > Fixes:

[PATCH 1/1] staging: iio: cdc: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian At the end of function ad7150_write_event_config(), directly returns 0. As a result, the errors will be ignored by the callers. It may be better to return variable "ret". Signed-off-by: Pan Bian --- drivers/staging/iio/cdc/ad7150.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] iio: 104-quad-8: Fix off-by-one errors when addressing IOR

2016-12-03 Thread Jonathan Cameron
On 28/11/16 21:55, William Breathitt Gray wrote: > The Input/Output Control register (IOR) is offset by 1 from the > respective channel data register. This patch fixes off-by-one errors > when attempting to write to a channel IOR where the base address was not > properly offset. > > Fixes:

Re: [PATCH] iio: 104-quad-8: Fix index control configuration

2016-12-03 Thread Jonathan Cameron
On 28/11/16 21:22, William Breathitt Gray wrote: > The LS7266R1 requires bits 5 & 6 to be high in order to select the Index > Control Register. This patch fixes a typo that incorrectly selects the > Input/Output Control Register where the Index Control Register was > desired. > > Fixes:

Re: [PATCH v3 7/7] ARM: dts: stm32: add stm32 general purpose timer driver in DT

2016-12-03 Thread Jonathan Cameron
On 02/12/16 13:22, Lee Jones wrote: > On Fri, 02 Dec 2016, Benjamin Gaignard wrote: > >> Add general purpose timers and it sub-nodes into DT for stm32f4. >> Define and enable pwm1 and pwm3 for stm32f469 discovery board >> >> version 3: >> - use "st,stm32-timer-trigger" in DT >> >> version 2: >> -

Re: [PATCH v3 7/7] ARM: dts: stm32: add stm32 general purpose timer driver in DT

2016-12-03 Thread Jonathan Cameron
On 02/12/16 10:17, Benjamin Gaignard wrote: > Add general purpose timers and it sub-nodes into DT for stm32f4. > Define and enable pwm1 and pwm3 for stm32f469 discovery board > > version 3: > - use "st,stm32-timer-trigger" in DT > > version 2: > - use parameters to describe hardware capabilities

Re: [PATCH v2 1/7] MFD: add bindings for stm32 general purpose timer driver

2016-12-03 Thread Jonathan Cameron
On 29/11/16 08:48, Benjamin Gaignard wrote: > 2016-11-27 16:41 GMT+01:00 Jonathan Cameron : >> On 27/11/16 14:10, Jonathan Cameron wrote: >>> On 24/11/16 15:14, Benjamin Gaignard wrote: Add bindings information for stm32 general purpose timer version 2: -

Re: [PATCH] iio: misc: add a generic regulator driver

2016-12-03 Thread Jonathan Cameron
On 30/11/16 10:10, Lars-Peter Clausen wrote: > On 11/29/2016 04:35 PM, Bartosz Golaszewski wrote: >> 2016-11-29 16:30 GMT+01:00 Lars-Peter Clausen : >>> On 11/29/2016 04:22 PM, Bartosz Golaszewski wrote: >>> [...] diff --git

Re: [PATCH v2 6/7] IIO: add STM32 IIO timer driver

2016-12-03 Thread Jonathan Cameron
On 29/11/16 09:46, Benjamin Gaignard wrote: > 2016-11-27 16:42 GMT+01:00 Jonathan Cameron : >> I delved into the datasheet after trying to figure this out, so I think >> I now sort of understand your intent, but please do answer the questions >> inline. >> >> On 24/11/16 15:14,

Re: [PATCH v3 7/7] ARM: dts: stm32: add stm32 general purpose timer driver in DT

2016-12-03 Thread Jonathan Cameron
On 02/12/16 13:22, Lee Jones wrote: > On Fri, 02 Dec 2016, Benjamin Gaignard wrote: > >> Add general purpose timers and it sub-nodes into DT for stm32f4. >> Define and enable pwm1 and pwm3 for stm32f469 discovery board >> >> version 3: >> - use "st,stm32-timer-trigger" in DT >> >> version 2: >> -

Re: [PATCH v3 7/7] ARM: dts: stm32: add stm32 general purpose timer driver in DT

2016-12-03 Thread Jonathan Cameron
On 02/12/16 10:17, Benjamin Gaignard wrote: > Add general purpose timers and it sub-nodes into DT for stm32f4. > Define and enable pwm1 and pwm3 for stm32f469 discovery board > > version 3: > - use "st,stm32-timer-trigger" in DT > > version 2: > - use parameters to describe hardware capabilities

Re: [PATCH v2 1/7] MFD: add bindings for stm32 general purpose timer driver

2016-12-03 Thread Jonathan Cameron
On 29/11/16 08:48, Benjamin Gaignard wrote: > 2016-11-27 16:41 GMT+01:00 Jonathan Cameron : >> On 27/11/16 14:10, Jonathan Cameron wrote: >>> On 24/11/16 15:14, Benjamin Gaignard wrote: Add bindings information for stm32 general purpose timer version 2: - rename stm32-mfd-timer

Re: [PATCH] iio: misc: add a generic regulator driver

2016-12-03 Thread Jonathan Cameron
On 30/11/16 10:10, Lars-Peter Clausen wrote: > On 11/29/2016 04:35 PM, Bartosz Golaszewski wrote: >> 2016-11-29 16:30 GMT+01:00 Lars-Peter Clausen : >>> On 11/29/2016 04:22 PM, Bartosz Golaszewski wrote: >>> [...] diff --git a/Documentation/devicetree/bindings/iio/misc/iio-regulator.txt

Re: [PATCH v2 6/7] IIO: add STM32 IIO timer driver

2016-12-03 Thread Jonathan Cameron
On 29/11/16 09:46, Benjamin Gaignard wrote: > 2016-11-27 16:42 GMT+01:00 Jonathan Cameron : >> I delved into the datasheet after trying to figure this out, so I think >> I now sort of understand your intent, but please do answer the questions >> inline. >> >> On 24/11/16 15:14, Benjamin Gaignard

Re: [PATCH 10/39] Annotate hardware config module parameters in drivers/iio/

2016-12-03 Thread Jonathan Cameron
On 01/12/16 13:50, William Breathitt Gray wrote: > On Thu, Dec 01, 2016 at 12:30:55PM +, David Howells wrote: >> When the kernel is running in secure boot mode, we lock down the kernel to >> prevent userspace from modifying the running kernel image. Whilst this >> includes prohibiting access

Re: [PATCH 10/39] Annotate hardware config module parameters in drivers/iio/

2016-12-03 Thread Jonathan Cameron
On 01/12/16 13:50, William Breathitt Gray wrote: > On Thu, Dec 01, 2016 at 12:30:55PM +, David Howells wrote: >> When the kernel is running in secure boot mode, we lock down the kernel to >> prevent userspace from modifying the running kernel image. Whilst this >> includes prohibiting access

Re: [PATCH] IIO: Change msleep to usleep_range for small msecs

2016-12-03 Thread Jonathan Cameron
On 02/12/16 19:07, Aniroop Mathur wrote: > On Wed, Nov 30, 2016 at 8:13 PM, Aniroop Mathur wrote: >> On 30 Nov 2016 19:05, "Lars-Peter Clausen" wrote: >> > >> > On 11/27/2016 11:51 AM, Jonathan Cameron wrote: >> > > On 26/11/16 03:47, Aniroop Mathur

Re: [PATCH] IIO: Change msleep to usleep_range for small msecs

2016-12-03 Thread Jonathan Cameron
On 02/12/16 19:07, Aniroop Mathur wrote: > On Wed, Nov 30, 2016 at 8:13 PM, Aniroop Mathur wrote: >> On 30 Nov 2016 19:05, "Lars-Peter Clausen" wrote: >> > >> > On 11/27/2016 11:51 AM, Jonathan Cameron wrote: >> > > On 26/11/16 03:47, Aniroop Mathur wrote: >> > >> msleep(1~20) may not do

Re: [PATCH] x86/intel_mid_thermal: Fix suspend handlers unused warning

2016-12-03 Thread Andy Shevchenko
On Sat, Nov 26, 2016 at 6:01 PM, Borislav Petkov wrote: > From: Borislav Petkov > > Fix: > > drivers/platform/x86/intel_mid_thermal.c:424:12: warning: > ‘mid_thermal_resume’ > defined but not used [-Wunused-function] >static int mid_thermal_resume(struct

Re: [PATCH] x86/intel_mid_thermal: Fix suspend handlers unused warning

2016-12-03 Thread Andy Shevchenko
On Sat, Nov 26, 2016 at 6:01 PM, Borislav Petkov wrote: > From: Borislav Petkov > > Fix: > > drivers/platform/x86/intel_mid_thermal.c:424:12: warning: > ‘mid_thermal_resume’ > defined but not used [-Wunused-function] >static int mid_thermal_resume(struct device *dev) > ^ >

[PATCH 2/2] soc: zte: pm_domains: Add support for zx296718 driver

2016-12-03 Thread Baoyou Xie
This patch introduces the power domain driver of zx296718 which belongs to zte's 2967 family. Signed-off-by: Baoyou Xie --- drivers/soc/zte/Makefile | 3 + drivers/soc/zte/zx296718_pm_domains.c | 162 ++ 2 files changed, 165

[PATCH 1/2] soc: zte: pm_domains: Prepare for supporting ARMv8 2967 family

2016-12-03 Thread Baoyou Xie
The ARMv8 2967 family (296718, 296716 etc) uses different value for controlling the power domain on/off registers, Choose the value depending on the compatible. Multiple domains are prepared for the family, it's privated by the drivers of boards. This patch prepares the common functions.

[PATCH 2/2] soc: zte: pm_domains: Add support for zx296718 driver

2016-12-03 Thread Baoyou Xie
This patch introduces the power domain driver of zx296718 which belongs to zte's 2967 family. Signed-off-by: Baoyou Xie --- drivers/soc/zte/Makefile | 3 + drivers/soc/zte/zx296718_pm_domains.c | 162 ++ 2 files changed, 165 insertions(+) create

[PATCH 1/2] soc: zte: pm_domains: Prepare for supporting ARMv8 2967 family

2016-12-03 Thread Baoyou Xie
The ARMv8 2967 family (296718, 296716 etc) uses different value for controlling the power domain on/off registers, Choose the value depending on the compatible. Multiple domains are prepared for the family, it's privated by the drivers of boards. This patch prepares the common functions.

RE: [PATCH 1/1] infiniband: hw: cxgb4: set errno on failure

2016-12-03 Thread Steve Wise
Acked-by: Steve Wise

RE: [PATCH 1/1] infiniband: hw: cxgb4: set errno on failure

2016-12-03 Thread Steve Wise
Acked-by: Steve Wise

[PATCH] uio: uio_cif: Fix style issues

2016-12-03 Thread ChinmayVS
- Update header-file inclusion path. - Fix indentation of switch and case. - Remove extra space in function calls. Signed-off-by: ChinmayVS --- drivers/uio/uio_cif.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git

[PATCH] uio: uio_cif: Fix style issues

2016-12-03 Thread ChinmayVS
- Update header-file inclusion path. - Fix indentation of switch and case. - Remove extra space in function calls. Signed-off-by: ChinmayVS --- drivers/uio/uio_cif.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/uio/uio_cif.c

ARM: topology: Checking for a failed kcalloc() in parse_dt_topology()?

2016-12-03 Thread SF Markus Elfring
Hello, Another run of a small script for the semantic patch language (Coccinelle) pointed the implementation of the function “parse_dt_topology” out for further considerations.

ARM: topology: Checking for a failed kcalloc() in parse_dt_topology()?

2016-12-03 Thread SF Markus Elfring
Hello, Another run of a small script for the semantic patch language (Coccinelle) pointed the implementation of the function “parse_dt_topology” out for further considerations.

[PATCH] staging: ks7010: Fixed 'missing blank line after declaration' warnings.

2016-12-03 Thread Yamanappagouda Patil
Fixed checkpatch.pl warnings 'Missing blank line after declaration' in ks_wlan_net.c file. Signed-off-by: Yamanappagouda Patil --- drivers/staging/ks7010/ks_wlan_net.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/ks7010/ks_wlan_net.c

[PATCH] staging: ks7010: Fixed 'missing blank line after declaration' warnings.

2016-12-03 Thread Yamanappagouda Patil
Fixed checkpatch.pl warnings 'Missing blank line after declaration' in ks_wlan_net.c file. Signed-off-by: Yamanappagouda Patil --- drivers/staging/ks7010/ks_wlan_net.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/ks7010/ks_wlan_net.c

[PATCH 1/1] infiniband: hw: ocrdma: fix bad initialization

2016-12-03 Thread Pan Bian
From: Pan Bian In function ocrdma_mbx_create_ah_tbl(), returns the value of status on errors. However, because status is initialized with 0, 0 will be returned even if on error paths. This patch initialize status with "-ENOMEM". Bugzilla:

[PATCH 1/1] infiniband: hw: ocrdma: fix bad initialization

2016-12-03 Thread Pan Bian
From: Pan Bian In function ocrdma_mbx_create_ah_tbl(), returns the value of status on errors. However, because status is initialized with 0, 0 will be returned even if on error paths. This patch initialize status with "-ENOMEM". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188831

Re: [PATCH 1/1] net: ethernet: 3com: set error code on failures

2016-12-03 Thread Lino Sanfilippo
Hi, On 03.12.2016 14:24, Pan Bian wrote: > From: Pan Bian > > In function typhoon_init_one(), returns the value of variable err on > errors. However, on some error paths, variable err is not set to a > negative errno. This patch assigns "-EIO" to err on those paths. > >

Re: [PATCH 1/1] net: ethernet: 3com: set error code on failures

2016-12-03 Thread Lino Sanfilippo
Hi, On 03.12.2016 14:24, Pan Bian wrote: > From: Pan Bian > > In function typhoon_init_one(), returns the value of variable err on > errors. However, on some error paths, variable err is not set to a > negative errno. This patch assigns "-EIO" to err on those paths. > > Signed-off-by: Pan Bian

Re: [PATCH v3] usb: hcd.h: construct hub class request constants from simpler constants

2016-12-03 Thread Tal Shorer
On Fri, Nov 18, 2016 at 2:17 PM, Tal Shorer wrote: > Currently, each hub class request constant is defined by a line like: > #define ClearHubFeature (0x2000 | USB_REQ_CLEAR_FEATURE) > > The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3. > The 0x80

Re: [PATCH v3] usb: hcd.h: construct hub class request constants from simpler constants

2016-12-03 Thread Tal Shorer
On Fri, Nov 18, 2016 at 2:17 PM, Tal Shorer wrote: > Currently, each hub class request constant is defined by a line like: > #define ClearHubFeature (0x2000 | USB_REQ_CLEAR_FEATURE) > > The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3. > The 0x80 bit that changes

[PATCH 1/1] net: dcb: set error code on failures

2016-12-03 Thread Pan Bian
From: Pan Bian In function dcbnl_cee_fill(), returns the value of variable err on errors. However, on some error paths (e.g. nla put fails), its value may be 0. It may be better to explicitly set a negative errno to variable err before returning. Bugzilla:

Re: net: use-after-free in worker_thread

2016-12-03 Thread Eric Dumazet
On Sat, 2016-12-03 at 14:05 +0100, Andrey Konovalov wrote: > On Sat, Dec 3, 2016 at 1:58 PM, Andrey Konovalov > wrote: > > +syzkal...@googlegroups.com > > > > On Sat, Dec 3, 2016 at 1:56 PM, Andrey Konovalov > > wrote: > >> Hi! > >> > >> I'm seeing

[PATCH 1/1] net: dcb: set error code on failures

2016-12-03 Thread Pan Bian
From: Pan Bian In function dcbnl_cee_fill(), returns the value of variable err on errors. However, on some error paths (e.g. nla put fails), its value may be 0. It may be better to explicitly set a negative errno to variable err before returning. Bugzilla:

Re: net: use-after-free in worker_thread

2016-12-03 Thread Eric Dumazet
On Sat, 2016-12-03 at 14:05 +0100, Andrey Konovalov wrote: > On Sat, Dec 3, 2016 at 1:58 PM, Andrey Konovalov > wrote: > > +syzkal...@googlegroups.com > > > > On Sat, Dec 3, 2016 at 1:56 PM, Andrey Konovalov > > wrote: > >> Hi! > >> > >> I'm seeing lots of the following error reports while

[PATCH 1/1] scsi: 32-9xxx: fix improper return value on errors

2016-12-03 Thread Pan Bian
From: Pan Bian In function twa_probe(), returns the value of variable retval on error paths. However, on some error paths, retval is not set to negative errnos, and its value will keep 0. This patch fixes them. Signed-off-by: Pan Bian ---

[PATCH 1/1] scsi: 32-9xxx: fix improper return value on errors

2016-12-03 Thread Pan Bian
From: Pan Bian In function twa_probe(), returns the value of variable retval on error paths. However, on some error paths, retval is not set to negative errnos, and its value will keep 0. This patch fixes them. Signed-off-by: Pan Bian --- drivers/scsi/3w-9xxx.c | 6 +- 1 file changed, 5

[PATCH 1/1] scsi: csiostor: fix improper reference to variable

2016-12-03 Thread Pan Bian
From: Pan Bian In function csio_config_device_caps(), returns the value of variable rv on error paths. However, when validating device capabilities, its value is reset, and will be 0 on the following error paths. 0 means no error in this context. It may be better to use

[PATCH 1/1] scsi: csiostor: fix improper reference to variable

2016-12-03 Thread Pan Bian
From: Pan Bian In function csio_config_device_caps(), returns the value of variable rv on error paths. However, when validating device capabilities, its value is reset, and will be 0 on the following error paths. 0 means no error in this context. It may be better to use variable retval to

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

2016-12-03 Thread kbuild test robot
-ups-to-make-lustre_idl-h-a-proper-UAPI-header/20161203-112301 config: s390-allmodconfig (attached as .config) compiler: s390x-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

2016-12-03 Thread kbuild test robot
-ups-to-make-lustre_idl-h-a-proper-UAPI-header/20161203-112301 config: s390-allmodconfig (attached as .config) compiler: s390x-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin

[PATCH 1/1] net: ethernet: 3com: set error code on failures

2016-12-03 Thread Pan Bian
From: Pan Bian In function typhoon_init_one(), returns the value of variable err on errors. However, on some error paths, variable err is not set to a negative errno. This patch assigns "-EIO" to err on those paths. Signed-off-by: Pan Bian ---

[PATCH 1/1] net: ethernet: 3com: set error code on failures

2016-12-03 Thread Pan Bian
From: Pan Bian In function typhoon_init_one(), returns the value of variable err on errors. However, on some error paths, variable err is not set to a negative errno. This patch assigns "-EIO" to err on those paths. Signed-off-by: Pan Bian --- drivers/net/ethernet/3com/typhoon.c | 3 +++ 1

alpha: Checking for a failed kmalloc() in process_reloc_for_got()?

2016-12-03 Thread SF Markus Elfring
Hello, Another run of a small script for the semantic patch language (Coccinelle) pointed the implementation of the function “process_reloc_for_got” out for further considerations.

alpha: Checking for a failed kmalloc() in process_reloc_for_got()?

2016-12-03 Thread SF Markus Elfring
Hello, Another run of a small script for the semantic patch language (Coccinelle) pointed the implementation of the function “process_reloc_for_got” out for further considerations.

Re: [PATCH 1/1] net: caif: fix ineffective error check

2016-12-03 Thread Sergei Shtylyov
Hello. On 12/3/2016 2:18 PM, Pan Bian wrote: In function caif_sktinit_module(), the check of the return value of sock_register() seems ineffective. This patch fixes it. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 Signed-off-by: Pan Bian ---

Re: [PATCH 1/1] net: caif: fix ineffective error check

2016-12-03 Thread Sergei Shtylyov
Hello. On 12/3/2016 2:18 PM, Pan Bian wrote: In function caif_sktinit_module(), the check of the return value of sock_register() seems ineffective. This patch fixes it. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 Signed-off-by: Pan Bian --- net/caif/caif_socket.c | 2 +- 1

Re: [PATCH 1/1] extcon: return error code on failure

2016-12-03 Thread Chanwoo Choi
Dear Greg, 2016-12-03 21:48 GMT+09:00 Chanwoo Choi : > Hi Pan, > > 2016-12-03 17:56 GMT+09:00 Pan Bian : >> Function get_zeroed_page() returns a NULL pointer if there is no enough >> memory. In function extcon_sync(), it returns 0 if the call to >>

Re: [PATCH 1/1] extcon: return error code on failure

2016-12-03 Thread Chanwoo Choi
Dear Greg, 2016-12-03 21:48 GMT+09:00 Chanwoo Choi : > Hi Pan, > > 2016-12-03 17:56 GMT+09:00 Pan Bian : >> Function get_zeroed_page() returns a NULL pointer if there is no enough >> memory. In function extcon_sync(), it returns 0 if the call to >> get_zeroed_page() fails. The return value 0

Re: net: use-after-free in worker_thread

2016-12-03 Thread Andrey Konovalov
+syzkal...@googlegroups.com On Sat, Dec 3, 2016 at 1:56 PM, Andrey Konovalov wrote: > Hi! > > I'm seeing lots of the following error reports while running the > syzkaller fuzzer. > > Reports appeared when I updated to 3c49de52 (Dec 2) from 2caceb32 (Dec 1). > >

Re: net: use-after-free in worker_thread

2016-12-03 Thread Andrey Konovalov
+syzkal...@googlegroups.com On Sat, Dec 3, 2016 at 1:56 PM, Andrey Konovalov wrote: > Hi! > > I'm seeing lots of the following error reports while running the > syzkaller fuzzer. > > Reports appeared when I updated to 3c49de52 (Dec 2) from 2caceb32 (Dec 1). > >

Re: net: use-after-free in worker_thread

2016-12-03 Thread Andrey Konovalov
On Sat, Dec 3, 2016 at 1:58 PM, Andrey Konovalov wrote: > +syzkal...@googlegroups.com > > On Sat, Dec 3, 2016 at 1:56 PM, Andrey Konovalov > wrote: >> Hi! >> >> I'm seeing lots of the following error reports while running the >> syzkaller fuzzer. >>

Re: net: use-after-free in worker_thread

2016-12-03 Thread Andrey Konovalov
On Sat, Dec 3, 2016 at 1:58 PM, Andrey Konovalov wrote: > +syzkal...@googlegroups.com > > On Sat, Dec 3, 2016 at 1:56 PM, Andrey Konovalov > wrote: >> Hi! >> >> I'm seeing lots of the following error reports while running the >> syzkaller fuzzer. >> >> Reports appeared when I updated to

[PATCH 1/1] infiniband: hw: cxgb4: set errno on failure

2016-12-03 Thread Pan Bian
From: Pan Bian In function c4iw_rdev_open(), the value of return variable err should be negative on errors. However, when the call to __get_free_page() returns a NULL pointer, its value is not set to "-ENOMEM" and keeps 0. 0 means no error. And thus, the behavior of its

[PATCH 1/1] infiniband: hw: cxgb4: set errno on failure

2016-12-03 Thread Pan Bian
From: Pan Bian In function c4iw_rdev_open(), the value of return variable err should be negative on errors. However, when the call to __get_free_page() returns a NULL pointer, its value is not set to "-ENOMEM" and keeps 0. 0 means no error. And thus, the behavior of its caller may be misled.

[PATCH] staging: ks7010: fixed 'space prohibited after that *' erros.

2016-12-03 Thread Yamanappagouda Patil
Fixed checkpatch.pl errors related to "space prohibited after that '*' or '&'" in ks_wlan_net.c file. Signed-off-by: Yamanappagouda Patil --- drivers/staging/ks7010/ks_wlan_net.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] staging: ks7010: fixed 'space prohibited after that *' erros.

2016-12-03 Thread Yamanappagouda Patil
Fixed checkpatch.pl errors related to "space prohibited after that '*' or '&'" in ks_wlan_net.c file. Signed-off-by: Yamanappagouda Patil --- drivers/staging/ks7010/ks_wlan_net.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

net: use-after-free in worker_thread

2016-12-03 Thread Andrey Konovalov
Hi! I'm seeing lots of the following error reports while running the syzkaller fuzzer. Reports appeared when I updated to 3c49de52 (Dec 2) from 2caceb32 (Dec 1). == BUG: KASAN: use-after-free in worker_thread+0x17d8/0x18a0 Read of

net: use-after-free in worker_thread

2016-12-03 Thread Andrey Konovalov
Hi! I'm seeing lots of the following error reports while running the syzkaller fuzzer. Reports appeared when I updated to 3c49de52 (Dec 2) from 2caceb32 (Dec 1). == BUG: KASAN: use-after-free in worker_thread+0x17d8/0x18a0 Read of

[PATCH 1/1] staging: lustre: lnet: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian At the end of function lstcon_group_info(), "return 0" seems improper. It may be better to return the value of rc. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811 Signed-off-by: Pan Bian ---

[PATCH 1/1] staging: lustre: lnet: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian At the end of function lstcon_group_info(), "return 0" seems improper. It may be better to return the value of rc. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811 Signed-off-by: Pan Bian --- drivers/staging/lustre/lnet/selftest/console.c | 2 +- 1 file changed, 1

Re: [PATCH 1/1] extcon: return error code on failure

2016-12-03 Thread Chanwoo Choi
Hi Pan, 2016-12-03 17:56 GMT+09:00 Pan Bian : > Function get_zeroed_page() returns a NULL pointer if there is no enough > memory. In function extcon_sync(), it returns 0 if the call to > get_zeroed_page() fails. The return value 0 indicates success in the > context, which is

Re: [PATCH 1/1] extcon: return error code on failure

2016-12-03 Thread Chanwoo Choi
Hi Pan, 2016-12-03 17:56 GMT+09:00 Pan Bian : > Function get_zeroed_page() returns a NULL pointer if there is no enough > memory. In function extcon_sync(), it returns 0 if the call to > get_zeroed_page() fails. The return value 0 indicates success in the > context, which is incosistent with the

Re: [PATCH v2 5/6] x86/xen: Add a Xen-specific sync_core() implementation

2016-12-03 Thread Borislav Petkov
On Fri, Dec 02, 2016 at 09:38:38AM -0800, Andy Lutomirski wrote: > TBH, I didn't start down this path for performance. I did it because > I wanted to kill off a CPUID that was breaking on old CPUs that don't > have CPUID. So I propose MOV-to-CR2 followed by an unconditional > jump. My goal here

Re: [PATCH v2 5/6] x86/xen: Add a Xen-specific sync_core() implementation

2016-12-03 Thread Borislav Petkov
On Fri, Dec 02, 2016 at 09:38:38AM -0800, Andy Lutomirski wrote: > TBH, I didn't start down this path for performance. I did it because > I wanted to kill off a CPUID that was breaking on old CPUs that don't > have CPUID. So I propose MOV-to-CR2 followed by an unconditional > jump. My goal here

[PATCH 1/1] atm: lanai: set error code when ioremap fails

2016-12-03 Thread Pan Bian
In function lanai_dev_open(), when the call to ioremap() fails, the value of return variable result is 0. 0 means no error in this context. This patch fixes the bug, assigning "-ENOMEM" to result when ioremap() returns a NULL pointer. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188791

[PATCH 1/1] atm: lanai: set error code when ioremap fails

2016-12-03 Thread Pan Bian
In function lanai_dev_open(), when the call to ioremap() fails, the value of return variable result is 0. 0 means no error in this context. This patch fixes the bug, assigning "-ENOMEM" to result when ioremap() returns a NULL pointer. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188791

Re: [PATCH v2 2/2] dell-wmi: Add events created by Dell Rugged 2-in-1s

2016-12-03 Thread Andy Shevchenko
On Sat, Nov 19, 2016 at 6:33 PM, Andy Shevchenko wrote: > On Thu, Jul 28, 2016 at 8:53 PM, Mario Limonciello > wrote: >> The Dell Rugged 7202 has 3 programmable buttons (labeled P1, P2, P3) >> and a detachable keyboard/mouse dock. >> >>

Re: [PATCH v2 2/2] dell-wmi: Add events created by Dell Rugged 2-in-1s

2016-12-03 Thread Andy Shevchenko
On Sat, Nov 19, 2016 at 6:33 PM, Andy Shevchenko wrote: > On Thu, Jul 28, 2016 at 8:53 PM, Mario Limonciello > wrote: >> The Dell Rugged 7202 has 3 programmable buttons (labeled P1, P2, P3) >> and a detachable keyboard/mouse dock. >> >> Signed-off-by: Mario Limonciello > > There was a long

[PATCH 1/1] media: platform: sti: return -ENOMEM on errors

2016-12-03 Thread Pan Bian
From: Pan Bian Function bdisp_debugfs_create() returns 0 even on errors. So its caller cannot detect the errors. It may be better to return "-ENOMEM" on the exception paths. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188801 Signed-off-by: Pan Bian

[PATCH 1/1] media: platform: sti: return -ENOMEM on errors

2016-12-03 Thread Pan Bian
From: Pan Bian Function bdisp_debugfs_create() returns 0 even on errors. So its caller cannot detect the errors. It may be better to return "-ENOMEM" on the exception paths. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188801 Signed-off-by: Pan Bian ---

Re: [PATCH] tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock

2016-12-03 Thread Bhuvanchandra DV
On 12/03/2016 02:25 PM, Nikita Yushchenko wrote: 03.12.2016 10:06, Bhuvanchandra DV пишет: On 12/03/2016 02:58 AM, Nikita Yushchenko wrote: Problem found via lockdep: - lpuart_set_termios() calls del_timer_sync(>lpuart_timer) while holding sport->port.lock - sport->lpuart_timer

Re: [PATCH] tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock

2016-12-03 Thread Bhuvanchandra DV
On 12/03/2016 02:25 PM, Nikita Yushchenko wrote: 03.12.2016 10:06, Bhuvanchandra DV пишет: On 12/03/2016 02:58 AM, Nikita Yushchenko wrote: Problem found via lockdep: - lpuart_set_termios() calls del_timer_sync(>lpuart_timer) while holding sport->port.lock - sport->lpuart_timer

Re: [PATCH v3 11/14] ACPI: irq: introduce interrupt producer

2016-12-03 Thread G Gregory
On Tue, Oct 25, 2016 at 11:09:26PM +0800, Hanjun Guo wrote: > From: Hanjun Guo > > In ACPI 6.1 spec, section 19.6.62, Interrupt Resource Descriptor Macro, > > Interrupt (ResourceUsage, EdgeLevel, ActiveLevel, Shared, > ResourceSourceIndex, ResourceSource, DescriptorName)

Re: [PATCH v3 11/14] ACPI: irq: introduce interrupt producer

2016-12-03 Thread G Gregory
On Tue, Oct 25, 2016 at 11:09:26PM +0800, Hanjun Guo wrote: > From: Hanjun Guo > > In ACPI 6.1 spec, section 19.6.62, Interrupt Resource Descriptor Macro, > > Interrupt (ResourceUsage, EdgeLevel, ActiveLevel, Shared, > ResourceSourceIndex, ResourceSource, DescriptorName) > { InterruptList } =>

[PATCH] arm64: dts: zx: add pcu_domain node for zx296718

2016-12-03 Thread Baoyou Xie
This patch adds the pcu_domain node, so it can be used by zte-soc's power domain driver. Furthermore, it adds the document of the node. Signed-off-by: Baoyou Xie --- Documentation/devicetree/bindings/arm/zte.txt | 11 +++ arch/arm64/boot/dts/zte/zx296718.dtsi

[PATCH] arm64: dts: zx: add pcu_domain node for zx296718

2016-12-03 Thread Baoyou Xie
This patch adds the pcu_domain node, so it can be used by zte-soc's power domain driver. Furthermore, it adds the document of the node. Signed-off-by: Baoyou Xie --- Documentation/devicetree/bindings/arm/zte.txt | 11 +++ arch/arm64/boot/dts/zte/zx296718.dtsi | 7 +++ 2

[PATCH 1/1] btrfs: volumes: fix improper return value

2016-12-03 Thread Pan Bian
Variable ret takes the errno on failures. However, it directly returns 0. It may be better to return "ret". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188741 Signed-off-by: Pan Bian --- fs/btrfs/volumes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/1] btrfs: volumes: fix improper return value

2016-12-03 Thread Pan Bian
Variable ret takes the errno on failures. However, it directly returns 0. It may be better to return "ret". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188741 Signed-off-by: Pan Bian --- fs/btrfs/volumes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/1] net: caif: fix ineffective error check

2016-12-03 Thread Pan Bian
In function caif_sktinit_module(), the check of the return value of sock_register() seems ineffective. This patch fixes it. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 Signed-off-by: Pan Bian --- net/caif/caif_socket.c | 2 +- 1 file changed, 1

[PATCH 1/1] net: caif: fix ineffective error check

2016-12-03 Thread Pan Bian
In function caif_sktinit_module(), the check of the return value of sock_register() seems ineffective. This patch fixes it. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 Signed-off-by: Pan Bian --- net/caif/caif_socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/1] net: bridge: set error code on failure

2016-12-03 Thread Pan Bian
Function br_sysfs_addbr() does not set error code when the call kobject_create_and_add() returns a NULL pointer. It may be better to return "-ENOMEM" when kobject_create_and_add() fails. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188781 Signed-off-by: Pan Bian

[PATCH 1/1] net: bridge: set error code on failure

2016-12-03 Thread Pan Bian
Function br_sysfs_addbr() does not set error code when the call kobject_create_and_add() returns a NULL pointer. It may be better to return "-ENOMEM" when kobject_create_and_add() fails. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188781 Signed-off-by: Pan Bian ---

[PATCH 1/1] net: usb: set error code when usb_alloc_urb fails

2016-12-03 Thread Pan Bian
In function lan78xx_probe(), variable ret takes the errno code on failures. However, when the call to usb_alloc_urb() fails, its value will keeps 0. 0 indicates success in the context, which is inconsistent with the execution result. This patch fixes the bug, assigning "-ENOMEM" to ret when

[PATCH 1/1] net: usb: set error code when usb_alloc_urb fails

2016-12-03 Thread Pan Bian
In function lan78xx_probe(), variable ret takes the errno code on failures. However, when the call to usb_alloc_urb() fails, its value will keeps 0. 0 indicates success in the context, which is inconsistent with the execution result. This patch fixes the bug, assigning "-ENOMEM" to ret when

WARNING: CPU: 1 PID: 22073 at kernel/locking/mutex-debug.c:41 debug_mutex_wake_waiter+0x7c/0x160

2016-12-03 Thread Borislav Petkov
Lemme add the usual suspects. I see also fuse in the splat, + Miklos. This is rc7 + tip/master. [ 8837.520731] [ cut here ] [ 8837.520739] WARNING: CPU: 1 PID: 22073 at kernel/locking/mutex-debug.c:41 debug_mutex_wake_waiter+0x7c/0x160 [ 8837.520740]

WARNING: CPU: 1 PID: 22073 at kernel/locking/mutex-debug.c:41 debug_mutex_wake_waiter+0x7c/0x160

2016-12-03 Thread Borislav Petkov
Lemme add the usual suspects. I see also fuse in the splat, + Miklos. This is rc7 + tip/master. [ 8837.520731] [ cut here ] [ 8837.520739] WARNING: CPU: 1 PID: 22073 at kernel/locking/mutex-debug.c:41 debug_mutex_wake_waiter+0x7c/0x160 [ 8837.520740]

[PATCH 1/1] btrfs: fix improper return value

2016-12-03 Thread Pan Bian
In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret on errors. However, it directly returns 0. It may be better to return ret. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731 Signed-off-by: Pan Bian --- fs/btrfs/uuid-tree.c | 2 +- 1 file

[PATCH 1/1] btrfs: fix improper return value

2016-12-03 Thread Pan Bian
In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret on errors. However, it directly returns 0. It may be better to return ret. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731 Signed-off-by: Pan Bian --- fs/btrfs/uuid-tree.c | 2 +- 1 file changed, 1

[PATCH 1/1] xen: xenbus: set error code on failure

2016-12-03 Thread Pan Bian
In function xenstored_local_init(), the value of return variable err should be negative on errors. But the value of err keeps 0 even if the call to get_zeroed_page() returns a NULL pointer. This patch assigns "-ENOMEM" to err on the error branch. Bugzilla:

[PATCH 1/1] xen: xenbus: set error code on failure

2016-12-03 Thread Pan Bian
In function xenstored_local_init(), the value of return variable err should be negative on errors. But the value of err keeps 0 even if the call to get_zeroed_page() returns a NULL pointer. This patch assigns "-ENOMEM" to err on the error branch. Bugzilla:

Re: [PATCH] staging: greybus: Fix macro definition

2016-12-03 Thread Chinmay V S
On Sat, Dec 3, 2016 at 3:52 PM, Greg KH wrote: > On Sat, Dec 03, 2016 at 03:41:19PM +0530, Chinmay VS wrote: >> From: ChinmayVS >> >> Macros with multiple statements should be enclosed in a do - while loop >> >> Signed-off-by: ChinmayVS

[PATCH 1/1] net: wireless: marvell: fix improper return value

2016-12-03 Thread Pan Bian
Function lbs_cmd_802_11_sleep_params() always return 0, even if the call to lbs_cmd_with_response() fails. In this case, the parameter @sp will keep uninitialized. Because the return value is 0, its caller (say lbs_sleepparams_read()) will not detect the error, and will copy the uninitialized

<    1   2   3   4   5   6   >