Re: [PATCH v9 07/16] drivers: acpi: implement acpi_dma_configure

On Sat, Dec 03, 2016 at 03:11:09AM +0100, Rafael J. Wysocki wrote: > On Fri, Dec 2, 2016 at 4:38 PM, Lorenzo Pieralisi > wrote: > > Rafael, Mark, Suravee, > > > > On Mon, Nov 21, 2016 at 10:01:39AM +, Lorenzo Pieralisi wrote: > >> On DT based systems, the

Re: [PATCH] staging: greybus: Fix macro definition

On Sat, Dec 3, 2016 at 3:52 PM, Greg KH wrote: > On Sat, Dec 03, 2016 at 03:41:19PM +0530, Chinmay VS wrote: >> From: ChinmayVS >> >> Macros with multiple statements should be enclosed in a do - while loop >> >> Signed-off-by: ChinmayVS >> --- >> drivers/staging/greybus/loopback.c | 4 +++- >>

[PATCH 1/1] net: wireless: marvell: fix improper return value

Function lbs_cmd_802_11_sleep_params() always return 0, even if the call to lbs_cmd_with_response() fails. In this case, the parameter @sp will keep uninitialized. Because the return value is 0, its caller (say lbs_sleepparams_read()) will not detect the error, and will copy the uninitialized

Re: [PATCH v9 07/16] drivers: acpi: implement acpi_dma_configure

On Sat, Dec 03, 2016 at 03:11:09AM +0100, Rafael J. Wysocki wrote: > On Fri, Dec 2, 2016 at 4:38 PM, Lorenzo Pieralisi > wrote: > > Rafael, Mark, Suravee, > > > > On Mon, Nov 21, 2016 at 10:01:39AM +, Lorenzo Pieralisi wrote: > >> On DT based systems, the of_dma_configure() API implements DMA

Re: [RFC, PATCH, v3.9] default exported asm symbols to zero

On Saturday, December 3, 2016 4:36:37 AM CET Ben Hutchings wrote: > On Fri, 2016-12-02 at 13:40 +0100, Arnd Bergmann wrote: > > With binutils-2.16 and before, a weak missing symbol was kept during the > > final link, and a missing CRC for an export would lead to that CRC > > being treated as zero

Re: [RFC, PATCH, v3.9] default exported asm symbols to zero

On Saturday, December 3, 2016 4:36:37 AM CET Ben Hutchings wrote: > On Fri, 2016-12-02 at 13:40 +0100, Arnd Bergmann wrote: > > With binutils-2.16 and before, a weak missing symbol was kept during the > > final link, and a missing CRC for an export would lead to that CRC > > being treated as zero

[PATCH 1/1] tty: serial: set error code when kasprintf fails

When the call to kasprintf() returns a NULL pointer, function sci_request_irq() frees the preallocated memory and returns 0 is returned. Because 0 means no error, the caller of sci_request_irq() will keep going, and the freed memory may be used or freed again. To avoid the above issue, this patch

[PATCH 1/1] tty: serial: set error code when kasprintf fails

When the call to kasprintf() returns a NULL pointer, function sci_request_irq() frees the preallocated memory and returns 0 is returned. Because 0 means no error, the caller of sci_request_irq() will keep going, and the freed memory may be used or freed again. To avoid the above issue, this patch

Re: scsi: use-after-free in bio_copy_from_iter

On Fri, Dec 02, 2016 at 05:50:39PM +0100, Dmitry Vyukov wrote: > On Fri, Nov 25, 2016 at 8:08 PM, Dmitry Vyukov wrote: [...] > > +David did some debugging of a similar case. His 0x400 at location > 0x2000efdc refers to 0x at 0x20012fdc in the provided reproducer: >

Re: scsi: use-after-free in bio_copy_from_iter

On Fri, Dec 02, 2016 at 05:50:39PM +0100, Dmitry Vyukov wrote: > On Fri, Nov 25, 2016 at 8:08 PM, Dmitry Vyukov wrote: [...] > > +David did some debugging of a similar case. His 0x400 at location > 0x2000efdc refers to 0x at 0x20012fdc in the provided reproducer: >

[PATCH 1/1] scsi: csiostor: fix improper return value

Function csio_hw_flash_erase_sectors() will always return 0, even on failures. Thus, its callers will not detect the errors, and may produce unexpected behavior. To avoid bugs, this patch replaces "return 0;" with "return ret;". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188681

[PATCH 1/1] scsi: csiostor: fix improper return value

Function csio_hw_flash_erase_sectors() will always return 0, even on failures. Thus, its callers will not detect the errors, and may produce unexpected behavior. To avoid bugs, this patch replaces "return 0;" with "return ret;". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188681

Re: [PATCH] staging: greybus: Fix macro definition

On Sat, Dec 03, 2016 at 03:41:19PM +0530, Chinmay VS wrote: > From: ChinmayVS > > Macros with multiple statements should be enclosed in a do - while loop > > Signed-off-by: ChinmayVS > --- > drivers/staging/greybus/loopback.c | 4 +++- > 1 file changed, 3

[PATCH 1/1] net: wireless: intersil: fix improper return value

Function orinoco_ioctl_commit() returns 0 (indicates success) when the call to orinoco_lock() fails. Thus, the return value is inconsistent with the execution status. It may be better to return "-EBUSY" when the call to orinoco_lock() fails. Bugzilla:

Re: [PATCH] staging: greybus: Fix macro definition

On Sat, Dec 03, 2016 at 03:41:19PM +0530, Chinmay VS wrote: > From: ChinmayVS > > Macros with multiple statements should be enclosed in a do - while loop > > Signed-off-by: ChinmayVS > --- > drivers/staging/greybus/loopback.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >

[PATCH 1/1] net: wireless: intersil: fix improper return value

Function orinoco_ioctl_commit() returns 0 (indicates success) when the call to orinoco_lock() fails. Thus, the return value is inconsistent with the execution status. It may be better to return "-EBUSY" when the call to orinoco_lock() fails. Bugzilla:

[PATCH 1/1] net: wireless: intersil: fix improper return value

Function orinoco_ioctl_commit() returns 0 (indicates success) when the call to orinoco_lock() fails. Thus, the return value is inconsistent with the execution status. It may be better to return "-EBUSY" when the call to orinoco_lock() fails. Bugzilla:

[PATCH 1/1] net: wireless: intersil: fix improper return value

Function orinoco_ioctl_commit() returns 0 (indicates success) when the call to orinoco_lock() fails. Thus, the return value is inconsistent with the execution status. It may be better to return "-EBUSY" when the call to orinoco_lock() fails. Bugzilla:

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > For the first lines of the patch, I opted to create a small function > > instead of breaking the the line in a weird way. > > > > The other changes are simple ones.

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > For the first lines of the patch, I opted to create a small function > > instead of breaking the the line in a weird way. > > > > The other changes are simple ones.

[PATCH 1/1] netdev: broadcom: propagate error code

Function bnxt_hwrm_stat_ctx_alloc() always returns 0, even if the call to _hwrm_send_message() fails. It may be better to propagate the errors to the caller of bnxt_hwrm_stat_ctx_alloc(). Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188661 Signed-off-by: Pan Bian

[PATCH 1/1] netdev: broadcom: propagate error code

Function bnxt_hwrm_stat_ctx_alloc() always returns 0, even if the call to _hwrm_send_message() fails. It may be better to propagate the errors to the caller of bnxt_hwrm_stat_ctx_alloc(). Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188661 Signed-off-by: Pan Bian ---

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

On Sat, Dec 03, 2016 at 10:56:54AM +0100, Fernando Apesteguia wrote: > On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > > For the first lines of the patch, I opted to create a small function > > > instead of

[PATCH] staging: greybus: Fix macro definition

From: ChinmayVS Macros with multiple statements should be enclosed in a do - while loop Signed-off-by: ChinmayVS --- drivers/staging/greybus/loopback.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/loopback.c

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

On Sat, Dec 03, 2016 at 10:56:54AM +0100, Fernando Apesteguia wrote: > On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > > For the first lines of the patch, I opted to create a small function > > > instead of

[PATCH] staging: greybus: Fix macro definition

From: ChinmayVS Macros with multiple statements should be enclosed in a do - while loop Signed-off-by: ChinmayVS --- drivers/staging/greybus/loopback.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/loopback.c

[SPCR] mmio32 iotype access requirements for X-Gene 8250(_dw) UART

Hi Duc, all, (and changing the subject and trimming/adjusting the CC) On 12/02/2016 02:39 PM, Duc Dang wrote: > On Fri, Dec 2, 2016 at 12:11 AM, Jon Masters wrote: >> You're welcome. >> >> (Unrelated) Note that I added a console= and earlycon in my test (and >> got the baud

[SPCR] mmio32 iotype access requirements for X-Gene 8250(_dw) UART

Hi Duc, all, (and changing the subject and trimming/adjusting the CC) On 12/02/2016 02:39 PM, Duc Dang wrote: > On Fri, Dec 2, 2016 at 12:11 AM, Jon Masters wrote: >> You're welcome. >> >> (Unrelated) Note that I added a console= and earlycon in my test (and >> got the baud rate wrong for the

drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move under broadcom vendor directory date: 1 year, 1 month ago config: xtensa-allmodconfig (attached as

drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move under broadcom vendor directory date: 1 year, 1 month ago config: xtensa-allmodconfig (attached as

Re: [PATCH] drm/i915: Remove instructions to file a bug report.

On Sat, 03 Dec 2016, Matt Turner wrote: > From these instructions, users assume that /sys/class/drm/card0/error > contains all the information a developer needs to diagnose and fix a GPU > hang. > > In fact it doesn't, and we have no tools for solving them (other than >

Re: [PATCH] drm/i915: Remove instructions to file a bug report.

On Sat, 03 Dec 2016, Matt Turner wrote: > From these instructions, users assume that /sys/class/drm/card0/error > contains all the information a developer needs to diagnose and fix a GPU > hang. > > In fact it doesn't, and we have no tools for solving them (other than > stabbing in the dark).

[PATCH] staging:bcm2048 : Add parentheses around variable x

Add parentheses around variable x for the readability purpose. This warning was found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging:bcm2048 : Add parentheses around variable x

Add parentheses around variable x for the readability purpose. This warning was found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/1] misc: set error code when devm_kstrdup fails

In function sram_reserve_regions(), the value of return variable ret should be negative on failures. However, the value of ret may be 0 even if the call to devm_kstrdup() returns a NULL pointer. This patch explicitly assigns "-ENOMEM" to ret on the path that devm_kstrdup() fails. Bugzilla:

[PATCH 1/1] misc: set error code when devm_kstrdup fails

In function sram_reserve_regions(), the value of return variable ret should be negative on failures. However, the value of ret may be 0 even if the call to devm_kstrdup() returns a NULL pointer. This patch explicitly assigns "-ENOMEM" to ret on the path that devm_kstrdup() fails. Bugzilla:

[PATCH 1/1] iio: light: fix improper return value

In function cm3232_reg_init(), it returns 0 even if the last call to i2c_smbus_write_byte_data() returns a negative value (indicates error). As a result, the return value may be inconsistent with the execution status, and the caller of cm3232_reg_init() will not be able to detect the error. This

[PATCH 1/1] iio: light: fix improper return value

In function cm3232_reg_init(), it returns 0 even if the last call to i2c_smbus_write_byte_data() returns a negative value (indicates error). As a result, the return value may be inconsistent with the execution status, and the caller of cm3232_reg_init() will not be able to detect the error. This

Re: [PATCH v3 00/13] net: ethernet: ti: cpts: update and fixes

On Fri, Dec 02, 2016 at 02:30:10PM -0600, Grygorii Strashko wrote: > It is preparation series intended to clean up and optimize TI CPTS driver to > facilitate further integration with other TI's SoCs like Keystone 2. > > Changes in v3: > - patches reordered: fixes and small updates moved first >

Re: [PATCH v3 00/13] net: ethernet: ti: cpts: update and fixes

On Fri, Dec 02, 2016 at 02:30:10PM -0600, Grygorii Strashko wrote: > It is preparation series intended to clean up and optimize TI CPTS driver to > facilitate further integration with other TI's SoCs like Keystone 2. > > Changes in v3: > - patches reordered: fixes and small updates moved first >

[PATCH 1/1] dri: vc4: set error code on failure

Function vc4_cl_lookup_bos() does not set the error code when drm_malloc_ab() returns a NULL pointer, and will return 0 (indicates success). This patch fixes the bug, assigning "-ENOMEM" to the return variable ret on the path that memory allocation fails. Bugzilla:

[PATCH 1/1] dri: vc4: set error code on failure

Function vc4_cl_lookup_bos() does not set the error code when drm_malloc_ab() returns a NULL pointer, and will return 0 (indicates success). This patch fixes the bug, assigning "-ENOMEM" to the return variable ret on the path that memory allocation fails. Bugzilla:

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > For the first lines of the patch, I opted to create a small function > instead of breaking the the line in a weird way. > > The other changes are simple ones. > > Signed-off-by: Fernando Apesteguia

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > For the first lines of the patch, I opted to create a small function > instead of breaking the the line in a weird way. > > The other changes are simple ones. > > Signed-off-by: Fernando Apesteguia > --- >

Re: [PATCH v2] lkdtm: Add tests for LIST_POISON and ZERO_SIZE_PTR

On Sat, Dec 03, 2016 at 10:10:57AM +0100, Greg KH wrote: > On Fri, Dec 02, 2016 at 01:32:24PM -0800, Kees Cook wrote: > > On Thu, Dec 1, 2016 at 8:22 PM, Michael Ellerman > > wrote: > > > This adds two tests, to check that a read or write to LIST_POISON1 and > > >

Re: [PATCH v2] lkdtm: Add tests for LIST_POISON and ZERO_SIZE_PTR

On Sat, Dec 03, 2016 at 10:10:57AM +0100, Greg KH wrote: > On Fri, Dec 02, 2016 at 01:32:24PM -0800, Kees Cook wrote: > > On Thu, Dec 1, 2016 at 8:22 PM, Michael Ellerman > > wrote: > > > This adds two tests, to check that a read or write to LIST_POISON1 and > > > ZERO_SIZE_PTR are blocked. > >

Re: [PATCH v2] lkdtm: Add tests for LIST_POISON and ZERO_SIZE_PTR

On Fri, Dec 02, 2016 at 01:32:24PM -0800, Kees Cook wrote: > On Thu, Dec 1, 2016 at 8:22 PM, Michael Ellerman wrote: > > This adds two tests, to check that a read or write to LIST_POISON1 and > > ZERO_SIZE_PTR are blocked. > > > > The default values for both (256 and 16)

Re: [PATCH v2] lkdtm: Add tests for LIST_POISON and ZERO_SIZE_PTR

On Fri, Dec 02, 2016 at 01:32:24PM -0800, Kees Cook wrote: > On Thu, Dec 1, 2016 at 8:22 PM, Michael Ellerman wrote: > > This adds two tests, to check that a read or write to LIST_POISON1 and > > ZERO_SIZE_PTR are blocked. > > > > The default values for both (256 and 16) typically fall in the

Re: [Intel-gfx] [PATCH] drm/i915: Remove instructions to file a bug report.

On Fri, Dec 02, 2016 at 05:03:05PM -0800, Matt Turner wrote: > From these instructions, users assume that /sys/class/drm/card0/error > contains all the information a developer needs to diagnose and fix a GPU > hang. > > In fact it doesn't, and we have no tools for solving them (other than >

Re: [Intel-gfx] [PATCH] drm/i915: Remove instructions to file a bug report.

On Fri, Dec 02, 2016 at 05:03:05PM -0800, Matt Turner wrote: > From these instructions, users assume that /sys/class/drm/card0/error > contains all the information a developer needs to diagnose and fix a GPU > hang. > > In fact it doesn't, and we have no tools for solving them (other than >

[PATCH 1/1] extcon: return error code on failure

Function get_zeroed_page() returns a NULL pointer if there is no enough memory. In function extcon_sync(), it returns 0 if the call to get_zeroed_page() fails. The return value 0 indicates success in the context, which is incosistent with the execution status. This patch fixes the bug by returning

[PATCH 1/1] extcon: return error code on failure

Function get_zeroed_page() returns a NULL pointer if there is no enough memory. In function extcon_sync(), it returns 0 if the call to get_zeroed_page() fails. The return value 0 indicates success in the context, which is incosistent with the execution status. This patch fixes the bug by returning

Re: [PATCH] tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock

03.12.2016 10:06, Bhuvanchandra DV пишет: > On 12/03/2016 02:58 AM, Nikita Yushchenko wrote: > Problem found via lockdep: - lpuart_set_termios() calls del_timer_sync(>lpuart_timer) while holding sport->port.lock - sport->lpuart_timer routine is

Re: [PATCH] fuse: freezing abort when use wait_event_killable{,_exclusive}().

-wait_event_killable-_exclusive/20161203-120253 base: https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next config: x86_64-rhel-7.2 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make

Re: [PATCH] tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock

03.12.2016 10:06, Bhuvanchandra DV пишет: > On 12/03/2016 02:58 AM, Nikita Yushchenko wrote: > Problem found via lockdep: - lpuart_set_termios() calls del_timer_sync(>lpuart_timer) while holding sport->port.lock - sport->lpuart_timer routine is

Re: [PATCH] fuse: freezing abort when use wait_event_killable{,_exclusive}().

-wait_event_killable-_exclusive/20161203-120253 base: https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next config: x86_64-rhel-7.2 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

On 12/1/2016 11:38 PM, Georgi Djakov wrote: On 11/29/2016 05:40 AM, Ritesh Harjani wrote: Hi Georgi, On 11/28/2016 11:09 PM, Georgi Djakov wrote: On apq8016, apq8084 and apq8074 platforms, writing to the software reset register triggers the "power irq". We need to ack and handle the irq,

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

On 12/1/2016 11:38 PM, Georgi Djakov wrote: On 11/29/2016 05:40 AM, Ritesh Harjani wrote: Hi Georgi, On 11/28/2016 11:09 PM, Georgi Djakov wrote: On apq8016, apq8084 and apq8074 platforms, writing to the software reset register triggers the "power irq". We need to ack and handle the irq,

Re: [PATCH 2/2] perf annotate: AArch64 support

Hi, Sorry, I replied little late. I see you already included patch in perf/core. I've tested this patch on powerpc with perf.data and vmlinux shared by Kim. Looks good to me. You can add my Tested-by. -Ravi. On Wednesday 30 November 2016 08:53 PM, Kim Phillips wrote: > This is a regex

Re: [PATCH 2/2] perf annotate: AArch64 support

Hi, Sorry, I replied little late. I see you already included patch in perf/core. I've tested this patch on powerpc with perf.data and vmlinux shared by Kim. Looks good to me. You can add my Tested-by. -Ravi. On Wednesday 30 November 2016 08:53 PM, Kim Phillips wrote: > This is a regex

[PATCH] net: af_mpls.c add space before open parenthesis

Adding space after switch keyword before open parenthesis for readability purpose. This patch fixes the checkpatch.pl warning: space required before the open parenthesis '(' Signed-off-by: Suraj Deshmukh --- net/mpls/af_mpls.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] net: af_mpls.c add space before open parenthesis

Adding space after switch keyword before open parenthesis for readability purpose. This patch fixes the checkpatch.pl warning: space required before the open parenthesis '(' Signed-off-by: Suraj Deshmukh --- net/mpls/af_mpls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

<    1   2   3   4   5   6