Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-12-05 Thread Lino Sanfilippo
Hi Pavel, On 05.12.2016 23:02, Pavel Machek wrote: > > we need spin_lock_bh at minimum, as we are locking user context > against timer. > > Best regards, > Pavel > I was referring to stmmac_tx_clean() which AFAICS is only

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-12-05 Thread Lino Sanfilippo
Hi Pavel, On 05.12.2016 23:02, Pavel Machek wrote: > > we need spin_lock_bh at minimum, as we are locking user context > against timer. > > Best regards, > Pavel > I was referring to stmmac_tx_clean() which AFAICS is only

Re: [PATCH] ACPI/IORT: Make dma masks set-up IORT specific

2016-12-05 Thread Rafael J. Wysocki
On Mon, Dec 5, 2016 at 1:26 PM, Lorenzo Pieralisi wrote: > The introduction of acpi_dma_configure() allows to configure DMA > and related IOMMU for any device that is DMA capable. To achieve > that goal it ensures DMA masks are set-up to sane default values > before

Re: [PATCH] ACPI/IORT: Make dma masks set-up IORT specific

2016-12-05 Thread Rafael J. Wysocki
On Mon, Dec 5, 2016 at 1:26 PM, Lorenzo Pieralisi wrote: > The introduction of acpi_dma_configure() allows to configure DMA > and related IOMMU for any device that is DMA capable. To achieve > that goal it ensures DMA masks are set-up to sane default values > before proceeding with IOMMU and DMA

[PATCH v3 net-next v3 3/4] net: dsa: mv88e6xxx: add a soft reset operation

2016-12-05 Thread Vivien Didelot
Marvell chips have different way to issue a software reset. Old chips (such as 88E6060) have a reset bit in an ATU control register. Newer chips moved this bit in a Global control register. Chips with controllable PPU should reset the PPU when resetting the switch. Add a new reset operation to

[PATCH v3 net-next v3 3/4] net: dsa: mv88e6xxx: add a soft reset operation

2016-12-05 Thread Vivien Didelot
Marvell chips have different way to issue a software reset. Old chips (such as 88E6060) have a reset bit in an ATU control register. Newer chips moved this bit in a Global control register. Chips with controllable PPU should reset the PPU when resetting the switch. Add a new reset operation to

[PATCH v3 net-next v3 2/4] net: dsa: mv88e6xxx: add helper to hardware reset

2016-12-05 Thread Vivien Didelot
Add an helper to toggle the eventual GPIO connected to the reset pin. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-)

[PATCH v3 net-next v3 4/4] net: dsa: mv88e6xxx: add PPU operations

2016-12-05 Thread Vivien Didelot
Some Marvell chips can enable/disable the PPU on demand. This is needed to access the PHY registers when there is no indirection mechanism. Add two new ppu_enable and ppu_disable ops to describe this and finally get rid of the MV88E6XXX_FLAG_PPU* flags. Signed-off-by: Vivien Didelot

[PATCH v3 net-next v3 0/4] net: dsa: mv88e6xxx: rework reset and PPU code

2016-12-05 Thread Vivien Didelot
Old Marvell chips (like 88E6060) don't have a PHY Polling Unit (PPU). Next chips (like 88E6185) have a PPU, which has exclusive access to the PHY registers, thus must be disabled before access. Newer chips (like 88E6352) have an indirect mechanism to access the PHY registers whenever, thus loose

[PATCH v3 net-next v3 2/4] net: dsa: mv88e6xxx: add helper to hardware reset

2016-12-05 Thread Vivien Didelot
Add an helper to toggle the eventual GPIO connected to the reset pin. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c

[PATCH v3 net-next v3 4/4] net: dsa: mv88e6xxx: add PPU operations

2016-12-05 Thread Vivien Didelot
Some Marvell chips can enable/disable the PPU on demand. This is needed to access the PHY registers when there is no indirection mechanism. Add two new ppu_enable and ppu_disable ops to describe this and finally get rid of the MV88E6XXX_FLAG_PPU* flags. Signed-off-by: Vivien Didelot ---

[PATCH v3 net-next v3 0/4] net: dsa: mv88e6xxx: rework reset and PPU code

2016-12-05 Thread Vivien Didelot
Old Marvell chips (like 88E6060) don't have a PHY Polling Unit (PPU). Next chips (like 88E6185) have a PPU, which has exclusive access to the PHY registers, thus must be disabled before access. Newer chips (like 88E6352) have an indirect mechanism to access the PHY registers whenever, thus loose

[PATCH v3 net-next v3 1/4] net: dsa: mv88e6xxx: add helper to disable ports

2016-12-05 Thread Vivien Didelot
Before resetting a switch, the ports should be set to the Disabled state and the transmit queues should be drained. Add an helper to explicit that. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c

[PATCH v3 net-next v3 1/4] net: dsa: mv88e6xxx: add helper to disable ports

2016-12-05 Thread Vivien Didelot
Before resetting a switch, the ports should be set to the Disabled state and the transmit queues should be drained. Add an helper to explicit that. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 34 +++--- 1 file

Re: [PATCH 39/39] mtd: nand: denali_dt: add compatible strings for UniPhier SoC variants

2016-12-05 Thread Dinh Nguyen
On 12/05/2016 03:29 PM, Marek Vasut wrote: > On 12/05/2016 09:51 PM, Dinh Nguyen wrote: >> On Sun, Dec 4, 2016 at 10:22 PM, Marek Vasut wrote: >>> On 12/05/2016 05:10 AM, Masahiro Yamada wrote: Hi Marek, 2016-12-05 12:44 GMT+09:00 Marek Vasut

Re: [PATCH 39/39] mtd: nand: denali_dt: add compatible strings for UniPhier SoC variants

2016-12-05 Thread Dinh Nguyen
On 12/05/2016 03:29 PM, Marek Vasut wrote: > On 12/05/2016 09:51 PM, Dinh Nguyen wrote: >> On Sun, Dec 4, 2016 at 10:22 PM, Marek Vasut wrote: >>> On 12/05/2016 05:10 AM, Masahiro Yamada wrote: Hi Marek, 2016-12-05 12:44 GMT+09:00 Marek Vasut : > On 12/05/2016 04:30 AM,

Re: [PATCH 1/2 v2] scsi: be2iscsi: set errno on error path

2016-12-05 Thread Martin K. Petersen
> "Pan" == Pan Bian writes: Pan> Variable ret is reset in the loop, and its value will be 0 during Pan> the after repeat of the loop. Then, if pci_alloc_consistent() Pan> returns NULL, the return value is 0. 0 means no error, which may Pan> make it impossible for the

Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting.

2016-12-05 Thread Emil Bartczak
On Mon, Dec 05, 2016 at 11:15:59PM +0100, Alexandre Belloni wrote: > On 05/12/2016 at 23:03:52 +0100, Emil Bartczak wrote : > > > > > > > #define MCP795_WRITE 0x12 > > > > #define MCP795_UNLOCK 0x14 > > > > #define MCP795_IDWRITE 0x32 > > > > @@ -39,6 +39,7 @@ > > > > > > > > #define

Re: [PATCH 1/2 v2] scsi: be2iscsi: set errno on error path

2016-12-05 Thread Martin K. Petersen
> "Pan" == Pan Bian writes: Pan> Variable ret is reset in the loop, and its value will be 0 during Pan> the after repeat of the loop. Then, if pci_alloc_consistent() Pan> returns NULL, the return value is 0. 0 means no error, which may Pan> make it impossible for the callers of

Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting.

2016-12-05 Thread Emil Bartczak
On Mon, Dec 05, 2016 at 11:15:59PM +0100, Alexandre Belloni wrote: > On 05/12/2016 at 23:03:52 +0100, Emil Bartczak wrote : > > > > > > > #define MCP795_WRITE 0x12 > > > > #define MCP795_UNLOCK 0x14 > > > > #define MCP795_IDWRITE 0x32 > > > > @@ -39,6 +39,7 @@ > > > > > > > > #define

Re: [RFC v3 1/6] Track the active utilisation

2016-12-05 Thread luca abeni
Hi Peter, On Fri, 18 Nov 2016 15:23:59 +0100 Peter Zijlstra wrote: [...] > u64 running_bw; > > static void add_running_bw(struct sched_dl_entity *dl_se, struct > dl_rq *dl_rq) { > u64 old = dl_rq->running_bw; > > dl_rq->running_bw += dl_se->dl_bw; >

Re: [RFC v3 1/6] Track the active utilisation

2016-12-05 Thread luca abeni
Hi Peter, On Fri, 18 Nov 2016 15:23:59 +0100 Peter Zijlstra wrote: [...] > u64 running_bw; > > static void add_running_bw(struct sched_dl_entity *dl_se, struct > dl_rq *dl_rq) { > u64 old = dl_rq->running_bw; > > dl_rq->running_bw += dl_se->dl_bw; >

Re: [PATCH 1/2] scsi: be2iscsi: set errno on error path

2016-12-05 Thread Martin K. Petersen
> "Pan" == Pan Bian writes: Pan> Variable ret is reset in the loop, and its value will be 0 during Pan> the second and after repeat of the loop. If pci_alloc_consistent() Pan> returns a NULL pointer then, it will leaves with return value 0. 0 Pan> means no error, which

Re: [PATCH 1/2] scsi: be2iscsi: set errno on error path

2016-12-05 Thread Martin K. Petersen
> "Pan" == Pan Bian writes: Pan> Variable ret is reset in the loop, and its value will be 0 during Pan> the second and after repeat of the loop. If pci_alloc_consistent() Pan> returns a NULL pointer then, it will leaves with return value 0. 0 Pan> means no error, which is contrary to the

Re: [PATCH v4 1/9] dt-bindings: clarify compatible property for rockchip timers

2016-12-05 Thread Rob Herring
On Tue, Nov 29, 2016 at 07:14:44PM +0300, Alexander Kochetkov wrote: > Make all properties description in form '"rockchip,-timer", > "rockchip,rk3288-timer"' for all chips found in linux kernel. > > Suggested-by: Heiko Stübner > Signed-off-by: Alexander Kochetkov

Re: [PATCH v4 1/9] dt-bindings: clarify compatible property for rockchip timers

2016-12-05 Thread Rob Herring
On Tue, Nov 29, 2016 at 07:14:44PM +0300, Alexander Kochetkov wrote: > Make all properties description in form '"rockchip,-timer", > "rockchip,rk3288-timer"' for all chips found in linux kernel. > > Suggested-by: Heiko Stübner > Signed-off-by: Alexander Kochetkov > --- >

Re: [PATCH] iommu/intel: disable DMAR for Q35 integrated gfx

2016-12-05 Thread Kees Cook
On Mon, Dec 5, 2016 at 2:07 PM, David Woodhouse wrote: > On Mon, 2016-12-05 at 13:58 -0800, Kees Cook wrote: >> This blacklists the Q35 integrated graphics so IOMMU can be otherwise >> enabled. Without this, a Q35 system can only enable IOMMU when booting >> with

Re: [PATCH] iommu/intel: disable DMAR for Q35 integrated gfx

2016-12-05 Thread Kees Cook
On Mon, Dec 5, 2016 at 2:07 PM, David Woodhouse wrote: > On Mon, 2016-12-05 at 13:58 -0800, Kees Cook wrote: >> This blacklists the Q35 integrated graphics so IOMMU can be otherwise >> enabled. Without this, a Q35 system can only enable IOMMU when booting >> with "intel_iommu=on,igfx_off" but not

Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations

2016-12-05 Thread Vivien Didelot
Stefan Eichenberger writes: > Hi Vivien, > > On Mon, Dec 05, 2016 at 11:27:03AM -0500, Vivien Didelot wrote: >> @@ -3266,6 +3220,8 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { >> .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, >> .g1_set_egress_port =

Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations

2016-12-05 Thread Vivien Didelot
Stefan Eichenberger writes: > Hi Vivien, > > On Mon, Dec 05, 2016 at 11:27:03AM -0500, Vivien Didelot wrote: >> @@ -3266,6 +3220,8 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { >> .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, >> .g1_set_egress_port =

Re: [PATCH 3/4] rtc: mcp795: fix month write resetting date to 1.

2016-12-05 Thread Emil Bartczak
Hi, On Mon, Dec 05, 2016 at 04:24:10PM +0100, Alexandre Belloni wrote: > On 05/12/2016 at 14:11:52 +0100, Emil Bartczak wrote : > > According to Microchip errata some combinations of date and month > > values may result in the date being reset to 1, even if the date > > is also written with the

Re: [PATCH 3/4] rtc: mcp795: fix month write resetting date to 1.

2016-12-05 Thread Emil Bartczak
Hi, On Mon, Dec 05, 2016 at 04:24:10PM +0100, Alexandre Belloni wrote: > On 05/12/2016 at 14:11:52 +0100, Emil Bartczak wrote : > > According to Microchip errata some combinations of date and month > > values may result in the date being reset to 1, even if the date > > is also written with the

Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting.

2016-12-05 Thread Alexandre Belloni
On 05/12/2016 at 23:03:52 +0100, Emil Bartczak wrote : > > > > > #define MCP795_WRITE 0x12 > > > #define MCP795_UNLOCK0x14 > > > #define MCP795_IDWRITE 0x32 > > > @@ -39,6 +39,7 @@ > > > > > > #define MCP795_ST_BIT0x80 > > > #define MCP795_24_BIT0x40 > > > +#define

Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting.

2016-12-05 Thread Alexandre Belloni
On 05/12/2016 at 23:03:52 +0100, Emil Bartczak wrote : > > > > > #define MCP795_WRITE 0x12 > > > #define MCP795_UNLOCK0x14 > > > #define MCP795_IDWRITE 0x32 > > > @@ -39,6 +39,7 @@ > > > > > > #define MCP795_ST_BIT0x80 > > > #define MCP795_24_BIT0x40 > > > +#define

Re: Build error due to commit 8ab2ae655b ("default exported asm symbols to zero")

2016-12-05 Thread Linus Torvalds
On Mon, Dec 5, 2016 at 1:23 PM, Guenter Roeck wrote: > > commit 8ab2ae655bf ("default exported asm symbols to zero") results > in the following build error when building alpha:allmodconfig. > > arch/alpha/lib/callback_srm.S: Assembler messages: >

Re: Build error due to commit 8ab2ae655b ("default exported asm symbols to zero")

2016-12-05 Thread Linus Torvalds
On Mon, Dec 5, 2016 at 1:23 PM, Guenter Roeck wrote: > > commit 8ab2ae655bf ("default exported asm symbols to zero") results > in the following build error when building alpha:allmodconfig. > > arch/alpha/lib/callback_srm.S: Assembler messages: > arch/alpha/lib/callback_srm.S:97: Warning: >

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-12-05 Thread Pavel Machek
Hi! > > > > Actually, I was wrong. irqlock protection is needed, since > > stmmac_tx_clean() is called from timer, and that's interrupt context, > > as you can confirm using BUG_ON(in_interrupt()); > > > > in_interrupt() can mean both softirq and hardirq context. In this case it > means

Re: [PATCH v3] PCI/ACPI: xgene: Add ECAM quirk for X-Gene PCIe controller

2016-12-05 Thread Duc Dang
On Mon, Dec 5, 2016 at 1:53 PM, Bjorn Helgaas wrote: > On Thu, Dec 01, 2016 at 06:52:23PM -0800, Duc Dang wrote: >> On Thu, Dec 1, 2016 at 10:33 AM, Bjorn Helgaas wrote: > >> I made similar changes in v4 patch. The ECAM quirk will be built when >> ACPI and

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-12-05 Thread Pavel Machek
Hi! > > > > Actually, I was wrong. irqlock protection is needed, since > > stmmac_tx_clean() is called from timer, and that's interrupt context, > > as you can confirm using BUG_ON(in_interrupt()); > > > > in_interrupt() can mean both softirq and hardirq context. In this case it > means

Re: [PATCH v3] PCI/ACPI: xgene: Add ECAM quirk for X-Gene PCIe controller

2016-12-05 Thread Duc Dang
On Mon, Dec 5, 2016 at 1:53 PM, Bjorn Helgaas wrote: > On Thu, Dec 01, 2016 at 06:52:23PM -0800, Duc Dang wrote: >> On Thu, Dec 1, 2016 at 10:33 AM, Bjorn Helgaas wrote: > >> I made similar changes in v4 patch. The ECAM quirk will be built when >> ACPI and PCI_QUIRKS are enabled. >> >> When

[PATCH v4 net-next 2/2] MAINTAINERS: add entry for slicoss ethernet driver

2016-12-05 Thread Lino Sanfilippo
Add myself as maintainer for the slicoss ethernet driver. Signed-off-by: Lino Sanfilippo --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..bb9af28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,11

[PATCH v4 net-next 2/2] MAINTAINERS: add entry for slicoss ethernet driver

2016-12-05 Thread Lino Sanfilippo
Add myself as maintainer for the slicoss ethernet driver. Signed-off-by: Lino Sanfilippo --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..bb9af28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,11 @@ T: git

Gigabit ethernet driver for Alacritechs SLIC devices (v4)

2016-12-05 Thread Lino Sanfilippo
Hi, this is the forth version of the slicoss gigabit ethernet driver (which is a rework of the driver from Alacritech which can currently be found under drivers/staging/slicoss). The driver is supposed to support Mojave, Oasis and Kalahari cards, for both copper and fiber. If this code is

Gigabit ethernet driver for Alacritechs SLIC devices (v4)

2016-12-05 Thread Lino Sanfilippo
Hi, this is the forth version of the slicoss gigabit ethernet driver (which is a rework of the driver from Alacritech which can currently be found under drivers/staging/slicoss). The driver is supposed to support Mojave, Oasis and Kalahari cards, for both copper and fiber. If this code is

[PATCH v4 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-12-05 Thread Lino Sanfilippo
Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer interface control) technology. The driver provides basic support without SLIC for the following devices: - Mojave cards (single port PCI Gigabit) both copper and fiber - Oasis cards (single and dual port PCI-x Gigabit)

[PATCH v4 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-12-05 Thread Lino Sanfilippo
Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer interface control) technology. The driver provides basic support without SLIC for the following devices: - Mojave cards (single port PCI Gigabit) both copper and fiber - Oasis cards (single and dual port PCI-x Gigabit)

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

2016-12-05 Thread Dan Carpenter
Sorry, I was unclear. I have no problem with white space changes on their own or when they are on the same line as something else you're changing. What I meant is that when you're just moving functions around then don't mix unrelated white space changes into that patch. I have automated scripts

Re: [PATCH] iommu/intel: disable DMAR for Q35 integrated gfx

2016-12-05 Thread David Woodhouse
On Mon, 2016-12-05 at 13:58 -0800, Kees Cook wrote: > This blacklists the Q35 integrated graphics so IOMMU can be otherwise > enabled. Without this, a Q35 system can only enable IOMMU when booting > with "intel_iommu=on,igfx_off" but not "intel_iommu=on". Hm, is this definitely the same bug? Or

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

2016-12-05 Thread Dan Carpenter
Sorry, I was unclear. I have no problem with white space changes on their own or when they are on the same line as something else you're changing. What I meant is that when you're just moving functions around then don't mix unrelated white space changes into that patch. I have automated scripts

Re: [PATCH] iommu/intel: disable DMAR for Q35 integrated gfx

2016-12-05 Thread David Woodhouse
On Mon, 2016-12-05 at 13:58 -0800, Kees Cook wrote: > This blacklists the Q35 integrated graphics so IOMMU can be otherwise > enabled. Without this, a Q35 system can only enable IOMMU when booting > with "intel_iommu=on,igfx_off" but not "intel_iommu=on". Hm, is this definitely the same bug? Or

Re: [PATCH] scsi: hpsa: use %phN for short hex dumps

2016-12-05 Thread Martin K. Petersen
> "Rasmus" == Rasmus Villemoes writes: Rasmus> Passing one instead of 8 or 16 arguments reduces the size of the Rasmus> generated code somewhat: Rasmus> add/remove: 2/3 grow/shrink: 1/4 up/down: 1772/-2137 (-365) Rasmus> There's one more candidate, unique_id_show,

Re: [PATCH] scsi: hpsa: use %phN for short hex dumps

2016-12-05 Thread Martin K. Petersen
> "Rasmus" == Rasmus Villemoes writes: Rasmus> Passing one instead of 8 or 16 arguments reduces the size of the Rasmus> generated code somewhat: Rasmus> add/remove: 2/3 grow/shrink: 1/4 up/down: 1772/-2137 (-365) Rasmus> There's one more candidate, unique_id_show, but that uses %02X,

Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting.

2016-12-05 Thread Emil Bartczak
Hi, On Mon, Dec 05, 2016 at 04:09:59PM +0100, Alexandre Belloni wrote: > Hi, > > On 05/12/2016 at 14:11:50 +0100, Emil Bartczak wrote : > > The 10 month register was always set to value 0 in the RTC hardware. > > Due to the bug month November or December became February. > > All your patches

Re: [PATCH 1/4] rtc: mcp795: fix invalid month setting.

2016-12-05 Thread Emil Bartczak
Hi, On Mon, Dec 05, 2016 at 04:09:59PM +0100, Alexandre Belloni wrote: > Hi, > > On 05/12/2016 at 14:11:50 +0100, Emil Bartczak wrote : > > The 10 month register was always set to value 0 in the RTC hardware. > > Due to the bug month November or December became February. > > All your patches

[PATCH] iommu/intel: disable DMAR for Q35 integrated gfx

2016-12-05 Thread Kees Cook
This blacklists the Q35 integrated graphics so IOMMU can be otherwise enabled. Without this, a Q35 system can only enable IOMMU when booting with "intel_iommu=on,igfx_off" but not "intel_iommu=on". 00:02.0 0300: 8086:29b2 (rev 02) (prog-if 00 [VGA controller]) Subsystem: 8086:4f4a

[PATCH] iommu/intel: disable DMAR for Q35 integrated gfx

2016-12-05 Thread Kees Cook
This blacklists the Q35 integrated graphics so IOMMU can be otherwise enabled. Without this, a Q35 system can only enable IOMMU when booting with "intel_iommu=on,igfx_off" but not "intel_iommu=on". 00:02.0 0300: 8086:29b2 (rev 02) (prog-if 00 [VGA controller]) Subsystem: 8086:4f4a

Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove

2016-12-05 Thread Martin K. Petersen
> "John" == John Garry writes: John> This patch addresses 4 problems in the module probe/remove: John> - When hisi_sas_shost_alloc() fails after we alloc shost memory, John> we should free shost memory before the function returns. John> - When hisi_sas_probe() fails

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

2016-12-05 Thread Dilger, Andreas
> On Dec 5, 2016, at 13:50, Dan Carpenter wrote: > > On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: >> -__u32 local_flags = 0; >> +u32 local_flags = 0; > >> -if (local_flags != 0) { >> +if (local_flags) { > > Please avoid these

Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove

2016-12-05 Thread Martin K. Petersen
> "John" == John Garry writes: John> This patch addresses 4 problems in the module probe/remove: John> - When hisi_sas_shost_alloc() fails after we alloc shost memory, John> we should free shost memory before the function returns. John> - When hisi_sas_probe() fails after we alloc the HBA

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

2016-12-05 Thread Dilger, Andreas
> On Dec 5, 2016, at 13:50, Dan Carpenter wrote: > > On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: >> -__u32 local_flags = 0; >> +u32 local_flags = 0; > >> -if (local_flags != 0) { >> +if (local_flags) { > > Please avoid these unrelated white space changes.

Re: [PATCH v3] PCI/ACPI: xgene: Add ECAM quirk for X-Gene PCIe controller

2016-12-05 Thread Bjorn Helgaas
On Thu, Dec 01, 2016 at 06:52:23PM -0800, Duc Dang wrote: > On Thu, Dec 1, 2016 at 10:33 AM, Bjorn Helgaas wrote: > I made similar changes in v4 patch. The ECAM quirk will be built when > ACPI and PCI_QUIRKS are enabled. > > When building for DT only, the ECAM quirk won't be

Re: [PATCH v3] PCI/ACPI: xgene: Add ECAM quirk for X-Gene PCIe controller

2016-12-05 Thread Bjorn Helgaas
On Thu, Dec 01, 2016 at 06:52:23PM -0800, Duc Dang wrote: > On Thu, Dec 1, 2016 at 10:33 AM, Bjorn Helgaas wrote: > I made similar changes in v4 patch. The ECAM quirk will be built when > ACPI and PCI_QUIRKS are enabled. > > When building for DT only, the ECAM quirk won't be compiled. Perfect.

RE: [tpmdd-devel] [PATCH v2 3/3] tpm_crb: request and relinquish locality 0

2016-12-05 Thread Winkler, Tomas
> > CC linux-security-module > > On Sat, Dec 03, 2016 at 07:52:13PM +0200, Jarkko Sakkinen wrote: > > Request and relinquish locality for the driver use in order to be a > > better citizen in a multi locality environment like TXT. The locality > > is requested and relinquished as part of going

RE: [tpmdd-devel] [PATCH v2 3/3] tpm_crb: request and relinquish locality 0

2016-12-05 Thread Winkler, Tomas
> > CC linux-security-module > > On Sat, Dec 03, 2016 at 07:52:13PM +0200, Jarkko Sakkinen wrote: > > Request and relinquish locality for the driver use in order to be a > > better citizen in a multi locality environment like TXT. The locality > > is requested and relinquished as part of going

Re: [PATCH v3 10/30] perf clang: Add builtin clang support ant test case

2016-12-05 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 05, 2016 at 07:02:48PM -0200, Arnaldo Carvalho de Melo escreveu: > Em Mon, Dec 05, 2016 at 08:51:01AM -0800, Alexei Starovoitov escreveu: > > yeah. it's kinda high. I'm guessing rpm llvm libs are in debug mode. > > Try llvm-config --build-mode --assertion-mode > > it should be Release

Re: [PATCH v3 10/30] perf clang: Add builtin clang support ant test case

2016-12-05 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 05, 2016 at 07:02:48PM -0200, Arnaldo Carvalho de Melo escreveu: > Em Mon, Dec 05, 2016 at 08:51:01AM -0800, Alexei Starovoitov escreveu: > > yeah. it's kinda high. I'm guessing rpm llvm libs are in debug mode. > > Try llvm-config --build-mode --assertion-mode > > it should be Release

Re: [PATCH 39/39] mtd: nand: denali_dt: add compatible strings for UniPhier SoC variants

2016-12-05 Thread Marek Vasut
On 12/05/2016 09:51 PM, Dinh Nguyen wrote: > On Sun, Dec 4, 2016 at 10:22 PM, Marek Vasut wrote: >> On 12/05/2016 05:10 AM, Masahiro Yamada wrote: >>> Hi Marek, >>> >>> >>> 2016-12-05 12:44 GMT+09:00 Marek Vasut : On 12/05/2016 04:30 AM, Masahiro

Re: [PATCH 39/39] mtd: nand: denali_dt: add compatible strings for UniPhier SoC variants

2016-12-05 Thread Marek Vasut
On 12/05/2016 09:51 PM, Dinh Nguyen wrote: > On Sun, Dec 4, 2016 at 10:22 PM, Marek Vasut wrote: >> On 12/05/2016 05:10 AM, Masahiro Yamada wrote: >>> Hi Marek, >>> >>> >>> 2016-12-05 12:44 GMT+09:00 Marek Vasut : On 12/05/2016 04:30 AM, Masahiro Yamada wrote: > Hi Dinh, > >

[PATCH 18/20] perf tools: Cleanup build directory before each test

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Cleanup the fixdep tool before every test. Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link:

[PATCH 18/20] perf tools: Cleanup build directory before each test

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Cleanup the fixdep tool before every test. Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1480884178-8072-8-git-send-email-jo...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/make | 2 +-

[PATCH 19/20] perf tools: Add non config targets

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding some missing non config targets that were for some reason omitted. Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link:

[PATCH 19/20] perf tools: Add non config targets

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding some missing non config targets that were for some reason omitted. Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1480884178-8072-7-git-send-email-jo...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo

[PATCH 16/20] perf tools: Move install-gtk target into rules area

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa The upcoming fixdep fix needs all targets at the same area, so they'll fit under a signal condition block. Move install-gtk target into the rules section. Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim

[PATCH 03/20] perf tools: Pass context to perf hook functions

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Pass a pointer to perf hook functions so they receive context information during setup. Signed-off-by: Wang Nan Cc: Alexei Starovoitov Cc: He Kuang Cc: Jiri Olsa Cc: Joe Stringer

[PATCH 16/20] perf tools: Move install-gtk target into rules area

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa The upcoming fixdep fix needs all targets at the same area, so they'll fit under a signal condition block. Move install-gtk target into the rules section. Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link:

[PATCH 03/20] perf tools: Pass context to perf hook functions

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Pass a pointer to perf hook functions so they receive context information during setup. Signed-off-by: Wang Nan Cc: Alexei Starovoitov Cc: He Kuang Cc: Jiri Olsa Cc: Joe Stringer Cc: Zefan Li Cc: pi3or...@163.com Link:

[PATCH 07/20] perf build: Add clang and llvm compile and linking support

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Add necessary c++ flags and link libraries to support builtin clang and LLVM. Add all llvm and clang libraries, so don't need to worry about clang changes its libraries setting. However, linking perf would take much longer than usual. Signed-off-by: Wang Nan

[PATCH 07/20] perf build: Add clang and llvm compile and linking support

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Add necessary c++ flags and link libraries to support builtin clang and LLVM. Add all llvm and clang libraries, so don't need to worry about clang changes its libraries setting. However, linking perf would take much longer than usual. Signed-off-by: Wang Nan Cc: Alexei

[PATCH 08/20] perf clang: Add builtin clang support ant test case

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Add basic clang support in clang.cpp and test__clang() testcase. The first testcase checks if builtin clang is able to generate LLVM IR. tests/clang.c is a proxy. Real testcase resides in utils/c++/clang-test.cpp in c++ and exports C interface to perf test

[PATCH 01/20] tools build: Make fixdep parsing wait for last target

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa The fixdep tool, among other things, replaces the target of the object in the gcc generated dependency output file. The parsing code assumes there's only single target in the rule but this is not always the case as described in here:

[PATCH 08/20] perf clang: Add builtin clang support ant test case

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Add basic clang support in clang.cpp and test__clang() testcase. The first testcase checks if builtin clang is able to generate LLVM IR. tests/clang.c is a proxy. Real testcase resides in utils/c++/clang-test.cpp in c++ and exports C interface to perf test subsystem. Test

[PATCH 01/20] tools build: Make fixdep parsing wait for last target

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa The fixdep tool, among other things, replaces the target of the object in the gcc generated dependency output file. The parsing code assumes there's only single target in the rule but this is not always the case as described in here:

[PATCH 06/20] tools build: Add feature detection for clang

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Check if basic clang compiling environment is ready. Doesn't like 'llvm-config --libs' which can returns llvm libraries in right order and duplicates some libraries if necessary, there's no correspondence for clang libraries (-lclangxxx). to avoid extra

[PATCH 09/20] perf clang: Use real file system for #include

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Utilize clang's OverlayFileSystem facility, allow CompilerInstance to access real file system. With this patch the '#include' directive can be used. Add a new getModuleFromSource for real file. Signed-off-by: Wang Nan Cc: Alexei

[PATCH 15/20] tools build: Move tabs to spaces where suitable

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We've been hit several times by a Makefile bug where line indented by tab was falsely considered as target command. We prevent this by always using space indentation for everything except for the target commands. Signed-off-by: Jiri Olsa Cc:

[PATCH 11/20] perf clang: Update test case to use real BPF script

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Allow C++ code to use util.h and tests/llvm.h. Let 'perf test' compile a real BPF script. Signed-off-by: Wang Nan Cc: Alexei Starovoitov Cc: He Kuang Cc: Jiri Olsa Cc: Joe Stringer

[PATCH 06/20] tools build: Add feature detection for clang

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Check if basic clang compiling environment is ready. Doesn't like 'llvm-config --libs' which can returns llvm libraries in right order and duplicates some libraries if necessary, there's no correspondence for clang libraries (-lclangxxx). to avoid extra complexity and to avoid

[PATCH 09/20] perf clang: Use real file system for #include

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Utilize clang's OverlayFileSystem facility, allow CompilerInstance to access real file system. With this patch the '#include' directive can be used. Add a new getModuleFromSource for real file. Signed-off-by: Wang Nan Cc: Alexei Starovoitov Cc: He Kuang Cc: Jiri Olsa Cc:

[PATCH 15/20] tools build: Move tabs to spaces where suitable

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We've been hit several times by a Makefile bug where line indented by tab was falsely considered as target command. We prevent this by always using space indentation for everything except for the target commands. Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc:

[PATCH 11/20] perf clang: Update test case to use real BPF script

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Allow C++ code to use util.h and tests/llvm.h. Let 'perf test' compile a real BPF script. Signed-off-by: Wang Nan Cc: Alexei Starovoitov Cc: He Kuang Cc: Jiri Olsa Cc: Joe Stringer Cc: Zefan Li Cc: pi3or...@163.com Link:

Re: [PATCH v3] PCI/ACPI: xgene: Add ECAM quirk for X-Gene PCIe controller

2016-12-05 Thread Duc Dang
On Mon, Dec 5, 2016 at 1:20 PM, Bjorn Helgaas wrote: > On Fri, Dec 02, 2016 at 11:06:30PM -0800, Duc Dang wrote: >> On Fri, Dec 2, 2016 at 3:39 PM, Bjorn Helgaas wrote: > >> > diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c >> > index

[PATCH 20/20] perf annotate: Show raw form for jump instruction with indirect target

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Ravi Bangoria For jump instructions that does not include target address as direct operand, show the original disassembled line for them. This is needed for certain powerpc jump instructions that use target address in a register (such as bctr, btar, ...).

[PATCH 17/20] perf tools: Move python/perf.so target into rules area

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Following fixdep fix needs all targets at the same area, so they'll fit under signal condition block. Moving python/perf.so target into rules section and intentionally removing the perl script related comment. Signed-off-by: Jiri Olsa Cc:

[PATCH 20/20] perf annotate: Show raw form for jump instruction with indirect target

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Ravi Bangoria For jump instructions that does not include target address as direct operand, show the original disassembled line for them. This is needed for certain powerpc jump instructions that use target address in a register (such as bctr, btar, ...). Before: ld

[PATCH 17/20] perf tools: Move python/perf.so target into rules area

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Following fixdep fix needs all targets at the same area, so they'll fit under signal condition block. Moving python/perf.so target into rules section and intentionally removing the perl script related comment. Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc:

Re: [PATCH v3] PCI/ACPI: xgene: Add ECAM quirk for X-Gene PCIe controller

2016-12-05 Thread Duc Dang
On Mon, Dec 5, 2016 at 1:20 PM, Bjorn Helgaas wrote: > On Fri, Dec 02, 2016 at 11:06:30PM -0800, Duc Dang wrote: >> On Fri, Dec 2, 2016 at 3:39 PM, Bjorn Helgaas wrote: > >> > diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c >> > index 8a177a1..a16fc8e 100644 >> > ---

[PATCH 14/20] tools build: Make the .cmd file more readable

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Putting extra line between dependencies and cmd_* definition to make it more readable. Before: $ cat .builtin-top.o.cmd ... /home/jolsa/kernel/linux-perf/tools/include/linux/stringify.h \ /home/jolsa/kernel/linux-perf/tools/include/linux/time64.h

[PATCH 05/20] tools build: Add feature detection for LLVM

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Check if basic LLVM compiling environment is ready. Use llvm-config to detect include and library directories. Avoid using 'llvm-config --cxxflags' because its result contain some unwanted flags like --sysroot (if LLVM is built by yocto). Use '?=' to set

[PATCH 14/20] tools build: Make the .cmd file more readable

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Putting extra line between dependencies and cmd_* definition to make it more readable. Before: $ cat .builtin-top.o.cmd ... /home/jolsa/kernel/linux-perf/tools/include/linux/stringify.h \ /home/jolsa/kernel/linux-perf/tools/include/linux/time64.h cmd_builtin-top.o :=

[PATCH 05/20] tools build: Add feature detection for LLVM

2016-12-05 Thread Arnaldo Carvalho de Melo
From: Wang Nan Check if basic LLVM compiling environment is ready. Use llvm-config to detect include and library directories. Avoid using 'llvm-config --cxxflags' because its result contain some unwanted flags like --sysroot (if LLVM is built by yocto). Use '?=' to set LLVM_CONFIG, so

<    1   2   3   4   5   6   7   8   9   10   >