[PATCH resend 3/8] irda: w83977af_ir: Remove and add blank lines

Use a more typical vertical spacing style. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 4ad91f4f867f..5aa61413aea8

[PATCH resend 4/8] irda: w83977af_ir: Neaten pointer comparisons

Convert pointer comparisons to NULL. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index

[PATCH resend 2/8] irda: w83977af_ir: More whitespace neatening

Add spaces around operators. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 232 - 1 file changed, 116 insertions(+), 116 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c

[PATCH resend 7/8] irda: w83977af_ir: Neaten logging

Use more common logging style, standardize function output logging use. Miscellanea: o Add and use pr_fmt o Convert printks to pr_ Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 48 -- 1 file changed, 23 insertions(+),

[PATCH resend 3/8] irda: w83977af_ir: Remove and add blank lines

Use a more typical vertical spacing style. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 4ad91f4f867f..5aa61413aea8 100644 ---

[PATCH resend 4/8] irda: w83977af_ir: Neaten pointer comparisons

Convert pointer comparisons to NULL. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 5aa61413aea8..ac481303e3ab

[PATCH resend 2/8] irda: w83977af_ir: More whitespace neatening

Add spaces around operators. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 232 - 1 file changed, 116 insertions(+), 116 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c

[PATCH resend 7/8] irda: w83977af_ir: Neaten logging

Use more common logging style, standardize function output logging use. Miscellanea: o Add and use pr_fmt o Convert printks to pr_ Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 48 -- 1 file changed, 23 insertions(+), 25 deletions(-)

[PATCH resend 6/8] irda: w83977af_ir: Parenthesis alignment

Neaten function declaration and definition arguments. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index

[PATCH resend 6/8] irda: w83977af_ir: Parenthesis alignment

Neaten function declaration and definition arguments. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 5d776fb716f4..9c5b780b1d39 100644 ---

[PATCH resend 0/8] irda: w83977af_ir: Neatening

On top of Arnd's overly long udelay patch because I noticed a misindented block. Even though I haven't turned on the netwinder in a box in the garage in who knows how long, if this device is still used somewhere, might as well neaten the code too. Joe Perches (8): irda: w83977af_ir: whitespace

[PATCH resend 0/8] irda: w83977af_ir: Neatening

On top of Arnd's overly long udelay patch because I noticed a misindented block. Even though I haven't turned on the netwinder in a box in the garage in who knows how long, if this device is still used somewhere, might as well neaten the code too. Joe Perches (8): irda: w83977af_ir: whitespace

[PATCH resend 1/8] irda: w83977af_ir: whitespace neatening

Remove leading and trailing whitespace. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 392 - 1 file changed, 196 insertions(+), 196 deletions(-) diff --git

[PATCH resend 1/8] irda: w83977af_ir: whitespace neatening

Remove leading and trailing whitespace. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 392 - 1 file changed, 196 insertions(+), 196 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c

[PATCH resend 8/8] irda: w83977af_ir: Fix misindented block

One indent level too many is too many. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index

[PATCH resend 8/8] irda: w83977af_ir: Fix misindented block

One indent level too many is too many. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 19b171af0e81..b865e93f01a0 100644 ---

[PATCH resend 5/8] irda: w83977af_ir: Use the common brace style

Add braces where appropriate and remove an unnecessary else. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c

[PATCH resend 5/8] irda: w83977af_ir: Use the common brace style

Add braces where appropriate and remove an unnecessary else. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index

Re: [PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode

On Mon, 2016-12-05 at 20:29 +0200, Netanel Belgazal wrote: > You are correct. > I didn't see the patches. > It is much better to use the napi_complete_done() return value. > I'll rework my patch. Excellent, please CC me on this particular work on the future. Thanks.

Re: [PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode

On Mon, 2016-12-05 at 20:29 +0200, Netanel Belgazal wrote: > You are correct. > I didn't see the patches. > It is much better to use the napi_complete_done() return value. > I'll rework my patch. Excellent, please CC me on this particular work on the future. Thanks.

Re: [PATCH] SPCR: check bit width for the 16550 UART

On Mon, Dec 5, 2016 at 5:05 AM, Aleksey Makarov wrote: > Check the 'Register Bit Width' field of the ACPI Generic Address > Structure that specifies the address of the UART registers to > decide if the driver should use "mmio32" access instead of "mmio". > > If the

Re: [PATCH] SPCR: check bit width for the 16550 UART

On Mon, Dec 5, 2016 at 5:05 AM, Aleksey Makarov wrote: > Check the 'Register Bit Width' field of the ACPI Generic Address > Structure that specifies the address of the UART registers to > decide if the driver should use "mmio32" access instead of "mmio". > > If the driver is other than 16550 the

Re: Enabling peer to peer device transactions for PCIe devices

On Mon, Dec 5, 2016 at 10:39 AM, Logan Gunthorpe wrote: > On 05/12/16 11:08 AM, Dan Williams wrote: >> >> I've already recommended that iopmem not be a block device and instead >> be a device-dax instance. I also don't think it should claim the PCI >> ID, rather the driver

Re: Enabling peer to peer device transactions for PCIe devices

On Mon, Dec 5, 2016 at 10:39 AM, Logan Gunthorpe wrote: > On 05/12/16 11:08 AM, Dan Williams wrote: >> >> I've already recommended that iopmem not be a block device and instead >> be a device-dax instance. I also don't think it should claim the PCI >> ID, rather the driver that wants to map one

Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote: There is desc_read() macros to read desc fields, so no need to use __raw_readl(); Signed-off-by: Ivan Khoronzhuk I'm going to update it all at once as part of [1]. [1] https://lkml.org/lkml/2016/12/1/781 ---

Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote: There is desc_read() macros to read desc fields, so no need to use __raw_readl(); Signed-off-by: Ivan Khoronzhuk I'm going to update it all at once as part of [1]. [1] https://lkml.org/lkml/2016/12/1/781 --- Based on net-next/master

RE: [patch net] net: fec: fix compile with CONFIG_M5272

From: Nikita Yushchenko Sent: Sunday, December 04, 2016 11:18 PM >To: David S. Miller ; Andy Duan >; Troy Kisky ; >Andrew Lunn ; Eric Nelson ; Philippe

RE: [patch net] net: fec: fix compile with CONFIG_M5272

From: Nikita Yushchenko Sent: Sunday, December 04, 2016 11:18 PM >To: David S. Miller ; Andy Duan >; Troy Kisky ; >Andrew Lunn ; Eric Nelson ; Philippe >Reynes ; Johannes Berg ; >net...@vger.kernel.org >Cc: Chris Healy ; Fabio Estevam >; linux-kernel@vger.kernel.org; Nikita >Yushchenko

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

On Mon, 5 Dec 2016, David Miller wrote: > From: Nicolas Pitre > Date: Mon, 5 Dec 2016 10:44:32 -0500 (EST) > > > On Sat, 3 Dec 2016, David Miller wrote: > > > >> From: Arnd Bergmann > >> Date: Sat, 3 Dec 2016 00:04:32 +0100 > >> > >> > ptp now

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

On Mon, 5 Dec 2016, David Miller wrote: > From: Nicolas Pitre > Date: Mon, 5 Dec 2016 10:44:32 -0500 (EST) > > > On Sat, 3 Dec 2016, David Miller wrote: > > > >> From: Arnd Bergmann > >> Date: Sat, 3 Dec 2016 00:04:32 +0100 > >> > >> > ptp now depends on the optional POSIX_TIMERS setting

Re: [PATCH net-next] r8169: Add support for restarting auto-negotiation

From: Florian Fainelli Date: Sat, 3 Dec 2016 12:01:19 -0800 > Implement ethtooll::nway_restart by utilizing mii_nway_restart. > > Signed-off-by: Florian Fainelli Applied.

Re: [PATCH net-next] r8169: Add support for restarting auto-negotiation

From: Florian Fainelli Date: Sat, 3 Dec 2016 12:01:19 -0800 > Implement ethtooll::nway_restart by utilizing mii_nway_restart. > > Signed-off-by: Florian Fainelli Applied.

Re: Enabling peer to peer device transactions for PCIe devices

On 05/12/16 11:08 AM, Dan Williams wrote: I've already recommended that iopmem not be a block device and instead be a device-dax instance. I also don't think it should claim the PCI ID, rather the driver that wants to map one of its bars this way can register the memory region with the

Re: Enabling peer to peer device transactions for PCIe devices

On 05/12/16 11:08 AM, Dan Williams wrote: I've already recommended that iopmem not be a block device and instead be a device-dax instance. I also don't think it should claim the PCI ID, rather the driver that wants to map one of its bars this way can register the memory region with the

Re: [PATCH v2] net: ping: check minimum size on ICMP header length

From: Kees Cook Date: Mon, 5 Dec 2016 10:34:38 -0800 > Prior to commit c0371da6047a ("put iov_iter into msghdr") in v3.19, there > was no check that the iovec contained enough bytes for an ICMP header, > and the read loop would walk across neighboring stack contents. Since

Re: [PATCH v2] net: ping: check minimum size on ICMP header length

From: Kees Cook Date: Mon, 5 Dec 2016 10:34:38 -0800 > Prior to commit c0371da6047a ("put iov_iter into msghdr") in v3.19, there > was no check that the iovec contained enough bytes for an ICMP header, > and the read loop would walk across neighboring stack contents. Since the > iov_iter

Re: [PATCH 0/8] irda: w83977af_ir: Neatening

From: Joe Perches Date: Mon, 05 Dec 2016 10:16:41 -0800 > On Thu, 2016-11-24 at 11:10 -0800, Joe Perches wrote: >> On top of Arnd's overly long udelay patch because I noticed a >> misindented block. >> >> Even though I haven't turned on the netwinder in a box in in the >>

Re: [PATCH 0/8] irda: w83977af_ir: Neatening

From: Joe Perches Date: Mon, 05 Dec 2016 10:16:41 -0800 > On Thu, 2016-11-24 at 11:10 -0800, Joe Perches wrote: >> On top of Arnd's overly long udelay patch because I noticed a >> misindented block. >> >> Even though I haven't turned on the netwinder in a box in in the >> garage in who knows

Re: [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration

On 12/05/2016 06:20 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:23PM +0200, Netanel Belgazal wrote: ENA default hash configure IPv4_frag hash twice instead of configure -> configures. You may want to include "erroneously". What is the consequence of this bug? I'll fix and I'll add

Re: [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration

On 12/05/2016 06:20 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:23PM +0200, Netanel Belgazal wrote: ENA default hash configure IPv4_frag hash twice instead of configure -> configures. You may want to include "erroneously". What is the consequence of this bug? I'll fix and I'll add

[PATCH v2] net: ping: check minimum size on ICMP header length

Prior to commit c0371da6047a ("put iov_iter into msghdr") in v3.19, there was no check that the iovec contained enough bytes for an ICMP header, and the read loop would walk across neighboring stack contents. Since the iov_iter conversion, bad arguments are noticed, but the returned error is

Re: [PATCH v3 00/13] net: ethernet: ti: cpts: update and fixes

On 12/03/2016 03:22 AM, Richard Cochran wrote: On Fri, Dec 02, 2016 at 02:30:10PM -0600, Grygorii Strashko wrote: It is preparation series intended to clean up and optimize TI CPTS driver to facilitate further integration with other TI's SoCs like Keystone 2. Changes in v3: - patches

Re: [PATCH V2 net 08/20] net/ena: add hardware hints capability to the driver

On 12/05/2016 06:31 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:26PM +0200, Netanel Belgazal wrote: The ENA device can update the ena driver about the desire timeouts. The hardware hints are transmitted as Asynchronous event to the driver. This is really a new feature, not a bugfix

[PATCH v2] net: ping: check minimum size on ICMP header length

Prior to commit c0371da6047a ("put iov_iter into msghdr") in v3.19, there was no check that the iovec contained enough bytes for an ICMP header, and the read loop would walk across neighboring stack contents. Since the iov_iter conversion, bad arguments are noticed, but the returned error is

Re: [PATCH v3 00/13] net: ethernet: ti: cpts: update and fixes

On 12/03/2016 03:22 AM, Richard Cochran wrote: On Fri, Dec 02, 2016 at 02:30:10PM -0600, Grygorii Strashko wrote: It is preparation series intended to clean up and optimize TI CPTS driver to facilitate further integration with other TI's SoCs like Keystone 2. Changes in v3: - patches

Re: [PATCH V2 net 08/20] net/ena: add hardware hints capability to the driver

On 12/05/2016 06:31 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:26PM +0200, Netanel Belgazal wrote: The ENA device can update the ena driver about the desire timeouts. The hardware hints are transmitted as Asynchronous event to the driver. This is really a new feature, not a bugfix

Re: [PATCH V2 net 07/20] net/ena: refactor ena_get_stats64 to be atomic context safe

On 12/05/2016 06:24 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:25PM +0200, Netanel Belgazal wrote: ndo_get_stat64 can be called from atomic context. However the current implementation sends an admin command to retrieve the statistics from the device. This admin commands uses sleep.

Re: [PATCH V2 net 06/20] net/ena: fix NULL dereference when removing the driver after device reset faild

On 12/05/2016 06:29 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:24PM +0200, Netanel Belgazal wrote: If for some reason the device stop responding and the device reset failed to recover the device, the mmio register read datastructure will not be reinitialized. If for some reason the

Re: [PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode

On 12/05/2016 07:45 AM, Eric Dumazet wrote: On Sun, 2016-12-04 at 15:19 +0200, Netanel Belgazal wrote: sk_busy_loop can call the napi callback few million times a sec. For each call there is unmask interrupt. We want to reduce the number of unmasks. Add an atomic variable that will tell the

[PATCH 3/7] block: use appropriate queue running functions

Use MQ variants for MQ, legacy ones for legacy. Signed-off-by: Jens Axboe --- block/blk-core.c | 5 - block/blk-exec.c | 10 -- block/blk-flush.c | 14 ++ block/elevator.c | 5 - 4 files changed, 26 insertions(+), 8 deletions(-) diff --git

[PATCH 6/7] blk-mq: test patch to get legacy IO schedulers working

With this applied, a single queue blk-mq manage device can use any of the legacy IO schedulers. This is exposed through Kconfig, exposing MQ scheduler choices. Like with the legacy devices, the IO scheduler can be runtime switched by echoing something else into: /sys/block//queue/scheduler

[PATCH 2/7] cfq-iosched: use appropriate run queue function

For MQ devices, we have to use other functions to run the queue. No functional changes in this patch, just a prep patch for support legacy schedulers on blk-mq. Signed-off-by: Jens Axboe --- block/cfq-iosched.c | 22 +++--- 1 file changed, 19 insertions(+), 3

Re: [PATCH V2 net 07/20] net/ena: refactor ena_get_stats64 to be atomic context safe

On 12/05/2016 06:24 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:25PM +0200, Netanel Belgazal wrote: ndo_get_stat64 can be called from atomic context. However the current implementation sends an admin command to retrieve the statistics from the device. This admin commands uses sleep.

Re: [PATCH V2 net 06/20] net/ena: fix NULL dereference when removing the driver after device reset faild

On 12/05/2016 06:29 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:24PM +0200, Netanel Belgazal wrote: If for some reason the device stop responding and the device reset failed to recover the device, the mmio register read datastructure will not be reinitialized. If for some reason the

Re: [PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode

On 12/05/2016 07:45 AM, Eric Dumazet wrote: On Sun, 2016-12-04 at 15:19 +0200, Netanel Belgazal wrote: sk_busy_loop can call the napi callback few million times a sec. For each call there is unmask interrupt. We want to reduce the number of unmasks. Add an atomic variable that will tell the

[PATCH 3/7] block: use appropriate queue running functions

Use MQ variants for MQ, legacy ones for legacy. Signed-off-by: Jens Axboe --- block/blk-core.c | 5 - block/blk-exec.c | 10 -- block/blk-flush.c | 14 ++ block/elevator.c | 5 - 4 files changed, 26 insertions(+), 8 deletions(-) diff --git a/block/blk-core.c

[PATCH 6/7] blk-mq: test patch to get legacy IO schedulers working

With this applied, a single queue blk-mq manage device can use any of the legacy IO schedulers. This is exposed through Kconfig, exposing MQ scheduler choices. Like with the legacy devices, the IO scheduler can be runtime switched by echoing something else into: /sys/block//queue/scheduler

[PATCH 2/7] cfq-iosched: use appropriate run queue function

For MQ devices, we have to use other functions to run the queue. No functional changes in this patch, just a prep patch for support legacy schedulers on blk-mq. Signed-off-by: Jens Axboe --- block/cfq-iosched.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff

[PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

No functional changes with this patch, it's just in preparation for supporting legacy schedulers on blk-mq. Signed-off-by: Jens Axboe --- block/blk-core.c | 2 +- block/blk-exec.c | 2 +- block/blk-flush.c | 26 ++ block/blk.h | 12 +++- 4

Re: [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails

From: Pan Bian Date: Sat, 3 Dec 2016 19:24:48 +0800 > In function lan78xx_probe(), variable ret takes the errno code on > failures. However, when the call to usb_alloc_urb() fails, its value > will keeps 0. 0 indicates success in the context, which is inconsistent > with

[PATCH 5/7] blk-mq: add BLK_MQ_F_NO_SCHED flag

Drivers can use this to prevent IO scheduling on a queue. Use this for NVMe, for the admin queue, which doesn't handle file system requests. Signed-off-by: Jens Axboe --- drivers/nvme/host/pci.c | 1 + include/linux/blk-mq.h | 1 + 2 files changed, 2 insertions(+) diff --git

Re: [PATCH V2 net 02/20] net/ena: fix error handling when probe fails

On 12/05/2016 06:09 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:20PM +0200, Netanel Belgazal wrote: When driver fails in probe, it will release all resources, including adapter. In case of probe failure, ena_remove should not try to free the adapter resources. Please word wrap your

[PATCHSET/RFC v2] Make legacy IO schedulers work with blk-mq

Version 2 of the hack/patchset, that enables blk-mq to use the legacy IO schedulers with single queue devices. Original posting is here: https://marc.info/?l=linux-block=148073493203664=2 You can also found this version in the following git branch: git://git.kernel.dk/linux-block

Re: [PATCH 1/1] net: bridge: set error code on failure

From: Pan Bian Date: Sat, 3 Dec 2016 19:33:23 +0800 > Function br_sysfs_addbr() does not set error code when the call > kobject_create_and_add() returns a NULL pointer. It may be better to > return "-ENOMEM" when kobject_create_and_add() fails. > > Bugzilla:

Re: [PATCH 1/1] atm: lanai: set error code when ioremap fails

From: Pan Bian Date: Sat, 3 Dec 2016 20:25:45 +0800 > In function lanai_dev_open(), when the call to ioremap() fails, the > value of return variable result is 0. 0 means no error in this context. > This patch fixes the bug, assigning "-ENOMEM" to result when ioremap() >

Re: [PATCH V2 net 02/20] net/ena: fix error handling when probe fails

On 12/05/2016 06:09 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:20PM +0200, Netanel Belgazal wrote: When driver fails in probe, it will release all resources, including adapter. In case of probe failure, ena_remove should not try to free the adapter resources. Please word wrap your

[PATCHSET/RFC v2] Make legacy IO schedulers work with blk-mq

Version 2 of the hack/patchset, that enables blk-mq to use the legacy IO schedulers with single queue devices. Original posting is here: https://marc.info/?l=linux-block=148073493203664=2 You can also found this version in the following git branch: git://git.kernel.dk/linux-block

Re: [PATCH 1/1] net: bridge: set error code on failure

From: Pan Bian Date: Sat, 3 Dec 2016 19:33:23 +0800 > Function br_sysfs_addbr() does not set error code when the call > kobject_create_and_add() returns a NULL pointer. It may be better to > return "-ENOMEM" when kobject_create_and_add() fails. > > Bugzilla:

Re: [PATCH 1/1] atm: lanai: set error code when ioremap fails

From: Pan Bian Date: Sat, 3 Dec 2016 20:25:45 +0800 > In function lanai_dev_open(), when the call to ioremap() fails, the > value of return variable result is 0. 0 means no error in this context. > This patch fixes the bug, assigning "-ENOMEM" to result when ioremap() > returns a NULL pointer.

[PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

No functional changes with this patch, it's just in preparation for supporting legacy schedulers on blk-mq. Signed-off-by: Jens Axboe --- block/blk-core.c | 2 +- block/blk-exec.c | 2 +- block/blk-flush.c | 26 ++ block/blk.h | 12 +++- 4 files

Re: [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails

From: Pan Bian Date: Sat, 3 Dec 2016 19:24:48 +0800 > In function lan78xx_probe(), variable ret takes the errno code on > failures. However, when the call to usb_alloc_urb() fails, its value > will keeps 0. 0 indicates success in the context, which is inconsistent > with the execution result.

[PATCH 5/7] blk-mq: add BLK_MQ_F_NO_SCHED flag

Drivers can use this to prevent IO scheduling on a queue. Use this for NVMe, for the admin queue, which doesn't handle file system requests. Signed-off-by: Jens Axboe --- drivers/nvme/host/pci.c | 1 + include/linux/blk-mq.h | 1 + 2 files changed, 2 insertions(+) diff --git

Re: [PATCH V2 net 13/20] net/ena: change driver's default timeouts

On 12/05/2016 06:35 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:31PM +0200, Netanel Belgazal wrote: ... because? (they turned out to be too aggressive, I believe.) Yes, The timeout were too aggressive on some specific machines. Signed-off-by: Netanel Belgazal

Re: [PATCH V2 net 13/20] net/ena: change driver's default timeouts

On 12/05/2016 06:35 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:31PM +0200, Netanel Belgazal wrote: ... because? (they turned out to be too aggressive, I believe.) Yes, The timeout were too aggressive on some specific machines. Signed-off-by: Netanel Belgazal ---

Re: [PATCH 1/1] netdev: broadcom: propagate error code

From: Pan Bian Date: Sat, 3 Dec 2016 17:56:17 +0800 > Function bnxt_hwrm_stat_ctx_alloc() always returns 0, even if the call > to _hwrm_send_message() fails. It may be better to propagate the errors > to the caller of bnxt_hwrm_stat_ctx_alloc(). > > Bugzilla:

Re: [PATCH 1/1] netdev: broadcom: propagate error code

From: Pan Bian Date: Sat, 3 Dec 2016 17:56:17 +0800 > Function bnxt_hwrm_stat_ctx_alloc() always returns 0, even if the call > to _hwrm_send_message() fails. It may be better to propagate the errors > to the caller of bnxt_hwrm_stat_ctx_alloc(). > > Bugzilla:

Re: bio linked list corruption.

On 5 December 2016 at 19:11, Andy Lutomirski wrote: > On Sun, Dec 4, 2016 at 3:04 PM, Vegard Nossum wrote: >> On 23 November 2016 at 20:58, Dave Jones wrote: >>> On Wed, Nov 23, 2016 at 02:34:19PM -0500, Dave Jones wrote: >>>

[PATCH 4/7] blk-mq: blk_account_io_start() takes a bool

Signed-off-by: Jens Axboe Reviewed-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index bac12caece06..90db5b490df9 100644

[PATCH 7/7] block: drop irq+lock when flushing queue plugs

Not convinced this is a faster approach, and it does look IRQs off longer than otherwise. With mq+scheduling, it's a problem since it forces us to offload the queue running. If we get rid of it, we can run the queue without the queue lock held. Signed-off-by: Jens Axboe ---

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

On 12/05/2016 08:49 AM, Rob Herring wrote: > On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: >> From: WingMan Kwok >> >> This patch adds support of the cpts device found in the >> gbe and 10gbe ethernet switches on the keystone 2 SoCs >> (66AK2E/L/Hx,

[PATCH 7/7] block: drop irq+lock when flushing queue plugs

Not convinced this is a faster approach, and it does look IRQs off longer than otherwise. With mq+scheduling, it's a problem since it forces us to offload the queue running. If we get rid of it, we can run the queue without the queue lock held. Signed-off-by: Jens Axboe --- block/blk-core.c |

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

On 12/05/2016 08:49 AM, Rob Herring wrote: > On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: >> From: WingMan Kwok >> >> This patch adds support of the cpts device found in the >> gbe and 10gbe ethernet switches on the keystone 2 SoCs >> (66AK2E/L/Hx, 66AK2Gx). >> >>

Re: bio linked list corruption.

On 5 December 2016 at 19:11, Andy Lutomirski wrote: > On Sun, Dec 4, 2016 at 3:04 PM, Vegard Nossum wrote: >> On 23 November 2016 at 20:58, Dave Jones wrote: >>> On Wed, Nov 23, 2016 at 02:34:19PM -0500, Dave Jones wrote: >>> >>> > [ 317.689216] BUG: Bad page state in process kworker/u8:8

[PATCH 4/7] blk-mq: blk_account_io_start() takes a bool

Signed-off-by: Jens Axboe Reviewed-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index bac12caece06..90db5b490df9 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On 12/05/2016 05:25 PM, J. Bruce Fields wrote: > On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: Can NFS people comment on this? Where does the nfs4_acl come from? >>> >>> This is the interface

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On 12/05/2016 05:25 PM, J. Bruce Fields wrote: > On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: Can NFS people comment on this? Where does the nfs4_acl come from? >>> >>> This is the interface the NFS client provides

Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

On 12/05/2016 06:18 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote: ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power

Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

On 12/05/2016 06:18 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote: ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power

Re: [PATCH V2 net 03/20] net/ena: fix queues number calculation

On 12/05/2016 06:11 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:21PM +0200, Netanel Belgazal wrote: The ENA driver tries to open a queue per vCPU. To determine how many vCPUs the instance have it uses num_possible_cpus while it should have use num_online_cpus instead. use () when

Re: [PATCH V2 net 03/20] net/ena: fix queues number calculation

On 12/05/2016 06:11 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:21PM +0200, Netanel Belgazal wrote: The ENA driver tries to open a queue per vCPU. To determine how many vCPUs the instance have it uses num_possible_cpus while it should have use num_online_cpus instead. use () when

Re: bio linked list corruption.

On Mon, Dec 5, 2016 at 10:11 AM, Andy Lutomirski wrote: > > So your kernel has been smp-alternatived. That 3e comes from > alternatives_smp_unlock. If you're running on SMP with UP > alternatives, things will break. I'm assuming he's just running in a VM with a single CPU.

Re: bio linked list corruption.

On Mon, Dec 5, 2016 at 10:11 AM, Andy Lutomirski wrote: > > So your kernel has been smp-alternatived. That 3e comes from > alternatives_smp_unlock. If you're running on SMP with UP > alternatives, things will break. I'm assuming he's just running in a VM with a single CPU. The problem that I

FUSE: regression when clearing setuid bits on chown

Hi Miklos, I think we've found a "regression" that has crept in due to this patch: commit a09f99eddef44035ec764075a37bace8181bec38 Author: Miklos Szeredi Date:   Sat Oct 1 07:32:32 2016 +0200 fuse: fix killing s[ug]id in setattr      Basically, the pjdfstests set the

[RESEND PATCH] bus: fsl-mc: add DPCON object APIs

From: Ioana Radulescu This patch adds the command building/parsing wrapper functions for the DPCON object. The binary interface version is v3.2. Signed-off-by: Ioana Radulescu Signed-off-by: Ioana Ciornei

FUSE: regression when clearing setuid bits on chown

Hi Miklos, I think we've found a "regression" that has crept in due to this patch: commit a09f99eddef44035ec764075a37bace8181bec38 Author: Miklos Szeredi Date:   Sat Oct 1 07:32:32 2016 +0200 fuse: fix killing s[ug]id in setattr      Basically, the pjdfstests set the ownership of a file to

[RESEND PATCH] bus: fsl-mc: add DPCON object APIs

From: Ioana Radulescu This patch adds the command building/parsing wrapper functions for the DPCON object. The binary interface version is v3.2. Signed-off-by: Ioana Radulescu Signed-off-by: Ioana Ciornei Signed-off-by: Stuart Yoder --- This patch depends on the following patch series:

Re: [PATCH v2] add equivalent of BIT(x) for bitfields

On Mon, Dec 5, 2016 at 9:49 AM, Sebastian Frias wrote: > Introduce GENVALUE(msb, lsb, value) macro to ease dealing with > continuous bitfields, just as BIT(x) does for single bits. Oh, and looking at the implementation, this is wrong. You use "lsb" twice, so it mustn't have

Re: [PATCH v2] add equivalent of BIT(x) for bitfields

On Mon, Dec 5, 2016 at 9:49 AM, Sebastian Frias wrote: > Introduce GENVALUE(msb, lsb, value) macro to ease dealing with > continuous bitfields, just as BIT(x) does for single bits. Oh, and looking at the implementation, this is wrong. You use "lsb" twice, so it mustn't have side effects. That's

Re: [PATCH 2/7] net: ethernet: ti: cpdma: fix desc re-queuing

On 12/02/2016 05:28 PM, Ivan Khoronzhuk wrote: > On Fri, Dec 02, 2016 at 10:45:07AM -0600, Grygorii Strashko wrote: >> >> >> On 12/02/2016 05:03 AM, Ivan Khoronzhuk wrote: >>> On Thu, Dec 01, 2016 at 05:34:27PM -0600, Grygorii Strashko wrote: The currently processing cpdma descriptor with

Re: [PATCH 2/7] net: ethernet: ti: cpdma: fix desc re-queuing

On 12/02/2016 05:28 PM, Ivan Khoronzhuk wrote: > On Fri, Dec 02, 2016 at 10:45:07AM -0600, Grygorii Strashko wrote: >> >> >> On 12/02/2016 05:03 AM, Ivan Khoronzhuk wrote: >>> On Thu, Dec 01, 2016 at 05:34:27PM -0600, Grygorii Strashko wrote: The currently processing cpdma descriptor with

<    4   5   6   7   8   9   10   11   12   13   >