Re: [PATCH] stmmac: fix memory barriers

2016-12-19 Thread Niklas Cassel
On 12/19/2016 06:10 PM, Joao Pinto wrote: > Hi, > > I am trying to built net-next git tree and it is failing: > > CC drivers/pnp/card.o > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function > ‘stmmac_hw_fix_mac_speed’: > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:224:34:

Re: [PATCH] stmmac: fix memory barriers

2016-12-19 Thread Niklas Cassel
On 12/19/2016 06:10 PM, Joao Pinto wrote: > Hi, > > I am trying to built net-next git tree and it is failing: > > CC drivers/pnp/card.o > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function > ‘stmmac_hw_fix_mac_speed’: > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:224:34:

[PATCH 2/4] mm: drop zap_details::check_swap_entries

2016-12-19 Thread Kirill A. Shutemov
detail == NULL would give the same functionality as .check_swap_entries==true. Signed-off-by: Kirill A. Shutemov Acked-by: Michal Hocko --- include/linux/mm.h | 1 - mm/memory.c| 4 ++-- mm/oom_kill.c | 3 +-- 3 files changed, 3

[PATCH 2/4] mm: drop zap_details::check_swap_entries

2016-12-19 Thread Kirill A. Shutemov
detail == NULL would give the same functionality as .check_swap_entries==true. Signed-off-by: Kirill A. Shutemov Acked-by: Michal Hocko --- include/linux/mm.h | 1 - mm/memory.c| 4 ++-- mm/oom_kill.c | 3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH 1/4] mm: drop zap_details::ignore_dirty

2016-12-19 Thread Kirill A. Shutemov
The only user of ignore_dirty is oom-reaper. But it doesn't really use it. ignore_dirty only has effect on file pages mapped with dirty pte. But oom-repear skips shared VMAs, so there's no way we can dirty file pte in them. Signed-off-by: Kirill A. Shutemov

Re: [PATCH 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor

2016-12-19 Thread Laurent Pinchart
Hi Kedar, On Monday 19 Dec 2016 15:39:43 Appana Durga Kedareswara Rao wrote: > Hi Laurent Pinchart, > > Thanks for the review... > > > > + if (!chan->idle) > > > + return; > > > > Don't you need to perform the same check for the DMA and CDMA channels ? > > If so, shouldn't this

[PATCH 1/4] mm: drop zap_details::ignore_dirty

2016-12-19 Thread Kirill A. Shutemov
The only user of ignore_dirty is oom-reaper. But it doesn't really use it. ignore_dirty only has effect on file pages mapped with dirty pte. But oom-repear skips shared VMAs, so there's no way we can dirty file pte in them. Signed-off-by: Kirill A. Shutemov Acked-by: Michal Hocko ---

Re: [PATCH 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor

2016-12-19 Thread Laurent Pinchart
Hi Kedar, On Monday 19 Dec 2016 15:39:43 Appana Durga Kedareswara Rao wrote: > Hi Laurent Pinchart, > > Thanks for the review... > > > > + if (!chan->idle) > > > + return; > > > > Don't you need to perform the same check for the DMA and CDMA channels ? > > If so, shouldn't this

[PATCH 3/4] mm: drop unused argument of zap_page_range()

2016-12-19 Thread Kirill A. Shutemov
There's no users of zap_page_range() who wants non-NULL 'details'. Let's drop it. Signed-off-by: Kirill A. Shutemov Acked-by: Michal Hocko --- arch/s390/mm/gmap.c | 2 +- arch/x86/mm/mpx.c | 2 +-

[PATCH 4/4] oom-reaper: use madvise_dontneed() logic to decide if unmap the VMA

2016-12-19 Thread Kirill A. Shutemov
Logic on whether we can reap pages from the VMA should match what we have in madvise_dontneed(). In particular, we should skip, VM_PFNMAP VMAs, but we don't now. Let's just extract condition on which we can shoot down pagesi from a VMA with MADV_DONTNEED into separate function and use it in both

[PATCH 4/4] oom-reaper: use madvise_dontneed() logic to decide if unmap the VMA

2016-12-19 Thread Kirill A. Shutemov
Logic on whether we can reap pages from the VMA should match what we have in madvise_dontneed(). In particular, we should skip, VM_PFNMAP VMAs, but we don't now. Let's just extract condition on which we can shoot down pagesi from a VMA with MADV_DONTNEED into separate function and use it in both

[PATCH 3/4] mm: drop unused argument of zap_page_range()

2016-12-19 Thread Kirill A. Shutemov
There's no users of zap_page_range() who wants non-NULL 'details'. Let's drop it. Signed-off-by: Kirill A. Shutemov Acked-by: Michal Hocko --- arch/s390/mm/gmap.c | 2 +- arch/x86/mm/mpx.c | 2 +- drivers/android/binder.c | 2 +-

Re: [PATCH] serial: 8250: Avoid "too much work" from bogus rx timeout interrupt

2016-12-19 Thread Doug Anderson
Hi, On Mon, Dec 19, 2016 at 4:59 AM, Andy Shevchenko wrote: > On Sun, 2016-12-18 at 17:14 -0800, Douglas Anderson wrote: >> On a Rockchip rk3399-based board during suspend/resume testing, we >> found that we could get the console UART into a state where it

Re: [PATCH] serial: 8250: Avoid "too much work" from bogus rx timeout interrupt

2016-12-19 Thread Doug Anderson
Hi, On Mon, Dec 19, 2016 at 4:59 AM, Andy Shevchenko wrote: > On Sun, 2016-12-18 at 17:14 -0800, Douglas Anderson wrote: >> On a Rockchip rk3399-based board during suspend/resume testing, we >> found that we could get the console UART into a state where it would >> print this to the console a

[PATCH] ivtv: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/pci/ivtv/ivtv-alsa-pcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/ivtv/ivtv-alsa-pcm.c b/drivers/media/pci/ivtv/ivtv-alsa-pcm.c

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> On Mon, Dec 19, 2016 at 8:22 AM, James Simmons > >> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > >> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > >> @@ -143,7 +143,7 @@ static int ldlm_process_flock_lock(struct ldlm_lock > >> *req, __u64 *flags, > >> int added =

[PATCH] ivtv: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/pci/ivtv/ivtv-alsa-pcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/ivtv/ivtv-alsa-pcm.c b/drivers/media/pci/ivtv/ivtv-alsa-pcm.c index a26f980..d0d2c93 100644

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> On Mon, Dec 19, 2016 at 8:22 AM, James Simmons > >> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > >> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > >> @@ -143,7 +143,7 @@ static int ldlm_process_flock_lock(struct ldlm_lock > >> *req, __u64 *flags, > >> int added =

[PATCH] tm6000: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible memory leak and exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/usb/tm6000/tm6000-video.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/tm6000/tm6000-video.c

[PATCH] tm6000: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible memory leak and exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/usb/tm6000/tm6000-video.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/tm6000/tm6000-video.c

Re: [lustre-devel] [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> James, > > > This should be a purely syntactical change, to help out tools - for GCC, I'm > pretty sure the meaning of { > } and { NULL } are the same.  Also, I don't think struct randomization does > what you're thinking. Yep. I misread his commit message. That is why it didn't make sense

Re: [lustre-devel] [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> James, > > > This should be a purely syntactical change, to help out tools - for GCC, I'm > pretty sure the meaning of { > } and { NULL } are the same.  Also, I don't think struct randomization does > what you're thinking. Yep. I misread his commit message. That is why it didn't make sense

Re: [PATCH] stmmac: fix memory barriers

2016-12-19 Thread Joao Pinto
Hi, I am trying to built net-next git tree and it is failing: CC drivers/pnp/card.o drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function ‘stmmac_hw_fix_mac_speed’: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:224:34: error: ‘struct stmmac_priv’ has no member named ‘phydev’

Re: [PATCH] stmmac: fix memory barriers

2016-12-19 Thread Joao Pinto
Hi, I am trying to built net-next git tree and it is failing: CC drivers/pnp/card.o drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function ‘stmmac_hw_fix_mac_speed’: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:224:34: error: ‘struct stmmac_priv’ has no member named ‘phydev’

Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

2016-12-19 Thread Jason A. Donenfeld
On Sat, Dec 17, 2016 at 3:55 PM, Jeffrey Walton wrote: > It may be prudent to include the endian reversal in the test to ensure > big endian machines produce expected results. Some closely related > testing on an old Apple PowerMac G5 revealed that result needed to be >

Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

2016-12-19 Thread Jason A. Donenfeld
On Sat, Dec 17, 2016 at 3:55 PM, Jeffrey Walton wrote: > It may be prudent to include the endian reversal in the test to ensure > big endian machines produce expected results. Some closely related > testing on an old Apple PowerMac G5 revealed that result needed to be > reversed before returning

[RFC] arch/x86/Kconfig.cpu: Update with new gcc disponible 64bits CPU uarchs.

2016-12-19 Thread Gustavo da Silva
Good afternon! Are there reasons to 'Kconfig.cpu' and 'Makefile' not contains the 'gcc -mtune=???' recent options? Well, bellow I send some diffs (untested) just for clarifications. Best regards, Gustavo da Silva. --- old/arch/x86/Kconfig.cpu +++ new/arch/x86/Kconfig.cpu

[RFC] arch/x86/Kconfig.cpu: Update with new gcc disponible 64bits CPU uarchs.

2016-12-19 Thread Gustavo da Silva
Good afternon! Are there reasons to 'Kconfig.cpu' and 'Makefile' not contains the 'gcc -mtune=???' recent options? Well, bellow I send some diffs (untested) just for clarifications. Best regards, Gustavo da Silva. --- old/arch/x86/Kconfig.cpu +++ new/arch/x86/Kconfig.cpu

[PATCH] staging: lustre: headers: potential UAPI headers

2016-12-19 Thread James Simmons
Not for landing. This is the purposed UAPI headers with the removal of unlikely and debugging macros. This is just for feedback to see if this is acceptable for the upstream client. Signed-off-by: James Simmons --- .../lustre/lustre/include/lustre/lustre_fid.h | 353

[PATCH] staging: lustre: headers: potential UAPI headers

2016-12-19 Thread James Simmons
Not for landing. This is the purposed UAPI headers with the removal of unlikely and debugging macros. This is just for feedback to see if this is acceptable for the upstream client. Signed-off-by: James Simmons --- .../lustre/lustre/include/lustre/lustre_fid.h | 353 +

Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-19 Thread Logan Gunthorpe
On 19/12/16 10:02 AM, Keith Busch wrote: > Some of this would be simplified if you use the managed device API's: > devm_request_irq, pcim_enable_device, pcim_iomap, etc... Thanks Keith, I'll look into using those. Logan

Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-19 Thread Logan Gunthorpe
On 19/12/16 10:02 AM, Keith Busch wrote: > Some of this would be simplified if you use the managed device API's: > devm_request_irq, pcim_enable_device, pcim_iomap, etc... Thanks Keith, I'll look into using those. Logan

Re: [RFC 0/1] New PCI Switch Management Driver

2016-12-19 Thread Logan Gunthorpe
Hey, On 19/12/16 09:09 AM, Myron Stowe wrote: > I guess the obvious questions is: why is a driver for a PCI switch > necessary? The core works with all compliant switches today and there > are no specifics for a particular design or such. > So I guess I'd like to hear the reasoning and

Re: [RFC 0/1] New PCI Switch Management Driver

2016-12-19 Thread Logan Gunthorpe
Hey, On 19/12/16 09:09 AM, Myron Stowe wrote: > I guess the obvious questions is: why is a driver for a PCI switch > necessary? The core works with all compliant switches today and there > are no specifics for a particular design or such. > So I guess I'd like to hear the reasoning and

Re: [PATCH] NTB: Fix 'request_irq()' and 'free_irq()' inconsistancy

2016-12-19 Thread Dave Jiang
On 12/18/2016 10:52 PM, Christophe JAILLET wrote: > 'request_irq()' and 'free_irq()' should have the same 'dev_id'. > > Signed-off-by: Christophe JAILLET Acking the Intel driver portion. Acked-by: Dave Jiang > --- >

Re: [PATCH] NTB: Fix 'request_irq()' and 'free_irq()' inconsistancy

2016-12-19 Thread Dave Jiang
On 12/18/2016 10:52 PM, Christophe JAILLET wrote: > 'request_irq()' and 'free_irq()' should have the same 'dev_id'. > > Signed-off-by: Christophe JAILLET Acking the Intel driver portion. Acked-by: Dave Jiang > --- > drivers/ntb/hw/amd/ntb_hw_amd.c | 2 +- >

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-19 Thread James Simmons
> On Tue, Dec 13, 2016 at 12:55:01AM +, Dilger, Andreas wrote: > > On Dec 12, 2016, at 13:00, James Simmons wrote: > > > > > > > > >> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > > >>> In order for lustre_idl.h to be usable for both user > > >>>

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-19 Thread James Simmons
> On Tue, Dec 13, 2016 at 12:55:01AM +, Dilger, Andreas wrote: > > On Dec 12, 2016, at 13:00, James Simmons wrote: > > > > > > > > >> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > > >>> In order for lustre_idl.h to be usable for both user > > >>> land and kernel space it

[PATCH] tm6000: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible memory leak and exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/usb/tm6000/tm6000-video.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/tm6000/tm6000-video.c

[PATCH] tm6000: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible memory leak and exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/usb/tm6000/tm6000-video.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/tm6000/tm6000-video.c

Re: [PATCH v4 4/8] mtd: spi-nor: add support of SPI protocols like SPI 1-2-2 and SPI 1-4-4

2016-12-19 Thread Cyrille Pitchen
Le 16/12/2016 à 14:47, Krzeminski, Marcin (Nokia - PL/Wroclaw) a écrit : >> -Original Message- >> From: Krzeminski, Marcin (Nokia - PL/Wroclaw) >> Sent: Tuesday, December 13, 2016 10:46 AM >> To: Cyrille Pitchen ; >> computersforpe...@gmail.com;

Re: [PATCH v4 4/8] mtd: spi-nor: add support of SPI protocols like SPI 1-2-2 and SPI 1-4-4

2016-12-19 Thread Cyrille Pitchen
Le 16/12/2016 à 14:47, Krzeminski, Marcin (Nokia - PL/Wroclaw) a écrit : >> -Original Message- >> From: Krzeminski, Marcin (Nokia - PL/Wroclaw) >> Sent: Tuesday, December 13, 2016 10:46 AM >> To: Cyrille Pitchen ; >> computersforpe...@gmail.com; marek.va...@gmail.com; >>

Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-19 Thread Keith Busch
On Sat, Dec 17, 2016 at 10:09:22AM -0700, Logan Gunthorpe wrote: > Microsemi's "Switchtec" line of PCI switch devices is already > supported by the kernel with standard PCI switch drivers. However, the > Switchtec device advertises a special management endpoint which > enables some additional

Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-19 Thread Keith Busch
On Sat, Dec 17, 2016 at 10:09:22AM -0700, Logan Gunthorpe wrote: > Microsemi's "Switchtec" line of PCI switch devices is already > supported by the kernel with standard PCI switch drivers. However, the > Switchtec device advertises a special management endpoint which > enables some additional

Re: *** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated

2016-12-19 Thread Markus Trippelsdorf
On 2016.12.19 at 17:18 +0100, Markus Trippelsdorf wrote: > Running the latest kernel git tree, I get buffer overflow warnings when > I try to run "perf top": > > *** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated > > > __GI_raise (sig=sig@entry=6) at

Re: *** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated

2016-12-19 Thread Markus Trippelsdorf
On 2016.12.19 at 17:18 +0100, Markus Trippelsdorf wrote: > Running the latest kernel git tree, I get buffer overflow warnings when > I try to run "perf top": > > *** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated > > > __GI_raise (sig=sig@entry=6) at

Re: [PATCH v3 0/5] introduce DAX tracepoint support

2016-12-19 Thread Ross Zwisler
On Thu, Dec 01, 2016 at 09:37:46AM -0700, Ross Zwisler wrote: > Tracepoints are the standard way to capture debugging and tracing > information in many parts of the kernel, including the XFS and ext4 > filesystems. This series creates a tracepoint header for FS DAX and add > the first few DAX

Re: [PATCH v3 0/5] introduce DAX tracepoint support

2016-12-19 Thread Ross Zwisler
On Thu, Dec 01, 2016 at 09:37:46AM -0700, Ross Zwisler wrote: > Tracepoints are the standard way to capture debugging and tracing > information in many parts of the kernel, including the XFS and ext4 > filesystems. This series creates a tracepoint header for FS DAX and add > the first few DAX

Re: [PATCH] drm: tilcdc: simplify the recovery from sync lost error on rev1

2016-12-19 Thread Jyri Sarha
On 12/19/16 16:19, Bartosz Golaszewski wrote: >> I would add here: >> + if ((tilcdc_read(dev, LCDC_RASTER_CTRL_REG) & >> + LCDC_RASTER_ENABLE)) { >> >>> + tilcdc_clear(dev, >>> + LCDC_RASTER_CTRL_REG,

Re: [PATCH] drm: tilcdc: simplify the recovery from sync lost error on rev1

2016-12-19 Thread Jyri Sarha
On 12/19/16 16:19, Bartosz Golaszewski wrote: >> I would add here: >> + if ((tilcdc_read(dev, LCDC_RASTER_CTRL_REG) & >> + LCDC_RASTER_ENABLE)) { >> >>> + tilcdc_clear(dev, >>> + LCDC_RASTER_CTRL_REG,

[PATCH] zoran: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible memory leak and exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/pci/zoran/zoran_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/zoran/zoran_driver.c

[PATCH] zoran: Clean up file handle in open() error path.

2016-12-19 Thread Santosh Kumar Singh
Fix to avoid possible memory leak and exit file handle in error paths. Signed-off-by: Santosh Kumar Singh --- drivers/media/pci/zoran/zoran_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/zoran/zoran_driver.c b/drivers/media/pci/zoran/zoran_driver.c index

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread Bruce Korb
On Mon, Dec 19, 2016 at 8:22 AM, James Simmons >> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c >> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c >> @@ -143,7 +143,7 @@ static int ldlm_process_flock_lock(struct ldlm_lock >> *req, __u64 *flags, >> int added = (mode == LCK_NL);

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread Bruce Korb
On Mon, Dec 19, 2016 at 8:22 AM, James Simmons >> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c >> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c >> @@ -143,7 +143,7 @@ static int ldlm_process_flock_lock(struct ldlm_lock >> *req, __u64 *flags, >> int added = (mode == LCK_NL);

Re: [PATCH] btrfs: use rb_entry()

2016-12-19 Thread Josef Bacik
On Mon, Dec 19, 2016 at 9:53 AM, Geliang Tang wrote: To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang Reviewed-by: Josef Bacik Thanks, Josef

Re: [PATCH] btrfs: use rb_entry()

2016-12-19 Thread Josef Bacik
On Mon, Dec 19, 2016 at 9:53 AM, Geliang Tang wrote: To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang Reviewed-by: Josef Bacik Thanks, Josef

Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver

2016-12-19 Thread Mark Brown
On Mon, Dec 19, 2016 at 10:30:09AM -0600, Pierre-Louis Bossart wrote: > All this code seems to be largely a copy-paste of the bytcr_rt5640 machine > driver and the same comments would apply there. This patch did miss the last Yes, there's a lot of room for cleanups in the existing code too (and

Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver

2016-12-19 Thread Mark Brown
On Mon, Dec 19, 2016 at 10:30:09AM -0600, Pierre-Louis Bossart wrote: > All this code seems to be largely a copy-paste of the bytcr_rt5640 machine > driver and the same comments would apply there. This patch did miss the last Yes, there's a lot of room for cleanups in the existing code too (and

Re: [PATCH] x86/microcode: Adjust ramdisk address when accessing by virtual address

2016-12-19 Thread Borislav Petkov
On Mon, Dec 19, 2016 at 11:10:29AM -0500, Boris Ostrovsky wrote: > config attached. I'll see how I can get you the initrd. Wait a bit, lemme see if I can repro with my initrd here. Thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

RE: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[]

2016-12-19 Thread Madalin-Cristian Bucur
> From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, December 19, 2016 5:37 PM > > From: Madalin Bucur > Date: Mon, 19 Dec 2016 11:22:20 +0200 > > > The fsl/fman drivers will use of_platform_populate() on all > > supported platforms. > > > > Signed-off-by:

Re: [PATCH] x86/microcode: Adjust ramdisk address when accessing by virtual address

2016-12-19 Thread Borislav Petkov
On Mon, Dec 19, 2016 at 11:10:29AM -0500, Boris Ostrovsky wrote: > config attached. I'll see how I can get you the initrd. Wait a bit, lemme see if I can repro with my initrd here. Thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

RE: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[]

2016-12-19 Thread Madalin-Cristian Bucur
> From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, December 19, 2016 5:37 PM > > From: Madalin Bucur > Date: Mon, 19 Dec 2016 11:22:20 +0200 > > > The fsl/fman drivers will use of_platform_populate() on all > > supported platforms. > > > > Signed-off-by: Madalin Bucur > > It

Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly

2016-12-19 Thread Miroslav Benes
On Thu, 8 Dec 2016, Josh Poimboeuf wrote: > The _TIF_ALLWORK_MASK macro automatically includes the least-significant > 16 bits of the thread_info flags, which is less than obvious and tends > to create confusion and surprises when reading or modifying the code. Yes. > Define the flags

Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly

2016-12-19 Thread Miroslav Benes
On Thu, 8 Dec 2016, Josh Poimboeuf wrote: > The _TIF_ALLWORK_MASK macro automatically includes the least-significant > 16 bits of the thread_info flags, which is less than obvious and tends > to create confusion and surprises when reading or modifying the code. Yes. > Define the flags

Re: [PATCH v4 4/8] mtd: spi-nor: add support of SPI protocols like SPI 1-2-2 and SPI 1-4-4

2016-12-19 Thread Cyrille Pitchen
Hi Marcin, Le 13/12/2016 à 10:46, Krzeminski, Marcin (Nokia - PL/Wroclaw) a écrit : > Cyrille, > >> -Original Message- >> From: linux-mtd [mailto:linux-mtd-boun...@lists.infradead.org] On Behalf >> Of Cyrille Pitchen >> Sent: Monday, November 21, 2016 3:16 PM >> To:

Re: [PATCH v4 4/8] mtd: spi-nor: add support of SPI protocols like SPI 1-2-2 and SPI 1-4-4

2016-12-19 Thread Cyrille Pitchen
Hi Marcin, Le 13/12/2016 à 10:46, Krzeminski, Marcin (Nokia - PL/Wroclaw) a écrit : > Cyrille, > >> -Original Message- >> From: linux-mtd [mailto:linux-mtd-boun...@lists.infradead.org] On Behalf >> Of Cyrille Pitchen >> Sent: Monday, November 21, 2016 3:16 PM >> To:

Re: [PATCH v2] staging: lustre: Fix variable type declaration after refactoring

2016-12-19 Thread James Simmons
> A recent clean-up declared och_flags as a int rather than fmode_t. This > lead to the following sparse warning: > > drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted > fmode_t degrades to integer > > This patch fixes this issue. Acked-by: James Simmons

Re: [PATCH v2] staging: lustre: Fix variable type declaration after refactoring

2016-12-19 Thread James Simmons
> A recent clean-up declared och_flags as a int rather than fmode_t. This > lead to the following sparse warning: > > drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted > fmode_t degrades to integer > > This patch fixes this issue. Acked-by: James Simmons > Fixes:

[PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-by: Stefan

[PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-by: Stefan

RE: thermal zones break with patch "Reimplement IDR and IDA using the radix tree" (mainline+next)

2016-12-19 Thread Matthew Wilcox
From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > On Fri, Dec 16, 2016 at 11:19 PM, Matthew Wilcox > wrote: > > Now ... thermal is actually using an IDR when it could save memory by using > an IDA. Are you interested in doing that conversion? > > +Cc: Mika,

RE: thermal zones break with patch "Reimplement IDR and IDA using the radix tree" (mainline+next)

2016-12-19 Thread Matthew Wilcox
From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > On Fri, Dec 16, 2016 at 11:19 PM, Matthew Wilcox > wrote: > > Now ... thermal is actually using an IDR when it could save memory by using > an IDA. Are you interested in doing that conversion? > > +Cc: Mika, Vinod > > Same here for at

Re: [PATCH v2 03/10] dt-bindings: perf: hisi: Add Devicetree bindings for Hisilicon SoC PMU

2016-12-19 Thread Rob Herring
On Wed, Dec 07, 2016 at 11:55:59AM -0500, Anurup M wrote: > 1) Device tree bindings for Hisilicon SoC PMU. > 2) Add example for Hisilicon L3 cache and MN PMU. > 3) Add child nodes of L3C and MN in djtag bindings example. > > Signed-off-by: Anurup M > Signed-off-by: Shaokun

Re: [PATCH v2 03/10] dt-bindings: perf: hisi: Add Devicetree bindings for Hisilicon SoC PMU

2016-12-19 Thread Rob Herring
On Wed, Dec 07, 2016 at 11:55:59AM -0500, Anurup M wrote: > 1) Device tree bindings for Hisilicon SoC PMU. > 2) Add example for Hisilicon L3 cache and MN PMU. > 3) Add child nodes of L3C and MN in djtag bindings example. > > Signed-off-by: Anurup M > Signed-off-by: Shaokun Zhang > --- >

Re: [PATCH v2 02/10] dt-bindings: hisi: Add Hisilicon HiP05/06/07 Djtag dts bindings

2016-12-19 Thread Rob Herring
On Wed, Dec 07, 2016 at 11:55:19AM -0500, Anurup M wrote: > From: Tan Xiaojun > > Add Hisilicon HiP05/06/07 Djtag dts bindings for CPU and IO Die > > Signed-off-by: Tan Xiaojun > Signed-off-by: Anurup M > --- >

Re: [PATCH v2 02/10] dt-bindings: hisi: Add Hisilicon HiP05/06/07 Djtag dts bindings

2016-12-19 Thread Rob Herring
On Wed, Dec 07, 2016 at 11:55:19AM -0500, Anurup M wrote: > From: Tan Xiaojun > > Add Hisilicon HiP05/06/07 Djtag dts bindings for CPU and IO Die > > Signed-off-by: Tan Xiaojun > Signed-off-by: Anurup M > --- > .../devicetree/bindings/arm/hisilicon/djtag.txt| 41 > ++

Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver

2016-12-19 Thread Pierre-Louis Bossart
On 12/19/16 9:55 AM, Mark Brown wrote: On Mon, Dec 19, 2016 at 09:51:47PM +0800, Shrirang Bagul wrote: + +#define DEBUG This should be production code... +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include The ordering

Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver

2016-12-19 Thread Pierre-Louis Bossart
On 12/19/16 9:55 AM, Mark Brown wrote: On Mon, Dec 19, 2016 at 09:51:47PM +0800, Shrirang Bagul wrote: + +#define DEBUG This should be production code... +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include The ordering

Re: [PATCH v3 2/2] iio: adc: hx711: Add IIO driver for AVIA HX711

2016-12-19 Thread Lars-Peter Clausen
On 12/14/2016 05:17 PM, Andreas Klinger wrote: [...] > +#include > +#include Since you used the consumer API linux/gpio.h is not needed. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define

Re: [PATCH v3 2/2] iio: adc: hx711: Add IIO driver for AVIA HX711

2016-12-19 Thread Lars-Peter Clausen
On 12/14/2016 05:17 PM, Andreas Klinger wrote: [...] > +#include > +#include Since you used the consumer API linux/gpio.h is not needed. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define

Re: [PATCH v3 01/15] stacktrace/x86: add function for detecting reliable stack traces

2016-12-19 Thread Miroslav Benes
On Thu, 8 Dec 2016, Josh Poimboeuf wrote: > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 215612c..b4a6663 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -155,6 +155,7 @@ config X86 > select HAVE_PERF_REGS > select HAVE_PERF_USER_STACK_DUMP > select

Re: [PATCH v3 01/15] stacktrace/x86: add function for detecting reliable stack traces

2016-12-19 Thread Miroslav Benes
On Thu, 8 Dec 2016, Josh Poimboeuf wrote: > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 215612c..b4a6663 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -155,6 +155,7 @@ config X86 > select HAVE_PERF_REGS > select HAVE_PERF_USER_STACK_DUMP > select

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook

Re: [PATCH] staging: lustre: ldlm: use designated initializers

2016-12-19 Thread James Simmons
> Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook > --- >

Re: [PATCH] tpm, tpm_crb: Handle 64-bit resource in crb_check_resource()

2016-12-19 Thread Jason Gunthorpe
On Mon, Dec 19, 2016 at 03:56:24PM +0200, Jarkko Sakkinen wrote: > On Sun, Dec 18, 2016 at 10:20:53PM -0600, Jiandi An wrote: > > crb_check_resource() in TPM CRB driver calls > > acpi_dev_resource_memory() which only handles 32-bit resources. > > Adding a call to acpi_dev_resource_address_space()

Re: [PATCH] tpm, tpm_crb: Handle 64-bit resource in crb_check_resource()

2016-12-19 Thread Jason Gunthorpe
On Mon, Dec 19, 2016 at 03:56:24PM +0200, Jarkko Sakkinen wrote: > On Sun, Dec 18, 2016 at 10:20:53PM -0600, Jiandi An wrote: > > crb_check_resource() in TPM CRB driver calls > > acpi_dev_resource_memory() which only handles 32-bit resources. > > Adding a call to acpi_dev_resource_address_space()

[PATCH 1/6] KVM: vmx: clear pending interrupts on KVM_SET_LAPIC

2016-12-19 Thread Paolo Bonzini
Pending interrupts might be in the PI descriptor when the LAPIC is restored from an external state; we do not want them to be injected. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/lapic.c | 3 +-- arch/x86/kvm/vmx.c | 9 + 2 files changed, 10 insertions(+), 2

[PATCH 1/6] KVM: vmx: clear pending interrupts on KVM_SET_LAPIC

2016-12-19 Thread Paolo Bonzini
Pending interrupts might be in the PI descriptor when the LAPIC is restored from an external state; we do not want them to be injected. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/lapic.c | 3 +-- arch/x86/kvm/vmx.c | 9 + 2 files changed, 10 insertions(+), 2 deletions(-) diff

[PATCH 2/6] kvm: nVMX: move nested events check to kvm_vcpu_running

2016-12-19 Thread Paolo Bonzini
vcpu_run calls kvm_vcpu_running, not kvm_arch_vcpu_runnable, and the former does not call check_nested_events. Once KVM_REQ_EVENT is removed from the APICv interrupt injection path, however, this would leave no place to trigger a vmexit from L2 to L1, causing a missed interrupt delivery while in

[PATCH v2 0/6] KVM: x86: cleanup and speedup for APICv

2016-12-19 Thread Paolo Bonzini
These are the fixed patches that now pass vmx.flat. The issue in "KVM: x86: do not scan IRR twice on APICv vmentry" was that, in v1 of the patches, kvm_cpu_get_interrupt did not scan IRR at all if it found PIR.ON=0. This is now fixed in patches 4 and 5. Another latent bug has to be fixed in

[PATCH 2/6] kvm: nVMX: move nested events check to kvm_vcpu_running

2016-12-19 Thread Paolo Bonzini
vcpu_run calls kvm_vcpu_running, not kvm_arch_vcpu_runnable, and the former does not call check_nested_events. Once KVM_REQ_EVENT is removed from the APICv interrupt injection path, however, this would leave no place to trigger a vmexit from L2 to L1, causing a missed interrupt delivery while in

[PATCH v2 0/6] KVM: x86: cleanup and speedup for APICv

2016-12-19 Thread Paolo Bonzini
These are the fixed patches that now pass vmx.flat. The issue in "KVM: x86: do not scan IRR twice on APICv vmentry" was that, in v1 of the patches, kvm_cpu_get_interrupt did not scan IRR at all if it found PIR.ON=0. This is now fixed in patches 4 and 5. Another latent bug has to be fixed in

Re: [v2] block: check partition alignment

2016-12-19 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

*** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated

2016-12-19 Thread Markus Trippelsdorf
Running the latest kernel git tree, I get buffer overflow warnings when I try to run "perf top": *** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 51 } (gdb) bt #0 __GI_raise

[PATCH 4/6] KVM: vmx: move sync_pir_to_irr from apic_find_highest_irr to callers

2016-12-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- arch/x86/kvm/lapic.c | 7 --- arch/x86/kvm/x86.c | 4 +++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 4c76c602576e..4af0e105caad 100644 --- a/arch/x86/kvm/lapic.c +++

Re: [v2] block: check partition alignment

2016-12-19 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

*** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated

2016-12-19 Thread Markus Trippelsdorf
Running the latest kernel git tree, I get buffer overflow warnings when I try to run "perf top": *** buffer overflow detected ***: /usr/src/linux/tools/perf/perf terminated __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 51 } (gdb) bt #0 __GI_raise

[PATCH 4/6] KVM: vmx: move sync_pir_to_irr from apic_find_highest_irr to callers

2016-12-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- arch/x86/kvm/lapic.c | 7 --- arch/x86/kvm/x86.c | 4 +++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 4c76c602576e..4af0e105caad 100644 --- a/arch/x86/kvm/lapic.c +++

[PATCH 6/6] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection

2016-12-19 Thread Paolo Bonzini
Since bf9f6ac8d749 ("KVM: Update Posted-Interrupts Descriptor when vCPU is blocked", 2015-09-18) the posted interrupt descriptor is checked unconditionally for PIR.ON. Therefore we don't need KVM_REQ_EVENT to trigger the scan and, if NMIs or SMIs are not involved, we can avoid the complicated

[PATCH 3/6] KVM: x86: preparatory changes for APICv cleanups

2016-12-19 Thread Paolo Bonzini
Add return value to __kvm_apic_update_irr/kvm_apic_update_irr. Move vmx_sync_pir_to_irr around. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/lapic.c | 25 + arch/x86/kvm/lapic.h | 4 ++-- arch/x86/kvm/vmx.c | 32

<    2   3   4   5   6   7   8   9   10   11   >