Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched with addr

On 03/01/2017 10:17 PM, Namhyung Kim wrote: Hi Taeung, On Wed, Mar 01, 2017 at 04:59:51AM +0900, Taeung Song wrote: Currently perf-annotate show wrong line numbers. For example, Actual source code is as below ... 21 }; 22 23 unsigned int limited_wgt; 24 25 unsigned int

Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched with addr

On 03/01/2017 10:17 PM, Namhyung Kim wrote: Hi Taeung, On Wed, Mar 01, 2017 at 04:59:51AM +0900, Taeung Song wrote: Currently perf-annotate show wrong line numbers. For example, Actual source code is as below ... 21 }; 22 23 unsigned int limited_wgt; 24 25 unsigned int

Re: [RFC PATCH] printk: Make functions of pr_ macros

On Thu, 2017-03-02 at 14:35 +0900, Sergey Senozhatsky wrote: > Hello Joe, > > On (02/28/17 19:17), Joe Perches wrote: > > Can save the space that the KERN_ headers require. > > > > The biggest negative here is the %pV use which needs > > recursion and adds stack depth. > > > > $ size vmlinux.o*

Re: [RFC PATCH] printk: Make functions of pr_ macros

On Thu, 2017-03-02 at 14:35 +0900, Sergey Senozhatsky wrote: > Hello Joe, > > On (02/28/17 19:17), Joe Perches wrote: > > Can save the space that the KERN_ headers require. > > > > The biggest negative here is the %pV use which needs > > recursion and adds stack depth. > > > > $ size vmlinux.o*

[PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

Currently we are trying to enable/disable the clk of irq's gpio bank when unmask/mask irq. But the kernel's "lazy disable approach" will skip masking irq when the irq chip doesn't support irq_disable ops. So we may hit this case: irq_enable-> enable clk irq_disable-> noop

[PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

Currently we are trying to enable/disable the clk of irq's gpio bank when unmask/mask irq. But the kernel's "lazy disable approach" will skip masking irq when the irq chip doesn't support irq_disable ops. So we may hit this case: irq_enable-> enable clk irq_disable-> noop

Re: net: use-after-free in neigh_timer_handler/sock_wfree

On Wed, Mar 1, 2017 at 9:25 PM, Cong Wang wrote: > On Wed, Mar 1, 2017 at 3:15 PM, Eric Dumazet wrote: >> On Wed, Mar 1, 2017 at 3:09 PM, Cong Wang wrote: >> >>> >>> But I doubt skb_orphan() is the solution here, shouldn't

Re: net: use-after-free in neigh_timer_handler/sock_wfree

On Wed, Mar 1, 2017 at 9:25 PM, Cong Wang wrote: > On Wed, Mar 1, 2017 at 3:15 PM, Eric Dumazet wrote: >> On Wed, Mar 1, 2017 at 3:09 PM, Cong Wang wrote: >> >>> >>> But I doubt skb_orphan() is the solution here, shouldn't we just >>> update sk->sk_wmem_alloc with skb->truesize changes? >> >>

Re: [f2fs-dev] [PATCH RFC] f2fs: combine nat_bits and free_nid_bitmap cache

On 3/2/2017 09:35, Chao Yu wrote: > On 2017/3/1 21:09, Kinglong Mee wrote: >> On 3/1/2017 17:10, Chao Yu wrote: >>> Both nat_bits cache and free_nid_bitmap cache provide same functionality >>> as a intermediate cache between free nid cache and disk, but with >>> different granularity of indicating

Re: [f2fs-dev] [PATCH RFC] f2fs: combine nat_bits and free_nid_bitmap cache

On 3/2/2017 09:35, Chao Yu wrote: > On 2017/3/1 21:09, Kinglong Mee wrote: >> On 3/1/2017 17:10, Chao Yu wrote: >>> Both nat_bits cache and free_nid_bitmap cache provide same functionality >>> as a intermediate cache between free nid cache and disk, but with >>> different granularity of indicating

Re: [RFC PATCH] printk: Make functions of pr_ macros

Hello Joe, On (02/28/17 19:17), Joe Perches wrote: > Can save the space that the KERN_ headers require. > > The biggest negative here is the %pV use which needs > recursion and adds stack depth. > > $ size vmlinux.o* (defconfig, x86-64) >text data bss dec hex filename >

Re: [RFC PATCH] printk: Make functions of pr_ macros

Hello Joe, On (02/28/17 19:17), Joe Perches wrote: > Can save the space that the KERN_ headers require. > > The biggest negative here is the %pV use which needs > recursion and adds stack depth. > > $ size vmlinux.o* (defconfig, x86-64) >text data bss dec hex filename >

Re: [PATCH v2] scsi: ufs: Factor out ufshcd_read_desc_param

> "Michal'" == Potomski, MichalX writes: Michal'> Since in UFS 2.1 specification some of the descriptor lengths Michal'> differs from 2.0 specification and some devices, which are Michal'> reporting spec version 2.0 have different descriptor lengths we Michal'>

Re: [PATCH v2] scsi: ufs: Factor out ufshcd_read_desc_param

> "Michal'" == Potomski, MichalX writes: Michal'> Since in UFS 2.1 specification some of the descriptor lengths Michal'> differs from 2.0 specification and some devices, which are Michal'> reporting spec version 2.0 have different descriptor lengths we Michal'> can not rely on hardcoded

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

On Wed, Mar 01, 2017 at 04:37:31PM -0800, Christoph Hellwig wrote: > On Wed, Mar 01, 2017 at 12:46:34PM +0800, Xiong Zhou wrote: > > Hi, > > > > It's reproduciable, not everytime though. Ext4 works fine. > > On ext4 fsstress won't run bulkstat because it doesn't exist. Either > way this smells

Re: mm allocation failure and hang when running xfstests generic/269 on xfs

On Wed, Mar 01, 2017 at 04:37:31PM -0800, Christoph Hellwig wrote: > On Wed, Mar 01, 2017 at 12:46:34PM +0800, Xiong Zhou wrote: > > Hi, > > > > It's reproduciable, not everytime though. Ext4 works fine. > > On ext4 fsstress won't run bulkstat because it doesn't exist. Either > way this smells

[PATCH V3 5/9] Staging: rtl8712: rtl871x_mp_ioctl.h - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- Version #1 Introduced lines longer then 80 Version #2 Lacked spaces at either end of comment line drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 191 - 1 file

Re: net: use-after-free in neigh_timer_handler/sock_wfree

On Wed, Mar 1, 2017 at 3:15 PM, Eric Dumazet wrote: > On Wed, Mar 1, 2017 at 3:09 PM, Cong Wang wrote: > >> >> But I doubt skb_orphan() is the solution here, shouldn't we just >> update sk->sk_wmem_alloc with skb->truesize changes? > > Is it worth

[PATCH V3 5/9] Staging: rtl8712: rtl871x_mp_ioctl.h - style fix

Fixed style of block comments Found using checkpatch Signed-off-by: Derek Robson --- Version #1 Introduced lines longer then 80 Version #2 Lacked spaces at either end of comment line drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 191 - 1 file changed, 107

Re: net: use-after-free in neigh_timer_handler/sock_wfree

On Wed, Mar 1, 2017 at 3:15 PM, Eric Dumazet wrote: > On Wed, Mar 1, 2017 at 3:09 PM, Cong Wang wrote: > >> >> But I doubt skb_orphan() is the solution here, shouldn't we just >> update sk->sk_wmem_alloc with skb->truesize changes? > > Is it worth it ? Apart from syszkaller I mean... > > We

Re: [PATCH v4 10/11] drivers: perf: hisi: Handle counter overflow IRQ in MN PMU

On Friday 24 February 2017 08:34 AM, Anurup M wrote: +static int hisi_mn_init_irqs_fdt(struct device *dev, +struct hisi_pmu *mn_pmu) +{ +struct hisi_mn_data *mn_data = mn_pmu->hwmod_data; +struct hisi_djtag_client *client = mn_data->client; +int irq = -1, num_irqs,

Re: [PATCH v4 10/11] drivers: perf: hisi: Handle counter overflow IRQ in MN PMU

On Friday 24 February 2017 08:34 AM, Anurup M wrote: +static int hisi_mn_init_irqs_fdt(struct device *dev, +struct hisi_pmu *mn_pmu) +{ +struct hisi_mn_data *mn_data = mn_pmu->hwmod_data; +struct hisi_djtag_client *client = mn_data->client; +int irq = -1, num_irqs,

Re: Regression in 4.11 - PowerPC crashes on boot, bisected to commit 5657933dbb6e

On Thu, 2017-03-02 at 16:14 +1100, Benjamin Herrenschmidt wrote: > On Wed, 2017-03-01 at 21:26 -0600, Larry Finger wrote: > > My Powerbook G4 Aluminum generates a fatal splat early in the boot process, > > just  > > after identifying the driver for the disk. Unfortunately, it turns off > >

Re: Regression in 4.11 - PowerPC crashes on boot, bisected to commit 5657933dbb6e

On Thu, 2017-03-02 at 16:14 +1100, Benjamin Herrenschmidt wrote: > On Wed, 2017-03-01 at 21:26 -0600, Larry Finger wrote: > > My Powerbook G4 Aluminum generates a fatal splat early in the boot process, > > just  > > after identifying the driver for the disk. Unfortunately, it turns off > >

Re: [RESEND PATCH v7 0/7] Rockchip dw-mipi-dsi driver

On Mon, Feb 20, 2017 at 04:02:16PM +0800, Chris Zhong wrote: > Hi all > > [Resend this v7 version series, since there are 5 mails have gone missing, > last > week] > > This version does not change the existing v6 patches, just to add the > "bandwidth fix" patch back, since we really need it. >

Re: [RESEND PATCH v7 0/7] Rockchip dw-mipi-dsi driver

On Mon, Feb 20, 2017 at 04:02:16PM +0800, Chris Zhong wrote: > Hi all > > [Resend this v7 version series, since there are 5 mails have gone missing, > last > week] > > This version does not change the existing v6 patches, just to add the > "bandwidth fix" patch back, since we really need it. >

Re: [PATCH v4] net: don't call strlen() on the user buffer in packet_bind_spkt()

On Wed, Mar 1, 2017 at 3:57 AM, Alexander Potapenko wrote: > This happens because addr.sa_data copied from the userspace is not > zero-terminated, and copying it with strlcpy() in packet_bind_spkt() > results in calling strlen() on the kernel copy of that non-terminated >

Re: [PATCH v4] net: don't call strlen() on the user buffer in packet_bind_spkt()

On Wed, Mar 1, 2017 at 3:57 AM, Alexander Potapenko wrote: > This happens because addr.sa_data copied from the userspace is not > zero-terminated, and copying it with strlcpy() in packet_bind_spkt() > results in calling strlen() on the kernel copy of that non-terminated > buffer. Very similar to

Re: Regression in 4.11 - PowerPC crashes on boot, bisected to commit 5657933dbb6e

On Wed, 2017-03-01 at 21:26 -0600, Larry Finger wrote: > My Powerbook G4 Aluminum generates a fatal splat early in the boot process, > just  > after identifying the driver for the disk. Unfortunately, it turns off almost  > immediately, thus I cannot report the message. After this bug has been  >

Re: Regression in 4.11 - PowerPC crashes on boot, bisected to commit 5657933dbb6e

On Wed, 2017-03-01 at 21:26 -0600, Larry Finger wrote: > My Powerbook G4 Aluminum generates a fatal splat early in the boot process, > just  > after identifying the driver for the disk. Unfortunately, it turns off almost  > immediately, thus I cannot report the message. After this bug has been  >

[PATCH v14 2/5] iio: adc: mxs-lradc: Add support for adc driver

Add support for sixteen-channel 12-bit resolution ADC and its functions, which include general-purpose ADC readings, battery voltage measurement, and die temperature measurement. Signed-off-by: Ksenija Stanojevic Reviewed-by: Jonathan Cameron

[PATCH v14 2/5] iio: adc: mxs-lradc: Add support for adc driver

Add support for sixteen-channel 12-bit resolution ADC and its functions, which include general-purpose ADC readings, battery voltage measurement, and die temperature measurement. Signed-off-by: Ksenija Stanojevic Reviewed-by: Jonathan Cameron Reviewed-by: Marek Vasut --- Changes in v14: - fix

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

On Tue, Feb 28, 2017 at 07:15:47PM +0100, Peter Zijlstra wrote: > (And we should not be returning to userspace with locks held anyway -- > lockdep already has a check for that). Don't we return to userspace with page locks held, eg during async directio?

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

On Tue, Feb 28, 2017 at 07:15:47PM +0100, Peter Zijlstra wrote: > (And we should not be returning to userspace with locks held anyway -- > lockdep already has a check for that). Don't we return to userspace with page locks held, eg during async directio?

[PATCH] zram: reduce load operation in page_same_filled

In page_same_filled function, all elements in the page is compared with next index value. The current comparison routine compares the (i)th and (i+1)th values of the page. In this case, two load operaions occur for each comparison. But if we store first value of the page stores at 'val' variable

[PATCH] zram: reduce load operation in page_same_filled

In page_same_filled function, all elements in the page is compared with next index value. The current comparison routine compares the (i)th and (i+1)th values of the page. In this case, two load operaions occur for each comparison. But if we store first value of the page stores at 'val' variable

Re: [PATCH v2] staging: mkspec: added aarch64 ifarch case.

On Wed, Mar 01, 2017 at 09:24:14AM -0800, James Tau wrote: > Patch attempting to fix native 'make rpm' build on ARM64 machines by adding an > "ifarch aarch64" case. Without it, build fails because the 'cp ...' in the > default case can't find the built image. > > Signed-off-by: James Tau

Re: [PATCH v2] staging: mkspec: added aarch64 ifarch case.

On Wed, Mar 01, 2017 at 09:24:14AM -0800, James Tau wrote: > Patch attempting to fix native 'make rpm' build on ARM64 machines by adding an > "ifarch aarch64" case. Without it, build fails because the 'cp ...' in the > default case can't find the built image. > > Signed-off-by: James Tau > ---

Re: [PATCH v7 3/8] perf tool: update about the new option to record namespace events

Em Tue, Feb 21, 2017 at 07:31:37PM +0530, Hari Bathini escreveu: > Now that we have a new option to record namespace events, update > the perf-record documentation accordingly. > > Signed-off-by: Hari Bathini > --- > tools/perf/Documentation/perf-record.txt |3

Re: [PATCH v7 3/8] perf tool: update about the new option to record namespace events

Em Tue, Feb 21, 2017 at 07:31:37PM +0530, Hari Bathini escreveu: > Now that we have a new option to record namespace events, update > the perf-record documentation accordingly. > > Signed-off-by: Hari Bathini > --- > tools/perf/Documentation/perf-record.txt |3 +++ > 1 file changed, 3

Re: Regression in 4.11 - PowerPC crashes on boot, bisected to commit 5657933dbb6e

On Wed, 2017-03-01 at 21:26 -0600, Larry Finger wrote: > My Powerbook G4 Aluminum generates a fatal splat early in the boot process, > just > after identifying the driver for the disk. Unfortunately, it turns off almost > immediately, thus I cannot report the message. After this bug has been >

Re: Regression in 4.11 - PowerPC crashes on boot, bisected to commit 5657933dbb6e

On Wed, 2017-03-01 at 21:26 -0600, Larry Finger wrote: > My Powerbook G4 Aluminum generates a fatal splat early in the boot process, > just > after identifying the driver for the disk. Unfortunately, it turns off almost > immediately, thus I cannot report the message. After this bug has been >

Re: [PATCH 2/4] perf tools: Introduce cpu_map__snprint_mask()

Em Sat, Feb 25, 2017 at 01:27:34PM +0900, Namhyung Kim escreveu: > On Fri, Feb 24, 2017 at 06:08:53PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Feb 24, 2017 at 10:12:49AM +0900, Namhyung Kim escreveu: > > util/cpumap.c:679:8: error: comparison is always true due to limited range > > of

Re: [PATCH 2/4] perf tools: Introduce cpu_map__snprint_mask()

Em Sat, Feb 25, 2017 at 01:27:34PM +0900, Namhyung Kim escreveu: > On Fri, Feb 24, 2017 at 06:08:53PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Feb 24, 2017 at 10:12:49AM +0900, Namhyung Kim escreveu: > > util/cpumap.c:679:8: error: comparison is always true due to limited range > > of

Re: [PATCH] pci: dwc: Fix NULL pointer dereference due to missing assignment

On 03/01/2017 02:32 AM, Bjorn Helgaas wrote: On Tue, Feb 28, 2017 at 01:38:18PM +0530, Vivek Gautam wrote: Add missing assignment of dw_pci core structure for designware-plat. Commit 8b130f815a6b ("PCI: dwc: Fix crashes seen due to missing assignments") fixed all other platforms, but missed

Re: [PATCH] pci: dwc: Fix NULL pointer dereference due to missing assignment

On 03/01/2017 02:32 AM, Bjorn Helgaas wrote: On Tue, Feb 28, 2017 at 01:38:18PM +0530, Vivek Gautam wrote: Add missing assignment of dw_pci core structure for designware-plat. Commit 8b130f815a6b ("PCI: dwc: Fix crashes seen due to missing assignments") fixed all other platforms, but missed

[PATCH v1] qed: Fix copy of uninitialized memory

In qed_ll2_start_ooo() the ll2_info variable is uninitialized and then passed to qed_ll2_acquire_connection() where it is copied into a new memory space. This shouldn't cause any issue as long as non of the copied memory is every read. But the potential for a bug being introduced by reading this

[PATCH v1] qed: Fix copy of uninitialized memory

In qed_ll2_start_ooo() the ll2_info variable is uninitialized and then passed to qed_ll2_acquire_connection() where it is copied into a new memory space. This shouldn't cause any issue as long as non of the copied memory is every read. But the potential for a bug being introduced by reading this

Re: ftrace_graph_filter not working correctly since v4.10

On Wed, 1 Mar 2017 22:28:43 -0500 Steven Rostedt wrote: > > 4.10 is fine. It's what has been merged for 4.11 that's broken. I'm > doing a bisect now to see what broke it. Yes, lots of commits touched > that code recently. I found the bad commit. I'll have a patch for you to

Re: ftrace_graph_filter not working correctly since v4.10

On Wed, 1 Mar 2017 22:28:43 -0500 Steven Rostedt wrote: > > 4.10 is fine. It's what has been merged for 4.11 that's broken. I'm > doing a bisect now to see what broke it. Yes, lots of commits touched > that code recently. I found the bad commit. I'll have a patch for you to test tomorrow. --

Re: [PATCH 2/2] hwmon: Aspeed AST2400/AST2500 ADC

Resending in plain text. On Tue, Feb 28, 2017 at 7:45 PM, Guenter Roeck wrote: > On 02/28/2017 04:49 PM, Joel Stanley wrote: >> >> On Wed, Mar 1, 2017 at 6:44 AM, Rick Altherr wrote: >>> >>> Aspeed AST2400/AST2500 BMC SoCs include a 16 channel, 10-bit

Re: [PATCH 2/2] hwmon: Aspeed AST2400/AST2500 ADC

Resending in plain text. On Tue, Feb 28, 2017 at 7:45 PM, Guenter Roeck wrote: > On 02/28/2017 04:49 PM, Joel Stanley wrote: >> >> On Wed, Mar 1, 2017 at 6:44 AM, Rick Altherr wrote: >>> >>> Aspeed AST2400/AST2500 BMC SoCs include a 16 channel, 10-bit ADC. This >>> driver implements reading the

Re: [PATCH v2 0/4] fujitsu_init() cleanup [resend due to vger error]

On Wed, Mar 01, 2017 at 09:10:40AM +0100, Micha?? K??pie?? wrote: > These patches should make fujitsu_init() a bit more palatable. No > changes are made to platform device code yet, for clarity these will be > posted in a separate series after this one gets applied. Thanks for these. As for the

Re: [PATCH v2 0/4] fujitsu_init() cleanup [resend due to vger error]

On Wed, Mar 01, 2017 at 09:10:40AM +0100, Micha?? K??pie?? wrote: > These patches should make fujitsu_init() a bit more palatable. No > changes are made to platform device code yet, for clarity these will be > posted in a separate series after this one gets applied. Thanks for these. As for the

Re: [PATCH 8/9] Revert "mm, vmscan: account for skipped pages as a partial scan"

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > This reverts commit d7f05528eedb047efe2288cff777676b028747b6. > > Now that reclaimability of a node is no longer based on the ratio > between pages scanned and theoretically reclaimable pages, we can > remove accounting tricks for pages

Re: [PATCH 8/9] Revert "mm, vmscan: account for skipped pages as a partial scan"

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > This reverts commit d7f05528eedb047efe2288cff777676b028747b6. > > Now that reclaimability of a node is no longer based on the ratio > between pages scanned and theoretically reclaimable pages, we can > remove accounting tricks for pages

[PATCH] f2fs-tools: calculate cp_ver correctly

It needs to check CP_CRC_RECOVERY_FLAG during cp_ver calculation. Signed-off-by: Chao Yu --- include/f2fs_fs.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h index 057adf39f6a9..a92011b83ff5 100644 ---

[PATCH] f2fs-tools: calculate cp_ver correctly

It needs to check CP_CRC_RECOVERY_FLAG during cp_ver calculation. Signed-off-by: Chao Yu --- include/f2fs_fs.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h index 057adf39f6a9..a92011b83ff5 100644 --- a/include/f2fs_fs.h +++

Re: [PATCH 9/9] mm: remove unnecessary back-off function when retrying page reclaim

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > The backoff mechanism is not needed. If we have MAX_RECLAIM_RETRIES > loops without progress, we'll OOM anyway; backing off might cut one or > two iterations off that in the rare OOM case. If we have intermittent > success reclaiming a few

[PATCH] staging: lustre: fix sparse warning about different address spaces

fixed the following sparse warning by adding proper cast: drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: warning: incorrect type in argument 2 (different address spaces) drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74:expected char const [noderef] *

Re: [PATCH V3 2/7] PM / OPP: Introduce "domain-performance-state" binding to OPP nodes

On 03/02/2017 04:43 AM, Rob Herring wrote: > On Wed, Mar 1, 2017 at 12:27 AM, Rajendra Nayak wrote: >> >> >> On 02/28/2017 09:22 PM, Rob Herring wrote: >>> On Tue, Feb 28, 2017 at 9:14 AM, Ulf Hansson wrote: [...] >>

Re: [PATCH 9/9] mm: remove unnecessary back-off function when retrying page reclaim

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > The backoff mechanism is not needed. If we have MAX_RECLAIM_RETRIES > loops without progress, we'll OOM anyway; backing off might cut one or > two iterations off that in the rare OOM case. If we have intermittent > success reclaiming a few

[PATCH] staging: lustre: fix sparse warning about different address spaces

fixed the following sparse warning by adding proper cast: drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: warning: incorrect type in argument 2 (different address spaces) drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74:expected char const [noderef] *

Re: [PATCH V3 2/7] PM / OPP: Introduce "domain-performance-state" binding to OPP nodes

On 03/02/2017 04:43 AM, Rob Herring wrote: > On Wed, Mar 1, 2017 at 12:27 AM, Rajendra Nayak wrote: >> >> >> On 02/28/2017 09:22 PM, Rob Herring wrote: >>> On Tue, Feb 28, 2017 at 9:14 AM, Ulf Hansson wrote: [...] >> ---> Parent domain-2

Re: [PATCH 4/9] mm: remove unnecessary reclaimability check from NUMA balancing target

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > NUMA balancing already checks the watermarks of the target node to > decide whether it's a suitable balancing target. Whether the node is > reclaimable or not is irrelevant when we don't intend to reclaim. > > Signed-off-by: Johannes

Re: [PATCH 4/9] mm: remove unnecessary reclaimability check from NUMA balancing target

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > NUMA balancing already checks the watermarks of the target node to > decide whether it's a suitable balancing target. Whether the node is > reclaimable or not is irrelevant when we don't intend to reclaim. > > Signed-off-by: Johannes

Re: [PATCH 7/9] mm: delete NR_PAGES_SCANNED and pgdat_reclaimable()

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > NR_PAGES_SCANNED counts number of pages scanned since the last page > free event in the allocator. This was used primarily to measure the > reclaimability of zones and nodes, and determine when reclaim should > give up on them. In that role,

Re: [PATCH 7/9] mm: delete NR_PAGES_SCANNED and pgdat_reclaimable()

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > NR_PAGES_SCANNED counts number of pages scanned since the last page > free event in the allocator. This was used primarily to measure the > reclaimability of zones and nodes, and determine when reclaim should > give up on them. In that role,

Re: PPro arch_cpu_idle: NMI watchdog: Watchdog detected hard LOCKUP on cpu 1

> > This is on my trusty IBM PC365, dual Pentium Pro. 4.10 worked fine, > > 4.10.0-09686-g9e314890292c and 4.10.0-10770-g2d6be4abf514 exhibit a > > problem. Ocassionally NMI watchdog kicks in and discovers one of the > > CPUs in LOCKUP. The system keeps running fine. The first lockup was > >

Re: PPro arch_cpu_idle: NMI watchdog: Watchdog detected hard LOCKUP on cpu 1

> > This is on my trusty IBM PC365, dual Pentium Pro. 4.10 worked fine, > > 4.10.0-09686-g9e314890292c and 4.10.0-10770-g2d6be4abf514 exhibit a > > problem. Ocassionally NMI watchdog kicks in and discovers one of the > > CPUs in LOCKUP. The system keeps running fine. The first lockup was > >

Re: [PATCH 5/9] mm: don't avoid high-priority reclaim on unreclaimable nodes

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > 246e87a93934 ("memcg: fix get_scan_count() for small targets") sought > to avoid high reclaim priorities for kswapd by forcing it to scan a > minimum amount of pages when lru_pages >> priority yielded nothing. > > b95a2f2d486d ("mm: vmscan:

Re: [PATCH 5/9] mm: don't avoid high-priority reclaim on unreclaimable nodes

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > 246e87a93934 ("memcg: fix get_scan_count() for small targets") sought > to avoid high reclaim priorities for kswapd by forcing it to scan a > minimum amount of pages when lru_pages >> priority yielded nothing. > > b95a2f2d486d ("mm: vmscan:

Re: [PATCH 6/9] mm: don't avoid high-priority reclaim on memcg limit reclaim

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > 246e87a93934 ("memcg: fix get_scan_count() for small targets") sought > to avoid high reclaim priorities for memcg by forcing it to scan a > minimum amount of pages when lru_pages >> priority yielded nothing. > This was done at a time when

Re: [PATCH 6/9] mm: don't avoid high-priority reclaim on memcg limit reclaim

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > 246e87a93934 ("memcg: fix get_scan_count() for small targets") sought > to avoid high reclaim priorities for memcg by forcing it to scan a > minimum amount of pages when lru_pages >> priority yielded nothing. > This was done at a time when

Re: ftrace_graph_filter not working correctly since v4.10

On Wed, 01 Mar 2017 18:01:31 -0800 Todd Brandt wrote: > I've been using early boot trace to gather callgraph data on filtered > functions but something appears to have broken it in v10.0. The graph > trace worked fine in v4.10-rc8, so something changed since the

Re: ftrace_graph_filter not working correctly since v4.10

On Wed, 01 Mar 2017 18:01:31 -0800 Todd Brandt wrote: > I've been using early boot trace to gather callgraph data on filtered > functions but something appears to have broken it in v10.0. The graph > trace worked fine in v4.10-rc8, so something changed since the release. > > Issue: > Using the

Re: [PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > 1d82de618ddd ("mm, vmscan: make kswapd reclaim in terms of nodes") > allowed laptop_mode=1 to start writing not just when the priority > drops to DEF_PRIORITY - 2 but also when the node is unreclaimable. > That appears to be a spurious change

Re: [PATCH 3/9] mm: remove seemingly spurious reclaimability check from laptop_mode gating

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > 1d82de618ddd ("mm, vmscan: make kswapd reclaim in terms of nodes") > allowed laptop_mode=1 to start writing not just when the priority > drops to DEF_PRIORITY - 2 but also when the node is unreclaimable. > That appears to be a spurious change

Regression in 4.11 - PowerPC crashes on boot, bisected to commit 5657933dbb6e

My Powerbook G4 Aluminum generates a fatal splat early in the boot process, just after identifying the driver for the disk. Unfortunately, it turns off almost immediately, thus I cannot report the message. After this bug has been triggered, the system clock has been reset to Dec. 31, 1969. I

Regression in 4.11 - PowerPC crashes on boot, bisected to commit 5657933dbb6e

My Powerbook G4 Aluminum generates a fatal splat early in the boot process, just after identifying the driver for the disk. Unfortunately, it turns off almost immediately, thus I cannot report the message. After this bug has been triggered, the system clock has been reset to Dec. 31, 1969. I

Re: [PATCH 2/9] mm: fix check for reclaimable pages in PF_MEMALLOC reclaim throttling

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > PF_MEMALLOC direct reclaimers get throttled on a node when the sum of > all free pages in each zone fall below half the min watermark. During > the summation, we want to exclude zones that don't have reclaimables. > Checking the same pgdat

Re: [PATCH 2/9] mm: fix check for reclaimable pages in PF_MEMALLOC reclaim throttling

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > PF_MEMALLOC direct reclaimers get throttled on a node when the sum of > all free pages in each zone fall below half the min watermark. During > the summation, we want to exclude zones that don't have reclaimables. > Checking the same pgdat

[PATCH] f2fs: correct cp_ver for compatibility to old image

There is no CP_CRC_RECOVERY_FLAG tagged in checkpoint pack, calculate cp_version as old format. Signed-off-by: Chao Yu --- fs/f2fs/node.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 6c027b6833f4..0d46404ca769

[PATCH] f2fs: correct cp_ver for compatibility to old image

There is no CP_CRC_RECOVERY_FLAG tagged in checkpoint pack, calculate cp_version as old format. Signed-off-by: Chao Yu --- fs/f2fs/node.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 6c027b6833f4..0d46404ca769 100644 ---

Re: [PATCH 2/2] printk: fix double printing with earlycon

On Wed, 1 Mar 2017 19:13:46 +0300 Aleksey Makarov wrote: > If a console was specified by ACPI SPCR table _and_ > command line parameters like "console=ttyAMA0" _and_ "earlycon" > were specified, then log messages appears twice. > > The root cause is that the code

Re: [PATCH 2/2] printk: fix double printing with earlycon

On Wed, 1 Mar 2017 19:13:46 +0300 Aleksey Makarov wrote: > If a console was specified by ACPI SPCR table _and_ > command line parameters like "console=ttyAMA0" _and_ "earlycon" > were specified, then log messages appears twice. > > The root cause is that the code traverse the list > of

Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > Jia He reports a problem with kswapd spinning at 100% CPU when > requesting more hugepages than memory available in the system: > > $ echo 4000 >/proc/sys/vm/nr_hugepages > > top - 13:42:59 up 3:37, 1 user, load average: 1.09, 1.03, 1.01

Re: [PATCH 1/9] mm: fix 100% CPU kswapd busyloop on unreclaimable nodes

On March 01, 2017 5:40 AM Johannes Weiner wrote: > > Jia He reports a problem with kswapd spinning at 100% CPU when > requesting more hugepages than memory available in the system: > > $ echo 4000 >/proc/sys/vm/nr_hugepages > > top - 13:42:59 up 3:37, 1 user, load average: 1.09, 1.03, 1.01

Re: [PATCH v5 0/4] iio: accel: adxl345: Split driver into core and I2C then add SPI support

On Thu, Mar 02, 2017 at 01:22:11AM +0200, Andy Shevchenko wrote: > On Tue, Feb 28, 2017 at 4:37 AM, Eva Rachel Retuya > wrote: > > This patchset modifies the adxl345 to use regmap. In doing so, we can > > easily introduce SPI support and let regmap handle the rest. > > > >

Re: tracing: add #undef to fix compile error

On Wed, 28 Sep 2016 22:55:54 -0400 Rik van Riel wrote: > There are several trace include files that define TRACE_INCLUDE_FILE. > > Include several of them in the same .c file (as I currently have in > some code I am working on), and the compile will blow up with a > "warning:

Re: [PATCH v5 0/4] iio: accel: adxl345: Split driver into core and I2C then add SPI support

On Thu, Mar 02, 2017 at 01:22:11AM +0200, Andy Shevchenko wrote: > On Tue, Feb 28, 2017 at 4:37 AM, Eva Rachel Retuya > wrote: > > This patchset modifies the adxl345 to use regmap. In doing so, we can > > easily introduce SPI support and let regmap handle the rest. > > > > Recap of basic

Re: tracing: add #undef to fix compile error

On Wed, 28 Sep 2016 22:55:54 -0400 Rik van Riel wrote: > There are several trace include files that define TRACE_INCLUDE_FILE. > > Include several of them in the same .c file (as I currently have in > some code I am working on), and the compile will blow up with a > "warning:

Re: [PATCH 00/21] MIPS memblock: Remove bootmem code and switch to NO_BOOTMEM

On 01/22/2017 11:55 PM, Marcin Nowakowski wrote: > Hi Serge, > > Thanks for this patch series, it's really useful. I've tested it on > Malta and Ci40 and it seems to work well (I've posted a few small > comments separately). I have not tested this yet, but this is definitively a very useful

Re: [PATCH 00/21] MIPS memblock: Remove bootmem code and switch to NO_BOOTMEM

On 01/22/2017 11:55 PM, Marcin Nowakowski wrote: > Hi Serge, > > Thanks for this patch series, it's really useful. I've tested it on > Malta and Ci40 and it seems to work well (I've posted a few small > comments separately). I have not tested this yet, but this is definitively a very useful

[PATCH] drivers: net: ethernet: remove incorrect __exit markups

Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by:

[PATCH] drivers: net: ethernet: remove incorrect __exit markups

Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by:

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

On Wed, Mar 01, 2017 at 02:17:07PM +0900, Byungchul Park wrote: > > > +void lock_commit_crosslock(struct lockdep_map *lock) > > > +{ > > > + struct cross_lock *xlock; > > > + unsigned long flags; > > > + > > > + if (!current->xhlocks) > > > + return; > > > + > > > + if

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

On Wed, Mar 01, 2017 at 02:17:07PM +0900, Byungchul Park wrote: > > > +void lock_commit_crosslock(struct lockdep_map *lock) > > > +{ > > > + struct cross_lock *xlock; > > > + unsigned long flags; > > > + > > > + if (!current->xhlocks) > > > + return; > > > + > > > + if

Re: [PATCH 1/2] drm: Use pr_cont where appropriate

On Mon, Feb 27, 2017 at 8:31 PM, Joe Perches wrote: > Using 'printk("\n")' is not preferred anymore and > using printk to continue logging messages now produces > multiple line logging output unless the continuations > use KERN_CONT. > > Convert these uses to appropriately use

Re: [PATCH 1/2] drm: Use pr_cont where appropriate

On Mon, Feb 27, 2017 at 8:31 PM, Joe Perches wrote: > Using 'printk("\n")' is not preferred anymore and > using printk to continue logging messages now produces > multiple line logging output unless the continuations > use KERN_CONT. > > Convert these uses to appropriately use pr_cont or a >

<    1   2   3   4   5   6   7   8   9   10   >