[PATCH 1/2] Staging: wlan-ng: Fix sparse warnings by using appropriate endian types

Fix some sparse warning by using correct endian types in structs and local variables. This patch only fix sparse warnings and do not change the logic. Signed-off-by: Adrien Descamps --- Compile tested only drivers/staging/wlan-ng/hfa384x.h | 58

[PATCH 1/2] Staging: wlan-ng: Fix sparse warnings by using appropriate endian types

Fix some sparse warning by using correct endian types in structs and local variables. This patch only fix sparse warnings and do not change the logic. Signed-off-by: Adrien Descamps --- Compile tested only drivers/staging/wlan-ng/hfa384x.h | 58 +--

[PATCH 2/2] Staging: wlan-ng: Fix endian error

sparse report fixed: drivers/staging//wlan-ng//hfa384x_usb.c:3517:35: warning: restricted __be64 degrades to integer drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: warning: incorrect type in assignment (different base types) drivers/staging//wlan-ng//hfa384x_usb.c:3517:33:expected

[PATCH 2/2] Staging: wlan-ng: Fix endian error

sparse report fixed: drivers/staging//wlan-ng//hfa384x_usb.c:3517:35: warning: restricted __be64 degrades to integer drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: warning: incorrect type in assignment (different base types) drivers/staging//wlan-ng//hfa384x_usb.c:3517:33:expected

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

Hi Richard, On Fri, Mar 3, 2017 at 3:22 PM, Richard Genoud wrote: > Since commit 1d267ea6539f ("serial: mctrl-gpio: simplify init routine"), > the mctrl_gpio_to_gpiod() function can't return an error anymore. > So, just testing for a NULL pointer is ok. If

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

Hi Richard, On Fri, Mar 3, 2017 at 3:22 PM, Richard Genoud wrote: > Since commit 1d267ea6539f ("serial: mctrl-gpio: simplify init routine"), > the mctrl_gpio_to_gpiod() function can't return an error anymore. > So, just testing for a NULL pointer is ok. If CONFIG_GPIOLIB=n,

Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly

On 03/03/2017 08:41 AM, Laurent Pinchart wrote: > Hi Laura, > > Thank you for the patch. > > On Thursday 02 Mar 2017 13:44:42 Laura Abbott wrote: >> When CMA was first introduced, its primary use was for DMA allocation >> and the only way to get CMA memory was to call dma_alloc_coherent. This >>

Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly

On 03/03/2017 08:41 AM, Laurent Pinchart wrote: > Hi Laura, > > Thank you for the patch. > > On Thursday 02 Mar 2017 13:44:42 Laura Abbott wrote: >> When CMA was first introduced, its primary use was for DMA allocation >> and the only way to get CMA memory was to call dma_alloc_coherent. This >>

Re: net/ipv4: deadlock in ip_ra_control

On Thu, Mar 2, 2017 at 10:40 AM, Dmitry Vyukov wrote: > On Wed, Mar 1, 2017 at 6:18 PM, Cong Wang wrote: >> On Wed, Mar 1, 2017 at 2:44 AM, Dmitry Vyukov wrote: >>> Hello, >>> >>> I've got the following deadlock report while

Re: net/ipv4: deadlock in ip_ra_control

On Thu, Mar 2, 2017 at 10:40 AM, Dmitry Vyukov wrote: > On Wed, Mar 1, 2017 at 6:18 PM, Cong Wang wrote: >> On Wed, Mar 1, 2017 at 2:44 AM, Dmitry Vyukov wrote: >>> Hello, >>> >>> I've got the following deadlock report while running syzkaller fuzzer >>> on

Re: [Outreachy kernel] [PATCH 2/6] staging: speakup: simple_strtoul is replaced with kstrtoul

On Sat, 4 Mar 2017, Arushi Singhal wrote: > This patch fixes "simple_strtoul is obsolete, use kstrtoul instead" > warning. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/kobjects.c| 4 ++-- > drivers/staging/speakup/main.c| 2 +-

Re: [Outreachy kernel] [PATCH 2/6] staging: speakup: simple_strtoul is replaced with kstrtoul

On Sat, 4 Mar 2017, Arushi Singhal wrote: > This patch fixes "simple_strtoul is obsolete, use kstrtoul instead" > warning. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/kobjects.c| 4 ++-- > drivers/staging/speakup/main.c| 2 +- >

Re: [Outreachy kernel] [PATCH] staging: speakup: else is not generally useful after a break or return

On Fri, 3 Mar 2017, Arushi Singhal wrote: > fixed checkpatch.pl warning: else is not generally useful after a break > or return. > Removed the else without affecting the logic. > Dead code is also eliminated. The chhange is not correct. There is a big chain of if/else if. The if (type ==

[PATCH 5/6] staging: speakup: Avoid multiple assignments on same line

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[PATCH 5/6] staging: speakup: Avoid multiple assignments on same line

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/speakup/main.c

Re: [Outreachy kernel] [PATCH] staging: speakup: else is not generally useful after a break or return

On Fri, 3 Mar 2017, Arushi Singhal wrote: > fixed checkpatch.pl warning: else is not generally useful after a break > or return. > Removed the else without affecting the logic. > Dead code is also eliminated. The chhange is not correct. There is a big chain of if/else if. The if (type ==

Re: net/ipv4: deadlock in ip_ra_control

On Fri, Mar 3, 2017 at 7:43 PM, Dmitry Vyukov wrote: > On Thu, Mar 2, 2017 at 10:40 AM, Dmitry Vyukov wrote: >> On Wed, Mar 1, 2017 at 6:18 PM, Cong Wang wrote: >>> On Wed, Mar 1, 2017 at 2:44 AM, Dmitry Vyukov

Re: net/ipv4: deadlock in ip_ra_control

On Fri, Mar 3, 2017 at 7:43 PM, Dmitry Vyukov wrote: > On Thu, Mar 2, 2017 at 10:40 AM, Dmitry Vyukov wrote: >> On Wed, Mar 1, 2017 at 6:18 PM, Cong Wang wrote: >>> On Wed, Mar 1, 2017 at 2:44 AM, Dmitry Vyukov wrote: Hello, I've got the following deadlock report while running

Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support

On 03/03/2017 08:39 AM, Laurent Pinchart wrote: > Hi Daniel, > > On Friday 03 Mar 2017 10:56:54 Daniel Vetter wrote: >> On Thu, Mar 02, 2017 at 01:44:38PM -0800, Laura Abbott wrote: >>> Now that we call dma_map in the dma_buf API callbacks there is no need >>> to use the existing cache APIs.

Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support

On 03/03/2017 08:39 AM, Laurent Pinchart wrote: > Hi Daniel, > > On Friday 03 Mar 2017 10:56:54 Daniel Vetter wrote: >> On Thu, Mar 02, 2017 at 01:44:38PM -0800, Laura Abbott wrote: >>> Now that we call dma_map in the dma_buf API callbacks there is no need >>> to use the existing cache APIs.

Re: [patch 3/3] speakup: add unicode variant of /dev/softsynth

Samuel Thibault writes: > This adds /dev/softsynthu, along /dev/softsynth, which emits output in > UTF-8 encoding, thus allowing to support 16bit characters. Most of the > code is shared, only the read function has to behave differently in > latin1 and in unicode

Re: [patch 3/3] speakup: add unicode variant of /dev/softsynth

Samuel Thibault writes: > This adds /dev/softsynthu, along /dev/softsynth, which emits output in > UTF-8 encoding, thus allowing to support 16bit characters. Most of the > code is shared, only the read function has to behave differently in > latin1 and in unicode mode. Since Linux only

[PATCH 4/6] staging: speakup: Blank lines removed after an open brace '{'

Blank lines aren't necessary after an open brace '{' as reported by Checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c

[PATCH 4/6] staging: speakup: Blank lines removed after an open brace '{'

Blank lines aren't necessary after an open brace '{' as reported by Checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index

Re: [patch 1/3] speakup: extend synth buffer to 16bit unicode characters

Samuel Thibault writes: > This extends the synth buffer slots to 16bit, so as to hold 16bit > unicode characters. > > synth_buffer_getc and synth_buffer_peek now return 16bit characters. > Speech synthesizers which do not support characters beyond latin1 can > use

Re: [patch 1/3] speakup: extend synth buffer to 16bit unicode characters

Samuel Thibault writes: > This extends the synth buffer slots to 16bit, so as to hold 16bit > unicode characters. > > synth_buffer_getc and synth_buffer_peek now return 16bit characters. > Speech synthesizers which do not support characters beyond latin1 can > use the

[PATCH 0/6] multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (6): staging: speakup: Add blank line after function/struct/union/enum declarations staging: speakup: simple_strtoul is replaced with kstrtoul staging: speakup: Logical continuations should be

[PATCH 0/6] multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (6): staging: speakup: Add blank line after function/struct/union/enum declarations staging: speakup: simple_strtoul is replaced with kstrtoul staging: speakup: Logical continuations should be

Re: [Outreachy kernel] [PATCH 5/6] staging: speakup: Avoid multiple assignments on same line

On Sat, 4 Mar 2017, Arushi Singhal wrote: > This patch fixes the checkpatch.pl warning "multiple assignments > should be avoided." > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/main.c | 18 -- > 1 file changed, 12

Re: [Outreachy kernel] [PATCH 5/6] staging: speakup: Avoid multiple assignments on same line

On Sat, 4 Mar 2017, Arushi Singhal wrote: > This patch fixes the checkpatch.pl warning "multiple assignments > should be avoided." > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/main.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff

Re: net/ipv4: division by 0 in tcp_select_window

On Fri, Mar 3, 2017 at 10:24 AM, Dmitry Vyukov wrote: > On Fri, Mar 3, 2017 at 7:10 PM, Dmitry Vyukov wrote: >> Hello, >> > Wonder if this has been causing other crashes like this one? > > [ cut here ] > kernel BUG at

Re: net/ipv4: division by 0 in tcp_select_window

On Fri, Mar 3, 2017 at 10:24 AM, Dmitry Vyukov wrote: > On Fri, Mar 3, 2017 at 7:10 PM, Dmitry Vyukov wrote: >> Hello, >> > Wonder if this has been causing other crashes like this one? > > [ cut here ] > kernel BUG at net/ipv4/tcp_output.c:2748! > Call Trace: > >

[PATCH 3/6] staging: speakup: Logical continuations should be on the previous line

This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff

[PATCH 3/6] staging: speakup: Logical continuations should be on the previous line

This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

[PATCH] staging: speakup: else is not generally useful after a break or return

fixed checkpatch.pl warning: else is not generally useful after a break or return. Removed the else without affecting the logic. Dead code is also eliminated. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/keyhelp.c | 53

[PATCH] staging: speakup: else is not generally useful after a break or return

fixed checkpatch.pl warning: else is not generally useful after a break or return. Removed the else without affecting the logic. Dead code is also eliminated. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/keyhelp.c | 53 ++- 1 file changed, 19

[PATCH v3 1/5] coresight: bindings for debug module

According to ARMv8 architecture reference manual (ARM DDI 0487A.k) Chapter 'Part H: External debug', the CPU can integrate debug module and it can support self-hosted debug and external debug. Especially for supporting self-hosted debug, this means the program can access the debug module from mmio

[PATCH v3 1/5] coresight: bindings for debug module

According to ARMv8 architecture reference manual (ARM DDI 0487A.k) Chapter 'Part H: External debug', the CPU can integrate debug module and it can support self-hosted debug and external debug. Especially for supporting self-hosted debug, this means the program can access the debug module from mmio

Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping

On 03/03/2017 08:37 AM, Laurent Pinchart wrote: > Hi Laura, > > Thank you for the patch. > > On Thursday 02 Mar 2017 13:44:36 Laura Abbott wrote: >> Technically, calling dma_buf_map_attachment should return a buffer >> properly dma_mapped. Add calls to dma_map_sg to begin_cpu_access to >> ensure

Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping

On 03/03/2017 08:37 AM, Laurent Pinchart wrote: > Hi Laura, > > Thank you for the patch. > > On Thursday 02 Mar 2017 13:44:36 Laura Abbott wrote: >> Technically, calling dma_buf_map_attachment should return a buffer >> properly dma_mapped. Add calls to dma_map_sg to begin_cpu_access to >> ensure

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On Tue, Feb 21, 2017 at 05:24:04PM +0300, Heikki Krogerus wrote: > +/* --- */ > +/* Driver callbacks to report role updates */ > + > +/** > + * typec_set_data_role - Report data role change > + * @port: The USB Type-C Port where the role was changed > + * @role:

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On Tue, Feb 21, 2017 at 05:24:04PM +0300, Heikki Krogerus wrote: > +/* --- */ > +/* Driver callbacks to report role updates */ > + > +/** > + * typec_set_data_role - Report data role change > + * @port: The USB Type-C Port where the role was changed > + * @role:

Re: [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table

On 03/03/2017 12:18 AM, Hillf Danton wrote: > > On March 03, 2017 5:45 AM Laura Abbott wrote: >> >> +static struct sg_table *dup_sg_table(struct sg_table *table) >> +{ >> +struct sg_table *new_table; >> +int ret, i; >> +struct scatterlist *sg, *new_sg; >> + >> +new_table =

Re: [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table

On 03/03/2017 12:18 AM, Hillf Danton wrote: > > On March 03, 2017 5:45 AM Laura Abbott wrote: >> >> +static struct sg_table *dup_sg_table(struct sg_table *table) >> +{ >> +struct sg_table *new_table; >> +int ret, i; >> +struct scatterlist *sg, *new_sg; >> + >> +new_table =

Re: [Outreachy kernel] [PATCH 6/6] staging: speakup: fixes braces {} should be used on all arms of this statement

On Sat, 4 Mar 2017, Arushi Singhal wrote: > This patch fixes the checks reported by checkpatch.pl > for braces {} should be used on all arms of this statement. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/main.c | 29

Re: [Outreachy kernel] Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

On Fri, 3 Mar 2017, SIMRAN SINGHAL wrote: > On Fri, Mar 3, 2017 at 11:15 PM, Sakari Ailus wrote: > > Hi Simran, > > > > On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote: > >> This patch removes unnecessary typecast of c90 int constant. > >> > >> WARNING:

Re: [Outreachy kernel] [PATCH 6/6] staging: speakup: fixes braces {} should be used on all arms of this statement

On Sat, 4 Mar 2017, Arushi Singhal wrote: > This patch fixes the checks reported by checkpatch.pl > for braces {} should be used on all arms of this statement. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/main.c | 29 +++-- > 1 file changed, 19

Re: [Outreachy kernel] Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

On Fri, 3 Mar 2017, SIMRAN SINGHAL wrote: > On Fri, Mar 3, 2017 at 11:15 PM, Sakari Ailus wrote: > > Hi Simran, > > > > On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote: > >> This patch removes unnecessary typecast of c90 int constant. > >> > >> WARNING: Unnecessary typecast of

Re: [PATCH] ARM: DTS armada: Add support for 2 more mvebu model

On Fri, Mar 03, 2017 at 06:07:35PM +0100, Ansuel Smith wrote: > This patch add support for 2 Linksys router model > (shelby and rango). With this we now support all > the mvebu board on the market. > > Signed-off-by: Imre Kaloz > Signed-off-by: Álvaro Fernández Rojas

Re: [PATCH] ARM: DTS armada: Add support for 2 more mvebu model

On Fri, Mar 03, 2017 at 06:07:35PM +0100, Ansuel Smith wrote: > This patch add support for 2 Linksys router model > (shelby and rango). With this we now support all > the mvebu board on the market. > > Signed-off-by: Imre Kaloz > Signed-off-by: Álvaro Fernández Rojas > Signed-off-by: Ansuel

Re: [PATCH 0/4] Improve intel-hid's self-consistency

On Thu, Mar 2, 2017 at 12:17 PM, Alex Hung wrote: > On Thu, Mar 2, 2017 at 7:03 AM, Andy Shevchenko > wrote: >> On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień wrote: >>> Commit 2cfa4b311acc ("platform/x86: intel-hid:

Re: [PATCH 0/4] Improve intel-hid's self-consistency

On Thu, Mar 2, 2017 at 12:17 PM, Alex Hung wrote: > On Thu, Mar 2, 2017 at 7:03 AM, Andy Shevchenko > wrote: >> On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień wrote: >>> Commit 2cfa4b311acc ("platform/x86: intel-hid: Support 5 button array") >>> contains some coding style cleanups compared to

Re: [PATCH v3 0/3] Add support for MyGica T230C DVB-T2 stick

On Fr, 2017-02-17 at 01:55 +0100, Stefan Brüns wrote: > The required command sequence for the new tuner (Si2141) was traced > from the > current Windows driver and verified with a small python > script/libusb. > The changes to the Si2168 and dvbsky driver are mostly additions of > the > required

Re: [PATCH v3 0/3] Add support for MyGica T230C DVB-T2 stick

On Fr, 2017-02-17 at 01:55 +0100, Stefan Brüns wrote: > The required command sequence for the new tuner (Si2141) was traced > from the > current Windows driver and verified with a small python > script/libusb. > The changes to the Si2168 and dvbsky driver are mostly additions of > the > required

Re: [PATCH v2 1/3] soc: qcom: Add scm call to protect modem mem in qcom scm driver.

On 2/28/2017 4:25 AM, Stephen Boyd wrote: On 01/30, Avaneesh Kumar Dwivedi wrote: diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 893f953ea..f476803 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -292,6 +292,20 @@ int

Re: [PATCH v2 1/3] soc: qcom: Add scm call to protect modem mem in qcom scm driver.

On 2/28/2017 4:25 AM, Stephen Boyd wrote: On 01/30, Avaneesh Kumar Dwivedi wrote: diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 893f953ea..f476803 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -292,6 +292,20 @@ int

Re: [PATCH 0/2] fs, ceph filesystem refcount conversions

On Fri, Mar 3, 2017 at 10:15 AM, Elena Reshetova wrote: > Now when new refcount_t type and API are finally merged > (see include/linux/refcount.h), the following > patches convert various refcounters in the ceph filesystem from atomic_t > to refcount_t. By doing this we

Re: [PATCH 0/2] fs, ceph filesystem refcount conversions

On Fri, Mar 3, 2017 at 10:15 AM, Elena Reshetova wrote: > Now when new refcount_t type and API are finally merged > (see include/linux/refcount.h), the following > patches convert various refcounters in the ceph filesystem from atomic_t > to refcount_t. By doing this we prevent intentional or

Re: [PATCH v2 2/3] remoteproc: qcom: Add scm call to protect modem mem in mss rproc drv.

On 2/28/2017 12:46 PM, Stephen Boyd wrote: On 01/30, Avaneesh Kumar Dwivedi wrote: This patch add hypervisor call support for second stage translation from mss remoteproc driver, this is required so that modem on msm8996 which is based on armv8 architecture can access DDR region where modem

Re: [PATCH v2 2/3] remoteproc: qcom: Add scm call to protect modem mem in mss rproc drv.

On 2/28/2017 12:46 PM, Stephen Boyd wrote: On 01/30, Avaneesh Kumar Dwivedi wrote: This patch add hypervisor call support for second stage translation from mss remoteproc driver, this is required so that modem on msm8996 which is based on armv8 architecture can access DDR region where modem

Re: net/ipv4: division by 0 in tcp_select_window

On Fri, Mar 3, 2017 at 10:10 AM, Dmitry Vyukov wrote: > Hello, > > The following program triggers division by 0 in tcp_select_window: > > https://gist.githubusercontent.com/dvyukov/ef28c0fd2ab57a655508ef7621b12e6c/raw/079011e2a9523a390b0621cbc1e5d9d5e637fd6d/gistfile1.txt

Re: net/ipv4: division by 0 in tcp_select_window

On Fri, Mar 3, 2017 at 10:10 AM, Dmitry Vyukov wrote: > Hello, > > The following program triggers division by 0 in tcp_select_window: > > https://gist.githubusercontent.com/dvyukov/ef28c0fd2ab57a655508ef7621b12e6c/raw/079011e2a9523a390b0621cbc1e5d9d5e637fd6d/gistfile1.txt Yeah, tcp_disconnect()

Re: net/ipv4: division by 0 in tcp_select_window

On Fri, Mar 3, 2017 at 7:10 PM, Dmitry Vyukov wrote: > Hello, > > The following program triggers division by 0 in tcp_select_window: > > https://gist.githubusercontent.com/dvyukov/ef28c0fd2ab57a655508ef7621b12e6c/raw/079011e2a9523a390b0621cbc1e5d9d5e637fd6d/gistfile1.txt > >

Re: net/ipv4: division by 0 in tcp_select_window

On Fri, Mar 3, 2017 at 7:10 PM, Dmitry Vyukov wrote: > Hello, > > The following program triggers division by 0 in tcp_select_window: > > https://gist.githubusercontent.com/dvyukov/ef28c0fd2ab57a655508ef7621b12e6c/raw/079011e2a9523a390b0621cbc1e5d9d5e637fd6d/gistfile1.txt > > divide error:

Re: [PATCH v4 1/3] x86: Introduce a new constant KERNEL_MAPPING_SIZE

Ok, TBH, I still don't like adding yet another define and paying attention to whether I should use image size or mapping size. After your patch, KERNEL_IMAGE_SIZE is used to enforce the actual image size from exploding: arch/x86/include/asm/page_32_types.h:43:#define KERNEL_IMAGE_SIZE (512

Re: [PATCH v4 1/3] x86: Introduce a new constant KERNEL_MAPPING_SIZE

Ok, TBH, I still don't like adding yet another define and paying attention to whether I should use image size or mapping size. After your patch, KERNEL_IMAGE_SIZE is used to enforce the actual image size from exploding: arch/x86/include/asm/page_32_types.h:43:#define KERNEL_IMAGE_SIZE (512

[PATCH 2/3] futex: fix decoding of operation

encoded_op uses int as type which results in pretty weird behaviour. E.g. if encoded_op contains oparg 0xfff, it currently results in oparg being -1. Switch encoded_op to 'unsigned int' which is correct given it is a bit mask anyway. And perform upper bound checking on oparg to inform users about

[PATCH 2/3] futex: fix decoding of operation

encoded_op uses int as type which results in pretty weird behaviour. E.g. if encoded_op contains oparg 0xfff, it currently results in oparg being -1. Switch encoded_op to 'unsigned int' which is correct given it is a bit mask anyway. And perform upper bound checking on oparg to inform users about

Re: [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data

On March 1, 2017 2:27:54 AM PST, Ingo Molnar wrote: > >* Thomas Gleixner wrote: > >> On Wed, 1 Mar 2017, Ingo Molnar wrote: >> > >> > * Jiri Slaby wrote: >> > >> > > This is a start of series to unify use of ENTRY, ENDPROC, GLOBAL, >END,

Re: [PATCH v2 3/3] remoteproc: qcom: Add msm8996 specific changes in mss rproc driver.

On 03/03, Dwivedi, Avaneesh Kumar (avani) wrote: > On 2/28/2017 4:18 AM, Stephen Boyd wrote: > >On 01/30, Avaneesh Kumar Dwivedi wrote: > >>@@ -1213,6 +1299,47 @@ static int q6v5_remove(struct platform_device *pdev) > >>return 0; > >> } > >>+static const struct rproc_hexagon_res msm8996_mss =

Re: [PATCH v2 3/3] remoteproc: qcom: Add msm8996 specific changes in mss rproc driver.

On 03/03, Dwivedi, Avaneesh Kumar (avani) wrote: > On 2/28/2017 4:18 AM, Stephen Boyd wrote: > >On 01/30, Avaneesh Kumar Dwivedi wrote: > >>@@ -1213,6 +1299,47 @@ static int q6v5_remove(struct platform_device *pdev) > >>return 0; > >> } > >>+static const struct rproc_hexagon_res msm8996_mss =

Re: [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data

On March 1, 2017 2:27:54 AM PST, Ingo Molnar wrote: > >* Thomas Gleixner wrote: > >> On Wed, 1 Mar 2017, Ingo Molnar wrote: >> > >> > * Jiri Slaby wrote: >> > >> > > This is a start of series to unify use of ENTRY, ENDPROC, GLOBAL, >END, >> > > and other macros across x86. When we have all

[PATCH 3/3] futex: make the encoded_op decoding readable

Decoding of encoded_op is a bit unreadable. It contains shifts to the left and to the right by some constants. Make it clearly visible what part of the bit mask is taken and shift the values only to the right appropriatelly. Signed-off-by: Jiri Slaby --- kernel/futex.c | 8

[PATCH 3/3] futex: make the encoded_op decoding readable

Decoding of encoded_op is a bit unreadable. It contains shifts to the left and to the right by some constants. Make it clearly visible what part of the bit mask is taken and shift the values only to the right appropriatelly. Signed-off-by: Jiri Slaby --- kernel/futex.c | 8 1 file

Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

On Fri, Mar 3, 2017 at 11:15 PM, Sakari Ailus wrote: > Hi Simran, > > On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote: >> This patch removes unnecessary typecast of c90 int constant. >> >> WARNING: Unnecessary typecast of c90 int constant >> >> Signed-off-by:

Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

On Fri, Mar 3, 2017 at 11:15 PM, Sakari Ailus wrote: > Hi Simran, > > On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote: >> This patch removes unnecessary typecast of c90 int constant. >> >> WARNING: Unnecessary typecast of c90 int constant >> >> Signed-off-by: simran singhal > >

Re: [PATCH v2 2/3] remoteproc: qcom: Add scm call to protect modem mem in mss rproc drv.

On 03/03, Dwivedi, Avaneesh Kumar (avani) wrote: > On 2/28/2017 12:46 PM, Stephen Boyd wrote: > >On 01/30, Avaneesh Kumar Dwivedi wrote: > >>+ dest_info[i].vm = dest[i]; > >>+ dest_info[i].perm = perm[i]; > >Needs to do a cpu_to_le32() somewhere. Please run sparse. > I

Re: [PATCH v2 2/3] remoteproc: qcom: Add scm call to protect modem mem in mss rproc drv.

On 03/03, Dwivedi, Avaneesh Kumar (avani) wrote: > On 2/28/2017 12:46 PM, Stephen Boyd wrote: > >On 01/30, Avaneesh Kumar Dwivedi wrote: > >>+ dest_info[i].vm = dest[i]; > >>+ dest_info[i].perm = perm[i]; > >Needs to do a cpu_to_le32() somewhere. Please run sparse. > I

Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property

On Fri, Mar 03, 2017 at 05:48:19PM +, Alexey Brodkin wrote: > Hi Liviu, > > On Fri, 2017-03-03 at 16:28 +, Liviu Dudau wrote: > > On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wrote: > > > > > > - /* find the encoder node and initialize it */ > > > - encoder_node =

Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property

On Fri, Mar 03, 2017 at 05:48:19PM +, Alexey Brodkin wrote: > Hi Liviu, > > On Fri, 2017-03-03 at 16:28 +, Liviu Dudau wrote: > > On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wrote: > > > > > > - /* find the encoder node and initialize it */ > > > - encoder_node =

[BUG 4.9/4.10] crash in __d_lookup() due to corrupted dentry_hashtable

Hello Al, Gustavo reported the crash below within __d_lookup() on s390. I'm wondering if you can make any sense of it: Unable to handle kernel pointer dereference in virtual kernel address space Failing address: f000 TEID: f803 Fault in home space mode while using kernel

[BUG 4.9/4.10] crash in __d_lookup() due to corrupted dentry_hashtable

Hello Al, Gustavo reported the crash below within __d_lookup() on s390. I'm wondering if you can make any sense of it: Unable to handle kernel pointer dereference in virtual kernel address space Failing address: f000 TEID: f803 Fault in home space mode while using kernel

Re: [PATCH v2 3/3] remoteproc: qcom: Add msm8996 specific changes in mss rproc driver.

On 2/28/2017 4:18 AM, Stephen Boyd wrote: On 01/30, Avaneesh Kumar Dwivedi wrote: diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index 35eee68..9c12a36 100644 --- a/drivers/remoteproc/qcom_q6v5_pil.c +++ b/drivers/remoteproc/qcom_q6v5_pil.c @@ -485,35

Re: [PATCH net] rxrpc: Fix potential NULL-pointer exception

From: David Howells Date: Thu, 02 Mar 2017 23:26:13 + > Fix a potential NULL-pointer exception in rxrpc_do_sendmsg(). The call > state check that I added should have gone into the else-body of the > if-statement where we actually have a call to check. > > Found by

Re: [PATCH v2 3/3] remoteproc: qcom: Add msm8996 specific changes in mss rproc driver.

On 2/28/2017 4:18 AM, Stephen Boyd wrote: On 01/30, Avaneesh Kumar Dwivedi wrote: diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index 35eee68..9c12a36 100644 --- a/drivers/remoteproc/qcom_q6v5_pil.c +++ b/drivers/remoteproc/qcom_q6v5_pil.c @@ -485,35

Re: [PATCH net] rxrpc: Fix potential NULL-pointer exception

From: David Howells Date: Thu, 02 Mar 2017 23:26:13 + > Fix a potential NULL-pointer exception in rxrpc_do_sendmsg(). The call > state check that I added should have gone into the else-body of the > if-statement where we actually have a call to check. > > Found by CoverityScan CID#1414316

hi

Greetings to you, My name is Avriel Harry, a sergeant of UNITED STATE ARMY, I hope this email will find you well & healthy and I hope we can establish a relationship since we are meeting here for the first time,i have gone through a profile that speaks good of you in this site and I was impressed

RE: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

James, Can you verify that changing the code to the following fixes your problem? if (IS_ERR_OR_NULL(d->clk) || !old) goto out; Regards, Jason -Original Message- From: Ray Jui [mailto:ray@broadcom.com] Sent: March-03-17 9:34 AM To: Andy Shevchenko

hi

Greetings to you, My name is Avriel Harry, a sergeant of UNITED STATE ARMY, I hope this email will find you well & healthy and I hope we can establish a relationship since we are meeting here for the first time,i have gone through a profile that speaks good of you in this site and I was impressed

RE: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

James, Can you verify that changing the code to the following fixes your problem? if (IS_ERR_OR_NULL(d->clk) || !old) goto out; Regards, Jason -Original Message- From: Ray Jui [mailto:ray@broadcom.com] Sent: March-03-17 9:34 AM To: Andy Shevchenko ; James Hogan ; Heiko Stuebner

Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

Hi Alexey, On 03-03-2017 13:27, Alexey Brodkin wrote: > > So if I understood you correct here what I really need is just to get rid of > existing check, > right? I.e. the following is to be in v2 respin: > --->8--- > diff --git

Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

Hi Alexey, On 03-03-2017 13:27, Alexey Brodkin wrote: > > So if I understood you correct here what I really need is just to get rid of > existing check, > right? I.e. the following is to be in v2 respin: > --->8--- > diff --git

Re: [PATCH] selinux: check for address length in selinux_socket_bind()

On Fri, Mar 3, 2017 at 9:23 AM, Alexander Potapenko wrote: > This happens because bind() unconditionally copies |size| bytes of > |addr| to the kernel, leaving the rest uninitialized. Then > security_socket_bind() reads the IP address bytes, including the > uninitialized ones,

Re: [PATCH] selinux: check for address length in selinux_socket_bind()

On Fri, Mar 3, 2017 at 9:23 AM, Alexander Potapenko wrote: > This happens because bind() unconditionally copies |size| bytes of > |addr| to the kernel, leaving the rest uninitialized. Then > security_socket_bind() reads the IP address bytes, including the > uninitialized ones, to determine the

[PATCH v4 2/5] staging: lustre: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++-- 1 file

[PATCH v4 2/5] staging: lustre: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v4 4/5] staging: rts5208: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rts5208/rtsx_transport.c | 3 +-- 1 file

[PATCH v4 4/5] staging: rts5208: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rts5208/rtsx_transport.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH v4 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rtl8712/rtl8712_recv.c | 11 +-- 1 file

[PATCH v4 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rtl8712/rtl8712_recv.c | 11 +-- 1 file changed, 5 insertions(+),

<    1   2   3   4   5   6   7   8   9   10   >