Re: [Outreachy kernel] [PATCH 3/3] staging: comedi: Replace "is is" with "is"

2017-03-04 Thread Julia Lawall
On Sat, 4 Mar 2017, simran singhal wrote: > This patch replace "is is " with "is". The replacement couldn't be > automated because sometimes the first "is" was meant to be another > word. > > Signed-off-by: simran singhal Acked-by: Julia Lawall

Re: [Outreachy kernel] [PATCH 3/3] staging: comedi: Replace "is is" with "is"

2017-03-04 Thread Julia Lawall
On Sat, 4 Mar 2017, simran singhal wrote: > This patch replace "is is " with "is". The replacement couldn't be > automated because sometimes the first "is" was meant to be another > word. > > Signed-off-by: simran singhal Acked-by: Julia Lawall > --- >

Re: [Outreachy kernel] [PATCH 2/3] staging: greybus: Replace "is is" with "is"

2017-03-04 Thread Julia Lawall
On Sat, 4 Mar 2017, simran singhal wrote: > This patch replace "is is " with "is". The replacement couldn't be > automated because sometimes the first "is" was meant to be another > word. > > Signed-off-by: simran singhal Acked-by: Julia Lawall

Re: [Outreachy kernel] [PATCH 2/3] staging: greybus: Replace "is is" with "is"

2017-03-04 Thread Julia Lawall
On Sat, 4 Mar 2017, simran singhal wrote: > This patch replace "is is " with "is". The replacement couldn't be > automated because sometimes the first "is" was meant to be another > word. > > Signed-off-by: simran singhal Acked-by: Julia Lawall > --- > drivers/staging/greybus/uart.c | 2 +-

Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192u: Replace "is is" with "is"

2017-03-04 Thread Julia Lawall
On Sat, 4 Mar 2017, simran singhal wrote: > This patch replace "is is " with "is". The replacement couldn't be > automated because sometimes the first "is" was meant to be another > word. > > Signed-off-by: simran singhal > --- >

Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192u: Replace "is is" with "is"

2017-03-04 Thread Julia Lawall
On Sat, 4 Mar 2017, simran singhal wrote: > This patch replace "is is " with "is". The replacement couldn't be > automated because sometimes the first "is" was meant to be another > word. > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- > 1 file

Re: [Outreachy kernel] [PATCH 0/3] Replace "is is " with "is"

2017-03-04 Thread Julia Lawall
Joe suggested to indicate the subsystem in the subject line of the cover letter, ie staging here. How are you finding these? julia On Sat, 4 Mar 2017, simran singhal wrote: > This patch series replace "is is " with "is" in various drivers. > > simran singhal (3): > staging: rtl8192u: Replace

Re: [Outreachy kernel] [PATCH 0/3] Replace "is is " with "is"

2017-03-04 Thread Julia Lawall
Joe suggested to indicate the subsystem in the subject line of the cover letter, ie staging here. How are you finding these? julia On Sat, 4 Mar 2017, simran singhal wrote: > This patch series replace "is is " with "is" in various drivers. > > simran singhal (3): > staging: rtl8192u: Replace

[PATCH] staging: speakup: Add __printf format/arg verification, fix fallout

2017-03-04 Thread Joe Perches
Using __printf allows the compiler to verify formats and arguments. Use it and fix the single misuse found. Signed-off-by: Joe Perches --- drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/spk_priv.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff

[PATCH] staging: speakup: Add __printf format/arg verification, fix fallout

2017-03-04 Thread Joe Perches
Using __printf allows the compiler to verify formats and arguments. Use it and fix the single misuse found. Signed-off-by: Joe Perches --- drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/spk_priv.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 3/3] staging: comedi: Replace "is is" with "is"

2017-03-04 Thread simran singhal
This patch replace "is is " with "is". The replacement couldn't be automated because sometimes the first "is" was meant to be another word. Signed-off-by: simran singhal --- drivers/staging/comedi/drivers/ni_usb6501.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 3/3] staging: comedi: Replace "is is" with "is"

2017-03-04 Thread simran singhal
This patch replace "is is " with "is". The replacement couldn't be automated because sometimes the first "is" was meant to be another word. Signed-off-by: simran singhal --- drivers/staging/comedi/drivers/ni_usb6501.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/3] staging: rtl8192u: Replace "is is" with "is"

2017-03-04 Thread simran singhal
This patch replace "is is " with "is". The replacement couldn't be automated because sometimes the first "is" was meant to be another word. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/3] staging: rtl8192u: Replace "is is" with "is"

2017-03-04 Thread simran singhal
This patch replace "is is " with "is". The replacement couldn't be automated because sometimes the first "is" was meant to be another word. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/3] Replace "is is " with "is"

2017-03-04 Thread simran singhal
This patch series replace "is is " with "is" in various drivers. simran singhal (3): staging: rtl8192u: Replace "is is" with "is" staging: greybus: Replace "is is" with "is" staging: comedi: Replace "is is" with "is" drivers/staging/comedi/drivers/ni_usb6501.c | 2 +-

[PATCH 0/3] Replace "is is " with "is"

2017-03-04 Thread simran singhal
This patch series replace "is is " with "is" in various drivers. simran singhal (3): staging: rtl8192u: Replace "is is" with "is" staging: greybus: Replace "is is" with "is" staging: comedi: Replace "is is" with "is" drivers/staging/comedi/drivers/ni_usb6501.c | 2 +-

[PATCH 2/3] staging: greybus: Replace "is is" with "is"

2017-03-04 Thread simran singhal
This patch replace "is is " with "is". The replacement couldn't be automated because sometimes the first "is" was meant to be another word. Signed-off-by: simran singhal --- drivers/staging/greybus/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/3] staging: greybus: Replace "is is" with "is"

2017-03-04 Thread simran singhal
This patch replace "is is " with "is". The replacement couldn't be automated because sometimes the first "is" was meant to be another word. Signed-off-by: simran singhal --- drivers/staging/greybus/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH RFC 04/14] block, bfq: modify the peak-rate estimator

2017-03-04 Thread Paolo Valente
Unless the maximum budget B_max that BFQ can assign to a queue is set explicitly by the user, BFQ automatically updates B_max. In particular, BFQ dynamically sets B_max to the number of sectors that can be read, at the current estimated peak rate, during the maximum time, T_max, allowed before a

[PATCH RFC 04/14] block, bfq: modify the peak-rate estimator

2017-03-04 Thread Paolo Valente
Unless the maximum budget B_max that BFQ can assign to a queue is set explicitly by the user, BFQ automatically updates B_max. In particular, BFQ dynamically sets B_max to the number of sectors that can be read, at the current estimated peak rate, during the maximum time, T_max, allowed before a

[PATCH RFC 02/14] block, bfq: add full hierarchical scheduling and cgroups support

2017-03-04 Thread Paolo Valente
From: Arianna Avanzini Add complete support for full hierarchical scheduling, with a cgroups interface. Full hierarchical scheduling is implemented through the 'entity' abstraction: both bfq_queues, i.e., the internal BFQ queues associated with processes, and groups

[PATCH RFC 02/14] block, bfq: add full hierarchical scheduling and cgroups support

2017-03-04 Thread Paolo Valente
From: Arianna Avanzini Add complete support for full hierarchical scheduling, with a cgroups interface. Full hierarchical scheduling is implemented through the 'entity' abstraction: both bfq_queues, i.e., the internal BFQ queues associated with processes, and groups are represented in general by

[PATCH RFC 05/14] block, bfq: add more fairness with writes and slow processes

2017-03-04 Thread Paolo Valente
This patch deals with two sources of unfairness, which can also cause high latencies and throughput loss. The first source is related to write requests. Write requests tend to starve read requests, basically because, on one side, writes are slower than reads, whereas, on the other side, storage

[PATCH RFC 05/14] block, bfq: add more fairness with writes and slow processes

2017-03-04 Thread Paolo Valente
This patch deals with two sources of unfairness, which can also cause high latencies and throughput loss. The first source is related to write requests. Write requests tend to starve read requests, basically because, on one side, writes are slower than reads, whereas, on the other side, storage

[PATCH RFC 09/14] block, bfq: reduce latency during request-pool saturation

2017-03-04 Thread Paolo Valente
This patch introduces an heuristic that reduces latency when the I/O-request pool is saturated. This goal is achieved by disabling device idling, for non-weight-raised queues, when there are weight- raised queues with pending or in-flight requests. In fact, as explained in more detail in the

[PATCH RFC 07/14] block, bfq: reduce I/O latency for soft real-time applications

2017-03-04 Thread Paolo Valente
To guarantee a low latency also to the I/O requests issued by soft real-time applications, this patch introduces a further heuristic, which weight-raises (in the sense explained in the previous patch) also the queues associated to applications deemed as soft real-time. To be deemed as soft

[PATCH RFC 07/14] block, bfq: reduce I/O latency for soft real-time applications

2017-03-04 Thread Paolo Valente
To guarantee a low latency also to the I/O requests issued by soft real-time applications, this patch introduces a further heuristic, which weight-raises (in the sense explained in the previous patch) also the queues associated to applications deemed as soft real-time. To be deemed as soft

[PATCH RFC 09/14] block, bfq: reduce latency during request-pool saturation

2017-03-04 Thread Paolo Valente
This patch introduces an heuristic that reduces latency when the I/O-request pool is saturated. This goal is achieved by disabling device idling, for non-weight-raised queues, when there are weight- raised queues with pending or in-flight requests. In fact, as explained in more detail in the

[PATCH RFC 14/14] block, bfq: handle bursts of queue activations

2017-03-04 Thread Paolo Valente
From: Arianna Avanzini Many popular I/O-intensive services or applications spawn or reactivate many parallel threads/processes during short time intervals. Examples are systemd during boot or git grep. These services or applications benefit mostly from a high

[PATCH RFC 10/14] block, bfq: add Early Queue Merge (EQM)

2017-03-04 Thread Paolo Valente
From: Arianna Avanzini A set of processes may happen to perform interleaved reads, i.e., read requests whose union would give rise to a sequential read pattern. There are two typical cases: first, processes reading fixed-size chunks of data at a fixed distance from

[PATCH RFC 14/14] block, bfq: handle bursts of queue activations

2017-03-04 Thread Paolo Valente
From: Arianna Avanzini Many popular I/O-intensive services or applications spawn or reactivate many parallel threads/processes during short time intervals. Examples are systemd during boot or git grep. These services or applications benefit mostly from a high throughput: the quicker the I/O

[PATCH RFC 10/14] block, bfq: add Early Queue Merge (EQM)

2017-03-04 Thread Paolo Valente
From: Arianna Avanzini A set of processes may happen to perform interleaved reads, i.e., read requests whose union would give rise to a sequential read pattern. There are two typical cases: first, processes reading fixed-size chunks of data at a fixed distance from each other; second, processes

[PATCH RFC 13/14] block, bfq: boost the throughput with random I/O on NCQ-capable HDDs

2017-03-04 Thread Paolo Valente
This patch is basically the counterpart, for NCQ-capable rotational devices, of the previous patch. Exactly as the previous patch does on flash-based devices and for any workload, this patch disables device idling on rotational devices, but only for random I/O. In fact, only with these queues

[PATCH RFC 12/14] block, bfq: boost the throughput on NCQ-capable flash-based devices

2017-03-04 Thread Paolo Valente
This patch boosts the throughput on NCQ-capable flash-based devices, while still preserving latency guarantees for interactive and soft real-time applications. The throughput is boosted by just not idling the device when the in-service queue remains empty, even if the queue is sync and has a

[PATCH RFC 13/14] block, bfq: boost the throughput with random I/O on NCQ-capable HDDs

2017-03-04 Thread Paolo Valente
This patch is basically the counterpart, for NCQ-capable rotational devices, of the previous patch. Exactly as the previous patch does on flash-based devices and for any workload, this patch disables device idling on rotational devices, but only for random I/O. In fact, only with these queues

[PATCH RFC 12/14] block, bfq: boost the throughput on NCQ-capable flash-based devices

2017-03-04 Thread Paolo Valente
This patch boosts the throughput on NCQ-capable flash-based devices, while still preserving latency guarantees for interactive and soft real-time applications. The throughput is boosted by just not idling the device when the in-service queue remains empty, even if the queue is sync and has a

[PATCH RFC 11/14] block, bfq: reduce idling only in symmetric scenarios

2017-03-04 Thread Paolo Valente
From: Arianna Avanzini A seeky queue (i..e, a queue containing random requests) is assigned a very small device-idling slice, for throughput issues. Unfortunately, given the process associated with a seeky queue, this behavior causes the following problem: if the

[PATCH RFC 11/14] block, bfq: reduce idling only in symmetric scenarios

2017-03-04 Thread Paolo Valente
From: Arianna Avanzini A seeky queue (i..e, a queue containing random requests) is assigned a very small device-idling slice, for throughput issues. Unfortunately, given the process associated with a seeky queue, this behavior causes the following problem: if the process, say P, performs sync

Re: [PATCH 1/4] watchdog: sama5d4: fix WDDIS handling

2017-03-04 Thread Guenter Roeck
On 03/02/2017 09:31 AM, Alexandre Belloni wrote: The datasheet states: "When setting the WDDIS bit, and while it is set, the fields WDV and WDD must not be modified." Because the whole configuration is already cached inside .mr, wait for the user to enable the watchdog to configure it so it is

Re: [PATCH v5 0/5] Remove unnecessary cast on void pointer

2017-03-04 Thread SIMRAN SINGHAL
On Sat, Mar 4, 2017 at 9:22 PM, Joe Perches wrote: > On Sat, 2017-03-04 at 21:00 +0530, simran singhal wrote: >> This patch-series removes unnecessary cast on void pointer in various >> drivers. > > Much better, thanks. > > Trivia: (and it's probably not necessary to resend) > >

Re: [PATCH 1/4] watchdog: sama5d4: fix WDDIS handling

2017-03-04 Thread Guenter Roeck
On 03/02/2017 09:31 AM, Alexandre Belloni wrote: The datasheet states: "When setting the WDDIS bit, and while it is set, the fields WDV and WDD must not be modified." Because the whole configuration is already cached inside .mr, wait for the user to enable the watchdog to configure it so it is

Re: [PATCH v5 0/5] Remove unnecessary cast on void pointer

2017-03-04 Thread SIMRAN SINGHAL
On Sat, Mar 4, 2017 at 9:22 PM, Joe Perches wrote: > On Sat, 2017-03-04 at 21:00 +0530, simran singhal wrote: >> This patch-series removes unnecessary cast on void pointer in various >> drivers. > > Much better, thanks. > > Trivia: (and it's probably not necessary to resend) > > The cover letter

[PATCH RFC 08/14] block, bfq: preserve a low latency also with NCQ-capable drives

2017-03-04 Thread Paolo Valente
I/O schedulers typically allow NCQ-capable drives to prefetch I/O requests, as NCQ boosts the throughput exactly by prefetching and internally reordering requests. Unfortunately, as discussed in detail and shown experimentally in [1], this may cause fairness and latency guarantees to be violated.

[PATCH RFC 08/14] block, bfq: preserve a low latency also with NCQ-capable drives

2017-03-04 Thread Paolo Valente
I/O schedulers typically allow NCQ-capable drives to prefetch I/O requests, as NCQ boosts the throughput exactly by prefetching and internally reordering requests. Unfortunately, as discussed in detail and shown experimentally in [1], this may cause fairness and latency guarantees to be violated.

Re: Microphone gain on N900

2017-03-04 Thread Jarkko Nikula
On 03/02/17 16:28, Pavel Machek wrote: > Hi! > v4.10 works quite nicely on N900, but I still have problems with audio. Even GSM calls would be usable, if I had reasonable volume on microphone and speaker... but I don't. Both speaker and microphone are too quiet. I can get

Re: Microphone gain on N900

2017-03-04 Thread Jarkko Nikula
On 03/02/17 16:28, Pavel Machek wrote: > Hi! > v4.10 works quite nicely on N900, but I still have problems with audio. Even GSM calls would be usable, if I had reasonable volume on microphone and speaker... but I don't. Both speaker and microphone are too quiet. I can get

[PATCH RFC 00/14] Add the BFQ I/O Scheduler to blk-mq

2017-03-04 Thread Paolo Valente
Hi, at last, here is my first patch series meant for merging. It adds BFQ to blk-mq. Don't worry, in this message I won't bore you again with the wonderful properties of BFQ :) A quick update on the status of the code: thanks to Murphy's laws, in the last handful of days, 1) A kind of rare

[PATCH RFC 00/14] Add the BFQ I/O Scheduler to blk-mq

2017-03-04 Thread Paolo Valente
Hi, at last, here is my first patch series meant for merging. It adds BFQ to blk-mq. Don't worry, in this message I won't bore you again with the wonderful properties of BFQ :) A quick update on the status of the code: thanks to Murphy's laws, in the last handful of days, 1) A kind of rare

[PATCH RFC 06/14] block, bfq: improve responsiveness

2017-03-04 Thread Paolo Valente
This patch introduces a simple heuristic to load applications quickly, and to perform the I/O requested by interactive applications just as quickly. To this purpose, both a newly-created queue and a queue associated with an interactive application (we explain in a moment how BFQ decides whether

[PATCH RFC 06/14] block, bfq: improve responsiveness

2017-03-04 Thread Paolo Valente
This patch introduces a simple heuristic to load applications quickly, and to perform the I/O requested by interactive applications just as quickly. To this purpose, both a newly-created queue and a queue associated with an interactive application (we explain in a moment how BFQ decides whether

[PATCH RFC 03/14] block, bfq: improve throughput boosting

2017-03-04 Thread Paolo Valente
The feedback-loop algorithm used by BFQ to compute queue (process) budgets is basically a set of three update rules, one for each of the main reasons why a queue may be expired. If many processes suddenly switch from sporadic I/O to greedy and sequential I/O, then these rules are quite slow to

[PATCH RFC 03/14] block, bfq: improve throughput boosting

2017-03-04 Thread Paolo Valente
The feedback-loop algorithm used by BFQ to compute queue (process) budgets is basically a set of three update rules, one for each of the main reasons why a queue may be expired. If many processes suddenly switch from sporadic I/O to greedy and sequential I/O, then these rules are quite slow to

[PATCH v5 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-04 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rtl8712/rtl8712_recv.c | 11 +-- 1 file

[PATCH v5 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-04 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rtl8712/rtl8712_recv.c | 11 +-- 1 file changed, 5 insertions(+),

rcu: WARNING in rcu_seq_end

2017-03-04 Thread Dmitry Vyukov
Hello, Paul, you wanted bugs in rcu. I've got this WARNING while running syzkaller fuzzer on 86292b33d4b79ee03e2f43ea0381ef85f077c760: [ cut here ] WARNING: CPU: 0 PID: 4832 at kernel/rcu/tree.c:3533 rcu_seq_end+0x110/0x140 kernel/rcu/tree.c:3533 Kernel panic - not

rcu: WARNING in rcu_seq_end

2017-03-04 Thread Dmitry Vyukov
Hello, Paul, you wanted bugs in rcu. I've got this WARNING while running syzkaller fuzzer on 86292b33d4b79ee03e2f43ea0381ef85f077c760: [ cut here ] WARNING: CPU: 0 PID: 4832 at kernel/rcu/tree.c:3533 rcu_seq_end+0x110/0x140 kernel/rcu/tree.c:3533 Kernel panic - not

[PATCH v5 1/5] staging: nvec: Remove unnecessary cast on void pointer

2017-03-04 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/nvec/nvec_kbd.c | 2 +- 1 file changed, 1

[PATCH v5 1/5] staging: nvec: Remove unnecessary cast on void pointer

2017-03-04 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/nvec/nvec_kbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 4/6] staging: wilc1000: Alignment should match open parenthesis

2017-03-04 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_spi.c | 2 +-

[PATCH 5/6] staging: wilc1000: function prototype argument should have identifier name

2017-03-04 Thread Arushi Singhal
function prototype argument should have an identifier name as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/wilc1000/wilc_wlan.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 4/6] staging: wilc1000: Alignment should match open parenthesis

2017-03-04 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_spi.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 16

[PATCH 5/6] staging: wilc1000: function prototype argument should have identifier name

2017-03-04 Thread Arushi Singhal
function prototype argument should have an identifier name as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/wilc1000/wilc_wlan.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.h

[PATCH 2/6] staging: speakup: Avoid multiple assignments on same line

2017-03-04 Thread Arushi Singhal
This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/main.c

[PATCH 2/6] staging: speakup: Avoid multiple assignments on same line

2017-03-04 Thread Arushi Singhal
This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index

[PATCH 3/6] staging: speakup: identation should use tabs

2017-03-04 Thread Arushi Singhal
Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_decpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_decpc.c

[PATCH 3/6] staging: speakup: identation should use tabs

2017-03-04 Thread Arushi Singhal
Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_decpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c index

[PATCH 1/6] staging: speakup: fixes braces {} should be used on all arms of this statement

2017-03-04 Thread Arushi Singhal
This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- drivers/staging/speakup/speakup_decext.c | 6 +++---

[PATCH 1/6] staging: speakup: fixes braces {} should be used on all arms of this statement

2017-03-04 Thread Arushi Singhal
This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- drivers/staging/speakup/speakup_decext.c | 6 +++--- drivers/staging/speakup/speakup_decpc.c |

[PATCH 6/6] staging: wilc1000: Logical continuations should be on the previous line

2017-03-04 Thread Arushi Singhal
This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/wilc1000/wilc_spi.c | 4 ++-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 ++--

[PATCH 6/6] staging: wilc1000: Logical continuations should be on the previous line

2017-03-04 Thread Arushi Singhal
This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/wilc1000/wilc_spi.c | 4 ++-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 ++-- 2 files changed, 8

[PATCH 0/6] multiple checkpatch issues

2017-03-04 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues. Arushi Singhal (6): staging: speakup: fixes braces {} should be used on all arms of this statement staging: speakup: Avoid multiple assignments on same line staging: speakup: identation should use tabs staging: wilc1000:

[PATCH 0/6] multiple checkpatch issues

2017-03-04 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues. Arushi Singhal (6): staging: speakup: fixes braces {} should be used on all arms of this statement staging: speakup: Avoid multiple assignments on same line staging: speakup: identation should use tabs staging: wilc1000:

[PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

2017-03-04 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- v5: -Fixed compilation warnings.

[PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

2017-03-04 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- v5: -Fixed compilation warnings. drivers/staging/lustre/lustre/llite/range_lock.c |

Re: [PATCH v5 0/5] Remove unnecessary cast on void pointer

2017-03-04 Thread Joe Perches
On Sat, 2017-03-04 at 21:00 +0530, simran singhal wrote: > This patch-series removes unnecessary cast on void pointer in various > drivers. Much better, thanks. Trivia: (and it's probably not necessary to resend) The cover letter should describe the subsystem being changed or ideally something

Re: [PATCH v5 0/5] Remove unnecessary cast on void pointer

2017-03-04 Thread Joe Perches
On Sat, 2017-03-04 at 21:00 +0530, simran singhal wrote: > This patch-series removes unnecessary cast on void pointer in various > drivers. Much better, thanks. Trivia: (and it's probably not necessary to resend) The cover letter should describe the subsystem being changed or ideally something

Re: [Outreachy kernel] [PATCH v5 0/5] Remove unnecessary cast on void pointer

2017-03-04 Thread Julia Lawall
On Sat, 4 Mar 2017, simran singhal wrote: > This patch-series removes unnecessary cast on void pointer in various > drivers. > > v5: > -Fixed compliation warning in lustre/lustre/llite/range_lock.c >which remain unfixed in v3. Acked-by: Julia Lawall for the whole

Re: [Outreachy kernel] [PATCH v5 0/5] Remove unnecessary cast on void pointer

2017-03-04 Thread Julia Lawall
On Sat, 4 Mar 2017, simran singhal wrote: > This patch-series removes unnecessary cast on void pointer in various > drivers. > > v5: > -Fixed compliation warning in lustre/lustre/llite/range_lock.c >which remain unfixed in v3. Acked-by: Julia Lawall for the whole series. > v4: >

[PATCH v5 0/5] Remove unnecessary cast on void pointer

2017-03-04 Thread simran singhal
This patch-series removes unnecessary cast on void pointer in various drivers. v5: -Fixed compliation warning in lustre/lustre/llite/range_lock.c which remain unfixed in v3. v4: -change the cover-letter subject v3: -Fixed compilation warning in lustre/lustre/llite/range_lock.c

[PATCH v5 0/5] Remove unnecessary cast on void pointer

2017-03-04 Thread simran singhal
This patch-series removes unnecessary cast on void pointer in various drivers. v5: -Fixed compliation warning in lustre/lustre/llite/range_lock.c which remain unfixed in v3. v4: -change the cover-letter subject v3: -Fixed compilation warning in lustre/lustre/llite/range_lock.c

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-03-04 Thread Sakari Ailus
On Sat, Mar 04, 2017 at 03:03:18PM +0200, Sakari Ailus wrote: > Hi Pavel, > > On Thu, Mar 02, 2017 at 01:38:48PM +0100, Pavel Machek wrote: > > Hi! > > > > > > Ok, how about this one? > > > > omap3isp: add rest of CSI1 support > > > > > > > > CSI1 needs one more bit to be set up. Do just

Re: [PATCHv2] omap3isp: add support for CSI1 bus

2017-03-04 Thread Sakari Ailus
On Sat, Mar 04, 2017 at 03:03:18PM +0200, Sakari Ailus wrote: > Hi Pavel, > > On Thu, Mar 02, 2017 at 01:38:48PM +0100, Pavel Machek wrote: > > Hi! > > > > > > Ok, how about this one? > > > > omap3isp: add rest of CSI1 support > > > > > > > > CSI1 needs one more bit to be set up. Do just

[PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void pointer

2017-03-04 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++-- 1 file

[PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void pointer

2017-03-04 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-04 Thread Geert Uytterhoeven
Hi Uwe, On Fri, Mar 3, 2017 at 8:44 PM, Uwe Kleine-König wrote: > On Fri, Mar 03, 2017 at 08:21:05PM +0100, Geert Uytterhoeven wrote: >> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c >> > index 91e7dddbf72c..2f4cdd4e7b4f 100644 >> > ---

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-04 Thread Geert Uytterhoeven
Hi Uwe, On Fri, Mar 3, 2017 at 8:44 PM, Uwe Kleine-König wrote: > On Fri, Mar 03, 2017 at 08:21:05PM +0100, Geert Uytterhoeven wrote: >> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c >> > index 91e7dddbf72c..2f4cdd4e7b4f 100644 >> > --- a/drivers/tty/serial/sh-sci.c >>

Re: [PATCH] omap3isp: wait for regulators to come up

2017-03-04 Thread Sakari Ailus
On Thu, Mar 02, 2017 at 04:46:42PM +0200, Laurent Pinchart wrote: > Hi Pavel, > > Thank you for the patch. > > On Thursday 02 Mar 2017 13:45:32 Pavel Machek wrote: > > If regulator returns -EPROBE_DEFER, we need to return it too, so that > > omap3isp will be re-probed when regulator is ready. >

Re: [PATCH] omap3isp: wait for regulators to come up

2017-03-04 Thread Sakari Ailus
On Thu, Mar 02, 2017 at 04:46:42PM +0200, Laurent Pinchart wrote: > Hi Pavel, > > Thank you for the patch. > > On Thursday 02 Mar 2017 13:45:32 Pavel Machek wrote: > > If regulator returns -EPROBE_DEFER, we need to return it too, so that > > omap3isp will be re-probed when regulator is ready. >

[PATCH] net: sun: cassini: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sun/cassini.c | 98

[PATCH] net: sun: cassini: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sun/cassini.c | 98

Re: [media] omap3isp: Correctly set IO_OUT_SEL and VP_CLK_POL for CCP2 mode

2017-03-04 Thread Sakari Ailus
On Wed, Mar 01, 2017 at 12:45:46PM +0100, Pavel Machek wrote: > ISP CSI1 module needs all the bits correctly set to work. > > Signed-off-by: Ivaylo Dimitrov > Signed-off-by: Pavel Machek > How are you sending the patches? I've applied this to the

Re: [media] omap3isp: Correctly set IO_OUT_SEL and VP_CLK_POL for CCP2 mode

2017-03-04 Thread Sakari Ailus
On Wed, Mar 01, 2017 at 12:45:46PM +0100, Pavel Machek wrote: > ISP CSI1 module needs all the bits correctly set to work. > > Signed-off-by: Ivaylo Dimitrov > Signed-off-by: Pavel Machek > How are you sending the patches? I've applied this to the ccp2 branch. -- Sakari Ailus e-mail:

Re: [Patch 0/2] media: ti-vpe: allow user specified stride

2017-03-04 Thread Benoit Parrot
Hans, Mauro, Ping. Regards, Benoit Tomi Valkeinen wrote on Fri [2017-Feb-17 11:45:41 +0200]: > On 13/02/17 15:06, Benoit Parrot wrote: > > This patch series enables user specified buffer stride to be used > > instead of always forcing the stride from the driver side. >

Re: [Patch 0/2] media: ti-vpe: allow user specified stride

2017-03-04 Thread Benoit Parrot
Hans, Mauro, Ping. Regards, Benoit Tomi Valkeinen wrote on Fri [2017-Feb-17 11:45:41 +0200]: > On 13/02/17 15:06, Benoit Parrot wrote: > > This patch series enables user specified buffer stride to be used > > instead of always forcing the stride from the driver side. > > > > Benoit Parrot

[PULL] A handful of docs fixes

2017-03-04 Thread Jonathan Corbet
The following changes since commit bd8562626c8e170691d6457fe4e8dfb45607a48d: docs / driver-api: Fix structure references in device_link.rst (2017-02-20 16:40:46 -0700) are available in the git repository at: git://git.lwn.net/linux.git tags/docs-4.11-fixes for you to fetch changes up to

[PULL] A handful of docs fixes

2017-03-04 Thread Jonathan Corbet
The following changes since commit bd8562626c8e170691d6457fe4e8dfb45607a48d: docs / driver-api: Fix structure references in device_link.rst (2017-02-20 16:40:46 -0700) are available in the git repository at: git://git.lwn.net/linux.git tags/docs-4.11-fixes for you to fetch changes up to

Re: [PATCH 4/4] watchdog: sama5d4: Add comment explaining what happens on resume

2017-03-04 Thread Guenter Roeck
On 03/02/2017 09:31 AM, Alexandre Belloni wrote: Because suspending to RAM may lose the register values, they are restored on resume. This is currently done unconditionally because there is currently no way to know (from the driver) whether they have really been lost or are still valid. Writing

Re: [PATCH 4/4] watchdog: sama5d4: Add comment explaining what happens on resume

2017-03-04 Thread Guenter Roeck
On 03/02/2017 09:31 AM, Alexandre Belloni wrote: Because suspending to RAM may lose the register values, they are restored on resume. This is currently done unconditionally because there is currently no way to know (from the driver) whether they have really been lost or are still valid. Writing

Re: [PATCH 2/4] watchdog: sama5d4: fix race condition

2017-03-04 Thread Guenter Roeck
On 03/02/2017 09:31 AM, Alexandre Belloni wrote: WDT_MR and WDT_CR must not updated within three slow clock periods after the last ping (write to WDT_CR or WDT_MR). Ensure enough time has elapsed before writing those registers. wdt_write() waits for 4 periods to ensure at least 3 edges are seen

Re: [PATCH 2/4] watchdog: sama5d4: fix race condition

2017-03-04 Thread Guenter Roeck
On 03/02/2017 09:31 AM, Alexandre Belloni wrote: WDT_MR and WDT_CR must not updated within three slow clock periods after the last ping (write to WDT_CR or WDT_MR). Ensure enough time has elapsed before writing those registers. wdt_write() waits for 4 periods to ensure at least 3 edges are seen

<    1   2   3   4   5   6   >