out of range LBA using sg_raw

Hi - Need help to understand if below is something we should consider to be fixed in megaraid_sas driver or call as unreal exposure. I have created slice VD of size 10GB (raid 1) using 2 drives. Each Physical Drive size is 256GB. Last LBA of the VD and actual Physical disk associated with

Re: [PATCH 09/26] IB/ocrdma: Improve another size determination in ocrdma_mq_cq_handler()

On Wed, Mar 08, 2017 at 02:00:56PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 20:20:45 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the

out of range LBA using sg_raw

Hi - Need help to understand if below is something we should consider to be fixed in megaraid_sas driver or call as unreal exposure. I have created slice VD of size 10GB (raid 1) using 2 drives. Each Physical Drive size is 256GB. Last LBA of the VD and actual Physical disk associated with

Re: [PATCH 09/26] IB/ocrdma: Improve another size determination in ocrdma_mq_cq_handler()

On Wed, Mar 08, 2017 at 02:00:56PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 20:20:45 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination

Re: [PATCH] ideapad-laptop: Add Lenovo ideapad 310-15IKB to no_hw_rfkill dmi list

On Tue, Feb 21, 2017 at 9:53 PM, Sven Rebhan wrote: > Like other Lenovo models the Lenovo ideapad 310-15IKB does not have a > hw rfkill switch. This results in hard-blocked radios after boot, > resulting in always blocked radios rendering them unusable. > > The attached

Re: [PATCH] ideapad-laptop: Add Lenovo ideapad 310-15IKB to no_hw_rfkill dmi list

On Tue, Feb 21, 2017 at 9:53 PM, Sven Rebhan wrote: > Like other Lenovo models the Lenovo ideapad 310-15IKB does not have a > hw rfkill switch. This results in hard-blocked radios after boot, > resulting in always blocked radios rendering them unusable. > > The attached patch adds the ideapad

Re: [PATCH 1/4] s390: get rid of superfluous __GFP_REPEAT

On Wed 08-03-17 09:23:40, Heiko Carstens wrote: > On Tue, Mar 07, 2017 at 04:48:40PM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > __GFP_REPEAT has a rather weak semantic but since it has been introduced > > around 2.6.12 it has been ignored for low order

Re: [PATCH 1/4] s390: get rid of superfluous __GFP_REPEAT

On Wed 08-03-17 09:23:40, Heiko Carstens wrote: > On Tue, Mar 07, 2017 at 04:48:40PM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > __GFP_REPEAT has a rather weak semantic but since it has been introduced > > around 2.6.12 it has been ignored for low order allocations. > > > >

[PATCH v2] HID: remove initial reading of reports at connect

It looks like a bunch of devices do not like to be polled for their reports at init time. When you look into the details, it seems that for those that are requiring the quirk HID_QUIRK_NO_INIT_REPORTS, the driver fails to retrieve part of the features/inputs while others (more generic) work. IMO,

[PATCH v2] HID: remove initial reading of reports at connect

It looks like a bunch of devices do not like to be polled for their reports at init time. When you look into the details, it seems that for those that are requiring the quirk HID_QUIRK_NO_INIT_REPORTS, the driver fails to retrieve part of the features/inputs while others (more generic) work. IMO,

Re: [PATCH 07/26] IB/ocrdma: Improve another size determination in ocrdma_mbx_get_ctrl_attribs()

On Wed, Mar 08, 2017 at 01:55:59PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 20:07:25 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the

Re: [PATCH 07/26] IB/ocrdma: Improve another size determination in ocrdma_mbx_get_ctrl_attribs()

On Wed, Mar 08, 2017 at 01:55:59PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 20:07:25 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination

[PATCH 17/26] IB/ocrdma: Use kmalloc_array() in ocrdma_create_srq()

From: Markus Elfring Date: Wed, 8 Mar 2017 08:45:31 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was

[PATCH 17/26] IB/ocrdma: Use kmalloc_array() in ocrdma_create_srq()

From: Markus Elfring Date: Wed, 8 Mar 2017 08:45:31 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle

Re: [PATCH 05/26] IB/ocrdma: Improve another size determination in ocrdma_mbx_query_qp()

On Wed, Mar 08, 2017 at 01:50:59PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 19:40:31 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the

Re: [PATCH 05/26] IB/ocrdma: Improve another size determination in ocrdma_mbx_query_qp()

On Wed, Mar 08, 2017 at 01:50:59PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 19:40:31 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination

Re: [PATCH 04/26] IB/ocrdma: Delete unnecessary variable initialisations in ocrdma_mbx_get_dcbx_config()

On Wed, Mar 08, 2017 at 01:48:46PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 19:25:55 +0100 > > The local variables "req" and "rsp" will be set to appropriate pointers > a bit later. Thus omit the explicit initialisations at the

Re: [PATCH 04/26] IB/ocrdma: Delete unnecessary variable initialisations in ocrdma_mbx_get_dcbx_config()

On Wed, Mar 08, 2017 at 01:48:46PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 19:25:55 +0100 > > The local variables "req" and "rsp" will be set to appropriate pointers > a bit later. Thus omit the explicit initialisations at the beginning. > > Signed-off-by:

[PATCH 2/2] usb: gadget: f_uvc: Sanity check wMaxPacketSize for SuperSpeed

As per USB3.0 Specification "Table 9-20. Standard Endpoint Descriptor", for interrupt and isochronous endpoints, wMaxPacketSize must be set to 1024 if the endpoint defines bMaxBurst to be greater than zero. Signed-off-by: Roger Quadros --- drivers/usb/gadget/function/f_uvc.c | 8

[PATCH 0/2] usb: gadget: f_uvc: SuperSpeed fixes

Hi Laurent & Felipe, These are some fixes for SuperSpeed case. -- cheers, -roger Roger Quadros (2): usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval usb: gadget: f_uvc: Sanity check wMaxPacketSize for SuperSpeed drivers/usb/gadget/function/f_uvc.c | 10

[PATCH 2/2] usb: gadget: f_uvc: Sanity check wMaxPacketSize for SuperSpeed

As per USB3.0 Specification "Table 9-20. Standard Endpoint Descriptor", for interrupt and isochronous endpoints, wMaxPacketSize must be set to 1024 if the endpoint defines bMaxBurst to be greater than zero. Signed-off-by: Roger Quadros --- drivers/usb/gadget/function/f_uvc.c | 8 1

[PATCH 0/2] usb: gadget: f_uvc: SuperSpeed fixes

Hi Laurent & Felipe, These are some fixes for SuperSpeed case. -- cheers, -roger Roger Quadros (2): usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval usb: gadget: f_uvc: Sanity check wMaxPacketSize for SuperSpeed drivers/usb/gadget/function/f_uvc.c | 10

Re: [PATCH 2/2] reset: simple: read back to make sure changes are applied

Hi, On 08/03/17 09:54, Philipp Zabel wrote: > Read back the register after setting or clearing a reset bit to make > sure that the changes are applied to the reset controller hardware. > Theoretically, this avoids the write to stay stuck in a store buffer > during the delay of an

Re: [PATCH 2/2] reset: simple: read back to make sure changes are applied

Hi, On 08/03/17 09:54, Philipp Zabel wrote: > Read back the register after setting or clearing a reset bit to make > sure that the changes are applied to the reset controller hardware. > Theoretically, this avoids the write to stay stuck in a store buffer > during the delay of an

RE: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

> On 03/06/2017 09:21 AM, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > > >

RE: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

> On 03/06/2017 09:21 AM, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > > >

Re: [PATCH 02/26] IB/ocrdma: Use kcalloc() in ocrdma_mbx_alloc_pd_range()

On Wed, Mar 08, 2017 at 01:41:00PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 18:23:54 +0100 > > * Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. >

Re: [PATCH 02/26] IB/ocrdma: Use kcalloc() in ocrdma_mbx_alloc_pd_range()

On Wed, Mar 08, 2017 at 01:41:00PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 18:23:54 +0100 > > * Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. > Thus reuse the corresponding

Re: [PATCH] virtio-pci: Remove affinity hint before freeing the interrupt

On Wed, Mar 08 2017 at 1:28:13 pm GMT, "Michael S. Tsirkin" wrote: > On Wed, Mar 08, 2017 at 08:09:27AM +, Marc Zyngier wrote: >> virtio-pci registers a per-vq affinity hint when using MSIX, >> but fails to remove it when freeing the interrupt, resulting >> in this type of

Re: [PATCH] virtio-pci: Remove affinity hint before freeing the interrupt

On Wed, Mar 08 2017 at 1:28:13 pm GMT, "Michael S. Tsirkin" wrote: > On Wed, Mar 08, 2017 at 08:09:27AM +, Marc Zyngier wrote: >> virtio-pci registers a per-vq affinity hint when using MSIX, >> but fails to remove it when freeing the interrupt, resulting >> in this type of splat: >> >> [

[PATCH 21/26] IB/ocrdma: Improve another size determination in ocrdma_create_srq()

From: Markus Elfring Date: Wed, 8 Mar 2017 10:10:50 +0100 Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 21/26] IB/ocrdma: Improve another size determination in ocrdma_create_srq()

From: Markus Elfring Date: Wed, 8 Mar 2017 10:10:50 +0100 Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On Tue, Mar 07, 2017 at 11:30:54PM +0100, Mats Karrman wrote: > > > So, both the DP controller and the USB PD phy are I2C devices, and now I > > > have to make them both > > > attach to the AM bus as well? > > The DP controller would provide the driver and the USB PD phy > > (actually, the typec

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On Tue, Mar 07, 2017 at 11:30:54PM +0100, Mats Karrman wrote: > > > So, both the DP controller and the USB PD phy are I2C devices, and now I > > > have to make them both > > > attach to the AM bus as well? > > The DP controller would provide the driver and the USB PD phy > > (actually, the typec

Re: netlink: GPF in netlink_unicast

On 2017-03-08 08:25, Richard Guy Briggs wrote: > On 2017-03-07 14:23, Paul Moore wrote: > > On Tue, Mar 7, 2017 at 1:44 PM, Paul Moore wrote: > > > On Tue, Mar 7, 2017 at 10:55 AM, Richard Guy Briggs > > > wrote: > > >> On 2017-03-07 09:29, Paul Moore

Re: netlink: GPF in netlink_unicast

On 2017-03-08 08:25, Richard Guy Briggs wrote: > On 2017-03-07 14:23, Paul Moore wrote: > > On Tue, Mar 7, 2017 at 1:44 PM, Paul Moore wrote: > > > On Tue, Mar 7, 2017 at 10:55 AM, Richard Guy Briggs > > > wrote: > > >> On 2017-03-07 09:29, Paul Moore wrote: > > >>> On Mon, Mar 6, 2017 at 11:03

Re: [PATCH v3 09/09] iommu/ipmmu-vmsa: Hook up r8a7795 DT matching code

Hi Magnus, On Wed, Mar 8, 2017 at 12:02 PM, Magnus Damm wrote: > From: Magnus Damm > > Tie in r8a7795 features and update the IOMMU_OF_DECLARE > compat string to include the updated compat string. > > TODO: > - Consider making use of

Re: [PATCH v3 09/09] iommu/ipmmu-vmsa: Hook up r8a7795 DT matching code

Hi Magnus, On Wed, Mar 8, 2017 at 12:02 PM, Magnus Damm wrote: > From: Magnus Damm > > Tie in r8a7795 features and update the IOMMU_OF_DECLARE > compat string to include the updated compat string. > > TODO: > - Consider making use of iommu_fwspec_add_ids() for uTLB handling > Needed to

Re: [PATCH 5/7] xen/9pfs: send requests to the backend

>>> +} >>> + >>> +static int p9_xen_write_todo(struct xen_9pfs_dataring *ring, RING_IDX size) >>> +{ >>> + RING_IDX cons, prod; >>> + >>> + cons = ring->intf->out_cons; >>> + prod = ring->intf->out_prod; >>> + mb(); >>> + >>> + if (XEN_9PFS_RING_SIZE - xen_9pfs_queued(prod, cons, >>>

Re: [PATCH 5/7] xen/9pfs: send requests to the backend

>>> +} >>> + >>> +static int p9_xen_write_todo(struct xen_9pfs_dataring *ring, RING_IDX size) >>> +{ >>> + RING_IDX cons, prod; >>> + >>> + cons = ring->intf->out_cons; >>> + prod = ring->intf->out_prod; >>> + mb(); >>> + >>> + if (XEN_9PFS_RING_SIZE - xen_9pfs_queued(prod, cons, >>>

Re: netlink: GPF in netlink_unicast

On Wed, Mar 8, 2017 at 8:25 AM, Richard Guy Briggs wrote: > On 2017-03-07 14:23, Paul Moore wrote: >> On Tue, Mar 7, 2017 at 1:44 PM, Paul Moore wrote: >> > On Tue, Mar 7, 2017 at 10:55 AM, Richard Guy Briggs >> > wrote: >> >> On

Re: [PATCH 6/7] mm: convert generic code to 5-level paging

On Mon 06-03-17 23:45:13, Kirill A. Shutemov wrote: > Convert all non-architecture-specific code to 5-level paging. > > It's mostly mechanical adding handling one more page table level in > places where we deal with pud_t. > > Signed-off-by: Kirill A. Shutemov

Re: netlink: GPF in netlink_unicast

On Wed, Mar 8, 2017 at 8:25 AM, Richard Guy Briggs wrote: > On 2017-03-07 14:23, Paul Moore wrote: >> On Tue, Mar 7, 2017 at 1:44 PM, Paul Moore wrote: >> > On Tue, Mar 7, 2017 at 10:55 AM, Richard Guy Briggs >> > wrote: >> >> On 2017-03-07 09:29, Paul Moore wrote: >> >>> On Mon, Mar 6, 2017

Re: [PATCH 6/7] mm: convert generic code to 5-level paging

On Mon 06-03-17 23:45:13, Kirill A. Shutemov wrote: > Convert all non-architecture-specific code to 5-level paging. > > It's mostly mechanical adding handling one more page table level in > places where we deal with pud_t. > > Signed-off-by: Kirill A. Shutemov OK, I haven't spotted anything

Re: [PATCH v3 04/09] iommu/ipmmu-vmsa: Make use of IOMMU_OF_DECLARE()

Hi Magnus, On Wed, Mar 8, 2017 at 12:02 PM, Magnus Damm wrote: > From: Magnus Damm > > Hook up IOMMU_OF_DECLARE() support in case CONFIG_IOMMU_DMA > is enabled. The only current supported case for 32-bit ARM > is disabled, however for 64-bit

Re: [PATCH v3 04/09] iommu/ipmmu-vmsa: Make use of IOMMU_OF_DECLARE()

Hi Magnus, On Wed, Mar 8, 2017 at 12:02 PM, Magnus Damm wrote: > From: Magnus Damm > > Hook up IOMMU_OF_DECLARE() support in case CONFIG_IOMMU_DMA > is enabled. The only current supported case for 32-bit ARM > is disabled, however for 64-bit ARM usage of OF is required. > > Signed-off-by:

Re: [PATCH v3 02/09] iommu/ipmmu-vmsa: Add optional root device feature

Hi Magnus, On Wed, Mar 8, 2017 at 12:01 PM, Magnus Damm wrote: > From: Magnus Damm > > Add root device handling to the IPMMU driver by allowing certain > DT compat strings to enable has_cache_leaf_nodes that in turn will > support both root

Re: [PATCH v3 02/09] iommu/ipmmu-vmsa: Add optional root device feature

Hi Magnus, On Wed, Mar 8, 2017 at 12:01 PM, Magnus Damm wrote: > From: Magnus Damm > > Add root device handling to the IPMMU driver by allowing certain > DT compat strings to enable has_cache_leaf_nodes that in turn will > support both root devices with interrupts and leaf devices that > face

RE: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

> On 03/06/2017 03:21 PM, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > >

Re: [PATCH 03/26] IB/ocrdma: Improve size determinations in ocrdma_mbx_get_dcbx_config()

On Wed, Mar 08, 2017 at 01:45:43PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 19:09:20 +0100 > > Replace the specification of data structures by references for variables > as the parameter for the operator "sizeof" to make the

RE: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

> On 03/06/2017 03:21 PM, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > >

Re: [PATCH 03/26] IB/ocrdma: Improve size determinations in ocrdma_mbx_get_dcbx_config()

On Wed, Mar 08, 2017 at 01:45:43PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 19:09:20 +0100 > > Replace the specification of data structures by references for variables > as the parameter for the operator "sizeof" to make the corresponding size >

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On Wed, Mar 08, 2017 at 06:17:50PM +0800, Baoquan He wrote: > All right, I will just update the code comment. Just back ported kaslr > to our OS product, people reviewed and found the upper boundary of kaslr > mm region is EFI_VA_START, that's not correct, it has to be corrected > firstly in

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On Wed, Mar 08, 2017 at 06:17:50PM +0800, Baoquan He wrote: > All right, I will just update the code comment. Just back ported kaslr > to our OS product, people reviewed and found the upper boundary of kaslr > mm region is EFI_VA_START, that's not correct, it has to be corrected > firstly in

Re: [PATCH 4/7] xen/9pfs: connect to the backend

> >>> + ring->bytes = (void*)__get_free_pages(GFP_KERNEL | __GFP_ZERO, >>> XEN_9PFS_RING_ORDER); >>> + if (ring->bytes == NULL) >>> + goto error; >>> + for (i = 0; i < (1 << XEN_9PFS_RING_ORDER); i++) >>> + ring->intf->ref[i] = >>>

Re: [PATCH 4/7] xen/9pfs: connect to the backend

> >>> + ring->bytes = (void*)__get_free_pages(GFP_KERNEL | __GFP_ZERO, >>> XEN_9PFS_RING_ORDER); >>> + if (ring->bytes == NULL) >>> + goto error; >>> + for (i = 0; i < (1 << XEN_9PFS_RING_ORDER); i++) >>> + ring->intf->ref[i] = >>>

Re: Kernel without RTC

On 08/03/2017 at 13:33:33 +, Hadimani, Jagadish wrote: > Hello Alexandre, > > I guess the Linux kernel uses HPET timer... > But can we can force Linux kernel to use Tsc or per core timer... > That is probably the case but your are targeting the wrong subsystem. The timekeeping is done using

Re: Kernel without RTC

On 08/03/2017 at 13:33:33 +, Hadimani, Jagadish wrote: > Hello Alexandre, > > I guess the Linux kernel uses HPET timer... > But can we can force Linux kernel to use Tsc or per core timer... > That is probably the case but your are targeting the wrong subsystem. The timekeeping is done using

Re: [PATCH] fs/9p: Compare qid.path in v9fs_test_inode

On Wed, 22 Feb 2017 02:06:29 +0200 Tuomas Tynkkynen wrote: > Commit fd2421f54423 ("fs/9p: When doing inode lookup compare qid details > and inode mode bits.") transformed v9fs_qid_iget() to use iget5_locked() > instead of iget_locked(). However, the test() callback is not

Re: [PATCH] fs/9p: Compare qid.path in v9fs_test_inode

On Wed, 22 Feb 2017 02:06:29 +0200 Tuomas Tynkkynen wrote: > Commit fd2421f54423 ("fs/9p: When doing inode lookup compare qid details > and inode mode bits.") transformed v9fs_qid_iget() to use iget5_locked() > instead of iget_locked(). However, the test() callback is not checking > fid.path at

[PATCH 25/26] IB/ocrdma: Delete unnecessary braces

From: Markus Elfring Date: Wed, 8 Mar 2017 12:36:41 +0100 Do not use curly brackets at some source code places where a single statement should be sufficient. Signed-off-by: Markus Elfring ---

[PATCH 14/26] IB/ocrdma: Improve another size determination in ocrdma_add()

From: Markus Elfring Date: Tue, 7 Mar 2017 22:12:36 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 25/26] IB/ocrdma: Delete unnecessary braces

From: Markus Elfring Date: Wed, 8 Mar 2017 12:36:41 +0100 Do not use curly brackets at some source code places where a single statement should be sufficient. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 41 +++-- 1 file changed, 16

[PATCH 14/26] IB/ocrdma: Improve another size determination in ocrdma_add()

From: Markus Elfring Date: Tue, 7 Mar 2017 22:12:36 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:

Re: [PATCH v2] livepatch: make klp_mutex proper part of API

On Wed, Mar 08, 2017 at 02:27:05PM +0100, Jiri Kosina wrote: > From: Jiri Kosina > > klp_mutex is shared between core.c and transition.c, and as such would > rather be properly located in a header so that we don't have to play > 'extern' games from .c sources. > > This also

Re: [PATCH v2] livepatch: make klp_mutex proper part of API

On Wed, Mar 08, 2017 at 02:27:05PM +0100, Jiri Kosina wrote: > From: Jiri Kosina > > klp_mutex is shared between core.c and transition.c, and as such would > rather be properly located in a header so that we don't have to play > 'extern' games from .c sources. > > This also silences sparse

Re: [PATCH v7 05/07] iommu/ipmmu-vmsa: Add new IOMMU_DOMAIN_DMA ops

On 07/03/17 03:17, Magnus Damm wrote: > From: Magnus Damm > > Introduce an alternative set of iommu_ops suitable for 64-bit ARM > as well as 32-bit ARM when CONFIG_IOMMU_DMA=y. Also adjust the > Kconfig to depend on ARM or IOMMU_DMA. Initialize the device > from

Re: [PATCH v7 05/07] iommu/ipmmu-vmsa: Add new IOMMU_DOMAIN_DMA ops

On 07/03/17 03:17, Magnus Damm wrote: > From: Magnus Damm > > Introduce an alternative set of iommu_ops suitable for 64-bit ARM > as well as 32-bit ARM when CONFIG_IOMMU_DMA=y. Also adjust the > Kconfig to depend on ARM or IOMMU_DMA. Initialize the device > from ->xlate() when

[PATCH 24/26] IB/ocrdma: One jump label less in ocrdma_alloc_ucontext_pd()

From: Markus Elfring Date: Wed, 8 Mar 2017 11:11:35 +0100 This issue was detected by using the Coccinelle software. 1. Return directly if a call of the function "_ocrdma_alloc_pd" failed. 2. Reduce the scope for the local variable "status" to one case of an if

[PATCH 24/26] IB/ocrdma: One jump label less in ocrdma_alloc_ucontext_pd()

From: Markus Elfring Date: Wed, 8 Mar 2017 11:11:35 +0100 This issue was detected by using the Coccinelle software. 1. Return directly if a call of the function "_ocrdma_alloc_pd" failed. 2. Reduce the scope for the local variable "status" to one case of an if statement. 3. Delete the jump

Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions

On Fri, 2016-11-11 at 07:08 -0500, Felix Janda wrote: > Currently, libc-compat.h detects inclusion of specific glibc headers, > and defines corresponding _UAPI_DEF_* macros, which in turn are used in > uapi headers to prevent definition of conflicting structures/constants. > There is no such

Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions

On Fri, 2016-11-11 at 07:08 -0500, Felix Janda wrote: > Currently, libc-compat.h detects inclusion of specific glibc headers, > and defines corresponding _UAPI_DEF_* macros, which in turn are used in > uapi headers to prevent definition of conflicting structures/constants. > There is no such

Re: [PATCH v2] livepatch: make klp_mutex proper part of API

On Wed, 8 Mar 2017, Jiri Kosina wrote: > From: Jiri Kosina > > klp_mutex is shared between core.c and transition.c, and as such would > rather be properly located in a header so that we don't have to play > 'extern' games from .c sources. > > This also silences sparse

Re: [PATCH v2] livepatch: make klp_mutex proper part of API

On Wed, 8 Mar 2017, Jiri Kosina wrote: > From: Jiri Kosina > > klp_mutex is shared between core.c and transition.c, and as such would > rather be properly located in a header so that we don't have to play > 'extern' games from .c sources. > > This also silences sparse warning (wrongly)

[PATCH 15/26] IB/ocrdma: Delete an error message for a failed memory allocation in ocrdma_add()

From: Markus Elfring Date: Tue, 7 Mar 2017 22:23:17 +0100 Omit an extra message for a memory allocation failure in this function. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring

[PATCH 15/26] IB/ocrdma: Delete an error message for a failed memory allocation in ocrdma_add()

From: Markus Elfring Date: Tue, 7 Mar 2017 22:23:17 +0100 Omit an extra message for a memory allocation failure in this function. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring ---

[PATCH 20/26] IB/ocrdma: Delete an unnecessary variable assignment in ocrdma_alloc_mr()

From: Markus Elfring Date: Wed, 8 Mar 2017 10:00:41 +0100 Delete an assignment for the local variable "status" in an if branch because the desired failure indication is already specified by a constant error code at the end. Signed-off-by: Markus Elfring

Re: [PATCH] virtio-pci: Remove affinity hint before freeing the interrupt

On Wed, Mar 08, 2017 at 08:09:27AM +, Marc Zyngier wrote: > virtio-pci registers a per-vq affinity hint when using MSIX, > but fails to remove it when freeing the interrupt, resulting > in this type of splat: > > [ 31.111202] WARNING: CPU: 0 PID: 2823 at kernel/irq/manage.c:1503 >

[PATCH 23/26] IB/ocrdma: Delete an unnecessary variable in ocrdma_dealloc_pd()

From: Markus Elfring Date: Wed, 8 Mar 2017 10:58:34 +0100 1. Return zero in one case directly. 2. Return the value from a call of the function "_ocrdma_dealloc_pd" without using an extra assignment for the local variable. 3. Remove the variable "status" in

[PATCH 20/26] IB/ocrdma: Delete an unnecessary variable assignment in ocrdma_alloc_mr()

From: Markus Elfring Date: Wed, 8 Mar 2017 10:00:41 +0100 Delete an assignment for the local variable "status" in an if branch because the desired failure indication is already specified by a constant error code at the end. Signed-off-by: Markus Elfring ---

Re: [PATCH] virtio-pci: Remove affinity hint before freeing the interrupt

On Wed, Mar 08, 2017 at 08:09:27AM +, Marc Zyngier wrote: > virtio-pci registers a per-vq affinity hint when using MSIX, > but fails to remove it when freeing the interrupt, resulting > in this type of splat: > > [ 31.111202] WARNING: CPU: 0 PID: 2823 at kernel/irq/manage.c:1503 >

[PATCH 23/26] IB/ocrdma: Delete an unnecessary variable in ocrdma_dealloc_pd()

From: Markus Elfring Date: Wed, 8 Mar 2017 10:58:34 +0100 1. Return zero in one case directly. 2. Return the value from a call of the function "_ocrdma_dealloc_pd" without using an extra assignment for the local variable. 3. Remove the variable "status" in this function then.

Re: Kernel without RTC

Hi, On 07/03/2017 at 00:48:18 +0530, Shah, Nehal-bakulchandra wrote: > Hi, > > Currently we are having hardware which does not have RTC. It is single > processor system. However it does have TSC timer. > > Now, how to use scheduler with only TSC as current kernel scheduler leverage > the RTC

Re: Kernel without RTC

Hi, On 07/03/2017 at 00:48:18 +0530, Shah, Nehal-bakulchandra wrote: > Hi, > > Currently we are having hardware which does not have RTC. It is single > processor system. However it does have TSC timer. > > Now, how to use scheduler with only TSC as current kernel scheduler leverage > the RTC

[PATCH v2] livepatch: make klp_mutex proper part of API

From: Jiri Kosina klp_mutex is shared between core.c and transition.c, and as such would rather be properly located in a header so that we don't have to play 'extern' games from .c sources. This also silences sparse warning (wrongly) suggesting that klp_mutex should be

[PATCH v2] livepatch: make klp_mutex proper part of API

From: Jiri Kosina klp_mutex is shared between core.c and transition.c, and as such would rather be properly located in a header so that we don't have to play 'extern' games from .c sources. This also silences sparse warning (wrongly) suggesting that klp_mutex should be defined static.

Re: [PATCH 3/4] Documentation: dt: Add bindings documentation for CSI-2 Host Video Platform

Hi Ramiro, On Tue, Mar 07, 2017 at 02:37:50PM +, Ramiro Oliveira wrote: > Create device tree bindings documentation for the CSI-2 Host Video > platform. Extra space here. > > Signed-off-by: Ramiro Oliveira > --- > .../devicetree/bindings/media/snps,plat-csi2.txt

Re: [PATCH 3/4] Documentation: dt: Add bindings documentation for CSI-2 Host Video Platform

Hi Ramiro, On Tue, Mar 07, 2017 at 02:37:50PM +, Ramiro Oliveira wrote: > Create device tree bindings documentation for the CSI-2 Host Video > platform. Extra space here. > > Signed-off-by: Ramiro Oliveira > --- > .../devicetree/bindings/media/snps,plat-csi2.txt | 77 >

[PATCH 22/26] IB/ocrdma: Returning only value constants in ocrdma_resize_cq()

From: Markus Elfring Date: Wed, 8 Mar 2017 10:48:24 +0100 Return constant integer values without storing them in the local variable "status". Signed-off-by: Markus Elfring --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9

[PATCH 22/26] IB/ocrdma: Returning only value constants in ocrdma_resize_cq()

From: Markus Elfring Date: Wed, 8 Mar 2017 10:48:24 +0100 Return constant integer values without storing them in the local variable "status". Signed-off-by: Markus Elfring --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff

[PATCH 18/26] IB/ocrdma: Use kcalloc() in three functions

From: Markus Elfring Date: Wed, 8 Mar 2017 09:19:47 +0100 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus reuse the corresponding function "kcalloc". This issue was detected by

[PATCH 18/26] IB/ocrdma: Use kcalloc() in three functions

From: Markus Elfring Date: Wed, 8 Mar 2017 09:19:47 +0100 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus reuse the corresponding function "kcalloc". This issue was detected by using the Coccinelle software.

[PATCH v2] iio: multiplexer: fix unsigned check with less than zero

Comparing a size_t with less than zero is always false as size_t is unsigned. So, change the type of the variable to ssize_t and replicate the size check from mux_configure_channel() into mux_write_ext_info() thus ensuring that the size will fit in the ssize_t variable. Detected by CoverityScan,

[PATCH v2] iio: multiplexer: fix unsigned check with less than zero

Comparing a size_t with less than zero is always false as size_t is unsigned. So, change the type of the variable to ssize_t and replicate the size check from mux_configure_channel() into mux_write_ext_info() thus ensuring that the size will fit in the ssize_t variable. Detected by CoverityScan,

Re: netlink: GPF in netlink_unicast

On 2017-03-07 14:23, Paul Moore wrote: > On Tue, Mar 7, 2017 at 1:44 PM, Paul Moore wrote: > > On Tue, Mar 7, 2017 at 10:55 AM, Richard Guy Briggs wrote: > >> On 2017-03-07 09:29, Paul Moore wrote: > >>> On Mon, Mar 6, 2017 at 11:03 PM, Richard Guy Briggs

Re: netlink: GPF in netlink_unicast

On 2017-03-07 14:23, Paul Moore wrote: > On Tue, Mar 7, 2017 at 1:44 PM, Paul Moore wrote: > > On Tue, Mar 7, 2017 at 10:55 AM, Richard Guy Briggs wrote: > >> On 2017-03-07 09:29, Paul Moore wrote: > >>> On Mon, Mar 6, 2017 at 11:03 PM, Richard Guy Briggs > >>> wrote: > >>> > On 2017-03-06

[PATCH 2/2] mm: Change mbind(MPOL_BIND) implementation for CDM nodes

CDM nodes need a way of explicit memory allocation mechanism from the user space. After the previous FALLBACK zonelist rebuilding process changes, the mbind(MPOL_BIND) based allocation request fails on the CDM node. This is because allocation requesting local node's FALLBACK zonelist is selected

[PATCH 2/2] mm: Change mbind(MPOL_BIND) implementation for CDM nodes

CDM nodes need a way of explicit memory allocation mechanism from the user space. After the previous FALLBACK zonelist rebuilding process changes, the mbind(MPOL_BIND) based allocation request fails on the CDM node. This is because allocation requesting local node's FALLBACK zonelist is selected

[PATCH 04/26] IB/ocrdma: Delete unnecessary variable initialisations in ocrdma_mbx_get_dcbx_config()

From: Markus Elfring Date: Tue, 7 Mar 2017 19:25:55 +0100 The local variables "req" and "rsp" will be set to appropriate pointers a bit later. Thus omit the explicit initialisations at the beginning. Signed-off-by: Markus Elfring

[PATCH 04/26] IB/ocrdma: Delete unnecessary variable initialisations in ocrdma_mbx_get_dcbx_config()

From: Markus Elfring Date: Tue, 7 Mar 2017 19:25:55 +0100 The local variables "req" and "rsp" will be set to appropriate pointers a bit later. Thus omit the explicit initialisations at the beginning. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 5 ++--- 1 file

<    7   8   9   10   11   12   13   14   15   16   >