Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks

2017-03-16 Thread Andrew Morton
On Thu, 16 Mar 2017 11:37:56 -0700 Joe Perches wrote: > > this can make it harder to read, in _the worst case_. one printk() > > guaranteed that we would see a single line in the serial log/etc. > > the sort of a problem with multiple printks is that printks coming > > from

Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks

2017-03-16 Thread Andrew Morton
On Thu, 16 Mar 2017 11:37:56 -0700 Joe Perches wrote: > > this can make it harder to read, in _the worst case_. one printk() > > guaranteed that we would see a single line in the serial log/etc. > > the sort of a problem with multiple printks is that printks coming > > from other CPUs will split

Re: [PATCH 3/4] x86, pci: Add interface to force mmconfig

2017-03-16 Thread Thomas Gleixner
On Wed, 15 Mar 2017, Andi Kleen wrote: > > pci_root_ops is what is finally handed in to pci_scan_root_bus() as ops > > argument for any bus segment no matter which type it is. > > mmconfig is only initialized after PCI is initialized (an ordering > problem with ACPI). Wrong. It can be

Re: [PATCH 3/4] x86, pci: Add interface to force mmconfig

2017-03-16 Thread Thomas Gleixner
On Wed, 15 Mar 2017, Andi Kleen wrote: > > pci_root_ops is what is finally handed in to pci_scan_root_bus() as ops > > argument for any bus segment no matter which type it is. > > mmconfig is only initialized after PCI is initialized (an ordering > problem with ACPI). Wrong. It can be

Re: [PATCH] [SCSI] esas2r: remove redundant NULL check on buffer

2017-03-16 Thread Bradley Grove
On 03/15/2017 12:46 PM, Colin King wrote: From: Colin Ian King buffer is a pointer to the static char array event_buffer and therefore can never be null, so the check is redundant. Remove it. Detected by CoverityScan, CID#1077556 ("Logically Dead Code")

Re: [PATCH] [SCSI] esas2r: remove redundant NULL check on buffer

2017-03-16 Thread Bradley Grove
On 03/15/2017 12:46 PM, Colin King wrote: From: Colin Ian King buffer is a pointer to the static char array event_buffer and therefore can never be null, so the check is redundant. Remove it. Detected by CoverityScan, CID#1077556 ("Logically Dead Code") Signed-off-by: Colin Ian King ---

Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths

2017-03-16 Thread Alexander Duyck
On Thu, Mar 16, 2017 at 3:05 PM, Eric Dumazet wrote: > On Thu, 2017-03-16 at 11:32 -0700, Alexander Duyck wrote: >> From: Sridhar Samudrala >> >> Fix sk_mark_napi_id() and sk_mark_napi_id_once() to set sk_napi_id only if >> skb->napi_id is a

Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths

2017-03-16 Thread Samudrala, Sridhar
On 3/16/2017 3:05 PM, Eric Dumazet wrote: On Thu, 2017-03-16 at 11:32 -0700, Alexander Duyck wrote: From: Sridhar Samudrala Fix sk_mark_napi_id() and sk_mark_napi_id_once() to set sk_napi_id only if skb->napi_id is a valid value. This happens in loopback paths

Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths

2017-03-16 Thread Samudrala, Sridhar
On 3/16/2017 3:05 PM, Eric Dumazet wrote: On Thu, 2017-03-16 at 11:32 -0700, Alexander Duyck wrote: From: Sridhar Samudrala Fix sk_mark_napi_id() and sk_mark_napi_id_once() to set sk_napi_id only if skb->napi_id is a valid value. This happens in loopback paths where skb->napi_id is not

Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths

2017-03-16 Thread Alexander Duyck
On Thu, Mar 16, 2017 at 3:05 PM, Eric Dumazet wrote: > On Thu, 2017-03-16 at 11:32 -0700, Alexander Duyck wrote: >> From: Sridhar Samudrala >> >> Fix sk_mark_napi_id() and sk_mark_napi_id_once() to set sk_napi_id only if >> skb->napi_id is a valid value. >> >> This happens in loopback paths

Re: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq

2017-03-16 Thread Andy Shevchenko
On Thu, Mar 16, 2017 at 4:55 PM, Robin Murphy wrote: > On 16/03/17 13:36, Russell King - ARM Linux wrote: >> On Thu, Mar 16, 2017 at 05:56:53PM +0530, Vignesh R wrote: >>> Using dev_name() as irq name during request_irq() might be misleading in >>> case of serial over PCI.

Re: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq

2017-03-16 Thread Andy Shevchenko
On Thu, Mar 16, 2017 at 4:55 PM, Robin Murphy wrote: > On 16/03/17 13:36, Russell King - ARM Linux wrote: >> On Thu, Mar 16, 2017 at 05:56:53PM +0530, Vignesh R wrote: >>> Using dev_name() as irq name during request_irq() might be misleading in >>> case of serial over PCI. Therefore use a better

Re: [net-next PATCH 5/5] epoll: Add busy poll support to epoll with socket fds.

2017-03-16 Thread Alexander Duyck
On Thu, Mar 16, 2017 at 3:11 PM, Eric Dumazet wrote: > On Thu, 2017-03-16 at 11:33 -0700, Alexander Duyck wrote: >> From: Sridhar Samudrala > >> +/* >> + * If busy polling is on and the file is a socket, return a pointer to >> + * struct sock

Re: [net-next PATCH 5/5] epoll: Add busy poll support to epoll with socket fds.

2017-03-16 Thread Alexander Duyck
On Thu, Mar 16, 2017 at 3:11 PM, Eric Dumazet wrote: > On Thu, 2017-03-16 at 11:33 -0700, Alexander Duyck wrote: >> From: Sridhar Samudrala > >> +/* >> + * If busy polling is on and the file is a socket, return a pointer to >> + * struct sock >> + */ >> +static inline struct sock

Re: [PATCH 4.10 00/48] 4.10.4-stable review

2017-03-16 Thread Guenter Roeck
On Thu, Mar 16, 2017 at 11:29:44PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.10.4 release. > There are 48 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.9 00/44] 4.9.16-stable review

2017-03-16 Thread Guenter Roeck
On Thu, Mar 16, 2017 at 11:29:25PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.16 release. > There are 44 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.10 00/48] 4.10.4-stable review

2017-03-16 Thread Guenter Roeck
On Thu, Mar 16, 2017 at 11:29:44PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.10.4 release. > There are 48 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.9 00/44] 4.9.16-stable review

2017-03-16 Thread Guenter Roeck
On Thu, Mar 16, 2017 at 11:29:25PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.16 release. > There are 44 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 0/7] Input: fix NULL-derefs at probe

2017-03-16 Thread Dmitry Torokhov
On Mon, Mar 13, 2017 at 04:45:52PM +0100, Johan Hovold wrote: > On Mon, Mar 13, 2017 at 04:15:18PM +0100, Oliver Neukum wrote: > > Am Montag, den 13.03.2017, 13:35 +0100 schrieb Johan Hovold: > > > This series fixes a number of NULL-pointer dereferences due to > > > missing > > > endpoint sanity

Re: [net-next PATCH 2/5] net: Call sk_mark_napi_id() in the ACK receive path

2017-03-16 Thread Alexander Duyck
On Thu, Mar 16, 2017 at 3:04 PM, Eric Dumazet wrote: > On Thu, 2017-03-16 at 11:32 -0700, Alexander Duyck wrote: >> From: Sridhar Samudrala >> >> Call sk_mark_napi_id() in the ACK receive path of a TCP_NEW_SYN_RECV >> socket, so that

Re: [PATCH 0/7] Input: fix NULL-derefs at probe

2017-03-16 Thread Dmitry Torokhov
On Mon, Mar 13, 2017 at 04:45:52PM +0100, Johan Hovold wrote: > On Mon, Mar 13, 2017 at 04:15:18PM +0100, Oliver Neukum wrote: > > Am Montag, den 13.03.2017, 13:35 +0100 schrieb Johan Hovold: > > > This series fixes a number of NULL-pointer dereferences due to > > > missing > > > endpoint sanity

Re: [net-next PATCH 2/5] net: Call sk_mark_napi_id() in the ACK receive path

2017-03-16 Thread Alexander Duyck
On Thu, Mar 16, 2017 at 3:04 PM, Eric Dumazet wrote: > On Thu, 2017-03-16 at 11:32 -0700, Alexander Duyck wrote: >> From: Sridhar Samudrala >> >> Call sk_mark_napi_id() in the ACK receive path of a TCP_NEW_SYN_RECV >> socket, so that sk->napi_id is set even if the socket hasn't yet received >>

Re: [PATCH 4.4 00/35] 4.4.55-stable review

2017-03-16 Thread Guenter Roeck
On Thu, Mar 16, 2017 at 11:29:19PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.55 release. > There are 35 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.4 00/35] 4.4.55-stable review

2017-03-16 Thread Guenter Roeck
On Thu, Mar 16, 2017 at 11:29:19PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.55 release. > There are 35 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

[PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-16 Thread Matthias Kaehlcke
'perms' will never be NULL since it isn't a plain pointer but an array of u32 values. This fixes the following warning when building with clang: security/selinux/ss/services.c:158:16: error: address of array 'p_in->perms' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]

[PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-16 Thread Matthias Kaehlcke
'perms' will never be NULL since it isn't a plain pointer but an array of u32 values. This fixes the following warning when building with clang: security/selinux/ss/services.c:158:16: error: address of array 'p_in->perms' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-16 Thread Akshay Bhat
Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: > > Looks much better now! There are message for state changes to error > warning and passive. Just the following message is not correct: > > (000.200824) can0 2004 [8] 00 40 00 00 00 00 5F 19 ERRORFRAME >

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-16 Thread Akshay Bhat
Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: > > Looks much better now! There are message for state changes to error > warning and passive. Just the following message is not correct: > > (000.200824) can0 2004 [8] 00 40 00 00 00 00 5F 19 ERRORFRAME >

[PATCH 04/11] net: usb: cdc_ncm: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/cdc_ncm.c |4 ++-- 1 files

[PATCH 04/11] net: usb: cdc_ncm: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/cdc_ncm.c |4 ++-- 1 files changed, 2

Re: [PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

2017-03-16 Thread Sakari Ailus
On Sat, Mar 11, 2017 at 12:31:24PM -0800, Steve Longerbeam wrote: > > > On 03/11/2017 05:41 AM, Sakari Ailus wrote: > >Hi Steve, > > > >On Thu, Mar 09, 2017 at 08:52:58PM -0800, Steve Longerbeam wrote: > >>If the pads on both sides of a link specify a frame interval, then > >>those frame

Re: [PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

2017-03-16 Thread Sakari Ailus
On Sat, Mar 11, 2017 at 12:31:24PM -0800, Steve Longerbeam wrote: > > > On 03/11/2017 05:41 AM, Sakari Ailus wrote: > >Hi Steve, > > > >On Thu, Mar 09, 2017 at 08:52:58PM -0800, Steve Longerbeam wrote: > >>If the pads on both sides of a link specify a frame interval, then > >>those frame

[PATCH 00/11] net: usbnet: move to new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. On usbnet, it was often implemented with usbnet_{get|set}_settings. In this serie, I add usbnet_{get|set}_link_ksettings in the first patch, then I update all the driver to use this new api, and in the last patch I remove the old api

[PATCH 00/11] net: usbnet: move to new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. On usbnet, it was often implemented with usbnet_{get|set}_settings. In this serie, I add usbnet_{get|set}_link_ksettings in the first patch, then I update all the driver to use this new api, and in the last patch I remove the old api

[PATCH 01/11] net: usb: usbnet: add new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We add the new api {get|set}_link_ksettings to this driver. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/usbnet.c | 36

[PATCH 01/11] net: usb: usbnet: add new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We add the new api {get|set}_link_ksettings to this driver. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/usbnet.c | 36

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-16 Thread Sakari Ailus
Hi Steve, On Tue, Mar 14, 2017 at 09:43:09AM -0700, Steve Longerbeam wrote: > > > On 03/14/2017 09:21 AM, Nicolas Dufresne wrote: > >Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : > >>On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > >>>On 03/11/2017 07:14

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-16 Thread Sakari Ailus
Hi Steve, On Tue, Mar 14, 2017 at 09:43:09AM -0700, Steve Longerbeam wrote: > > > On 03/14/2017 09:21 AM, Nicolas Dufresne wrote: > >Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : > >>On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > >>>On 03/11/2017 07:14

[PATCH 11/11] net: usb: usb: remove old api ethtool_{get|set}_settings

2017-03-16 Thread Philippe Reynes
The function usbnet_{get|set}_settings is no longer used, so we remove it. Signed-off-by: Philippe Reynes --- drivers/net/usb/usbnet.c | 35 --- include/linux/usb/usbnet.h |4 2 files changed, 0 insertions(+), 39 deletions(-) diff

[PATCH 11/11] net: usb: usb: remove old api ethtool_{get|set}_settings

2017-03-16 Thread Philippe Reynes
The function usbnet_{get|set}_settings is no longer used, so we remove it. Signed-off-by: Philippe Reynes --- drivers/net/usb/usbnet.c | 35 --- include/linux/usb/usbnet.h |4 2 files changed, 0 insertions(+), 39 deletions(-) diff --git

[PATCH v4 4/6] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct

2017-03-16 Thread sunil . m
From: Suniel Mahesh Replaced sizeof(struct foo) into sizeof(*ptr), found by checkpatch.pl Signed-off-by: Suniel Mahesh --- Changes for v4: - Dropped two patches from the series, as they were not adding significant value suggested by Dan Carpenter.

[PATCH v4 4/6] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct

2017-03-16 Thread sunil . m
From: Suniel Mahesh Replaced sizeof(struct foo) into sizeof(*ptr), found by checkpatch.pl Signed-off-by: Suniel Mahesh --- Changes for v4: - Dropped two patches from the series, as they were not adding significant value suggested by Dan Carpenter. staging: rtl8192e: Fix coding style, this

[PATCH 10/11] net: usb: asix: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/asix_devices.c | 12 ++--

[PATCH 10/11] net: usb: asix: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/asix_devices.c | 12 ++-- 1 files changed, 6

[PATCH 09/11] net: usb: sr9700: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/sr9700.c |4 ++-- 1 files

[PATCH 09/11] net: usb: sr9700: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/sr9700.c |4 ++-- 1 files changed, 2

[PATCH 07/11] net: usb: sierra_net: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/sierra_net.c |4 ++-- 1 files

[PATCH 07/11] net: usb: sierra_net: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/sierra_net.c |4 ++-- 1 files changed, 2

[PATCH 08/11] net: usb: smsc75xx: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/smsc75xx.c |4 ++-- 1 files

[PATCH 06/11] net: usb: mcs7830: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/mcs7830.c |4 ++-- 1 files

[PATCH 08/11] net: usb: smsc75xx: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/smsc75xx.c |4 ++-- 1 files changed, 2

[PATCH 06/11] net: usb: mcs7830: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/mcs7830.c |4 ++-- 1 files changed, 2

[PATCH 02/11] net: usb: smsc95xx: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/smsc95xx.c | 24

[PATCH 03/11] net: usb: sr9800: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/sr9800.c |4 ++-- 1 files

[PATCH 03/11] net: usb: sr9800: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/sr9800.c |4 ++-- 1 files changed, 2

[PATCH 02/11] net: usb: smsc95xx: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/smsc95xx.c | 24 1 files

[PATCH v4 6/6] staging: rtl8192e: Fix blank lines and space after a cast

2017-03-16 Thread sunil . m
From: Suniel Mahesh Fixed the following checkpatch.pl checks: Blank lines aren't necessary after an open brace '{' and before a close brace '}', removed No space is necessary after a cast, removed Please don't use multiple blank lines, removed Signed-off-by: Suniel Mahesh

[PATCH v4 6/6] staging: rtl8192e: Fix blank lines and space after a cast

2017-03-16 Thread sunil . m
From: Suniel Mahesh Fixed the following checkpatch.pl checks: Blank lines aren't necessary after an open brace '{' and before a close brace '}', removed No space is necessary after a cast, removed Please don't use multiple blank lines, removed Signed-off-by: Suniel Mahesh --- Changes for v4:

[PATCH 05/11] net: usb: dm9601: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/dm9601.c |4 ++-- 1 files

[PATCH 05/11] net: usb: dm9601: use new api ethtool_{get|set}_link_ksettings

2017-03-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/usb/dm9601.c |4 ++-- 1 files changed, 2

[PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and checks

2017-03-16 Thread sunil . m
From: Suniel Mahesh Split earlier patches into multiple commits for easy review as suggested by Dan Carpenter. Modified subject, description and in few patches both for better readability as suggested by Greg KH. Dropped two patches from the earler series, as they were not

[PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and checks

2017-03-16 Thread sunil . m
From: Suniel Mahesh Split earlier patches into multiple commits for easy review as suggested by Dan Carpenter. Modified subject, description and in few patches both for better readability as suggested by Greg KH. Dropped two patches from the earler series, as they were not adding significant

Re: [net-next PATCH 5/5] epoll: Add busy poll support to epoll with socket fds.

2017-03-16 Thread Eric Dumazet
On Thu, 2017-03-16 at 11:33 -0700, Alexander Duyck wrote: > From: Sridhar Samudrala > +/* > + * If busy polling is on and the file is a socket, return a pointer to > + * struct sock > + */ > +static inline struct sock *ep_sk_from_file(struct file *file) > +{ > +

Re: [net-next PATCH 5/5] epoll: Add busy poll support to epoll with socket fds.

2017-03-16 Thread Eric Dumazet
On Thu, 2017-03-16 at 11:33 -0700, Alexander Duyck wrote: > From: Sridhar Samudrala > +/* > + * If busy polling is on and the file is a socket, return a pointer to > + * struct sock > + */ > +static inline struct sock *ep_sk_from_file(struct file *file) > +{ > + struct inode *inode =

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-16 Thread Pavel Machek
Hi! > > > > mplayer is useful for testing... but that one already works (after you > > > > setup the pipeline, and configure exposure/gain). > > > > > > > > But thats useful for testing, not really for production. Image will be > > > > out of focus and with wrong white balance. > > > > > > > >

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-16 Thread Pavel Machek
Hi! > > > > mplayer is useful for testing... but that one already works (after you > > > > setup the pipeline, and configure exposure/gain). > > > > > > > > But thats useful for testing, not really for production. Image will be > > > > out of focus and with wrong white balance. > > > > > > > >

Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths

2017-03-16 Thread Eric Dumazet
On Thu, 2017-03-16 at 11:32 -0700, Alexander Duyck wrote: > From: Sridhar Samudrala > > Fix sk_mark_napi_id() and sk_mark_napi_id_once() to set sk_napi_id only if > skb->napi_id is a valid value. > > This happens in loopback paths where skb->napi_id is not updated

Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths

2017-03-16 Thread Eric Dumazet
On Thu, 2017-03-16 at 11:32 -0700, Alexander Duyck wrote: > From: Sridhar Samudrala > > Fix sk_mark_napi_id() and sk_mark_napi_id_once() to set sk_napi_id only if > skb->napi_id is a valid value. > > This happens in loopback paths where skb->napi_id is not updated in > rx path and holds

Re: [PATCH v1] x86/mm, asm-generic: Add IOMMU ioremap_uc() variant default

2017-03-16 Thread Luis R. Rodriguez
On Thu, Mar 16, 2017 at 03:46:51PM -0500, Bjorn Helgaas wrote: > On Thu, Jul 9, 2015 at 7:28 PM, Luis R. Rodriguez > wrote: > > > +/** > > + * DOC: ioremap() and ioremap_*() variants > > + * > > + * If you have an IOMMU your architecture is expected to have both > >

Re: [PATCH v1] x86/mm, asm-generic: Add IOMMU ioremap_uc() variant default

2017-03-16 Thread Luis R. Rodriguez
On Thu, Mar 16, 2017 at 03:46:51PM -0500, Bjorn Helgaas wrote: > On Thu, Jul 9, 2015 at 7:28 PM, Luis R. Rodriguez > wrote: > > > +/** > > + * DOC: ioremap() and ioremap_*() variants > > + * > > + * If you have an IOMMU your architecture is expected to have both > > ioremap() > > + * and

[PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit

2017-03-16 Thread Matthias Kaehlcke
With the previous unsigned long value clang generates warnings like this: sound/pci/hda/patch_ca0132.c:860:37: error: implicit conversion from 'unsigned long' to 'u32' (aka 'unsigned int') changes value from 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]

[PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit

2017-03-16 Thread Matthias Kaehlcke
With the previous unsigned long value clang generates warnings like this: sound/pci/hda/patch_ca0132.c:860:37: error: implicit conversion from 'unsigned long' to 'u32' (aka 'unsigned int') changes value from 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]

Re: [net-next PATCH 2/5] net: Call sk_mark_napi_id() in the ACK receive path

2017-03-16 Thread Eric Dumazet
On Thu, 2017-03-16 at 11:32 -0700, Alexander Duyck wrote: > From: Sridhar Samudrala > > Call sk_mark_napi_id() in the ACK receive path of a TCP_NEW_SYN_RECV > socket, so that sk->napi_id is set even if the socket hasn't yet received > any data. With this change we

Re: [net-next PATCH 2/5] net: Call sk_mark_napi_id() in the ACK receive path

2017-03-16 Thread Eric Dumazet
On Thu, 2017-03-16 at 11:32 -0700, Alexander Duyck wrote: > From: Sridhar Samudrala > > Call sk_mark_napi_id() in the ACK receive path of a TCP_NEW_SYN_RECV > socket, so that sk->napi_id is set even if the socket hasn't yet received > any data. With this change we should be able to start busy

Re: [PATCH v2 0/3] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers

2017-03-16 Thread Tejun Heo
On Tue, Mar 14, 2017 at 05:36:51PM +0100, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patchset adds Palmchip BK3710 IDE controller driver to > libata and switches ARM/DaVinci to use it (instead of the old > IDE driver). > > Sekhar, please check that it still works after changes, thanks. > >

Re: [PATCH v2 0/3] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers

2017-03-16 Thread Tejun Heo
On Tue, Mar 14, 2017 at 05:36:51PM +0100, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patchset adds Palmchip BK3710 IDE controller driver to > libata and switches ARM/DaVinci to use it (instead of the old > IDE driver). > > Sekhar, please check that it still works after changes, thanks. > >

Re: [RFC PATCH 27/33] irqchip/gic-v3-its: Add VPE interrupt masking

2017-03-16 Thread Auger Eric
Hi Marc, On 17/01/2017 11:20, Marc Zyngier wrote: > When masking/unmasking a doorbell interrupt, it is necessary > to issue an invalidation to the corresponding redistributor. > We use the DirectLPI feature by writting directly to the corresponding s/writting/writing is DirectLPI always supported?

Re: [RFC PATCH 27/33] irqchip/gic-v3-its: Add VPE interrupt masking

2017-03-16 Thread Auger Eric
Hi Marc, On 17/01/2017 11:20, Marc Zyngier wrote: > When masking/unmasking a doorbell interrupt, it is necessary > to issue an invalidation to the corresponding redistributor. > We use the DirectLPI feature by writting directly to the corresponding s/writting/writing is DirectLPI always supported?

[PATCH] Staging: wilc1000: fix two typos in #define's

2017-03-16 Thread Dylan Leggio
Signed-off-by: Dylan Leggio --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index

[PATCH] Staging: wilc1000: fix two typos in #define's

2017-03-16 Thread Dylan Leggio
Signed-off-by: Dylan Leggio --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index

Re: [RFC PATCH 10/33] irqchip/gic-v4-its: Allow use of indirect VCPU tables

2017-03-16 Thread Auger Eric
On 17/01/2017 11:20, Marc Zyngier wrote: > The VCPU tables can be quite sparse as well, and it makes sense > to use indirect tables as well if possible. I think patch title should be irqchip/gic-v3-its:.. Eric > > Signed-off-by: Marc Zyngier > --- >

Re: [RFC PATCH 10/33] irqchip/gic-v4-its: Allow use of indirect VCPU tables

2017-03-16 Thread Auger Eric
On 17/01/2017 11:20, Marc Zyngier wrote: > The VCPU tables can be quite sparse as well, and it makes sense > to use indirect tables as well if possible. I think patch title should be irqchip/gic-v3-its:.. Eric > > Signed-off-by: Marc Zyngier > --- > drivers/irqchip/irq-gic-v3-its.c | 20

Re: [PATCH 02/20] PCI: fix pci_remap_iospace() remap attribute

2017-03-16 Thread Bjorn Helgaas
[+cc Luis] On Mon, Feb 27, 2017 at 03:14:13PM +, Lorenzo Pieralisi wrote: > According to the PCI local bus specifications (Revision 3.0, 3.2.5), > I/O Address space transactions are non-posted. On architectures where > I/O space is implemented through a chunk of memory mapped space mapped >

Re: [PATCH 02/20] PCI: fix pci_remap_iospace() remap attribute

2017-03-16 Thread Bjorn Helgaas
[+cc Luis] On Mon, Feb 27, 2017 at 03:14:13PM +, Lorenzo Pieralisi wrote: > According to the PCI local bus specifications (Revision 3.0, 3.2.5), > I/O Address space transactions are non-posted. On architectures where > I/O space is implemented through a chunk of memory mapped space mapped >

Re: [RFC PATCH 24/33] irqchip/gic-v3-its: Add VPE scheduling

2017-03-16 Thread Shanker Donthineni
Hi Eric, On 03/16/2017 04:23 PM, Auger Eric wrote: > Hi, > > On 17/01/2017 11:20, Marc Zyngier wrote: >> When a VPE is scheduled to run, the corresponding redistributor must >> be told so, by setting VPROPBASER to the VM's property table, and >> VPENDBASER to the vcpu's pending table. >> >> When

Re: [RFC PATCH 24/33] irqchip/gic-v3-its: Add VPE scheduling

2017-03-16 Thread Shanker Donthineni
Hi Eric, On 03/16/2017 04:23 PM, Auger Eric wrote: > Hi, > > On 17/01/2017 11:20, Marc Zyngier wrote: >> When a VPE is scheduled to run, the corresponding redistributor must >> be told so, by setting VPROPBASER to the VM's property table, and >> VPENDBASER to the vcpu's pending table. >> >> When

Re: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq

2017-03-16 Thread Arnd Bergmann
On Thursday, March 16, 2017 5:56:53 PM CET Vignesh R wrote: > Using dev_name() as irq name during request_irq() might be misleading in > case of serial over PCI. Therefore use a better alternative name for > identifying serial port irqs as "serial" appended with serial_index of > the port. This

Re: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq

2017-03-16 Thread Arnd Bergmann
On Thursday, March 16, 2017 5:56:53 PM CET Vignesh R wrote: > Using dev_name() as irq name during request_irq() might be misleading in > case of serial over PCI. Therefore use a better alternative name for > identifying serial port irqs as "serial" appended with serial_index of > the port. This

Re: [PATCH v2] ARM: zynq: Add #io-channel-cells to (x)adc node for iio-hwmon

2017-03-16 Thread Lars-Peter Clausen
On 03/16/2017 06:54 PM, Moritz Fischer wrote: > Hi Lars, > > On Thu, Mar 16, 2017 at 9:51 AM, Lars-Peter Clausen wrote: >> On 03/16/2017 05:45 PM, Michal Simek wrote: >>> On 16.3.2017 17:39, Moritz Fischer wrote: On Thu, Mar 16, 2017 at 9:16 AM, Michal Simek

Re: [PATCH] clock: Fix smp_processor_id() in preemptible bug

2017-03-16 Thread Paul E. McKenney
On Thu, Mar 16, 2017 at 02:00:02PM -0700, Paul E. McKenney wrote: > On Thu, Mar 16, 2017 at 09:57:48AM -0700, Paul E. McKenney wrote: > > On Thu, Mar 16, 2017 at 04:53:10PM +0100, Peter Zijlstra wrote: > > > On Wed, Mar 15, 2017 at 03:58:17PM -0700, Paul E. McKenney wrote: > > > > On Mon, Mar 13,

Re: [PATCH v2] ARM: zynq: Add #io-channel-cells to (x)adc node for iio-hwmon

2017-03-16 Thread Lars-Peter Clausen
On 03/16/2017 06:54 PM, Moritz Fischer wrote: > Hi Lars, > > On Thu, Mar 16, 2017 at 9:51 AM, Lars-Peter Clausen wrote: >> On 03/16/2017 05:45 PM, Michal Simek wrote: >>> On 16.3.2017 17:39, Moritz Fischer wrote: On Thu, Mar 16, 2017 at 9:16 AM, Michal Simek wrote: > Hi, >

Re: [PATCH] clock: Fix smp_processor_id() in preemptible bug

2017-03-16 Thread Paul E. McKenney
On Thu, Mar 16, 2017 at 02:00:02PM -0700, Paul E. McKenney wrote: > On Thu, Mar 16, 2017 at 09:57:48AM -0700, Paul E. McKenney wrote: > > On Thu, Mar 16, 2017 at 04:53:10PM +0100, Peter Zijlstra wrote: > > > On Wed, Mar 15, 2017 at 03:58:17PM -0700, Paul E. McKenney wrote: > > > > On Mon, Mar 13,

RE: [PATCH 1/2 v4] pci-hyperv: properly handle pci bus remove

2017-03-16 Thread Long Li
> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Thursday, March 16, 2017 1:07 PM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas ; >

RE: [PATCH 1/2 v4] pci-hyperv: properly handle pci bus remove

2017-03-16 Thread Long Li
> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Thursday, March 16, 2017 1:07 PM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas ; > de...@linuxdriverproject.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re:

Re: [PATCH] ext4: Add statx support

2017-03-16 Thread Andreas Dilger
On Mar 16, 2017, at 5:35 AM, David Howells wrote: > > Return enhanced file attributes from the Ext4 filesystem. This includes > the following: > > (1) The inode creation time (i_crtime) as stx_btime, setting STATX_BTIME. > > (2) Certain FS_xxx_FL flags are mapped to

Re: [PATCH] ext4: Add statx support

2017-03-16 Thread Andreas Dilger
On Mar 16, 2017, at 5:35 AM, David Howells wrote: > > Return enhanced file attributes from the Ext4 filesystem. This includes > the following: > > (1) The inode creation time (i_crtime) as stx_btime, setting STATX_BTIME. > > (2) Certain FS_xxx_FL flags are mapped to stx_attribute flags. > >

[PATCHv2 7/7] x86/mm: Switch to generic get_user_page_fast() implementation

2017-03-16 Thread Kirill A. Shutemov
The patch provides all required hooks to match generic get_user_pages_fast() behaviour to x86 and switch x86 over. Signed-off-by: Kirill A. Shutemov --- v2: - Fix build on non-PAE 32-bit x86; - Rename HAVE_GENERIC_RCU_GUP to HAVE_GENERIC_GUP and update

[PATCHv2 7/7] x86/mm: Switch to generic get_user_page_fast() implementation

2017-03-16 Thread Kirill A. Shutemov
The patch provides all required hooks to match generic get_user_pages_fast() behaviour to x86 and switch x86 over. Signed-off-by: Kirill A. Shutemov --- v2: - Fix build on non-PAE 32-bit x86; - Rename HAVE_GENERIC_RCU_GUP to HAVE_GENERIC_GUP and update comment; --- arch/arm/Kconfig

PATCH for style warnings in drivers/staging/most/aim-v4l2

2017-03-16 Thread Chandra Annamaneni
Enclosed is a patch to the file video.c. It only fixes style warning flagged by checkpatch.pl. Please let me know if anything else needs to be done. Thanks. Chandra diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c index e074841..59e861e 100644 ---

PATCH for style warnings in drivers/staging/most/aim-v4l2

2017-03-16 Thread Chandra Annamaneni
Enclosed is a patch to the file video.c. It only fixes style warning flagged by checkpatch.pl. Please let me know if anything else needs to be done. Thanks. Chandra diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c index e074841..59e861e 100644 ---

<    1   2   3   4   5   6   7   8   9   10   >