Re: [PATCH 09/11] staging: speakup: Simplify the NULL comparisons

2017-03-23 Thread Greg KH
On Tue, Mar 21, 2017 at 05:12:33PM +0530, Arushi Singhal wrote: > Fixed coding style for null comparisons in speakup driver to be more > consistant with the rest of the kernel coding style. > Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. > > Signed-off-by: Arushi Singhal > --- > driver

Re: [PATCH 05/11] staging: speakup: Remove multiple assignments

2017-03-23 Thread Greg KH
On Tue, Mar 21, 2017 at 05:12:29PM +0530, Arushi Singhal wrote: > This patch fixes the checkpatch.pl warning "multiple assignments > should be avoided." > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --

Re: [PATCH 02/11] staging: speakup: Remove multiple assignments

2017-03-23 Thread Greg KH
On Tue, Mar 21, 2017 at 05:12:26PM +0530, Arushi Singhal wrote: > This patch fixes the checkpatch.pl warning "multiple assignments > should be avoided." > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/main.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletio

Re: kvm: use-after-free function call in kvm_io_bus_destroy

2017-03-23 Thread David Hildenbrand
On 23.03.2017 13:33, Dmitry Vyukov wrote: > Hello, > > I've got the following report while running syzkaller fuzzer on > 093b995e3b55a0ae0670226ddfcb05bfbf0099ae. Note the preceding injected > kmalloc failure, most likely it's the root cause. > > > FAULT_INJECTION: forcing a failure. > name fail

Re: [PATCH staging/speakup v3 3/3] use speakup_allocate as per required context

2017-03-23 Thread Greg KH
On Tue, Mar 21, 2017 at 12:40:24PM +0530, Pranay Kr. Srivastava wrote: > speakup_allocate used GFP_ATOMIC for allocations > even while during initialization due to it's use > in notifier call. > > Pass GFP_ flags as well to speakup_allocate depending > on the context it is called in. > > Signed-o

Re: [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen

2017-03-23 Thread Stanislaw Gruszka
On Wed, Mar 22, 2017 at 10:56:02AM -0700, Ankur Arora wrote: > >It is ok to do upload_pm_data() with delay i.e. after some other > >resume actions are done and possibly xen-acpi-processor is in > >running state ? > The state uploaded is ACPI P and C state from struct acpi_processor > which AFAICS i

[PATCH] microblaze: use sg_phys()

2017-03-23 Thread Geliang Tang
Use sg_phys() instead of open-coding it. Signed-off-by: Geliang Tang --- arch/microblaze/kernel/dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/microblaze/kernel/dma.c b/arch/microblaze/kernel/dma.c index 12e093a..e45ada8 100644 --- a/arch/microblaze/kernel/dma.c

[PATCH] qla2xxx: use sg_virt()

2017-03-23 Thread Geliang Tang
Use sg_virt() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/scsi/qla2xxx/qla_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 3203367..9610d85 100644 --- a/drivers/scsi/qla2xxx/qla

[PATCH] iommu: use sg_phys()

2017-03-23 Thread Geliang Tang
Use sg_phys() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/iommu/intel-iommu.c | 2 +- drivers/iommu/iommu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index d412a31..9d09a9e 100644

[PATCH] crypto: ixp4xx - Use sg_virt()

2017-03-23 Thread Geliang Tang
Use sg_virt() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/crypto/ixp4xx_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c index 7868765..771dd26 100644 --- a/drivers/crypto/ixp4xx_cr

[PATCH] isdn: use setup_timer

2017-03-23 Thread Geliang Tang
Use setup_timer() instead of init_timer() to simplify the code. Signed-off-by: Geliang Tang --- drivers/isdn/divert/isdn_divert.c | 9 +++-- drivers/isdn/hardware/eicon/divasi.c| 5 ++--- drivers/isdn/hardware/mISDN/hfcmulti.c | 10 -- drivers/isdn/hardware/mISDN/hfcpci.

[PATCH] pstore: remove unused vmalloc.h in pmsg

2017-03-23 Thread Geliang Tang
Since the vmalloc code has been removed from write_pmsg() in the commit "5bf6d1b pstore/pmsg: drop bounce buffer", remove the unused header vmalloc.h. Signed-off-by: Geliang Tang --- fs/pstore/pmsg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/pstore/pmsg.c b/fs/pstore/pmsg.c index c16

Re: [PATCH v1] mfd: core: Preserve PLATFORM_DEVID_NONE

2017-03-23 Thread Andy Shevchenko
On Thu, 2017-03-23 at 11:21 +, Lee Jones wrote: > On Thu, 16 Mar 2017, Andy Shevchenko wrote: > > > There is a potential flaw if cell has id > 0 and is going to be > > registered with PLATFORM_DEVID_NONE. > > > > Ignore if PLATFORM_DEVID_NONE is supplied. > > This is a substantial change to

[PATCH] staging: media: atomisp: use kvmalloc and kvfree

2017-03-23 Thread Geliang Tang
Use kvmalloc() and kvfree() instead of open-coding. Signed-off-by: Geliang Tang --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/

[PATCH] staging: media: atomisp: fix build error

2017-03-23 Thread Geliang Tang
Fix the following build error: CC drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.o drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: error: excess elements in array initializer [-Werror] "i", /* ion */ ^~~ drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: note: (

Re: [PATCH 1/5] w83627ehf: Use hwmon_device_register_with_info and sensor groups

2017-03-23 Thread Guenter Roeck
On 03/23/2017 06:05 AM, Peter Hüwe wrote: This is of course v2 of the series Forgot to add it to git-send-email, sorry. Shall I resend with v2 in subject? No, it's ok. At least you have a change log :-). Thanks, Guenter

Re: [PATCH V1] mmc: core: fix still flush cache when eMMC cache off

2017-03-23 Thread Ulf Hansson
On 23 March 2017 at 11:45, Bean Huo (beanhuo) wrote: > Hi, > >>On 19 March 2017 at 01:45, Bean Huo (beanhuo) wrote: >>> This patch fixes the issue that mmc_blk_issue_rq still flushes cache >>> when eMMC cache has already been off through user space tool, such as >>> mmc-utils. >>> The reason is t

Re: [PATCH v5 08/13] powerpc/perf: PMU functions for Core IMC and hotplugging

2017-03-23 Thread Gautham R Shenoy
Hi Maddy, Hemant, Anju, On Thu, Mar 16, 2017 at 01:05:02PM +0530, Madhavan Srinivasan wrote: [..snip..] > + > +static void core_imc_change_cpu_context(int old_cpu, int new_cpu) > +{ > + if (!core_imc_pmu) > + return; > + perf_pmu_migrate_context(&core_imc_pmu->pmu, old_cpu, n

Re: security, hugetlbfs: write to user memory in hugetlbfs_destroy_inode

2017-03-23 Thread Dmitry Vyukov
On Thu, Mar 23, 2017 at 2:06 PM, Dmitry Vyukov wrote: > Hello, > > I've got the following report while running syzkaller fuzzer on > 093b995e3b55a0ae0670226ddfcb05bfbf0099ae. Note the preceding injected > kmalloc failure in inode_alloc_security, most likely it's the root > cause. > > > FAULT_INJEC

security, hugetlbfs: write to user memory in hugetlbfs_destroy_inode

2017-03-23 Thread Dmitry Vyukov
Hello, I've got the following report while running syzkaller fuzzer on 093b995e3b55a0ae0670226ddfcb05bfbf0099ae. Note the preceding injected kmalloc failure in inode_alloc_security, most likely it's the root cause. FAULT_INJECTION: forcing a failure. name failslab, interval 1, probability 0, spa

[RFC PATCH v0.2] PCI: Add support for tango PCIe host bridge

2017-03-23 Thread Mason
I think this version is ready for review. It has all the required bits and pieces. I still have a few questions, embedded as comments in the code. (Missing are ancillary changes to Kconfig, Makefile) --- drivers/pci/host/pcie-tango.c | 350 ++ 1 file changed

Re: [PATCH v2] kasan: report only the first error by default

2017-03-23 Thread Andrey Ryabinin
On 03/23/2017 03:41 PM, Mark Rutland wrote: > On Thu, Mar 23, 2017 at 02:49:16PM +0300, Andrey Ryabinin wrote: >> +kasan_multi_shot >> +[KNL] Enforce KASAN (Kernel Address Sanitizer) to print >> +report on every invalid memory access. Without this >> +

Re: [PATCH 1/5] w83627ehf: Use hwmon_device_register_with_info and sensor groups

2017-03-23 Thread Peter Hüwe
This is of course v2 of the series Forgot to add it to git-send-email, sorry. Shall I resend with v2 in subject? Peter

[PATCH 4/5] w83627ehf: Drop FSFE template and replace with SPDX License information

2017-03-23 Thread Peter Huewe
As indicated by checkpatch it makes sense to not use the FSFE Template about GPLv2+ Signed-off-by: Peter Huewe --- drivers/hwmon/w83627ehf.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c index a6f56b1272

[PATCH] x86/boot: Support uncompressed kernel

2017-03-23 Thread Chao Peng
Compressed kernel has its own drawback: uncompressing takes time. Even though the time is short enough to ignore for most cases but for cases that time is critical this is still a big number. In our on-going optimization for kernel boot time, the measured overall kernel boot time is ~90ms while the

[PATCH 2/5] w83627ehf: Use octal values for access rights of sysfs files

2017-03-23 Thread Peter Huewe
As indicated by checkpatch, use the octal representation for the access rights. S_IWUSR | S_IRUGO => 0644 S_IRUGO => 0444 Signed-off-by: Peter Huewe --- drivers/hwmon/w83627ehf.c | 52 --- 1 file changed, 22 insertions(+), 30 deletions(-) diff --git

[PATCH 5/5] w83627ehf: Drop support for nct6775/nct6776

2017-03-23 Thread Peter Huewe
Since there exists a dedicated driver for nct6775/nct6776 it makes sense to remove support for these chips from this driver, in order to have only one code base for these types of chips. This also improves maintainability and readability (and size) of this driver. Some not so-obvious changes are:

Re: [PATCH 3/7] iommu/iova: insert start_pfn boundary of dma32

2017-03-23 Thread Robin Murphy
On 22/03/17 06:27, Zhen Lei wrote: > Reserve the first granule size memory(start at start_pfn) as boundary > iova, to make sure that iovad->cached32_node can not be NULL in future. > Meanwhile, changed the assignment of iovad->cached32_node from rb_next to > rb_prev of &free->node in function __cac

[PATCH 3/5] w83627ehf: Minor readability fixes

2017-03-23 Thread Peter Huewe
just some cosmetics for better readability, proposed by Lindent/checkpatch Signed-off-by: Peter Huewe --- drivers/hwmon/w83627ehf.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c

[PATCH 1/5] w83627ehf: Use hwmon_device_register_with_info and sensor groups

2017-03-23 Thread Peter Huewe
This patch replaces the old, deprecated call to hwmon_device_register with the new hwmon_device_register_with_info and converts the whole driver to the new hwmon interface using the hwmon_chip_info methods and the attribute_group method. All standard attributes were converted to the corresponding

Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

2017-03-23 Thread Linus Walleij
On Thu, Mar 23, 2017 at 1:13 PM, Arnd Bergmann wrote: > On Thu, Mar 23, 2017 at 11:22 AM, Linus Walleij > wrote: >> On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann wrote: >> >>> We cannot select the option when SERIAL_8250 is not also set: >>> >>> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM

Re: net/kcm: use-after-free in kcm_wq

2017-03-23 Thread Dmitry Vyukov
On Fri, Mar 3, 2017 at 9:03 PM, Cong Wang wrote: > On Fri, Mar 3, 2017 at 2:11 AM, Dmitry Vyukov wrote: >> Also like this one: >> >> == >> BUG: KASAN: use-after-free in atomic_long_read >> include/linux/compiler.h:254 [inline] at add

[RFC PATCH 2/2] arm64: hugetlbpages: Correctly handle swap entries in huge_pte_offset()

2017-03-23 Thread Punit Agrawal
huge_pte_offset() does not correctly handle poisoned or migration page table entries. Not knowing the size of the hugepage entry being requested only compounded the problem. The recently added hstate parameter can be used to determine the size of hugepage being accessed. Use the size to find the c

Re: [PATCH] hangcheck-timer: Fix typo in comment

2017-03-23 Thread Greg Kroah-Hartman
On Thu, Mar 23, 2017 at 05:08:00PM +0800, Shile Zhang wrote: > Fix the typo "alloted" -> "allotted" in comment. > > Signed-off-by: Shile Zhang > --- > drivers/char/hangcheck-timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) You sent me two different patches, with the same subject,

[RFC PATCH 1/2] mm/hugetlb.c: add hstate parameter to huge_pte_offset()

2017-03-23 Thread Punit Agrawal
A poisoned or migrated hugepage is stored as a swap entry in the page tables. On architectures that support hugepages consisting of contiguous page table entries (such as on arm64) this leads to ambiguity in determining the right page table entry to return in huge_pte_offset() when a poisoned entry

[RFC PATCH 0/2] Add hstate parameter to huge_pte_offset()

2017-03-23 Thread Punit Agrawal
On architectures that support hugepages composed of contiguous pte as well as block entries at the same level in the page table, huge_pte_offset() is not able to determine the right offset to return when it encounters a swap entry (which is used to mark poisoned as well as migrated pages in the pag

Re: [PATCH] ARM: nommu: access ID_PFR1 only if CPUID scheme

2017-03-23 Thread afzal mohammed
Hi, On Thu, Mar 23, 2017 at 09:37:48PM +1000, Greg Ungerer wrote: > Tested-by: Greg Ungerer Thanks Greg Since there was no negative feedback yet, change has been deposited in rmk's patch system as 8665/1 Regards afzal

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

2017-03-23 Thread Joao Pinto
RX and TX queues to use */ - plat->tx_queues_to_use = 1; - plat->rx_queues_to_use = 1; - - /* Disable Priority config by default */ - plat->tx_queues_cfg[0].use_prio = false; - plat->rx_queues_cfg[0].use_prio = false; - - /* Disable RX queues routing

netlink: NULL timer crash

2017-03-23 Thread Dmitry Vyukov
Hello, The following program triggers call of NULL timer func: https://gist.githubusercontent.com/dvyukov/c210d01c74b911273469a93862ea7788/raw/2a3182772a6a6e20af3e71c02c2a1c2895d803fb/gistfile1.txt BUG: unable to handle kernel NULL pointer dereference at (null) IP: (null) PG

[PATCH] xen, fbfront: add support for specifying size via xenstore

2017-03-23 Thread Juergen Gross
Today xen-fbfront supports specifying the display size via module parameters only. Add support for specifying the size via Xenstore in order to enable doing this easily via the domain's Xen configuration. Add an error message in case the configured display size conflicts with video memory size. S

[PATCH] xen, fbfront: fix connecting to backend

2017-03-23 Thread Juergen Gross
Connecting to the backend isn't working reliably in xen-fbfront: in case XenbusStateInitWait of the backend has been missed the backend transition to XenbusStateConnected will trigger the connected state only without doing the actions required when the backend has connected. Cc: sta...@vger.kernel

Re: [PATCH v18 0/3] USB Type-C Connector class

2017-03-23 Thread Greg KH
On Tue, Mar 21, 2017 at 01:56:45PM +0200, Heikki Krogerus wrote: > The USB Type-C class is meant to provide unified interface to the > userspace to present the USB Type-C ports in a system. Now applied, nice job, thanks for sticking with this, it's much appreciated. greg k-h

[PATCH] arm/arm64: KVM: send SIGBUS error to qemu

2017-03-23 Thread Dongjiu Geng
when the pfn is KVM_PFN_ERR_HWPOISON, it indicates to send SIGBUS signal from KVM's fault-handling code to qemu, qemu can handle this signal according to the fault address. Signed-off-by: Dongjiu Geng --- arch/arm/kvm/mmu.c | 20 include/linux/kvm_host.h | 5 + 2

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-23 Thread Geert Uytterhoeven
Hi Uwe, On Thu, Mar 23, 2017 at 1:34 PM, Uwe Kleine-König wrote: > On Thu, Mar 23, 2017 at 01:03:56PM +0100, Geert Uytterhoeven wrote: >> On Thu, Mar 23, 2017 at 12:11 PM, Uwe Kleine-König >> wrote: >> >> Make sure to enable all drivers and subsystems you need when building >> >> your kernel. Th

Re: [PATCH linux-next V2] tty: Disable default console blanking interval

2017-03-23 Thread Austin S. Hemmelgarn
On 2017-03-22 21:32, Scot Doyle wrote: On Wed, 22 Mar 2017, Tim Gardner wrote: BugLink: http://bugs.launchpad.net/bugs/869017 Console blanking is not enabling DPMS power saving (thereby negating any power-saving benefit), and is simply turning the screen content blank. This means that any crash

Re: [PATCH v2] kasan: report only the first error by default

2017-03-23 Thread Mark Rutland
On Thu, Mar 23, 2017 at 02:49:16PM +0300, Andrey Ryabinin wrote: > + kasan_multi_shot > + [KNL] Enforce KASAN (Kernel Address Sanitizer) to print > + report on every invalid memory access. Without this > + parameter KASAN will print re

Re: [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

2017-03-23 Thread Chris Wilson
On Thu, Mar 23, 2017 at 12:22:30PM +, Colin King wrote: > From: Colin Ian King > > info is being checked to see if it is a null pointer, however, vpgu is > dereferencing info before this check, leading to a potential null > pointer dereference. If info is null, then the error message being >

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-23 Thread Uwe Kleine-König
On Thu, Mar 23, 2017 at 01:03:56PM +0100, Geert Uytterhoeven wrote: > Hi Uwe, > > On Thu, Mar 23, 2017 at 12:11 PM, Uwe Kleine-König > wrote: > >> Make sure to enable all drivers and subsystems you need when building > >> your kernel. That's always true. And may indeed be hard to debug (e.g. what

kvm: use-after-free function call in kvm_io_bus_destroy

2017-03-23 Thread Dmitry Vyukov
Hello, I've got the following report while running syzkaller fuzzer on 093b995e3b55a0ae0670226ddfcb05bfbf0099ae. Note the preceding injected kmalloc failure, most likely it's the root cause. FAULT_INJECTION: forcing a failure. name failslab, interval 1, probability 0, space 0, times 0 CPU: 0 PID

[GIT PULL] Immutable branch between MFD, IIO and Input due for the v4.12 merge window

2017-03-23 Thread Lee Jones
Enjoy! The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201: Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-iio-input-v4.12 for you to fetch changes up to b2d4764046

[PATCH v5] KVM: VMX: Fix enable VPID conditions

2017-03-23 Thread Wanpeng Li
From: Wanpeng Li This can be reproduced by running L2 on L1, and disable VPID on L0 if w/o commit "KVM: nVMX: Fix nested VPID vmx exec control", the L2 crash as below: KVM: entry failed, hardware error 0x7 EAX= EBX= ECX= EDX=000306c3 ESI= EDI= EBP=00

Re: [PATCH v3 3/5] coresight: add support for debug module

2017-03-23 Thread Mike Leach
Also agree with Suzuki's excellent summary. A couple of notes on using EDPRCR The logic for this assuming a correctly implemented system should be something like. if (prsr() == powered_down) { // if we are powered down request power up. sw_unlock() // ensure that the sw lock regist

Re: [PATCH v4 7/7] mfd: dt-bindings: Add RK805 device tree bindings document

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Elaine Zhang wrote: > Add device tree bindings documentation for Rockchip's RK805 PMIC. > > Signed-off-by: Elaine Zhang > --- > Documentation/devicetree/bindings/mfd/rk808.txt | 20 +++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/Doc

Re: [PATCH 0/2] serial: Add name field to uart_port

2017-03-23 Thread Vignesh R
On Thursday 23 March 2017 12:16 AM, Andy Shevchenko wrote: > On Tue, Mar 21, 2017 at 3:36 PM, Vignesh R wrote: >> This series adds name attribute to uart_port struct inorder to store >> name of the tty port that will help in identify different uart >> instances. >> This patch series is based on

Re: [PATCH v4 4/7] mfd: rk808: Add RK805 support

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Elaine Zhang wrote: > The RK805 chip is a Power Management IC (PMIC) for multimedia and handheld > devices. It contains the following components: > > - Regulators > - RTC > - Clocking > > Both RK808 and RK805 chips are using a similar register map, > so we can re

sound: use-after-free in snd_seq_cell_alloc

2017-03-23 Thread Dmitry Vyukov
Hello, I've got the following report while running syzkaller fuzzer on 093b995e3b55a0ae0670226ddfcb05bfbf0099ae. Unfortunately this is not reproducible so far. == BUG: KASAN: use-after-free in __lock_acquire+0x39df/0x3a80 kernel/lock

[PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

2017-03-23 Thread Colin King
From: Colin Ian King info is being checked to see if it is a null pointer, however, vpgu is dereferencing info before this check, leading to a potential null pointer dereference. If info is null, then the error message being printed by macro gvt_vgpu_err and this requires vpgu to exist. We can u

Re: [PATCH 0/7] Misc GDT fixes and a cleanup

2017-03-23 Thread Boris Ostrovsky
On 03/22/2017 05:32 PM, Andy Lutomirski wrote: > Hi all- > > This applies to tip:x86/mm. For ease of testing, the series is here, too: > > https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/tag/?h=review_20170322_gdt_and_wp > > This fixes a few issues, most of which appear to be rather

usb: use-after-free write in usb_hcd_link_urb_to_ep

2017-03-23 Thread Dmitry Vyukov
Hello, I've got the following report while running syzkaller fuzzer on 093b995e3b55a0ae0670226ddfcb05bfbf0099ae. Not the preceding injected kmalloc failure, most likely it's the root cause. FAULT_INJECTION: forcing a failure. name failslab, interval 1, probability 0, space 0, times 0 CPU: 0 PID:

Re: [PATCH v4 2/7] mfd: rk808: add rk805 regs addr and ID

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Elaine Zhang wrote: > Signed-off-by: Elaine Zhang > --- > include/linux/mfd/rk808.h | 119 > ++ > 1 file changed, 119 insertions(+) > > diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h > index 54feb140c210..a133

Re: [PATCH 1/2] tty: serial_core: Add name field to uart_port struct

2017-03-23 Thread Vignesh R
On Thursday 23 March 2017 12:15 AM, Andy Shevchenko wrote: > On Tue, Mar 21, 2017 at 3:36 PM, Vignesh R wrote: >> Introduce a field to store name of uart_port that can be used to easily >> identify uart port instances on a system that has more than one uart > > uart -> UART > >> instance. The

Re: [PATCH v4 1/7] mfd: rk808: fix up the chip id get failed

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Elaine Zhang wrote: > the rk8xx chip id is: > ((MSB << 8) | LSB) & 0xfff0 > > Signed-off-by: Elaine Zhang > --- > drivers/mfd/rk808.c | 21 +++-- > include/linux/mfd/rk808.h | 1 + > 2 files changed, 16 insertions(+), 6 deletions(-) For my own refere

Re: [PATCH v3 2/3] mfd: intel_soc_pmic_bxtwc: Move inclusion to c-file

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Andy Shevchenko wrote: > There is no need to include intel_soc_pmic.h into header which doesn't > require it. > > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/intel_soc_pmic_bxtwc.c | 1 + > include/linux/mfd/intel_bxtwc.h| 2 -- > 2 files changed, 1 insertion(+),

Re: [PATCH v3 3/3] mfd: intel_soc_pmic_bxtwc: Rename header to follow c-file

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Andy Shevchenko wrote: > For better understanding of relationship between headers and modules > rename: > intel_bxtwc.h -> intel_soc_pmic_bxtwc.h > > While here, remove file name from the file itself. > > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/intel_soc_p

Re: [PATCH] ARM: gemini: don't select SERIAL_OF_PLATFORM

2017-03-23 Thread Arnd Bergmann
On Thu, Mar 23, 2017 at 11:22 AM, Linus Walleij wrote: > On Tue, Mar 21, 2017 at 9:52 PM, Arnd Bergmann wrote: > >> We cannot select the option when SERIAL_8250 is not also set: >> >> warning: (ARCH_GEMINI) selects SERIAL_OF_PLATFORM which has unmet direct >> dependencies (TTY && HAS_IOMEM && SE

Re: [PATCH] blk-mq: don't complete un-started request in timeout handler

2017-03-23 Thread Ming Lei
On Wed, Mar 22, 2017 at 11:58:17AM -0400, Keith Busch wrote: > On Tue, Mar 21, 2017 at 11:03:59PM -0400, Jens Axboe wrote: > > On 03/21/2017 10:14 PM, Ming Lei wrote: > > > When iterating busy requests in timeout handler, > > > if the STARTED flag of one request isn't set, that means > > > the requ

Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Andy Shevchenko wrote: > Crystal Cove and Whiskey Cove are two different PMICs which are > installed on Intel Atom SoC based platforms. > > Moreover there are two independent drivers that by some reason were > supposed (*) to get into one kernel module. > > Fix the mess by c

Re: [PATCH 2/7] iommu/iova: cut down judgement times

2017-03-23 Thread Robin Murphy
On 22/03/17 06:27, Zhen Lei wrote: > Below judgement can only be satisfied at the last time, which produced 2N > judgements(suppose N times failed, 0 or 1 time successed) in vain. > > if ((pfn >= iova->pfn_lo) && (pfn <= iova->pfn_hi)) { > return iova; > } For me, GCC (6.2.1 AArch64) seems

Re: [RFC][PATCH 2/4] printk: offload printing from wake_up_klogd_work_func()

2017-03-23 Thread Petr Mladek
On Thu 2017-03-23 18:00:42, Sergey Senozhatsky wrote: > On (03/20/17 17:09), Petr Mladek wrote: > [..] > > > > BTW: wake_up_klogd_work does not need to be per-CPU as well. > > irq_work infrastructure heavily uses per-CPU variables. > > But a global struct irq_work is safe, see irq_work_claim(). >

net/kcm: double free of kcm inode

2017-03-23 Thread Dmitry Vyukov
Hello, I've got the following report while running syzkaller fuzzer. Note the preceding kmem_cache_alloc injected failure, it's most likely the root cause. FAULT_INJECTION: forcing a failure. name failslab, interval 1, probability 0, space 0, times 0 CPU: 1 PID: 21839 Comm: syz-executor4 Not tain

Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-23 Thread Paul Moore
On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler wrote: > Ping? Any feedback on this patch? It's on my list of patches to review, patience please. > On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke wrote: >> >> 'perms' will never be NULL since it isn't a plain pointer but an array >> of u32 va

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-23 Thread Geert Uytterhoeven
Hi Uwe, On Thu, Mar 23, 2017 at 12:11 PM, Uwe Kleine-König wrote: >> Make sure to enable all drivers and subsystems you need when building >> your kernel. That's always true. And may indeed be hard to debug (e.g. what >> kernel options do I need to make systemd work?). > > It's worse here. If you

Re: [PATCH v4] KVM: VMX: Fix enable VPID even if INVVPID is not exposed in vmx capability

2017-03-23 Thread David Hildenbrand
On 23.03.2017 03:39, Wanpeng Li wrote: > From: Wanpeng Li > > This can be reproduced by running L2 on L1, and disable VPID on L0 > if w/o commit "KVM: nVMX: Fix nested VPID vmx exec control", the L2 > crash as below: > > KVM: entry failed, hardware error 0x7 > EAX= EBX= ECX=000

[PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-23 Thread Daniel Baluta
From: Nicolin Chen WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better to control the MCLK in codec driver. Thus remove the clock enable in machine dirver accordingly. While at it, get rid of imx_wm8962_remove function since it is now empty. Signed-off-by: Nicolin Chen Sign

Re: [PATCH] drm/fb-helper: Allow var->x/yres(_virtual) < fb->width/height again

2017-03-23 Thread Daniel Stone
Hi Michel, On 23 March 2017 at 08:53, Michel Dänzer wrote: > Otherwise this can also prevent modesets e.g. for switching VTs, when > multiple monitors with different native resolutions are connected. > > The depths must match though, so keep the != test for that. > > Also update the DRM_DEBUG out

Re: [RFC][PATCH 0/4] printk: introduce printing kernel thread

2017-03-23 Thread Petr Mladek
On Wed 2017-03-22 18:59:20, Peter Zijlstra wrote: > On Mon, Mar 06, 2017 at 09:45:50PM +0900, Sergey Senozhatsky wrote: > > sysrq is potentially even trickier. can we always wake_up() kernel > > thread from sysrq? there probably might be cases when we can't rely > > on the scheduler. > > sysrq

Re: [PATCH v6 2/2] soc/imx: Add GPCv2 power gating driver

2017-03-23 Thread Dong Aisheng
On Mon, Mar 20, 2017 at 01:34:19PM -0700, Andrey Smirnov wrote: > On Mon, Mar 20, 2017 at 12:03 AM, Dong Aisheng wrote: > > On Thu, Mar 16, 2017 at 06:30:50AM -0700, Andrey Smirnov wrote: > >> Add code allowing for control of various power domains managed by GPCv2 > >> IP block found in i.MX7 seri

Re: [PATCH] staging: tsl2x7x: Moved contents of the header to the source file.

2017-03-23 Thread Lars-Peter Clausen
On 03/23/2017 12:53 PM, Arushi Singhal wrote: > Moved the contents of the header(tsl2x7x.h) into the source file > tsl2x7x_core.c with the exception of the platform data struct which is > supposed to be used from somewhere else other than the driver. The platform_data struct uses the other structs

Re: [GIT PULL] Immutable branch between MFD and PHY due for the v4.12 merge window

2017-03-23 Thread Krzysztof Kozlowski
On Thu, Mar 23, 2017 at 12:51 PM, Lee Jones wrote: > Enjoy! > > The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201: > > Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git

[PATCH V2] i2c: tegra-bpmp: Enable Tegra BPMP I2C adapter

2017-03-23 Thread Jon Hunter
Enable the Tegra BPMP I2C adapter by default if the Tegra BPMP itself is enabled. This adapter is used as the I2C interface for the PMIC on the Tegra186 Jetson-TX2 platform. Signed-off-by: Jon Hunter Acked-by: Thierry Reding --- Changes since V1: - Dropped redundant 'if' condition from 'default

[PATCH] [media] coda: remove redundant call to v4l2_m2m_get_vq

2017-03-23 Thread Colin King
From: Colin Ian King The call to v4ls_m2m_get_vq is only used to get the return value which is not being used, so it appears to be redundant and can be removed. Detected with CoverityScan, CID#1420674 ("Useless call") Signed-off-by: Colin Ian King --- drivers/media/platform/coda/coda-common.c

[PATCH] staging: tsl2x7x: Moved contents of the header to the source file.

2017-03-23 Thread Arushi Singhal
Moved the contents of the header(tsl2x7x.h) into the source file tsl2x7x_core.c with the exception of the platform data struct which is supposed to be used from somewhere else other than the driver. Signed-off-by: Arushi Singhal --- drivers/staging/iio/light/tsl2x7x.h | 57 -

Re: [PATCH v5 06/13] powerpc/perf: IMC pmu cpumask and cpu hotplug support

2017-03-23 Thread Gautham R Shenoy
Hi Hemant, Maddy, On Thu, Mar 16, 2017 at 01:05:00PM +0530, Madhavan Srinivasan wrote: > From: Hemant Kumar > > Adds cpumask attribute to be used by each IMC pmu. Only one cpu (any > online CPU) from each chip for nest PMUs is designated to read counters. > > On CPU hotplug, dying CPU is check

Re: [PATCH 05/13] platform/chrome: cros_ec_lpc: Add R/W helpers to LPC protocol variants

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Enric Balletbo i Serra wrote: > From: Shawn Nematbakhsh > > Call common functions for read / write to prepare support for future > LPC protocol variants which use different I/O ops than inb / outb. > > Signed-off-by: Shawn Nematbakhsh > Signed-off-by: Thierry Escande > --

Re: [PATCH 06/13] platform/chrome: cros_ec_lpc: Add support for mec1322 EC

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Enric Balletbo i Serra wrote: > From: Shawn Nematbakhsh > > This adds support for the ChromeOS LPC Microchip Embedded Controller > (mec1322) variant. > > mec1322 accesses I/O region [800h, 9ffh] through embedded memory > interface (EMI) rather than LPC. > > Signed-off-by:

[PATCH] qla2xxx: remove redundant check on sess being non-null

2017-03-23 Thread Colin King
From: Colin Ian King All error paths to label out_term2 result in sess being null, so the check for sess being non-null and the call to put_sess is dead code and can therefore be removed. Detected with CoverityScan, CID#1420664 ("Logically dead code") Signed-off-by: Colin Ian King --- drivers

Re: [PATCH] ARM: nommu: access ID_PFR1 only if CPUID scheme

2017-03-23 Thread Greg Ungerer
Hi Afzal, On 23/03/17 20:43, afzal mohammed wrote: On Fri, Mar 17, 2017 at 10:10:34PM +0530, afzal mohammed wrote: Greg upon trying to boot no-MMU Kernel on ARM926EJ reported boot failure. He root caused it to ID_PFR1 access introduced by the commit mentioned in the fixes tag below. All CP15 p

Re: [PATCH] video: fbdev: pmag-aa-fb: remove incorrect __exit markups

2017-03-23 Thread Maciej W. Rozycki
On Mon, 20 Mar 2017, Bartlomiej Zolnierkiewicz wrote: > > Even if bus is not hot-pluggable, devices can be unbound from the > > driver via sysfs, so we should not be using __exit annotations on > > remove() methods. The only exception is drivers registered with > > platform_driver_probe() which sp

[GIT PULL] Immutable branch between MFD and GPIO due for the v4.12 merge window

2017-03-23 Thread Lee Jones
Enjoy, The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201: Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-gpio-v4.12 for you to fetch changes up to 9f7c7ceefe5e824e

Re: [PATCH v5 3/3] mfd: wm831x: Add device tree binding document

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Charles Keepax wrote: > Add a device tree binding document for the wm831x series of PMICs. > Currently only support for the registering the device and the GPIOs are > actually implemented in the driver. > > Signed-off-by: Charles Keepax > --- > > Changes since v4: > - Remo

[PATCH v2] kasan: report only the first error by default

2017-03-23 Thread Andrey Ryabinin
Disable kasan after the first report. There are several reasons for this: * Single bug quite often has multiple invalid memory accesses causing storm in the dmesg. * Write OOB access might corrupt metadata so the next report will print bogus alloc/free stacktraces. * Reports after the fi

Re: [PATCH v5 1/3] mfd: wm831x: Add basic device tree binding

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Charles Keepax wrote: > Add the basic ability to register the device through device tree, more > work is needed to get each individual sub-driver functioning correctly > but this is enough to get the device to probe from device tree. > > Signed-off-by: Charles Keepax > --- >

Re: [PATCH v5 2/3] gpio: wm831x: Add basic device tree support

2017-03-23 Thread Lee Jones
On Fri, 17 Mar 2017, Charles Keepax wrote: > Now the wm831x-core has basic DT support we can update this driver to > allow use of the GPIOs within a device tree system. > > Signed-off-by: Charles Keepax > Acked-by: Linus Walleij > --- > > No changes since v4, still should go through Lee's tree

Re: [PATCH] scsi: fcoe: sanity check string size for store_ctrl_mode option

2017-03-23 Thread Dan Carpenter
On Wed, Mar 22, 2017 at 07:42:08PM +, Colin Ian King wrote: > On 22/03/17 19:39, Dan Carpenter wrote: > > On Wed, Mar 22, 2017 at 02:01:37PM +, Colin King wrote: > >> From: Colin Ian King > >> > >> Reading and writing to mode[count - 1] implies the count should not > >> be less than 1 so a

[PATCH] staging: rtl8192e: Fix embedded function names with __func__

2017-03-23 Thread suniel . spartan
From: Suniel Mahesh Prefer and make it generic by using %s and __func__ to print functions name instead of embedding functions name in print statements Signed-off-by: Suniel Mahesh --- drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 22 +++--- 1 file changed, 11 insertions(+), 11

Re: [PATCH] staging: ad7746: Moved contents of the header to the source file.

2017-03-23 Thread Lars-Peter Clausen
On 03/23/2017 12:36 PM, Arushi Singhal wrote: > Moved the contents of the header(ad7746.h) into the source file > ad7746.c with the exception of the platform data struct which is > supposed to be used from somewhere else other than the driver. > > Signed-off-by: Arushi Singhal > --- > drivers/st

Re: [PATCH 1/7] iommu/iova: fix incorrect variable types

2017-03-23 Thread Robin Murphy
On 22/03/17 06:27, Zhen Lei wrote: > Keep these four variables type consistent with the paramters of function > __alloc_and_insert_iova_range and the members of struct iova: > > 1. static int __alloc_and_insert_iova_range(struct iova_domain *iovad, > unsigned long size, unsigned long

[PATCH] staging: ad7746: Moved contents of the header to the source file.

2017-03-23 Thread Arushi Singhal
Moved the contents of the header(ad7746.h) into the source file ad7746.c with the exception of the platform data struct which is supposed to be used from somewhere else other than the driver. Signed-off-by: Arushi Singhal --- drivers/staging/iio/cdc/ad7746.c | 5 + drivers/staging/iio/cdc/ad

[PATCH 2/4] sched: cpudeadline: don't re-initialize struct cpudl

2017-03-23 Thread Viresh Kumar
The struct cpudl passed to cpudl_init() is already initialized to zero. Don't do that again. Signed-off-by: Viresh Kumar --- kernel/sched/cpudeadline.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c index fba235c7d026..a51e91bf3907 10

[PATCH 1/4] sched: topology: drop memset() from init_rootdomain()

2017-03-23 Thread Viresh Kumar
There are only two callers of init_rootdomain(). One of them passes a global to it and another one sends dynamically allocated root-domain. There is no need to memset the root-domain in the first case as the structure is already reset. Update alloc_rootdomain() to allocate the memory with kzalloc

<    3   4   5   6   7   8   9   10   11   >