[PATCH v3 12/37] mtd: nand: denali: support 1024 byte ECC step size

2017-03-29 Thread Masahiro Yamada
This driver was originally written for the Intel MRST platform with several platform specific parameters hard-coded. Another thing we need to fix is the hard-coded ECC step size. Currently, it is defined as follows: #define ECC_SECTOR_SIZE 512 (somehow, it is defined in both denali.c and dena

[PATCH v3 29/37] mtd: nand: denali: merge struct nand_buf into struct denali_nand_info

2017-03-29 Thread Masahiro Yamada
Now struct nand_buf has only two members, so I see no reason for the separation. Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - Newly added drivers/mtd/nand/denali.c | 29 ++--- drivers/mtd/nand/denali.h | 8 ++-- 2 files changed, 16 inse

[PATCH v3 22/37] mtd: nand: denali: rework interrupt handling

2017-03-29 Thread Masahiro Yamada
Simplify the interrupt handling and fix issues: - The register field view of INTR_EN / INTR_STATUS is different among IP versions. The global macro DENALI_IRQ_ALL is hard-coded for Intel platforms. The interrupt mask should be determined at run-time depending on the running platform. - wa

[PATCH v3 24/37] mtd: nand: denali: fix NAND_CMD_PARAM handling

2017-03-29 Thread Masahiro Yamada
NAND_CMD_PARAM is not working at all due to multiple bugs. [1] The command 0x90 issued instead of 0xec The command code 0x90 is hard-code as index_addr(denali, addr | 0, 0x90) So, Read ID (0x90) command is sent to the device instead of Read Parameter Page (0xec). [2] only first 8 bytes are re

[PATCH v3 00/37] mtd: nand: denali: 2nd round of Denali NAND IP patch bomb

2017-03-29 Thread Masahiro Yamada
This driver includes many problems. One of the biggest one is a bunch of hard-coded parameters. This IP has many parameters that can be customized when a delivery RTL is generated. However, this driver was upstreamed by Intel, with Intel parameters hard-coded. Later, Altera added denali_dt.c t

[PATCH v3 16/37] mtd: nand: denali_dt: add compatible strings for UniPhier SoC variants

2017-03-29 Thread Masahiro Yamada
Add two compatible strings for UniPhier SoCs. "socionext,uniphier-denali-nand-v5a" is used on UniPhier sLD3, LD4, Pro4, sLD8 SoCs. "socionext,uniphier-denali-nand-v5b" is used on UniPhier Pro5, PXs2, LD6b, LD11, LD20 SoCs. Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2:

[PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-03-29 Thread Masahiro Yamada
Historically, this driver tried to choose as big ECC strength as possible, but it would be reasonable to allow DT to set a particular ECC strength with "nand-ecc-strength" property. This is useful when a particular ECC setting is hard-coded by firmware (or hard- wired by boot ROM). If no ECC stre

[PATCH v3 13/37] mtd: nand: denali: avoid hard-coding ecc.strength and ecc.bytes

2017-03-29 Thread Masahiro Yamada
Another problem of this driver is hard-coded ecc.strength and ecc.bytes. Currently ecc.bytes is defined as follows: #define ECC_8BITS 14 #define ECC_15BITS26 The parameters were hard-coded because only the following two cases are possible on Intel platforms: - ecc.size = 512, ecc.s

[PATCH v3 23/37] mtd: nand: denali: fix NAND_CMD_STATUS handling

2017-03-29 Thread Masahiro Yamada
The current NAND_CMD_STATUS handling is weird; it just reads the WRITE_PROTECT register, and returns NAND_STATUS_WP if it is set. It does not send Read Status (0x70) command, so it is not helpful for checking the current device status. Signed-off-by: Masahiro Yamada --- Changes in v3: None Chan

[PATCH v3 07/37] mtd: nand: denali_dt: enable HW_ECC_FIXUP for Altera SOCFPGA variant

2017-03-29 Thread Masahiro Yamada
There are various customizable parameters, so several variants for this IP. A generic compatible like "denali,denali-nand-dt" is useless. Moreover, there are multiple things wrong with this string. (Refer to Rob's comment [1]) The "denali,denali-nand-dt" was added by Altera for the SOCFPGA port.

[PATCH v3 10/37] mtd: nand: denali_dt: use pdev instead of ofdev for platform_device

2017-03-29 Thread Masahiro Yamada
"pdev" is much more often used to point a platform_device, so this will help the driver code look consistent across the kernel. While we are here, fix "line over 80 characters" coding style violations. Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: None drivers/mtd/nand

Re: [RFC PATCH tip/master 2/3] kprobes: Allocate kretprobe instance if its free list is empty

2017-03-29 Thread Ingo Molnar
* Masami Hiramatsu wrote: > > So this is something I missed while the original code was merged, but the > > concept > > looks a bit weird: why do we do any "allocation" while a handler is > > executing? > > > > That's fundamentally fragile. What's the maximum number of parallel > > 'kretpro

[PATCH v3 03/37] mtd: nand: denali: remove meaningless pipeline read-ahead operation

2017-03-29 Thread Masahiro Yamada
The pipeline read-ahead function of the Denali IP enables continuous reading from the device; while data is being read out by a CPU, the controller maintains additional commands for streaming data from the device. This will reduce the latency of the second page or later. This feature is obviously

[PATCH v3 05/37] mtd: nand: denali: fix erased page checking

2017-03-29 Thread Masahiro Yamada
This part is wrong in multiple ways: [1] is_erased() is called against "buf" twice, so the OOB area is not checked at all. The second call should check chip->oob_poi. [2] This code block is nested by double "if (check_erase_page)". The inner one is redundant. [3] The ECC_ERROR_ADDRESS register

[PATCH v3 08/37] mtd: nand: denali: support 64bit capable DMA engine

2017-03-29 Thread Masahiro Yamada
The current driver only supports the DMA engine up to 32 bit physical address, but there also exists 64 bit capable DMA engine for this IP. The data DMA setup sequence is completely different, so I added the 64 bit DMA code as a new function denali_setup_dma64(). The 32 bit one has been renamed t

[PATCH v3 04/37] mtd: nand: denali: fix bitflips calculation in handle_ecc()

2017-03-29 Thread Masahiro Yamada
This function is wrong in multiple ways: [1] Counting corrected bytes instead of corrected bits. The following code is counting the number of corrected _bytes_. /* correct the ECC error */ buf[offset] ^= err_cor_value; mtd->ecc_stats.corrected++; bitflips++; What the core framew

[PATCH v3 18/37] mtd: nand: denali: do not propagate NAND_STATUS_FAIL to waitfunc()

2017-03-29 Thread Masahiro Yamada
Currently, the error handling of denali_write_page(_raw) is a bit complicated. If the program command fails, NAND_STATUS_FAIL is set to the driver internal denali->status, then read out later by denali_waitfunc(). We can avoid it by exploiting the nand_write_page() implementation. If chip->ecc.wr

[PATCH v3 06/37] mtd: nand: denali: support HW_ECC_FIXUP capability

2017-03-29 Thread Masahiro Yamada
Some old versions of the Denali IP (perhaps used only for Intel?) detects ECC errors and provides correct data via a register, but does not touch the transferred data. So, the software must fixup the data in the buffer according to the provided ECC correction information. Newer versions perform E

Re: [PATCH] drm/i915: fix build error without CONFIG_BACKLIGHT_CLASS_DEVICE

2017-03-29 Thread Jani Nikula
On Wed, 29 Mar 2017, Tobias Regnery wrote: > With CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=n we see the following > link error in the i915 driver: > > drivers/built-in.o: In function 'intel_backlight_device_register': > (.text+0x2a921d): undefined reference to 'backlight_device_register' >

[PATCH v3 09/37] mtd: nand: denali_dt: remove dma-mask DT property

2017-03-29 Thread Masahiro Yamada
The driver sets appropriate DMA mask. Delete the "dma-mask" DT property. See [1] for negative comments for this binding. [1] https://lkml.org/lkml/2016/2/8/57 Signed-off-by: Masahiro Yamada Acked-by: Rob Herring --- Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/

[PATCH v3 11/37] mtd: nand: denali: allow to override revision number

2017-03-29 Thread Masahiro Yamada
Commit 271707b1d817 ("mtd: nand: denali: max_banks calculation changed in revision 5.1") added a revision check to support the new max_banks encoding. Its git-log states "The encoding of max_banks changed in Denali revision 5.1". There are exceptional cases, for example, the revision register on

[PATCH v3 02/37] mtd: nand: denali: allow to override mtd->name from label DT property

2017-03-29 Thread Masahiro Yamada
Commit 28309572aac4 ("mtd: name the mtd device with an optional label property") allow us to identify a chip in a user-friendly way. If nand_set_flash_node() picks up the "label" from DT, let's respect it. Otherwise, let it fallback to the current name "denali-nand". Signed-off-by: Masahiro Yama

[PATCH v3 27/37] mtd: nand: denali: use interrupt instead of polling for bank reset

2017-03-29 Thread Masahiro Yamada
The current bank reset implementation polls the INTR_STATUS register until interested bits are set. This is not good because: - it simply wastes time-slice of the thread which the driver module is loaded from. - The while() loop may continue eternally if no bit is set, for example, due to th

[PATCH v3 21/37] mtd: nand: denali: handle timing parameters by setup_data_interface()

2017-03-29 Thread Masahiro Yamada
The timing parameter handling in this driver is bad in multiple ways. [1] The ONFi Timing Mode is specified by the module parameter "onfi_timing_mode". Users are free to set any Timing Mode that may not be supported on the device. [2] The function nand_onfi_timing_set() holds many parame

[PATCH v3 25/37] mtd: nand: denali: switch over to cmd_ctrl instead of cmdfunc

2017-03-29 Thread Masahiro Yamada
The NAND_CMD_SET_FEATURES support is missing from denali_cmdfunc(). This is needed for nand_onfi_set_features(). Besides, we see /* TODO: Read OOB data */ comment line. It would be possible to add more commands along with the current implementation, but having ->cmd_ctrl() seems a better approach

[PATCH v3 30/37] mtd: nand: denali: use flag instead of register macro for direction

2017-03-29 Thread Masahiro Yamada
It is not a good idea to re-use macros that represent a specific register bit field for the transfer direction. It is true that bit 8 indicates the direction for the MAP10 pipeline operation and the data DMA operation, but this is not valid across the IP. Use a simple flag (write: 1, read: 0) for

Re: in_irq_or_nmi() and RFC patch

2017-03-29 Thread Peter Zijlstra
On Wed, Mar 29, 2017 at 09:44:41PM +0200, Jesper Dangaard Brouer wrote: > @@ -2481,7 +2481,11 @@ void free_hot_cold_page(struct page *page, bool cold) > unsigned long pfn = page_to_pfn(page); > int migratetype; > > - if (in_interrupt()) { > + /* > + * Exclude (hard) IRQ a

[PATCH v3 28/37] mtd: nand: denali: propagate page to helpers via function argument

2017-03-29 Thread Masahiro Yamada
This driver stores the currently addressed page into denali->page, which is later read out by helper functions. While I am tackling on this driver, I often missed to insert "denali->page = page;" where necessary. This makes page_read/write callbacks to get access to a wrong page, which is a bug h

[PATCH v3 19/37] mtd: nand: denali: use BIT() and GENMASK() for register macros

2017-03-29 Thread Masahiro Yamada
Make register field macros more readable especially for comparing the macros and the register description in the Denali User's Guide. Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: - Newly added drivers/mtd/nand/denali.h | 244 ++

[PATCH v3 17/37] mtd: nand: denali: set NAND_ECC_CUSTOM_PAGE_ACCESS

2017-03-29 Thread Masahiro Yamada
The denali_cmdfunc() actually does nothing valuable for NAND_CMD_{PAGEPROG,READ0,SEQIN}. For NAND_CMD_{READ0,SEQIN}, it copies "page" to "denali->page", then denali_read_page() and denali_read_page_raw() compare them to check if the NAND framework called the callbacks in correct order. (Inconsiste

[PATCH v3 26/37] mtd: nand: denali: fix bank reset function

2017-03-29 Thread Masahiro Yamada
The function denali_nand_reset() is called during the driver probe, and polls the INTR__RST_COMP and INTR__TIME_OUT bits. However, INTR__RST_COMP is set anyway even if no NAND device is connected to that bank. This can be a problem for ONFi devices. The nand_scan_ident() iterates over maxchips,

[PATCH v3 15/37] mtd: nand: denali: remove Toshiba and Hynix specific fixup code

2017-03-29 Thread Masahiro Yamada
The Denali IP can automatically detect device parameters such as page size, oob size, device width, etc. and this driver currently relies on it. However, this hardware function is known to be problematic. [1] Due to a hardware bug, various misdetected cases were reported. That is why get_tosh

[PATCH v3 20/37] mtd: nand: denali: remove unneeded find_valid_banks()

2017-03-29 Thread Masahiro Yamada
The function find_valid_banks() issues the Read ID (0x90) command, then compares the first byte (Manufacturer ID) of each bank with the one of bank0. This is equivalent to what nand_scan_ident() does. The number of chips is detected there, so this is unneeded. What is worse for find_valid_banks(

[PATCH v3 01/37] mtd: nand: relax ecc.read_page() return value for uncorrectable ECC

2017-03-29 Thread Masahiro Yamada
The comment for ecc.read_page() requires that it should return "0 if bitflips uncorrectable". Actually, drivers could return positive values when uncorrectable bitflips occur. For example, nand_read_page_swecc() is the case. If ecc.correct() returns -EBADMSG for the first ECC sector, and a positi

[PATCH 1/2] arm64: dts: add drive-strength levels of pin for Hi3660 SoC

2017-03-29 Thread Wang Xiaoyin
Add drive-strength levels of pin for Hi3660 Soc. Signed-off-by: Wang Xiaoyin --- include/dt-bindings/pinctrl/hisi.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/dt-bindings/pinctrl/hisi.h b/include/dt-bindings/pinctrl/hisi.h index 38f1ea879ea1..0359bfdc9119 10064

[PATCH 2/2] arm64: dts: add pinctrl dtsi file for HiKey960 development board

2017-03-29 Thread Wang Xiaoyin
Add pinctrl dtsi file for HiKey960 development board, enable 5 pinmux devices and 1 pinconf device, also include some nodes of configurations for pins. Signed-off-by: Wang Xiaoyin --- arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 + .../arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi |

[PATCH v3 2/2] usb: otg-fsm: Prevent build warning "VDBG" redefined

2017-03-29 Thread Roger Quadros
If usb/otg-fsm.h and usb/composite.h are included together then it results in the build warning [1]. Prevent that by defining VDBG locally. Also get rid of MPC_LOC which doesn't seem to be used by anyone. [1] - warning fixed by this patch: In file included from drivers/usb/dwc3/core.h:33, fr

[PATCH v3 0/2] usb: dwc3: trivial fixes.

2017-03-29 Thread Roger Quadros
Hi Felipe, Resending this series rebased on v4.11-rc4. Changelog: v3: -rebased on v4.11-rc4 v2: -include bitops.h header cheers, -roger Roger Quadros (2): usb: dwc3: use BIT() macro where possible usb: otg-fsm: Prevent build warning "VDBG" redefined drivers/usb/common/usb-otg-fsm.c | 7

Re: [BUG nohz]: wrong user and system time accounting

2017-03-29 Thread Wanpeng Li
Cc Peterz, Thomas, 2017-03-30 12:27 GMT+08:00 Mike Galbraith : > On Wed, 2017-03-29 at 16:08 -0400, Rik van Riel wrote: > >> In other words, the tick on cpu0 is aligned >> with the tick on the nohz_full cpus, and >> jiffies is advanced while the nohz_full cpus >> with an active tick happen to be in

Re: [RFC PATCH v1 00/30] fs: inode->i_version rework and optimization

2017-03-29 Thread Jan Kara
On Wed 29-03-17 13:54:31, Jeff Layton wrote: > On Wed, 2017-03-29 at 13:15 +0200, Jan Kara wrote: > > On Tue 21-03-17 14:46:53, Jeff Layton wrote: > > > On Tue, 2017-03-21 at 14:30 -0400, J. Bruce Fields wrote: > > > > On Tue, Mar 21, 2017 at 01:23:24PM -0400, Jeff Layton wrote: > > > > > On Tue, 2

[PATCH v3 1/2] usb: dwc3: use BIT() macro where possible

2017-03-29 Thread Roger Quadros
To avoid checkpatch warnings with new patches let's start using the BIT() macro wherever possible. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.h | 193 ++- drivers/usb/dwc3/dwc3-omap.c | 48 +-- drivers/usb/dwc3/gadget.h| 20 +

sudo x86info -a => kernel BUG at mm/usercopy.c:78!

2017-03-29 Thread Tommi Rantala
Hi, Running: $ sudo x86info -a On this HP ZBook 15 G3 laptop kills the x86info process with segfault and produces the following kernel BUG. $ git describe v4.11-rc4-40-gfe82203 It is also reproducible with the fedora kernel: 4.9.14-200.fc25.x86_64 Full dmesg output here: https://past

Re: [PATCH] serial: Do not treat the IIR register as a bitfield

2017-03-29 Thread Olliver Schinagl
On March 30, 2017 8:15:29 AM CEST, Vignesh R wrote: >Hi, > >On Thursday 30 March 2017 12:14 AM, Olliver Schinagl wrote: >> diff --git a/include/uapi/linux/serial_reg.h >b/include/uapi/linux/serial_reg.h >> index 5db76880b4ad..489522389a10 100644 >> --- a/include/uapi/linux/serial_reg.h >> +++ b/

Re: [PATCH 4/8] asm-generic: add atomic-instrumented.h

2017-03-29 Thread Ingo Molnar
* Mark Rutland wrote: > With some minimal CPP, it can be a lot more manageable: > > > #define INSTR_ATOMIC_XCHG(order) \ > static __always_inline int atomic_xchg##order(atomic_t *v, int i) \ > {

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Michał Kępień
> On Thu, Mar 30, 2017 at 02:26:26PM +1030, Jonathan Woithe wrote: > > On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote: > > > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > > > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? > > > > wrote: > > > > > > > > > D

[PATCH] iio:meter:ade7759: Removing use of deprecated macros

2017-03-29 Thread Chen Guanqiao
Removing use of deprecated macros(S_IRUGO, SIWUGO, S_IXUGO), and replaced with 4 gidit octal. Signed-off-by: Chen Guanqiao --- drivers/staging/iio/meter/ade7759.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/staging/iio/meter/ade7759.c

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

2017-03-29 Thread Roger Quadros
Hi, On 29/03/17 16:15, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: @@ -839,6 +841,505 @@ static int dwc3_core_get_phy(struct dwc3 *dwc) return 0; } +static int dwc3_drd_start_host(struct dwc3 *dwc, int on, bool skip); +static int dwc3_drd_start_gadg

Re: [RESEND][PATCH] TOMOYO: Use designated initializers

2017-03-29 Thread James Morris
On Wed, 29 Mar 2017, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Sig

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

2017-03-29 Thread Amir Goldstein
On Thu, Mar 30, 2017 at 8:53 AM, Ralph Sennhauser wrote: > Hi Richard, > > On Thu, 30 Mar 2017 00:15:31 +0200 > Richard Weinberger wrote: > >> Ralph, >> >> Am 29.03.2017 um 23:26 schrieb Ralph Sennhauser: >> >> # create and link a tmpfile - then remove it >> >> sudo rm -rf foo; sudo xfs_io -T -c

[PATCH 2/2] staging: atomisp: use local variable to reduce the number of reference

2017-03-29 Thread Daeseok Youn
Define new local variable to reduce the number of reference. The new local variable is added to save the addess of dfs and used in atomisp_freq_scaling() function. Signed-off-by: Daeseok Youn --- .../media/atomisp/pci/atomisp2/atomisp_cmd.c | 37 -- 1 file changed, 20 i

[PATCH 1/2] staging: atomisp: simplify the if condition in atomisp_freq_scaling()

2017-03-29 Thread Daeseok Youn
The condition line in if-statement is needed to be shorthen to improve readability. Signed-off-by: Daeseok Youn --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomi

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-29 Thread Michal Hocko
On Wed 29-03-17 16:25:18, Ilya Dryomov wrote: > On Wed, Mar 29, 2017 at 1:16 PM, Michal Hocko wrote: > > On Wed 29-03-17 13:10:01, Ilya Dryomov wrote: > >> On Wed, Mar 29, 2017 at 12:55 PM, Michal Hocko wrote: > >> > On Wed 29-03-17 12:41:26, Michal Hocko wrote: > >> > [...] > >> >> > ceph_con_wo

Re: Including Alpine -next tree in linux-next

2017-03-29 Thread Antoine Tenart
Hi Stephen, On Thu, Mar 30, 2017 at 09:29:09AM +1100, Stephen Rothwell wrote: > On Wed, 29 Mar 2017 15:21:48 +0200 Antoine Tenart > wrote: > > On Thu, Mar 30, 2017 at 12:14:54AM +1100, Stephen Rothwell wrote: > > > On Wed, 29 Mar 2017 15:12:01 +0200 Antoine Tenart > > > wrote: > > > > Would

Re: [PATCHv2 6/8] x86/dump_pagetables: Add support 5-level paging

2017-03-29 Thread Ingo Molnar
* Kirill A. Shutemov wrote: > On Wed, Mar 29, 2017 at 12:15:07AM +0300, Kirill A. Shutemov wrote: > > I'll try to look more into this issue tomorrow. > > Putting this commit before seems f2a6a7050109 ("x86: Convert the rest of > the code to support p4d_t") seems fixes the issue. Ok, I've appli

Re: [PATCH] serial: Do not treat the IIR register as a bitfield

2017-03-29 Thread Vignesh R
Hi, On Thursday 30 March 2017 12:14 AM, Olliver Schinagl wrote: > diff --git a/include/uapi/linux/serial_reg.h b/include/uapi/linux/serial_reg.h > index 5db76880b4ad..489522389a10 100644 > --- a/include/uapi/linux/serial_reg.h > +++ b/include/uapi/linux/serial_reg.h > @@ -31,18 +31,18 @@ > #defin

Re: [PATCH 2/2] nvmem: imx-ocotp: add write support

2017-03-29 Thread Sascha Hauer
On Mon, Mar 27, 2017 at 10:42:06AM -0300, Fabio Estevam wrote: > [Adding Pengutronix folks and Shawn on Cc] > > On Mon, Mar 27, 2017 at 10:31 AM, Richard Leitner > wrote: > > Implement write routine for OCOTP controller found in i.MX6 SoC's. > > Furthermore add locking to the read function to pre

Re: [PATCH] mm,hugetlb: compute page_size_log properly

2017-03-29 Thread Michal Hocko
On Wed 29-03-17 10:45:14, Andi Kleen wrote: > On Wed, Mar 29, 2017 at 10:06:25AM +0200, Michal Hocko wrote: > > On Tue 28-03-17 10:54:08, Matthew Wilcox wrote: > > > On Tue, Mar 28, 2017 at 09:55:13AM -0700, Davidlohr Bueso wrote: > > > > Do we have any consensus here? Keeping SHM_HUGE_* is current

Re: [PATCH 1/6] virtio: wrap find_vqs

2017-03-29 Thread Jason Wang
On 2017年03月30日 04:48, Michael S. Tsirkin wrote: We are going to add more parameters to find_vqs, let's wrap the call so we don't need to tweak all drivers every time. Signed-off-by: Michael S. Tsirkin --- A quick glance and it looks ok, but what the benefit of this series, is it required by

Re: [RFC 0/1] add support for reclaiming priorities per mem cgroup

2017-03-29 Thread Minchan Kim
To memcg maintainer, Could you comment about this topic? On Fri, Mar 17, 2017 at 04:16:35PM -0700, Tim Murray wrote: > Hi all, > > I've been working to improve Android's memory management and drop > lowmemorykiller from the kernel, and I'd like to get some feedback on a small > patch with a lo

linux-next: Tree for Mar 30

2017-03-29 Thread Stephen Rothwell
Hi all, Changes since 20170329: Undropped tree: xen-tip The vfs tree gained a conflict against Linus' tree. The drm tree gained conflicts against the drm-intel-fixes tree. The mailbox tree lost its build failure. The phy-next tree gained a build failure, so I used the version from

Re: [PATCH v8 3/3] printk: fix double printing with earlycon

2017-03-29 Thread Sergey Senozhatsky
On (03/28/17 14:56), Petr Mladek wrote: [..] > > > Is it better? If not, I will send a version with console_cmdline_last. > > > > personally I'm fine with the nested loop. the latest version > > "for (last = MAX_CMDLINECONSOLES - 1; last >= 0;..." > > > > is even easier to read. > > The num

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-03-29 Thread Joel Stanley
On Thu, Mar 30, 2017 at 4:13 AM, Christopher Bostic wrote: > From: Chris Bostic > > Implement a FSI master using GPIO. Will generate FSI protocol for > read and write commands to particular addresses. Sends master command > and waits for and decodes a slave response. > > Includes changes from E

Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs

2017-03-29 Thread Ralph Sennhauser
Hi Richard, On Thu, 30 Mar 2017 00:15:31 +0200 Richard Weinberger wrote: > Ralph, > > Am 29.03.2017 um 23:26 schrieb Ralph Sennhauser: > >> # create and link a tmpfile - then remove it > >> sudo rm -rf foo; sudo xfs_io -T -c "flink foo" . ; ls -l foo; sudo > >> rm foo > > > > next-20170328,

[PATCH v2 3/4] zram: make deduplication feature optional

2017-03-29 Thread js1304
From: Joonsoo Kim Benefit of deduplication is dependent on the workload so it's not preferable to always enable. Therefore, make it optional in Kconfig and device param. Default is 'off'. This option will be beneficial for users who use the zram as blockdev and stores build output to it. Signed-

[PATCH v2 4/4] zram: compare all the entries with same checksum for deduplication

2017-03-29 Thread js1304
From: Joonsoo Kim Until now, we compare just one entry with same checksum when checking duplication since it is the simplest way to implement. However, for the completeness, checking all the entries is better so this patch implement to compare all the entries with same checksum. Since this event

Re: [PATCH net-next] virtio_net: don't reset twice on XDP on/off

2017-03-29 Thread Jason Wang
On 2017年03月30日 04:14, Michael S. Tsirkin wrote: We already do a reset once in remove_vq_common - there appears to be no point in doing another one when we add/remove XDP. Signed-off-by: Michael S. Tsirkin --- drivers/net/virtio_net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

[PATCH v2 1/4] zram: introduce zram_entry to prepare dedup functionality

2017-03-29 Thread js1304
From: Joonsoo Kim Following patch will implement deduplication functionality in the zram and it requires an indirection layer to manage the life cycle of zsmalloc handle. To prepare that, this patch introduces zram_entry which can be used to manage the life-cycle of zsmalloc handle. Many lines ar

[PATCH v2 2/4] zram: implement deduplication in zram

2017-03-29 Thread js1304
From: Joonsoo Kim This patch implements deduplication feature in zram. The purpose of this work is naturally to save amount of memory usage by zram. Android is one of the biggest users to use zram as swap and it's really important to save amount of memory usage. There is a paper that reports tha

[PATCH v2 0/4] zram: implement deduplication in zram

2017-03-29 Thread js1304
From: Joonsoo Kim Changes from v1 o reogranize dedup specific functions o support Kconfig on/off o update zram documents o compare all the entries with same checksum (patch #4) This patchset implements deduplication feature in zram. Motivation is to save memory usage by zram. There are detailed

Re: linux-next: build failure after merge of the phy-next tree

2017-03-29 Thread Kishon Vijay Abraham I
t; Caused by commit > > ffa0c278e89c ("phy: rockchip-inno-usb2: add support of u2phy for rk3328") > > I have used the phy-next tree from next-20170329 for today. Thanks for reporting this. Will fix it in my tree. -Kishon

Re: [PATCH] phy: rockchip-inno-usb2: fix spelling mistake: "connecetd" -> "connected"

2017-03-29 Thread Kishon Vijay Abraham I
On Thursday 23 February 2017 05:00 AM, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in dev_dbg message, also rejoin > lines to clean up checkpatch warning > > Signed-off-by: Colin Ian King merged, thanks. -Kishon > --- > drivers/phy/phy-rockchip-inno-usb2.c

Re: [PATCH v2 2/2] mfd: axp20c-i2c: Select designware i2c-bus driver on x86

2017-03-29 Thread kbuild test robot
Hi Hans, [auto build test WARNING on ljones-mfd/for-mfd-next] [also build test WARNING on v4.11-rc4 next-20170329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/mfd

Re: [PATCH v2 2/2] mfd: axp20c-i2c: Select designware i2c-bus driver on x86

2017-03-29 Thread kbuild test robot
Hi Hans, [auto build test ERROR on ljones-mfd/for-mfd-next] [also build test ERROR on v4.11-rc4 next-20170329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/mfd-intel_soc_pmic

[PATCH] block: do not put mq context in blk_mq_alloc_request_hctx

2017-03-29 Thread Minchan Kim
In blk_mq_alloc_request_hctx, blk_mq_sched_get_request doesn't get sw context so we don't need to put the context with blk_mq_put_ctx. Unless, we will see preempt counter underflow. Cc: Sagi Grimberg Cc: Omar Sandoval Cc: Jens Axboe Signed-off-by: Minchan Kim --- Maybe, it would be fixed by s

Re: [PATCH v2] virtio_net: fix support for small rings

2017-03-29 Thread Jason Wang
On 2017年03月30日 01:42, Michael S. Tsirkin wrote: When ring size is small (<32 entries) making buffers smaller means a full ring might not be able to hold enough buffers to fit a single large packet. Make sure a ring full of buffers is large enough to allow at least one packet of max size. Fixe

Re: [v6 PATCH 00/21] x86: Enable User-Mode Instruction Prevention

2017-03-29 Thread Ricardo Neri
On Wed, 2017-03-29 at 23:55 +0300, Stas Sergeev wrote: > 29.03.2017 07:38, Ricardo Neri пишет: > >> Probably you could also remove > >> the sldt and str emulation for protected mode, because, > >> as I understand from this thread, wine does not > >> need those. > > I see. I would lean on keeping th

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Darren Hart
On Thu, Mar 30, 2017 at 02:26:26PM +1030, Jonathan Woithe wrote: > On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote: > > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? > > > wrote: > > > > > > > Darren, Andy, i

Re: [PATCH v6 0/4] Broadcom SBA RAID support

2017-03-29 Thread Vinod Koul
On Wed, Mar 29, 2017 at 11:35:43AM +0530, Anup Patel wrote: > On Tue, Mar 21, 2017 at 2:48 PM, Vinod Koul wrote: > > On Tue, Mar 21, 2017 at 02:17:21PM +0530, Anup Patel wrote: > >> On Tue, Mar 21, 2017 at 2:00 PM, Vinod Koul wrote: > >> > On Mon, Mar 06, 2017 at 03:13:24PM +0530, Anup Patel wrot

Re: [PATCH v2 0/8] thermal: ti-soc-thermal: Migrate slope/offset data to device tree

2017-03-29 Thread Eduardo Valentin
On Thu, Mar 30, 2017 at 08:59:31AM +0530, Keerthy wrote: > > > On Wednesday 29 March 2017 10:07 AM, Eduardo Valentin wrote: > > Keerthy, > > > > On Fri, Mar 24, 2017 at 07:26:10AM -0700, Tony Lindgren wrote: > >> * Keerthy [170323 20:29]: > >>> > >>> > >>> On Friday 24 March 2017 02:22 AM, Tony

Re: [PATCH -mm -v7 4/9] mm, THP, swap: Add get_huge_swap_page()

2017-03-29 Thread Huang, Ying
Johannes Weiner writes: > On Tue, Mar 28, 2017 at 01:32:04PM +0800, Huang, Ying wrote: >> @@ -527,6 +527,23 @@ static inline swp_entry_t get_swap_page(void) >> >> #endif /* CONFIG_SWAP */ >> >> +#ifdef CONFIG_THP_SWAP_CLUSTER >> +static inline swp_entry_t get_huge_swap_page(void) >> +{ >> +

Re: [BUG nohz]: wrong user and system time accounting

2017-03-29 Thread Mike Galbraith
On Wed, 2017-03-29 at 16:08 -0400, Rik van Riel wrote: > In other words, the tick on cpu0 is aligned > with the tick on the nohz_full cpus, and > jiffies is advanced while the nohz_full cpus > with an active tick happen to be in kernel > mode? You really want skew_tick=1, especially on big boxen.

linux-next: build failure after merge of the vhost tree

2017-03-29 Thread Stephen Rothwell
rst use in this function) ctx ? ctx[i] : false); ^ Caused by commit a965e977a103 ("virtio: add context flag to find vqs") I have used the vhost tree from next-20170329 for today. -- Cheers, Stephen Rothwell

Re: [PATCH -mm -v7 9/9] mm, THP, swap: Delay splitting THP during swap out

2017-03-29 Thread Huang, Ying
Johannes Weiner writes: > On Tue, Mar 28, 2017 at 01:32:09PM +0800, Huang, Ying wrote: >> @@ -183,12 +184,53 @@ void __delete_from_swap_cache(struct page *page) >> ADD_CACHE_INFO(del_total, nr); >> } >> >> +#ifdef CONFIG_THP_SWAP_CLUSTER >> +int add_to_swap_trans_huge(struct page *page, s

Re: [PATCH v2] sd: Consider max_xfer_blocks if opt_xfer_blocks is unusable

2017-03-29 Thread Fam Zheng
On Wed, 03/29 22:37, Martin K. Petersen wrote: > Fam Zheng writes: > > Fam, > > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > > index fcfeddc..a5c7e67 100644 > > --- a/drivers/scsi/sd.c > > +++ b/drivers/scsi/sd.c > > @@ -2957,6 +2957,7 @@ static int sd_revalidate_disk(struct gendisk *d

Re: [PATCH] zram: factor out partial IO routine

2017-03-29 Thread Sergey Senozhatsky
On (03/29/17 16:48), Minchan Kim wrote: > For architecture(PAGE_SIZE > 4K), zram have supported partial IO. > However, the mixed code for handling normal/partial IO is too mess, > error-prone to modify IO handler functions with upcoming feature > so this patch aims for cleaning up via factoring out

Re: spin_lock behavior with ARM64 big.Little/HMP

2017-03-29 Thread Vikram Mulukutla
Hi Sudeep, Interesting. Just curious if this is r0p0/p1 A53 ? If so, is the errata 819472 enabled ? Sorry for bringing this up after the loo-ong delay, but I've been assured that the A53 involved is > r0p1. I've also confirmed this problem on multiple internal platforms, and I'm pretty sur

Re: [RFC PATCH 0/6] Unify the Interrupt Mode and setup it as soon as possible

2017-03-29 Thread Baoquan He
On 03/30/17 at 11:09am, Dou Liyang wrote: > > > At 03/30/2017 11:03 AM, Dou Liyang wrote: > > Hi Baoquan, > > > > At 03/30/2017 10:08 AM, Baoquan He wrote: > > > Hi Liyang, > > > > > > This is awesome. I planned to do this after kaslr back porting, glad to > > > see your posting. I like below d

Re: [PATCH v9 10/15] ACPI: platform-msi: retrieve dev id from IORT

2017-03-29 Thread majun (Euler7)
Hi all: 在 2017/3/30 11:07, Hanjun Guo 写道: > On 03/30/2017 01:32 AM, Lorenzo Pieralisi wrote: >> On Wed, Mar 29, 2017 at 05:13:54PM +0100, Lorenzo Pieralisi wrote: >>> On Wed, Mar 29, 2017 at 03:52:47PM +0100, Marc Zyngier wrote: On 29/03/17 14:00, Hanjun Guo wrote: > On 03/29/2017 08:38 P

Re: [PATCH 4.8 50/96] firmware: fix usermode helper fallback loading

2017-03-29 Thread Luis R. Rodriguez
On Fri, Mar 24, 2017 at 04:01:58PM -0400, Ben Gamari wrote: > Greg Kroah-Hartman writes: > > > On Fri, Jan 06, 2017 at 10:54:38PM +0100, Yves-Alexis Perez wrote: > >> On Fri, 2017-01-06 at 22:43 +0100, Greg Kroah-Hartman wrote: > >> > 4.8-stable review patch.  If anyone has any objections, please

Re: [PATCH 1/8] platform/x86: fujitsu-laptop: move backlight input device setup to a separate function

2017-03-29 Thread Jonathan Woithe
On Wed, Mar 29, 2017 at 12:54:15PM -0700, Darren Hart wrote: > On Mon, Mar 20, 2017 at 10:32:17AM +0100, Micha?? K??pie?? wrote: > > + > > + return error; > > This return path could be cleaned up a bit: > > error = input_register_device(input); > if (error) > input_fre

[PATCH] powerpc/prom: Increase RMA size to 512MB

2017-03-29 Thread Sukadev Bhattiprolu
>From 3ae8d1ed31b01b92b172fe20e4560cfbfab135ec Mon Sep 17 00:00:00 2001 From: root Date: Mon, 27 Mar 2017 19:43:14 -0400 Subject: [PATCH] powerpc/prom: Increase RMA size to 512MB When booting very large systems with a large initrd, we run out of space for either the RTAS or the flattened device t

Re: [PATCH] virtio_net: enable big packets for large MTU values

2017-03-29 Thread Jason Wang
On 2017年03月29日 20:38, Michael S. Tsirkin wrote: If one enables e.g. jumbo frames without mergeable buffers, packets won't fit in 1500 byte buffers we use. Switch to big packet mode instead. TODO: make sizing more exact, possibly extend small packet mode to use larger pages. Signed-off-by: Mich

Re: lockdep warning: console vs. mem hotplug

2017-03-29 Thread Sergey Senozhatsky
On (03/28/17 16:22), Michal Hocko wrote: [..] > > Sebastian, does this change make lockdep happy? > > > > it removes console drivers from the __offline_isolated_pages(). not the > > best solution I can think of, but the simplest one. > > > > --- > > > > mm/page_alloc.c | 2 +- > > 1 file change

Re: [PATCH] virtio_net: fix mergeable bufs error handling

2017-03-29 Thread Jason Wang
On 2017年03月29日 20:37, Michael S. Tsirkin wrote: On xdp error we try to free head_skb without having initialized it, that's clearly bogus. Fixes: f600b6905015 ("virtio_net: Add XDP support") Cc: John Fastabend Signed-off-by: Michael S. Tsirkin --- drivers/net/virtio_net.c | 2 +- 1 file ch

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Jonathan Woithe
On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote: > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? > > wrote: > > > > > Darren, Andy, in light of the above I will be awaiting your review of > > > this series. I

Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues")

2017-03-29 Thread Mike Galbraith
On Wed, 2017-03-29 at 23:19 +0300, Michael S. Tsirkin wrote: > > > > > > > > > > > &portdev->max_nr_ports) == 0) { > > @@ -2179,7 +2179,9 @@ static struct virtio_device_id id_table[ > > > > static unsigned int features[] = { > > > >> > VIRTIO_CONSOLE_F_SIZE, > > +#ifndef

Re: [PATCH net-next 8/8] vhost_net: use lockless peeking for skb array during busy polling

2017-03-29 Thread Jason Wang
On 2017年03月30日 10:33, Michael S. Tsirkin wrote: On Thu, Mar 30, 2017 at 10:16:15AM +0800, Jason Wang wrote: On 2017年03月29日 20:07, Michael S. Tsirkin wrote: On Tue, Mar 21, 2017 at 12:04:47PM +0800, Jason Wang wrote: For the socket that exports its skb array, we can use lockless polling to a

linux-next: build failure after merge of the phy-next tree

2017-03-29 Thread Stephen Rothwell
hip-inno-usb2.c:1148:17: error: 'rk3328_usb2phy_tuning' undeclared here (not in a function) .phy_tuning = rk3328_usb2phy_tuning, ^ Caused by commit ffa0c278e89c ("phy: rockchip-inno-usb2: add support of u2phy for rk3328") I have used the phy-nex

Re: linux-next: manual merge of the tty tree with the tty.current tree

2017-03-29 Thread Michael Neuling
On Mon, 2017-03-20 at 10:26 +0100, Dmitry Vyukov wrote: > On Mon, Mar 20, 2017 at 10:21 AM, Dmitry Vyukov wrote: > > On Mon, Mar 20, 2017 at 3:28 AM, Stephen Rothwell > > wrote: > > > Hi Greg, > > > > > > Today's linux-next merge of the tty tree got a conflict in: > > > > > >   drivers/tty/tty_

Re: [PATCH] kernel.h: add IS_PTR_ALIGNED() macro

2017-03-29 Thread H. Peter Anvin
On 03/29/17 18:57, Masahiro Yamada wrote: > > Could you care to send a patch? > > Perhaps, ALIGN and PTR_ALIGN can be merged as well? > Can't promise when I'd get around to it... -hpa

  1   2   3   4   5   6   7   8   9   10   >