Re: syscall_get_error() && TS_ checks

2017-03-29 Thread Linus Torvalds
On Wed, Mar 29, 2017 at 9:33 AM, Oleg Nesterov wrote: > > Firstly, why do we need the IS_ERR_VALUE() check? This is only used by > do_signal/handle_signal, we do not care if it returns non-zero as long > as the value can't be confused with -ERESTART.* codes. There are system calls that can return

RE: [RFC LINUX PATCH 0/3] Allow remote to specify shared memory

2017-03-29 Thread Jiaying Liang
Hi Suman, > -Original Message- > From: Suman Anna [mailto:s-a...@ti.com] > Sent: Tuesday, March 28, 2017 4:24 PM > To: Wendy Liang > Cc: Jiaying Liang; Bjorn Andersson; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kernel.org; Jiaying Liang > Subject: Re: [RFC LINUX PATCH 0/3] All

Re: [PATCH 2/2] mtd: spi-nor: add driver for STM32 quad spi flash controller

2017-03-29 Thread Ludovic BARRE
On 03/29/2017 03:57 PM, Marek Vasut wrote: On 03/29/2017 03:35 PM, Ludovic BARRE wrote: [...] +writel_relaxed(CR_PRESC(presc) | CR_FTHRES(3) | CR_TCEN | CR_SSHIFT + | CR_EN, qspi->io_base + QUADSPI_CR); + +/* a minimum fsize must be set to sent the command id */ +fl

Re: [PATCH] Add hardware PTP support.

2017-03-29 Thread David Miller
From: Rafal Ozieblo Date: Wed, 29 Mar 2017 15:00:51 +0100 > This patch is based on original Harini's patch and Andrei's patch, > implemented in aseparate file to ease the review/maintanance > and integration with other platforms. > > In case that macb is compiled as a module, it has been renamed

[PATCH 0/7] NFC: fix device allocation and nfcmrvl crashes

2017-03-29 Thread Johan Hovold
This started out with the observation that the nfcmrvl_uart driver unconditionally dereferenced the tty class device despite the fact that not every tty has an associated struct device (Unix98 ptys). Some further changes were needed in the common nfcmrvl code to fully address this, some of which al

Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling

2017-03-29 Thread Andy Shevchenko
On Wed, Mar 29, 2017 at 10:19 AM, Michał Kępień wrote: > Darren, Andy, in light of the above I will be awaiting your review of > this series. I will submit v2 afterwards, with all remarks from both > you and Jonathan taken into account. Darren marked this series under his name to review, so, I

[PATCH v2 1/2] coresight: Disable the path only when the source is disabled

2017-03-29 Thread Suzuki K Poulose
With a coresight tracing session, the components along the path from the source to sink are disabled after the source is disabled. However, if the source was not actually disabled due to active users, we should not disable the components in the path. Cc: Mathieu Poirier Signed-off-by: Suzuki K Po

[PATCH v2 2/2] coresight: Fix reference count for software sources

2017-03-29 Thread Suzuki K Poulose
For software sources (i.e STM), there could be multiple agents generating the trace data, unlike the ETMs. So we need to properly do the accounting for the active number of users to disable the device when the last user goes away. Right now, the reference counting is broken for sources as we skip t

[PATCH v2 0/2] coresight: Allow sharing of STM

2017-03-29 Thread Suzuki K Poulose
This series fixes the coresight generic layer to handle the reference counting for the STM source properly, to allow multiple applications to share the STM. Without this series, the STM is disabled when the first user closes its connection, causing trace data losses. Changes since v1: - Fixed m

Re: [PATCH] ACPI / gpio: do not fall back to parsing _CRS when we get a deferral

2017-03-29 Thread Hans de Goede
HI, On 28-03-17 17:04, Andy Shevchenko wrote: On Thu, 2017-03-23 at 13:21 -0700, Dmitry Torokhov wrote: If, while locating GPIOs by name, we get probe deferral, we should immediately report it to caller rather than trying to fall back to parsing unnamed GPIOs from _CRS block. +Cc: Hans. Hans

Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups

2017-03-29 Thread Tony Lindgren
* Fabio Estevam [170329 06:36]: > Tony/Linus > > On Wed, Mar 15, 2017 at 6:46 AM, Linus Walleij > wrote: > > >> Still waiting to hear back from Linus on what he prefers. > > > > I am snowed under by mail and might be missing stuff at the > > moment... > > > > If there is some especially urgent

syscall_get_error() && TS_ checks

2017-03-29 Thread Oleg Nesterov
I must have missed something, but I simply can't undestand it. static inline long syscall_get_error(struct task_struct *task, struct pt_regs *regs) { unsigned long error = regs->ax; #ifdef CONFIG_IA32_EMULATION

Re: [PATCH v2] staging: iio: Remove unneeded parentheses.

2017-03-29 Thread Jonathan Cameron
On 29 March 2017 17:05:51 BST, Arushi Singhal wrote: >Remove the extra parenthesis remove the checkpatch issue. > >Signed-off-by: Arushi Singhal Patch doesn't need resending as already applied. If it did the description is now incorrect! >--- >changes in v2 > -done the changes according to th

Re: [Outreachy kernel] [RESEND PATCH] staging: iio: Remove extra Parenthesis

2017-03-29 Thread Jonathan Cameron
On 29 March 2017 16:38:28 BST, Julia Lawall wrote: > > >On Wed, 29 Mar 2017, Arushi Singhal wrote: > >> Remove the extra parenthesis remove the checkpatch issue. > >Is this a patch on the current state of the staging tree? When I do a >pull and then look at the code, the line numbers are all of

[PATCH 1/7] NFC: fix broken device allocation

2017-03-29 Thread Johan Hovold
Commit 7eda8b8e9677 ("NFC: Use IDR library to assing NFC devices IDs") moved device-id allocation and struct-device initialisation from nfc_allocate_device() to nfc_register_device(). This broke just about every nfc-device-registration error path, which continue to call nfc_free_device() that trie

Re: [PATCH] Add checks for kmalloc allocation failures

2017-03-29 Thread Eric Dumazet
On Wed, 2017-03-29 at 16:54 +0100, Colin King wrote: > From: Colin Ian King > > Ensure we don't end up with a null pointer dereferences by checking > for for allocation failures. Allocate by sizeof(*ptr) rather than > the type to fix checkpack warnings. Also merge multiple lines into > one line

[PATCH 5/7] NFC: nfcmrvl: fix firmware-management initialisation

2017-03-29 Thread Johan Hovold
The nci-device was never deregistered in the event that fw-initialisation failed. Fix this by moving the firmware initialisation before device registration since the firmware work queue should be available before registering. Note that this depends on a recent fix that moved device-name initialis

[PATCH 3/7] NFC: nfcmrvl: do not use device-managed resources

2017-03-29 Thread Johan Hovold
This specifically fixes a NULL-pointer dereference when using the n_nci line discipline on one end of a Unix98 pty as well as resource leaks in the registration error paths. Device-managed resources is a bad fit for this driver as devices can be registered from the n_nci line discipline. Firstly,

[PATCH 2/7] NFC: nfcmrvl_uart: add missing tty-device sanity check

2017-03-29 Thread Johan Hovold
Make sure to check the tty-device pointer before trying to access the parent device to avoid dereferencing a NULL-pointer when the tty is one end of a Unix98 pty. Fixes: e097dc624f78 ("NFC: nfcmrvl: add UART driver") Cc: stable # 4.2 Cc: Vincent Cuissard Signed-off-by: Johan Hovold --- dri

[PATCH 7/7] NFC: nfcmrvl_usb: use interface as phy device

2017-03-29 Thread Johan Hovold
Use the USB-interface rather than parent USB-device device, which is what this driver binds to, when registering the nci device. Note that using the right device is important when dealing with device- managed resources as the interface can be unbound independently of the parent device. Also note

[PATCH 6/7] NFC: nfcmrvl_uart: fix device-node leak during probe

2017-03-29 Thread Johan Hovold
Make sure to release the device-node reference when done parsing the node. Fixes: e097dc624f78 ("NFC: nfcmrvl: add UART driver") Cc: Vincent Cuissard Signed-off-by: Johan Hovold --- drivers/nfc/nfcmrvl/uart.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/nfc/nfcmrvl/uart.c b/dr

[PATCH 4/7] NFC: nfcmrvl: use nfc-device for firmware download

2017-03-29 Thread Johan Hovold
Use the nfc- rather than phy-device in firmware-management code that needs a valid struct device. This specifically fixes a NULL-pointer dereference in nfcmrvl_fw_dnld_init() during registration when the underlying tty is one end of a Unix98 pty. Note that the driver still uses the phy device for

RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS

2017-03-29 Thread Deucher, Alexander
> -Original Message- > From: 'Joerg Roedel' [mailto:jroe...@suse.de] > Sent: Tuesday, March 28, 2017 6:26 PM > To: Deucher, Alexander > Cc: 'Joerg Roedel'; Bjorn Helgaas; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; Daniel Drake; Nath, Arindam > Subject: Re: [PATCH] PCI: Blac

[PATCH 0/2] Bluetooth: fix hci-uart crashes

2017-03-29 Thread Johan Hovold
Not every tty has a class device and this could be used to trigger NULL-pointer dereferences in two hci-uart drivers that lacked the required sanity checks. Johan Johan Hovold (2): Bluetooth: hci_bcm: add missing tty-device sanity check Bluetooth: hci_intel: add missing tty-device sanity che

[PATCH 2/2] Bluetooth: hci_intel: add missing tty-device sanity check

2017-03-29 Thread Johan Hovold
Make sure to check the tty-device pointer before looking up the sibling platform device to avoid dereferencing a NULL-pointer when the tty is one end of a Unix98 pty. Fixes: 74cdad37cd24 ("Bluetooth: hci_intel: Add runtime PM support") Fixes: 1ab1f239bf17 ("Bluetooth: hci_intel: Add support for pl

[PATCH 1/2] Bluetooth: hci_bcm: add missing tty-device sanity check

2017-03-29 Thread Johan Hovold
Make sure to check the tty-device pointer before looking up the sibling platform device to avoid dereferencing a NULL-pointer when the tty is one end of a Unix98 pty. Fixes: 0395ffc1ee05 ("Bluetooth: hci_bcm: Add PM for BCM devices") Cc: stable # 4.3 Cc: Frederic Danis Signed-off-by: Johan H

Re: [PATCH] x86/intel_rdt: Add cpus_list rdtgroup file

2017-03-29 Thread Jiri Olsa
On Wed, Mar 29, 2017 at 09:08:26AM -0700, Fenghua Yu wrote: > On Wed, Mar 29, 2017 at 05:09:48PM +0200, Jiri Olsa wrote: > > While playing with the resctrl interface I found it much > > easier to deal with cpumask list rather than just regular > > cpumask. > > Could you please explain specifically

Re: [Outreachy kernel] [PATCH 1/4] iio: common: st_sensors: Replace ternary operator with min macro

2017-03-29 Thread Daniel Baluta
On Wed, Mar 29, 2017 at 3:33 PM, simran singhal wrote: > Use macro min() to get the minimum of two values for brevity and > readability. > > Signed-off-by: simran singhal > --- > drivers/iio/common/st_sensors/st_sensors_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] ARM: dts: keystone-k2l: fix broken Ethernet due to disabled OSR

2017-03-29 Thread santosh.shilim...@oracle.com
Hi Arnd, Olof, On 3/29/17 5:32 AM, Sekhar Nori wrote: From: Murali Karicheri Ethernet networking on K2L has been broken since v4.11-rc1. This was caused by commit 32a34441a9bd ("ARM: keystone: dts: fix netcp clocks and add names"). This commit inadvertently moves on-chip static RAM clock to th

Re: [PATCH v9 10/15] ACPI: platform-msi: retrieve dev id from IORT

2017-03-29 Thread Lorenzo Pieralisi
On Wed, Mar 29, 2017 at 03:52:47PM +0100, Marc Zyngier wrote: > On 29/03/17 14:00, Hanjun Guo wrote: > > On 03/29/2017 08:38 PM, Lorenzo Pieralisi wrote: > >> On Wed, Mar 29, 2017 at 07:52:48PM +0800, Hanjun Guo wrote: > >>> Hi Lorenzo, > >>> > >>> On 03/29/2017 06:14 PM, Lorenzo Pieralisi wrote: >

Re: [PATCH] virtio_net: enable big packets for large MTU values

2017-03-29 Thread Michael S. Tsirkin
On Wed, Mar 29, 2017 at 03:38:09PM +0300, Michael S. Tsirkin wrote: > If one enables e.g. jumbo frames without mergeable > buffers, packets won't fit in 1500 byte buffers > we use. Switch to big packet mode instead. > TODO: make sizing more exact, possibly extend small > packet mode to use larger p

Re: [PATCH v3 8/8] mm, compaction: finish whole pageblock to reduce fragmentation

2017-03-29 Thread Vlastimil Babka
On 03/16/2017 03:18 AM, Joonsoo Kim wrote: > On Tue, Mar 07, 2017 at 02:15:45PM +0100, Vlastimil Babka wrote: >> The main goal of direct compaction is to form a high-order page for >> allocation, >> but it should also help against long-term fragmentation when possible. Most >> lower-than-pageblock

Re: [PATCH 1/5] locking: Introduce range reader/writer lock

2017-03-29 Thread Davidlohr Bueso
On Wed, 29 Mar 2017, Kirill A. Shutemov wrote: On Wed, Mar 29, 2017 at 08:31:33AM -0700, Davidlohr Bueso wrote: On Wed, 29 Mar 2017, Laurent Dufour wrote: > On 28/03/2017 18:58, Kirill A. Shutemov wrote: > > On Tue, Mar 28, 2017 at 09:39:18AM -0700, Davidlohr Bueso wrote: > > > I'll wait to se

Re: [PATCH 1/1] tty: serial: st-asc: Make the locking RT aware

2017-03-29 Thread Sebastian Andrzej Siewior
On 2017-03-22 18:12:31 [+0100], Lionel Debieve wrote: > The lock is a sleeping lock and local_irq_save() is not the > standard implementation now. Working for both -RT and non > RT. > > Signed-off-by: Lionel Debieve Acked-by: Sebastian Andrzej Siewior This is how serial8250_console_write() loo

Re: [PATCH v7 2/2] soc/imx: Add GPCv2 power gating driver

2017-03-29 Thread Lucas Stach
Hi Dong, Am Donnerstag, den 30.03.2017, 15:51 +0800 schrieb Dong Aisheng: > Hi Lucas, > > On Thu, Mar 23, 2017 at 03:35:49PM +0100, Lucas Stach wrote: > > Hi Dong, > > > > Am Freitag, den 24.03.2017, 14:24 +0800 schrieb Dong Aisheng: > > [...] > > > > +static struct platform_driver imx7_pgc_doma

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-29 Thread Sebastian Andrzej Siewior
On 2017-03-22 09:05:58 [-0700], Steven Rostedt wrote: > On Wed, 22 Mar 2017 16:18:43 +0100 > Lionel Debieve wrote: > > > Use raw_spin_lock in enable/disable channel as it comes from > > interrupt context. > > > > BUG: sleeping function called from invalid context at > > kernel/locking/rtmutex.c:

Re: [PATCH v3 7/8] mm, compaction: restrict async compaction to pageblocks of same migratetype

2017-03-29 Thread Vlastimil Babka
On 03/16/2017 03:14 AM, Joonsoo Kim wrote: > On Tue, Mar 07, 2017 at 02:15:44PM +0100, Vlastimil Babka wrote: >> The migrate scanner in async compaction is currently limited to >> MIGRATE_MOVABLE >> pageblocks. This is a heuristic intended to reduce latency, based on the >> assumption that non-MOV

Re: [PATCH] x86/intel_rdt: Add cpus_list rdtgroup file

2017-03-29 Thread Fenghua Yu
On Wed, Mar 29, 2017 at 05:09:48PM +0200, Jiri Olsa wrote: > While playing with the resctrl interface I found it much > easier to deal with cpumask list rather than just regular > cpumask. Could you please explain specifically why and when it's easier to deal with cpumask list? In programming case

[PATCH v2] staging: iio: Remove unneeded parentheses.

2017-03-29 Thread Arushi Singhal
Remove the extra parenthesis remove the checkpatch issue. Signed-off-by: Arushi Singhal --- changes in v2 -done the changes according to the current tree drivers/staging/iio/cdc/ad7746.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/iio/cd

[PATCH 2/2] dt-bindings: gpio: Document Cadence GPIO controller bindings

2017-03-29 Thread Boris Brezillon
Document Cadence GPIO bindings. Signed-off-by: Boris Brezillon --- .../devicetree/bindings/gpio/cdns,gpio.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/cdns,gpio.txt diff --git a/Documentation/devicetree/bind

[PATCH 1/2] gpio: Add a driver for Cadence GPIO controller

2017-03-29 Thread Boris Brezillon
Add a driver for Cadence GPIO controller. Even though this driver is pretty simple, I was not able to use the generic GPIO infrastructure because it needs custom ->request()/->free() implementation and ->direction_output() requires modifying 2 different registers while the generic implementation on

Re: [PATCH v22 07/11] acpi/arm64: Add GTDT table parse driver

2017-03-29 Thread Lorenzo Pieralisi
On Wed, Mar 29, 2017 at 09:42:39PM +0800, Fu Wei wrote: [...] > >> For calling acpi_gtdt_init() twice: > >> (1) 1st time: in early boot(bootmem), for init arch_timer and > >> memory-mapped timer, we initialize the acpi_gtdt_desc. > >> you can see that all the items in this struct are pointer. > >

[PATCH v4 2/2] power: supply: ltc2941-battery-gauge: Add OF device ID table

2017-03-29 Thread Javier Martinez Canillas
The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could c

[PATCH v4 1/2] power: supply: ltc2941-battery-gauge: Add vendor to compatibles in binding

2017-03-29 Thread Javier Martinez Canillas
The DT binding document for LTC2941 and LTC2943 battery gauges did not use a vendor prefix in the listed compatible strings. The driver says that the manufacturer is Linear Technology which is "lltc" in vendor-prefixes.txt. There isn't an upstream Device Tree source file that has nodes defined for

Re: [PATCH 46/46] selinuxfs: Use seq_puts() in sel_avc_stats_seq_show()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:46 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 14:04:53 +0100 > > A string which did not contain data format specifications should be put > into a sequence. Thus use the corresponding function "seq_puts". > > This issue was detected by u

Re: [Outreachy kernel] [PATCH] iio: accel: bma180: Set up buffer timestamps for non-zero values

2017-03-29 Thread Alison Schofield
On Wed, Mar 29, 2017 at 08:16:58AM -0700, Alison Schofield wrote: > On Wed, Mar 29, 2017 at 07:41:31PM +0530, simran singhal wrote: > > Use the iio_pollfunc_store_time parameter during triggered buffer set-up > > to get valid timestamps. > > > > Signed-off-by: simran singhal > > Hi Simran, > I g

Re: [PATCH] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-03-29 Thread Rob Herring
On Thu, Mar 23, 2017 at 03:22:58PM +0100, michael.henner...@analog.com wrote: > From: Michael Hennerich > > This patch adds support for the Analog Devices / Linear Technology > LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. > The LTC4306 optionally provides two general purpose inpu

Re: [PATCH net-next v6 11/11] landlock: Add user and kernel documentation for Landlock

2017-03-29 Thread kbuild test robot
Hi Mickaël, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Micka-l-Sala-n/Landlock-LSM-Toward-unprivileged-sandboxing/20170329-211258 reproduce: make htmldocs All warnings (new ones prefixed by >>): include/linux/init.h:1: warni

Re: [PATCH 7/8] asm-generic: add KASAN instrumentation to atomic operations

2017-03-29 Thread Mark Rutland
e,release,relaxed} variants (as arm64 will need), > > so this looks good to me. > > > > As a heads-up, I wanted to have a go at that, but I wasn't able to apply > > patch two onwards on v4.11-rc{3,4} or next-20170329. I was not able to > > cleanly revert the i

Re: [PATCH v3 3/7] arm: dts: dt-bindings: Add Renesas RZ pinctrl header

2017-03-29 Thread jacopo
Hi Linus, another reply to your email, please don't feel assaulted :) On Wed, Mar 29, 2017 at 03:22:23PM +0200, Linus Walleij wrote: > On Fri, Mar 24, 2017 at 4:22 PM, Jacopo Mondi > wrote: > > > Add dt-bindings for Renesas r7s72100 pin controller header file. > > > > Signed-off-by: Jacopo

Re: [PATCH v7 2/2] soc/imx: Add GPCv2 power gating driver

2017-03-29 Thread Dong Aisheng
Hi Lucas, On Thu, Mar 23, 2017 at 03:35:49PM +0100, Lucas Stach wrote: > Hi Dong, > > Am Freitag, den 24.03.2017, 14:24 +0800 schrieb Dong Aisheng: > [...] > > > +static struct platform_driver imx7_pgc_domain_driver = { > > > + .driver = { > > > + .name = "imx7-pgc", > > > + }, > > > + .p

[PATCH] Add checks for kmalloc allocation failures

2017-03-29 Thread Colin King
From: Colin Ian King Ensure we don't end up with a null pointer dereferences by checking for for allocation failures. Allocate by sizeof(*ptr) rather than the type to fix checkpack warnings. Also merge multiple lines into one line for the kmalloc call. Detected by CoverityScan, CID#1422435 ("D

Re: Impact of CONFIG_PARAVIRT=y / mmap benchmark

2017-03-29 Thread Randy Dunlap
On 03/28/17 10:17, Radu Rendec wrote: > Hi, > > I'm trying to assess the performance impact of enabling PARAVIRT (and > XEN) in a custom kernel configuration. I came across a very old thread > (https://lkml.org/lkml/2009/5/13/449) on this topic and the conclusion > back then was that the performan

[PATCH V2] acpi: apei: check for pending errors when probing HED type GHES entries

2017-03-29 Thread Tyler Baicar
If a HED type error occurs prior to GHES probing, the kernel will never report the error. The HED driver will see that no notifiers are registered, and clear the interrupt. This becomes a more serious problem with firmware that supports GHESv2 acknowledgements from the kernel. The firmware will po

Re: [PATCH 7/8] asm-generic: add KASAN instrumentation to atomic operations

2017-03-29 Thread Dmitry Vyukov
...@kernel.org > > FWIW, I think that structuring the file this way will make it easier to > add the {acquire,release,relaxed} variants (as arm64 will need), > so this looks good to me. > > As a heads-up, I wanted to have a go at that, but I wasn't able to apply > patch tw

Re: [PATCH v3 1/2] PCI: Add tango MSI controller support

2017-03-29 Thread Mason
On 29/03/2017 15:16, Mason wrote: > But I don't understand how to get my pcie pointer back in irq_ack > or irq_unmask, or the relevant msi. Can you throw me a clue? Let's see... the irq_chip call-backs receive an irq_data pointer. struct irq_data - per irq chip data passed down to chip functions

Re: [PATCH v5 6/9] coresight: add support for CPU debug module

2017-03-29 Thread Suzuki K Poulose
On 29/03/17 11:37, Leo Yan wrote: On Wed, Mar 29, 2017 at 11:31:03AM +0100, Suzuki K Poulose wrote: On 29/03/17 11:27, Leo Yan wrote: On Wed, Mar 29, 2017 at 10:07:07AM +0100, Suzuki K Poulose wrote: [...] + if (mode == EDDEVID_IMPL_NONE) { + drvdata->edpcsr_present = fa

Re: [PATCH 2/2] mdadm.c: fix compile error "switch condition has boolean value"

2017-03-29 Thread Gioh Kim
On Wed, Mar 29, 2017 at 11:47:28AM -0400, jes.soren...@gmail.com wrote: > Gioh Kim writes: > > Remove a boolean expression in switch condition > > to prevent compile error of some compilers. > > Please be specific, which compile is unable to handle this? > > > Signed-off-by: Gioh Kim > > --- >

Re: [PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Doug Anderson
Hi, On Wed, Mar 29, 2017 at 3:04 AM, Olliver Schinagl wrote: > Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus rx > timeout interrupt") > added a bit check with quite a wide mask. To be concise with the other > similar calls in this driver, change it to mask against the f

Re: [PATCH] iommu/vt-d: Make sure IOMMUs are off when intel_iommu=off

2017-03-29 Thread Jacob Pan
On Wed, 29 Mar 2017 17:00:39 +0200 Joerg Roedel wrote: > From: Joerg Roedel > > When booting into a kexec kernel with intel_iommu=off, and > the previous kernel had intel_iommu=on, the IOMMU hardware > is still enabled and gets not disabled by the new kernel. > > This causes the boot to fail b

Re: [PATCH v3 4/8] mm, page_alloc: count movable pages when stealing from pageblock

2017-03-29 Thread Vlastimil Babka
On 03/16/2017 02:53 AM, Joonsoo Kim wrote: > On Tue, Mar 07, 2017 at 02:15:41PM +0100, Vlastimil Babka wrote: >> When stealing pages from pageblock of a different migratetype, we count how >> many free pages were stolen, and change the pageblock's migratetype if more >> than half of the pageblock w

Re: [PATCH 44/46] selinux: Adjust two checks for null pointers

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:44 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 13:30:20 +0100 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script "checkpatch.pl" pointed information out like the following. > >

Re: [PATCH 2/2] mdadm.c: fix compile error "switch condition has boolean value"

2017-03-29 Thread jes . sorensen
Gioh Kim writes: > Remove a boolean expression in switch condition > to prevent compile error of some compilers. Please be specific, which compile is unable to handle this? > Signed-off-by: Gioh Kim > --- > mdadm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/

Re: [PATCH 1/2] super1: replace hard-coded values with bit definitions

2017-03-29 Thread jes . sorensen
Gioh Kim writes: > Some hard-coded values for disk status are replaced > with bit definitions. > > Signed-off-by: Gioh Kim > --- > super1.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Applied! Please use --cover-letter when you send out multi-commit patch sets, which include

Re: [PATCH v5 6/9] coresight: add support for CPU debug module

2017-03-29 Thread Mathieu Poirier
On Wed, Mar 29, 2017 at 11:07:35AM +0800, Leo Yan wrote: > Hi Suzuki, > > On Mon, Mar 27, 2017 at 05:34:57PM +0100, Suzuki K Poulose wrote: > > On 25/03/17 18:23, Leo Yan wrote: > > [...] > > > Leo, > > > > Thanks a lot for the quick rework. I don't fully understand (yet!) why we > > need the

Re: [PATCH 43/46] selinux: Use kmalloc_array() in sidtab_init()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:43 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 13:13:19 +0100 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kma

Re: [PATCH 42/46] selinux: One function call less in roles_init() after error detection

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:42 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 12:56:54 +0100 > > The kfree() function was called in up to two cases by the > roles_init() function during error handling even if the passed variable > contained a null pointer. > > * Adjus

Re: [PATCH 41/46] selinux: Move two assignments for the variable "rc" in roles_init()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:41 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 12:40:35 +0100 > > One local variable was set to an error code in two cases before > a concrete error situation was detected. Thus move the corresponding > assignments into if branches to in

Re: [PATCH 1/5] locking: Introduce range reader/writer lock

2017-03-29 Thread Kirill A. Shutemov
On Wed, Mar 29, 2017 at 08:31:33AM -0700, Davidlohr Bueso wrote: > On Wed, 29 Mar 2017, Laurent Dufour wrote: > > > On 28/03/2017 18:58, Kirill A. Shutemov wrote: > > > On Tue, Mar 28, 2017 at 09:39:18AM -0700, Davidlohr Bueso wrote: > > > > I'll wait to see if there are any more concerns and send

Re: [PATCH v3 0/5] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers

2017-03-29 Thread Tejun Heo
On Fri, Mar 24, 2017 at 04:38:24PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Thursday, March 23, 2017 07:27:05 PM Sekhar Nori wrote: > > On Wednesday 22 March 2017 11:50 PM, Bartlomiej Zolnierkiewicz wrote: > > > Hi, > > > > > > This patchset adds Palmchip BK3710 IDE controller driver to > > >

Re: [PATCH 40/46] selinux: Return directly after a failed kzalloc() in roles_init()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:40 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 12:10:09 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 f

[RFC][PATCH] UBI: Make MTD_UBI_FASTMAP non-experimental

2017-03-29 Thread Jesper Nilsson
MTD_UBI_FASTMAP has been set as experimental since it was merged back in 2012. There hasn't been much change in the format, so we can consider the feature stable and start being careful about breaking the format. (This is somewhat of a pre-requisite for anyone actually using the feature in the rea

Re: [PATCH 39/46] selinux: Move two assignments for the variable "rc" in ocontext_read()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:39 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 11:30:12 +0100 > > One local variable was set to an error code in two cases before > a concrete error situation was detected. Thus move the corresponding > assignments into if branches to in

Re: [PATCH] kvm: pass the virtual SEI syndrome to guest OS

2017-03-29 Thread Laszlo Ersek
On 03/29/17 16:48, Christoffer Dall wrote: > On Wed, Mar 29, 2017 at 10:36:51PM +0800, gengdongjiu wrote: >> 2017-03-29 18:36 GMT+08:00, Achin Gupta : >>> Qemu is essentially fulfilling the role of secure firmware at the >>> EL2/EL1 interface (as discussed with Christoffer below). So it >>> should

RE: [PATCH v3 3/7] arm: dts: dt-bindings: Add Renesas RZ pinctrl header

2017-03-29 Thread Chris Brandt
On Wednesday, March 29, 2017, Chris Brandt wrote: > On Wednesday, March 29, 2017, Geert Uytterhoeven wrote: > > > But, what do we do for Ethernet? All the pins are "normal" except > > > just the MDIO pin needs to be bidirectional. > > > That's the part I'm confused by. > > > How do we flag that jus

Re: [PATCH 38/46] selinux: One function call less in five functions after null pointer detection

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:38 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 11:28:02 +0100 > > Call the function "kfree" at the end only after it was determined > that the passed parameter contained a non-null pointer. > > Signed-off-by: Markus Elfring > --- > sec

Re: [Outreachy kernel] [RESEND PATCH] staging: iio: Remove extra Parenthesis

2017-03-29 Thread Julia Lawall
On Wed, 29 Mar 2017, Arushi Singhal wrote: > Remove the extra parenthesis remove the checkpatch issue. Is this a patch on the current state of the staging tree? When I do a pull and then look at the code, the line numbers are all off. Furthermore, there are not calls to BIT with parentheses ar

Re: [PATCH v3 2/5] clk: sunxi-ng: add support for PRCM CCUs

2017-03-29 Thread Icenowy Zheng
On Wed, 29 Mar 2017 18:42:43 +0800 Icenowy Zheng wrote: > From: Icenowy Zheng > > SoCs after A31 has a clock controller module in the PRCM part. > > Support the clock controller module on H3/5 and A64 now. > > Signed-off-by: Icenowy Zheng > --- > Changes in v3: > - Change osc32000 mux to ios

[PATCH][V2] VSOCK: remove unnecessary ternary operator on return value

2017-03-29 Thread Colin King
From: Colin Ian King Rather than assign the positive errno values to ret and then checking if it is positive and flip the sign, just return the errno value. Detected by CoverityScan, CID#986649 ("Logically Dead Code") Signed-off-by: Colin Ian King --- net/vmw_vsock/vmci_transport.c | 22 +

Re: [RFC PATCH v2 16/32] x86: kvm: Provide support to create Guest and HV shared per-CPU variables

2017-03-29 Thread Borislav Petkov
On Wed, Mar 29, 2017 at 05:21:13PM +0200, Paolo Bonzini wrote: > The GHCB would have to be allocated much earlier, possibly even by > firmware depending on how things will be designed. How about a statically allocated page like we do with the early pagetable pages in head_64.S? > I think it's pre

Re: [PATCH 1/5] locking: Introduce range reader/writer lock

2017-03-29 Thread Davidlohr Bueso
On Wed, 29 Mar 2017, Laurent Dufour wrote: On 28/03/2017 18:58, Kirill A. Shutemov wrote: On Tue, Mar 28, 2017 at 09:39:18AM -0700, Davidlohr Bueso wrote: I'll wait to see if there are any more concerns and send a v2 with your corrections. Have you tried drop-in replacement of mmap_sem with

Re: [PATCH 37/46] selinux: Move an assignment for the variable "rc" in policydb_load_isids()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:37 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 11:24:51 +0100 > > A local variable was set to an error code in one case before a concrete > error situation was detected. Thus move the corresponding assignment into > an if branch to indic

Re: [PATCH 35/46] selinux: Return directly after a failed kzalloc() in perm_read()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:35 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 11:20:13 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 f

Re: [PATCH v22 03/11] clocksource: arm_arch_timer: refactor arch_timer_needs_probing

2017-03-29 Thread Daniel Lezcano
On Wed, Mar 29, 2017 at 04:24:08PM +0100, Mark Rutland wrote: > On Tue, Mar 28, 2017 at 05:02:20PM +0200, Daniel Lezcano wrote: > > On Wed, Mar 22, 2017 at 12:31:14AM +0800, fu@linaro.org wrote: > > > From: Fu Wei > > > > > > When system init with device-tree, we don't know which node will be

Re: [PATCH v3 2/8] mm, compaction: remove redundant watermark check in compact_finished()

2017-03-29 Thread Vlastimil Babka
On 03/16/2017 02:30 AM, Joonsoo Kim wrote: > Hello, Hi, sorry for the late replies. > On Tue, Mar 07, 2017 at 02:15:39PM +0100, Vlastimil Babka wrote: >> When detecting whether compaction has succeeded in forming a high-order page, >> __compact_finished() employs a watermark check, followed by an

Re: [PATCH 36/46] selinux: Move an assignment for the variable "rc" in mls_read_range_helper()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:36 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 11:22:23 +0100 > > A local variable was set to an error code in one case before a concrete > error situation was detected. Thus move the corresponding assignment into > an if branch to indic

Re: [PATCH 34/46] selinux: Return directly after a failed kzalloc() in common_read()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:34 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 11:15:19 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 f

[PATCH] selinux: Fix SBLABEL_MNT for NFS mounts

2017-03-29 Thread Tomeu Vizoso
Labelling of files in a NFSv4.2 currently fails with ENOTSUPP because the mount point doesn't have SBLABEL_MNT. Add specific condition for NFS4 filesystems so it gets correctly labeled. Signed-off-by: Tomeu Vizoso Cc: J. Bruce Fields --- Hi, cannot remotely say that I currently understand ho

Re: [PATCH 33/46] selinux: Move an assignment for the variable "rc" in class_read()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:33 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 11:10:39 +0100 > > A local variable was set to an error code in one case before a concrete > error situation was detected. Thus move the corresponding assignment into > an if branch to indic

Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES

2017-03-29 Thread Tejun Heo
On Wed, Mar 29, 2017 at 10:38:17AM +0800, Cao jin wrote: > On 03/29/2017 12:00 AM, Tejun Heo wrote: > > On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote: > >> Signed-off-by: Cao jin > > > > I'm not sure. I think I used it during development and it's not like > > it costs anything to keep.

Re: [PATCH 32/46] selinux: Return directly after a failed kzalloc() in class_read()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:32 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 22:30:51 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 f

Re: [PATCHv2 6/8] x86/dump_pagetables: Add support 5-level paging

2017-03-29 Thread Kirill A. Shutemov
On Wed, Mar 29, 2017 at 12:15:07AM +0300, Kirill A. Shutemov wrote: > I'll try to look more into this issue tomorrow. Putting this commit before seems f2a6a7050109 ("x86: Convert the rest of the code to support p4d_t") seems fixes the issue. -- Kirill A. Shutemov

Re: [PATCH v22 03/11] clocksource: arm_arch_timer: refactor arch_timer_needs_probing

2017-03-29 Thread Mark Rutland
On Tue, Mar 28, 2017 at 05:02:20PM +0200, Daniel Lezcano wrote: > On Wed, Mar 22, 2017 at 12:31:14AM +0800, fu@linaro.org wrote: > > From: Fu Wei > > > > When system init with device-tree, we don't know which node will be > > initialized first. And the code in arch_timer_common_init should wa

VM crashes during early stages of boot

2017-03-29 Thread Noa Osherovich
Hi, Starting with kernel 4.11-rc1 our regression VMs crash during boot. Not all of them and not every time, but this happens often enough and in a very early boot stage (example outputs below). Did anyone else see these with 4.11 RCs? Any suggestions are welcome. Example host details: X86 runnin

Re: [PATCH 30/46] selinux: Return directly after a failed kzalloc() in role_read()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:30 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 22:20:25 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 f

Re: [PATCH 0/2] Fix sysfs recursive removal splats in isci

2017-03-29 Thread Tejun Heo
Hello, On Wed, Mar 29, 2017 at 11:41:07AM +0200, Johannes Thumshirn wrote: > This series fixes a sysfs warning caused by isci not being able to cope with > recursive sysfs path removals which are in place since commit bcdde7e > ("sysfs: make __sysfs_remove_dir() recursive"). Thanks for fixing the

Re: [RFC PATCH v2 16/32] x86: kvm: Provide support to create Guest and HV shared per-CPU variables

2017-03-29 Thread Paolo Bonzini
On 28/03/2017 20:39, Borislav Petkov wrote: >> 2) Since the encryption attributes works on PAGE_SIZE hence add some extra >> padding to 'struct kvm-steal-time' to make it PAGE_SIZE and then at runtime >> clear the encryption attribute of the full PAGE. The downside of this was >> now we need to m

Re: [PATCH 29/46] selinux: Return directly after a failed kzalloc() in type_read()

2017-03-29 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:29 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 22:15:54 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 f

Re: [PATCH net-next v6 04/11] landlock: Add LSM hooks related to filesystem

2017-03-29 Thread kbuild test robot
Hi Mickaël, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Micka-l-Sala-n/Landlock-LSM-Toward-unprivileged-sandboxing/20170329-211258 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce

Re: [PATCH v2] mtdram: check offs and len where appropriate

2017-03-29 Thread Boris Brezillon
On Fri, 17 Mar 2017 10:29:39 +0800 chenwy wrote: > We should prevent user to operating mtd device with > an illegal offset or length. I realize that all the tests you do here are already done in mtdcore.c. If one is missing, please patch mtdcore.c instead. Thanks, Boris > > Signed-off-by: Ch

<    1   2   3   4   5   6   7   8   9   10   >