Re: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

On Sun, Apr 23, 2017 at 1:29 PM, Winkler, Tomas wrote: >> New helpers take pointers to uuid_{be|le} as parameters. >> >> When using them on a raw data we don't need to do an ugly dereference and, >> in some cases, a type casting. > I think this going overboard, the _pp

Re: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

On Sun, Apr 23, 2017 at 1:29 PM, Winkler, Tomas wrote: >> New helpers take pointers to uuid_{be|le} as parameters. >> >> When using them on a raw data we don't need to do an ugly dereference and, >> in some cases, a type casting. > I think this going overboard, the _pp types are just enough. I

Re: [PATCH 1/3] [media] si2157: get chip id during probing

On Sun, 23 Apr 2017 15:19:21 +0300 Antti Palosaari wrote: > On 03/16/2017 12:22 AM, Andreas Kemnade wrote: > > If the si2157 is behind a e.g. si2168, the si2157 will > > at least in some situations not be readable after the si268 > > got the command 0101. It still accepts commands

Re: [PATCH 1/3] [media] si2157: get chip id during probing

On Sun, 23 Apr 2017 15:19:21 +0300 Antti Palosaari wrote: > On 03/16/2017 12:22 AM, Andreas Kemnade wrote: > > If the si2157 is behind a e.g. si2168, the si2157 will > > at least in some situations not be readable after the si268 > > got the command 0101. It still accepts commands but the answer

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

>> Its implementation of the check “ALLOC_WITH_MULTIPLY” considers only an other >> search pattern so far. >> >> * Do you find it worthwhile to add a prefix like “devm_” to the used >> regular expression? >> >> * Would like to improve any related scripts for the semantic patch language >>

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

>> Its implementation of the check “ALLOC_WITH_MULTIPLY” considers only an other >> search pattern so far. >> >> * Do you find it worthwhile to add a prefix like “devm_” to the used >> regular expression? >> >> * Would like to improve any related scripts for the semantic patch language >>

[PATCH 1/1] mfd: intel_soc_pmic_core: fix unchecked return value

From: Pan Bian unction devm_regmap_init_i2c() returns an ERR_PTR on errors, and its return value should be checked before it is dereferenced. However, in function intel_soc_pmic_i2c_probe(), the return value of function devm_regmap_init_i2c() is used without validation. This

[PATCH 1/1] mfd: intel_soc_pmic_core: fix unchecked return value

From: Pan Bian unction devm_regmap_init_i2c() returns an ERR_PTR on errors, and its return value should be checked before it is dereferenced. However, in function intel_soc_pmic_i2c_probe(), the return value of function devm_regmap_init_i2c() is used without validation. This patch fixes it.

Re: [PATCH 1/3] [media] si2157: get chip id during probing

On 03/16/2017 12:22 AM, Andreas Kemnade wrote: If the si2157 is behind a e.g. si2168, the si2157 will at least in some situations not be readable after the si268 got the command 0101. It still accepts commands but the answer is just ff. So read the chip id before that so the information is

Re: [PATCH 1/3] [media] si2157: get chip id during probing

On 03/16/2017 12:22 AM, Andreas Kemnade wrote: If the si2157 is behind a e.g. si2168, the si2157 will at least in some situations not be readable after the si268 got the command 0101. It still accepts commands but the answer is just ff. So read the chip id before that so the information is

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

SF Markus Elfring wrote: >>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply >> For example. Also I just noticed some previous comment by Krzysztof that >> pointed that out already. >> >> My suggestion: One sentence describing that the current situation is. > > Why do you find the

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

SF Markus Elfring wrote: >>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply >> For example. Also I just noticed some previous comment by Krzysztof that >> pointed that out already. >> >> My suggestion: One sentence describing that the current situation is. > > Why do you find the

[PATCH 1/1] [media] cobalt: fix unchecked return values

From: Pan Bian Function pci_find_ext_capability() may return 0, which is an invalid address. In function cobalt_pcie_status_show(), its return value is used without validation. This patch adds checks to validate the return address. Signed-off-by: Pan Bian

[PATCH 1/1] [media] cobalt: fix unchecked return values

From: Pan Bian Function pci_find_ext_capability() may return 0, which is an invalid address. In function cobalt_pcie_status_show(), its return value is used without validation. This patch adds checks to validate the return address. Signed-off-by: Pan Bian ---

Re: [tpmdd-devel] [backport v4.9] tpm_tis: use default timeout value if chip reports it as zero

On Wed, Apr 19, 2017 at 05:38:07PM +0200, Greg KH wrote: > On Wed, Apr 19, 2017 at 06:29:08PM +0300, Jarkko Sakkinen wrote: > > On Sun, Apr 16, 2017 at 09:14:29PM +0200, Paul Menzel wrote: > > > Dear Greg, > > > > > > > > > On 2017-04-15 22:50, Greg KH wrote: > > > > On Sat, Apr 15, 2017 at

Re: [tpmdd-devel] [backport v4.9] tpm_tis: use default timeout value if chip reports it as zero

On Wed, Apr 19, 2017 at 05:38:07PM +0200, Greg KH wrote: > On Wed, Apr 19, 2017 at 06:29:08PM +0300, Jarkko Sakkinen wrote: > > On Sun, Apr 16, 2017 at 09:14:29PM +0200, Paul Menzel wrote: > > > Dear Greg, > > > > > > > > > On 2017-04-15 22:50, Greg KH wrote: > > > > On Sat, Apr 15, 2017 at

[PATCH 1/1] qlcnic: fix unchecked return value

From: Pan Bian Function pci_find_ext_capability() may return 0, which is an invalid address. In function qlcnic_sriov_virtid_fn(), its return value is used without validation. This may result in invalid memory access bugs. This patch fixes the bug. Signed-off-by: Pan Bian

[PATCH 1/1] qlcnic: fix unchecked return value

From: Pan Bian Function pci_find_ext_capability() may return 0, which is an invalid address. In function qlcnic_sriov_virtid_fn(), its return value is used without validation. This may result in invalid memory access bugs. This patch fixes the bug. Signed-off-by: Pan Bian ---

[GIT pull] ras fix for 4.11

Linus, please pull the latest ras-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ras-urgent-for-linus The MCE atomic notifier callchain invokes callbacks which might sleep. Convert it to a blocking notifier and prevent calls from atomic context.

[GIT pull] ras fix for 4.11

Linus, please pull the latest ras-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ras-urgent-for-linus The MCE atomic notifier callchain invokes callbacks which might sleep. Convert it to a blocking notifier and prevent calls from atomic context.

[PATCH 1/1] staging: wilc1000: fix unchecked return value

From: Pan Bian Function dev_alloc_skb() will return a NULL pointer if there is no enough memory. However, in function WILC_WFI_mon_xmit(), its return value is used without validation. This may result in a bad memory access bug. This patch fixes the bug. Signed-off-by: Pan

[PATCH 1/1] staging: wilc1000: fix unchecked return value

From: Pan Bian Function dev_alloc_skb() will return a NULL pointer if there is no enough memory. However, in function WILC_WFI_mon_xmit(), its return value is used without validation. This may result in a bad memory access bug. This patch fixes the bug. Signed-off-by: Pan Bian ---

Re: [v4,1/6] powerpc: ftrace: minor cleanup

On Wed, 2017-04-19 at 12:52:23 UTC, "Naveen N. Rao" wrote: > Move the stack setup and teardown code to the ftrace_graph_caller(). > This way, we don't incur the cost of setting it up unless function graph > is enabled for this function. > > Also, remove the extraneous LR restore code after the

Re: [v4,1/6] powerpc: ftrace: minor cleanup

On Wed, 2017-04-19 at 12:52:23 UTC, "Naveen N. Rao" wrote: > Move the stack setup and teardown code to the ftrace_graph_caller(). > This way, we don't incur the cost of setting it up unless function graph > is enabled for this function. > > Also, remove the extraneous LR restore code after the

Re: [v3,7/7] powerpc: kprobes: remove duplicate saving of msr

On Wed, 2017-04-19 at 12:51:06 UTC, "Naveen N. Rao" wrote: > set_current_kprobe() already saves regs->msr into kprobe_saved_msr. Remove > the redundant save. > > Signed-off-by: Naveen N. Rao > Reviewed-by: Masami Hiramatsu Applied to

Re: [v3,7/7] powerpc: kprobes: remove duplicate saving of msr

On Wed, 2017-04-19 at 12:51:06 UTC, "Naveen N. Rao" wrote: > set_current_kprobe() already saves regs->msr into kprobe_saved_msr. Remove > the redundant save. > > Signed-off-by: Naveen N. Rao > Reviewed-by: Masami Hiramatsu Applied to powerpc next, thanks.

[GIT pull] irq fix for 4.11

Linus, please pull the latest irq-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-urgent-for-linus The (hopefully) final fix for the irq affinity spreading logic. Thanks, tglx --> Keith Busch (1):

[GIT pull] irq fix for 4.11

Linus, please pull the latest irq-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-urgent-for-linus The (hopefully) final fix for the irq affinity spreading logic. Thanks, tglx --> Keith Busch (1):

[tip:timers/urgent] nohz: Fix again collision between tick and other hrtimers

Commit-ID: d58bd60c773d8b16c19c4b9533bceee3761eb804 Gitweb: http://git.kernel.org/tip/d58bd60c773d8b16c19c4b9533bceee3761eb804 Author: Frederic Weisbecker AuthorDate: Fri, 21 Apr 2017 16:00:54 +0200 Committer: Thomas Gleixner CommitDate: Sun, 23

[tip:timers/urgent] tick: Make sure tick timer is active when bypassing reprogramming

Commit-ID: 22aa2ad45fd8a6ef56eb60038fc0ac7059c0a986 Gitweb: http://git.kernel.org/tip/22aa2ad45fd8a6ef56eb60038fc0ac7059c0a986 Author: Frederic Weisbecker AuthorDate: Fri, 21 Apr 2017 16:00:55 +0200 Committer: Thomas Gleixner CommitDate: Sun, 23

[tip:timers/urgent] tick: Make sure tick timer is active when bypassing reprogramming

Commit-ID: 22aa2ad45fd8a6ef56eb60038fc0ac7059c0a986 Gitweb: http://git.kernel.org/tip/22aa2ad45fd8a6ef56eb60038fc0ac7059c0a986 Author: Frederic Weisbecker AuthorDate: Fri, 21 Apr 2017 16:00:55 +0200 Committer: Thomas Gleixner CommitDate: Sun, 23 Apr 2017 13:33:18 +0200 tick: Make sure

[tip:timers/urgent] nohz: Fix again collision between tick and other hrtimers

Commit-ID: d58bd60c773d8b16c19c4b9533bceee3761eb804 Gitweb: http://git.kernel.org/tip/d58bd60c773d8b16c19c4b9533bceee3761eb804 Author: Frederic Weisbecker AuthorDate: Fri, 21 Apr 2017 16:00:54 +0200 Committer: Thomas Gleixner CommitDate: Sun, 23 Apr 2017 13:33:18 +0200 nohz: Fix again

[PATCH 1/1] usb: hub: check return value

From: Pan Bian Function usb_autopm_get_interface() will return a negative errno on failure, and function usb_autopm_put_interface() should not be called if it fails. However, in function usb_remove_device(), the return value of function usb_autopm_get_interface() is not

[PATCH 1/1] usb: hub: check return value

From: Pan Bian Function usb_autopm_get_interface() will return a negative errno on failure, and function usb_autopm_put_interface() should not be called if it fails. However, in function usb_remove_device(), the return value of function usb_autopm_get_interface() is not validated before calling

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply > For example. Also I just noticed some previous comment by Krzysztof that > pointed that out already. > > My suggestion: One sentence describing that the current situation is. Why do you find the sentence for the multiplication

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply > For example. Also I just noticed some previous comment by Krzysztof that > pointed that out already. > > My suggestion: One sentence describing that the current situation is. Why do you find the sentence for the multiplication

Question on the five-level page table support patches

Hi Kirill! I recently read the LWN article on your and your colleagues work to add five-level page table support for x86 to the Linux kernel [1] and I got your email address from the last patch of the series. Since this extends the address space beyond 48-bits, as you may know, it will cause

Question on the five-level page table support patches

Hi Kirill! I recently read the LWN article on your and your colleagues work to add five-level page table support for x86 to the Linux kernel [1] and I got your email address from the last patch of the series. Since this extends the address space beyond 48-bits, as you may know, it will cause

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

SF Markus Elfring wrote: >>> * A multiplication for the size determination of a memory allocation >>> indicated that an array data structure should be processed. >>> Thus use the corresponding function "devm_kcalloc". >> I have trouble parsing that sentences. This looks like the typical >>

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

SF Markus Elfring wrote: >>> * A multiplication for the size determination of a memory allocation >>> indicated that an array data structure should be processed. >>> Thus use the corresponding function "devm_kcalloc". >> I have trouble parsing that sentences. This looks like the typical >>

[PATCH v5 05/11] drm/sun4i: abstract a engine type

As we are going to add support for the Allwinner DE2 engine in sun4i-drm driver, we will finally have two types of display engines -- the DE1 backend and the DE2 mixer. They both do some display blending and feed graphics data to TCON, so I choose to call them both "engine" here. Abstract the

[PATCH v5 05/11] drm/sun4i: abstract a engine type

As we are going to add support for the Allwinner DE2 engine in sun4i-drm driver, we will finally have two types of display engines -- the DE1 backend and the DE2 mixer. They both do some display blending and feed graphics data to TCON, so I choose to call them both "engine" here. Abstract the

[PATCH v5 10/11] ARM: dts: sun8i: add pinmux for LCD pins of V3s SoC

Allwinner V3s SoC features a set of pins that have functionality of RGB LCD, the pins are at different pin ban than other SoCs. Add pinctrl node for them. Signed-off-by: Icenowy Zheng --- arch/arm/boot/dts/sun8i-v3s.dtsi | 9 + 1 file changed, 9 insertions(+) diff

[PATCH v5 10/11] ARM: dts: sun8i: add pinmux for LCD pins of V3s SoC

Allwinner V3s SoC features a set of pins that have functionality of RGB LCD, the pins are at different pin ban than other SoCs. Add pinctrl node for them. Signed-off-by: Icenowy Zheng --- arch/arm/boot/dts/sun8i-v3s.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v5 09/11] ARM: dts: sun8i: add DE2 nodes for V3s SoC

Allwinner V3s SoC features a "Display Engine 2.0" with only one TCON which have RGB LCD output. Add device nodes for it as well as the TCON. Signed-off-by: Icenowy Zheng --- arch/arm/boot/dts/sun8i-v3s.dtsi | 87 1 file changed, 87

[PATCH v5 11/11] [DO NOT MERGE] ARM: dts: sun8i: enable LCD panel of Lichee Pi Zero

A 480x272 QiaoDian QD43003C0-40-7LED panel is available from Lichee Pi. This commit connects this panel to Lichee Pi Zero. Lichee Pi also provides a 800x480 panel without accurate model number, so do not merge this patch. It will finally come as device tree overlay. Signed-off-by: Icenowy Zheng

[PATCH v5 09/11] ARM: dts: sun8i: add DE2 nodes for V3s SoC

Allwinner V3s SoC features a "Display Engine 2.0" with only one TCON which have RGB LCD output. Add device nodes for it as well as the TCON. Signed-off-by: Icenowy Zheng --- arch/arm/boot/dts/sun8i-v3s.dtsi | 87 1 file changed, 87 insertions(+) diff

[PATCH v5 11/11] [DO NOT MERGE] ARM: dts: sun8i: enable LCD panel of Lichee Pi Zero

A 480x272 QiaoDian QD43003C0-40-7LED panel is available from Lichee Pi. This commit connects this panel to Lichee Pi Zero. Lichee Pi also provides a 800x480 panel without accurate model number, so do not merge this patch. It will finally come as device tree overlay. Signed-off-by: Icenowy Zheng

[PATCH v5 07/11] drm/sun4i: Add compatible string for V3s display engine

Allwinner V3s features the new "Display Engine 2.0", which can now also be driven with our subdrivers in sun4i-drm. Add the compatible string for in sun4i_drv.c, in order to make the display engine and its components probed. Signed-off-by: Icenowy Zheng ---

[PATCH v5 07/11] drm/sun4i: Add compatible string for V3s display engine

Allwinner V3s features the new "Display Engine 2.0", which can now also be driven with our subdrivers in sun4i-drm. Add the compatible string for in sun4i_drv.c, in order to make the display engine and its components probed. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/sun4i/sun4i_drv.c |

[PATCH v5 04/11] drm/sun4i: return only planes for layers created

As we are going to add support for the Allwinner DE2 Mixer in sun4i-drm driver, we will finally have two types of layers. Each layer is bound to a drm_plane that is CRTC-specific, so we create them when initializing CRTC (calling sun4i_layers_init, which will be generalized in next patch). The

[PATCH v5 04/11] drm/sun4i: return only planes for layers created

As we are going to add support for the Allwinner DE2 Mixer in sun4i-drm driver, we will finally have two types of layers. Each layer is bound to a drm_plane that is CRTC-specific, so we create them when initializing CRTC (calling sun4i_layers_init, which will be generalized in next patch). The

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

>> * A multiplication for the size determination of a memory allocation >> indicated that an array data structure should be processed. >> Thus use the corresponding function "devm_kcalloc". > I have trouble parsing that sentences. This looks like the typical > approach of native german

[PATCH v5 03/11] dt-bindings: add bindings for DE2 on V3s SoC

Allwinner V3s SoC have a display engine which have a different pipeline with older SoCs. Add document for it (new compatibles and the new "mixer" part). Signed-off-by: Icenowy Zheng Acked-by: Rob Herring --- Changes in v4: - Removed the refactor at TCON

[PATCH v5 08/11] drm/sun4i: tcon: add support for V3s TCON

Allwinner V3s SoC features a TCON without channel 1. Add support for it. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/sun4i/sun4i_drv.c | 3 ++- drivers/gpu/drm/sun4i/sun4i_tcon.c | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v5 03/11] dt-bindings: add bindings for DE2 on V3s SoC

Allwinner V3s SoC have a display engine which have a different pipeline with older SoCs. Add document for it (new compatibles and the new "mixer" part). Signed-off-by: Icenowy Zheng Acked-by: Rob Herring --- Changes in v4: - Removed the refactor at TCON chapter. Changes in v3: - Remove the

[PATCH v5 08/11] drm/sun4i: tcon: add support for V3s TCON

Allwinner V3s SoC features a TCON without channel 1. Add support for it. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/sun4i/sun4i_drv.c | 3 ++- drivers/gpu/drm/sun4i/sun4i_tcon.c | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

>> * A multiplication for the size determination of a memory allocation >> indicated that an array data structure should be processed. >> Thus use the corresponding function "devm_kcalloc". > I have trouble parsing that sentences. This looks like the typical > approach of native german

[PATCH v5 06/11] drm/sun4i: add support for Allwinner DE2 mixers

Allwinner have a new "Display Engine 2.0" in their new SoCs, which comes with mixers to do graphic processing and feed data to TCON, like the old backends and frontends. Add support for the mixer on Allwinner V3s SoC; it's the simplest one. Currently a lot of functions are still missing -- more

[PATCH v5 06/11] drm/sun4i: add support for Allwinner DE2 mixers

Allwinner have a new "Display Engine 2.0" in their new SoCs, which comes with mixers to do graphic processing and feed data to TCON, like the old backends and frontends. Add support for the mixer on Allwinner V3s SoC; it's the simplest one. Currently a lot of functions are still missing -- more

[PATCH v5 02/11] clk: sunxi-ng: add support for DE2 CCU

The "Display Engine 2.0" in Allwinner newer SoCs contains a clock management unit for its subunits, like the DE CCU in A80. Add a sunxi-ng style driver for it. Signed-off-by: Icenowy Zheng --- Changes in v5: - Removed dt-bindings headers (they're now in patch 1). Changes in v4:

[PATCH v5 02/11] clk: sunxi-ng: add support for DE2 CCU

The "Display Engine 2.0" in Allwinner newer SoCs contains a clock management unit for its subunits, like the DE CCU in A80. Add a sunxi-ng style driver for it. Signed-off-by: Icenowy Zheng --- Changes in v5: - Removed dt-bindings headers (they're now in patch 1). Changes in v4: - Fixed the

[PATCH v5 01/11] dt-bindings: add binding for the Allwinner DE2 CCU

Allwinner "Display Engine 2.0" contains some clock controls in it. In order to add them as clock drivers, we need a device tree binding. Add the binding here. Also add the device tree binding headers. Signed-off-by: Icenowy Zheng --- Changes in v5: - Moved dt-binding headers

[PATCH v5 01/11] dt-bindings: add binding for the Allwinner DE2 CCU

Allwinner "Display Engine 2.0" contains some clock controls in it. In order to add them as clock drivers, we need a device tree binding. Add the binding here. Also add the device tree binding headers. Signed-off-by: Icenowy Zheng --- Changes in v5: - Moved dt-binding headers here. - Changed

[PATCH v5 00/11] Initial Allwinner Display Engine 2.0 Support

This patchset is the initial patchset for Allwinner DE2 support. It contains the support of clocks in DE2 and the mixers in DE2. The SoC used to develop this patchset is V3s, as V3s is the simplest one of the SoCs that have DE2. (Allwinner V3s features only one mixer, although its clock control

[PATCH v5 00/11] Initial Allwinner Display Engine 2.0 Support

This patchset is the initial patchset for Allwinner DE2 support. It contains the support of clocks in DE2 and the mixers in DE2. The SoC used to develop this patchset is V3s, as V3s is the simplest one of the SoCs that have DE2. (Allwinner V3s features only one mixer, although its clock control

[PATCH 3/5] trace-cmd:read: BUG initialize input_files item to zero

On allocation the data structure was not initialized. Later on some attribute of this structure are used (e.g. tsoffset) assuming that the default value is zero, but it is not always true. Signed-off-by: Federico Vaga --- trace-read.c | 1 + 1 file changed, 1

[PATCH 3/5] trace-cmd:read: BUG initialize input_files item to zero

On allocation the data structure was not initialized. Later on some attribute of this structure are used (e.g. tsoffset) assuming that the default value is zero, but it is not always true. Signed-off-by: Federico Vaga --- trace-read.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/5] plugin:python: fix compiler warning

The function `load_plugin` is passed, as argument, to `trace_util_load_plugins()` but the prototype was not exactly the same. Signed-off-by: Federico Vaga --- plugin_python.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/plugin_python.c

[PATCH 1/5] plugin:python: fix compiler warning

The function `load_plugin` is passed, as argument, to `trace_util_load_plugins()` but the prototype was not exactly the same. Signed-off-by: Federico Vaga --- plugin_python.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/plugin_python.c b/plugin_python.c index

trace-cmd bug fixes

This set of patches contains some fixes found while studying the trace-cmd code.

[PATCH 4/5] trace-cmd: fix argument parsing minor BUG

For some reason the list command does not use anymore `getopt()` to parse the arguments, instead it uses a custum implementation. During this change [5da0eff trace-cmd: Add regex for listing of events] the variable `optind` has been forgotten. To reproduce the problem try to use invalid

[PATCH 5/5] trace-cmd: BUG fix malloc() pointer validation

To reproduce the bug mkdir /sys/kernel/debug/tracing/instances/test ./trace-cmd show -B test -s -f Failed to allocate instance path snapshot Signed-off-by: Federico Vaga --- trace-cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace-cmd.c

trace-cmd bug fixes

This set of patches contains some fixes found while studying the trace-cmd code.

[PATCH 4/5] trace-cmd: fix argument parsing minor BUG

For some reason the list command does not use anymore `getopt()` to parse the arguments, instead it uses a custum implementation. During this change [5da0eff trace-cmd: Add regex for listing of events] the variable `optind` has been forgotten. To reproduce the problem try to use invalid

[PATCH 5/5] trace-cmd: BUG fix malloc() pointer validation

To reproduce the bug mkdir /sys/kernel/debug/tracing/instances/test ./trace-cmd show -B test -s -f Failed to allocate instance path snapshot Signed-off-by: Federico Vaga --- trace-cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace-cmd.c b/trace-cmd.c index

[PATCH 2/5] plugin:python: check asprintf() errors

The code was validating the string but the man page for asprintf(3) says clearly: If memory allocation wasn't possible, or some other error occurs, these functions will return -1, and the contents of strp are undefined. So, we cannot really rely on the returned string pointer.

[PATCH 2/5] plugin:python: check asprintf() errors

The code was validating the string but the man page for asprintf(3) says clearly: If memory allocation wasn't possible, or some other error occurs, these functions will return -1, and the contents of strp are undefined. So, we cannot really rely on the returned string pointer.

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

-for-some-Mediatek-SoCs/20170423-163432 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

-for-some-Mediatek-SoCs/20170423-163432 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O

RE: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

> New helpers take pointers to uuid_{be|le} as parameters. > > When using them on a raw data we don't need to do an ugly dereference and, > in some cases, a type casting. > > Cc: Andrew Morton > Cc: Arnd Bergmann > Cc: Liam Girdwood

RE: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

> New helpers take pointers to uuid_{be|le} as parameters. > > When using them on a raw data we don't need to do an ugly dereference and, > in some cases, a type casting. > > Cc: Andrew Morton > Cc: Arnd Bergmann > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Vinod Koul > Cc: Srinivas

Re: [PATCH v2 3/3] powerpc/mm: Implement CONFIG_DEBUG_RODATA on PPC32

christophe leroy writes: > Le 22/04/2017 à 08:08, Michael Ellerman a écrit : >> "Naveen N. Rao" writes: >>> Excerpts from Christophe Leroy's message of April 21, 2017 18:32: diff --git a/arch/powerpc/kernel/ftrace.c

Re: [PATCH v2 3/3] powerpc/mm: Implement CONFIG_DEBUG_RODATA on PPC32

christophe leroy writes: > Le 22/04/2017 à 08:08, Michael Ellerman a écrit : >> "Naveen N. Rao" writes: >>> Excerpts from Christophe Leroy's message of April 21, 2017 18:32: diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c index 32509de6ce4c..06d2ac53f471

Re: [PATCH] mm, vmscan: do not loop on too_many_isolated for ever

On 2017/03/10 20:44, Tetsuo Handa wrote: > Michal Hocko wrote: >> On Thu 09-03-17 13:05:40, Johannes Weiner wrote: >>> On Tue, Mar 07, 2017 at 02:52:36PM -0500, Rik van Riel wrote: It only does this to some extent. If reclaim made no progress, for example due to immediately bailing

Re: [PATCH] mm, vmscan: do not loop on too_many_isolated for ever

On 2017/03/10 20:44, Tetsuo Handa wrote: > Michal Hocko wrote: >> On Thu 09-03-17 13:05:40, Johannes Weiner wrote: >>> On Tue, Mar 07, 2017 at 02:52:36PM -0500, Rik van Riel wrote: It only does this to some extent. If reclaim made no progress, for example due to immediately bailing

[PATCH 1/1] iommu/amd: fix incorrect error handling

From: Pan Bian In function amd_iommu_bind_pasid(), the control flow jumps to label out_free when pasid_state->mm and mm is NULL. And mmput(mm) is called. In function mmput(mm), mm is referenced without validation. This will result in a NULL dereference bug. This patch fixes

[PATCH 1/1] iommu/amd: fix incorrect error handling

From: Pan Bian In function amd_iommu_bind_pasid(), the control flow jumps to label out_free when pasid_state->mm and mm is NULL. And mmput(mm) is called. In function mmput(mm), mm is referenced without validation. This will result in a NULL dereference bug. This patch fixes the bug.

[PATCH 1/1] char: xillybus: check return value

From: Pan Bian Function of_address_to_resource() tries to translate device tree address and return as resource. If the translation fails, it will return a negative errno. However, function xilly_drv_probe() does not validate its return value, which may result in a bad memory

[PATCH 1/1] char: xillybus: check return value

From: Pan Bian Function of_address_to_resource() tries to translate device tree address and return as resource. If the translation fails, it will return a negative errno. However, function xilly_drv_probe() does not validate its return value, which may result in a bad memory access bug. This

Re: [PATCH 1/2] dmaengine: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

Hello Markus, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 22 Apr 2017 23:00:23 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the

Re: [PATCH 1/2] dmaengine: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

Hello Markus, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 22 Apr 2017 23:00:23 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc".

[PATCH] staging: android: ion: fix coding style issue

Use tab instead of spaces for indentation, as reported by checkpatch.pl Signed-off-by: Adheer Chandravanshi --- drivers/staging/android/ion/ion_cma_heap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] staging: android: ion: fix coding style issue

Use tab instead of spaces for indentation, as reported by checkpatch.pl Signed-off-by: Adheer Chandravanshi --- drivers/staging/android/ion/ion_cma_heap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion_cma_heap.c

Re: [PATCH] mailbox: fix completion order for blocking requests

On Tue, Apr 11, 2017 at 6:15 PM, Alexey Klimov wrote: > On Thu, Apr 06, 2017 at 10:45:26PM +0530, Jassi Brar wrote: >> On 6 April 2017 at 22:28, Alexey Klimov wrote: >> > Hi Jassi/Sudeep, >> > >> > On Wed, Mar 29, 2017 at 07:01:09PM +0100, Sudeep

Re: [PATCH] mailbox: fix completion order for blocking requests

On Tue, Apr 11, 2017 at 6:15 PM, Alexey Klimov wrote: > On Thu, Apr 06, 2017 at 10:45:26PM +0530, Jassi Brar wrote: >> On 6 April 2017 at 22:28, Alexey Klimov wrote: >> > Hi Jassi/Sudeep, >> > >> > On Wed, Mar 29, 2017 at 07:01:09PM +0100, Sudeep Holla wrote: >> >> >> >> >> >> On 29/03/17 18:43,

[PATCH 1/1] net: bcmgenet: fix incorrect return value checks

From: Pan Bian Function platform_get_irq() will return a negative value on errors. However, in function bcmgenet_probe(), 0 is considered as a flag of error. This patch fixes the bug by checking whether the return value of platform_get_irq() is less than 0. Signed-off-by:

[PATCH 1/1] net: bcmgenet: fix incorrect return value checks

From: Pan Bian Function platform_get_irq() will return a negative value on errors. However, in function bcmgenet_probe(), 0 is considered as a flag of error. This patch fixes the bug by checking whether the return value of platform_get_irq() is less than 0. Signed-off-by: Pan Bian ---

tango_nand: is logic right in error cases? (was Re: fsl_ifc_nand: are blank pages protected by ECC?)

Hi! > > Maybe I figured it out. Unfortunately, it is only compile tested. Does > > it look approximately right? > > Yep that's definitely better. Just one thing missing (see below), > otherwise it looks good. I'm copying from tango_nand, therefore I had to check tango_nand, too. static int

tango_nand: is logic right in error cases? (was Re: fsl_ifc_nand: are blank pages protected by ECC?)

Hi! > > Maybe I figured it out. Unfortunately, it is only compile tested. Does > > it look approximately right? > > Yep that's definitely better. Just one thing missing (see below), > otherwise it looks good. I'm copying from tango_nand, therefore I had to check tango_nand, too. static int

<    1   2   3   4   5   6   7   >