Re: [PATCH] mm, zone_device: replace {get, put}_zone_device_page() with a single reference

2017-04-27 Thread Logan Gunthorpe
On 27/04/17 10:38 AM, Dan Williams wrote: > ...is inside a for_each_device_pfn() loop. > Ah, oops. Then that makes perfect sense. Thanks. You may have my review tag if you'd like: Reviewed-by: Logan Gunthorpe Logan

Re: [PATCH] mm, zone_device: replace {get, put}_zone_device_page() with a single reference

2017-04-27 Thread Logan Gunthorpe
On 27/04/17 10:38 AM, Dan Williams wrote: > ...is inside a for_each_device_pfn() loop. > Ah, oops. Then that makes perfect sense. Thanks. You may have my review tag if you'd like: Reviewed-by: Logan Gunthorpe Logan

Re: [PATCH 2/3] iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #74

2017-04-27 Thread Mark Rutland
On Thu, Apr 27, 2017 at 05:16:23PM +0530, Geetha sowjanya wrote: > + /* > + * Override the size, for Cavium CN99xx implementations > + * which doesn't support the page 1 SMMU register space. > + */ > + cpu_model = read_cpuid_id() & MIDR_CPU_MODEL_MASK; > + if (cpu_model

Re: [PATCH 2/3] iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #74

2017-04-27 Thread Mark Rutland
On Thu, Apr 27, 2017 at 05:16:23PM +0530, Geetha sowjanya wrote: > + /* > + * Override the size, for Cavium CN99xx implementations > + * which doesn't support the page 1 SMMU register space. > + */ > + cpu_model = read_cpuid_id() & MIDR_CPU_MODEL_MASK; > + if (cpu_model

Re: [PATCH v4 00/21] PCI: fix config space memory mappings

2017-04-27 Thread Khuong Dinh
Hi, They're same before and after applying the patch. It was tested with X-Gene 1 and X-Gene 2 with DT (Device Tree) and ACPI boot. X-Gene 1 - DT : [root@(none) ~]# lspci -s 01:00.0 -v 01:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network Connection Subsystem: Intel

Re: [PATCH v4 00/21] PCI: fix config space memory mappings

2017-04-27 Thread Khuong Dinh
Hi, They're same before and after applying the patch. It was tested with X-Gene 1 and X-Gene 2 with DT (Device Tree) and ACPI boot. X-Gene 1 - DT : [root@(none) ~]# lspci -s 01:00.0 -v 01:00.0 Ethernet controller: Intel Corporation 82574L Gigabit Network Connection Subsystem: Intel

Re: [PATCH v5 08/11] mm: hwpoison: soft offline supports thp migration

2017-04-27 Thread Zi Yan
Naoya Horiguchi wrote: > On Fri, Apr 21, 2017 at 10:55:49AM -0500, Zi Yan wrote: >> >> Anshuman Khandual wrote: >>> On 04/21/2017 02:17 AM, Zi Yan wrote: From: Naoya Horiguchi This patch enables thp migration for soft offline. Signed-off-by:

Re: [PATCH v5 08/11] mm: hwpoison: soft offline supports thp migration

2017-04-27 Thread Zi Yan
Naoya Horiguchi wrote: > On Fri, Apr 21, 2017 at 10:55:49AM -0500, Zi Yan wrote: >> >> Anshuman Khandual wrote: >>> On 04/21/2017 02:17 AM, Zi Yan wrote: From: Naoya Horiguchi This patch enables thp migration for soft offline. Signed-off-by: Naoya Horiguchi

Re: [PATCH 2/2] ARM: dts: NSP: Add Thermal Support

2017-04-27 Thread Eduardo Valentin
On Tue, Apr 25, 2017 at 04:49:11PM -0400, Jon Mason wrote: > Add thermal support via the ns-thermal driver and create a single > thermal zone for the entire SoC. > > Signed-off-by: Jon Mason Acked-by: Eduardo Valentin > --- >

Re: [PATCH 2/2] ARM: dts: NSP: Add Thermal Support

2017-04-27 Thread Eduardo Valentin
On Tue, Apr 25, 2017 at 04:49:11PM -0400, Jon Mason wrote: > Add thermal support via the ns-thermal driver and create a single > thermal zone for the entire SoC. > > Signed-off-by: Jon Mason Acked-by: Eduardo Valentin > --- > arch/arm/boot/dts/bcm-nsp.dtsi | 26 ++ >

Re: [PATCH] mm, zone_device: replace {get, put}_zone_device_page() with a single reference

2017-04-27 Thread Dan Williams
On Thu, Apr 27, 2017 at 9:33 AM, Logan Gunthorpe wrote: > > > On 27/04/17 10:14 AM, Dan Williams wrote: >> You're overlooking that the page reference count 1 after >> arch_add_memory(). So at the end of time we're just dropping the >> arch_add_memory() reference to release

Re: [PATCH] mm, zone_device: replace {get, put}_zone_device_page() with a single reference

2017-04-27 Thread Dan Williams
On Thu, Apr 27, 2017 at 9:33 AM, Logan Gunthorpe wrote: > > > On 27/04/17 10:14 AM, Dan Williams wrote: >> You're overlooking that the page reference count 1 after >> arch_add_memory(). So at the end of time we're just dropping the >> arch_add_memory() reference to release the page and related >>

Re: [PATCH 0/3] Cavium ThunderX2 SMMUv3 errata workarounds

2017-04-27 Thread Sunil Kovvuri
On Thu, Apr 27, 2017 at 7:09 PM, Robert Richter wrote: > On 27.04.17 17:16:21, Geetha sowjanya wrote: >> From: Geetha >> >> Cavium CN99xx SMMUv3 implementation has two Silicon Erratas. >> 1. Errata ID #74 >>SMMU register alias Page 1 is not

Re: [PATCH 0/3] Cavium ThunderX2 SMMUv3 errata workarounds

2017-04-27 Thread Sunil Kovvuri
On Thu, Apr 27, 2017 at 7:09 PM, Robert Richter wrote: > On 27.04.17 17:16:21, Geetha sowjanya wrote: >> From: Geetha >> >> Cavium CN99xx SMMUv3 implementation has two Silicon Erratas. >> 1. Errata ID #74 >>SMMU register alias Page 1 is not implemented >> 2. Errata ID #126 >>SMMU doesnt

Re: [PATCH 1/2] thermal: broadcom: Allow for NSP to use ns-thermal driver

2017-04-27 Thread Eduardo Valentin
Hey Jason, On Tue, Apr 25, 2017 at 04:49:10PM -0400, Jon Mason wrote: > Change the iProc Kconfig to select THERMAL and THERMAL_OF, which allows > the ns-thermal driver to be selected via menuconfig. Also, change the > ns-thermal driver to work on any iProc based SoC. Finally, tweak the >

Re: [PATCH 1/2] thermal: broadcom: Allow for NSP to use ns-thermal driver

2017-04-27 Thread Eduardo Valentin
Hey Jason, On Tue, Apr 25, 2017 at 04:49:10PM -0400, Jon Mason wrote: > Change the iProc Kconfig to select THERMAL and THERMAL_OF, which allows > the ns-thermal driver to be selected via menuconfig. Also, change the > ns-thermal driver to work on any iProc based SoC. Finally, tweak the >

[PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-04-27 Thread Eric Anholt
Many DRM drivers have common code to make a stub connector implementation that wraps a drm_panel. By wrapping the panel in a DRM bridge, all of the connector code (including calls during encoder enable/disable) goes away. Signed-off-by: Eric Anholt ---

[PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-04-27 Thread Eric Anholt
Many DRM drivers have common code to make a stub connector implementation that wraps a drm_panel. By wrapping the panel in a DRM bridge, all of the connector code (including calls during encoder enable/disable) goes away. Signed-off-by: Eric Anholt --- Documentation/gpu/drm-kms-helpers.rst |

[PATCH 2/2] drm/vc4: Switch to using the panel-bridge layer, and support bridges.

2017-04-27 Thread Eric Anholt
The newer version of the RPi panel driver is going to be a combination of a bridge and a panel, but we should also support panels without a bridge, so the panel-bridge layer lets us do that cleanly. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/Kconfig | 2 +-

[PATCH 2/2] drm/vc4: Switch to using the panel-bridge layer, and support bridges.

2017-04-27 Thread Eric Anholt
The newer version of the RPi panel driver is going to be a combination of a bridge and a panel, but we should also support panels without a bridge, so the panel-bridge layer lets us do that cleanly. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/Kconfig | 2 +-

Re: [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked() (was: Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a percpu_rwsem)

2017-04-27 Thread Suzuki K Poulose
On Thu, Apr 27, 2017 at 04:48:06PM +0100, Mark Rutland wrote: > Hi Catalin/Will, > > The below addresses a boot failure Catalin spotted in next-20170424, > based on Sebastian's patch [1]. I've given it a spin on Juno R1, where I > can reproduce the issue prior to applying this patch. > > I

Re: [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked() (was: Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a percpu_rwsem)

2017-04-27 Thread Suzuki K Poulose
On Thu, Apr 27, 2017 at 04:48:06PM +0100, Mark Rutland wrote: > Hi Catalin/Will, > > The below addresses a boot failure Catalin spotted in next-20170424, > based on Sebastian's patch [1]. I've given it a spin on Juno R1, where I > can reproduce the issue prior to applying this patch. > > I

Re: iov_iter_pipe warning.

2017-04-27 Thread Dave Jones
On Thu, Apr 27, 2017 at 12:19:18AM -0400, Dave Jones wrote: > On Fri, Apr 21, 2017 at 06:54:30PM +0100, Al Viro wrote: > > On Wed, Apr 12, 2017 at 03:03:18PM -0400, Dave Jones wrote: > > > > > Well it's been running an hour without incident, which looks promising. > > > I'll leave it

Re: iov_iter_pipe warning.

2017-04-27 Thread Dave Jones
On Thu, Apr 27, 2017 at 12:19:18AM -0400, Dave Jones wrote: > On Fri, Apr 21, 2017 at 06:54:30PM +0100, Al Viro wrote: > > On Wed, Apr 12, 2017 at 03:03:18PM -0400, Dave Jones wrote: > > > > > Well it's been running an hour without incident, which looks promising. > > > I'll leave it

[PATCH v2] ceph: Fix file open flags on ppc64

2017-04-27 Thread Alexander Graf
The file open flags (O_foo) are platform specific and should never go out to an interface that is not local to the system. Unfortunately these flags have leaked out onto the wire in the cephfs implementation. That lead to bogus flags getting transmitted on ppc64. This patch converts the kernel

[PATCH v2] ceph: Fix file open flags on ppc64

2017-04-27 Thread Alexander Graf
The file open flags (O_foo) are platform specific and should never go out to an interface that is not local to the system. Unfortunately these flags have leaked out onto the wire in the cephfs implementation. That lead to bogus flags getting transmitted on ppc64. This patch converts the kernel

Re: Generic DMA-capable streaming device driver looking for home

2017-04-27 Thread Lars-Peter Clausen
On 04/27/2017 04:50 PM, Sinan Kaya wrote: > On 4/27/2017 10:00 AM, Jon Masters wrote: >> On 04/20/2017 06:10 PM, Alex Williams wrote: >>> Hi all, >>> >>> We're writing a device driver and having some difficulty matching a >>> subsystem to the driver/device properties. Can anyone help with >>>

Re: Generic DMA-capable streaming device driver looking for home

2017-04-27 Thread Lars-Peter Clausen
On 04/27/2017 04:50 PM, Sinan Kaya wrote: > On 4/27/2017 10:00 AM, Jon Masters wrote: >> On 04/20/2017 06:10 PM, Alex Williams wrote: >>> Hi all, >>> >>> We're writing a device driver and having some difficulty matching a >>> subsystem to the driver/device properties. Can anyone help with >>>

Re: [PATCH] mm, zone_device: replace {get, put}_zone_device_page() with a single reference

2017-04-27 Thread Logan Gunthorpe
On 27/04/17 10:14 AM, Dan Williams wrote: > You're overlooking that the page reference count 1 after > arch_add_memory(). So at the end of time we're just dropping the > arch_add_memory() reference to release the page and related > dev_pagemap. Thanks, that does actually make a lot more sense

Re: [PATCH] mm, zone_device: replace {get, put}_zone_device_page() with a single reference

2017-04-27 Thread Logan Gunthorpe
On 27/04/17 10:14 AM, Dan Williams wrote: > You're overlooking that the page reference count 1 after > arch_add_memory(). So at the end of time we're just dropping the > arch_add_memory() reference to release the page and related > dev_pagemap. Thanks, that does actually make a lot more sense

[PATCH] net: ath: tx99: fixed a spelling issue

2017-04-27 Thread ammly
Fixed a spelling issue. Signed-off-by: Ammly Fredrick --- drivers/net/wireless/ath/ath9k/tx99.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/tx99.c b/drivers/net/wireless/ath/ath9k/tx99.c index 16aca9e28b77..a866cbda0799

[PATCH] net: ath: tx99: fixed a spelling issue

2017-04-27 Thread ammly
Fixed a spelling issue. Signed-off-by: Ammly Fredrick --- drivers/net/wireless/ath/ath9k/tx99.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/tx99.c b/drivers/net/wireless/ath/ath9k/tx99.c index 16aca9e28b77..a866cbda0799 100644 ---

Re: [RFC PATCH] printk: Make functions of pr_ macros

2017-04-27 Thread Steven Rostedt
On Thu, 27 Apr 2017 17:11:21 +0200 Petr Mladek wrote: > BTW: The above mentioned commit adds one argument to > vprintk_default(). But the symbol is exported. I am > not sure if we could break the API. There is no kernel ABI/API. Exported kernel functions can change at will as

Re: [RFC PATCH] printk: Make functions of pr_ macros

2017-04-27 Thread Steven Rostedt
On Thu, 27 Apr 2017 17:11:21 +0200 Petr Mladek wrote: > BTW: The above mentioned commit adds one argument to > vprintk_default(). But the symbol is exported. I am > not sure if we could break the API. There is no kernel ABI/API. Exported kernel functions can change at will as long as a make

Re: [PATCH] Introduce v3 namespaced file capabilities

2017-04-27 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > "Serge E. Hallyn" writes: > >> Quoting Eric W. Biederman (ebied...@xmission.com): >>> >>> "Serge E. Hallyn" writes: >>> >>> > diff --git a/fs/xattr.c b/fs/xattr.c >>> > index 7e3317c..75cc65a 100644 >>> >

Re: [PATCH] Introduce v3 namespaced file capabilities

2017-04-27 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > "Serge E. Hallyn" writes: > >> Quoting Eric W. Biederman (ebied...@xmission.com): >>> >>> "Serge E. Hallyn" writes: >>> >>> > diff --git a/fs/xattr.c b/fs/xattr.c >>> > index 7e3317c..75cc65a 100644 >>> > --- a/fs/xattr.c >>> > +++

Re: [PATCH] usb: musb: musb_host: Introduce postponed URB giveback

2017-04-27 Thread Matwey V. Kornilov
2017-04-27 18:35 GMT+03:00 Bin Liu : > Hi Matwey, > > On Thu, Apr 27, 2017 at 01:20:33PM +0300, Matwey V. Kornilov wrote: >> This commit changes the order of actions undertaken in >> musb_advance_schedule() in order to overcome issue with broken >> isochronous transfer [1]. >> >>

Re: [PATCH] usb: musb: musb_host: Introduce postponed URB giveback

2017-04-27 Thread Matwey V. Kornilov
2017-04-27 18:35 GMT+03:00 Bin Liu : > Hi Matwey, > > On Thu, Apr 27, 2017 at 01:20:33PM +0300, Matwey V. Kornilov wrote: >> This commit changes the order of actions undertaken in >> musb_advance_schedule() in order to overcome issue with broken >> isochronous transfer [1]. >> >> There is no harm

Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

2017-04-27 Thread Eduardo Valentin
On Wed, Apr 26, 2017 at 04:17:52PM +0530, Viresh Kumar wrote: > On 26-04-17, 11:41, Lukasz Luba wrote: > > Hi Viresh, > > > > I went through the v4 code and it looks good to me. > > Feel free to add for the v4 series > > Reviewed-by: Lukasz Luba > > Thanks a lot for testing

Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

2017-04-27 Thread Eduardo Valentin
On Wed, Apr 26, 2017 at 04:17:52PM +0530, Viresh Kumar wrote: > On 26-04-17, 11:41, Lukasz Luba wrote: > > Hi Viresh, > > > > I went through the v4 code and it looks good to me. > > Feel free to add for the v4 series > > Reviewed-by: Lukasz Luba > > Thanks a lot for testing and reviewing the

Re: [lkp-robot] [perf] 924726b2b5: double_fault:#[##]

2017-04-27 Thread Sebastian Andrzej Siewior
On 2017-04-27 10:58:36 [+0800], kernel test robot wrote: > > FYI, we noticed the following commit: > > commit: 924726b2b5e5000dfb8eb6032651baed1b1bdc6c ("perf: Cure hotplug lock > ordering issues") > https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git smp/hotplug I can't find that commit

Re: [lkp-robot] [perf] 924726b2b5: double_fault:#[##]

2017-04-27 Thread Sebastian Andrzej Siewior
On 2017-04-27 10:58:36 [+0800], kernel test robot wrote: > > FYI, we noticed the following commit: > > commit: 924726b2b5e5000dfb8eb6032651baed1b1bdc6c ("perf: Cure hotplug lock > ordering issues") > https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git smp/hotplug I can't find that commit

Re: [PATCH 2/2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy

2017-04-27 Thread Oleg Nesterov
On 04/27, Kirill Tkhai wrote: > > On 27.04.2017 19:12, Oleg Nesterov wrote: > > On 04/26, Kirill Tkhai wrote: > >> > >> On 26.04.2017 18:53, Oleg Nesterov wrote: > >>> > +static long set_last_pid_vec(struct pid_namespace *pid_ns, > + struct pidns_ioc_req *req)

Re: [PATCH 2/2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy

2017-04-27 Thread Oleg Nesterov
On 04/27, Kirill Tkhai wrote: > > On 27.04.2017 19:12, Oleg Nesterov wrote: > > On 04/26, Kirill Tkhai wrote: > >> > >> On 26.04.2017 18:53, Oleg Nesterov wrote: > >>> > +static long set_last_pid_vec(struct pid_namespace *pid_ns, > + struct pidns_ioc_req *req)

Re: [PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions

2017-04-27 Thread Eduardo Valentin
On Wed, Apr 26, 2017 at 05:33:10PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 26 Apr 2017 17:24:56 +0200 > > Three update suggestions were taken into account > from static source code analysis. > > Markus Elfring (3): > Use

Re: [PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions

2017-04-27 Thread Eduardo Valentin
On Wed, Apr 26, 2017 at 05:33:10PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 26 Apr 2017 17:24:56 +0200 > > Three update suggestions were taken into account > from static source code analysis. > > Markus Elfring (3): > Use devm_kcalloc() in ti_bandgap_build() >

Re: [PATCH 2/2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy

2017-04-27 Thread Kirill Tkhai
On 27.04.2017 19:12, Oleg Nesterov wrote: > On 04/26, Kirill Tkhai wrote: >> >> On 26.04.2017 18:53, Oleg Nesterov wrote: >>> +static long set_last_pid_vec(struct pid_namespace *pid_ns, + struct pidns_ioc_req *req) +{ + char *str, *p; + int ret = 0;

Re: [PATCH 2/2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy

2017-04-27 Thread Kirill Tkhai
On 27.04.2017 19:12, Oleg Nesterov wrote: > On 04/26, Kirill Tkhai wrote: >> >> On 26.04.2017 18:53, Oleg Nesterov wrote: >>> +static long set_last_pid_vec(struct pid_namespace *pid_ns, + struct pidns_ioc_req *req) +{ + char *str, *p; + int ret = 0;

[RFC] drm/amd/amdgpu: get rid of else branch

2017-04-27 Thread Nikola Pajkovsky
This is super simple elimination of else branch and I should probably even use unlikely in if (ring->count_dw < count_dw) { However, amdgpu_ring_write() has similar if condition, but does not return after DRM_ERROR and it looks suspicious. On error, we still adding v to ring and keeping

[RFC] drm/amd/amdgpu: get rid of else branch

2017-04-27 Thread Nikola Pajkovsky
This is super simple elimination of else branch and I should probably even use unlikely in if (ring->count_dw < count_dw) { However, amdgpu_ring_write() has similar if condition, but does not return after DRM_ERROR and it looks suspicious. On error, we still adding v to ring and keeping

Re: [PATCH 2/2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy

2017-04-27 Thread Oleg Nesterov
On 04/26, Kirill Tkhai wrote: > > On 26.04.2017 18:53, Oleg Nesterov wrote: > >> > >> +static long set_last_pid_vec(struct pid_namespace *pid_ns, > >> + struct pidns_ioc_req *req) > >> +{ > >> + char *str, *p; > >> + int ret = 0; > >> + pid_t pid; > >> + > >> +

Re: [PATCH 2/2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy

2017-04-27 Thread Oleg Nesterov
On 04/26, Kirill Tkhai wrote: > > On 26.04.2017 18:53, Oleg Nesterov wrote: > >> > >> +static long set_last_pid_vec(struct pid_namespace *pid_ns, > >> + struct pidns_ioc_req *req) > >> +{ > >> + char *str, *p; > >> + int ret = 0; > >> + pid_t pid; > >> + > >> +

[PATCH] parport_serial: Add support for WCH CH382L PCI-E Single Parallel Port Card Adapter.

2017-04-27 Thread Alexander Gerasiov
PCIID: 0x1c00:0x3050. Similair to 0x3250 but without serial ports soldered on board. Signed-off-by: Alexander Gerasiov --- drivers/parport/parport_serial.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/parport/parport_serial.c

[PATCH] parport_serial: Add support for WCH CH382L PCI-E Single Parallel Port Card Adapter.

2017-04-27 Thread Alexander Gerasiov
PCIID: 0x1c00:0x3050. Similair to 0x3250 but without serial ports soldered on board. Signed-off-by: Alexander Gerasiov --- drivers/parport/parport_serial.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/parport/parport_serial.c b/drivers/parport/parport_serial.c index

Re: [PATCH v5 1/4] printk/nmi: generic solution for safe printk in NMI

2017-04-27 Thread Steven Rostedt
On Thu, 20 Apr 2017 15:11:54 +0200 Petr Mladek wrote: > > >From c530d9dee91c74db5e6a198479e2e63b24cb84a2 Mon Sep 17 00:00:00 2001 > From: Petr Mladek > Date: Thu, 20 Apr 2017 10:52:31 +0200 > Subject: [PATCH] printk: Use the main logbuf in NMI when

Re: [PATCH v5 1/4] printk/nmi: generic solution for safe printk in NMI

2017-04-27 Thread Steven Rostedt
On Thu, 20 Apr 2017 15:11:54 +0200 Petr Mladek wrote: > > >From c530d9dee91c74db5e6a198479e2e63b24cb84a2 Mon Sep 17 00:00:00 2001 > From: Petr Mladek > Date: Thu, 20 Apr 2017 10:52:31 +0200 > Subject: [PATCH] printk: Use the main logbuf in NMI when logbuf_lock is > available I tried this

Re: [PATCH] mm, zone_device: replace {get, put}_zone_device_page() with a single reference

2017-04-27 Thread Dan Williams
On Thu, Apr 27, 2017 at 9:11 AM, Logan Gunthorpe wrote: > > > On 26/04/17 06:55 PM, Dan Williams wrote: >> @@ -277,7 +269,10 @@ struct dev_pagemap *find_dev_pagemap(resource_size_t >> phys) >> * >> * Notes: >> * 1/ @ref must be 'live' on entry and 'dead' before

Re: [PATCH] mm, zone_device: replace {get, put}_zone_device_page() with a single reference

2017-04-27 Thread Dan Williams
On Thu, Apr 27, 2017 at 9:11 AM, Logan Gunthorpe wrote: > > > On 26/04/17 06:55 PM, Dan Williams wrote: >> @@ -277,7 +269,10 @@ struct dev_pagemap *find_dev_pagemap(resource_size_t >> phys) >> * >> * Notes: >> * 1/ @ref must be 'live' on entry and 'dead' before devm_memunmap_pages() >>

Re: [PATCH v3] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy

2017-04-27 Thread Eric W. Biederman
Kirill Tkhai writes: > On 27.04.2017 18:15, Eric W. Biederman wrote: >> Kirill Tkhai writes: >> >>> On implementing of nested pid namespaces support in CRIU >>> (checkpoint-restore in userspace tool) we run into >>> the situation, that it's

Re: [PATCH v3] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy

2017-04-27 Thread Eric W. Biederman
Kirill Tkhai writes: > On 27.04.2017 18:15, Eric W. Biederman wrote: >> Kirill Tkhai writes: >> >>> On implementing of nested pid namespaces support in CRIU >>> (checkpoint-restore in userspace tool) we run into >>> the situation, that it's impossible to create a task with >>> specific NSpid

Re: [PATCH 2/2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy

2017-04-27 Thread Oleg Nesterov
On 04/26, Kirill Tkhai wrote: > > On 26.04.2017 18:53, Oleg Nesterov wrote: > > > >> +static long set_last_pid_vec(struct pid_namespace *pid_ns, > >> + struct pidns_ioc_req *req) > >> +{ > >> + char *str, *p; > >> + int ret = 0; > >> + pid_t pid; > >> + > >> +

Re: [PATCH 2/2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy

2017-04-27 Thread Oleg Nesterov
On 04/26, Kirill Tkhai wrote: > > On 26.04.2017 18:53, Oleg Nesterov wrote: > > > >> +static long set_last_pid_vec(struct pid_namespace *pid_ns, > >> + struct pidns_ioc_req *req) > >> +{ > >> + char *str, *p; > >> + int ret = 0; > >> + pid_t pid; > >> + > >> +

Re: [PATCH v5 09/32] x86/mm: Provide general kernel support for memory encryption

2017-04-27 Thread Borislav Petkov
On Tue, Apr 18, 2017 at 04:17:54PM -0500, Tom Lendacky wrote: > Changes to the existing page table macros will allow the SME support to > be enabled in a simple fashion with minimal changes to files that use these > macros. Since the memory encryption mask will now be part of the regular >

Re: [PATCH v5 09/32] x86/mm: Provide general kernel support for memory encryption

2017-04-27 Thread Borislav Petkov
On Tue, Apr 18, 2017 at 04:17:54PM -0500, Tom Lendacky wrote: > Changes to the existing page table macros will allow the SME support to > be enabled in a simple fashion with minimal changes to files that use these > macros. Since the memory encryption mask will now be part of the regular >

Re: [PATCH net-next] can: fix build error without CONFIG_PROC_FS

2017-04-27 Thread Oliver Hartkopp
Hello Arnd, many thanks for your patch. Btw > static void canbcm_pernet_exit(struct net *net) > { > +#ifdef CONFIG_PROC_FS >/* remove /proc/net/can-bcm directory */ >if (IS_ENABLED(CONFIG_PROC_FS)) { >if (net->can.bcmproc_dir) >

Re: [PATCH net-next] can: fix build error without CONFIG_PROC_FS

2017-04-27 Thread Oliver Hartkopp
Hello Arnd, many thanks for your patch. Btw > static void canbcm_pernet_exit(struct net *net) > { > +#ifdef CONFIG_PROC_FS >/* remove /proc/net/can-bcm directory */ >if (IS_ENABLED(CONFIG_PROC_FS)) { >if (net->can.bcmproc_dir) >

Re: [PATCH] mm, zone_device: replace {get, put}_zone_device_page() with a single reference

2017-04-27 Thread Logan Gunthorpe
On 26/04/17 06:55 PM, Dan Williams wrote: > @@ -277,7 +269,10 @@ struct dev_pagemap *find_dev_pagemap(resource_size_t > phys) > * > * Notes: > * 1/ @ref must be 'live' on entry and 'dead' before devm_memunmap_pages() > time > - *(or devm release event). > + *(or devm release

Re: [PATCH] mm, zone_device: replace {get, put}_zone_device_page() with a single reference

2017-04-27 Thread Logan Gunthorpe
On 26/04/17 06:55 PM, Dan Williams wrote: > @@ -277,7 +269,10 @@ struct dev_pagemap *find_dev_pagemap(resource_size_t > phys) > * > * Notes: > * 1/ @ref must be 'live' on entry and 'dead' before devm_memunmap_pages() > time > - *(or devm release event). > + *(or devm release

Re: [RFC PATCH] printk: Make functions of pr_ macros

2017-04-27 Thread Joe Perches
On Thu, 2017-04-27 at 17:11 +0200, Petr Mladek wrote: > On Wed 2017-03-01 21:58:54, Joe Perches wrote: > > On Thu, 2017-03-02 at 14:35 +0900, Sergey Senozhatsky wrote: > > > On (02/28/17 19:17), Joe Perches wrote: > > > > Can save the space that the KERN_ headers require. > > > > > > > > The

Re: [RFC PATCH] printk: Make functions of pr_ macros

2017-04-27 Thread Joe Perches
On Thu, 2017-04-27 at 17:11 +0200, Petr Mladek wrote: > On Wed 2017-03-01 21:58:54, Joe Perches wrote: > > On Thu, 2017-03-02 at 14:35 +0900, Sergey Senozhatsky wrote: > > > On (02/28/17 19:17), Joe Perches wrote: > > > > Can save the space that the KERN_ headers require. > > > > > > > > The

Re: [PATCH v3 1/4] x86/vm86/32: Switch to flush_tlb_mm_range() in mark_screen_rdonly()

2017-04-27 Thread Andy Lutomirski
On Wed, Apr 26, 2017 at 5:02 PM, Nadav Amit wrote: > And besides, it looks as if the code was meant to flush the entire > TLB in some cases (e.g., if pgd_none_or_clear_bad() is true). > > On 4/26/17, 4:56 PM, "Nadav Amit" wrote: > > It may be benign, but I

Re: [PATCH v3 1/4] x86/vm86/32: Switch to flush_tlb_mm_range() in mark_screen_rdonly()

2017-04-27 Thread Andy Lutomirski
On Wed, Apr 26, 2017 at 5:02 PM, Nadav Amit wrote: > And besides, it looks as if the code was meant to flush the entire > TLB in some cases (e.g., if pgd_none_or_clear_bad() is true). > > On 4/26/17, 4:56 PM, "Nadav Amit" wrote: > > It may be benign, but I don’t think that flushing the TLB

Re: [PATCH V2] x86/tboot: add an option to disable iommu force on

2017-04-27 Thread Joerg Roedel
On Thu, Apr 27, 2017 at 08:41:20AM -0700, Shaohua Li wrote: > Sorry, I wrote the wrong data. With iommu the pps is 6M pps, and without it, > we > can get around 20M pps. XDP is much faster than normal network workloads. The > test uses 64 bytes. We tried other sizes in the machine (not 8 bytes

Re: [PATCH V2] x86/tboot: add an option to disable iommu force on

2017-04-27 Thread Joerg Roedel
On Thu, Apr 27, 2017 at 08:41:20AM -0700, Shaohua Li wrote: > Sorry, I wrote the wrong data. With iommu the pps is 6M pps, and without it, > we > can get around 20M pps. XDP is much faster than normal network workloads. The > test uses 64 bytes. We tried other sizes in the machine (not 8 bytes

Re: [PATCH] checkpatch: add --typedefsfile

2017-04-27 Thread Joe Perches
On Thu, 2017-04-27 at 17:41 +0200, Jerome Forissier wrote: > On 04/21/2017 08:31 AM, Jerome Forissier wrote: > > On 04/20/2017 06:49 PM, Joe Perches wrote: > > > On Thu, 2017-04-20 at 17:39 +0200, Jerome Forissier wrote: > > > > When using checkpatch on out-of-tree code, it may occur that some > >

Re: [PATCH] checkpatch: add --typedefsfile

2017-04-27 Thread Joe Perches
On Thu, 2017-04-27 at 17:41 +0200, Jerome Forissier wrote: > On 04/21/2017 08:31 AM, Jerome Forissier wrote: > > On 04/20/2017 06:49 PM, Joe Perches wrote: > > > On Thu, 2017-04-20 at 17:39 +0200, Jerome Forissier wrote: > > > > When using checkpatch on out-of-tree code, it may occur that some > >

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

2017-04-27 Thread Logan Gunthorpe
On 27/04/17 09:27 AM, Jason Gunthorpe wrote: > On Thu, Apr 27, 2017 at 08:53:38AM +0200, Christoph Hellwig wrote: > How about first switching as many call sites as possible to use > sg_copy_X_buffer instead of kmap? Yeah, I could look at doing that first. One problem is we might get more Naks

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

2017-04-27 Thread Logan Gunthorpe
On 27/04/17 09:27 AM, Jason Gunthorpe wrote: > On Thu, Apr 27, 2017 at 08:53:38AM +0200, Christoph Hellwig wrote: > How about first switching as many call sites as possible to use > sg_copy_X_buffer instead of kmap? Yeah, I could look at doing that first. One problem is we might get more Naks

[GIT PULL] Ceph fix for 4.11-rc9

2017-04-27 Thread Ilya Dryomov
Hi Linus, The following changes since commit 5a7ad1146caa895ad718a534399e38bd2ba721b7: Linux 4.11-rc8 (2017-04-23 16:53:00 -0700) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.11-rc9 for you to fetch changes up to

[GIT PULL] Ceph fix for 4.11-rc9

2017-04-27 Thread Ilya Dryomov
Hi Linus, The following changes since commit 5a7ad1146caa895ad718a534399e38bd2ba721b7: Linux 4.11-rc8 (2017-04-23 16:53:00 -0700) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.11-rc9 for you to fetch changes up to

[RFC v3 02/17] mm: Prepare for FAULT_FLAG_SPECULATIVE

2017-04-27 Thread Laurent Dufour
From: Peter Zijlstra When speculating faults (without holding mmap_sem) we need to validate that the vma against which we loaded pages is still valid when we're ready to install the new PTE. Therefore, replace the pte_offset_map_lock() calls that (re)take the PTL with

[RFC v3 02/17] mm: Prepare for FAULT_FLAG_SPECULATIVE

2017-04-27 Thread Laurent Dufour
From: Peter Zijlstra When speculating faults (without holding mmap_sem) we need to validate that the vma against which we loaded pages is still valid when we're ready to install the new PTE. Therefore, replace the pte_offset_map_lock() calls that (re)take the PTL with pte_map_lock() which can

[RFC v3 03/17] mm: Introduce pte_spinlock

2017-04-27 Thread Laurent Dufour
This is needed because in handle_pte_fault() pte_offset_map() is called and then fe->ptl is fetched and spin_locked. This was previously embedded in the call to pte_offset_map_lock(). Signed-off-by: Laurent Dufour --- mm/memory.c | 15 +++ 1 file

[RFC v3 03/17] mm: Introduce pte_spinlock

2017-04-27 Thread Laurent Dufour
This is needed because in handle_pte_fault() pte_offset_map() is called and then fe->ptl is fetched and spin_locked. This was previously embedded in the call to pte_offset_map_lock(). Signed-off-by: Laurent Dufour --- mm/memory.c | 15 +++ 1 file changed, 11 insertions(+), 4

[RFC v3 09/17] mm/spf: Fix fe.sequence init in __handle_mm_fault()

2017-04-27 Thread Laurent Dufour
__handle_mm_fault() calls handle_pte_fault which requires the sequence field of the fault_env to be initialized. Signed-off-by: Laurent Dufour --- mm/memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memory.c b/mm/memory.c index

[RFC v3 09/17] mm/spf: Fix fe.sequence init in __handle_mm_fault()

2017-04-27 Thread Laurent Dufour
__handle_mm_fault() calls handle_pte_fault which requires the sequence field of the fault_env to be initialized. Signed-off-by: Laurent Dufour --- mm/memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memory.c b/mm/memory.c index 458f579feb6f..f8afd52f0d34 100644 --- a/mm/memory.c

[RFC v3 04/17] mm: VMA sequence count

2017-04-27 Thread Laurent Dufour
From: Peter Zijlstra Wrap the VMA modifications (vma_adjust/unmap_page_range) with sequence counts such that we can easily test if a VMA is changed. The unmap_page_range() one allows us to make assumptions about page-tables; when we find the seqcount hasn't changed we can

[RFC v3 08/17] mm/spf: Try spin lock in speculative path

2017-04-27 Thread Laurent Dufour
There is a deadlock when a CPU is doing a speculative page fault and another one is calling do_unmap(). The deadlock occurred because the speculative path try to spinlock the pte while the interrupt are disabled. When the other CPU in the unmap's path has locked the pte then is waiting for all

[RFC v3 10/17] mm/spf: don't set fault entry's fields if locking failed

2017-04-27 Thread Laurent Dufour
In the case pte_map_lock failed to lock the pte or if the VMA is no more valid, the fault entry's fields should not be set so that caller won't try to unlock it. Signed-off-by: Laurent Dufour --- mm/memory.c | 14 +- 1 file changed, 9 insertions(+), 5

[RFC v3 04/17] mm: VMA sequence count

2017-04-27 Thread Laurent Dufour
From: Peter Zijlstra Wrap the VMA modifications (vma_adjust/unmap_page_range) with sequence counts such that we can easily test if a VMA is changed. The unmap_page_range() one allows us to make assumptions about page-tables; when we find the seqcount hasn't changed we can assume page-tables are

[RFC v3 08/17] mm/spf: Try spin lock in speculative path

2017-04-27 Thread Laurent Dufour
There is a deadlock when a CPU is doing a speculative page fault and another one is calling do_unmap(). The deadlock occurred because the speculative path try to spinlock the pte while the interrupt are disabled. When the other CPU in the unmap's path has locked the pte then is waiting for all

[RFC v3 10/17] mm/spf: don't set fault entry's fields if locking failed

2017-04-27 Thread Laurent Dufour
In the case pte_map_lock failed to lock the pte or if the VMA is no more valid, the fault entry's fields should not be set so that caller won't try to unlock it. Signed-off-by: Laurent Dufour --- mm/memory.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[RFC v3 07/17] mm,x86: Add speculative pagefault handling

2017-04-27 Thread Laurent Dufour
From: Peter Zijlstra Try a speculative fault before acquiring mmap_sem, if it returns with VM_FAULT_RETRY continue with the mmap_sem acquisition and do the traditional fault. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/mm/fault.c | 18

[RFC v3 07/17] mm,x86: Add speculative pagefault handling

2017-04-27 Thread Laurent Dufour
From: Peter Zijlstra Try a speculative fault before acquiring mmap_sem, if it returns with VM_FAULT_RETRY continue with the mmap_sem acquisition and do the traditional fault. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/mm/fault.c | 18 ++ 1 file changed, 18

Re: [PATCH v6 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow

2017-04-27 Thread David Miller
From: "Jason A. Donenfeld" Date: Thu, 27 Apr 2017 11:21:51 +0200 > Hey Dave, > > David Laight and I have been discussing offlist. It occurred to both > of us that this could just be turned into a loop because perhaps this > is actually just tail-recursive. Upon further

Re: [PATCH v6 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow

2017-04-27 Thread David Miller
From: "Jason A. Donenfeld" Date: Thu, 27 Apr 2017 11:21:51 +0200 > Hey Dave, > > David Laight and I have been discussing offlist. It occurred to both > of us that this could just be turned into a loop because perhaps this > is actually just tail-recursive. Upon further inspection, however, the

[RFC v3 16/17] mm: protect madvise vs speculative pf

2017-04-27 Thread Laurent Dufour
This is an attempt to protect madvise's effect against the speculative page fault handler. Signed-off-by: Laurent Dufour --- mm/madvise.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/madvise.c b/mm/madvise.c index

[RFC v3 16/17] mm: protect madvise vs speculative pf

2017-04-27 Thread Laurent Dufour
This is an attempt to protect madvise's effect against the speculative page fault handler. Signed-off-by: Laurent Dufour --- mm/madvise.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/madvise.c b/mm/madvise.c index 0e3828eae9f8..f91b64564571 100644 ---

[RFC v3 01/17] mm: Dont assume page-table invariance during faults

2017-04-27 Thread Laurent Dufour
From: Peter Zijlstra One of the side effects of speculating on faults (without holding mmap_sem) is that we can race with free_pgtables() and therefore we cannot assume the page-tables will stick around. Remove the relyance on the pte pointer. Signed-off-by: Peter

[RFC v3 01/17] mm: Dont assume page-table invariance during faults

2017-04-27 Thread Laurent Dufour
From: Peter Zijlstra One of the side effects of speculating on faults (without holding mmap_sem) is that we can race with free_pgtables() and therefore we cannot assume the page-tables will stick around. Remove the relyance on the pte pointer. Signed-off-by: Peter Zijlstra (Intel) ---

<    2   3   4   5   6   7   8   9   10   11   >