On Tue, 2017-05-02 at 11:38 +0800, lixi...@cmss.chinamobile.com wrote:
> From: Xiubo Li
>
> Changed for V7:
> - #1 fix two issues.
> - #2 fix kbuild warning and some issues.
>
> Changed for V6:
> - Remove the tcmu_vma_close(). Since the unmap thread will do the
On Tue, 2017-05-02 at 11:38 +0800, lixi...@cmss.chinamobile.com wrote:
> From: Xiubo Li
>
> Changed for V7:
> - #1 fix two issues.
> - #2 fix kbuild warning and some issues.
>
> Changed for V6:
> - Remove the tcmu_vma_close(). Since the unmap thread will do the same for it
> - The unmap thread
Around Mon 27 Mar 2017 15:35:56 +0200 or thereabout, Hans-Christian Noren
Egtvedt wrote:
> Around Mon 27 Mar 2017 15:26:04 +0200 or thereabout, Boris Brezillon wrote:
>> On Wed, 1 Mar 2017 21:44:26 +0100 Hans-Christian Noren Egtvedt
>> wrote:
>> Is this still planned
Around Mon 27 Mar 2017 15:35:56 +0200 or thereabout, Hans-Christian Noren
Egtvedt wrote:
> Around Mon 27 Mar 2017 15:26:04 +0200 or thereabout, Boris Brezillon wrote:
>> On Wed, 1 Mar 2017 21:44:26 +0100 Hans-Christian Noren Egtvedt
>> wrote:
>> Is this still planned for 4.12?
>
> Yes, I
On Fri, Apr 28, 2017 at 9:26 AM, Paul Moore wrote:
> On Fri, Apr 28, 2017 at 12:11 PM, Cong Wang wrote:
>> On Fri, Apr 28, 2017 at 8:30 AM, Paul Moore wrote:
>>> On Thu, Apr 27, 2017 at 8:47 PM, Paul Moore
On Fri, Apr 28, 2017 at 9:26 AM, Paul Moore wrote:
> On Fri, Apr 28, 2017 at 12:11 PM, Cong Wang wrote:
>> On Fri, Apr 28, 2017 at 8:30 AM, Paul Moore wrote:
>>> On Thu, Apr 27, 2017 at 8:47 PM, Paul Moore wrote:
In that case please send a proper inline patch to the audit mailing list
On 05/02/2017 10:34 AM, Guenter Roeck wrote:
> On 05/01/2017 09:35 PM, Shilpasri G Bhat wrote:
>> Hi Guenter,
>>
>> On 04/28/2017 06:59 PM, Guenter Roeck wrote:
>>> On 04/27/2017 10:59 PM, Shilpasri G Bhat wrote:
Add support for adding min/max values for the inband sensors copied by
On 05/02/2017 10:34 AM, Guenter Roeck wrote:
> On 05/01/2017 09:35 PM, Shilpasri G Bhat wrote:
>> Hi Guenter,
>>
>> On 04/28/2017 06:59 PM, Guenter Roeck wrote:
>>> On 04/27/2017 10:59 PM, Shilpasri G Bhat wrote:
Add support for adding min/max values for the inband sensors copied by
Hi Huang,
On Tue, May 02, 2017 at 01:35:24PM +0800, Huang, Ying wrote:
> Hi, Minchan,
>
> Minchan Kim writes:
>
> > On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote:
> >> In fact, during the test, I found the overhead of sort() is comparable
> >> with the
Hi Huang,
On Tue, May 02, 2017 at 01:35:24PM +0800, Huang, Ying wrote:
> Hi, Minchan,
>
> Minchan Kim writes:
>
> > On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote:
> >> In fact, during the test, I found the overhead of sort() is comparable
> >> with the performance difference of
Le 01/05/2017 à 23:46, Brian Norris a écrit :
On Fri, Feb 10, 2017 at 03:01:10PM +0100, Christophe Leroy wrote:
On some hardware, the nCE signal is wired to the ChipSelect associated
to bus address of the NAND, so it is automatically driven during the
memory access and it is not managed by a
Le 01/05/2017 à 23:46, Brian Norris a écrit :
On Fri, Feb 10, 2017 at 03:01:10PM +0100, Christophe Leroy wrote:
On some hardware, the nCE signal is wired to the ChipSelect associated
to bus address of the NAND, so it is automatically driven during the
memory access and it is not managed by a
The adt7475 has had find_nearest() since it's creation in 2009. Since
then find_closest() has been introduced and several drivers have been
updated to use it. Update the adt7475 to use find_closest() and remove
the now unused find_nearest().
Signed-off-by: Chris Packham
The adt7475 has had find_nearest() since it's creation in 2009. Since
then find_closest() has been introduced and several drivers have been
updated to use it. Update the adt7475 to use find_closest() and remove
the now unused find_nearest().
Signed-off-by: Chris Packham
---
By default adt7475 will stop the fans (pwm duty cycle 0%) when the
temperature drops past Tmin - hysteresis. Some systems want to keep the
fans moving even when the temperature drops so add new sysfs attributes
that configure the enhanced acoustics min 1-3 which allows the fans to
run at the
When enabled temperature smoothing allows ramping the fan speed over a
configurable period of time instead of jumping to the new speed
instantaneously.
Signed-off-by: Chris Packham
---
Documentation/hwmon/adt7475 | 5 ++
drivers/hwmon/adt7475.c | 121
By default adt7475 will stop the fans (pwm duty cycle 0%) when the
temperature drops past Tmin - hysteresis. Some systems want to keep the
fans moving even when the temperature drops so add new sysfs attributes
that configure the enhanced acoustics min 1-3 which allows the fans to
run at the
When enabled temperature smoothing allows ramping the fan speed over a
configurable period of time instead of jumping to the new speed
instantaneously.
Signed-off-by: Chris Packham
---
Documentation/hwmon/adt7475 | 5 ++
drivers/hwmon/adt7475.c | 121
Hi Dan,
Today's linux-next merge of the nvdimm tree got a conflict in:
drivers/nvdimm/pmem.c
between commit:
71389703839e ("mm, zone_device: Replace {get, put}_zone_device_page() with a
single reference to fix pmem crash")
from the tip tree and commit:
c1d6e828a35d ("pmem: add
Hi Dan,
Today's linux-next merge of the nvdimm tree got a conflict in:
drivers/nvdimm/pmem.c
between commit:
71389703839e ("mm, zone_device: Replace {get, put}_zone_device_page() with a
single reference to fix pmem crash")
from the tip tree and commit:
c1d6e828a35d ("pmem: add
Hi, Minchan,
Minchan Kim writes:
> On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote:
>> In fact, during the test, I found the overhead of sort() is comparable
>> with the performance difference of adding likely()/unlikely() to the
>> "if" in the function.
>
>
Hi, Minchan,
Minchan Kim writes:
> On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote:
>> In fact, during the test, I found the overhead of sort() is comparable
>> with the performance difference of adding likely()/unlikely() to the
>> "if" in the function.
>
> Huang,
>
> This
> On Apr 10, 2017, at 3:46 PM, Christopher Bostic
> wrote:
>
> From: Jeremy Kerr
>
> This change introduces the fsi device API: simple read, write and peek
> accessors for the devices' address spaces.
>
> Includes contributions from Chris Bostic
On Thu, Apr 27, 2017 at 04:46:22PM +0900, Sergey Senozhatsky wrote:
> Hello,
>
> On (04/27/17 15:57), Joonsoo Kim wrote:
> [..]
> > I tested with your benchmark and found that contention happens
> > since the data page is perfectly the same. All the written data (2GB)
> > is de-duplicated.
>
>
> On Apr 10, 2017, at 3:46 PM, Christopher Bostic
> wrote:
>
> From: Jeremy Kerr
>
> This change introduces the fsi device API: simple read, write and peek
> accessors for the devices' address spaces.
>
> Includes contributions from Chris Bostic
> and Edward A. James .
>
> Signed-off-by:
On Thu, Apr 27, 2017 at 04:46:22PM +0900, Sergey Senozhatsky wrote:
> Hello,
>
> On (04/27/17 15:57), Joonsoo Kim wrote:
> [..]
> > I tested with your benchmark and found that contention happens
> > since the data page is perfectly the same. All the written data (2GB)
> > is de-duplicated.
>
>
On 04/28/2017 10:53 AM, Amir Goldstein wrote:
On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote:
Am 24.04.2017 um 17:47 schrieb Richard Weinberger:
So, if some flag should be implemented, who should do it? :)
I'll not do it for you. ;)
Please also see
On 04/28/2017 10:53 AM, Amir Goldstein wrote:
On Fri, Apr 28, 2017 at 1:03 AM, Richard Weinberger wrote:
Am 24.04.2017 um 17:47 schrieb Richard Weinberger:
So, if some flag should be implemented, who should do it? :)
I'll not do it for you. ;)
Please also see
On Mon, 2017-05-01 at 13:40 -0500, Mike Christie wrote:
> On 04/30/2017 06:29 AM, Xiubo Li wrote:
> > [...]
> >> To avoid starvation, I think you want a second list/fifo that holds the
> >> watiers. In tcmu_get_empty_block if the list is not empty, record how
> >> many pages we needed and then
On Mon, 2017-05-01 at 13:40 -0500, Mike Christie wrote:
> On 04/30/2017 06:29 AM, Xiubo Li wrote:
> > [...]
> >> To avoid starvation, I think you want a second list/fifo that holds the
> >> watiers. In tcmu_get_empty_block if the list is not empty, record how
> >> many pages we needed and then
Hi Xiubo & Co,
On Wed, 2017-04-26 at 14:25 +0800, lixi...@cmss.chinamobile.com wrote:
> From: Xiubo Li
>
> Changed for V6:
> - Remove the tcmu_vma_close(). Since the unmap thread will do the same for it
> - The unmap thread will skip the busy devices.
> - Using
Hi Xiubo & Co,
On Wed, 2017-04-26 at 14:25 +0800, lixi...@cmss.chinamobile.com wrote:
> From: Xiubo Li
>
> Changed for V6:
> - Remove the tcmu_vma_close(). Since the unmap thread will do the same for it
> - The unmap thread will skip the busy devices.
> - Using and testing the V5 version 3
Oops, forgot to add lkml and linux-mm.
Sorry for that.
Send it again.
>From 8ddf1c8aa15baf085bc6e8c62ce705459d57ea4c Mon Sep 17 00:00:00 2001
From: Minchan Kim
Date: Tue, 2 May 2017 12:34:05 +0900
Subject: [PATCH] vmscan: scan pages until it founds eligible pages
On Tue, May
Oops, forgot to add lkml and linux-mm.
Sorry for that.
Send it again.
>From 8ddf1c8aa15baf085bc6e8c62ce705459d57ea4c Mon Sep 17 00:00:00 2001
From: Minchan Kim
Date: Tue, 2 May 2017 12:34:05 +0900
Subject: [PATCH] vmscan: scan pages until it founds eligible pages
On Tue, May 02, 2017 at
On 05/01/2017 09:35 PM, Shilpasri G Bhat wrote:
Hi Guenter,
On 04/28/2017 06:59 PM, Guenter Roeck wrote:
On 04/27/2017 10:59 PM, Shilpasri G Bhat wrote:
Add support for adding min/max values for the inband sensors copied by
OCC to main memory. And also add current(mA) sensors to the list.
On 05/01/2017 09:35 PM, Shilpasri G Bhat wrote:
Hi Guenter,
On 04/28/2017 06:59 PM, Guenter Roeck wrote:
On 04/27/2017 10:59 PM, Shilpasri G Bhat wrote:
Add support for adding min/max values for the inband sensors copied by
OCC to main memory. And also add current(mA) sensors to the list.
On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote:
> In fact, during the test, I found the overhead of sort() is comparable
> with the performance difference of adding likely()/unlikely() to the
> "if" in the function.
Huang,
This discussion is started from your optimization code:
On Fri, Apr 28, 2017 at 09:35:37PM +0800, Huang, Ying wrote:
> In fact, during the test, I found the overhead of sort() is comparable
> with the performance difference of adding likely()/unlikely() to the
> "if" in the function.
Huang,
This discussion is started from your optimization code:
On Monday 01 May 2017 10:50 AM, Keerthy wrote:
>
>
> On Thursday 27 April 2017 09:50 PM, Eduardo Valentin wrote:
>> On Wed, Apr 26, 2017 at 05:33:10PM +0200, SF Markus Elfring wrote:
>>> From: Markus Elfring
>>> Date: Wed, 26 Apr 2017 17:24:56 +0200
>>>
>>>
On Monday 01 May 2017 10:50 AM, Keerthy wrote:
>
>
> On Thursday 27 April 2017 09:50 PM, Eduardo Valentin wrote:
>> On Wed, Apr 26, 2017 at 05:33:10PM +0200, SF Markus Elfring wrote:
>>> From: Markus Elfring
>>> Date: Wed, 26 Apr 2017 17:24:56 +0200
>>>
>>> Three update suggestions were taken
Hi Guenter,
On 04/28/2017 06:59 PM, Guenter Roeck wrote:
> On 04/27/2017 10:59 PM, Shilpasri G Bhat wrote:
>> Add support for adding min/max values for the inband sensors copied by
>> OCC to main memory. And also add current(mA) sensors to the list.
>>
>> Signed-off-by: Shilpasri G Bhat
Hi Guenter,
On 04/28/2017 06:59 PM, Guenter Roeck wrote:
> On 04/27/2017 10:59 PM, Shilpasri G Bhat wrote:
>> Add support for adding min/max values for the inband sensors copied by
>> OCC to main memory. And also add current(mA) sensors to the list.
>>
>> Signed-off-by: Shilpasri G Bhat
>> ---
Howdy,
Well, sadly, the problem is more or less back is 4.11.0. The system doesn't
really
crash but it goes into an infinite loop with
[34776.826800] BUG: workqueue lockup - pool cpus=6 node=0 flags=0x0 nice=0
stuck for 33s!
More logs: https://pastebin.com/YqE4riw0
(I upgraded from 4.8 with
Howdy,
Well, sadly, the problem is more or less back is 4.11.0. The system doesn't
really
crash but it goes into an infinite loop with
[34776.826800] BUG: workqueue lockup - pool cpus=6 node=0 flags=0x0 nice=0
stuck for 33s!
More logs: https://pastebin.com/YqE4riw0
(I upgraded from 4.8 with
On Mon, May 1, 2017 at 5:40 PM, Greg KH wrote:
> On Mon, May 01, 2017 at 04:19:48PM +0530, Adheer Chandravanshi wrote:
>> Fix style issues as reported by checkpatch.pl
>
> That's really vague, you need to be specific, and only fix one type of
> thing per patch.
>
>
On Mon, May 1, 2017 at 5:40 PM, Greg KH wrote:
> On Mon, May 01, 2017 at 04:19:48PM +0530, Adheer Chandravanshi wrote:
>> Fix style issues as reported by checkpatch.pl
>
> That's really vague, you need to be specific, and only fix one type of
> thing per patch.
>
> thanks,
>
> greg k-h
Thanks
On Mon, May 01, 2017 at 09:11:05PM -0700, Linus Torvalds wrote:
> On Mon, May 1, 2017 at 9:02 PM, Paul E. McKenney
> wrote:
> >
> > I will get rid of the unused rcu_segcblist_extract_all() function
> > and create a kernel/rcu/segcblist.c for the functions that are
On Mon, May 01, 2017 at 09:11:05PM -0700, Linus Torvalds wrote:
> On Mon, May 1, 2017 at 9:02 PM, Paul E. McKenney
> wrote:
> >
> > I will get rid of the unused rcu_segcblist_extract_all() function
> > and create a kernel/rcu/segcblist.c for the functions that are either
> > non-trivial or
Hello Rui,
Please pull the following changes to get the Thermal SoC updates
for 4.12-rc1. Here we have:
- Removal of non-DT booting on TI-SoC driver. Also, support to
fetching coefficients from DT.
- Refactoring of RCAR Gen3.
- New driver: support for BCM 2835.
- New driver: support for Broadcom
Hello Rui,
Please pull the following changes to get the Thermal SoC updates
for 4.12-rc1. Here we have:
- Removal of non-DT booting on TI-SoC driver. Also, support to
fetching coefficients from DT.
- Refactoring of RCAR Gen3.
- New driver: support for BCM 2835.
- New driver: support for Broadcom
On Mon, May 1, 2017 at 9:02 PM, Paul E. McKenney
wrote:
>
> I will get rid of the unused rcu_segcblist_extract_all() function
> and create a kernel/rcu/segcblist.c for the functions that are either
> non-trivial or performance-insensitive.
>
> Does that cover it, or am
On Mon, May 1, 2017 at 9:02 PM, Paul E. McKenney
wrote:
>
> I will get rid of the unused rcu_segcblist_extract_all() function
> and create a kernel/rcu/segcblist.c for the functions that are either
> non-trivial or performance-insensitive.
>
> Does that cover it, or am I missing something?
Hi all,
Today's linux-next merge of the drivers-x86 tree got a conflict in:
drivers/watchdog/iTCO_wdt.c
between commit:
38a700fa1df9 ("watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions")
(which also appears in the drivers-x86 tree as commit f583a884afec)
from the watchdog tree
Hi all,
Today's linux-next merge of the drivers-x86 tree got a conflict in:
drivers/watchdog/iTCO_wdt.c
between commit:
38a700fa1df9 ("watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions")
(which also appears in the drivers-x86 tree as commit f583a884afec)
from the watchdog tree
Add null check before dereferencing dev->regs pointer inside
net2280_led_shutdown() function.
Addresses-Coverity-ID: 101783
Signed-off-by: Gustavo A. R. Silva
---
drivers/usb/gadget/udc/net2280.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
Add null check before dereferencing dev->regs pointer inside
net2280_led_shutdown() function.
Addresses-Coverity-ID: 101783
Signed-off-by: Gustavo A. R. Silva
---
drivers/usb/gadget/udc/net2280.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
On Thu, Apr 27, 2017 at 05:06:36PM +0200, Michal Hocko wrote:
> On Tue 25-04-17 12:42:57, Joonsoo Kim wrote:
> > On Mon, Apr 24, 2017 at 03:09:36PM +0200, Michal Hocko wrote:
> > > On Mon 17-04-17 11:02:12, Joonsoo Kim wrote:
> > > > On Thu, Apr 13, 2017 at 01:56:15PM +0200, Michal Hocko wrote:
>
On Thu, Apr 27, 2017 at 05:06:36PM +0200, Michal Hocko wrote:
> On Tue 25-04-17 12:42:57, Joonsoo Kim wrote:
> > On Mon, Apr 24, 2017 at 03:09:36PM +0200, Michal Hocko wrote:
> > > On Mon 17-04-17 11:02:12, Joonsoo Kim wrote:
> > > > On Thu, Apr 13, 2017 at 01:56:15PM +0200, Michal Hocko wrote:
>
On Mon, May 01, 2017 at 06:19:44PM -0700, Linus Torvalds wrote:
> On Mon, May 1, 2017 at 2:59 AM, Ingo Molnar wrote:
> > Linus,
> >
> > Please pull the latest core-rcu-for-linus git tree from:
> >
> >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> >
On Mon, May 01, 2017 at 06:19:44PM -0700, Linus Torvalds wrote:
> On Mon, May 1, 2017 at 2:59 AM, Ingo Molnar wrote:
> > Linus,
> >
> > Please pull the latest core-rcu-for-linus git tree from:
> >
> >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> > core-rcu-for-linus
>
> I
On Wednesday 26 April 2017 09:04 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 26 Apr 2017 16:45:25 +0200
>
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
>
On Wednesday 26 April 2017 09:04 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 26 Apr 2017 16:45:25 +0200
>
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding
On Wednesday 26 April 2017 09:07 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 26 Apr 2017 17:03:07 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: Possible unnecessary 'out of memory' message
>
>
On Wednesday 26 April 2017 09:07 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 26 Apr 2017 17:03:07 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: Possible unnecessary 'out of memory' message
>
> Thus remove such statements
On Wednesday 26 April 2017 09:09 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 26 Apr 2017 17:11:28 +0200
>
> Add a missing character in this description for a function.
Reviewed-by: Keerthy
>
> Signed-off-by: Markus
On Wednesday 26 April 2017 09:09 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 26 Apr 2017 17:11:28 +0200
>
> Add a missing character in this description for a function.
Reviewed-by: Keerthy
>
> Signed-off-by: Markus Elfring
> ---
>
Since commit 23688bf4f830 ("block: ensure to split after potentially
bouncing a bio") blk_queue_bounce() is called *before*
blk_queue_split().
This means that:
1/ the comments blk_queue_split() about bounce buffers are
irrelevant, and
2/ a very large bio (more than BIO_MAX_PAGES) will no
Since commit 23688bf4f830 ("block: ensure to split after potentially
bouncing a bio") blk_queue_bounce() is called *before*
blk_queue_split().
This means that:
1/ the comments blk_queue_split() about bounce buffers are
irrelevant, and
2/ a very large bio (more than BIO_MAX_PAGES) will no
This function allocates a bio, then a collection
of pages. It copes with failure.
It currently uses a mempool() to allocate the bio,
but alloc_page() to allocate the pages. These fail
in different ways, so the usage is inconsistent.
Change the bio_clone() to bio_clone_kmalloc()
so that no pool
This function allocates a bio, then a collection
of pages. It copes with failure.
It currently uses a mempool() to allocate the bio,
but alloc_page() to allocate the pages. These fail
in different ways, so the usage is inconsistent.
Change the bio_clone() to bio_clone_kmalloc()
so that no pool
bio_clone() is no longer used.
Only bio_clone_bioset() or bio_clone_fast().
This is for the best, as bio_clone() used fs_bio_set,
and filesystems are unlikely to want to use bio_clone().
So remove bio_clone() and all references.
This includes a fix to some incorrect documentation.
Reviewed-by:
bio_clone() is no longer used.
Only bio_clone_bioset() or bio_clone_fast().
This is for the best, as bio_clone() used fs_bio_set,
and filesystems are unlikely to want to use bio_clone().
So remove bio_clone() and all references.
This includes a fix to some incorrect documentation.
Reviewed-by:
blk_bio_segment_split() makes sure bios have no more than
BIO_MAX_PAGES entries in the bi_io_vec.
This was done because bio_clone_bioset() (when given a
mempool bioset) could not handle larger io_vecs.
No driver uses bio_clone_bioset() any more, they all
use bio_clone_fast() if anything, and
blk_bio_segment_split() makes sure bios have no more than
BIO_MAX_PAGES entries in the bi_io_vec.
This was done because bio_clone_bioset() (when given a
mempool bioset) could not handle larger io_vecs.
No driver uses bio_clone_bioset() any more, they all
use bio_clone_fast() if anything, and
This patch converts bioset_create() and
bioset_create_nobvec() to not create a workqueue so
alloctions will never trigger punt_bios_to_rescuer(). It
also introduces bioset_create_rescued() and
bioset_create_nobvec_rescued() which preserve the old
behaviour.
All callers of bioset_create() and
This patch converts bioset_create() and
bioset_create_nobvec() to not create a workqueue so
alloctions will never trigger punt_bios_to_rescuer(). It
also introduces bioset_create_rescued() and
bioset_create_nobvec_rescued() which preserve the old
behaviour.
All callers of bioset_create() and
bios that are re-submitted will pass through blk_queue_split() when
blk_queue_bio() is called, and this will split the bio if necessary.
There is no longer any need to do this splitting in xen-blkfront.
Acked-by: Roger Pau Monné
Signed-off-by: NeilBrown
---
bio_clone() makes a copy of the bi_io_vec, but rbd never changes that,
so there is no need for a copy.
bio_clone_fast() can be used instead, which avoids making the copy.
This requires that we provide a bio_set. bio_clone() uses fs_bio_set,
but it isn't, in general, safe to use the same bio_set
A rescuing bioset is only useful if there might be bios from
that same bioset on the bio_list_on_stack queue at a time
when bio_alloc_bioset() is called. This never applies to
q->bio_split.
Allocations from q->bio_split are only ever made from
blk_queue_split() which is only ever called early in
"flags" arguments are often seen as good API design as they allow
easy extensibility.
bioset_create_nobvec() is implemented internally as a variation in
flags passed to __bioset_create().
To support future extension, make the internal structure part of the
API.
i.e. add a 'flags' argument to
bios that are re-submitted will pass through blk_queue_split() when
blk_queue_bio() is called, and this will split the bio if necessary.
There is no longer any need to do this splitting in xen-blkfront.
Acked-by: Roger Pau Monné
Signed-off-by: NeilBrown
---
drivers/block/xen-blkfront.c | 54
bio_clone() makes a copy of the bi_io_vec, but rbd never changes that,
so there is no need for a copy.
bio_clone_fast() can be used instead, which avoids making the copy.
This requires that we provide a bio_set. bio_clone() uses fs_bio_set,
but it isn't, in general, safe to use the same bio_set
A rescuing bioset is only useful if there might be bios from
that same bioset on the bio_list_on_stack queue at a time
when bio_alloc_bioset() is called. This never applies to
q->bio_split.
Allocations from q->bio_split are only ever made from
blk_queue_split() which is only ever called early in
"flags" arguments are often seen as good API design as they allow
easy extensibility.
bioset_create_nobvec() is implemented internally as a variation in
flags passed to __bioset_create().
To support future extension, make the internal structure part of the
API.
i.e. add a 'flags' argument to
drbd does not modify the bi_io_vec of the cloned bio,
so there is no need to clone that part. So bio_clone_fast()
is the better choice.
For bio_clone_fast() we need to specify a bio_set.
We could use fs_bio_set, which bio_clone() uses, or
drbd_md_io_bio_set, which drbd uses for metadata, but it
pktcdvd doesn't change the bi_io_vec of the clone bio,
so it is more efficient to use bio_clone_fast(), and not clone
the bi_io_vec.
This requires providing a bio_set, and it is safest to
provide a dedicated bio_set rather than sharing
fs_bio_set, which filesytems use.
This new bio_set,
pblk_submit_read() uses bio_clone_bioset() but doesn't change the
io_vec, so bio_clone_fast() is a better choice.
It also uses fs_bio_set which is intended for filesystems. Using it
in a device driver can deadlock.
So allocate a new bioset, and and use bio_clone_fast().
Signed-off-by: NeilBrown
drbd does not modify the bi_io_vec of the cloned bio,
so there is no need to clone that part. So bio_clone_fast()
is the better choice.
For bio_clone_fast() we need to specify a bio_set.
We could use fs_bio_set, which bio_clone() uses, or
drbd_md_io_bio_set, which drbd uses for metadata, but it
pktcdvd doesn't change the bi_io_vec of the clone bio,
so it is more efficient to use bio_clone_fast(), and not clone
the bi_io_vec.
This requires providing a bio_set, and it is safest to
provide a dedicated bio_set rather than sharing
fs_bio_set, which filesytems use.
This new bio_set,
pblk_submit_read() uses bio_clone_bioset() but doesn't change the
io_vec, so bio_clone_fast() is a better choice.
It also uses fs_bio_set which is intended for filesystems. Using it
in a device driver can deadlock.
So allocate a new bioset, and and use bio_clone_fast().
Signed-off-by: NeilBrown
This is a revision of my series of patches working
towards removing the bioset work queues.
This set is based on Linus' tree as for today (2nd May) plus
the for-linus branch from Shaohua's md/raid tree.
This series adds a fix for the new lightnvm/pblk-read code
and discards
blk_queue_split() is always called with the last arg being q->bio_split,
where 'q' is the first arg.
Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses
q->bio_split.
This is inconsistent and unnecessary. Remove the last arg and always use
q->bio_split inside
This is a revision of my series of patches working
towards removing the bioset work queues.
This set is based on Linus' tree as for today (2nd May) plus
the for-linus branch from Shaohua's md/raid tree.
This series adds a fix for the new lightnvm/pblk-read code
and discards
blk_queue_split() is always called with the last arg being q->bio_split,
where 'q' is the first arg.
Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses
q->bio_split.
This is inconsistent and unnecessary. Remove the last arg and always use
q->bio_split inside
On Tuesday 18 April 2017 11:48 AM, Keerthy wrote:
>
>
> On Tuesday 18 April 2017 11:45 AM, Ravikumar wrote:
>>
>>
>> On Tuesday 18 April 2017 09:59 AM, Keerthy wrote:
>>> orderly_poweroff is triggered when a graceful shutdown
>>> of system is desired. This may be used in many critical states
On Tuesday 18 April 2017 11:48 AM, Keerthy wrote:
>
>
> On Tuesday 18 April 2017 11:45 AM, Ravikumar wrote:
>>
>>
>> On Tuesday 18 April 2017 09:59 AM, Keerthy wrote:
>>> orderly_poweroff is triggered when a graceful shutdown
>>> of system is desired. This may be used in many critical states
On Tuesday 18 April 2017 09:59 AM, Keerthy wrote:
> thermal_zone_device_check --> thermal_zone_device_update -->
> handle_thermal_trip --> handle_critical_trips --> orderly_poweroff
>
> The above sequence happens every 250/500 mS based on the configuration.
> The orderly_poweroff function is
On Tuesday 18 April 2017 09:59 AM, Keerthy wrote:
> thermal_zone_device_check --> thermal_zone_device_update -->
> handle_thermal_trip --> handle_critical_trips --> orderly_poweroff
>
> The above sequence happens every 250/500 mS based on the configuration.
> The orderly_poweroff function is
From: Xiubo Li
Currently for the TCMU, the ring buffer size is fixed to 64K cmd
area + 1M data area, and this will be bottlenecks for high iops.
The struct tcmu_cmd_entry {} size is fixed about 112 bytes with
iovec[N] & N <= 4, and the size of struct iovec is about
From: Xiubo Li
For each target there will be one ring, when the target number
grows larger and larger, it could eventually runs out of the
system memories.
In this patch for each target ring, currently for the cmd area
the size will be fixed to 8MB and for the data
1 - 100 of 1248 matches
Mail list logo