Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback

On Thu, May 11, 2017 at 11:17:59PM +0200, Thomas Gleixner wrote: > On Thu, 11 May 2017, Ben Hutchings wrote: > > > On Thu, 2017-05-11 at 16:12 +0200, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch. If anyone has any objections, please let me > > > know. > > > > > > --

Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback

On Thu, May 11, 2017 at 11:17:59PM +0200, Thomas Gleixner wrote: > On Thu, 11 May 2017, Ben Hutchings wrote: > > > On Thu, 2017-05-11 at 16:12 +0200, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch. If anyone has any objections, please let me > > > know. > > > > > > --

Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface

On Fri, 12 May 2017 11:27:42 +0200 Linus Walleij linus.wall...@linaro.org wrote: ... >Patch applied for fixes with Andy's Review tag. Thanks! What about this one https://lkml.org/lkml/2017/4/20/907 ? Any issues with it? Or can it be queued for v4.13? Thanks, Anatolij

[PATCH v3] Staging: rtl8192u: ieee80211: ieee80211_module.c: fix style issue

Fixed a brace coding style issue, found via checkpatch. Signed-off-by: Riccardo Marotti --- Changes in v2: - Fix mismatch between "Signed-off-by:" and "From:" names. Changes in v3: - Fix missing summary of changes in version 2.

Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid()

Hi Daniel, On Wednesday 10 May 2017 17:14:33 Daniel Vetter wrote: > On Wed, May 10, 2017 at 04:41:09PM +0300, Ville Syrjälä wrote: > > On Tue, May 09, 2017 at 06:00:13PM +0100, Jose Abreu wrote: > > > Introduce a new helper function which calls mode_valid() callback > > > for all bridges in an

Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface

On Fri, 12 May 2017 11:27:42 +0200 Linus Walleij linus.wall...@linaro.org wrote: ... >Patch applied for fixes with Andy's Review tag. Thanks! What about this one https://lkml.org/lkml/2017/4/20/907 ? Any issues with it? Or can it be queued for v4.13? Thanks, Anatolij

[PATCH v3] Staging: rtl8192u: ieee80211: ieee80211_module.c: fix style issue

Fixed a brace coding style issue, found via checkpatch. Signed-off-by: Riccardo Marotti --- Changes in v2: - Fix mismatch between "Signed-off-by:" and "From:" names. Changes in v3: - Fix missing summary of changes in version 2. drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +--

Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid()

Hi Daniel, On Wednesday 10 May 2017 17:14:33 Daniel Vetter wrote: > On Wed, May 10, 2017 at 04:41:09PM +0300, Ville Syrjälä wrote: > > On Tue, May 09, 2017 at 06:00:13PM +0100, Jose Abreu wrote: > > > Introduce a new helper function which calls mode_valid() callback > > > for all bridges in an

Re: [PATCH 3.18 00/39] 3.18.53-stable review

On Thu, May 11, 2017 at 02:46:37PM -0700, Tony Lindgren wrote: > * Matthijs van Duin [170511 14:34]: > > On Thu, May 11, 2017 at 02:16:07PM -0700, Guenter Roeck wrote: > > > arch/arm/mach-omap2/omap-headsmp.S:60: Error: bad instruction `badr > > > r0,hyp_boot' > > > >

Re: [PATCH] powernv:idle: Set NAPSTATELOST after recovering paca on P9 DD1

On Fri, 12 May 2017 14:52:06 +0530 "Gautham R. Shenoy" wrote: > From: "Gautham R. Shenoy" > > commit 17ed4c8f81da ("powerpc/powernv: Recover correct PACA on wakeup > from a stop on P9 DD1") promises to set the NAPSTATELOST bit in paca > after

Re: [PATCH 3.18 00/39] 3.18.53-stable review

On Thu, May 11, 2017 at 02:46:37PM -0700, Tony Lindgren wrote: > * Matthijs van Duin [170511 14:34]: > > On Thu, May 11, 2017 at 02:16:07PM -0700, Guenter Roeck wrote: > > > arch/arm/mach-omap2/omap-headsmp.S:60: Error: bad instruction `badr > > > r0,hyp_boot' > > > > > > I see "badr" used in

Re: [PATCH] powernv:idle: Set NAPSTATELOST after recovering paca on P9 DD1

On Fri, 12 May 2017 14:52:06 +0530 "Gautham R. Shenoy" wrote: > From: "Gautham R. Shenoy" > > commit 17ed4c8f81da ("powerpc/powernv: Recover correct PACA on wakeup > from a stop on P9 DD1") promises to set the NAPSTATELOST bit in paca > after recovering the correct paca for the thread waking

Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers

On 05/12/2017 02:15 PM, Kishon Vijay Abraham I wrote: Hi Vivek, On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: Adding vendor specific directories in phy to group phy drivers under their respective vendor umbrella. Also updated the MAINTAINERS file to reflect the correct directory

Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers

On 05/12/2017 02:15 PM, Kishon Vijay Abraham I wrote: Hi Vivek, On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: Adding vendor specific directories in phy to group phy drivers under their respective vendor umbrella. Also updated the MAINTAINERS file to reflect the correct directory

Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper

Hi Jose, Thank you for the patch. On Tuesday 09 May 2017 18:00:12 Jose Abreu wrote: > This changes the connector probe helper function to use the new > encoder->mode_valid() and crtc->mode_valid() helper callbacks to > validate the modes. > > The new callbacks are optional so the behaviour

Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper

Hi Jose, Thank you for the patch. On Tuesday 09 May 2017 18:00:12 Jose Abreu wrote: > This changes the connector probe helper function to use the new > encoder->mode_valid() and crtc->mode_valid() helper callbacks to > validate the modes. > > The new callbacks are optional so the behaviour

[PATCH v4] brcmfmac: btcoex: replace init_timer with setup_timer

MFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + CONFIG_BRCMDBG=y Kernel version: 4.11.0 (localversion-next is next-20170512) drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.

[PATCH v4] brcmfmac: btcoex: replace init_timer with setup_timer

version: 4.11.0 (localversion-next is next-20170512) drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c

Re: [PATCH 1/2] staging: ccree: Fix indentation of driver_hash[] initializers

On Fri, May 12, 2017 at 11:28:37AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Fri, May 12, 2017 at 10:57 AM, Greg Kroah-Hartman > wrote: > > On Sun, May 07, 2017 at 09:53:29PM +0200, Geert Uytterhoeven wrote: > >> Closing braces should match the first

Re: [PATCH 1/2] staging: ccree: Fix indentation of driver_hash[] initializers

Hi Greg, On Fri, May 12, 2017 at 10:57 AM, Greg Kroah-Hartman wrote: > On Sun, May 07, 2017 at 09:53:29PM +0200, Geert Uytterhoeven wrote: >> Closing braces should match the first characters of the opening. >> >> Signed-off-by: Geert Uytterhoeven

Re: [PATCH 1/2] staging: ccree: Fix indentation of driver_hash[] initializers

On Fri, May 12, 2017 at 11:28:37AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Fri, May 12, 2017 at 10:57 AM, Greg Kroah-Hartman > wrote: > > On Sun, May 07, 2017 at 09:53:29PM +0200, Geert Uytterhoeven wrote: > >> Closing braces should match the first characters of the opening. > >> > >>

Re: [PATCH 1/2] staging: ccree: Fix indentation of driver_hash[] initializers

Hi Greg, On Fri, May 12, 2017 at 10:57 AM, Greg Kroah-Hartman wrote: > On Sun, May 07, 2017 at 09:53:29PM +0200, Geert Uytterhoeven wrote: >> Closing braces should match the first characters of the opening. >> >> Signed-off-by: Geert Uytterhoeven >> --- >> drivers/staging/ccree/ssi_hash.c | 28

Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface

On Thu, May 11, 2017 at 8:24 PM, Anatolij Gustschin wrote: > Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table() > for the !GPIOLIB case to prevent build errors. > > Signed-off-by: Anatolij Gustschin Patch applied for fixes with Andy's Review

Re: Threads stuck in zap_pid_ns_processes()

On Fri, May 12, 2017 at 7:19 AM, Eric W. Biederman wrote: > Guenter Roeck writes: > >> On Thu, May 11, 2017 at 04:25:23PM -0500, Eric W. Biederman wrote: >>> Guenter Roeck writes: >>> >>> > On Thu, May 11, 2017 at 12:31:21PM -0500,

Re: pinctrl-sx150x.c broken in 4.11

On Thu, May 11, 2017 at 7:51 PM, Tony Lindgren wrote: > * Nikita Yushchenko [170511 10:01]: >> Well that's exactly what patch from my first mail in this thread does. >> This indeed fixes my case, but I don't know if it is correct in generic >>

Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface

On Thu, May 11, 2017 at 8:24 PM, Anatolij Gustschin wrote: > Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table() > for the !GPIOLIB case to prevent build errors. > > Signed-off-by: Anatolij Gustschin Patch applied for fixes with Andy's Review tag. Yours, Linus Walleij

Re: Threads stuck in zap_pid_ns_processes()

On Fri, May 12, 2017 at 7:19 AM, Eric W. Biederman wrote: > Guenter Roeck writes: > >> On Thu, May 11, 2017 at 04:25:23PM -0500, Eric W. Biederman wrote: >>> Guenter Roeck writes: >>> >>> > On Thu, May 11, 2017 at 12:31:21PM -0500, Eric W. Biederman wrote: >>> >> Guenter Roeck writes: >>> >>

Re: pinctrl-sx150x.c broken in 4.11

On Thu, May 11, 2017 at 7:51 PM, Tony Lindgren wrote: > * Nikita Yushchenko [170511 10:01]: >> Well that's exactly what patch from my first mail in this thread does. >> This indeed fixes my case, but I don't know if it is correct in generic >> case. > > OK, yeah I just looked it up as I was not

Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width

On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote: > +#define REG_INT_MIG_8723B 0x0304 /* Interrupt Migration > */ > +#define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor > Address > + */ >

Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width

On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote: > +#define REG_INT_MIG_8723B 0x0304 /* Interrupt Migration > */ > +#define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor > Address > + */ >

Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions

On Thu, May 11, 2017 at 4:20 PM, Andre Przywara wrote: >> On Thu, May 4, 2017 at 1:57 AM, Andre Przywara >> wrote: >> >>> When a pinctrl driver gets interrupted during its probe process >>> (returning -EPROBE_DEFER), the devres system cleans up

Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions

On Thu, May 11, 2017 at 4:20 PM, Andre Przywara wrote: >> On Thu, May 4, 2017 at 1:57 AM, Andre Przywara >> wrote: >> >>> When a pinctrl driver gets interrupted during its probe process >>> (returning -EPROBE_DEFER), the devres system cleans up all allocated >>> resources. During this process

[PATCH] powernv:idle: Set NAPSTATELOST after recovering paca on P9 DD1

From: "Gautham R. Shenoy" commit 17ed4c8f81da ("powerpc/powernv: Recover correct PACA on wakeup from a stop on P9 DD1") promises to set the NAPSTATELOST bit in paca after recovering the correct paca for the thread waking up from stop1 on DD1, so that the GPRs can be

[PATCH] powernv:idle: Set NAPSTATELOST after recovering paca on P9 DD1

From: "Gautham R. Shenoy" commit 17ed4c8f81da ("powerpc/powernv: Recover correct PACA on wakeup from a stop on P9 DD1") promises to set the NAPSTATELOST bit in paca after recovering the correct paca for the thread waking up from stop1 on DD1, so that the GPRs can be correctly restored on the

Re: net: ath: tx99: fixed a spelling issue

ammly wrote: > Fixed a spelling issue. > > Signed-off-by: Ammly Fredrick I changed the commit log. Also check your From header in the email headers, it's missing your last name. Author: Ammly Fredrick Date: Thu Apr 27 19:31:37 2017

Re: net: ath: tx99: fixed a spelling issue

ammly wrote: > Fixed a spelling issue. > > Signed-off-by: Ammly Fredrick I changed the commit log. Also check your From header in the email headers, it's missing your last name. Author: Ammly Fredrick Date: Thu Apr 27 19:31:37 2017 +0300 ath9k: fix spelling in ath9k_tx99_init()

Re: [PATCH] cpufreq: dbx500: add a Kconfig symbol

On Thu, May 11, 2017 at 2:12 PM, Arnd Bergmann wrote: > Moving the cooling code into the cpufreq driver caused a possible build > failure > when the cpu_thermal helper code is a loadable module or disabled: > > drivers/cpufreq/dbx500-cpufreq.o: In function `dbx500_cpufreq_ready':

mm: page allocation failures in swap_duplicate -> add_swap_count_continuation

Folks, recently I have seen page allocation failures during paging in the paging code: e.g. May 05 21:36:53 kernel: Call Trace: May 05 21:36:53 kernel: ([<00112f62>] show_trace+0x62/0x78) May 05 21:36:53 kernel: [<00113050>] show_stack+0x68/0xe0 May 05 21:36:53 kernel:

Re: [PATCH] cpufreq: dbx500: add a Kconfig symbol

On Thu, May 11, 2017 at 2:12 PM, Arnd Bergmann wrote: > Moving the cooling code into the cpufreq driver caused a possible build > failure > when the cpu_thermal helper code is a loadable module or disabled: > > drivers/cpufreq/dbx500-cpufreq.o: In function `dbx500_cpufreq_ready': >

mm: page allocation failures in swap_duplicate -> add_swap_count_continuation

Folks, recently I have seen page allocation failures during paging in the paging code: e.g. May 05 21:36:53 kernel: Call Trace: May 05 21:36:53 kernel: ([<00112f62>] show_trace+0x62/0x78) May 05 21:36:53 kernel: [<00113050>] show_stack+0x68/0xe0 May 05 21:36:53 kernel:

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

Arend van Spriel writes: >>> This third version is the same as v1 on which I commented to put the >>> coccinelle output in the commit message. So I would still keep v2 if >>> nothing else changed in v3 apart from my Acked-by: tag. >> >> Ok, but I can easily take v3

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

Arend van Spriel writes: >>> This third version is the same as v1 on which I commented to put the >>> coccinelle output in the commit message. So I would still keep v2 if >>> nothing else changed in v3 apart from my Acked-by: tag. >> >> Ok, but I can easily take v3 (ie. this one) so that you get

Re: [PATCH 2/2] kvm: arm/arm64: Fix use after free of stage2 page table

On 03/05/17 15:17, Suzuki K Poulose wrote: > We yield the kvm->mmu_lock occassionaly while performing an operation occasionally > (e.g, unmap or permission changes) on a large area of stage2 mappings. > However this could possibly cause another thread to clear and free

Re: [PATCH 2/2] kvm: arm/arm64: Fix use after free of stage2 page table

On 03/05/17 15:17, Suzuki K Poulose wrote: > We yield the kvm->mmu_lock occassionaly while performing an operation occasionally > (e.g, unmap or permission changes) on a large area of stage2 mappings. > However this could possibly cause another thread to clear and free

答复: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC

Hi Niklas, Thanks a lot for your time to review my patch. I'll modify according to your comments and update the patch. Best regards, Song -邮件原件- 发件人: Niklas Cassel [mailto:niklas.cas...@axis.com] 发送时间: 2017年5月12日 16:08 收件人: songxiaowei; bhelg...@google.com; kis...@ti.com;

答复: [PATCH 1/2] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC

Hi Niklas, Thanks a lot for your time to review my patch. I'll modify according to your comments and update the patch. Best regards, Song -邮件原件- 发件人: Niklas Cassel [mailto:niklas.cas...@axis.com] 发送时间: 2017年5月12日 16:08 收件人: songxiaowei; bhelg...@google.com; kis...@ti.com;

Re: [PATCH] pinctrl: imx: Check for memory allocation failure

On Sat, May 6, 2017 at 10:23 AM, Christophe JAILLET wrote: > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > Return -ENOMEM instead, as done for the other memory allocation just a > few lines below. > BTW, change the 'devm_kzalloc' into a

Re: [PATCH] media: fix one code style problem

On Fri, May 05, 2017 at 01:18:24PM -0700, Remco wrote: > From: Remco Verhoef > > this patch will fix one code style problem (ctx:WxE), space > prohibited before that Your subject needs work :) And why just one issue, is that the only place this type of problem is needed

Re: [PATCH] pinctrl: imx: Check for memory allocation failure

On Sat, May 6, 2017 at 10:23 AM, Christophe JAILLET wrote: > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > Return -ENOMEM instead, as done for the other memory allocation just a > few lines below. > BTW, change the 'devm_kzalloc' into a 'devm_kcalloc'. > > Signed-off-by:

Re: [PATCH] media: fix one code style problem

On Fri, May 05, 2017 at 01:18:24PM -0700, Remco wrote: > From: Remco Verhoef > > this patch will fix one code style problem (ctx:WxE), space > prohibited before that Your subject needs work :) And why just one issue, is that the only place this type of problem is needed in this file? thanks,

Re: [PATCH 1/2] kvm: arm/arm64: Fix race in resetting stage2 PGD

On 03/05/17 15:17, Suzuki K Poulose wrote: > In kvm_free_stage2_pgd() we check the stage2 PGD before holding > the lock and proceed to take the lock if it is valid. And we unmap > the page tables, followed by releasing the lock. We reset the PGD > only after dropping this lock, which could cause a

Re: [PATCH 1/2] kvm: arm/arm64: Fix race in resetting stage2 PGD

On 03/05/17 15:17, Suzuki K Poulose wrote: > In kvm_free_stage2_pgd() we check the stage2 PGD before holding > the lock and proceed to take the lock if it is valid. And we unmap > the page tables, followed by releasing the lock. We reset the PGD > only after dropping this lock, which could cause a

Re: [RFC PATCH 6/6] drm/i915/gvt: support QEMU getting the dmabuf

Hi, > If the contents of the framebuffer change or if the parameters of the > framebuffer change? I can't image that creating a new dmabuf fd for > every visual change within the framebuffer would be efficient, but I > don't have any concept of what a dmabuf actually does. Ok, some

Re: [RFC PATCH 6/6] drm/i915/gvt: support QEMU getting the dmabuf

Hi, > If the contents of the framebuffer change or if the parameters of the > framebuffer change? I can't image that creating a new dmabuf fd for > every visual change within the framebuffer would be efficient, but I > don't have any concept of what a dmabuf actually does. Ok, some

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

adcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use setup_timer function for function on line 384. Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y + CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + CONFIG_BRCMDBG=y Kernel version: 4.11.0 (localversi

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

with: x86_64_defconfig + CONFIG_BRCMFMAC=y + CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + CONFIG_BRCMDBG=y Kernel version: 4.11.0 (localversion-next is next-20170512) How is this different from the first version? https://patchwork.kernel.org/patch/9709467/ Hi

Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

On Thu, May 11, 2017 at 11:23:11PM +0200, Pavel Machek wrote: > On Fri 2017-04-21 14:08:04, Ville Syrjälä wrote: > > On Fri, Apr 21, 2017 at 11:50:18AM +0200, Gerd Hoffmann wrote: > > > On Fr, 2017-04-21 at 12:25 +0300, Ville Syrjälä wrote: > > > > On Fri, Apr 21, 2017 at 09:58:24AM +0200, Gerd

Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

On Thu, May 11, 2017 at 11:23:11PM +0200, Pavel Machek wrote: > On Fri 2017-04-21 14:08:04, Ville Syrjälä wrote: > > On Fri, Apr 21, 2017 at 11:50:18AM +0200, Gerd Hoffmann wrote: > > > On Fr, 2017-04-21 at 12:25 +0300, Ville Syrjälä wrote: > > > > On Fri, Apr 21, 2017 at 09:58:24AM +0200, Gerd

Re: [PATCH v3] pinctrl: mediatek: reuse pinctrl driver for mt7623

On Mon, May 1, 2017 at 9:54 AM, wrote: > From: Sean Wang > > mt7623 pinctrl hardware can be compatible with mt2701 driver, > so the patch lets the pinctrl on mt7623 SoC reuse the driver > and deletes those redundant ones. > > Cc: John Crispin

Re: [PATCH v3] pinctrl: mediatek: reuse pinctrl driver for mt7623

On Mon, May 1, 2017 at 9:54 AM, wrote: > From: Sean Wang > > mt7623 pinctrl hardware can be compatible with mt2701 driver, > so the patch lets the pinctrl on mt7623 SoC reuse the driver > and deletes those redundant ones. > > Cc: John Crispin > Signed-off-by: Sean Wang Execllent, patch

Re: [PATCH] staging: rtl8188eu: Fix one coding style problem

On Tue, May 09, 2017 at 05:07:51PM -0700, Remco Verhoef wrote: > Fix code indent should use tabs where possible coding style > error. Your subject should be a bit better, why, "one"? please fix and resend. thanks, greg k-h

Re: [PATCH] staging: rtl8188eu: Fix one coding style problem

On Tue, May 09, 2017 at 05:07:51PM -0700, Remco Verhoef wrote: > Fix code indent should use tabs where possible coding style > error. Your subject should be a bit better, why, "one"? please fix and resend. thanks, greg k-h

Re: [PATCH v2] Staging: rtl8192u: ieee80211: ieee80211_module.c: fix style issue

On Sun, May 07, 2017 at 11:01:07AM +0200, Riccardo Marotti wrote: > Fixed a brace coding style issue, found via checkpatch. > > Signed-off-by: Riccardo Marotti > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH v2] Staging: rtl8192u: ieee80211: ieee80211_module.c: fix style issue

On Sun, May 07, 2017 at 11:01:07AM +0200, Riccardo Marotti wrote: > Fixed a brace coding style issue, found via checkpatch. > > Signed-off-by: Riccardo Marotti > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) What changed

Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse

On Tue, May 09, 2017 at 03:17:56PM +0530, suniel.spar...@gmail.com wrote: > From: Suniel Mahesh > > The function Mk16_le() is calling le16_to_cpu() > internally. le16_to_cpu() takes an argument of type (__le *) > but the argument passed is of type (u16 *). Fixed it by

Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse

On Tue, May 09, 2017 at 03:17:56PM +0530, suniel.spar...@gmail.com wrote: > From: Suniel Mahesh > > The function Mk16_le() is calling le16_to_cpu() > internally. le16_to_cpu() takes an argument of type (__le *) > but the argument passed is of type (u16 *). Fixed it by passing > the correct

Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse

On Mon, May 01, 2017 at 01:19:24PM +0530, suniel.spar...@gmail.com wrote: > From: Suniel Mahesh > > The function Mk16_le() is calling le16_to_cpu() internally. > le16_to_cpu() takes an argument of type (__le *) but the argument > passed is of type (u16 *). Fixed it by

Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse

On Mon, May 01, 2017 at 01:19:24PM +0530, suniel.spar...@gmail.com wrote: > From: Suniel Mahesh > > The function Mk16_le() is calling le16_to_cpu() internally. > le16_to_cpu() takes an argument of type (__le *) but the argument > passed is of type (u16 *). Fixed it by passing the correct

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven wrote: Oops missed this: > Hence I think we should not use generic pin properties, but consider these > settings to be part of pinmux configuration. > As having large tables in the driver is undesirable, I think storing

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven wrote: Oops missed this: > Hence I think we should not use generic pin properties, but consider these > settings to be part of pinmux configuration. > As having large tables in the driver is undesirable, I think storing the > settings in the

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven wrote: > The question I'm asking myself is: are these settings related to pin > configuration (i.e. depending on the use of the pin, and several settings > are valid, depending on the use case), or are they related to

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven wrote: > The question I'm asking myself is: are these settings related to pin > configuration (i.e. depending on the use of the pin, and several settings > are valid, depending on the use case), or are they related to pinmux > (i.e. defined by

Re: [PATCH] staging: ccree: remove trailing whitespace. switch spaces to tabs

On Tue, May 09, 2017 at 11:39:56AM -0700, Connor Kelleher wrote: > ssi_fips.c: > > fixing checkpatch.pl errors: > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > +This function returns the REE

Re: [PATCH] staging: ccree: remove trailing whitespace. switch spaces to tabs

On Tue, May 09, 2017 at 11:39:56AM -0700, Connor Kelleher wrote: > ssi_fips.c: > > fixing checkpatch.pl errors: > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > +This function returns the REE

Re: [PATCH] staging: ccree: ssi_aead.c: Fix blank lines coding style issue

On Tue, May 09, 2017 at 07:53:30PM +0300, Alex wrote: > Checkpatch emits CHECK: Please don't use multiple blank lines. > > Remove multiple blank lines. > > Signed-off-by: Alexander Mazyrin This name doesn't match your "From:" name :(

Re: [PATCH] staging: ccree: ssi_aead.c: Fix blank lines coding style issue

On Tue, May 09, 2017 at 07:53:30PM +0300, Alex wrote: > Checkpatch emits CHECK: Please don't use multiple blank lines. > > Remove multiple blank lines. > > Signed-off-by: Alexander Mazyrin This name doesn't match your "From:" name :(

Re: [PATCH 1/2] staging: ccree: Fix indentation of driver_hash[] initializers

On Sun, May 07, 2017 at 09:53:29PM +0200, Geert Uytterhoeven wrote: > Closing braces should match the first characters of the opening. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/staging/ccree/ssi_hash.c | 28 ++-- > 1 file changed, 14

Re: [PATCH 1/2] staging: ccree: Fix indentation of driver_hash[] initializers

On Sun, May 07, 2017 at 09:53:29PM +0200, Geert Uytterhoeven wrote: > Closing braces should match the first characters of the opening. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/staging/ccree/ssi_hash.c | 28 ++-- > 1 file changed, 14 insertions(+), 14

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

MAC=y + >>> CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + >>> CONFIG_BRCMDBG=y >>> >>> Kernel version: 4.11.0 (localversion-next is next-20170512) >> >> How is this different from the first version? >> >> https

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

.c:383:1-11: Use >>> setup_timer function for function on line 384. >>> >>> Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y + >>> CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + >>>

Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers

Hi Vivek, On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: > Adding vendor specific directories in phy to group > phy drivers under their respective vendor umbrella. > > Also updated the MAINTAINERS file to reflect the correct > directory structure for phy drivers. > > Signed-off-by: Vivek

Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers

Hi Vivek, On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: > Adding vendor specific directories in phy to group > phy drivers under their respective vendor umbrella. > > Also updated the MAINTAINERS file to reflect the correct > directory structure for phy drivers. > > Signed-off-by: Vivek

Re: Clarification for general change acceptance

> When you make a patch, you are not obliged to eliminate all of the other > checkpatch warnings on the file. Your view is generally fine. > I don't know where you got this idea from. I got used as a professional software developer to some approaches for reducing development warnings to some

Re: Clarification for general change acceptance

> When you make a patch, you are not obliged to eliminate all of the other > checkpatch warnings on the file. Your view is generally fine. > I don't know where you got this idea from. I got used as a professional software developer to some approaches for reducing development warnings to some

[PATCH 1/2] m32r, microblaze, x86, xtensa: use generic vga.h

What these architectures declare is the same as what can be found in asm-generic/vga.h. So use that header instead. Signed-off-by: Jiri Slaby Acked-by: Max Filippov Cc: Michal Simek Cc: Thomas Gleixner Cc: Ingo Molnar

[PATCH 1/2] m32r, microblaze, x86, xtensa: use generic vga.h

What these architectures declare is the same as what can be found in asm-generic/vga.h. So use that header instead. Signed-off-by: Jiri Slaby Acked-by: Max Filippov Cc: Michal Simek Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Chris Zankel Cc: x...@kernel.org Cc:

[PATCH 2/2] frv, mn10300, s390, sh: remove empty vga.h

Provided the architectures do not need any special handling (they seem not to support vga at all, actually), there is no need to have an empty vga.h. Let them refer to the generic one instead. Signed-off-by: Jiri Slaby Acked-by: Geert Uytterhoeven Acked-by:

[PATCH 2/2] frv, mn10300, s390, sh: remove empty vga.h

Provided the architectures do not need any special handling (they seem not to support vga at all, actually), there is no need to have an empty vga.h. Let them refer to the generic one instead. Signed-off-by: Jiri Slaby Acked-by: Geert Uytterhoeven Acked-by: Martin Schwidefsky Cc: David Howells

Re: handle_bad_irq and locking

On Thu, 11 May 2017, Gregory Fong wrote: > Hi Thomas, > > I noticed that when you changed arm irq handling to use the generic > implementation back in 2006 that you changed do_bad_IRQ() to the > following: > > +#define do_bad_IRQ(irq,desc,regs) \ > +do {

Re: handle_bad_irq and locking

On Thu, 11 May 2017, Gregory Fong wrote: > Hi Thomas, > > I noticed that when you changed arm irq handling to use the generic > implementation back in 2006 that you changed do_bad_IRQ() to the > following: > > +#define do_bad_IRQ(irq,desc,regs) \ > +do {

Attn, view attach and get back to me

--- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Attn, view attach and get back to me

--- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [PATCH 2/2] KVM: nVMX: fix nEPT handling of guest page table accesses

On 12/05/2017 09:38, Xiao Guangrong wrote: > CC Kevin as i am not sure if Intel is aware of this issue, it > breaks other hypervisors, e.g, Xen, as swell. It's actually more complicated. When EPT A/D bits are disabled, reads of the page tables behave as described in the manual; writes have both

Re: [PATCH 2/2] KVM: nVMX: fix nEPT handling of guest page table accesses

On 12/05/2017 09:38, Xiao Guangrong wrote: > CC Kevin as i am not sure if Intel is aware of this issue, it > breaks other hypervisors, e.g, Xen, as swell. It's actually more complicated. When EPT A/D bits are disabled, reads of the page tables behave as described in the manual; writes have both

Re: [kernel-locking] question about structure field initialization

On Thu, May 11, 2017 at 03:00:02PM -0500, Gustavo A. R. Silva wrote: > > Hello everybody, > > While looking into Coverity ID 1402035 I ran into the following > piece of code at kernel/locking/test-ww_mutex.c:197: > > 197static int test_abba(bool resolve) > 198{ > 199struct test_abba

Re: [kernel-locking] question about structure field initialization

On Thu, May 11, 2017 at 03:00:02PM -0500, Gustavo A. R. Silva wrote: > > Hello everybody, > > While looking into Coverity ID 1402035 I ran into the following > piece of code at kernel/locking/test-ww_mutex.c:197: > > 197static int test_abba(bool resolve) > 198{ > 199struct test_abba

[tip:irq/urgent] irqchip/mbigen: Fix the clear register offset calculation

Commit-ID: 9459a04b6a5a09967eec94a1b66f0a74312819d9 Gitweb: http://git.kernel.org/tip/9459a04b6a5a09967eec94a1b66f0a74312819d9 Author: MaJun AuthorDate: Fri, 12 May 2017 11:55:28 +0800 Committer: Thomas Gleixner CommitDate: Fri, 12 May 2017

[tip:irq/urgent] irqchip/mbigen: Fix the clear register offset calculation

Commit-ID: 9459a04b6a5a09967eec94a1b66f0a74312819d9 Gitweb: http://git.kernel.org/tip/9459a04b6a5a09967eec94a1b66f0a74312819d9 Author: MaJun AuthorDate: Fri, 12 May 2017 11:55:28 +0800 Committer: Thomas Gleixner CommitDate: Fri, 12 May 2017 10:25:38 +0200 irqchip/mbigen: Fix the clear

Re: Clarification for general change acceptance

> But I will come along source code places where I am going to update details > which are also trivial. When you make a patch, you are not obliged to eliminate all of the other checkpatch warnings on the file. I don't know where you got this idea from. The submitting patch guidelines don't say

Re: Clarification for general change acceptance

> But I will come along source code places where I am going to update details > which are also trivial. When you make a patch, you are not obliged to eliminate all of the other checkpatch warnings on the file. I don't know where you got this idea from. The submitting patch guidelines don't say

<    6   7   8   9   10   11   12   13   14   >