Re: [PATCH] ARM: Use WFI when possible when halting a core

2017-07-27 Thread Chen-Yu Tsai
On Thu, Jul 27, 2017 at 8:45 PM, Chen-Yu Tsai wrote: > On Thu, Jul 27, 2017 at 8:17 PM, Russell King - ARM Linux > wrote: >> On Thu, Jul 27, 2017 at 08:08:03PM +0800, Chen-Yu Tsai wrote: >>> On ARM, the kernel busy loops after cleaning up when a core is to be >>> halted. This may have the undesir

Re: [PATCH] mm: memcontrol: Use int for event/state parameter in several functions

2017-07-27 Thread Michal Hocko
On Thu 27-07-17 14:10:04, Matthias Kaehlcke wrote: > Several functions use an enum type as parameter for an event/state, > but are called in some locations with an argument of a different enum > type. Adjust the interface of these functions to reality by changing the > parameter to int. enums are

Re: [PATCH] KVM: nVMX: do not pin the VMCS12

2017-07-27 Thread Paolo Bonzini
On 27/07/2017 19:20, David Matlack wrote: >> + kvm_vcpu_write_guest_page(&vmx->vcpu, >> + vmx->nested.current_vmptr >> PAGE_SHIFT, >> + vmx->nested.cached_vmcs12, 0, VMCS12_SIZE); > Have you hit any "suspicious RCU usage" error m

[PATCH v6 02/14] spi: qup: Setup DMA mode correctly

2017-07-27 Thread Varadarajan Narayanan
To operate in DMA mode, the buffer should be aligned and the size of the transfer should be a multiple of block size (for v1). And the no. of words being transferred should be programmed in the count registers appropriately. Signed-off-by: Andy Gross Signed-off-by: Varadarajan Narayanan --- dri

[PATCH v6 04/14] spi: qup: Place the QUP in run mode before DMA

2017-07-27 Thread Varadarajan Narayanan
Signed-off-by: Andy Gross Signed-off-by: Varadarajan Narayanan --- drivers/spi/spi-qup.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index fdd34c3..f1aa5c1 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -34

[PATCH v6 06/14] spi: qup: Fix transaction done signaling

2017-07-27 Thread Varadarajan Narayanan
Wait to signal done until we get all of the interrupts we are expecting to get for a transaction. If we don't wait for the input done flag, we can be in between transactions when the done flag comes in and this can mess up the next transaction. While here cleaning up the code which sets controlle

[PATCH v6 05/14] spi: qup: Fix error handling in spi_qup_prep_sg

2017-07-27 Thread Varadarajan Narayanan
Signed-off-by: Varadarajan Narayanan --- drivers/spi/spi-qup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index f1aa5c1..ef95294 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -311,8 +311,8 @@ static int

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-27 Thread David.Wu
Hi Florian, 在 2017/7/28 0:54, Florian Fainelli 写道: - if you need knowledge about this PHY connection type prior to binding the PHY device and its driver (that is, before of_phy_connect()) we could add a boolean property e.g: "phy-is-internal" that allows us to know that, or we can have a new phy

[PATCH v6 09/14] spi: qup: call io_config in mode specific function

2017-07-27 Thread Varadarajan Narayanan
DMA transactions should only only need to call io_config only once, but block mode might call it several times to setup several transactions so it can handle reads/writes larger than the max size per transaction, so we move the call to the do_ functions. This is just refactoring, there should be n

[PATCH v6 12/14] spi: qup: allow multiple DMA transactions per spi xfer

2017-07-27 Thread Varadarajan Narayanan
Much like the block mode changes, we are breaking up DMA transactions into 64K chunks so we can reset the QUP engine. Signed-off-by: Matthew McClintock Signed-off-by: Varadarajan Narayanan --- drivers/spi/spi-qup.c | 92 --- 1 file changed, 66 ins

[PATCH v6 14/14] spi: qup: Fix QUP version identify method

2017-07-27 Thread Varadarajan Narayanan
Use of_device_get_match_data to identify QUP version instead of of_device_is_compatible. Signed-off-by: Varadarajan Narayanan --- drivers/spi/spi-qup.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 4c3c938..1364516

[PATCH v6 10/14] spi: qup: allow block mode to generate multiple transactions

2017-07-27 Thread Varadarajan Narayanan
This let's you write more to the SPI bus than 64K-1 which is important if the block size of a SPI device is >= 64K or some other device wants to do something larger. This has the benefit of completely removing spi_message from the spi-qup transactions Signed-off-by: Matthew McClintock Signed-off

[PATCH v6 13/14] spi: qup: Ensure done detection

2017-07-27 Thread Varadarajan Narayanan
This patch fixes an issue where a SPI transaction has completed, but the done condition is missed. This occurs because at the time of interrupt the MAX_INPUT_DONE_FLAG is not asserted. However, in the process of reading blocks of data from the FIFO, the last portion of data comes in. The opflags

[PATCH v6 11/14] spi: qup: refactor spi_qup_prep_sg

2017-07-27 Thread Varadarajan Narayanan
Take specific sgl and nent to be prepared. This is in preparation for splitting DMA into multiple transacations, this contains no code changes just refactoring. Signed-off-by: Matthew McClintock Signed-off-by: Varadarajan Narayanan --- drivers/spi/spi-qup.c | 23 ++- 1 file

[PATCH v6 07/14] spi: qup: Do block sized read/write in block mode

2017-07-27 Thread Varadarajan Narayanan
This patch corrects the behavior of the BLOCK transactions. During block transactions, the controller must be read/written to in block size transactions. Signed-off-by: Andy Gross Signed-off-by: Varadarajan Narayanan --- drivers/spi/spi-qup.c | 151 +++--

[PATCH v6 08/14] spi: qup: refactor spi_qup_io_config into two functions

2017-07-27 Thread Varadarajan Narayanan
This is in preparation for handling transactions larger than 64K-1 bytes in block mode, which is currently unsupported and quietly fails. We need to break these into two functions 1) prep is called once per spi_message and 2) io_config is called once per spi-qup bus transaction This is just refac

[PATCH v6 03/14] spi: qup: Add completion timeout

2017-07-27 Thread Varadarajan Narayanan
Add i/o completion timeout for DMA and PIO modes. Signed-off-by: Andy Gross Signed-off-by: Varadarajan Narayanan --- drivers/spi/spi-qup.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index abe799b..fdd34c3

[PATCH v6 01/14] spi: qup: Enable chip select support

2017-07-27 Thread Varadarajan Narayanan
Enable chip select support for QUP versions later than v1. The chip select support was broken in QUP version 1. Hence the chip select support was removed earlier in an earlier commit (4a8573abe "spi: qup: Remove chip select function"). Since the chip select support is functional in recent versions

[PATCH v6 00/14] spi: qup: Fixes and add support for >64k transfers

2017-07-27 Thread Varadarajan Narayanan
v6: Fix git bisect-ability issues in spi: qup: Add completion timeout spi: qup: call io_config in mode specific function spi: qup: allow multiple DMA transactions per spi xfer v5: Incorporate feedback from Mark Brown and Geert Uytterh

Re: [PATCH 3.10] pstore: Make spinlock per zone instead of global

2017-07-27 Thread Leo Yan
On Fri, Jul 28, 2017 at 06:25:55AM +0200, Willy Tarreau wrote: > Hi Leo, > > There was no upstream commit ID here but I found it in mainline here : > > commit 109704492ef637956265ec2eb72ae7b3b39eb6f4 > Author: Joel Fernandes > Date: Thu Oct 20 00:34:00 2016 -0700 > > pstore: Make sp

Re: [PATCH v8 06/13] iommu/amd: copy old trans table from old kernel

2017-07-27 Thread Baoquan He
On 07/27/17 at 05:38pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:04PM +0800, Baoquan He wrote: > > @@ -2128,9 +2131,43 @@ static void early_enable_iommu(struct amd_iommu > > *iommu) > > static void early_enable_iommus(void) > > { > > struct amd_iommu *iommu; > > + bool is_pre_en

Re: [PATCH v7 16/26] x86/insn-eval: Support both signed 32-bit and 64-bit effective addresses

2017-07-27 Thread Borislav Petkov
On Thu, Jul 27, 2017 at 07:04:52PM -0700, Ricardo Neri wrote: > However using the union could be less readable than having two almost > identical functions. So having some small duplication for the sake of clarity and readability is much better, if you ask me. And it's not like you're duplicating

[PATCH] x86/boot: check overlap between kernel and EFI_BOOT_SERVICES_*

2017-07-27 Thread Naoya Horiguchi
On Wed, Jul 26, 2017 at 09:34:32AM +0800, Baoquan He wrote: > On 07/26/17 at 09:13am, Baoquan He wrote: > > On 07/26/17 at 12:12am, Naoya Horiguchi wrote: > > > On Mon, Jul 24, 2017 at 02:20:44PM +0100, Matt Fleming wrote: > > > > On Mon, 10 Jul, at 02:51:36PM, Naoya Horiguchi wrote: > > > > > EFI_

[PATCH V5 2/2] cpufreq: Process remote callbacks from any CPU if the platform permits

2017-07-27 Thread Viresh Kumar
On many platforms, CPUs can do DVFS across cpufreq policies. i.e CPU from policy-A can change frequency of CPUs belonging to policy-B. This is quite common in case of ARM platforms where we don't configure any per-cpu register. Add a flag to identify such platforms and update cpufreq_can_do_remot

[PATCH V5 0/2] sched: cpufreq: Allow remote callbacks

2017-07-27 Thread Viresh Kumar
With Android UI and benchmarks the latency of cpufreq response to certain scheduling events can become very critical. Currently, callbacks into cpufreq governors are only made from the scheduler if the target CPU of the event is the same as the current CPU. This means there are certain situations w

[PATCH V5 1/2] sched: cpufreq: Allow remote cpufreq callbacks

2017-07-27 Thread Viresh Kumar
With Android UI and benchmarks the latency of cpufreq response to certain scheduling events can become very critical. Currently, callbacks into cpufreq governors are only made from the scheduler if the target CPU of the event is the same as the current CPU. This means there are certain situations w

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-27 Thread David.Wu
Hi Andrew, 在 2017/7/27 21:48, Andrew Lunn 写道: I think we need to discuss this. This PHY appears to be on an MDIO bus, it uses a standard PHY driver, and it appears to be using an RMII interface. So it is just an ordinary PHY. Internal is supposed to be something which is not ordinary, does not

Re: [PATCH v7] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions

2017-07-27 Thread Ingo Molnar
* Baoquan He wrote: > Currently KASLR will parse all e820 entries of RAM type and add all > candidate position into slots array. Then we will choose one slot > randomly as the new position which kernel will be decompressed into > and run at. > > On system with EFI enabled, e820 memory regions a

Re: [PATCH v3] cpu_pm: replace raw_notifier to atomic_notifier

2017-07-27 Thread Tony Lindgren
* Alex Shi [170727 18:42]: > Tony Lezcano found a miss use that rcu_read_lock used after rcu_idle_enter > Paul E. McKenney suggested trying RCU_NONIDLE. Hmm I think you have a hybrid name typo above in case you mean me :) Tony

[PATCH 0/3] fix several TLB batch races

2017-07-27 Thread Minchan Kim
Nadav and Mel founded several subtle races caused by TLB batching. This patchset aims for solving thoses problems using embedding [set|clear]_tlb_flush_pending to TLB batching API. With that, places to know TLB flush pending catch it up by using mm_tlb_flush_pending. Each patch includes detailed d

[PATCH 3/3] mm: fix KSM data corruption

2017-07-27 Thread Minchan Kim
Nadav reported KSM can corrupt the user data by the TLB batching race[1]. That means data user written can be lost. Quote from Nadav Amit " For this race we need 4 CPUs: CPU0: Caches a writable and dirty PTE entry, and uses the stale value for write later. CPU1: Runs madvise_free on the range th

[PATCH 2/3] mm: fix MADV_[FREE|DONTNEED] TLB flush miss problem

2017-07-27 Thread Minchan Kim
Nadav reported parallel MADV_DONTNEED on same range has a stale TLB problem and Mel fixed it[1] and found same problem on MADV_FREE[2]. Quote from Mel Gorman "The race in question is CPU 0 running madv_free and updating some PTEs while CPU 1 is also running madv_free and looking at the same PTEs.

[PATCH 1/3] mm: make tlb_flush_pending global

2017-07-27 Thread Minchan Kim
Currently, tlb_flush_pending is used only for CONFIG_[NUMA_BALANCING| COMPACTION] but upcoming patches to solve subtle TLB flush bacting problem will use it regardless of compaction/numa so this patch doesn't remove the dependency. Cc: Nadav Amit Cc: Mel Gorman Signed-off-by: Minchan Kim --- i

[PATCH] ARM: rockchip: enable ZONE_DMA for non 64-bit capable peripherals

2017-07-27 Thread Tao Huang
Most IP cores on ARM Rockchip platforms can only address 32 bits of physical memory for DMA. Thus ZONE_DMA should be enabled when LPAE is activated. Signed-off-by: Tao Huang --- arch/arm/mach-rockchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-rockchip/Kconfig b/ar

Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error

2017-07-27 Thread Ingo Molnar
* Borislav Petkov wrote: > BUT(!), I just realized, I *think* I can address this much more elegantly: > extend trace_mce_record() by adding the decoded string as its last argument. > And > that's fine, I'm being told, because adding arguments to the tracepoints is > not > a big deal, removi

Re: [PATCH -tip v5 1/2] irq: Introduce CONFIG_IRQENTRY kconfig

2017-07-27 Thread Ingo Molnar
* Masami Hiramatsu wrote: > Introduce CONFIG_IRQENTRY to simplify generating > irqentry and softirqentry text sections. > Currently generating those sections depends on > CONFIG_FUNCTION_GRAPH_TRACER and/or CONFIG_KASAN, in > each source code. This moves those #ifdef dependencies > into Kconfig,

[PATCH 2/2] init/main.c: Fixes quoted string split across lines & missing blank line after declaration

2017-07-27 Thread janani-sankarababu
Signed-off-by: Janani S --- init/main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/init/main.c b/init/main.c index f8eb4966..920b829 100644 --- a/init/main.c +++ b/init/main.c @@ -176,6 +176,7 @@ static bool __init obsolete_checksetup(char *line) p = __setup_s

Re: [RFC PATCH 3/3] mm: shm: Use new hugetlb size encoding definitions

2017-07-27 Thread Michal Hocko
On Thu 27-07-17 14:18:11, Mike Kravetz wrote: > On 07/27/2017 12:50 AM, Michal Hocko wrote: > > On Wed 26-07-17 10:39:30, Mike Kravetz wrote: > >> On 07/26/2017 03:07 AM, Michal Hocko wrote: > >>> On Wed 26-07-17 11:53:38, Michal Hocko wrote: > On Mon 17-07-17 15:28:01, Mike Kravetz wrote: > >

Re: [PATCH 2/4] KVM: VMX: avoid double list add with VT-d posted interrupts

2017-07-27 Thread Paolo Bonzini
On 28/07/2017 04:31, Longpeng (Mike) wrote: > Hi Paolo, > > On 2017/6/6 18:57, Paolo Bonzini wrote: > >> In some cases, for example involving hot-unplug of assigned >> devices, pi_post_block can forget to remove the vCPU from the >> blocked_vcpu_list. When this happens, the next call to >> pi_pr

Re: [PATCH v1 2/2] acpi, x86: Remove encryption mask from ACPI page protection type

2017-07-27 Thread Ingo Molnar
* Tom Lendacky wrote: > > > + * in memory in an encrypted state so return a protection attribute > > > + * that does not have the encryption bit set. > > >*/ > > > - return PAGE_KERNEL; > > > + return sme_active() ? PAGE_KERNEL_IO : PAGE_KERNEL; > > > > Why isn't there a PAGE_KE

Re: [PATCH] mm, oom: allow oom reaper to race with exit_mmap

2017-07-27 Thread Michal Hocko
On Thu 27-07-17 16:55:59, Andrea Arcangeli wrote: > On Thu, Jul 27, 2017 at 08:50:24AM +0200, Michal Hocko wrote: > > Yes this will work and it won't depend on the oom_lock. But isn't it > > just more ugly than simply doing > > > > if (tsk_is_oom_victim) { > > down_write(&mm->mmap_

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-27 Thread Michael Ellerman
Jens Axboe writes: > On 07/27/2017 08:47 AM, Bart Van Assche wrote: >> On Thu, 2017-07-27 at 08:02 -0600, Jens Axboe wrote: >>> The bug looks like SCSI running the queue inline from IRQ >>> context, that's not a good idea. ... >> >> scsi_run_queue() works fine if no scheduler is configured. Addit

Re: [PATCH v2] qe: fix compile issue for arm64

2017-07-27 Thread Michael Ellerman
Zhao Qiang writes: > Signed-off-by: Zhao Qiang > --- > Changes for v2: > - include all Errata QE_General4 in #ifdef > > drivers/soc/fsl/qe/qe.c | 2 ++ > 1 file changed, 2 insertions(+) AFAICS this driver can only be built on PPC, what am I missing? config QUICC_ENGINE bool "Fre

[PATCH] init:main.c: Fixed issues in Block comments and removed braces in single statement if block

2017-07-27 Thread janani-sankarababu
Signed-off-by: Janani S --- init/main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/init/main.c b/init/main.c index 052481f..f8eb4966 100644 --- a/init/main.c +++ b/init/main.c @@ -181,7 +181,8 @@ static bool __init obsolete_checksetup(char *line)

[PATCH v6.1 4/7] drm/rockchip: vop: group vop registers

2017-07-27 Thread Mark Yao
Grouping the vop registers facilitates make register definition clearer, and also is useful for different vop reuse the same group register. Signed-off-by: Mark Yao Reviewed-by: Jeffy Chen --- Changes in v6.1 - fix Null pointer crash on vop_reg_set drivers/gpu/drm/rockchip/rockchip_drm_vop.c |

RE: [PATCH] cpufreq: x86: Make scaling_cur_freq behave more as expected

2017-07-27 Thread Doug Smythies
On 2017.07.27 17:13 Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > After commit f8475cef9008 "x86: use common aperfmperf_khz_on_cpu() to > calculate KHz using APERF/MPERF" the scaling_cur_freq policy attribute > in sysfs only behaves as expected on x86 with APERF/MPERF registers > availab

Re: [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios

2017-07-27 Thread Vivek Gautam
On Fri, Jul 28, 2017 at 2:30 AM, Stephen Boyd wrote: > On 07/26/2017 11:30 PM, Vivek Gautam wrote: >> Signed-off-by: Vivek Gautam >> --- >> arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 + >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi

Re: [PATCH] device property: Fix usecount for of_graph_get_port_parent()

2017-07-27 Thread Tony Lindgren
* Rob Herring [170727 15:19]: > On Thu, Jul 27, 2017 at 4:44 AM, Tony Lindgren wrote: > > --- a/drivers/of/property.c > > +++ b/drivers/of/property.c > > @@ -708,6 +708,15 @@ struct device_node *of_graph_get_port_parent(struct > > device_node *node) > > { > > unsigned int depth; > > > >

Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks

2017-07-27 Thread Viresh Kumar
On 27-07-17, 12:55, Saravana Kannan wrote: > Yes. Simplifying isn't always about number of lines of code. It's also about > abstraction. Having generic scheduler code care about HW details doesn't > seem nice. I can argue that even the policy->cpus field is also hardware specific, isn't it ? And w

Re: linux-next: Signed-off-by missing for commit in the renesas tree

2017-07-27 Thread Stephen Rothwell
Hi, On Fri, 28 Jul 2017 12:09:12 +0700 jmondi wrote: > > On Fri, Jul 28, 2017 at 09:21:08AM +1000, Stephen Rothwell wrote: > > > > Commit > > > > bb003371172f ("arm: dts: genmai: Add RIIC2 pin group") > > > > is missing a Signed-off-by from its committer. > > I do see my SOB in the patch I'v

Re: [PATCH V3] mm/madvise: Enable (soft|hard) offline of HugeTLB pages at PGD level

2017-07-27 Thread Anshuman Khandual
On 07/28/2017 06:19 AM, Mike Kravetz wrote: > On 05/16/2017 03:05 AM, Anshuman Khandual wrote: >> Though migrating gigantic HugeTLB pages does not sound much like real >> world use case, they can be affected by memory errors. Hence migration >> at the PGD level HugeTLB pages should be supported jus

Re: [PATCH V1 02/12] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other cleanup

2017-07-27 Thread kgunda
On 2017-07-28 05:30, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: This patch cleans up the following. - Rename the "pa" to "pmic_arb". - Rename the spmi_pmic_arb *dev to spmi_pmic_arb *pmic_arb. - Rename the pa_{read,write}_data() functions to pmic_arb_{read,write}_data(). - Rename channe

linux-next: Tree for Jul 28

2017-07-27 Thread Stephen Rothwell
Hi all, Changes since 20170727: Non-merge commits (relative to Linus' tree): 2843 2887 files changed, 101051 insertions(+), 48048 deletions(-) I have created today's linux-next tree at git://git.kernel.o

Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx

2017-07-27 Thread Krzysztof Kozlowski
On Fri, Jul 28, 2017 at 10:11:48AM +0530, Arvind Yadav wrote: > Hi, > > > On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote: > >The s3c_i2sv2_probe() only enabled iis clock. Missing prepare isn't > >probably fatal, because for SoC clocks this is usually no-op, but for > >correctness t

Re: [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

2017-07-27 Thread kgunda
On 2017-07-28 05:31, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Replace the writel_relaxed with __raw_writel to avoid byte swapping in pmic_arb_write_data() function. That way the code is independent of the CPU endianness. Signed-off-by: Kiran Gunda Reviewed-by: Stephen Boyd This also

Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function

2017-07-27 Thread kgunda
On 2017-07-28 06:48, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Clean up the pmic_arb_find_apid() by using the local variables to improve the code readability. Signed-off-by: Kiran Gunda --- Reviewed-by: Stephen Boyd One nit below: break; re

Re: [PATCH V1 05/12] spmi: pmic-arb: fix memory allocation for mapping_table

2017-07-27 Thread kgunda
On 2017-07-28 05:19, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Allocate the correct memory size (max_pmic_peripherals) for the mapping_table that holds the apid to ppid mapping. Also use a local variable for mapping_table for better alignment of the code. Signed-off-by: Kiran Gunda Th

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-27 Thread Viresh Kumar
+ IMX maintainers. On 27-07-17, 19:54, Leonard Crestez wrote: > On Wed, 2017-07-26 at 11:36 +0530, Viresh Kumar wrote: > > - Find how much time does it really take to change the frequency of > >   the CPU. I don't really thing 109 us is the right transition > >   latency. Use attached patch for t

Re: [PATCH 3/4] KVM: VMX: simplify and fix vmx_vcpu_pi_load

2017-07-27 Thread Longpeng (Mike)
On 2017/7/28 12:22, Longpeng (Mike) wrote: > > > On 2017/6/6 18:57, Paolo Bonzini wrote: > >> The simplify part: do not touch pi_desc.nv, we can set it when the >> VCPU is first created. Likewise, pi_desc.sn is only handled by >> vmx_vcpu_pi_load, do not touch it in __pi_post_block. >> >> Th

Re: strace-4.18 test suite oopses sparc64 4.12 and 4.13-rc kernels

2017-07-27 Thread David Miller
From: Mikael Pettersson Date: Thu, 27 Jul 2017 21:45:25 +0200 > Attempting to build strace-4.18 as sparcv9 code and run its test suite > on a sparc64 machine (Sun Blade 2500 w/ 2 x USIIIi in my case) fails > reliably in three test cases (sched.gen, sched_xetattr.gen, and poll) > because two test

Re: linux-next: Signed-off-by missing for commit in the renesas tree

2017-07-27 Thread jmondi
Hi Simon, On Fri, Jul 28, 2017 at 09:21:08AM +1000, Stephen Rothwell wrote: > Hi Simon, > > Commit > > bb003371172f ("arm: dts: genmai: Add RIIC2 pin group") > > is missing a Signed-off-by from its committer. I do see my SOB in the patch I've sent. Any chance it has been dropped while applying

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-27 Thread Kurt Van Dijck
> > On 07/27/2017 01:47 PM, Oliver Hartkopp wrote: > > On 07/26/2017 08:29 PM, Franklin S Cooper Jr wrote: > >> > > > >> I'm fine with switching to using bitrate instead of speed. Kurk was > >> originally the one that suggested to use the term arbitration and data > >> since thats how the spec r

Re: [PATCH v3/resubmit 1/3] staging: gs_fpgaboot: add buffer overflow checks

2017-07-27 Thread Greg Kroah-Hartman
On Wed, Jul 26, 2017 at 09:13:57PM -0400, Jacob von Chorus wrote: > Four fields in struct fpgaimage are char arrays of length MAX_STR (256). > The amount of data read into these buffers is controlled by a length > field in the bitstream file read from userspace. If a corrupt or > malicious firmware

Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

2017-07-27 Thread Greg Kroah-Hartman
On Thu, Jul 27, 2017 at 05:27:32PM +0300, Gilad Ben-Yossef wrote: > From: Suniel Mahesh > > It is recommended to use managed function devm_kzalloc, which > simplifies driver cleanup paths and driver code. > This patch does the following: > (a) replace kzalloc with devm_kzalloc. > (b) drop kfree()

Re: [PATCH 0/4] staging: ccree: coding style clean ups

2017-07-27 Thread Greg Kroah-Hartman
On Thu, Jul 27, 2017 at 01:43:14PM +0300, Gilad Ben-Yossef wrote: > Misc. coding style fixes for ccree driver. > > These are the missing patches that failed to apply two weeks ago, > rebased onto latest staging-next. > > By the way, I still do not understand why they failed to apply, > as they ap

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-27 Thread Greg KH
On Mon, Jul 24, 2017 at 10:08:37AM +0300, Dan Carpenter wrote: > I don't understand why greybus has to be special instead of the same as > everything else. Who cares about this stuff really? Just do whatever > is easiest and most common. It's not special, and --strict should apply here as long a

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-27 Thread Greg KH
On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > Alignment should match with open parenthesis. > This fixes the coding style issue. > > Signed-off-by: Shreeya Patel > --- > drivers/staging/greybus/tools/loopback_test.c | 35 > --- > 1 file changed, 16 ins

Re: [PATCH V3 2/9] cpufreq: Use transition_delay_us for legacy governors as well

2017-07-27 Thread Viresh Kumar
On 24-07-17, 18:17, Peter Zijlstra wrote: > On Wed, Jul 19, 2017 at 03:42:42PM +0530, Viresh Kumar wrote: > > The policy->transition_delay_us field is used only by the schedutil > > governor currently, and this field describes how fast the driver wants > > the cpufreq governor to change CPUs freque

Re: Possible race in hysdn.ko

2017-07-27 Thread isdn
Hello Anton, first of all, this code was developed by other people and I never managed to get one of these cards - so I do not know so much about this driver at all. Unfortunately the firm behind hysdn do not longer exist and was taken over by Hermstedt AG years ago and even Hermstedt AG is not lo

Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx

2017-07-27 Thread Arvind Yadav
Hi, On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote: The s3c_i2sv2_probe() only enabled iis clock. Missing prepare isn't probably fatal, because for SoC clocks this is usually no-op, but for correctness this clock should be prepared. Signed-off-by: Krzysztof Kozlowski --- Chan

Re: [PATCH V4 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-07-27 Thread Leon Romanovsky
On Thu, Jul 27, 2017 at 11:44:32PM +, Salil Mehta wrote: > Hi Leon > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > > Sent: Sunday, July 23, 2017 2:16 PM > > To: Salil Mehta > > Cc: da...@da

Re: [RFT v2 1/3] ASoC: samsung: Fix possible double iounmap on s3c24xx driver probe failure

2017-07-27 Thread Arvind Yadav
On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote: Commit 87b132bc0315 ("ASoC: samsung: s3c24{xx,12}-i2s: port to use generic dmaengine API") moved ioremap() call from s3c-i2s-v2.c:s3c_i2sv2_probe() to s3c2412-i2s.c:s3c2412_iis_dev_probe() and converted it to devm- resource managed i

Re: [PATCH V8 3/3] powernv: Add support to clear sensor groups data

2017-07-27 Thread Cyril Bur
On Wed, 2017-07-26 at 10:35 +0530, Shilpasri G Bhat wrote: > Adds support for clearing different sensor groups. OCC inband sensor > groups like CSM, Profiler, Job Scheduler can be cleared using this > driver. The min/max of all sensors belonging to these sensor groups > will be cleared. > Hi Shil

Re: [PATCH] staging: unisys: visorchipset: constify attribute_group structure

2017-07-27 Thread Greg KH
On Wed, Jul 26, 2017 at 09:51:32PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. > > File size before: > text data bss dec

Re: [PATCH] staging: unisys: visorbus_main: constify attribute_group structures

2017-07-27 Thread Greg KH
On Tue, Jul 25, 2017 at 06:45:52PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. > > File size before: > text data bss dec

Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks

2017-07-27 Thread Joel Fernandes (Google)
On Thu, Jul 27, 2017 at 12:55 PM, Saravana Kannan wrote: > On 07/26/2017 08:30 PM, Viresh Kumar wrote: >> >> On 26-07-17, 14:00, Saravana Kannan wrote: >>> >>> No, the alternative is to pass it on to the CPU freq driver and let it >>> decide what it wants to do. That's the whole point if having a

Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

2017-07-27 Thread Suniel Mahesh
On Friday 28 July 2017 01:18 AM, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 05:27:33PM +0300, Gilad Ben-Yossef wrote: >> +new_drvdata->cc_base = devm_ioremap_resource(&plat_dev->dev, >> + req_mem_cc_regs); >> +if (IS_ERR(new_drvdata->cc_ba

Re: [PATCH 3.10] pstore: Make spinlock per zone instead of global

2017-07-27 Thread Willy Tarreau
Hi Leo, There was no upstream commit ID here but I found it in mainline here : commit 109704492ef637956265ec2eb72ae7b3b39eb6f4 Author: Joel Fernandes Date: Thu Oct 20 00:34:00 2016 -0700 pstore: Make spinlock per zone instead of global What worries me is that some later fixes w

Re: [PATCH 3/4] KVM: VMX: simplify and fix vmx_vcpu_pi_load

2017-07-27 Thread Longpeng (Mike)
On 2017/6/6 18:57, Paolo Bonzini wrote: > The simplify part: do not touch pi_desc.nv, we can set it when the > VCPU is first created. Likewise, pi_desc.sn is only handled by > vmx_vcpu_pi_load, do not touch it in __pi_post_block. > > The fix part: do not check kvm_arch_has_assigned_device, ins

Re: [PATCH V8 2/3] powernv: Add support to set power-shifting-ratio

2017-07-27 Thread Cyril Bur
On Wed, 2017-07-26 at 10:35 +0530, Shilpasri G Bhat wrote: > This patch adds support to set power-shifting-ratio for CPU-GPU which > is used by OCC power capping algorithm. > > Signed-off-by: Shilpasri G Bhat Hi Shilpasri, I started looking though this - a lot the comments to patch 1/3 apply h

Re: [PATCH V8 1/3] powernv: powercap: Add support for powercap framework

2017-07-27 Thread Shilpasri G Bhat
Hi Cyril, On 07/28/2017 07:09 AM, Cyril Bur wrote: > Is there any reason that pcap_attrs needs to be contiguous? If not, I > feel like you could eliminate the entire loop below (and the last one > as well maybe) and just do the assignment of pattr_groups[].attrs[] up > there. > > In fact do you e

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Michael S. Tsirkin
On Fri, Jul 28, 2017 at 11:50:45AM +0800, Jason Wang wrote: > > > On 2017年07月28日 11:46, Michael S. Tsirkin wrote: > > On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > > > + if (old_prog) > > > > > + bpf_p

Re: [PATCH v8 09/13] iommu/amd: Use is_attach_deferred call-back

2017-07-27 Thread Baoquan He
On 07/27/17 at 05:53pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:07PM +0800, Baoquan He wrote: > > +static bool amd_iommu_is_attach_deferred(struct iommu_domain *domain, > > +struct device *dev) > > +{ > > + struct iommu_dev_data *dev_data = dev->arc

Re: [PATCH v8 05/13] iommu/amd: Add function copy_dev_tables()

2017-07-27 Thread Baoquan He
On 07/27/17 at 05:29pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:03PM +0800, Baoquan He wrote: > > Add function copy_dev_tables to copy the old DEV table entries of the > > panicked > > Since there is only one (for now), you can name the function in > singular: copy_dev_table() or copy

Fwd: trinity test fanotify cause hungtasks on kernel 4.13

2017-07-27 Thread Gu Zheng
hi,ALL: when we used the trinity test the fanotify interfaces, it cause many hungtasks. CONFIG_FANOTIFY_ACCESS_PERMISSIONS=y the shell is simple: 1 #!/bin/bash 2 3 while true 4 do 5 ./trinity -c fanotify_init -l off -C 2 -X > /dev/null 2>&1 & 6 sleep 1 7 ./trinity -c fanotify_mark

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Jakub Kicinski
On Fri, 28 Jul 2017 06:46:40 +0300, Michael S. Tsirkin wrote: > On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > > + if (old_prog) > > > > + bpf_prog_put(old_prog); > > > > + rcu_assign_pointer(tu

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Jason Wang
On 2017年07月28日 11:46, Michael S. Tsirkin wrote: On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: + old_prog = rtnl_dereference(tun->xdp_prog); + if (old_prog) + bpf_prog_put(old_prog); + rcu_assign_pointer(tun->xdp_prog, prog); Is this OK? Could thi

Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver

2017-07-27 Thread Anup Patel
On Fri, Jul 28, 2017 at 8:43 AM, Vinod Koul wrote: > On Thu, Jul 27, 2017 at 09:42:33AM +0530, Anup Patel wrote: >> On Wed, Jul 26, 2017 at 10:39 PM, Vinod Koul wrote: >> > On Wed, Jul 26, 2017 at 11:06:39AM +0530, Anup Patel wrote: > >> >> drivers/dma/bcm-sba-raid.c | 439 >> >> +++

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Michael S. Tsirkin
On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > + if (old_prog) > > > + bpf_prog_put(old_prog); > > > + rcu_assign_pointer(tun->xdp_prog, prog); > > Is this OK? Could this lead to the program getting freed and then > > d

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

2017-07-27 Thread Joel Fernandes (Google)
On Thu, Jul 27, 2017 at 12:21 AM, Juri Lelli wrote: [..] >> > >> > But even without that, if you see the routine >> > init_entity_runnable_average() in fair.c, the new tasks are >> > initialized in a way that they are seen as heavy tasks. And so even >> > for the first time they run, freq should n

Re: [PATCH 2/6] dma: bcm-sba-raid: Peek mbox when we are left with no free requests

2017-07-27 Thread Anup Patel
On Fri, Jul 28, 2017 at 8:45 AM, Vinod Koul wrote: > On Thu, Jul 27, 2017 at 10:25:25AM +0530, Anup Patel wrote: >> On Wed, Jul 26, 2017 at 10:40 PM, Vinod Koul wrote: >> > On Wed, Jul 26, 2017 at 11:06:40AM +0530, Anup Patel wrote: >> >> We should peek mbox channels when we are left with no free

Re: [Eas-dev] [PATCH V4 1/3] sched: cpufreq: Allow remote cpufreq callbacks

2017-07-27 Thread Joel Fernandes (Google)
On Thu, Jul 27, 2017 at 12:14 AM, Viresh Kumar wrote: > On 26-07-17, 23:13, Joel Fernandes (Google) wrote: >> On Wed, Jul 26, 2017 at 10:50 PM, Viresh Kumar >> wrote: >> > On 26-07-17, 22:34, Joel Fernandes (Google) wrote: >> >> On Wed, Jul 26, 2017 at 2:22 AM, Viresh Kumar >> >> wrote: >> >>

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Jason Wang
On 2017年07月28日 11:13, Jakub Kicinski wrote: On Thu, 27 Jul 2017 17:25:33 +0800, Jason Wang wrote: This patch tries to implement XDP for tun. The implementation was split into two parts: - fast path: small and no gso packet. We try to do XDP at page level before build_skb(). For XDP_TX, sin

Re: [PATCH v2] net: inet: diag: expose sockets cgroup classid

2017-07-27 Thread Jakub Kicinski
On Thu, 27 Jul 2017 18:11:32 +, Levin, Alexander (Sasha Levin) wrote: > This is useful for directly looking up a task based on class id rather than > having to scan through all open file descriptors. > > Signed-off-by: Sasha Levin > --- > > Changes in V2: > - Addressed comments from Cong Wa

Re: [PATCH tip/core/rcu 07/15] rcu: Add event tracing to ->gp_tasks update at GP start

2017-07-27 Thread Paul E. McKenney
On Thu, Jul 27, 2017 at 09:38:10PM -0400, Steven Rostedt wrote: > On Mon, 24 Jul 2017 14:44:36 -0700 > "Paul E. McKenney" wrote: > > > There is currently event tracing to track when a task is preempted > > within a preemptible RCU read-side critical section, and also when that > > task subsequent

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-27 Thread Jakub Kicinski
On Thu, 27 Jul 2017 17:25:33 +0800, Jason Wang wrote: > This patch tries to implement XDP for tun. The implementation was > split into two parts: > > - fast path: small and no gso packet. We try to do XDP at page level > before build_skb(). For XDP_TX, since creating/destroying queues > were c

Re: [PATCH 2/6] dma: bcm-sba-raid: Peek mbox when we are left with no free requests

2017-07-27 Thread Vinod Koul
On Thu, Jul 27, 2017 at 10:25:25AM +0530, Anup Patel wrote: > On Wed, Jul 26, 2017 at 10:40 PM, Vinod Koul wrote: > > On Wed, Jul 26, 2017 at 11:06:40AM +0530, Anup Patel wrote: > >> We should peek mbox channels when we are left with no free > >> sba_requests in sba_alloc_request() > > > > and why

Re: [PATCH Y.A. RESEND] MAINTAINERS: fix alpha. ordering

2017-07-27 Thread Joe Perches
On Thu, 2017-07-27 at 19:43 -0700, Linus Torvalds wrote: > On Thu, Jul 27, 2017 at 5:30 PM, Joe Perches wrote: > > > > Maybe add a reordering of the patterns so that each pattern list > > is in a specific order too > > I don't think this is wrong per se, but I'm not sure I want to get > into the

Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver

2017-07-27 Thread Vinod Koul
On Thu, Jul 27, 2017 at 09:42:33AM +0530, Anup Patel wrote: > On Wed, Jul 26, 2017 at 10:39 PM, Vinod Koul wrote: > > On Wed, Jul 26, 2017 at 11:06:39AM +0530, Anup Patel wrote: > >> drivers/dma/bcm-sba-raid.c | 439 > >> +++-- > >> 1 file changed, 226 in

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-07-27 Thread Ding Tianhong
On 2017/7/28 1:49, Alexander Duyck wrote: > On Wed, Jul 26, 2017 at 6:08 PM, Ding Tianhong > wrote: >> >> >> On 2017/7/27 2:26, Casey Leedom wrote: >>> By the way Ding, two issues: >>> >>> 1. Did we ever get any acknowledgement from either Intel or AMD >>> on this patch? I know that we

  1   2   3   4   5   6   7   8   9   >