Re: Question about bh1770glc.ko

2017-08-08 Thread Greg KH
On Tue, Aug 08, 2017 at 03:46:18PM +0300, Anton Volkov wrote: > Hello. > > In drivers/misc/bh1770glc.c several functions have comments stating that > they must be called under lock protection, e.g. bh1770_prox_mode_control, > bh1770_lux_interrupt_control, bh1770_lux_rate, bh1770_chip_on. However

Re: Question about bh1770glc.ko

2017-08-08 Thread Greg KH
On Tue, Aug 08, 2017 at 03:46:18PM +0300, Anton Volkov wrote: > Hello. > > In drivers/misc/bh1770glc.c several functions have comments stating that > they must be called under lock protection, e.g. bh1770_prox_mode_control, > bh1770_lux_interrupt_control, bh1770_lux_rate, bh1770_chip_on. However

Re: scsi: hisi_sas: replace kfree with scsi_host_put

2017-08-08 Thread John Garry
On 08/08/2017 12:37, Pan Bian wrote: Return value of scsi_host_alloc() should be released with scsi_host_put() rather than kfree(). Signed-off-by: Pan Bian We also have a kfree(shost) in newly added pci-based v3 driver which would need replacing for consistency. But,

Re: scsi: hisi_sas: replace kfree with scsi_host_put

2017-08-08 Thread John Garry
On 08/08/2017 12:37, Pan Bian wrote: Return value of scsi_host_alloc() should be released with scsi_host_put() rather than kfree(). Signed-off-by: Pan Bian We also have a kfree(shost) in newly added pci-based v3 driver which would need replacing for consistency. But, apart from that, we

Re: [PATCH v4 00/21] Qualcomm 8x16 Camera Subsystem driver

2017-08-08 Thread Sakari Ailus
On Tue, Aug 08, 2017 at 04:29:57PM +0300, Todor Tomov wrote: > This patchset adds basic support for the Qualcomm Camera Subsystem found > on Qualcomm MSM8916 and APQ8016 processors. > > The driver implements V4L2, Media controller and V4L2 subdev interfaces. > Camera sensor using V4L2 subdev

Re: [PATCH v4 00/21] Qualcomm 8x16 Camera Subsystem driver

2017-08-08 Thread Sakari Ailus
On Tue, Aug 08, 2017 at 04:29:57PM +0300, Todor Tomov wrote: > This patchset adds basic support for the Qualcomm Camera Subsystem found > on Qualcomm MSM8916 and APQ8016 processors. > > The driver implements V4L2, Media controller and V4L2 subdev interfaces. > Camera sensor using V4L2 subdev

media: mtk-mdp: use IS_ERR to check return value of of_clk_get

2017-08-08 Thread Pan Bian
Function of_clk_get() returns an ERR_PTR on failures. In file mtk_mdp_commp.c, its return value is checked against NULL. Such checks cannot prevent from accessing bad memory. This patch replaces the NULL checks with IS_ERR checks. Signed-off-by: Pan Bian ---

media: mtk-mdp: use IS_ERR to check return value of of_clk_get

2017-08-08 Thread Pan Bian
Function of_clk_get() returns an ERR_PTR on failures. In file mtk_mdp_commp.c, its return value is checked against NULL. Such checks cannot prevent from accessing bad memory. This patch replaces the NULL checks with IS_ERR checks. Signed-off-by: Pan Bian ---

Re: [PATCH v4 09/21] media: camss: Add files which handle the video device nodes

2017-08-08 Thread Sakari Ailus
Hi Todor, On Tue, Aug 08, 2017 at 04:30:06PM +0300, Todor Tomov wrote: ... > +static int video_start_streaming(struct vb2_queue *q, unsigned int count) > +{ > + struct camss_video *video = vb2_get_drv_priv(q); > + struct video_device *vdev = >vdev; > + struct media_entity *entity; > +

Re: [PATCH v4 09/21] media: camss: Add files which handle the video device nodes

2017-08-08 Thread Sakari Ailus
Hi Todor, On Tue, Aug 08, 2017 at 04:30:06PM +0300, Todor Tomov wrote: ... > +static int video_start_streaming(struct vb2_queue *q, unsigned int count) > +{ > + struct camss_video *video = vb2_get_drv_priv(q); > + struct video_device *vdev = >vdev; > + struct media_entity *entity; > +

[PATCH 3/3 v2] thermal: core: Fix resources release in error paths in thermal_zone_device_register()

2017-08-08 Thread Christophe JAILLET
Reorder error handling code in order to fix some resources leaks in some cases: - 'tz' would leak if 'thermal_zone_create_device_groups()' fails - memory allocated by 'thermal_zone_create_device_groups()' would leak if 'device_register()' fails With this patch, we now have 2 error

[PATCH 3/3 v2] thermal: core: Fix resources release in error paths in thermal_zone_device_register()

2017-08-08 Thread Christophe JAILLET
Reorder error handling code in order to fix some resources leaks in some cases: - 'tz' would leak if 'thermal_zone_create_device_groups()' fails - memory allocated by 'thermal_zone_create_device_groups()' would leak if 'device_register()' fails With this patch, we now have 2 error

[PATCH 1/3 v2] thermal: core: Add some new helper functions to free resources

2017-08-08 Thread Christophe JAILLET
In order to easily free resources allocated by 'thermal_zone_create_device_groups()' we need 2 new helper functions. The first one undoes 'thermal_zone_create_device_groups()'. The 2nd one undoes 'create_trip_attrs()', which is a function called by 'thermal_zone_create_device_groups()'.

[PATCH 1/3 v2] thermal: core: Add some new helper functions to free resources

2017-08-08 Thread Christophe JAILLET
In order to easily free resources allocated by 'thermal_zone_create_device_groups()' we need 2 new helper functions. The first one undoes 'thermal_zone_create_device_groups()'. The 2nd one undoes 'create_trip_attrs()', which is a function called by 'thermal_zone_create_device_groups()'.

[PATCH 2/3 v2] thermal: core: Use the new 'thermal_zone_destroy_device_groups()' helper function

2017-08-08 Thread Christophe JAILLET
Simplify code by using the new 'thermal_zone_destroy_device_groups()' helper function. Signed-off-by: Christophe JAILLET --- drivers/thermal/thermal_core.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/thermal/thermal_core.c

[PATCH 2/3 v2] thermal: core: Use the new 'thermal_zone_destroy_device_groups()' helper function

2017-08-08 Thread Christophe JAILLET
Simplify code by using the new 'thermal_zone_destroy_device_groups()' helper function. Signed-off-by: Christophe JAILLET --- drivers/thermal/thermal_core.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c

[PATCH 0/3 v2] thermal: core: Fix some error handling code in 'thermal_zone_device_register()'

2017-08-08 Thread Christophe JAILLET
These patches fix some issue in the error handling path in 'thermal_zone_device_register()' The first patch adds some new helper function in order to ease the resource management. Maybe using devm_ variant could also be a better choise to free manage these resources. As it would be a bigger

[PATCH 0/3 v2] thermal: core: Fix some error handling code in 'thermal_zone_device_register()'

2017-08-08 Thread Christophe JAILLET
These patches fix some issue in the error handling path in 'thermal_zone_device_register()' The first patch adds some new helper function in order to ease the resource management. Maybe using devm_ variant could also be a better choise to free manage these resources. As it would be a bigger

Re: scsi: mvsas: replace kfree with scsi_host_put

2017-08-08 Thread Jinpu Wang
On Tue, Aug 8, 2017 at 2:02 PM, Pan Bian wrote: > The return value of scsi_host_alloc() should be released by > scsi_host_put(). However, in function mvs_pci_init(), kfree() > is used. This patch replaces kfree() with scsi_host_put() to avoid > possible memory leaks. > >

Re: scsi: mvsas: replace kfree with scsi_host_put

2017-08-08 Thread Jinpu Wang
On Tue, Aug 8, 2017 at 2:02 PM, Pan Bian wrote: > The return value of scsi_host_alloc() should be released by > scsi_host_put(). However, in function mvs_pci_init(), kfree() > is used. This patch replaces kfree() with scsi_host_put() to avoid > possible memory leaks. > > Signed-off-by: Pan Bian

[PATCH 01/16] mm: Dont assume page-table invariance during faults

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra One of the side effects of speculating on faults (without holding mmap_sem) is that we can race with free_pgtables() and therefore we cannot assume the page-tables will stick around. Remove the reliance on the pte pointer. Signed-off-by: Peter

[PATCH 01/16] mm: Dont assume page-table invariance during faults

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra One of the side effects of speculating on faults (without holding mmap_sem) is that we can race with free_pgtables() and therefore we cannot assume the page-tables will stick around. Remove the reliance on the pte pointer. Signed-off-by: Peter Zijlstra (Intel) ---

[PATCH 04/16] mm: VMA sequence count

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra Wrap the VMA modifications (vma_adjust/unmap_page_range) with sequence counts such that we can easily test if a VMA is changed. The unmap_page_range() one allows us to make assumptions about page-tables; when we find the seqcount hasn't changed we can

[PATCH 04/16] mm: VMA sequence count

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra Wrap the VMA modifications (vma_adjust/unmap_page_range) with sequence counts such that we can easily test if a VMA is changed. The unmap_page_range() one allows us to make assumptions about page-tables; when we find the seqcount hasn't changed we can assume page-tables are

[PATCH 05/16] mm: Protect VMA modifications using VMA sequence count

2017-08-08 Thread Laurent Dufour
The VMA sequence count has been introduced to allow fast detection of VMA modification when running a page fault handler without holding the mmap_sem. This patch provides protection agains the VMA modification done in : - madvise() - mremap() - mpol_rebind_policy()

[PATCH 05/16] mm: Protect VMA modifications using VMA sequence count

2017-08-08 Thread Laurent Dufour
The VMA sequence count has been introduced to allow fast detection of VMA modification when running a page fault handler without holding the mmap_sem. This patch provides protection agains the VMA modification done in : - madvise() - mremap() - mpol_rebind_policy()

[PATCH 03/16] mm: Introduce pte_spinlock for FAULT_FLAG_SPECULATIVE

2017-08-08 Thread Laurent Dufour
When handling page fault without holding the mmap_sem the fetch of the pte lock pointer and the locking will have to be done while ensuring that the VMA is not touched in our back. So move the fetch and locking operations in a dedicated function. Signed-off-by: Laurent Dufour

[PATCH 03/16] mm: Introduce pte_spinlock for FAULT_FLAG_SPECULATIVE

2017-08-08 Thread Laurent Dufour
When handling page fault without holding the mmap_sem the fetch of the pte lock pointer and the locking will have to be done while ensuring that the VMA is not touched in our back. So move the fetch and locking operations in a dedicated function. Signed-off-by: Laurent Dufour --- mm/memory.c |

[PATCH 06/16] mm: RCU free VMAs

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra Manage the VMAs with SRCU such that we can do a lockless VMA lookup. We put the fput(vma->vm_file) in the SRCU callback, this keeps files valid during speculative faults, this is possible due to the delayed fput work by Al Viro -- do we need

[PATCH 06/16] mm: RCU free VMAs

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra Manage the VMAs with SRCU such that we can do a lockless VMA lookup. We put the fput(vma->vm_file) in the SRCU callback, this keeps files valid during speculative faults, this is possible due to the delayed fput work by Al Viro -- do we need srcu_barrier() in unmount

Re: firmware: vpd: use memunmap instead of iounmap

2017-08-08 Thread Guenter Roeck
On Tue, Aug 8, 2017 at 5:45 AM, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() is better. > > Signed-off-by: Pan Bian The code uses memremap(), so that

Re: firmware: vpd: use memunmap instead of iounmap

2017-08-08 Thread Guenter Roeck
On Tue, Aug 8, 2017 at 5:45 AM, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() is better. > > Signed-off-by: Pan Bian The code uses memremap(), so that seems reasonable. Reviewed-by: Guenter

[PATCH 08/16] mm: Try spin lock in speculative path

2017-08-08 Thread Laurent Dufour
There is a deadlock when a CPU is doing a speculative page fault and another one is calling do_unmap(). The deadlock occurred because the speculative path try to spinlock the pte while the interrupt are disabled. When the other CPU in the unmap's path has locked the pte then is waiting for all

[PATCH 08/16] mm: Try spin lock in speculative path

2017-08-08 Thread Laurent Dufour
There is a deadlock when a CPU is doing a speculative page fault and another one is calling do_unmap(). The deadlock occurred because the speculative path try to spinlock the pte while the interrupt are disabled. When the other CPU in the unmap's path has locked the pte then is waiting for all

[PATCH 07/16] mm: Provide speculative fault infrastructure

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra Provide infrastructure to do a speculative fault (not holding mmap_sem). The not holding of mmap_sem means we can race against VMA change/removal and page-table destruction. We use the SRCU VMA freeing to keep the VMA around. We use the VMA seqcount to

[PATCH 07/16] mm: Provide speculative fault infrastructure

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra Provide infrastructure to do a speculative fault (not holding mmap_sem). The not holding of mmap_sem means we can race against VMA change/removal and page-table destruction. We use the SRCU VMA freeing to keep the VMA around. We use the VMA seqcount to detect change

[PATCH 09/16] x86/mm: Add speculative pagefault handling

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra Try a speculative fault before acquiring mmap_sem, if it returns with VM_FAULT_RETRY continue with the mmap_sem acquisition and do the traditional fault. Signed-off-by: Peter Zijlstra (Intel) [Clearing of FAULT_FLAG_ALLOW_RETRY

[PATCH 09/16] x86/mm: Add speculative pagefault handling

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra Try a speculative fault before acquiring mmap_sem, if it returns with VM_FAULT_RETRY continue with the mmap_sem acquisition and do the traditional fault. Signed-off-by: Peter Zijlstra (Intel) [Clearing of FAULT_FLAG_ALLOW_RETRY is now done in handle_speculative_fault()]

[PATCH 11/16] mm: Introduce __page_add_new_anon_rmap()

2017-08-08 Thread Laurent Dufour
When dealing with speculative page fault handler, we may race with VMA being split or merged. In this case the vma->vm_start and vm->vm_end fields may not match the address the page fault is occurring. This can only happens when the VMA is split but in that case, the anon_vma pointer of the new

[PATCH 11/16] mm: Introduce __page_add_new_anon_rmap()

2017-08-08 Thread Laurent Dufour
When dealing with speculative page fault handler, we may race with VMA being split or merged. In this case the vma->vm_start and vm->vm_end fields may not match the address the page fault is occurring. This can only happens when the VMA is split but in that case, the anon_vma pointer of the new

[PATCH 10/16] powerpc/mm: Add speculative page fault

2017-08-08 Thread Laurent Dufour
This patch enable the speculative page fault on the PowerPC architecture. This will try a speculative page fault without holding the mmap_sem, if it returns with WM_FAULT_RETRY, the mmap_sem is acquired and the traditional page fault processing is done. Signed-off-by: Laurent Dufour

[PATCH 13/16] perf: Add a speculative page fault sw events

2017-08-08 Thread Laurent Dufour
Add new software events to count succeeded and failed speculative page faults. Signed-off-by: Laurent Dufour --- include/uapi/linux/perf_event.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h

[PATCH 10/16] powerpc/mm: Add speculative page fault

2017-08-08 Thread Laurent Dufour
This patch enable the speculative page fault on the PowerPC architecture. This will try a speculative page fault without holding the mmap_sem, if it returns with WM_FAULT_RETRY, the mmap_sem is acquired and the traditional page fault processing is done. Signed-off-by: Laurent Dufour ---

[PATCH 13/16] perf: Add a speculative page fault sw events

2017-08-08 Thread Laurent Dufour
Add new software events to count succeeded and failed speculative page faults. Signed-off-by: Laurent Dufour --- include/uapi/linux/perf_event.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h index

[PATCH 14/16] x86/mm: Add support for SPF events

2017-08-08 Thread Laurent Dufour
Add support for the new speculative page faults software events. Signed-off-by: Laurent Dufour --- arch/x86/mm/fault.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index 46fb9c2a832d..17985f11b9da

mtd: nand: use dma_mapping_error to check map errors

2017-08-08 Thread Pan Bian
The return value of dma_map_single() should be checked by dma_mapping_error(). However, in function flctl_dma_fifo0_transfer(), its return value is checked against NULL, which could result in failures. Signed-off-by: Pan Bian --- drivers/mtd/nand/sh_flctl.c | 2 +- 1 file

[PATCH 14/16] x86/mm: Add support for SPF events

2017-08-08 Thread Laurent Dufour
Add support for the new speculative page faults software events. Signed-off-by: Laurent Dufour --- arch/x86/mm/fault.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index 46fb9c2a832d..17985f11b9da 100644 ---

mtd: nand: use dma_mapping_error to check map errors

2017-08-08 Thread Pan Bian
The return value of dma_map_single() should be checked by dma_mapping_error(). However, in function flctl_dma_fifo0_transfer(), its return value is checked against NULL, which could result in failures. Signed-off-by: Pan Bian --- drivers/mtd/nand/sh_flctl.c | 2 +- 1 file changed, 1

[PATCH 15/16] powerpc/mm: Add support for SPF events

2017-08-08 Thread Laurent Dufour
Add support for the new speculative page faults software events. Signed-off-by: Laurent Dufour --- arch/powerpc/mm/fault.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c index

[PATCH 15/16] powerpc/mm: Add support for SPF events

2017-08-08 Thread Laurent Dufour
Add support for the new speculative page faults software events. Signed-off-by: Laurent Dufour --- arch/powerpc/mm/fault.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c index c6cd40901dd0..112c4bc9da70 100644 ---

[PATCH 12/16] mm: Protect SPF handler against anon_vma changes

2017-08-08 Thread Laurent Dufour
The speculative page fault handler must be protected against anon_vma changes. This is because page_add_new_anon_rmap() is called during the speculative path. In addition, don't try speculative page fault if the VMA don't have an anon_vma structure allocated because its allocation should be

[PATCH 12/16] mm: Protect SPF handler against anon_vma changes

2017-08-08 Thread Laurent Dufour
The speculative page fault handler must be protected against anon_vma changes. This is because page_add_new_anon_rmap() is called during the speculative path. In addition, don't try speculative page fault if the VMA don't have an anon_vma structure allocated because its allocation should be

[PATCH 16/16] perf tools: Add support for SPF events

2017-08-08 Thread Laurent Dufour
Add support for the new speculative faults events. Signed-off-by: Laurent Dufour --- tools/include/uapi/linux/perf_event.h | 2 ++ tools/perf/util/evsel.c | 2 ++ tools/perf/util/parse-events.c| 8 tools/perf/util/parse-events.l

[PATCH 16/16] perf tools: Add support for SPF events

2017-08-08 Thread Laurent Dufour
Add support for the new speculative faults events. Signed-off-by: Laurent Dufour --- tools/include/uapi/linux/perf_event.h | 2 ++ tools/perf/util/evsel.c | 2 ++ tools/perf/util/parse-events.c| 8 tools/perf/util/parse-events.l| 2 ++

[PATCH 00/16] Speculative page faults

2017-08-08 Thread Laurent Dufour
This is a port on kernel 4.13 of the work done by Peter Zijlstra to handle page fault without holding the mm semaphore [1]. The idea is to try to handle user space page faults without holding the mmap_sem. This should allow better concurrency for massively threaded process since the page fault

[PATCH 00/16] Speculative page faults

2017-08-08 Thread Laurent Dufour
This is a port on kernel 4.13 of the work done by Peter Zijlstra to handle page fault without holding the mm semaphore [1]. The idea is to try to handle user space page faults without holding the mmap_sem. This should allow better concurrency for massively threaded process since the page fault

[PATCH 02/16] mm: Prepare for FAULT_FLAG_SPECULATIVE

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra When speculating faults (without holding mmap_sem) we need to validate that the vma against which we loaded pages is still valid when we're ready to install the new PTE. Therefore, replace the pte_offset_map_lock() calls that (re)take the PTL with

[PATCH 02/16] mm: Prepare for FAULT_FLAG_SPECULATIVE

2017-08-08 Thread Laurent Dufour
From: Peter Zijlstra When speculating faults (without holding mmap_sem) we need to validate that the vma against which we loaded pages is still valid when we're ready to install the new PTE. Therefore, replace the pte_offset_map_lock() calls that (re)take the PTL with pte_map_lock() which can

Re: [PATCH] usb: gadget: f_uac2: calculate wMaxPacketSize before endpoint match

2017-08-08 Thread Sekhar Nori
On Tuesday 08 August 2017 07:50 PM, Roger Quadros wrote: > On 17/05/17 11:15, Sekhar Nori wrote: >> Calculate wMaxPacketSize before endpoint matching the >> descriptor is found. >> >> This allows audio gadget to be used with controllers >> which have a shortage or unavailability of endpoints >>

Re: [PATCH] usb: gadget: f_uac2: calculate wMaxPacketSize before endpoint match

2017-08-08 Thread Sekhar Nori
On Tuesday 08 August 2017 07:50 PM, Roger Quadros wrote: > On 17/05/17 11:15, Sekhar Nori wrote: >> Calculate wMaxPacketSize before endpoint matching the >> descriptor is found. >> >> This allows audio gadget to be used with controllers >> which have a shortage or unavailability of endpoints >>

Re: [PATCH] arm64: correct modules range of kernel virtual memory layout

2017-08-08 Thread Ard Biesheuvel
On 8 August 2017 at 15:18, Will Deacon wrote: > On Tue, Aug 08, 2017 at 03:04:55PM +0100, Ard Biesheuvel wrote: >> On 8 August 2017 at 14:19, Will Deacon wrote: >> > On Tue, Aug 08, 2017 at 01:27:25PM +0800, Miles Chen wrote: >> >> On Tue, 2017-08-08 at

Re: [PATCH] arm64: correct modules range of kernel virtual memory layout

2017-08-08 Thread Ard Biesheuvel
On 8 August 2017 at 15:18, Will Deacon wrote: > On Tue, Aug 08, 2017 at 03:04:55PM +0100, Ard Biesheuvel wrote: >> On 8 August 2017 at 14:19, Will Deacon wrote: >> > On Tue, Aug 08, 2017 at 01:27:25PM +0800, Miles Chen wrote: >> >> On Tue, 2017-08-08 at 12:44 +0800, Miles Chen wrote: >> >> >

Re: [PATCH 2/2] PCI: iproc: Add optional brcm,pci-hotplug

2017-08-08 Thread Rob Herring
Please send bindings to DT list. On Mon, Aug 7, 2017 at 11:44 PM, Oza Pawandeep wrote: > Add description for optional device tree property > 'brcm,pci-hotplug' for PCI hotplug feature. > > Signed-off-by: Oza Pawandeep > Reviewed-by: Ray Jui

Re: [PATCH 2/2] PCI: iproc: Add optional brcm,pci-hotplug

2017-08-08 Thread Rob Herring
Please send bindings to DT list. On Mon, Aug 7, 2017 at 11:44 PM, Oza Pawandeep wrote: > Add description for optional device tree property > 'brcm,pci-hotplug' for PCI hotplug feature. > > Signed-off-by: Oza Pawandeep > Reviewed-by: Ray Jui > > diff --git

Re: [PATCH] usb: gadget: f_uac2: calculate wMaxPacketSize before endpoint match

2017-08-08 Thread Roger Quadros
On 17/05/17 11:15, Sekhar Nori wrote: > Calculate wMaxPacketSize before endpoint matching the > descriptor is found. > > This allows audio gadget to be used with controllers > which have a shortage or unavailability of endpoints > that can handle max packet size of 1023 (FS) or 1024 > (HS). > >

Re: [PATCH] usb: gadget: f_uac2: calculate wMaxPacketSize before endpoint match

2017-08-08 Thread Roger Quadros
On 17/05/17 11:15, Sekhar Nori wrote: > Calculate wMaxPacketSize before endpoint matching the > descriptor is found. > > This allows audio gadget to be used with controllers > which have a shortage or unavailability of endpoints > that can handle max packet size of 1023 (FS) or 1024 > (HS). > >

Re: [PATCH] arm64: correct modules range of kernel virtual memory layout

2017-08-08 Thread Will Deacon
On Tue, Aug 08, 2017 at 03:04:55PM +0100, Ard Biesheuvel wrote: > On 8 August 2017 at 14:19, Will Deacon wrote: > > On Tue, Aug 08, 2017 at 01:27:25PM +0800, Miles Chen wrote: > >> On Tue, 2017-08-08 at 12:44 +0800, Miles Chen wrote: > >> > Agreed.MODULES_VADDR should be

Re: [PATCH] arm64: correct modules range of kernel virtual memory layout

2017-08-08 Thread Will Deacon
On Tue, Aug 08, 2017 at 03:04:55PM +0100, Ard Biesheuvel wrote: > On 8 August 2017 at 14:19, Will Deacon wrote: > > On Tue, Aug 08, 2017 at 01:27:25PM +0800, Miles Chen wrote: > >> On Tue, 2017-08-08 at 12:44 +0800, Miles Chen wrote: > >> > Agreed.MODULES_VADDR should be phased out. Considering

RE: [PATCH 1/2] ARM: shmobile: document iW-RainboW-G22M-SM SODIMM System on Module

2017-08-08 Thread Chris Paterson
+ linux-renesas-soc > From: Fabrizio Castro [mailto:fabrizio.cas...@bp.renesas.com] > Sent: 08 August 2017 13:28 > > Document the iW-RainboW-G22M-SM SODIMM System on Module device tree > bindings. It is just a placeholder for the time being, the actual > implementation > is not available yet. >

RE: [PATCH 2/2] ARM: shmobile: document iW-RainboW-G22D SODIMM SOM Development Platform

2017-08-08 Thread Chris Paterson
+ linux-renesas-soc > From: Fabrizio Castro [mailto:fabrizio.cas...@bp.renesas.com] > Sent: 08 August 2017 13:28 > > Document the iW-RainboW-G22D device tree bindings. > It is just a placeholder for the time being, the actual implementation is not > available yet. > > Signed-off-by: Fabrizio

RE: [PATCH 1/2] ARM: shmobile: document iW-RainboW-G22M-SM SODIMM System on Module

2017-08-08 Thread Chris Paterson
+ linux-renesas-soc > From: Fabrizio Castro [mailto:fabrizio.cas...@bp.renesas.com] > Sent: 08 August 2017 13:28 > > Document the iW-RainboW-G22M-SM SODIMM System on Module device tree > bindings. It is just a placeholder for the time being, the actual > implementation > is not available yet. >

RE: [PATCH 2/2] ARM: shmobile: document iW-RainboW-G22D SODIMM SOM Development Platform

2017-08-08 Thread Chris Paterson
+ linux-renesas-soc > From: Fabrizio Castro [mailto:fabrizio.cas...@bp.renesas.com] > Sent: 08 August 2017 13:28 > > Document the iW-RainboW-G22D device tree bindings. > It is just a placeholder for the time being, the actual implementation is not > available yet. > > Signed-off-by: Fabrizio

RE: [PATCH 0/2] ARM: shmobile: document iWave's iW-RainboW-G22D-SODIMM RZ/G1E SODIMM development platform

2017-08-08 Thread Chris Paterson
+ linux-renesas-soc > From: Fabrizio Castro [mailto:fabrizio.cas...@bp.renesas.com] > Sent: 08 August 2017 13:28 > To: robh...@kernel.org; mark.rutl...@arm.com > > Hello, > > This series aims to add the documentation for the device tree bindings of the > iWave iW-RainboW-G22D-SODIMM RZ/G1E

RE: [PATCH 0/2] ARM: shmobile: document iWave's iW-RainboW-G22D-SODIMM RZ/G1E SODIMM development platform

2017-08-08 Thread Chris Paterson
+ linux-renesas-soc > From: Fabrizio Castro [mailto:fabrizio.cas...@bp.renesas.com] > Sent: 08 August 2017 13:28 > To: robh...@kernel.org; mark.rutl...@arm.com > > Hello, > > This series aims to add the documentation for the device tree bindings of the > iWave iW-RainboW-G22D-SODIMM RZ/G1E

Re: [PATCH] net: phy: Use tab for indentation in Kconfig

2017-08-08 Thread Andrew Lunn
On Tue, Aug 08, 2017 at 11:32:25AM +0200, Michal Simek wrote: > Using tabs instead of space for indentaion > > Signed-off-by: Michal Simek Reviewed-by: Andrew Lunn Andrew

Re: [PATCH] net: phy: Use tab for indentation in Kconfig

2017-08-08 Thread Andrew Lunn
On Tue, Aug 08, 2017 at 11:32:25AM +0200, Michal Simek wrote: > Using tabs instead of space for indentaion > > Signed-off-by: Michal Simek Reviewed-by: Andrew Lunn Andrew

Re: [PATCH] arm64: correct modules range of kernel virtual memory layout

2017-08-08 Thread Ard Biesheuvel
On 8 August 2017 at 14:19, Will Deacon wrote: > On Tue, Aug 08, 2017 at 01:27:25PM +0800, Miles Chen wrote: >> On Tue, 2017-08-08 at 12:44 +0800, Miles Chen wrote: >> > On Mon, 2017-08-07 at 15:01 +0100, Will Deacon wrote: >> > > On Mon, Aug 07, 2017 at 02:18:00PM +0100, Ard

Re: [PATCH] arm64: correct modules range of kernel virtual memory layout

2017-08-08 Thread Ard Biesheuvel
On 8 August 2017 at 14:19, Will Deacon wrote: > On Tue, Aug 08, 2017 at 01:27:25PM +0800, Miles Chen wrote: >> On Tue, 2017-08-08 at 12:44 +0800, Miles Chen wrote: >> > On Mon, 2017-08-07 at 15:01 +0100, Will Deacon wrote: >> > > On Mon, Aug 07, 2017 at 02:18:00PM +0100, Ard Biesheuvel wrote: >>

Re: [PATCHv2] bluetooth: document config options

2017-08-08 Thread Marcel Holtmann
Hi Pavel, > On Aug 8, 2017, at 15:48, Pavel Machek wrote: > > Kernel config options should include useful help text; I had to look > up the terms on wikipedia. > > Signed-off-by: Pavel Machek > > --- > >> are you planning to send a patch with updated wording for

Re: [PATCHv2] bluetooth: document config options

2017-08-08 Thread Marcel Holtmann
Hi Pavel, > On Aug 8, 2017, at 15:48, Pavel Machek wrote: > > Kernel config options should include useful help text; I had to look > up the terms on wikipedia. > > Signed-off-by: Pavel Machek > > --- > >> are you planning to send a patch with updated wording for this? > > Sorry for the

Re: [RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-08 Thread Peter Zijlstra
On Tue, Aug 08, 2017 at 03:56:26PM +0200, Vincent Guittot wrote: > > I don't think that IRQ tracking patch is working. > update_irq_load_avg(rq->clock, cpu_of(rq), rq, 1); is called in > update_rq_clock_task() which is never called in irq context. In order > to use PELT for tracking irq and

Re: [RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-08 Thread Peter Zijlstra
On Tue, Aug 08, 2017 at 03:56:26PM +0200, Vincent Guittot wrote: > > I don't think that IRQ tracking patch is working. > update_irq_load_avg(rq->clock, cpu_of(rq), rq, 1); is called in > update_rq_clock_task() which is never called in irq context. In order > to use PELT for tracking irq and

Re: [PATCH v2 0/3] fix xen hvm guest with kaslr enabled

2017-08-08 Thread Boris Ostrovsky
On 08/08/2017 02:46 AM, Juergen Gross wrote: > On 28/07/17 12:23, Juergen Gross wrote: >> This patch series fixes a regression introduced in 4.13-rc1: A Xen >> HVM guest with KASLR enabled wouldn't boot any longer due to the usage >> of __va() before kernel_randomize_memory() was called. >> >>

Re: [PATCH v2 0/3] fix xen hvm guest with kaslr enabled

2017-08-08 Thread Boris Ostrovsky
On 08/08/2017 02:46 AM, Juergen Gross wrote: > On 28/07/17 12:23, Juergen Gross wrote: >> This patch series fixes a regression introduced in 4.13-rc1: A Xen >> HVM guest with KASLR enabled wouldn't boot any longer due to the usage >> of __va() before kernel_randomize_memory() was called. >> >>

Re: [PATCH] KVM: X86: expand ->arch.apic_arb_prio to u64

2017-08-08 Thread Paolo Bonzini
On 08/08/2017 15:50, Longpeng (Mike) wrote: > > > On 2017/8/8 21:08, Paolo Bonzini wrote: > >> On 08/08/2017 13:37, Longpeng(Mike) wrote: >>> Currently 'apic_arb_prio' is int32_t, it's too short for long >>> time running. In our environment, it overflowed and then the >>> UBSAN was angry: >>>

Re: [PATCH] KVM: X86: expand ->arch.apic_arb_prio to u64

2017-08-08 Thread Paolo Bonzini
On 08/08/2017 15:50, Longpeng (Mike) wrote: > > > On 2017/8/8 21:08, Paolo Bonzini wrote: > >> On 08/08/2017 13:37, Longpeng(Mike) wrote: >>> Currently 'apic_arb_prio' is int32_t, it's too short for long >>> time running. In our environment, it overflowed and then the >>> UBSAN was angry: >>>

Re: [RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-08 Thread Vincent Guittot
On 7 August 2017 at 18:44, Peter Zijlstra wrote: > On Fri, Aug 04, 2017 at 03:40:21PM +0200, Vincent Guittot wrote: > >> There were several comments on v1: >> - As raised by Peter for v1, if IRQ time is taken into account in >> rt_avg, it will not be accounted in

Re: [RESEND PATCH v2 1/2] sched/rt: add utilization tracking

2017-08-08 Thread Vincent Guittot
On 7 August 2017 at 18:44, Peter Zijlstra wrote: > On Fri, Aug 04, 2017 at 03:40:21PM +0200, Vincent Guittot wrote: > >> There were several comments on v1: >> - As raised by Peter for v1, if IRQ time is taken into account in >> rt_avg, it will not be accounted in rq->clock_task. This means that

scsi: qla2xxx: use dma_mapping_error to check map errors

2017-08-08 Thread Pan Bian
The return value of dma_map_single() should be checked by dma_mapping_error(). However, in function qla26xx_dport_diagnostics(), its return value is checked against NULL, which could result in failures. Signed-off-by: Pan Bian --- drivers/scsi/qla2xxx/qla_mbx.c | 2 +- 1

scsi: qla2xxx: use dma_mapping_error to check map errors

2017-08-08 Thread Pan Bian
The return value of dma_map_single() should be checked by dma_mapping_error(). However, in function qla26xx_dport_diagnostics(), its return value is checked against NULL, which could result in failures. Signed-off-by: Pan Bian --- drivers/scsi/qla2xxx/qla_mbx.c | 2 +- 1 file changed, 1

Re: [PATCH 2/2] arm64: cleanup {COMPAT_,}SET_PERSONALITY() macro

2017-08-08 Thread Catalin Marinas
On Sat, Aug 05, 2017 at 05:40:22PM +0300, Yury Norov wrote: > Originally {COMPAT_,}SET_PERSONALITY() only sets the 32-bit flag in > thread_info > structure. But there is some work that should be done after setting the > personality. > Currently it's done in the macro, which is not the best idea.

Re: [PATCH 2/2] arm64: cleanup {COMPAT_,}SET_PERSONALITY() macro

2017-08-08 Thread Catalin Marinas
On Sat, Aug 05, 2017 at 05:40:22PM +0300, Yury Norov wrote: > Originally {COMPAT_,}SET_PERSONALITY() only sets the 32-bit flag in > thread_info > structure. But there is some work that should be done after setting the > personality. > Currently it's done in the macro, which is not the best idea.

[PATCH] hv_set_ifconfig.sh double check before setting ip

2017-08-08 Thread Eduardo Otubo
This patch fixes the behavior of the hv_set_ifconfig script when setting the interface ip. Sometimes the interface has already been configured by network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file exists error"; in order to avoid this error this patch makes sure double checks the

[PATCH] hv_set_ifconfig.sh double check before setting ip

2017-08-08 Thread Eduardo Otubo
This patch fixes the behavior of the hv_set_ifconfig script when setting the interface ip. Sometimes the interface has already been configured by network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file exists error"; in order to avoid this error this patch makes sure double checks the

Re: [PATCH] KVM: X86: expand ->arch.apic_arb_prio to u64

2017-08-08 Thread Longpeng (Mike)
On 2017/8/8 21:08, Paolo Bonzini wrote: > On 08/08/2017 13:37, Longpeng(Mike) wrote: >> Currently 'apic_arb_prio' is int32_t, it's too short for long >> time running. In our environment, it overflowed and then the >> UBSAN was angry: >> >> signed integer overflow: >> 2147483647 + 1 cannot be

Re: [PATCH] KVM: X86: expand ->arch.apic_arb_prio to u64

2017-08-08 Thread Longpeng (Mike)
On 2017/8/8 21:08, Paolo Bonzini wrote: > On 08/08/2017 13:37, Longpeng(Mike) wrote: >> Currently 'apic_arb_prio' is int32_t, it's too short for long >> time running. In our environment, it overflowed and then the >> UBSAN was angry: >> >> signed integer overflow: >> 2147483647 + 1 cannot be

Re: [PATCH 1/2] arm64: introduce separated bits for mm_context_t flags

2017-08-08 Thread Catalin Marinas
On Sat, Aug 05, 2017 at 05:40:21PM +0300, Yury Norov wrote: > diff --git a/arch/arm64/include/asm/mmu.h b/arch/arm64/include/asm/mmu.h > index 5468c834b072..2c57b06b2883 100644 > --- a/arch/arm64/include/asm/mmu.h > +++ b/arch/arm64/include/asm/mmu.h > @@ -16,6 +16,8 @@ > #ifndef __ASM_MMU_H >

Re: [PATCH 1/2] arm64: introduce separated bits for mm_context_t flags

2017-08-08 Thread Catalin Marinas
On Sat, Aug 05, 2017 at 05:40:21PM +0300, Yury Norov wrote: > diff --git a/arch/arm64/include/asm/mmu.h b/arch/arm64/include/asm/mmu.h > index 5468c834b072..2c57b06b2883 100644 > --- a/arch/arm64/include/asm/mmu.h > +++ b/arch/arm64/include/asm/mmu.h > @@ -16,6 +16,8 @@ > #ifndef __ASM_MMU_H >

[PATCH 2/3] serial: 8250_uniphier: use CHAR register for canary to detect power-off

2017-08-08 Thread Masahiro Yamada
The 8250 core uses the SCR as a canary to discover if the console has been powered-off. This hardware does not have SCR at offset 7, but an unused register CHAR at a different offset. As long as the character interrupt is disabled, the register access has no impact, so it is useful as an

[PATCH 0/3] serial: 8250_uniphier: bug fix and suspend/resume support

2017-08-08 Thread Masahiro Yamada
1/3 is a bug-fix (the driver may unregister a different port) 2/3 and 3/3 add suspend/resume support. Masahiro Yamada (3): serial: 8250_uniphier: fix serial port index in private data serial: 8250_uniphier: use CHAR register for canary to detect power-off serial: 8250_uniphier: add

<    5   6   7   8   9   10   11   12   13   14   >