Re: [PATCH] zram: fix null dereference of handle

2017-09-19 Thread Minchan Kim
On Tue, Sep 19, 2017 at 07:21:25PM +0900, Sergey Senozhatsky wrote: > Minchan, > > I just ran across it [because I had a bug to analize where this > part was involved]. I'd really prefer the kernel to BUG_ON immediately > instead of dying in agony. > > can we, please, return BUG_ON() back? > >

Re: [PATCH] zram: fix null dereference of handle

2017-09-19 Thread Minchan Kim
On Tue, Sep 19, 2017 at 07:21:25PM +0900, Sergey Senozhatsky wrote: > Minchan, > > I just ran across it [because I had a bug to analize where this > part was involved]. I'd really prefer the kernel to BUG_ON immediately > instead of dying in agony. > > can we, please, return BUG_ON() back? > >

Re: Error when building the kernel on top of 4.14-rc1 for target firmware_install?

2017-09-19 Thread Yu Chen
On Wed, Sep 20, 2017 at 1:37 PM, Greg Kroah-Hartman wrote: > On Wed, Sep 20, 2017 at 11:20:19AM +0800, Yu Chen wrote: >> Hi, >> kernel compile failed after running # make rpm >> >> + >>

Re: [PATCH v2 3/5] dmaengine: zynqmp_ps_pcie: Adding PS PCIe DMA driver

2017-09-19 Thread Michal Simek
On 8.9.2017 14:23, Ravi Shankar Jonnalagadda wrote: > Adding support for ZynqmMP PS PCIe EP driver. > Adding support for ZynqmMP PS PCIe Root DMA driver. > Modifying Kconfig and Makefile to add the support. > > Signed-off-by: Ravi Shankar Jonnalagadda > Signed-off-by:

Re: Error when building the kernel on top of 4.14-rc1 for target firmware_install?

2017-09-19 Thread Yu Chen
On Wed, Sep 20, 2017 at 1:37 PM, Greg Kroah-Hartman wrote: > On Wed, Sep 20, 2017 at 11:20:19AM +0800, Yu Chen wrote: >> Hi, >> kernel compile failed after running # make rpm >> >> + >> INSTALL_FW_PATH=/root/rpmbuild/BUILDROOT/kernel-4.14.0_rc1+-22.x86_64/lib/firmware/4.14.0-rc1+ >> + make >>

Re: [PATCH v2 3/5] dmaengine: zynqmp_ps_pcie: Adding PS PCIe DMA driver

2017-09-19 Thread Michal Simek
On 8.9.2017 14:23, Ravi Shankar Jonnalagadda wrote: > Adding support for ZynqmMP PS PCIe EP driver. > Adding support for ZynqmMP PS PCIe Root DMA driver. > Modifying Kconfig and Makefile to add the support. > > Signed-off-by: Ravi Shankar Jonnalagadda > Signed-off-by: RaviKiran Gummaluri > ---

[PATCH v2 4/4] mm:swap: skip swapcache for swapin of synchronous device

2017-09-19 Thread Minchan Kim
With fast swap storage, platform want to use swap more aggressively and swap-in is crucial to application latency. The rw_page based synchronous devices like zram, pmem and btt are such fast storage. When I profile swapin performance with zram lz4 decompress test, S/W overhead is more than 70%.

[PATCH v2 4/4] mm:swap: skip swapcache for swapin of synchronous device

2017-09-19 Thread Minchan Kim
With fast swap storage, platform want to use swap more aggressively and swap-in is crucial to application latency. The rw_page based synchronous devices like zram, pmem and btt are such fast storage. When I profile swapin performance with zram lz4 decompress test, S/W overhead is more than 70%.

[PATCH v2 1/4] zram: set BDI_CAP_STABLE_WRITES once

2017-09-19 Thread Minchan Kim
[1] fixed weird thing(i.e., reset BDI_CAP_STABLE_WRITES flag unconditionally whenever revalidat_disk is called) so zram doesn't need to reset the flag any more whenever revalidating the bdev. Instead, set the flag just once when the zram device is created. It shouldn't change any behavior. [1]

[PATCH v2 1/4] zram: set BDI_CAP_STABLE_WRITES once

2017-09-19 Thread Minchan Kim
[1] fixed weird thing(i.e., reset BDI_CAP_STABLE_WRITES flag unconditionally whenever revalidat_disk is called) so zram doesn't need to reset the flag any more whenever revalidating the bdev. Instead, set the flag just once when the zram device is created. It shouldn't change any behavior. [1]

[PATCH v2 2/4] bdi: introduce BDI_CAP_SYNCHRONOUS_IO

2017-09-19 Thread Minchan Kim
By discussion[1], someday we will remove rw_page function. If so, we need something to detect such super-fast storage which synchronous IO operation like current rw_page is always win. This patch introduces BDI_CAP_SYNCHRONOUS_IO to indicate such devices. With it, we could use various

[PATCH v2 2/4] bdi: introduce BDI_CAP_SYNCHRONOUS_IO

2017-09-19 Thread Minchan Kim
By discussion[1], someday we will remove rw_page function. If so, we need something to detect such super-fast storage which synchronous IO operation like current rw_page is always win. This patch introduces BDI_CAP_SYNCHRONOUS_IO to indicate such devices. With it, we could use various

[PATCH v2 3/4] mm:swap: introduce SWP_SYNCHRONOUS_IO

2017-09-19 Thread Minchan Kim
If rw-page based fast storage is used for swap devices, we need to detect it to enhance swap IO operations. This patch is preparation for optimizing of swap-in operation with next patch. Cc: Hugh Dickins Signed-off-by: Minchan Kim --- include/linux/swap.h

[PATCH v2 0/4] skip swapcache for super fast device

2017-09-19 Thread Minchan Kim
With fast swap storage, platform want to use swap more aggressively and swap-in is crucial to application latency. The rw_page based synchronous devices like zram, pmem and btt are such fast storage. When I profile swapin performance with zram lz4 decompress test, S/W overhead is more than 70%.

[PATCH v2 3/4] mm:swap: introduce SWP_SYNCHRONOUS_IO

2017-09-19 Thread Minchan Kim
If rw-page based fast storage is used for swap devices, we need to detect it to enhance swap IO operations. This patch is preparation for optimizing of swap-in operation with next patch. Cc: Hugh Dickins Signed-off-by: Minchan Kim --- include/linux/swap.h | 3 ++- mm/swapfile.c| 3 +++

[PATCH v2 0/4] skip swapcache for super fast device

2017-09-19 Thread Minchan Kim
With fast swap storage, platform want to use swap more aggressively and swap-in is crucial to application latency. The rw_page based synchronous devices like zram, pmem and btt are such fast storage. When I profile swapin performance with zram lz4 decompress test, S/W overhead is more than 70%.

Re: [PATCH v2 2/4] bdi: introduce BDI_CAP_SYNCHRONOUS_IO

2017-09-19 Thread Minchan Kim
On Tue, Sep 19, 2017 at 04:25:03PM +0200, Christoph Hellwig wrote: > I'm only seeing patch 2 of 4 - please resend the whole series so > that it can properly be reviewed. Yub, I will resend. Thanks for the review in advance.

Re: [PATCH v2 2/4] bdi: introduce BDI_CAP_SYNCHRONOUS_IO

2017-09-19 Thread Minchan Kim
On Tue, Sep 19, 2017 at 04:25:03PM +0200, Christoph Hellwig wrote: > I'm only seeing patch 2 of 4 - please resend the whole series so > that it can properly be reviewed. Yub, I will resend. Thanks for the review in advance.

Re: Error when building the kernel on top of 4.14-rc1 for target firmware_install?

2017-09-19 Thread Greg Kroah-Hartman
On Wed, Sep 20, 2017 at 11:20:19AM +0800, Yu Chen wrote: > Hi, > kernel compile failed after running # make rpm > > + > INSTALL_FW_PATH=/root/rpmbuild/BUILDROOT/kernel-4.14.0_rc1+-22.x86_64/lib/firmware/4.14.0-rc1+ > + make >

Re: Error when building the kernel on top of 4.14-rc1 for target firmware_install?

2017-09-19 Thread Greg Kroah-Hartman
On Wed, Sep 20, 2017 at 11:20:19AM +0800, Yu Chen wrote: > Hi, > kernel compile failed after running # make rpm > > + > INSTALL_FW_PATH=/root/rpmbuild/BUILDROOT/kernel-4.14.0_rc1+-22.x86_64/lib/firmware/4.14.0-rc1+ > + make >

Re: linux-next: error while fetching the microblaze tree

2017-09-19 Thread Michal Simek
Hi Stephen, On 20.9.2017 01:26, Stephen Rothwell wrote: > Hi Michal, > > On Thu, 7 Jan 2016 09:38:56 +1100 Stephen Rothwell > wrote: >> >> Fetching the microblaze tree >> (git://git.monstr.eu/linux-2.6-microblaze.git#next) produces this error. >> >> fatal: read error:

Re: linux-next: error while fetching the microblaze tree

2017-09-19 Thread Michal Simek
Hi Stephen, On 20.9.2017 01:26, Stephen Rothwell wrote: > Hi Michal, > > On Thu, 7 Jan 2016 09:38:56 +1100 Stephen Rothwell > wrote: >> >> Fetching the microblaze tree >> (git://git.monstr.eu/linux-2.6-microblaze.git#next) produces this error. >> >> fatal: read error: Connection reset by peer

Re: [PATCH v6] security/keys: rewrite all of big_key crypto

2017-09-19 Thread Stephan Mueller
Am Sonntag, 17. September 2017, 13:52:17 CEST schrieb Jason A. Donenfeld: Hi Jason, > * Use of ECB mode, allowing an attacker to trivially swap blocks or > compare identical plaintext blocks. The use of GCM with the implementtion here is just as challenging. The implementation uses a

Re: [PATCH v6] security/keys: rewrite all of big_key crypto

2017-09-19 Thread Stephan Mueller
Am Sonntag, 17. September 2017, 13:52:17 CEST schrieb Jason A. Donenfeld: Hi Jason, > * Use of ECB mode, allowing an attacker to trivially swap blocks or > compare identical plaintext blocks. The use of GCM with the implementtion here is just as challenging. The implementation uses a

[PATCH v2 1/4] watchdog: aspeed: Retain watchdog enabled state

2017-09-19 Thread Andrew Jeffery
An unintended post-condition of probe() is that the watchdog is disabled. This behaviour was introduced by an unnecessary write to the control register to configure the hardware based on the devicetree. The write is unnecessary because the cached control value that is manipulated by the code

[PATCH v2 3/4] watchdog: aspeed: Remove specific reference to AST2400 in Kconfig

2017-09-19 Thread Andrew Jeffery
The driver also supports the watchdog in the AST25xx series, and may work on earlier SoCs as well. Signed-off-by: Andrew Jeffery Reviewed-by: Guenter Roeck --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 1/4] watchdog: aspeed: Retain watchdog enabled state

2017-09-19 Thread Andrew Jeffery
An unintended post-condition of probe() is that the watchdog is disabled. This behaviour was introduced by an unnecessary write to the control register to configure the hardware based on the devicetree. The write is unnecessary because the cached control value that is manipulated by the code

[PATCH v2 3/4] watchdog: aspeed: Remove specific reference to AST2400 in Kconfig

2017-09-19 Thread Andrew Jeffery
The driver also supports the watchdog in the AST25xx series, and may work on earlier SoCs as well. Signed-off-by: Andrew Jeffery Reviewed-by: Guenter Roeck --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/Kconfig

[PATCH v2 2/4] watchdog: aspeed: Fix 'Apseed' typo in Kconfig

2017-09-19 Thread Andrew Jeffery
Apseed sounds like a good name for a web/mobile start-up incubator, but isn't a reflection of Aspeed themselves. Signed-off-by: Andrew Jeffery Reviewed-by: Guenter Roeck --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 2/4] watchdog: aspeed: Fix 'Apseed' typo in Kconfig

2017-09-19 Thread Andrew Jeffery
Apseed sounds like a good name for a web/mobile start-up incubator, but isn't a reflection of Aspeed themselves. Signed-off-by: Andrew Jeffery Reviewed-by: Guenter Roeck --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/Kconfig

[PATCH v2 0/4] watchdog: aspeed: Retain enabled state and move to arch_initcall

2017-09-19 Thread Andrew Jeffery
Hello, This series fixes some issues with the Aspeed watchdog, as outlined in the v1[1] cover letter. I've added a bit of an explanation as to why we call aspeed_wdt_start() in probe() if the watchdog is already enabled, but the essence of it is to ensure the watchdog is configured to the

[PATCH v2 0/4] watchdog: aspeed: Retain enabled state and move to arch_initcall

2017-09-19 Thread Andrew Jeffery
Hello, This series fixes some issues with the Aspeed watchdog, as outlined in the v1[1] cover letter. I've added a bit of an explanation as to why we call aspeed_wdt_start() in probe() if the watchdog is already enabled, but the essence of it is to ensure the watchdog is configured to the

[PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall

2017-09-19 Thread Andrew Jeffery
Probing at device_initcall time lead to perverse cases where the watchdog was probed after, say, I2C devices, which then leaves a potentially running watchdog at the mercy of I2C device behaviour and bus conditions. Load the watchdog driver early to ensure that the kernel is patting it well

[PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall

2017-09-19 Thread Andrew Jeffery
Probing at device_initcall time lead to perverse cases where the watchdog was probed after, say, I2C devices, which then leaves a potentially running watchdog at the mercy of I2C device behaviour and bus conditions. Load the watchdog driver early to ensure that the kernel is patting it well

Re: [PATCH v3] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks

2017-09-19 Thread Keerthy
On Wednesday 20 September 2017 01:00 AM, Bjorn Helgaas wrote: > On Fri, Sep 08, 2017 at 10:44:54AM +0530, Keerthy wrote: >> Add shutdown handler to cleanly turn off clocks. This will help >> in cases of kexec where in a new kernel can boot abruptly. >> >> Signed-off-by: Keerthy

Re: [PATCH v3] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks

2017-09-19 Thread Keerthy
On Wednesday 20 September 2017 01:00 AM, Bjorn Helgaas wrote: > On Fri, Sep 08, 2017 at 10:44:54AM +0530, Keerthy wrote: >> Add shutdown handler to cleanly turn off clocks. This will help >> in cases of kexec where in a new kernel can boot abruptly. >> >> Signed-off-by: Keerthy >> Acked-by:

[PATCH v4 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

2017-09-19 Thread George Cherian
Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, all PCC registers, for all processors in the same performance domain (as defined by _PSD), must be defined to be in the same subspace. Based on Section 14.1 of ACPI specification, it is possible to have a maximum of 256 PCC

[PATCH v4 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

2017-09-19 Thread George Cherian
Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, all PCC registers, for all processors in the same performance domain (as defined by _PSD), must be defined to be in the same subspace. Based on Section 14.1 of ACPI specification, it is possible to have a maximum of 256 PCC

[PATCH v4 1/2] mailbox: PCC: Move the MAX_PCC_SUBSPACES definition to header file

2017-09-19 Thread George Cherian
Move the MAX_PCC_SUBSPACES definition to acpi/pcc.h file. In preparation to add subspace id support for cppc_acpi driver. Signed-off-by: George Cherian --- drivers/mailbox/pcc.c | 1 - include/acpi/pcc.h| 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v4] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks

2017-09-19 Thread Keerthy
Add shutdown handler to cleanly turn off clocks. This will help in cases of kexec where in a new kernel can boot abruptly. Signed-off-by: Keerthy Acked-by: Kishon Vijay Abraham I --- Changes in v4: * Added the missing changes from v2! Changes in v3: *

[PATCH v4 1/2] mailbox: PCC: Move the MAX_PCC_SUBSPACES definition to header file

2017-09-19 Thread George Cherian
Move the MAX_PCC_SUBSPACES definition to acpi/pcc.h file. In preparation to add subspace id support for cppc_acpi driver. Signed-off-by: George Cherian --- drivers/mailbox/pcc.c | 1 - include/acpi/pcc.h| 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks

2017-09-19 Thread Keerthy
Add shutdown handler to cleanly turn off clocks. This will help in cases of kexec where in a new kernel can boot abruptly. Signed-off-by: Keerthy Acked-by: Kishon Vijay Abraham I --- Changes in v4: * Added the missing changes from v2! Changes in v3: * Pushed the function outside #ifdef

[PATCH v4 0/2] Make cppc acpi driver aware of pcc subspace ids

2017-09-19 Thread George Cherian
The current cppc acpi driver works with only one pcc subspace id. It maintains and registers only one pcc channel even if the acpi table has different pcc subspace ids. As per ACPI 6.2 spec all PCC registers, for all processors in the same performance domain (as defined by _PSD), must be

[PATCH v4 0/2] Make cppc acpi driver aware of pcc subspace ids

2017-09-19 Thread George Cherian
The current cppc acpi driver works with only one pcc subspace id. It maintains and registers only one pcc channel even if the acpi table has different pcc subspace ids. As per ACPI 6.2 spec all PCC registers, for all processors in the same performance domain (as defined by _PSD), must be

[PATCH v5] [DVB][FRONTEND] Modified the code related to FE_SET_PROPERTY ioctl

2017-09-19 Thread Satendra Singh Thakur
-Since all the properties in the func dtv_property_process_set are 4 bytes, We have added 2 new arguments u32 cmd and u32 data; in place of older argument struct dtv_property *tvp. -We have removed property validation in function dtv_property_process_set because most of the frontend drivers in

[PATCH v5] [DVB][FRONTEND] Modified the code related to FE_SET_PROPERTY ioctl

2017-09-19 Thread Satendra Singh Thakur
-Since all the properties in the func dtv_property_process_set are 4 bytes, We have added 2 new arguments u32 cmd and u32 data; in place of older argument struct dtv_property *tvp. -We have removed property validation in function dtv_property_process_set because most of the frontend drivers in

Re: [RFC] sched/fair: Use wake_q length as a hint for wake_wide

2017-09-19 Thread Joel Fernandes
> On Tue, Sep 19, 2017 at 3:05 AM, Brendan Jackman > wrote: >> On Mon, Sep 18 2017 at 22:15, Joel Fernandes wrote: [..] IIUC, if wake_affine() behaves correctly this trick wouldn't be necessary on SMP systems, so it might be best guarded by the presence >>> >>>

Re: [RFC] sched/fair: Use wake_q length as a hint for wake_wide

2017-09-19 Thread Joel Fernandes
> On Tue, Sep 19, 2017 at 3:05 AM, Brendan Jackman > wrote: >> On Mon, Sep 18 2017 at 22:15, Joel Fernandes wrote: [..] IIUC, if wake_affine() behaves correctly this trick wouldn't be necessary on SMP systems, so it might be best guarded by the presence >>> >>> Actually wake_affine

[PATCH review for 4.4 14/47] iio: adc: axp288: Drop bogus AXP288_ADC_TS_PIN_CTRL register modifications

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Hans de Goede [ Upstream commit fa2849e9649b5180ffc4cb3c3b005261c403093a ] For some reason the axp288_adc driver was modifying the AXP288_ADC_TS_PIN_CTRL register, changing bits 0-1 depending on whether the GP_ADC channel or another channel was written. These bits

[PATCH review for 4.4 14/47] iio: adc: axp288: Drop bogus AXP288_ADC_TS_PIN_CTRL register modifications

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Hans de Goede [ Upstream commit fa2849e9649b5180ffc4cb3c3b005261c403093a ] For some reason the axp288_adc driver was modifying the AXP288_ADC_TS_PIN_CTRL register, changing bits 0-1 depending on whether the GP_ADC channel or another channel was written. These bits control when a bias

[PATCH review for 4.4 25/47] partitions/efi: Fix integer overflow in GPT size calculation

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Alden Tondettar [ Upstream commit c5082b70adfe8e1ea1cf4a8eff92c9f260e364d2 ] If a GUID Partition Table claims to have more than 2**25 entries, the calculation of the partition table size in alloc_read_gpt_entries() will overflow a 32-bit integer and not enough

[PATCH review for 4.4 25/47] partitions/efi: Fix integer overflow in GPT size calculation

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Alden Tondettar [ Upstream commit c5082b70adfe8e1ea1cf4a8eff92c9f260e364d2 ] If a GUID Partition Table claims to have more than 2**25 entries, the calculation of the partition table size in alloc_read_gpt_entries() will overflow a 32-bit integer and not enough space will be allocated for

[PATCH review for 4.4 01/47] drm_fourcc: Fix DRM_FORMAT_MOD_LINEAR #define

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: "Kristian H. Kristensen" [ Upstream commit af913418261d6d3e7a29f06cf35f04610ead667c ] We need to define DRM_FORMAT_MOD_VENDOR_NONE for the fourcc_mod_code() macro to work correctly. Signed-off-by: Kristian H. Kristensen Signed-off-by: Daniel

[PATCH review for 4.4 01/47] drm_fourcc: Fix DRM_FORMAT_MOD_LINEAR #define

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: "Kristian H. Kristensen" [ Upstream commit af913418261d6d3e7a29f06cf35f04610ead667c ] We need to define DRM_FORMAT_MOD_VENDOR_NONE for the fourcc_mod_code() macro to work correctly. Signed-off-by: Kristian H. Kristensen Signed-off-by: Daniel Vetter Link:

[PATCH review for 4.4 02/47] drm: bridge: add DT bindings for TI ths8135

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Bartosz Golaszewski [ Upstream commit 2e644be30fcc08c736f66b60f4898d274d4873ab ] THS8135 is a configurable video DAC. Add DT bindings for this chip. Signed-off-by: Bartosz Golaszewski Reviewed-by: Laurent Pinchart

[PATCH review for 4.4 02/47] drm: bridge: add DT bindings for TI ths8135

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Bartosz Golaszewski [ Upstream commit 2e644be30fcc08c736f66b60f4898d274d4873ab ] THS8135 is a configurable video DAC. Add DT bindings for this chip. Signed-off-by: Bartosz Golaszewski Reviewed-by: Laurent Pinchart Acked-by: Rob Herring Signed-off-by: Archit Taneja Link:

[PATCH review for 4.4 28/47] usb: chipidea: vbus event may exist before starting gadget

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Peter Chen [ Upstream commit c3b674a04b8ab62a1d35e86714d466af0a0ecc18 ] At some situations, the vbus may already be there before starting gadget. So we need to check vbus event after switching to gadget in order to handle missing vbus event. The typical use cases are

[PATCH review for 4.4 28/47] usb: chipidea: vbus event may exist before starting gadget

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Peter Chen [ Upstream commit c3b674a04b8ab62a1d35e86714d466af0a0ecc18 ] At some situations, the vbus may already be there before starting gadget. So we need to check vbus event after switching to gadget in order to handle missing vbus event. The typical use cases are plugging vbus cable

[PATCH review for 4.4 13/47] hwmon: (gl520sm) Fix overflows and crash seen when writing into limit attributes

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Guenter Roeck [ Upstream commit 87cdfa9d60f4f40e6d71b04b10b36d9df3c89282 ] Writes into limit attributes can overflow due to multplications and additions with unbound input values. Writing into fan limit attributes can result in a crash with a division by zero if very

[PATCH review for 4.4 13/47] hwmon: (gl520sm) Fix overflows and crash seen when writing into limit attributes

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Guenter Roeck [ Upstream commit 87cdfa9d60f4f40e6d71b04b10b36d9df3c89282 ] Writes into limit attributes can overflow due to multplications and additions with unbound input values. Writing into fan limit attributes can result in a crash with a division by zero if very large values are

[PATCH review for 4.4 12/47] clk: wm831x: fix usleep_range with bad range

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Nicholas Mc Guire [ Upstream commit ed784c532a3d0959db488f40a96c5127f63d42dc ] The delay here is not in atomic context and does not seem critical with respect to precision, but usleep_range(min,max) with min==max results in giving the timer subsystem no room to optimize

[PATCH review for 4.4 12/47] clk: wm831x: fix usleep_range with bad range

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Nicholas Mc Guire [ Upstream commit ed784c532a3d0959db488f40a96c5127f63d42dc ] The delay here is not in atomic context and does not seem critical with respect to precision, but usleep_range(min,max) with min==max results in giving the timer subsystem no room to optimize uncritical delays.

[PATCH review for 4.4 08/47] MIPS: ralink: Fix incorrect assignment on ralink_soc

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Colin Ian King [ Upstream commit 08d90c81b714482dceb5323d14f6617bcf55ee61 ] ralink_soc sould be assigned to RT3883_SOC, replace incorrect comparision with assignment. Signed-off-by: Colin Ian King Fixes: 418d29c87061 ("MIPS: ralink:

[PATCH review for 4.4 08/47] MIPS: ralink: Fix incorrect assignment on ralink_soc

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Colin Ian King [ Upstream commit 08d90c81b714482dceb5323d14f6617bcf55ee61 ] ralink_soc sould be assigned to RT3883_SOC, replace incorrect comparision with assignment. Signed-off-by: Colin Ian King Fixes: 418d29c87061 ("MIPS: ralink: Unify SoC id handling") Cc: John Crispin Cc:

[PATCH review for 4.4 11/47] sh_eth: use correct name for ECMR_MPDE bit

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Niklas Söderlund [ Upstream commit 6dcf45e514974a1ff10755015b5e06746a033e5f ] This bit was wrongly named due to a typo, Sergei checked the SH7734/63 manuals and this bit should be named MPDE. Suggested-by: Sergei Shtylyov

[PATCH review for 4.4 11/47] sh_eth: use correct name for ECMR_MPDE bit

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Niklas Söderlund [ Upstream commit 6dcf45e514974a1ff10755015b5e06746a033e5f ] This bit was wrongly named due to a typo, Sergei checked the SH7734/63 manuals and this bit should be named MPDE. Suggested-by: Sergei Shtylyov Signed-off-by: Niklas Söderlund Signed-off-by: David S. Miller

[PATCH review for 4.4 19/47] IB/ipoib: rtnl_unlock can not come after free_netdev

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Feras Daoud [ Upstream commit 89a3987ab7a923c047c6dec008e60ad6f41fac22 ] The ipoib_vlan_add function calls rtnl_unlock after free_netdev, rtnl_unlock not only releases the lock, but also calls netdev_run_todo. The latter function browses the net_todo_list array and

[PATCH review for 4.4 15/47] iio: adc: hx711: Add DT binding for avia,hx711

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Andreas Klinger [ Upstream commit ff1293f67734da68e23fecb6ecdae7112b8c43f9 ] Add DT bindings for avia,hx711 Add vendor avia to vendor list Signed-off-by: Andreas Klinger Acked-by: Rob Herring Signed-off-by: Jonathan Cameron

[PATCH review for 4.4 19/47] IB/ipoib: rtnl_unlock can not come after free_netdev

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Feras Daoud [ Upstream commit 89a3987ab7a923c047c6dec008e60ad6f41fac22 ] The ipoib_vlan_add function calls rtnl_unlock after free_netdev, rtnl_unlock not only releases the lock, but also calls netdev_run_todo. The latter function browses the net_todo_list array and completes the

[PATCH review for 4.4 15/47] iio: adc: hx711: Add DT binding for avia,hx711

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Andreas Klinger [ Upstream commit ff1293f67734da68e23fecb6ecdae7112b8c43f9 ] Add DT bindings for avia,hx711 Add vendor avia to vendor list Signed-off-by: Andreas Klinger Acked-by: Rob Herring Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin ---

[PATCH review for 4.4 05/47] ARM: dts: r8a7790: Use R-Car Gen 2 fallback binding for msiof nodes

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Simon Horman [ Upstream commit 654450baf2afba86cf328e1849ccac61ec4630af ] Use recently added R-Car Gen 2 fallback binding for msiof nodes in DT for r8a7790 SoC. This has no run-time effect for the current driver as the initialisation sequence is the same for

[PATCH review for 4.4 05/47] ARM: dts: r8a7790: Use R-Car Gen 2 fallback binding for msiof nodes

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Simon Horman [ Upstream commit 654450baf2afba86cf328e1849ccac61ec4630af ] Use recently added R-Car Gen 2 fallback binding for msiof nodes in DT for r8a7790 SoC. This has no run-time effect for the current driver as the initialisation sequence is the same for the SoC-specific binding for

[PATCH review for 4.4 35/47] mmc: sdio: fix alignment issue in struct sdio_func

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Heiner Kallweit [ Upstream commit 5ef1ecf060f28ecef313b5723f1fd39bf5a35f56 ] Certain 64-bit systems (e.g. Amlogic Meson GX) require buffers to be used for DMA to be 8-byte-aligned. struct sdio_func has an embedded small DMA buffer not meeting this requirement. When

[PATCH review for 4.4 35/47] mmc: sdio: fix alignment issue in struct sdio_func

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Heiner Kallweit [ Upstream commit 5ef1ecf060f28ecef313b5723f1fd39bf5a35f56 ] Certain 64-bit systems (e.g. Amlogic Meson GX) require buffers to be used for DMA to be 8-byte-aligned. struct sdio_func has an embedded small DMA buffer not meeting this requirement. When testing switching to

[PATCH review for 4.4 18/47] IB/ipoib: Fix deadlock over vlan_mutex

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Feras Daoud [ Upstream commit 1c3098cdb05207e740715857df7b0998e372f527 ] This patch fixes Deadlock while executing ipoib_vlan_delete. The function takes the vlan_rwsem semaphore and calls unregister_netdevice. The later function calls ipoib_mcast_stop_thread that

[PATCH review for 4.4 18/47] IB/ipoib: Fix deadlock over vlan_mutex

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Feras Daoud [ Upstream commit 1c3098cdb05207e740715857df7b0998e372f527 ] This patch fixes Deadlock while executing ipoib_vlan_delete. The function takes the vlan_rwsem semaphore and calls unregister_netdevice. The later function calls ipoib_mcast_stop_thread that cause workqueue flush.

[PATCH review for 4.4 21/47] drm/amdkfd: fix improper return value on error

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Pan Bian [ Upstream commit 8bf793883da213864efc50c274d2b38ec0ca58b2 ] In function kfd_wait_on_events(), when the call to copy_from_user() fails, the value of return variable ret is 0. 0 indicates success, which is inconsistent with the execution status. This patch

[PATCH review for 4.4 21/47] drm/amdkfd: fix improper return value on error

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Pan Bian [ Upstream commit 8bf793883da213864efc50c274d2b38ec0ca58b2 ] In function kfd_wait_on_events(), when the call to copy_from_user() fails, the value of return variable ret is 0. 0 indicates success, which is inconsistent with the execution status. This patch fixes the bug by

[PATCH review for 4.4 04/47] RDS: RDMA: Fix the composite message user notification

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Santosh Shilimkar [ Upstream commit 941f8d55f6d613a460a5e080d25a38509f45eb75 ] When application sends an RDS RDMA composite message consist of RDMA transfer to be followed up by non RDMA payload, it expect to be notified *only* when the full message gets

[PATCH review for 4.4 22/47] USB: serial: mos7720: fix control-message error handling

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Johan Hovold [ Upstream commit 0d130367abf582e7cbf60075c2a7ab53817b1d14 ] Make sure to log an error on short transfers when reading a device register. Also clear the provided buffer (which if often an uninitialised automatic variable) on errors as the driver currently

[PATCH review for 4.4 04/47] RDS: RDMA: Fix the composite message user notification

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Santosh Shilimkar [ Upstream commit 941f8d55f6d613a460a5e080d25a38509f45eb75 ] When application sends an RDS RDMA composite message consist of RDMA transfer to be followed up by non RDMA payload, it expect to be notified *only* when the full message gets delivered. RDS RDMA notification

[PATCH review for 4.4 22/47] USB: serial: mos7720: fix control-message error handling

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Johan Hovold [ Upstream commit 0d130367abf582e7cbf60075c2a7ab53817b1d14 ] Make sure to log an error on short transfers when reading a device register. Also clear the provided buffer (which if often an uninitialised automatic variable) on errors as the driver currently does not bother to

[PATCH review for 4.4 37/47] netfilter: invoke synchronize_rcu after set the _hook_ to NULL

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Liping Zhang [ Upstream commit 3b7dabf029478bb80507a6c4500ca94132a2bc0b ] Otherwise, another CPU may access the invalid pointer. For example: CPU0CPU1 - rcu_read_lock(); - pfunc = _hook_; _hook_ = NULL;

[PATCH review for 4.4 37/47] netfilter: invoke synchronize_rcu after set the _hook_ to NULL

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Liping Zhang [ Upstream commit 3b7dabf029478bb80507a6c4500ca94132a2bc0b ] Otherwise, another CPU may access the invalid pointer. For example: CPU0CPU1 - rcu_read_lock(); - pfunc = _hook_; _hook_ = NULL; - mod unload

[PATCH review for 4.4 24/47] pinctrl: mvebu: Use seq_puts() in mvebu_pinconf_group_dbg_show()

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Markus Elfring [ Upstream commit 420dc61642920849d824a0de2aa853db59f5244f ] Strings which did not contain data format specifications should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the

[PATCH review for 4.4 40/47] netfilter: nfnl_cthelper: fix incorrect helper->expect_class_max

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Liping Zhang [ Upstream commit ae5c682113f9f94cc5e76f92cf041ee624c173ee ] The helper->expect_class_max must be set to the total number of expect_policy minus 1, since we will use the statement "if (class > helper->expect_class_max)" to validate the CTA_EXPECT_CLASS

[PATCH review for 4.4 24/47] pinctrl: mvebu: Use seq_puts() in mvebu_pinconf_group_dbg_show()

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Markus Elfring [ Upstream commit 420dc61642920849d824a0de2aa853db59f5244f ] Strings which did not contain data format specifications should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH review for 4.4 40/47] netfilter: nfnl_cthelper: fix incorrect helper->expect_class_max

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Liping Zhang [ Upstream commit ae5c682113f9f94cc5e76f92cf041ee624c173ee ] The helper->expect_class_max must be set to the total number of expect_policy minus 1, since we will use the statement "if (class > helper->expect_class_max)" to validate the CTA_EXPECT_CLASS attr in

[PATCH review for 4.4 23/47] USB: serial: mos7840: fix control-message error handling

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Johan Hovold [ Upstream commit cd8db057e93ddaacbec025b567490555d2bca280 ] Make sure to detect short transfers when reading a device register. The modem-status handling had sufficient error checks in place, but move handling of short transfers into the register accessor

[PATCH review for 4.4 23/47] USB: serial: mos7840: fix control-message error handling

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Johan Hovold [ Upstream commit cd8db057e93ddaacbec025b567490555d2bca280 ] Make sure to detect short transfers when reading a device register. The modem-status handling had sufficient error checks in place, but move handling of short transfers into the register accessor function itself

[PATCH review for 4.4 16/47] ARM: 8635/1: nommu: allow enabling REMAP_VECTORS_TO_RAM

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Afzal Mohammed [ Upstream commit 8a792e9afbce84a0fdaf213fe42bb97382487094 ] REMAP_VECTORS_TO_RAM depends on DRAM_BASE, but since DRAM_BASE is a hex, REMAP_VECTORS_TO_RAM could never get enabled. Also depending on DRAM_BASE is redundant as whenever

[PATCH review for 4.4 16/47] ARM: 8635/1: nommu: allow enabling REMAP_VECTORS_TO_RAM

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Afzal Mohammed [ Upstream commit 8a792e9afbce84a0fdaf213fe42bb97382487094 ] REMAP_VECTORS_TO_RAM depends on DRAM_BASE, but since DRAM_BASE is a hex, REMAP_VECTORS_TO_RAM could never get enabled. Also depending on DRAM_BASE is redundant as whenever REMAP_VECTORS_TO_RAM makes itself

[PATCH review for 4.4 29/47] ASoC: dapm: fix some pointer error handling

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Linus Walleij [ Upstream commit 639467c8f26d834c934215e8b59129ce442475fe ] commit 66feeec9322132689d42723df2537d60f96f8e44 "RFC: ASoC: dapm: handle probe deferrals" forgot a to update some two sites where the call was used. The static codechecks quickly found

[PATCH review for 4.4 26/47] ASoC: dapm: handle probe deferrals

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Linus Walleij [ Upstream commit 37e1df8c95e2c8a57c77eafc097648f6e40a60ff ] This starts to handle probe deferrals on regulators and clocks on the ASoC DAPM. I came to this patch after audio stopped working on Ux500 ages ago and I finally looked into it to see

[PATCH review for 4.4 29/47] ASoC: dapm: fix some pointer error handling

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Linus Walleij [ Upstream commit 639467c8f26d834c934215e8b59129ce442475fe ] commit 66feeec9322132689d42723df2537d60f96f8e44 "RFC: ASoC: dapm: handle probe deferrals" forgot a to update some two sites where the call was used. The static codechecks quickly found them. Reported-by: Dan

[PATCH review for 4.4 26/47] ASoC: dapm: handle probe deferrals

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Linus Walleij [ Upstream commit 37e1df8c95e2c8a57c77eafc097648f6e40a60ff ] This starts to handle probe deferrals on regulators and clocks on the ASoC DAPM. I came to this patch after audio stopped working on Ux500 ages ago and I finally looked into it to see what is wrong. I had messages

[PATCH review for 4.4 38/47] MIPS: IRQ Stack: Unwind IRQ stack onto task stack

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Matt Redfearn [ Upstream commit db8466c581cca1a08b505f1319c3ecd246f16fa8 ] When the separate IRQ stack was introduced, stack unwinding only proceeded as far as the top of the IRQ stack, leading to kernel backtraces being less useful, lacking the trace of what was

[PATCH review for 4.4 38/47] MIPS: IRQ Stack: Unwind IRQ stack onto task stack

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Matt Redfearn [ Upstream commit db8466c581cca1a08b505f1319c3ecd246f16fa8 ] When the separate IRQ stack was introduced, stack unwinding only proceeded as far as the top of the IRQ stack, leading to kernel backtraces being less useful, lacking the trace of what was interrupted. Fix this by

[PATCH review for 4.4 33/47] team: fix memory leaks

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Pan Bian [ Upstream commit 72ec0bc64b9a5d8e0efcb717abfc757746b101b7 ] In functions team_nl_send_port_list_get() and team_nl_send_options_get(), pointer skb keeps the return value of nlmsg_new(). When the call to genlmsg_put() fails, the memory is not freed(). This

[PATCH review for 4.4 33/47] team: fix memory leaks

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Pan Bian [ Upstream commit 72ec0bc64b9a5d8e0efcb717abfc757746b101b7 ] In functions team_nl_send_port_list_get() and team_nl_send_options_get(), pointer skb keeps the return value of nlmsg_new(). When the call to genlmsg_put() fails, the memory is not freed(). This will result in memory

  1   2   3   4   5   6   7   8   9   10   >