Re: [PATCH v4 2/2] crypto: stm32 - Support for STM32 CRYP crypto module

2017-10-21 Thread Corentin Labbe
On Thu, Oct 19, 2017 at 01:01:56PM +, Fabien DESSENNE wrote: > Hi Corentin > > > Thank you for your comments. I will fix according to them. See also me > answers/questions below > > While we are at it, do you plan to deliver a new version of the > crypto_engine update? (I had to remove the

Re: [fstests PATCH v2] generic: add test for DAX MAP_SYNC support

2017-10-21 Thread Amir Goldstein
On Sat, Oct 21, 2017 at 12:25 AM, Ross Zwisler wrote: > Add a test that exercises DAX's new MAP_SYNC flag. > > This test creates a file and writes to it via an mmap(), but never syncs > via fsync/msync. This process is tracked via dm-log-writes, then replayed. > > If MAP_SYNC is working the dm-lo

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-21 Thread gengdongjiu
On 2017/10/21 20:15, Borislav Petkov wrote: >> Signed-off-by: Dongjiu Geng >> Tested-by: Tyler Baicar >> Signed-off-by: Borislav Petkov > I gave you Reviewed-by, not Signed-off-by. > > Before you send more patches, read this: > > Documentation/process/submitting-patches.rst > > You can read

[RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-21 Thread Dongjiu Geng
For the SEA notification, the two functions ghes_sea_add() and ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA is defined. If not, it will return errors in the ghes_probe() and not continue. If the probe is failed, the ghes_sea_remove() also has no chance to be called. Hence, remove the

Re: Enabling peer to peer device transactions for PCIe devices

2017-10-21 Thread Petrosyan, Ludwig
Hello Logan Thank You very much for respond. Could be I have done is stupid... But at first sight it has to be simple: The PCIe Write transactions are address routed, so if in the packet header the other endpoint address is written the TLP has to be routed (by PCIe Switch to the endpoint), the D

Re: [PATCH] fs: fix xattr permission checking error

2017-10-21 Thread Theodore Ts'o
On Sat, Oct 21, 2017 at 03:39:47PM +0200, Nicolas Belouin wrote: > Fix an issue making trusted xattr world readable and other > cap_sys_admin only > NACK. It is *documented* that trusted xattrs are only supposed to be readable by root. - Ted

Re: [PATCH] fs: check for DAC_READ_SEARCH instead of SYS_ADMIN

2017-10-21 Thread Theodore Ts'o
On Sat, Oct 21, 2017 at 03:24:46PM +0200, Nicolas Belouin wrote: > These checks are meant to prevent leaks or attacks via directory > traversal, the use of CAP_SYS_ADMIN here is a misuse, > CAP_DAC_READ_SEARCH being way more appropriate as a process > with CAP_DAC_READ_SEARCH is entrusted with goin

Re: [PATCH v1 1/3] virtio-balloon: replace the coarse-grained balloon_lock

2017-10-21 Thread Tetsuo Handa
Wei Wang wrote: > The balloon_lock was used to synchronize the access demand to elements > of struct virtio_balloon and its queue operations (please see commit > e22504296d). This prevents the concurrent run of the leak_balloon and > fill_balloon functions, thereby resulting in a deadlock issue on

Re: [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error

2017-10-21 Thread Sean Wang
On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote: > When adding the MT6380 compatible, the sentinel for of_device_id was > deleted, which leades to the following compiler error: > FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not > terminated with a NULL entry! > > Fi

Re: [PATCH v1 2/3] virtio-balloon: deflate up to oom_pages on OOM

2017-10-21 Thread Tetsuo Handa
Michael S. Tsirkin wrote: > On Fri, Oct 20, 2017 at 07:54:25PM +0800, Wei Wang wrote: > > The current implementation only deflates 256 pages even when a user > > specifies more than that via the oom_pages module param. This patch > > enables the deflating of up to oom_pages pages if there are enoug

RE: [PATCH 02/15] drivers, net, ethernet: convert mtk_eth.dma_refcnt from atomic_t to refcount_t

2017-10-21 Thread Sean Wang
On Fri, 2017-10-20 at 10:37 +, Reshetova, Elena wrote: > > On Fri, 2017-10-20 at 10:23 +0300, Elena Reshetova wrote: > > > atomic_t variables are currently used to implement reference > > > counters with the following properties: > > > - counter is initialized to 1 using atomic_set() > > > -

(*ABS*+0xbb29b267): multiple definition of `__crc___gcov_merge_add'

2017-10-21 Thread kbuild test robot
Hi Thomas, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0787643a5f6aad1f0cdeb305f7fe492b71943ea4 commit: d3488649dcd23b7a6e63895274ec69f80e92d4ed um: Fix CONFIG_GCOV for modules. date: 5 weeks ago config: um-al

Re: [PATCH v2 7/9] usb: host: modify description for MTK xHCI config

2017-10-21 Thread Chunfeng Yun
Hi, Greg On Tue, 2017-10-17 at 13:42 +0300, Mathias Nyman wrote: > On 17.10.2017 13:20, Greg Kroah-Hartman wrote: > > On Fri, Oct 13, 2017 at 01:32:14PM +0300, Mathias Nyman wrote: > >> On 13.10.2017 11:26, Chunfeng Yun wrote: > >>> Due to all MediaTek SoCs with xHCI host controller use this > >>>

Re: [PATCH v1 2/3] virtio-balloon: deflate up to oom_pages on OOM

2017-10-21 Thread Michael S. Tsirkin
On Fri, Oct 20, 2017 at 07:54:25PM +0800, Wei Wang wrote: > The current implementation only deflates 256 pages even when a user > specifies more than that via the oom_pages module param. This patch > enables the deflating of up to oom_pages pages if there are enough > inflated pages. > > Signed-of

Re: [PATCH v1 0/3] Virtio-balloon Improvement

2017-10-21 Thread Michael S. Tsirkin
On Fri, Oct 20, 2017 at 07:54:23PM +0800, Wei Wang wrote: > This patch series intends to summarize the recent contributions made by > Michael S. Tsirkin, Tetsuo Handa, Michal Hocko etc. via reporting and > discussing the related deadlock issues on the mailinglist. Please check > each patch for deta

[PATCH v3 01/13] openrisc: use shadow registers to save regs on exception

2017-10-21 Thread Stafford Horne
From: Stefan Kristiansson Previously, the area between 0x0-0x100 have been used as a "scratch" memory area to temporarily store regs during exception entry. In a multi-core environment, this will not work. This change is to use shadow registers for nested context. Currently only the "critical"

[PATCH v3 13/13] openrisc: add tick timer multi-core sync logic

2017-10-21 Thread Stafford Horne
In case timers are not in sync when cpus start (i.e. hot plug / offset resets) we need to synchronize the secondary cpus internal timer with the main cpu. This is needed as in OpenRISC SMP there is only one clocksource registered which reads from the same ttcr register on each cpu. This synchroni

[PATCH v3 11/13] openrisc: support framepointers and STACKTRACE_SUPPORT

2017-10-21 Thread Stafford Horne
For lockdep support a reliable stack trace mechanism is needed. This patch adds support in OpenRISC for the stacktrace framework, implemented by a simple unwinder api. The unwinder api supports both framepointer and basic stack tracing. The unwinder is now used to replace the stack_dump() implem

[PATCH v3 12/13] openrisc: enable LOCKDEP_SUPPORT and irqflags tracing

2017-10-21 Thread Stafford Horne
Lockdep is needed for proving the spinlocks and rwlocks work fine on our platform. It also requires calling the trace_hardirqs_off() and trace_hardirqs_on() pair of routines when entering and exiting an interrupt. For OpenRISC the interrupt stack frame does not support frame pointers, so to call

[PATCH v3 10/13] openrisc: add simple_smp dts and defconfig for simulators

2017-10-21 Thread Stafford Horne
From: Stefan Kristiansson Simple enough to be compatible with simulation environments, such as verilated systems, QEMU and other targets supporting OpenRISC SMP. This also supports our base FPGA SoC's if the cpu frequency is upped to 50Mhz. Signed-off-by: Stefan Kristiansson [sho...@gmail.com:

[PATCH v3 09/13] openrisc: add cacheflush support to fix icache aliasing

2017-10-21 Thread Stafford Horne
From: Jan Henrik Weinstock On OpenRISC the icache does not snoop data stores. This can cause aliasing as reported by Jan. This patch fixes the issue to ensure icache is properly synchronized when code is written to memory. It supports both SMP and UP flushing. This supports dcache flush as wel

[PATCH v3 07/13] openrisc: fix initial preempt state for secondary cpu tasks

2017-10-21 Thread Stafford Horne
During SMP testing we were getting the below warning after booting the secondary cpu: [0.06] BUG: scheduling while atomic: swapper/1/0/0x This change follows similar patterns from other architectures to start the schduler with preempt disabled. Signed-off-by: Stafford Horne ---

[PATCH v3 08/13] openrisc: sleep instead of spin on secondary wait

2017-10-21 Thread Stafford Horne
Currently we do a spin on secondary cpus when waiting to boot. This theoretically causes issues with power consumption and does cause issues with qemu cycle burning (it starves cpu 0 from actually being able to boot.) This change puts each secondary cpu to sleep if they have a power management un

[PATCH v3 02/13] openrisc: add 1 and 2 byte cmpxchg support

2017-10-21 Thread Stafford Horne
OpenRISC only supports hardware instructions that perform 4 byte atomic operations. For enabling qrwlocks for upcoming SMP support 1 and 2 byte implementations are needed. To do this we leverage the 4 byte atomic operations and shift/mask the 1 and 2 byte areas as needed. This heavily borrows id

[PATCH v3 05/13] irqchip: add initial support for ompic

2017-10-21 Thread Stafford Horne
From: Stefan Kristiansson IPI driver for the Open Multi-Processor Interrupt Controller (ompic) as described in the Multi-core support section of the OpenRISC 1.2 proposed architecture specification: https://github.com/stffrdhrn/doc/raw/arch-1.2-proposal/openrisc-arch-1.2-rev0.pdf Each OpenRI

[PATCH v3 03/13] openrisc: use qspinlocks and qrwlocks

2017-10-21 Thread Stafford Horne
Enable OpenRISC to use qspinlocks and qrwlocks for upcoming SMP support. Signed-off-by: Stafford Horne --- arch/openrisc/Kconfig | 2 ++ arch/openrisc/include/asm/Kbuild | 4 arch/openrisc/include/asm/spinlock.h | 12 +++- arch/openrisc/include

[PATCH v3 06/13] openrisc: initial SMP support

2017-10-21 Thread Stafford Horne
From: Stefan Kristiansson This patch introduces the SMP support for the OpenRISC architecture. The SMP architecture requires cores which have multi-core features which have been introduced a few years back including: - New SPRS SPR_COREID SPR_NUMCORES - Shadow SPRs - Atomic Instructions - Ca

[PATCH v3 04/13] dt-bindings: add openrisc to vendor prefixes list

2017-10-21 Thread Stafford Horne
Add OpenRISC.io to vendor prefixes. This is reserved for softcores developed by the OpenRISC community. The OpenRISC community has separated from OpenCores.org requiring a new prefix. Reviewed-by: Andreas Färber Acked-by: Rob Herring Signed-off-by: Stafford Horne --- Changes since v2 - None

[PATCH v3 00/13] OpenRISC SMP Support

2017-10-21 Thread Stafford Horne
Hello Again, (sorry for a bit of delay getting this version out, gdb and qemu patches have been keeping me busy) This series adds SMP support for OpenRISC. The OpenRISC multi-core platform and SMP linux support is based on the work that Stefan Kristiansson did around 2012 implemented in Verilog

[PATCH] MAINTAINERS: Add OpenRISC pic maintainer

2017-10-21 Thread Stafford Horne
The OpenRISC team is the maintainer of the irqchip or1k-pic driver under drivers/irqchip. Signed-off-by: Stafford Horne --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2281af4b41b6..8ce029872089 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10

Re: [PATCH] cpu/hotplug: Reset node state after operation

2017-10-21 Thread Paul E. McKenney
On Sat, Oct 21, 2017 at 04:06:52PM +0200, Thomas Gleixner wrote: > The recent rework of the cpu hotplug internals changed the usage of the per > cpu state->node field, but missed to clean it up after usage. > > So subsequent hotplug operations use the stale pointer from a previous > operation and

[PATCH 1/3] Documentation: Move OpenRISC docs out of arch/

2017-10-21 Thread Stafford Horne
The OpenRISC docs have traditionally been in arch/ but that does not seem like the correct place to be. Move them so they will be more visible to others. Also update MAINTAINERS to make sure we get notifications of changes. Signed-off-by: Stafford Horne --- arch/openrisc/README.openrisc => Doc

[PATCH 3/3] openrisc: dts: Add OpenRISC platform SoC

2017-10-21 Thread Stafford Horne
Add devicetree binding documentation for the OpenRISC platform opencores,or1ksim. This is the main OpenRISC reference platform supporting multiple FPGA SoC's. This format is based on some of the mips binding docs as we have similar requirements. Also, update maintainers so openrisc related bindi

[PATCH 2/3] Documentation: openrisc: Updates to README

2017-10-21 Thread Stafford Horne
Update the OpenRISC readme to provide some more up-to-date information on how to get started with OpenRISC. This includes: - remove references to southpole who no longer are consulting for OpenRISC (confirmed with Jonas) - suggested QEMU instead of the old or1ksim as QEMU is well supported

[PATCH 0/3] OpenRISC doc updates

2017-10-21 Thread Stafford Horne
Hello, This series moves OpenRISC documentation out of the arch/ folder and into the Documentation folder. I have also done some updates the README to bring to better match the current state of OpenRISC. Also, this adds documentation to the openrisc,or1ksim device tree binding which was previous

[GIT] Networking

2017-10-21 Thread David Miller
A little more than usual this time around. Been travelling, so that is part of it. Anyways, here are the highlights: 1) Deal with memcontrol races wrt. listener dismantle, from Eric Dumazet. 2) Handle page allocation failures properly in nfp driver, from Jaku Kicinski. 3) Fix memory lea

Re: [GIT PULL] Documentation: Add a file explaining the requested Linux kernel license enforcement policy

2017-10-21 Thread Bradley M. Kuhn
> On Thu, Oct 19, 2017 at 06:28:12PM +0300, Pavel Nikulin wrote: > Modification of GPL V2 terms are explicitly disallowed. Greg KH replied at 03:29 (US/Eastern) on Friday: >> Again, we are not modifying the license, so all should be fine I agree with Greg; the Linux Kernel Enforcement Statement d

Re: [PATCH] stmmac: Don't access tx_q->dirty_tx before netif_tx_lock

2017-10-21 Thread David Miller
From: Bernd Edlinger Date: Sat, 21 Oct 2017 06:51:30 + > This is the possible reason for different hard to reproduce > problems on my ARMv7-SMP test system. > > The symptoms are in recent kernels imprecise external aborts, > and in older kernels various kinds of network stalls and > unexpect

[PATCH v2] openrisc: dts: or1ksim: Add stdout-path

2017-10-21 Thread Stafford Horne
During reviews of the OpenRISC SMP patch series it was suggested to add stdout-path to the SMP dts file. Add stdout-path to our other dts files to be a good example. Cc: Geert Uytterhoeven Signed-off-by: Stafford Horne --- Changes since v1 - Complete rewrite with input from Geert arch/openr

Re: [PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-10-21 Thread David Miller
From: Florian Fainelli Date: Sat, 21 Oct 2017 19:01:45 -0700 > Reviewed-by : Florian Fainelli > > I still can't make sure this is not a problem for multiple PHYs > hanging off the same bus, but like anything else, we'll deal with > problems later if they arise. Thanks Florian. Applied, thanks

Re: [PATCH] net: smc_close: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Sat, 21 Oct 2017 20:21:00 -0500 > > Quoting David Miller : > >> From: "Gustavo A. R. Silva" >> Date: Thu, 19 Oct 2017 17:02:44 -0500 >> >>> @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct >>> work_struct *work) >>> case SMC_PEERCLOSEWAIT1: >>

Re: [PATCH] net: x25: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 20 Oct 2017 12:37:52 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH] net: af_unix: mark expected switch fall-through

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 20 Oct 2017 12:05:30 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH] net: tipc: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 20 Oct 2017 12:01:26 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva This doesn't apply to net-next.

Re: [PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-10-21 Thread Florian Fainelli
On October 21, 2017 6:37:38 PM PDT, David Miller wrote: > >Second ping, this patch needs a review ASAP. > >Geert's hard-resetting PHY changes depend upon this change. Done, same concerns as before and we could all improve on trying to get this tested on a pure SW model (e.g QEMU) but there is on

Re: [PATCH net-next 0/3] net: stmmac: Fix HW timestamping

2017-10-21 Thread David Miller
From: Jose Abreu Date: Fri, 20 Oct 2017 14:37:33 +0100 > Three fixes for HW timestamping feature, all of them for RX side. Series applied to 'net', thanks.

Re: [PATCH net] rxrpc: Don't release call mutex on error pointer

2017-10-21 Thread David Miller
From: David Howells Date: Fri, 20 Oct 2017 17:01:22 +0100 > Don't release call mutex at the end of rxrpc_kernel_begin_call() if the > call pointer actually holds an error value. > > Fixes: 540b1c48c37a ("rxrpc: Fix deadlock between call creation and > sendmsg/recvmsg") > Reported-by: Marc Dionn

Re: [PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-10-21 Thread Florian Fainelli
On October 18, 2017 4:54:03 AM PDT, Geert Uytterhoeven wrote: >If an Ethernet PHY is initialized before the interrupt controller it is >connected to, a message like the following is printed: > >irq: no irq domain found for /interrupt-controller@e61c ! > >However, the actual error is ignor

Re: v4.14-rc3/arm64 DABT exception in atomic_inc() / __skb_clone()

2017-10-21 Thread Wei Wei
I have uploaded the VM core dump [1]. And I don’t know if these logs are helpful in the case of failing to get the C reproducer currently. [1] https://github.com/dotweiba/skb_clone_atomic_inc_bug/blob/master/vmcore.gz 2017/10/21 20:24:32 reproducing crash 'unable to handle kernel paging request

Re: [PATCH 2/3] watchdog: hpwdt: SMBIOS check

2017-10-21 Thread Jerry Hoemann
On Fri, Oct 20, 2017 at 07:37:21PM -0700, Guenter Roeck wrote: > On 10/20/2017 03:54 PM, Jerry Hoemann wrote: > > Correct test on SMBIOS table 219 Misc Features bits for UEFI supported. > > > Please explain in more detail. There is no table 219 in the SMBIOS > specification. Sorry, my patch docu

Re: [PATCH v3 net-next 0/2] net: dsa: lan9303: Add fdb/mdb methods

2017-10-21 Thread David Miller
From: Egil Hjelmeland Date: Fri, 20 Oct 2017 12:19:08 +0200 > This series add support for accessing and managing the lan9303 ALR > (Address Logic Resolution). > > The first patch add low level functions for accessing the ALR, along > with port_fast_age and port_fdb_dump methods. > > The secon

Re: [PATCH 1/3] watchdog: hpwdt: add ioctl WDIOC_GETPRETIMEOUT

2017-10-21 Thread Jerry Hoemann
On Fri, Oct 20, 2017 at 07:25:20PM -0700, Guenter Roeck wrote: > On 10/20/2017 03:54 PM, Jerry Hoemann wrote: > > Add support for WDIOC_GETPRETIMEOUT ioctl so that user applications > > can determine when the NMI should arrive. > > > > Signed-off-by: Jerry Hoemann > > --- > > drivers/watchdog/h

Re: [PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral

2017-10-21 Thread David Miller
Second ping, this patch needs a review ASAP. Geert's hard-resetting PHY changes depend upon this change. Thank you.

[PATCH v2] net: smc_close: mark expected switch fall-through

2017-10-21 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I placed the "fall through" comment on its own line, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Mov

Re: [PATCH 00/15] networking drivers refcount_t conversions

2017-10-21 Thread David Miller
From: Elena Reshetova Date: Fri, 20 Oct 2017 10:23:34 +0300 > Note: these are the last patches related to networking that perform > conversion of refcounters from atomic_t to refcount_t. > In contrast to the core network refcounter conversions that > were merged earlier, these are much more strai

Re: [PATCH] net: smc_close: mark expected switch fall-throughs

2017-10-21 Thread Gustavo A. R. Silva
Quoting David Miller : From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 17:02:44 -0500 @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct work_struct *work) case SMC_PEERCLOSEWAIT1: if (rxflags->peer_done_writing) sk->sk_state =

Re: [PATCH net-next 0/2] Add mac loopback selftest support in hns3 driver

2017-10-21 Thread David Miller
From: Yunsheng Lin Date: Fri, 20 Oct 2017 10:19:20 +0800 > This patchset refactors the skb receiving and transmitting function > before adding mac loopback selftest support in hns3 driver. Series applied.

Re: [PATCH] net: smc_close: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 17:02:44 -0500 > @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct work_struct > *work) > case SMC_PEERCLOSEWAIT1: > if (rxflags->peer_done_writing) > sk->sk_state = SMC_PEERCLOSEWAIT2; > -

Re: [PATCH] net: sched: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 16:28:24 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH] net: rose: mark expected switch fall-throughs

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 13:03:51 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH] openvswitch: conntrack: mark expected switch fall-through

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 12:55:03 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I placed a "fall through" comment on > its own line, which is what GCC is exp

Re: [PATCH] net: netrom: nr_in: mark expected switch fall-through

2017-10-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 19 Oct 2017 12:43:08 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied to net-next.

Re: [kernel-hardening] [RFC PATCH 1/2] security, capabilities: Add CAP_SYS_MOUNT

2017-10-21 Thread Casey Schaufler
On 10/21/2017 11:41 AM, Nicolas Belouin wrote: > > On October 21, 2017 7:31:24 PM GMT+02:00, Casey Schaufler > wrote: >> On 10/21/2017 6:43 AM, Nicolas Belouin wrote: >>> With CAP_SYS_ADMIN being bloated and inapropriate for actions such >>> as mounting/unmounting filesystems, the creation of a n

[git pull] vfs.git fixes

2017-10-21 Thread Al Viro
MS_I_VERSION fixes - Mimi's fix + missing bits picked from Matthew (his patch contained a duplicate of the fs/namespace.c fix as well, but by that point the original fix had already been applied) The following changes since commit 1cfd0ddd82232804e03f3023f6a58b50dfef0574: bio_copy_user_

Re: [v8,4/5] watchdog: Add RAVE SP watchdog driver

2017-10-21 Thread Joe Perches
On Sat, 2017-10-21 at 09:47 -0700, Guenter Roeck wrote: > On Wed, Oct 18, 2017 at 10:01:35AM -0700, Andrey Smirnov wrote: > > This driver provides access to RAVE SP watchdog functionality. [] > > +static int rave_sp_wdt_legacy_configure(struct watchdog_device *wdd) > > +{ > > + const bool enable

[git pull] Input updates for v4.14-rc5

2017-10-21 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. You will get: - joydev now implements a blacklist to avoid creating joystick nodes for accelerometers found in composite devices such as PlaSt

[PATCH v4] ARM: dts: display5: Device tree description of LWN's DISPLAY5 board

2017-10-21 Thread Lukasz Majewski
This commit adds device tree description of Liebherr's Display5 board. Signed-off-by: Lukasz Majewski Reviewed-by: Fabio Estevam --- Changes for v2: - Postpone adding Mitsubishi display - Replace GPL with dual GPL/X11 licenses - Remove superfluous "i2s-master" property - Replace pinctrl 0x8000

[PATCH v2] w1: keep balance of mutex locks and refcnts

2017-10-21 Thread Alexey Khoroshilov
w1_therm_eeprom() and w1_DS18B20_precision() decrement THERM_REFCNT on error paths, while they did not increment it yet. read_therm() unlocks bus mutex on some error paths, while it is not acquired. The patch makes sure all the functions keep the balance in usage of the mutex and the THERM_REFCNT

Camera support, Prague next week, sdlcam

2017-10-21 Thread Pavel Machek
Hi! I'd still like to get some reasonable support for cellphone camera in Linux. IMO first reasonable step is to merge sdlcam, then we can implement autofocus, improve autogain... and rest of the boring stuff. Ouch and media graph support would be nice. Currently, _nothing_ works with media graph

Re: [PATCH 14/14] rcu: Use lockdep to assert IRQs are disabled/enabled

2017-10-21 Thread Paul E. McKenney
On Fri, Oct 20, 2017 at 02:56:11AM +0200, Frederic Weisbecker wrote: > Lockdep now has an integrated IRQs disabled/enabled sanity check. Just > use it instead of the ad-hoc RCU version. > > Signed-off-by: Frederic Weisbecker > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Thomas Gleixner > Cc: Pa

Re: [PATCH] ARM: dts: exynos: add cpu perf counters to Exynos54xx boards

2017-10-21 Thread Krzysztof Kozlowski
On Sat, Oct 21, 2017 at 05:54:31PM +1030, Marian Mihailescu wrote: > Hi Robin, > > Apologies, I did not really check which cluster is described for the > 5410 (since 5422 boots from the A7). > > Should I define both pmu nodes (w/o interrupt affinity) in the > exynos54xx,dtsi, and set the status p

[PATCH] tpm_i2c_nuvoton: Use common error handling code in i2c_nuvoton_send()

2017-10-21 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 21 Oct 2017 22:07:39 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/char/tpm/tpm_i2c_nuvoton.c | 1

Re: [PATCH] fs: fix xattr permission checking error

2017-10-21 Thread Nicolas Belouin
Indeed, I was mistaken here. Thanks for the review. I will do the "strncmp() ==0" in another patch as it is particularly unclear in this context. On October 21, 2017 9:48:16 PM GMT+02:00, Andreas Dilger wrote: >On Oct 21, 2017, at 7:39 AM, Nicolas Belouin >wrote: >> >> Fix an issue making tru

Re: crypto-testmgr: Use common error handling code in drbg_cavs_test()

2017-10-21 Thread SF Markus Elfring
> Though, jumping back and forth like this with goto directives is something > that looks a bit strange. At least to my taste, may I suggest to have gotos > pointing only downwards and not up again? (Note, the same applies to the > ansi_cprng patch set). > > What about something like following:

Re: [PATCH V2 3/4] thermal/drivers/hisi: Prepare to add support for other hisi platforms

2017-10-21 Thread Daniel Lezcano
On 21/10/2017 21:08, Eduardo Valentin wrote: > Heym > > On Sat, Oct 21, 2017 at 08:33:07PM +0200, Daniel Lezcano wrote: >> What sparse version are you using ? > > > Does it really matter? You are still assigning a const pointer to a non-const > pointer. I would like to reproduce it in order to

Re: [PATCH] fs: fix xattr permission checking error

2017-10-21 Thread Andreas Dilger
On Oct 21, 2017, at 7:39 AM, Nicolas Belouin wrote: > > Fix an issue making trusted xattr world readable and other > cap_sys_admin only > > Signed-off-by: Nicolas Belouin > --- > fs/hfsplus/xattr.c | 2 +- > fs/jfs/xattr.c | 5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > dif

Re: [kernel-hardening] [PATCH] fs: Use CAP_DAC_OVERRIDE to allow for file dedupe

2017-10-21 Thread Nicolas Belouin
On October 21, 2017 4:08:31 PM GMT+02:00, Nick Kralevich wrote: >On Sat, Oct 21, 2017 at 6:28 AM, Nicolas Belouin >wrote: >> In its current implementation the check is against CAP_SYS_ADMIN, >> however this capability is bloated and inapropriate for this use. >> Indeed the check aims to avoid

Re: [PATCH 3/3] iio: adc: stm32: add support for differential channels

2017-10-21 Thread Jonathan Cameron
On Tue, 17 Oct 2017 15:15:45 +0200 Fabrice Gasnier wrote: > STM32H7 ADC channels can be configured either as single ended or > differential with 'st,adc-channels' or 'st,adc-diff-channels' > (positive and negative input pair: , ...). > > Differential channels have different offset and scale, fro

Re: [PATCH 1/3] dt-bindings: iio: adc: stm32: add support for diff channels

2017-10-21 Thread Jonathan Cameron
On Sat, 21 Oct 2017 18:54:01 +0100 Jonathan Cameron wrote: > On Tue, 17 Oct 2017 15:15:43 +0200 > Fabrice Gasnier wrote: > > > STM32H7 ADC channels may be configured either as single-ended or > > differential. > > Add 'st,adc-diff-channels' property to support differential channels. > > Differe

Re: [PATCH 2/2] crypto/drbg: account for no longer returning -EALREADY

2017-10-21 Thread Stephan Mueller
Am Donnerstag, 19. Oktober 2017, 22:45:06 CEST schrieb Jason A. Donenfeld: Hi Jason, > We now structure things in a way that assumes the seeding function is > always eventually called. > > Signed-off-by: Jason A. Donenfeld > --- > crypto/drbg.c | 20 +--- > 1 file changed, 5 in

[PATCH] Added acpi device id ELAN0611 to support lenovo ideapad 520 touchpad

2017-10-21 Thread Ido Adiv
Signed-off-by: Ido Adiv --- drivers/input/mouse/elan_i2c_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c index 0e761d07..6d6b092e 100644 --- a/drivers/input/mouse/elan_i2c_core.c +++ b/drivers/input/mouse/elan_i

Re: [PATCH v2 4/4] lockdep: Assign a lock_class per gendisk used for wait_for_completion()

2017-10-21 Thread kbuild test robot
Hi Byungchul, [auto build test ERROR on linus/master] [also build test ERROR on v4.14-rc5 next-20171018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Byungchul-Park/Fix-false-positives-by-cros

Re: [GIT PULL] Documentation: Add a file explaining the requested Linux kernel license enforcement policy

2017-10-21 Thread Pavel Nikulin
If you say that your lawyers have comprehensively researched that, I can't say they did a good job. Almost every line sounds close to being a contractual agreement. If you say that this is only a personal promise, you have to state that. Like writing "this is not a an addendum to license terms and

Re: [RFC PATCH 1/2] security, capabilities: create CAP_TRUSTED

2017-10-21 Thread nicolas
,linux-e...@vger.kernel.org,linux-kernel@vger.kernel.org,linux-f2fs-de...@lists.sourceforge.net,linux-fsde...@vger.kernel.org,linux-...@lists.infradead.org,jfs-discuss...@lists.sourceforge.net,ocfs2-de...@oss.oracle.com,linux-unio...@vger.kernel.org,reiserfs-de...@vger.kernel.org,linux-security-mod

Re: [PATCH V2 3/4] thermal/drivers/hisi: Prepare to add support for other hisi platforms

2017-10-21 Thread Eduardo Valentin
Heym On Sat, Oct 21, 2017 at 08:33:07PM +0200, Daniel Lezcano wrote: > What sparse version are you using ? Does it really matter? You are still assigning a const pointer to a non-const pointer. BR,

Re: [kernel-hardening] [RFC PATCH 1/2] security, capabilities: create CAP_TRUSTED

2017-10-21 Thread nicolas
,linux-e...@vger.kernel.org,linux-kernel@vger.kernel.org,linux-f2fs-de...@lists.sourceforge.net,linux-fsde...@vger.kernel.org,linux-...@lists.infradead.org,jfs-discuss...@lists.sourceforge.net,ocfs2-de...@oss.oracle.com,linux-unio...@vger.kernel.org,reiserfs-de...@vger.kernel.org,linux-security-mod

Re: [PATCH] cgroup: reorder flexible array members of struct cgroup_root

2017-10-21 Thread Nick Desaulniers
On Sat, Oct 21, 2017 at 9:03 AM, Tejun Heo wrote: > The kernel is explicitly using GNU extended version of C and has > always from the beginning, so not-std-c isn't a valid argument. Ok, how about that it looks like gcc7.1 starts treating this as an error? https://godbolt.org/g/ivzPHZ gcc6.3 lo

Re: [PATCH 1/2] crypto-testmgr: Use common error handling code in drbg_cavs_test()

2017-10-21 Thread Stephan Mueller
Am Samstag, 21. Oktober 2017, 19:53:54 CEST schrieb SF Markus Elfring: Hi Markus, > From: Markus Elfring > Date: Sat, 21 Oct 2017 19:29:11 +0200 > > Adjust jump targets so that a bit of exception handling can be better > reused at the end of this function. > > This issue was detected by using

[PATCH] nbd: Use common error handling code in nbd_genl_connect()

2017-10-21 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 21 Oct 2017 20:50:37 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/block/nbd.c | 21 +++--

Re: [kernel-hardening] [RFC PATCH 1/2] security, capabilities: Add CAP_SYS_MOUNT

2017-10-21 Thread Nicolas Belouin
On October 21, 2017 7:31:24 PM GMT+02:00, Casey Schaufler wrote: >On 10/21/2017 6:43 AM, Nicolas Belouin wrote: >> With CAP_SYS_ADMIN being bloated and inapropriate for actions such >> as mounting/unmounting filesystems, the creation of a new capability >> is needed. >> CAP_SYS_MOUNT is meant t

Re: [PATCH 2/3] iio: adc: stm32: remove const channel names definition

2017-10-21 Thread Jonathan Cameron
On Tue, 17 Oct 2017 15:15:44 +0200 Fabrice Gasnier wrote: > Remove const array that defines channels. Build channels definition > at probe time, when initializing channels (only for requested ones). > This will ease adding differential channels support. > > Signed-off-by: Fabrice Gasnier Looks

RE: [PATCH v2] dell-laptop: Fix keyboard led max_brightness property for Dell Latitude E6410

2017-10-21 Thread Gabriel M. Elder
Original Message Subject: Re: [PATCH v2] dell-laptop: Fix keyboard led max_brightness property for Dell Latitude E6410 From: Pali Rohár Date: Thu, October 19, 2017 1:31 pm To: "Gabriel M. Elder" Cc: Darren Hart , Matthew Garrett , Andy Shevchenko , Gabriele Mazzotta , mario.limo

[PATCH 2/2] crypto-testmgr: Delete an unnecessary variable initialisation in drbg_cavs_test()

2017-10-21 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 21 Oct 2017 19:33:45 +0200 The variable "ret" will eventually be set to an error code a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- crypto/testmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH 1/3] dt-bindings: iio: adc: stm32: add support for diff channels

2017-10-21 Thread Jonathan Cameron
On Sat, 21 Oct 2017 18:54:01 +0100 Jonathan Cameron wrote: > On Tue, 17 Oct 2017 15:15:43 +0200 > Fabrice Gasnier wrote: > > > STM32H7 ADC channels may be configured either as single-ended or > > differential. > > Add 'st,adc-diff-channels' property to support differential channels. > > Differe

[PATCH 1/2] crypto-testmgr: Use common error handling code in drbg_cavs_test()

2017-10-21 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 21 Oct 2017 19:29:11 +0200 Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- crypto/testmgr.c | 31 ++

Re: [PATCH 1/3] dt-bindings: iio: adc: stm32: add support for diff channels

2017-10-21 Thread Jonathan Cameron
On Tue, 17 Oct 2017 15:15:43 +0200 Fabrice Gasnier wrote: > STM32H7 ADC channels may be configured either as single-ended or > differential. > Add 'st,adc-diff-channels' property to support differential channels. > Differential channels are defined as a pair of positive and negative > inputs: vin

[PATCH 0/2] crypto-testmgr: Fine-tuning for drbg_cavs_test()

2017-10-21 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 21 Oct 2017 19:47:43 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use common error handling code Delete an unnecessary variable initialisation crypto/testmgr.c | 33 +--

Re: [PATCH] iio: adc: sun4i-gpadc: use of_device_get_match_data

2017-10-21 Thread Jonathan Cameron
On Fri, 20 Oct 2017 07:37:29 +0200 Corentin Labbe wrote: > The usage of of_device_get_match_data reduce the code size a bit. > Furthermore, it prevents an improbable dereference when > of_match_device() return NULL. > > Signed-off-by: Corentin Labbe Nice little tidy up - thanks. Applied to the

[PATCH] watchdog: sunxi_wdt: use of_device_get_match_data

2017-10-21 Thread Corentin Labbe
The usage of of_device_get_match_data reduce the code size a bit. Furthermore, it prevents an improbable dereference when of_match_device() return NULL. Signed-off-by: Corentin Labbe --- drivers/watchdog/sunxi_wdt.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drive

Re: [PATCH 13/13] staging: iio: tsl2x7x: add goto for TSL2X7X_LUX_CALC_OVER_FLOW

2017-10-21 Thread Jonathan Cameron
On Thu, 19 Oct 2017 16:06:32 -0400 Brian Masney wrote: > This patch adds a return_max label for the two cases that need to set > the lux to TSL2X7X_LUX_CALC_OVER_FLOW and return. > > Signed-off-by: Brian Masney Sorry - don't like this last one. I think it hurts readability. Leave this as it w

  1   2   3   >