Re: [PATCH 1/2] f2fs: add missing quota_initialize in f2fs_set_acl

On 2017/10/25 13:44, Jaegeuk Kim wrote: > On 10/24, Chao Yu wrote: >> On 2017/10/24 6:14, Jaegeuk Kim wrote: >>> This patch adds to call quota_intialize in f2fs_set_acl. >>> >>> Signed-off-by: Jaegeuk Kim >>> --- >>> fs/f2fs/acl.c | 4 >>> 1 file changed, 4 insertions(+)

Re: [PATCH 1/2] f2fs: add missing quota_initialize in f2fs_set_acl

On 2017/10/25 13:44, Jaegeuk Kim wrote: > On 10/24, Chao Yu wrote: >> On 2017/10/24 6:14, Jaegeuk Kim wrote: >>> This patch adds to call quota_intialize in f2fs_set_acl. >>> >>> Signed-off-by: Jaegeuk Kim >>> --- >>> fs/f2fs/acl.c | 4 >>> 1 file changed, 4 insertions(+) >>> >>> diff --git

Re: [PATCH v3 8/8] block: Assign a lock_class per gendisk used for wait_for_completion()

* Byungchul Park wrote: > > Isn't lockdep_map a zero size structure that is always defined? If yes then > > there's no need for an #ifdef. > > No, a zero size structure for lockdep_map is not provided yet. > There are two options I can do: > > 1. Add a zero size

Re: [PATCH v3 8/8] block: Assign a lock_class per gendisk used for wait_for_completion()

* Byungchul Park wrote: > > Isn't lockdep_map a zero size structure that is always defined? If yes then > > there's no need for an #ifdef. > > No, a zero size structure for lockdep_map is not provided yet. > There are two options I can do: > > 1. Add a zero size structure for lockdep_map and

Re: [PATCH v2 6/6] f2fs: give up CP_TRIMMED_FLAG if it drops discards

On 2017/10/25 13:45, Jaegeuk Kim wrote: > On 10/24, Chao Yu wrote: >> On 2017/10/24 20:46, Jaegeuk Kim wrote: >>> On 10/24, Chao Yu wrote: Hi Jaegeuk, On 2017/10/4 9:08, Chao Yu wrote: > From: Chao Yu > > In ->umount, once we drop remained discard

Re: [PATCH v2 6/6] f2fs: give up CP_TRIMMED_FLAG if it drops discards

On 2017/10/25 13:45, Jaegeuk Kim wrote: > On 10/24, Chao Yu wrote: >> On 2017/10/24 20:46, Jaegeuk Kim wrote: >>> On 10/24, Chao Yu wrote: Hi Jaegeuk, On 2017/10/4 9:08, Chao Yu wrote: > From: Chao Yu > > In ->umount, once we drop remained discard entries, we should not

Re: 492b95e597 ("rcuperf: Set more user-friendly defaults"): WARNING: CPU: 0 PID: 1 at arch/x86/kernel/smp.c:128 native_smp_send_reschedule

Hi Paul, On Tue, Oct 24, 2017 at 06:25:13AM -0700, Paul E. McKenney wrote: On Tue, Oct 24, 2017 at 04:49:52AM +0200, Fengguang Wu wrote: Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

Re: 492b95e597 ("rcuperf: Set more user-friendly defaults"): WARNING: CPU: 0 PID: 1 at arch/x86/kernel/smp.c:128 native_smp_send_reschedule

Hi Paul, On Tue, Oct 24, 2017 at 06:25:13AM -0700, Paul E. McKenney wrote: On Tue, Oct 24, 2017 at 04:49:52AM +0200, Fengguang Wu wrote: Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

Re: [PATCH v3 2/8] lockdep: Introduce CROSSRELEASE_STACK_TRACE and make it not unwind as default

* Byungchul Park wrote: > On Tue, Oct 24, 2017 at 12:05:16PM +0200, Ingo Molnar wrote: > > > > * Byungchul Park wrote: > > > > > Johan Hovold reported a performance regression by crossrelease like: > > > > Pplease add Reported-by and

Re: [PATCH v3 2/8] lockdep: Introduce CROSSRELEASE_STACK_TRACE and make it not unwind as default

* Byungchul Park wrote: > On Tue, Oct 24, 2017 at 12:05:16PM +0200, Ingo Molnar wrote: > > > > * Byungchul Park wrote: > > > > > Johan Hovold reported a performance regression by crossrelease like: > > > > Pplease add Reported-by and Analyzed-by tags - you didn't even Cc: Johan! > > Excuse

Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

On Wed, May 31, 2017 at 04:04:17PM +0200, Frederic Weisbecker wrote: > On Tue, May 30, 2017 at 02:29:20PM +0900, Byungchul Park wrote: > > On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote: > > > Although llist provides proper APIs, they are not used. Make them used. > > > > +to

Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

On Wed, May 31, 2017 at 04:04:17PM +0200, Frederic Weisbecker wrote: > On Tue, May 30, 2017 at 02:29:20PM +0900, Byungchul Park wrote: > > On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote: > > > Although llist provides proper APIs, they are not used. Make them used. > > > > +to

Re: [PATCH v10] vfio: platform: reset: Add Broadcom FlexRM reset module

On Tue, Oct 3, 2017 at 10:57 AM, Anup Patel wrote: > This patch adds Broadcom FlexRM low-level reset for > VFIO platform. > > It will do the following: > 1. Disable/Deactivate each FlexRM ring > 2. Flush each FlexRM ring > > The cleanup sequence for FlexRM rings is

Re: [PATCH v10] vfio: platform: reset: Add Broadcom FlexRM reset module

On Tue, Oct 3, 2017 at 10:57 AM, Anup Patel wrote: > This patch adds Broadcom FlexRM low-level reset for > VFIO platform. > > It will do the following: > 1. Disable/Deactivate each FlexRM ring > 2. Flush each FlexRM ring > > The cleanup sequence for FlexRM rings is adapted from > Broadcom FlexRM

Re: [PATCH v2 6/6] f2fs: give up CP_TRIMMED_FLAG if it drops discards

On 10/24, Chao Yu wrote: > On 2017/10/24 20:46, Jaegeuk Kim wrote: > > On 10/24, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2017/10/4 9:08, Chao Yu wrote: > >>> From: Chao Yu > >>> > >>> In ->umount, once we drop remained discard entries, we should not > >>> set

Re: [PATCH v2 6/6] f2fs: give up CP_TRIMMED_FLAG if it drops discards

On 10/24, Chao Yu wrote: > On 2017/10/24 20:46, Jaegeuk Kim wrote: > > On 10/24, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2017/10/4 9:08, Chao Yu wrote: > >>> From: Chao Yu > >>> > >>> In ->umount, once we drop remained discard entries, we should not > >>> set CP_TRIMMED_FLAG with another

Re: [PATCH 1/2] f2fs: add missing quota_initialize in f2fs_set_acl

On 10/24, Chao Yu wrote: > On 2017/10/24 6:14, Jaegeuk Kim wrote: > > This patch adds to call quota_intialize in f2fs_set_acl. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/acl.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/fs/f2fs/acl.c

Re: [PATCH 1/2] f2fs: add missing quota_initialize in f2fs_set_acl

On 10/24, Chao Yu wrote: > On 2017/10/24 6:14, Jaegeuk Kim wrote: > > This patch adds to call quota_intialize in f2fs_set_acl. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/acl.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c > > index

Re: [PATCH 1/2 v2] f2fs: add missing quota_initialize in f2fs_set_acl

This patch adds to call quota_intialize in f2fs_set_acl. Signed-off-by: Jaegeuk Kim --- fs/f2fs/xattr.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index 147b481c6902..8801db019892 100644 --- a/fs/f2fs/xattr.c +++

Re: [PATCH 1/2 v2] f2fs: add missing quota_initialize in f2fs_set_acl

This patch adds to call quota_intialize in f2fs_set_acl. Signed-off-by: Jaegeuk Kim --- fs/f2fs/xattr.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index 147b481c6902..8801db019892 100644 --- a/fs/f2fs/xattr.c +++ b/fs/f2fs/xattr.c @@ -686,6 +686,10

Re: [PATCH] kbuild: fix dependency of dtbs targets

Hi. 2017-10-10 0:05 GMT+09:00 Russell King - ARM Linux : > On Wed, Oct 04, 2017 at 01:27:20PM +0900, Masahiro Yamada wrote: >> The target "dtbs" should depend on "scripts" because it needs to >> build dtc. The "prepare" target is unneeded here. > > Looks fine for ARM, as

Re: [PATCH] kbuild: fix dependency of dtbs targets

Hi. 2017-10-10 0:05 GMT+09:00 Russell King - ARM Linux : > On Wed, Oct 04, 2017 at 01:27:20PM +0900, Masahiro Yamada wrote: >> The target "dtbs" should depend on "scripts" because it needs to >> build dtc. The "prepare" target is unneeded here. > > Looks fine for ARM, as the only thing the dtbs

[PATCH 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

ATCPIT100 is often used on the Andes architecture, This timer provide 4 PIT channels. Each PIT channel is a multi-function timer, can be configured as 32,16,8 bit timers or PWM as well. For system timer it will set 32-bit timer0 as clock source and count downwards until underflow and restart

[PATCH 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

ATCPIT100 is often used on the Andes architecture, This timer provide 4 PIT channels. Each PIT channel is a multi-function timer, can be configured as 32,16,8 bit timers or PWM as well. For system timer it will set 32-bit timer0 as clock source and count downwards until underflow and restart

[PATCH 3/3] dt-bindings: timer: Add andestech atcpit100 timer binding doc

Signed-off-by: rick Signed-off-by: rick Signed-off-by: Greentime Hu --- .../bindings/timer/andestech,atcpit100-timer.txt | 31 1 file changed, 31 insertions(+) create mode 100644

[PATCH 3/3] dt-bindings: timer: Add andestech atcpit100 timer binding doc

Signed-off-by: rick Signed-off-by: rick Signed-off-by: Greentime Hu --- .../bindings/timer/andestech,atcpit100-timer.txt | 31 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/andestech,atcpit100-timer.txt diff --git

[PATCH 2/3] clocksource/drivers/Kconfig: Support andestech atcpit100

Signed-off-by: rick Signed-off-by: rick Signed-off-by: Greentime Hu --- drivers/clocksource/Kconfig |6 ++ drivers/clocksource/Makefile |1 + 2 files changed, 7 insertions(+) diff --git a/drivers/clocksource/Kconfig

[PATCH 2/3] clocksource/drivers/Kconfig: Support andestech atcpit100

Signed-off-by: rick Signed-off-by: rick Signed-off-by: Greentime Hu --- drivers/clocksource/Kconfig |6 ++ drivers/clocksource/Makefile |1 + 2 files changed, 7 insertions(+) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index cc60620..e950066 100644 ---

Re: [PATCH] drivers/wireless: iwlwifi/mvm: Convert timers to use timer_setup()

On Tue, 2017-10-24 at 02:29 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > The RCU lifetime on baid_data is unclear,

Re: [PATCH] drivers/wireless: iwlwifi/mvm: Convert timers to use timer_setup()

On Tue, 2017-10-24 at 02:29 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > The RCU lifetime on baid_data is unclear,

Re: [PATCH 1/3] driver: mailbox: add support for Hi3660

Hi Jassi, On Wed, Oct 25, 2017 at 09:47:34AM +0530, Jassi Brar wrote: > On Mon, Aug 7, 2017 at 2:47 PM, Zhong Kaihua wrote: > > From: Kaihua Zhong > > > > Add mailbox driver for Hi3660. > > > > Signed-off-by: Leo Yan > >

Re: [PATCH 1/3] driver: mailbox: add support for Hi3660

Hi Jassi, On Wed, Oct 25, 2017 at 09:47:34AM +0530, Jassi Brar wrote: > On Mon, Aug 7, 2017 at 2:47 PM, Zhong Kaihua wrote: > > From: Kaihua Zhong > > > > Add mailbox driver for Hi3660. > > > > Signed-off-by: Leo Yan > > Signed-off-by: Ruyi Wang > > Tested-by: Kaihua Zhong > > > > --- > >

[PATCH v4 5/7] completion: Add support for initializing completion with lockdep_map

Sometimes, we want to initialize completions with sparate lockdep maps to assign lock classes as desired. For example, the workqueue code needs to directly manage lockdep maps, since only the code is aware of how to classify lockdep maps properly. Provide additional macros initializing

[PATCH v4 5/7] completion: Add support for initializing completion with lockdep_map

Sometimes, we want to initialize completions with sparate lockdep maps to assign lock classes as desired. For example, the workqueue code needs to directly manage lockdep maps, since only the code is aware of how to classify lockdep maps properly. Provide additional macros initializing

[PATCH v4 1/7] block: use DECLARE_COMPLETION_ONSTACK in submit_bio_wait

From: Christoph Hellwig Simplify the code by getting rid of the submit_bio_ret structure. Signed-off-by: Christoph Hellwig --- block/bio.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/block/bio.c b/block/bio.c index

[PATCH v4 7/7] block: Assign a lock_class per gendisk used for wait_for_completion()

Darrick posted the following warning and Dave Chinner analyzed it: > == > WARNING: possible circular locking dependency detected > 4.14.0-rc1-fixes #1 Tainted: GW > -- > loop0/31693 is

[PATCH v4 1/7] block: use DECLARE_COMPLETION_ONSTACK in submit_bio_wait

From: Christoph Hellwig Simplify the code by getting rid of the submit_bio_ret structure. Signed-off-by: Christoph Hellwig --- block/bio.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/block/bio.c b/block/bio.c index 5f5472e..99d0ca5 100644 ---

[PATCH v4 7/7] block: Assign a lock_class per gendisk used for wait_for_completion()

Darrick posted the following warning and Dave Chinner analyzed it: > == > WARNING: possible circular locking dependency detected > 4.14.0-rc1-fixes #1 Tainted: GW > -- > loop0/31693 is

[PATCH v4 2/7] locking/lockdep: Add a boot parameter allowing unwind in cross-release and disable it by default

Johan Hovold reported a heavy performance regression caused by lockdep cross-release: > Boot time (from "Linux version" to login prompt) had in fact doubled > since 4.13 where it took 17 seconds (with my current config) compared to > the 35 seconds I now see with 4.14-rc4. > > I quick bisect

[PATCH v4 2/7] locking/lockdep: Add a boot parameter allowing unwind in cross-release and disable it by default

Johan Hovold reported a heavy performance regression caused by lockdep cross-release: > Boot time (from "Linux version" to login prompt) had in fact doubled > since 4.13 where it took 17 seconds (with my current config) compared to > the 35 seconds I now see with 4.14-rc4. > > I quick bisect

[PATCH v4 6/7] workqueue: Remove unnecessary acquisitions wrt workqueue flush

The workqueue added manual acquisitions to catch deadlock cases. Now crossrelease was introduced, some of those are redundant, since wait_for_completion() already includes the acquisition for itself. Removed it. Signed-off-by: Byungchul Park --- include/linux/workqueue.h

[PATCH v4 4/7] locking/lockdep: Introduce CONFIG_BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK

The boot parameter, crossrelease_fullstack, was introduced to control whether to enable unwind in cross-release or not. Add a Kconfig doing the same thing. Suggested-by: Ingo Molnar Signed-off-by: Byungchul Park --- kernel/locking/lockdep.c | 4

[PATCH v4 6/7] workqueue: Remove unnecessary acquisitions wrt workqueue flush

The workqueue added manual acquisitions to catch deadlock cases. Now crossrelease was introduced, some of those are redundant, since wait_for_completion() already includes the acquisition for itself. Removed it. Signed-off-by: Byungchul Park --- include/linux/workqueue.h | 4 ++--

[PATCH v4 4/7] locking/lockdep: Introduce CONFIG_BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK

The boot parameter, crossrelease_fullstack, was introduced to control whether to enable unwind in cross-release or not. Add a Kconfig doing the same thing. Suggested-by: Ingo Molnar Signed-off-by: Byungchul Park --- kernel/locking/lockdep.c | 4 lib/Kconfig.debug| 15

[PATCH v4 0/7] cross-release: Enhence performance and fix false positives

There are two things I didn't apply as Ingo suggested, since I didn't understand his intention exactly: 1. Adding 'Analyzed-by' tag at the 2nd patch 2. Using a inline function instead #define at the 7th patch Let me know if the above should still be applied. Changes from v3 - Exclude a

[PATCH v4 0/7] cross-release: Enhence performance and fix false positives

There are two things I didn't apply as Ingo suggested, since I didn't understand his intention exactly: 1. Adding 'Analyzed-by' tag at the 2nd patch 2. Using a inline function instead #define at the 7th patch Let me know if the above should still be applied. Changes from v3 - Exclude a

[PATCH v4 3/7] locking/lockdep: Remove the BROKEN flag from CONFIG_LOCKDEP_CROSSRELEASE and CONFIG_LOCKDEP_COMPLETIONS

Now that the performance regression is fixed, re-enable CONFIG_LOCKDEP_CROSSRELEASE=y and CONFIG_LOCKDEP_COMPLETIONS=y. Signed-off-by: Byungchul Park --- lib/Kconfig.debug | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug

[PATCH v4 3/7] locking/lockdep: Remove the BROKEN flag from CONFIG_LOCKDEP_CROSSRELEASE and CONFIG_LOCKDEP_COMPLETIONS

Now that the performance regression is fixed, re-enable CONFIG_LOCKDEP_CROSSRELEASE=y and CONFIG_LOCKDEP_COMPLETIONS=y. Signed-off-by: Byungchul Park --- lib/Kconfig.debug | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index

[PATCH 1/2] gpio: gpiolib: Expand sleep tolerance to include controller reset

Reset tolerance is added to gpiolib with the introduction of a new pinconf parameter propagating the request to hardware. The existing persistence support for sleep is augmented to include reset tolerance if the GPIO driver provides it. Persistence continues to be enabled by default; in-kernel

[PATCH 1/2] gpio: gpiolib: Expand sleep tolerance to include controller reset

Reset tolerance is added to gpiolib with the introduction of a new pinconf parameter propagating the request to hardware. The existing persistence support for sleep is augmented to include reset tolerance if the GPIO driver provides it. Persistence continues to be enabled by default; in-kernel

[PATCH 2/2] gpio: aspeed: Add support for reset tolerance

Use the new pinconf parameter for reset tolerance to expose the associated capability of the Aspeed GPIO controller. Signed-off-by: Andrew Jeffery --- drivers/gpio/gpio-aspeed.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff

[PATCH 0/2] gpio: Expose reset tolerance capability

Hello, This short series enables GPIO state persistence across controller resets, modifying gpiolib to expose control of the behaviour and providing an initial implementation in the Aspeed GPIO controller. This is a follow-up to the initial RFC series[1], which had some undesirable features (and

[PATCH 2/2] gpio: aspeed: Add support for reset tolerance

Use the new pinconf parameter for reset tolerance to expose the associated capability of the Aspeed GPIO controller. Signed-off-by: Andrew Jeffery --- drivers/gpio/gpio-aspeed.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git

[PATCH 0/2] gpio: Expose reset tolerance capability

Hello, This short series enables GPIO state persistence across controller resets, modifying gpiolib to expose control of the behaviour and providing an initial implementation in the Aspeed GPIO controller. This is a follow-up to the initial RFC series[1], which had some undesirable features (and

Re: Kernel error messages: leds fujitsu::radio_led: Setting an LED's brightness failed

> > - Investigating the E LED. This requires taking a look at the DSDT > > dump from your laptop and searching for clues as to how this LED is > > handled. I will be happy to do that, but again, no promises about > > how much time it will take. (And given the nature of this task,

Re: Kernel error messages: leds fujitsu::radio_led: Setting an LED's brightness failed

> > - Investigating the E LED. This requires taking a look at the DSDT > > dump from your laptop and searching for clues as to how this LED is > > handled. I will be happy to do that, but again, no promises about > > how much time it will take. (And given the nature of this task,

Re: [PATCH v7 2/2] crypto: s5p-sss: Add HASH support for Exynos

Hi Kamil, I'll just answer to your question, all the comments from you are accepted, please send a new version with the minor fixes, hopefully the change will be included into v4.15-rc. On 10/24/2017 02:27 PM, Kamil Konieczny wrote: > Hi Vladimir, > > Thank you for review, I will apply almost

Re: [PATCH v7 2/2] crypto: s5p-sss: Add HASH support for Exynos

Hi Kamil, I'll just answer to your question, all the comments from you are accepted, please send a new version with the minor fixes, hopefully the change will be included into v4.15-rc. On 10/24/2017 02:27 PM, Kamil Konieczny wrote: > Hi Vladimir, > > Thank you for review, I will apply almost

[PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

Radio LED detection method implemented in commit 4f62568c1fcf ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it causes a radio LED to be erroneously detected on a Fujitsu Lifebook E751 which has a slide switch (and thus no radio LED). Use bit 17 of flags_supported (the value

[PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

Radio LED detection method implemented in commit 4f62568c1fcf ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it causes a radio LED to be erroneously detected on a Fujitsu Lifebook E751 which has a slide switch (and thus no radio LED). Use bit 17 of flags_supported (the value

Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init()

Hi Juergen, At 10/23/2017 09:49 PM, Juergen Gross wrote: Don't try to set the static virt_spin_lock_key to a value before jump_label_init() has been called, as this will result in a WARN(). Solve the problem by introducing a new lock_init() hook called after jump_label_init() instead of doing

Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init()

Hi Juergen, At 10/23/2017 09:49 PM, Juergen Gross wrote: Don't try to set the static virt_spin_lock_key to a value before jump_label_init() has been called, as this will result in a WARN(). Solve the problem by introducing a new lock_init() hook called after jump_label_init() instead of doing

Re: [PATCH] drivers/net: wan/sbni: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:47:00 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: David Howells

Re: [PATCH] drivers/net: wan/sbni: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:47:00 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: David Howells > Cc:

Re: [PATCH v7 1/2] crypto: s5p-sss: change spaces into tabs in defines

Hi Kamil, On 10/24/2017 01:19 PM, Kamil Konieczny wrote: > Hi Vladimir, > > Thank you for review. > > On 22.10.2017 12:18, Vladimir Zapolskiy wrote: >> Hi Kamil, >> >> On 10/17/2017 02:28 PM, Kamil Konieczny wrote: >>> change spaces into tabs in defines >> >> Here a grammatically correct

Re: [PATCH v7 1/2] crypto: s5p-sss: change spaces into tabs in defines

Hi Kamil, On 10/24/2017 01:19 PM, Kamil Konieczny wrote: > Hi Vladimir, > > Thank you for review. > > On 22.10.2017 12:18, Vladimir Zapolskiy wrote: >> Hi Kamil, >> >> On 10/17/2017 02:28 PM, Kamil Konieczny wrote: >>> change spaces into tabs in defines >> >> Here a grammatically correct

Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG

From: Herbert Xu Date: Wed, 25 Oct 2017 12:05:41 +0800 > On Tue, Oct 24, 2017 at 05:48:42PM +0900, David Miller wrote: >> >> This discussion has happened before. >> >> But I'll explain the conclusion here for your benefit. >> >> BUG_ON() is a statement and

Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG

From: Herbert Xu Date: Wed, 25 Oct 2017 12:05:41 +0800 > On Tue, Oct 24, 2017 at 05:48:42PM +0900, David Miller wrote: >> >> This discussion has happened before. >> >> But I'll explain the conclusion here for your benefit. >> >> BUG_ON() is a statement and everything inside of it will >>

Re: [PATCH] drivers/net: sis: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:46:52 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Francois

Re: [PATCH] drivers/net: sis: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:46:52 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Francois Romieu > Cc: Daniele

Re: [PATCH 1/3] driver: mailbox: add support for Hi3660

On Mon, Aug 7, 2017 at 2:47 PM, Zhong Kaihua wrote: > From: Kaihua Zhong > > Add mailbox driver for Hi3660. > > Signed-off-by: Leo Yan > Signed-off-by: Ruyi Wang > Tested-by: Kaihua Zhong

Re: [PATCH 1/3] driver: mailbox: add support for Hi3660

On Mon, Aug 7, 2017 at 2:47 PM, Zhong Kaihua wrote: > From: Kaihua Zhong > > Add mailbox driver for Hi3660. > > Signed-off-by: Leo Yan > Signed-off-by: Ruyi Wang > Tested-by: Kaihua Zhong > > --- > drivers/mailbox/Kconfig | 6 + > drivers/mailbox/Makefile | 2 + >

Re: [PATCH] net: atm/mpc: Stop using open-coded timer .data field

From: Kees Cook Date: Tue, 24 Oct 2017 01:46:45 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using an explicit static variable to hold > additional expiration details. > > Cc: "David S. Miller"

Re: [PATCH] net: atm/mpc: Stop using open-coded timer .data field

From: Kees Cook Date: Tue, 24 Oct 2017 01:46:45 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using an explicit static variable to hold > additional expiration details. > > Cc: "David S. Miller" > Cc: Bhumika Goyal > Cc:

Re: [PATCH] ipv6: esp6: use BUG_ON instead of if condition followed by BUG

On Tue, Oct 24, 2017 at 11:28:26AM -0500, Gustavo A. R. Silva wrote: > Use BUG_ON instead of if condition followed by BUG in esp_remove_trailer. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > net/ipv6/esp6.c | 3

Re: [PATCH] ipv6: esp6: use BUG_ON instead of if condition followed by BUG

On Tue, Oct 24, 2017 at 11:28:26AM -0500, Gustavo A. R. Silva wrote: > Use BUG_ON instead of if condition followed by BUG in esp_remove_trailer. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > net/ipv6/esp6.c | 3 +-- > 1 file changed, 1

Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG

On Tue, Oct 24, 2017 at 05:48:42PM +0900, David Miller wrote: > > This discussion has happened before. > > But I'll explain the conclusion here for your benefit. > > BUG_ON() is a statement and everything inside of it will > always execute. > > BUG_ON() is always preferred because it allows

Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG

On Tue, Oct 24, 2017 at 05:48:42PM +0900, David Miller wrote: > > This discussion has happened before. > > But I'll explain the conclusion here for your benefit. > > BUG_ON() is a statement and everything inside of it will > always execute. > > BUG_ON() is always preferred because it allows

Re: [PATCH] net: hsr: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:46:16 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Arvid Brodin

Re: [PATCH] net: af_packet: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:46:26 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "David S.

Re: [PATCH] net: hsr: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:46:16 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Arvid Brodin > Cc: "David S. Miller"

Re: [PATCH] net: af_packet: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:46:26 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "David S. Miller" > Cc: Eric Dumazet

Re: [PATCH v7] printk: hash addresses printed with %p

On Wed, Oct 25, 2017 at 5:49 AM, Tobin C. Harding wrote: > static_branch_disable(_ptr_secret) : Doesn't sleep, just atomic read > and set and maybe a WARN_ONCE. Are you sure about that? I just looked myself, and though there is a !HAVE_JUMP_LABEL ifdef that does what you

Re: [PATCH v7] printk: hash addresses printed with %p

On Wed, Oct 25, 2017 at 5:49 AM, Tobin C. Harding wrote: > static_branch_disable(_ptr_secret) : Doesn't sleep, just atomic read > and set and maybe a WARN_ONCE. Are you sure about that? I just looked myself, and though there is a !HAVE_JUMP_LABEL ifdef that does what you described, there's also

Re: [PATCH] net: dccp: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:46:09 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Adds a pointer back to

Re: [PATCH] net: dccp: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:46:09 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Adds a pointer back to the sock. > > Cc:

Re: [PATCH] net: ethernet/sfc: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:45:59 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Solarflare

Re: [PATCH] net: ethernet/sfc: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 24 Oct 2017 01:45:59 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Solarflare linux maintainers > Cc:

[PATCH v3 5/6] dt-bindings: add the rockchip,dual-channel for dw-mipi-dsi

Configure dsi slave channel when driving a panel which needs 2 DSI links. Signed-off-by: Nickey Yang --- .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v3 5/6] dt-bindings: add the rockchip,dual-channel for dw-mipi-dsi

Configure dsi slave channel when driving a panel which needs 2 DSI links. Signed-off-by: Nickey Yang --- .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

This patch correct Feedback divider setting: 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN 2、Due to the use of a "by 2 pre-scaler," the range of the feedback multiplication Feedback divider is limited to even division numbers, and Feedback divider must be greater than 12, less than 1000.

[PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

This patch correct Feedback divider setting: 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN 2、Due to the use of a "by 2 pre-scaler," the range of the feedback multiplication Feedback divider is limited to even division numbers, and Feedback divider must be greater than 12, less than 1000.

[PATCH v3 4/6] drm/rockchip/dsi: add dual mipi channel support

This patch add dual mipi channel support: 1.add definition of dsi1 register and grf operation. 2.dsi0 and dsi1 will work in master and slave mode when driving dual mipi panel. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 377

[PATCH v3 6/6] arm64: dts: rockchip: add mipi_dsi1 support for rk3399

This patch adds the mipi_dsi1 related needed information. e.g.: interrupts, grf, clocks, ports and so on. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 1 file changed, 39 insertions(+) diff --git

[PATCH v3 4/6] drm/rockchip/dsi: add dual mipi channel support

This patch add dual mipi channel support: 1.add definition of dsi1 register and grf operation. 2.dsi0 and dsi1 will work in master and slave mode when driving dual mipi panel. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 377

[PATCH v3 6/6] arm64: dts: rockchip: add mipi_dsi1 support for rk3399

This patch adds the mipi_dsi1 related needed information. e.g.: interrupts, grf, clocks, ports and so on. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 1 file changed, 39 insertions(+) diff --git

[PATCH v3 2/6] drm/rockchip/dsi: correct phy parameter setting

As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0> should depend on frequency,so fix it. Reviewed-by: Sean Paul Reviewed-by: Matthias Kaehlcke Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c |

[PATCH v3 1/6] drm/rockchip/dsi: Define and use macros for PHY register addresses

Replace the hardcoded register address numerical values with macros to clarify the code. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 129 ++--- 1 file changed, 85 insertions(+), 44 deletions(-) diff --git

[PATCH v3 2/6] drm/rockchip/dsi: correct phy parameter setting

As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0> should depend on frequency,so fix it. Reviewed-by: Sean Paul Reviewed-by: Matthias Kaehlcke Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 98 -- 1 file changed, 70

[PATCH v3 1/6] drm/rockchip/dsi: Define and use macros for PHY register addresses

Replace the hardcoded register address numerical values with macros to clarify the code. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 129 ++--- 1 file changed, 85 insertions(+), 44 deletions(-) diff --git

  1   2   3   4   5   6   7   8   9   10   >