[Patch v6 03/22] CIFS: SMBD: Add rdma mount option

From: Long Li Add "rdma" to CIFS mount options to connect to SMB Direct. Add checks to validate this is used on SMB 3.X dialects. To connect to SMBDirect, use "mount.cifs -o rdma,vers=3.x". At the time of this patch, 3.x can be 3.0, 3.02 or 3.1.1. Signed-off-by: Long Li

[Patch v6 03/22] CIFS: SMBD: Add rdma mount option

From: Long Li Add "rdma" to CIFS mount options to connect to SMB Direct. Add checks to validate this is used on SMB 3.X dialects. To connect to SMBDirect, use "mount.cifs -o rdma,vers=3.x". At the time of this patch, 3.x can be 3.0, 3.02 or 3.1.1. Signed-off-by: Long Li ---

[Patch v6 04/22] CIFS: SMBD: Add SMB Direct protocol initial values and constants

From: Long Li To prepare for protocol implementation, add constants and user-configurable values for the SMB Direct protocol. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 77 +

[Patch v6 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

From: Long Li If I/O size is larger than rdma_readwrite_threshold, use RDMA write for SMB read by specifying channel SMB2_CHANNEL_RDMA_V1 or SMB2_CHANNEL_RDMA_V1_INVALIDATE in the SMB packet, depending on SMB dialect used. Append a smbd_buffer_descriptor_v1 to the end of

[Patch v6 04/22] CIFS: SMBD: Add SMB Direct protocol initial values and constants

From: Long Li To prepare for protocol implementation, add constants and user-configurable values for the SMB Direct protocol. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 77 + fs/cifs/smbdirect.h | 21 +++ 2 files changed,

[Patch v6 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

From: Long Li If I/O size is larger than rdma_readwrite_threshold, use RDMA write for SMB read by specifying channel SMB2_CHANNEL_RDMA_V1 or SMB2_CHANNEL_RDMA_V1_INVALIDATE in the SMB packet, depending on SMB dialect used. Append a smbd_buffer_descriptor_v1 to the end of the SMB packet and fill

[Patch v6 13/22] CIFS: SMBD: Set SMB Direct maximum read or write size for I/O

From: Long Li When connecting over SMB Direct, the transport negotiates its maximum I/O sizes with the server and determines how to choose to do RDMA send/recv vs read/write. Expose these maximum I/O sizes to upper layer so we will get the correct sized payloads.

[Patch v6 13/22] CIFS: SMBD: Set SMB Direct maximum read or write size for I/O

From: Long Li When connecting over SMB Direct, the transport negotiates its maximum I/O sizes with the server and determines how to choose to do RDMA send/recv vs read/write. Expose these maximum I/O sizes to upper layer so we will get the correct sized payloads. Signed-off-by: Long Li ---

[Patch v6 07/22] CIFS: SMBD: Implement function to create a SMB Direct connection

From: Long Li The upper layer calls this function to connect to peer through SMB Direct. Each SMB Direct connection is based on a RDMA RC Queue Pair. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 17 + 1 file changed, 17

[Patch v6 09/22] CIFS: SMBD: Implement function to reconnect to a SMB Direct transport

From: Long Li Add function to implement a reconnect to SMB Direct. This involves tearing down the current connection and establishing/negotiating a new connection. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 36

[Patch v6 07/22] CIFS: SMBD: Implement function to create a SMB Direct connection

From: Long Li The upper layer calls this function to connect to peer through SMB Direct. Each SMB Direct connection is based on a RDMA RC Queue Pair. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 17 + 1 file changed, 17 insertions(+) diff --git a/fs/cifs/smbdirect.c

[Patch v6 09/22] CIFS: SMBD: Implement function to reconnect to a SMB Direct transport

From: Long Li Add function to implement a reconnect to SMB Direct. This involves tearing down the current connection and establishing/negotiating a new connection. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 36 1 file changed, 36 insertions(+) diff

[Patch v6 12/22] CIFS: SMBD: Upper layer destroys SMB Direct session on shutdown or umount

From: Long Li When upper layer wants to umount, make it call shutdown on transport when SMB Direct is used. Signed-off-by: Long Li --- fs/cifs/connect.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/cifs/connect.c

[Patch v6 11/22] CIFS: SMBD: Implement function to destroy a SMB Direct connection

From: Long Li Add function to tear down a SMB Direct connection. This is used by upper layer to free all SMB Direct connection and transport resources. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 16 1 file changed, 16

[Patch v6 12/22] CIFS: SMBD: Upper layer destroys SMB Direct session on shutdown or umount

From: Long Li When upper layer wants to umount, make it call shutdown on transport when SMB Direct is used. Signed-off-by: Long Li --- fs/cifs/connect.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 8ca3c13..23f10d1

[Patch v6 11/22] CIFS: SMBD: Implement function to destroy a SMB Direct connection

From: Long Li Add function to tear down a SMB Direct connection. This is used by upper layer to free all SMB Direct connection and transport resources. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 16 1 file changed, 16 insertions(+) diff --git a/fs/cifs/smbdirect.c

[Patch v6 22/22] CIFS: SMBD: Add SMB Direct debug counters

From: Long Li For debugging and troubleshooting, export SMBDirect debug counters to /proc/fs/cifs/DebugData. Signed-off-by: Long Li --- fs/cifs/cifs_debug.c | 66 1 file changed, 66 insertions(+)

[Patch v6 00/22] CIFS: Implement SMB Direct protocol

From: Long Li Starting with SMB2 dialect 3.0, Microsoft introduced SMB Direct transport protocol for transferring upper layer (SMB2) payload over RDMA via Infiniband, RoCE or iWARP. The prococol is published in [MS-SMBD]

[Patch v6 01/22] CIFS: SMBD: Add parameter rdata to smb2_new_read_req

From: Long Li This patch is for preparing upper layer for doing SMB read via RDMA write. When the SMB read packet header is assembled, SMB Direct code needs to know the I/O layout if this request is to use a RDMA write. rdata has all the information of I/O layout for

[Patch v6 17/22] CIFS: SMBD: Upper layer sends data via RDMA send

From: Long Li With SMB Direct connected, use it for sending data via RDMA send. Signed-off-by: Long Li --- fs/cifs/transport.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/fs/cifs/transport.c

[Patch v6 22/22] CIFS: SMBD: Add SMB Direct debug counters

From: Long Li For debugging and troubleshooting, export SMBDirect debug counters to /proc/fs/cifs/DebugData. Signed-off-by: Long Li --- fs/cifs/cifs_debug.c | 66 1 file changed, 66 insertions(+) diff --git a/fs/cifs/cifs_debug.c

[Patch v6 00/22] CIFS: Implement SMB Direct protocol

From: Long Li Starting with SMB2 dialect 3.0, Microsoft introduced SMB Direct transport protocol for transferring upper layer (SMB2) payload over RDMA via Infiniband, RoCE or iWARP. The prococol is published in [MS-SMBD] (https://msdn.microsoft.com/en-us/library/hh536346.aspx). Patch v2 added

[Patch v6 01/22] CIFS: SMBD: Add parameter rdata to smb2_new_read_req

From: Long Li This patch is for preparing upper layer for doing SMB read via RDMA write. When the SMB read packet header is assembled, SMB Direct code needs to know the I/O layout if this request is to use a RDMA write. rdata has all the information of I/O layout for memory registration. Add

[Patch v6 17/22] CIFS: SMBD: Upper layer sends data via RDMA send

From: Long Li With SMB Direct connected, use it for sending data via RDMA send. Signed-off-by: Long Li --- fs/cifs/transport.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index 7efbab0..1b51d08 100644 ---

[Patch v6 08/22] CIFS: SMBD: Upper layer connects to SMBDirect session

From: Long Li When "rdma" is specified in the mount option, make CIFS connect to SMB Direct. Signed-off-by: Long Li --- fs/cifs/connect.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git

[Patch v6 08/22] CIFS: SMBD: Upper layer connects to SMBDirect session

From: Long Li When "rdma" is specified in the mount option, make CIFS connect to SMB Direct. Signed-off-by: Long Li --- fs/cifs/connect.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index

[Patch v6 15/22] CIFS: SMBD: Upper layer receives data via RDMA receive

From: Long Li With SMB Direct connected, use it for receiving data via RDMA receive. Signed-off-by: Long Li --- fs/cifs/connect.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index

[Patch v6 15/22] CIFS: SMBD: Upper layer receives data via RDMA receive

From: Long Li With SMB Direct connected, use it for receiving data via RDMA receive. Signed-off-by: Long Li --- fs/cifs/connect.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 23f10d1..6325062 100644 ---

[Patch v6 16/22] CIFS: SMBD: Implement function to send data via RDMA send

From: Long Li The transport doesn't maintain send buffers or send queue for transferring payload via RDMA send. There is no data copy in the transport on send. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 246

[Patch v6 16/22] CIFS: SMBD: Implement function to send data via RDMA send

From: Long Li The transport doesn't maintain send buffers or send queue for transferring payload via RDMA send. There is no data copy in the transport on send. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 246 fs/cifs/smbdirect.h | 3

[Patch v6 18/22] CIFS: SMBD: Implement RDMA memory registration

From: Long Li Memory registration is used for transferring payload via RDMA read or write. After I/O is done, memory registrations are recovered and reused. This process can be time consuming and is done in a work queue at the same time or after I/O is returned to upper

[Patch v6 05/22] CIFS: SMBD: Establish SMB Direct connection

From: Long Li Add code to implement the core functions to establish a SMB Direct connection. 1. Establish an RDMA connection to SMB server. 2. Negotiate and setup SMB Direct protocol. 3. Implement idle connection timer and credit management. SMB Direct is enabled by

[Patch v6 18/22] CIFS: SMBD: Implement RDMA memory registration

From: Long Li Memory registration is used for transferring payload via RDMA read or write. After I/O is done, memory registrations are recovered and reused. This process can be time consuming and is done in a work queue at the same time or after I/O is returned to upper layer. Signed-off-by:

[Patch v6 05/22] CIFS: SMBD: Establish SMB Direct connection

From: Long Li Add code to implement the core functions to establish a SMB Direct connection. 1. Establish an RDMA connection to SMB server. 2. Negotiate and setup SMB Direct protocol. 3. Implement idle connection timer and credit management. SMB Direct is enabled by setting

[Patch v6 20/22] CIFS: SMBD: Read correct returned data length for RDMA write (SMB read) I/O

From: Long Li This patch is for preparing upper layer doing SMB read via RDMA write. When RDMA write is used for SMB read, the returned data length is in DataRemaining in the response packet. Reading it properly by adding a parameter to specifiy where the returned data

[Patch v6 06/22] CIFS: SMBD: export protocol initial values

From: Long Li For use-configurable SMB Direct protocol values, export them to /proc/fs/cifs. Signed-off-by: Long Li --- fs/cifs/cifs_debug.c | 79 1 file changed, 79 insertions(+) diff --git

[Patch v6 20/22] CIFS: SMBD: Read correct returned data length for RDMA write (SMB read) I/O

From: Long Li This patch is for preparing upper layer doing SMB read via RDMA write. When RDMA write is used for SMB read, the returned data length is in DataRemaining in the response packet. Reading it properly by adding a parameter to specifiy where the returned data length is. Add the

[Patch v6 06/22] CIFS: SMBD: export protocol initial values

From: Long Li For use-configurable SMB Direct protocol values, export them to /proc/fs/cifs. Signed-off-by: Long Li --- fs/cifs/cifs_debug.c | 79 1 file changed, 79 insertions(+) diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c

[Patch v6 02/22] CIFS: SMBD: Introduce kernel config option CONFIG_CIFS_SMB_DIRECT

From: Long Li SMB Direct is a protocol for transferring SMB packets over RDMA. It was introduced with Windows Serer 2012 and SMB 3.0. With CONFIG_CIFS_SMB_DIRECT=y, SMB Direct code is built as part of CIFS. Signed-off-by: Long Li ---

[Patch v6 19/22] CIFS: SMBD: Upper layer performs SMB write via RDMA read through memory registration

From: Long Li When sending I/O, if size is larger than rdma_readwrite_threshold we prepare to send SMB write packet for a RDMA read via memory registration. The actual I/O is done by remote peer through local RDMA hardware. Modify the relevant fields in the packet

[Patch v6 02/22] CIFS: SMBD: Introduce kernel config option CONFIG_CIFS_SMB_DIRECT

From: Long Li SMB Direct is a protocol for transferring SMB packets over RDMA. It was introduced with Windows Serer 2012 and SMB 3.0. With CONFIG_CIFS_SMB_DIRECT=y, SMB Direct code is built as part of CIFS. Signed-off-by: Long Li --- fs/cifs/Kconfig | 8 1 file changed, 8

[Patch v6 19/22] CIFS: SMBD: Upper layer performs SMB write via RDMA read through memory registration

From: Long Li When sending I/O, if size is larger than rdma_readwrite_threshold we prepare to send SMB write packet for a RDMA read via memory registration. The actual I/O is done by remote peer through local RDMA hardware. Modify the relevant fields in the packet accordingly, and append a

[Patch v6 10/22] CIFS: SMBD: Upper layer reconnects to SMB Direct session

From: Long Li Do a reconnect on SMB Direct when it is used as the connection. Reconnect can happen for many reasons and it's mostly the decision of SMB2 upper layer. Signed-off-by: Long Li --- fs/cifs/connect.c | 7 +++ 1 file changed, 7

[Patch v6 14/22] CIFS: SMBD: Implement function to receive data via RDMA receive

From: Long Li On the receive path, the transport maintains receive buffers and a reassembly queue for transferring payload via RDMA recv. There is data copy in the transport on recv when it copies the payload to upper layer. The transport recognizes the RFC1002 header

[Patch v6 10/22] CIFS: SMBD: Upper layer reconnects to SMB Direct session

From: Long Li Do a reconnect on SMB Direct when it is used as the connection. Reconnect can happen for many reasons and it's mostly the decision of SMB2 upper layer. Signed-off-by: Long Li --- fs/cifs/connect.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fs/cifs/connect.c

[Patch v6 14/22] CIFS: SMBD: Implement function to receive data via RDMA receive

From: Long Li On the receive path, the transport maintains receive buffers and a reassembly queue for transferring payload via RDMA recv. There is data copy in the transport on recv when it copies the payload to upper layer. The transport recognizes the RFC1002 header length use in the SMB

[PATCH 0/2] kbuild: move dtb-y and CONFIG_OF_ALL_DTBS to Kbuild core to fix some issues

This series applies on top of my previous cleanup patch: https://patchwork.kernel.org/patch/10038167/ This series must go to the same branch, so I am sending this to DT ML. Masahiro Yamada (2): MIPS: dts: remove bogus bcm96358nb4ser.dtb from dtb-y entry kbuild: handle dtb-y and

[PATCH 2/2] kbuild: handle dtb-y and CONFIG_OF_ALL_DTBS natively in Makefile.lib

If CONFIG_OF_ALL_DTBS is enabled, "make ARCH=arm64 dtbs" compiles each DTB twice; one from arch/arm64/boot/dts/*/Makefile and the other from the dtb-$(CONFIG_OF_ALL_DTBS) line in arch/arm64/boot/dts/Makefile. It could be a race problem when building DTBS in parallel. Another minor issue is

[PATCH 1/2] MIPS: dts: remove bogus bcm96358nb4ser.dtb from dtb-y entry

arch/mips/boot/dts/brcm/bcm96358nb4ser.dts does not exist, so we cannot build bcm96358nb4ser.dtb . Signed-off-by: Masahiro Yamada --- arch/mips/boot/dts/brcm/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/mips/boot/dts/brcm/Makefile

[PATCH 0/2] kbuild: move dtb-y and CONFIG_OF_ALL_DTBS to Kbuild core to fix some issues

This series applies on top of my previous cleanup patch: https://patchwork.kernel.org/patch/10038167/ This series must go to the same branch, so I am sending this to DT ML. Masahiro Yamada (2): MIPS: dts: remove bogus bcm96358nb4ser.dtb from dtb-y entry kbuild: handle dtb-y and

[PATCH 2/2] kbuild: handle dtb-y and CONFIG_OF_ALL_DTBS natively in Makefile.lib

If CONFIG_OF_ALL_DTBS is enabled, "make ARCH=arm64 dtbs" compiles each DTB twice; one from arch/arm64/boot/dts/*/Makefile and the other from the dtb-$(CONFIG_OF_ALL_DTBS) line in arch/arm64/boot/dts/Makefile. It could be a race problem when building DTBS in parallel. Another minor issue is

[PATCH 1/2] MIPS: dts: remove bogus bcm96358nb4ser.dtb from dtb-y entry

arch/mips/boot/dts/brcm/bcm96358nb4ser.dts does not exist, so we cannot build bcm96358nb4ser.dtb . Signed-off-by: Masahiro Yamada --- arch/mips/boot/dts/brcm/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/mips/boot/dts/brcm/Makefile b/arch/mips/boot/dts/brcm/Makefile index

[PATCH 2/5] tty: serial: jsm: add blank line after declarations

This patch fixes checkpatch.pl warning: Missing a blank line after declarations. Signed-off-by: Gimcuan Hui --- drivers/tty/serial/jsm/jsm_tty.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c index

[PATCH 2/5] tty: serial: jsm: add blank line after declarations

This patch fixes checkpatch.pl warning: Missing a blank line after declarations. Signed-off-by: Gimcuan Hui --- drivers/tty/serial/jsm/jsm_tty.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c index

[PATCH 4/5] tty: serial: jsm: fix coding style

This patch fixes the checkpatch.pl complain: ERROR: else should follow close brace '}'. Signed-off-by: Gimcuan Hui --- drivers/tty/serial/jsm/jsm_tty.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/jsm/jsm_tty.c

[PATCH 5/5] tty: serial: jsm: add space before the open parenthesis '('

This patch fixes the checkpatch.pl complains: space required before the open parenthesis '('. Signed-off-by: Gimcuan Hui --- drivers/tty/serial/jsm/jsm_tty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/jsm/jsm_tty.c

[PATCH 4/5] tty: serial: jsm: fix coding style

This patch fixes the checkpatch.pl complain: ERROR: else should follow close brace '}'. Signed-off-by: Gimcuan Hui --- drivers/tty/serial/jsm/jsm_tty.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c

[PATCH 5/5] tty: serial: jsm: add space before the open parenthesis '('

This patch fixes the checkpatch.pl complains: space required before the open parenthesis '('. Signed-off-by: Gimcuan Hui --- drivers/tty/serial/jsm/jsm_tty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/jsm/jsm_tty.c

[PATCH 3/5] tty: serial: jsm: delete space between function name and '('

This patch fixes checkpatch.pl warning: space prohibited between function name and open parenthesis '('. Signed-off-by: Gimcuan Hui --- drivers/tty/serial/jsm/jsm_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/jsm/jsm_tty.c

[PATCH 0/5] TTY/JSM coding style fixes

This patch set fixes several warnings and errors reported by checkpatch.pl. Gimcuan Hui (5): tty: serial: jsm: change the type of local variable tty: serial: jsm: add blank line after declarations tty: serial: jsm: delete space between function name and '(' tty: serial: jsm: fix coding

[PATCH 1/5] tty: serial: jsm: change the type of local variable

The return type of jsm_get_mstat was int, and the local var result was for the return should be int, make the change. This patch fixes the checkpatch.pl warning: Prefer 'unsigned int' to bare use of 'unsigned'. Signed-off-by: Gimcuan Hui --- drivers/tty/serial/jsm/jsm_tty.c

[PATCH 3/5] tty: serial: jsm: delete space between function name and '('

This patch fixes checkpatch.pl warning: space prohibited between function name and open parenthesis '('. Signed-off-by: Gimcuan Hui --- drivers/tty/serial/jsm/jsm_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/jsm/jsm_tty.c

[PATCH 0/5] TTY/JSM coding style fixes

This patch set fixes several warnings and errors reported by checkpatch.pl. Gimcuan Hui (5): tty: serial: jsm: change the type of local variable tty: serial: jsm: add blank line after declarations tty: serial: jsm: delete space between function name and '(' tty: serial: jsm: fix coding

[PATCH 1/5] tty: serial: jsm: change the type of local variable

The return type of jsm_get_mstat was int, and the local var result was for the return should be int, make the change. This patch fixes the checkpatch.pl warning: Prefer 'unsigned int' to bare use of 'unsigned'. Signed-off-by: Gimcuan Hui --- drivers/tty/serial/jsm/jsm_tty.c | 2 +- 1 file

[PATCH] thunderbolt: tb: fix use after free in tb_activate_pcie_devices

Add a ̣̣continue statement in order to avoid using a previously free'd pointer tunnel in list_add. Addresses-Coverity-ID: 1415336 Fixes: 9d3cce0b6136 ("thunderbolt: Introduce thunderbolt bus and connection manager") Signed-off-by: Gustavo A. R. Silva ---

[PATCH] thunderbolt: tb: fix use after free in tb_activate_pcie_devices

Add a ̣̣continue statement in order to avoid using a previously free'd pointer tunnel in list_add. Addresses-Coverity-ID: 1415336 Fixes: 9d3cce0b6136 ("thunderbolt: Introduce thunderbolt bus and connection manager") Signed-off-by: Gustavo A. R. Silva --- drivers/thunderbolt/tb.c | 1 + 1 file

Re: [PATCH] net/mlx5e/core/en_fs: fix pointer dereference after free in mlx5e_execute_l2_action

On Sat, Nov 4, 2017 at 8:54 PM, Gustavo A. R. Silva wrote: > hn is being kfree'd in mlx5e_del_l2_from_hash and then dereferenced > by accessing hn->ai.addr > > Fix this by copying the MAC address into a local variable for its safe use > in all possible execution paths

Re: [PATCH] net/mlx5e/core/en_fs: fix pointer dereference after free in mlx5e_execute_l2_action

On Sat, Nov 4, 2017 at 8:54 PM, Gustavo A. R. Silva wrote: > hn is being kfree'd in mlx5e_del_l2_from_hash and then dereferenced > by accessing hn->ai.addr > > Fix this by copying the MAC address into a local variable for its safe use > in all possible execution paths within function

[PATCH v4] tty: serial: meson: allow baud-rates lower than 9600

Devices like DCF77 receivers need the baud-rate to be as low as 50. I have tested this on a Meson GXL device with uart_A. Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Carlo Caione Cc: Kevin Hilman Cc:

[PATCH v4] tty: serial: meson: allow baud-rates lower than 9600

Devices like DCF77 receivers need the baud-rate to be as low as 50. I have tested this on a Meson GXL device with uart_A. Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Carlo Caione Cc: Kevin Hilman Cc: linux-amlo...@lists.infradead.org Cc: linux-arm-ker...@lists.infradead.org Cc:

Re: [PATCH 3.10 000/139] 3.10.108-stable review

On Thu, Nov 02, 2017 at 07:12:00AM +0100, Willy Tarreau wrote: >Hi Guenter, > >On Wed, Nov 01, 2017 at 06:21:13PM -0700, Guenter Roeck wrote: >> drivers/s390/scsi/zfcp_scsi.c: In function 'zfcp_task_mgmt_function': >> drivers/s390/scsi/zfcp_scsi.c:298:4: error: too many arguments to function >>

Re: [PATCH 3.10 000/139] 3.10.108-stable review

On Thu, Nov 02, 2017 at 07:12:00AM +0100, Willy Tarreau wrote: >Hi Guenter, > >On Wed, Nov 01, 2017 at 06:21:13PM -0700, Guenter Roeck wrote: >> drivers/s390/scsi/zfcp_scsi.c: In function 'zfcp_task_mgmt_function': >> drivers/s390/scsi/zfcp_scsi.c:298:4: error: too many arguments to function >>

Re: [PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

Am Samstag, 4. November 2017 14:13:52 CET schrieb Greg Kroah-Hartman: What changed from v2? Nothing. I just re-based the patch on a fresh git clone as you couldn't merge v2. And I need a real name as the author of the patch :( Damn, sorry about that. Will do a v4.

Re: [PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

Am Samstag, 4. November 2017 14:13:52 CET schrieb Greg Kroah-Hartman: What changed from v2? Nothing. I just re-based the patch on a fresh git clone as you couldn't merge v2. And I need a real name as the author of the patch :( Damn, sorry about that. Will do a v4.

Re: [PATCH v3] scsi: require CAP_SYS_ADMIN to write to procfs interface

On 11/05/2017 01:56 PM, Aleksa Sarai wrote: Previously, the only capability effectively required to operate on the /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, having an fsuid of GLOBAL_ROOT_UID was enough). This means that semi-privileged processes could interfere with

Re: [PATCH v3] scsi: require CAP_SYS_ADMIN to write to procfs interface

On 11/05/2017 01:56 PM, Aleksa Sarai wrote: Previously, the only capability effectively required to operate on the /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, having an fsuid of GLOBAL_ROOT_UID was enough). This means that semi-privileged processes could interfere with

[PATCH] net/mlx5e/core/en_fs: fix pointer dereference after free in mlx5e_execute_l2_action

hn is being kfree'd in mlx5e_del_l2_from_hash and then dereferenced by accessing hn->ai.addr Fix this by copying the MAC address into a local variable for its safe use in all possible execution paths within function mlx5e_execute_l2_action. Addresses-Coverity-ID: 1417789 Fixes: eeb66cdb6826

[PATCH] net/mlx5e/core/en_fs: fix pointer dereference after free in mlx5e_execute_l2_action

hn is being kfree'd in mlx5e_del_l2_from_hash and then dereferenced by accessing hn->ai.addr Fix this by copying the MAC address into a local variable for its safe use in all possible execution paths within function mlx5e_execute_l2_action. Addresses-Coverity-ID: 1417789 Fixes: eeb66cdb6826

Re: [f2fs-dev] [PATCH 2/2] f2fs: stop all the operations by cp_error flag

Hi Jaegeuk, On 2017/10/24 17:51, Chao Yu wrote: > On 2017/10/24 6:14, Jaegeuk Kim wrote: >> This patch replaces to use cp_error flag instead of RDONLY for quota off. We should convert error number with block_page_mkwrite_return in .page_mkwrite, otherwise generic/019 will cause a deadlock issue

Re: [f2fs-dev] [PATCH 2/2] f2fs: stop all the operations by cp_error flag

Hi Jaegeuk, On 2017/10/24 17:51, Chao Yu wrote: > On 2017/10/24 6:14, Jaegeuk Kim wrote: >> This patch replaces to use cp_error flag instead of RDONLY for quota off. We should convert error number with block_page_mkwrite_return in .page_mkwrite, otherwise generic/019 will cause a deadlock issue

[PATCH 2/2] staging: greybus: loopback: convert loopback to use generic async operations

Loopback has its own internal method for tracking and timing out asynchronous operations however previous patches make it possible to use functionality provided by operation.c to do this instead. Using the code in operation.c means we can completely subtract the timer, the work-queue, the kref and

[PATCH 2/2] staging: greybus: loopback: convert loopback to use generic async operations

Loopback has its own internal method for tracking and timing out asynchronous operations however previous patches make it possible to use functionality provided by operation.c to do this instead. Using the code in operation.c means we can completely subtract the timer, the work-queue, the kref and

[PATCH 1/2] staging: greybus: operation: add private data with get/set accessors

Asynchronous operation completion handler's lives are made easier if there is a generic pointer that can store private data associated with the operation. This patch adds a pointer field to operation.h and get/set methods to access that pointer. Signed-off-by: Bryan O'Donoghue

[PATCH 0/2] Convert greybus loopback to core async API

dbec27298b0d ('staging: greybus: operation: add generic timeout support') gives the ability to remove lots of the asynchronous operation code in loopback. Kees is also doing a cleanup of timer code which for loopback will go away when converting to the core API. These two patches kill two birds

[PATCH 1/2] staging: greybus: operation: add private data with get/set accessors

Asynchronous operation completion handler's lives are made easier if there is a generic pointer that can store private data associated with the operation. This patch adds a pointer field to operation.h and get/set methods to access that pointer. Signed-off-by: Bryan O'Donoghue Cc: Johan Hovold

[PATCH 0/2] Convert greybus loopback to core async API

dbec27298b0d ('staging: greybus: operation: add generic timeout support') gives the ability to remove lots of the asynchronous operation code in loopback. Kees is also doing a cleanup of timer code which for loopback will go away when converting to the core API. These two patches kill two birds

[PATCH v4 1/1] xdp: Sample xdp program implementing ip forward

From: Christina Jacob Implements port to port forwarding with route table and arp table lookup for ipv4 packets using bpf_redirect helper function and lpm_trie map. Signed-off-by: Christina Jacob --- samples/bpf/Makefile |

[PATCH v4 0/1] XDP program for ip forward

From: Christina Jacob The patch below implements port to port forwarding through route table and arp table lookup for ipv4 packets using bpf_redirect helper function and lpm_trie map. This has an improved performance over the normal kernel stack ip forward.

[PATCH v4 0/1] XDP program for ip forward

From: Christina Jacob The patch below implements port to port forwarding through route table and arp table lookup for ipv4 packets using bpf_redirect helper function and lpm_trie map. This has an improved performance over the normal kernel stack ip forward. Implementation details.

[PATCH v4 1/1] xdp: Sample xdp program implementing ip forward

From: Christina Jacob Implements port to port forwarding with route table and arp table lookup for ipv4 packets using bpf_redirect helper function and lpm_trie map. Signed-off-by: Christina Jacob --- samples/bpf/Makefile | 4 + samples/bpf/xdp_router_ipv4_kern.c | 186

Re: [PATCH] kbuild: Set KBUILD_CFLAGS before incl. arch Makefile

2017-11-03 6:26 GMT+09:00 Nick Desaulniers : > From: Chris Fries > > Set the clang KBUILD_CFLAGS up before including arch/ Makefiles, > so that ld-options (etc.) can work correctly. ld-option is only used for arch/{arm64,powerpc}/Makefile

Re: [PATCH] kbuild: Set KBUILD_CFLAGS before incl. arch Makefile

2017-11-03 6:26 GMT+09:00 Nick Desaulniers : > From: Chris Fries > > Set the clang KBUILD_CFLAGS up before including arch/ Makefiles, > so that ld-options (etc.) can work correctly. ld-option is only used for arch/{arm64,powerpc}/Makefile arch/arm64/Makefile: ifeq ($(call ld-option,

Re: [RFC -mm] mm, userfaultfd, THP: Avoid waiting when PMD under THP migration

On Fri, Nov 3, 2017 at 11:00 PM, Zi Yan wrote: > On 3 Nov 2017, at 3:52, Huang, Ying wrote: > >> From: Huang Ying >> >> If THP migration is enabled, the following situation is possible, >> >> - A THP is mapped at source address >> - Migration is

Re: [RFC -mm] mm, userfaultfd, THP: Avoid waiting when PMD under THP migration

On Fri, Nov 3, 2017 at 11:00 PM, Zi Yan wrote: > On 3 Nov 2017, at 3:52, Huang, Ying wrote: > >> From: Huang Ying >> >> If THP migration is enabled, the following situation is possible, >> >> - A THP is mapped at source address >> - Migration is started to move the THP to another node >> - Page

[PATCH v3] scsi: require CAP_SYS_ADMIN to write to procfs interface

Previously, the only capability effectively required to operate on the /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, having an fsuid of GLOBAL_ROOT_UID was enough). This means that semi-privileged processes could interfere with core components of a system (such as causing a

[PATCH v3] scsi: require CAP_SYS_ADMIN to write to procfs interface

Previously, the only capability effectively required to operate on the /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, having an fsuid of GLOBAL_ROOT_UID was enough). This means that semi-privileged processes could interfere with core components of a system (such as causing a

Re: [PATCH V9 3/4] scsi: Align block queue to dma_get_cache_alignment()

Hi Huacai, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.14-rc7] [cannot apply to next-20171103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH V9 3/4] scsi: Align block queue to dma_get_cache_alignment()

Hi Huacai, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.14-rc7] [cannot apply to next-20171103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] drivers/pcmcia: omap1: Fix error in automated timer conversion

One part of automated timer conversion tools did not take into account void * variables when searching out prior direct timer callback usage, which resulted in an attempt to dereference the timer field without a proper type. Reported-by: kbuild test robot Signed-off-by: Kees Cook

[PATCH] drivers/pcmcia: omap1: Fix error in automated timer conversion

One part of automated timer conversion tools did not take into account void * variables when searching out prior direct timer callback usage, which resulted in an attempt to dereference the timer field without a proper type. Reported-by: kbuild test robot Signed-off-by: Kees Cook ---

  1   2   3   4   5   >