Re: [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static

2017-11-13 Thread Paolo Bonzini
On 03/11/2017 19:52, Gimcuan Hui wrote: > The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init > locally, and does not need to be called by other module, make it static. > > This patch cleans up sparse warning: > symbol 'kvm_mmu_clear_all_pte_masks' was not declared.

Re: [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static

2017-11-13 Thread Paolo Bonzini
On 03/11/2017 19:52, Gimcuan Hui wrote: > The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init > locally, and does not need to be called by other module, make it static. > > This patch cleans up sparse warning: > symbol 'kvm_mmu_clear_all_pte_masks' was not declared.

Re: linux-next: Tree for Nov 7

2017-11-13 Thread Michal Hocko
On Mon 13-11-17 13:00:57, Michal Hocko wrote: [...] > Yes, I have mentioned that in the previous email but the amount of code > would be even larger. Basically every arch which reimplements > arch_get_unmapped_area would have to special case new MAP_FIXED flag to > do vma lookup. It turned out

Re: linux-next: Tree for Nov 7

2017-11-13 Thread Michal Hocko
On Mon 13-11-17 13:00:57, Michal Hocko wrote: [...] > Yes, I have mentioned that in the previous email but the amount of code > would be even larger. Basically every arch which reimplements > arch_get_unmapped_area would have to special case new MAP_FIXED flag to > do vma lookup. It turned out

Re: [PATCH] arm: dts: ls1021a: add "fsl, ls1021a-esdhc" compatible string to esdhc node

2017-11-13 Thread Fabio Estevam
On Mon, Nov 13, 2017 at 12:39 PM, Rasmus Villemoes wrote: > Commit a22950c888e3 (mmc: sdhci-of-esdhc: add quirk > SDHCI_QUIRK_BROKEN_TIMEOUT_VAL for ls1021a) added logic to the driver to > enable the broken timeout val quirk for ls1021a, but did not add the >

Re: [PATCH] arm: dts: ls1021a: add "fsl, ls1021a-esdhc" compatible string to esdhc node

2017-11-13 Thread Fabio Estevam
On Mon, Nov 13, 2017 at 12:39 PM, Rasmus Villemoes wrote: > Commit a22950c888e3 (mmc: sdhci-of-esdhc: add quirk > SDHCI_QUIRK_BROKEN_TIMEOUT_VAL for ls1021a) added logic to the driver to > enable the broken timeout val quirk for ls1021a, but did not add the > corresponding compatible string to

Re: N900 kernel support

2017-11-13 Thread Pali Rohár
On Friday 10 November 2017 21:54:08 Pavel Machek wrote: > Hi! > > > Hi! Yesterday I updated https://elinux.org/N900 page based on data which > > I found in linux git repository. So driver status should be > > up-to-date. > > BTW... do you have any reasonable userland to run on n900? Maemo 5

Re: N900 kernel support

2017-11-13 Thread Pali Rohár
On Friday 10 November 2017 21:54:08 Pavel Machek wrote: > Hi! > > > Hi! Yesterday I updated https://elinux.org/N900 page based on data which > > I found in linux git repository. So driver status should be > > up-to-date. > > BTW... do you have any reasonable userland to run on n900? Maemo 5

Re: powerpc-linux-gnu-ld: warning: orphan section `.data.rel.ro' from `arch/powerpc/kernel/head_44x.o' being placed in section `.data.rel.ro'.

2017-11-13 Thread Masahiro Yamada
Hi Nicholas, 2017-11-11 17:45 GMT+09:00 Nicholas Piggin : > On Fri, 10 Nov 2017 23:41:49 +0800 > kbuild test robot wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> head:

Re: powerpc-linux-gnu-ld: warning: orphan section `.data.rel.ro' from `arch/powerpc/kernel/head_44x.o' being placed in section `.data.rel.ro'.

2017-11-13 Thread Masahiro Yamada
Hi Nicholas, 2017-11-11 17:45 GMT+09:00 Nicholas Piggin : > On Fri, 10 Nov 2017 23:41:49 +0800 > kbuild test robot wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> head: 1c9dbd4615fd751e5e0b99807a3c7c8612e28e20 >> commit:

Re: [GIT PULL] scheduler updates for v4.15

2017-11-13 Thread Ingo Molnar
* Mike Galbraith wrote: > On Mon, 2017-11-13 at 09:00 +0100, Ingo Molnar wrote: > > > > - Improve the RT IPI based balancing logic (Steven Rostedt) > > Well how 'bout that, serendipity strikes again: > > I just got a report that a proggy Gregory Haskins wrote back in 2007 >

Re: [GIT PULL] scheduler updates for v4.15

2017-11-13 Thread Ingo Molnar
* Mike Galbraith wrote: > On Mon, 2017-11-13 at 09:00 +0100, Ingo Molnar wrote: > > > > - Improve the RT IPI based balancing logic (Steven Rostedt) > > Well how 'bout that, serendipity strikes again: > > I just got a report that a proggy Gregory Haskins wrote back in 2007 > (preempt-test)

Re: [PATCH v3] dell-laptop: Fix keyboard led max_brightness property for Dell Latitude E6410

2017-11-13 Thread Pali Rohár
On Sunday 12 November 2017 10:01:10 Gabriel M. Elder wrote: > If necessary, I am willing to test whatever final proposed patch the > community recommends, settles on, and accepts. Would you all like me to > test the v3 patch as well? v3 has just renamed variable, so I do not think that it is

Re: [PATCH v3] dell-laptop: Fix keyboard led max_brightness property for Dell Latitude E6410

2017-11-13 Thread Pali Rohár
On Sunday 12 November 2017 10:01:10 Gabriel M. Elder wrote: > If necessary, I am willing to test whatever final proposed patch the > community recommends, settles on, and accepts. Would you all like me to > test the v3 patch as well? v3 has just renamed variable, so I do not think that it is

Re: [PATCH] lockdep: Add missing declaration of 'pr_cont()'

2017-11-13 Thread alexander . levin
On Tue, Nov 07, 2017 at 05:10:07PM +0100, Alexander Sverdlin wrote: >Hello! > >On Tue Nov  7 03:24:20 2017 Mengting Zhang wrote: >> An annoying compile warning due to missing declaration is shown below: >> In file included from lockdep.c:27:0: >>

Re: [PATCH] lockdep: Add missing declaration of 'pr_cont()'

2017-11-13 Thread alexander . levin
On Tue, Nov 07, 2017 at 05:10:07PM +0100, Alexander Sverdlin wrote: >Hello! > >On Tue Nov  7 03:24:20 2017 Mengting Zhang wrote: >> An annoying compile warning due to missing declaration is shown below: >> In file included from lockdep.c:27:0: >> ../../../kernel/locking/lockdep.c: In function >>

Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init

2017-11-13 Thread Sudeep Holla
On 13/11/17 14:58, Daniel Lezcano wrote: > On 13/11/2017 11:11, Sudeep Holla wrote: [..] >> >> Agreed, may be if we add users which is called from init functions, the >> warning should disappear. Also as tglx suggested, we could rename if it's >> just used from init function error/exit paths.

Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init

2017-11-13 Thread Sudeep Holla
On 13/11/17 14:58, Daniel Lezcano wrote: > On 13/11/2017 11:11, Sudeep Holla wrote: [..] >> >> Agreed, may be if we add users which is called from init functions, the >> warning should disappear. Also as tglx suggested, we could rename if it's >> just used from init function error/exit paths.

Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Daniel Lezcano wrote: > On 13/11/2017 11:11, Sudeep Holla wrote: > > Agreed, may be if we add users which is called from init functions, the > > warning should disappear. Also as tglx suggested, we could rename if it's > > just used from init function error/exit paths. > >

Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Daniel Lezcano wrote: > On 13/11/2017 11:11, Sudeep Holla wrote: > > Agreed, may be if we add users which is called from init functions, the > > warning should disappear. Also as tglx suggested, we could rename if it's > > just used from init function error/exit paths. > >

Re: linux-next: Tree for Nov 7

2017-11-13 Thread Russell King - ARM Linux
On Mon, Nov 13, 2017 at 03:11:40PM +0100, Michal Hocko wrote: > On Mon 13-11-17 10:20:06, Michal Hocko wrote: > > [Cc arm and ppc maintainers] > > > > Thanks a lot for testing! > > > > On Sun 12-11-17 11:38:02, Joel Stanley wrote: > > > On Fri, Nov 10, 2017 at 11:00 PM, Michal Hocko

Re: linux-next: Tree for Nov 7

2017-11-13 Thread Russell King - ARM Linux
On Mon, Nov 13, 2017 at 03:11:40PM +0100, Michal Hocko wrote: > On Mon 13-11-17 10:20:06, Michal Hocko wrote: > > [Cc arm and ppc maintainers] > > > > Thanks a lot for testing! > > > > On Sun 12-11-17 11:38:02, Joel Stanley wrote: > > > On Fri, Nov 10, 2017 at 11:00 PM, Michal Hocko wrote: > >

Re: [PATCH RFC v3 4/6] Documentation: Add three sysctls for smart idle poll

2017-11-13 Thread Ingo Molnar
* Quan Xu wrote: > From: Quan Xu > > To reduce the cost of poll, we introduce three sysctl to control the > poll time when running as a virtual machine with paravirt. > > Signed-off-by: Yang Zhang > Signed-off-by: Quan Xu

Re: [PATCH RFC v3 4/6] Documentation: Add three sysctls for smart idle poll

2017-11-13 Thread Ingo Molnar
* Quan Xu wrote: > From: Quan Xu > > To reduce the cost of poll, we introduce three sysctl to control the > poll time when running as a virtual machine with paravirt. > > Signed-off-by: Yang Zhang > Signed-off-by: Quan Xu > --- > Documentation/sysctl/kernel.txt | 35

RE: [PATCH 6/7] perf tools: Remove 'overwrite' concept from code level

2017-11-13 Thread Liang, Kan
> Since all 'overwrite' usage are cleaned and no one really use a readonly main > ringbuffer, remove 'overwrite' from function arguments and evlist. The > concept > of 'overwrite' and 'write_backward' are cleanner than before: > > 1. In code level, there's no 'overwrite' concept. Each evlist

RE: [PATCH 6/7] perf tools: Remove 'overwrite' concept from code level

2017-11-13 Thread Liang, Kan
> Since all 'overwrite' usage are cleaned and no one really use a readonly main > ringbuffer, remove 'overwrite' from function arguments and evlist. The > concept > of 'overwrite' and 'write_backward' are cleanner than before: > > 1. In code level, there's no 'overwrite' concept. Each evlist

Re: [PATCH] KVM: X86: Avoid to handle first-time write when updating the pv stuffs each time

2017-11-13 Thread Paolo Bonzini
On 13/11/2017 07:47, Wanpeng Li wrote: > From: Wanpeng Li > > There is a logic to handle first-time write when updating the > pvclock/wall clock/steal time shared memory pages each time, > actually we should do this logic during pv stuffs setup if we > suspect the

Re: [PATCH] KVM: X86: Avoid to handle first-time write when updating the pv stuffs each time

2017-11-13 Thread Paolo Bonzini
On 13/11/2017 07:47, Wanpeng Li wrote: > From: Wanpeng Li > > There is a logic to handle first-time write when updating the > pvclock/wall clock/steal time shared memory pages each time, > actually we should do this logic during pv stuffs setup if we > suspect the version-field can't be

Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init

2017-11-13 Thread Daniel Lezcano
On 13/11/2017 11:11, Sudeep Holla wrote: > On Sun, Nov 12, 2017 at 11:24:56PM +0100, Arnd Bergmann wrote: >> On Sun, Nov 12, 2017 at 10:16 PM, Thomas Gleixner wrote: >>> On Mon, 6 Nov 2017, Arnd Bergmann wrote: The newly added function triggers a harmless Kbuild warning

Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init

2017-11-13 Thread Daniel Lezcano
On 13/11/2017 11:11, Sudeep Holla wrote: > On Sun, Nov 12, 2017 at 11:24:56PM +0100, Arnd Bergmann wrote: >> On Sun, Nov 12, 2017 at 10:16 PM, Thomas Gleixner wrote: >>> On Mon, 6 Nov 2017, Arnd Bergmann wrote: The newly added function triggers a harmless Kbuild warning because of a

Re: [PATCH] net: dsa: add CONFIG_BRIDGE dependency

2017-11-13 Thread Arnd Bergmann
On Mon, Nov 13, 2017 at 3:07 PM, David Miller wrote: > > Please see: > > http://patchwork.ozlabs.org/patch/837041/ Ok, that should work equally well. I had the same thing at first and then changed it to be a little more specific with the dependency. Arnd

Re: [PATCH] net: dsa: add CONFIG_BRIDGE dependency

2017-11-13 Thread Arnd Bergmann
On Mon, Nov 13, 2017 at 3:07 PM, David Miller wrote: > > Please see: > > http://patchwork.ozlabs.org/patch/837041/ Ok, that should work equally well. I had the same thing at first and then changed it to be a little more specific with the dependency. Arnd

Re:

2017-11-13 Thread Amos Kalonzo
Attn: I am wondering why You haven't respond to my email for some days now. reference to my client's contract balance payment of (11.7M,USD) Kindly get back to me for more details. Best Regards Amos Kalonzo

Re:

2017-11-13 Thread Amos Kalonzo
Attn: I am wondering why You haven't respond to my email for some days now. reference to my client's contract balance payment of (11.7M,USD) Kindly get back to me for more details. Best Regards Amos Kalonzo

Re: [Y2038] [PATCH 3/7] scsi: bfa: improve bfa_ioc_send_enable/disable data

2017-11-13 Thread Arnd Bergmann
On Mon, Nov 13, 2017 at 3:08 PM, Ben Hutchings wrote: > On Fri, 2017-11-10 at 16:37 +0100, Arnd Bergmann wrote: >> >> bfi_h2i_set(enable_req.mh, BFI_MC_IOC, BFI_IOC_H2I_ENABLE_REQ, >> bfa_ioc_portid(ioc)); >> enable_req.clscode =

Re: [Y2038] [PATCH 3/7] scsi: bfa: improve bfa_ioc_send_enable/disable data

2017-11-13 Thread Arnd Bergmann
On Mon, Nov 13, 2017 at 3:08 PM, Ben Hutchings wrote: > On Fri, 2017-11-10 at 16:37 +0100, Arnd Bergmann wrote: >> >> bfi_h2i_set(enable_req.mh, BFI_MC_IOC, BFI_IOC_H2I_ENABLE_REQ, >> bfa_ioc_portid(ioc)); >> enable_req.clscode = cpu_to_be16(ioc->clscode); >> -

Re: [PATCH 0/3] fix SIGNAL_UNKILLABLE && SIGKILL interaction

2017-11-13 Thread Oleg Nesterov
ping... Dmitry confirms this actually fixes the problem reported by syzkaller we discussed in another thread. On 11/03, Oleg Nesterov wrote: > > On 11/02, Oleg Nesterov wrote: > > > > I need to write the changelog, and perhaps even split this small patch for > > better documentation. > > OK,

Re: [PATCH 0/3] fix SIGNAL_UNKILLABLE && SIGKILL interaction

2017-11-13 Thread Oleg Nesterov
ping... Dmitry confirms this actually fixes the problem reported by syzkaller we discussed in another thread. On 11/03, Oleg Nesterov wrote: > > On 11/02, Oleg Nesterov wrote: > > > > I need to write the changelog, and perhaps even split this small patch for > > better documentation. > > OK,

Re: [perf_swevent_add] WARNING: CPU: 0 PID: 393 at kernel/events/core.c:7735 perf_swevent_add+0xe0/0x14f

2017-11-13 Thread Fengguang Wu
On Mon, Nov 13, 2017 at 03:36:05PM +0100, Jiri Olsa wrote: On Sat, Nov 11, 2017 at 06:37:58PM +0800, Fengguang Wu wrote: Hello, FYI this happens in 4.14.0-rc8, however not a new bug. SNIP #!/bin/bash kernel=$1 initrd=initrd.img wget --no-clobber

Re: [perf_swevent_add] WARNING: CPU: 0 PID: 393 at kernel/events/core.c:7735 perf_swevent_add+0xe0/0x14f

2017-11-13 Thread Fengguang Wu
On Mon, Nov 13, 2017 at 03:36:05PM +0100, Jiri Olsa wrote: On Sat, Nov 11, 2017 at 06:37:58PM +0800, Fengguang Wu wrote: Hello, FYI this happens in 4.14.0-rc8, however not a new bug. SNIP #!/bin/bash kernel=$1 initrd=initrd.img wget --no-clobber

[PATCH 15/24] staging: ccree: trim long lines for readability

2017-11-13 Thread Gilad Ben-Yossef
The ccree driver did not adhere to the kernel max 80 chars per line limit making the code hard to follow. Fix this by breaking long lines and in some cases, moving comments to a separate line from code. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c

[PATCH 15/24] staging: ccree: trim long lines for readability

2017-11-13 Thread Gilad Ben-Yossef
The ccree driver did not adhere to the kernel max 80 chars per line limit making the code hard to follow. Fix this by breaking long lines and in some cases, moving comments to a separate line from code. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 152

[PATCH] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" compatible string to esdhc node

2017-11-13 Thread Rasmus Villemoes
Commit a22950c888e3 (mmc: sdhci-of-esdhc: add quirk SDHCI_QUIRK_BROKEN_TIMEOUT_VAL for ls1021a) added logic to the driver to enable the broken timeout val quirk for ls1021a, but did not add the corresponding compatible string to the device tree, so it didn't really have any effect. Fix that.

[PATCH] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" compatible string to esdhc node

2017-11-13 Thread Rasmus Villemoes
Commit a22950c888e3 (mmc: sdhci-of-esdhc: add quirk SDHCI_QUIRK_BROKEN_TIMEOUT_VAL for ls1021a) added logic to the driver to enable the broken timeout val quirk for ls1021a, but did not add the corresponding compatible string to the device tree, so it didn't really have any effect. Fix that.

RE: [PATCH 0/7] perf tools: Clarify overwrite and backward, bugfix

2017-11-13 Thread Liang, Kan
> Based on previous discussion, perf needs to support only two types > of ringbuffer: read-write + forward, readonly + backward. This patchset > completly removes the concept of 'overwrite' from code level, controls > mapping permission using write_backward instead. I think I suggested to remove

RE: [PATCH 0/7] perf tools: Clarify overwrite and backward, bugfix

2017-11-13 Thread Liang, Kan
> Based on previous discussion, perf needs to support only two types > of ringbuffer: read-write + forward, readonly + backward. This patchset > completly removes the concept of 'overwrite' from code level, controls > mapping permission using write_backward instead. I think I suggested to remove

[PATCH 24/24] staging: ccree: drop unused macro

2017-11-13 Thread Gilad Ben-Yossef
The CC_REG_NAME macro is unused. Drop it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_hw_queue_defs.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h index

[PATCH 23/24] staging: ccree: use local vars for readability

2017-11-13 Thread Gilad Ben-Yossef
Refactor cc_map_aead_request() to use local vars for addresses for better readability of code. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 64 +++--- 1 file changed, 29 insertions(+), 35 deletions(-) diff --git

[PATCH 24/24] staging: ccree: drop unused macro

2017-11-13 Thread Gilad Ben-Yossef
The CC_REG_NAME macro is unused. Drop it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_hw_queue_defs.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h index 2ae0f65..c5aaa79 100644 ---

[PATCH 23/24] staging: ccree: use local vars for readability

2017-11-13 Thread Gilad Ben-Yossef
Refactor cc_map_aead_request() to use local vars for addresses for better readability of code. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 64 +++--- 1 file changed, 29 insertions(+), 35 deletions(-) diff --git

[PATCH 21/24] staging: ccree: remove unused field

2017-11-13 Thread Gilad Ben-Yossef
Field monitor_null_cycles of struct drvdata was not being used. Remove it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_driver.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/ccree/ssi_driver.h b/drivers/staging/ccree/ssi_driver.h

[PATCH 21/24] staging: ccree: remove unused field

2017-11-13 Thread Gilad Ben-Yossef
Field monitor_null_cycles of struct drvdata was not being used. Remove it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_driver.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/ccree/ssi_driver.h b/drivers/staging/ccree/ssi_driver.h index

[PATCH 22/24] staging: ccree: replace msleep with a completion

2017-11-13 Thread Gilad Ben-Yossef
When the driver would try to queue commands to the HW FIFO but ran out of slots it would use msleep as a delay until the FIFO would clear. This is messy and not accurate. Replace the msleep with a proper completion on the event of command completion which should indicate at least one slot is

[PATCH 22/24] staging: ccree: replace msleep with a completion

2017-11-13 Thread Gilad Ben-Yossef
When the driver would try to queue commands to the HW FIFO but ran out of slots it would use msleep as a delay until the FIFO would clear. This is messy and not accurate. Replace the msleep with a proper completion on the event of command completion which should indicate at least one slot is

[PATCH 20/24] staging: ccree: remove unneeded wrapper function

2017-11-13 Thread Gilad Ben-Yossef
Remove unneeded wrapper function to simplify code. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_hash.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/staging/ccree/ssi_hash.c

[PATCH 20/24] staging: ccree: remove unneeded wrapper function

2017-11-13 Thread Gilad Ben-Yossef
Remove unneeded wrapper function to simplify code. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_hash.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_hash.c index

[PATCH 19/24] staging: ccree: rename long define for readability

2017-11-13 Thread Gilad Ben-Yossef
Rename the too long SSI_MAX_HASH_OPAD_TMP_KEYS_SIZE to SSI_MAX_OPAD_KEYS_SIZE for better code readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_hash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 19/24] staging: ccree: rename long define for readability

2017-11-13 Thread Gilad Ben-Yossef
Rename the too long SSI_MAX_HASH_OPAD_TMP_KEYS_SIZE to SSI_MAX_OPAD_KEYS_SIZE for better code readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_hash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_hash.c

[PATCH 18/24] staging: ccree: rename func for readability

2017-11-13 Thread Gilad Ben-Yossef
Rename the insanely long ssi_ahash_get_larval_digest_sram_addr() func to cc_larval_digest_addr() for better code readability Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c | 7 +++ drivers/staging/ccree/ssi_hash.c | 13 ++---

[PATCH 18/24] staging: ccree: rename func for readability

2017-11-13 Thread Gilad Ben-Yossef
Rename the insanely long ssi_ahash_get_larval_digest_sram_addr() func to cc_larval_digest_addr() for better code readability Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c | 7 +++ drivers/staging/ccree/ssi_hash.c | 13 ++--- drivers/staging/ccree/ssi_hash.h |

[PATCH 17/24] staging: ccree: refactor code with local vars

2017-11-13 Thread Gilad Ben-Yossef
Refactor the queue handling loop using local variables for better code readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_request_mgr.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git

[PATCH 16/24] staging: ccree: remove dead defs and decls

2017-11-13 Thread Gilad Ben-Yossef
Remove no longer definitions of enums and forward declaration of functions dealing with sysfs interface of the long removed ccree cycle counter. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_sysfs.h | 23 --- 1 file changed, 23

[PATCH 17/24] staging: ccree: refactor code with local vars

2017-11-13 Thread Gilad Ben-Yossef
Refactor the queue handling loop using local variables for better code readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_request_mgr.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.c

[PATCH 16/24] staging: ccree: remove dead defs and decls

2017-11-13 Thread Gilad Ben-Yossef
Remove no longer definitions of enums and forward declaration of functions dealing with sysfs interface of the long removed ccree cycle counter. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_sysfs.h | 23 --- 1 file changed, 23 deletions(-) diff --git

[PATCH 14/24] staging: ccree: replace macro with inline func

2017-11-13 Thread Gilad Ben-Yossef
Replace GET_DMA_BUFFER_TYPE with an inline function variant with type checking. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git

[PATCH 14/24] staging: ccree: replace macro with inline func

2017-11-13 Thread Gilad Ben-Yossef
Replace GET_DMA_BUFFER_TYPE with an inline function variant with type checking. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c

[PATCH 12/24] staging: ccree: fix code indent

2017-11-13 Thread Gilad Ben-Yossef
Fix code ident not following the coding style. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_cipher.c | 2 +- drivers/staging/ccree/ssi_sysfs.c | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_cipher.c

[PATCH 11/24] staging: ccree: constify help string

2017-11-13 Thread Gilad Ben-Yossef
Make help string static const Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sysfs.c b/drivers/staging/ccree/ssi_sysfs.c index 5d39f15..8d50382 100644 ---

[PATCH 13/24] staging: ccree: Replace CONFIG_PM_RUNTIME with CONFIG_PM

2017-11-13 Thread Gilad Ben-Yossef
After commit b2b49ccbdd54 ("PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected") PM_RUNTIME is always set if PM is set, so #ifdef blocks depending on CONFIG_PM_RUNTIME may now be changed to depend on CONFIG_PM. Replace CONFIG_PM_RUNTIME with CONFIG_PM. Signed-off-by: Gilad Ben-Yossef

[PATCH 12/24] staging: ccree: fix code indent

2017-11-13 Thread Gilad Ben-Yossef
Fix code ident not following the coding style. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_cipher.c | 2 +- drivers/staging/ccree/ssi_sysfs.c | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_cipher.c

[PATCH 11/24] staging: ccree: constify help string

2017-11-13 Thread Gilad Ben-Yossef
Make help string static const Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sysfs.c b/drivers/staging/ccree/ssi_sysfs.c index 5d39f15..8d50382 100644 ---

[PATCH 13/24] staging: ccree: Replace CONFIG_PM_RUNTIME with CONFIG_PM

2017-11-13 Thread Gilad Ben-Yossef
After commit b2b49ccbdd54 ("PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected") PM_RUNTIME is always set if PM is set, so #ifdef blocks depending on CONFIG_PM_RUNTIME may now be changed to depend on CONFIG_PM. Replace CONFIG_PM_RUNTIME with CONFIG_PM. Signed-off-by: Gilad Ben-Yossef ---

[PATCH 10/24] staging: ccree: document spinlock usage

2017-11-13 Thread Gilad Ben-Yossef
Document spinlock usage to protect against concurrent access to HW register which must occur a single request at a time. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_request_mgr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 09/24] staging: ccree: replace open coded loop with for

2017-11-13 Thread Gilad Ben-Yossef
Replace open coded register writing loop with a for. Further simplify code by using a local var to precompute the register address for readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_request_mgr.c | 16 +--- 1 file changed, 9

[PATCH 09/24] staging: ccree: replace open coded loop with for

2017-11-13 Thread Gilad Ben-Yossef
Replace open coded register writing loop with a for. Further simplify code by using a local var to precompute the register address for readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_request_mgr.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-)

[PATCH 10/24] staging: ccree: document spinlock usage

2017-11-13 Thread Gilad Ben-Yossef
Document spinlock usage to protect against concurrent access to HW register which must occur a single request at a time. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_request_mgr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/ccree/ssi_request_mgr.c

[PATCH 06/24] staging: ccree: remove unneeded empty lines

2017-11-13 Thread Gilad Ben-Yossef
Remove uneeded empty lines that crept in to code. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 1 - drivers/staging/ccree/ssi_hash.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c

[PATCH 07/24] staging: ccree: remove unneeded cast

2017-11-13 Thread Gilad Ben-Yossef
Remove uneeded cast from writel_relaxed parameter. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_request_mgr.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.c

[PATCH 06/24] staging: ccree: remove unneeded empty lines

2017-11-13 Thread Gilad Ben-Yossef
Remove uneeded empty lines that crept in to code. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 1 - drivers/staging/ccree/ssi_hash.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c

[PATCH 07/24] staging: ccree: remove unneeded cast

2017-11-13 Thread Gilad Ben-Yossef
Remove uneeded cast from writel_relaxed parameter. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_request_mgr.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c

[PATCH 08/24] staging: ccree: make mem barrier per request

2017-11-13 Thread Gilad Ben-Yossef
The driver was issuing a write memory barrier per each HW descriptor written but these descriptors are written in groups and we really only need one per group. White at it, document memory barrier reason. Signed-off-by: Gilad Ben-Yossef ---

[PATCH 08/24] staging: ccree: make mem barrier per request

2017-11-13 Thread Gilad Ben-Yossef
The driver was issuing a write memory barrier per each HW descriptor written but these descriptors are written in groups and we really only need one per group. White at it, document memory barrier reason. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_request_mgr.c | 13

[PATCH 05/24] staging: ccree: move logical cont. to 1st line

2017-11-13 Thread Gilad Ben-Yossef
Move logical continuations to first line for readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c

[PATCH 05/24] staging: ccree: move logical cont. to 1st line

2017-11-13 Thread Gilad Ben-Yossef
Move logical continuations to first line for readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c index

[PATCH 04/24] staging: ccree: remove MIN/MAX macros

2017-11-13 Thread Gilad Ben-Yossef
The driver was using open coded MIN/MAX macros to compute fixed defines. Remove them and use bigger value always instead. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.h | 2 +- drivers/staging/ccree/ssi_driver.h | 3 ---

[PATCH 04/24] staging: ccree: remove MIN/MAX macros

2017-11-13 Thread Gilad Ben-Yossef
The driver was using open coded MIN/MAX macros to compute fixed defines. Remove them and use bigger value always instead. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.h | 2 +- drivers/staging/ccree/ssi_driver.h | 3 --- drivers/staging/ccree/ssi_hash.c | 2 +- 3 files

Re: [PATCH 2/3] Input: twl6040-vibra: fix child-node lookup

2017-11-13 Thread Johan Hovold
On Mon, Nov 13, 2017 at 03:39:48PM +0100, H. Nikolaus Schaller wrote: > Hi, > > > Am 13.11.2017 um 15:19 schrieb Johan Hovold : > > > > On Mon, Nov 13, 2017 at 04:10:52PM +0200, Peter Ujfalusi wrote: > > > >> On 2017-11-11 17:43, Johan Hovold wrote: > >>> Fix child-node lookup

[PATCH 03/24] staging: ccree: remove unnecessary parentheses

2017-11-13 Thread Gilad Ben-Yossef
Remove unnecessary parentheses in if statements across the driver. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c | 36 +- drivers/staging/ccree/ssi_buffer_mgr.c | 28 +-

[PATCH 03/24] staging: ccree: remove unnecessary parentheses

2017-11-13 Thread Gilad Ben-Yossef
Remove unnecessary parentheses in if statements across the driver. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c | 36 +- drivers/staging/ccree/ssi_buffer_mgr.c | 28 +- drivers/staging/ccree/ssi_cipher.c |

Re: [PATCH 2/3] Input: twl6040-vibra: fix child-node lookup

2017-11-13 Thread Johan Hovold
On Mon, Nov 13, 2017 at 03:39:48PM +0100, H. Nikolaus Schaller wrote: > Hi, > > > Am 13.11.2017 um 15:19 schrieb Johan Hovold : > > > > On Mon, Nov 13, 2017 at 04:10:52PM +0200, Peter Ujfalusi wrote: > > > >> On 2017-11-11 17:43, Johan Hovold wrote: > >>> Fix child-node lookup during probe,

[PATCH 00/24] staging: ccree: more cleanup patches

2017-11-13 Thread Gilad Ben-Yossef
Another set of cleanup patches. This set goes on top of the previous fixes and cleanups patch set sent to the list. With this set of patches checkpatch now only reports one false warning and a warning on device tree string being undocumented. Gilad Ben-Yossef (24): staging: ccree: fix typos

[PATCH 00/24] staging: ccree: more cleanup patches

2017-11-13 Thread Gilad Ben-Yossef
Another set of cleanup patches. This set goes on top of the previous fixes and cleanups patch set sent to the list. With this set of patches checkpatch now only reports one false warning and a warning on device tree string being undocumented. Gilad Ben-Yossef (24): staging: ccree: fix typos

[PATCH 02/24] staging: ccree: alloc by instance not type

2017-11-13 Thread Gilad Ben-Yossef
Allocation by instance is preferred to allocation by type. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_sram_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sram_mgr.c

[PATCH 02/24] staging: ccree: alloc by instance not type

2017-11-13 Thread Gilad Ben-Yossef
Allocation by instance is preferred to allocation by type. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_sram_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sram_mgr.c b/drivers/staging/ccree/ssi_sram_mgr.c index

[PATCH 01/24] staging: ccree: fix typos

2017-11-13 Thread Gilad Ben-Yossef
Fix a bunch of comment typos. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_hash.c| 2 +- drivers/staging/ccree/ssi_hash.h| 2 +- drivers/staging/ccree/ssi_ivgen.c | 2 +- drivers/staging/ccree/ssi_request_mgr.c | 2 +-

[PATCH 01/24] staging: ccree: fix typos

2017-11-13 Thread Gilad Ben-Yossef
Fix a bunch of comment typos. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_hash.c| 2 +- drivers/staging/ccree/ssi_hash.h| 2 +- drivers/staging/ccree/ssi_ivgen.c | 2 +- drivers/staging/ccree/ssi_request_mgr.c | 2 +-

[PATCH 3/5] KVM: x86: emulate sldt and str

2017-11-13 Thread Paolo Bonzini
These are needed to handle the descriptor table vmexits when emulating UMIP. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/emulate.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/emulate.c

[PATCH 3/5] KVM: x86: emulate sldt and str

2017-11-13 Thread Paolo Bonzini
These are needed to handle the descriptor table vmexits when emulating UMIP. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/emulate.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index

[PATCH 4/5] KVM: x86: add support for emulating UMIP

2017-11-13 Thread Paolo Bonzini
The User-Mode Instruction Prevention feature present in recent Intel processor prevents a group of instructions (sgdt, sidt, sldt, smsw, and str) from being executed with CPL > 0. Otherwise, a general protection fault is issued. UMIP instructions in general are also able to trigger vmexits, so we

[PATCH 4/5] KVM: x86: add support for emulating UMIP

2017-11-13 Thread Paolo Bonzini
The User-Mode Instruction Prevention feature present in recent Intel processor prevents a group of instructions (sgdt, sidt, sldt, smsw, and str) from being executed with CPL > 0. Otherwise, a general protection fault is issued. UMIP instructions in general are also able to trigger vmexits, so we

<    6   7   8   9   10   11   12   13   14   15   >