[PATCH v2 01/11] staging: pi433: Fix indentation in rf69_enum.h

Basically just 's//\t/', to fix checkpatch.pl warnings: "please, no spaces at the start of a line". Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69_enum.h | 207 +++--- 1 file changed, 103 insertions(+), 104 deletions(-) diff

[PATCH v2 01/11] staging: pi433: Fix indentation in rf69_enum.h

Basically just 's//\t/', to fix checkpatch.pl warnings: "please, no spaces at the start of a line". Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69_enum.h | 207 +++--- 1 file changed, 103 insertions(+), 104 deletions(-) diff --git

[PATCH v2 05/11] staging: pi433: Rename enum modShaping in rf69_enum.h

Renames enum modShaping and its values to get rid of checkpatch.pl warnings: "Avoid CamelCase: ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 21

[PATCH v2 05/11] staging: pi433: Rename enum modShaping in rf69_enum.h

Renames enum modShaping and its values to get rid of checkpatch.pl warnings: "Avoid CamelCase: ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 21 +++--

[PATCH v2 11/11] staging: pi433: Remove SET_CHECKED usage from pi433_probe

SET_CHECKED returns from the function on failure and in pi433_probe it is necessary to free the GPIOs and the device on failure. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 28 +--- 1 file changed, 21 insertions(+), 7

[PATCH v2 11/11] staging: pi433: Remove SET_CHECKED usage from pi433_probe

SET_CHECKED returns from the function on failure and in pi433_probe it is necessary to free the GPIOs and the device on failure. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git

[PATCH v2 10/11] staging: pi433: Move enum option_on_off to pi433_if.h

The enum is now only used for ioctl, so move it pi433_if.h. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.h | 5 + drivers/staging/pi433/rf69_enum.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2 10/11] staging: pi433: Move enum option_on_off to pi433_if.h

The enum is now only used for ioctl, so move it pi433_if.h. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.h | 5 + drivers/staging/pi433/rf69_enum.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.h

[PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c | 18 ++

[PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c | 18 ++ drivers/staging/pi433/rf69.h | 4 ++-- 3

[PATCH v2 03/11] staging: pi433: Rename variable in struct pi433_rx_cfg

Renames variable thresholdDecrement in struct pi433_rx_cfg to threshold_decrement to get rid of checkpatch.pl warning "Avoid CamelCase: ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- 2 files changed, 2

[PATCH v2 03/11] staging: pi433: Rename variable in struct pi433_rx_cfg

Renames variable thresholdDecrement in struct pi433_rx_cfg to threshold_decrement to get rid of checkpatch.pl warning "Avoid CamelCase: ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- 2 files changed, 2 insertions(+), 2

Re: [patch 53/60] x86/mm: Use/Fix PCID to optimize user/kernel switches

On 12/05/2017 02:05 PM, Peter Zijlstra wrote: >> I haven't checked that hard which patch introduces this bug, but it >> seems that, with this applied, nothing propagates >> non-mm-switch-related flushes to usermode. Shouldn't >> flush_tlb_func_common() contain a call to invalidate_user_asid()

Re: [patch 53/60] x86/mm: Use/Fix PCID to optimize user/kernel switches

On 12/05/2017 02:05 PM, Peter Zijlstra wrote: >> I haven't checked that hard which patch introduces this bug, but it >> seems that, with this applied, nothing propagates >> non-mm-switch-related flushes to usermode. Shouldn't >> flush_tlb_func_common() contain a call to invalidate_user_asid()

[PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34 ++---

Re: [PATCH] ARM: dts: sun8i: h3: enable USB OTG for NanoPi Neo board

On Tue, Dec 05, 2017 at 10:07:06AM +0100, Maxime Ripard wrote: diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts index 78f6c24952dd..14c3f137dbd3 100644 --- a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts +++

[PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34 ++---

Re: [PATCH] ARM: dts: sun8i: h3: enable USB OTG for NanoPi Neo board

On Tue, Dec 05, 2017 at 10:07:06AM +0100, Maxime Ripard wrote: diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts index 78f6c24952dd..14c3f137dbd3 100644 --- a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts +++

[PATCH v2 08/11] staging: pi433: Remove enum data_mode

Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.h | 6

[PATCH v2 08/11] staging: pi433: Remove enum data_mode

Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.h | 6 -- 4 files

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 01:36:44PM -0800, Paul E. McKenney wrote: > What we do in some code is to comment the pairings, allowing the other > side of the pairing to be easily located. Would that work for you? I would say that that is mandatory for any memory ordering code ;-)

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 01:36:44PM -0800, Paul E. McKenney wrote: > What we do in some code is to comment the pairings, allowing the other > side of the pairing to be easily located. Would that work for you? I would say that that is mandatory for any memory ordering code ;-)

[PATCH v2 07/11] staging: pi433: Split rf69_set_sync_enabled into two functions

Splits rf69_set_sync_enabled(dev, enabled) into rf69_enable_sync(dev) and rf69_disable_sync(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 21 +++-- drivers/staging/pi433/rf69.c | 18 ++

[PATCH v2 07/11] staging: pi433: Split rf69_set_sync_enabled into two functions

Splits rf69_set_sync_enabled(dev, enabled) into rf69_enable_sync(dev) and rf69_disable_sync(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 21 +++-- drivers/staging/pi433/rf69.c | 18 ++ drivers/staging/pi433/rf69.h | 4 ++--

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 10:57:00PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > READ_ONCE is really all over the place (some code literally replaced all > > memory accesses with READ/WRITE ONCE). > > Yeah, so? Oh my point was I can't just

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 10:57:00PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > READ_ONCE is really all over the place (some code literally replaced all > > memory accesses with READ/WRITE ONCE). > > Yeah, so? Oh my point was I can't just

Re: [PATCH 2/3] kernel: Move groups_sort to the caller of set_groups.

On Tue, Dec 05 2017, Thiago Rafael Becker wrote: > The responsibility for calling groups_sort is now on the caller > of set_groups. > > Signed-off-by: Thiago Rafael Becker > --- > arch/s390/kernel/compat_linux.c | 1 + > fs/nfsd/auth.c| 3 +++ >

Re: [PATCH 2/3] kernel: Move groups_sort to the caller of set_groups.

On Tue, Dec 05 2017, Thiago Rafael Becker wrote: > The responsibility for calling groups_sort is now on the caller > of set_groups. > > Signed-off-by: Thiago Rafael Becker > --- > arch/s390/kernel/compat_linux.c | 1 + > fs/nfsd/auth.c| 3 +++ > kernel/groups.c

[PATCH v2 09/11] staging: pi433: Combine all rf69_set_amplifier_x()

Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/staging/pi433/rf69.c | 46

[PATCH v2 00/11] Fix indentation and CamelCase issue in staging/pi433

These patches fixes a bunch of code style issues in staging/pi433. The first patch fixes indentation in rf69_enum.h and the rest of the patches fixes CamelCase issues and other minor issues in all of staging/pi433. Changes in v2: - Instead of fixing CamelCase issue in enum data_mode,

[PATCH v2 09/11] staging: pi433: Combine all rf69_set_amplifier_x()

Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/staging/pi433/rf69.c | 46

[PATCH v2 00/11] Fix indentation and CamelCase issue in staging/pi433

These patches fixes a bunch of code style issues in staging/pi433. The first patch fixes indentation in rf69_enum.h and the rest of the patches fixes CamelCase issues and other minor issues in all of staging/pi433. Changes in v2: - Instead of fixing CamelCase issue in enum data_mode,

[PATCH v2 02/11] staging: pi433: Capitalize constant definitions

Fixes checkpatch.pl warnings "Avoid CamelCase ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 32 - drivers/staging/pi433/rf69_registers.h | 44 +- 2 files changed, 38 insertions(+), 38

[PATCH v2 02/11] staging: pi433: Capitalize constant definitions

Fixes checkpatch.pl warnings "Avoid CamelCase ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 32 - drivers/staging/pi433/rf69_registers.h | 44 +- 2 files changed, 38 insertions(+), 38 deletions(-) diff

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

On 05/12/2017 at 14:28:28 +0100, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni > wrote: > > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > > > > Ok, does that solve both randconfigs? > > > > diff --git

Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol

On 05/12/2017 at 14:28:28 +0100, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni > wrote: > > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > > > > Ok, does that solve both randconfigs? > > > > diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig > >

Re: [patch 53/60] x86/mm: Use/Fix PCID to optimize user/kernel switches

On Tue, Dec 05, 2017 at 01:46:36PM -0800, Andy Lutomirski wrote: > On Mon, Dec 4, 2017 at 6:07 AM, Thomas Gleixner wrote: > > We can use PCID to retain the TLBs across CR3 switches; including > > those now part of the user/kernel switch. This increases performance > > of

Re: [patch 53/60] x86/mm: Use/Fix PCID to optimize user/kernel switches

On Tue, Dec 05, 2017 at 01:46:36PM -0800, Andy Lutomirski wrote: > On Mon, Dec 4, 2017 at 6:07 AM, Thomas Gleixner wrote: > > We can use PCID to retain the TLBs across CR3 switches; including > > those now part of the user/kernel switch. This increases performance > > of kernel entry/exit at the

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

On Tue, Dec 05 2017, Matthew Wilcox wrote: > On Tue, Dec 05, 2017 at 07:11:00AM +1100, NeilBrown wrote: >> As we don't seem to be pursuing this possibility is probably isn't very >> important, but I'd like to point out that the original fix isn't a true >> fix. >> It just sorts a shared

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

On Tue, Dec 05 2017, Matthew Wilcox wrote: > On Tue, Dec 05, 2017 at 07:11:00AM +1100, NeilBrown wrote: >> As we don't seem to be pursuing this possibility is probably isn't very >> important, but I'd like to point out that the original fix isn't a true >> fix. >> It just sorts a shared

Re: [PATCH V6 2/7] ACPI / bus: Introduce acpi_get_match_data() function

On Tue, Dec 5, 2017 at 6:04 PM, Sinan Kaya wrote: > OF has of_device_get_match_data() function to extract driver specific data > structure. Add a similar function for ACPI. > > Signed-off-by: Sinan Kaya > Acked-by: Rafael J. Wysocki

Re: [PATCH V6 2/7] ACPI / bus: Introduce acpi_get_match_data() function

On Tue, Dec 5, 2017 at 6:04 PM, Sinan Kaya wrote: > OF has of_device_get_match_data() function to extract driver specific data > structure. Add a similar function for ACPI. > > Signed-off-by: Sinan Kaya > Acked-by: Rafael J. Wysocki Not sure yet, sorry. > --- > drivers/acpi/bus.c | 12

Re: [PATCH v5 1/5] soc: qcom: Introduce QMI encoder/decoder

On Tue, 2017-12-05 at 09:43 -0800, Bjorn Andersson wrote: > Add the helper library for encoding and decoding QMI encoded messages. > The implementation is taken from lib/qmi_encdec.c of the Qualcomm kernel > (msm-3.18). > > Modifications has been made to the public API, source buffers has been >

Re: [PATCH v2] w1: driver for serial linkUSB, linkOEM, LINK devices

Hi Sorry for delay 13.11.2017, 00:05, "Hans-Frieder Vogt" : > attached is the revised version of a driver that supports the serial OneWire > masters from iButtonLink(TM) in the w1 kernel driver. In order to be usable > it needs an updated userland tool (patch included in

Re: [PATCH v5 1/5] soc: qcom: Introduce QMI encoder/decoder

On Tue, 2017-12-05 at 09:43 -0800, Bjorn Andersson wrote: > Add the helper library for encoding and decoding QMI encoded messages. > The implementation is taken from lib/qmi_encdec.c of the Qualcomm kernel > (msm-3.18). > > Modifications has been made to the public API, source buffers has been >

Re: [PATCH v2] w1: driver for serial linkUSB, linkOEM, LINK devices

Hi Sorry for delay 13.11.2017, 00:05, "Hans-Frieder Vogt" : > attached is the revised version of a driver that supports the serial OneWire > masters from iButtonLink(TM) in the w1 kernel driver. In order to be usable > it needs an updated userland tool (patch included in documentation file).

[PATCH v2] ARM: dts: sun8i: h3: enable USB OTG for NanoPi Neo board

Similarly to Orange Pi Zero, NanoPi Neo board has an USB OTG port with an ID pin but with unpowered VBUS. This patch enables this port in forced peripheral mode. ohci/ehci nodes are still enabled since the host mode may work if external power source is used. In that case, the mode can be

[PATCH v2] ARM: dts: sun8i: h3: enable USB OTG for NanoPi Neo board

Similarly to Orange Pi Zero, NanoPi Neo board has an USB OTG port with an ID pin but with unpowered VBUS. This patch enables this port in forced peripheral mode. ohci/ehci nodes are still enabled since the host mode may work if external power source is used. In that case, the mode can be

Re: [PATCH v8 10/13] dt-bindings: Add qcom slimbus controller bindings

On 04/12/17 21:28, Rob Herring wrote: On Thu, Nov 30, 2017 at 05:41:57PM +, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia This patch add device tree bindings for Qualcomm slimbus controller. Signed-off-by: Sagar Dharia

Re: [PATCH v8 10/13] dt-bindings: Add qcom slimbus controller bindings

On 04/12/17 21:28, Rob Herring wrote: On Thu, Nov 30, 2017 at 05:41:57PM +, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia This patch add device tree bindings for Qualcomm slimbus controller. Signed-off-by: Sagar Dharia Signed-off-by: Srinivas Kandagatla ---

Re: [PATCH] string.h: work around for increased stack usage

On Tue, 5 Dec 2017 22:51:19 +0100 Arnd Bergmann wrote: > The hardened strlen() function causes rather large stack usage in at > least one file in the kernel, in particular when CONFIG_KASAN is enabled: > > drivers/media/usb/em28xx/em28xx-dvb.c: In function 'em28xx_dvb_init': >

Re: [PATCH] string.h: work around for increased stack usage

On Tue, 5 Dec 2017 22:51:19 +0100 Arnd Bergmann wrote: > The hardened strlen() function causes rather large stack usage in at > least one file in the kernel, in particular when CONFIG_KASAN is enabled: > > drivers/media/usb/em28xx/em28xx-dvb.c: In function 'em28xx_dvb_init': >

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 11:43:41PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 01:36:44PM -0800, Paul E. McKenney wrote: > > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 05, 2017 at 12:08:01PM -0800, Paul E. McKenney wrote: > > > > On Tue,

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 11:43:41PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 01:36:44PM -0800, Paul E. McKenney wrote: > > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 05, 2017 at 12:08:01PM -0800, Paul E. McKenney wrote: > > > > On Tue,

Re: [PATCH v8 01/13] Documentation: Add SLIMbus summary

Thanks for the review comments. On 01/12/17 10:27, Jonathan Neuschäfer wrote: Hi, some small nits below. On Thu, Nov 30, 2017 at 05:41:48PM +, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia SLIMbus (Serial Low Power Interchip Media Bus) is a

Re: [PATCH v8 01/13] Documentation: Add SLIMbus summary

Thanks for the review comments. On 01/12/17 10:27, Jonathan Neuschäfer wrote: Hi, some small nits below. On Thu, Nov 30, 2017 at 05:41:48PM +, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia SLIMbus (Serial Low Power Interchip Media Bus) is a specification developed by MIPI

Re: [PATCH] ocfs2: use get_task_comm

On Tue, Dec 05, 2017 at 10:44:17PM +0100, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 9:32 PM, Kees Cook wrote: > > On Tue, Dec 5, 2017 at 12:27 PM, Arnd Bergmann wrote: > >> > >> More generally speaking though, how exactly do we guarantee that > >> there

Re: [PATCH] ocfs2: use get_task_comm

On Tue, Dec 05, 2017 at 10:44:17PM +0100, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 9:32 PM, Kees Cook wrote: > > On Tue, Dec 5, 2017 at 12:27 PM, Arnd Bergmann wrote: > >> > >> More generally speaking though, how exactly do we guarantee that > >> there is NUL-termination on tsk->comm during

Re: [PATCH 4.4 20/96] autofs: dont fail mount for transient error

On Tue, 2017-11-28 at 11:22 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > -- > > From: NeilBrown > > commit ecc0c469f27765ed1e2b967be0aa17cee1a60b76 upstream. [...] > @@ -173,7 +175,18 @@

Re: [PATCH 4.4 20/96] autofs: dont fail mount for transient error

On Tue, 2017-11-28 at 11:22 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > -- > > From: NeilBrown > > commit ecc0c469f27765ed1e2b967be0aa17cee1a60b76 upstream. [...] > @@ -173,7 +175,18 @@ static void

Re: [patch 00/60] x86/kpti: Kernel Page Table Isolation (was KAISER)

On 12/05/2017 01:49 PM, Andy Lutomirski wrote: > Random thought for the future: KPTI will make it possible to avoid > global IPI broadcasts on kernel flushes as we discussed, incorrectly, > two years ago at LPC. This could be nice. I'm slow. How?

Re: [patch 00/60] x86/kpti: Kernel Page Table Isolation (was KAISER)

On 12/05/2017 01:49 PM, Andy Lutomirski wrote: > Random thought for the future: KPTI will make it possible to avoid > global IPI broadcasts on kernel flushes as we discussed, incorrectly, > two years ago at LPC. This could be nice. I'm slow. How?

Re: GemniLake laptops goes power off directly after performing suspend

On Tuesday, December 5, 2017 5:19:03 PM CET Chris Chiu wrote: > On Tue, Dec 5, 2017 at 11:01 PM, Rafael J. Wysocki wrote: > > On Tue, Dec 5, 2017 at 11:32 AM, Chris Chiu wrote: > >> Hi, > >> I have 2 GemniLake laptops from ASUS, named X441MB and X507MA,

Re: GemniLake laptops goes power off directly after performing suspend

On Tuesday, December 5, 2017 5:19:03 PM CET Chris Chiu wrote: > On Tue, Dec 5, 2017 at 11:01 PM, Rafael J. Wysocki wrote: > > On Tue, Dec 5, 2017 at 11:32 AM, Chris Chiu wrote: > >> Hi, > >> I have 2 GemniLake laptops from ASUS, named X441MB and X507MA, > >> both go power off after I do

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > READ_ONCE is really all over the place (some code literally replaced all > memory accesses with READ/WRITE ONCE). Yeah, so? Complain to the compiler people for forcing us into that. > Would an API like

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > READ_ONCE is really all over the place (some code literally replaced all > memory accesses with READ/WRITE ONCE). Yeah, so? Complain to the compiler people for forcing us into that. > Would an API like

Re: [PATCHv2 2/2] userns: control capabilities of some user namespaces

On Wed, Nov 29, 2017 at 9:57 AM, Serge E. Hallyn wrote: > Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): >> On Tue, Nov 28, 2017 at 3:04 PM, Serge E. Hallyn wrote: >> > Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): >> > ... >> >>

Re: [PATCHv2 2/2] userns: control capabilities of some user namespaces

On Wed, Nov 29, 2017 at 9:57 AM, Serge E. Hallyn wrote: > Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): >> On Tue, Nov 28, 2017 at 3:04 PM, Serge E. Hallyn wrote: >> > Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): >> > ... >> >> >> diff --git a/security/commoncap.c

Re: [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for Google Glimmer

Hi Gwendal, On 01/12/2017 20:54, Gwendal Grignou wrote: This is not required. Looking with dmidecode, Glimmer reports: ... BIOS Information Vendor: coreboot Version: Google_Glimmer.5216.198.19 ... Therefore, the first entry of cros_ec_lpc_dmi_table will match. These DMI

Re: [PATCH v2] KVM: VMX: Cache IA32_DEBUGCTL in memory

2017-11-29 01:31-0800, Wanpeng Li: > From: Wanpeng Li > > MSR_IA32_DEBUGCTLMSR is zeroed on VMEXIT, so it is saved/restored > each time during world switch. Jim from Google pointed out that > when running schbench in L2, vmx_vcpu_run will occupy 4% cpu time, > and the

Re: [PATCH v2] KVM: VMX: Cache IA32_DEBUGCTL in memory

2017-11-29 01:31-0800, Wanpeng Li: > From: Wanpeng Li > > MSR_IA32_DEBUGCTLMSR is zeroed on VMEXIT, so it is saved/restored > each time during world switch. Jim from Google pointed out that > when running schbench in L2, vmx_vcpu_run will occupy 4% cpu time, > and the 25% of vmx_vcpu_run cpu

Re: [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for Google Glimmer

Hi Gwendal, On 01/12/2017 20:54, Gwendal Grignou wrote: This is not required. Looking with dmidecode, Glimmer reports: ... BIOS Information Vendor: coreboot Version: Google_Glimmer.5216.198.19 ... Therefore, the first entry of cros_ec_lpc_dmi_table will match. These DMI

[PATCH] string.h: work around for increased stack usage

The hardened strlen() function causes rather large stack usage in at least one file in the kernel, in particular when CONFIG_KASAN is enabled: drivers/media/usb/em28xx/em28xx-dvb.c: In function 'em28xx_dvb_init': drivers/media/usb/em28xx/em28xx-dvb.c:2062:1: error: the frame size of 3256 bytes

[PATCH] string.h: work around for increased stack usage

The hardened strlen() function causes rather large stack usage in at least one file in the kernel, in particular when CONFIG_KASAN is enabled: drivers/media/usb/em28xx/em28xx-dvb.c: In function 'em28xx_dvb_init': drivers/media/usb/em28xx/em28xx-dvb.c:2062:1: error: the frame size of 3256 bytes

[PATCH 2/2] usbip: Use common error handling code in stub_recv_cmd_submit()

From: Markus Elfring Date: Tue, 5 Dec 2017 22:40:30 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- drivers/usb/usbip/stub_rx.c | 22

[PATCH 2/2] usbip: Use common error handling code in stub_recv_cmd_submit()

From: Markus Elfring Date: Tue, 5 Dec 2017 22:40:30 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- drivers/usb/usbip/stub_rx.c | 22 ++ 1 file changed, 10 insertions(+), 12

Re: [patch 00/60] x86/kpti: Kernel Page Table Isolation (was KAISER)

Random thought for the future: KPTI will make it possible to avoid global IPI broadcasts on kernel flushes as we discussed, incorrectly, two years ago at LPC. This could be nice.

[PATCH 0/2] usbip: Adjustments for two function implementations

From: Markus Elfring Date: Tue, 5 Dec 2017 22:44:55 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in two functions Use common error handling

Re: [patch 00/60] x86/kpti: Kernel Page Table Isolation (was KAISER)

Random thought for the future: KPTI will make it possible to avoid global IPI broadcasts on kernel flushes as we discussed, incorrectly, two years ago at LPC. This could be nice.

[PATCH 0/2] usbip: Adjustments for two function implementations

From: Markus Elfring Date: Tue, 5 Dec 2017 22:44:55 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in two functions Use common error handling code in stub_recv_cmd_submit()

Re: [PATCH v2 04/15] NTB: ntb_pp: Add full multi-port NTB API support

On 05/12/17 12:53 PM, Serge Semin wrote: Is it really necessary to have all of this info defined in macro? We don't use them anywhere in the source below. I add this change here due to the last Greg patch, where he removed DRIVER_LICENSE from the code. He said, that the license check tool

[PATCH 1/2] usbip: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Tue, 5 Dec 2017 22:25:38 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH v2 04/15] NTB: ntb_pp: Add full multi-port NTB API support

On 05/12/17 12:53 PM, Serge Semin wrote: Is it really necessary to have all of this info defined in macro? We don't use them anywhere in the source below. I add this change here due to the last Greg patch, where he removed DRIVER_LICENSE from the code. He said, that the license check tool

[PATCH 1/2] usbip: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Tue, 5 Dec 2017 22:25:38 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/usb/usbip/stub_rx.c | 2 -- 1 file changed, 2 deletions(-)

Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods

On 05/12/17 01:54 PM, Serge Semin wrote: Just because no one said anything before, doesn't mean it's acceptable. I think that is the official Linux code review mantra ;-) Okay, if we are going to do it this way, then return ~0 instead. At least that way there is no ugly cast. Ok. I'll

Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods

On 05/12/17 01:54 PM, Serge Semin wrote: Just because no one said anything before, doesn't mean it's acceptable. I think that is the official Linux code review mantra ;-) Okay, if we are going to do it this way, then return ~0 instead. At least that way there is no ugly cast. Ok. I'll

Re: [patch 53/60] x86/mm: Use/Fix PCID to optimize user/kernel switches

On Mon, Dec 4, 2017 at 6:07 AM, Thomas Gleixner wrote: > We can use PCID to retain the TLBs across CR3 switches; including > those now part of the user/kernel switch. This increases performance > of kernel entry/exit at the cost of more expensive/complicated TLB > flushing. >

Re: [patch 53/60] x86/mm: Use/Fix PCID to optimize user/kernel switches

On Mon, Dec 4, 2017 at 6:07 AM, Thomas Gleixner wrote: > We can use PCID to retain the TLBs across CR3 switches; including > those now part of the user/kernel switch. This increases performance > of kernel entry/exit at the cost of more expensive/complicated TLB > flushing. > > Now that we have

Re: [PATCH 4.14 00/95] 4.14.4-stable review

> On Dec 5, 2017, at 12:24 AM, Greg Kroah-Hartman > wrote: > > On Mon, Dec 04, 2017 at 03:12:45PM -0600, Tom Gall wrote: >> >> >>> On Dec 4, 2017, at 9:59 AM, Greg Kroah-Hartman >>> wrote: >>> >>> This is the start of the stable

Re: [PATCH 4.14 00/95] 4.14.4-stable review

> On Dec 5, 2017, at 12:24 AM, Greg Kroah-Hartman > wrote: > > On Mon, Dec 04, 2017 at 03:12:45PM -0600, Tom Gall wrote: >> >> >>> On Dec 4, 2017, at 9:59 AM, Greg Kroah-Hartman >>> wrote: >>> >>> This is the start of the stable review cycle for the 4.14.4 release. >>> There are 95

Re: [PATCH] ocfs2: use get_task_comm

On Tue, Dec 5, 2017 at 9:32 PM, Kees Cook wrote: > On Tue, Dec 5, 2017 at 12:27 PM, Arnd Bergmann wrote: >> >> More generally speaking though, how exactly do we guarantee that >> there is NUL-termination on tsk->comm during a concurrent update? >> Could we

Re: [PATCH] ocfs2: use get_task_comm

On Tue, Dec 5, 2017 at 9:32 PM, Kees Cook wrote: > On Tue, Dec 5, 2017 at 12:27 PM, Arnd Bergmann wrote: >> >> More generally speaking though, how exactly do we guarantee that >> there is NUL-termination on tsk->comm during a concurrent update? >> Could we ever get into a situation where

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 01:36:44PM -0800, Paul E. McKenney wrote: > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 05, 2017 at 12:08:01PM -0800, Paul E. McKenney wrote: > > > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > > > On Tue,

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 01:36:44PM -0800, Paul E. McKenney wrote: > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 05, 2017 at 12:08:01PM -0800, Paul E. McKenney wrote: > > > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > > > On Tue,

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 10:17:35PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 10:28:38PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 05, 2017 at 08:57:52PM +0100, Peter Zijlstra wrote: > > > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > > > > >

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 10:17:35PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 10:28:38PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 05, 2017 at 08:57:52PM +0100, Peter Zijlstra wrote: > > > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > > > > >

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 12:08:01PM -0800, Paul E. McKenney wrote: > > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 05, 2017 at 11:33:39AM -0800, Paul E. McKenney wrote: > > > > On Tue,

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 12:08:01PM -0800, Paul E. McKenney wrote: > > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 05, 2017 at 11:33:39AM -0800, Paul E. McKenney wrote: > > > > On Tue,

[PATCH] perf, tools: Fix perf stat for old kernels w/o PERF_SAMPLE_IDENTIFIER

From: Andi Kleen PERF_SAMPLE_IDENTIFIER is a newer kernel feature and not available on old kernels. Since 4979d0c7d0c7 ("perf stat record: Add record command") we set it unconditionally for perf stat, which makes perf stat show all counters as "not supported" on a 3.0

[PATCH] perf, tools: Fix perf stat for old kernels w/o PERF_SAMPLE_IDENTIFIER

From: Andi Kleen PERF_SAMPLE_IDENTIFIER is a newer kernel feature and not available on old kernels. Since 4979d0c7d0c7 ("perf stat record: Add record command") we set it unconditionally for perf stat, which makes perf stat show all counters as "not supported" on a 3.0 kernel. Make it

<    3   4   5   6   7   8   9   10   11   12   >