Re: [PATCH] scripts/faddr2line: extend usage on generic arch

2017-12-05 Thread Richard Weinberger
On Tue, Nov 21, 2017 at 10:29 AM, Liu, Changcheng wrote: > fadd2line script should use the binary tool > used for the target system. > > Signed-off-by: Liu Changcheng > > diff --git a/scripts/faddr2line b/scripts/faddr2line > index

Re: [PATCH] scripts/faddr2line: extend usage on generic arch

2017-12-05 Thread Richard Weinberger
On Tue, Nov 21, 2017 at 10:29 AM, Liu, Changcheng wrote: > fadd2line script should use the binary tool > used for the target system. > > Signed-off-by: Liu Changcheng > > diff --git a/scripts/faddr2line b/scripts/faddr2line > index 1f5ce95..39e07d8 100755 > --- a/scripts/faddr2line > +++

Re: [tip:x86/mpx] x86/insn-eval: Add utility function to get segment descriptor

2017-12-05 Thread Borislav Petkov
On Tue, Dec 05, 2017 at 07:38:45PM +0100, Peter Zijlstra wrote: > Sorry what? So either this code is broken because it has IRQs enabled, > or its broken because its trying to acquire a mutex with IRQs disabled. > Which is it? Well, lemme try to sum up what Peter, Thomas and I discussed on IRC:

Re: [tip:x86/mpx] x86/insn-eval: Add utility function to get segment descriptor

2017-12-05 Thread Borislav Petkov
On Tue, Dec 05, 2017 at 07:38:45PM +0100, Peter Zijlstra wrote: > Sorry what? So either this code is broken because it has IRQs enabled, > or its broken because its trying to acquire a mutex with IRQs disabled. > Which is it? Well, lemme try to sum up what Peter, Thomas and I discussed on IRC:

Re: [PATCH 2/2] net: macb: kill useless use of list_empty()

2017-12-05 Thread Nicolas Ferre
On 05/12/2017 at 21:18, Julia Cartwright wrote: > The list_for_each_entry() macro already handles the case where the list > is empty (by not executing the loop body). It's not necessary to handle > this case specially, so stop doing so. > > Cc: Rafal Ozieblo > Signed-off-by:

Re: [PATCH 2/2] net: macb: kill useless use of list_empty()

2017-12-05 Thread Nicolas Ferre
On 05/12/2017 at 21:18, Julia Cartwright wrote: > The list_for_each_entry() macro already handles the case where the list > is empty (by not executing the loop body). It's not necessary to handle > this case specially, so stop doing so. > > Cc: Rafal Ozieblo > Signed-off-by: Julia Cartwright >

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

2017-12-05 Thread Matthew Wilcox
On Tue, Dec 05, 2017 at 07:11:00AM +1100, NeilBrown wrote: > As we don't seem to be pursuing this possibility is probably isn't very > important, but I'd like to point out that the original fix isn't a true > fix. > It just sorts a shared group_info early. This does not stop corruption. > Every

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

2017-12-05 Thread Matthew Wilcox
On Tue, Dec 05, 2017 at 07:11:00AM +1100, NeilBrown wrote: > As we don't seem to be pursuing this possibility is probably isn't very > important, but I'd like to point out that the original fix isn't a true > fix. > It just sorts a shared group_info early. This does not stop corruption. > Every

Re: [PATCH 5/9] x86/uv: Use the right tlbflush API

2017-12-05 Thread Peter Zijlstra
On Tue, Dec 05, 2017 at 03:09:48PM -0600, Andrew Banman wrote: > On 12/5/17 6:34 AM, Peter Zijlstra wrote: > >Since uv_flush_tlb_others() implements flush_tlb_others() which is > >about flushing user mappings, we should use __flush_tlb_single(), > >which too is about flushing user mappings. > > >

Re: [PATCH 5/9] x86/uv: Use the right tlbflush API

2017-12-05 Thread Peter Zijlstra
On Tue, Dec 05, 2017 at 03:09:48PM -0600, Andrew Banman wrote: > On 12/5/17 6:34 AM, Peter Zijlstra wrote: > >Since uv_flush_tlb_others() implements flush_tlb_others() which is > >about flushing user mappings, we should use __flush_tlb_single(), > >which too is about flushing user mappings. > > >

Re: [PATCH 1/2] net: macb: reduce scope of rx_fs_lock-protected regions

2017-12-05 Thread Nicolas Ferre
On 05/12/2017 at 21:17, Julia Cartwright wrote: > Commit ae8223de3df5 ("net: macb: Added support for RX filtering") > introduces a lock, rx_fs_lock which is intended to protect the list of > rx_flow items and synchronize access to the hardware rx filtering > registers. > > However, the region

Re: [PATCH 1/2] net: macb: reduce scope of rx_fs_lock-protected regions

2017-12-05 Thread Nicolas Ferre
On 05/12/2017 at 21:17, Julia Cartwright wrote: > Commit ae8223de3df5 ("net: macb: Added support for RX filtering") > introduces a lock, rx_fs_lock which is intended to protect the list of > rx_flow items and synchronize access to the hardware rx filtering > registers. > > However, the region

Re: [PATCH v2 08/19] ASoC: tlv320aic31xx: Switch GPIO handling to use gpiod_* API

2017-12-05 Thread Andrew F. Davis
On 12/04/2017 10:47 AM, Andrew F. Davis wrote: > On 11/29/2017 03:32 PM, Andrew F. Davis wrote: >> Move to using newer gpiod_* GPIO handling functions. This simplifies >> the code and eases dropping platform data in the next patch. Also >> remember GPIO are active low, so set "1" to reset. >> >>

Re: [PATCH v2 08/19] ASoC: tlv320aic31xx: Switch GPIO handling to use gpiod_* API

2017-12-05 Thread Andrew F. Davis
On 12/04/2017 10:47 AM, Andrew F. Davis wrote: > On 11/29/2017 03:32 PM, Andrew F. Davis wrote: >> Move to using newer gpiod_* GPIO handling functions. This simplifies >> the code and eases dropping platform data in the next patch. Also >> remember GPIO are active low, so set "1" to reset. >> >>

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Michael S. Tsirkin
On Tue, Dec 05, 2017 at 12:08:01PM -0800, Paul E. McKenney wrote: > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 05, 2017 at 11:33:39AM -0800, Paul E. McKenney wrote: > > > On Tue, Dec 05, 2017 at 09:24:21PM +0200, Michael S. Tsirkin wrote: > > [ . . . ] >

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Michael S. Tsirkin
On Tue, Dec 05, 2017 at 12:08:01PM -0800, Paul E. McKenney wrote: > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 05, 2017 at 11:33:39AM -0800, Paul E. McKenney wrote: > > > On Tue, Dec 05, 2017 at 09:24:21PM +0200, Michael S. Tsirkin wrote: > > [ . . . ] >

Re: [PATCH v3] scripts/package: snap-pkg target

2017-12-05 Thread Jim Davis
On Tue, Dec 5, 2017 at 4:43 AM, Paolo Pisati wrote: >> I noticed that if I tried to make snap-pkg with the O=/some/dir option >> the tar step failed but the rest of the build continued, and seems to >> have finished successfully. Should the snap-pkg target stop after

Re: [PATCH v3] scripts/package: snap-pkg target

2017-12-05 Thread Jim Davis
On Tue, Dec 5, 2017 at 4:43 AM, Paolo Pisati wrote: >> I noticed that if I tried to make snap-pkg with the O=/some/dir option >> the tar step failed but the rest of the build continued, and seems to >> have finished successfully. Should the snap-pkg target stop after a >> tar failure? > > That

Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission

2017-12-05 Thread Vinicius Costa Gomes
Hi David, David Miller writes: > From: Richard Cochran > Date: Mon, 18 Sep 2017 09:41:15 +0200 > >> - The driver does not handle out of order packets. If user space >> sends a packet with an earlier Tx time, then the code should stop >>

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-05 Thread Rob Herring
On Tue, Dec 5, 2017 at 11:04 AM, Sinan Kaya wrote: > Now that we have a get_match_data() callback as part of the firmware node, > implement the OF specific piece for it. > > Signed-off-by: Sinan Kaya > --- > drivers/of/property.c | 7 +++ > 1 file

Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission

2017-12-05 Thread Vinicius Costa Gomes
Hi David, David Miller writes: > From: Richard Cochran > Date: Mon, 18 Sep 2017 09:41:15 +0200 > >> - The driver does not handle out of order packets. If user space >> sends a packet with an earlier Tx time, then the code should stop >> the queue, reshuffle the descriptors

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-05 Thread Rob Herring
On Tue, Dec 5, 2017 at 11:04 AM, Sinan Kaya wrote: > Now that we have a get_match_data() callback as part of the firmware node, > implement the OF specific piece for it. > > Signed-off-by: Sinan Kaya > --- > drivers/of/property.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-12-05 Thread Linus Torvalds
On Tue, Dec 5, 2017 at 1:08 PM, Randy Dunlap wrote: > > This kind of option (with default hashed) is what I was just thinking of > after having seen a few unhelpful traces. But then the knob might not be > changed in time for the traces either. :( .. I really dislike the

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-12-05 Thread Linus Torvalds
On Tue, Dec 5, 2017 at 1:08 PM, Randy Dunlap wrote: > > This kind of option (with default hashed) is what I was just thinking of > after having seen a few unhelpful traces. But then the knob might not be > changed in time for the traces either. :( .. I really dislike the idea of such a knob.

Re: [PATCH v2 09/19] ASoC: tlv320aic31xx: Remove platform data

2017-12-05 Thread Andrew F. Davis
On 12/01/2017 07:26 AM, Mark Brown wrote: > On Wed, Nov 29, 2017 at 03:32:50PM -0600, Andrew F. Davis wrote: >> Platform data is not used by anyone (at least in upstream) so >> drop this data and switch to using fwnode(DT/ACPI) only. > > The advantage being...? Not all architectures use DT or

Re: [PATCH v2 09/19] ASoC: tlv320aic31xx: Remove platform data

2017-12-05 Thread Andrew F. Davis
On 12/01/2017 07:26 AM, Mark Brown wrote: > On Wed, Nov 29, 2017 at 03:32:50PM -0600, Andrew F. Davis wrote: >> Platform data is not used by anyone (at least in upstream) so >> drop this data and switch to using fwnode(DT/ACPI) only. > > The advantage being...? Not all architectures use DT or

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Peter Zijlstra
On Tue, Dec 05, 2017 at 10:28:38PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 08:57:52PM +0100, Peter Zijlstra wrote: > > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > > > > WRITE_ONCE(obj->val, 1); > > > > > smp_wmb(); > > > > > WRITE_ONCE(*foo, obj); > >

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

2017-12-05 Thread Peter Zijlstra
On Tue, Dec 05, 2017 at 10:28:38PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 05, 2017 at 08:57:52PM +0100, Peter Zijlstra wrote: > > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > > > > WRITE_ONCE(obj->val, 1); > > > > > smp_wmb(); > > > > > WRITE_ONCE(*foo, obj); > >

Re: [RFC v3 PATCH 0/2] Introduce Security Version to EFI Stub

2017-12-05 Thread Josh Boyer
On Tue, Dec 5, 2017 at 5:01 AM, Gary Lin wrote: > The series of patches introduce Security Version to EFI stub. > > Security Version is a monotonically increasing number and designed to > prevent the user from loading an insecure kernel accidentally. The > bootloader maintains a

Re: [RFC v3 PATCH 0/2] Introduce Security Version to EFI Stub

2017-12-05 Thread Josh Boyer
On Tue, Dec 5, 2017 at 5:01 AM, Gary Lin wrote: > The series of patches introduce Security Version to EFI stub. > > Security Version is a monotonically increasing number and designed to > prevent the user from loading an insecure kernel accidentally. The > bootloader maintains a list of security

Re: [PATCH 5/9] x86/uv: Use the right tlbflush API

2017-12-05 Thread Andrew Banman
On 12/5/17 6:34 AM, Peter Zijlstra wrote: Since uv_flush_tlb_others() implements flush_tlb_others() which is about flushing user mappings, we should use __flush_tlb_single(), which too is about flushing user mappings. Cc: Andrew Banman Cc: Mike Travis

Re: [PATCH 5/9] x86/uv: Use the right tlbflush API

2017-12-05 Thread Andrew Banman
On 12/5/17 6:34 AM, Peter Zijlstra wrote: Since uv_flush_tlb_others() implements flush_tlb_others() which is about flushing user mappings, we should use __flush_tlb_single(), which too is about flushing user mappings. Cc: Andrew Banman Cc: Mike Travis Signed-off-by: Peter Zijlstra (Intel) ---

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-12-05 Thread Randy Dunlap
On 11/30/2017 02:38 AM, David Laight wrote: > From: Kees Cook >> Sent: 29 November 2017 22:28 >> On Wed, Nov 29, 2017 at 2:07 AM, David Laight >> wrote: >>> From: Linus Torvalds Sent: 29 November 2017 02:29 On Tue, Nov 28, 2017 at 6:05 PM, Tobin C. Harding

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-12-05 Thread Randy Dunlap
On 11/30/2017 02:38 AM, David Laight wrote: > From: Kees Cook >> Sent: 29 November 2017 22:28 >> On Wed, Nov 29, 2017 at 2:07 AM, David Laight >> wrote: >>> From: Linus Torvalds Sent: 29 November 2017 02:29 On Tue, Nov 28, 2017 at 6:05 PM, Tobin C. Harding wrote: > >

Re: [PATCH 3/9] x86/early-quirks: reverse the if ladders

2017-12-05 Thread Ville Syrjälä
On Tue, Dec 05, 2017 at 09:02:43PM +, Matthew Auld wrote: > Makes things a little easier to follow. > > Suggested-by: Ville Syrjälä > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Ville

Re: [PATCH 3/9] x86/early-quirks: reverse the if ladders

2017-12-05 Thread Ville Syrjälä
On Tue, Dec 05, 2017 at 09:02:43PM +, Matthew Auld wrote: > Makes things a little easier to follow. > > Suggested-by: Ville Syrjälä > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Ville Syrjälä > Cc: Chris Wilson > Cc: Paulo Zanoni > Cc: Thomas Gleixner > Cc: Ingo Molnar >

[PATCH 3/9] x86/early-quirks: reverse the if ladders

2017-12-05 Thread Matthew Auld
Makes things a little easier to follow. Suggested-by: Ville Syrjälä Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris Wilson

[PATCH 3/9] x86/early-quirks: reverse the if ladders

2017-12-05 Thread Matthew Auld
Makes things a little easier to follow. Suggested-by: Ville Syrjälä Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris Wilson Cc: Paulo Zanoni Cc: Thomas Gleixner Cc: Ingo Molnar Cc: H. Peter Anvin Cc: x...@kernel.org Cc: linux-kernel@vger.kernel.org ---

[PATCH 1/9] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-12-05 Thread Matthew Auld
From: Joonas Lahtinen To give upcoming SKU BIOSes more flexibility in placing the Intel graphics stolen memory, make all variables storing the placement or size compatible with full 64 bit range. Also by exporting the stolen region as a resource, we can then nuke

[PATCH 1/9] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-12-05 Thread Matthew Auld
From: Joonas Lahtinen To give upcoming SKU BIOSes more flexibility in placing the Intel graphics stolen memory, make all variables storing the placement or size compatible with full 64 bit range. Also by exporting the stolen region as a resource, we can then nuke the duplicated stolen discovery

[PATCH 2/9] x86/early-quirks: replace the magical increment start values

2017-12-05 Thread Matthew Auld
Replace the magical +2, +9 etc. with +MB, which is far easier to read. Suggested-by: Ville Syrjälä Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris

[PATCH 2/9] x86/early-quirks: replace the magical increment start values

2017-12-05 Thread Matthew Auld
Replace the magical +2, +9 etc. with +MB, which is far easier to read. Suggested-by: Ville Syrjälä Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris Wilson Cc: Paulo Zanoni Cc: Thomas Gleixner Cc: Ingo Molnar Cc: H. Peter Anvin Cc: x...@kernel.org Cc:

[PATCH] ACPI / GED: unregister interrupts during shutdown

2017-12-05 Thread Sinan Kaya
Some GED interrupts could be pending by the time we are doing a reboot. Even though GED driver uses devm_request_irq() to register the interrupt handler, the handler is not being freed on time during a shutdown since the driver is missing a shutdown callback. If the ACPI handler is no longer

[PATCH] ACPI / GED: unregister interrupts during shutdown

2017-12-05 Thread Sinan Kaya
Some GED interrupts could be pending by the time we are doing a reboot. Even though GED driver uses devm_request_irq() to register the interrupt handler, the handler is not being freed on time during a shutdown since the driver is missing a shutdown callback. If the ACPI handler is no longer

Re: [RFC PATCH v3 1/7] ktask: add documentation

2017-12-05 Thread Daniel Jordan
Forgot to cc Randy Dunlap and add his Reviewed-by from v2. On 12/05/2017 02:52 PM, Daniel Jordan wrote: Motivates and explains the ktask API for kernel clients. Signed-off-by: Daniel Jordan Reviewed-by: Steve Sistare

Re: [RFC PATCH v3 1/7] ktask: add documentation

2017-12-05 Thread Daniel Jordan
Forgot to cc Randy Dunlap and add his Reviewed-by from v2. On 12/05/2017 02:52 PM, Daniel Jordan wrote: Motivates and explains the ktask API for kernel clients. Signed-off-by: Daniel Jordan Reviewed-by: Steve Sistare Reviewed-by: Randy Dunlap Daniel Cc: Aaron Lu Cc: Andrew Morton Cc:

Re: [PATCH v3 1/8] SOC: brcmstb: add memory API

2017-12-05 Thread Bjorn Helgaas
On Tue, Nov 14, 2017 at 05:12:05PM -0500, Jim Quinlan wrote: > From: Florian Fainelli > > This commit adds a memory API suitable for ascertaining the sizes of > each of the N memory controllers in a Broadcom STB chip. Its first > user will be the Broadcom STB PCIe root

Re: [PATCH v3 1/8] SOC: brcmstb: add memory API

2017-12-05 Thread Bjorn Helgaas
On Tue, Nov 14, 2017 at 05:12:05PM -0500, Jim Quinlan wrote: > From: Florian Fainelli > > This commit adds a memory API suitable for ascertaining the sizes of > each of the N memory controllers in a Broadcom STB chip. Its first > user will be the Broadcom STB PCIe root complex driver, which

Re: [PATCH 4/8] ARM: dts: imx7s: add dma support

2017-12-05 Thread Tyler Baker
On Fri, Dec 1, 2017 at 12:17 PM, Fabio Estevam wrote: > On Thu, Nov 30, 2017 at 6:14 PM, wrote: >> From: Tyler Baker >> >> Enable dma on all SPI and UART interfaces. > > You only touched SPI ports, not the UART.

Re: [PATCH 4/8] ARM: dts: imx7s: add dma support

2017-12-05 Thread Tyler Baker
On Fri, Dec 1, 2017 at 12:17 PM, Fabio Estevam wrote: > On Thu, Nov 30, 2017 at 6:14 PM, wrote: >> From: Tyler Baker >> >> Enable dma on all SPI and UART interfaces. > > You only touched SPI ports, not the UART. I'll update the commit message, thanks.

Re: [PATCH 3/8] ARM: dts: imx7d-cl-som: add nodes for usbh, and usbotg2

2017-12-05 Thread Tyler Baker
On Fri, Dec 1, 2017 at 12:13 PM, Fabio Estevam wrote: > On Thu, Nov 30, 2017 at 6:14 PM, wrote: >> From: Tyler Baker >> >> Add device tree nodes for the USB hub, and USB OTG. i2c2 on this >> platform supports low

Re: [PATCH 3/8] ARM: dts: imx7d-cl-som: add nodes for usbh, and usbotg2

2017-12-05 Thread Tyler Baker
On Fri, Dec 1, 2017 at 12:13 PM, Fabio Estevam wrote: > On Thu, Nov 30, 2017 at 6:14 PM, wrote: >> From: Tyler Baker >> >> Add device tree nodes for the USB hub, and USB OTG. i2c2 on this >> platform supports low state retention power state so lets use it. >> >> Signed-off-by: Tyler Baker >>

Re: [PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts

2017-12-05 Thread Tyler Baker
On Fri, Dec 1, 2017 at 12:10 PM, Fabio Estevam wrote: > On Thu, Nov 30, 2017 at 6:14 PM, wrote: > >> + { >> + fsl,spi-num-chipselects = <1>; > > Please remove this property. It is no longer used. Ack. > > >> + dvicape@39 { >> +

Re: [PATCH 2/8] ARM: dts: imx7: build imx7d-sbc-iot-imx7 dtb

2017-12-05 Thread Tyler Baker
On Fri, Dec 1, 2017 at 12:11 PM, Fabio Estevam wrote: > On Thu, Nov 30, 2017 at 6:14 PM, wrote: >> From: Tyler Baker >> >> Build the imx7d-sbc-iot-imx7 device tree blob. >> >> Signed-off-by: Tyler Baker

Re: [PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts

2017-12-05 Thread Tyler Baker
On Fri, Dec 1, 2017 at 12:10 PM, Fabio Estevam wrote: > On Thu, Nov 30, 2017 at 6:14 PM, wrote: > >> + { >> + fsl,spi-num-chipselects = <1>; > > Please remove this property. It is no longer used. Ack. > > >> + dvicape@39 { >> + compatible = "sil164_simple"; > > This

Re: [PATCH 2/8] ARM: dts: imx7: build imx7d-sbc-iot-imx7 dtb

2017-12-05 Thread Tyler Baker
On Fri, Dec 1, 2017 at 12:11 PM, Fabio Estevam wrote: > On Thu, Nov 30, 2017 at 6:14 PM, wrote: >> From: Tyler Baker >> >> Build the imx7d-sbc-iot-imx7 device tree blob. >> >> Signed-off-by: Tyler Baker >> --- >> arch/arm/boot/dts/Makefile | 1 + >> 1 file changed, 1 insertion(+) >> >> diff

Re: [PATCH 8/8] PCIe: imx6: imx7d: add support for phy refclk source

2017-12-05 Thread Tyler Baker
On Fri, Dec 1, 2017 at 12:21 PM, Fabio Estevam wrote: > On Thu, Nov 30, 2017 at 6:14 PM, wrote: >> From: Tyler Baker >> >> In the i.MX7D the PCIe PHY can use either externel oscillator or >> internal PLL as a

Re: [PATCH 8/8] PCIe: imx6: imx7d: add support for phy refclk source

2017-12-05 Thread Tyler Baker
On Fri, Dec 1, 2017 at 12:21 PM, Fabio Estevam wrote: > On Thu, Nov 30, 2017 at 6:14 PM, wrote: >> From: Tyler Baker >> >> In the i.MX7D the PCIe PHY can use either externel oscillator or >> internal PLL as a reference clock source. >> Add support for the PHY Reference Clock source including

Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-05 Thread Serge Semin
On Tue, Dec 05, 2017 at 01:08:44PM -0500, Jon Mason wrote: > On Tue, Dec 5, 2017 at 12:56 PM, Serge Semin wrote: > > On Tue, Dec 05, 2017 at 11:52:32AM -0500, Jon Mason > > wrote: > >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin

Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-05 Thread Serge Semin
On Tue, Dec 05, 2017 at 01:08:44PM -0500, Jon Mason wrote: > On Tue, Dec 5, 2017 at 12:56 PM, Serge Semin wrote: > > On Tue, Dec 05, 2017 at 11:52:32AM -0500, Jon Mason > > wrote: > >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin > >> wrote: > >> > Simple (1 << pidx) operation causes

Re: kernel CI: printk loglevels in kernel boot logs?

2017-12-05 Thread Steven Rostedt
On Tue, 5 Dec 2017 16:55:37 +0100 Petr Mladek wrote: > I would have agreed with this argument few weeks ago but I do not get > it any longer. If there are tools depending on the message format > and people enable the extended format, the tools might stop working. > > You might

Re: kernel CI: printk loglevels in kernel boot logs?

2017-12-05 Thread Steven Rostedt
On Tue, 5 Dec 2017 16:55:37 +0100 Petr Mladek wrote: > I would have agreed with this argument few weeks ago but I do not get > it any longer. If there are tools depending on the message format > and people enable the extended format, the tools might stop working. > > You might argue that these

Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods

2017-12-05 Thread Serge Semin
On Tue, Dec 05, 2017 at 01:07:26PM -0500, Jon Mason wrote: > On Tue, Dec 5, 2017 at 12:31 PM, Serge Semin wrote: > > On Tue, Dec 05, 2017 at 11:49:10AM -0500, Jon Mason > > wrote: > >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin

Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods

2017-12-05 Thread Serge Semin
On Tue, Dec 05, 2017 at 01:07:26PM -0500, Jon Mason wrote: > On Tue, Dec 5, 2017 at 12:31 PM, Serge Semin wrote: > > On Tue, Dec 05, 2017 at 11:49:10AM -0500, Jon Mason > > wrote: > >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin > >> wrote: > >> > There is a common methods signature form

[PATCH v3 2/2] ASoC: codecs: Add initial PCM1862/63/64/65 universal ADC driver

2017-12-05 Thread Andrew F. Davis
From: Andreas Dannenberg This is an initial version of the PCM186x codec driver supporting both 2-channel and 4-channel device variants. Not all device features are supported yet such as master/slave mode PLL configuration for which the codec driver currently relies on the

[PATCH v3 2/2] ASoC: codecs: Add initial PCM1862/63/64/65 universal ADC driver

2017-12-05 Thread Andrew F. Davis
From: Andreas Dannenberg This is an initial version of the PCM186x codec driver supporting both 2-channel and 4-channel device variants. Not all device features are supported yet such as master/slave mode PLL configuration for which the codec driver currently relies on the PCM186x built-in clock

[PATCH v3 1/2] ASoC: codecs: Add PCM186x binding documentation

2017-12-05 Thread Andrew F. Davis
Add the dt-binding documentation for the TI PCM186x 2ch and 4ch Audio ADCs With Universal Front End. Signed-off-by: Andrew F. Davis Acked-by: Rob Herring --- Changes from v2: - None Changes from v1: - pcm186x@4a -> audio-codec@4a - Added Acked-by

[PATCH v3 1/2] ASoC: codecs: Add PCM186x binding documentation

2017-12-05 Thread Andrew F. Davis
Add the dt-binding documentation for the TI PCM186x 2ch and 4ch Audio ADCs With Universal Front End. Signed-off-by: Andrew F. Davis Acked-by: Rob Herring --- Changes from v2: - None Changes from v1: - pcm186x@4a -> audio-codec@4a - Added Acked-by .../devicetree/bindings/sound/pcm186x.txt

Re: [PATCH] efi: move some sysfs files to be read-only by root

2017-12-05 Thread Tobin C. Harding
On Tue, Dec 05, 2017 at 11:13:43AM +0100, Greg Kroah-Hartman wrote: > Thanks to the scripts/leaking_addresses.pl script, it was found that > some EFI values should not be readable by non-root users. > > So make them root-only, and to do that, add a __ATTR_RO_MODE() macro to > make this easier,

Re: [PATCH] efi: move some sysfs files to be read-only by root

2017-12-05 Thread Tobin C. Harding
On Tue, Dec 05, 2017 at 11:13:43AM +0100, Greg Kroah-Hartman wrote: > Thanks to the scripts/leaking_addresses.pl script, it was found that > some EFI values should not be readable by non-root users. > > So make them root-only, and to do that, add a __ATTR_RO_MODE() macro to > make this easier,

Re: [PATCH -next] pci: add function stub for pci_get_domain_bus_and_slot()

2017-12-05 Thread Sinan Kaya
On 12/5/2017 3:39 PM, Bjorn Helgaas wrote: > [+cc Sinan] > > On Tue, Nov 28, 2017 at 02:31:21PM -0800, Randy Dunlap wrote: >> From: Randy Dunlap >> >> The coretemp driver build fails when CONFIG_PCI is not enabled >> because it uses a function that does not have a stub for

Re: [PATCH -next] pci: add function stub for pci_get_domain_bus_and_slot()

2017-12-05 Thread Sinan Kaya
On 12/5/2017 3:39 PM, Bjorn Helgaas wrote: > [+cc Sinan] > > On Tue, Nov 28, 2017 at 02:31:21PM -0800, Randy Dunlap wrote: >> From: Randy Dunlap >> >> The coretemp driver build fails when CONFIG_PCI is not enabled >> because it uses a function that does not have a stub for that >> config case,

[PATCH v8 2/2] leds: lm3692x: Introduce LM3692x dual string driver

2017-12-05 Thread Dan Murphy
Introducing the LM3692x Dual-String white LED driver. Data sheet is located http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf Signed-off-by: Dan Murphy --- v8 - No changes v7 - Reverted back to creating the LED label within the driver - https://patchwork.kernel.org/patch/10087473/

[PATCH v8 2/2] leds: lm3692x: Introduce LM3692x dual string driver

2017-12-05 Thread Dan Murphy
Introducing the LM3692x Dual-String white LED driver. Data sheet is located http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf Signed-off-by: Dan Murphy --- v8 - No changes v7 - Reverted back to creating the LED label within the driver - https://patchwork.kernel.org/patch/10087473/ v6 - Use new LED

[PATCH v8 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

2017-12-05 Thread Dan Murphy
This adds the devicetree bindings for the LM3692x I2C LED string driver. Acked-by: Pavel Machek Signed-off-by: Dan Murphy --- v8 - Added address-cells and size-cells as well as child node reg - https://patchwork.kernel.org/patch/10091259/ v7 - No changes -

[PATCH v8 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

2017-12-05 Thread Dan Murphy
This adds the devicetree bindings for the LM3692x I2C LED string driver. Acked-by: Pavel Machek Signed-off-by: Dan Murphy --- v8 - Added address-cells and size-cells as well as child node reg - https://patchwork.kernel.org/patch/10091259/ v7 - No changes -

[PATCH v2 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860

2017-12-05 Thread Dan Murphy
Add a default trigger optional node to the child node. This will allow the driver to set the trigger for a backlight. Signed-off-by: Dan Murphy --- v2 - Moved binding changes to first patch in the series. Documentation/devicetree/bindings/leds/leds-lp8860.txt | 3 +++ 1 file

[PATCH v2 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860

2017-12-05 Thread Dan Murphy
Add a default trigger optional node to the child node. This will allow the driver to set the trigger for a backlight. Signed-off-by: Dan Murphy --- v2 - Moved binding changes to first patch in the series. Documentation/devicetree/bindings/leds/leds-lp8860.txt | 3 +++ 1 file changed, 3

[PATCH v2 0/6] Updated lp8860 led driver

2017-12-05 Thread Dan Murphy
All v2 - Added an initial patch to bring the DT binding up to standard prior to adding the changes for the label and triggers. v1 Cover letter repeat below After creating a new LED driver for the LM3692x device I went back to the LP8860 driver that I authored and found some updates that need

[PATCH v2 0/6] Updated lp8860 led driver

2017-12-05 Thread Dan Murphy
All v2 - Added an initial patch to bring the DT binding up to standard prior to adding the changes for the label and triggers. v1 Cover letter repeat below After creating a new LED driver for the LM3692x device I went back to the LP8860 driver that I authored and found some updates that need

[PATCH v2 3/6] leds: lp8860: Update the dt parsing for LED labeling

2017-12-05 Thread Dan Murphy
Update the DT parsing for the label node so that the label is retrieved from the device child as opposed to being part of the parent. This will align this driver with the LED binding documentation Documentation/devicetree/bindings/leds/common.txt Signed-off-by: Dan Murphy ---

[PATCH v2 3/6] leds: lp8860: Update the dt parsing for LED labeling

2017-12-05 Thread Dan Murphy
Update the DT parsing for the label node so that the label is retrieved from the device child as opposed to being part of the parent. This will align this driver with the LED binding documentation Documentation/devicetree/bindings/leds/common.txt Signed-off-by: Dan Murphy --- v2 - no changes

[PATCH v2 5/6] leds: lp8860: Add DT parsing to retrieve the trigger node

2017-12-05 Thread Dan Murphy
Add the ability to parse the DT and set the default trigger mode for the LED. Signed-off-by: Dan Murphy --- v2 - no changes drivers/leds/leds-lp8860.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c index

[PATCH v2 2/6] dt: bindings: lp8860: Update DT label binding

2017-12-05 Thread Dan Murphy
Update the lp8860 label binding to the LED standard as documented in Documentation/devicetree/bindings/leds/common.txt Signed-off-by: Dan Murphy --- v2 - Added reg to child node and made it required Documentation/devicetree/bindings/leds/leds-lp8860.txt | 12 ++-- 1

[PATCH v2 5/6] leds: lp8860: Add DT parsing to retrieve the trigger node

2017-12-05 Thread Dan Murphy
Add the ability to parse the DT and set the default trigger mode for the LED. Signed-off-by: Dan Murphy --- v2 - no changes drivers/leds/leds-lp8860.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c index

[PATCH v2 2/6] dt: bindings: lp8860: Update DT label binding

2017-12-05 Thread Dan Murphy
Update the lp8860 label binding to the LED standard as documented in Documentation/devicetree/bindings/leds/common.txt Signed-off-by: Dan Murphy --- v2 - Added reg to child node and made it required Documentation/devicetree/bindings/leds/leds-lp8860.txt | 12 ++-- 1 file changed, 10

[PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860

2017-12-05 Thread Dan Murphy
Update the lp8860 bindings to fix various issues found. Add address-cells and size-cells, rename enable-gpio to enable-gpios, update the node name to the device name and indent the node example. Signed-off-by: Dan Murphy --- v2 - New patch

[PATCH v2 6/6] leds: lp8860: Various fixes to align with LED framework

2017-12-05 Thread Dan Murphy
Update the driver to conform with the LED framework. Use devm_led_classdev_register Destroy mutex on exit Remove dependency on CONFIG_OF in the driver and move to the Kconfig Update the MODULE_LICENSE to GPL v2 Remove setting of MAX brightness as the LED framework does this. Signed-off-by: Dan

[PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860

2017-12-05 Thread Dan Murphy
Update the lp8860 bindings to fix various issues found. Add address-cells and size-cells, rename enable-gpio to enable-gpios, update the node name to the device name and indent the node example. Signed-off-by: Dan Murphy --- v2 - New patch .../devicetree/bindings/leds/leds-lp8860.txt |

[PATCH v2 6/6] leds: lp8860: Various fixes to align with LED framework

2017-12-05 Thread Dan Murphy
Update the driver to conform with the LED framework. Use devm_led_classdev_register Destroy mutex on exit Remove dependency on CONFIG_OF in the driver and move to the Kconfig Update the MODULE_LICENSE to GPL v2 Remove setting of MAX brightness as the LED framework does this. Signed-off-by: Dan

Re: [PATCH V11 3/5] printk: hash addresses printed with %p

2017-12-05 Thread Tobin C. Harding
On Tue, Dec 05, 2017 at 09:20:57PM +0100, Geert Uytterhoeven wrote: > Hi Tobin, > > On Wed, Nov 29, 2017 at 3:05 AM, Tobin C. Harding wrote: > > Currently there exist approximately 14 000 places in the kernel where > > addresses are being printed using an unadorned %p. This

Re: [PATCH V11 3/5] printk: hash addresses printed with %p

2017-12-05 Thread Tobin C. Harding
On Tue, Dec 05, 2017 at 09:20:57PM +0100, Geert Uytterhoeven wrote: > Hi Tobin, > > On Wed, Nov 29, 2017 at 3:05 AM, Tobin C. Harding wrote: > > Currently there exist approximately 14 000 places in the kernel where > > addresses are being printed using an unadorned %p. This potentially > > leaks

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Serge Semin
On Tue, Dec 05, 2017 at 01:27:57PM -0500, Jon Mason wrote: > On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > > DB interface of ntb_tool driver hasn't been changed much, but > > db_valid_mask DebugFS file has still been added to new ntb_tool > >

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Serge Semin
On Tue, Dec 05, 2017 at 01:27:57PM -0500, Jon Mason wrote: > On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > > DB interface of ntb_tool driver hasn't been changed much, but > > db_valid_mask DebugFS file has still been added to new ntb_tool > > driver. In this case it's much better to test

Re: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop using the flash

2017-12-05 Thread Cyrille Pitchen
Hi Hou, Le 05/12/2017 à 06:33, Zhiqiang Hou a écrit : > From: Hou Zhiqiang > > To be compatible with legacy device, reset the addressing mode > to the default mode. Such as Freescale eSPI boot, it copies the > images from SPI flash without firing a reset signal previously,

Re: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop using the flash

2017-12-05 Thread Cyrille Pitchen
Hi Hou, Le 05/12/2017 à 06:33, Zhiqiang Hou a écrit : > From: Hou Zhiqiang > > To be compatible with legacy device, reset the addressing mode > to the default mode. Such as Freescale eSPI boot, it copies the > images from SPI flash without firing a reset signal previously, > so the reboot

Re: [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-05 Thread Jacek Anaszewski
Hi Ben, On 12/05/2017 12:19 PM, Ben Whitten wrote: > From: Ben Whitten > > The patch was converted to led_blink_oneshot, in doing so we find that the > behaviour has changed. As I dont want to break 'userspace' led behaviour this > patch shouldn't be merged as is. Open to

Re: [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger

2017-12-05 Thread Jacek Anaszewski
Hi Ben, On 12/05/2017 12:19 PM, Ben Whitten wrote: > From: Ben Whitten > > The patch was converted to led_blink_oneshot, in doing so we find that the > behaviour has changed. As I dont want to break 'userspace' led behaviour this > patch shouldn't be merged as is. Open to suggestions. > >

Re: [PATCH -next] pci: add function stub for pci_get_domain_bus_and_slot()

2017-12-05 Thread Bjorn Helgaas
[+cc Sinan] On Tue, Nov 28, 2017 at 02:31:21PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > The coretemp driver build fails when CONFIG_PCI is not enabled > because it uses a function that does not have a stub for that > config case, so add the function stub. > >

Re: [PATCH -next] pci: add function stub for pci_get_domain_bus_and_slot()

2017-12-05 Thread Bjorn Helgaas
[+cc Sinan] On Tue, Nov 28, 2017 at 02:31:21PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > The coretemp driver build fails when CONFIG_PCI is not enabled > because it uses a function that does not have a stub for that > config case, so add the function stub. > >

<    4   5   6   7   8   9   10   11   12   13   >