Re: [PATCH 08/17] perf tools: Move kernel mmap name into struct machine

Em Tue, Feb 06, 2018 at 07:18:04PM +0100, Jiri Olsa escreveu: > It simplifies and centralizes the code. The kernel mmap > name is set for machine type, which we know from the > beginning, so there's no reason to generate it every time > we need it. > > Link:

Re: [PATCH] usb: musb: fix enumeration after resume

Hi, On Tue, 6 Feb 2018 10:47:25 -0800 Tony Lindgren wrote: > * Andreas Kemnade [180127 08:34]: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is not set. If it was set before suspend (because it > > was enabled

Re: [PATCH 07/17] perf tools: Free root_dir in machine__init error path

Em Tue, Feb 06, 2018 at 07:18:03PM +0100, Jiri Olsa escreveu: > Freeing root_dir in machine__init error path. > > Link: http://lkml.kernel.org/n/tip-ng92slsanexqw7h1d6sad...@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/util/machine.c | 8 +++- > 1 file

Re: [PATCH 07/17] perf tools: Free root_dir in machine__init error path

Em Tue, Feb 06, 2018 at 07:18:03PM +0100, Jiri Olsa escreveu: > Freeing root_dir in machine__init error path. > > Link: http://lkml.kernel.org/n/tip-ng92slsanexqw7h1d6sad...@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/util/machine.c | 8 +++- > 1 file changed, 7

Re: [PATCH v4 1/3] sched/fair: add util_est on top of PELT

On Tue, Feb 06, 2018 at 06:33:15PM +, Patrick Bellasi wrote: > Good point, I was actually expecting this question and I should have > added it to the cover letter, sorry. > > The reasoning was: the task's estimated utilization is defined as the > max between PELT and the "estimation". Where

Re: [PATCH v4 1/3] sched/fair: add util_est on top of PELT

On Tue, Feb 06, 2018 at 06:33:15PM +, Patrick Bellasi wrote: > Good point, I was actually expecting this question and I should have > added it to the cover letter, sorry. > > The reasoning was: the task's estimated utilization is defined as the > max between PELT and the "estimation". Where

Re: [PATCH 05/17] tools lib api fs: Add sysfs__read_xll function

Em Tue, Feb 06, 2018 at 07:18:01PM +0100, Jiri Olsa escreveu: > Adding sysfs__read_xll function to be able to read sysfs > files with hex numbers in, which do not have 0x prefix. Applied 2-5 in this series, continuing... - Arnaldo > Link:

Re: [PATCH 05/17] tools lib api fs: Add sysfs__read_xll function

Em Tue, Feb 06, 2018 at 07:18:01PM +0100, Jiri Olsa escreveu: > Adding sysfs__read_xll function to be able to read sysfs > files with hex numbers in, which do not have 0x prefix. Applied 2-5 in this series, continuing... - Arnaldo > Link:

Re: [PATCH 01/17] perf report: Ask ordered events for --tasks option

On Tue, Feb 06, 2018 at 03:48:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Feb 06, 2018 at 07:17:57PM +0100, Jiri Olsa escreveu: > > If we have the time in, keep the events in time order. > > Try to be more verbose, what actual effect this will have in this particular > case? > > So, I

Re: [PATCH 06/17] tools lib symbol: Skip non-address kallsyms line

Em Tue, Feb 06, 2018 at 04:06:49PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Feb 06, 2018 at 07:18:02PM +0100, Jiri Olsa escreveu: > > Adding check on failed attempt to parse the address > > and skip the line parsing early in that case. > > How did you stumble on that? Can you provide

Re: [PATCH 06/17] tools lib symbol: Skip non-address kallsyms line

Em Tue, Feb 06, 2018 at 04:06:49PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Feb 06, 2018 at 07:18:02PM +0100, Jiri Olsa escreveu: > > Adding check on failed attempt to parse the address > > and skip the line parsing early in that case. > > How did you stumble on that? Can you provide

Re: [PATCH 01/17] perf report: Ask ordered events for --tasks option

On Tue, Feb 06, 2018 at 03:48:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Feb 06, 2018 at 07:17:57PM +0100, Jiri Olsa escreveu: > > If we have the time in, keep the events in time order. > > Try to be more verbose, what actual effect this will have in this particular > case? > > So, I

Re: [PATCH 06/17] tools lib symbol: Skip non-address kallsyms line

Em Tue, Feb 06, 2018 at 07:18:02PM +0100, Jiri Olsa escreveu: > Adding check on failed attempt to parse the address > and skip the line parsing early in that case. How did you stumble on that? Can you provide an example of a line or situation where this would happen? - Arnaldo > Link:

Re: [PATCH 06/17] tools lib symbol: Skip non-address kallsyms line

Em Tue, Feb 06, 2018 at 07:18:02PM +0100, Jiri Olsa escreveu: > Adding check on failed attempt to parse the address > and skip the line parsing early in that case. How did you stumble on that? Can you provide an example of a line or situation where this would happen? - Arnaldo > Link:

Re: [PATCH v5 08/11] scsi: host template attribute groups

On Tue, 2018-02-06 at 18:06 +0200, Stanislav Nijnikov wrote: > + if (sdev->host->hostt->sdev_groups) { > + error = sysfs_create_groups(>sdev_gendev.kobj, > + sdev->host->hostt->sdev_groups); > + if (error) > +

Re: [PATCH v5 08/11] scsi: host template attribute groups

On Tue, 2018-02-06 at 18:06 +0200, Stanislav Nijnikov wrote: > + if (sdev->host->hostt->sdev_groups) { > + error = sysfs_create_groups(>sdev_gendev.kobj, > + sdev->host->hostt->sdev_groups); > + if (error) > +

Re: [PATCH 2/2] arm64: dts: sdm845: Add serial console support

On Tue 06 Feb 10:37 PST 2018, Doug Anderson wrote: > Hi, > > On Fri, Jan 26, 2018 at 2:18 PM, Stephen Boyd wrote: > > On 01/25, Rajendra Nayak wrote: > >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi > >> b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi > >> new file

Re: [PATCH 2/2] arm64: dts: sdm845: Add serial console support

On Tue 06 Feb 10:37 PST 2018, Doug Anderson wrote: > Hi, > > On Fri, Jan 26, 2018 at 2:18 PM, Stephen Boyd wrote: > > On 01/25, Rajendra Nayak wrote: > >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi > >> b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi > >> new file mode 100644 > >>

Re: [BUG] x86 : i486 reporting to be vulnerable to Meltdown/Spectre_V1/Spectre_V2

On Tue, Feb 06, 2018 at 01:33:30PM -0500, tedheadster wrote: > On Sat, Feb 3, 2018 at 2:37 AM, David Woodhouse wrote: > > On Fri, 2018-02-02 at 23:52 -0500, tedheadster wrote: > >> I just tested the 4.15 kernel and it is reporting that my old i486 > >> (non-cpuid capable) cpu

Re: [BUG] x86 : i486 reporting to be vulnerable to Meltdown/Spectre_V1/Spectre_V2

On Tue, Feb 06, 2018 at 01:33:30PM -0500, tedheadster wrote: > On Sat, Feb 3, 2018 at 2:37 AM, David Woodhouse wrote: > > On Fri, 2018-02-02 at 23:52 -0500, tedheadster wrote: > >> I just tested the 4.15 kernel and it is reporting that my old i486 > >> (non-cpuid capable) cpu is vulnerable to all

Re: [PATCH] usb: musb: fix enumeration after resume

Hi, On Tue, 6 Feb 2018 12:46:05 -0600 Bin Liu wrote: > Hi, > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is not set. If it was

Re: [PATCH] usb: musb: fix enumeration after resume

Hi, On Tue, 6 Feb 2018 12:46:05 -0600 Bin Liu wrote: > Hi, > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is not set. If it was set before

Re: [PATCH 2/2] arm64: dts: sdm845: Add serial console support

On Mon 29 Jan 00:18 PST 2018, Rajendra Nayak wrote: > On 01/27/2018 03:48 AM, Stephen Boyd wrote: > > On 01/25, Rajendra Nayak wrote: > >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi > >> b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi > >> new file mode 100644 > >> index

Re: [PATCH 2/2] arm64: dts: sdm845: Add serial console support

On Mon 29 Jan 00:18 PST 2018, Rajendra Nayak wrote: > On 01/27/2018 03:48 AM, Stephen Boyd wrote: > > On 01/25, Rajendra Nayak wrote: > >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi > >> b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi > >> new file mode 100644 > >> index

Re: [RFC PATCH 00/64] mm: towards parallel address space operations

On Mon, 05 Feb 2018, Laurent Dufour wrote: On 05/02/2018 02:26, Davidlohr Bueso wrote: From: Davidlohr Bueso Hi, This patchset is a new version of both the range locking machinery as well as a full mmap_sem conversion that makes use of it -- as the worst case scenario as

Re: [RFC PATCH 00/64] mm: towards parallel address space operations

On Mon, 05 Feb 2018, Laurent Dufour wrote: On 05/02/2018 02:26, Davidlohr Bueso wrote: From: Davidlohr Bueso Hi, This patchset is a new version of both the range locking machinery as well as a full mmap_sem conversion that makes use of it -- as the worst case scenario as all mmap_sem calls

Re: [PATCH v3 14/21] fpga: dfl: add fpga manager platform driver for FME

On Tue, Feb 6, 2018 at 12:47 AM, Wu Hao wrote: > On Mon, Feb 05, 2018 at 10:25:54PM -0600, Alan Tull wrote: >> On Mon, Feb 5, 2018 at 7:47 PM, Wu Hao wrote: >> > On Mon, Feb 05, 2018 at 10:36:45AM -0800, Luebbers, Enno wrote: >> >> Hi Hao, >> >> >> >> On Sun,

Re: [PATCH v3 14/21] fpga: dfl: add fpga manager platform driver for FME

On Tue, Feb 6, 2018 at 12:47 AM, Wu Hao wrote: > On Mon, Feb 05, 2018 at 10:25:54PM -0600, Alan Tull wrote: >> On Mon, Feb 5, 2018 at 7:47 PM, Wu Hao wrote: >> > On Mon, Feb 05, 2018 at 10:36:45AM -0800, Luebbers, Enno wrote: >> >> Hi Hao, >> >> >> >> On Sun, Feb 04, 2018 at 05:37:06PM +0800, Wu

Re: [PATCH 1/2] arm64: dts: sdm845: Add minimal dts/dtsi files for sdm845 SoC and MTP

On Thu 25 Jan 08:32 PST 2018, Rajendra Nayak wrote: > + spmi_bus: qcom,spmi@c44 { [..] > + }; > + While we have the chance, please remove this empty line. > + }; > +}; Regards, Bjorn

Re: [PATCH 1/2] arm64: dts: sdm845: Add minimal dts/dtsi files for sdm845 SoC and MTP

On Thu 25 Jan 08:32 PST 2018, Rajendra Nayak wrote: > + spmi_bus: qcom,spmi@c44 { [..] > + }; > + While we have the chance, please remove this empty line. > + }; > +}; Regards, Bjorn

Re: [PATCH] printk: Print error pointers as negative integers for %p

On Tue, Feb 6, 2018 at 11:21 AM, David Howells wrote: > The new hashing feature of unadorned printk("%p") makes it hard to spot if > the pointer actually carries an error value. Make %p print any pointer > that matches IS_ERR() as a negative integer. > > Should I set SMALL

Re: [PATCH] printk: Print error pointers as negative integers for %p

On Tue, Feb 6, 2018 at 11:21 AM, David Howells wrote: > The new hashing feature of unadorned printk("%p") makes it hard to spot if > the pointer actually carries an error value. Make %p print any pointer > that matches IS_ERR() as a negative integer. > > Should I set SMALL and the field_width as

Re: [PATCH 01/17] perf report: Ask ordered events for --tasks option

Em Tue, Feb 06, 2018 at 07:17:57PM +0100, Jiri Olsa escreveu: > If we have the time in, keep the events in time order. Try to be more verbose, what actual effect this will have in this particular case? So, I had to try it to see the effects and explain them: --- /tmp/before 2018-02-06

Re: [PATCH 01/17] perf report: Ask ordered events for --tasks option

Em Tue, Feb 06, 2018 at 07:17:57PM +0100, Jiri Olsa escreveu: > If we have the time in, keep the events in time order. Try to be more verbose, what actual effect this will have in this particular case? So, I had to try it to see the effects and explain them: --- /tmp/before 2018-02-06

[PATCH] perf mem: Show perf mem report usage by -h option

When typing 'perf mem report -h', the result showed 'perf report' usage. So change to show 'perf mem report' usage. Cc: Jiri Olsa Cc: Namhyung Kim Cc: Taeung Song Signed-off-by: Sangwon Hong ---

Re: [PATCH] usb: musb: fix enumeration after resume

* Andreas Kemnade [180127 08:34]: > On dm3730 there are enumeration problems after resume. > Investigation led to the cause that the MUSB_POWER_SOFTCONN > bit is not set. If it was set before suspend (because it > was enabled via musb_pullup()), it is set in >

[PATCH] perf mem: Show perf mem report usage by -h option

When typing 'perf mem report -h', the result showed 'perf report' usage. So change to show 'perf mem report' usage. Cc: Jiri Olsa Cc: Namhyung Kim Cc: Taeung Song Signed-off-by: Sangwon Hong --- tools/perf/builtin-mem.c | 21 - 1 file changed, 20 insertions(+), 1

Re: [PATCH] usb: musb: fix enumeration after resume

* Andreas Kemnade [180127 08:34]: > On dm3730 there are enumeration problems after resume. > Investigation led to the cause that the MUSB_POWER_SOFTCONN > bit is not set. If it was set before suspend (because it > was enabled via musb_pullup()), it is set in > musb_restore_context() so the pullup

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

On Tue, Feb 06, 2018 at 11:58:17AM -0500, Sven Van Asbroeck wrote: > On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn wrote: > > And a DSA driver does not need to be complex. You can start simple, > > and add more features later. > > I see. Would it be possible/practical to start

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

On Tue, Feb 06, 2018 at 11:58:17AM -0500, Sven Van Asbroeck wrote: > On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn wrote: > > And a DSA driver does not need to be complex. You can start simple, > > and add more features later. > > I see. Would it be possible/practical to start with just

Re: [PATCH] usb: musb: fix enumeration after resume

Hi, On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > On dm3730 there are enumeration problems after resume. > Investigation led to the cause that the MUSB_POWER_SOFTCONN > bit is not set. If it was set before suspend (because it > was enabled via musb_pullup()), it is set in >

Re: [PATCH] usb: musb: fix enumeration after resume

Hi, On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > On dm3730 there are enumeration problems after resume. > Investigation led to the cause that the MUSB_POWER_SOFTCONN > bit is not set. If it was set before suspend (because it > was enabled via musb_pullup()), it is set in >

Re: [PATCH] ARM: dts: da850-evm: add clock properties to the nand node

2018-02-06 19:25 GMT+01:00 David Lechner : > On 02/06/2018 12:16 PM, David Lechner wrote: >> >> On 02/06/2018 07:51 AM, Sekhar Nori wrote: >>> >>> On Tuesday 06 February 2018 06:38 PM, Bartosz Golaszewski wrote: 2018-02-06 12:07 GMT+01:00 Sekhar Nori

Re: [PATCH] ARM: dts: da850-evm: add clock properties to the nand node

2018-02-06 19:25 GMT+01:00 David Lechner : > On 02/06/2018 12:16 PM, David Lechner wrote: >> >> On 02/06/2018 07:51 AM, Sekhar Nori wrote: >>> >>> On Tuesday 06 February 2018 06:38 PM, Bartosz Golaszewski wrote: 2018-02-06 12:07 GMT+01:00 Sekhar Nori : > > On Monday 05 February

Re: [PATCH] vsprintf: avoid misleading "(null)" for %px

On Tue, Feb 6, 2018 at 12:22 AM, Tobin C. Harding wrote: > The original patch is good IMO and I AFAICT in everyone else's. The original patch misses test cases. Without them is problematic to follow what's going on with printing. -- With Best Regards, Andy Shevchenko

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

From: Kees Cook Date: Wed, 7 Feb 2018 05:36:02 +1100 > Making put_cmsg() inline would help quite a bit with tracking the > builtin_const-ness, and that could speed things up a little bit too. > Would you be opposed to inlining? Nope.

Re: [PATCH] vsprintf: avoid misleading "(null)" for %px

On Tue, Feb 6, 2018 at 12:22 AM, Tobin C. Harding wrote: > The original patch is good IMO and I AFAICT in everyone else's. The original patch misses test cases. Without them is problematic to follow what's going on with printing. -- With Best Regards, Andy Shevchenko

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

From: Kees Cook Date: Wed, 7 Feb 2018 05:36:02 +1100 > Making put_cmsg() inline would help quite a bit with tracking the > builtin_const-ness, and that could speed things up a little bit too. > Would you be opposed to inlining? Nope.

Re: [PATCH 06/64] mm: teach pagefault paths about range locking

On Mon, 05 Feb 2018, Laurent Dufour wrote: --- a/drivers/misc/sgi-gru/grufault.c +++ b/drivers/misc/sgi-gru/grufault.c @@ -189,7 +189,8 @@ static void get_clear_fault_map(struct gru_state *gru, */ static int non_atomic_pte_lookup(struct vm_area_struct *vma,

Re: [PATCH 06/64] mm: teach pagefault paths about range locking

On Mon, 05 Feb 2018, Laurent Dufour wrote: --- a/drivers/misc/sgi-gru/grufault.c +++ b/drivers/misc/sgi-gru/grufault.c @@ -189,7 +189,8 @@ static void get_clear_fault_map(struct gru_state *gru, */ static int non_atomic_pte_lookup(struct vm_area_struct *vma,

Re: [PATCH 2/2] arm64: dts: sdm845: Add serial console support

Hi, On Fri, Jan 26, 2018 at 2:18 PM, Stephen Boyd wrote: > On 01/25, Rajendra Nayak wrote: >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi >> b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi >> new file mode 100644 >> index ..b97f99e6f4b4 >> --- /dev/null

Re: [PATCH 2/2] arm64: dts: sdm845: Add serial console support

Hi, On Fri, Jan 26, 2018 at 2:18 PM, Stephen Boyd wrote: > On 01/25, Rajendra Nayak wrote: >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi >> b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi >> new file mode 100644 >> index ..b97f99e6f4b4 >> --- /dev/null >> +++

Re: [PATCH v3 0/6] cpufreq: schedutil: fixes for flags updates

On 06-Feb 19:14, Claudio Scordino wrote: > Hi Patrick, > >At first glance, your proposal below makes to make sense. > > > >However, I'm wondering if we cannot get it working using > >rq->dl's provided information instead of flags? > > Yes, we can use the value of rq->dl to check if there has

Re: [PATCH v3 0/6] cpufreq: schedutil: fixes for flags updates

On 06-Feb 19:14, Claudio Scordino wrote: > Hi Patrick, > >At first glance, your proposal below makes to make sense. > > > >However, I'm wondering if we cannot get it working using > >rq->dl's provided information instead of flags? > > Yes, we can use the value of rq->dl to check if there has

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

On Wed, Feb 7, 2018 at 3:19 AM, David Miller wrote: > From: Kees Cook > Date: Tue, 6 Feb 2018 04:31:50 +1100 > >> On Tue, Feb 6, 2018 at 2:03 AM, David Miller wrote: >>> From: Kees Cook >>> Date: Fri, 2 Feb

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

On Wed, Feb 7, 2018 at 3:19 AM, David Miller wrote: > From: Kees Cook > Date: Tue, 6 Feb 2018 04:31:50 +1100 > >> On Tue, Feb 6, 2018 at 2:03 AM, David Miller wrote: >>> From: Kees Cook >>> Date: Fri, 2 Feb 2018 02:27:49 -0800 >>> @@ -343,6 +343,14 @@ struct ucred { extern int

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

Hi. 06.02.2018 15:50, Paolo Valente wrote: Could you please do a gdb /block/bfq-iosched.o # or vmlinux.o if bfq is builtin list *(bfq_finish_requeue_request+0x54) list *(bfq_put_queue+0x10b) for me? Fresh crashes and gdb output are given below. A side note: it is harder to trigger things on

Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

Hi. 06.02.2018 15:50, Paolo Valente wrote: Could you please do a gdb /block/bfq-iosched.o # or vmlinux.o if bfq is builtin list *(bfq_finish_requeue_request+0x54) list *(bfq_put_queue+0x10b) for me? Fresh crashes and gdb output are given below. A side note: it is harder to trigger things on

Re: [BUG] x86 : i486 reporting to be vulnerable to Meltdown/Spectre_V1/Spectre_V2

On Sat, Feb 3, 2018 at 2:37 AM, David Woodhouse wrote: > On Fri, 2018-02-02 at 23:52 -0500, tedheadster wrote: >> I just tested the 4.15 kernel and it is reporting that my old i486 >> (non-cpuid capable) cpu is vulnerable to all three issues: Meltdown, >> Spectre V1, and

Re: [BUG] x86 : i486 reporting to be vulnerable to Meltdown/Spectre_V1/Spectre_V2

On Sat, Feb 3, 2018 at 2:37 AM, David Woodhouse wrote: > On Fri, 2018-02-02 at 23:52 -0500, tedheadster wrote: >> I just tested the 4.15 kernel and it is reporting that my old i486 >> (non-cpuid capable) cpu is vulnerable to all three issues: Meltdown, >> Spectre V1, and Spectre V2. >> >> I find

Re: [PATCH v4 1/3] sched/fair: add util_est on top of PELT

On 06-Feb 16:50, Peter Zijlstra wrote: > > Mostly nice, I almost applied, except too many nits below. :) Thanks for the really fast still useful review! > On Tue, Feb 06, 2018 at 02:41:29PM +, Patrick Bellasi wrote: > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index

Re: [PATCH v4 1/3] sched/fair: add util_est on top of PELT

On 06-Feb 16:50, Peter Zijlstra wrote: > > Mostly nice, I almost applied, except too many nits below. :) Thanks for the really fast still useful review! > On Tue, Feb 06, 2018 at 02:41:29PM +, Patrick Bellasi wrote: > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index

[PATCH 01/17] perf report: Ask ordered events for --tasks option

If we have the time in, keep the events in time order. Link: http://lkml.kernel.org/n/tip-3wcrngoibk5l96nqyhp0n...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/builtin-report.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/builtin-report.c

[PATCH 15/17] perf tools: Check if we read regular file in dso__load

Current code in dso__load calls the is_regular_file function, but it checks its return value only after calling symsrc__init. That can make symsrc__init block in elf_* functions on reading the file if the file happens to be device and not regular one. Make the check before calling symsrc__init.

[PATCH 01/17] perf report: Ask ordered events for --tasks option

If we have the time in, keep the events in time order. Link: http://lkml.kernel.org/n/tip-3wcrngoibk5l96nqyhp0n...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/builtin-report.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/builtin-report.c

[PATCH 15/17] perf tools: Check if we read regular file in dso__load

Current code in dso__load calls the is_regular_file function, but it checks its return value only after calling symsrc__init. That can make symsrc__init block in elf_* functions on reading the file if the file happens to be device and not regular one. Make the check before calling symsrc__init.

[PATCH 10/17] perf tools: Generalize machine__set_kernel_mmap function

So it could be called without event object, just with start and end values. It will be used in following patch. Link: http://lkml.kernel.org/n/tip-u4hu7m5fmwwsscy6ki70h...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/machine.c | 13 +++-- 1 file changed,

[PATCH 10/17] perf tools: Generalize machine__set_kernel_mmap function

So it could be called without event object, just with start and end values. It will be used in following patch. Link: http://lkml.kernel.org/n/tip-u4hu7m5fmwwsscy6ki70h...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/machine.c | 13 +++-- 1 file changed, 7 insertions(+),

[PATCH 05/17] tools lib api fs: Add sysfs__read_xll function

Adding sysfs__read_xll function to be able to read sysfs files with hex numbers in, which do not have 0x prefix. Link: http://lkml.kernel.org/n/tip-j5ullvrcli5ga3hn6692t...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/lib/api/fs/fs.c | 15 +--

[PATCH 05/17] tools lib api fs: Add sysfs__read_xll function

Adding sysfs__read_xll function to be able to read sysfs files with hex numbers in, which do not have 0x prefix. Link: http://lkml.kernel.org/n/tip-j5ullvrcli5ga3hn6692t...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/lib/api/fs/fs.c | 15 +-- tools/lib/api/fs/fs.h | 1 + 2

[PATCH 02/17] perf record: Put new line after target override warning

There's no new-line after target-override warning, now: $ perf record -a --per-thread Warning: SYSTEM/CPU switch overriding PER-THREAD^C[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.705 MB perf.data (2939 samples) ] with patch: $ perf record -a

[PATCH 02/17] perf record: Put new line after target override warning

There's no new-line after target-override warning, now: $ perf record -a --per-thread Warning: SYSTEM/CPU switch overriding PER-THREAD^C[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.705 MB perf.data (2939 samples) ] with patch: $ perf record -a

[PATCH 00/17] perf tools: Assorted fixes

hi, sending assorted general fixes that queued up in my other branches. Also available in here: https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/fixes thanks, jirka --- Jiri Olsa (17): perf report: Ask ordered events for --tasks option perf record: Put new

[PATCH 00/17] perf tools: Assorted fixes

hi, sending assorted general fixes that queued up in my other branches. Also available in here: https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/fixes thanks, jirka --- Jiri Olsa (17): perf report: Ask ordered events for --tasks option perf record: Put new

[PATCH 11/17] perf tools: Use machine__set_kernel_mmap instead of map_groups__fixup_end

The machine__set_kernel_mmap does the same job as map_groups__fixup_end when used on kernel maps within machine__create_kernel_maps call. This way we can also remove map_groups__fixup_end function, because there's no user to it. Also moving machine__set_kernel_mmap up in code, so we don't need

[PATCH 04/17] tools lib api fs: Add filename__read_xll function

Adding filename__read_xll function to be able to read files with hex numbers in, which do not have 0x prefix. Link: http://lkml.kernel.org/n/tip-d9qv8n8xlmkywsb9vdrcj...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/lib/api/fs/fs.c | 29 ++---

[PATCH 07/17] perf tools: Free root_dir in machine__init error path

Freeing root_dir in machine__init error path. Link: http://lkml.kernel.org/n/tip-ng92slsanexqw7h1d6sad...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/machine.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/machine.c

[PATCH 11/17] perf tools: Use machine__set_kernel_mmap instead of map_groups__fixup_end

The machine__set_kernel_mmap does the same job as map_groups__fixup_end when used on kernel maps within machine__create_kernel_maps call. This way we can also remove map_groups__fixup_end function, because there's no user to it. Also moving machine__set_kernel_mmap up in code, so we don't need

[PATCH 04/17] tools lib api fs: Add filename__read_xll function

Adding filename__read_xll function to be able to read files with hex numbers in, which do not have 0x prefix. Link: http://lkml.kernel.org/n/tip-d9qv8n8xlmkywsb9vdrcj...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/lib/api/fs/fs.c | 29 ++--- tools/lib/api/fs/fs.h |

[PATCH 07/17] perf tools: Free root_dir in machine__init error path

Freeing root_dir in machine__init error path. Link: http://lkml.kernel.org/n/tip-ng92slsanexqw7h1d6sad...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/machine.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/machine.c

[PATCH 14/17] perf tools: Do not create kernel maps in sample__resolve

There's no need for kernel maps to be allocated at this point - sample processing. We search for kernel maps using the kernel map_groups in machine::kmaps which is static. If vmlinux maps for any reason still don't exist, the search correctly fails because they are not in the map group. Link:

[PATCH 09/17] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

We should not search for kernel start address in __machine__create_kernel_maps function, because it's being used in 'report' code path, where we are interested in kernel MMAP data address instead of in current kernel address The __machine__create_kernel_maps serves purely for creating the

[PATCH 14/17] perf tools: Do not create kernel maps in sample__resolve

There's no need for kernel maps to be allocated at this point - sample processing. We search for kernel maps using the kernel map_groups in machine::kmaps which is static. If vmlinux maps for any reason still don't exist, the search correctly fails because they are not in the map group. Link:

[PATCH 09/17] perf tools: Don't search for active kernel start in __machine__create_kernel_maps

We should not search for kernel start address in __machine__create_kernel_maps function, because it's being used in 'report' code path, where we are interested in kernel MMAP data address instead of in current kernel address The __machine__create_kernel_maps serves purely for creating the

[PATCH 13/17] perf tools: Remove machine__load_kallsyms function

And replacing it with __machine__load_kallsyms function. The current machine__load_kallsyms function has no caller, so replacing it directly with __machine__load_kallsyms. Also removing the no_kcore argument as it was always called with true value. Link:

[PATCH 13/17] perf tools: Remove machine__load_kallsyms function

And replacing it with __machine__load_kallsyms function. The current machine__load_kallsyms function has no caller, so replacing it directly with __machine__load_kallsyms. Also removing the no_kcore argument as it was always called with true value. Link:

[PATCH 17/17] perf tools: Fix comment for sort__* compare functions

In commit 2f15bd8c6c6e ("perf tools: Fix "Command" sort_entry's cmp and collapse function") we switched from pointer to string comparison. But failed to remove related comments. Removing them and adding another one to warn before pointer comparison in here. Link:

[PATCH 17/17] perf tools: Fix comment for sort__* compare functions

In commit 2f15bd8c6c6e ("perf tools: Fix "Command" sort_entry's cmp and collapse function") we switched from pointer to string comparison. But failed to remove related comments. Removing them and adding another one to warn before pointer comparison in here. Link:

[PATCH 12/17] perf tools: Rename __map_groups__fixup_end to map_groups__fixup_end

There's no need to keep the '__' prefix now when there's map_groups__fixup_end function gone. Link: http://lkml.kernel.org/n/tip-xq9wpm97spnpaxfjhaz1a...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/machine.c| 2 +- tools/perf/util/symbol-elf.c | 2 +-

[PATCH 12/17] perf tools: Rename __map_groups__fixup_end to map_groups__fixup_end

There's no need to keep the '__' prefix now when there's map_groups__fixup_end function gone. Link: http://lkml.kernel.org/n/tip-xq9wpm97spnpaxfjhaz1a...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/machine.c| 2 +- tools/perf/util/symbol-elf.c | 2 +-

Re: [PATCH] x86: PM: Make APM idle driver initialize polling state

On Tue, Feb 06, 2018 at 07:02:58PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Update the APM driver overlooked by commit 1b39e3f813b4 (cpuidle: Make > drivers initialize polling state) to initialize the polling state like > the other cpuidle drivers

Re: [PATCH] x86: PM: Make APM idle driver initialize polling state

On Tue, Feb 06, 2018 at 07:02:58PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Update the APM driver overlooked by commit 1b39e3f813b4 (cpuidle: Make > drivers initialize polling state) to initialize the polling state like > the other cpuidle drivers modified by that commit to

Re: [PATCH] ARM: dts: da850-evm: add clock properties to the nand node

On 02/06/2018 12:16 PM, David Lechner wrote: On 02/06/2018 07:51 AM, Sekhar Nori wrote: On Tuesday 06 February 2018 06:38 PM, Bartosz Golaszewski wrote: 2018-02-06 12:07 GMT+01:00 Sekhar Nori : On Monday 05 February 2018 09:22 PM, Bartosz Golaszewski wrote: From: Bartosz

Re: [PATCH] ARM: dts: da850-evm: add clock properties to the nand node

On 02/06/2018 12:16 PM, David Lechner wrote: On 02/06/2018 07:51 AM, Sekhar Nori wrote: On Tuesday 06 February 2018 06:38 PM, Bartosz Golaszewski wrote: 2018-02-06 12:07 GMT+01:00 Sekhar Nori : On Monday 05 February 2018 09:22 PM, Bartosz Golaszewski wrote: From: Bartosz Golaszewski Make

[PATCH 16/17] perf tests: Fix dwarf unwind for stripped binaries

When we strip the perf binary, dwarf unwind test stop to work. The reason is that strip will remove static function symbols, which we need to check for unwind. This change will keep this test working in cases where the global symbols are put into dynamic symbol table, which is the case on x86. It

[PATCH 03/17] perf script: Add --show-round-event to display PERF_RECORD_FINISHED_ROUND

Adding --show-round-event to display PERF_RECORD_FINISHED_ROUND events like: # perf script --show-round-events 2>/dev/null yes 8591 [002] 124177.397597: 18 cpu/mem-stores/P: ff... yes 8591 [002] 124177.397615: 1

[PATCH 16/17] perf tests: Fix dwarf unwind for stripped binaries

When we strip the perf binary, dwarf unwind test stop to work. The reason is that strip will remove static function symbols, which we need to check for unwind. This change will keep this test working in cases where the global symbols are put into dynamic symbol table, which is the case on x86. It

[PATCH 03/17] perf script: Add --show-round-event to display PERF_RECORD_FINISHED_ROUND

Adding --show-round-event to display PERF_RECORD_FINISHED_ROUND events like: # perf script --show-round-events 2>/dev/null yes 8591 [002] 124177.397597: 18 cpu/mem-stores/P: ff... yes 8591 [002] 124177.397615: 1

[PATCH 08/17] perf tools: Move kernel mmap name into struct machine

It simplifies and centralizes the code. The kernel mmap name is set for machine type, which we know from the beginning, so there's no reason to generate it every time we need it. Link: http://lkml.kernel.org/n/tip-2fx7kxxdc5zcm6990cq2m...@git.kernel.org Signed-off-by: Jiri Olsa

[PATCH 08/17] perf tools: Move kernel mmap name into struct machine

It simplifies and centralizes the code. The kernel mmap name is set for machine type, which we know from the beginning, so there's no reason to generate it every time we need it. Link: http://lkml.kernel.org/n/tip-2fx7kxxdc5zcm6990cq2m...@git.kernel.org Signed-off-by: Jiri Olsa ---

<    3   4   5   6   7   8   9   10   11   12   >